{"action":"created","issue":{"url":"https://api.github.com/repos/daltoniam/Starscream/issues/253","repository_url":"https://api.github.com/repos/daltoniam/Starscream","labels_url":"https://api.github.com/repos/daltoniam/Starscream/issues/253/labels{/name}","comments_url":"https://api.github.com/repos/daltoniam/Starscream/issues/253/comments","events_url":"https://api.github.com/repos/daltoniam/Starscream/issues/253/events","html_url":"https://github.com/daltoniam/Starscream/pull/253","id":179061151,"number":253,"title":"Only disable SSL cert validation if we are using a secure scheme.","user":{"login":"noremac","id":2042645,"avatar_url":"https://avatars.githubusercontent.com/u/2042645?v=3","gravatar_id":"","url":"https://api.github.com/users/noremac","html_url":"https://github.com/noremac","followers_url":"https://api.github.com/users/noremac/followers","following_url":"https://api.github.com/users/noremac/following{/other_user}","gists_url":"https://api.github.com/users/noremac/gists{/gist_id}","starred_url":"https://api.github.com/users/noremac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noremac/subscriptions","organizations_url":"https://api.github.com/users/noremac/orgs","repos_url":"https://api.github.com/users/noremac/repos","events_url":"https://api.github.com/users/noremac/events{/privacy}","received_events_url":"https://api.github.com/users/noremac/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-25T01:02:54Z","updated_at":"2016-09-30T18:49:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/daltoniam/Starscream/pulls/253","html_url":"https://github.com/daltoniam/Starscream/pull/253","diff_url":"https://github.com/daltoniam/Starscream/pull/253.diff","patch_url":"https://github.com/daltoniam/Starscream/pull/253.patch"},"body":"Enabling `disableSSLCertValidation` against a non-secure scheme (`\"ws\"`) can cause some slightly hard to track down connection failures. This PR fixes that issue by only checking and handling `disableSSLCertValidation` in an area where we know we are using a secured scheme (`\"wss\"` or `\"https\"`).\r\n\r\nAdditionally, we may want to log this mismatch with a simple print statement as well?\r\n\r\nI could see this as an area where no user-error is tolerated (figure out if you are secure or not _darn it!_ 😄) so, some might see this PR as slightly dangerous. I think it's useful though.\r\n\r\n(We may want to add the `if let cipherSuites...` line up into this same area as well?\r\n\r\nLet me know what you think!"},"comment":{"url":"https://api.github.com/repos/daltoniam/Starscream/issues/comments/250823323","html_url":"https://github.com/daltoniam/Starscream/pull/253#issuecomment-250823323","issue_url":"https://api.github.com/repos/daltoniam/Starscream/issues/253","id":250823323,"user":{"login":"noremac","id":2042645,"avatar_url":"https://avatars.githubusercontent.com/u/2042645?v=3","gravatar_id":"","url":"https://api.github.com/users/noremac","html_url":"https://github.com/noremac","followers_url":"https://api.github.com/users/noremac/followers","following_url":"https://api.github.com/users/noremac/following{/other_user}","gists_url":"https://api.github.com/users/noremac/gists{/gist_id}","starred_url":"https://api.github.com/users/noremac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noremac/subscriptions","organizations_url":"https://api.github.com/users/noremac/orgs","repos_url":"https://api.github.com/users/noremac/repos","events_url":"https://api.github.com/users/noremac/events{/privacy}","received_events_url":"https://api.github.com/users/noremac/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T18:49:43Z","updated_at":"2016-09-30T18:49:43Z","body":"All set! Let me know if there's anything else."}}
{"actor":{"display_login":"noremac"}}