{"action":"created","comment":{"url":"https://api.github.com/repos/trufont/trufont/pulls/comments/51465077","id":51465077,"diff_hunk":"@@ -29,6 +29,7 @@ def __init__(self, font=None, parent=None):\n         self.editor.modificationChanged.connect(self.setWindowModified)\n \n     def setWindowTitle(self, title=\"Font Features\", font=None):\n+        title = self.tr(\"Font Features\")","path":"Lib/defconQt/featureTextEditor.py","position":null,"original_position":27,"commit_id":"8517e4768bfdd563aaccc3b7de9f4f3f4d454a3b","original_commit_id":"5a1b6c52d54fa59a197d06e93e3bdaad4485f8b8","user":{"login":"khaledhosny","id":93914,"avatar_url":"https://avatars.githubusercontent.com/u/93914?v=3","gravatar_id":"","url":"https://api.github.com/users/khaledhosny","html_url":"https://github.com/khaledhosny","followers_url":"https://api.github.com/users/khaledhosny/followers","following_url":"https://api.github.com/users/khaledhosny/following{/other_user}","gists_url":"https://api.github.com/users/khaledhosny/gists{/gist_id}","starred_url":"https://api.github.com/users/khaledhosny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaledhosny/subscriptions","organizations_url":"https://api.github.com/users/khaledhosny/orgs","repos_url":"https://api.github.com/users/khaledhosny/repos","events_url":"https://api.github.com/users/khaledhosny/events{/privacy}","received_events_url":"https://api.github.com/users/khaledhosny/received_events","type":"User","site_admin":false},"body":"This should be a single string, not split into translatable and non-translatable parts.","created_at":"2016-02-01T19:13:25Z","updated_at":"2016-02-01T19:13:25Z","html_url":"https://github.com/trufont/trufont/pull/224#discussion_r51465077","pull_request_url":"https://api.github.com/repos/trufont/trufont/pulls/224","_links":{"self":{"href":"https://api.github.com/repos/trufont/trufont/pulls/comments/51465077"},"html":{"href":"https://github.com/trufont/trufont/pull/224#discussion_r51465077"},"pull_request":{"href":"https://api.github.com/repos/trufont/trufont/pulls/224"}}},"pull_request":{"url":"https://api.github.com/repos/trufont/trufont/pulls/224","id":57854395,"html_url":"https://github.com/trufont/trufont/pull/224","diff_url":"https://github.com/trufont/trufont/pull/224.diff","patch_url":"https://github.com/trufont/trufont/pull/224.patch","issue_url":"https://api.github.com/repos/trufont/trufont/issues/224","number":224,"state":"open","locked":false,"title":"Translation support","user":{"login":"madig","id":380829,"avatar_url":"https://avatars.githubusercontent.com/u/380829?v=3","gravatar_id":"","url":"https://api.github.com/users/madig","html_url":"https://github.com/madig","followers_url":"https://api.github.com/users/madig/followers","following_url":"https://api.github.com/users/madig/following{/other_user}","gists_url":"https://api.github.com/users/madig/gists{/gist_id}","starred_url":"https://api.github.com/users/madig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madig/subscriptions","organizations_url":"https://api.github.com/users/madig/orgs","repos_url":"https://api.github.com/users/madig/repos","events_url":"https://api.github.com/users/madig/events{/privacy}","received_events_url":"https://api.github.com/users/madig/received_events","type":"User","site_admin":false},"body":"I'd like to get this in, but maybe without my example translation. As long as the HIG/UI has not stabilized, it is only useful for testing.\r\n\r\nKnown problems:\r\n- Translations don't load when starting via `trufont` -- package into resource file?\r\n- `pylupdate5` gets confused when strings contain non-ASCII characters. Either avoid or escape them (quotation marks!) or attach them afterwards (ellipsis).\r\n\r\nNotes:\r\n- When sizing elements like buttons and columns, don't set a fixed width based on the length of English words. I'd fix fontView.py's glyphListButton if I knew why sizeHint() makes it so wide.","created_at":"2016-02-01T15:29:16Z","updated_at":"2016-02-01T19:13:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b1b2dc5b91c138d938ff7c07867c730184660c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/trufont/trufont/pulls/224/commits","review_comments_url":"https://api.github.com/repos/trufont/trufont/pulls/224/comments","review_comment_url":"https://api.github.com/repos/trufont/trufont/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trufont/trufont/issues/224/comments","statuses_url":"https://api.github.com/repos/trufont/trufont/statuses/8517e4768bfdd563aaccc3b7de9f4f3f4d454a3b","head":{"label":"madig:translation-support","ref":"translation-support","sha":"8517e4768bfdd563aaccc3b7de9f4f3f4d454a3b","user":{"login":"madig","id":380829,"avatar_url":"https://avatars.githubusercontent.com/u/380829?v=3","gravatar_id":"","url":"https://api.github.com/users/madig","html_url":"https://github.com/madig","followers_url":"https://api.github.com/users/madig/followers","following_url":"https://api.github.com/users/madig/following{/other_user}","gists_url":"https://api.github.com/users/madig/gists{/gist_id}","starred_url":"https://api.github.com/users/madig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madig/subscriptions","organizations_url":"https://api.github.com/users/madig/orgs","repos_url":"https://api.github.com/users/madig/repos","events_url":"https://api.github.com/users/madig/events{/privacy}","received_events_url":"https://api.github.com/users/madig/received_events","type":"User","site_admin":false},"repo":{"id":50694350,"name":"trufont","full_name":"madig/trufont","owner":{"login":"madig","id":380829,"avatar_url":"https://avatars.githubusercontent.com/u/380829?v=3","gravatar_id":"","url":"https://api.github.com/users/madig","html_url":"https://github.com/madig","followers_url":"https://api.github.com/users/madig/followers","following_url":"https://api.github.com/users/madig/following{/other_user}","gists_url":"https://api.github.com/users/madig/gists{/gist_id}","starred_url":"https://api.github.com/users/madig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madig/subscriptions","organizations_url":"https://api.github.com/users/madig/orgs","repos_url":"https://api.github.com/users/madig/repos","events_url":"https://api.github.com/users/madig/events{/privacy}","received_events_url":"https://api.github.com/users/madig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madig/trufont","description":"A ufo3 font editor. À l’ancienne.","fork":true,"url":"https://api.github.com/repos/madig/trufont","forks_url":"https://api.github.com/repos/madig/trufont/forks","keys_url":"https://api.github.com/repos/madig/trufont/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madig/trufont/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madig/trufont/teams","hooks_url":"https://api.github.com/repos/madig/trufont/hooks","issue_events_url":"https://api.github.com/repos/madig/trufont/issues/events{/number}","events_url":"https://api.github.com/repos/madig/trufont/events","assignees_url":"https://api.github.com/repos/madig/trufont/assignees{/user}","branches_url":"https://api.github.com/repos/madig/trufont/branches{/branch}","tags_url":"https://api.github.com/repos/madig/trufont/tags","blobs_url":"https://api.github.com/repos/madig/trufont/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madig/trufont/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madig/trufont/git/refs{/sha}","trees_url":"https://api.github.com/repos/madig/trufont/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madig/trufont/statuses/{sha}","languages_url":"https://api.github.com/repos/madig/trufont/languages","stargazers_url":"https://api.github.com/repos/madig/trufont/stargazers","contributors_url":"https://api.github.com/repos/madig/trufont/contributors","subscribers_url":"https://api.github.com/repos/madig/trufont/subscribers","subscription_url":"https://api.github.com/repos/madig/trufont/subscription","commits_url":"https://api.github.com/repos/madig/trufont/commits{/sha}","git_commits_url":"https://api.github.com/repos/madig/trufont/git/commits{/sha}","comments_url":"https://api.github.com/repos/madig/trufont/comments{/number}","issue_comment_url":"https://api.github.com/repos/madig/trufont/issues/comments{/number}","contents_url":"https://api.github.com/repos/madig/trufont/contents/{+path}","compare_url":"https://api.github.com/repos/madig/trufont/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madig/trufont/merges","archive_url":"https://api.github.com/repos/madig/trufont/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madig/trufont/downloads","issues_url":"https://api.github.com/repos/madig/trufont/issues{/number}","pulls_url":"https://api.github.com/repos/madig/trufont/pulls{/number}","milestones_url":"https://api.github.com/repos/madig/trufont/milestones{/number}","notifications_url":"https://api.github.com/repos/madig/trufont/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madig/trufont/labels{/name}","releases_url":"https://api.github.com/repos/madig/trufont/releases{/id}","deployments_url":"https://api.github.com/repos/madig/trufont/deployments","created_at":"2016-01-29T22:01:13Z","updated_at":"2016-01-29T22:01:14Z","pushed_at":"2016-02-01T19:12:58Z","git_url":"git://github.com/madig/trufont.git","ssh_url":"git@github.com:madig/trufont.git","clone_url":"https://github.com/madig/trufont.git","svn_url":"https://github.com/madig/trufont","homepage":"http://trufont.github.io/","size":1309,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trufont:master","ref":"master","sha":"5de7e0e9a8438fbe3b59fbe61fdbad889d0cc692","user":{"login":"trufont","id":15032310,"avatar_url":"https://avatars.githubusercontent.com/u/15032310?v=3","gravatar_id":"","url":"https://api.github.com/users/trufont","html_url":"https://github.com/trufont","followers_url":"https://api.github.com/users/trufont/followers","following_url":"https://api.github.com/users/trufont/following{/other_user}","gists_url":"https://api.github.com/users/trufont/gists{/gist_id}","starred_url":"https://api.github.com/users/trufont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufont/subscriptions","organizations_url":"https://api.github.com/users/trufont/orgs","repos_url":"https://api.github.com/users/trufont/repos","events_url":"https://api.github.com/users/trufont/events{/privacy}","received_events_url":"https://api.github.com/users/trufont/received_events","type":"Organization","site_admin":false},"repo":{"id":44068507,"name":"trufont","full_name":"trufont/trufont","owner":{"login":"trufont","id":15032310,"avatar_url":"https://avatars.githubusercontent.com/u/15032310?v=3","gravatar_id":"","url":"https://api.github.com/users/trufont","html_url":"https://github.com/trufont","followers_url":"https://api.github.com/users/trufont/followers","following_url":"https://api.github.com/users/trufont/following{/other_user}","gists_url":"https://api.github.com/users/trufont/gists{/gist_id}","starred_url":"https://api.github.com/users/trufont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufont/subscriptions","organizations_url":"https://api.github.com/users/trufont/orgs","repos_url":"https://api.github.com/users/trufont/repos","events_url":"https://api.github.com/users/trufont/events{/privacy}","received_events_url":"https://api.github.com/users/trufont/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trufont/trufont","description":"A ufo3 font editor. À l’ancienne.","fork":false,"url":"https://api.github.com/repos/trufont/trufont","forks_url":"https://api.github.com/repos/trufont/trufont/forks","keys_url":"https://api.github.com/repos/trufont/trufont/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trufont/trufont/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trufont/trufont/teams","hooks_url":"https://api.github.com/repos/trufont/trufont/hooks","issue_events_url":"https://api.github.com/repos/trufont/trufont/issues/events{/number}","events_url":"https://api.github.com/repos/trufont/trufont/events","assignees_url":"https://api.github.com/repos/trufont/trufont/assignees{/user}","branches_url":"https://api.github.com/repos/trufont/trufont/branches{/branch}","tags_url":"https://api.github.com/repos/trufont/trufont/tags","blobs_url":"https://api.github.com/repos/trufont/trufont/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trufont/trufont/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trufont/trufont/git/refs{/sha}","trees_url":"https://api.github.com/repos/trufont/trufont/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trufont/trufont/statuses/{sha}","languages_url":"https://api.github.com/repos/trufont/trufont/languages","stargazers_url":"https://api.github.com/repos/trufont/trufont/stargazers","contributors_url":"https://api.github.com/repos/trufont/trufont/contributors","subscribers_url":"https://api.github.com/repos/trufont/trufont/subscribers","subscription_url":"https://api.github.com/repos/trufont/trufont/subscription","commits_url":"https://api.github.com/repos/trufont/trufont/commits{/sha}","git_commits_url":"https://api.github.com/repos/trufont/trufont/git/commits{/sha}","comments_url":"https://api.github.com/repos/trufont/trufont/comments{/number}","issue_comment_url":"https://api.github.com/repos/trufont/trufont/issues/comments{/number}","contents_url":"https://api.github.com/repos/trufont/trufont/contents/{+path}","compare_url":"https://api.github.com/repos/trufont/trufont/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trufont/trufont/merges","archive_url":"https://api.github.com/repos/trufont/trufont/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trufont/trufont/downloads","issues_url":"https://api.github.com/repos/trufont/trufont/issues{/number}","pulls_url":"https://api.github.com/repos/trufont/trufont/pulls{/number}","milestones_url":"https://api.github.com/repos/trufont/trufont/milestones{/number}","notifications_url":"https://api.github.com/repos/trufont/trufont/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trufont/trufont/labels{/name}","releases_url":"https://api.github.com/repos/trufont/trufont/releases{/id}","deployments_url":"https://api.github.com/repos/trufont/trufont/deployments","created_at":"2015-10-11T20:32:11Z","updated_at":"2016-02-01T16:14:30Z","pushed_at":"2016-02-01T19:13:00Z","git_url":"git://github.com/trufont/trufont.git","ssh_url":"git@github.com:trufont/trufont.git","clone_url":"https://github.com/trufont/trufont.git","svn_url":"https://github.com/trufont/trufont","homepage":"http://trufont.github.io/","size":1228,"stargazers_count":69,"watchers_count":69,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":67,"forks":18,"open_issues":67,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trufont/trufont/pulls/224"},"html":{"href":"https://github.com/trufont/trufont/pull/224"},"issue":{"href":"https://api.github.com/repos/trufont/trufont/issues/224"},"comments":{"href":"https://api.github.com/repos/trufont/trufont/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/trufont/trufont/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/trufont/trufont/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trufont/trufont/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/trufont/trufont/statuses/8517e4768bfdd563aaccc3b7de9f4f3f4d454a3b"}}}}