{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/27509","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/27509/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/27509/comments","events_url":"https://api.github.com/repos/docker/docker/issues/27509/events","html_url":"https://github.com/docker/docker/pull/27509","id":183793988,"number":27509,"title":"Add session identifier header","user":{"login":"DavidObando","id":950290,"avatar_url":"https://avatars.githubusercontent.com/u/950290?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidObando","html_url":"https://github.com/DavidObando","followers_url":"https://api.github.com/users/DavidObando/followers","following_url":"https://api.github.com/users/DavidObando/following{/other_user}","gists_url":"https://api.github.com/users/DavidObando/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidObando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidObando/subscriptions","organizations_url":"https://api.github.com/users/DavidObando/orgs","repos_url":"https://api.github.com/users/DavidObando/repos","events_url":"https://api.github.com/users/DavidObando/events{/privacy}","received_events_url":"https://api.github.com/users/DavidObando/received_events","type":"User","site_admin":false},"labels":[{"id":73635104,"url":"https://api.github.com/repos/docker/docker/labels/area/distribution","name":"area/distribution","color":"fbca04","default":false},{"id":175375318,"url":"https://api.github.com/repos/docker/docker/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-18T20:27:30Z","updated_at":"2016-11-14T22:23:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/27509","html_url":"https://github.com/docker/docker/pull/27509","diff_url":"https://github.com/docker/docker/pull/27509.diff","patch_url":"https://github.com/docker/docker/pull/27509.patch"},"body":"**\\- What I did**\nThis is an attempt at tackling #27507.\n\nI added an additional header to the list of headers added by `registry.DockerHeaders()`. It only contains a UUID value that's supposed to help correlate events in the registry's logs. This is part 1 of a 2 part change, the next one being having the registry add this session id to the request logs.\n\n**\\- How I did it**\n- Generate a new global UUID value in `registry.go`\n- Send it as part of the docker headers used to talk to both v1 and v2 endpoints.\n\n**\\- How to verify it**\n- Have a registry service that logs the value of this header, as described in #27507.\n\n**\\- Description for the changelog**\nAdded a session ID header to be sent to the registry for telemetry purposes.\n\n**\\- A picture of a cute animal (not mandatory but encouraged)**\n![zaida](https://cloud.githubusercontent.com/assets/950290/19495038/8f55b368-9536-11e6-9a1c-74e6470302db.jpg)\n\nSigned-off-by: David Obando daobando@microsoft.com\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/260482812","html_url":"https://github.com/docker/docker/pull/27509#issuecomment-260482812","issue_url":"https://api.github.com/repos/docker/docker/issues/27509","id":260482812,"user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T22:23:13Z","updated_at":"2016-11-14T22:23:13Z","body":"> The session id should exist at the daemon-level because I care to correlate across multiple operations. What pushes and pulls came from a specific engine would allow me to get a more clear picture of what's happening in a specific machine if I were to investigate issues.\r\n\r\n@DavidObando This lifecycle doesn't necessarily make a whole lot of sense for a \"session id\". Operations coming from an engine instance may not actually be correlated. I would tend to think this would happen at cli invocation boundaries.\r\n\r\nAs for the user example I placed, this is just defining arbitrary key values to be associated with the session data. This doesn't need to be `user`, as I have in the example, but marking the session with something is helpful."}}
{"actor":{"display_login":"stevvooe"}}