{"action":"created","comment":{"url":"https://api.github.com/repos/dobtco/dvl-core/pulls/comments/65916726","id":65916726,"diff_hunk":"@@ -44,15 +45,22 @@\n }\n \n .sidebar_data_icon {\n-  float: left;\n-  width: 1rem;\n+  position: absolute;\n+  top: 50%;\n+  left: 0;\n+  margin-top: $rhythm * -3;\n+  width: $rhythm * 5;\n   text-align: center;\n   i {\n     line-height: 1;\n-    color: $darkerGray;\n+    color: $gray;\n   }\n   @media screen and (min-width: $lapWidth) {\n     width: $rhythm * 5;\n+    left: $rhythm * 2;\n+    .sidebar_data li:last-of-type & {\n+      margin-top: $rhythm * -1.5;","path":"vendor/assets/stylesheets/dvl/components/sidebar_data.scss","position":29,"original_position":29,"commit_id":"10c20a508723b23cbc4b099a61e5bf5f52cf9bbb","original_commit_id":"5035e1a88dd31b871b396546c24b8f7b73a0e689","user":{"login":"ajb","id":1270317,"avatar_url":"https://avatars.githubusercontent.com/u/1270317?v=3","gravatar_id":"","url":"https://api.github.com/users/ajb","html_url":"https://github.com/ajb","followers_url":"https://api.github.com/users/ajb/followers","following_url":"https://api.github.com/users/ajb/following{/other_user}","gists_url":"https://api.github.com/users/ajb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajb/subscriptions","organizations_url":"https://api.github.com/users/ajb/orgs","repos_url":"https://api.github.com/users/ajb/repos","events_url":"https://api.github.com/users/ajb/events{/privacy}","received_events_url":"https://api.github.com/users/ajb/received_events","type":"User","site_admin":false},"body":"@jrubenoff: would appreciate if you can explain","created_at":"2016-06-06T15:55:30Z","updated_at":"2016-06-06T15:55:30Z","html_url":"https://github.com/dobtco/dvl-core/pull/250#discussion_r65916726","pull_request_url":"https://api.github.com/repos/dobtco/dvl-core/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/comments/65916726"},"html":{"href":"https://github.com/dobtco/dvl-core/pull/250#discussion_r65916726"},"pull_request":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/dobtco/dvl-core/pulls/250","id":65001188,"html_url":"https://github.com/dobtco/dvl-core/pull/250","diff_url":"https://github.com/dobtco/dvl-core/pull/250.diff","patch_url":"https://github.com/dobtco/dvl-core/pull/250.patch","issue_url":"https://api.github.com/repos/dobtco/dvl-core/issues/250","number":250,"state":"open","locked":false,"title":"Consistent line height, other style fixes, better style guide","user":{"login":"jrubenoff","id":1328849,"avatar_url":"https://avatars.githubusercontent.com/u/1328849?v=3","gravatar_id":"","url":"https://api.github.com/users/jrubenoff","html_url":"https://github.com/jrubenoff","followers_url":"https://api.github.com/users/jrubenoff/followers","following_url":"https://api.github.com/users/jrubenoff/following{/other_user}","gists_url":"https://api.github.com/users/jrubenoff/gists{/gist_id}","starred_url":"https://api.github.com/users/jrubenoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrubenoff/subscriptions","organizations_url":"https://api.github.com/users/jrubenoff/orgs","repos_url":"https://api.github.com/users/jrubenoff/repos","events_url":"https://api.github.com/users/jrubenoff/events{/privacy}","received_events_url":"https://api.github.com/users/jrubenoff/received_events","type":"User","site_admin":false},"body":"Closes #249, #241, #223, #204, and dobtco/screendoor-v2#3302\r\n\r\n- Uses a global unitless `line-height`, and makes appropriate alignment adjustments\r\n\r\n----\r\n\r\nAlso:\r\n\r\n- `<dt>` is now bold for added clarity:\r\n\r\n![screen shot 2016-04-01 at 1 30 24 pm](https://cloud.githubusercontent.com/assets/1328849/14219211/eaddcdea-f80d-11e5-89a8-74fb79a8d06a.png)\r\n\r\n- Improved \"dos and don'ts\" pattern, and nicer-looking screenshots, in the style guide:\r\n\r\n![screen shot 2016-04-01 at 1 31 03 pm](https://cloud.githubusercontent.com/assets/1328849/14219220/00da92a4-f80e-11e5-9bc5-bd319a1e315b.png)\r\n\r\n- Tighter spacing for formatted lists:\r\n\r\n![screen shot 2016-04-01 at 1 32 16 pm](https://cloud.githubusercontent.com/assets/1328849/14219255/2a9abab0-f80e-11e5-9213-02838d718d9c.png)\r\n\r\n- New documentation for text contrast, small caps, links to external sites in dropdowns\r\n","created_at":"2016-04-01T20:32:43Z","updated_at":"2016-06-06T15:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9743cea1aa54f13e572871050fcb0641b5bc093","assignee":{"login":"ajb","id":1270317,"avatar_url":"https://avatars.githubusercontent.com/u/1270317?v=3","gravatar_id":"","url":"https://api.github.com/users/ajb","html_url":"https://github.com/ajb","followers_url":"https://api.github.com/users/ajb/followers","following_url":"https://api.github.com/users/ajb/following{/other_user}","gists_url":"https://api.github.com/users/ajb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajb/subscriptions","organizations_url":"https://api.github.com/users/ajb/orgs","repos_url":"https://api.github.com/users/ajb/repos","events_url":"https://api.github.com/users/ajb/events{/privacy}","received_events_url":"https://api.github.com/users/ajb/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dobtco/dvl-core/pulls/250/commits","review_comments_url":"https://api.github.com/repos/dobtco/dvl-core/pulls/250/comments","review_comment_url":"https://api.github.com/repos/dobtco/dvl-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dobtco/dvl-core/issues/250/comments","statuses_url":"https://api.github.com/repos/dobtco/dvl-core/statuses/10c20a508723b23cbc4b099a61e5bf5f52cf9bbb","head":{"label":"dobtco:updates","ref":"updates","sha":"10c20a508723b23cbc4b099a61e5bf5f52cf9bbb","user":{"login":"dobtco","id":3903909,"avatar_url":"https://avatars.githubusercontent.com/u/3903909?v=3","gravatar_id":"","url":"https://api.github.com/users/dobtco","html_url":"https://github.com/dobtco","followers_url":"https://api.github.com/users/dobtco/followers","following_url":"https://api.github.com/users/dobtco/following{/other_user}","gists_url":"https://api.github.com/users/dobtco/gists{/gist_id}","starred_url":"https://api.github.com/users/dobtco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dobtco/subscriptions","organizations_url":"https://api.github.com/users/dobtco/orgs","repos_url":"https://api.github.com/users/dobtco/repos","events_url":"https://api.github.com/users/dobtco/events{/privacy}","received_events_url":"https://api.github.com/users/dobtco/received_events","type":"Organization","site_admin":false},"repo":{"id":26410803,"name":"dvl-core","full_name":"dobtco/dvl-core","owner":{"login":"dobtco","id":3903909,"avatar_url":"https://avatars.githubusercontent.com/u/3903909?v=3","gravatar_id":"","url":"https://api.github.com/users/dobtco","html_url":"https://github.com/dobtco","followers_url":"https://api.github.com/users/dobtco/followers","following_url":"https://api.github.com/users/dobtco/following{/other_user}","gists_url":"https://api.github.com/users/dobtco/gists{/gist_id}","starred_url":"https://api.github.com/users/dobtco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dobtco/subscriptions","organizations_url":"https://api.github.com/users/dobtco/orgs","repos_url":"https://api.github.com/users/dobtco/repos","events_url":"https://api.github.com/users/dobtco/events{/privacy}","received_events_url":"https://api.github.com/users/dobtco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dobtco/dvl-core","description":"Base styles for the DOBT View Layer.","fork":false,"url":"https://api.github.com/repos/dobtco/dvl-core","forks_url":"https://api.github.com/repos/dobtco/dvl-core/forks","keys_url":"https://api.github.com/repos/dobtco/dvl-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dobtco/dvl-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dobtco/dvl-core/teams","hooks_url":"https://api.github.com/repos/dobtco/dvl-core/hooks","issue_events_url":"https://api.github.com/repos/dobtco/dvl-core/issues/events{/number}","events_url":"https://api.github.com/repos/dobtco/dvl-core/events","assignees_url":"https://api.github.com/repos/dobtco/dvl-core/assignees{/user}","branches_url":"https://api.github.com/repos/dobtco/dvl-core/branches{/branch}","tags_url":"https://api.github.com/repos/dobtco/dvl-core/tags","blobs_url":"https://api.github.com/repos/dobtco/dvl-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dobtco/dvl-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dobtco/dvl-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dobtco/dvl-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dobtco/dvl-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dobtco/dvl-core/languages","stargazers_url":"https://api.github.com/repos/dobtco/dvl-core/stargazers","contributors_url":"https://api.github.com/repos/dobtco/dvl-core/contributors","subscribers_url":"https://api.github.com/repos/dobtco/dvl-core/subscribers","subscription_url":"https://api.github.com/repos/dobtco/dvl-core/subscription","commits_url":"https://api.github.com/repos/dobtco/dvl-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dobtco/dvl-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dobtco/dvl-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dobtco/dvl-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dobtco/dvl-core/contents/{+path}","compare_url":"https://api.github.com/repos/dobtco/dvl-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dobtco/dvl-core/merges","archive_url":"https://api.github.com/repos/dobtco/dvl-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dobtco/dvl-core/downloads","issues_url":"https://api.github.com/repos/dobtco/dvl-core/issues{/number}","pulls_url":"https://api.github.com/repos/dobtco/dvl-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dobtco/dvl-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dobtco/dvl-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dobtco/dvl-core/labels{/name}","releases_url":"https://api.github.com/repos/dobtco/dvl-core/releases{/id}","deployments_url":"https://api.github.com/repos/dobtco/dvl-core/deployments","created_at":"2014-11-09T22:00:57Z","updated_at":"2016-01-12T15:44:21Z","pushed_at":"2016-06-06T15:53:15Z","git_url":"git://github.com/dobtco/dvl-core.git","ssh_url":"git@github.com:dobtco/dvl-core.git","clone_url":"https://github.com/dobtco/dvl-core.git","svn_url":"https://github.com/dobtco/dvl-core","homepage":"http://styleguide.dobt.co/","size":1119,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":2,"default_branch":"master"}},"base":{"label":"dobtco:master","ref":"master","sha":"242566744ec119d394f38d932f3baffd941b2eca","user":{"login":"dobtco","id":3903909,"avatar_url":"https://avatars.githubusercontent.com/u/3903909?v=3","gravatar_id":"","url":"https://api.github.com/users/dobtco","html_url":"https://github.com/dobtco","followers_url":"https://api.github.com/users/dobtco/followers","following_url":"https://api.github.com/users/dobtco/following{/other_user}","gists_url":"https://api.github.com/users/dobtco/gists{/gist_id}","starred_url":"https://api.github.com/users/dobtco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dobtco/subscriptions","organizations_url":"https://api.github.com/users/dobtco/orgs","repos_url":"https://api.github.com/users/dobtco/repos","events_url":"https://api.github.com/users/dobtco/events{/privacy}","received_events_url":"https://api.github.com/users/dobtco/received_events","type":"Organization","site_admin":false},"repo":{"id":26410803,"name":"dvl-core","full_name":"dobtco/dvl-core","owner":{"login":"dobtco","id":3903909,"avatar_url":"https://avatars.githubusercontent.com/u/3903909?v=3","gravatar_id":"","url":"https://api.github.com/users/dobtco","html_url":"https://github.com/dobtco","followers_url":"https://api.github.com/users/dobtco/followers","following_url":"https://api.github.com/users/dobtco/following{/other_user}","gists_url":"https://api.github.com/users/dobtco/gists{/gist_id}","starred_url":"https://api.github.com/users/dobtco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dobtco/subscriptions","organizations_url":"https://api.github.com/users/dobtco/orgs","repos_url":"https://api.github.com/users/dobtco/repos","events_url":"https://api.github.com/users/dobtco/events{/privacy}","received_events_url":"https://api.github.com/users/dobtco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dobtco/dvl-core","description":"Base styles for the DOBT View Layer.","fork":false,"url":"https://api.github.com/repos/dobtco/dvl-core","forks_url":"https://api.github.com/repos/dobtco/dvl-core/forks","keys_url":"https://api.github.com/repos/dobtco/dvl-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dobtco/dvl-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dobtco/dvl-core/teams","hooks_url":"https://api.github.com/repos/dobtco/dvl-core/hooks","issue_events_url":"https://api.github.com/repos/dobtco/dvl-core/issues/events{/number}","events_url":"https://api.github.com/repos/dobtco/dvl-core/events","assignees_url":"https://api.github.com/repos/dobtco/dvl-core/assignees{/user}","branches_url":"https://api.github.com/repos/dobtco/dvl-core/branches{/branch}","tags_url":"https://api.github.com/repos/dobtco/dvl-core/tags","blobs_url":"https://api.github.com/repos/dobtco/dvl-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dobtco/dvl-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dobtco/dvl-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dobtco/dvl-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dobtco/dvl-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dobtco/dvl-core/languages","stargazers_url":"https://api.github.com/repos/dobtco/dvl-core/stargazers","contributors_url":"https://api.github.com/repos/dobtco/dvl-core/contributors","subscribers_url":"https://api.github.com/repos/dobtco/dvl-core/subscribers","subscription_url":"https://api.github.com/repos/dobtco/dvl-core/subscription","commits_url":"https://api.github.com/repos/dobtco/dvl-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dobtco/dvl-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dobtco/dvl-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dobtco/dvl-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dobtco/dvl-core/contents/{+path}","compare_url":"https://api.github.com/repos/dobtco/dvl-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dobtco/dvl-core/merges","archive_url":"https://api.github.com/repos/dobtco/dvl-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dobtco/dvl-core/downloads","issues_url":"https://api.github.com/repos/dobtco/dvl-core/issues{/number}","pulls_url":"https://api.github.com/repos/dobtco/dvl-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dobtco/dvl-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dobtco/dvl-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dobtco/dvl-core/labels{/name}","releases_url":"https://api.github.com/repos/dobtco/dvl-core/releases{/id}","deployments_url":"https://api.github.com/repos/dobtco/dvl-core/deployments","created_at":"2014-11-09T22:00:57Z","updated_at":"2016-01-12T15:44:21Z","pushed_at":"2016-06-06T15:53:15Z","git_url":"git://github.com/dobtco/dvl-core.git","ssh_url":"git@github.com:dobtco/dvl-core.git","clone_url":"https://github.com/dobtco/dvl-core.git","svn_url":"https://github.com/dobtco/dvl-core","homepage":"http://styleguide.dobt.co/","size":1119,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/250"},"html":{"href":"https://github.com/dobtco/dvl-core/pull/250"},"issue":{"href":"https://api.github.com/repos/dobtco/dvl-core/issues/250"},"comments":{"href":"https://api.github.com/repos/dobtco/dvl-core/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dobtco/dvl-core/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/dobtco/dvl-core/statuses/10c20a508723b23cbc4b099a61e5bf5f52cf9bbb"}}}}
{"actor":{"display_login":"ajb"}}