{"action":"created","issue":{"url":"https://api.github.com/repos/spencerlyon2/PlotlyJS.jl/issues/67","repository_url":"https://api.github.com/repos/spencerlyon2/PlotlyJS.jl","labels_url":"https://api.github.com/repos/spencerlyon2/PlotlyJS.jl/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/spencerlyon2/PlotlyJS.jl/issues/67/comments","events_url":"https://api.github.com/repos/spencerlyon2/PlotlyJS.jl/issues/67/events","html_url":"https://github.com/spencerlyon2/PlotlyJS.jl/pull/67","id":174796675,"number":67,"title":"Juno Plot Pane Support","user":{"login":"MikeInnes","id":2234614,"avatar_url":"https://avatars.githubusercontent.com/u/2234614?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeInnes","html_url":"https://github.com/MikeInnes","followers_url":"https://api.github.com/users/MikeInnes/followers","following_url":"https://api.github.com/users/MikeInnes/following{/other_user}","gists_url":"https://api.github.com/users/MikeInnes/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeInnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeInnes/subscriptions","organizations_url":"https://api.github.com/users/MikeInnes/orgs","repos_url":"https://api.github.com/users/MikeInnes/repos","events_url":"https://api.github.com/users/MikeInnes/events{/privacy}","received_events_url":"https://api.github.com/users/MikeInnes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-09-02T16:17:09Z","updated_at":"2016-09-05T13:33:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spencerlyon2/PlotlyJS.jl/pulls/67","html_url":"https://github.com/spencerlyon2/PlotlyJS.jl/pull/67","diff_url":"https://github.com/spencerlyon2/PlotlyJS.jl/pull/67.diff","patch_url":"https://github.com/spencerlyon2/PlotlyJS.jl/pull/67.patch"},"body":"![toolbar](https://cloud.githubusercontent.com/assets/2234614/18210155/178bcfdc-712f-11e6-8e01-bd8ed92529eb.gif)\r\n\r\nThis is a fairly simple patch in the end – the change in `electron.jl` is just to load the blink object from Atom if it's available and from Blink.jl directly if not. I'm not sure what you're using the options dict for, or if you use `Window`-specific APIs at any point, so that may be worth checking – but at worst it should work exactly the same in the repl.\r\n\r\nThen in `juno.jl` I just register `SyncPlot` as a type of plot (so that it gets routed to the plotpane by default) and display it appropriately.\r\n\r\nJust for fun I also added a nice in-editor display for the Plot and SyncPlot types. I haven't tried to display traces and layouts differently within the plot, but if you have any ideas then that's easy to do.\r\n\r\nThis patch does introduce a dependency on Juno.jl – but don't worry, this is just a small set of pure-Julia packages defining the API, unlike Atom.jl which is half of the Julia package ecosystem ;)"},"comment":{"url":"https://api.github.com/repos/spencerlyon2/PlotlyJS.jl/issues/comments/244748127","html_url":"https://github.com/spencerlyon2/PlotlyJS.jl/pull/67#issuecomment-244748127","issue_url":"https://api.github.com/repos/spencerlyon2/PlotlyJS.jl/issues/67","id":244748127,"user":{"login":"malmaud","id":987837,"avatar_url":"https://avatars.githubusercontent.com/u/987837?v=3","gravatar_id":"","url":"https://api.github.com/users/malmaud","html_url":"https://github.com/malmaud","followers_url":"https://api.github.com/users/malmaud/followers","following_url":"https://api.github.com/users/malmaud/following{/other_user}","gists_url":"https://api.github.com/users/malmaud/gists{/gist_id}","starred_url":"https://api.github.com/users/malmaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malmaud/subscriptions","organizations_url":"https://api.github.com/users/malmaud/orgs","repos_url":"https://api.github.com/users/malmaud/repos","events_url":"https://api.github.com/users/malmaud/events{/privacy}","received_events_url":"https://api.github.com/users/malmaud/received_events","type":"User","site_admin":false},"created_at":"2016-09-05T13:33:40Z","updated_at":"2016-09-05T13:33:40Z","body":"Yes, that's instant."}}
{"actor":{"display_login":"malmaud"}}