{"action":"created","issue":{"url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/83","labels_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/83/comments","events_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/83/events","html_url":"https://github.com/FreeCAD/FreeCAD/pull/83","id":129376780,"number":83,"title":"Turns on C++11 support for GCC and Clang","user":{"login":"ianrrees","id":5280982,"avatar_url":"https://avatars.githubusercontent.com/u/5280982?v=3","gravatar_id":"","url":"https://api.github.com/users/ianrrees","html_url":"https://github.com/ianrrees","followers_url":"https://api.github.com/users/ianrrees/followers","following_url":"https://api.github.com/users/ianrrees/following{/other_user}","gists_url":"https://api.github.com/users/ianrrees/gists{/gist_id}","starred_url":"https://api.github.com/users/ianrrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianrrees/subscriptions","organizations_url":"https://api.github.com/users/ianrrees/orgs","repos_url":"https://api.github.com/users/ianrrees/repos","events_url":"https://api.github.com/users/ianrrees/events{/privacy}","received_events_url":"https://api.github.com/users/ianrrees/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-28T08:23:45Z","updated_at":"2016-01-31T22:13:04Z","closed_at":"2016-01-31T14:27:32Z","pull_request":{"url":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/83","html_url":"https://github.com/FreeCAD/FreeCAD/pull/83","diff_url":"https://github.com/FreeCAD/FreeCAD/pull/83.diff","patch_url":"https://github.com/FreeCAD/FreeCAD/pull/83.patch"},"body":"Following up on result from http://forum.freecadweb.org/viewtopic.php?f=10&t=14006 - I'd like to propose that we switch on the compiler options for C++11 on platforms where those are used.  These don't appear to have negative effects when building gcc versions going back at least to 4.5, and don't affect builds on Windows.\r\n\r\nOn recent MacOS at least, building without -std=c++11 can result in lots of compile warnings when newer libraries are used."},"comment":{"url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/comments/177632302","html_url":"https://github.com/FreeCAD/FreeCAD/pull/83#issuecomment-177632302","issue_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/83","id":177632302,"user":{"login":"bblacey","id":6841373,"avatar_url":"https://avatars.githubusercontent.com/u/6841373?v=3","gravatar_id":"","url":"https://api.github.com/users/bblacey","html_url":"https://github.com/bblacey","followers_url":"https://api.github.com/users/bblacey/followers","following_url":"https://api.github.com/users/bblacey/following{/other_user}","gists_url":"https://api.github.com/users/bblacey/gists{/gist_id}","starred_url":"https://api.github.com/users/bblacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bblacey/subscriptions","organizations_url":"https://api.github.com/users/bblacey/orgs","repos_url":"https://api.github.com/users/bblacey/repos","events_url":"https://api.github.com/users/bblacey/events{/privacy}","received_events_url":"https://api.github.com/users/bblacey/received_events","type":"User","site_admin":false},"created_at":"2016-01-31T22:13:04Z","updated_at":"2016-01-31T22:13:04Z","body":"Hey Ian,\r\n\r\nLooks like a bug slipped through with this pull-request.  Here's the patch to fix it.\r\n\r\n```\r\ndiff --git a/CMakeLists.txt b/CMakeLists.txt\r\nindex 419427b..d7d4a46 100644\r\n--- a/CMakeLists.txt\r\n+++ b/CMakeLists.txt\r\n@@ -69,7 +69,7 @@ IF(CMAKE_COMPILER_IS_GNUCXX)\r\n     ELSE(GCC_VERSION)\r\n         SET (CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -std=c++0x\")\r\n     ENDIF(GCC_VERSION)\r\n-ENDIF()\r\n+ENDIF(CMAKE_COMPILER_IS_GNUCXX)\r\n \r\n # ================================================================================\r\n # Output directories for install target\r\n```"}}