{"push_id":1047018700,"size":1,"distinct_size":1,"ref":"refs/heads/fix_dns_record_codec","head":"5a82ddfd70f807b74bd78e1a40ec2d79a0f95e02","before":"ae384c317836d24a08dc7654122eab82dfcafd4b","commits":[{"sha":"5a82ddfd70f807b74bd78e1a40ec2d79a0f95e02","author":{"email":"8efd86fb78a56a5145ed7739dcb00c78581c5375@motd.kr","name":"Trustin Lee"},"message":"Fix incorrect name encoding/decoding in DNS records\n\nMotivation:\n\n- The decoded name should always end with a dot (.), but we currently\n  strip it, which is incorrect.\n  - (O) 0 -> \".\"\n  - (X) 0 -> \"\"\n  - (O) 5 netty 2 io 0 -> \"netty.io.\"\n  - (X) 5 netty 2 io 0 -> \"netty.io\"\n- The encoded name should end with a null-label, which is a label whose\n  length is 0, but we currently append an extra NUL, causing FORMERR(1)\n  on a strict DNS server:\n  - (O) . -> 0\n  - (X) . -> 0 0\n  - (O) netty.io. -> 5 netty 2 io 0\n  - (X) netty.io. -> 5 netty 2 io 0 0\n\nModifications:\n\n- Make sure to append '.' when decoding a name.\n- Improve index checks so that the decoder can raise\n  CorruptFrameException instead of IIOBE\n- Do not encode extra NUL\n- Add more tests\n- Increase the log level when running tests\n\nResult:\n\nRobustness and correctness","distinct":true,"url":"https://api.github.com/repos/netty/netty/commits/5a82ddfd70f807b74bd78e1a40ec2d79a0f95e02"}]}