{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/xcbuild/pulls/comments/88570501","pull_request_review_id":9141649,"id":88570501,"diff_hunk":"@@ -28,19 +31,41 @@ resolve(\n     pbxsetting::Environment const &baseEnvironment,\n     std::vector<Phase::File> const &inputs) const\n {\n+    std::vector<std::string> absoluteInputPaths;\n+    std::vector<std::string> assetPaths;\n+    std::vector<std::string> stickerPackStrings;\n+    for (Phase::File const &input : inputs) {\n+        if (input.fileType()->identifier() == \"text.plist.strings\") {\n+            std::string strings;","path":"Libraries/pbxbuild/Sources/Tool/AssetCatalogResolver.cpp","position":21,"original_position":21,"commit_id":"dd612773588209d6bc513e3e40b40d4355874e94","original_commit_id":"dd612773588209d6bc513e3e40b40d4355874e94","user":{"login":"sas","id":51052,"avatar_url":"https://avatars.githubusercontent.com/u/51052?v=3","gravatar_id":"","url":"https://api.github.com/users/sas","html_url":"https://github.com/sas","followers_url":"https://api.github.com/users/sas/followers","following_url":"https://api.github.com/users/sas/following{/other_user}","gists_url":"https://api.github.com/users/sas/gists{/gist_id}","starred_url":"https://api.github.com/users/sas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sas/subscriptions","organizations_url":"https://api.github.com/users/sas/orgs","repos_url":"https://api.github.com/users/sas/repos","events_url":"https://api.github.com/users/sas/events{/privacy}","received_events_url":"https://api.github.com/users/sas/received_events","type":"User","site_admin":false},"body":"Nit: you could allocate your `strings` variable and then `reserve()` the amount of space you're going to need before doing the concatenations. That'll avoid a bunch of reallocations. This might not even be a hot path, so feel free to ignore the suggestion.","created_at":"2016-11-17T23:25:32Z","updated_at":"2016-11-17T23:26:24Z","html_url":"https://github.com/facebook/xcbuild/pull/179#discussion_r88570501","pull_request_url":"https://api.github.com/repos/facebook/xcbuild/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/comments/88570501"},"html":{"href":"https://github.com/facebook/xcbuild/pull/179#discussion_r88570501"},"pull_request":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/xcbuild/pulls/179","id":92377263,"html_url":"https://github.com/facebook/xcbuild/pull/179","diff_url":"https://github.com/facebook/xcbuild/pull/179.diff","patch_url":"https://github.com/facebook/xcbuild/pull/179.patch","issue_url":"https://api.github.com/repos/facebook/xcbuild/issues/179","number":179,"state":"open","locked":false,"title":"Partially update asset catalog compiler specification and resolver.","user":{"login":"grp","id":163390,"avatar_url":"https://avatars.githubusercontent.com/u/163390?v=3","gravatar_id":"","url":"https://api.github.com/users/grp","html_url":"https://github.com/grp","followers_url":"https://api.github.com/users/grp/followers","following_url":"https://api.github.com/users/grp/following{/other_user}","gists_url":"https://api.github.com/users/grp/gists{/gist_id}","starred_url":"https://api.github.com/users/grp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grp/subscriptions","organizations_url":"https://api.github.com/users/grp/orgs","repos_url":"https://api.github.com/users/grp/repos","events_url":"https://api.github.com/users/grp/events{/privacy}","received_events_url":"https://api.github.com/users/grp/received_events","type":"User","site_admin":false},"body":"Asset catalog compilation now uses a custom variable to pass inputs\r\nto the specification, and a custom grouping method to group inputs.\r\n\r\nDoes not pass sticker pack translations to asset catalog compiler,\r\nas this seems to require parsing the asset catalog just to determine\r\nwhich strings files should be used. Left as a future task.","created_at":"2016-11-04T16:55:35Z","updated_at":"2016-11-17T23:26:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aeb7729200c513b183661b66e1919cd29b43575d","assignee":{"login":"Ktwu","id":470651,"avatar_url":"https://avatars.githubusercontent.com/u/470651?v=3","gravatar_id":"","url":"https://api.github.com/users/Ktwu","html_url":"https://github.com/Ktwu","followers_url":"https://api.github.com/users/Ktwu/followers","following_url":"https://api.github.com/users/Ktwu/following{/other_user}","gists_url":"https://api.github.com/users/Ktwu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ktwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ktwu/subscriptions","organizations_url":"https://api.github.com/users/Ktwu/orgs","repos_url":"https://api.github.com/users/Ktwu/repos","events_url":"https://api.github.com/users/Ktwu/events{/privacy}","received_events_url":"https://api.github.com/users/Ktwu/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ktwu","id":470651,"avatar_url":"https://avatars.githubusercontent.com/u/470651?v=3","gravatar_id":"","url":"https://api.github.com/users/Ktwu","html_url":"https://github.com/Ktwu","followers_url":"https://api.github.com/users/Ktwu/followers","following_url":"https://api.github.com/users/Ktwu/following{/other_user}","gists_url":"https://api.github.com/users/Ktwu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ktwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ktwu/subscriptions","organizations_url":"https://api.github.com/users/Ktwu/orgs","repos_url":"https://api.github.com/users/Ktwu/repos","events_url":"https://api.github.com/users/Ktwu/events{/privacy}","received_events_url":"https://api.github.com/users/Ktwu/received_events","type":"User","site_admin":false},{"login":"onhachoe","id":3234054,"avatar_url":"https://avatars.githubusercontent.com/u/3234054?v=3","gravatar_id":"","url":"https://api.github.com/users/onhachoe","html_url":"https://github.com/onhachoe","followers_url":"https://api.github.com/users/onhachoe/followers","following_url":"https://api.github.com/users/onhachoe/following{/other_user}","gists_url":"https://api.github.com/users/onhachoe/gists{/gist_id}","starred_url":"https://api.github.com/users/onhachoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onhachoe/subscriptions","organizations_url":"https://api.github.com/users/onhachoe/orgs","repos_url":"https://api.github.com/users/onhachoe/repos","events_url":"https://api.github.com/users/onhachoe/events{/privacy}","received_events_url":"https://api.github.com/users/onhachoe/received_events","type":"User","site_admin":false},{"login":"jackwu95","id":3927565,"avatar_url":"https://avatars.githubusercontent.com/u/3927565?v=3","gravatar_id":"","url":"https://api.github.com/users/jackwu95","html_url":"https://github.com/jackwu95","followers_url":"https://api.github.com/users/jackwu95/followers","following_url":"https://api.github.com/users/jackwu95/following{/other_user}","gists_url":"https://api.github.com/users/jackwu95/gists{/gist_id}","starred_url":"https://api.github.com/users/jackwu95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackwu95/subscriptions","organizations_url":"https://api.github.com/users/jackwu95/orgs","repos_url":"https://api.github.com/users/jackwu95/repos","events_url":"https://api.github.com/users/jackwu95/events{/privacy}","received_events_url":"https://api.github.com/users/jackwu95/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/xcbuild/pulls/179/commits","review_comments_url":"https://api.github.com/repos/facebook/xcbuild/pulls/179/comments","review_comment_url":"https://api.github.com/repos/facebook/xcbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/xcbuild/issues/179/comments","statuses_url":"https://api.github.com/repos/facebook/xcbuild/statuses/dd612773588209d6bc513e3e40b40d4355874e94","head":{"label":"facebook:grp/actool-resolver","ref":"grp/actool-resolver","sha":"dd612773588209d6bc513e3e40b40d4355874e94","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":43019030,"name":"xcbuild","full_name":"facebook/xcbuild","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/xcbuild","description":"Xcode-compatible build tool.","fork":false,"url":"https://api.github.com/repos/facebook/xcbuild","forks_url":"https://api.github.com/repos/facebook/xcbuild/forks","keys_url":"https://api.github.com/repos/facebook/xcbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/xcbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/xcbuild/teams","hooks_url":"https://api.github.com/repos/facebook/xcbuild/hooks","issue_events_url":"https://api.github.com/repos/facebook/xcbuild/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/xcbuild/events","assignees_url":"https://api.github.com/repos/facebook/xcbuild/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/xcbuild/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/xcbuild/tags","blobs_url":"https://api.github.com/repos/facebook/xcbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/xcbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/xcbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/xcbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/xcbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/xcbuild/languages","stargazers_url":"https://api.github.com/repos/facebook/xcbuild/stargazers","contributors_url":"https://api.github.com/repos/facebook/xcbuild/contributors","subscribers_url":"https://api.github.com/repos/facebook/xcbuild/subscribers","subscription_url":"https://api.github.com/repos/facebook/xcbuild/subscription","commits_url":"https://api.github.com/repos/facebook/xcbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/xcbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/xcbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/xcbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/xcbuild/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/xcbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/xcbuild/merges","archive_url":"https://api.github.com/repos/facebook/xcbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/xcbuild/downloads","issues_url":"https://api.github.com/repos/facebook/xcbuild/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/xcbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/xcbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/xcbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/xcbuild/labels{/name}","releases_url":"https://api.github.com/repos/facebook/xcbuild/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/xcbuild/deployments","created_at":"2015-09-23T18:24:01Z","updated_at":"2016-11-17T21:00:52Z","pushed_at":"2016-11-17T22:45:58Z","git_url":"git://github.com/facebook/xcbuild.git","ssh_url":"git@github.com:facebook/xcbuild.git","clone_url":"https://github.com/facebook/xcbuild.git","svn_url":"https://github.com/facebook/xcbuild","homepage":null,"size":4430,"stargazers_count":1165,"watchers_count":1165,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":34,"forks":72,"open_issues":34,"watchers":1165,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"ef95e55f4732e26c83b4a8cb266f21c6897b309c","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":43019030,"name":"xcbuild","full_name":"facebook/xcbuild","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/xcbuild","description":"Xcode-compatible build tool.","fork":false,"url":"https://api.github.com/repos/facebook/xcbuild","forks_url":"https://api.github.com/repos/facebook/xcbuild/forks","keys_url":"https://api.github.com/repos/facebook/xcbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/xcbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/xcbuild/teams","hooks_url":"https://api.github.com/repos/facebook/xcbuild/hooks","issue_events_url":"https://api.github.com/repos/facebook/xcbuild/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/xcbuild/events","assignees_url":"https://api.github.com/repos/facebook/xcbuild/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/xcbuild/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/xcbuild/tags","blobs_url":"https://api.github.com/repos/facebook/xcbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/xcbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/xcbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/xcbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/xcbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/xcbuild/languages","stargazers_url":"https://api.github.com/repos/facebook/xcbuild/stargazers","contributors_url":"https://api.github.com/repos/facebook/xcbuild/contributors","subscribers_url":"https://api.github.com/repos/facebook/xcbuild/subscribers","subscription_url":"https://api.github.com/repos/facebook/xcbuild/subscription","commits_url":"https://api.github.com/repos/facebook/xcbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/xcbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/xcbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/xcbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/xcbuild/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/xcbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/xcbuild/merges","archive_url":"https://api.github.com/repos/facebook/xcbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/xcbuild/downloads","issues_url":"https://api.github.com/repos/facebook/xcbuild/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/xcbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/xcbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/xcbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/xcbuild/labels{/name}","releases_url":"https://api.github.com/repos/facebook/xcbuild/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/xcbuild/deployments","created_at":"2015-09-23T18:24:01Z","updated_at":"2016-11-17T21:00:52Z","pushed_at":"2016-11-17T22:45:58Z","git_url":"git://github.com/facebook/xcbuild.git","ssh_url":"git@github.com:facebook/xcbuild.git","clone_url":"https://github.com/facebook/xcbuild.git","svn_url":"https://github.com/facebook/xcbuild","homepage":null,"size":4430,"stargazers_count":1165,"watchers_count":1165,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":34,"forks":72,"open_issues":34,"watchers":1165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/179"},"html":{"href":"https://github.com/facebook/xcbuild/pull/179"},"issue":{"href":"https://api.github.com/repos/facebook/xcbuild/issues/179"},"comments":{"href":"https://api.github.com/repos/facebook/xcbuild/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/xcbuild/statuses/dd612773588209d6bc513e3e40b40d4355874e94"}}}}
{"actor":{"display_login":"sas"}}