{"action":"created","comment":{"url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments/77121802","id":77121802,"diff_hunk":"@@ -0,0 +1,205 @@\n+/*\n+Copyright 2016 ScalABM\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+   http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+package markets.orderbooks.parallel.concurrent\n+\n+import markets.orderbooks.AbstractOrderBookSpec\n+import markets.orders.limit.LimitOrder\n+import markets.orders.market.MarketOrder\n+import markets.orders.{AskOrder, BidOrder}\n+import markets.tradables.Tradable\n+\n+import scala.util.Random\n+\n+\n+class OrderBookSpec extends AbstractOrderBookSpec {\n+\n+  import markets.RandomOrderGenerator._\n+\n+  val prng = new Random(1776)\n+\n+  def askOrderBookFactory(tradable: Tradable) = OrderBook[AskOrder](tradable)\n+\n+  def bidOrderBookFactory(tradable: Tradable) = OrderBook[BidOrder](tradable)","path":"src/test/scala-2.11/markets/orderbooks/parallel/concurrent/OrderBookSpec.scala","position":35,"original_position":35,"commit_id":"0e5e3b7e97ea14f3a0a701a64140e52696e71ded","original_commit_id":"0e5e3b7e97ea14f3a0a701a64140e52696e71ded","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Public method must have explicit type](https://www.codacy.com/app/davidrpugh/markets-sandbox/file/3692341907/issues/source?bid=2921361&fileBranchId=3664746#l35)","created_at":"2016-09-01T06:47:28Z","updated_at":"2016-09-01T06:47:28Z","html_url":"https://github.com/ScalABM/markets-sandbox/pull/169#discussion_r77121802","pull_request_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments/77121802"},"html":{"href":"https://github.com/ScalABM/markets-sandbox/pull/169#discussion_r77121802"},"pull_request":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/169","id":83577185,"html_url":"https://github.com/ScalABM/markets-sandbox/pull/169","diff_url":"https://github.com/ScalABM/markets-sandbox/pull/169.diff","patch_url":"https://github.com/ScalABM/markets-sandbox/pull/169.patch","issue_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/169","number":169,"state":"open","locked":false,"title":"Add parallel orderbook","user":{"login":"davidrpugh","id":2219562,"avatar_url":"https://avatars.githubusercontent.com/u/2219562?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrpugh","html_url":"https://github.com/davidrpugh","followers_url":"https://api.github.com/users/davidrpugh/followers","following_url":"https://api.github.com/users/davidrpugh/following{/other_user}","gists_url":"https://api.github.com/users/davidrpugh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrpugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrpugh/subscriptions","organizations_url":"https://api.github.com/users/davidrpugh/orgs","repos_url":"https://api.github.com/users/davidrpugh/repos","events_url":"https://api.github.com/users/davidrpugh/events{/privacy}","received_events_url":"https://api.github.com/users/davidrpugh/received_events","type":"User","site_admin":false},"body":"This PR provides a new package implementing order books whose methods are capable of operating in parallel.","created_at":"2016-09-01T06:30:50Z","updated_at":"2016-09-01T06:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4c87a64b28f884125370e12e438dc37781a2391","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/169/commits","review_comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/169/comments","review_comment_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/169/comments","statuses_url":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/0e5e3b7e97ea14f3a0a701a64140e52696e71ded","head":{"label":"ScalABM:add-parallel-orderbook","ref":"add-parallel-orderbook","sha":"0e5e3b7e97ea14f3a0a701a64140e52696e71ded","user":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"repo":{"id":44811632,"name":"markets-sandbox","full_name":"ScalABM/markets-sandbox","owner":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScalABM/markets-sandbox","description":"A sandbox for building and testing scalable implementations of various market micro-structures.","fork":false,"url":"https://api.github.com/repos/ScalABM/markets-sandbox","forks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/forks","keys_url":"https://api.github.com/repos/ScalABM/markets-sandbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScalABM/markets-sandbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScalABM/markets-sandbox/teams","hooks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/hooks","issue_events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/events{/number}","events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/events","assignees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/assignees{/user}","branches_url":"https://api.github.com/repos/ScalABM/markets-sandbox/branches{/branch}","tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/tags","blobs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/{sha}","languages_url":"https://api.github.com/repos/ScalABM/markets-sandbox/languages","stargazers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/stargazers","contributors_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contributors","subscribers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscribers","subscription_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscription","commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contents/{+path}","compare_url":"https://api.github.com/repos/ScalABM/markets-sandbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScalABM/markets-sandbox/merges","archive_url":"https://api.github.com/repos/ScalABM/markets-sandbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScalABM/markets-sandbox/downloads","issues_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues{/number}","pulls_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls{/number}","milestones_url":"https://api.github.com/repos/ScalABM/markets-sandbox/milestones{/number}","notifications_url":"https://api.github.com/repos/ScalABM/markets-sandbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScalABM/markets-sandbox/labels{/name}","releases_url":"https://api.github.com/repos/ScalABM/markets-sandbox/releases{/id}","deployments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/deployments","created_at":"2015-10-23T12:25:31Z","updated_at":"2016-02-12T14:49:56Z","pushed_at":"2016-09-01T06:45:48Z","git_url":"git://github.com/ScalABM/markets-sandbox.git","ssh_url":"git@github.com:ScalABM/markets-sandbox.git","clone_url":"https://github.com/ScalABM/markets-sandbox.git","svn_url":"https://github.com/ScalABM/markets-sandbox","homepage":null,"size":990,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":1,"default_branch":"master"}},"base":{"label":"ScalABM:develop","ref":"develop","sha":"63b877a2b51b02b931431c874f7c7f895249177d","user":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"repo":{"id":44811632,"name":"markets-sandbox","full_name":"ScalABM/markets-sandbox","owner":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScalABM/markets-sandbox","description":"A sandbox for building and testing scalable implementations of various market micro-structures.","fork":false,"url":"https://api.github.com/repos/ScalABM/markets-sandbox","forks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/forks","keys_url":"https://api.github.com/repos/ScalABM/markets-sandbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScalABM/markets-sandbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScalABM/markets-sandbox/teams","hooks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/hooks","issue_events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/events{/number}","events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/events","assignees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/assignees{/user}","branches_url":"https://api.github.com/repos/ScalABM/markets-sandbox/branches{/branch}","tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/tags","blobs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/{sha}","languages_url":"https://api.github.com/repos/ScalABM/markets-sandbox/languages","stargazers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/stargazers","contributors_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contributors","subscribers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscribers","subscription_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscription","commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contents/{+path}","compare_url":"https://api.github.com/repos/ScalABM/markets-sandbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScalABM/markets-sandbox/merges","archive_url":"https://api.github.com/repos/ScalABM/markets-sandbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScalABM/markets-sandbox/downloads","issues_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues{/number}","pulls_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls{/number}","milestones_url":"https://api.github.com/repos/ScalABM/markets-sandbox/milestones{/number}","notifications_url":"https://api.github.com/repos/ScalABM/markets-sandbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScalABM/markets-sandbox/labels{/name}","releases_url":"https://api.github.com/repos/ScalABM/markets-sandbox/releases{/id}","deployments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/deployments","created_at":"2015-10-23T12:25:31Z","updated_at":"2016-02-12T14:49:56Z","pushed_at":"2016-09-01T06:45:48Z","git_url":"git://github.com/ScalABM/markets-sandbox.git","ssh_url":"git@github.com:ScalABM/markets-sandbox.git","clone_url":"https://github.com/ScalABM/markets-sandbox.git","svn_url":"https://github.com/ScalABM/markets-sandbox","homepage":null,"size":990,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/169"},"html":{"href":"https://github.com/ScalABM/markets-sandbox/pull/169"},"issue":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/169"},"comments":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/0e5e3b7e97ea14f3a0a701a64140e52696e71ded"}}}}
{"actor":{"display_login":"codacy-bot"}}