{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments/93488292","pull_request_review_id":14017420,"id":93488292,"diff_hunk":"@@ -53,7 +53,7 @@ var scalewayMutexKV = mutexkv.NewMutexKV()\n func providerConfigure(d *schema.ResourceData) (interface{}, error) {\n \tconfig := Config{","path":"builtin/providers/scaleway/provider.go","position":23,"original_position":23,"commit_id":"79ff7bee4b1282337310541a1fe0023670cc77ec","original_commit_id":"79ff7bee4b1282337310541a1fe0023670cc77ec","user":{"login":"nicolai86","id":111324,"avatar_url":"https://avatars.githubusercontent.com/u/111324?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolai86","html_url":"https://github.com/nicolai86","followers_url":"https://api.github.com/users/nicolai86/followers","following_url":"https://api.github.com/users/nicolai86/following{/other_user}","gists_url":"https://api.github.com/users/nicolai86/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolai86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolai86/subscriptions","organizations_url":"https://api.github.com/users/nicolai86/orgs","repos_url":"https://api.github.com/users/nicolai86/repos","events_url":"https://api.github.com/users/nicolai86/events{/privacy}","received_events_url":"https://api.github.com/users/nicolai86/received_events","type":"User","site_admin":false},"body":"please leave the `access_key` in for now, for backwards compatibility.\r\n\r\nIt could look like this:\r\n\r\n```\r\napiKey := \"\"\r\nif v, ok := d.Get(\"token\").(string); ok {\r\n  apiKey = v\r\n}\r\nif v, ok := d.Get(\"access_key\").(string); ok {\r\n  apiKey = v\r\n}\r\n…\r\nConfig{\r\n  APIKey: apiKey,\r\n}\r\n```","created_at":"2016-12-21T18:02:05Z","updated_at":"2016-12-21T18:04:36Z","html_url":"https://github.com/hashicorp/terraform/pull/10874#discussion_r93488292","pull_request_url":"https://api.github.com/repos/hashicorp/terraform/pulls/10874","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments/93488292"},"html":{"href":"https://github.com/hashicorp/terraform/pull/10874#discussion_r93488292"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/10874"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/10874","id":98855946,"html_url":"https://github.com/hashicorp/terraform/pull/10874","diff_url":"https://github.com/hashicorp/terraform/pull/10874.diff","patch_url":"https://github.com/hashicorp/terraform/pull/10874.patch","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/10874","number":10874,"state":"open","locked":false,"title":"Fix contradiction in terms with provider documentation (#10815)","user":{"login":"OJFord","id":3946014,"avatar_url":"https://avatars.githubusercontent.com/u/3946014?v=3","gravatar_id":"","url":"https://api.github.com/users/OJFord","html_url":"https://github.com/OJFord","followers_url":"https://api.github.com/users/OJFord/followers","following_url":"https://api.github.com/users/OJFord/following{/other_user}","gists_url":"https://api.github.com/users/OJFord/gists{/gist_id}","starred_url":"https://api.github.com/users/OJFord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OJFord/subscriptions","organizations_url":"https://api.github.com/users/OJFord/orgs","repos_url":"https://api.github.com/users/OJFord/repos","events_url":"https://api.github.com/users/OJFord/events{/privacy}","received_events_url":"https://api.github.com/users/OJFord/received_events","type":"User","site_admin":false},"body":"This PR fixes a contradiction in the API access terminology used by Scaleway and Terraform; each previously using `access_key` for different parameters. Discussion in #10815.\r\n\r\nI've also included a removal of 'ARM' from the documentation (e.g. 'ARM server') to reflect the fact that Scaleway now also provides x86 servers.","created_at":"2016-12-21T01:19:59Z","updated_at":"2016-12-21T18:07:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ef2549ea3788026bc35ca878aa92c392d8969fc","assignee":{"login":"nicolai86","id":111324,"avatar_url":"https://avatars.githubusercontent.com/u/111324?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolai86","html_url":"https://github.com/nicolai86","followers_url":"https://api.github.com/users/nicolai86/followers","following_url":"https://api.github.com/users/nicolai86/following{/other_user}","gists_url":"https://api.github.com/users/nicolai86/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolai86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolai86/subscriptions","organizations_url":"https://api.github.com/users/nicolai86/orgs","repos_url":"https://api.github.com/users/nicolai86/repos","events_url":"https://api.github.com/users/nicolai86/events{/privacy}","received_events_url":"https://api.github.com/users/nicolai86/received_events","type":"User","site_admin":false},"assignees":[{"login":"nicolai86","id":111324,"avatar_url":"https://avatars.githubusercontent.com/u/111324?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolai86","html_url":"https://github.com/nicolai86","followers_url":"https://api.github.com/users/nicolai86/followers","following_url":"https://api.github.com/users/nicolai86/following{/other_user}","gists_url":"https://api.github.com/users/nicolai86/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolai86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolai86/subscriptions","organizations_url":"https://api.github.com/users/nicolai86/orgs","repos_url":"https://api.github.com/users/nicolai86/repos","events_url":"https://api.github.com/users/nicolai86/events{/privacy}","received_events_url":"https://api.github.com/users/nicolai86/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/terraform/pulls/10874/commits","review_comments_url":"https://api.github.com/repos/hashicorp/terraform/pulls/10874/comments","review_comment_url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/10874/comments","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/79ff7bee4b1282337310541a1fe0023670cc77ec","head":{"label":"OJFord:master","ref":"master","sha":"79ff7bee4b1282337310541a1fe0023670cc77ec","user":{"login":"OJFord","id":3946014,"avatar_url":"https://avatars.githubusercontent.com/u/3946014?v=3","gravatar_id":"","url":"https://api.github.com/users/OJFord","html_url":"https://github.com/OJFord","followers_url":"https://api.github.com/users/OJFord/followers","following_url":"https://api.github.com/users/OJFord/following{/other_user}","gists_url":"https://api.github.com/users/OJFord/gists{/gist_id}","starred_url":"https://api.github.com/users/OJFord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OJFord/subscriptions","organizations_url":"https://api.github.com/users/OJFord/orgs","repos_url":"https://api.github.com/users/OJFord/repos","events_url":"https://api.github.com/users/OJFord/events{/privacy}","received_events_url":"https://api.github.com/users/OJFord/received_events","type":"User","site_admin":false},"repo":{"id":77003209,"name":"terraform","full_name":"OJFord/terraform","owner":{"login":"OJFord","id":3946014,"avatar_url":"https://avatars.githubusercontent.com/u/3946014?v=3","gravatar_id":"","url":"https://api.github.com/users/OJFord","html_url":"https://github.com/OJFord","followers_url":"https://api.github.com/users/OJFord/followers","following_url":"https://api.github.com/users/OJFord/following{/other_user}","gists_url":"https://api.github.com/users/OJFord/gists{/gist_id}","starred_url":"https://api.github.com/users/OJFord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OJFord/subscriptions","organizations_url":"https://api.github.com/users/OJFord/orgs","repos_url":"https://api.github.com/users/OJFord/repos","events_url":"https://api.github.com/users/OJFord/events{/privacy}","received_events_url":"https://api.github.com/users/OJFord/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OJFord/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":true,"url":"https://api.github.com/repos/OJFord/terraform","forks_url":"https://api.github.com/repos/OJFord/terraform/forks","keys_url":"https://api.github.com/repos/OJFord/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OJFord/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OJFord/terraform/teams","hooks_url":"https://api.github.com/repos/OJFord/terraform/hooks","issue_events_url":"https://api.github.com/repos/OJFord/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/OJFord/terraform/events","assignees_url":"https://api.github.com/repos/OJFord/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/OJFord/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/OJFord/terraform/tags","blobs_url":"https://api.github.com/repos/OJFord/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OJFord/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OJFord/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/OJFord/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OJFord/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/OJFord/terraform/languages","stargazers_url":"https://api.github.com/repos/OJFord/terraform/stargazers","contributors_url":"https://api.github.com/repos/OJFord/terraform/contributors","subscribers_url":"https://api.github.com/repos/OJFord/terraform/subscribers","subscription_url":"https://api.github.com/repos/OJFord/terraform/subscription","commits_url":"https://api.github.com/repos/OJFord/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/OJFord/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/OJFord/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/OJFord/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/OJFord/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/OJFord/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OJFord/terraform/merges","archive_url":"https://api.github.com/repos/OJFord/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OJFord/terraform/downloads","issues_url":"https://api.github.com/repos/OJFord/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/OJFord/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/OJFord/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/OJFord/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OJFord/terraform/labels{/name}","releases_url":"https://api.github.com/repos/OJFord/terraform/releases{/id}","deployments_url":"https://api.github.com/repos/OJFord/terraform/deployments","created_at":"2016-12-21T00:55:49Z","updated_at":"2016-12-21T00:56:02Z","pushed_at":"2016-12-21T01:14:19Z","git_url":"git://github.com/OJFord/terraform.git","ssh_url":"git@github.com:OJFord/terraform.git","clone_url":"https://github.com/OJFord/terraform.git","svn_url":"https://github.com/OJFord/terraform","homepage":"https://www.terraform.io/","size":69658,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"a45d2e5289d98a5ccb5d41da50b6b27038692208","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":17728164,"name":"terraform","full_name":"hashicorp/terraform","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform","forks_url":"https://api.github.com/repos/hashicorp/terraform/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/terraform/deployments","created_at":"2014-03-13T22:25:48Z","updated_at":"2016-12-21T17:05:34Z","pushed_at":"2016-12-21T14:53:55Z","git_url":"git://github.com/hashicorp/terraform.git","ssh_url":"git@github.com:hashicorp/terraform.git","clone_url":"https://github.com/hashicorp/terraform.git","svn_url":"https://github.com/hashicorp/terraform","homepage":"https://www.terraform.io/","size":69655,"stargazers_count":6548,"watchers_count":6548,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2338,"mirror_url":null,"open_issues_count":1579,"forks":2338,"open_issues":1579,"watchers":6548,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/10874"},"html":{"href":"https://github.com/hashicorp/terraform/pull/10874"},"issue":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/10874"},"comments":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/10874/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/10874/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/10874/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/terraform/statuses/79ff7bee4b1282337310541a1fe0023670cc77ec"}}}}
{"actor":{"display_login":"nicolai86"}}