{"action":"closed","issue":{"url":"https://api.github.com/repos/callemall/material-ui/issues/5299","repository_url":"https://api.github.com/repos/callemall/material-ui","labels_url":"https://api.github.com/repos/callemall/material-ui/issues/5299/labels{/name}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/5299/comments","events_url":"https://api.github.com/repos/callemall/material-ui/issues/5299/events","html_url":"https://github.com/callemall/material-ui/issues/5299","id":180212710,"number":5299,"title":"Maybe a fix for unknown props in [RefreshIndicator]...","user":{"login":"verenea","id":17173088,"avatar_url":"https://avatars.githubusercontent.com/u/17173088?v=3","gravatar_id":"","url":"https://api.github.com/users/verenea","html_url":"https://github.com/verenea","followers_url":"https://api.github.com/users/verenea/followers","following_url":"https://api.github.com/users/verenea/following{/other_user}","gists_url":"https://api.github.com/users/verenea/gists{/gist_id}","starred_url":"https://api.github.com/users/verenea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verenea/subscriptions","organizations_url":"https://api.github.com/users/verenea/orgs","repos_url":"https://api.github.com/users/verenea/repos","events_url":"https://api.github.com/users/verenea/events{/privacy}","received_events_url":"https://api.github.com/users/verenea/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-30T03:33:57Z","updated_at":"2016-10-09T12:17:03Z","closed_at":"2016-10-09T12:17:03Z","body":"### Problem description\r\nI kept receiving Warning: Unknown props `left`, `top`, `status`, `percentage` on <div> tag. Remove these props from the element. For details, see https://fb.me/react-unknown-prop\r\n    in div (created by Paper)\r\n    in Paper (created by RefreshIndicator).\r\n\r\nI did some testing and logging within the npm_modules/material-ui/RefreshIndicator code and seemed to isolate the problem within the render block where props are being merged and assigned to the parent Paper element. As a test, I excluded the 'other' props from the merge and the warnings have disappeared without any apparent negative consequences in the components intended behavior.\r\n\r\n### Steps to reproduce\r\nThis would occur when loading a route that has a RefreshIndicator fire up in response to props being set that toggle the status (thus loading true/false).\r\n\r\n### Versions\r\n\r\n- Material-UI: 15.3.2\r\n- React: 0.16.0-rc2\r\n- Browser: chrome\r\n\r\n### Description\r\nSo, I went into the RefreshIndicator source, and at line 356, simply commented out where the 'other' props are being merged and passed to the Paper element being created and the errors have gone away. I have yet to notice any side effects or bad behavior. The warnings are gone and the components still perform as expected.\r\n\r\nSee below in the render block where I did a test to comment out the merging of 'other' props\r\n\r\n```\r\nkey: 'render',\r\n    value: function render() {\r\n      var _props = this.props;\r\n      var style = _props.style;\r\n      var other = (0, _objectWithoutProperties3.default)(_props, ['style']);\r\n      \r\n      var styles = getStyles(this.props, this.context);\r\n\r\n      return _react2.default.createElement(\r\n        _Paper2.default,\r\n        (0, _extends3.default)({\r\n          circle: true,\r\n          style: (0, _simpleAssign2.default)(styles.root, style)\r\n        }),//, other), <!---- here!!\r\n        this.renderChildren()\r\n      );\r\n    }\r\n```\r\nAnyways, not sure if this is the proper place for this, but thought I'd pass along.\r\n\r\n### Images & references\r\n\r\n-->\r\n"}}
{"actor":{"display_login":"oliviertassinari"}}