{"action":"created","issue":{"url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/970","repository_url":"https://api.github.com/repos/voxpupuli/puppet-nginx","labels_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/970/labels{/name}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/970/comments","events_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/970/events","html_url":"https://github.com/voxpupuli/puppet-nginx/pull/970","id":188948997,"number":970,"title":"Reorganize templates for clearer understanding","user":{"login":"xaque208","id":334176,"avatar_url":"https://avatars.githubusercontent.com/u/334176?v=3","gravatar_id":"","url":"https://api.github.com/users/xaque208","html_url":"https://github.com/xaque208","followers_url":"https://api.github.com/users/xaque208/followers","following_url":"https://api.github.com/users/xaque208/following{/other_user}","gists_url":"https://api.github.com/users/xaque208/gists{/gist_id}","starred_url":"https://api.github.com/users/xaque208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaque208/subscriptions","organizations_url":"https://api.github.com/users/xaque208/orgs","repos_url":"https://api.github.com/users/xaque208/repos","events_url":"https://api.github.com/users/xaque208/events{/privacy}","received_events_url":"https://api.github.com/users/xaque208/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-13T03:03:35Z","updated_at":"2016-11-13T06:03:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/970","html_url":"https://github.com/voxpupuli/puppet-nginx/pull/970","diff_url":"https://github.com/voxpupuli/puppet-nginx/pull/970.diff","patch_url":"https://github.com/voxpupuli/puppet-nginx/pull/970.patch"},"body":"Without this change, the structure of the templates for locations are\r\nbit rigid and hard to understand.  Each component of a location uses an\r\nisolated template which means that much of the common logic is hard\r\ncoded to a particular location style, the deployment of which is chosen\r\nbased on a somewhat arbitrary idea of what it means to be a location,\r\nand in some cases, the module gets it wrong.  In cases where there is\r\nseeming correctness, modifications to a particular selection of logic\r\nare duplicated among the nested templates.\r\n\r\nThis work is the results of what was necessary for me to understand what\r\nthe templates were doing, and to deploy a fastcgi PHP application.  As\r\nsuch, the templates have been centralized and conditions about their\r\nfunctionality have been moved into the template to determine if\r\nrendering needs to be taken.  This allows a more complete, and leaves\r\npotential for more complex examples easier to understand and reason\r\nabout.\r\n\r\nAlso here is the addition of a new param fastcgi_index on the location\r\nclass.\r\n\r\nThis work should result in on-disk configurations that are functionally\r\nequivalent to what was in place before, except in places where the\r\nmodule was masking conflicting options that were not being rendered in\r\nthe templates."},"comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/comments/260168828","html_url":"https://github.com/voxpupuli/puppet-nginx/pull/970#issuecomment-260168828","issue_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/970","id":260168828,"user":{"login":"jyaworski","id":449135,"avatar_url":"https://avatars.githubusercontent.com/u/449135?v=3","gravatar_id":"","url":"https://api.github.com/users/jyaworski","html_url":"https://github.com/jyaworski","followers_url":"https://api.github.com/users/jyaworski/followers","following_url":"https://api.github.com/users/jyaworski/following{/other_user}","gists_url":"https://api.github.com/users/jyaworski/gists{/gist_id}","starred_url":"https://api.github.com/users/jyaworski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyaworski/subscriptions","organizations_url":"https://api.github.com/users/jyaworski/orgs","repos_url":"https://api.github.com/users/jyaworski/repos","events_url":"https://api.github.com/users/jyaworski/events{/privacy}","received_events_url":"https://api.github.com/users/jyaworski/received_events","type":"User","site_admin":false},"created_at":"2016-11-13T06:03:14Z","updated_at":"2016-11-13T06:03:14Z","body":"Big fan of concat."}}
{"actor":{"display_login":"jyaworski"}}