{"action":"created","issue":{"url":"https://api.github.com/repos/apache/tinkerpop/issues/448","repository_url":"https://api.github.com/repos/apache/tinkerpop","labels_url":"https://api.github.com/repos/apache/tinkerpop/issues/448/labels{/name}","comments_url":"https://api.github.com/repos/apache/tinkerpop/issues/448/comments","events_url":"https://api.github.com/repos/apache/tinkerpop/issues/448/events","html_url":"https://github.com/apache/tinkerpop/pull/448","id":180983595,"number":448,"title":"Python glv graphson update","user":{"login":"aholmberg","id":1443722,"avatar_url":"https://avatars.githubusercontent.com/u/1443722?v=3","gravatar_id":"","url":"https://api.github.com/users/aholmberg","html_url":"https://github.com/aholmberg","followers_url":"https://api.github.com/users/aholmberg/followers","following_url":"https://api.github.com/users/aholmberg/following{/other_user}","gists_url":"https://api.github.com/users/aholmberg/gists{/gist_id}","starred_url":"https://api.github.com/users/aholmberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aholmberg/subscriptions","organizations_url":"https://api.github.com/users/aholmberg/orgs","repos_url":"https://api.github.com/users/aholmberg/repos","events_url":"https://api.github.com/users/aholmberg/events{/privacy}","received_events_url":"https://api.github.com/users/aholmberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-10-04T19:32:45Z","updated_at":"2016-10-10T13:52:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/448","html_url":"https://github.com/apache/tinkerpop/pull/448","diff_url":"https://github.com/apache/tinkerpop/pull/448.diff","patch_url":"https://github.com/apache/tinkerpop/pull/448.patch"},"body":"I have a series of gremlinpython graphson serdes simplifications, followed by a refactor to make type mappings an instance variable, rather than a module-level mapping. I did not attempt to preserve the module API since `gremlinpython` has not entered GA release status.\r\n\r\nI welcome any feedback."},"comment":{"url":"https://api.github.com/repos/apache/tinkerpop/issues/comments/252625579","html_url":"https://github.com/apache/tinkerpop/pull/448#issuecomment-252625579","issue_url":"https://api.github.com/repos/apache/tinkerpop/issues/448","id":252625579,"user":{"login":"aholmberg","id":1443722,"avatar_url":"https://avatars.githubusercontent.com/u/1443722?v=3","gravatar_id":"","url":"https://api.github.com/users/aholmberg","html_url":"https://github.com/aholmberg","followers_url":"https://api.github.com/users/aholmberg/followers","following_url":"https://api.github.com/users/aholmberg/following{/other_user}","gists_url":"https://api.github.com/users/aholmberg/gists{/gist_id}","starred_url":"https://api.github.com/users/aholmberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aholmberg/subscriptions","organizations_url":"https://api.github.com/users/aholmberg/orgs","repos_url":"https://api.github.com/users/aholmberg/repos","events_url":"https://api.github.com/users/aholmberg/events{/privacy}","received_events_url":"https://api.github.com/users/aholmberg/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T13:52:06Z","updated_at":"2016-10-10T13:52:06Z","body":"> you changed GraphSONWriter and GraphSONWriter to GraphSONIO\r\n\r\nThis was not Python-specific, but felt like a natural design to me. I unified the I/O per type, and tied those together at the top level in `GraphSONIO`. It seems strange to me to have the two sides of the same encoding split between classes. I thought I saw something in the java impl called `GraphSONIO`, but maybe I was mistaken. \r\n\r\nI can split them up, but then it means carrying around two things to encode/decode everywhere, instead of one:\r\n\r\n`connection = DriverConnection(..., graphson_reader=GraphSONReader(...), graphson_writer=GraphSONWriter(...))`\r\nvs.\r\n`connection = DriverConnection(..., graphson_io=GraphSONIO(...))`\r\n\r\nI'll study the Java impl. a little closer to see if I can understand the benefit. Please let me know if you have any further thoughts."}}
{"actor":{"display_login":"aholmberg"}}