{"action":"created","comment":{"url":"https://api.github.com/repos/TSTK/ACHP/pulls/comments/92830304","pull_request_review_id":13353031,"id":92830304,"diff_hunk":"@@ -419,12 +419,12 @@ def collect(cellList,tag,tagvalue,out):\n             else:\r\n                 self.DT_sc_h=self.Tbubble_h-self.Tout_h\r\n         \r\n-    def eNTU_CounterFlow(self,Cr,Ntu):\r\n-        \"\"\"\r\n-        This function returns the effectiveness for counter flow fluids\r\n-        \"\"\"\r\n-        return ((1 - exp(-Ntu * (1 - Cr))) / \r\n-            (1 - Cr * exp(-Ntu * (1 - Cr))))\r\n+#     def eNTU_CounterFlow(self,Cr,Ntu):\r","path":"ACHP/PHEHX.py","position":10,"original_position":10,"commit_id":"0874125033a3e551048f0890aec702e20adc5e02","original_commit_id":"0874125033a3e551048f0890aec702e20adc5e02","user":{"login":"bo3mrh","id":11583412,"avatar_url":"https://avatars.githubusercontent.com/u/11583412?v=3","gravatar_id":"","url":"https://api.github.com/users/bo3mrh","html_url":"https://github.com/bo3mrh","followers_url":"https://api.github.com/users/bo3mrh/followers","following_url":"https://api.github.com/users/bo3mrh/following{/other_user}","gists_url":"https://api.github.com/users/bo3mrh/gists{/gist_id}","starred_url":"https://api.github.com/users/bo3mrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bo3mrh/subscriptions","organizations_url":"https://api.github.com/users/bo3mrh/orgs","repos_url":"https://api.github.com/users/bo3mrh/repos","events_url":"https://api.github.com/users/bo3mrh/events{/privacy}","received_events_url":"https://api.github.com/users/bo3mrh/received_events","type":"User","site_admin":false},"body":"This function is not used in the code. We use epsilon from Q/Qmax to calculate NTU. See\r\nhttps://github.com/TSTK/ACHP/blob/master/ACHP/PHEHX.py#L465\r\nand\r\nhttps://github.com/TSTK/ACHP/blob/master/ACHP/PHEHX.py#L602\r\nI commented it out just in case we might need it later","created_at":"2016-12-16T15:27:50Z","updated_at":"2016-12-16T15:27:50Z","html_url":"https://github.com/TSTK/ACHP/pull/23#discussion_r92830304","pull_request_url":"https://api.github.com/repos/TSTK/ACHP/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/TSTK/ACHP/pulls/comments/92830304"},"html":{"href":"https://github.com/TSTK/ACHP/pull/23#discussion_r92830304"},"pull_request":{"href":"https://api.github.com/repos/TSTK/ACHP/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/TSTK/ACHP/pulls/23","id":98242637,"html_url":"https://github.com/TSTK/ACHP/pull/23","diff_url":"https://github.com/TSTK/ACHP/pull/23.diff","patch_url":"https://github.com/TSTK/ACHP/pull/23.patch","issue_url":"https://api.github.com/repos/TSTK/ACHP/issues/23","number":23,"state":"open","locked":false,"title":"fixing typos","user":{"login":"bo3mrh","id":11583412,"avatar_url":"https://avatars.githubusercontent.com/u/11583412?v=3","gravatar_id":"","url":"https://api.github.com/users/bo3mrh","html_url":"https://github.com/bo3mrh","followers_url":"https://api.github.com/users/bo3mrh/followers","following_url":"https://api.github.com/users/bo3mrh/following{/other_user}","gists_url":"https://api.github.com/users/bo3mrh/gists{/gist_id}","starred_url":"https://api.github.com/users/bo3mrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bo3mrh/subscriptions","organizations_url":"https://api.github.com/users/bo3mrh/orgs","repos_url":"https://api.github.com/users/bo3mrh/repos","events_url":"https://api.github.com/users/bo3mrh/events{/privacy}","received_events_url":"https://api.github.com/users/bo3mrh/received_events","type":"User","site_admin":false},"body":"A typo is fixed for the calculation of heat transfer in two-phase\nregion due to unit typo in molar mass in 2ph.\nNow for 2phase region, Qmax is calculated based on Tin instead of Tsat\n(works better with glide refrigerants)","created_at":"2016-12-15T22:20:59Z","updated_at":"2016-12-16T15:27:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6d7f6e9d21dcacaf4082464b82f4257fd388a6f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TSTK/ACHP/pulls/23/commits","review_comments_url":"https://api.github.com/repos/TSTK/ACHP/pulls/23/comments","review_comment_url":"https://api.github.com/repos/TSTK/ACHP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TSTK/ACHP/issues/23/comments","statuses_url":"https://api.github.com/repos/TSTK/ACHP/statuses/0874125033a3e551048f0890aec702e20adc5e02","head":{"label":"bo3mrh:Fixing-typos","ref":"Fixing-typos","sha":"0874125033a3e551048f0890aec702e20adc5e02","user":{"login":"bo3mrh","id":11583412,"avatar_url":"https://avatars.githubusercontent.com/u/11583412?v=3","gravatar_id":"","url":"https://api.github.com/users/bo3mrh","html_url":"https://github.com/bo3mrh","followers_url":"https://api.github.com/users/bo3mrh/followers","following_url":"https://api.github.com/users/bo3mrh/following{/other_user}","gists_url":"https://api.github.com/users/bo3mrh/gists{/gist_id}","starred_url":"https://api.github.com/users/bo3mrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bo3mrh/subscriptions","organizations_url":"https://api.github.com/users/bo3mrh/orgs","repos_url":"https://api.github.com/users/bo3mrh/repos","events_url":"https://api.github.com/users/bo3mrh/events{/privacy}","received_events_url":"https://api.github.com/users/bo3mrh/received_events","type":"User","site_admin":false},"repo":{"id":32904911,"name":"ACHP","full_name":"bo3mrh/ACHP","owner":{"login":"bo3mrh","id":11583412,"avatar_url":"https://avatars.githubusercontent.com/u/11583412?v=3","gravatar_id":"","url":"https://api.github.com/users/bo3mrh","html_url":"https://github.com/bo3mrh","followers_url":"https://api.github.com/users/bo3mrh/followers","following_url":"https://api.github.com/users/bo3mrh/following{/other_user}","gists_url":"https://api.github.com/users/bo3mrh/gists{/gist_id}","starred_url":"https://api.github.com/users/bo3mrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bo3mrh/subscriptions","organizations_url":"https://api.github.com/users/bo3mrh/orgs","repos_url":"https://api.github.com/users/bo3mrh/repos","events_url":"https://api.github.com/users/bo3mrh/events{/privacy}","received_events_url":"https://api.github.com/users/bo3mrh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bo3mrh/ACHP","description":"A python-based air conditioning and heat pump system model","fork":true,"url":"https://api.github.com/repos/bo3mrh/ACHP","forks_url":"https://api.github.com/repos/bo3mrh/ACHP/forks","keys_url":"https://api.github.com/repos/bo3mrh/ACHP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bo3mrh/ACHP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bo3mrh/ACHP/teams","hooks_url":"https://api.github.com/repos/bo3mrh/ACHP/hooks","issue_events_url":"https://api.github.com/repos/bo3mrh/ACHP/issues/events{/number}","events_url":"https://api.github.com/repos/bo3mrh/ACHP/events","assignees_url":"https://api.github.com/repos/bo3mrh/ACHP/assignees{/user}","branches_url":"https://api.github.com/repos/bo3mrh/ACHP/branches{/branch}","tags_url":"https://api.github.com/repos/bo3mrh/ACHP/tags","blobs_url":"https://api.github.com/repos/bo3mrh/ACHP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bo3mrh/ACHP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bo3mrh/ACHP/git/refs{/sha}","trees_url":"https://api.github.com/repos/bo3mrh/ACHP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bo3mrh/ACHP/statuses/{sha}","languages_url":"https://api.github.com/repos/bo3mrh/ACHP/languages","stargazers_url":"https://api.github.com/repos/bo3mrh/ACHP/stargazers","contributors_url":"https://api.github.com/repos/bo3mrh/ACHP/contributors","subscribers_url":"https://api.github.com/repos/bo3mrh/ACHP/subscribers","subscription_url":"https://api.github.com/repos/bo3mrh/ACHP/subscription","commits_url":"https://api.github.com/repos/bo3mrh/ACHP/commits{/sha}","git_commits_url":"https://api.github.com/repos/bo3mrh/ACHP/git/commits{/sha}","comments_url":"https://api.github.com/repos/bo3mrh/ACHP/comments{/number}","issue_comment_url":"https://api.github.com/repos/bo3mrh/ACHP/issues/comments{/number}","contents_url":"https://api.github.com/repos/bo3mrh/ACHP/contents/{+path}","compare_url":"https://api.github.com/repos/bo3mrh/ACHP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bo3mrh/ACHP/merges","archive_url":"https://api.github.com/repos/bo3mrh/ACHP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bo3mrh/ACHP/downloads","issues_url":"https://api.github.com/repos/bo3mrh/ACHP/issues{/number}","pulls_url":"https://api.github.com/repos/bo3mrh/ACHP/pulls{/number}","milestones_url":"https://api.github.com/repos/bo3mrh/ACHP/milestones{/number}","notifications_url":"https://api.github.com/repos/bo3mrh/ACHP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bo3mrh/ACHP/labels{/name}","releases_url":"https://api.github.com/repos/bo3mrh/ACHP/releases{/id}","deployments_url":"https://api.github.com/repos/bo3mrh/ACHP/deployments","created_at":"2015-03-26T03:12:19Z","updated_at":"2016-11-04T15:31:10Z","pushed_at":"2016-12-15T22:21:23Z","git_url":"git://github.com/bo3mrh/ACHP.git","ssh_url":"git@github.com:bo3mrh/ACHP.git","clone_url":"https://github.com/bo3mrh/ACHP.git","svn_url":"https://github.com/bo3mrh/ACHP","homepage":null,"size":24596,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"Changes-to-master"}},"base":{"label":"TSTK:master","ref":"master","sha":"3e4121d3598bcb62f0023c1b52d497ed872e8665","user":{"login":"TSTK","id":14844663,"avatar_url":"https://avatars.githubusercontent.com/u/14844663?v=3","gravatar_id":"","url":"https://api.github.com/users/TSTK","html_url":"https://github.com/TSTK","followers_url":"https://api.github.com/users/TSTK/followers","following_url":"https://api.github.com/users/TSTK/following{/other_user}","gists_url":"https://api.github.com/users/TSTK/gists{/gist_id}","starred_url":"https://api.github.com/users/TSTK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSTK/subscriptions","organizations_url":"https://api.github.com/users/TSTK/orgs","repos_url":"https://api.github.com/users/TSTK/repos","events_url":"https://api.github.com/users/TSTK/events{/privacy}","received_events_url":"https://api.github.com/users/TSTK/received_events","type":"Organization","site_admin":false},"repo":{"id":32901374,"name":"ACHP","full_name":"TSTK/ACHP","owner":{"login":"TSTK","id":14844663,"avatar_url":"https://avatars.githubusercontent.com/u/14844663?v=3","gravatar_id":"","url":"https://api.github.com/users/TSTK","html_url":"https://github.com/TSTK","followers_url":"https://api.github.com/users/TSTK/followers","following_url":"https://api.github.com/users/TSTK/following{/other_user}","gists_url":"https://api.github.com/users/TSTK/gists{/gist_id}","starred_url":"https://api.github.com/users/TSTK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSTK/subscriptions","organizations_url":"https://api.github.com/users/TSTK/orgs","repos_url":"https://api.github.com/users/TSTK/repos","events_url":"https://api.github.com/users/TSTK/events{/privacy}","received_events_url":"https://api.github.com/users/TSTK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TSTK/ACHP","description":"A python-based air conditioning and heat pump system model","fork":false,"url":"https://api.github.com/repos/TSTK/ACHP","forks_url":"https://api.github.com/repos/TSTK/ACHP/forks","keys_url":"https://api.github.com/repos/TSTK/ACHP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TSTK/ACHP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TSTK/ACHP/teams","hooks_url":"https://api.github.com/repos/TSTK/ACHP/hooks","issue_events_url":"https://api.github.com/repos/TSTK/ACHP/issues/events{/number}","events_url":"https://api.github.com/repos/TSTK/ACHP/events","assignees_url":"https://api.github.com/repos/TSTK/ACHP/assignees{/user}","branches_url":"https://api.github.com/repos/TSTK/ACHP/branches{/branch}","tags_url":"https://api.github.com/repos/TSTK/ACHP/tags","blobs_url":"https://api.github.com/repos/TSTK/ACHP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TSTK/ACHP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TSTK/ACHP/git/refs{/sha}","trees_url":"https://api.github.com/repos/TSTK/ACHP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TSTK/ACHP/statuses/{sha}","languages_url":"https://api.github.com/repos/TSTK/ACHP/languages","stargazers_url":"https://api.github.com/repos/TSTK/ACHP/stargazers","contributors_url":"https://api.github.com/repos/TSTK/ACHP/contributors","subscribers_url":"https://api.github.com/repos/TSTK/ACHP/subscribers","subscription_url":"https://api.github.com/repos/TSTK/ACHP/subscription","commits_url":"https://api.github.com/repos/TSTK/ACHP/commits{/sha}","git_commits_url":"https://api.github.com/repos/TSTK/ACHP/git/commits{/sha}","comments_url":"https://api.github.com/repos/TSTK/ACHP/comments{/number}","issue_comment_url":"https://api.github.com/repos/TSTK/ACHP/issues/comments{/number}","contents_url":"https://api.github.com/repos/TSTK/ACHP/contents/{+path}","compare_url":"https://api.github.com/repos/TSTK/ACHP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TSTK/ACHP/merges","archive_url":"https://api.github.com/repos/TSTK/ACHP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TSTK/ACHP/downloads","issues_url":"https://api.github.com/repos/TSTK/ACHP/issues{/number}","pulls_url":"https://api.github.com/repos/TSTK/ACHP/pulls{/number}","milestones_url":"https://api.github.com/repos/TSTK/ACHP/milestones{/number}","notifications_url":"https://api.github.com/repos/TSTK/ACHP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TSTK/ACHP/labels{/name}","releases_url":"https://api.github.com/repos/TSTK/ACHP/releases{/id}","deployments_url":"https://api.github.com/repos/TSTK/ACHP/deployments","created_at":"2015-03-26T01:42:24Z","updated_at":"2016-11-04T14:30:18Z","pushed_at":"2016-12-15T22:20:59Z","git_url":"git://github.com/TSTK/ACHP.git","ssh_url":"git@github.com:TSTK/ACHP.git","clone_url":"https://github.com/TSTK/ACHP.git","svn_url":"https://github.com/TSTK/ACHP","homepage":null,"size":12246,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TSTK/ACHP/pulls/23"},"html":{"href":"https://github.com/TSTK/ACHP/pull/23"},"issue":{"href":"https://api.github.com/repos/TSTK/ACHP/issues/23"},"comments":{"href":"https://api.github.com/repos/TSTK/ACHP/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/TSTK/ACHP/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/TSTK/ACHP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TSTK/ACHP/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/TSTK/ACHP/statuses/0874125033a3e551048f0890aec702e20adc5e02"}}}}
{"actor":{"display_login":"bo3mrh"}}