{"action":"created","comment":{"url":"https://api.github.com/repos/nats-io/gnatsd/pulls/comments/61182408","id":61182408,"diff_hunk":"@@ -146,6 +147,7 @@ func (s *Server) HandleConnz(w http.ResponseWriter, r *http.Request) {\n \t// Now we have the real number of ConnInfo objects, we can set c.NumConns\n \t// and allocate the array\n \tc.NumConns = len(pairs)\n+\tc.TotalLive = len(s.clients)","path":"server/monitor.go","position":22,"original_position":22,"commit_id":"a6dfe88746a447f47f79163b0aba883f9c7001c5","original_commit_id":"a6dfe88746a447f47f79163b0aba883f9c7001c5","user":{"login":"derekcollison","id":90097,"avatar_url":"https://avatars.githubusercontent.com/u/90097?v=3","gravatar_id":"","url":"https://api.github.com/users/derekcollison","html_url":"https://github.com/derekcollison","followers_url":"https://api.github.com/users/derekcollison/followers","following_url":"https://api.github.com/users/derekcollison/following{/other_user}","gists_url":"https://api.github.com/users/derekcollison/gists{/gist_id}","starred_url":"https://api.github.com/users/derekcollison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekcollison/subscriptions","organizations_url":"https://api.github.com/users/derekcollison/orgs","repos_url":"https://api.github.com/users/derekcollison/repos","events_url":"https://api.github.com/users/derekcollison/events{/privacy}","received_events_url":"https://api.github.com/users/derekcollison/received_events","type":"User","site_admin":false},"body":"Let's re-use the connections.","created_at":"2016-04-26T23:33:26Z","updated_at":"2016-04-26T23:33:26Z","html_url":"https://github.com/nats-io/gnatsd/pull/258#discussion_r61182408","pull_request_url":"https://api.github.com/repos/nats-io/gnatsd/pulls/258","_links":{"self":{"href":"https://api.github.com/repos/nats-io/gnatsd/pulls/comments/61182408"},"html":{"href":"https://github.com/nats-io/gnatsd/pull/258#discussion_r61182408"},"pull_request":{"href":"https://api.github.com/repos/nats-io/gnatsd/pulls/258"}}},"pull_request":{"url":"https://api.github.com/repos/nats-io/gnatsd/pulls/258","id":67974511,"html_url":"https://github.com/nats-io/gnatsd/pull/258","diff_url":"https://github.com/nats-io/gnatsd/pull/258.diff","patch_url":"https://github.com/nats-io/gnatsd/pull/258.patch","issue_url":"https://api.github.com/repos/nats-io/gnatsd/issues/258","number":258,"state":"open","locked":false,"title":"Add a live connection count to connz monitoring.","user":{"login":"ColinSullivan1","id":11180189,"avatar_url":"https://avatars.githubusercontent.com/u/11180189?v=3","gravatar_id":"","url":"https://api.github.com/users/ColinSullivan1","html_url":"https://github.com/ColinSullivan1","followers_url":"https://api.github.com/users/ColinSullivan1/followers","following_url":"https://api.github.com/users/ColinSullivan1/following{/other_user}","gists_url":"https://api.github.com/users/ColinSullivan1/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinSullivan1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinSullivan1/subscriptions","organizations_url":"https://api.github.com/users/ColinSullivan1/orgs","repos_url":"https://api.github.com/users/ColinSullivan1/repos","events_url":"https://api.github.com/users/ColinSullivan1/events{/privacy}","received_events_url":"https://api.github.com/users/ColinSullivan1/received_events","type":"User","site_admin":false},"body":"Adds a new field, `total_live` to the `/connz` generated json, representing the number of live connections at the moment.","created_at":"2016-04-26T23:27:28Z","updated_at":"2016-04-26T23:33:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d181322385189108f51f7d70a02007e75f3602d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nats-io/gnatsd/pulls/258/commits","review_comments_url":"https://api.github.com/repos/nats-io/gnatsd/pulls/258/comments","review_comment_url":"https://api.github.com/repos/nats-io/gnatsd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nats-io/gnatsd/issues/258/comments","statuses_url":"https://api.github.com/repos/nats-io/gnatsd/statuses/a6dfe88746a447f47f79163b0aba883f9c7001c5","head":{"label":"nats-io:add_total_live_connz","ref":"add_total_live_connz","sha":"a6dfe88746a447f47f79163b0aba883f9c7001c5","user":{"login":"nats-io","id":10203055,"avatar_url":"https://avatars.githubusercontent.com/u/10203055?v=3","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6443435,"name":"gnatsd","full_name":"nats-io/gnatsd","owner":{"login":"nats-io","id":10203055,"avatar_url":"https://avatars.githubusercontent.com/u/10203055?v=3","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nats-io/gnatsd","description":"High-Performance server for NATS, the cloud native messaging system.","fork":false,"url":"https://api.github.com/repos/nats-io/gnatsd","forks_url":"https://api.github.com/repos/nats-io/gnatsd/forks","keys_url":"https://api.github.com/repos/nats-io/gnatsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nats-io/gnatsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nats-io/gnatsd/teams","hooks_url":"https://api.github.com/repos/nats-io/gnatsd/hooks","issue_events_url":"https://api.github.com/repos/nats-io/gnatsd/issues/events{/number}","events_url":"https://api.github.com/repos/nats-io/gnatsd/events","assignees_url":"https://api.github.com/repos/nats-io/gnatsd/assignees{/user}","branches_url":"https://api.github.com/repos/nats-io/gnatsd/branches{/branch}","tags_url":"https://api.github.com/repos/nats-io/gnatsd/tags","blobs_url":"https://api.github.com/repos/nats-io/gnatsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nats-io/gnatsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nats-io/gnatsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/nats-io/gnatsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nats-io/gnatsd/statuses/{sha}","languages_url":"https://api.github.com/repos/nats-io/gnatsd/languages","stargazers_url":"https://api.github.com/repos/nats-io/gnatsd/stargazers","contributors_url":"https://api.github.com/repos/nats-io/gnatsd/contributors","subscribers_url":"https://api.github.com/repos/nats-io/gnatsd/subscribers","subscription_url":"https://api.github.com/repos/nats-io/gnatsd/subscription","commits_url":"https://api.github.com/repos/nats-io/gnatsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/nats-io/gnatsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/nats-io/gnatsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/nats-io/gnatsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/nats-io/gnatsd/contents/{+path}","compare_url":"https://api.github.com/repos/nats-io/gnatsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nats-io/gnatsd/merges","archive_url":"https://api.github.com/repos/nats-io/gnatsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nats-io/gnatsd/downloads","issues_url":"https://api.github.com/repos/nats-io/gnatsd/issues{/number}","pulls_url":"https://api.github.com/repos/nats-io/gnatsd/pulls{/number}","milestones_url":"https://api.github.com/repos/nats-io/gnatsd/milestones{/number}","notifications_url":"https://api.github.com/repos/nats-io/gnatsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nats-io/gnatsd/labels{/name}","releases_url":"https://api.github.com/repos/nats-io/gnatsd/releases{/id}","deployments_url":"https://api.github.com/repos/nats-io/gnatsd/deployments","created_at":"2012-10-29T16:12:24Z","updated_at":"2016-04-26T23:29:14Z","pushed_at":"2016-04-26T23:27:28Z","git_url":"git://github.com/nats-io/gnatsd.git","ssh_url":"git@github.com:nats-io/gnatsd.git","clone_url":"https://github.com/nats-io/gnatsd.git","svn_url":"https://github.com/nats-io/gnatsd","homepage":"https://nats.io","size":1612,"stargazers_count":1999,"watchers_count":1999,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":231,"mirror_url":null,"open_issues_count":10,"forks":231,"open_issues":10,"watchers":1999,"default_branch":"master"}},"base":{"label":"nats-io:master","ref":"master","sha":"83a2b3c5954436f87f0d8c6da24b5dd02a110f19","user":{"login":"nats-io","id":10203055,"avatar_url":"https://avatars.githubusercontent.com/u/10203055?v=3","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6443435,"name":"gnatsd","full_name":"nats-io/gnatsd","owner":{"login":"nats-io","id":10203055,"avatar_url":"https://avatars.githubusercontent.com/u/10203055?v=3","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nats-io/gnatsd","description":"High-Performance server for NATS, the cloud native messaging system.","fork":false,"url":"https://api.github.com/repos/nats-io/gnatsd","forks_url":"https://api.github.com/repos/nats-io/gnatsd/forks","keys_url":"https://api.github.com/repos/nats-io/gnatsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nats-io/gnatsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nats-io/gnatsd/teams","hooks_url":"https://api.github.com/repos/nats-io/gnatsd/hooks","issue_events_url":"https://api.github.com/repos/nats-io/gnatsd/issues/events{/number}","events_url":"https://api.github.com/repos/nats-io/gnatsd/events","assignees_url":"https://api.github.com/repos/nats-io/gnatsd/assignees{/user}","branches_url":"https://api.github.com/repos/nats-io/gnatsd/branches{/branch}","tags_url":"https://api.github.com/repos/nats-io/gnatsd/tags","blobs_url":"https://api.github.com/repos/nats-io/gnatsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nats-io/gnatsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nats-io/gnatsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/nats-io/gnatsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nats-io/gnatsd/statuses/{sha}","languages_url":"https://api.github.com/repos/nats-io/gnatsd/languages","stargazers_url":"https://api.github.com/repos/nats-io/gnatsd/stargazers","contributors_url":"https://api.github.com/repos/nats-io/gnatsd/contributors","subscribers_url":"https://api.github.com/repos/nats-io/gnatsd/subscribers","subscription_url":"https://api.github.com/repos/nats-io/gnatsd/subscription","commits_url":"https://api.github.com/repos/nats-io/gnatsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/nats-io/gnatsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/nats-io/gnatsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/nats-io/gnatsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/nats-io/gnatsd/contents/{+path}","compare_url":"https://api.github.com/repos/nats-io/gnatsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nats-io/gnatsd/merges","archive_url":"https://api.github.com/repos/nats-io/gnatsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nats-io/gnatsd/downloads","issues_url":"https://api.github.com/repos/nats-io/gnatsd/issues{/number}","pulls_url":"https://api.github.com/repos/nats-io/gnatsd/pulls{/number}","milestones_url":"https://api.github.com/repos/nats-io/gnatsd/milestones{/number}","notifications_url":"https://api.github.com/repos/nats-io/gnatsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nats-io/gnatsd/labels{/name}","releases_url":"https://api.github.com/repos/nats-io/gnatsd/releases{/id}","deployments_url":"https://api.github.com/repos/nats-io/gnatsd/deployments","created_at":"2012-10-29T16:12:24Z","updated_at":"2016-04-26T23:29:14Z","pushed_at":"2016-04-26T23:27:28Z","git_url":"git://github.com/nats-io/gnatsd.git","ssh_url":"git@github.com:nats-io/gnatsd.git","clone_url":"https://github.com/nats-io/gnatsd.git","svn_url":"https://github.com/nats-io/gnatsd","homepage":"https://nats.io","size":1612,"stargazers_count":1999,"watchers_count":1999,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":231,"mirror_url":null,"open_issues_count":10,"forks":231,"open_issues":10,"watchers":1999,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nats-io/gnatsd/pulls/258"},"html":{"href":"https://github.com/nats-io/gnatsd/pull/258"},"issue":{"href":"https://api.github.com/repos/nats-io/gnatsd/issues/258"},"comments":{"href":"https://api.github.com/repos/nats-io/gnatsd/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/nats-io/gnatsd/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/nats-io/gnatsd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nats-io/gnatsd/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/nats-io/gnatsd/statuses/a6dfe88746a447f47f79163b0aba883f9c7001c5"}}}}