{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/12258","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/12258/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/12258/comments","events_url":"https://api.github.com/repos/apache/spark/issues/12258/events","html_url":"https://github.com/apache/spark/pull/12258","id":146848406,"number":12258,"title":"[SPARK-14485][CORE] ignore task finished for executor lost and removed by driver","user":{"login":"zhonghaihua","id":4409429,"avatar_url":"https://avatars.githubusercontent.com/u/4409429?v=3","gravatar_id":"","url":"https://api.github.com/users/zhonghaihua","html_url":"https://github.com/zhonghaihua","followers_url":"https://api.github.com/users/zhonghaihua/followers","following_url":"https://api.github.com/users/zhonghaihua/following{/other_user}","gists_url":"https://api.github.com/users/zhonghaihua/gists{/gist_id}","starred_url":"https://api.github.com/users/zhonghaihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhonghaihua/subscriptions","organizations_url":"https://api.github.com/users/zhonghaihua/orgs","repos_url":"https://api.github.com/users/zhonghaihua/repos","events_url":"https://api.github.com/users/zhonghaihua/events{/privacy}","received_events_url":"https://api.github.com/users/zhonghaihua/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2016-04-08T07:58:17Z","updated_at":"2016-06-08T18:31:13Z","closed_at":"2016-06-07T23:34:54Z","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12258","html_url":"https://github.com/apache/spark/pull/12258","diff_url":"https://github.com/apache/spark/pull/12258.diff","patch_url":"https://github.com/apache/spark/pull/12258.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nNow, when executor is removed by driver with heartbeats timeout, driver will re-queue the task on this executor and send a kill command to cluster to kill this executor.\r\nBut, in a situation, the running task of this executor is finished and return result to driver before this executor killed by kill command sent by driver. At this situation, driver will accept the task finished event and ignore speculative task and re-queued task. \r\nBut, as we know, this executor has removed by driver, the result of this finished task can not save in driver because the BlockManagerId has also removed from BlockManagerMaster by driver. So, the result data of this stage is not complete, and then, it will cause fetch failure. For more details, [link to jira issues SPARK-14485](https://issues.apache.org/jira/browse/SPARK-14485)\r\nThis PR introduce a mechanism to ignore this kind of task finished.\r\n\r\n\r\n## How was this patch tested?\r\n\r\nN/A\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/224685201","html_url":"https://github.com/apache/spark/pull/12258#issuecomment-224685201","issue_url":"https://api.github.com/repos/apache/spark/issues/12258","id":224685201,"user":{"login":"kayousterhout","id":1108612,"avatar_url":"https://avatars.githubusercontent.com/u/1108612?v=3","gravatar_id":"","url":"https://api.github.com/users/kayousterhout","html_url":"https://github.com/kayousterhout","followers_url":"https://api.github.com/users/kayousterhout/followers","following_url":"https://api.github.com/users/kayousterhout/following{/other_user}","gists_url":"https://api.github.com/users/kayousterhout/gists{/gist_id}","starred_url":"https://api.github.com/users/kayousterhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kayousterhout/subscriptions","organizations_url":"https://api.github.com/users/kayousterhout/orgs","repos_url":"https://api.github.com/users/kayousterhout/repos","events_url":"https://api.github.com/users/kayousterhout/events{/privacy}","received_events_url":"https://api.github.com/users/kayousterhout/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T18:31:13Z","updated_at":"2016-06-08T18:31:13Z","body":"Also, @vanzin, a process note here: my understanding is that 2.0 should only have blockers / regressions merged at this point. Based on the JIRA, it looks like this bug has existed for along time so is not a regression, and doesn't cause a failure or hang -- just unnecessary additional work to re-run the task.  So, it should not have been merged into the 2.0 release.  As a result (and also because of the concerns I addressed above, which make me concerned that this may introduce additional issues into 2.0) I'd advocate for reverting this in 2.0.  @rxin thoughts, since you're the release manager?"}}
{"actor":{"display_login":"kayousterhout"}}