{"action":"created","comment":{"url":"https://api.github.com/repos/umts/probable-engine/pulls/comments/72627224","id":72627224,"diff_hunk":"@@ -29,6 +29,7 @@ class Rental < ActiveRecord::Base\n   scope :upcoming_rentals, -> { reserved.where('start_time <= ? AND end_time >= ?', DateTime.current + 1.day, DateTime.current) }\n   scope :all_future_rentals, -> { reserved.where('end_time >= ?', DateTime.current) }\n   scope :no_show_rentals, -> { reserved.where('end_time < ?', DateTime.current) }\n+  scope :inactive_rentals, -> { where('rental_status = ? OR rental_status = ?', 'canceled', 'checked_in') }","path":"app/models/rental.rb","position":4,"original_position":4,"commit_id":"bfb832146794f8fae2736dee043a0624304cbcd9","original_commit_id":"2a638839ce4e06d1f0971f23bc855c63901dac49","user":{"login":"phantompatrol","id":129601,"avatar_url":"https://avatars.githubusercontent.com/u/129601?v=3","gravatar_id":"","url":"https://api.github.com/users/phantompatrol","html_url":"https://github.com/phantompatrol","followers_url":"https://api.github.com/users/phantompatrol/followers","following_url":"https://api.github.com/users/phantompatrol/following{/other_user}","gists_url":"https://api.github.com/users/phantompatrol/gists{/gist_id}","starred_url":"https://api.github.com/users/phantompatrol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phantompatrol/subscriptions","organizations_url":"https://api.github.com/users/phantompatrol/orgs","repos_url":"https://api.github.com/users/phantompatrol/repos","events_url":"https://api.github.com/users/phantompatrol/events{/privacy}","received_events_url":"https://api.github.com/users/phantompatrol/received_events","type":"User","site_admin":false},"body":"Perhaps refactor `where(rental_status: [canceled, checked_in])`? And perhaps use the methods, if you have access to them, as opposed to strings","created_at":"2016-07-28T14:02:18Z","updated_at":"2016-07-28T14:02:18Z","html_url":"https://github.com/umts/probable-engine/pull/121#discussion_r72627224","pull_request_url":"https://api.github.com/repos/umts/probable-engine/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/umts/probable-engine/pulls/comments/72627224"},"html":{"href":"https://github.com/umts/probable-engine/pull/121#discussion_r72627224"},"pull_request":{"href":"https://api.github.com/repos/umts/probable-engine/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/umts/probable-engine/pulls/121","id":79071361,"html_url":"https://github.com/umts/probable-engine/pull/121","diff_url":"https://github.com/umts/probable-engine/pull/121.diff","patch_url":"https://github.com/umts/probable-engine/pull/121.patch","issue_url":"https://api.github.com/repos/umts/probable-engine/issues/121","number":121,"state":"open","locked":false,"title":"Processing no shows","user":{"login":"cmednieks","id":19389086,"avatar_url":"https://avatars.githubusercontent.com/u/19389086?v=3","gravatar_id":"","url":"https://api.github.com/users/cmednieks","html_url":"https://github.com/cmednieks","followers_url":"https://api.github.com/users/cmednieks/followers","following_url":"https://api.github.com/users/cmednieks/following{/other_user}","gists_url":"https://api.github.com/users/cmednieks/gists{/gist_id}","starred_url":"https://api.github.com/users/cmednieks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmednieks/subscriptions","organizations_url":"https://api.github.com/users/cmednieks/orgs","repos_url":"https://api.github.com/users/cmednieks/repos","events_url":"https://api.github.com/users/cmednieks/events{/privacy}","received_events_url":"https://api.github.com/users/cmednieks/received_events","type":"User","site_admin":false},"body":"Regarding #93 , handles the case in which a customer makes a reservation and does not pick it up or cancel it prior to the end date:\r\n- When 'process' is clicked in the home view, a form similar to check_in/out is rendered\r\n- This form asks the admin if the customer was informed of their 'no-show' status (maybe use a mailer for this?)\r\n- If yes, then rental status goes from reserved to canceled\r\n- According to Jon, the customer will have already been charged for the rental and paid as a confirmation so there will be no need for further financial transactions","created_at":"2016-07-27T18:13:03Z","updated_at":"2016-07-28T14:02:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6db775381ae1ef410ea2797fbcc58dee236bc5b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/umts/probable-engine/pulls/121/commits","review_comments_url":"https://api.github.com/repos/umts/probable-engine/pulls/121/comments","review_comment_url":"https://api.github.com/repos/umts/probable-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/umts/probable-engine/issues/121/comments","statuses_url":"https://api.github.com/repos/umts/probable-engine/statuses/bfb832146794f8fae2736dee043a0624304cbcd9","head":{"label":"cmednieks:processing-no-shows","ref":"processing-no-shows","sha":"bfb832146794f8fae2736dee043a0624304cbcd9","user":{"login":"cmednieks","id":19389086,"avatar_url":"https://avatars.githubusercontent.com/u/19389086?v=3","gravatar_id":"","url":"https://api.github.com/users/cmednieks","html_url":"https://github.com/cmednieks","followers_url":"https://api.github.com/users/cmednieks/followers","following_url":"https://api.github.com/users/cmednieks/following{/other_user}","gists_url":"https://api.github.com/users/cmednieks/gists{/gist_id}","starred_url":"https://api.github.com/users/cmednieks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmednieks/subscriptions","organizations_url":"https://api.github.com/users/cmednieks/orgs","repos_url":"https://api.github.com/users/cmednieks/repos","events_url":"https://api.github.com/users/cmednieks/events{/privacy}","received_events_url":"https://api.github.com/users/cmednieks/received_events","type":"User","site_admin":false},"repo":{"id":63158705,"name":"probable-engine","full_name":"cmednieks/probable-engine","owner":{"login":"cmednieks","id":19389086,"avatar_url":"https://avatars.githubusercontent.com/u/19389086?v=3","gravatar_id":"","url":"https://api.github.com/users/cmednieks","html_url":"https://github.com/cmednieks","followers_url":"https://api.github.com/users/cmednieks/followers","following_url":"https://api.github.com/users/cmednieks/following{/other_user}","gists_url":"https://api.github.com/users/cmednieks/gists{/gist_id}","starred_url":"https://api.github.com/users/cmednieks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmednieks/subscriptions","organizations_url":"https://api.github.com/users/cmednieks/orgs","repos_url":"https://api.github.com/users/cmednieks/repos","events_url":"https://api.github.com/users/cmednieks/events{/privacy}","received_events_url":"https://api.github.com/users/cmednieks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmednieks/probable-engine","description":null,"fork":true,"url":"https://api.github.com/repos/cmednieks/probable-engine","forks_url":"https://api.github.com/repos/cmednieks/probable-engine/forks","keys_url":"https://api.github.com/repos/cmednieks/probable-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmednieks/probable-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmednieks/probable-engine/teams","hooks_url":"https://api.github.com/repos/cmednieks/probable-engine/hooks","issue_events_url":"https://api.github.com/repos/cmednieks/probable-engine/issues/events{/number}","events_url":"https://api.github.com/repos/cmednieks/probable-engine/events","assignees_url":"https://api.github.com/repos/cmednieks/probable-engine/assignees{/user}","branches_url":"https://api.github.com/repos/cmednieks/probable-engine/branches{/branch}","tags_url":"https://api.github.com/repos/cmednieks/probable-engine/tags","blobs_url":"https://api.github.com/repos/cmednieks/probable-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmednieks/probable-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmednieks/probable-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmednieks/probable-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmednieks/probable-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/cmednieks/probable-engine/languages","stargazers_url":"https://api.github.com/repos/cmednieks/probable-engine/stargazers","contributors_url":"https://api.github.com/repos/cmednieks/probable-engine/contributors","subscribers_url":"https://api.github.com/repos/cmednieks/probable-engine/subscribers","subscription_url":"https://api.github.com/repos/cmednieks/probable-engine/subscription","commits_url":"https://api.github.com/repos/cmednieks/probable-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmednieks/probable-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmednieks/probable-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmednieks/probable-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmednieks/probable-engine/contents/{+path}","compare_url":"https://api.github.com/repos/cmednieks/probable-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmednieks/probable-engine/merges","archive_url":"https://api.github.com/repos/cmednieks/probable-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmednieks/probable-engine/downloads","issues_url":"https://api.github.com/repos/cmednieks/probable-engine/issues{/number}","pulls_url":"https://api.github.com/repos/cmednieks/probable-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/cmednieks/probable-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/cmednieks/probable-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmednieks/probable-engine/labels{/name}","releases_url":"https://api.github.com/repos/cmednieks/probable-engine/releases{/id}","deployments_url":"https://api.github.com/repos/cmednieks/probable-engine/deployments","created_at":"2016-07-12T13:08:08Z","updated_at":"2016-07-20T12:31:10Z","pushed_at":"2016-07-28T14:01:46Z","git_url":"git://github.com/cmednieks/probable-engine.git","ssh_url":"git@github.com:cmednieks/probable-engine.git","clone_url":"https://github.com/cmednieks/probable-engine.git","svn_url":"https://github.com/cmednieks/probable-engine","homepage":null,"size":2767,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"umts:master","ref":"master","sha":"f7902e93d71e6e1ac4d05250c9264fd9a9510d24","user":{"login":"umts","id":398175,"avatar_url":"https://avatars.githubusercontent.com/u/398175?v=3","gravatar_id":"","url":"https://api.github.com/users/umts","html_url":"https://github.com/umts","followers_url":"https://api.github.com/users/umts/followers","following_url":"https://api.github.com/users/umts/following{/other_user}","gists_url":"https://api.github.com/users/umts/gists{/gist_id}","starred_url":"https://api.github.com/users/umts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umts/subscriptions","organizations_url":"https://api.github.com/users/umts/orgs","repos_url":"https://api.github.com/users/umts/repos","events_url":"https://api.github.com/users/umts/events{/privacy}","received_events_url":"https://api.github.com/users/umts/received_events","type":"Organization","site_admin":false},"repo":{"id":50848353,"name":"probable-engine","full_name":"umts/probable-engine","owner":{"login":"umts","id":398175,"avatar_url":"https://avatars.githubusercontent.com/u/398175?v=3","gravatar_id":"","url":"https://api.github.com/users/umts","html_url":"https://github.com/umts","followers_url":"https://api.github.com/users/umts/followers","following_url":"https://api.github.com/users/umts/following{/other_user}","gists_url":"https://api.github.com/users/umts/gists{/gist_id}","starred_url":"https://api.github.com/users/umts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umts/subscriptions","organizations_url":"https://api.github.com/users/umts/orgs","repos_url":"https://api.github.com/users/umts/repos","events_url":"https://api.github.com/users/umts/events{/privacy}","received_events_url":"https://api.github.com/users/umts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/umts/probable-engine","description":"","fork":false,"url":"https://api.github.com/repos/umts/probable-engine","forks_url":"https://api.github.com/repos/umts/probable-engine/forks","keys_url":"https://api.github.com/repos/umts/probable-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umts/probable-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umts/probable-engine/teams","hooks_url":"https://api.github.com/repos/umts/probable-engine/hooks","issue_events_url":"https://api.github.com/repos/umts/probable-engine/issues/events{/number}","events_url":"https://api.github.com/repos/umts/probable-engine/events","assignees_url":"https://api.github.com/repos/umts/probable-engine/assignees{/user}","branches_url":"https://api.github.com/repos/umts/probable-engine/branches{/branch}","tags_url":"https://api.github.com/repos/umts/probable-engine/tags","blobs_url":"https://api.github.com/repos/umts/probable-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umts/probable-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umts/probable-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/umts/probable-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umts/probable-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/umts/probable-engine/languages","stargazers_url":"https://api.github.com/repos/umts/probable-engine/stargazers","contributors_url":"https://api.github.com/repos/umts/probable-engine/contributors","subscribers_url":"https://api.github.com/repos/umts/probable-engine/subscribers","subscription_url":"https://api.github.com/repos/umts/probable-engine/subscription","commits_url":"https://api.github.com/repos/umts/probable-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/umts/probable-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/umts/probable-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/umts/probable-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/umts/probable-engine/contents/{+path}","compare_url":"https://api.github.com/repos/umts/probable-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umts/probable-engine/merges","archive_url":"https://api.github.com/repos/umts/probable-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umts/probable-engine/downloads","issues_url":"https://api.github.com/repos/umts/probable-engine/issues{/number}","pulls_url":"https://api.github.com/repos/umts/probable-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/umts/probable-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/umts/probable-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umts/probable-engine/labels{/name}","releases_url":"https://api.github.com/repos/umts/probable-engine/releases{/id}","deployments_url":"https://api.github.com/repos/umts/probable-engine/deployments","created_at":"2016-02-01T15:25:11Z","updated_at":"2016-07-14T18:17:52Z","pushed_at":"2016-07-28T14:01:46Z","git_url":"git://github.com/umts/probable-engine.git","ssh_url":"git@github.com:umts/probable-engine.git","clone_url":"https://github.com/umts/probable-engine.git","svn_url":"https://github.com/umts/probable-engine","homepage":null,"size":2748,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":31,"forks":10,"open_issues":31,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/umts/probable-engine/pulls/121"},"html":{"href":"https://github.com/umts/probable-engine/pull/121"},"issue":{"href":"https://api.github.com/repos/umts/probable-engine/issues/121"},"comments":{"href":"https://api.github.com/repos/umts/probable-engine/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/umts/probable-engine/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/umts/probable-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/umts/probable-engine/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/umts/probable-engine/statuses/bfb832146794f8fae2736dee043a0624304cbcd9"}}}}
{"actor":{"display_login":"phantompatrol"}}