{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/17473","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/17473/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17473/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/17473/events","html_url":"https://github.com/mantidproject/mantid/pull/17473","id":176451747,"number":17473,"title":"17454 build without ph","user":{"login":"abuts","id":1109606,"avatar_url":"https://avatars.githubusercontent.com/u/1109606?v=3","gravatar_id":"","url":"https://api.github.com/users/abuts","html_url":"https://github.com/abuts","followers_url":"https://api.github.com/users/abuts/followers","following_url":"https://api.github.com/users/abuts/following{/other_user}","gists_url":"https://api.github.com/users/abuts/gists{/gist_id}","starred_url":"https://api.github.com/users/abuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abuts/subscriptions","organizations_url":"https://api.github.com/users/abuts/orgs","repos_url":"https://api.github.com/users/abuts/repos","events_url":"https://api.github.com/users/abuts/events{/privacy}","received_events_url":"https://api.github.com/users/abuts/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Bug","name":"Misc: Bug","color":"d4c5f9"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Easy","name":"Misc: Easy","color":"d4c5f9"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Priority:%20High","name":"Priority: High","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"DavidFair","id":1817032,"avatar_url":"https://avatars.githubusercontent.com/u/1817032?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidFair","html_url":"https://github.com/DavidFair","followers_url":"https://api.github.com/users/DavidFair/followers","following_url":"https://api.github.com/users/DavidFair/following{/other_user}","gists_url":"https://api.github.com/users/DavidFair/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidFair/subscriptions","organizations_url":"https://api.github.com/users/DavidFair/orgs","repos_url":"https://api.github.com/users/DavidFair/repos","events_url":"https://api.github.com/users/DavidFair/events{/privacy}","received_events_url":"https://api.github.com/users/DavidFair/received_events","type":"User","site_admin":false},"assignees":[{"login":"DavidFair","id":1817032,"avatar_url":"https://avatars.githubusercontent.com/u/1817032?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidFair","html_url":"https://github.com/DavidFair","followers_url":"https://api.github.com/users/DavidFair/followers","following_url":"https://api.github.com/users/DavidFair/following{/other_user}","gists_url":"https://api.github.com/users/DavidFair/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidFair/subscriptions","organizations_url":"https://api.github.com/users/DavidFair/orgs","repos_url":"https://api.github.com/users/DavidFair/repos","events_url":"https://api.github.com/users/DavidFair/events{/privacy}","received_events_url":"https://api.github.com/users/DavidFair/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"Code Freeze: 16-Sep-2016\r\nDeveloper & Unscripted Testing: 16-Sep-2016 to 20-Sep-2016\r\nBeta test: 20-Sep-2016 to 04-Oct-2016\r\nRelease Date: 10-Oct-2016","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":694,"closed_issues":802,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-09-13T12:12:59Z","due_on":"2016-10-10T00:00:00Z","closed_at":null},"comments":0,"created_at":"2016-09-12T18:41:07Z","updated_at":"2016-09-13T12:14:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17473","html_url":"https://github.com/mantidproject/mantid/pull/17473","diff_url":"https://github.com/mantidproject/mantid/pull/17473.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17473.patch"},"body":"This should enable building Mantid under windows without precompiled headers enabled. \r\n\r\n**To test:**\r\nTest by code review. Changes are trivial. \r\n\r\nYou probably need windows, VS2015 SP3 to test it properly, then when building with cmake you should disable precompiled headers. Current mantid build fails before changes but you can trust me -- it works after the changes. \r\n\r\n<!-- Instructions for testing. -->\r\n\r\nFixes #17454.\r\n\r\nInternal, no release notes are necessary.\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/246662438","html_url":"https://github.com/mantidproject/mantid/pull/17473#issuecomment-246662438","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17473","id":246662438,"user":{"login":"DavidFair","id":1817032,"avatar_url":"https://avatars.githubusercontent.com/u/1817032?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidFair","html_url":"https://github.com/DavidFair","followers_url":"https://api.github.com/users/DavidFair/followers","following_url":"https://api.github.com/users/DavidFair/following{/other_user}","gists_url":"https://api.github.com/users/DavidFair/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidFair/subscriptions","organizations_url":"https://api.github.com/users/DavidFair/orgs","repos_url":"https://api.github.com/users/DavidFair/repos","events_url":"https://api.github.com/users/DavidFair/events{/privacy}","received_events_url":"https://api.github.com/users/DavidFair/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T12:14:35Z","updated_at":"2016-09-13T12:14:35Z","body":"Builds on Windows 10 with Visual Studio 2015 Update 3 so it resolves the issue. :shipit: "}}
{"actor":{"display_login":"DavidFair"}}