{"action":"created","comment":{"url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/comments/49307218","id":49307218,"diff_hunk":"@@ -512,11 +511,8 @@ def generate_file_rst(fname, target_dir, src_dir, gallery_conf):\n     ref_fname = example_file.replace(os.path.sep, '_')\n     example_rst = \"\"\"\\n\\n.. _sphx_glr_{0}:\\n\\n\"\"\".format(ref_fname)\n \n-    if not fname.startswith('plot') or not gallery_conf['plot_gallery']:\n-        convert_func = dict(code=codestr2rst, text=text2string)\n-        for blabel, bcontent in script_blocks:\n-            example_rst += convert_func[blabel](bcontent) + '\\n'\n-    else:\n+    filename_pattern = gallery_conf.get('filename_pattern')","path":"sphinx_gallery/gen_rst.py","position":26,"original_position":26,"commit_id":"2f737dedf06a4b36e841b5e5f336a922061c710c","original_commit_id":"0bfbfe55d120acebb0acc342755956ab1bbd23bf","user":{"login":"lesteve","id":1680079,"avatar_url":"https://avatars.githubusercontent.com/u/1680079?v=3","gravatar_id":"","url":"https://api.github.com/users/lesteve","html_url":"https://github.com/lesteve","followers_url":"https://api.github.com/users/lesteve/followers","following_url":"https://api.github.com/users/lesteve/following{/other_user}","gists_url":"https://api.github.com/users/lesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/lesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesteve/subscriptions","organizations_url":"https://api.github.com/users/lesteve/orgs","repos_url":"https://api.github.com/users/lesteve/repos","events_url":"https://api.github.com/users/lesteve/events{/privacy}","received_events_url":"https://api.github.com/users/lesteve/received_events","type":"User","site_admin":false},"body":"> For me all the defaults are in the dictionary in gen_gallery.py, one place for everything and only there.\r\nSo no user is forced to change their conf.py if they don't feel to play around the filename_pattern, the plot default is there\r\n\r\nI see I wasn't aware of that at all, sorry. I am not quite sure how gen_gallery.gallery_conf interacts with sphinx_gallery_conf defined in conf.py but I double-check that not having filename_pattern defined in conf.py works file and picks the default one from gen_gallery.gallery_conf.","created_at":"2016-01-11T10:37:19Z","updated_at":"2016-01-11T10:37:19Z","html_url":"https://github.com/sphinx-gallery/sphinx-gallery/pull/85#discussion_r49307218","pull_request_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/comments/49307218"},"html":{"href":"https://github.com/sphinx-gallery/sphinx-gallery/pull/85#discussion_r49307218"},"pull_request":{"href":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/85","id":55326109,"html_url":"https://github.com/sphinx-gallery/sphinx-gallery/pull/85","diff_url":"https://github.com/sphinx-gallery/sphinx-gallery/pull/85.diff","patch_url":"https://github.com/sphinx-gallery/sphinx-gallery/pull/85.patch","issue_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/issues/85","number":85,"state":"open","locked":false,"title":"[MRG+1] execute only examples matching specified pattern","user":{"login":"jasmainak","id":15852194,"avatar_url":"https://avatars.githubusercontent.com/u/15852194?v=3","gravatar_id":"","url":"https://api.github.com/users/jasmainak","html_url":"https://github.com/jasmainak","followers_url":"https://api.github.com/users/jasmainak/followers","following_url":"https://api.github.com/users/jasmainak/following{/other_user}","gists_url":"https://api.github.com/users/jasmainak/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmainak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmainak/subscriptions","organizations_url":"https://api.github.com/users/jasmainak/orgs","repos_url":"https://api.github.com/users/jasmainak/repos","events_url":"https://api.github.com/users/jasmainak/events{/privacy}","received_events_url":"https://api.github.com/users/jasmainak/received_events","type":"User","site_admin":false},"body":"closes https://github.com/sphinx-gallery/sphinx-gallery/issues/82","created_at":"2016-01-07T11:12:00Z","updated_at":"2016-01-11T10:37:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebd11e43a20aaf01db00c2b4421c518529172018","assignee":null,"milestone":{"url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/milestones/1","html_url":"https://github.com/sphinx-gallery/sphinx-gallery/milestones/Release%20v0.0.12","labels_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/milestones/1/labels","id":1477176,"number":1,"title":"Release v0.0.12","description":"","creator":{"login":"Titan-C","id":713451,"avatar_url":"https://avatars.githubusercontent.com/u/713451?v=3","gravatar_id":"","url":"https://api.github.com/users/Titan-C","html_url":"https://github.com/Titan-C","followers_url":"https://api.github.com/users/Titan-C/followers","following_url":"https://api.github.com/users/Titan-C/following{/other_user}","gists_url":"https://api.github.com/users/Titan-C/gists{/gist_id}","starred_url":"https://api.github.com/users/Titan-C/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Titan-C/subscriptions","organizations_url":"https://api.github.com/users/Titan-C/orgs","repos_url":"https://api.github.com/users/Titan-C/repos","events_url":"https://api.github.com/users/Titan-C/events{/privacy}","received_events_url":"https://api.github.com/users/Titan-C/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":2,"state":"open","created_at":"2015-12-29T16:07:19Z","updated_at":"2016-01-11T08:55:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/85/commits","review_comments_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/85/comments","review_comment_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/issues/85/comments","statuses_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/statuses/2f737dedf06a4b36e841b5e5f336a922061c710c","head":{"label":"jasmainak:pattern_examples","ref":"pattern_examples","sha":"2f737dedf06a4b36e841b5e5f336a922061c710c","user":{"login":"jasmainak","id":15852194,"avatar_url":"https://avatars.githubusercontent.com/u/15852194?v=3","gravatar_id":"","url":"https://api.github.com/users/jasmainak","html_url":"https://github.com/jasmainak","followers_url":"https://api.github.com/users/jasmainak/followers","following_url":"https://api.github.com/users/jasmainak/following{/other_user}","gists_url":"https://api.github.com/users/jasmainak/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmainak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmainak/subscriptions","organizations_url":"https://api.github.com/users/jasmainak/orgs","repos_url":"https://api.github.com/users/jasmainak/repos","events_url":"https://api.github.com/users/jasmainak/events{/privacy}","received_events_url":"https://api.github.com/users/jasmainak/received_events","type":"User","site_admin":false},"repo":{"id":49187076,"name":"sphinx-gallery","full_name":"jasmainak/sphinx-gallery","owner":{"login":"jasmainak","id":15852194,"avatar_url":"https://avatars.githubusercontent.com/u/15852194?v=3","gravatar_id":"","url":"https://api.github.com/users/jasmainak","html_url":"https://github.com/jasmainak","followers_url":"https://api.github.com/users/jasmainak/followers","following_url":"https://api.github.com/users/jasmainak/following{/other_user}","gists_url":"https://api.github.com/users/jasmainak/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmainak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmainak/subscriptions","organizations_url":"https://api.github.com/users/jasmainak/orgs","repos_url":"https://api.github.com/users/jasmainak/repos","events_url":"https://api.github.com/users/jasmainak/events{/privacy}","received_events_url":"https://api.github.com/users/jasmainak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasmainak/sphinx-gallery","description":"Sphinx extension for automatic generation of an example gallery","fork":true,"url":"https://api.github.com/repos/jasmainak/sphinx-gallery","forks_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/forks","keys_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/teams","hooks_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/hooks","issue_events_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/issues/events{/number}","events_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/events","assignees_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/assignees{/user}","branches_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/branches{/branch}","tags_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/tags","blobs_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/statuses/{sha}","languages_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/languages","stargazers_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/stargazers","contributors_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/contributors","subscribers_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/subscribers","subscription_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/subscription","commits_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/contents/{+path}","compare_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/merges","archive_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/downloads","issues_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/issues{/number}","pulls_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/pulls{/number}","milestones_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/milestones{/number}","notifications_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/labels{/name}","releases_url":"https://api.github.com/repos/jasmainak/sphinx-gallery/releases{/id}","created_at":"2016-01-07T06:51:33Z","updated_at":"2016-01-07T06:51:34Z","pushed_at":"2016-01-11T09:56:43Z","git_url":"git://github.com/jasmainak/sphinx-gallery.git","ssh_url":"git@github.com:jasmainak/sphinx-gallery.git","clone_url":"https://github.com/jasmainak/sphinx-gallery.git","svn_url":"https://github.com/jasmainak/sphinx-gallery","homepage":"http://sphinx-gallery.readthedocs.org","size":534,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sphinx-gallery:master","ref":"master","sha":"b0a75118d34642d12c8485f153f8bfad7040f02d","user":{"login":"sphinx-gallery","id":9541799,"avatar_url":"https://avatars.githubusercontent.com/u/9541799?v=3","gravatar_id":"","url":"https://api.github.com/users/sphinx-gallery","html_url":"https://github.com/sphinx-gallery","followers_url":"https://api.github.com/users/sphinx-gallery/followers","following_url":"https://api.github.com/users/sphinx-gallery/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-gallery/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-gallery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-gallery/subscriptions","organizations_url":"https://api.github.com/users/sphinx-gallery/orgs","repos_url":"https://api.github.com/users/sphinx-gallery/repos","events_url":"https://api.github.com/users/sphinx-gallery/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-gallery/received_events","type":"Organization","site_admin":false},"repo":{"id":25860190,"name":"sphinx-gallery","full_name":"sphinx-gallery/sphinx-gallery","owner":{"login":"sphinx-gallery","id":9541799,"avatar_url":"https://avatars.githubusercontent.com/u/9541799?v=3","gravatar_id":"","url":"https://api.github.com/users/sphinx-gallery","html_url":"https://github.com/sphinx-gallery","followers_url":"https://api.github.com/users/sphinx-gallery/followers","following_url":"https://api.github.com/users/sphinx-gallery/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-gallery/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-gallery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-gallery/subscriptions","organizations_url":"https://api.github.com/users/sphinx-gallery/orgs","repos_url":"https://api.github.com/users/sphinx-gallery/repos","events_url":"https://api.github.com/users/sphinx-gallery/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-gallery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphinx-gallery/sphinx-gallery","description":"Sphinx extension for automatic generation of an example gallery","fork":false,"url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery","forks_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/forks","keys_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/teams","hooks_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/hooks","issue_events_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/issues/events{/number}","events_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/events","assignees_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/assignees{/user}","branches_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/branches{/branch}","tags_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/tags","blobs_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/statuses/{sha}","languages_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/languages","stargazers_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/stargazers","contributors_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/contributors","subscribers_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/subscribers","subscription_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/subscription","commits_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/contents/{+path}","compare_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/merges","archive_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/downloads","issues_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/issues{/number}","pulls_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls{/number}","milestones_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/milestones{/number}","notifications_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/labels{/name}","releases_url":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/releases{/id}","created_at":"2014-10-28T08:41:46Z","updated_at":"2016-01-11T08:55:16Z","pushed_at":"2016-01-11T09:56:43Z","git_url":"git://github.com/sphinx-gallery/sphinx-gallery.git","ssh_url":"git@github.com:sphinx-gallery/sphinx-gallery.git","clone_url":"https://github.com/sphinx-gallery/sphinx-gallery.git","svn_url":"https://github.com/sphinx-gallery/sphinx-gallery","homepage":"http://sphinx-gallery.readthedocs.org","size":604,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":25,"forks":12,"open_issues":25,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/85"},"html":{"href":"https://github.com/sphinx-gallery/sphinx-gallery/pull/85"},"issue":{"href":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/issues/85"},"comments":{"href":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/sphinx-gallery/sphinx-gallery/statuses/2f737dedf06a4b36e841b5e5f336a922061c710c"}}}}