{"action":"created","issue":{"url":"https://api.github.com/repos/astropy/astropy/issues/4952","repository_url":"https://api.github.com/repos/astropy/astropy","labels_url":"https://api.github.com/repos/astropy/astropy/issues/4952/labels{/name}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/4952/comments","events_url":"https://api.github.com/repos/astropy/astropy/issues/4952/events","html_url":"https://github.com/astropy/astropy/pull/4952","id":155670039,"number":4952,"title":"fixed bugs in get_sun","user":{"login":"StuartLittlefair","id":4570807,"avatar_url":"https://avatars.githubusercontent.com/u/4570807?v=3","gravatar_id":"","url":"https://api.github.com/users/StuartLittlefair","html_url":"https://github.com/StuartLittlefair","followers_url":"https://api.github.com/users/StuartLittlefair/followers","following_url":"https://api.github.com/users/StuartLittlefair/following{/other_user}","gists_url":"https://api.github.com/users/StuartLittlefair/gists{/gist_id}","starred_url":"https://api.github.com/users/StuartLittlefair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StuartLittlefair/subscriptions","organizations_url":"https://api.github.com/users/StuartLittlefair/orgs","repos_url":"https://api.github.com/users/StuartLittlefair/repos","events_url":"https://api.github.com/users/StuartLittlefair/events{/privacy}","received_events_url":"https://api.github.com/users/StuartLittlefair/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/astropy/astropy/labels/Bug","name":"Bug","color":"eb6420"},{"url":"https://api.github.com/repos/astropy/astropy/labels/coordinates","name":"coordinates","color":"c7def8"},{"url":"https://api.github.com/repos/astropy/astropy/labels/Work%20in%20progress","name":"Work in progress","color":"f9d0c4"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/36","html_url":"https://github.com/astropy/astropy/milestones/v1.0.10","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/36/labels","id":1635680,"number":36,"title":"v1.0.10","description":"","creator":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?v=3","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":11,"state":"open","created_at":"2016-03-10T03:38:10Z","updated_at":"2016-05-19T15:45:15Z","due_on":null,"closed_at":null},"comments":30,"created_at":"2016-05-19T07:24:17Z","updated_at":"2016-05-25T13:37:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/4952","html_url":"https://github.com/astropy/astropy/pull/4952","diff_url":"https://github.com/astropy/astropy/pull/4952.diff","patch_url":"https://github.com/astropy/astropy/pull/4952.patch"},"body":"@mhvk spotted a discrepancy between the coordinates reported by ```get_sun``` and the JPL ephemerides in #4920.\r\n\r\nThis discrepancy is predominantly caused by using the incorrect units for velocity in the call to ```erfa.ab```. In addition, the velocity had an incorrect sign and should have been the barycentric, not heliocentric velocity. \r\n\r\nThe routine now returns positions accurate to ~0.15 arcsec and 100 km compared to the JPL ephemerides, over the time range CE 1950 to 2050.\r\n\r\nOne problem I haven't been able to understand is that these changes cause the tests to fail at [this function](https://github.com/astropy/astropy/blob/master/astropy/coordinates/tests/test_intermediate_transformations.py#L326). \r\n\r\nI think the failure is something to do with the GCRS-ICRS transforms. For other bodies, the roundtrip GCRS-ICRS-GCRS ends back where it started. For the Sun it does not; however I'm not sure why. This test is now failing because the position returned by ```get_sun``` is now close enough to the Sun to fall foul of this."},"comment":{"url":"https://api.github.com/repos/astropy/astropy/issues/comments/221578315","html_url":"https://github.com/astropy/astropy/pull/4952#issuecomment-221578315","issue_url":"https://api.github.com/repos/astropy/astropy/issues/4952","id":221578315,"user":{"login":"mhvk","id":2789820,"avatar_url":"https://avatars.githubusercontent.com/u/2789820?v=3","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T13:37:23Z","updated_at":"2016-05-25T13:37:23Z","body":"@StuartLittlefair - I'm confused -- I thought the spherical routines had already been made available in #4571"}}
{"actor":{"display_login":"mhvk"}}