{"action":"created","issue":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3296","repository_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite","labels_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3296/labels{/name}","comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3296/comments","events_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3296/events","html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/3296","id":171782583,"number":3296,"title":"`await` all long-running async tasks kicked off in `go()`","user":{"login":"erikdesjardins","id":7673145,"avatar_url":"https://avatars.githubusercontent.com/u/7673145?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdesjardins","html_url":"https://github.com/erikdesjardins","followers_url":"https://api.github.com/users/erikdesjardins/followers","following_url":"https://api.github.com/users/erikdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/erikdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdesjardins/subscriptions","organizations_url":"https://api.github.com/users/erikdesjardins/orgs","repos_url":"https://api.github.com/users/erikdesjardins/repos","events_url":"https://api.github.com/users/erikdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/erikdesjardins/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/labels/RE-Housekeeping","name":"RE-Housekeeping","color":"DDDDDD"}],"state":"open","locked":false,"assignee":{"login":"erikdesjardins","id":7673145,"avatar_url":"https://avatars.githubusercontent.com/u/7673145?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdesjardins","html_url":"https://github.com/erikdesjardins","followers_url":"https://api.github.com/users/erikdesjardins/followers","following_url":"https://api.github.com/users/erikdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/erikdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdesjardins/subscriptions","organizations_url":"https://api.github.com/users/erikdesjardins/orgs","repos_url":"https://api.github.com/users/erikdesjardins/repos","events_url":"https://api.github.com/users/erikdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/erikdesjardins/received_events","type":"User","site_admin":false},"assignees":[{"login":"erikdesjardins","id":7673145,"avatar_url":"https://avatars.githubusercontent.com/u/7673145?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdesjardins","html_url":"https://github.com/erikdesjardins","followers_url":"https://api.github.com/users/erikdesjardins/followers","following_url":"https://api.github.com/users/erikdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/erikdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdesjardins/subscriptions","organizations_url":"https://api.github.com/users/erikdesjardins/orgs","repos_url":"https://api.github.com/users/erikdesjardins/repos","events_url":"https://api.github.com/users/erikdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/erikdesjardins/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/milestones/3","html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/milestones/Future","labels_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/milestones/3/labels","id":287262,"number":3,"title":"Future","description":"For things we definitely want to fix, but haven't yet decided when.","creator":{"login":"andytuba","id":455632,"avatar_url":"https://avatars.githubusercontent.com/u/455632?v=3","gravatar_id":"","url":"https://api.github.com/users/andytuba","html_url":"https://github.com/andytuba","followers_url":"https://api.github.com/users/andytuba/followers","following_url":"https://api.github.com/users/andytuba/following{/other_user}","gists_url":"https://api.github.com/users/andytuba/gists{/gist_id}","starred_url":"https://api.github.com/users/andytuba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andytuba/subscriptions","organizations_url":"https://api.github.com/users/andytuba/orgs","repos_url":"https://api.github.com/users/andytuba/repos","events_url":"https://api.github.com/users/andytuba/events{/privacy}","received_events_url":"https://api.github.com/users/andytuba/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":10,"state":"open","created_at":"2013-03-12T23:33:06Z","updated_at":"2016-08-17T23:14:55Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-08-17T23:13:58Z","updated_at":"2016-08-18T01:47:46Z","closed_at":null,"body":"...especially `forEachChunked`, for more accurate profiling.\r\n\r\nWe don't want to do this for `beforeLoad`, because that stage should complete as soon as possible (so `go` can run), but we don't care if `afterLoad` is arbitrarily delayed (it's unimportant).\r\n\r\nre #3295"},"comment":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/comments/240601353","html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues/3296#issuecomment-240601353","issue_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3296","id":240601353,"user":{"login":"erikdesjardins","id":7673145,"avatar_url":"https://avatars.githubusercontent.com/u/7673145?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdesjardins","html_url":"https://github.com/erikdesjardins","followers_url":"https://api.github.com/users/erikdesjardins/followers","following_url":"https://api.github.com/users/erikdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/erikdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdesjardins/subscriptions","organizations_url":"https://api.github.com/users/erikdesjardins/orgs","repos_url":"https://api.github.com/users/erikdesjardins/repos","events_url":"https://api.github.com/users/erikdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/erikdesjardins/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T01:47:46Z","updated_at":"2016-08-18T01:47:46Z","body":"Sort of; #3297 is specifically intended to improve performance, but most changes for this issue won't change performance, they'll just make it easier to profile.\r\n\r\nFor example, something like [this](https://github.com/honestbleeps/Reddit-Enhancement-Suite/blob/6a5b2870f395c7daa55e83a236161d2a398e8d7f/lib/modules/xPostLinks.js#L65) is not `await`ed, a profile shows xPostLinks doing very little work. If it (and every function up the chain to `go`) were `awaited`, the performance would be the same, but we'd be able to see it."}}
{"actor":{"display_login":"erikdesjardins"}}