{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/89994859","pull_request_review_id":10519765,"id":89994859,"diff_hunk":"@@ -349,6 +361,29 @@ static int device_setup_unit(Manager *m, struct udev_device *dev, const char *pa\n                         (void) device_add_udev_wants(u, dev);\n         }\n \n+        DEVICE(u)->bind_mounts = device_is_bound_by_mounts(dev);","path":"src/core/device.c","position":null,"original_position":23,"commit_id":"58bcc2e5c2d2194e729b3334ddd8bb365c87ca6f","original_commit_id":"a79db02b4e6afbe4f8eb8a1e9799fc04b0a73e0a","user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars.githubusercontent.com/u/2130732?v=3","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"body":"hmm, you have a point maybe, but in that case I think the caching should be hidden in device_is_bound_by_mounts()","created_at":"2016-11-29T11:57:17Z","updated_at":"2016-11-29T11:57:17Z","html_url":"https://github.com/systemd/systemd/pull/4515#discussion_r89994859","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/4515","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/89994859"},"html":{"href":"https://github.com/systemd/systemd/pull/4515#discussion_r89994859"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4515"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/4515","id":91394856,"html_url":"https://github.com/systemd/systemd/pull/4515","diff_url":"https://github.com/systemd/systemd/pull/4515.diff","patch_url":"https://github.com/systemd/systemd/pull/4515.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/4515","number":4515,"state":"open","locked":false,"title":"cdrom_id: try unmounting the media (if mounted) before ejecting it","user":{"login":"fbuihuu","id":251384,"avatar_url":"https://avatars.githubusercontent.com/u/251384?v=3","gravatar_id":"","url":"https://api.github.com/users/fbuihuu","html_url":"https://github.com/fbuihuu","followers_url":"https://api.github.com/users/fbuihuu/followers","following_url":"https://api.github.com/users/fbuihuu/following{/other_user}","gists_url":"https://api.github.com/users/fbuihuu/gists{/gist_id}","starred_url":"https://api.github.com/users/fbuihuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbuihuu/subscriptions","organizations_url":"https://api.github.com/users/fbuihuu/orgs","repos_url":"https://api.github.com/users/fbuihuu/repos","events_url":"https://api.github.com/users/fbuihuu/events{/privacy}","received_events_url":"https://api.github.com/users/fbuihuu/received_events","type":"User","site_admin":false},"body":"Since commit 9d06297e2629, systemd doesn't automatically unmount paths where\nthe device has been mounted even if the device unit is tagget as inactive (via\nSYSTEMD_READY=0).\n\nThis patch teaches 'cdrom_id' to unmount itself all paths before ejecting the\nmedia as it was the case before commit 9d06297e2629.\n","created_at":"2016-10-28T14:47:26Z","updated_at":"2016-11-29T11:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d952ce6581886ce835bae83b163ce3b477fa638","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/4515/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/4515/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/4515/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/58bcc2e5c2d2194e729b3334ddd8bb365c87ca6f","head":{"label":"fbuihuu:possibly-umount-cdrom-when-ejecting","ref":"possibly-umount-cdrom-when-ejecting","sha":"58bcc2e5c2d2194e729b3334ddd8bb365c87ca6f","user":{"login":"fbuihuu","id":251384,"avatar_url":"https://avatars.githubusercontent.com/u/251384?v=3","gravatar_id":"","url":"https://api.github.com/users/fbuihuu","html_url":"https://github.com/fbuihuu","followers_url":"https://api.github.com/users/fbuihuu/followers","following_url":"https://api.github.com/users/fbuihuu/following{/other_user}","gists_url":"https://api.github.com/users/fbuihuu/gists{/gist_id}","starred_url":"https://api.github.com/users/fbuihuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbuihuu/subscriptions","organizations_url":"https://api.github.com/users/fbuihuu/orgs","repos_url":"https://api.github.com/users/fbuihuu/repos","events_url":"https://api.github.com/users/fbuihuu/events{/privacy}","received_events_url":"https://api.github.com/users/fbuihuu/received_events","type":"User","site_admin":false},"repo":{"id":43303412,"name":"systemd","full_name":"fbuihuu/systemd","owner":{"login":"fbuihuu","id":251384,"avatar_url":"https://avatars.githubusercontent.com/u/251384?v=3","gravatar_id":"","url":"https://api.github.com/users/fbuihuu","html_url":"https://github.com/fbuihuu","followers_url":"https://api.github.com/users/fbuihuu/followers","following_url":"https://api.github.com/users/fbuihuu/following{/other_user}","gists_url":"https://api.github.com/users/fbuihuu/gists{/gist_id}","starred_url":"https://api.github.com/users/fbuihuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbuihuu/subscriptions","organizations_url":"https://api.github.com/users/fbuihuu/orgs","repos_url":"https://api.github.com/users/fbuihuu/repos","events_url":"https://api.github.com/users/fbuihuu/events{/privacy}","received_events_url":"https://api.github.com/users/fbuihuu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbuihuu/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/fbuihuu/systemd","forks_url":"https://api.github.com/repos/fbuihuu/systemd/forks","keys_url":"https://api.github.com/repos/fbuihuu/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbuihuu/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbuihuu/systemd/teams","hooks_url":"https://api.github.com/repos/fbuihuu/systemd/hooks","issue_events_url":"https://api.github.com/repos/fbuihuu/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/fbuihuu/systemd/events","assignees_url":"https://api.github.com/repos/fbuihuu/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/fbuihuu/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/fbuihuu/systemd/tags","blobs_url":"https://api.github.com/repos/fbuihuu/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbuihuu/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbuihuu/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbuihuu/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbuihuu/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/fbuihuu/systemd/languages","stargazers_url":"https://api.github.com/repos/fbuihuu/systemd/stargazers","contributors_url":"https://api.github.com/repos/fbuihuu/systemd/contributors","subscribers_url":"https://api.github.com/repos/fbuihuu/systemd/subscribers","subscription_url":"https://api.github.com/repos/fbuihuu/systemd/subscription","commits_url":"https://api.github.com/repos/fbuihuu/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbuihuu/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbuihuu/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbuihuu/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbuihuu/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/fbuihuu/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbuihuu/systemd/merges","archive_url":"https://api.github.com/repos/fbuihuu/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbuihuu/systemd/downloads","issues_url":"https://api.github.com/repos/fbuihuu/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/fbuihuu/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/fbuihuu/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/fbuihuu/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbuihuu/systemd/labels{/name}","releases_url":"https://api.github.com/repos/fbuihuu/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/fbuihuu/systemd/deployments","created_at":"2015-09-28T13:44:04Z","updated_at":"2016-02-25T09:44:48Z","pushed_at":"2016-11-29T08:43:10Z","git_url":"git://github.com/fbuihuu/systemd.git","ssh_url":"git@github.com:fbuihuu/systemd.git","clone_url":"https://github.com/fbuihuu/systemd.git","svn_url":"https://github.com/fbuihuu/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":63537,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"920ec31b5ffeb8695bef68e0dc082c0fc22965d3","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd upstream","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2016-11-29T07:20:26Z","pushed_at":"2016-11-29T11:20:11Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":77916,"stargazers_count":1483,"watchers_count":1483,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":635,"mirror_url":null,"open_issues_count":521,"forks":635,"open_issues":521,"watchers":1483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4515"},"html":{"href":"https://github.com/systemd/systemd/pull/4515"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/4515"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/4515/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4515/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4515/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/58bcc2e5c2d2194e729b3334ddd8bb365c87ca6f"}}}}
{"actor":{"display_login":"poettering"}}