{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/73279543","id":73279543,"diff_hunk":"@@ -13,7 +13,7 @@\n         the .NET Framework directory and thus will no longer be the right answer. Override it to point\n         to the correct .NET Framework location. --> \n    <PropertyGroup>\n-      <XamlBuildTaskPath Condition=\"'$(XamlBuildTaskPath)' == ''\">$(MSBuildFrameworkToolsPath)</XamlBuildTaskPath>\n+      <XamlBuildTaskPath Condition=\"'$(XamlBuildTaskPath)' == ''\">$(MSBuildToolsPath)</XamlBuildTaskPath>","path":"src/XMakeTasks/Microsoft.Xaml.targets","position":5,"original_position":5,"commit_id":"fdc51b138a732ef7e203e01903fa04bdbaf146b9","original_commit_id":"fdc51b138a732ef7e203e01903fa04bdbaf146b9","user":{"login":"AndyGerlicher","id":9847849,"avatar_url":"https://avatars.githubusercontent.com/u/9847849?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyGerlicher","html_url":"https://github.com/AndyGerlicher","followers_url":"https://api.github.com/users/AndyGerlicher/followers","following_url":"https://api.github.com/users/AndyGerlicher/following{/other_user}","gists_url":"https://api.github.com/users/AndyGerlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyGerlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyGerlicher/subscriptions","organizations_url":"https://api.github.com/users/AndyGerlicher/orgs","repos_url":"https://api.github.com/users/AndyGerlicher/repos","events_url":"https://api.github.com/users/AndyGerlicher/events{/privacy}","received_events_url":"https://api.github.com/users/AndyGerlicher/received_events","type":"User","site_admin":false},"body":"This doesn't quite make sense. This property would be `$(MSBuildToolsPath)\\Microsoft.Xaml.targets` which when deployed and executing is _this_ file. If this file + that DLL is going to come from the VS installer, I don't think there's any change needed to this file. Ideally this could come from a NuGet package so we could enable this scenario outside of VS. But I'm fine if that's not the case for now.","created_at":"2016-08-03T04:35:47Z","updated_at":"2016-08-03T04:35:47Z","html_url":"https://github.com/Microsoft/msbuild/pull/856#discussion_r73279543","pull_request_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/856","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/73279543"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/856#discussion_r73279543"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/856"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/856","id":79830535,"html_url":"https://github.com/Microsoft/msbuild/pull/856","diff_url":"https://github.com/Microsoft/msbuild/pull/856.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/856.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/856","number":856,"state":"open","locked":false,"title":"Updates to support XamlBuildTask","user":{"login":"dmetzgar","id":2986365,"avatar_url":"https://avatars.githubusercontent.com/u/2986365?v=3","gravatar_id":"","url":"https://api.github.com/users/dmetzgar","html_url":"https://github.com/dmetzgar","followers_url":"https://api.github.com/users/dmetzgar/followers","following_url":"https://api.github.com/users/dmetzgar/following{/other_user}","gists_url":"https://api.github.com/users/dmetzgar/gists{/gist_id}","starred_url":"https://api.github.com/users/dmetzgar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmetzgar/subscriptions","organizations_url":"https://api.github.com/users/dmetzgar/orgs","repos_url":"https://api.github.com/users/dmetzgar/repos","events_url":"https://api.github.com/users/dmetzgar/events{/privacy}","received_events_url":"https://api.github.com/users/dmetzgar/received_events","type":"User","site_admin":false},"body":"Modifies the Microsoft.Xaml.targets shim to use a local copy of XamlBuildTask.dll. Applies a binding redirect to msbuild process to use the 15.1 version of XamlBuildTask (the local copy) instead of the 4.0 version (the GAC copy).","created_at":"2016-08-03T00:20:03Z","updated_at":"2016-08-03T04:35:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0ea70a49fcfbc6325366d0d4a8e9219efdfa443","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/856/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/856/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/856/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/fdc51b138a732ef7e203e01903fa04bdbaf146b9","head":{"label":"dmetzgar:master","ref":"master","sha":"fdc51b138a732ef7e203e01903fa04bdbaf146b9","user":{"login":"dmetzgar","id":2986365,"avatar_url":"https://avatars.githubusercontent.com/u/2986365?v=3","gravatar_id":"","url":"https://api.github.com/users/dmetzgar","html_url":"https://github.com/dmetzgar","followers_url":"https://api.github.com/users/dmetzgar/followers","following_url":"https://api.github.com/users/dmetzgar/following{/other_user}","gists_url":"https://api.github.com/users/dmetzgar/gists{/gist_id}","starred_url":"https://api.github.com/users/dmetzgar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmetzgar/subscriptions","organizations_url":"https://api.github.com/users/dmetzgar/orgs","repos_url":"https://api.github.com/users/dmetzgar/repos","events_url":"https://api.github.com/users/dmetzgar/events{/privacy}","received_events_url":"https://api.github.com/users/dmetzgar/received_events","type":"User","site_admin":false},"repo":{"id":64800661,"name":"msbuild","full_name":"dmetzgar/msbuild","owner":{"login":"dmetzgar","id":2986365,"avatar_url":"https://avatars.githubusercontent.com/u/2986365?v=3","gravatar_id":"","url":"https://api.github.com/users/dmetzgar","html_url":"https://github.com/dmetzgar","followers_url":"https://api.github.com/users/dmetzgar/followers","following_url":"https://api.github.com/users/dmetzgar/following{/other_user}","gists_url":"https://api.github.com/users/dmetzgar/gists{/gist_id}","starred_url":"https://api.github.com/users/dmetzgar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmetzgar/subscriptions","organizations_url":"https://api.github.com/users/dmetzgar/orgs","repos_url":"https://api.github.com/users/dmetzgar/repos","events_url":"https://api.github.com/users/dmetzgar/events{/privacy}","received_events_url":"https://api.github.com/users/dmetzgar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmetzgar/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/dmetzgar/msbuild","forks_url":"https://api.github.com/repos/dmetzgar/msbuild/forks","keys_url":"https://api.github.com/repos/dmetzgar/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmetzgar/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmetzgar/msbuild/teams","hooks_url":"https://api.github.com/repos/dmetzgar/msbuild/hooks","issue_events_url":"https://api.github.com/repos/dmetzgar/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/dmetzgar/msbuild/events","assignees_url":"https://api.github.com/repos/dmetzgar/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/dmetzgar/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/dmetzgar/msbuild/tags","blobs_url":"https://api.github.com/repos/dmetzgar/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmetzgar/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmetzgar/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmetzgar/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmetzgar/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/dmetzgar/msbuild/languages","stargazers_url":"https://api.github.com/repos/dmetzgar/msbuild/stargazers","contributors_url":"https://api.github.com/repos/dmetzgar/msbuild/contributors","subscribers_url":"https://api.github.com/repos/dmetzgar/msbuild/subscribers","subscription_url":"https://api.github.com/repos/dmetzgar/msbuild/subscription","commits_url":"https://api.github.com/repos/dmetzgar/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmetzgar/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmetzgar/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmetzgar/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmetzgar/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/dmetzgar/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmetzgar/msbuild/merges","archive_url":"https://api.github.com/repos/dmetzgar/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmetzgar/msbuild/downloads","issues_url":"https://api.github.com/repos/dmetzgar/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/dmetzgar/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/dmetzgar/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/dmetzgar/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmetzgar/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/dmetzgar/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/dmetzgar/msbuild/deployments","created_at":"2016-08-03T00:04:12Z","updated_at":"2016-08-03T00:04:16Z","pushed_at":"2016-08-03T00:18:42Z","git_url":"git://github.com/dmetzgar/msbuild.git","ssh_url":"git@github.com:dmetzgar/msbuild.git","clone_url":"https://github.com/dmetzgar/msbuild.git","svn_url":"https://github.com/dmetzgar/msbuild","homepage":null,"size":11047,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"eb80f26c82a01646f57c4740e7125364692a28d3","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"name":"msbuild","full_name":"Microsoft/msbuild","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2016-08-03T01:25:37Z","pushed_at":"2016-08-03T01:50:41Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":13942,"stargazers_count":2666,"watchers_count":2666,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":529,"mirror_url":null,"open_issues_count":261,"forks":529,"open_issues":261,"watchers":2666,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/856"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/856"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/856"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/856/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/856/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/856/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/fdc51b138a732ef7e203e01903fa04bdbaf146b9"}}}}
{"actor":{"display_login":"AndyGerlicher"}}