{"action":"closed","issue":{"url":"https://api.github.com/repos/OpenBCI/openbci-js-sdk/issues/23","labels_url":"https://api.github.com/repos/OpenBCI/openbci-js-sdk/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/OpenBCI/openbci-js-sdk/issues/23/comments","events_url":"https://api.github.com/repos/OpenBCI/openbci-js-sdk/issues/23/events","html_url":"https://github.com/OpenBCI/openbci-js-sdk/issues/23","id":128620438,"number":23,"title":"startStream does not return promise","user":{"login":"andyh616","id":6596567,"avatar_url":"https://avatars.githubusercontent.com/u/6596567?v=3","gravatar_id":"","url":"https://api.github.com/users/andyh616","html_url":"https://github.com/andyh616","followers_url":"https://api.github.com/users/andyh616/followers","following_url":"https://api.github.com/users/andyh616/following{/other_user}","gists_url":"https://api.github.com/users/andyh616/gists{/gist_id}","starred_url":"https://api.github.com/users/andyh616/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyh616/subscriptions","organizations_url":"https://api.github.com/users/andyh616/orgs","repos_url":"https://api.github.com/users/andyh616/repos","events_url":"https://api.github.com/users/andyh616/events{/privacy}","received_events_url":"https://api.github.com/users/andyh616/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-01-25T19:42:49Z","updated_at":"2016-01-27T17:35:29Z","closed_at":"2016-01-27T17:35:29Z","body":"The documentation says this should return a promise but is just writes a value to the board.  Should we make this a promise or change the comments?  If it's possible that the command won't work occasionally, we should probably return a promise.\r\n\r\n```\r\n    /**\r\n     * Purpose: Sends a start streaming command to the board.\r\n     * @returns {Promise} indicating if the signal was able to be sent.\r\n     * Note: You must have successfully connected to an OpenBCI board using the connect\r\n     *           method. Just because the signal was able to be sent to the board, does not\r\n     *           mean the board will start streaming.\r\n     * Author: AJ Keller (@pushtheworldllc)\r\n     */\r\n    OpenBCIBoard.prototype.streamStart = function() {\r\n        this.streaming = true;\r\n        this._reset();\r\n        return this.write(k.OBCIStreamStart);\r\n    };\r\n\r\n    /**\r\n     * Purpose: Sends a stop streaming command to the board.\r\n     * @returns {Promise} indicating if the signal was able to be sent.\r\n     * Note: You must have successfully connected to an OpenBCI board using the connect\r\n     *           method. Just because the signal was able to be sent to the board, does not\r\n     *           mean the board stopped streaming.\r\n     * Author: AJ Keller (@pushtheworldllc)\r\n     */\r\n    OpenBCIBoard.prototype.streamStop = function() {\r\n        this.streaming = false;\r\n        return this.write(k.OBCIStreamStop);\r\n    };\r\n```"}}