{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/mapbox/feature-filter/pulls/9","id":57406228,"html_url":"https://github.com/mapbox/feature-filter/pull/9","diff_url":"https://github.com/mapbox/feature-filter/pull/9.diff","patch_url":"https://github.com/mapbox/feature-filter/pull/9.patch","issue_url":"https://api.github.com/repos/mapbox/feature-filter/issues/9","number":9,"state":"closed","locked":false,"title":"Change 'in' (and '!in') filter to work with a hash for performance.","user":{"login":"dcervelli","id":1100312,"avatar_url":"https://avatars.githubusercontent.com/u/1100312?v=3","gravatar_id":"","url":"https://api.github.com/users/dcervelli","html_url":"https://github.com/dcervelli","followers_url":"https://api.github.com/users/dcervelli/followers","following_url":"https://api.github.com/users/dcervelli/following{/other_user}","gists_url":"https://api.github.com/users/dcervelli/gists{/gist_id}","starred_url":"https://api.github.com/users/dcervelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcervelli/subscriptions","organizations_url":"https://api.github.com/users/dcervelli/orgs","repos_url":"https://api.github.com/users/dcervelli/repos","events_url":"https://api.github.com/users/dcervelli/events{/privacy}","received_events_url":"https://api.github.com/users/dcervelli/received_events","type":"User","site_admin":false},"body":"The 'in' filter was previously chaining if statements leading to\r\nO(n*m) running time if using the returned filter function while\r\niterating over a list of n features with m items in the filter.\r\n\r\nThis change puts the 'in' arguments into a simple javascript hash\r\nfor O(n) time.","created_at":"2016-01-27T19:02:46Z","updated_at":"2016-01-29T16:56:43Z","closed_at":"2016-01-29T16:56:43Z","merged_at":null,"merge_commit_sha":"473bbc300969a96fbae77b87ec46b4e381cd4fcd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/feature-filter/pulls/9/commits","review_comments_url":"https://api.github.com/repos/mapbox/feature-filter/pulls/9/comments","review_comment_url":"https://api.github.com/repos/mapbox/feature-filter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/feature-filter/issues/9/comments","statuses_url":"https://api.github.com/repos/mapbox/feature-filter/statuses/2054d4078b63500445efe65beaabc15388d5a503","head":{"label":"dcervelli:in-as-set","ref":"in-as-set","sha":"2054d4078b63500445efe65beaabc15388d5a503","user":{"login":"dcervelli","id":1100312,"avatar_url":"https://avatars.githubusercontent.com/u/1100312?v=3","gravatar_id":"","url":"https://api.github.com/users/dcervelli","html_url":"https://github.com/dcervelli","followers_url":"https://api.github.com/users/dcervelli/followers","following_url":"https://api.github.com/users/dcervelli/following{/other_user}","gists_url":"https://api.github.com/users/dcervelli/gists{/gist_id}","starred_url":"https://api.github.com/users/dcervelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcervelli/subscriptions","organizations_url":"https://api.github.com/users/dcervelli/orgs","repos_url":"https://api.github.com/users/dcervelli/repos","events_url":"https://api.github.com/users/dcervelli/events{/privacy}","received_events_url":"https://api.github.com/users/dcervelli/received_events","type":"User","site_admin":false},"repo":{"id":50491829,"name":"feature-filter","full_name":"dcervelli/feature-filter","owner":{"login":"dcervelli","id":1100312,"avatar_url":"https://avatars.githubusercontent.com/u/1100312?v=3","gravatar_id":"","url":"https://api.github.com/users/dcervelli","html_url":"https://github.com/dcervelli","followers_url":"https://api.github.com/users/dcervelli/followers","following_url":"https://api.github.com/users/dcervelli/following{/other_user}","gists_url":"https://api.github.com/users/dcervelli/gists{/gist_id}","starred_url":"https://api.github.com/users/dcervelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcervelli/subscriptions","organizations_url":"https://api.github.com/users/dcervelli/orgs","repos_url":"https://api.github.com/users/dcervelli/repos","events_url":"https://api.github.com/users/dcervelli/events{/privacy}","received_events_url":"https://api.github.com/users/dcervelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcervelli/feature-filter","description":"Creates filtering function for vector tile features","fork":true,"url":"https://api.github.com/repos/dcervelli/feature-filter","forks_url":"https://api.github.com/repos/dcervelli/feature-filter/forks","keys_url":"https://api.github.com/repos/dcervelli/feature-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcervelli/feature-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcervelli/feature-filter/teams","hooks_url":"https://api.github.com/repos/dcervelli/feature-filter/hooks","issue_events_url":"https://api.github.com/repos/dcervelli/feature-filter/issues/events{/number}","events_url":"https://api.github.com/repos/dcervelli/feature-filter/events","assignees_url":"https://api.github.com/repos/dcervelli/feature-filter/assignees{/user}","branches_url":"https://api.github.com/repos/dcervelli/feature-filter/branches{/branch}","tags_url":"https://api.github.com/repos/dcervelli/feature-filter/tags","blobs_url":"https://api.github.com/repos/dcervelli/feature-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcervelli/feature-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcervelli/feature-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcervelli/feature-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcervelli/feature-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/dcervelli/feature-filter/languages","stargazers_url":"https://api.github.com/repos/dcervelli/feature-filter/stargazers","contributors_url":"https://api.github.com/repos/dcervelli/feature-filter/contributors","subscribers_url":"https://api.github.com/repos/dcervelli/feature-filter/subscribers","subscription_url":"https://api.github.com/repos/dcervelli/feature-filter/subscription","commits_url":"https://api.github.com/repos/dcervelli/feature-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcervelli/feature-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcervelli/feature-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcervelli/feature-filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcervelli/feature-filter/contents/{+path}","compare_url":"https://api.github.com/repos/dcervelli/feature-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcervelli/feature-filter/merges","archive_url":"https://api.github.com/repos/dcervelli/feature-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcervelli/feature-filter/downloads","issues_url":"https://api.github.com/repos/dcervelli/feature-filter/issues{/number}","pulls_url":"https://api.github.com/repos/dcervelli/feature-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/dcervelli/feature-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/dcervelli/feature-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcervelli/feature-filter/labels{/name}","releases_url":"https://api.github.com/repos/dcervelli/feature-filter/releases{/id}","deployments_url":"https://api.github.com/repos/dcervelli/feature-filter/deployments","created_at":"2016-01-27T08:04:50Z","updated_at":"2016-01-27T08:04:52Z","pushed_at":"2016-01-27T23:04:56Z","git_url":"git://github.com/dcervelli/feature-filter.git","ssh_url":"git@github.com:dcervelli/feature-filter.git","clone_url":"https://github.com/dcervelli/feature-filter.git","svn_url":"https://github.com/dcervelli/feature-filter","homepage":"","size":15,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"d2e04ecbfceb83b41e2519f14351d0af94ebc407","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":24871098,"name":"feature-filter","full_name":"mapbox/feature-filter","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/feature-filter","description":"Creates filtering function for vector tile features","fork":false,"url":"https://api.github.com/repos/mapbox/feature-filter","forks_url":"https://api.github.com/repos/mapbox/feature-filter/forks","keys_url":"https://api.github.com/repos/mapbox/feature-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/feature-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/feature-filter/teams","hooks_url":"https://api.github.com/repos/mapbox/feature-filter/hooks","issue_events_url":"https://api.github.com/repos/mapbox/feature-filter/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/feature-filter/events","assignees_url":"https://api.github.com/repos/mapbox/feature-filter/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/feature-filter/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/feature-filter/tags","blobs_url":"https://api.github.com/repos/mapbox/feature-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/feature-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/feature-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/feature-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/feature-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/feature-filter/languages","stargazers_url":"https://api.github.com/repos/mapbox/feature-filter/stargazers","contributors_url":"https://api.github.com/repos/mapbox/feature-filter/contributors","subscribers_url":"https://api.github.com/repos/mapbox/feature-filter/subscribers","subscription_url":"https://api.github.com/repos/mapbox/feature-filter/subscription","commits_url":"https://api.github.com/repos/mapbox/feature-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/feature-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/feature-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/feature-filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/feature-filter/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/feature-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/feature-filter/merges","archive_url":"https://api.github.com/repos/mapbox/feature-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/feature-filter/downloads","issues_url":"https://api.github.com/repos/mapbox/feature-filter/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/feature-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/feature-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/feature-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/feature-filter/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/feature-filter/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/feature-filter/deployments","created_at":"2014-10-07T00:31:39Z","updated_at":"2016-01-29T12:08:41Z","pushed_at":"2016-01-29T16:44:37Z","git_url":"git://github.com/mapbox/feature-filter.git","ssh_url":"git@github.com:mapbox/feature-filter.git","clone_url":"https://github.com/mapbox/feature-filter.git","svn_url":"https://github.com/mapbox/feature-filter","homepage":"","size":25,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/feature-filter/pulls/9"},"html":{"href":"https://github.com/mapbox/feature-filter/pull/9"},"issue":{"href":"https://api.github.com/repos/mapbox/feature-filter/issues/9"},"comments":{"href":"https://api.github.com/repos/mapbox/feature-filter/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/feature-filter/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/feature-filter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/feature-filter/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/feature-filter/statuses/2054d4078b63500445efe65beaabc15388d5a503"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":9,"review_comments":1,"commits":1,"additions":105,"deletions":32,"changed_files":1}}