{"action":"opened","number":56,"pull_request":{"url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/pulls/56","id":76238547,"html_url":"https://github.com/mpociot/laravel-apidoc-generator/pull/56","diff_url":"https://github.com/mpociot/laravel-apidoc-generator/pull/56.diff","patch_url":"https://github.com/mpociot/laravel-apidoc-generator/pull/56.patch","issue_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/issues/56","number":56,"state":"open","locked":false,"title":"Fix failing tests under PHP5","user":{"login":"fergthh","id":9524225,"avatar_url":"https://avatars.githubusercontent.com/u/9524225?v=3","gravatar_id":"","url":"https://api.github.com/users/fergthh","html_url":"https://github.com/fergthh","followers_url":"https://api.github.com/users/fergthh/followers","following_url":"https://api.github.com/users/fergthh/following{/other_user}","gists_url":"https://api.github.com/users/fergthh/gists{/gist_id}","starred_url":"https://api.github.com/users/fergthh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fergthh/subscriptions","organizations_url":"https://api.github.com/users/fergthh/orgs","repos_url":"https://api.github.com/users/fergthh/repos","events_url":"https://api.github.com/users/fergthh/events{/privacy}","received_events_url":"https://api.github.com/users/fergthh/received_events","type":"User","site_admin":false},"body":"Well, under PHP7 all tests has been passed successfully. But under PHP5, the same tests fail miserably. This happens for the behavior of `asort` function when we try to sort an array with duplicated key values.\r\n\r\n![captura](https://cloud.githubusercontent.com/assets/9524225/16579152/c5763f0e-4274-11e6-9dfa-0875ea4ac92a.JPG)\r\n\r\nIn `GenerateDocumentation.php`, we sort the items first and then we group them by resource. In this way, if we have routes with same resource the order is unpredectable.\r\n\r\nIn order to eliminate duplications, we can group the items by resource and finally sort them.\r\n\r\n\r\nWith this change, we will be obtaining the same results in both PHP versions.","created_at":"2016-07-05T08:55:50Z","updated_at":"2016-07-05T08:55:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/pulls/56/commits","review_comments_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/pulls/56/comments","review_comment_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/issues/56/comments","statuses_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/statuses/dc5654281f9a669bb61660bc4428f3edc59b79dd","head":{"label":"fergthh:fix-failing-tests-under-php5","ref":"fix-failing-tests-under-php5","sha":"dc5654281f9a669bb61660bc4428f3edc59b79dd","user":{"login":"fergthh","id":9524225,"avatar_url":"https://avatars.githubusercontent.com/u/9524225?v=3","gravatar_id":"","url":"https://api.github.com/users/fergthh","html_url":"https://github.com/fergthh","followers_url":"https://api.github.com/users/fergthh/followers","following_url":"https://api.github.com/users/fergthh/following{/other_user}","gists_url":"https://api.github.com/users/fergthh/gists{/gist_id}","starred_url":"https://api.github.com/users/fergthh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fergthh/subscriptions","organizations_url":"https://api.github.com/users/fergthh/orgs","repos_url":"https://api.github.com/users/fergthh/repos","events_url":"https://api.github.com/users/fergthh/events{/privacy}","received_events_url":"https://api.github.com/users/fergthh/received_events","type":"User","site_admin":false},"repo":{"id":60961545,"name":"laravel-apidoc-generator","full_name":"fergthh/laravel-apidoc-generator","owner":{"login":"fergthh","id":9524225,"avatar_url":"https://avatars.githubusercontent.com/u/9524225?v=3","gravatar_id":"","url":"https://api.github.com/users/fergthh","html_url":"https://github.com/fergthh","followers_url":"https://api.github.com/users/fergthh/followers","following_url":"https://api.github.com/users/fergthh/following{/other_user}","gists_url":"https://api.github.com/users/fergthh/gists{/gist_id}","starred_url":"https://api.github.com/users/fergthh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fergthh/subscriptions","organizations_url":"https://api.github.com/users/fergthh/orgs","repos_url":"https://api.github.com/users/fergthh/repos","events_url":"https://api.github.com/users/fergthh/events{/privacy}","received_events_url":"https://api.github.com/users/fergthh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fergthh/laravel-apidoc-generator","description":"Laravel API Documentation Generator","fork":true,"url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator","forks_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/forks","keys_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/teams","hooks_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/hooks","issue_events_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/issues/events{/number}","events_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/events","assignees_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/assignees{/user}","branches_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/branches{/branch}","tags_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/tags","blobs_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/languages","stargazers_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/stargazers","contributors_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/contributors","subscribers_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/subscribers","subscription_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/subscription","commits_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/contents/{+path}","compare_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/merges","archive_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/downloads","issues_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/issues{/number}","pulls_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/labels{/name}","releases_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/releases{/id}","deployments_url":"https://api.github.com/repos/fergthh/laravel-apidoc-generator/deployments","created_at":"2016-06-12T10:33:19Z","updated_at":"2016-06-12T10:33:20Z","pushed_at":"2016-07-05T08:51:21Z","git_url":"git://github.com/fergthh/laravel-apidoc-generator.git","ssh_url":"git@github.com:fergthh/laravel-apidoc-generator.git","clone_url":"https://github.com/fergthh/laravel-apidoc-generator.git","svn_url":"https://github.com/fergthh/laravel-apidoc-generator","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mpociot:master","ref":"master","sha":"df1bc487d49a714ab57f388ebb7ca77b845f2c84","user":{"login":"mpociot","id":804684,"avatar_url":"https://avatars.githubusercontent.com/u/804684?v=3","gravatar_id":"","url":"https://api.github.com/users/mpociot","html_url":"https://github.com/mpociot","followers_url":"https://api.github.com/users/mpociot/followers","following_url":"https://api.github.com/users/mpociot/following{/other_user}","gists_url":"https://api.github.com/users/mpociot/gists{/gist_id}","starred_url":"https://api.github.com/users/mpociot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpociot/subscriptions","organizations_url":"https://api.github.com/users/mpociot/orgs","repos_url":"https://api.github.com/users/mpociot/repos","events_url":"https://api.github.com/users/mpociot/events{/privacy}","received_events_url":"https://api.github.com/users/mpociot/received_events","type":"User","site_admin":false},"repo":{"id":57999295,"name":"laravel-apidoc-generator","full_name":"mpociot/laravel-apidoc-generator","owner":{"login":"mpociot","id":804684,"avatar_url":"https://avatars.githubusercontent.com/u/804684?v=3","gravatar_id":"","url":"https://api.github.com/users/mpociot","html_url":"https://github.com/mpociot","followers_url":"https://api.github.com/users/mpociot/followers","following_url":"https://api.github.com/users/mpociot/following{/other_user}","gists_url":"https://api.github.com/users/mpociot/gists{/gist_id}","starred_url":"https://api.github.com/users/mpociot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpociot/subscriptions","organizations_url":"https://api.github.com/users/mpociot/orgs","repos_url":"https://api.github.com/users/mpociot/repos","events_url":"https://api.github.com/users/mpociot/events{/privacy}","received_events_url":"https://api.github.com/users/mpociot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpociot/laravel-apidoc-generator","description":"Laravel API Documentation Generator","fork":false,"url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator","forks_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/forks","keys_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/teams","hooks_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/hooks","issue_events_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/issues/events{/number}","events_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/events","assignees_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/assignees{/user}","branches_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/branches{/branch}","tags_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/tags","blobs_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/languages","stargazers_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/stargazers","contributors_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/contributors","subscribers_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/subscribers","subscription_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/subscription","commits_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/contents/{+path}","compare_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/merges","archive_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/downloads","issues_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/issues{/number}","pulls_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/labels{/name}","releases_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/releases{/id}","deployments_url":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/deployments","created_at":"2016-05-03T20:20:16Z","updated_at":"2016-07-05T03:50:00Z","pushed_at":"2016-07-05T08:55:50Z","git_url":"git://github.com/mpociot/laravel-apidoc-generator.git","ssh_url":"git@github.com:mpociot/laravel-apidoc-generator.git","clone_url":"https://github.com/mpociot/laravel-apidoc-generator.git","svn_url":"https://github.com/mpociot/laravel-apidoc-generator","homepage":null,"size":100,"stargazers_count":399,"watchers_count":399,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":10,"forks":33,"open_issues":10,"watchers":399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/pulls/56"},"html":{"href":"https://github.com/mpociot/laravel-apidoc-generator/pull/56"},"issue":{"href":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/issues/56"},"comments":{"href":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/mpociot/laravel-apidoc-generator/statuses/dc5654281f9a669bb61660bc4428f3edc59b79dd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"fergthh"}}