{"action":"closed","issue":{"url":"https://api.github.com/repos/tpaviot/oce/issues/611","repository_url":"https://api.github.com/repos/tpaviot/oce","labels_url":"https://api.github.com/repos/tpaviot/oce/issues/611/labels{/name}","comments_url":"https://api.github.com/repos/tpaviot/oce/issues/611/comments","events_url":"https://api.github.com/repos/tpaviot/oce/issues/611/events","html_url":"https://github.com/tpaviot/oce/issues/611","id":144815439,"number":611,"title":"[0.17.1] More issues with NULL pointers and PLUGINFACTORY on OSX Clang@7.0.2","user":{"login":"davydden","id":8023934,"avatar_url":"https://avatars.githubusercontent.com/u/8023934?v=3","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tpaviot/oce/labels/QA","name":"QA","color":"d7e102"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-03-31T07:38:29Z","updated_at":"2016-07-26T22:18:09Z","closed_at":"2016-07-26T22:18:09Z","body":"It seems this PR https://github.com/tpaviot/oce/pull/604 did not fix all the issues. I applied this patch to 0.17.1 and have the following warnings:\r\n```\r\n/private/var/folders/5k/sqpp24tx3ylds4fgm13pfht00000gn/T/davydden/spack-stage/spack-stage-dRo5ln/oce-OCE-0.17.1/src/Standard/Standard_ErrorHandler.cxx:143:40: warning: comparison of array 'anActive->myLabel' not equal to a null pointer is always true [-Wtautological-pointer-compare]\r\n  return anActive != NULL && anActive->myLabel != NULL;\r\n                             ~~~~~~~~~~^~~~~~~    ~~~~\r\n/private/var/folders/5k/sqpp24tx3ylds4fgm13pfht00000gn/T/davydden/spack-stage/spack-stage-dRo5ln/oce-OCE-0.17.1/src/Standard/Standard_ErrorHandler.cxx:157:36: warning: comparison of array 'anActive->myLabel' equal to a null pointer is always false [-Wtautological-pointer-compare]\r\n  if(anActive == NULL || anActive->myLabel == NULL) {\r\n                         ~~~~~~~~~~^~~~~~~    ~~~~\r\n```\r\n```\r\n/private/var/folders/5k/sqpp24tx3ylds4fgm13pfht00000gn/T/davydden/spack-stage/spack-stage-dRo5ln/oce-OCE-0.17.1/src/LDOM/LDOM_CharacterData.cxx:62:8: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; comparison may be assumed to always evaluate to false [-Wtautological-undefined-compare]\r\n  if (&aText == NULL)\r\n       ^~~~~    ~~~~\r\n```\r\n\r\nAdditionally i have a couple of others warnings, related to `PLUGINFACTORY`:\r\n```\r\n/private/var/folders/5k/sqpp24tx3ylds4fgm13pfht00000gn/T/davydden/spack-stage/spack-stage-dRo5ln/oce-OCE-0.17.1/src/FWOSDriver/FWOSDriver.cxx:26:1: warning: 'PLUGINFACTORY' has C-linkage specified, but returns user-defined type 'Handle_Standard_Transient' which is incompatible with C [-Wreturn-type-c-linkage]\r\nPLUGIN(FWOSDriver)\r\n^\r\n/private/var/folders/5k/sqpp24tx3ylds4fgm13pfht00000gn/T/davydden/spack-stage/spack-stage-dRo5ln/oce-OCE-0.17.1/src/Plugin/Plugin_Macro.hxx:21:56: note: expanded from macro 'PLUGIN'\r\nextern \"C\" {Standard_EXPORT Handle(Standard_Transient) PLUGINFACTORY(const Standard_GUID&);} \\\r\n            \r\n```\r\n```\r\n/private/var/folders/5k/sqpp24tx3ylds4fgm13pfht00000gn/T/davydden/spack-stage/spack-stage-dRo5ln/oce-OCE-0.17.1/src/BinLDrivers/BinLDrivers.cxx:95:1: warning: 'PLUGINFACTORY' has C-linkage specified, but returns user-defined type 'Handle_Standard_Transient' which is incompatible with C [-Wreturn-type-c-linkage]\r\nPLUGIN(BinLDrivers)\r\n^\r\n/private/var/folders/5k/sqpp24tx3ylds4fgm13pfht00000gn/T/davydden/spack-stage/spack-stage-dRo5ln/oce-OCE-0.17.1/src/Plugin/Plugin_Macro.hxx:21:56: note: expanded from macro 'PLUGIN'\r\nextern \"C\" {Standard_EXPORT Handle(Standard_Transient) PLUGINFACTORY(const Standard_GUID&);} \\\r\n```\r\n```\r\n/private/var/folders/5k/sqpp24tx3ylds4fgm13pfht00000gn/T/davydden/spack-stage/spack-stage-dRo5ln/oce-OCE-0.17.1/src/XmlLDrivers/XmlLDrivers.cxx:129:1: warning: 'PLUGINFACTORY' has C-linkage specified, but returns user-defined type 'Handle_Standard_Transient' which is incompatible with C [-Wreturn-type-c-linkage]\r\nPLUGIN(XmlLDrivers)\r\n^\r\n/private/var/folders/5k/sqpp24tx3ylds4fgm13pfht00000gn/T/davydden/spack-stage/spack-stage-dRo5ln/oce-OCE-0.17.1/src/Plugin/Plugin_Macro.hxx:21:56: note: expanded from macro 'PLUGIN'\r\nextern \"C\" {Standard_EXPORT Handle(Standard_Transient) PLUGINFACTORY(const Standard_GUID&);} \\\r\n                \r\n```\r\n```\r\n/private/var/folders/5k/sqpp24tx3ylds4fgm13pfht00000gn/T/davydden/spack-stage/spack-stage-dRo5ln/oce-OCE-0.17.1/src/StdLDrivers/StdLDrivers.cxx:71:1: warning: 'PLUGINFACTORY' has C-linkage specified, but returns user-defined type 'Handle_Standard_Transient' which is incompatible with C [-Wreturn-type-c-linkage]\r\nPLUGIN(StdLDrivers)\r\n^\r\n/private/var/folders/5k/sqpp24tx3ylds4fgm13pfht00000gn/T/davydden/spack-stage/spack-stage-dRo5ln/oce-OCE-0.17.1/src/Plugin/Plugin_Macro.hxx:21:56: note: expanded from macro 'PLUGIN'\r\nextern \"C\" {Standard_EXPORT Handle(Standard_Transient) PLUGINFACTORY(const Standard_GUID&);} \\\r\n           \r\n```\r\n\r\np.s. I adjusted the original post by removing unit tests failures as those are not related to this issue."}}
{"actor":{"display_login":"thatcadguy"}}