{"action":"created","comment":{"url":"https://api.github.com/repos/appc/cni/pulls/comments/59748645","id":59748645,"diff_hunk":"@@ -34,4 +35,5 @@ If the bridge is missing, the plugin will create one on first use and, if gatewa\n * `isGateway` (boolean, optional): assign an IP address to the bridge. Defaults to false.\n * `ipMasq` (boolean, optional): set up IP Masquerade on the host for traffic originating from this network and destined outside of it. Defaults to false.\n * `mtu` (integer, optional): explicitly set MTU to the specified value. Defaults to the value chosen by the kernel.\n+* `hairpinMode` (boolean, optional): set hairpin mode for interfaces on the bridge. Defaults to false.","path":"Documentation/bridge.md","position":12,"original_position":12,"commit_id":"f277fed3409ff315ed8654e11ef0eb3d463fa01f","original_commit_id":"7f380f6e4142700c9da8bbf20223392df2b46df0","user":{"login":"steveeJ","id":1181362,"avatar_url":"https://avatars.githubusercontent.com/u/1181362?v=3","gravatar_id":"","url":"https://api.github.com/users/steveeJ","html_url":"https://github.com/steveeJ","followers_url":"https://api.github.com/users/steveeJ/followers","following_url":"https://api.github.com/users/steveeJ/following{/other_user}","gists_url":"https://api.github.com/users/steveeJ/gists{/gist_id}","starred_url":"https://api.github.com/users/steveeJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveeJ/subscriptions","organizations_url":"https://api.github.com/users/steveeJ/orgs","repos_url":"https://api.github.com/users/steveeJ/repos","events_url":"https://api.github.com/users/steveeJ/events{/privacy}","received_events_url":"https://api.github.com/users/steveeJ/received_events","type":"User","site_admin":false},"body":"I'd also keep the current default. IMHO the developers who use CNI for their projects will make sure their users are not surprised by setting this accordingly.","created_at":"2016-04-14T16:31:41Z","updated_at":"2016-04-14T16:31:41Z","html_url":"https://github.com/appc/cni/pull/175#discussion_r59748645","pull_request_url":"https://api.github.com/repos/appc/cni/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/appc/cni/pulls/comments/59748645"},"html":{"href":"https://github.com/appc/cni/pull/175#discussion_r59748645"},"pull_request":{"href":"https://api.github.com/repos/appc/cni/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/appc/cni/pulls/175","id":65361335,"html_url":"https://github.com/appc/cni/pull/175","diff_url":"https://github.com/appc/cni/pull/175.diff","patch_url":"https://github.com/appc/cni/pull/175.patch","issue_url":"https://api.github.com/repos/appc/cni/issues/175","number":175,"state":"open","locked":false,"title":"add support to set hairpin mode for bridge plugin","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"body":"Added `hairpin_mode` option for bridge plugin. After veth setup, `hairpin_mode` will be enable if `hairpin_mode` is set to true. We think it is natural for CNI to handle this. ","created_at":"2016-04-05T19:35:17Z","updated_at":"2016-04-14T16:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1807e265e4cdd5d3babae4a4d205ca126a4c0c1c","assignee":null,"milestone":{"url":"https://api.github.com/repos/appc/cni/milestones/3","html_url":"https://github.com/appc/cni/milestones/v0.3.0","labels_url":"https://api.github.com/repos/appc/cni/milestones/3/labels","id":1538622,"number":3,"title":"v0.3.0","description":"","creator":{"login":"steveeJ","id":1181362,"avatar_url":"https://avatars.githubusercontent.com/u/1181362?v=3","gravatar_id":"","url":"https://api.github.com/users/steveeJ","html_url":"https://github.com/steveeJ","followers_url":"https://api.github.com/users/steveeJ/followers","following_url":"https://api.github.com/users/steveeJ/following{/other_user}","gists_url":"https://api.github.com/users/steveeJ/gists{/gist_id}","starred_url":"https://api.github.com/users/steveeJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveeJ/subscriptions","organizations_url":"https://api.github.com/users/steveeJ/orgs","repos_url":"https://api.github.com/users/steveeJ/repos","events_url":"https://api.github.com/users/steveeJ/events{/privacy}","received_events_url":"https://api.github.com/users/steveeJ/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":3,"state":"open","created_at":"2016-01-23T14:03:07Z","updated_at":"2016-04-13T17:46:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/appc/cni/pulls/175/commits","review_comments_url":"https://api.github.com/repos/appc/cni/pulls/175/comments","review_comment_url":"https://api.github.com/repos/appc/cni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appc/cni/issues/175/comments","statuses_url":"https://api.github.com/repos/appc/cni/statuses/f277fed3409ff315ed8654e11ef0eb3d463fa01f","head":{"label":"freehan:master","ref":"master","sha":"f277fed3409ff315ed8654e11ef0eb3d463fa01f","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"repo":{"id":55529190,"name":"cni","full_name":"freehan/cni","owner":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/freehan/cni","description":"Container Network Interface","fork":true,"url":"https://api.github.com/repos/freehan/cni","forks_url":"https://api.github.com/repos/freehan/cni/forks","keys_url":"https://api.github.com/repos/freehan/cni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freehan/cni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freehan/cni/teams","hooks_url":"https://api.github.com/repos/freehan/cni/hooks","issue_events_url":"https://api.github.com/repos/freehan/cni/issues/events{/number}","events_url":"https://api.github.com/repos/freehan/cni/events","assignees_url":"https://api.github.com/repos/freehan/cni/assignees{/user}","branches_url":"https://api.github.com/repos/freehan/cni/branches{/branch}","tags_url":"https://api.github.com/repos/freehan/cni/tags","blobs_url":"https://api.github.com/repos/freehan/cni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freehan/cni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freehan/cni/git/refs{/sha}","trees_url":"https://api.github.com/repos/freehan/cni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freehan/cni/statuses/{sha}","languages_url":"https://api.github.com/repos/freehan/cni/languages","stargazers_url":"https://api.github.com/repos/freehan/cni/stargazers","contributors_url":"https://api.github.com/repos/freehan/cni/contributors","subscribers_url":"https://api.github.com/repos/freehan/cni/subscribers","subscription_url":"https://api.github.com/repos/freehan/cni/subscription","commits_url":"https://api.github.com/repos/freehan/cni/commits{/sha}","git_commits_url":"https://api.github.com/repos/freehan/cni/git/commits{/sha}","comments_url":"https://api.github.com/repos/freehan/cni/comments{/number}","issue_comment_url":"https://api.github.com/repos/freehan/cni/issues/comments{/number}","contents_url":"https://api.github.com/repos/freehan/cni/contents/{+path}","compare_url":"https://api.github.com/repos/freehan/cni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freehan/cni/merges","archive_url":"https://api.github.com/repos/freehan/cni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freehan/cni/downloads","issues_url":"https://api.github.com/repos/freehan/cni/issues{/number}","pulls_url":"https://api.github.com/repos/freehan/cni/pulls{/number}","milestones_url":"https://api.github.com/repos/freehan/cni/milestones{/number}","notifications_url":"https://api.github.com/repos/freehan/cni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freehan/cni/labels{/name}","releases_url":"https://api.github.com/repos/freehan/cni/releases{/id}","deployments_url":"https://api.github.com/repos/freehan/cni/deployments","created_at":"2016-04-05T17:45:02Z","updated_at":"2016-04-05T17:45:03Z","pushed_at":"2016-04-13T21:32:34Z","git_url":"git://github.com/freehan/cni.git","ssh_url":"git@github.com:freehan/cni.git","clone_url":"https://github.com/freehan/cni.git","svn_url":"https://github.com/freehan/cni","homepage":"","size":781,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appc:master","ref":"master","sha":"9a2801085be159a68f23ec9333e97be86d293217","user":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"repo":{"id":33429211,"name":"cni","full_name":"appc/cni","owner":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appc/cni","description":"Container Network Interface","fork":false,"url":"https://api.github.com/repos/appc/cni","forks_url":"https://api.github.com/repos/appc/cni/forks","keys_url":"https://api.github.com/repos/appc/cni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appc/cni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appc/cni/teams","hooks_url":"https://api.github.com/repos/appc/cni/hooks","issue_events_url":"https://api.github.com/repos/appc/cni/issues/events{/number}","events_url":"https://api.github.com/repos/appc/cni/events","assignees_url":"https://api.github.com/repos/appc/cni/assignees{/user}","branches_url":"https://api.github.com/repos/appc/cni/branches{/branch}","tags_url":"https://api.github.com/repos/appc/cni/tags","blobs_url":"https://api.github.com/repos/appc/cni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appc/cni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appc/cni/git/refs{/sha}","trees_url":"https://api.github.com/repos/appc/cni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appc/cni/statuses/{sha}","languages_url":"https://api.github.com/repos/appc/cni/languages","stargazers_url":"https://api.github.com/repos/appc/cni/stargazers","contributors_url":"https://api.github.com/repos/appc/cni/contributors","subscribers_url":"https://api.github.com/repos/appc/cni/subscribers","subscription_url":"https://api.github.com/repos/appc/cni/subscription","commits_url":"https://api.github.com/repos/appc/cni/commits{/sha}","git_commits_url":"https://api.github.com/repos/appc/cni/git/commits{/sha}","comments_url":"https://api.github.com/repos/appc/cni/comments{/number}","issue_comment_url":"https://api.github.com/repos/appc/cni/issues/comments{/number}","contents_url":"https://api.github.com/repos/appc/cni/contents/{+path}","compare_url":"https://api.github.com/repos/appc/cni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appc/cni/merges","archive_url":"https://api.github.com/repos/appc/cni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appc/cni/downloads","issues_url":"https://api.github.com/repos/appc/cni/issues{/number}","pulls_url":"https://api.github.com/repos/appc/cni/pulls{/number}","milestones_url":"https://api.github.com/repos/appc/cni/milestones{/number}","notifications_url":"https://api.github.com/repos/appc/cni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appc/cni/labels{/name}","releases_url":"https://api.github.com/repos/appc/cni/releases{/id}","deployments_url":"https://api.github.com/repos/appc/cni/deployments","created_at":"2015-04-05T03:35:49Z","updated_at":"2016-04-09T22:35:15Z","pushed_at":"2016-04-14T14:43:41Z","git_url":"git://github.com/appc/cni.git","ssh_url":"git@github.com:appc/cni.git","clone_url":"https://github.com/appc/cni.git","svn_url":"https://github.com/appc/cni","homepage":"","size":2329,"stargazers_count":125,"watchers_count":125,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":52,"forks":38,"open_issues":52,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appc/cni/pulls/175"},"html":{"href":"https://github.com/appc/cni/pull/175"},"issue":{"href":"https://api.github.com/repos/appc/cni/issues/175"},"comments":{"href":"https://api.github.com/repos/appc/cni/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/appc/cni/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/appc/cni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appc/cni/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/appc/cni/statuses/f277fed3409ff315ed8654e11ef0eb3d463fa01f"}}}}