{"action":"closed","number":2604,"pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/2604","id":93184510,"html_url":"https://github.com/salesagility/SuiteCRM/pull/2604","diff_url":"https://github.com/salesagility/SuiteCRM/pull/2604.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/2604.patch","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/2604","number":2604,"state":"closed","locked":false,"title":"scrm-39 -  Replace X templates on SubPanels with Smarty","user":{"login":"daniel-samson","id":12231216,"avatar_url":"https://avatars.githubusercontent.com/u/12231216?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-samson","html_url":"https://github.com/daniel-samson","followers_url":"https://api.github.com/users/daniel-samson/followers","following_url":"https://api.github.com/users/daniel-samson/following{/other_user}","gists_url":"https://api.github.com/users/daniel-samson/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-samson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-samson/subscriptions","organizations_url":"https://api.github.com/users/daniel-samson/orgs","repos_url":"https://api.github.com/users/daniel-samson/repos","events_url":"https://api.github.com/users/daniel-samson/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-samson/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here unless your commit contains the issue number -->\r\n\r\nI order to make the sub panels fit the SuiteP design. So that the column names are at the top. I have change the sub panels so that they now support smarty templates. \r\n\r\nThis means you can also override the **include/SubPanel/tpls/SubPanelDynamic.tpl** file in the themes. Which could be quite useful. I have create a new view called **include/ListView/ListViewSubPanel.php** which is extends the standard ListView.\r\n\r\n I haven't completely gotten rid of the x templates. I have left some of the custom views which currently are not being used anyway. I have also left some hard coded stuff like the pagination in the ListViewSubpanel. As some of the processing is handed here. Perhaps in the future we might move some of this code out into a template.\r\n\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\n- Makes the subpanels fit the SuiteP design.\r\n- Keeps the Suite7 and SuiteR the same.\r\n\r\n## How To Test This\r\n<!--- Please describe in detail how to test your changes. -->\r\n\r\n- Check each sub panel in SuiteCRM.\r\n- Ensure that each function works like it did before.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [x] My code follows the code style of this project found [here](https://suitecrm.com/wiki/index.php/Coding_Standards).\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have read the [**How to Contribute**](https://suitecrm.com/wiki/index.php/Contributing_to_SuiteCRM) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->","created_at":"2016-11-10T16:32:27Z","updated_at":"2016-11-17T10:56:45Z","closed_at":"2016-11-17T10:56:45Z","merged_at":null,"merge_commit_sha":"cbdf9da13038537257636baf69ef2ecf9206f25f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/2604/commits","review_comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/2604/comments","review_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/2604/comments","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/94f6d43cccbdee7ed11a4b63142897af047b5a96","head":{"label":"daniel-samson:scrm-39","ref":"scrm-39","sha":"94f6d43cccbdee7ed11a4b63142897af047b5a96","user":{"login":"daniel-samson","id":12231216,"avatar_url":"https://avatars.githubusercontent.com/u/12231216?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-samson","html_url":"https://github.com/daniel-samson","followers_url":"https://api.github.com/users/daniel-samson/followers","following_url":"https://api.github.com/users/daniel-samson/following{/other_user}","gists_url":"https://api.github.com/users/daniel-samson/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-samson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-samson/subscriptions","organizations_url":"https://api.github.com/users/daniel-samson/orgs","repos_url":"https://api.github.com/users/daniel-samson/repos","events_url":"https://api.github.com/users/daniel-samson/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-samson/received_events","type":"User","site_admin":false},"repo":{"id":46138130,"name":"SuiteCRM","full_name":"daniel-samson/SuiteCRM","owner":{"login":"daniel-samson","id":12231216,"avatar_url":"https://avatars.githubusercontent.com/u/12231216?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-samson","html_url":"https://github.com/daniel-samson","followers_url":"https://api.github.com/users/daniel-samson/followers","following_url":"https://api.github.com/users/daniel-samson/following{/other_user}","gists_url":"https://api.github.com/users/daniel-samson/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-samson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-samson/subscriptions","organizations_url":"https://api.github.com/users/daniel-samson/orgs","repos_url":"https://api.github.com/users/daniel-samson/repos","events_url":"https://api.github.com/users/daniel-samson/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-samson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daniel-samson/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":true,"url":"https://api.github.com/repos/daniel-samson/SuiteCRM","forks_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/forks","keys_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/events","assignees_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/merges","archive_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/deployments","created_at":"2015-11-13T17:53:25Z","updated_at":"2016-07-21T11:52:57Z","pushed_at":"2016-11-16T17:19:39Z","git_url":"git://github.com/daniel-samson/SuiteCRM.git","ssh_url":"git@github.com:daniel-samson/SuiteCRM.git","clone_url":"https://github.com/daniel-samson/SuiteCRM.git","svn_url":"https://github.com/daniel-samson/SuiteCRM","homepage":"http://www.suitecrm.com","size":73296,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"salesagility:hotfix","ref":"hotfix","sha":"ee487a959aab67d3f37ce831ea9217fda028b88e","user":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars.githubusercontent.com/u/1450870?v=3","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"repo":{"id":13044600,"name":"SuiteCRM","full_name":"salesagility/SuiteCRM","owner":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars.githubusercontent.com/u/1450870?v=3","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesagility/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":false,"url":"https://api.github.com/repos/salesagility/SuiteCRM","forks_url":"https://api.github.com/repos/salesagility/SuiteCRM/forks","keys_url":"https://api.github.com/repos/salesagility/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesagility/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesagility/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/salesagility/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/events","assignees_url":"https://api.github.com/repos/salesagility/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/salesagility/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/salesagility/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/salesagility/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/salesagility/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesagility/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/salesagility/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesagility/SuiteCRM/merges","archive_url":"https://api.github.com/repos/salesagility/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesagility/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/salesagility/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/salesagility/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/salesagility/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/salesagility/SuiteCRM/deployments","created_at":"2013-09-23T19:10:08Z","updated_at":"2016-11-17T07:42:40Z","pushed_at":"2016-11-17T10:53:24Z","git_url":"git://github.com/salesagility/SuiteCRM.git","ssh_url":"git@github.com:salesagility/SuiteCRM.git","clone_url":"https://github.com/salesagility/SuiteCRM.git","svn_url":"https://github.com/salesagility/SuiteCRM","homepage":"http://www.suitecrm.com","size":81262,"stargazers_count":455,"watchers_count":455,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":409,"mirror_url":null,"open_issues_count":719,"forks":409,"open_issues":719,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/2604"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/2604"},"issue":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/2604"},"comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/2604/comments"},"review_comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/2604/comments"},"review_comment":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/2604/commits"},"statuses":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/94f6d43cccbdee7ed11a4b63142897af047b5a96"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":2,"commits":27,"additions":8462,"deletions":1102,"changed_files":16}}
{"actor":{"display_login":"daniel-samson"}}