{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments/66486762","id":66486762,"diff_hunk":"@@ -276,17 +280,34 @@ def delete(self, client=None):\n         \"\"\"\n         return self.bucket.delete_blob(self.name, client=client)\n \n-    def download_to_file(self, file_obj, client=None):\n+    def download_to_file(self, file_obj, key=None, client=None):\n         \"\"\"Download the contents of this blob into a file-like object.\n \n         .. note::\n \n            If the server-set property, :attr:`media_link`, is not yet\n            initialized, makes an additional API request to load it.\n \n+         Downloading a file that has been `customer-supplied\n+         <https://cloud.google.com/storage/docs/encryption#customer-supplied>`_\n+         encryption::\n+\n+            >>> from gcloud import storage\n+            >>> from gcloud.storage import Blob\n+\n+            >>> sc = storage.Client(project='my-project')","path":"gcloud/storage/blob.py","position":39,"original_position":39,"commit_id":"bfaf04939b3e52890d2c74755902bcf7076ca5d8","original_commit_id":"bfaf04939b3e52890d2c74755902bcf7076ca5d8","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"What is the variable name we use elsewhere? Let's try to be consistent. AFAIK it's `client`, rather than `sc`","created_at":"2016-06-09T17:41:02Z","updated_at":"2016-06-09T17:41:02Z","html_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/1844#discussion_r66486762","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/1844","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments/66486762"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/1844#discussion_r66486762"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/1844"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/1844","id":72924379,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/1844","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/1844.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/1844.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/1844","number":1844,"state":"open","locked":false,"title":"Add customer-supplied encryption to storage","user":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"body":"Possible solution to resolve #1841.\r\n\r\nI think my tests could use some feedback.","created_at":"2016-06-07T18:26:47Z","updated_at":"2016-06-09T17:41:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5a24921d7727969f8559d109e260fb1522e971c","assignee":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/1844/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/1844/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/1844/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/statuses/bfaf04939b3e52890d2c74755902bcf7076ca5d8","head":{"label":"daspecster:customer-supplied-encryption","ref":"customer-supplied-encryption","sha":"bfaf04939b3e52890d2c74755902bcf7076ca5d8","user":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"repo":{"id":43923717,"name":"gcloud-python","full_name":"daspecster/gcloud-python","owner":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daspecster/gcloud-python","description":"Google Cloud Client Library for Python","fork":true,"url":"https://api.github.com/repos/daspecster/gcloud-python","forks_url":"https://api.github.com/repos/daspecster/gcloud-python/forks","keys_url":"https://api.github.com/repos/daspecster/gcloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daspecster/gcloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daspecster/gcloud-python/teams","hooks_url":"https://api.github.com/repos/daspecster/gcloud-python/hooks","issue_events_url":"https://api.github.com/repos/daspecster/gcloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/daspecster/gcloud-python/events","assignees_url":"https://api.github.com/repos/daspecster/gcloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/daspecster/gcloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/daspecster/gcloud-python/tags","blobs_url":"https://api.github.com/repos/daspecster/gcloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daspecster/gcloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daspecster/gcloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/daspecster/gcloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daspecster/gcloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/daspecster/gcloud-python/languages","stargazers_url":"https://api.github.com/repos/daspecster/gcloud-python/stargazers","contributors_url":"https://api.github.com/repos/daspecster/gcloud-python/contributors","subscribers_url":"https://api.github.com/repos/daspecster/gcloud-python/subscribers","subscription_url":"https://api.github.com/repos/daspecster/gcloud-python/subscription","commits_url":"https://api.github.com/repos/daspecster/gcloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/daspecster/gcloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/daspecster/gcloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/daspecster/gcloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/daspecster/gcloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/daspecster/gcloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daspecster/gcloud-python/merges","archive_url":"https://api.github.com/repos/daspecster/gcloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daspecster/gcloud-python/downloads","issues_url":"https://api.github.com/repos/daspecster/gcloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/daspecster/gcloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/daspecster/gcloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/daspecster/gcloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daspecster/gcloud-python/labels{/name}","releases_url":"https://api.github.com/repos/daspecster/gcloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/daspecster/gcloud-python/deployments","created_at":"2015-10-09T00:31:09Z","updated_at":"2016-04-22T01:09:23Z","pushed_at":"2016-06-08T20:04:43Z","git_url":"git://github.com/daspecster/gcloud-python.git","ssh_url":"git@github.com:daspecster/gcloud-python.git","clone_url":"https://github.com/daspecster/gcloud-python.git","svn_url":"https://github.com/daspecster/gcloud-python","homepage":"https://googlecloudplatform.github.io/gcloud-python/","size":32963,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"92e9362f5246ecea1a9f96ea104353d3caf7623c","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"name":"gcloud-python","full_name":"GoogleCloudPlatform/gcloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2016-06-09T14:33:04Z","pushed_at":"2016-06-08T20:04:44Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-python","homepage":"https://googlecloudplatform.github.io/gcloud-python/","size":59010,"stargazers_count":330,"watchers_count":330,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":171,"mirror_url":null,"open_issues_count":145,"forks":171,"open_issues":145,"watchers":330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/1844"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/1844"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/1844"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/1844/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/1844/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/1844/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/statuses/bfaf04939b3e52890d2c74755902bcf7076ca5d8"}}}}
{"actor":{"display_login":"dhermes"}}