{"action":"created","comment":{"url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/comments/68010516","id":68010516,"diff_hunk":"@@ -155,9 +155,9 @@ class FHead(_Rex):\n     flags = re.MULTILINE\n \n     def __call__(self, f):\n-        if f.request and self.re.search(bytes(f.request.headers)):\n+        if f.request and self.re.search(bytes(f.request.headers).decode()):","path":"mitmproxy/filt.py","position":null,"original_position":5,"commit_id":"d655d8f1f3b362201a9883d0dd03df31fddf481d","original_commit_id":"10469d9efbebd840815a0f1b97eece8778eaf8a0","user":{"login":"dufferzafar","id":1449512,"avatar_url":"https://avatars.githubusercontent.com/u/1449512?v=3","gravatar_id":"","url":"https://api.github.com/users/dufferzafar","html_url":"https://github.com/dufferzafar","followers_url":"https://api.github.com/users/dufferzafar/followers","following_url":"https://api.github.com/users/dufferzafar/following{/other_user}","gists_url":"https://api.github.com/users/dufferzafar/gists{/gist_id}","starred_url":"https://api.github.com/users/dufferzafar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dufferzafar/subscriptions","organizations_url":"https://api.github.com/users/dufferzafar/orgs","repos_url":"https://api.github.com/users/dufferzafar/repos","events_url":"https://api.github.com/users/dufferzafar/events{/privacy}","received_events_url":"https://api.github.com/users/dufferzafar/received_events","type":"User","site_admin":false},"body":"Okay, so I've removed `filt` related code from here! I think this can be merged now.","created_at":"2016-06-22T08:09:06Z","updated_at":"2016-06-22T08:09:06Z","html_url":"https://github.com/mitmproxy/mitmproxy/pull/1282#discussion_r68010516","pull_request_url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1282","_links":{"self":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/comments/68010516"},"html":{"href":"https://github.com/mitmproxy/mitmproxy/pull/1282#discussion_r68010516"},"pull_request":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1282"}}},"pull_request":{"url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1282","id":74623872,"html_url":"https://github.com/mitmproxy/mitmproxy/pull/1282","diff_url":"https://github.com/mitmproxy/mitmproxy/pull/1282.diff","patch_url":"https://github.com/mitmproxy/mitmproxy/pull/1282.patch","issue_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1282","number":1282,"state":"open","locked":false,"title":"Python 3 - mitmproxy.{protocol.http1, proxy, platform.pf}","user":{"login":"dufferzafar","id":1449512,"avatar_url":"https://avatars.githubusercontent.com/u/1449512?v=3","gravatar_id":"","url":"https://api.github.com/users/dufferzafar","html_url":"https://github.com/dufferzafar","followers_url":"https://api.github.com/users/dufferzafar/followers","following_url":"https://api.github.com/users/dufferzafar/following{/other_user}","gists_url":"https://api.github.com/users/dufferzafar/gists{/gist_id}","starred_url":"https://api.github.com/users/dufferzafar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dufferzafar/subscriptions","organizations_url":"https://api.github.com/users/dufferzafar/orgs","repos_url":"https://api.github.com/users/dufferzafar/repos","events_url":"https://api.github.com/users/dufferzafar/events{/privacy}","received_events_url":"https://api.github.com/users/dufferzafar/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-06-21T14:38:49Z","updated_at":"2016-06-22T08:09:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"062f88cf2c0bf9cc7f1c0e589536649675466909","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1282/commits","review_comments_url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1282/comments","review_comment_url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1282/comments","statuses_url":"https://api.github.com/repos/mitmproxy/mitmproxy/statuses/d655d8f1f3b362201a9883d0dd03df31fddf481d","head":{"label":"dufferzafar:py3","ref":"py3","sha":"d655d8f1f3b362201a9883d0dd03df31fddf481d","user":{"login":"dufferzafar","id":1449512,"avatar_url":"https://avatars.githubusercontent.com/u/1449512?v=3","gravatar_id":"","url":"https://api.github.com/users/dufferzafar","html_url":"https://github.com/dufferzafar","followers_url":"https://api.github.com/users/dufferzafar/followers","following_url":"https://api.github.com/users/dufferzafar/following{/other_user}","gists_url":"https://api.github.com/users/dufferzafar/gists{/gist_id}","starred_url":"https://api.github.com/users/dufferzafar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dufferzafar/subscriptions","organizations_url":"https://api.github.com/users/dufferzafar/orgs","repos_url":"https://api.github.com/users/dufferzafar/repos","events_url":"https://api.github.com/users/dufferzafar/events{/privacy}","received_events_url":"https://api.github.com/users/dufferzafar/received_events","type":"User","site_admin":false},"repo":{"id":49568934,"name":"mitmproxy","full_name":"dufferzafar/mitmproxy","owner":{"login":"dufferzafar","id":1449512,"avatar_url":"https://avatars.githubusercontent.com/u/1449512?v=3","gravatar_id":"","url":"https://api.github.com/users/dufferzafar","html_url":"https://github.com/dufferzafar","followers_url":"https://api.github.com/users/dufferzafar/followers","following_url":"https://api.github.com/users/dufferzafar/following{/other_user}","gists_url":"https://api.github.com/users/dufferzafar/gists{/gist_id}","starred_url":"https://api.github.com/users/dufferzafar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dufferzafar/subscriptions","organizations_url":"https://api.github.com/users/dufferzafar/orgs","repos_url":"https://api.github.com/users/dufferzafar/repos","events_url":"https://api.github.com/users/dufferzafar/events{/privacy}","received_events_url":"https://api.github.com/users/dufferzafar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dufferzafar/mitmproxy","description":"An interactive SSL-capable intercepting HTTP proxy for penetration testers and software developers","fork":true,"url":"https://api.github.com/repos/dufferzafar/mitmproxy","forks_url":"https://api.github.com/repos/dufferzafar/mitmproxy/forks","keys_url":"https://api.github.com/repos/dufferzafar/mitmproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dufferzafar/mitmproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dufferzafar/mitmproxy/teams","hooks_url":"https://api.github.com/repos/dufferzafar/mitmproxy/hooks","issue_events_url":"https://api.github.com/repos/dufferzafar/mitmproxy/issues/events{/number}","events_url":"https://api.github.com/repos/dufferzafar/mitmproxy/events","assignees_url":"https://api.github.com/repos/dufferzafar/mitmproxy/assignees{/user}","branches_url":"https://api.github.com/repos/dufferzafar/mitmproxy/branches{/branch}","tags_url":"https://api.github.com/repos/dufferzafar/mitmproxy/tags","blobs_url":"https://api.github.com/repos/dufferzafar/mitmproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dufferzafar/mitmproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dufferzafar/mitmproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/dufferzafar/mitmproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dufferzafar/mitmproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/dufferzafar/mitmproxy/languages","stargazers_url":"https://api.github.com/repos/dufferzafar/mitmproxy/stargazers","contributors_url":"https://api.github.com/repos/dufferzafar/mitmproxy/contributors","subscribers_url":"https://api.github.com/repos/dufferzafar/mitmproxy/subscribers","subscription_url":"https://api.github.com/repos/dufferzafar/mitmproxy/subscription","commits_url":"https://api.github.com/repos/dufferzafar/mitmproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/dufferzafar/mitmproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/dufferzafar/mitmproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/dufferzafar/mitmproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/dufferzafar/mitmproxy/contents/{+path}","compare_url":"https://api.github.com/repos/dufferzafar/mitmproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dufferzafar/mitmproxy/merges","archive_url":"https://api.github.com/repos/dufferzafar/mitmproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dufferzafar/mitmproxy/downloads","issues_url":"https://api.github.com/repos/dufferzafar/mitmproxy/issues{/number}","pulls_url":"https://api.github.com/repos/dufferzafar/mitmproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/dufferzafar/mitmproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/dufferzafar/mitmproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dufferzafar/mitmproxy/labels{/name}","releases_url":"https://api.github.com/repos/dufferzafar/mitmproxy/releases{/id}","deployments_url":"https://api.github.com/repos/dufferzafar/mitmproxy/deployments","created_at":"2016-01-13T11:11:50Z","updated_at":"2016-01-13T11:11:51Z","pushed_at":"2016-06-22T08:07:58Z","git_url":"git://github.com/dufferzafar/mitmproxy.git","ssh_url":"git@github.com:dufferzafar/mitmproxy.git","clone_url":"https://github.com/dufferzafar/mitmproxy.git","svn_url":"https://github.com/dufferzafar/mitmproxy","homepage":"http://mitmproxy.org","size":30509,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mitmproxy:master","ref":"master","sha":"66a2b0d61563efc529931e9a2b2d82a9d00159a5","user":{"login":"mitmproxy","id":4652787,"avatar_url":"https://avatars.githubusercontent.com/u/4652787?v=3","gravatar_id":"","url":"https://api.github.com/users/mitmproxy","html_url":"https://github.com/mitmproxy","followers_url":"https://api.github.com/users/mitmproxy/followers","following_url":"https://api.github.com/users/mitmproxy/following{/other_user}","gists_url":"https://api.github.com/users/mitmproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/mitmproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitmproxy/subscriptions","organizations_url":"https://api.github.com/users/mitmproxy/orgs","repos_url":"https://api.github.com/users/mitmproxy/repos","events_url":"https://api.github.com/users/mitmproxy/events{/privacy}","received_events_url":"https://api.github.com/users/mitmproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":519832,"name":"mitmproxy","full_name":"mitmproxy/mitmproxy","owner":{"login":"mitmproxy","id":4652787,"avatar_url":"https://avatars.githubusercontent.com/u/4652787?v=3","gravatar_id":"","url":"https://api.github.com/users/mitmproxy","html_url":"https://github.com/mitmproxy","followers_url":"https://api.github.com/users/mitmproxy/followers","following_url":"https://api.github.com/users/mitmproxy/following{/other_user}","gists_url":"https://api.github.com/users/mitmproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/mitmproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitmproxy/subscriptions","organizations_url":"https://api.github.com/users/mitmproxy/orgs","repos_url":"https://api.github.com/users/mitmproxy/repos","events_url":"https://api.github.com/users/mitmproxy/events{/privacy}","received_events_url":"https://api.github.com/users/mitmproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitmproxy/mitmproxy","description":"An interactive SSL-capable intercepting HTTP proxy for penetration testers and software developers","fork":false,"url":"https://api.github.com/repos/mitmproxy/mitmproxy","forks_url":"https://api.github.com/repos/mitmproxy/mitmproxy/forks","keys_url":"https://api.github.com/repos/mitmproxy/mitmproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitmproxy/mitmproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitmproxy/mitmproxy/teams","hooks_url":"https://api.github.com/repos/mitmproxy/mitmproxy/hooks","issue_events_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/events{/number}","events_url":"https://api.github.com/repos/mitmproxy/mitmproxy/events","assignees_url":"https://api.github.com/repos/mitmproxy/mitmproxy/assignees{/user}","branches_url":"https://api.github.com/repos/mitmproxy/mitmproxy/branches{/branch}","tags_url":"https://api.github.com/repos/mitmproxy/mitmproxy/tags","blobs_url":"https://api.github.com/repos/mitmproxy/mitmproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitmproxy/mitmproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitmproxy/mitmproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitmproxy/mitmproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitmproxy/mitmproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mitmproxy/mitmproxy/languages","stargazers_url":"https://api.github.com/repos/mitmproxy/mitmproxy/stargazers","contributors_url":"https://api.github.com/repos/mitmproxy/mitmproxy/contributors","subscribers_url":"https://api.github.com/repos/mitmproxy/mitmproxy/subscribers","subscription_url":"https://api.github.com/repos/mitmproxy/mitmproxy/subscription","commits_url":"https://api.github.com/repos/mitmproxy/mitmproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitmproxy/mitmproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitmproxy/mitmproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitmproxy/mitmproxy/contents/{+path}","compare_url":"https://api.github.com/repos/mitmproxy/mitmproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitmproxy/mitmproxy/merges","archive_url":"https://api.github.com/repos/mitmproxy/mitmproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitmproxy/mitmproxy/downloads","issues_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues{/number}","pulls_url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mitmproxy/mitmproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mitmproxy/mitmproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitmproxy/mitmproxy/labels{/name}","releases_url":"https://api.github.com/repos/mitmproxy/mitmproxy/releases{/id}","deployments_url":"https://api.github.com/repos/mitmproxy/mitmproxy/deployments","created_at":"2010-02-16T04:10:13Z","updated_at":"2016-06-22T05:49:07Z","pushed_at":"2016-06-22T08:07:58Z","git_url":"git://github.com/mitmproxy/mitmproxy.git","ssh_url":"git@github.com:mitmproxy/mitmproxy.git","clone_url":"https://github.com/mitmproxy/mitmproxy.git","svn_url":"https://github.com/mitmproxy/mitmproxy","homepage":"http://mitmproxy.org","size":33899,"stargazers_count":5101,"watchers_count":5101,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":734,"mirror_url":null,"open_issues_count":76,"forks":734,"open_issues":76,"watchers":5101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1282"},"html":{"href":"https://github.com/mitmproxy/mitmproxy/pull/1282"},"issue":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1282"},"comments":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1282/comments"},"review_comments":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1282/comments"},"review_comment":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1282/commits"},"statuses":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/statuses/d655d8f1f3b362201a9883d0dd03df31fddf481d"}}}}
{"actor":{"display_login":"dufferzafar"}}