{"action":"closed","number":359,"pull_request":{"url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/pulls/359","id":99753021,"html_url":"https://github.com/Sententiaregum/Sententiaregum/pull/359","diff_url":"https://github.com/Sententiaregum/Sententiaregum/pull/359.diff","patch_url":"https://github.com/Sententiaregum/Sententiaregum/pull/359.patch","issue_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/issues/359","number":359,"state":"closed","locked":false,"title":"rewrite internals of the frontend's security guard","user":{"login":"Ma27","id":6025220,"avatar_url":"https://avatars.githubusercontent.com/u/6025220?v=3","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"body":"### Overview\r\n\r\nThis PR contains first steps regarding the security system of the frontend:\r\n\r\n- [x] simple refactorings for `Locale` and `ApiKey` usage and reduction of their usage\r\n- [x] implement menu reducer and remove `{ items: [] }` structure in favor of a flat array for menu items\r\n- [x] add `redux-thunk` and make several actions async to use current app state in an action (e.g. authentication state rather than `ApiKey`)\r\n- [x] rewrite route authentication checker\r\n- [x] fix more tests\r\n\r\n#### Notes\r\n\r\n1. currently passing tests\r\n\r\n- `localeActionsSpec`\r\n- `menuActionsSpec`\r\n- most of the markup components\r\n- `menuReducerSpec`\r\n- `localeReducerSpec`\r\n- `ApiKeySpec`\r\n- `LocaleSpec`\r\n- `appProfileCheckerSpec`\r\n\r\n2. usage of `ApiKey` and `Locale`\r\n\r\nboth services communicate with the browser's API to store session data in the browser. Since redux should be the \"single source of truth\" regarding state management, these APIs should only be used in actions for changing their values. When loading these values, they have to be extracted from the state tree.\r\n\r\n3. modified state tree\r\n\r\nthe current state tree represents the basic skeleton of the old state sub-trees persisted in the stores.\r\nThe `userReducer` is just basic boilerplate code to show how to handle these state sub-trees in the future and not ready yet. The current state tree shouldn't experience too much changes during this development phase.\r\nThe details of how to handle single sub-trees (e.g. for registration/activation or login) must be evaluated before rewriting these features.","created_at":"2016-12-30T13:50:21Z","updated_at":"2016-12-30T17:41:26Z","closed_at":"2016-12-30T17:41:26Z","merged_at":"2016-12-30T17:41:26Z","merge_commit_sha":"b2f5e57c413cd1794990c3d4d678899b5238b576","assignee":{"login":"Ma27","id":6025220,"avatar_url":"https://avatars.githubusercontent.com/u/6025220?v=3","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ma27","id":6025220,"avatar_url":"https://avatars.githubusercontent.com/u/6025220?v=3","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},{"login":"benbieler","id":10898370,"avatar_url":"https://avatars.githubusercontent.com/u/10898370?v=3","gravatar_id":"","url":"https://api.github.com/users/benbieler","html_url":"https://github.com/benbieler","followers_url":"https://api.github.com/users/benbieler/followers","following_url":"https://api.github.com/users/benbieler/following{/other_user}","gists_url":"https://api.github.com/users/benbieler/gists{/gist_id}","starred_url":"https://api.github.com/users/benbieler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbieler/subscriptions","organizations_url":"https://api.github.com/users/benbieler/orgs","repos_url":"https://api.github.com/users/benbieler/repos","events_url":"https://api.github.com/users/benbieler/events{/privacy}","received_events_url":"https://api.github.com/users/benbieler/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/pulls/359/commits","review_comments_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/pulls/359/comments","review_comment_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/issues/359/comments","statuses_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/statuses/ac12f3a3bcfe9bfe1bb5c67ac5d78b9b4fc6ebee","head":{"label":"Sententiaregum:development/refactor-security-system","ref":"development/refactor-security-system","sha":"ac12f3a3bcfe9bfe1bb5c67ac5d78b9b4fc6ebee","user":{"login":"Sententiaregum","id":14262478,"avatar_url":"https://avatars.githubusercontent.com/u/14262478?v=3","gravatar_id":"","url":"https://api.github.com/users/Sententiaregum","html_url":"https://github.com/Sententiaregum","followers_url":"https://api.github.com/users/Sententiaregum/followers","following_url":"https://api.github.com/users/Sententiaregum/following{/other_user}","gists_url":"https://api.github.com/users/Sententiaregum/gists{/gist_id}","starred_url":"https://api.github.com/users/Sententiaregum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sententiaregum/subscriptions","organizations_url":"https://api.github.com/users/Sententiaregum/orgs","repos_url":"https://api.github.com/users/Sententiaregum/repos","events_url":"https://api.github.com/users/Sententiaregum/events{/privacy}","received_events_url":"https://api.github.com/users/Sententiaregum/received_events","type":"Organization","site_admin":false},"repo":{"id":42404562,"name":"Sententiaregum","full_name":"Sententiaregum/Sententiaregum","owner":{"login":"Sententiaregum","id":14262478,"avatar_url":"https://avatars.githubusercontent.com/u/14262478?v=3","gravatar_id":"","url":"https://api.github.com/users/Sententiaregum","html_url":"https://github.com/Sententiaregum","followers_url":"https://api.github.com/users/Sententiaregum/followers","following_url":"https://api.github.com/users/Sententiaregum/following{/other_user}","gists_url":"https://api.github.com/users/Sententiaregum/gists{/gist_id}","starred_url":"https://api.github.com/users/Sententiaregum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sententiaregum/subscriptions","organizations_url":"https://api.github.com/users/Sententiaregum/orgs","repos_url":"https://api.github.com/users/Sententiaregum/repos","events_url":"https://api.github.com/users/Sententiaregum/events{/privacy}","received_events_url":"https://api.github.com/users/Sententiaregum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sententiaregum/Sententiaregum","description":":mailbox_closed: A social network based on Symfony3 and ReactJS.","fork":false,"url":"https://api.github.com/repos/Sententiaregum/Sententiaregum","forks_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/forks","keys_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/teams","hooks_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/hooks","issue_events_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/issues/events{/number}","events_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/events","assignees_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/assignees{/user}","branches_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/branches{/branch}","tags_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/tags","blobs_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/statuses/{sha}","languages_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/languages","stargazers_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/stargazers","contributors_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/contributors","subscribers_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/subscribers","subscription_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/subscription","commits_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/contents/{+path}","compare_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/merges","archive_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/downloads","issues_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/issues{/number}","pulls_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/pulls{/number}","milestones_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/milestones{/number}","notifications_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/labels{/name}","releases_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/releases{/id}","deployments_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/deployments","created_at":"2015-09-13T17:01:22Z","updated_at":"2016-12-09T22:46:34Z","pushed_at":"2016-12-30T17:41:26Z","git_url":"git://github.com/Sententiaregum/Sententiaregum.git","ssh_url":"git@github.com:Sententiaregum/Sententiaregum.git","clone_url":"https://github.com/Sententiaregum/Sententiaregum.git","svn_url":"https://github.com/Sententiaregum/Sententiaregum","homepage":"","size":1195,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":25,"forks":3,"open_issues":25,"watchers":7,"default_branch":"master"}},"base":{"label":"Sententiaregum:develop","ref":"develop","sha":"291e0982c67399a3c22bf5dba476e7177077390f","user":{"login":"Sententiaregum","id":14262478,"avatar_url":"https://avatars.githubusercontent.com/u/14262478?v=3","gravatar_id":"","url":"https://api.github.com/users/Sententiaregum","html_url":"https://github.com/Sententiaregum","followers_url":"https://api.github.com/users/Sententiaregum/followers","following_url":"https://api.github.com/users/Sententiaregum/following{/other_user}","gists_url":"https://api.github.com/users/Sententiaregum/gists{/gist_id}","starred_url":"https://api.github.com/users/Sententiaregum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sententiaregum/subscriptions","organizations_url":"https://api.github.com/users/Sententiaregum/orgs","repos_url":"https://api.github.com/users/Sententiaregum/repos","events_url":"https://api.github.com/users/Sententiaregum/events{/privacy}","received_events_url":"https://api.github.com/users/Sententiaregum/received_events","type":"Organization","site_admin":false},"repo":{"id":42404562,"name":"Sententiaregum","full_name":"Sententiaregum/Sententiaregum","owner":{"login":"Sententiaregum","id":14262478,"avatar_url":"https://avatars.githubusercontent.com/u/14262478?v=3","gravatar_id":"","url":"https://api.github.com/users/Sententiaregum","html_url":"https://github.com/Sententiaregum","followers_url":"https://api.github.com/users/Sententiaregum/followers","following_url":"https://api.github.com/users/Sententiaregum/following{/other_user}","gists_url":"https://api.github.com/users/Sententiaregum/gists{/gist_id}","starred_url":"https://api.github.com/users/Sententiaregum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sententiaregum/subscriptions","organizations_url":"https://api.github.com/users/Sententiaregum/orgs","repos_url":"https://api.github.com/users/Sententiaregum/repos","events_url":"https://api.github.com/users/Sententiaregum/events{/privacy}","received_events_url":"https://api.github.com/users/Sententiaregum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sententiaregum/Sententiaregum","description":":mailbox_closed: A social network based on Symfony3 and ReactJS.","fork":false,"url":"https://api.github.com/repos/Sententiaregum/Sententiaregum","forks_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/forks","keys_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/teams","hooks_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/hooks","issue_events_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/issues/events{/number}","events_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/events","assignees_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/assignees{/user}","branches_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/branches{/branch}","tags_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/tags","blobs_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/statuses/{sha}","languages_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/languages","stargazers_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/stargazers","contributors_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/contributors","subscribers_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/subscribers","subscription_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/subscription","commits_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/contents/{+path}","compare_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/merges","archive_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/downloads","issues_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/issues{/number}","pulls_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/pulls{/number}","milestones_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/milestones{/number}","notifications_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/labels{/name}","releases_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/releases{/id}","deployments_url":"https://api.github.com/repos/Sententiaregum/Sententiaregum/deployments","created_at":"2015-09-13T17:01:22Z","updated_at":"2016-12-09T22:46:34Z","pushed_at":"2016-12-30T17:41:26Z","git_url":"git://github.com/Sententiaregum/Sententiaregum.git","ssh_url":"git@github.com:Sententiaregum/Sententiaregum.git","clone_url":"https://github.com/Sententiaregum/Sententiaregum.git","svn_url":"https://github.com/Sententiaregum/Sententiaregum","homepage":"","size":1195,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":25,"forks":3,"open_issues":25,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sententiaregum/Sententiaregum/pulls/359"},"html":{"href":"https://github.com/Sententiaregum/Sententiaregum/pull/359"},"issue":{"href":"https://api.github.com/repos/Sententiaregum/Sententiaregum/issues/359"},"comments":{"href":"https://api.github.com/repos/Sententiaregum/Sententiaregum/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/Sententiaregum/Sententiaregum/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/Sententiaregum/Sententiaregum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sententiaregum/Sententiaregum/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/Sententiaregum/Sententiaregum/statuses/ac12f3a3bcfe9bfe1bb5c67ac5d78b9b4fc6ebee"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Ma27","id":6025220,"avatar_url":"https://avatars.githubusercontent.com/u/6025220?v=3","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"comments":3,"review_comments":10,"maintainer_can_modify":false,"commits":14,"additions":666,"deletions":2501,"changed_files":28}}
{"actor":{"display_login":"Ma27"}}