{"action":"created","issue":{"url":"https://api.github.com/repos/urho3d/Urho3D/issues/1253","repository_url":"https://api.github.com/repos/urho3d/Urho3D","labels_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1253/labels{/name}","comments_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1253/comments","events_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1253/events","html_url":"https://github.com/urho3d/Urho3D/pull/1253","id":141663220,"number":1253,"title":"Applied patch to fix undefined reference error when compiling for Wayland on Linux.","user":{"login":"GKR","id":143604,"avatar_url":"https://avatars.githubusercontent.com/u/143604?v=3","gravatar_id":"","url":"https://api.github.com/users/GKR","html_url":"https://github.com/GKR","followers_url":"https://api.github.com/users/GKR/followers","following_url":"https://api.github.com/users/GKR/following{/other_user}","gists_url":"https://api.github.com/users/GKR/gists{/gist_id}","starred_url":"https://api.github.com/users/GKR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GKR/subscriptions","organizations_url":"https://api.github.com/users/GKR/orgs","repos_url":"https://api.github.com/users/GKR/repos","events_url":"https://api.github.com/users/GKR/events{/privacy}","received_events_url":"https://api.github.com/users/GKR/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-17T18:10:07Z","updated_at":"2016-03-18T09:35:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/urho3d/Urho3D/pulls/1253","html_url":"https://github.com/urho3d/Urho3D/pull/1253","diff_url":"https://github.com/urho3d/Urho3D/pull/1253.diff","patch_url":"https://github.com/urho3d/Urho3D/pull/1253.patch"},"body":"Applied patch to fix undefined reference error when compiling for Wayland (1.10) on Linux.\r\n\r\nThis has been fixed in SDL, but no SDL release has been made that includes this fix.\r\n\r\nThe SDL fix can be found here:\r\nhttps://hg.libsdl.org/SDL/rev/330f500d5815\r\n\r\nIn the mean time, this fixes Urho3D compilation on Linux.\r\n\r\n```\r\n[ 74%] Linking CXX executable ../../../bin/Urho3DPlayer\r\n../../../lib/libUrho3D.a(SDL_waylandvideo.c.o): In function `display_handle_global':\r\nSDL_waylandvideo.c:(.text+0x593): undefined reference to `wl_proxy_marshal_constructor_versioned'\r\nSDL_waylandvideo.c:(.text+0x5d4): undefined reference to `wl_proxy_marshal_constructor_versioned'\r\nSDL_waylandvideo.c:(.text+0x61d): undefined reference to `wl_proxy_marshal_constructor_versioned'\r\nSDL_waylandvideo.c:(.text+0x684): undefined reference to `wl_proxy_marshal_constructor_versioned'\r\nSDL_waylandvideo.c:(.text+0x6cc): undefined reference to `wl_proxy_marshal_constructor_versioned'\r\n../../../lib/libUrho3D.a(SDL_waylandvideo.c.o):SDL_waylandvideo.c:(.text+0x6fb): more undefined references to `wl_proxy_marshal_constructor_versioned' follow\r\ncollect2: error: ld returned 1 exit status\r\nSource/Tools/Urho3DPlayer/CMakeFiles/Urho3DPlayer.dir/build.make:95: recipe for target 'bin/Urho3DPlayer' failed\r\nmake[2]: *** [bin/Urho3DPlayer] Error 1\r\nCMakeFiles/Makefile2:1282: recipe for target 'Source/Tools/Urho3DPlayer/CMakeFiles/Urho3DPlayer.dir/all' failed\r\nmake[1]: *** [Source/Tools/Urho3DPlayer/CMakeFiles/Urho3DPlayer.dir/all] Error 2\r\nMakefile:149: recipe for target 'all' failed\r\nmake: *** [all] Error 2\r\n```"},"comment":{"url":"https://api.github.com/repos/urho3d/Urho3D/issues/comments/198276120","html_url":"https://github.com/urho3d/Urho3D/pull/1253#issuecomment-198276120","issue_url":"https://api.github.com/repos/urho3d/Urho3D/issues/1253","id":198276120,"user":{"login":"cadaver","id":51361,"avatar_url":"https://avatars.githubusercontent.com/u/51361?v=3","gravatar_id":"","url":"https://api.github.com/users/cadaver","html_url":"https://github.com/cadaver","followers_url":"https://api.github.com/users/cadaver/followers","following_url":"https://api.github.com/users/cadaver/following{/other_user}","gists_url":"https://api.github.com/users/cadaver/gists{/gist_id}","starred_url":"https://api.github.com/users/cadaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cadaver/subscriptions","organizations_url":"https://api.github.com/users/cadaver/orgs","repos_url":"https://api.github.com/users/cadaver/repos","events_url":"https://api.github.com/users/cadaver/events{/privacy}","received_events_url":"https://api.github.com/users/cadaver/received_events","type":"User","site_admin":false},"created_at":"2016-03-18T09:35:16Z","updated_at":"2016-03-18T09:35:16Z","body":"@weitjong What is the best approach now? To cherrypick this commit from the SDL mirror and update the subtree, rather than applying this PR directly?"}}