{"action":"created","issue":{"url":"https://api.github.com/repos/boto/boto/issues/1477","repository_url":"https://api.github.com/repos/boto/boto","labels_url":"https://api.github.com/repos/boto/boto/issues/1477/labels{/name}","comments_url":"https://api.github.com/repos/boto/boto/issues/1477/comments","events_url":"https://api.github.com/repos/boto/boto/issues/1477/events","html_url":"https://github.com/boto/boto/issues/1477","id":13972188,"number":1477,"title":"s3.generate_url appends x-amz-security-token to query string even when query_auth=False","user":{"login":"nakedible","id":445682,"avatar_url":"https://avatars.githubusercontent.com/u/445682?v=3","gravatar_id":"","url":"https://api.github.com/users/nakedible","html_url":"https://github.com/nakedible","followers_url":"https://api.github.com/users/nakedible/followers","following_url":"https://api.github.com/users/nakedible/following{/other_user}","gists_url":"https://api.github.com/users/nakedible/gists{/gist_id}","starred_url":"https://api.github.com/users/nakedible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakedible/subscriptions","organizations_url":"https://api.github.com/users/nakedible/orgs","repos_url":"https://api.github.com/users/nakedible/repos","events_url":"https://api.github.com/users/nakedible/events{/privacy}","received_events_url":"https://api.github.com/users/nakedible/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/boto/boto/labels/accepted","name":"accepted","color":"d4c5f9"},{"url":"https://api.github.com/repos/boto/boto/labels/bug","name":"bug","color":"e10c02"},{"url":"https://api.github.com/repos/boto/boto/labels/Needs%20Implementation","name":"Needs Implementation","color":"bfdadc"},{"url":"https://api.github.com/repos/boto/boto/labels/s3","name":"s3","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2013-05-05T00:12:48Z","updated_at":"2016-06-30T21:32:30Z","closed_at":null,"body":"It seems s3.generate_url will produce a url with a query parameter x-amz-security-token if the current auth provider has a security token even when passing query_auth=False. This url is totally non-working as it has the x-amz-security-token parameter, but none of the other authentication parameters."},"comment":{"url":"https://api.github.com/repos/boto/boto/issues/comments/229795232","html_url":"https://github.com/boto/boto/issues/1477#issuecomment-229795232","issue_url":"https://api.github.com/repos/boto/boto/issues/1477","id":229795232,"user":{"login":"joshma","id":64739,"avatar_url":"https://avatars.githubusercontent.com/u/64739?v=3","gravatar_id":"","url":"https://api.github.com/users/joshma","html_url":"https://github.com/joshma","followers_url":"https://api.github.com/users/joshma/followers","following_url":"https://api.github.com/users/joshma/following{/other_user}","gists_url":"https://api.github.com/users/joshma/gists{/gist_id}","starred_url":"https://api.github.com/users/joshma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshma/subscriptions","organizations_url":"https://api.github.com/users/joshma/orgs","repos_url":"https://api.github.com/users/joshma/repos","events_url":"https://api.github.com/users/joshma/events{/privacy}","received_events_url":"https://api.github.com/users/joshma/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T21:32:30Z","updated_at":"2016-06-30T21:32:30Z","body":"@gholms if `query_auth=False`, won't https://github.com/boto/boto/commit/43217f97d3e7367e5e9b3dbb694381b4ede51125 not affect this particular codepath? It looks like it's still hitting https://github.com/boto/boto/blob/43217f97d3e7367e5e9b3dbb694381b4ede51125/boto/s3/connection.py#L422 - the headers are added to the query part still."}}
{"actor":{"display_login":"joshma"}}