{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/comments/84976517","pull_request_review_id":5720193,"id":84976517,"diff_hunk":"@@ -489,6 +489,8 @@ std::string HelpMessage(HelpMessageMode mode)\n     strUsage += HelpMessageOpt(\"-bytespersigop\", strprintf(_(\"Minimum bytes per sigop in transactions we relay and mine (default: %u)\"), DEFAULT_BYTES_PER_SIGOP));\n     strUsage += HelpMessageOpt(\"-datacarrier\", strprintf(_(\"Relay and mine data carrier transactions (default: %u)\"), DEFAULT_ACCEPT_DATACARRIER));\n     strUsage += HelpMessageOpt(\"-datacarriersize\", strprintf(_(\"Maximum size of data in data carrier transactions we relay and mine (default: %u)\"), MAX_OP_RETURN_RELAY));\n+    // called excessiveblocksize in BU","path":"src/init.cpp","position":4,"original_position":4,"commit_id":"afbbf92223b960992aa9cf1dd6e1e4ccfd5c6e1c","original_commit_id":"afbbf92223b960992aa9cf1dd6e1e4ccfd5c6e1c","user":{"login":"dskloet","id":6271274,"avatar_url":"https://avatars.githubusercontent.com/u/6271274?v=3","gravatar_id":"","url":"https://api.github.com/users/dskloet","html_url":"https://github.com/dskloet","followers_url":"https://api.github.com/users/dskloet/followers","following_url":"https://api.github.com/users/dskloet/following{/other_user}","gists_url":"https://api.github.com/users/dskloet/gists{/gist_id}","starred_url":"https://api.github.com/users/dskloet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dskloet/subscriptions","organizations_url":"https://api.github.com/users/dskloet/orgs","repos_url":"https://api.github.com/users/dskloet/repos","events_url":"https://api.github.com/users/dskloet/events{/privacy}","received_events_url":"https://api.github.com/users/dskloet/received_events","type":"User","site_admin":false},"body":"Why abbreviate Bitcoin Unlimited? It might be less clear in some future.","created_at":"2016-10-25T19:00:34Z","updated_at":"2016-10-25T19:00:34Z","html_url":"https://github.com/bitcoinclassic/bitcoinclassic/pull/191#discussion_r84976517","pull_request_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/comments/84976517"},"html":{"href":"https://github.com/bitcoinclassic/bitcoinclassic/pull/191#discussion_r84976517"},"pull_request":{"href":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/191","id":90800184,"html_url":"https://github.com/bitcoinclassic/bitcoinclassic/pull/191","diff_url":"https://github.com/bitcoinclassic/bitcoinclassic/pull/191.diff","patch_url":"https://github.com/bitcoinclassic/bitcoinclassic/pull/191.patch","issue_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/191","number":191,"state":"open","locked":false,"title":"Big blocks","user":{"login":"zander","id":63063,"avatar_url":"https://avatars.githubusercontent.com/u/63063?v=3","gravatar_id":"","url":"https://api.github.com/users/zander","html_url":"https://github.com/zander","followers_url":"https://api.github.com/users/zander/followers","following_url":"https://api.github.com/users/zander/following{/other_user}","gists_url":"https://api.github.com/users/zander/gists{/gist_id}","starred_url":"https://api.github.com/users/zander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zander/subscriptions","organizations_url":"https://api.github.com/users/zander/orgs","repos_url":"https://api.github.com/users/zander/repos","events_url":"https://api.github.com/users/zander/events{/privacy}","received_events_url":"https://api.github.com/users/zander/received_events","type":"User","site_admin":false},"body":"This reverts BIP109. Classic will no longer vote for BIP109.\r\n    \r\nThis reuses the code and starts voting for a new bit which is a protocol\r\nupgrade and the only change in that one is that the maximum block size is\r\nremoved.\r\n    \r\nThis new fork is activated using bit 26, while requiring signalling for\r\nBIP9 making the block version 0x28000000 When 85% of 1000 blocks have this\r\nbit set we lock in this change and have a 4 week wait period.\r\nAfter that period blocks no longer have a size limit.\r\n    \r\nMiners can continue to use the -blockmaxsize argument or bitcoin.conf\r\nsetting to limit the size of blocks they generate!  All nodes can also use\r\nthe `-blocksizeacceptlimit` option to limit the size of the blocks accepted\r\nfrom other miners.\r\n\r\nThis change simplifies some of the designs that were introduced for BIP9, like the overloading of the  IsSuperMajority method and the txdb getter/setter is now made substantially simpler too. Overdesigns are good to remove.\r\n\r\nTo be able to be 'ready' for a spontaneous fork Bitcoin Classic removes the check for max block size even if the upgrade has not been triggered (which triggers a removal of a unit test).\r\n\r\nLast, I moved the fork-bit to be namespaced inside CBlockHeader, being a tiny little bit more structured instead of everything in the global namespace.","created_at":"2016-10-25T12:46:15Z","updated_at":"2016-10-25T19:00:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bbb6c32537781cc58987a73d95426373963aa7d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/191/commits","review_comments_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/191/comments","review_comment_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/191/comments","statuses_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/statuses/afbbf92223b960992aa9cf1dd6e1e4ccfd5c6e1c","head":{"label":"zander:bigBlocks","ref":"bigBlocks","sha":"afbbf92223b960992aa9cf1dd6e1e4ccfd5c6e1c","user":{"login":"zander","id":63063,"avatar_url":"https://avatars.githubusercontent.com/u/63063?v=3","gravatar_id":"","url":"https://api.github.com/users/zander","html_url":"https://github.com/zander","followers_url":"https://api.github.com/users/zander/followers","following_url":"https://api.github.com/users/zander/following{/other_user}","gists_url":"https://api.github.com/users/zander/gists{/gist_id}","starred_url":"https://api.github.com/users/zander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zander/subscriptions","organizations_url":"https://api.github.com/users/zander/orgs","repos_url":"https://api.github.com/users/zander/repos","events_url":"https://api.github.com/users/zander/events{/privacy}","received_events_url":"https://api.github.com/users/zander/received_events","type":"User","site_admin":false},"repo":{"id":50025342,"name":"bitcoinclassic","full_name":"zander/bitcoinclassic","owner":{"login":"zander","id":63063,"avatar_url":"https://avatars.githubusercontent.com/u/63063?v=3","gravatar_id":"","url":"https://api.github.com/users/zander","html_url":"https://github.com/zander","followers_url":"https://api.github.com/users/zander/followers","following_url":"https://api.github.com/users/zander/following{/other_user}","gists_url":"https://api.github.com/users/zander/gists{/gist_id}","starred_url":"https://api.github.com/users/zander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zander/subscriptions","organizations_url":"https://api.github.com/users/zander/orgs","repos_url":"https://api.github.com/users/zander/repos","events_url":"https://api.github.com/users/zander/events{/privacy}","received_events_url":"https://api.github.com/users/zander/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zander/bitcoinclassic","description":"Bitcoin sources","fork":true,"url":"https://api.github.com/repos/zander/bitcoinclassic","forks_url":"https://api.github.com/repos/zander/bitcoinclassic/forks","keys_url":"https://api.github.com/repos/zander/bitcoinclassic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zander/bitcoinclassic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zander/bitcoinclassic/teams","hooks_url":"https://api.github.com/repos/zander/bitcoinclassic/hooks","issue_events_url":"https://api.github.com/repos/zander/bitcoinclassic/issues/events{/number}","events_url":"https://api.github.com/repos/zander/bitcoinclassic/events","assignees_url":"https://api.github.com/repos/zander/bitcoinclassic/assignees{/user}","branches_url":"https://api.github.com/repos/zander/bitcoinclassic/branches{/branch}","tags_url":"https://api.github.com/repos/zander/bitcoinclassic/tags","blobs_url":"https://api.github.com/repos/zander/bitcoinclassic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zander/bitcoinclassic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zander/bitcoinclassic/git/refs{/sha}","trees_url":"https://api.github.com/repos/zander/bitcoinclassic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zander/bitcoinclassic/statuses/{sha}","languages_url":"https://api.github.com/repos/zander/bitcoinclassic/languages","stargazers_url":"https://api.github.com/repos/zander/bitcoinclassic/stargazers","contributors_url":"https://api.github.com/repos/zander/bitcoinclassic/contributors","subscribers_url":"https://api.github.com/repos/zander/bitcoinclassic/subscribers","subscription_url":"https://api.github.com/repos/zander/bitcoinclassic/subscription","commits_url":"https://api.github.com/repos/zander/bitcoinclassic/commits{/sha}","git_commits_url":"https://api.github.com/repos/zander/bitcoinclassic/git/commits{/sha}","comments_url":"https://api.github.com/repos/zander/bitcoinclassic/comments{/number}","issue_comment_url":"https://api.github.com/repos/zander/bitcoinclassic/issues/comments{/number}","contents_url":"https://api.github.com/repos/zander/bitcoinclassic/contents/{+path}","compare_url":"https://api.github.com/repos/zander/bitcoinclassic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zander/bitcoinclassic/merges","archive_url":"https://api.github.com/repos/zander/bitcoinclassic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zander/bitcoinclassic/downloads","issues_url":"https://api.github.com/repos/zander/bitcoinclassic/issues{/number}","pulls_url":"https://api.github.com/repos/zander/bitcoinclassic/pulls{/number}","milestones_url":"https://api.github.com/repos/zander/bitcoinclassic/milestones{/number}","notifications_url":"https://api.github.com/repos/zander/bitcoinclassic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zander/bitcoinclassic/labels{/name}","releases_url":"https://api.github.com/repos/zander/bitcoinclassic/releases{/id}","deployments_url":"https://api.github.com/repos/zander/bitcoinclassic/deployments","created_at":"2016-01-20T11:20:17Z","updated_at":"2016-10-25T11:06:55Z","pushed_at":"2016-10-25T16:49:44Z","git_url":"git://github.com/zander/bitcoinclassic.git","ssh_url":"git@github.com:zander/bitcoinclassic.git","clone_url":"https://github.com/zander/bitcoinclassic.git","svn_url":"https://github.com/zander/bitcoinclassic","homepage":"","size":58494,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"bitcoinclassic:develop","ref":"develop","sha":"63648e2cb7ffdf5b9d30f7504e018967da2144eb","user":{"login":"bitcoinclassic","id":16547401,"avatar_url":"https://avatars.githubusercontent.com/u/16547401?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinclassic","html_url":"https://github.com/bitcoinclassic","followers_url":"https://api.github.com/users/bitcoinclassic/followers","following_url":"https://api.github.com/users/bitcoinclassic/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinclassic/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinclassic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinclassic/subscriptions","organizations_url":"https://api.github.com/users/bitcoinclassic/orgs","repos_url":"https://api.github.com/users/bitcoinclassic/repos","events_url":"https://api.github.com/users/bitcoinclassic/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinclassic/received_events","type":"Organization","site_admin":false},"repo":{"id":49230227,"name":"bitcoinclassic","full_name":"bitcoinclassic/bitcoinclassic","owner":{"login":"bitcoinclassic","id":16547401,"avatar_url":"https://avatars.githubusercontent.com/u/16547401?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinclassic","html_url":"https://github.com/bitcoinclassic","followers_url":"https://api.github.com/users/bitcoinclassic/followers","following_url":"https://api.github.com/users/bitcoinclassic/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinclassic/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinclassic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinclassic/subscriptions","organizations_url":"https://api.github.com/users/bitcoinclassic/orgs","repos_url":"https://api.github.com/users/bitcoinclassic/repos","events_url":"https://api.github.com/users/bitcoinclassic/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinclassic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinclassic/bitcoinclassic","description":"Bitcoin Classic integration/staging tree","fork":true,"url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic","forks_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/forks","keys_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/teams","hooks_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/hooks","issue_events_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/events","assignees_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/tags","blobs_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/languages","stargazers_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/stargazers","contributors_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/contributors","subscribers_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/subscribers","subscription_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/subscription","commits_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/merges","archive_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/downloads","issues_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/deployments","created_at":"2016-01-07T20:55:02Z","updated_at":"2016-10-25T13:43:42Z","pushed_at":"2016-10-25T16:49:44Z","git_url":"git://github.com/bitcoinclassic/bitcoinclassic.git","ssh_url":"git@github.com:bitcoinclassic/bitcoinclassic.git","clone_url":"https://github.com/bitcoinclassic/bitcoinclassic.git","svn_url":"https://github.com/bitcoinclassic/bitcoinclassic","homepage":"https://bitcoinclassic.com","size":67751,"stargazers_count":400,"watchers_count":400,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":6,"forks":75,"open_issues":6,"watchers":400,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/191"},"html":{"href":"https://github.com/bitcoinclassic/bitcoinclassic/pull/191"},"issue":{"href":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/191"},"comments":{"href":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/statuses/afbbf92223b960992aa9cf1dd6e1e4ccfd5c6e1c"}}}}
{"actor":{"display_login":"dskloet"}}