{"action":"created","comment":{"url":"https://api.github.com/repos/uxmal/reko/pulls/comments/73803533","id":73803533,"diff_hunk":"@@ -39,19 +40,22 @@ public class ArgumentDeserializerTests\n         private ProcedureSerializer sigser;\n         private ArgumentDeserializer argser;\n         private MsdosPlatform platform;\n+        private MockRepository mr;\n \n         [SetUp]\n         public void Setup()\n         {\n+            mr = new MockRepository();\n             var sc = new ServiceContainer();\n             sc.AddService<IFileSystemService>(new FileSystemServiceImpl());\n             arch = new X86ArchitectureReal();\n             platform = new MsdosPlatform(sc, arch);\n-            sigser = new X86ProcedureSerializer(\n+            sigser = mr.Stub<ProcedureSerializer>(\n                 arch,\n                 new TypeLibraryDeserializer(platform, true, new TypeLibrary()),\n                 \"stdapi\");\n-            argser = new ArgumentDeserializer(sigser, arch, arch.CreateFrame(), 4);\n+            argser = new ArgumentDeserializer(sigser, arch, arch.CreateFrame(), 13);","path":"src/UnitTests/Core/Serialization/ArgumentDeserializerTests.cs","position":28,"original_position":28,"commit_id":"c9c93dca62cb067d6fdb1eb60cf11f89cf240580","original_commit_id":"c9c93dca62cb067d6fdb1eb60cf11f89cf240580","user":{"login":"ptomin","id":13188041,"avatar_url":"https://avatars.githubusercontent.com/u/13188041?v=3","gravatar_id":"","url":"https://api.github.com/users/ptomin","html_url":"https://github.com/ptomin","followers_url":"https://api.github.com/users/ptomin/followers","following_url":"https://api.github.com/users/ptomin/following{/other_user}","gists_url":"https://api.github.com/users/ptomin/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomin/subscriptions","organizations_url":"https://api.github.com/users/ptomin/orgs","repos_url":"https://api.github.com/users/ptomin/repos","events_url":"https://api.github.com/users/ptomin/events{/privacy}","received_events_url":"https://api.github.com/users/ptomin/received_events","type":"User","site_admin":false},"body":"ArgumentDeserializer does not know that stack aligned pointers should have offsets divisible by 4. It should just allocate variables on stack starting from return address size. Is not it?","created_at":"2016-08-07T15:09:29Z","updated_at":"2016-08-07T15:09:30Z","html_url":"https://github.com/uxmal/reko/pull/287#discussion_r73803533","pull_request_url":"https://api.github.com/repos/uxmal/reko/pulls/287","_links":{"self":{"href":"https://api.github.com/repos/uxmal/reko/pulls/comments/73803533"},"html":{"href":"https://github.com/uxmal/reko/pull/287#discussion_r73803533"},"pull_request":{"href":"https://api.github.com/repos/uxmal/reko/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/uxmal/reko/pulls/287","id":80340336,"html_url":"https://github.com/uxmal/reko/pull/287","diff_url":"https://github.com/uxmal/reko/pull/287.diff","patch_url":"https://github.com/uxmal/reko/pull/287.patch","issue_url":"https://api.github.com/repos/uxmal/reko/issues/287","number":287,"state":"open","locked":false,"title":"Create unit tests to verify problems with stack offsets","user":{"login":"ptomin","id":13188041,"avatar_url":"https://avatars.githubusercontent.com/u/13188041?v=3","gravatar_id":"","url":"https://api.github.com/users/ptomin","html_url":"https://github.com/ptomin","followers_url":"https://api.github.com/users/ptomin/followers","following_url":"https://api.github.com/users/ptomin/following{/other_user}","gists_url":"https://api.github.com/users/ptomin/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomin/subscriptions","organizations_url":"https://api.github.com/users/ptomin/orgs","repos_url":"https://api.github.com/users/ptomin/repos","events_url":"https://api.github.com/users/ptomin/events{/privacy}","received_events_url":"https://api.github.com/users/ptomin/received_events","type":"User","site_admin":false},"body":"I have created unit test for `ArgumentDeserializer` and modify one more test to verify one of the problem mentioned in #286. I have marked them as `FailedTest` to avoid failure of Travis CI","created_at":"2016-08-06T13:33:15Z","updated_at":"2016-08-07T15:09:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c419284aa40672a7b00e2b2d0561a4c4bac344c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uxmal/reko/pulls/287/commits","review_comments_url":"https://api.github.com/repos/uxmal/reko/pulls/287/comments","review_comment_url":"https://api.github.com/repos/uxmal/reko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uxmal/reko/issues/287/comments","statuses_url":"https://api.github.com/repos/uxmal/reko/statuses/c9c93dca62cb067d6fdb1eb60cf11f89cf240580","head":{"label":"ptomin:stack-vars-unit-tests","ref":"stack-vars-unit-tests","sha":"c9c93dca62cb067d6fdb1eb60cf11f89cf240580","user":{"login":"ptomin","id":13188041,"avatar_url":"https://avatars.githubusercontent.com/u/13188041?v=3","gravatar_id":"","url":"https://api.github.com/users/ptomin","html_url":"https://github.com/ptomin","followers_url":"https://api.github.com/users/ptomin/followers","following_url":"https://api.github.com/users/ptomin/following{/other_user}","gists_url":"https://api.github.com/users/ptomin/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomin/subscriptions","organizations_url":"https://api.github.com/users/ptomin/orgs","repos_url":"https://api.github.com/users/ptomin/repos","events_url":"https://api.github.com/users/ptomin/events{/privacy}","received_events_url":"https://api.github.com/users/ptomin/received_events","type":"User","site_admin":false},"repo":{"id":48247195,"name":"reko","full_name":"ptomin/reko","owner":{"login":"ptomin","id":13188041,"avatar_url":"https://avatars.githubusercontent.com/u/13188041?v=3","gravatar_id":"","url":"https://api.github.com/users/ptomin","html_url":"https://github.com/ptomin","followers_url":"https://api.github.com/users/ptomin/followers","following_url":"https://api.github.com/users/ptomin/following{/other_user}","gists_url":"https://api.github.com/users/ptomin/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomin/subscriptions","organizations_url":"https://api.github.com/users/ptomin/orgs","repos_url":"https://api.github.com/users/ptomin/repos","events_url":"https://api.github.com/users/ptomin/events{/privacy}","received_events_url":"https://api.github.com/users/ptomin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ptomin/reko","description":"Reko is a binary decompiler.","fork":true,"url":"https://api.github.com/repos/ptomin/reko","forks_url":"https://api.github.com/repos/ptomin/reko/forks","keys_url":"https://api.github.com/repos/ptomin/reko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ptomin/reko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ptomin/reko/teams","hooks_url":"https://api.github.com/repos/ptomin/reko/hooks","issue_events_url":"https://api.github.com/repos/ptomin/reko/issues/events{/number}","events_url":"https://api.github.com/repos/ptomin/reko/events","assignees_url":"https://api.github.com/repos/ptomin/reko/assignees{/user}","branches_url":"https://api.github.com/repos/ptomin/reko/branches{/branch}","tags_url":"https://api.github.com/repos/ptomin/reko/tags","blobs_url":"https://api.github.com/repos/ptomin/reko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ptomin/reko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ptomin/reko/git/refs{/sha}","trees_url":"https://api.github.com/repos/ptomin/reko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ptomin/reko/statuses/{sha}","languages_url":"https://api.github.com/repos/ptomin/reko/languages","stargazers_url":"https://api.github.com/repos/ptomin/reko/stargazers","contributors_url":"https://api.github.com/repos/ptomin/reko/contributors","subscribers_url":"https://api.github.com/repos/ptomin/reko/subscribers","subscription_url":"https://api.github.com/repos/ptomin/reko/subscription","commits_url":"https://api.github.com/repos/ptomin/reko/commits{/sha}","git_commits_url":"https://api.github.com/repos/ptomin/reko/git/commits{/sha}","comments_url":"https://api.github.com/repos/ptomin/reko/comments{/number}","issue_comment_url":"https://api.github.com/repos/ptomin/reko/issues/comments{/number}","contents_url":"https://api.github.com/repos/ptomin/reko/contents/{+path}","compare_url":"https://api.github.com/repos/ptomin/reko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ptomin/reko/merges","archive_url":"https://api.github.com/repos/ptomin/reko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ptomin/reko/downloads","issues_url":"https://api.github.com/repos/ptomin/reko/issues{/number}","pulls_url":"https://api.github.com/repos/ptomin/reko/pulls{/number}","milestones_url":"https://api.github.com/repos/ptomin/reko/milestones{/number}","notifications_url":"https://api.github.com/repos/ptomin/reko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ptomin/reko/labels{/name}","releases_url":"https://api.github.com/repos/ptomin/reko/releases{/id}","deployments_url":"https://api.github.com/repos/ptomin/reko/deployments","created_at":"2015-12-18T17:15:47Z","updated_at":"2016-04-24T08:20:54Z","pushed_at":"2016-08-07T14:51:05Z","git_url":"git://github.com/ptomin/reko.git","ssh_url":"git@github.com:ptomin/reko.git","clone_url":"https://github.com/ptomin/reko.git","svn_url":"https://github.com/ptomin/reko","homepage":"https://uxmal.github.io/reko","size":65981,"stargazers_count":2,"watchers_count":2,"language":"Assembly","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"uxmal:master","ref":"master","sha":"65fb7da9e1cef822e4d820edafd367d03aac9779","user":{"login":"uxmal","id":10154465,"avatar_url":"https://avatars.githubusercontent.com/u/10154465?v=3","gravatar_id":"","url":"https://api.github.com/users/uxmal","html_url":"https://github.com/uxmal","followers_url":"https://api.github.com/users/uxmal/followers","following_url":"https://api.github.com/users/uxmal/following{/other_user}","gists_url":"https://api.github.com/users/uxmal/gists{/gist_id}","starred_url":"https://api.github.com/users/uxmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uxmal/subscriptions","organizations_url":"https://api.github.com/users/uxmal/orgs","repos_url":"https://api.github.com/users/uxmal/repos","events_url":"https://api.github.com/users/uxmal/events{/privacy}","received_events_url":"https://api.github.com/users/uxmal/received_events","type":"User","site_admin":false},"repo":{"id":39718308,"name":"reko","full_name":"uxmal/reko","owner":{"login":"uxmal","id":10154465,"avatar_url":"https://avatars.githubusercontent.com/u/10154465?v=3","gravatar_id":"","url":"https://api.github.com/users/uxmal","html_url":"https://github.com/uxmal","followers_url":"https://api.github.com/users/uxmal/followers","following_url":"https://api.github.com/users/uxmal/following{/other_user}","gists_url":"https://api.github.com/users/uxmal/gists{/gist_id}","starred_url":"https://api.github.com/users/uxmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uxmal/subscriptions","organizations_url":"https://api.github.com/users/uxmal/orgs","repos_url":"https://api.github.com/users/uxmal/repos","events_url":"https://api.github.com/users/uxmal/events{/privacy}","received_events_url":"https://api.github.com/users/uxmal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uxmal/reko","description":"Reko is a binary decompiler.","fork":false,"url":"https://api.github.com/repos/uxmal/reko","forks_url":"https://api.github.com/repos/uxmal/reko/forks","keys_url":"https://api.github.com/repos/uxmal/reko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uxmal/reko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uxmal/reko/teams","hooks_url":"https://api.github.com/repos/uxmal/reko/hooks","issue_events_url":"https://api.github.com/repos/uxmal/reko/issues/events{/number}","events_url":"https://api.github.com/repos/uxmal/reko/events","assignees_url":"https://api.github.com/repos/uxmal/reko/assignees{/user}","branches_url":"https://api.github.com/repos/uxmal/reko/branches{/branch}","tags_url":"https://api.github.com/repos/uxmal/reko/tags","blobs_url":"https://api.github.com/repos/uxmal/reko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uxmal/reko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uxmal/reko/git/refs{/sha}","trees_url":"https://api.github.com/repos/uxmal/reko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uxmal/reko/statuses/{sha}","languages_url":"https://api.github.com/repos/uxmal/reko/languages","stargazers_url":"https://api.github.com/repos/uxmal/reko/stargazers","contributors_url":"https://api.github.com/repos/uxmal/reko/contributors","subscribers_url":"https://api.github.com/repos/uxmal/reko/subscribers","subscription_url":"https://api.github.com/repos/uxmal/reko/subscription","commits_url":"https://api.github.com/repos/uxmal/reko/commits{/sha}","git_commits_url":"https://api.github.com/repos/uxmal/reko/git/commits{/sha}","comments_url":"https://api.github.com/repos/uxmal/reko/comments{/number}","issue_comment_url":"https://api.github.com/repos/uxmal/reko/issues/comments{/number}","contents_url":"https://api.github.com/repos/uxmal/reko/contents/{+path}","compare_url":"https://api.github.com/repos/uxmal/reko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uxmal/reko/merges","archive_url":"https://api.github.com/repos/uxmal/reko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uxmal/reko/downloads","issues_url":"https://api.github.com/repos/uxmal/reko/issues{/number}","pulls_url":"https://api.github.com/repos/uxmal/reko/pulls{/number}","milestones_url":"https://api.github.com/repos/uxmal/reko/milestones{/number}","notifications_url":"https://api.github.com/repos/uxmal/reko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uxmal/reko/labels{/name}","releases_url":"https://api.github.com/repos/uxmal/reko/releases{/id}","deployments_url":"https://api.github.com/repos/uxmal/reko/deployments","created_at":"2015-07-26T07:58:30Z","updated_at":"2016-08-06T13:38:46Z","pushed_at":"2016-08-07T08:59:49Z","git_url":"git://github.com/uxmal/reko.git","ssh_url":"git@github.com:uxmal/reko.git","clone_url":"https://github.com/uxmal/reko.git","svn_url":"https://github.com/uxmal/reko","homepage":"https://uxmal.github.io/reko","size":75627,"stargazers_count":98,"watchers_count":98,"language":"Assembly","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":62,"forks":22,"open_issues":62,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uxmal/reko/pulls/287"},"html":{"href":"https://github.com/uxmal/reko/pull/287"},"issue":{"href":"https://api.github.com/repos/uxmal/reko/issues/287"},"comments":{"href":"https://api.github.com/repos/uxmal/reko/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/uxmal/reko/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/uxmal/reko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uxmal/reko/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/uxmal/reko/statuses/c9c93dca62cb067d6fdb1eb60cf11f89cf240580"}}}}
{"actor":{"display_login":"ptomin"}}