{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/81696873","pull_request_review_id":2657656,"id":81696873,"diff_hunk":"@@ -110,11 +125,13 @@ def install\n     ]\n \n     if build.with? \"openh264\"\n-      resource(\"openh264-1.5.0\").stage do\n-        system \"make\", \"install-shared\", \"PREFIX=#{libexec}/openh264-1.5.0\"\n-        chmod 0444, libexec/\"openh264-1.5.0/lib/libopenh264.dylib\"\n+      if build.stable?\n+        resource(\"openh264-1.5.0\").stage do\n+          system \"make\", \"install-shared\", \"PREFIX=#{libexec}/openh264-1.5.0\"\n+          chmod 0444, libexec/\"openh264-1.5.0/lib/libopenh264.dylib\"","path":"Formula/ffmpeg.rb","position":98,"original_position":97,"commit_id":"42ffafeda9ac67b7ed24fdc4ae28de3e793f80ee","original_commit_id":"cb6e39a9f13537500131fdd6e888108632735739","user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"body":"I think you can remove it unless it breaks things locally.","created_at":"2016-10-04T07:13:47Z","updated_at":"2016-10-04T07:13:47Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/5540#discussion_r81696873","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5540","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/81696873"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/5540#discussion_r81696873"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5540"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5540","id":87759574,"html_url":"https://github.com/Homebrew/homebrew-core/pull/5540","diff_url":"https://github.com/Homebrew/homebrew-core/pull/5540.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/5540.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5540","number":5540,"state":"open","locked":false,"title":"ffmpeg: fix head specific deps, refactor code into seperate specs","user":{"login":"JCount","id":18537310,"avatar_url":"https://avatars.githubusercontent.com/u/18537310?v=3","gravatar_id":"","url":"https://api.github.com/users/JCount","html_url":"https://github.com/JCount","followers_url":"https://api.github.com/users/JCount/followers","following_url":"https://api.github.com/users/JCount/following{/other_user}","gists_url":"https://api.github.com/users/JCount/gists{/gist_id}","starred_url":"https://api.github.com/users/JCount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JCount/subscriptions","organizations_url":"https://api.github.com/users/JCount/orgs","repos_url":"https://api.github.com/users/JCount/repos","events_url":"https://api.github.com/users/JCount/events{/privacy}","received_events_url":"https://api.github.com/users/JCount/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally prior to submission with `brew install <formula>` (where `<formula>` is the name of the formula you're submitting)?\r\n- [x] Does your submission pass `brew audit --new-formula <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\n`HEAD` has removed `sdl 1` support due to its EOL status, now requiring `sdl2` in order to build ffplay. Also, `HEAD` can now be built against brewed `openh264` (1.6.0), meaning it no longer has to rely on the vendor of `openh264 1.5.0`.\r\n\r\nI tried to handle these two points of divergence between `stable` and `head` by creating minimal `'spec' do` blocks, leaving by far the bulk of the of the option and dependency declarations as shared code. I tested building both with `--with-ffplay --with-openh264` and both built without errors. However, I do not know if this is proper usage of the Hombrew DSL, or even the proper approach to try and achieve this dependency(/option) separation.\r\n\r\nI am happy to do whatever revisions are necessary to make this work, just point me where I need to go.\r\n\r\nAlso, I did not attach a revision number because I honestly have no clue whether I should in this instance, so I decided to hold off and wait for feedback.","created_at":"2016-10-03T17:45:40Z","updated_at":"2016-10-04T07:13:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdd16c1368f949a035b3a2447683af24ba40c82c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5540/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5540/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5540/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/42ffafeda9ac67b7ed24fdc4ae28de3e793f80ee","head":{"label":"JCount:ffmpeg-fix-head","ref":"ffmpeg-fix-head","sha":"42ffafeda9ac67b7ed24fdc4ae28de3e793f80ee","user":{"login":"JCount","id":18537310,"avatar_url":"https://avatars.githubusercontent.com/u/18537310?v=3","gravatar_id":"","url":"https://api.github.com/users/JCount","html_url":"https://github.com/JCount","followers_url":"https://api.github.com/users/JCount/followers","following_url":"https://api.github.com/users/JCount/following{/other_user}","gists_url":"https://api.github.com/users/JCount/gists{/gist_id}","starred_url":"https://api.github.com/users/JCount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JCount/subscriptions","organizations_url":"https://api.github.com/users/JCount/orgs","repos_url":"https://api.github.com/users/JCount/repos","events_url":"https://api.github.com/users/JCount/events{/privacy}","received_events_url":"https://api.github.com/users/JCount/received_events","type":"User","site_admin":false},"repo":{"id":56944202,"name":"homebrew-core","full_name":"JCount/homebrew-core","owner":{"login":"JCount","id":18537310,"avatar_url":"https://avatars.githubusercontent.com/u/18537310?v=3","gravatar_id":"","url":"https://api.github.com/users/JCount","html_url":"https://github.com/JCount","followers_url":"https://api.github.com/users/JCount/followers","following_url":"https://api.github.com/users/JCount/following{/other_user}","gists_url":"https://api.github.com/users/JCount/gists{/gist_id}","starred_url":"https://api.github.com/users/JCount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JCount/subscriptions","organizations_url":"https://api.github.com/users/JCount/orgs","repos_url":"https://api.github.com/users/JCount/repos","events_url":"https://api.github.com/users/JCount/events{/privacy}","received_events_url":"https://api.github.com/users/JCount/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JCount/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/JCount/homebrew-core","forks_url":"https://api.github.com/repos/JCount/homebrew-core/forks","keys_url":"https://api.github.com/repos/JCount/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JCount/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JCount/homebrew-core/teams","hooks_url":"https://api.github.com/repos/JCount/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/JCount/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/JCount/homebrew-core/events","assignees_url":"https://api.github.com/repos/JCount/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/JCount/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/JCount/homebrew-core/tags","blobs_url":"https://api.github.com/repos/JCount/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JCount/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JCount/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/JCount/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JCount/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/JCount/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/JCount/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/JCount/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/JCount/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/JCount/homebrew-core/subscription","commits_url":"https://api.github.com/repos/JCount/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/JCount/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/JCount/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/JCount/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/JCount/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/JCount/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JCount/homebrew-core/merges","archive_url":"https://api.github.com/repos/JCount/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JCount/homebrew-core/downloads","issues_url":"https://api.github.com/repos/JCount/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/JCount/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/JCount/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/JCount/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JCount/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/JCount/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/JCount/homebrew-core/deployments","created_at":"2016-04-23T22:48:27Z","updated_at":"2016-04-24T01:21:50Z","pushed_at":"2016-10-03T19:39:29Z","git_url":"git://github.com/JCount/homebrew-core.git","ssh_url":"git@github.com:JCount/homebrew-core.git","clone_url":"https://github.com/JCount/homebrew-core.git","svn_url":"https://github.com/JCount/homebrew-core","homepage":"http://brew.sh","size":82686,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"6541fb946e5fbdfe92a93b87ba365ddac8bb7820","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2016-10-04T05:44:10Z","pushed_at":"2016-10-04T07:13:04Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"http://brew.sh","size":139018,"stargazers_count":850,"watchers_count":850,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1453,"mirror_url":null,"open_issues_count":162,"forks":1453,"open_issues":162,"watchers":850,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5540"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/5540"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5540"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5540/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5540/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5540/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/42ffafeda9ac67b7ed24fdc4ae28de3e793f80ee"}}}}
{"actor":{"display_login":"MikeMcQuaid"}}