{"action":"opened","issue":{"url":"https://api.github.com/repos/clarkbox/testswarm-browserstack/issues/47","repository_url":"https://api.github.com/repos/clarkbox/testswarm-browserstack","labels_url":"https://api.github.com/repos/clarkbox/testswarm-browserstack/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/clarkbox/testswarm-browserstack/issues/47/comments","events_url":"https://api.github.com/repos/clarkbox/testswarm-browserstack/issues/47/events","html_url":"https://github.com/clarkbox/testswarm-browserstack/issues/47","id":176256338,"number":47,"title":"`totalLimit` is not honored","user":{"login":"workmanw","id":825487,"avatar_url":"https://avatars.githubusercontent.com/u/825487?v=3","gravatar_id":"","url":"https://api.github.com/users/workmanw","html_url":"https://github.com/workmanw","followers_url":"https://api.github.com/users/workmanw/followers","following_url":"https://api.github.com/users/workmanw/following{/other_user}","gists_url":"https://api.github.com/users/workmanw/gists{/gist_id}","starred_url":"https://api.github.com/users/workmanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/workmanw/subscriptions","organizations_url":"https://api.github.com/users/workmanw/orgs","repos_url":"https://api.github.com/users/workmanw/repos","events_url":"https://api.github.com/users/workmanw/events{/privacy}","received_events_url":"https://api.github.com/users/workmanw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-11T18:08:16Z","updated_at":"2016-09-11T18:08:16Z","closed_at":null,"body":"I believe this to be a bug. If you see this segment of code, part of \"task 2\": [src/testswarm-browserstack.js#L601-L610](https://github.com/clarkbox/testswarm-browserstack/blob/846a55e3b5b7e0dc2cd96b39f31411369cfed212/src/testswarm-browserstack.js#L601-L610), you see it loops over the testswarm stats and spawns up browsers that are needed by testswarm.\r\n\r\nLater on in \"task 3\" though, it effectively does the same thing ([testswarm-browserstack.js#L664-L69](https://github.com/clarkbox/testswarm-browserstack/blob/846a55e3b5b7e0dc2cd96b39f31411369cfed212/src/testswarm-browserstack.js#L664-L691)), except this time it does actually honor the `totalLimit`. \r\n\r\nI would be happy to submit a PR to have \"task 2\" check `workerTotal() < config.browserstack.totalLimit`, but I'm kind of curious why it even exists. I see the code comment that explains it's goal is to ignore the queue and try to get stuff booted. But this effectively causes `totalLimit` to be completely useless. Am I missing something?\r\n"}}
{"actor":{"display_login":"workmanw"}}