{"action":"created","comment":{"url":"https://api.github.com/repos/grammarly/rocker/pulls/comments/70214126","id":70214126,"diff_hunk":"@@ -296,6 +296,8 @@ func buildCommand(c *cli.Context) {\n \t\tif !filepath.IsAbs(contextDir) {\n \t\t\tcontextDir = filepath.Join(wd, args[0])\n \t\t}\n+\t} else if contextDir != wd {\n+\t\tlog.Warningf(\"Default context directory is %s. You can specify context direcotry as the last argument.\", contextDir)","path":"main.go","position":5,"original_position":5,"commit_id":"a0c7ee3c39a4fec5e3b8ceed3b667f70a6cafcc2","original_commit_id":"a0c7ee3c39a4fec5e3b8ceed3b667f70a6cafcc2","user":{"login":"ybogdanov","id":292569,"avatar_url":"https://avatars.githubusercontent.com/u/292569?v=3","gravatar_id":"","url":"https://api.github.com/users/ybogdanov","html_url":"https://github.com/ybogdanov","followers_url":"https://api.github.com/users/ybogdanov/followers","following_url":"https://api.github.com/users/ybogdanov/following{/other_user}","gists_url":"https://api.github.com/users/ybogdanov/gists{/gist_id}","starred_url":"https://api.github.com/users/ybogdanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ybogdanov/subscriptions","organizations_url":"https://api.github.com/users/ybogdanov/orgs","repos_url":"https://api.github.com/users/ybogdanov/repos","events_url":"https://api.github.com/users/ybogdanov/events{/privacy}","received_events_url":"https://api.github.com/users/ybogdanov/received_events","type":"User","site_admin":false},"body":"I would say something like this:\r\n```\r\nlog.Warningf(\"Implicit context directory used: %s. You can override context directory using the last argument.\", contextDir)\r\n```","created_at":"2016-07-11T07:48:17Z","updated_at":"2016-07-11T07:48:17Z","html_url":"https://github.com/grammarly/rocker/pull/117#discussion_r70214126","pull_request_url":"https://api.github.com/repos/grammarly/rocker/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/grammarly/rocker/pulls/comments/70214126"},"html":{"href":"https://github.com/grammarly/rocker/pull/117#discussion_r70214126"},"pull_request":{"href":"https://api.github.com/repos/grammarly/rocker/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/grammarly/rocker/pulls/117","id":76874635,"html_url":"https://github.com/grammarly/rocker/pull/117","diff_url":"https://github.com/grammarly/rocker/pull/117.diff","patch_url":"https://github.com/grammarly/rocker/pull/117.patch","issue_url":"https://api.github.com/repos/grammarly/rocker/issues/117","number":117,"state":"open","locked":false,"title":"Warn about implicit contextDir change","user":{"login":"ctrlok","id":3265316,"avatar_url":"https://avatars.githubusercontent.com/u/3265316?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrlok","html_url":"https://github.com/ctrlok","followers_url":"https://api.github.com/users/ctrlok/followers","following_url":"https://api.github.com/users/ctrlok/following{/other_user}","gists_url":"https://api.github.com/users/ctrlok/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrlok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrlok/subscriptions","organizations_url":"https://api.github.com/users/ctrlok/orgs","repos_url":"https://api.github.com/users/ctrlok/repos","events_url":"https://api.github.com/users/ctrlok/events{/privacy}","received_events_url":"https://api.github.com/users/ctrlok/received_events","type":"User","site_admin":false},"body":"© @ybogdanov \r\n\r\n> Why is the default behavior taking base dir of Rockerfile instead of a current working directory? Because this behavior is more intuitive than the opposite. You can run a Rockerfile from any directory while keeping its functionality without a need to specify the context directory repetitively. Docker solves the latter by making the last argument mandatory.\r\n> But yes, it's a good idea of making a warning if a base directory of Rockerfile is not same as current and the last argument is not specified explicitly.","created_at":"2016-07-10T14:26:44Z","updated_at":"2016-07-11T07:48:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eba5b1cb05764c7a43769e7b734e20b57d457608","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/grammarly/rocker/pulls/117/commits","review_comments_url":"https://api.github.com/repos/grammarly/rocker/pulls/117/comments","review_comment_url":"https://api.github.com/repos/grammarly/rocker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grammarly/rocker/issues/117/comments","statuses_url":"https://api.github.com/repos/grammarly/rocker/statuses/a0c7ee3c39a4fec5e3b8ceed3b667f70a6cafcc2","head":{"label":"grammarly:f-contextDir-warning","ref":"f-contextDir-warning","sha":"a0c7ee3c39a4fec5e3b8ceed3b667f70a6cafcc2","user":{"login":"grammarly","id":352781,"avatar_url":"https://avatars.githubusercontent.com/u/352781?v=3","gravatar_id":"","url":"https://api.github.com/users/grammarly","html_url":"https://github.com/grammarly","followers_url":"https://api.github.com/users/grammarly/followers","following_url":"https://api.github.com/users/grammarly/following{/other_user}","gists_url":"https://api.github.com/users/grammarly/gists{/gist_id}","starred_url":"https://api.github.com/users/grammarly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grammarly/subscriptions","organizations_url":"https://api.github.com/users/grammarly/orgs","repos_url":"https://api.github.com/users/grammarly/repos","events_url":"https://api.github.com/users/grammarly/events{/privacy}","received_events_url":"https://api.github.com/users/grammarly/received_events","type":"Organization","site_admin":false},"repo":{"id":42118261,"name":"rocker","full_name":"grammarly/rocker","owner":{"login":"grammarly","id":352781,"avatar_url":"https://avatars.githubusercontent.com/u/352781?v=3","gravatar_id":"","url":"https://api.github.com/users/grammarly","html_url":"https://github.com/grammarly","followers_url":"https://api.github.com/users/grammarly/followers","following_url":"https://api.github.com/users/grammarly/following{/other_user}","gists_url":"https://api.github.com/users/grammarly/gists{/gist_id}","starred_url":"https://api.github.com/users/grammarly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grammarly/subscriptions","organizations_url":"https://api.github.com/users/grammarly/orgs","repos_url":"https://api.github.com/users/grammarly/repos","events_url":"https://api.github.com/users/grammarly/events{/privacy}","received_events_url":"https://api.github.com/users/grammarly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grammarly/rocker","description":"Rocker breaks the limits of Dockerfile.","fork":false,"url":"https://api.github.com/repos/grammarly/rocker","forks_url":"https://api.github.com/repos/grammarly/rocker/forks","keys_url":"https://api.github.com/repos/grammarly/rocker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grammarly/rocker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grammarly/rocker/teams","hooks_url":"https://api.github.com/repos/grammarly/rocker/hooks","issue_events_url":"https://api.github.com/repos/grammarly/rocker/issues/events{/number}","events_url":"https://api.github.com/repos/grammarly/rocker/events","assignees_url":"https://api.github.com/repos/grammarly/rocker/assignees{/user}","branches_url":"https://api.github.com/repos/grammarly/rocker/branches{/branch}","tags_url":"https://api.github.com/repos/grammarly/rocker/tags","blobs_url":"https://api.github.com/repos/grammarly/rocker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grammarly/rocker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grammarly/rocker/git/refs{/sha}","trees_url":"https://api.github.com/repos/grammarly/rocker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grammarly/rocker/statuses/{sha}","languages_url":"https://api.github.com/repos/grammarly/rocker/languages","stargazers_url":"https://api.github.com/repos/grammarly/rocker/stargazers","contributors_url":"https://api.github.com/repos/grammarly/rocker/contributors","subscribers_url":"https://api.github.com/repos/grammarly/rocker/subscribers","subscription_url":"https://api.github.com/repos/grammarly/rocker/subscription","commits_url":"https://api.github.com/repos/grammarly/rocker/commits{/sha}","git_commits_url":"https://api.github.com/repos/grammarly/rocker/git/commits{/sha}","comments_url":"https://api.github.com/repos/grammarly/rocker/comments{/number}","issue_comment_url":"https://api.github.com/repos/grammarly/rocker/issues/comments{/number}","contents_url":"https://api.github.com/repos/grammarly/rocker/contents/{+path}","compare_url":"https://api.github.com/repos/grammarly/rocker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grammarly/rocker/merges","archive_url":"https://api.github.com/repos/grammarly/rocker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grammarly/rocker/downloads","issues_url":"https://api.github.com/repos/grammarly/rocker/issues{/number}","pulls_url":"https://api.github.com/repos/grammarly/rocker/pulls{/number}","milestones_url":"https://api.github.com/repos/grammarly/rocker/milestones{/number}","notifications_url":"https://api.github.com/repos/grammarly/rocker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grammarly/rocker/labels{/name}","releases_url":"https://api.github.com/repos/grammarly/rocker/releases{/id}","deployments_url":"https://api.github.com/repos/grammarly/rocker/deployments","created_at":"2015-09-08T14:40:32Z","updated_at":"2016-07-11T07:36:45Z","pushed_at":"2016-07-10T14:26:44Z","git_url":"git://github.com/grammarly/rocker.git","ssh_url":"git@github.com:grammarly/rocker.git","clone_url":"https://github.com/grammarly/rocker.git","svn_url":"https://github.com/grammarly/rocker","homepage":null,"size":5518,"stargazers_count":364,"watchers_count":364,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":13,"forks":17,"open_issues":13,"watchers":364,"default_branch":"master"}},"base":{"label":"grammarly:dev","ref":"dev","sha":"98fe4ac025bb4370c7265183a81ecf0ca0bfa2f8","user":{"login":"grammarly","id":352781,"avatar_url":"https://avatars.githubusercontent.com/u/352781?v=3","gravatar_id":"","url":"https://api.github.com/users/grammarly","html_url":"https://github.com/grammarly","followers_url":"https://api.github.com/users/grammarly/followers","following_url":"https://api.github.com/users/grammarly/following{/other_user}","gists_url":"https://api.github.com/users/grammarly/gists{/gist_id}","starred_url":"https://api.github.com/users/grammarly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grammarly/subscriptions","organizations_url":"https://api.github.com/users/grammarly/orgs","repos_url":"https://api.github.com/users/grammarly/repos","events_url":"https://api.github.com/users/grammarly/events{/privacy}","received_events_url":"https://api.github.com/users/grammarly/received_events","type":"Organization","site_admin":false},"repo":{"id":42118261,"name":"rocker","full_name":"grammarly/rocker","owner":{"login":"grammarly","id":352781,"avatar_url":"https://avatars.githubusercontent.com/u/352781?v=3","gravatar_id":"","url":"https://api.github.com/users/grammarly","html_url":"https://github.com/grammarly","followers_url":"https://api.github.com/users/grammarly/followers","following_url":"https://api.github.com/users/grammarly/following{/other_user}","gists_url":"https://api.github.com/users/grammarly/gists{/gist_id}","starred_url":"https://api.github.com/users/grammarly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grammarly/subscriptions","organizations_url":"https://api.github.com/users/grammarly/orgs","repos_url":"https://api.github.com/users/grammarly/repos","events_url":"https://api.github.com/users/grammarly/events{/privacy}","received_events_url":"https://api.github.com/users/grammarly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grammarly/rocker","description":"Rocker breaks the limits of Dockerfile.","fork":false,"url":"https://api.github.com/repos/grammarly/rocker","forks_url":"https://api.github.com/repos/grammarly/rocker/forks","keys_url":"https://api.github.com/repos/grammarly/rocker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grammarly/rocker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grammarly/rocker/teams","hooks_url":"https://api.github.com/repos/grammarly/rocker/hooks","issue_events_url":"https://api.github.com/repos/grammarly/rocker/issues/events{/number}","events_url":"https://api.github.com/repos/grammarly/rocker/events","assignees_url":"https://api.github.com/repos/grammarly/rocker/assignees{/user}","branches_url":"https://api.github.com/repos/grammarly/rocker/branches{/branch}","tags_url":"https://api.github.com/repos/grammarly/rocker/tags","blobs_url":"https://api.github.com/repos/grammarly/rocker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grammarly/rocker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grammarly/rocker/git/refs{/sha}","trees_url":"https://api.github.com/repos/grammarly/rocker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grammarly/rocker/statuses/{sha}","languages_url":"https://api.github.com/repos/grammarly/rocker/languages","stargazers_url":"https://api.github.com/repos/grammarly/rocker/stargazers","contributors_url":"https://api.github.com/repos/grammarly/rocker/contributors","subscribers_url":"https://api.github.com/repos/grammarly/rocker/subscribers","subscription_url":"https://api.github.com/repos/grammarly/rocker/subscription","commits_url":"https://api.github.com/repos/grammarly/rocker/commits{/sha}","git_commits_url":"https://api.github.com/repos/grammarly/rocker/git/commits{/sha}","comments_url":"https://api.github.com/repos/grammarly/rocker/comments{/number}","issue_comment_url":"https://api.github.com/repos/grammarly/rocker/issues/comments{/number}","contents_url":"https://api.github.com/repos/grammarly/rocker/contents/{+path}","compare_url":"https://api.github.com/repos/grammarly/rocker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grammarly/rocker/merges","archive_url":"https://api.github.com/repos/grammarly/rocker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grammarly/rocker/downloads","issues_url":"https://api.github.com/repos/grammarly/rocker/issues{/number}","pulls_url":"https://api.github.com/repos/grammarly/rocker/pulls{/number}","milestones_url":"https://api.github.com/repos/grammarly/rocker/milestones{/number}","notifications_url":"https://api.github.com/repos/grammarly/rocker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grammarly/rocker/labels{/name}","releases_url":"https://api.github.com/repos/grammarly/rocker/releases{/id}","deployments_url":"https://api.github.com/repos/grammarly/rocker/deployments","created_at":"2015-09-08T14:40:32Z","updated_at":"2016-07-11T07:36:45Z","pushed_at":"2016-07-10T14:26:44Z","git_url":"git://github.com/grammarly/rocker.git","ssh_url":"git@github.com:grammarly/rocker.git","clone_url":"https://github.com/grammarly/rocker.git","svn_url":"https://github.com/grammarly/rocker","homepage":null,"size":5518,"stargazers_count":364,"watchers_count":364,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":13,"forks":17,"open_issues":13,"watchers":364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grammarly/rocker/pulls/117"},"html":{"href":"https://github.com/grammarly/rocker/pull/117"},"issue":{"href":"https://api.github.com/repos/grammarly/rocker/issues/117"},"comments":{"href":"https://api.github.com/repos/grammarly/rocker/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/grammarly/rocker/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/grammarly/rocker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grammarly/rocker/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/grammarly/rocker/statuses/a0c7ee3c39a4fec5e3b8ceed3b667f70a6cafcc2"}}}}
{"actor":{"display_login":"ybogdanov"}}