{"action":"created","comment":{"url":"https://api.github.com/repos/eventlet/eventlet/pulls/comments/65524960","id":65524960,"diff_hunk":"@@ -98,7 +101,8 @@ def readall(self):\n             except OSError as e:\n                 if get_errno(e) not in SOCKET_BLOCKING:\n                     raise IOError(*e.args)\n-            self._trampoline(self, read=True)\n+            if not self._is_regular:","path":"eventlet/greenio/py3.py","position":22,"original_position":22,"commit_id":"dea17132b93b6bd3f5de348df55a56fa14ae021a","original_commit_id":"dea17132b93b6bd3f5de348df55a56fa14ae021a","user":{"login":"temoto","id":27057,"avatar_url":"https://avatars.githubusercontent.com/u/27057?v=3","gravatar_id":"","url":"https://api.github.com/users/temoto","html_url":"https://github.com/temoto","followers_url":"https://api.github.com/users/temoto/followers","following_url":"https://api.github.com/users/temoto/following{/other_user}","gists_url":"https://api.github.com/users/temoto/gists{/gist_id}","starred_url":"https://api.github.com/users/temoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/temoto/subscriptions","organizations_url":"https://api.github.com/users/temoto/orgs","repos_url":"https://api.github.com/users/temoto/repos","events_url":"https://api.github.com/users/temoto/events{/privacy}","received_events_url":"https://api.github.com/users/temoto/received_events","type":"User","site_admin":false},"body":"According to `stat()` documentation, file descriptor may be a regular file, directory, symlink, block or char device, socket and fifo. What are supported types? Is it possible to use white list instead? Check that fd is of supported type.","created_at":"2016-06-02T11:47:33Z","updated_at":"2016-06-02T11:47:33Z","html_url":"https://github.com/eventlet/eventlet/pull/257#discussion_r65524960","pull_request_url":"https://api.github.com/repos/eventlet/eventlet/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/comments/65524960"},"html":{"href":"https://github.com/eventlet/eventlet/pull/257#discussion_r65524960"},"pull_request":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/eventlet/eventlet/pulls/257","id":48050065,"html_url":"https://github.com/eventlet/eventlet/pull/257","diff_url":"https://github.com/eventlet/eventlet/pull/257.diff","patch_url":"https://github.com/eventlet/eventlet/pull/257.patch","issue_url":"https://api.github.com/repos/eventlet/eventlet/issues/257","number":257,"state":"open","locked":false,"title":"Fix GreenFileIO.readall() for regular file","user":{"login":"haypo","id":194129,"avatar_url":"https://avatars.githubusercontent.com/u/194129?v=3","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"body":"GreenFileIO.readall() calls _trampoline(self, read=True). Problem: on\r\nregular file, epoll_ctl() fails with EPERM on Linux, because regular\r\nfiles are not supported.\r\n\r\nThis change skips the call to _trampoline() on regular files. Add\r\nalso various unit tests on the various ways to read the whole content\r\nof a file.","created_at":"2015-10-19T09:44:07Z","updated_at":"2016-06-02T11:47:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e570bb0bcf7beb68e681bff787de4709534099f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eventlet/eventlet/pulls/257/commits","review_comments_url":"https://api.github.com/repos/eventlet/eventlet/pulls/257/comments","review_comment_url":"https://api.github.com/repos/eventlet/eventlet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eventlet/eventlet/issues/257/comments","statuses_url":"https://api.github.com/repos/eventlet/eventlet/statuses/dea17132b93b6bd3f5de348df55a56fa14ae021a","head":{"label":"haypo:readall_regular","ref":"readall_regular","sha":"dea17132b93b6bd3f5de348df55a56fa14ae021a","user":{"login":"haypo","id":194129,"avatar_url":"https://avatars.githubusercontent.com/u/194129?v=3","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"repo":{"id":26885447,"name":"eventlet","full_name":"haypo/eventlet","owner":{"login":"haypo","id":194129,"avatar_url":"https://avatars.githubusercontent.com/u/194129?v=3","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haypo/eventlet","description":"Concurrent networking library for Python (official mirror)","fork":true,"url":"https://api.github.com/repos/haypo/eventlet","forks_url":"https://api.github.com/repos/haypo/eventlet/forks","keys_url":"https://api.github.com/repos/haypo/eventlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haypo/eventlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haypo/eventlet/teams","hooks_url":"https://api.github.com/repos/haypo/eventlet/hooks","issue_events_url":"https://api.github.com/repos/haypo/eventlet/issues/events{/number}","events_url":"https://api.github.com/repos/haypo/eventlet/events","assignees_url":"https://api.github.com/repos/haypo/eventlet/assignees{/user}","branches_url":"https://api.github.com/repos/haypo/eventlet/branches{/branch}","tags_url":"https://api.github.com/repos/haypo/eventlet/tags","blobs_url":"https://api.github.com/repos/haypo/eventlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haypo/eventlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haypo/eventlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/haypo/eventlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haypo/eventlet/statuses/{sha}","languages_url":"https://api.github.com/repos/haypo/eventlet/languages","stargazers_url":"https://api.github.com/repos/haypo/eventlet/stargazers","contributors_url":"https://api.github.com/repos/haypo/eventlet/contributors","subscribers_url":"https://api.github.com/repos/haypo/eventlet/subscribers","subscription_url":"https://api.github.com/repos/haypo/eventlet/subscription","commits_url":"https://api.github.com/repos/haypo/eventlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/haypo/eventlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/haypo/eventlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/haypo/eventlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/haypo/eventlet/contents/{+path}","compare_url":"https://api.github.com/repos/haypo/eventlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haypo/eventlet/merges","archive_url":"https://api.github.com/repos/haypo/eventlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haypo/eventlet/downloads","issues_url":"https://api.github.com/repos/haypo/eventlet/issues{/number}","pulls_url":"https://api.github.com/repos/haypo/eventlet/pulls{/number}","milestones_url":"https://api.github.com/repos/haypo/eventlet/milestones{/number}","notifications_url":"https://api.github.com/repos/haypo/eventlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haypo/eventlet/labels{/name}","releases_url":"https://api.github.com/repos/haypo/eventlet/releases{/id}","deployments_url":"https://api.github.com/repos/haypo/eventlet/deployments","created_at":"2014-11-19T22:49:38Z","updated_at":"2016-02-10T13:35:10Z","pushed_at":"2016-03-03T15:43:16Z","git_url":"git://github.com/haypo/eventlet.git","ssh_url":"git@github.com:haypo/eventlet.git","clone_url":"https://github.com/haypo/eventlet.git","svn_url":"https://github.com/haypo/eventlet","homepage":"eventlet.net","size":10640,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eventlet:master","ref":"master","sha":"869432f9ab4772da2d728733838744244402ed13","user":{"login":"eventlet","id":3017635,"avatar_url":"https://avatars.githubusercontent.com/u/3017635?v=3","gravatar_id":"","url":"https://api.github.com/users/eventlet","html_url":"https://github.com/eventlet","followers_url":"https://api.github.com/users/eventlet/followers","following_url":"https://api.github.com/users/eventlet/following{/other_user}","gists_url":"https://api.github.com/users/eventlet/gists{/gist_id}","starred_url":"https://api.github.com/users/eventlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventlet/subscriptions","organizations_url":"https://api.github.com/users/eventlet/orgs","repos_url":"https://api.github.com/users/eventlet/repos","events_url":"https://api.github.com/users/eventlet/events{/privacy}","received_events_url":"https://api.github.com/users/eventlet/received_events","type":"Organization","site_admin":false},"repo":{"id":7115259,"name":"eventlet","full_name":"eventlet/eventlet","owner":{"login":"eventlet","id":3017635,"avatar_url":"https://avatars.githubusercontent.com/u/3017635?v=3","gravatar_id":"","url":"https://api.github.com/users/eventlet","html_url":"https://github.com/eventlet","followers_url":"https://api.github.com/users/eventlet/followers","following_url":"https://api.github.com/users/eventlet/following{/other_user}","gists_url":"https://api.github.com/users/eventlet/gists{/gist_id}","starred_url":"https://api.github.com/users/eventlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventlet/subscriptions","organizations_url":"https://api.github.com/users/eventlet/orgs","repos_url":"https://api.github.com/users/eventlet/repos","events_url":"https://api.github.com/users/eventlet/events{/privacy}","received_events_url":"https://api.github.com/users/eventlet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eventlet/eventlet","description":"Concurrent networking library for Python (official mirror)","fork":false,"url":"https://api.github.com/repos/eventlet/eventlet","forks_url":"https://api.github.com/repos/eventlet/eventlet/forks","keys_url":"https://api.github.com/repos/eventlet/eventlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventlet/eventlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventlet/eventlet/teams","hooks_url":"https://api.github.com/repos/eventlet/eventlet/hooks","issue_events_url":"https://api.github.com/repos/eventlet/eventlet/issues/events{/number}","events_url":"https://api.github.com/repos/eventlet/eventlet/events","assignees_url":"https://api.github.com/repos/eventlet/eventlet/assignees{/user}","branches_url":"https://api.github.com/repos/eventlet/eventlet/branches{/branch}","tags_url":"https://api.github.com/repos/eventlet/eventlet/tags","blobs_url":"https://api.github.com/repos/eventlet/eventlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventlet/eventlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventlet/eventlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventlet/eventlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventlet/eventlet/statuses/{sha}","languages_url":"https://api.github.com/repos/eventlet/eventlet/languages","stargazers_url":"https://api.github.com/repos/eventlet/eventlet/stargazers","contributors_url":"https://api.github.com/repos/eventlet/eventlet/contributors","subscribers_url":"https://api.github.com/repos/eventlet/eventlet/subscribers","subscription_url":"https://api.github.com/repos/eventlet/eventlet/subscription","commits_url":"https://api.github.com/repos/eventlet/eventlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventlet/eventlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventlet/eventlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventlet/eventlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/eventlet/eventlet/contents/{+path}","compare_url":"https://api.github.com/repos/eventlet/eventlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventlet/eventlet/merges","archive_url":"https://api.github.com/repos/eventlet/eventlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventlet/eventlet/downloads","issues_url":"https://api.github.com/repos/eventlet/eventlet/issues{/number}","pulls_url":"https://api.github.com/repos/eventlet/eventlet/pulls{/number}","milestones_url":"https://api.github.com/repos/eventlet/eventlet/milestones{/number}","notifications_url":"https://api.github.com/repos/eventlet/eventlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventlet/eventlet/labels{/name}","releases_url":"https://api.github.com/repos/eventlet/eventlet/releases{/id}","deployments_url":"https://api.github.com/repos/eventlet/eventlet/deployments","created_at":"2012-12-11T16:33:20Z","updated_at":"2016-06-01T03:58:29Z","pushed_at":"2016-06-01T16:28:10Z","git_url":"git://github.com/eventlet/eventlet.git","ssh_url":"git@github.com:eventlet/eventlet.git","clone_url":"https://github.com/eventlet/eventlet.git","svn_url":"https://github.com/eventlet/eventlet","homepage":"eventlet.net","size":8925,"stargazers_count":374,"watchers_count":374,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":127,"mirror_url":null,"open_issues_count":91,"forks":127,"open_issues":91,"watchers":374,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/257"},"html":{"href":"https://github.com/eventlet/eventlet/pull/257"},"issue":{"href":"https://api.github.com/repos/eventlet/eventlet/issues/257"},"comments":{"href":"https://api.github.com/repos/eventlet/eventlet/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eventlet/eventlet/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/eventlet/eventlet/statuses/dea17132b93b6bd3f5de348df55a56fa14ae021a"}}}}
{"actor":{"display_login":"temoto"}}