{"action":"created","comment":{"url":"https://api.github.com/repos/xnio/xnio/pulls/comments/92394587","pull_request_review_id":12908377,"id":92394587,"diff_hunk":"@@ -0,0 +1,31 @@\n+package org.xnio;\n+\n+import java.io.Closeable;\n+import java.io.IOException;\n+\n+import org.xnio.management.XnioServerMXBean;\n+\n+/**\n+ * @author Tomaz Cerar (c) 2016 Red Hat Inc.\n+ */\n+public abstract class SelfRegisteringServerMetrics implements XnioServerMXBean, Closeable {","path":"api/src/main/java/org/xnio/SelfRegisteringServerMetrics.java","position":11,"original_position":11,"commit_id":"a2d5fa147cb9bb77e0cff948889e97294de2d56f","original_commit_id":"a2d5fa147cb9bb77e0cff948889e97294de2d56f","user":{"login":"dmlloyd","id":124581,"avatar_url":"https://avatars.githubusercontent.com/u/124581?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlloyd","html_url":"https://github.com/dmlloyd","followers_url":"https://api.github.com/users/dmlloyd/followers","following_url":"https://api.github.com/users/dmlloyd/following{/other_user}","gists_url":"https://api.github.com/users/dmlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlloyd/subscriptions","organizations_url":"https://api.github.com/users/dmlloyd/orgs","repos_url":"https://api.github.com/users/dmlloyd/repos","events_url":"https://api.github.com/users/dmlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/dmlloyd/received_events","type":"User","site_admin":false},"body":"Can we just drop this class?","created_at":"2016-12-14T13:45:32Z","updated_at":"2016-12-14T13:45:32Z","html_url":"https://github.com/xnio/xnio/pull/102#discussion_r92394587","pull_request_url":"https://api.github.com/repos/xnio/xnio/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/xnio/xnio/pulls/comments/92394587"},"html":{"href":"https://github.com/xnio/xnio/pull/102#discussion_r92394587"},"pull_request":{"href":"https://api.github.com/repos/xnio/xnio/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/xnio/xnio/pulls/102","id":94647589,"html_url":"https://github.com/xnio/xnio/pull/102","diff_url":"https://github.com/xnio/xnio/pull/102.diff","patch_url":"https://github.com/xnio/xnio/pull/102.patch","issue_url":"https://api.github.com/repos/xnio/xnio/issues/102","number":102,"state":"open","locked":false,"title":"Expose XNIO metrics in friendlier way","user":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=3","gravatar_id":"","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"body":"also XNIO-268 QueuedNioTcpServer always returns \"-1\" for \"ConnectionCount\" attribute in MBean","created_at":"2016-11-21T16:22:59Z","updated_at":"2016-12-14T13:45:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d5563deeada4d8caec564ff995f144f95e27496","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xnio/xnio/pulls/102/commits","review_comments_url":"https://api.github.com/repos/xnio/xnio/pulls/102/comments","review_comment_url":"https://api.github.com/repos/xnio/xnio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xnio/xnio/issues/102/comments","statuses_url":"https://api.github.com/repos/xnio/xnio/statuses/a2d5fa147cb9bb77e0cff948889e97294de2d56f","head":{"label":"ctomc:runtime-data","ref":"runtime-data","sha":"a2d5fa147cb9bb77e0cff948889e97294de2d56f","user":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=3","gravatar_id":"","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"repo":{"id":17754800,"name":"xnio","full_name":"ctomc/xnio","owner":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=3","gravatar_id":"","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctomc/xnio","description":"XNIO","fork":true,"url":"https://api.github.com/repos/ctomc/xnio","forks_url":"https://api.github.com/repos/ctomc/xnio/forks","keys_url":"https://api.github.com/repos/ctomc/xnio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctomc/xnio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctomc/xnio/teams","hooks_url":"https://api.github.com/repos/ctomc/xnio/hooks","issue_events_url":"https://api.github.com/repos/ctomc/xnio/issues/events{/number}","events_url":"https://api.github.com/repos/ctomc/xnio/events","assignees_url":"https://api.github.com/repos/ctomc/xnio/assignees{/user}","branches_url":"https://api.github.com/repos/ctomc/xnio/branches{/branch}","tags_url":"https://api.github.com/repos/ctomc/xnio/tags","blobs_url":"https://api.github.com/repos/ctomc/xnio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctomc/xnio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctomc/xnio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctomc/xnio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctomc/xnio/statuses/{sha}","languages_url":"https://api.github.com/repos/ctomc/xnio/languages","stargazers_url":"https://api.github.com/repos/ctomc/xnio/stargazers","contributors_url":"https://api.github.com/repos/ctomc/xnio/contributors","subscribers_url":"https://api.github.com/repos/ctomc/xnio/subscribers","subscription_url":"https://api.github.com/repos/ctomc/xnio/subscription","commits_url":"https://api.github.com/repos/ctomc/xnio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctomc/xnio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctomc/xnio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctomc/xnio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctomc/xnio/contents/{+path}","compare_url":"https://api.github.com/repos/ctomc/xnio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctomc/xnio/merges","archive_url":"https://api.github.com/repos/ctomc/xnio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctomc/xnio/downloads","issues_url":"https://api.github.com/repos/ctomc/xnio/issues{/number}","pulls_url":"https://api.github.com/repos/ctomc/xnio/pulls{/number}","milestones_url":"https://api.github.com/repos/ctomc/xnio/milestones{/number}","notifications_url":"https://api.github.com/repos/ctomc/xnio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctomc/xnio/labels{/name}","releases_url":"https://api.github.com/repos/ctomc/xnio/releases{/id}","deployments_url":"https://api.github.com/repos/ctomc/xnio/deployments","created_at":"2014-03-14T17:43:33Z","updated_at":"2014-04-16T14:02:17Z","pushed_at":"2016-12-12T15:00:14Z","git_url":"git://github.com/ctomc/xnio.git","ssh_url":"git@github.com:ctomc/xnio.git","clone_url":"https://github.com/ctomc/xnio.git","svn_url":"https://github.com/ctomc/xnio","homepage":"http://www.jboss.org/xnio","size":4318,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"xnio:3.4","ref":"3.4","sha":"c97e17a76006b664bf02091afaa4eec1e83caf14","user":{"login":"xnio","id":1971403,"avatar_url":"https://avatars.githubusercontent.com/u/1971403?v=3","gravatar_id":"","url":"https://api.github.com/users/xnio","html_url":"https://github.com/xnio","followers_url":"https://api.github.com/users/xnio/followers","following_url":"https://api.github.com/users/xnio/following{/other_user}","gists_url":"https://api.github.com/users/xnio/gists{/gist_id}","starred_url":"https://api.github.com/users/xnio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnio/subscriptions","organizations_url":"https://api.github.com/users/xnio/orgs","repos_url":"https://api.github.com/users/xnio/repos","events_url":"https://api.github.com/users/xnio/events{/privacy}","received_events_url":"https://api.github.com/users/xnio/received_events","type":"Organization","site_admin":false},"repo":{"id":820836,"name":"xnio","full_name":"xnio/xnio","owner":{"login":"xnio","id":1971403,"avatar_url":"https://avatars.githubusercontent.com/u/1971403?v=3","gravatar_id":"","url":"https://api.github.com/users/xnio","html_url":"https://github.com/xnio","followers_url":"https://api.github.com/users/xnio/followers","following_url":"https://api.github.com/users/xnio/following{/other_user}","gists_url":"https://api.github.com/users/xnio/gists{/gist_id}","starred_url":"https://api.github.com/users/xnio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnio/subscriptions","organizations_url":"https://api.github.com/users/xnio/orgs","repos_url":"https://api.github.com/users/xnio/repos","events_url":"https://api.github.com/users/xnio/events{/privacy}","received_events_url":"https://api.github.com/users/xnio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xnio/xnio","description":"XNIO","fork":false,"url":"https://api.github.com/repos/xnio/xnio","forks_url":"https://api.github.com/repos/xnio/xnio/forks","keys_url":"https://api.github.com/repos/xnio/xnio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xnio/xnio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xnio/xnio/teams","hooks_url":"https://api.github.com/repos/xnio/xnio/hooks","issue_events_url":"https://api.github.com/repos/xnio/xnio/issues/events{/number}","events_url":"https://api.github.com/repos/xnio/xnio/events","assignees_url":"https://api.github.com/repos/xnio/xnio/assignees{/user}","branches_url":"https://api.github.com/repos/xnio/xnio/branches{/branch}","tags_url":"https://api.github.com/repos/xnio/xnio/tags","blobs_url":"https://api.github.com/repos/xnio/xnio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xnio/xnio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xnio/xnio/git/refs{/sha}","trees_url":"https://api.github.com/repos/xnio/xnio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xnio/xnio/statuses/{sha}","languages_url":"https://api.github.com/repos/xnio/xnio/languages","stargazers_url":"https://api.github.com/repos/xnio/xnio/stargazers","contributors_url":"https://api.github.com/repos/xnio/xnio/contributors","subscribers_url":"https://api.github.com/repos/xnio/xnio/subscribers","subscription_url":"https://api.github.com/repos/xnio/xnio/subscription","commits_url":"https://api.github.com/repos/xnio/xnio/commits{/sha}","git_commits_url":"https://api.github.com/repos/xnio/xnio/git/commits{/sha}","comments_url":"https://api.github.com/repos/xnio/xnio/comments{/number}","issue_comment_url":"https://api.github.com/repos/xnio/xnio/issues/comments{/number}","contents_url":"https://api.github.com/repos/xnio/xnio/contents/{+path}","compare_url":"https://api.github.com/repos/xnio/xnio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xnio/xnio/merges","archive_url":"https://api.github.com/repos/xnio/xnio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xnio/xnio/downloads","issues_url":"https://api.github.com/repos/xnio/xnio/issues{/number}","pulls_url":"https://api.github.com/repos/xnio/xnio/pulls{/number}","milestones_url":"https://api.github.com/repos/xnio/xnio/milestones{/number}","notifications_url":"https://api.github.com/repos/xnio/xnio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xnio/xnio/labels{/name}","releases_url":"https://api.github.com/repos/xnio/xnio/releases{/id}","deployments_url":"https://api.github.com/repos/xnio/xnio/deployments","created_at":"2010-08-06T06:03:15Z","updated_at":"2016-12-13T14:05:19Z","pushed_at":"2016-12-12T15:00:14Z","git_url":"git://github.com/xnio/xnio.git","ssh_url":"git@github.com:xnio/xnio.git","clone_url":"https://github.com/xnio/xnio.git","svn_url":"https://github.com/xnio/xnio","homepage":"http://www.jboss.org/xnio","size":5127,"stargazers_count":108,"watchers_count":108,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":12,"forks":65,"open_issues":12,"watchers":108,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/xnio/xnio/pulls/102"},"html":{"href":"https://github.com/xnio/xnio/pull/102"},"issue":{"href":"https://api.github.com/repos/xnio/xnio/issues/102"},"comments":{"href":"https://api.github.com/repos/xnio/xnio/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/xnio/xnio/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/xnio/xnio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xnio/xnio/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/xnio/xnio/statuses/a2d5fa147cb9bb77e0cff948889e97294de2d56f"}}}}
{"actor":{"display_login":"dmlloyd"}}