{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74864816","id":74864816,"diff_hunk":"@@ -0,0 +1,60 @@\n+/*\n+Copyright 2016 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package healthcheck\n+\n+import (\n+\t\"fmt\"\n+\t\"net/http\"\n+\n+\t\"github.com/golang/glog\"\n+\t\"k8s.io/kubernetes/pkg/types\"\n+\t\"k8s.io/kubernetes/pkg/util/healthcheckparser\"\n+)\n+\n+// HTTP Utility function to send the required statusCode and error text to a http.ResponseWriter object\n+func sendHealthCheckResponse(rw http.ResponseWriter, statusCode int, error string) {\n+\trw.Header().Set(\"Content-Type\", \"text/plain\")\n+\trw.WriteHeader(statusCode)\n+\tfmt.Fprint(rw, error)\n+}\n+\n+// Utility function to parse an incoming http request, construct and send a health check message to the main loop\n+// Waits for responses from the main loop before responding to and closing the connection to the HTTP client.\n+func parseHttpRequest(req *http.Request) (string, error) {\n+\tglog.V(3).Infof(\"Received Health Check on url %s\", req.URL.String())\n+\t// Sanity check and parse the healthcheck URL\n+\tnamespace, name, err := healthcheckparser.ParseURL(req.URL.String())\n+\tif err != nil {\n+\t\tglog.Info(\"Parse failure - cannot respond to malformed healthcheck URL\")\n+\t\treturn \"\", err\n+\t}\n+\tglog.V(4).Infof(\"Parsed Healthcheck as service %s/%s\", namespace, name)\n+\n+\tserviceName := types.NamespacedName{namespace, name}\n+\treturn serviceName.String(), nil\n+}\n+\n+// ServeHTTP: Interface callback method for net.Listener Handlers\n+func (h *proxyHC) ServeHTTP(response http.ResponseWriter, req *http.Request) {\n+\t// Grab the session guid from the URL and lookup in the fastmap","path":"pkg/proxy/healthcheck/http.go","position":53,"original_position":53,"commit_id":"16adff34ab31ef38c9d5c29d7be5315273d386c4","original_commit_id":"16adff34ab31ef38c9d5c29d7be5315273d386c4","user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"body":"hmm, this comment doesn't make sense to me. We're actually not parsing out a session guid even if it might look similar? ","created_at":"2016-08-16T01:34:38Z","updated_at":"2016-08-16T01:34:38Z","html_url":"https://github.com/kubernetes/kubernetes/pull/30569#discussion_r74864816","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30569","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74864816"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30569#discussion_r74864816"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30569"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30569","id":81206372,"html_url":"https://github.com/kubernetes/kubernetes/pull/30569","diff_url":"https://github.com/kubernetes/kubernetes/pull/30569.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30569.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30569","number":30569,"state":"open","locked":false,"title":"Load Balancer Health Check responder library for ESIPP","user":{"login":"girishkalele","id":18541549,"avatar_url":"https://avatars.githubusercontent.com/u/18541549?v=3","gravatar_id":"","url":"https://api.github.com/users/girishkalele","html_url":"https://github.com/girishkalele","followers_url":"https://api.github.com/users/girishkalele/followers","following_url":"https://api.github.com/users/girishkalele/following{/other_user}","gists_url":"https://api.github.com/users/girishkalele/gists{/gist_id}","starred_url":"https://api.github.com/users/girishkalele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishkalele/subscriptions","organizations_url":"https://api.github.com/users/girishkalele/orgs","repos_url":"https://api.github.com/users/girishkalele/repos","events_url":"https://api.github.com/users/girishkalele/events{/privacy}","received_events_url":"https://api.github.com/users/girishkalele/received_events","type":"User","site_admin":false},"body":"This is an independent component that is needed for the Load Balancer health traffic steering functionality (part of the 1.4 ESIPP work)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30569)\n<!-- Reviewable:end -->\n","created_at":"2016-08-13T04:03:26Z","updated_at":"2016-08-16T01:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4be296ced38d76afb4c56bb8e51de16eec0eb683","assignee":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"assignees":[{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30569/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30569/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30569/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/16adff34ab31ef38c9d5c29d7be5315273d386c4","head":{"label":"girishkalele:esipp_healthchecker","ref":"esipp_healthchecker","sha":"16adff34ab31ef38c9d5c29d7be5315273d386c4","user":{"login":"girishkalele","id":18541549,"avatar_url":"https://avatars.githubusercontent.com/u/18541549?v=3","gravatar_id":"","url":"https://api.github.com/users/girishkalele","html_url":"https://github.com/girishkalele","followers_url":"https://api.github.com/users/girishkalele/followers","following_url":"https://api.github.com/users/girishkalele/following{/other_user}","gists_url":"https://api.github.com/users/girishkalele/gists{/gist_id}","starred_url":"https://api.github.com/users/girishkalele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishkalele/subscriptions","organizations_url":"https://api.github.com/users/girishkalele/orgs","repos_url":"https://api.github.com/users/girishkalele/repos","events_url":"https://api.github.com/users/girishkalele/events{/privacy}","received_events_url":"https://api.github.com/users/girishkalele/received_events","type":"User","site_admin":false},"repo":{"id":58407800,"name":"kubernetes","full_name":"girishkalele/kubernetes","owner":{"login":"girishkalele","id":18541549,"avatar_url":"https://avatars.githubusercontent.com/u/18541549?v=3","gravatar_id":"","url":"https://api.github.com/users/girishkalele","html_url":"https://github.com/girishkalele","followers_url":"https://api.github.com/users/girishkalele/followers","following_url":"https://api.github.com/users/girishkalele/following{/other_user}","gists_url":"https://api.github.com/users/girishkalele/gists{/gist_id}","starred_url":"https://api.github.com/users/girishkalele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishkalele/subscriptions","organizations_url":"https://api.github.com/users/girishkalele/orgs","repos_url":"https://api.github.com/users/girishkalele/repos","events_url":"https://api.github.com/users/girishkalele/events{/privacy}","received_events_url":"https://api.github.com/users/girishkalele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/girishkalele/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/girishkalele/kubernetes","forks_url":"https://api.github.com/repos/girishkalele/kubernetes/forks","keys_url":"https://api.github.com/repos/girishkalele/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girishkalele/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girishkalele/kubernetes/teams","hooks_url":"https://api.github.com/repos/girishkalele/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/girishkalele/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/girishkalele/kubernetes/events","assignees_url":"https://api.github.com/repos/girishkalele/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/girishkalele/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/girishkalele/kubernetes/tags","blobs_url":"https://api.github.com/repos/girishkalele/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girishkalele/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girishkalele/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/girishkalele/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girishkalele/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/girishkalele/kubernetes/languages","stargazers_url":"https://api.github.com/repos/girishkalele/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/girishkalele/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/girishkalele/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/girishkalele/kubernetes/subscription","commits_url":"https://api.github.com/repos/girishkalele/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/girishkalele/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/girishkalele/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/girishkalele/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/girishkalele/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/girishkalele/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girishkalele/kubernetes/merges","archive_url":"https://api.github.com/repos/girishkalele/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girishkalele/kubernetes/downloads","issues_url":"https://api.github.com/repos/girishkalele/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/girishkalele/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/girishkalele/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/girishkalele/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girishkalele/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/girishkalele/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/girishkalele/kubernetes/deployments","created_at":"2016-05-09T20:59:15Z","updated_at":"2016-05-09T20:59:30Z","pushed_at":"2016-08-16T00:24:16Z","git_url":"git://github.com/girishkalele/kubernetes.git","ssh_url":"git@github.com:girishkalele/kubernetes.git","clone_url":"https://github.com/girishkalele/kubernetes.git","svn_url":"https://github.com/girishkalele/kubernetes","homepage":"http://kubernetes.io","size":306209,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"7a3d5159cf1c510dd124d1e768ba4917764c9ba3","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-16T00:41:50Z","pushed_at":"2016-08-16T01:32:43Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":523040,"stargazers_count":16148,"watchers_count":16148,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5138,"mirror_url":null,"open_issues_count":4187,"forks":5138,"open_issues":4187,"watchers":16148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30569"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30569"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30569"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30569/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30569/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30569/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/16adff34ab31ef38c9d5c29d7be5315273d386c4"}}}}
{"actor":{"display_login":"bprashanth"}}