{"action":"closed","issue":{"url":"https://api.github.com/repos/angular/angular.js/issues/14063","repository_url":"https://api.github.com/repos/angular/angular.js","labels_url":"https://api.github.com/repos/angular/angular.js/issues/14063/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/14063/comments","events_url":"https://api.github.com/repos/angular/angular.js/issues/14063/events","html_url":"https://github.com/angular/angular.js/issues/14063","id":134103072,"number":14063,"title":"fix(ngAria): bind to `keydown` instead of `keypress` in `ngClick`","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular.js/labels/component:%20ngAria","name":"component: ngAria","color":"bfe5bf"},{"url":"https://api.github.com/repos/angular/angular.js/labels/frequency:%20low","name":"frequency: low","color":"bfe5bf"},{"url":"https://api.github.com/repos/angular/angular.js/labels/needs:%20breaking%20change","name":"needs: breaking change","color":"e11d21"},{"url":"https://api.github.com/repos/angular/angular.js/labels/PRs%20plz!","name":"PRs plz!","color":"02d7e1"},{"url":"https://api.github.com/repos/angular/angular.js/labels/severity:%20broken%20expected%20use","name":"severity: broken expected use","color":"fbda00"},{"url":"https://api.github.com/repos/angular/angular.js/labels/type:%20bug","name":"type: bug","color":"000000"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/105","html_url":"https://github.com/angular/angular.js/milestones/1.6.x","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/105/labels","id":1317216,"number":105,"title":"1.6.x","description":null,"creator":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":33,"state":"open","created_at":"2015-09-21T20:16:38Z","updated_at":"2016-07-06T12:55:37Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-02-16T21:35:21Z","updated_at":"2016-07-06T12:55:37Z","closed_at":"2016-07-06T12:55:37Z","body":"`ngAria`'s `ngClick` (among other things) tries to emulate the behavior of native buttons for non-button elements (e.g. `<div>`, `<li>` etc) used as button. Using native buttons is strongly recommended, but we should still try to make things accessible, even if the developer chooses to not follow the best practice :smiley:\r\n\r\nCurrently, we detect \"clicks\" by listening to `keypress` events. Switching to `keydown` instead, would make the behavior more consistent with how the browser fires click events on native buttons.\r\n\r\nAlso, discussed in https://github.com/angular/angular.js/pull/13996/files#r52934300."}}
{"actor":{"display_login":"gkalpak"}}