{"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/54356307","id":54356307,"diff_hunk":"@@ -29,10 +29,265 @@\n \n #include <aspect/parameters.h>\n \n+namespace dealii\n+{\n+  /**\n+   * Represent a single variable of the deal.II finite element system\n+   */\n+  template <int dim>\n+  struct Variable\n+  {\n+      /**\n+       * Constructor for a variable.\n+       *\n+       * @param name A user-friendly and unique string representation.","path":"include/aspect/introspection.h","position":15,"original_position":15,"commit_id":"a4633081022dbba64d18322d050cff17574293bb","original_commit_id":"a4633081022dbba64d18322d050cff17574293bb","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"representation of WHAT?","created_at":"2016-02-28T21:04:19Z","updated_at":"2016-02-28T21:04:19Z","html_url":"https://github.com/geodynamics/aspect/pull/772#discussion_r54356307","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/772","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/54356307"},"html":{"href":"https://github.com/geodynamics/aspect/pull/772#discussion_r54356307"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/772"}}},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/772","id":60571176,"html_url":"https://github.com/geodynamics/aspect/pull/772","diff_url":"https://github.com/geodynamics/aspect/pull/772.diff","patch_url":"https://github.com/geodynamics/aspect/pull/772.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/772","number":772,"state":"open","locked":false,"title":"[WIP] Introspection2","user":{"login":"tjhei","id":1531285,"avatar_url":"https://avatars.githubusercontent.com/u/1531285?v=3","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"body":"This PR is reworking the Introspection class to be more flexible with the goal to a) simplify the code and b) allow the melt transport (or others) to plug into the creation of the introspection.\r\n\r\nThe class ``Variable`` and ``IntrospectionBase`` is quite convenient and something that might (at some point?) move into deal.II.\r\n\r\nThis PR also moves the creation of signals to the beginning of the constructor of the simulator, otherwise plugins can not attach to signals before the FiniteElement system is created.","created_at":"2016-02-24T20:17:05Z","updated_at":"2016-02-28T21:04:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0bfa4d58af419caa217d35b64a832982f7887ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/772/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/772/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/772/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/a4633081022dbba64d18322d050cff17574293bb","head":{"label":"tjhei:introspection2","ref":"introspection2","sha":"a4633081022dbba64d18322d050cff17574293bb","user":{"login":"tjhei","id":1531285,"avatar_url":"https://avatars.githubusercontent.com/u/1531285?v=3","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"repo":{"id":19503755,"name":"aspect","full_name":"tjhei/aspect","owner":{"login":"tjhei","id":1531285,"avatar_url":"https://avatars.githubusercontent.com/u/1531285?v=3","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tjhei/aspect","description":"Finite element parallel code to simulate problems in thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/tjhei/aspect","forks_url":"https://api.github.com/repos/tjhei/aspect/forks","keys_url":"https://api.github.com/repos/tjhei/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tjhei/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tjhei/aspect/teams","hooks_url":"https://api.github.com/repos/tjhei/aspect/hooks","issue_events_url":"https://api.github.com/repos/tjhei/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/tjhei/aspect/events","assignees_url":"https://api.github.com/repos/tjhei/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/tjhei/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/tjhei/aspect/tags","blobs_url":"https://api.github.com/repos/tjhei/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tjhei/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tjhei/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/tjhei/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tjhei/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/tjhei/aspect/languages","stargazers_url":"https://api.github.com/repos/tjhei/aspect/stargazers","contributors_url":"https://api.github.com/repos/tjhei/aspect/contributors","subscribers_url":"https://api.github.com/repos/tjhei/aspect/subscribers","subscription_url":"https://api.github.com/repos/tjhei/aspect/subscription","commits_url":"https://api.github.com/repos/tjhei/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/tjhei/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/tjhei/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/tjhei/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/tjhei/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/tjhei/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tjhei/aspect/merges","archive_url":"https://api.github.com/repos/tjhei/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tjhei/aspect/downloads","issues_url":"https://api.github.com/repos/tjhei/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/tjhei/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/tjhei/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/tjhei/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tjhei/aspect/labels{/name}","releases_url":"https://api.github.com/repos/tjhei/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/tjhei/aspect/deployments","created_at":"2014-05-06T17:29:57Z","updated_at":"2015-02-27T01:19:19Z","pushed_at":"2016-02-25T13:42:01Z","git_url":"git://github.com/tjhei/aspect.git","ssh_url":"git@github.com:tjhei/aspect.git","clone_url":"https://github.com/tjhei/aspect.git","svn_url":"https://github.com/tjhei/aspect","homepage":null,"size":117944,"stargazers_count":0,"watchers_count":0,"language":"Gnuplot","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geodynamics:master","ref":"master","sha":"4913d0c2471973a5daebd2604ae0f1f025ba50ce","user":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"name":"aspect","full_name":"geodynamics/aspect","owner":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extendible finite element code to simulate thermal convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/geodynamics/aspect/deployments","created_at":"2014-05-06T16:47:18Z","updated_at":"2016-02-15T13:49:47Z","pushed_at":"2016-02-26T22:21:33Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"git@github.com:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"http://aspect.dealii.org/","size":129856,"stargazers_count":22,"watchers_count":22,"language":"Gnuplot","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":76,"forks":48,"open_issues":76,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/772"},"html":{"href":"https://github.com/geodynamics/aspect/pull/772"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/772"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/772/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/772/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/772/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/a4633081022dbba64d18322d050cff17574293bb"}}}}