{"action":"created","issue":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1399","repository_url":"https://api.github.com/repos/rockstor/rockstor-core","labels_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1399/labels{/name}","comments_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1399/comments","events_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1399/events","html_url":"https://github.com/rockstor/rockstor-core/pull/1399","id":165975903,"number":1399,"title":"improve nvme system disk compatibility. Fixes #1397","user":{"login":"phillxnet","id":2521585,"avatar_url":"https://avatars.githubusercontent.com/u/2521585?v=3","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-17T13:06:50Z","updated_at":"2016-07-19T15:04:23Z","closed_at":"2016-07-19T01:09:05Z","pull_request":{"url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1399","html_url":"https://github.com/rockstor/rockstor-core/pull/1399","diff_url":"https://github.com/rockstor/rockstor-core/pull/1399.diff","patch_url":"https://github.com/rockstor/rockstor-core/pull/1399.patch"},"body":"As nvme device names differ in format from previously accounted for devices the root_disk() method failed to properly return the base device name of a partition ie:\r\nbase device name = nvme0n1\r\nRockstor system partition on the above base device:\r\n3rd partition = nvme0n1p3\r\nThis lead to an unintentional return of the base device from scan_disks() as a device of interest. This in turn lead to db issues where the system disk was represented twice, once as it's base device and again as the usual system disk partition entry.\r\n\r\nThe changes presented here have been tested on regular, bios raid, and mdadm system disk installs and no regressions were observed.\r\n\r\nFixes #1397 \r\n\r\nThanks to @snafu in the following forum thread for helping to pinpoint this bug and for testing the changes presented here (to master) on an nvme system disk install by hand applying them to latest stable (3.8-14).\r\nhttps://forum.rockstor.com/t/unable-to-update-disk-state-for-nvme-device/1567\r\n\r\nPlease note that this patch does not address outstanding serial retrieval issues for nvme devices however @snafu in the above referenced thread has developed a working set of udev rules towards the end of that thread."},"comment":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/comments/233661953","html_url":"https://github.com/rockstor/rockstor-core/pull/1399#issuecomment-233661953","issue_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1399","id":233661953,"user":{"login":"phillxnet","id":2521585,"avatar_url":"https://avatars.githubusercontent.com/u/2521585?v=3","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T15:04:22Z","updated_at":"2016-07-19T15:04:22Z","body":"@schakrava Cheers."}}
{"actor":{"display_login":"phillxnet"}}