{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/86968071","pull_request_review_id":7598138,"id":86968071,"diff_hunk":"@@ -2559,6 +2559,33 @@ void ClearFatalExceptionHandlers(Environment* env) {\n       Undefined(env->isolate())).FromJust();\n }\n \n+// Call process.emitWarning(str), fmt is a snprintf() format string\n+void ProcessEmitWarning(Environment* env, const char* fmt, ...) {\n+  char warning[1024];\n+  va_list ap;\n+\n+  va_start(ap, fmt);\n+  vsnprintf(warning, sizeof(warning), fmt, ap);\n+  va_end(ap);\n+\n+  HandleScope handle_scope(env->isolate());\n+  Context::Scope context_scope(env->context());\n+\n+  Local<Object> process = env->process_object();\n+  MaybeLocal<Value> emitWarning = process->Get(env->context(),","path":"src/node.cc","position":17,"original_position":17,"commit_id":"8972adbe51477418e1d760a85e7152d5f6847ecd","original_commit_id":"8972adbe51477418e1d760a85e7152d5f6847ecd","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"`emit_warning`","created_at":"2016-11-08T11:12:00Z","updated_at":"2016-11-08T11:17:42Z","html_url":"https://github.com/nodejs/node/pull/9139#discussion_r86968071","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/9139","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/86968071"},"html":{"href":"https://github.com/nodejs/node/pull/9139#discussion_r86968071"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/9139"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9139","id":89687625,"html_url":"https://github.com/nodejs/node/pull/9139","diff_url":"https://github.com/nodejs/node/pull/9139.diff","patch_url":"https://github.com/nodejs/node/pull/9139.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9139","number":9139,"state":"open","locked":false,"title":"crypto: allow adding extra certs to well-known CAs","user":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"body":"##### Checklist\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\n- [x] tests and/or benchmarks are included\n- [x] documentation is changed or added\n- [x] commit message follows commit guidelines\n##### Affected core subsystem(s)\n\ncrypto,tls,https\n##### Description of change\n\nIn closed environments, self-signed or privately signed certificates are\ncommonly used, and rejected by Node.js since their root CAs are not\nwell-known. Allow extending the set of well-known compiled-in CAs via\nenvironment, so they can be set as a matter of policy.\n\nNote that #8334 addresses a similar but not identical use-case, and works better for those (like linux distributions) that are willing to recompile Node.js to use OpenSSL's default certificate store. #8334\ndoesn't address those who cannot recompile, do not have access to the system certificate store, or\nwho are are on a system where the default certificate store is not exposed as an OpenSSL compatible\nstore (for example, OS X and Windows).\n\nSee #3159, #8334 \n\nPartially fixes #4175 (particularly https://github.com/nodejs/node/issues/4175#issuecomment-171206355), and may also address https://github.com/Microsoft/tfs-cli/issues/118 and https://github.com/apigee/microgateway-core/issues/9 without forcing them to recompile node.\n","created_at":"2016-10-17T19:35:25Z","updated_at":"2016-11-08T11:17:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ec79b71fc953862a5746d62fc4d44020cf08a26","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9139/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9139/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9139/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/8972adbe51477418e1d760a85e7152d5f6847ecd","head":{"label":"sam-github:extendable-ca-certs","ref":"extendable-ca-certs","sha":"8972adbe51477418e1d760a85e7152d5f6847ecd","user":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"repo":{"id":28619971,"name":"node","full_name":"sam-github/node","owner":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sam-github/node","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/sam-github/node","forks_url":"https://api.github.com/repos/sam-github/node/forks","keys_url":"https://api.github.com/repos/sam-github/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sam-github/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sam-github/node/teams","hooks_url":"https://api.github.com/repos/sam-github/node/hooks","issue_events_url":"https://api.github.com/repos/sam-github/node/issues/events{/number}","events_url":"https://api.github.com/repos/sam-github/node/events","assignees_url":"https://api.github.com/repos/sam-github/node/assignees{/user}","branches_url":"https://api.github.com/repos/sam-github/node/branches{/branch}","tags_url":"https://api.github.com/repos/sam-github/node/tags","blobs_url":"https://api.github.com/repos/sam-github/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sam-github/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sam-github/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/sam-github/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sam-github/node/statuses/{sha}","languages_url":"https://api.github.com/repos/sam-github/node/languages","stargazers_url":"https://api.github.com/repos/sam-github/node/stargazers","contributors_url":"https://api.github.com/repos/sam-github/node/contributors","subscribers_url":"https://api.github.com/repos/sam-github/node/subscribers","subscription_url":"https://api.github.com/repos/sam-github/node/subscription","commits_url":"https://api.github.com/repos/sam-github/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/sam-github/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/sam-github/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/sam-github/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/sam-github/node/contents/{+path}","compare_url":"https://api.github.com/repos/sam-github/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sam-github/node/merges","archive_url":"https://api.github.com/repos/sam-github/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sam-github/node/downloads","issues_url":"https://api.github.com/repos/sam-github/node/issues{/number}","pulls_url":"https://api.github.com/repos/sam-github/node/pulls{/number}","milestones_url":"https://api.github.com/repos/sam-github/node/milestones{/number}","notifications_url":"https://api.github.com/repos/sam-github/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sam-github/node/labels{/name}","releases_url":"https://api.github.com/repos/sam-github/node/releases{/id}","deployments_url":"https://api.github.com/repos/sam-github/node/deployments","created_at":"2014-12-30T06:15:39Z","updated_at":"2016-10-24T15:57:21Z","pushed_at":"2016-11-07T21:27:39Z","git_url":"git://github.com/sam-github/node.git","ssh_url":"git@github.com:sam-github/node.git","clone_url":"https://github.com/sam-github/node.git","svn_url":"https://github.com/sam-github/node","homepage":null,"size":224325,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"a41b41a5409e41907982504dc0d6fd0c8c7968f9","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-11-08T11:12:20Z","pushed_at":"2016-11-08T11:00:41Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":358888,"stargazers_count":28689,"watchers_count":28689,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4812,"mirror_url":null,"open_issues_count":887,"forks":4812,"open_issues":887,"watchers":28689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9139"},"html":{"href":"https://github.com/nodejs/node/pull/9139"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9139"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9139/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9139/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9139/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/8972adbe51477418e1d760a85e7152d5f6847ecd"}}}}
{"actor":{"display_login":"bnoordhuis"}}