{"action":"created","comment":{"url":"https://api.github.com/repos/google/shaderc/pulls/comments/63532216","id":63532216,"diff_hunk":"@@ -59,11 +59,10 @@ An input file of - represents standard input.\n   -std=<value>      Version and profile for input files. Possible values\n                     are concatenations of version and profile, e.g. 310es,\n                     450core, etc.\n-  -masm=<dialect>   Output SPIRV binary code using selected dialect. The only\n-                    supported choice for now is c-init-list. When set to\n-                    c-init-list, output SPIRV binary code will be emitted as a\n-                    C-style initializer list. c-init-list is only valid when\n-                    the compilation output is SPIRV binary code.\n+  -mfmt=<format>    Output SPIR-V binary code using selected format. This option\n+                    is valid to be specified only when the compilation output\n+                    is in SPIR-V binary code form. Available options includes\n+                    bin, c and num.","path":"glslc/src/main.cc","position":null,"original_position":12,"commit_id":"475fd3bcef18f4ae61c537c1177b83b3a038e979","original_commit_id":"475fd3bcef18f4ae61c537c1177b83b3a038e979","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"body":"\"include\"","created_at":"2016-05-17T14:30:00Z","updated_at":"2016-05-17T14:30:00Z","html_url":"https://github.com/google/shaderc/pull/218#discussion_r63532216","pull_request_url":"https://api.github.com/repos/google/shaderc/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/google/shaderc/pulls/comments/63532216"},"html":{"href":"https://github.com/google/shaderc/pull/218#discussion_r63532216"},"pull_request":{"href":"https://api.github.com/repos/google/shaderc/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/google/shaderc/pulls/218","id":70108619,"html_url":"https://github.com/google/shaderc/pull/218","diff_url":"https://github.com/google/shaderc/pull/218.diff","patch_url":"https://github.com/google/shaderc/pull/218.patch","issue_url":"https://api.github.com/repos/google/shaderc/issues/218","number":218,"state":"open","locked":false,"title":"-mfmt=bin/c/num to emit binary as it is, numbers or C init list","user":{"login":"Qining","id":2983685,"avatar_url":"https://avatars.githubusercontent.com/u/2983685?v=3","gravatar_id":"","url":"https://api.github.com/users/Qining","html_url":"https://github.com/Qining","followers_url":"https://api.github.com/users/Qining/followers","following_url":"https://api.github.com/users/Qining/following{/other_user}","gists_url":"https://api.github.com/users/Qining/gists{/gist_id}","starred_url":"https://api.github.com/users/Qining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qining/subscriptions","organizations_url":"https://api.github.com/users/Qining/orgs","repos_url":"https://api.github.com/users/Qining/repos","events_url":"https://api.github.com/users/Qining/events{/privacy}","received_events_url":"https://api.github.com/users/Qining/received_events","type":"User","site_admin":false},"body":"Issue: #214\r\n\r\nAdd command line option: -masm=c-init-list to emit SPIRV binary code as\r\na C-style uint32_t array initializer list in the output file.\r\n\r\n-masm=c-init-list should only be specified when the compilation output\r\nis SPIRV binary code. When used with disassembly mode (-S) and\r\npreprocessing-only mode (-E), it will result in error and fail the\r\ncompilation. Note that dumping dependency info as compilation output (-M\r\nor -MM) also implies preprocessing-only (-E) and will lead to error.\r\nBut dumpping dependency info to extra .d file (-MD or -MMD) won't cause\r\nerror as the compilation output is still SPIRV binary code.","created_at":"2016-05-15T00:57:13Z","updated_at":"2016-05-17T14:30:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adf1a917323060dce9e2f71dfdf2d835febd7343","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/shaderc/pulls/218/commits","review_comments_url":"https://api.github.com/repos/google/shaderc/pulls/218/comments","review_comment_url":"https://api.github.com/repos/google/shaderc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/shaderc/issues/218/comments","statuses_url":"https://api.github.com/repos/google/shaderc/statuses/475fd3bcef18f4ae61c537c1177b83b3a038e979","head":{"label":"Qining:compile-to-uint32-array","ref":"compile-to-uint32-array","sha":"475fd3bcef18f4ae61c537c1177b83b3a038e979","user":{"login":"Qining","id":2983685,"avatar_url":"https://avatars.githubusercontent.com/u/2983685?v=3","gravatar_id":"","url":"https://api.github.com/users/Qining","html_url":"https://github.com/Qining","followers_url":"https://api.github.com/users/Qining/followers","following_url":"https://api.github.com/users/Qining/following{/other_user}","gists_url":"https://api.github.com/users/Qining/gists{/gist_id}","starred_url":"https://api.github.com/users/Qining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qining/subscriptions","organizations_url":"https://api.github.com/users/Qining/orgs","repos_url":"https://api.github.com/users/Qining/repos","events_url":"https://api.github.com/users/Qining/events{/privacy}","received_events_url":"https://api.github.com/users/Qining/received_events","type":"User","site_admin":false},"repo":{"id":48245210,"name":"shaderc","full_name":"Qining/shaderc","owner":{"login":"Qining","id":2983685,"avatar_url":"https://avatars.githubusercontent.com/u/2983685?v=3","gravatar_id":"","url":"https://api.github.com/users/Qining","html_url":"https://github.com/Qining","followers_url":"https://api.github.com/users/Qining/followers","following_url":"https://api.github.com/users/Qining/following{/other_user}","gists_url":"https://api.github.com/users/Qining/gists{/gist_id}","starred_url":"https://api.github.com/users/Qining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qining/subscriptions","organizations_url":"https://api.github.com/users/Qining/orgs","repos_url":"https://api.github.com/users/Qining/repos","events_url":"https://api.github.com/users/Qining/events{/privacy}","received_events_url":"https://api.github.com/users/Qining/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Qining/shaderc","description":"A collection of tools, libraries and tests for shader compilation.","fork":true,"url":"https://api.github.com/repos/Qining/shaderc","forks_url":"https://api.github.com/repos/Qining/shaderc/forks","keys_url":"https://api.github.com/repos/Qining/shaderc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qining/shaderc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qining/shaderc/teams","hooks_url":"https://api.github.com/repos/Qining/shaderc/hooks","issue_events_url":"https://api.github.com/repos/Qining/shaderc/issues/events{/number}","events_url":"https://api.github.com/repos/Qining/shaderc/events","assignees_url":"https://api.github.com/repos/Qining/shaderc/assignees{/user}","branches_url":"https://api.github.com/repos/Qining/shaderc/branches{/branch}","tags_url":"https://api.github.com/repos/Qining/shaderc/tags","blobs_url":"https://api.github.com/repos/Qining/shaderc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qining/shaderc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qining/shaderc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qining/shaderc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qining/shaderc/statuses/{sha}","languages_url":"https://api.github.com/repos/Qining/shaderc/languages","stargazers_url":"https://api.github.com/repos/Qining/shaderc/stargazers","contributors_url":"https://api.github.com/repos/Qining/shaderc/contributors","subscribers_url":"https://api.github.com/repos/Qining/shaderc/subscribers","subscription_url":"https://api.github.com/repos/Qining/shaderc/subscription","commits_url":"https://api.github.com/repos/Qining/shaderc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qining/shaderc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qining/shaderc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qining/shaderc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qining/shaderc/contents/{+path}","compare_url":"https://api.github.com/repos/Qining/shaderc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qining/shaderc/merges","archive_url":"https://api.github.com/repos/Qining/shaderc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qining/shaderc/downloads","issues_url":"https://api.github.com/repos/Qining/shaderc/issues{/number}","pulls_url":"https://api.github.com/repos/Qining/shaderc/pulls{/number}","milestones_url":"https://api.github.com/repos/Qining/shaderc/milestones{/number}","notifications_url":"https://api.github.com/repos/Qining/shaderc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qining/shaderc/labels{/name}","releases_url":"https://api.github.com/repos/Qining/shaderc/releases{/id}","deployments_url":"https://api.github.com/repos/Qining/shaderc/deployments","created_at":"2015-12-18T16:31:32Z","updated_at":"2016-02-18T17:37:57Z","pushed_at":"2016-05-17T13:53:38Z","git_url":"git://github.com/Qining/shaderc.git","ssh_url":"git@github.com:Qining/shaderc.git","clone_url":"https://github.com/Qining/shaderc.git","svn_url":"https://github.com/Qining/shaderc","homepage":"","size":629,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"5e1f49e86450ff361d8c8f459bb8b6fd7526bd18","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":40277133,"name":"shaderc","full_name":"google/shaderc","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/shaderc","description":"A collection of tools, libraries and tests for shader compilation.","fork":false,"url":"https://api.github.com/repos/google/shaderc","forks_url":"https://api.github.com/repos/google/shaderc/forks","keys_url":"https://api.github.com/repos/google/shaderc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/shaderc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/shaderc/teams","hooks_url":"https://api.github.com/repos/google/shaderc/hooks","issue_events_url":"https://api.github.com/repos/google/shaderc/issues/events{/number}","events_url":"https://api.github.com/repos/google/shaderc/events","assignees_url":"https://api.github.com/repos/google/shaderc/assignees{/user}","branches_url":"https://api.github.com/repos/google/shaderc/branches{/branch}","tags_url":"https://api.github.com/repos/google/shaderc/tags","blobs_url":"https://api.github.com/repos/google/shaderc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/shaderc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/shaderc/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/shaderc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/shaderc/statuses/{sha}","languages_url":"https://api.github.com/repos/google/shaderc/languages","stargazers_url":"https://api.github.com/repos/google/shaderc/stargazers","contributors_url":"https://api.github.com/repos/google/shaderc/contributors","subscribers_url":"https://api.github.com/repos/google/shaderc/subscribers","subscription_url":"https://api.github.com/repos/google/shaderc/subscription","commits_url":"https://api.github.com/repos/google/shaderc/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/shaderc/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/shaderc/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/shaderc/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/shaderc/contents/{+path}","compare_url":"https://api.github.com/repos/google/shaderc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/shaderc/merges","archive_url":"https://api.github.com/repos/google/shaderc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/shaderc/downloads","issues_url":"https://api.github.com/repos/google/shaderc/issues{/number}","pulls_url":"https://api.github.com/repos/google/shaderc/pulls{/number}","milestones_url":"https://api.github.com/repos/google/shaderc/milestones{/number}","notifications_url":"https://api.github.com/repos/google/shaderc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/shaderc/labels{/name}","releases_url":"https://api.github.com/repos/google/shaderc/releases{/id}","deployments_url":"https://api.github.com/repos/google/shaderc/deployments","created_at":"2015-08-06T01:17:42Z","updated_at":"2016-05-17T13:50:49Z","pushed_at":"2016-05-17T13:53:39Z","git_url":"git://github.com/google/shaderc.git","ssh_url":"git@github.com:google/shaderc.git","clone_url":"https://github.com/google/shaderc.git","svn_url":"https://github.com/google/shaderc","homepage":"","size":835,"stargazers_count":211,"watchers_count":211,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":8,"forks":25,"open_issues":8,"watchers":211,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/shaderc/pulls/218"},"html":{"href":"https://github.com/google/shaderc/pull/218"},"issue":{"href":"https://api.github.com/repos/google/shaderc/issues/218"},"comments":{"href":"https://api.github.com/repos/google/shaderc/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/google/shaderc/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/google/shaderc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/shaderc/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/google/shaderc/statuses/475fd3bcef18f4ae61c537c1177b83b3a038e979"}}}}