{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/capital-framework/issues/395","repository_url":"https://api.github.com/repos/cfpb/capital-framework","labels_url":"https://api.github.com/repos/cfpb/capital-framework/issues/395/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/capital-framework/issues/395/comments","events_url":"https://api.github.com/repos/cfpb/capital-framework/issues/395/events","html_url":"https://github.com/cfpb/capital-framework/pull/395","id":174125609,"number":395,"title":"Updated form inputs to atomic design principles","user":{"login":"jimmynotjim","id":1280430,"avatar_url":"https://avatars.githubusercontent.com/u/1280430?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"assignees":[{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-30T21:04:10Z","updated_at":"2016-09-01T19:53:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/capital-framework/pulls/395","html_url":"https://github.com/cfpb/capital-framework/pull/395","diff_url":"https://github.com/cfpb/capital-framework/pull/395.diff","patch_url":"https://github.com/cfpb/capital-framework/pull/395.patch"},"body":"Updates form inputs as well as a few necessary parent molecules and organisms of the inputs.\r\n\r\n## Additions\r\n\r\n- Added `text-input` atom to combine all text style inputs as one and reduce specificity of existing inputs.\r\n- Added `checkbox` and `radio` atoms to simplify styles. Removes the need for hiding the input and relying on pseudo elems on the label.\r\n- Added `label` atom with heading modifier.\r\n\r\n## Removals\r\n\r\n- Removed form variables from cf-core\r\n\r\n## Changes\r\n\r\n- Updated form variable naming scheme to be more consistent with each other and our BEM style principles.\r\n\r\n## Testing\r\n\r\n- run `npm run cf-link`\r\n- in a tab with the sandbox repo run the following:\r\n    - checkout the `form-examples` [branch](https://github.com/cfpb/capital-framework-sandbox/pull/23) \r\n    - run `npm run cf-link`\r\n    - run `npm run build`\r\n    - run `npm start`\r\n    - navigate to http://localhost:3000/components/cf-forms/ and check out the text inputs at the top and the Atomic Filter Form at the bottom. Ignore all the broken bits, those are fixed and ready for a follow up PR.\r\n\r\n## Review\r\n\r\n- @mistergone \r\n- @cfarm \r\n- @KimberlyMunoz \r\n- @Scotchester \r\n\r\n## Screenshots\r\n\r\n__Labels__\r\n\r\n![screen shot 2016-08-30 at 4 01 10 pm](https://cloud.githubusercontent.com/assets/1280430/18106858/fe600d04-6eca-11e6-941a-fcdb307f95e2.png)\r\n\r\n__Basic inputs__\r\n\r\n![screen shot 2016-08-30 at 4 01 30 pm](https://cloud.githubusercontent.com/assets/1280430/18106867/0d98dcc4-6ecb-11e6-85a5-4170864e398a.png)\r\n\r\n__Input states__\r\n\r\n![screen shot 2016-08-30 at 4 01 52 pm](https://cloud.githubusercontent.com/assets/1280430/18106880/173e7c7a-6ecb-11e6-9b9b-8e0d38902168.png)\r\n\r\n__Filter form example__\r\n\r\n![screen shot 2016-08-30 at 4 02 22 pm](https://cloud.githubusercontent.com/assets/1280430/18106895/29d2f37a-6ecb-11e6-8333-9a2231563855.png)\r\n\r\n## Notes\r\n\r\n- ⚠️  __WARNING:__ The sandbox branch breaks a lot of the other form elements. There are upcoming PRs to fix those, please ignore for the time being.\r\n\r\n## Checklist\r\n\r\n* [x] Changes are limited to a single goal (no scope creep)\r\n* [x] Code can be automatically merged (no conflicts)\r\n* [x] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [x] Passes all existing automated tests\r\n* [x] New functions include new tests\r\n* [x] New functions are documented (with a description, list of inputs, and expected output)\r\n* [x] Placeholder code is flagged\r\n* [ ] Visually tested in supported browsers and devices\r\n* [ ] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)"},"comment":{"url":"https://api.github.com/repos/cfpb/capital-framework/issues/comments/244192627","html_url":"https://github.com/cfpb/capital-framework/pull/395#issuecomment-244192627","issue_url":"https://api.github.com/repos/cfpb/capital-framework/issues/395","id":244192627,"user":{"login":"cfarm","id":702526,"avatar_url":"https://avatars.githubusercontent.com/u/702526?v=3","gravatar_id":"","url":"https://api.github.com/users/cfarm","html_url":"https://github.com/cfarm","followers_url":"https://api.github.com/users/cfarm/followers","following_url":"https://api.github.com/users/cfarm/following{/other_user}","gists_url":"https://api.github.com/users/cfarm/gists{/gist_id}","starred_url":"https://api.github.com/users/cfarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfarm/subscriptions","organizations_url":"https://api.github.com/users/cfarm/orgs","repos_url":"https://api.github.com/users/cfarm/repos","events_url":"https://api.github.com/users/cfarm/events{/privacy}","received_events_url":"https://api.github.com/users/cfarm/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T19:53:29Z","updated_at":"2016-09-01T19:53:29Z","body":"@mistergone make sure to push that lil merge button after you thumbs up a PR. for now, I get the pleasure of doing it on this one,mwaha"}}
{"actor":{"display_login":"cfarm"}}