{"action":"opened","number":25426,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/25426","id":74266425,"html_url":"https://github.com/rails/rails/pull/25426","diff_url":"https://github.com/rails/rails/pull/25426.diff","patch_url":"https://github.com/rails/rails/pull/25426.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/25426","number":25426,"state":"open","locked":false,"title":"Fix jobs overriding AJ::Base#logger","user":{"login":"casperisfine","id":19192189,"avatar_url":"https://avatars.githubusercontent.com/u/19192189?v=3","gravatar_id":"","url":"https://api.github.com/users/casperisfine","html_url":"https://github.com/casperisfine","followers_url":"https://api.github.com/users/casperisfine/followers","following_url":"https://api.github.com/users/casperisfine/following{/other_user}","gists_url":"https://api.github.com/users/casperisfine/gists{/gist_id}","starred_url":"https://api.github.com/users/casperisfine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casperisfine/subscriptions","organizations_url":"https://api.github.com/users/casperisfine/orgs","repos_url":"https://api.github.com/users/casperisfine/repos","events_url":"https://api.github.com/users/casperisfine/events{/privacy}","received_events_url":"https://api.github.com/users/casperisfine/received_events","type":"User","site_admin":false},"body":"I was tracking down this bug on our test suite:\r\n\r\n```ruby\r\n    NoMethodError: undefined method `tagged' for #<Logger:0x007fba48a52ad0>\r\n    (activejob-4.2.6) lib/active_job/logging.rb:43 in `tag_logger`\r\n    (activejob-4.2.6) lib/active_job/logging.rb:13 in `in `block (2 levels) in <module`\r\n    (activesupport-4.2.6) lib/active_support/callbacks.rb:441 in `instance_exec`\r\n    (activesupport-4.2.6) lib/active_support/callbacks.rb:441 in `block in make_lambda`\r\n    (activesupport-4.2.6) lib/active_support/callbacks.rb:342 in `call`\r\n    (activesupport-4.2.6) lib/active_support/callbacks.rb:342 in `block in simple`\r\n    (activesupport-4.2.6) lib/active_support/callbacks.rb:497 in `call`\r\n    (activesupport-4.2.6) lib/active_support/callbacks.rb:497 in `block in around`\r\n    (activesupport-4.2.6) lib/active_support/callbacks.rb:505 in `call`\r\n    (activesupport-4.2.6) lib/active_support/callbacks.rb:505 in `call`\r\n    (activesupport-4.2.6) lib/active_support/callbacks.rb:92 in `__run_callbacks__`\r\n    (activesupport-4.2.6) lib/active_support/callbacks.rb:778 in `_run_enqueue_callbacks`\r\n    (activesupport-4.2.6) lib/active_support/callbacks.rb:81 in `run_callbacks`\r\n    (activejob-4.2.6) lib/active_job/enqueuing.rb:67 in `enqueue`\r\n```\r\n\r\nTurns out, we migrated a lot of old code to ActiveJob, and some of those old job had a `logger` method.\r\nIn some specific cases, `#logger` would be taggable, but `ActiveJob::Base.logger` wouldn't.\r\n\r\n@rafaelfranca ","created_at":"2016-06-17T16:03:46Z","updated_at":"2016-06-17T16:03:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/25426/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/25426/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/25426/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/61d6d2d8c64ade29d1ebd4b4ae6dae05a77b9158","head":{"label":"Shopify:fix-activejob-logger","ref":"fix-activejob-logger","sha":"61d6d2d8c64ade29d1ebd4b4ae6dae05a77b9158","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":60858413,"name":"rails","full_name":"Shopify/rails","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/Shopify/rails","forks_url":"https://api.github.com/repos/Shopify/rails/forks","keys_url":"https://api.github.com/repos/Shopify/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/rails/teams","hooks_url":"https://api.github.com/repos/Shopify/rails/hooks","issue_events_url":"https://api.github.com/repos/Shopify/rails/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/rails/events","assignees_url":"https://api.github.com/repos/Shopify/rails/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/rails/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/rails/tags","blobs_url":"https://api.github.com/repos/Shopify/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/rails/languages","stargazers_url":"https://api.github.com/repos/Shopify/rails/stargazers","contributors_url":"https://api.github.com/repos/Shopify/rails/contributors","subscribers_url":"https://api.github.com/repos/Shopify/rails/subscribers","subscription_url":"https://api.github.com/repos/Shopify/rails/subscription","commits_url":"https://api.github.com/repos/Shopify/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/rails/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/rails/merges","archive_url":"https://api.github.com/repos/Shopify/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/rails/downloads","issues_url":"https://api.github.com/repos/Shopify/rails/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/rails/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/rails/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/rails/deployments","created_at":"2016-06-10T15:34:34Z","updated_at":"2016-06-10T15:35:37Z","pushed_at":"2016-06-17T16:01:00Z","git_url":"git://github.com/Shopify/rails.git","ssh_url":"git@github.com:Shopify/rails.git","clone_url":"https://github.com/Shopify/rails.git","svn_url":"https://github.com/Shopify/rails","homepage":"http://rubyonrails.org","size":138488,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"30dd8b2cb0913b2ecc94d2b1d9e29b15e5913f71","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-06-17T14:22:57Z","pushed_at":"2016-06-17T16:03:47Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":346608,"stargazers_count":31613,"watchers_count":31613,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12787,"mirror_url":null,"open_issues_count":1051,"forks":12787,"open_issues":1051,"watchers":31613,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/25426"},"html":{"href":"https://github.com/rails/rails/pull/25426"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/25426"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/25426/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/25426/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/25426/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/61d6d2d8c64ade29d1ebd4b4ae6dae05a77b9158"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"casperisfine"}}