{"push_id":1263849667,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"5d93290e42d74f05a86d985a89f58e1a8fe87f88","before":"b521f2349e46888514ce55d06ace1d8c5fa6df03","commits":[{"sha":"5d93290e42d74f05a86d985a89f58e1a8fe87f88","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Update Celerity map parser for new docblock code\n\nSummary:\nAfter D16431, listing the same `@annotation` multiple times makes the docblock parser return a list.\n\nWe have some resources which list `@requires` or `@provides` several times, but don't handle the new parser properly. Make the code more flexible, since this is a reasonable way to specify the annotations.\n\nSee also D16432. This produces a failure in this form:\n\n```\n[2016-08-23 21:10:15] ERROR 2: trim() expects parameter 1 to be string, array given at [/core/data/drydock/workingcopy-74/repo/phabricator/src/applications/celerity/CelerityResourceMapGenerator.php:236]\n2\tarcanist(head=master, ref.master=89e8b4852384), phabricator(head=6c940fb71b0a8850c6a1b7f5fc642a8f8135a76a, ref.master=b521f2349e46), phutil(head=master, ref.master=237549280f08)\n3\t  #0 trim(array) called at [<phabricator>/src/applications/celerity/CelerityResourceMapGenerator.php:236]\n4\t  #1 CelerityResourceMapGenerator::getProvidesAndRequires(string, string) called at [<phabricator>/src/applications/celerity/CelerityResourceMapGenerator.php:193]\n5\t  #2 CelerityResourceMapGenerator::rebuildTextResources(CelerityPhabricatorResources, CelerityResourceTransformer) called at [<phabricator>/src/applications/celerity/CelerityResourceMapGenerator.php:54]\n6\t  #3 CelerityResourceMapGenerator::generate() called at [<phabricator>/src/__tests__/PhabricatorCelerityTestCase.php:16]\n7\t  #4 PhabricatorCelerityTestCase::testCelerityMaps()\n8\t  #5 call_user_func_array(array, array) called at [<arcanist>/src/unit/engine/phutil/PhutilTestCase.php:492]\n9\t  #6 PhutilTestCase::run() called at [<arcanist>/src/unit/engine/PhutilUnitTestEngine.php:69]\n10\t  #7 PhutilUnitTestEngine::run() called at [<arcanist>/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:147]\n11\t  #8 ArcanistConfigurationDrivenUnitTestEngine::run() called at [<arcanist>/src/workflow/ArcanistUnitWorkflow.php:167]\n12\t  #9 ArcanistUnitWorkflow::run() called at [<arcanist>/scripts/arcanist.php:394]\n```\n\nTest Plan: Ran `bin/celerity map`, no more warnings and no change to the actual map.\n\nReviewers: joshuaspence, chad\n\nReviewed By: chad\n\nDifferential Revision: https://secure.phabricator.com/D16433","distinct":true,"url":"https://api.github.com/repos/phacility/phabricator/commits/5d93290e42d74f05a86d985a89f58e1a8fe87f88"}]}
{"actor":{"display_login":"epriestley"}}