{"action":"created","comment":{"url":"https://api.github.com/repos/RobotLocomotion/director/pulls/comments/59655023","id":59655023,"diff_hunk":"@@ -685,38 +686,45 @@ def onPlanStatus(msg):\n         if polyData:\n             vis.showPolyData(polyData, os.path.basename(filename))\n \n-\n-if useImageWidget:\n-    imageWidget = cameraview.ImageWidget(cameraview.imageManager, 'CAMERA_LEFT', view)\n-    #imageWidget = cameraview.ImageWidget(cameraview.imageManager, 'KINECT_RGB', view)\n-\n if useCameraFrustumVisualizer and cameraview.CameraFrustumVisualizer.isCompatibleWithConfig():\n     cameraFrustumVisualizer = cameraview.CameraFrustumVisualizer(robotStateModel, cameraview.imageManager, 'CAMERA_LEFT')\n \n class ImageOverlayManager(object):\n \n     def __init__(self):\n         self.viewName = 'CAMERA_LEFT'\n-        #self.viewName = 'KINECT_RGB'\n-        self.size = 400\n+        self.desiredWidth = 400\n+        self.size = [self.desiredWidth, self.desiredWidth/(4/3.)]","path":"src/python/director/startup.py","position":36,"original_position":36,"commit_id":"eb6179e7c34848b8ff34e556af8fba5b9243f98a","original_commit_id":"eb6179e7c34848b8ff34e556af8fba5b9243f98a","user":{"login":"patmarion","id":90784,"avatar_url":"https://avatars.githubusercontent.com/u/90784?v=3","gravatar_id":"","url":"https://api.github.com/users/patmarion","html_url":"https://github.com/patmarion","followers_url":"https://api.github.com/users/patmarion/followers","following_url":"https://api.github.com/users/patmarion/following{/other_user}","gists_url":"https://api.github.com/users/patmarion/gists{/gist_id}","starred_url":"https://api.github.com/users/patmarion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patmarion/subscriptions","organizations_url":"https://api.github.com/users/patmarion/orgs","repos_url":"https://api.github.com/users/patmarion/repos","events_url":"https://api.github.com/users/patmarion/events{/privacy}","received_events_url":"https://api.github.com/users/patmarion/received_events","type":"User","site_admin":false},"body":"this should be reverted, the aspect ration needs to be defined by the image dimensions after the first image is received by lcm, it should not be hard coded","created_at":"2016-04-14T02:04:55Z","updated_at":"2016-04-14T02:04:55Z","html_url":"https://github.com/RobotLocomotion/director/pull/212#discussion_r59655023","pull_request_url":"https://api.github.com/repos/RobotLocomotion/director/pulls/212","_links":{"self":{"href":"https://api.github.com/repos/RobotLocomotion/director/pulls/comments/59655023"},"html":{"href":"https://github.com/RobotLocomotion/director/pull/212#discussion_r59655023"},"pull_request":{"href":"https://api.github.com/repos/RobotLocomotion/director/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/director/pulls/212","id":62244213,"html_url":"https://github.com/RobotLocomotion/director/pull/212","diff_url":"https://github.com/RobotLocomotion/director/pull/212.diff","patch_url":"https://github.com/RobotLocomotion/director/pull/212.patch","issue_url":"https://api.github.com/repos/RobotLocomotion/director/issues/212","number":212,"state":"closed","locked":false,"title":"Image Widgets: auto-detect aspect ratio for ImageOverlayManager, make ImageWidget default","user":{"login":"wxmerkt","id":1664508,"avatar_url":"https://avatars.githubusercontent.com/u/1664508?v=3","gravatar_id":"","url":"https://api.github.com/users/wxmerkt","html_url":"https://github.com/wxmerkt","followers_url":"https://api.github.com/users/wxmerkt/followers","following_url":"https://api.github.com/users/wxmerkt/following{/other_user}","gists_url":"https://api.github.com/users/wxmerkt/gists{/gist_id}","starred_url":"https://api.github.com/users/wxmerkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxmerkt/subscriptions","organizations_url":"https://api.github.com/users/wxmerkt/orgs","repos_url":"https://api.github.com/users/wxmerkt/repos","events_url":"https://api.github.com/users/wxmerkt/events{/privacy}","received_events_url":"https://api.github.com/users/wxmerkt/received_events","type":"User","site_admin":false},"body":"This PR includes two changes to the ImageOverlayManager and ImageWidget:\r\n\r\n1. ImageOverlayManager now auto-detects the aspect ratio of the image to be displayed so that there is no more black borders at the top and bottom of the image\r\n2. ImageWidget can be initialised hidden\r\n3. ImageWidget is now the default for the toggle button in the user interface. The rationale behind this is that we often record videos with an image overlay on only to realise afterwards that it's a black spot instead of the video\r\n4. The source of an ImageWidget can be changed without having to re-initialise the object\r\n\r\nPat, there are two remaining issues that I'd like to get your input on:\r\n\r\n1. ImageWidget has unused padding left and right of the image, yet I could not find the right vtk command to get rid of it\r\n2. ImageOverlayManager had a better image quality than ImageWidget does\r\n\r\nThanks :)","created_at":"2016-03-09T15:22:11Z","updated_at":"2016-04-14T02:04:55Z","closed_at":"2016-03-10T12:55:21Z","merged_at":"2016-03-10T12:55:21Z","merge_commit_sha":"8ea3efddfe67ce6f07955277f4a88ea6006893b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RobotLocomotion/director/pulls/212/commits","review_comments_url":"https://api.github.com/repos/RobotLocomotion/director/pulls/212/comments","review_comment_url":"https://api.github.com/repos/RobotLocomotion/director/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RobotLocomotion/director/issues/212/comments","statuses_url":"https://api.github.com/repos/RobotLocomotion/director/statuses/eb6179e7c34848b8ff34e556af8fba5b9243f98a","head":{"label":"openhumanoids:wxm-image-widgets","ref":"wxm-image-widgets","sha":"eb6179e7c34848b8ff34e556af8fba5b9243f98a","user":{"login":"openhumanoids","id":6392416,"avatar_url":"https://avatars.githubusercontent.com/u/6392416?v=3","gravatar_id":"","url":"https://api.github.com/users/openhumanoids","html_url":"https://github.com/openhumanoids","followers_url":"https://api.github.com/users/openhumanoids/followers","following_url":"https://api.github.com/users/openhumanoids/following{/other_user}","gists_url":"https://api.github.com/users/openhumanoids/gists{/gist_id}","starred_url":"https://api.github.com/users/openhumanoids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhumanoids/subscriptions","organizations_url":"https://api.github.com/users/openhumanoids/orgs","repos_url":"https://api.github.com/users/openhumanoids/repos","events_url":"https://api.github.com/users/openhumanoids/events{/privacy}","received_events_url":"https://api.github.com/users/openhumanoids/received_events","type":"Organization","site_admin":false},"repo":{"id":41318197,"name":"director","full_name":"openhumanoids/director","owner":{"login":"openhumanoids","id":6392416,"avatar_url":"https://avatars.githubusercontent.com/u/6392416?v=3","gravatar_id":"","url":"https://api.github.com/users/openhumanoids","html_url":"https://github.com/openhumanoids","followers_url":"https://api.github.com/users/openhumanoids/followers","following_url":"https://api.github.com/users/openhumanoids/following{/other_user}","gists_url":"https://api.github.com/users/openhumanoids/gists{/gist_id}","starred_url":"https://api.github.com/users/openhumanoids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhumanoids/subscriptions","organizations_url":"https://api.github.com/users/openhumanoids/orgs","repos_url":"https://api.github.com/users/openhumanoids/repos","events_url":"https://api.github.com/users/openhumanoids/events{/privacy}","received_events_url":"https://api.github.com/users/openhumanoids/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhumanoids/director","description":"A robotics interface and visualization framework, with extensive applications for working with http://drake.mit.edu","fork":true,"url":"https://api.github.com/repos/openhumanoids/director","forks_url":"https://api.github.com/repos/openhumanoids/director/forks","keys_url":"https://api.github.com/repos/openhumanoids/director/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhumanoids/director/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhumanoids/director/teams","hooks_url":"https://api.github.com/repos/openhumanoids/director/hooks","issue_events_url":"https://api.github.com/repos/openhumanoids/director/issues/events{/number}","events_url":"https://api.github.com/repos/openhumanoids/director/events","assignees_url":"https://api.github.com/repos/openhumanoids/director/assignees{/user}","branches_url":"https://api.github.com/repos/openhumanoids/director/branches{/branch}","tags_url":"https://api.github.com/repos/openhumanoids/director/tags","blobs_url":"https://api.github.com/repos/openhumanoids/director/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhumanoids/director/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhumanoids/director/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhumanoids/director/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhumanoids/director/statuses/{sha}","languages_url":"https://api.github.com/repos/openhumanoids/director/languages","stargazers_url":"https://api.github.com/repos/openhumanoids/director/stargazers","contributors_url":"https://api.github.com/repos/openhumanoids/director/contributors","subscribers_url":"https://api.github.com/repos/openhumanoids/director/subscribers","subscription_url":"https://api.github.com/repos/openhumanoids/director/subscription","commits_url":"https://api.github.com/repos/openhumanoids/director/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhumanoids/director/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhumanoids/director/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhumanoids/director/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhumanoids/director/contents/{+path}","compare_url":"https://api.github.com/repos/openhumanoids/director/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhumanoids/director/merges","archive_url":"https://api.github.com/repos/openhumanoids/director/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhumanoids/director/downloads","issues_url":"https://api.github.com/repos/openhumanoids/director/issues{/number}","pulls_url":"https://api.github.com/repos/openhumanoids/director/pulls{/number}","milestones_url":"https://api.github.com/repos/openhumanoids/director/milestones{/number}","notifications_url":"https://api.github.com/repos/openhumanoids/director/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhumanoids/director/labels{/name}","releases_url":"https://api.github.com/repos/openhumanoids/director/releases{/id}","deployments_url":"https://api.github.com/repos/openhumanoids/director/deployments","created_at":"2015-08-24T17:50:35Z","updated_at":"2016-04-10T07:42:32Z","pushed_at":"2016-04-13T16:27:21Z","git_url":"git://github.com/openhumanoids/director.git","ssh_url":"git@github.com:openhumanoids/director.git","clone_url":"https://github.com/openhumanoids/director.git","svn_url":"https://github.com/openhumanoids/director","homepage":"","size":21117,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"RobotLocomotion:master","ref":"master","sha":"e26a219c5db14b635947af48a61f7900683165e2","user":{"login":"RobotLocomotion","id":6496345,"avatar_url":"https://avatars.githubusercontent.com/u/6496345?v=3","gravatar_id":"","url":"https://api.github.com/users/RobotLocomotion","html_url":"https://github.com/RobotLocomotion","followers_url":"https://api.github.com/users/RobotLocomotion/followers","following_url":"https://api.github.com/users/RobotLocomotion/following{/other_user}","gists_url":"https://api.github.com/users/RobotLocomotion/gists{/gist_id}","starred_url":"https://api.github.com/users/RobotLocomotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobotLocomotion/subscriptions","organizations_url":"https://api.github.com/users/RobotLocomotion/orgs","repos_url":"https://api.github.com/users/RobotLocomotion/repos","events_url":"https://api.github.com/users/RobotLocomotion/events{/privacy}","received_events_url":"https://api.github.com/users/RobotLocomotion/received_events","type":"Organization","site_admin":false},"repo":{"id":23202451,"name":"director","full_name":"RobotLocomotion/director","owner":{"login":"RobotLocomotion","id":6496345,"avatar_url":"https://avatars.githubusercontent.com/u/6496345?v=3","gravatar_id":"","url":"https://api.github.com/users/RobotLocomotion","html_url":"https://github.com/RobotLocomotion","followers_url":"https://api.github.com/users/RobotLocomotion/followers","following_url":"https://api.github.com/users/RobotLocomotion/following{/other_user}","gists_url":"https://api.github.com/users/RobotLocomotion/gists{/gist_id}","starred_url":"https://api.github.com/users/RobotLocomotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobotLocomotion/subscriptions","organizations_url":"https://api.github.com/users/RobotLocomotion/orgs","repos_url":"https://api.github.com/users/RobotLocomotion/repos","events_url":"https://api.github.com/users/RobotLocomotion/events{/privacy}","received_events_url":"https://api.github.com/users/RobotLocomotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RobotLocomotion/director","description":"A robotics interface and visualization framework, with extensive applications for working with http://drake.mit.edu","fork":false,"url":"https://api.github.com/repos/RobotLocomotion/director","forks_url":"https://api.github.com/repos/RobotLocomotion/director/forks","keys_url":"https://api.github.com/repos/RobotLocomotion/director/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RobotLocomotion/director/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RobotLocomotion/director/teams","hooks_url":"https://api.github.com/repos/RobotLocomotion/director/hooks","issue_events_url":"https://api.github.com/repos/RobotLocomotion/director/issues/events{/number}","events_url":"https://api.github.com/repos/RobotLocomotion/director/events","assignees_url":"https://api.github.com/repos/RobotLocomotion/director/assignees{/user}","branches_url":"https://api.github.com/repos/RobotLocomotion/director/branches{/branch}","tags_url":"https://api.github.com/repos/RobotLocomotion/director/tags","blobs_url":"https://api.github.com/repos/RobotLocomotion/director/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RobotLocomotion/director/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RobotLocomotion/director/git/refs{/sha}","trees_url":"https://api.github.com/repos/RobotLocomotion/director/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RobotLocomotion/director/statuses/{sha}","languages_url":"https://api.github.com/repos/RobotLocomotion/director/languages","stargazers_url":"https://api.github.com/repos/RobotLocomotion/director/stargazers","contributors_url":"https://api.github.com/repos/RobotLocomotion/director/contributors","subscribers_url":"https://api.github.com/repos/RobotLocomotion/director/subscribers","subscription_url":"https://api.github.com/repos/RobotLocomotion/director/subscription","commits_url":"https://api.github.com/repos/RobotLocomotion/director/commits{/sha}","git_commits_url":"https://api.github.com/repos/RobotLocomotion/director/git/commits{/sha}","comments_url":"https://api.github.com/repos/RobotLocomotion/director/comments{/number}","issue_comment_url":"https://api.github.com/repos/RobotLocomotion/director/issues/comments{/number}","contents_url":"https://api.github.com/repos/RobotLocomotion/director/contents/{+path}","compare_url":"https://api.github.com/repos/RobotLocomotion/director/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RobotLocomotion/director/merges","archive_url":"https://api.github.com/repos/RobotLocomotion/director/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RobotLocomotion/director/downloads","issues_url":"https://api.github.com/repos/RobotLocomotion/director/issues{/number}","pulls_url":"https://api.github.com/repos/RobotLocomotion/director/pulls{/number}","milestones_url":"https://api.github.com/repos/RobotLocomotion/director/milestones{/number}","notifications_url":"https://api.github.com/repos/RobotLocomotion/director/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RobotLocomotion/director/labels{/name}","releases_url":"https://api.github.com/repos/RobotLocomotion/director/releases{/id}","deployments_url":"https://api.github.com/repos/RobotLocomotion/director/deployments","created_at":"2014-08-21T20:45:56Z","updated_at":"2016-04-10T17:41:25Z","pushed_at":"2016-04-14T02:03:00Z","git_url":"git://github.com/RobotLocomotion/director.git","ssh_url":"git@github.com:RobotLocomotion/director.git","clone_url":"https://github.com/RobotLocomotion/director.git","svn_url":"https://github.com/RobotLocomotion/director","homepage":"","size":19822,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":21,"forks":19,"open_issues":21,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RobotLocomotion/director/pulls/212"},"html":{"href":"https://github.com/RobotLocomotion/director/pull/212"},"issue":{"href":"https://api.github.com/repos/RobotLocomotion/director/issues/212"},"comments":{"href":"https://api.github.com/repos/RobotLocomotion/director/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/RobotLocomotion/director/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/RobotLocomotion/director/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RobotLocomotion/director/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/RobotLocomotion/director/statuses/eb6179e7c34848b8ff34e556af8fba5b9243f98a"}}}}