{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/567","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/567/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/567/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/567/events","html_url":"https://github.com/vufind-org/vufind/pull/567","id":127478589,"number":567,"title":"Multiple subfields in 264","user":{"login":"witzigs","id":9479686,"avatar_url":"https://avatars.githubusercontent.com/u/9479686?v=3","gravatar_id":"","url":"https://api.github.com/users/witzigs","html_url":"https://github.com/witzigs","followers_url":"https://api.github.com/users/witzigs/followers","following_url":"https://api.github.com/users/witzigs/following{/other_user}","gists_url":"https://api.github.com/users/witzigs/gists{/gist_id}","starred_url":"https://api.github.com/users/witzigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witzigs/subscriptions","organizations_url":"https://api.github.com/users/witzigs/orgs","repos_url":"https://api.github.com/users/witzigs/repos","events_url":"https://api.github.com/users/witzigs/events{/privacy}","received_events_url":"https://api.github.com/users/witzigs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-01-19T16:02:21Z","updated_at":"2016-01-28T18:07:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/567","html_url":"https://github.com/vufind-org/vufind/pull/567","diff_url":"https://github.com/vufind-org/vufind/pull/567.diff","patch_url":"https://github.com/vufind-org/vufind/pull/567.patch"},"body":"Subfields in 264 are repeatable. Currently this information is not displayed in VuFind. This PR adds support for such cases.\r\n\r\nAdditionally I removed the array merge which merges information from fields 260 and 264 if both are present in a record. This usually shouldn't be happening but if it does anyway, it's better to prefer the information from one field instead of doubling the information."},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/176310281","html_url":"https://github.com/vufind-org/vufind/pull/567#issuecomment-176310281","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/567","id":176310281,"user":{"login":"demiankatz","id":309069,"avatar_url":"https://avatars.githubusercontent.com/u/309069?v=3","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"created_at":"2016-01-28T18:07:42Z","updated_at":"2016-01-28T18:07:42Z","body":"@witzigs, Please take a look at #577 - this contains my initial work on adding support for repeating subfields to the indexing routines. It also includes an alternate implementation on the SolrMarc record driver that simplifies the code for combining subfields by using the existing getSubfieldArray() routine. Right now it's using the default \"concatenate = true\" parameter on getSubfieldArray to collapse subfields using existing embedded punctuation. However, this could be further customized to send \"concatenate = false\" and then implode the resulting array in situations where the source MARC data does not already include punctuation.\r\n\r\nI've also sent out some notes on this conversation to a metadata advisory group that I am a part of in hope of collecting some more input on best practices.\r\n\r\nI'll wait until I hear more (and perhaps until after the next developers call on Tuesday, February 2nd) before closing or merging anything... but hopefully we're getting closer to a complete and workable solution. I'm interested to hear your thoughts!"}}