{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/58797671","id":58797671,"diff_hunk":"@@ -12,125 +12,187 @@ using System.Threading;\n using System.Collections.Generic;\n using System.Runtime.CompilerServices;\n using System.Net;\n+using System.Globalization;\n \n-//\n-// Arguments\n-//\n-\n-// This is due to a design decision in csi that has Args non-static.\n-// Non-static variables are impossible to read inide of nested classes.\n-static IEnumerable<string> StaticArgs = null;\n-StaticArgs = Args;\n-\n-/// Returns the path to log file if one exists.\n-/// Returns null otherwise.\n-static string LogFile()\n+class RelativeDirectory \n {\n-    var key = \"--log=\";\n-    return (from arg in StaticArgs where arg.StartsWith(key) select arg.Substring(key.Length)).FirstOrDefault();\n-}\n+    string _workingFile;\n+    \n+    public RelativeDirectory([CallerFilePath] string workingFile = \"\") \n+    {\n+        _workingFile = workingFile;\n+    }\n+    \n+    public string MyWorkingDirectory => Directory.GetParent(_workingFile).FullName;\n+    \n+\n+    /// Returns the directory that you can put artifacts like\n+    /// etl traces or compiled binaries\n+    public string MyArtifactsDirectory ","path":"src/Test/Perf/util/test_util.csx","position":35,"original_position":35,"commit_id":"7cc6a50367c7485ebaafaaa214c3d2f8973a1eb8","original_commit_id":"7cc6a50367c7485ebaafaaa214c3d2f8973a1eb8","user":{"login":"TyOverby","id":573215,"avatar_url":"https://avatars.githubusercontent.com/u/573215?v=3","gravatar_id":"","url":"https://api.github.com/users/TyOverby","html_url":"https://github.com/TyOverby","followers_url":"https://api.github.com/users/TyOverby/followers","following_url":"https://api.github.com/users/TyOverby/following{/other_user}","gists_url":"https://api.github.com/users/TyOverby/gists{/gist_id}","starred_url":"https://api.github.com/users/TyOverby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TyOverby/subscriptions","organizations_url":"https://api.github.com/users/TyOverby/orgs","repos_url":"https://api.github.com/users/TyOverby/repos","events_url":"https://api.github.com/users/TyOverby/events{/privacy}","received_events_url":"https://api.github.com/users/TyOverby/received_events","type":"User","site_admin":false},"body":"Those directories are created on demand only if they are used, so they can't be properties.","created_at":"2016-04-06T23:10:44Z","updated_at":"2016-04-06T23:10:44Z","html_url":"https://github.com/dotnet/roslyn/pull/10236#discussion_r58797671","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/10236","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/58797671"},"html":{"href":"https://github.com/dotnet/roslyn/pull/10236#discussion_r58797671"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/10236"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/10236","id":64864249,"html_url":"https://github.com/dotnet/roslyn/pull/10236","diff_url":"https://github.com/dotnet/roslyn/pull/10236.diff","patch_url":"https://github.com/dotnet/roslyn/pull/10236.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/10236","number":10236,"state":"open","locked":false,"title":"Make tests their own first class objects","user":{"login":"TyOverby","id":573215,"avatar_url":"https://avatars.githubusercontent.com/u/573215?v=3","gravatar_id":"","url":"https://api.github.com/users/TyOverby","html_url":"https://github.com/TyOverby","followers_url":"https://api.github.com/users/TyOverby/followers","following_url":"https://api.github.com/users/TyOverby/following{/other_user}","gists_url":"https://api.github.com/users/TyOverby/gists{/gist_id}","starred_url":"https://api.github.com/users/TyOverby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TyOverby/subscriptions","organizations_url":"https://api.github.com/users/TyOverby/orgs","repos_url":"https://api.github.com/users/TyOverby/repos","events_url":"https://api.github.com/users/TyOverby/events{/privacy}","received_events_url":"https://api.github.com/users/TyOverby/received_events","type":"User","site_admin":false},"body":"This PR makes a few fundamental changes to the architecture of the runner and the tests.\r\n\r\nEach \"test\" is now an object of class PerfTest.  This object has methods such as `Setup` (for dowloading files), `Test` (for running the actual test), and a getter `Iterations` for controlling iteration count.\r\n\r\nImportantly (for me at least), tests can still be run manually just by invoking the test by hand!\r\n\r\nThis PR is out in order to get people up to date, but it isn't finished.  I haven't talked to @basoundr about integrating with the TraceManager yet (the refactor changed the order of operations that TraceManager expected, so I've commented out trace collecting).  This will obviously need to be implemented before a merge can occur.  I expect that @basoundr and I will pair program in order to finish the feature.","created_at":"2016-03-31T21:45:00Z","updated_at":"2016-04-06T23:10:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36133a7c7df034d08f002f530fafbf9695787975","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/10236/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/10236/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/10236/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/7cc6a50367c7485ebaafaaa214c3d2f8973a1eb8","head":{"label":"TyOverby:perftest-test-descriptor","ref":"perftest-test-descriptor","sha":"7cc6a50367c7485ebaafaaa214c3d2f8973a1eb8","user":{"login":"TyOverby","id":573215,"avatar_url":"https://avatars.githubusercontent.com/u/573215?v=3","gravatar_id":"","url":"https://api.github.com/users/TyOverby","html_url":"https://github.com/TyOverby","followers_url":"https://api.github.com/users/TyOverby/followers","following_url":"https://api.github.com/users/TyOverby/following{/other_user}","gists_url":"https://api.github.com/users/TyOverby/gists{/gist_id}","starred_url":"https://api.github.com/users/TyOverby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TyOverby/subscriptions","organizations_url":"https://api.github.com/users/TyOverby/orgs","repos_url":"https://api.github.com/users/TyOverby/repos","events_url":"https://api.github.com/users/TyOverby/events{/privacy}","received_events_url":"https://api.github.com/users/TyOverby/received_events","type":"User","site_admin":false},"repo":{"id":42192742,"name":"roslyn","full_name":"TyOverby/roslyn","owner":{"login":"TyOverby","id":573215,"avatar_url":"https://avatars.githubusercontent.com/u/573215?v=3","gravatar_id":"","url":"https://api.github.com/users/TyOverby","html_url":"https://github.com/TyOverby","followers_url":"https://api.github.com/users/TyOverby/followers","following_url":"https://api.github.com/users/TyOverby/following{/other_user}","gists_url":"https://api.github.com/users/TyOverby/gists{/gist_id}","starred_url":"https://api.github.com/users/TyOverby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TyOverby/subscriptions","organizations_url":"https://api.github.com/users/TyOverby/orgs","repos_url":"https://api.github.com/users/TyOverby/repos","events_url":"https://api.github.com/users/TyOverby/events{/privacy}","received_events_url":"https://api.github.com/users/TyOverby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TyOverby/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/TyOverby/roslyn","forks_url":"https://api.github.com/repos/TyOverby/roslyn/forks","keys_url":"https://api.github.com/repos/TyOverby/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TyOverby/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TyOverby/roslyn/teams","hooks_url":"https://api.github.com/repos/TyOverby/roslyn/hooks","issue_events_url":"https://api.github.com/repos/TyOverby/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/TyOverby/roslyn/events","assignees_url":"https://api.github.com/repos/TyOverby/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/TyOverby/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/TyOverby/roslyn/tags","blobs_url":"https://api.github.com/repos/TyOverby/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TyOverby/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TyOverby/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/TyOverby/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TyOverby/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/TyOverby/roslyn/languages","stargazers_url":"https://api.github.com/repos/TyOverby/roslyn/stargazers","contributors_url":"https://api.github.com/repos/TyOverby/roslyn/contributors","subscribers_url":"https://api.github.com/repos/TyOverby/roslyn/subscribers","subscription_url":"https://api.github.com/repos/TyOverby/roslyn/subscription","commits_url":"https://api.github.com/repos/TyOverby/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/TyOverby/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/TyOverby/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/TyOverby/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/TyOverby/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/TyOverby/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TyOverby/roslyn/merges","archive_url":"https://api.github.com/repos/TyOverby/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TyOverby/roslyn/downloads","issues_url":"https://api.github.com/repos/TyOverby/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/TyOverby/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/TyOverby/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/TyOverby/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TyOverby/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/TyOverby/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/TyOverby/roslyn/deployments","created_at":"2015-09-09T17:09:52Z","updated_at":"2016-01-22T19:21:23Z","pushed_at":"2016-04-06T18:03:41Z","git_url":"git://github.com/TyOverby/roslyn.git","ssh_url":"git@github.com:TyOverby/roslyn.git","clone_url":"https://github.com/TyOverby/roslyn.git","svn_url":"https://github.com/TyOverby/roslyn","homepage":"","size":150712,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"51edce0f2db81ea7f7b2e3b31b3d4e65c2c4f5cc","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-04-06T22:57:24Z","pushed_at":"2016-04-06T22:17:03Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":220730,"stargazers_count":4814,"watchers_count":4814,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1209,"mirror_url":null,"open_issues_count":2598,"forks":1209,"open_issues":2598,"watchers":4814,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/10236"},"html":{"href":"https://github.com/dotnet/roslyn/pull/10236"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/10236"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/10236/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/10236/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/10236/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/7cc6a50367c7485ebaafaaa214c3d2f8973a1eb8"}}}}