{"action":"opened","number":31,"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/31","id":82733226,"html_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/31","diff_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/31.diff","patch_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/31.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/31","number":31,"state":"open","locked":false,"title":"Parse suggestions from address book search result","user":{"login":"marcoconti83","id":620000,"avatar_url":"https://avatars.githubusercontent.com/u/620000?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoconti83","html_url":"https://github.com/marcoconti83","followers_url":"https://api.github.com/users/marcoconti83/followers","following_url":"https://api.github.com/users/marcoconti83/following{/other_user}","gists_url":"https://api.github.com/users/marcoconti83/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoconti83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoconti83/subscriptions","organizations_url":"https://api.github.com/users/marcoconti83/orgs","repos_url":"https://api.github.com/users/marcoconti83/repos","events_url":"https://api.github.com/users/marcoconti83/events{/privacy}","received_events_url":"https://api.github.com/users/marcoconti83/received_events","type":"User","site_admin":false},"body":"# Reason for this pull request\r\n\r\nThis restores the behaviour that was present at version: https://github.com/wireapp/wire-ios-sync-engine/blob/a84e152d82fde41e5a961eb2cf505c067150680c/Source/Synchronization/ZMAddressBookSync.m#L153 and then removed. Not that this is not the final implementation of the feature: that behaviour was not as designed, and will eventually be fixed (soonish).\r\n\r\n# Changes\r\n- Parsing response of address book search request\r\n\r\n# Known issues\r\n\r\nWith this pull request we have a similar issue that will be addressed later. The issue is that, since we search in batches, and take the response of a batch as the new list of suggestions, at any given time the suggestions will be the ones coming from the last batch upload. If the user has more contacts than the batch size (will upload more than one batch), the suggestions will change constantly after every batch upload. We could append the new results, instead of replacing them, but this will cause the list to grow potentially indefinitely, as we then never clean it.\r\n\r\nIt was decided to live with this limitation for now.","created_at":"2016-08-25T14:45:03Z","updated_at":"2016-08-25T14:45:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/31/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/31/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/31/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/e346758d9fbda35ee7219221aa78275e636bb37d","head":{"label":"wireapp:feature/ab-suggestions","ref":"feature/ab-suggestions","sha":"e346758d9fbda35ee7219221aa78275e636bb37d","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":53574338,"name":"wire-ios-sync-engine","full_name":"wireapp/wire-ios-sync-engine","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-sync-engine","description":"iOS synchronization library for Wire","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine","forks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/deployments","created_at":"2016-03-10T10:02:14Z","updated_at":"2016-08-10T08:32:02Z","pushed_at":"2016-08-25T14:45:03Z","git_url":"git://github.com/wireapp/wire-ios-sync-engine.git","ssh_url":"git@github.com:wireapp/wire-ios-sync-engine.git","clone_url":"https://github.com/wireapp/wire-ios-sync-engine.git","svn_url":"https://github.com/wireapp/wire-ios-sync-engine","homepage":"https://wire.com","size":5042,"stargazers_count":86,"watchers_count":86,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":86,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"c304f73594098163420156fada39d3d08a807971","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":53574338,"name":"wire-ios-sync-engine","full_name":"wireapp/wire-ios-sync-engine","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-sync-engine","description":"iOS synchronization library for Wire","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine","forks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/deployments","created_at":"2016-03-10T10:02:14Z","updated_at":"2016-08-10T08:32:02Z","pushed_at":"2016-08-25T14:45:03Z","git_url":"git://github.com/wireapp/wire-ios-sync-engine.git","ssh_url":"git@github.com:wireapp/wire-ios-sync-engine.git","clone_url":"https://github.com/wireapp/wire-ios-sync-engine.git","svn_url":"https://github.com/wireapp/wire-ios-sync-engine","homepage":"https://wire.com","size":5042,"stargazers_count":86,"watchers_count":86,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":86,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/31"},"html":{"href":"https://github.com/wireapp/wire-ios-sync-engine/pull/31"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/31"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/e346758d9fbda35ee7219221aa78275e636bb37d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":112,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"marcoconti83"}}