{"action":"closed","number":4321,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4321","id":88521945,"html_url":"https://github.com/dolphin-emu/dolphin/pull/4321","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4321.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4321.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4321","number":4321,"state":"closed","locked":false,"title":"Remove Frameskip","user":{"login":"Helios747","id":6785841,"avatar_url":"https://avatars.githubusercontent.com/u/6785841?v=3","gravatar_id":"","url":"https://api.github.com/users/Helios747","html_url":"https://github.com/Helios747","followers_url":"https://api.github.com/users/Helios747/followers","following_url":"https://api.github.com/users/Helios747/following{/other_user}","gists_url":"https://api.github.com/users/Helios747/gists{/gist_id}","starred_url":"https://api.github.com/users/Helios747/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Helios747/subscriptions","organizations_url":"https://api.github.com/users/Helios747/orgs","repos_url":"https://api.github.com/users/Helios747/repos","events_url":"https://api.github.com/users/Helios747/events{/privacy}","received_events_url":"https://api.github.com/users/Helios747/received_events","type":"User","site_admin":false},"body":"Frameskip is really broken in Dolphin and graphics / JIT devs say fixing it would be a nightmare. So I'm removing it to protect the user. We don't even save the setting to disk anyways.\r\n\r\nIt's broken in that it's very inconsistent in what it even does to games. Sometimes it does nothing at all. Sometimes it just renders black frames in place of the frames it drops. Sometimes it entirely breaks the game. JMC says it doesn't often do what it's supposed to.\r\n\r\nCan somebody who knows frame advance code look over this to make sure I didn't delete something important, whoever did the frame advance stuff named some functions and configmanager stuff \"Frameskip\" for some reason.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/4321)\n<!-- Reviewable:end -->\n","created_at":"2016-10-07T23:17:07Z","updated_at":"2016-10-08T00:09:37Z","closed_at":"2016-10-08T00:09:37Z","merged_at":null,"merge_commit_sha":"50260247707c9c5291d1e7fbf8625db2d22b8a4e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4321/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4321/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4321/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/a2e5d0f8664acfeb2335c25282b18cf263b067c8","head":{"label":"Helios747:I_hate_features","ref":"I_hate_features","sha":"a2e5d0f8664acfeb2335c25282b18cf263b067c8","user":{"login":"Helios747","id":6785841,"avatar_url":"https://avatars.githubusercontent.com/u/6785841?v=3","gravatar_id":"","url":"https://api.github.com/users/Helios747","html_url":"https://github.com/Helios747","followers_url":"https://api.github.com/users/Helios747/followers","following_url":"https://api.github.com/users/Helios747/following{/other_user}","gists_url":"https://api.github.com/users/Helios747/gists{/gist_id}","starred_url":"https://api.github.com/users/Helios747/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Helios747/subscriptions","organizations_url":"https://api.github.com/users/Helios747/orgs","repos_url":"https://api.github.com/users/Helios747/repos","events_url":"https://api.github.com/users/Helios747/events{/privacy}","received_events_url":"https://api.github.com/users/Helios747/received_events","type":"User","site_admin":false},"repo":{"id":36282779,"name":"dolphin","full_name":"Helios747/dolphin","owner":{"login":"Helios747","id":6785841,"avatar_url":"https://avatars.githubusercontent.com/u/6785841?v=3","gravatar_id":"","url":"https://api.github.com/users/Helios747","html_url":"https://github.com/Helios747","followers_url":"https://api.github.com/users/Helios747/followers","following_url":"https://api.github.com/users/Helios747/following{/other_user}","gists_url":"https://api.github.com/users/Helios747/gists{/gist_id}","starred_url":"https://api.github.com/users/Helios747/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Helios747/subscriptions","organizations_url":"https://api.github.com/users/Helios747/orgs","repos_url":"https://api.github.com/users/Helios747/repos","events_url":"https://api.github.com/users/Helios747/events{/privacy}","received_events_url":"https://api.github.com/users/Helios747/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Helios747/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/Helios747/dolphin","forks_url":"https://api.github.com/repos/Helios747/dolphin/forks","keys_url":"https://api.github.com/repos/Helios747/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Helios747/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Helios747/dolphin/teams","hooks_url":"https://api.github.com/repos/Helios747/dolphin/hooks","issue_events_url":"https://api.github.com/repos/Helios747/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/Helios747/dolphin/events","assignees_url":"https://api.github.com/repos/Helios747/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/Helios747/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/Helios747/dolphin/tags","blobs_url":"https://api.github.com/repos/Helios747/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Helios747/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Helios747/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Helios747/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Helios747/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/Helios747/dolphin/languages","stargazers_url":"https://api.github.com/repos/Helios747/dolphin/stargazers","contributors_url":"https://api.github.com/repos/Helios747/dolphin/contributors","subscribers_url":"https://api.github.com/repos/Helios747/dolphin/subscribers","subscription_url":"https://api.github.com/repos/Helios747/dolphin/subscription","commits_url":"https://api.github.com/repos/Helios747/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Helios747/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Helios747/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Helios747/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Helios747/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/Helios747/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Helios747/dolphin/merges","archive_url":"https://api.github.com/repos/Helios747/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Helios747/dolphin/downloads","issues_url":"https://api.github.com/repos/Helios747/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/Helios747/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/Helios747/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/Helios747/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Helios747/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/Helios747/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/Helios747/dolphin/deployments","created_at":"2015-05-26T08:34:19Z","updated_at":"2016-02-20T04:16:54Z","pushed_at":"2016-10-08T00:02:15Z","git_url":"git://github.com/Helios747/dolphin.git","ssh_url":"git@github.com:Helios747/dolphin.git","clone_url":"https://github.com/Helios747/dolphin.git","svn_url":"https://github.com/Helios747/dolphin","homepage":"https://dolphin-emu.org/","size":264179,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"4ba1100f3191c80e58f89c78d1e8965e126da8f3","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2016-10-07T19:10:13Z","pushed_at":"2016-10-08T00:02:23Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":329758,"stargazers_count":2765,"watchers_count":2765,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":740,"mirror_url":null,"open_issues_count":105,"forks":740,"open_issues":105,"watchers":2765,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4321"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/4321"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4321"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4321/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4321/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4321/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/a2e5d0f8664acfeb2335c25282b18cf263b067c8"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":105,"deletions":217,"changed_files":18}}
{"actor":{"display_login":"Helios747"}}