{"action":"created","comment":{"url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/comments/57518090","id":57518090,"diff_hunk":"@@ -17,10 +17,312 @@\n \n package pl.project13.maven.git.log;\n \n+/**\n+ * Interface for logging in git-commit-id plugin. Isolates logging to enable future possible code reuse in other tools.\n+ * Adds verbosity flag. Given SLF4J popularity and recent internal Maven adoption, follows SLF4J interfaces.\n+ */\n public interface LoggerBridge {\n-  void log(Object... parts);\n-  void error(Object... parts);\n-  void warn(Object... parts);\n-  void debug(Object... parts);\n-  void setVerbose(boolean verbose);\n-}\n+\n+    /**\n+     * Returns true if plugin does verbose logging.\n+     *\n+     * @return true if plugin does verbose logging\n+     */\n+    boolean isVerbose();\n+\n+    /**\n+     * Sets plugin to verbose mode.\n+     *\n+     * @param verbose plugin verbosity flag\n+     */\n+    void setVerbose(boolean verbose);\n+\n+/*\n+    The following borrowed from SLF4J Logger.java","path":"src/main/java/pl/project13/maven/git/log/LoggerBridge.java","position":31,"original_position":31,"commit_id":"2e9482bd74fde9144c67c85680581c0b3844a130","original_commit_id":"2e9482bd74fde9144c67c85680581c0b3844a130","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"body":"I had to check license compatibility... seems we're good though - MIT","created_at":"2016-03-26T19:16:32Z","updated_at":"2016-03-26T19:16:32Z","html_url":"https://github.com/ktoso/maven-git-commit-id-plugin/pull/233#discussion_r57518090","pull_request_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/233","_links":{"self":{"href":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/comments/57518090"},"html":{"href":"https://github.com/ktoso/maven-git-commit-id-plugin/pull/233#discussion_r57518090"},"pull_request":{"href":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/233"}}},"pull_request":{"url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/233","id":54898342,"html_url":"https://github.com/ktoso/maven-git-commit-id-plugin/pull/233","diff_url":"https://github.com/ktoso/maven-git-commit-id-plugin/pull/233.diff","patch_url":"https://github.com/ktoso/maven-git-commit-id-plugin/pull/233.patch","issue_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/233","number":233,"state":"closed","locked":false,"title":"Simplify logging","user":{"login":"autayeu","id":495207,"avatar_url":"https://avatars.githubusercontent.com/u/495207?v=3","gravatar_id":"","url":"https://api.github.com/users/autayeu","html_url":"https://github.com/autayeu","followers_url":"https://api.github.com/users/autayeu/followers","following_url":"https://api.github.com/users/autayeu/following{/other_user}","gists_url":"https://api.github.com/users/autayeu/gists{/gist_id}","starred_url":"https://api.github.com/users/autayeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autayeu/subscriptions","organizations_url":"https://api.github.com/users/autayeu/orgs","repos_url":"https://api.github.com/users/autayeu/repos","events_url":"https://api.github.com/users/autayeu/events{/privacy}","received_events_url":"https://api.github.com/users/autayeu/received_events","type":"User","site_admin":false},"body":"This pull contains the following changes (in addition to logging simplification itself)\r\n* logging is now standard Maven (no separation of logs to stderr, no shading)\r\n* docs (formatting mostly) improved\r\n* various typos fixed\r\n* updated dependencies (project and plugins, relevant for #216)\r\n* various clean-ups (diamonds, Java 7, try with resources, etc)\r\n* some clean-ups of testing rigs in production code\r\n* thread safety violation via static variable is fixed\r\n","created_at":"2016-01-01T23:48:23Z","updated_at":"2016-03-26T19:16:32Z","closed_at":"2016-03-12T16:17:58Z","merged_at":"2016-03-12T16:17:58Z","merge_commit_sha":"f6eec5645ef86f910d274b4b16f10834e23a71e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/233/commits","review_comments_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/233/comments","review_comment_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/233/comments","statuses_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/statuses/2e9482bd74fde9144c67c85680581c0b3844a130","head":{"label":"autayeu:simplify-logging","ref":"simplify-logging","sha":"2e9482bd74fde9144c67c85680581c0b3844a130","user":{"login":"autayeu","id":495207,"avatar_url":"https://avatars.githubusercontent.com/u/495207?v=3","gravatar_id":"","url":"https://api.github.com/users/autayeu","html_url":"https://github.com/autayeu","followers_url":"https://api.github.com/users/autayeu/followers","following_url":"https://api.github.com/users/autayeu/following{/other_user}","gists_url":"https://api.github.com/users/autayeu/gists{/gist_id}","starred_url":"https://api.github.com/users/autayeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autayeu/subscriptions","organizations_url":"https://api.github.com/users/autayeu/orgs","repos_url":"https://api.github.com/users/autayeu/repos","events_url":"https://api.github.com/users/autayeu/events{/privacy}","received_events_url":"https://api.github.com/users/autayeu/received_events","type":"User","site_admin":false},"repo":{"id":48708943,"name":"maven-git-commit-id-plugin","full_name":"autayeu/maven-git-commit-id-plugin","owner":{"login":"autayeu","id":495207,"avatar_url":"https://avatars.githubusercontent.com/u/495207?v=3","gravatar_id":"","url":"https://api.github.com/users/autayeu","html_url":"https://github.com/autayeu","followers_url":"https://api.github.com/users/autayeu/followers","following_url":"https://api.github.com/users/autayeu/following{/other_user}","gists_url":"https://api.github.com/users/autayeu/gists{/gist_id}","starred_url":"https://api.github.com/users/autayeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autayeu/subscriptions","organizations_url":"https://api.github.com/users/autayeu/orgs","repos_url":"https://api.github.com/users/autayeu/repos","events_url":"https://api.github.com/users/autayeu/events{/privacy}","received_events_url":"https://api.github.com/users/autayeu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/autayeu/maven-git-commit-id-plugin","description":"Maven plugin which includes build-time git repository information into an POJO / *.properties). Make your apps tell you which version exactly they were built from! Priceless in large distributed deployments... :-)","fork":true,"url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin","forks_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/forks","keys_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/teams","hooks_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/hooks","issue_events_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/events","assignees_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/tags","blobs_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/languages","stargazers_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/stargazers","contributors_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/contributors","subscribers_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/subscribers","subscription_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/subscription","commits_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/merges","archive_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/downloads","issues_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/labels{/name}","releases_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/autayeu/maven-git-commit-id-plugin/deployments","created_at":"2015-12-28T19:31:08Z","updated_at":"2015-12-28T19:31:10Z","pushed_at":"2016-01-03T16:55:34Z","git_url":"git://github.com/autayeu/maven-git-commit-id-plugin.git","ssh_url":"git@github.com:autayeu/maven-git-commit-id-plugin.git","clone_url":"https://github.com/autayeu/maven-git-commit-id-plugin.git","svn_url":"https://github.com/autayeu/maven-git-commit-id-plugin","homepage":"http://project13.pl","size":2361,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ktoso:master","ref":"master","sha":"c9dafa81008e262a02d29025bfa49ec0bb95be64","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"repo":{"id":1361792,"name":"maven-git-commit-id-plugin","full_name":"ktoso/maven-git-commit-id-plugin","owner":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktoso/maven-git-commit-id-plugin","description":"Maven plugin which includes build-time git repository information into an POJO / *.properties). Make your apps tell you which version exactly they were built from! Priceless in large distributed deployments... :-)","fork":false,"url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin","forks_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/forks","keys_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/teams","hooks_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/hooks","issue_events_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/events","assignees_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/tags","blobs_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/languages","stargazers_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/stargazers","contributors_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/contributors","subscribers_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/subscribers","subscription_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/subscription","commits_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/merges","archive_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/downloads","issues_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/labels{/name}","releases_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/deployments","created_at":"2011-02-13T13:55:14Z","updated_at":"2016-03-25T06:47:44Z","pushed_at":"2016-03-26T18:38:47Z","git_url":"git://github.com/ktoso/maven-git-commit-id-plugin.git","ssh_url":"git@github.com:ktoso/maven-git-commit-id-plugin.git","clone_url":"https://github.com/ktoso/maven-git-commit-id-plugin.git","svn_url":"https://github.com/ktoso/maven-git-commit-id-plugin","homepage":"http://project13.pl","size":2802,"stargazers_count":333,"watchers_count":333,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":85,"mirror_url":null,"open_issues_count":29,"forks":85,"open_issues":29,"watchers":333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/233"},"html":{"href":"https://github.com/ktoso/maven-git-commit-id-plugin/pull/233"},"issue":{"href":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/233"},"comments":{"href":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/statuses/2e9482bd74fde9144c67c85680581c0b3844a130"}}}}