{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/529","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/529/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/529/comments","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/529/events","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/529","id":127347539,"number":529,"title":"Added Tax Logic for Hope Credit","user":{"login":"GoFroggyRun","id":13324931,"avatar_url":"https://avatars.githubusercontent.com/u/13324931?v=3","gravatar_id":"","url":"https://api.github.com/users/GoFroggyRun","html_url":"https://github.com/GoFroggyRun","followers_url":"https://api.github.com/users/GoFroggyRun/followers","following_url":"https://api.github.com/users/GoFroggyRun/following{/other_user}","gists_url":"https://api.github.com/users/GoFroggyRun/gists{/gist_id}","starred_url":"https://api.github.com/users/GoFroggyRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoFroggyRun/subscriptions","organizations_url":"https://api.github.com/users/GoFroggyRun/orgs","repos_url":"https://api.github.com/users/GoFroggyRun/repos","events_url":"https://api.github.com/users/GoFroggyRun/events{/privacy}","received_events_url":"https://api.github.com/users/GoFroggyRun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-01-19T02:00:31Z","updated_at":"2016-01-26T18:58:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/529","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/529","diff_url":"https://github.com/open-source-economics/Tax-Calculator/pull/529.diff","patch_url":"https://github.com/open-source-economics/Tax-Calculator/pull/529.patch"},"body":"Per requests from @MattHJensen, in order to analyze the reform that \"make American Opportunity tax credit for higher education permanent”, the calculation for Hope Credit was incorporated.\r\n\r\nFunction `HopeCredit` was written using @feenberg's SAS calculator, which has the tax logic for Hope Credit, and the actual 2009 [Form 8863](http://www.unclefed.com/IRS-Forms/2009/f8863.pdf) as references. Also, the function only deals with the latest tax logic for Hope Credit, that is from year 2005 to 2009. (I assume this is how the Hope Credit to be retained after 2017)\r\n\r\nWhen fed with proper inputs, the function should produce desire results. Since the function `HopeCredit` is called nowhere in `calculate.py`, `py.test` might not be able to detect potential errors. Thus, `py.test` was also executed when `HopeCredit` is called in `calculate.py`, in `self.calc_one_year()`.\r\n\r\n@MattHJensen @feenberg @Amy-Xu Any comments, concerns or remarks would be appreciated."},"comment":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments/175178010","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/529#issuecomment-175178010","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/529","id":175178010,"user":{"login":"MattHJensen","id":8301092,"avatar_url":"https://avatars.githubusercontent.com/u/8301092?v=3","gravatar_id":"","url":"https://api.github.com/users/MattHJensen","html_url":"https://github.com/MattHJensen","followers_url":"https://api.github.com/users/MattHJensen/followers","following_url":"https://api.github.com/users/MattHJensen/following{/other_user}","gists_url":"https://api.github.com/users/MattHJensen/gists{/gist_id}","starred_url":"https://api.github.com/users/MattHJensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattHJensen/subscriptions","organizations_url":"https://api.github.com/users/MattHJensen/orgs","repos_url":"https://api.github.com/users/MattHJensen/repos","events_url":"https://api.github.com/users/MattHJensen/events{/privacy}","received_events_url":"https://api.github.com/users/MattHJensen/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T18:58:03Z","updated_at":"2016-01-26T18:58:03Z","body":"Turns out the Dec 2015 budget deal extended the AOC beyond 2017, and so we don't actually need the hope credit anymore. @GoFroggyRun, could you confirm, and then we can close this PR?\r\n\r\nhttps://www.whitehouse.gov/blog/2015/12/22/tax-agreement-makes-permanent-expansions-important-tax-credits-working-families"}}