{"action":"created","issue":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/6991","repository_url":"https://api.github.com/repos/fastlane/fastlane","labels_url":"https://api.github.com/repos/fastlane/fastlane/issues/6991/labels{/name}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/6991/comments","events_url":"https://api.github.com/repos/fastlane/fastlane/issues/6991/events","html_url":"https://github.com/fastlane/fastlane/pull/6991","id":189187048,"number":6991,"title":"Remove Shenzhen dependency","user":{"login":"sebastianludwig","id":1715010,"avatar_url":"https://avatars.githubusercontent.com/u/1715010?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianludwig","html_url":"https://github.com/sebastianludwig","followers_url":"https://api.github.com/users/sebastianludwig/followers","following_url":"https://api.github.com/users/sebastianludwig/following{/other_user}","gists_url":"https://api.github.com/users/sebastianludwig/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianludwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianludwig/subscriptions","organizations_url":"https://api.github.com/users/sebastianludwig/orgs","repos_url":"https://api.github.com/users/sebastianludwig/repos","events_url":"https://api.github.com/users/sebastianludwig/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianludwig/received_events","type":"User","site_admin":false},"labels":[{"id":338233566,"url":"https://api.github.com/repos/fastlane/fastlane/labels/fastlane","name":"fastlane","color":"CCCCCC","default":false}],"state":"open","locked":false,"assignee":{"login":"milch","id":279407,"avatar_url":"https://avatars.githubusercontent.com/u/279407?v=3","gravatar_id":"","url":"https://api.github.com/users/milch","html_url":"https://github.com/milch","followers_url":"https://api.github.com/users/milch/followers","following_url":"https://api.github.com/users/milch/following{/other_user}","gists_url":"https://api.github.com/users/milch/gists{/gist_id}","starred_url":"https://api.github.com/users/milch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milch/subscriptions","organizations_url":"https://api.github.com/users/milch/orgs","repos_url":"https://api.github.com/users/milch/repos","events_url":"https://api.github.com/users/milch/events{/privacy}","received_events_url":"https://api.github.com/users/milch/received_events","type":"User","site_admin":false},"assignees":[{"login":"milch","id":279407,"avatar_url":"https://avatars.githubusercontent.com/u/279407?v=3","gravatar_id":"","url":"https://api.github.com/users/milch","html_url":"https://github.com/milch","followers_url":"https://api.github.com/users/milch/followers","following_url":"https://api.github.com/users/milch/following{/other_user}","gists_url":"https://api.github.com/users/milch/gists{/gist_id}","starred_url":"https://api.github.com/users/milch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milch/subscriptions","organizations_url":"https://api.github.com/users/milch/orgs","repos_url":"https://api.github.com/users/milch/repos","events_url":"https://api.github.com/users/milch/events{/privacy}","received_events_url":"https://api.github.com/users/milch/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2016-11-14T18:23:06Z","updated_at":"2016-12-09T19:43:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/6991","html_url":"https://github.com/fastlane/fastlane/pull/6991","diff_url":"https://github.com/fastlane/fastlane/pull/6991.diff","patch_url":"https://github.com/fastlane/fastlane/pull/6991.patch"},"body":"Thanks for contributing to _fastlane_! Before you submit your pull request, please make sure to check the following boxes:\r\n\r\n- [x] Run `bundle exec rspec` from the subdirectory of each tool you modified. Alternatively, run `rake test_all` from the root directory.\r\n- [x] Run `bundle exec rubocop -a` to ensure the code style is valid\r\n- [x] Read the [Contribution Guidelines](https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)\r\n- [x] We currently don't accept new actions, please publish a plugin instead, more information in [Plugins.md](https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Plugins.md)\r\n\r\nThis PR is based on the discussion in fastlane/shenzhen#11 and aims to remove the `Shenzhen` dependency.\r\n\r\nThe actions were pretty straight forward, all unit tests are green. However I haven't set up test accounts where possible yet to test if the actual upload still works as expected.\r\n\r\nThe `ipa` action is more interesting. It's deprecated at least since March. It uses [a command](https://github.com/fastlane/shenzhen/blob/master/lib/shenzhen/xcodebuild.rb#L65) which [hangs on Xcode 8](https://forums.developer.apple.com/thread/50372). Not sure if this affects everybody but the `ipa` action is currently definitely broken. I only did a quick search, but didn't find any open issues concerning the ipa action. \r\n\r\nThis boils down to: How long do you wish to keep the deprecated action around and put more effort into maintaining it? With gym as a perfect(?) successor, I'd suggest to get rid of it. If you agree, I'd be happy to go forward with this PR."},"comment":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/comments/266104172","html_url":"https://github.com/fastlane/fastlane/pull/6991#issuecomment-266104172","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/6991","id":266104172,"user":{"login":"milch","id":279407,"avatar_url":"https://avatars.githubusercontent.com/u/279407?v=3","gravatar_id":"","url":"https://api.github.com/users/milch","html_url":"https://github.com/milch","followers_url":"https://api.github.com/users/milch/followers","following_url":"https://api.github.com/users/milch/following{/other_user}","gists_url":"https://api.github.com/users/milch/gists{/gist_id}","starred_url":"https://api.github.com/users/milch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milch/subscriptions","organizations_url":"https://api.github.com/users/milch/orgs","repos_url":"https://api.github.com/users/milch/repos","events_url":"https://api.github.com/users/milch/events{/privacy}","received_events_url":"https://api.github.com/users/milch/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T19:43:09Z","updated_at":"2016-12-09T19:43:09Z","body":"@sebastianludwig Thanks for your patience! I just finished my testing and everything seemed to work great. I took the liberty of rebasing master for you so we can get this merged ASAP. "}}
{"actor":{"display_login":"milch"}}