{"action":"created","issue":{"url":"https://api.github.com/repos/ocombe/ng2-translate/issues/301","repository_url":"https://api.github.com/repos/ocombe/ng2-translate","labels_url":"https://api.github.com/repos/ocombe/ng2-translate/issues/301/labels{/name}","comments_url":"https://api.github.com/repos/ocombe/ng2-translate/issues/301/comments","events_url":"https://api.github.com/repos/ocombe/ng2-translate/issues/301/events","html_url":"https://github.com/ocombe/ng2-translate/issues/301","id":186997218,"number":301,"title":"Release 3.2.0 changes the API, should've been 4.0.0","user":{"login":"eemeli","id":617000,"avatar_url":"https://avatars.githubusercontent.com/u/617000?v=3","gravatar_id":"","url":"https://api.github.com/users/eemeli","html_url":"https://github.com/eemeli","followers_url":"https://api.github.com/users/eemeli/followers","following_url":"https://api.github.com/users/eemeli/following{/other_user}","gists_url":"https://api.github.com/users/eemeli/gists{/gist_id}","starred_url":"https://api.github.com/users/eemeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eemeli/subscriptions","organizations_url":"https://api.github.com/users/eemeli/orgs","repos_url":"https://api.github.com/users/eemeli/repos","events_url":"https://api.github.com/users/eemeli/events{/privacy}","received_events_url":"https://api.github.com/users/eemeli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-03T08:06:04Z","updated_at":"2016-11-03T08:14:11Z","closed_at":null,"body":"**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x] bug report => check the FAQ and search github for a similar issue or PR before submitting\r\n[ ] support request => check the FAQ and search github for a similar issue before submitting\r\n[ ] feature request\r\n```\r\n\r\n**Current behavior**\r\nRelease 3.2.0 and in particular commit 481365df changed the signature of `MissingTranslationHandler#handle()`, an exported part of the API. Previously it expected a single `key: string` parameter, now it wants a `params: MissingTranslationHandlerParams`.\r\n\r\n**Expected/desired behavior**\r\nAccording to semver, non-backward compatible changes in the API should increment the major version. This did not happen here, and as dependencies like `^3.1.3` match the `3.2.0` release, having followed the [instructions](../#how-to-handle-missing-translations) is now leading to builds breaking.\r\n\r\n**Please tell us about your environment:**\r\n\r\n* **ng2-translate version:** 3.2.0\r\n* **Angular version:** 2.1.2\r\n* **Browser:** all\r\n* **Language:** all"},"comment":{"url":"https://api.github.com/repos/ocombe/ng2-translate/issues/comments/258083501","html_url":"https://github.com/ocombe/ng2-translate/issues/301#issuecomment-258083501","issue_url":"https://api.github.com/repos/ocombe/ng2-translate/issues/301","id":258083501,"user":{"login":"SamVerschueren","id":1913805,"avatar_url":"https://avatars.githubusercontent.com/u/1913805?v=3","gravatar_id":"","url":"https://api.github.com/users/SamVerschueren","html_url":"https://github.com/SamVerschueren","followers_url":"https://api.github.com/users/SamVerschueren/followers","following_url":"https://api.github.com/users/SamVerschueren/following{/other_user}","gists_url":"https://api.github.com/users/SamVerschueren/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVerschueren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVerschueren/subscriptions","organizations_url":"https://api.github.com/users/SamVerschueren/orgs","repos_url":"https://api.github.com/users/SamVerschueren/repos","events_url":"https://api.github.com/users/SamVerschueren/events{/privacy}","received_events_url":"https://api.github.com/users/SamVerschueren/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T08:14:11Z","updated_at":"2016-11-03T08:14:11Z","body":"@ocombe I don't believe that's possible. I think the only way of doing that is checking out the commit right before the breaking change and release a new patch release.\r\n\r\nAlso, if we're releasing a new major, we might consider removing the `ng2-translate.ts` file in the root of the project. But I leave that to you to decide :)."}}
{"actor":{"display_login":"SamVerschueren"}}