{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/phovea/phovea_core/pulls/12","id":92807028,"html_url":"https://github.com/phovea/phovea_core/pull/12","diff_url":"https://github.com/phovea/phovea_core/pull/12.diff","patch_url":"https://github.com/phovea/phovea_core/pull/12.patch","issue_url":"https://api.github.com/repos/phovea/phovea_core/issues/12","number":12,"state":"closed","locked":false,"title":"Mccalluc/port tests","user":{"login":"mccalluc","id":730388,"avatar_url":"https://avatars.githubusercontent.com/u/730388?v=3","gravatar_id":"","url":"https://api.github.com/users/mccalluc","html_url":"https://github.com/mccalluc","followers_url":"https://api.github.com/users/mccalluc/followers","following_url":"https://api.github.com/users/mccalluc/following{/other_user}","gists_url":"https://api.github.com/users/mccalluc/gists{/gist_id}","starred_url":"https://api.github.com/users/mccalluc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccalluc/subscriptions","organizations_url":"https://api.github.com/users/mccalluc/orgs","repos_url":"https://api.github.com/users/mccalluc/repos","events_url":"https://api.github.com/users/mccalluc/events{/privacy}","received_events_url":"https://api.github.com/users/mccalluc/received_events","type":"User","site_admin":false},"body":"@sgratzl : I would appreciate your feedback here. I've brought over the qunit tests from the other branch, and translating them one by one.\r\n- Would you object to bringing over the Object.keys tests? As I think about it now, they work for me as something like a table of contents at the top of the file, and then down below I can look at the behavior of individual methods.\r\n- Would it be ok merge back into master incrementally? Beyond a green checkmark, are there things that matter to you here?\r\n- Some of the tests have failed, for reasons I've had trouble diagnosing: for instance:\r\n```\r\nChrome 54.0.2840 (Mac OS X 10.11.6) Circle corner encountered a declaration exception FAILED\r\n\tRangeError: Maximum call stack size exceeded\r\n\t    at vec (tests.webpack.js:2576:13)\r\n\t    at vec (tests.webpack.js:2578:12)\r\n\t    at vec (tests.webpack.js:2578:12)\r\n\t    at vec (tests.webpack.js:2578:12)\r\n\t    at vec (tests.webpack.js:2578:12)\r\n```\r\n... except that tests.webpack.js looks like this to me:\r\n```\r\n//build registry\r\nrequire('./phovea_registry.js');\r\n/**\r\n * find all tests in the spec directory and load them\r\n */\r\nvar context = require.context('./tests', true, /\\.test\\.ts$/); //make sure you have your directory and regex test set correctly!\r\ncontext.keys().forEach(context);\r\n```\r\nHow would I find line 2578?\r\n\r\nMore broadly, having the tests in TS works, but there are issues which we should acknowledge and try to mitigate.\r\n- Because of the compilation + webpack + tslint time, the cycle between writing a test, seeing a failure, and correcting it is much slower now than when I was working in JS.\r\n- I need to figure out how to get debugging to work.\r\n- I need to figure out how to get DOM fixtures to work.\r\n- Karma is a test runner... I think I could still be using QUnit syntax (`npm install -g karma-qunit`): Is this something folks have strong opinions about?","created_at":"2016-11-08T16:05:28Z","updated_at":"2016-11-21T14:33:02Z","closed_at":"2016-11-21T14:33:01Z","merged_at":"2016-11-21T14:33:01Z","merge_commit_sha":"971f133ff64e40e0d994c1606a3e839827e7b39f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/phovea/phovea_core/pulls/12/commits","review_comments_url":"https://api.github.com/repos/phovea/phovea_core/pulls/12/comments","review_comment_url":"https://api.github.com/repos/phovea/phovea_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phovea/phovea_core/issues/12/comments","statuses_url":"https://api.github.com/repos/phovea/phovea_core/statuses/f05ed0c61fafced09ec1687e214f8461dc17d47d","head":{"label":"phovea:mccalluc/port-tests","ref":"mccalluc/port-tests","sha":"f05ed0c61fafced09ec1687e214f8461dc17d47d","user":{"login":"phovea","id":21689003,"avatar_url":"https://avatars.githubusercontent.com/u/21689003?v=3","gravatar_id":"","url":"https://api.github.com/users/phovea","html_url":"https://github.com/phovea","followers_url":"https://api.github.com/users/phovea/followers","following_url":"https://api.github.com/users/phovea/following{/other_user}","gists_url":"https://api.github.com/users/phovea/gists{/gist_id}","starred_url":"https://api.github.com/users/phovea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phovea/subscriptions","organizations_url":"https://api.github.com/users/phovea/orgs","repos_url":"https://api.github.com/users/phovea/repos","events_url":"https://api.github.com/users/phovea/events{/privacy}","received_events_url":"https://api.github.com/users/phovea/received_events","type":"Organization","site_admin":false},"repo":{"id":39556332,"name":"phovea_core","full_name":"phovea/phovea_core","owner":{"login":"phovea","id":21689003,"avatar_url":"https://avatars.githubusercontent.com/u/21689003?v=3","gravatar_id":"","url":"https://api.github.com/users/phovea","html_url":"https://github.com/phovea","followers_url":"https://api.github.com/users/phovea/followers","following_url":"https://api.github.com/users/phovea/following{/other_user}","gists_url":"https://api.github.com/users/phovea/gists{/gist_id}","starred_url":"https://api.github.com/users/phovea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phovea/subscriptions","organizations_url":"https://api.github.com/users/phovea/orgs","repos_url":"https://api.github.com/users/phovea/repos","events_url":"https://api.github.com/users/phovea/events{/privacy}","received_events_url":"https://api.github.com/users/phovea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phovea/phovea_core","description":"Phovea core includes the plugin registry, data definition (+ common types: tables, matrix, vector, stratification), ajax, selections","fork":false,"url":"https://api.github.com/repos/phovea/phovea_core","forks_url":"https://api.github.com/repos/phovea/phovea_core/forks","keys_url":"https://api.github.com/repos/phovea/phovea_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phovea/phovea_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phovea/phovea_core/teams","hooks_url":"https://api.github.com/repos/phovea/phovea_core/hooks","issue_events_url":"https://api.github.com/repos/phovea/phovea_core/issues/events{/number}","events_url":"https://api.github.com/repos/phovea/phovea_core/events","assignees_url":"https://api.github.com/repos/phovea/phovea_core/assignees{/user}","branches_url":"https://api.github.com/repos/phovea/phovea_core/branches{/branch}","tags_url":"https://api.github.com/repos/phovea/phovea_core/tags","blobs_url":"https://api.github.com/repos/phovea/phovea_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phovea/phovea_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phovea/phovea_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/phovea/phovea_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phovea/phovea_core/statuses/{sha}","languages_url":"https://api.github.com/repos/phovea/phovea_core/languages","stargazers_url":"https://api.github.com/repos/phovea/phovea_core/stargazers","contributors_url":"https://api.github.com/repos/phovea/phovea_core/contributors","subscribers_url":"https://api.github.com/repos/phovea/phovea_core/subscribers","subscription_url":"https://api.github.com/repos/phovea/phovea_core/subscription","commits_url":"https://api.github.com/repos/phovea/phovea_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/phovea/phovea_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/phovea/phovea_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/phovea/phovea_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/phovea/phovea_core/contents/{+path}","compare_url":"https://api.github.com/repos/phovea/phovea_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phovea/phovea_core/merges","archive_url":"https://api.github.com/repos/phovea/phovea_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phovea/phovea_core/downloads","issues_url":"https://api.github.com/repos/phovea/phovea_core/issues{/number}","pulls_url":"https://api.github.com/repos/phovea/phovea_core/pulls{/number}","milestones_url":"https://api.github.com/repos/phovea/phovea_core/milestones{/number}","notifications_url":"https://api.github.com/repos/phovea/phovea_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phovea/phovea_core/labels{/name}","releases_url":"https://api.github.com/repos/phovea/phovea_core/releases{/id}","deployments_url":"https://api.github.com/repos/phovea/phovea_core/deployments","created_at":"2015-07-23T08:49:28Z","updated_at":"2016-11-06T09:27:39Z","pushed_at":"2016-11-21T14:33:02Z","git_url":"git://github.com/phovea/phovea_core.git","ssh_url":"git@github.com:phovea/phovea_core.git","clone_url":"https://github.com/phovea/phovea_core.git","svn_url":"https://github.com/phovea/phovea_core","homepage":"http://phovea.caleydo.org/","size":414,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":4,"default_branch":"master"}},"base":{"label":"phovea:master","ref":"master","sha":"613643ab5fda7e6af38668b19f2e5c8d6372fd92","user":{"login":"phovea","id":21689003,"avatar_url":"https://avatars.githubusercontent.com/u/21689003?v=3","gravatar_id":"","url":"https://api.github.com/users/phovea","html_url":"https://github.com/phovea","followers_url":"https://api.github.com/users/phovea/followers","following_url":"https://api.github.com/users/phovea/following{/other_user}","gists_url":"https://api.github.com/users/phovea/gists{/gist_id}","starred_url":"https://api.github.com/users/phovea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phovea/subscriptions","organizations_url":"https://api.github.com/users/phovea/orgs","repos_url":"https://api.github.com/users/phovea/repos","events_url":"https://api.github.com/users/phovea/events{/privacy}","received_events_url":"https://api.github.com/users/phovea/received_events","type":"Organization","site_admin":false},"repo":{"id":39556332,"name":"phovea_core","full_name":"phovea/phovea_core","owner":{"login":"phovea","id":21689003,"avatar_url":"https://avatars.githubusercontent.com/u/21689003?v=3","gravatar_id":"","url":"https://api.github.com/users/phovea","html_url":"https://github.com/phovea","followers_url":"https://api.github.com/users/phovea/followers","following_url":"https://api.github.com/users/phovea/following{/other_user}","gists_url":"https://api.github.com/users/phovea/gists{/gist_id}","starred_url":"https://api.github.com/users/phovea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phovea/subscriptions","organizations_url":"https://api.github.com/users/phovea/orgs","repos_url":"https://api.github.com/users/phovea/repos","events_url":"https://api.github.com/users/phovea/events{/privacy}","received_events_url":"https://api.github.com/users/phovea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phovea/phovea_core","description":"Phovea core includes the plugin registry, data definition (+ common types: tables, matrix, vector, stratification), ajax, selections","fork":false,"url":"https://api.github.com/repos/phovea/phovea_core","forks_url":"https://api.github.com/repos/phovea/phovea_core/forks","keys_url":"https://api.github.com/repos/phovea/phovea_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phovea/phovea_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phovea/phovea_core/teams","hooks_url":"https://api.github.com/repos/phovea/phovea_core/hooks","issue_events_url":"https://api.github.com/repos/phovea/phovea_core/issues/events{/number}","events_url":"https://api.github.com/repos/phovea/phovea_core/events","assignees_url":"https://api.github.com/repos/phovea/phovea_core/assignees{/user}","branches_url":"https://api.github.com/repos/phovea/phovea_core/branches{/branch}","tags_url":"https://api.github.com/repos/phovea/phovea_core/tags","blobs_url":"https://api.github.com/repos/phovea/phovea_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phovea/phovea_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phovea/phovea_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/phovea/phovea_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phovea/phovea_core/statuses/{sha}","languages_url":"https://api.github.com/repos/phovea/phovea_core/languages","stargazers_url":"https://api.github.com/repos/phovea/phovea_core/stargazers","contributors_url":"https://api.github.com/repos/phovea/phovea_core/contributors","subscribers_url":"https://api.github.com/repos/phovea/phovea_core/subscribers","subscription_url":"https://api.github.com/repos/phovea/phovea_core/subscription","commits_url":"https://api.github.com/repos/phovea/phovea_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/phovea/phovea_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/phovea/phovea_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/phovea/phovea_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/phovea/phovea_core/contents/{+path}","compare_url":"https://api.github.com/repos/phovea/phovea_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phovea/phovea_core/merges","archive_url":"https://api.github.com/repos/phovea/phovea_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phovea/phovea_core/downloads","issues_url":"https://api.github.com/repos/phovea/phovea_core/issues{/number}","pulls_url":"https://api.github.com/repos/phovea/phovea_core/pulls{/number}","milestones_url":"https://api.github.com/repos/phovea/phovea_core/milestones{/number}","notifications_url":"https://api.github.com/repos/phovea/phovea_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phovea/phovea_core/labels{/name}","releases_url":"https://api.github.com/repos/phovea/phovea_core/releases{/id}","deployments_url":"https://api.github.com/repos/phovea/phovea_core/deployments","created_at":"2015-07-23T08:49:28Z","updated_at":"2016-11-06T09:27:39Z","pushed_at":"2016-11-21T14:33:02Z","git_url":"git://github.com/phovea/phovea_core.git","ssh_url":"git@github.com:phovea/phovea_core.git","clone_url":"https://github.com/phovea/phovea_core.git","svn_url":"https://github.com/phovea/phovea_core","homepage":"http://phovea.caleydo.org/","size":414,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phovea/phovea_core/pulls/12"},"html":{"href":"https://github.com/phovea/phovea_core/pull/12"},"issue":{"href":"https://api.github.com/repos/phovea/phovea_core/issues/12"},"comments":{"href":"https://api.github.com/repos/phovea/phovea_core/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/phovea/phovea_core/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/phovea/phovea_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phovea/phovea_core/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/phovea/phovea_core/statuses/f05ed0c61fafced09ec1687e214f8461dc17d47d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mccalluc","id":730388,"avatar_url":"https://avatars.githubusercontent.com/u/730388?v=3","gravatar_id":"","url":"https://api.github.com/users/mccalluc","html_url":"https://github.com/mccalluc","followers_url":"https://api.github.com/users/mccalluc/followers","following_url":"https://api.github.com/users/mccalluc/following{/other_user}","gists_url":"https://api.github.com/users/mccalluc/gists{/gist_id}","starred_url":"https://api.github.com/users/mccalluc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccalluc/subscriptions","organizations_url":"https://api.github.com/users/mccalluc/orgs","repos_url":"https://api.github.com/users/mccalluc/repos","events_url":"https://api.github.com/users/mccalluc/events{/privacy}","received_events_url":"https://api.github.com/users/mccalluc/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":10,"additions":4411,"deletions":1,"changed_files":26}}
{"actor":{"display_login":"mccalluc"}}