{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/googlei18n/compreffor/pulls/8","id":68476263,"html_url":"https://github.com/googlei18n/compreffor/pull/8","diff_url":"https://github.com/googlei18n/compreffor/pull/8.diff","patch_url":"https://github.com/googlei18n/compreffor/pull/8.patch","issue_url":"https://api.github.com/repos/googlei18n/compreffor/issues/8","number":8,"state":"closed","locked":false,"title":"build executable and shared lib using setup.py","user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"body":"This is just temporary, until we make a true Python extension module (i'm thinking of using Cython for that).\r\n\r\nThe build still requires GNU `make` and a unix compiler, so to make it work on Windows one needs to use the mingw-w64 gcc from an [MSYS2](https://msys2.github.io/) environment.\r\n\r\nAt least this allows to run `python setup.py build` or `python setup.py install` (or `pip install`, etc.) and have `make`  run automatically as a subprocess.\r\n\r\nI installed MSYS2, then installed the 32-bit toolchain with `pacman -S mingw-w64-i686-toolchain` and built the `cffCompressor.exe` and `compreff.dll` (the names are a bit inconsistent, btw).\r\n\r\nWhen running compreffor using the executable (with `compreff(font, use_lib=False)`), the executable crashes with `std::bad_alloc`... We need to further investigate this. However, when running with the shared library loaded through `ctypes` (by setting `use_lib=True`), then it seems to be working fine.\r\nSo, I decided to make `use_lib=True` the default. Non-windows users can set `use_lib=False` if that speeds it up (I haven't tested).\r\n\r\nPlease take a look, thanks.\r\n","created_at":"2016-04-30T19:11:24Z","updated_at":"2016-05-01T05:50:35Z","closed_at":"2016-05-01T05:50:35Z","merged_at":"2016-05-01T05:50:35Z","merge_commit_sha":"e5eb1de5150163b2ce27a03abe1c53df9e235127","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/googlei18n/compreffor/pulls/8/commits","review_comments_url":"https://api.github.com/repos/googlei18n/compreffor/pulls/8/comments","review_comment_url":"https://api.github.com/repos/googlei18n/compreffor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlei18n/compreffor/issues/8/comments","statuses_url":"https://api.github.com/repos/googlei18n/compreffor/statuses/e91612704d3ff178d46d8f9f17872ae2203e34be","head":{"label":"anthrotype:buildcxx","ref":"buildcxx","sha":"e91612704d3ff178d46d8f9f17872ae2203e34be","user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"repo":{"id":36726468,"name":"compreffor","full_name":"anthrotype/compreffor","owner":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anthrotype/compreffor","description":"A CFF table subroutinizer for FontTools","fork":true,"url":"https://api.github.com/repos/anthrotype/compreffor","forks_url":"https://api.github.com/repos/anthrotype/compreffor/forks","keys_url":"https://api.github.com/repos/anthrotype/compreffor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anthrotype/compreffor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anthrotype/compreffor/teams","hooks_url":"https://api.github.com/repos/anthrotype/compreffor/hooks","issue_events_url":"https://api.github.com/repos/anthrotype/compreffor/issues/events{/number}","events_url":"https://api.github.com/repos/anthrotype/compreffor/events","assignees_url":"https://api.github.com/repos/anthrotype/compreffor/assignees{/user}","branches_url":"https://api.github.com/repos/anthrotype/compreffor/branches{/branch}","tags_url":"https://api.github.com/repos/anthrotype/compreffor/tags","blobs_url":"https://api.github.com/repos/anthrotype/compreffor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anthrotype/compreffor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anthrotype/compreffor/git/refs{/sha}","trees_url":"https://api.github.com/repos/anthrotype/compreffor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anthrotype/compreffor/statuses/{sha}","languages_url":"https://api.github.com/repos/anthrotype/compreffor/languages","stargazers_url":"https://api.github.com/repos/anthrotype/compreffor/stargazers","contributors_url":"https://api.github.com/repos/anthrotype/compreffor/contributors","subscribers_url":"https://api.github.com/repos/anthrotype/compreffor/subscribers","subscription_url":"https://api.github.com/repos/anthrotype/compreffor/subscription","commits_url":"https://api.github.com/repos/anthrotype/compreffor/commits{/sha}","git_commits_url":"https://api.github.com/repos/anthrotype/compreffor/git/commits{/sha}","comments_url":"https://api.github.com/repos/anthrotype/compreffor/comments{/number}","issue_comment_url":"https://api.github.com/repos/anthrotype/compreffor/issues/comments{/number}","contents_url":"https://api.github.com/repos/anthrotype/compreffor/contents/{+path}","compare_url":"https://api.github.com/repos/anthrotype/compreffor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anthrotype/compreffor/merges","archive_url":"https://api.github.com/repos/anthrotype/compreffor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anthrotype/compreffor/downloads","issues_url":"https://api.github.com/repos/anthrotype/compreffor/issues{/number}","pulls_url":"https://api.github.com/repos/anthrotype/compreffor/pulls{/number}","milestones_url":"https://api.github.com/repos/anthrotype/compreffor/milestones{/number}","notifications_url":"https://api.github.com/repos/anthrotype/compreffor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anthrotype/compreffor/labels{/name}","releases_url":"https://api.github.com/repos/anthrotype/compreffor/releases{/id}","deployments_url":"https://api.github.com/repos/anthrotype/compreffor/deployments","created_at":"2015-06-02T10:44:11Z","updated_at":"2016-04-30T15:54:45Z","pushed_at":"2016-04-30T19:23:06Z","git_url":"git://github.com/anthrotype/compreffor.git","ssh_url":"git@github.com:anthrotype/compreffor.git","clone_url":"https://github.com/anthrotype/compreffor.git","svn_url":"https://github.com/anthrotype/compreffor","homepage":null,"size":240,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlei18n:master","ref":"master","sha":"f5bf3e42059e2a51a79f3cb6d7be2bc1d84cbe35","user":{"login":"googlei18n","id":5503833,"avatar_url":"https://avatars.githubusercontent.com/u/5503833?v=3","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"repo":{"id":36692932,"name":"compreffor","full_name":"googlei18n/compreffor","owner":{"login":"googlei18n","id":5503833,"avatar_url":"https://avatars.githubusercontent.com/u/5503833?v=3","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlei18n/compreffor","description":"A CFF table subroutinizer for FontTools","fork":false,"url":"https://api.github.com/repos/googlei18n/compreffor","forks_url":"https://api.github.com/repos/googlei18n/compreffor/forks","keys_url":"https://api.github.com/repos/googlei18n/compreffor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlei18n/compreffor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlei18n/compreffor/teams","hooks_url":"https://api.github.com/repos/googlei18n/compreffor/hooks","issue_events_url":"https://api.github.com/repos/googlei18n/compreffor/issues/events{/number}","events_url":"https://api.github.com/repos/googlei18n/compreffor/events","assignees_url":"https://api.github.com/repos/googlei18n/compreffor/assignees{/user}","branches_url":"https://api.github.com/repos/googlei18n/compreffor/branches{/branch}","tags_url":"https://api.github.com/repos/googlei18n/compreffor/tags","blobs_url":"https://api.github.com/repos/googlei18n/compreffor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlei18n/compreffor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlei18n/compreffor/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlei18n/compreffor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlei18n/compreffor/statuses/{sha}","languages_url":"https://api.github.com/repos/googlei18n/compreffor/languages","stargazers_url":"https://api.github.com/repos/googlei18n/compreffor/stargazers","contributors_url":"https://api.github.com/repos/googlei18n/compreffor/contributors","subscribers_url":"https://api.github.com/repos/googlei18n/compreffor/subscribers","subscription_url":"https://api.github.com/repos/googlei18n/compreffor/subscription","commits_url":"https://api.github.com/repos/googlei18n/compreffor/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlei18n/compreffor/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlei18n/compreffor/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlei18n/compreffor/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlei18n/compreffor/contents/{+path}","compare_url":"https://api.github.com/repos/googlei18n/compreffor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlei18n/compreffor/merges","archive_url":"https://api.github.com/repos/googlei18n/compreffor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlei18n/compreffor/downloads","issues_url":"https://api.github.com/repos/googlei18n/compreffor/issues{/number}","pulls_url":"https://api.github.com/repos/googlei18n/compreffor/pulls{/number}","milestones_url":"https://api.github.com/repos/googlei18n/compreffor/milestones{/number}","notifications_url":"https://api.github.com/repos/googlei18n/compreffor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlei18n/compreffor/labels{/name}","releases_url":"https://api.github.com/repos/googlei18n/compreffor/releases{/id}","deployments_url":"https://api.github.com/repos/googlei18n/compreffor/deployments","created_at":"2015-06-01T22:34:10Z","updated_at":"2016-02-17T08:45:05Z","pushed_at":"2016-05-01T05:50:35Z","git_url":"git://github.com/googlei18n/compreffor.git","ssh_url":"git@github.com:googlei18n/compreffor.git","clone_url":"https://github.com/googlei18n/compreffor.git","svn_url":"https://github.com/googlei18n/compreffor","homepage":null,"size":242,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlei18n/compreffor/pulls/8"},"html":{"href":"https://github.com/googlei18n/compreffor/pull/8"},"issue":{"href":"https://api.github.com/repos/googlei18n/compreffor/issues/8"},"comments":{"href":"https://api.github.com/repos/googlei18n/compreffor/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/googlei18n/compreffor/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/googlei18n/compreffor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlei18n/compreffor/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/googlei18n/compreffor/statuses/e91612704d3ff178d46d8f9f17872ae2203e34be"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"behdad","id":142891,"avatar_url":"https://avatars.githubusercontent.com/u/142891?v=3","gravatar_id":"","url":"https://api.github.com/users/behdad","html_url":"https://github.com/behdad","followers_url":"https://api.github.com/users/behdad/followers","following_url":"https://api.github.com/users/behdad/following{/other_user}","gists_url":"https://api.github.com/users/behdad/gists{/gist_id}","starred_url":"https://api.github.com/users/behdad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behdad/subscriptions","organizations_url":"https://api.github.com/users/behdad/orgs","repos_url":"https://api.github.com/users/behdad/repos","events_url":"https://api.github.com/users/behdad/events{/privacy}","received_events_url":"https://api.github.com/users/behdad/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":5,"additions":118,"deletions":9,"changed_files":4}}