{"action":"created","comment":{"url":"https://api.github.com/repos/numenta/nupic.core/pulls/comments/90294394","pull_request_review_id":10815364,"id":90294394,"diff_hunk":"@@ -1120,20 +1122,79 @@ void SpatialPooler::updateDutyCyclesHelper_(vector<Real>& dutyCycles,\n \n void SpatialPooler::updateBoostFactors_()\n {\n-  for (UInt i = 0; i < numColumns_; i++)\n+  if (maxBoost_ > 1.0)\n+  {    \n+    if (globalInhibition_)\n+    {\n+      updateBoostFactorsGlobal_();\n+    }\n+    else\n+    {\n+      updateBoostFactorsLocal_();\n+    }\n+  }\n+}\n+\n+void SpatialPooler::updateBoostFactorsGlobal_()\n+{\n+  Real targetDensity;\n+  if (numActiveColumnsPerInhArea_ > 0)\n+  {\n+    UInt inhibitionArea = pow((Real) (2 * inhibitionRadius_ + 1),","path":"src/nupic/algorithms/SpatialPooler.cpp","position":50,"original_position":50,"commit_id":"0e06012f1637f7d18d2b674dfdc0559b0ae05da2","original_commit_id":"0e06012f1637f7d18d2b674dfdc0559b0ae05da2","user":{"login":"scottpurdy","id":239726,"avatar_url":"https://avatars.githubusercontent.com/u/239726?v=3","gravatar_id":"","url":"https://api.github.com/users/scottpurdy","html_url":"https://github.com/scottpurdy","followers_url":"https://api.github.com/users/scottpurdy/followers","following_url":"https://api.github.com/users/scottpurdy/following{/other_user}","gists_url":"https://api.github.com/users/scottpurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/scottpurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottpurdy/subscriptions","organizations_url":"https://api.github.com/users/scottpurdy/orgs","repos_url":"https://api.github.com/users/scottpurdy/repos","events_url":"https://api.github.com/users/scottpurdy/events{/privacy}","received_events_url":"https://api.github.com/users/scottpurdy/received_events","type":"User","site_admin":false},"body":"Same, use explicit `UInt32`","created_at":"2016-11-30T18:21:52Z","updated_at":"2016-11-30T18:21:52Z","html_url":"https://github.com/numenta/nupic.core/pull/1164#discussion_r90294394","pull_request_url":"https://api.github.com/repos/numenta/nupic.core/pulls/1164","_links":{"self":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/comments/90294394"},"html":{"href":"https://github.com/numenta/nupic.core/pull/1164#discussion_r90294394"},"pull_request":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/1164"}}},"pull_request":{"url":"https://api.github.com/repos/numenta/nupic.core/pulls/1164","id":95744559,"html_url":"https://github.com/numenta/nupic.core/pull/1164","diff_url":"https://github.com/numenta/nupic.core/pull/1164.diff","patch_url":"https://github.com/numenta/nupic.core/pull/1164.patch","issue_url":"https://api.github.com/repos/numenta/nupic.core/issues/1164","number":1164,"state":"open","locked":false,"title":"Implement New SP Boosting Rules","user":{"login":"ywcui1990","id":5067931,"avatar_url":"https://avatars.githubusercontent.com/u/5067931?v=3","gravatar_id":"","url":"https://api.github.com/users/ywcui1990","html_url":"https://github.com/ywcui1990","followers_url":"https://api.github.com/users/ywcui1990/followers","following_url":"https://api.github.com/users/ywcui1990/following{/other_user}","gists_url":"https://api.github.com/users/ywcui1990/gists{/gist_id}","starred_url":"https://api.github.com/users/ywcui1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywcui1990/subscriptions","organizations_url":"https://api.github.com/users/ywcui1990/orgs","repos_url":"https://api.github.com/users/ywcui1990/repos","events_url":"https://api.github.com/users/ywcui1990/events{/privacy}","received_events_url":"https://api.github.com/users/ywcui1990/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/numenta/nupic.core/issues/1155\r\n\r\n* Modify the updateBoostFactors function in spatial pooler\r\n* Update related spatial pooler test\r\n* Round boost factor to a couple decimal places to avoid float point differences\r\n* Correct misc typos in spatial_pooler.hpp","created_at":"2016-11-29T18:04:29Z","updated_at":"2016-11-30T18:31:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03f8d0a10b6cd46033d549e8dfe910c05fce359b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/numenta/nupic.core/pulls/1164/commits","review_comments_url":"https://api.github.com/repos/numenta/nupic.core/pulls/1164/comments","review_comment_url":"https://api.github.com/repos/numenta/nupic.core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numenta/nupic.core/issues/1164/comments","statuses_url":"https://api.github.com/repos/numenta/nupic.core/statuses/0e06012f1637f7d18d2b674dfdc0559b0ae05da2","head":{"label":"ywcui1990:BoostingRes","ref":"BoostingRes","sha":"0e06012f1637f7d18d2b674dfdc0559b0ae05da2","user":{"login":"ywcui1990","id":5067931,"avatar_url":"https://avatars.githubusercontent.com/u/5067931?v=3","gravatar_id":"","url":"https://api.github.com/users/ywcui1990","html_url":"https://github.com/ywcui1990","followers_url":"https://api.github.com/users/ywcui1990/followers","following_url":"https://api.github.com/users/ywcui1990/following{/other_user}","gists_url":"https://api.github.com/users/ywcui1990/gists{/gist_id}","starred_url":"https://api.github.com/users/ywcui1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywcui1990/subscriptions","organizations_url":"https://api.github.com/users/ywcui1990/orgs","repos_url":"https://api.github.com/users/ywcui1990/repos","events_url":"https://api.github.com/users/ywcui1990/events{/privacy}","received_events_url":"https://api.github.com/users/ywcui1990/received_events","type":"User","site_admin":false},"repo":{"id":56193611,"name":"nupic.core","full_name":"ywcui1990/nupic.core","owner":{"login":"ywcui1990","id":5067931,"avatar_url":"https://avatars.githubusercontent.com/u/5067931?v=3","gravatar_id":"","url":"https://api.github.com/users/ywcui1990","html_url":"https://github.com/ywcui1990","followers_url":"https://api.github.com/users/ywcui1990/followers","following_url":"https://api.github.com/users/ywcui1990/following{/other_user}","gists_url":"https://api.github.com/users/ywcui1990/gists{/gist_id}","starred_url":"https://api.github.com/users/ywcui1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywcui1990/subscriptions","organizations_url":"https://api.github.com/users/ywcui1990/orgs","repos_url":"https://api.github.com/users/ywcui1990/repos","events_url":"https://api.github.com/users/ywcui1990/events{/privacy}","received_events_url":"https://api.github.com/users/ywcui1990/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ywcui1990/nupic.core","description":"Implementation of core NuPIC algorithms in C++ (under construction)","fork":true,"url":"https://api.github.com/repos/ywcui1990/nupic.core","forks_url":"https://api.github.com/repos/ywcui1990/nupic.core/forks","keys_url":"https://api.github.com/repos/ywcui1990/nupic.core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ywcui1990/nupic.core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ywcui1990/nupic.core/teams","hooks_url":"https://api.github.com/repos/ywcui1990/nupic.core/hooks","issue_events_url":"https://api.github.com/repos/ywcui1990/nupic.core/issues/events{/number}","events_url":"https://api.github.com/repos/ywcui1990/nupic.core/events","assignees_url":"https://api.github.com/repos/ywcui1990/nupic.core/assignees{/user}","branches_url":"https://api.github.com/repos/ywcui1990/nupic.core/branches{/branch}","tags_url":"https://api.github.com/repos/ywcui1990/nupic.core/tags","blobs_url":"https://api.github.com/repos/ywcui1990/nupic.core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ywcui1990/nupic.core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ywcui1990/nupic.core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ywcui1990/nupic.core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ywcui1990/nupic.core/statuses/{sha}","languages_url":"https://api.github.com/repos/ywcui1990/nupic.core/languages","stargazers_url":"https://api.github.com/repos/ywcui1990/nupic.core/stargazers","contributors_url":"https://api.github.com/repos/ywcui1990/nupic.core/contributors","subscribers_url":"https://api.github.com/repos/ywcui1990/nupic.core/subscribers","subscription_url":"https://api.github.com/repos/ywcui1990/nupic.core/subscription","commits_url":"https://api.github.com/repos/ywcui1990/nupic.core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ywcui1990/nupic.core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ywcui1990/nupic.core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ywcui1990/nupic.core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ywcui1990/nupic.core/contents/{+path}","compare_url":"https://api.github.com/repos/ywcui1990/nupic.core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ywcui1990/nupic.core/merges","archive_url":"https://api.github.com/repos/ywcui1990/nupic.core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ywcui1990/nupic.core/downloads","issues_url":"https://api.github.com/repos/ywcui1990/nupic.core/issues{/number}","pulls_url":"https://api.github.com/repos/ywcui1990/nupic.core/pulls{/number}","milestones_url":"https://api.github.com/repos/ywcui1990/nupic.core/milestones{/number}","notifications_url":"https://api.github.com/repos/ywcui1990/nupic.core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ywcui1990/nupic.core/labels{/name}","releases_url":"https://api.github.com/repos/ywcui1990/nupic.core/releases{/id}","deployments_url":"https://api.github.com/repos/ywcui1990/nupic.core/deployments","created_at":"2016-04-13T23:52:54Z","updated_at":"2016-04-13T23:52:56Z","pushed_at":"2016-11-30T17:44:35Z","git_url":"git://github.com/ywcui1990/nupic.core.git","ssh_url":"git@github.com:ywcui1990/nupic.core.git","clone_url":"https://github.com/ywcui1990/nupic.core.git","svn_url":"https://github.com/ywcui1990/nupic.core","homepage":"http://numenta.org","size":187818,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numenta:master","ref":"master","sha":"96afd3c76c75dfa890c60059b921977b19260a68","user":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"repo":{"id":16366081,"name":"nupic.core","full_name":"numenta/nupic.core","owner":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numenta/nupic.core","description":"Implementation of core NuPIC algorithms in C++ (under construction)","fork":false,"url":"https://api.github.com/repos/numenta/nupic.core","forks_url":"https://api.github.com/repos/numenta/nupic.core/forks","keys_url":"https://api.github.com/repos/numenta/nupic.core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numenta/nupic.core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numenta/nupic.core/teams","hooks_url":"https://api.github.com/repos/numenta/nupic.core/hooks","issue_events_url":"https://api.github.com/repos/numenta/nupic.core/issues/events{/number}","events_url":"https://api.github.com/repos/numenta/nupic.core/events","assignees_url":"https://api.github.com/repos/numenta/nupic.core/assignees{/user}","branches_url":"https://api.github.com/repos/numenta/nupic.core/branches{/branch}","tags_url":"https://api.github.com/repos/numenta/nupic.core/tags","blobs_url":"https://api.github.com/repos/numenta/nupic.core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numenta/nupic.core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numenta/nupic.core/git/refs{/sha}","trees_url":"https://api.github.com/repos/numenta/nupic.core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numenta/nupic.core/statuses/{sha}","languages_url":"https://api.github.com/repos/numenta/nupic.core/languages","stargazers_url":"https://api.github.com/repos/numenta/nupic.core/stargazers","contributors_url":"https://api.github.com/repos/numenta/nupic.core/contributors","subscribers_url":"https://api.github.com/repos/numenta/nupic.core/subscribers","subscription_url":"https://api.github.com/repos/numenta/nupic.core/subscription","commits_url":"https://api.github.com/repos/numenta/nupic.core/commits{/sha}","git_commits_url":"https://api.github.com/repos/numenta/nupic.core/git/commits{/sha}","comments_url":"https://api.github.com/repos/numenta/nupic.core/comments{/number}","issue_comment_url":"https://api.github.com/repos/numenta/nupic.core/issues/comments{/number}","contents_url":"https://api.github.com/repos/numenta/nupic.core/contents/{+path}","compare_url":"https://api.github.com/repos/numenta/nupic.core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numenta/nupic.core/merges","archive_url":"https://api.github.com/repos/numenta/nupic.core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numenta/nupic.core/downloads","issues_url":"https://api.github.com/repos/numenta/nupic.core/issues{/number}","pulls_url":"https://api.github.com/repos/numenta/nupic.core/pulls{/number}","milestones_url":"https://api.github.com/repos/numenta/nupic.core/milestones{/number}","notifications_url":"https://api.github.com/repos/numenta/nupic.core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numenta/nupic.core/labels{/name}","releases_url":"https://api.github.com/repos/numenta/nupic.core/releases{/id}","deployments_url":"https://api.github.com/repos/numenta/nupic.core/deployments","created_at":"2014-01-30T02:13:40Z","updated_at":"2016-11-29T00:54:23Z","pushed_at":"2016-11-30T17:44:36Z","git_url":"git://github.com/numenta/nupic.core.git","ssh_url":"git@github.com:numenta/nupic.core.git","clone_url":"https://github.com/numenta/nupic.core.git","svn_url":"https://github.com/numenta/nupic.core","homepage":"http://numenta.org","size":233952,"stargazers_count":170,"watchers_count":170,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":122,"forks":164,"open_issues":122,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/1164"},"html":{"href":"https://github.com/numenta/nupic.core/pull/1164"},"issue":{"href":"https://api.github.com/repos/numenta/nupic.core/issues/1164"},"comments":{"href":"https://api.github.com/repos/numenta/nupic.core/issues/1164/comments"},"review_comments":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/1164/comments"},"review_comment":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/1164/commits"},"statuses":{"href":"https://api.github.com/repos/numenta/nupic.core/statuses/0e06012f1637f7d18d2b674dfdc0559b0ae05da2"}}}}
{"actor":{"display_login":"scottpurdy"}}