{"action":"created","comment":{"url":"https://api.github.com/repos/HPENetworking/topology/pulls/comments/65230960","id":65230960,"diff_hunk":"@@ -531,6 +531,7 @@ def connect(self, connection=None):\n         except:\n             # Always remove bad connections if it failed\n             del self._connections[connection]\n+            raise","path":"lib/topology/platforms/shell.py","position":4,"original_position":4,"commit_id":"0d658122deed080d82d8410e28d299ef89b7bb90","original_commit_id":"0d658122deed080d82d8410e28d299ef89b7bb90","user":{"login":"carlos-jenkins","id":1628587,"avatar_url":"https://avatars.githubusercontent.com/u/1628587?v=3","gravatar_id":"","url":"https://api.github.com/users/carlos-jenkins","html_url":"https://github.com/carlos-jenkins","followers_url":"https://api.github.com/users/carlos-jenkins/followers","following_url":"https://api.github.com/users/carlos-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/carlos-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/carlos-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlos-jenkins/subscriptions","organizations_url":"https://api.github.com/users/carlos-jenkins/orgs","repos_url":"https://api.github.com/users/carlos-jenkins/repos","events_url":"https://api.github.com/users/carlos-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/carlos-jenkins/received_events","type":"User","site_admin":false},"body":"Maybe log it, but in any case _setup_shell is user defined so anything can happen here. We shouldn't mask the real exception, so this generic approach is great.\r\n\r\nAnd btw thanks, that raise was missing.","created_at":"2016-05-31T17:52:08Z","updated_at":"2016-05-31T17:52:08Z","html_url":"https://github.com/HPENetworking/topology/pull/22#discussion_r65230960","pull_request_url":"https://api.github.com/repos/HPENetworking/topology/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/HPENetworking/topology/pulls/comments/65230960"},"html":{"href":"https://github.com/HPENetworking/topology/pull/22#discussion_r65230960"},"pull_request":{"href":"https://api.github.com/repos/HPENetworking/topology/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/HPENetworking/topology/pulls/22","id":72049609,"html_url":"https://github.com/HPENetworking/topology/pull/22","diff_url":"https://github.com/HPENetworking/topology/pull/22.diff","patch_url":"https://github.com/HPENetworking/topology/pull/22.patch","issue_url":"https://api.github.com/repos/HPENetworking/topology/issues/22","number":22,"state":"open","locked":false,"title":"fix: dev: Adding a missing raise.","user":{"login":"ocelotl","id":5069942,"avatar_url":"https://avatars.githubusercontent.com/u/5069942?v=3","gravatar_id":"","url":"https://api.github.com/users/ocelotl","html_url":"https://github.com/ocelotl","followers_url":"https://api.github.com/users/ocelotl/followers","following_url":"https://api.github.com/users/ocelotl/following{/other_user}","gists_url":"https://api.github.com/users/ocelotl/gists{/gist_id}","starred_url":"https://api.github.com/users/ocelotl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocelotl/subscriptions","organizations_url":"https://api.github.com/users/ocelotl/orgs","repos_url":"https://api.github.com/users/ocelotl/repos","events_url":"https://api.github.com/users/ocelotl/events{/privacy}","received_events_url":"https://api.github.com/users/ocelotl/received_events","type":"User","site_admin":false},"body":"A raise was missing, make it impossible to handle an exception that may be raised in the try block.","created_at":"2016-05-31T16:52:36Z","updated_at":"2016-05-31T17:52:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"853e855ae4f52b416f9c0405780831e37cecfa5f","assignee":{"login":"dajose","id":4218582,"avatar_url":"https://avatars.githubusercontent.com/u/4218582?v=3","gravatar_id":"","url":"https://api.github.com/users/dajose","html_url":"https://github.com/dajose","followers_url":"https://api.github.com/users/dajose/followers","following_url":"https://api.github.com/users/dajose/following{/other_user}","gists_url":"https://api.github.com/users/dajose/gists{/gist_id}","starred_url":"https://api.github.com/users/dajose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dajose/subscriptions","organizations_url":"https://api.github.com/users/dajose/orgs","repos_url":"https://api.github.com/users/dajose/repos","events_url":"https://api.github.com/users/dajose/events{/privacy}","received_events_url":"https://api.github.com/users/dajose/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/HPENetworking/topology/pulls/22/commits","review_comments_url":"https://api.github.com/repos/HPENetworking/topology/pulls/22/comments","review_comment_url":"https://api.github.com/repos/HPENetworking/topology/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HPENetworking/topology/issues/22/comments","statuses_url":"https://api.github.com/repos/HPENetworking/topology/statuses/0d658122deed080d82d8410e28d299ef89b7bb90","head":{"label":"HPENetworking:raise_bug","ref":"raise_bug","sha":"0d658122deed080d82d8410e28d299ef89b7bb90","user":{"login":"HPENetworking","id":11503648,"avatar_url":"https://avatars.githubusercontent.com/u/11503648?v=3","gravatar_id":"","url":"https://api.github.com/users/HPENetworking","html_url":"https://github.com/HPENetworking","followers_url":"https://api.github.com/users/HPENetworking/followers","following_url":"https://api.github.com/users/HPENetworking/following{/other_user}","gists_url":"https://api.github.com/users/HPENetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/HPENetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HPENetworking/subscriptions","organizations_url":"https://api.github.com/users/HPENetworking/orgs","repos_url":"https://api.github.com/users/HPENetworking/repos","events_url":"https://api.github.com/users/HPENetworking/events{/privacy}","received_events_url":"https://api.github.com/users/HPENetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":49096595,"name":"topology","full_name":"HPENetworking/topology","owner":{"login":"HPENetworking","id":11503648,"avatar_url":"https://avatars.githubusercontent.com/u/11503648?v=3","gravatar_id":"","url":"https://api.github.com/users/HPENetworking","html_url":"https://github.com/HPENetworking","followers_url":"https://api.github.com/users/HPENetworking/followers","following_url":"https://api.github.com/users/HPENetworking/following{/other_user}","gists_url":"https://api.github.com/users/HPENetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/HPENetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HPENetworking/subscriptions","organizations_url":"https://api.github.com/users/HPENetworking/orgs","repos_url":"https://api.github.com/users/HPENetworking/repos","events_url":"https://api.github.com/users/HPENetworking/events{/privacy}","received_events_url":"https://api.github.com/users/HPENetworking/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HPENetworking/topology","description":"Network Topology Framework using NML, with support for pytest","fork":false,"url":"https://api.github.com/repos/HPENetworking/topology","forks_url":"https://api.github.com/repos/HPENetworking/topology/forks","keys_url":"https://api.github.com/repos/HPENetworking/topology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HPENetworking/topology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HPENetworking/topology/teams","hooks_url":"https://api.github.com/repos/HPENetworking/topology/hooks","issue_events_url":"https://api.github.com/repos/HPENetworking/topology/issues/events{/number}","events_url":"https://api.github.com/repos/HPENetworking/topology/events","assignees_url":"https://api.github.com/repos/HPENetworking/topology/assignees{/user}","branches_url":"https://api.github.com/repos/HPENetworking/topology/branches{/branch}","tags_url":"https://api.github.com/repos/HPENetworking/topology/tags","blobs_url":"https://api.github.com/repos/HPENetworking/topology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HPENetworking/topology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HPENetworking/topology/git/refs{/sha}","trees_url":"https://api.github.com/repos/HPENetworking/topology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HPENetworking/topology/statuses/{sha}","languages_url":"https://api.github.com/repos/HPENetworking/topology/languages","stargazers_url":"https://api.github.com/repos/HPENetworking/topology/stargazers","contributors_url":"https://api.github.com/repos/HPENetworking/topology/contributors","subscribers_url":"https://api.github.com/repos/HPENetworking/topology/subscribers","subscription_url":"https://api.github.com/repos/HPENetworking/topology/subscription","commits_url":"https://api.github.com/repos/HPENetworking/topology/commits{/sha}","git_commits_url":"https://api.github.com/repos/HPENetworking/topology/git/commits{/sha}","comments_url":"https://api.github.com/repos/HPENetworking/topology/comments{/number}","issue_comment_url":"https://api.github.com/repos/HPENetworking/topology/issues/comments{/number}","contents_url":"https://api.github.com/repos/HPENetworking/topology/contents/{+path}","compare_url":"https://api.github.com/repos/HPENetworking/topology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HPENetworking/topology/merges","archive_url":"https://api.github.com/repos/HPENetworking/topology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HPENetworking/topology/downloads","issues_url":"https://api.github.com/repos/HPENetworking/topology/issues{/number}","pulls_url":"https://api.github.com/repos/HPENetworking/topology/pulls{/number}","milestones_url":"https://api.github.com/repos/HPENetworking/topology/milestones{/number}","notifications_url":"https://api.github.com/repos/HPENetworking/topology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HPENetworking/topology/labels{/name}","releases_url":"https://api.github.com/repos/HPENetworking/topology/releases{/id}","deployments_url":"https://api.github.com/repos/HPENetworking/topology/deployments","created_at":"2016-01-05T22:27:13Z","updated_at":"2016-05-26T19:01:28Z","pushed_at":"2016-05-31T16:52:36Z","git_url":"git://github.com/HPENetworking/topology.git","ssh_url":"git@github.com:HPENetworking/topology.git","clone_url":"https://github.com/HPENetworking/topology.git","svn_url":"https://github.com/HPENetworking/topology","homepage":"http://topology.rtfd.org/","size":3832,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"HPENetworking:master","ref":"master","sha":"4c671773c386dbaba7aa9e1a6a7992f80c316983","user":{"login":"HPENetworking","id":11503648,"avatar_url":"https://avatars.githubusercontent.com/u/11503648?v=3","gravatar_id":"","url":"https://api.github.com/users/HPENetworking","html_url":"https://github.com/HPENetworking","followers_url":"https://api.github.com/users/HPENetworking/followers","following_url":"https://api.github.com/users/HPENetworking/following{/other_user}","gists_url":"https://api.github.com/users/HPENetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/HPENetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HPENetworking/subscriptions","organizations_url":"https://api.github.com/users/HPENetworking/orgs","repos_url":"https://api.github.com/users/HPENetworking/repos","events_url":"https://api.github.com/users/HPENetworking/events{/privacy}","received_events_url":"https://api.github.com/users/HPENetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":49096595,"name":"topology","full_name":"HPENetworking/topology","owner":{"login":"HPENetworking","id":11503648,"avatar_url":"https://avatars.githubusercontent.com/u/11503648?v=3","gravatar_id":"","url":"https://api.github.com/users/HPENetworking","html_url":"https://github.com/HPENetworking","followers_url":"https://api.github.com/users/HPENetworking/followers","following_url":"https://api.github.com/users/HPENetworking/following{/other_user}","gists_url":"https://api.github.com/users/HPENetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/HPENetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HPENetworking/subscriptions","organizations_url":"https://api.github.com/users/HPENetworking/orgs","repos_url":"https://api.github.com/users/HPENetworking/repos","events_url":"https://api.github.com/users/HPENetworking/events{/privacy}","received_events_url":"https://api.github.com/users/HPENetworking/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HPENetworking/topology","description":"Network Topology Framework using NML, with support for pytest","fork":false,"url":"https://api.github.com/repos/HPENetworking/topology","forks_url":"https://api.github.com/repos/HPENetworking/topology/forks","keys_url":"https://api.github.com/repos/HPENetworking/topology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HPENetworking/topology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HPENetworking/topology/teams","hooks_url":"https://api.github.com/repos/HPENetworking/topology/hooks","issue_events_url":"https://api.github.com/repos/HPENetworking/topology/issues/events{/number}","events_url":"https://api.github.com/repos/HPENetworking/topology/events","assignees_url":"https://api.github.com/repos/HPENetworking/topology/assignees{/user}","branches_url":"https://api.github.com/repos/HPENetworking/topology/branches{/branch}","tags_url":"https://api.github.com/repos/HPENetworking/topology/tags","blobs_url":"https://api.github.com/repos/HPENetworking/topology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HPENetworking/topology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HPENetworking/topology/git/refs{/sha}","trees_url":"https://api.github.com/repos/HPENetworking/topology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HPENetworking/topology/statuses/{sha}","languages_url":"https://api.github.com/repos/HPENetworking/topology/languages","stargazers_url":"https://api.github.com/repos/HPENetworking/topology/stargazers","contributors_url":"https://api.github.com/repos/HPENetworking/topology/contributors","subscribers_url":"https://api.github.com/repos/HPENetworking/topology/subscribers","subscription_url":"https://api.github.com/repos/HPENetworking/topology/subscription","commits_url":"https://api.github.com/repos/HPENetworking/topology/commits{/sha}","git_commits_url":"https://api.github.com/repos/HPENetworking/topology/git/commits{/sha}","comments_url":"https://api.github.com/repos/HPENetworking/topology/comments{/number}","issue_comment_url":"https://api.github.com/repos/HPENetworking/topology/issues/comments{/number}","contents_url":"https://api.github.com/repos/HPENetworking/topology/contents/{+path}","compare_url":"https://api.github.com/repos/HPENetworking/topology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HPENetworking/topology/merges","archive_url":"https://api.github.com/repos/HPENetworking/topology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HPENetworking/topology/downloads","issues_url":"https://api.github.com/repos/HPENetworking/topology/issues{/number}","pulls_url":"https://api.github.com/repos/HPENetworking/topology/pulls{/number}","milestones_url":"https://api.github.com/repos/HPENetworking/topology/milestones{/number}","notifications_url":"https://api.github.com/repos/HPENetworking/topology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HPENetworking/topology/labels{/name}","releases_url":"https://api.github.com/repos/HPENetworking/topology/releases{/id}","deployments_url":"https://api.github.com/repos/HPENetworking/topology/deployments","created_at":"2016-01-05T22:27:13Z","updated_at":"2016-05-26T19:01:28Z","pushed_at":"2016-05-31T16:52:36Z","git_url":"git://github.com/HPENetworking/topology.git","ssh_url":"git@github.com:HPENetworking/topology.git","clone_url":"https://github.com/HPENetworking/topology.git","svn_url":"https://github.com/HPENetworking/topology","homepage":"http://topology.rtfd.org/","size":3832,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HPENetworking/topology/pulls/22"},"html":{"href":"https://github.com/HPENetworking/topology/pull/22"},"issue":{"href":"https://api.github.com/repos/HPENetworking/topology/issues/22"},"comments":{"href":"https://api.github.com/repos/HPENetworking/topology/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/HPENetworking/topology/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/HPENetworking/topology/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HPENetworking/topology/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/HPENetworking/topology/statuses/0d658122deed080d82d8410e28d299ef89b7bb90"}}}}
{"actor":{"display_login":"carlos-jenkins"}}