{"action":"created","comment":{"url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments/62355922","id":62355922,"diff_hunk":"@@ -2621,19 +2621,20 @@ candidate:1 1 UDP 1694498815 192.0.2.33 10000 typ host\n                     only included if such an option was present in the\n                     offer.</t>\n \n-                    <t>The next step is to generate lip sync groups as\n-                    defined in <xref target=\"RFC5888\" />, Section 7. For\n-                    each MediaStream with more than one referenced\n-                    RtpTransceiver, a group of type \"LS\" MUST be added\n-                    that contains the mid values for each RtpTransceiver\n-                    added with that MediaStream. In some cases this may\n-                    result in adding a mid to a given LS group that was\n-                    not in that LS group in the associated\n-                    offer. Although this is not allowed by <xref\n-                    target=\"RFC5888\" />, it is allowed when implementing\n-                    this specification. [[OPEN ISSUE: This is still\n-                    under discussion. See:\n-                    https://github.com/rtcweb-wg/jsep/issues/162.]]</t>\n+                    <t>The next step is to generate session-level lip\n+                    sync groups as defined in <xref target=\"RFC5888\"/>,\n+                    Section 7. For each group of type \"LS\" present in the offer,\n+                    determine which of the local RtpTransceivers identified by\n+                    the group's mid values reference a common local MediaStream\n+                    (as specified in the addTrack and\n+                    addTransceiver methods). If at least two such\n+                    RtpTransceivers exist, a group of type \"LS\" with the mid\n+                    values of these RtpTransceivers MUST be added. Otherwise,","path":"draft-ietf-rtcweb-jsep.xml","position":649,"original_position":649,"commit_id":"6ef3ca7791c4ad52ff0b3960f2f7322290041d79","original_commit_id":"6ef3ca7791c4ad52ff0b3960f2f7322290041d79","user":{"login":"ekr","id":1111457,"avatar_url":"https://avatars.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"body":"Fine by me. The question mark indicated I was unsure.","created_at":"2016-05-06T16:43:37Z","updated_at":"2016-05-06T16:43:37Z","html_url":"https://github.com/rtcweb-wg/jsep/pull/263#discussion_r62355922","pull_request_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/263","_links":{"self":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments/62355922"},"html":{"href":"https://github.com/rtcweb-wg/jsep/pull/263#discussion_r62355922"},"pull_request":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/263","id":64185735,"html_url":"https://github.com/rtcweb-wg/jsep/pull/263","diff_url":"https://github.com/rtcweb-wg/jsep/pull/263.diff","patch_url":"https://github.com/rtcweb-wg/jsep/pull/263.patch","issue_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/263","number":263,"state":"open","locked":false,"title":"Fixup how LS groups work.","user":{"login":"fluffy","id":217200,"avatar_url":"https://avatars.githubusercontent.com/u/217200?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffy","html_url":"https://github.com/fluffy","followers_url":"https://api.github.com/users/fluffy/followers","following_url":"https://api.github.com/users/fluffy/following{/other_user}","gists_url":"https://api.github.com/users/fluffy/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffy/subscriptions","organizations_url":"https://api.github.com/users/fluffy/orgs","repos_url":"https://api.github.com/users/fluffy/repos","events_url":"https://api.github.com/users/fluffy/events{/privacy}","received_events_url":"https://api.github.com/users/fluffy/received_events","type":"User","site_admin":false},"body":"Fixes #162 \r\n\r\nReplaces https://github.com/rtcweb-wg/jsep/pull/167","created_at":"2016-03-25T17:29:11Z","updated_at":"2016-05-06T16:43:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d0611276fc059d94371aa8b1da07f3a52afe9c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/263/commits","review_comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/263/comments","review_comment_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/263/comments","statuses_url":"https://api.github.com/repos/rtcweb-wg/jsep/statuses/6ef3ca7791c4ad52ff0b3960f2f7322290041d79","head":{"label":"rtcweb-wg:lipsync6","ref":"lipsync6","sha":"6ef3ca7791c4ad52ff0b3960f2f7322290041d79","user":{"login":"rtcweb-wg","id":7396946,"avatar_url":"https://avatars.githubusercontent.com/u/7396946?v=3","gravatar_id":"","url":"https://api.github.com/users/rtcweb-wg","html_url":"https://github.com/rtcweb-wg","followers_url":"https://api.github.com/users/rtcweb-wg/followers","following_url":"https://api.github.com/users/rtcweb-wg/following{/other_user}","gists_url":"https://api.github.com/users/rtcweb-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/rtcweb-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtcweb-wg/subscriptions","organizations_url":"https://api.github.com/users/rtcweb-wg/orgs","repos_url":"https://api.github.com/users/rtcweb-wg/repos","events_url":"https://api.github.com/users/rtcweb-wg/events{/privacy}","received_events_url":"https://api.github.com/users/rtcweb-wg/received_events","type":"Organization","site_admin":false},"repo":{"id":19118011,"name":"jsep","full_name":"rtcweb-wg/jsep","owner":{"login":"rtcweb-wg","id":7396946,"avatar_url":"https://avatars.githubusercontent.com/u/7396946?v=3","gravatar_id":"","url":"https://api.github.com/users/rtcweb-wg","html_url":"https://github.com/rtcweb-wg","followers_url":"https://api.github.com/users/rtcweb-wg/followers","following_url":"https://api.github.com/users/rtcweb-wg/following{/other_user}","gists_url":"https://api.github.com/users/rtcweb-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/rtcweb-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtcweb-wg/subscriptions","organizations_url":"https://api.github.com/users/rtcweb-wg/orgs","repos_url":"https://api.github.com/users/rtcweb-wg/repos","events_url":"https://api.github.com/users/rtcweb-wg/events{/privacy}","received_events_url":"https://api.github.com/users/rtcweb-wg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rtcweb-wg/jsep","description":"","fork":false,"url":"https://api.github.com/repos/rtcweb-wg/jsep","forks_url":"https://api.github.com/repos/rtcweb-wg/jsep/forks","keys_url":"https://api.github.com/repos/rtcweb-wg/jsep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtcweb-wg/jsep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtcweb-wg/jsep/teams","hooks_url":"https://api.github.com/repos/rtcweb-wg/jsep/hooks","issue_events_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/events{/number}","events_url":"https://api.github.com/repos/rtcweb-wg/jsep/events","assignees_url":"https://api.github.com/repos/rtcweb-wg/jsep/assignees{/user}","branches_url":"https://api.github.com/repos/rtcweb-wg/jsep/branches{/branch}","tags_url":"https://api.github.com/repos/rtcweb-wg/jsep/tags","blobs_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtcweb-wg/jsep/statuses/{sha}","languages_url":"https://api.github.com/repos/rtcweb-wg/jsep/languages","stargazers_url":"https://api.github.com/repos/rtcweb-wg/jsep/stargazers","contributors_url":"https://api.github.com/repos/rtcweb-wg/jsep/contributors","subscribers_url":"https://api.github.com/repos/rtcweb-wg/jsep/subscribers","subscription_url":"https://api.github.com/repos/rtcweb-wg/jsep/subscription","commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtcweb-wg/jsep/contents/{+path}","compare_url":"https://api.github.com/repos/rtcweb-wg/jsep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtcweb-wg/jsep/merges","archive_url":"https://api.github.com/repos/rtcweb-wg/jsep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtcweb-wg/jsep/downloads","issues_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues{/number}","pulls_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls{/number}","milestones_url":"https://api.github.com/repos/rtcweb-wg/jsep/milestones{/number}","notifications_url":"https://api.github.com/repos/rtcweb-wg/jsep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtcweb-wg/jsep/labels{/name}","releases_url":"https://api.github.com/repos/rtcweb-wg/jsep/releases{/id}","deployments_url":"https://api.github.com/repos/rtcweb-wg/jsep/deployments","created_at":"2014-04-24T17:46:05Z","updated_at":"2016-01-12T21:23:00Z","pushed_at":"2016-05-06T16:34:28Z","git_url":"git://github.com/rtcweb-wg/jsep.git","ssh_url":"git@github.com:rtcweb-wg/jsep.git","clone_url":"https://github.com/rtcweb-wg/jsep.git","svn_url":"https://github.com/rtcweb-wg/jsep","homepage":null,"size":2846,"stargazers_count":12,"watchers_count":12,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":25,"forks":13,"open_issues":25,"watchers":12,"default_branch":"master"}},"base":{"label":"rtcweb-wg:master","ref":"master","sha":"4e14b650d7ed5aaa01409180227f5e360e7e3020","user":{"login":"rtcweb-wg","id":7396946,"avatar_url":"https://avatars.githubusercontent.com/u/7396946?v=3","gravatar_id":"","url":"https://api.github.com/users/rtcweb-wg","html_url":"https://github.com/rtcweb-wg","followers_url":"https://api.github.com/users/rtcweb-wg/followers","following_url":"https://api.github.com/users/rtcweb-wg/following{/other_user}","gists_url":"https://api.github.com/users/rtcweb-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/rtcweb-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtcweb-wg/subscriptions","organizations_url":"https://api.github.com/users/rtcweb-wg/orgs","repos_url":"https://api.github.com/users/rtcweb-wg/repos","events_url":"https://api.github.com/users/rtcweb-wg/events{/privacy}","received_events_url":"https://api.github.com/users/rtcweb-wg/received_events","type":"Organization","site_admin":false},"repo":{"id":19118011,"name":"jsep","full_name":"rtcweb-wg/jsep","owner":{"login":"rtcweb-wg","id":7396946,"avatar_url":"https://avatars.githubusercontent.com/u/7396946?v=3","gravatar_id":"","url":"https://api.github.com/users/rtcweb-wg","html_url":"https://github.com/rtcweb-wg","followers_url":"https://api.github.com/users/rtcweb-wg/followers","following_url":"https://api.github.com/users/rtcweb-wg/following{/other_user}","gists_url":"https://api.github.com/users/rtcweb-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/rtcweb-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtcweb-wg/subscriptions","organizations_url":"https://api.github.com/users/rtcweb-wg/orgs","repos_url":"https://api.github.com/users/rtcweb-wg/repos","events_url":"https://api.github.com/users/rtcweb-wg/events{/privacy}","received_events_url":"https://api.github.com/users/rtcweb-wg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rtcweb-wg/jsep","description":"","fork":false,"url":"https://api.github.com/repos/rtcweb-wg/jsep","forks_url":"https://api.github.com/repos/rtcweb-wg/jsep/forks","keys_url":"https://api.github.com/repos/rtcweb-wg/jsep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtcweb-wg/jsep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtcweb-wg/jsep/teams","hooks_url":"https://api.github.com/repos/rtcweb-wg/jsep/hooks","issue_events_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/events{/number}","events_url":"https://api.github.com/repos/rtcweb-wg/jsep/events","assignees_url":"https://api.github.com/repos/rtcweb-wg/jsep/assignees{/user}","branches_url":"https://api.github.com/repos/rtcweb-wg/jsep/branches{/branch}","tags_url":"https://api.github.com/repos/rtcweb-wg/jsep/tags","blobs_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtcweb-wg/jsep/statuses/{sha}","languages_url":"https://api.github.com/repos/rtcweb-wg/jsep/languages","stargazers_url":"https://api.github.com/repos/rtcweb-wg/jsep/stargazers","contributors_url":"https://api.github.com/repos/rtcweb-wg/jsep/contributors","subscribers_url":"https://api.github.com/repos/rtcweb-wg/jsep/subscribers","subscription_url":"https://api.github.com/repos/rtcweb-wg/jsep/subscription","commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtcweb-wg/jsep/contents/{+path}","compare_url":"https://api.github.com/repos/rtcweb-wg/jsep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtcweb-wg/jsep/merges","archive_url":"https://api.github.com/repos/rtcweb-wg/jsep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtcweb-wg/jsep/downloads","issues_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues{/number}","pulls_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls{/number}","milestones_url":"https://api.github.com/repos/rtcweb-wg/jsep/milestones{/number}","notifications_url":"https://api.github.com/repos/rtcweb-wg/jsep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtcweb-wg/jsep/labels{/name}","releases_url":"https://api.github.com/repos/rtcweb-wg/jsep/releases{/id}","deployments_url":"https://api.github.com/repos/rtcweb-wg/jsep/deployments","created_at":"2014-04-24T17:46:05Z","updated_at":"2016-01-12T21:23:00Z","pushed_at":"2016-05-06T16:34:28Z","git_url":"git://github.com/rtcweb-wg/jsep.git","ssh_url":"git@github.com:rtcweb-wg/jsep.git","clone_url":"https://github.com/rtcweb-wg/jsep.git","svn_url":"https://github.com/rtcweb-wg/jsep","homepage":null,"size":2846,"stargazers_count":12,"watchers_count":12,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":25,"forks":13,"open_issues":25,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/263"},"html":{"href":"https://github.com/rtcweb-wg/jsep/pull/263"},"issue":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/issues/263"},"comments":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/statuses/6ef3ca7791c4ad52ff0b3960f2f7322290041d79"}}}}