{"action":"opened","issue":{"url":"https://api.github.com/repos/ngOfficeUIFabric/ng-officeuifabric/issues/131","labels_url":"https://api.github.com/repos/ngOfficeUIFabric/ng-officeuifabric/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/ngOfficeUIFabric/ng-officeuifabric/issues/131/comments","events_url":"https://api.github.com/repos/ngOfficeUIFabric/ng-officeuifabric/issues/131/events","html_url":"https://github.com/ngOfficeUIFabric/ng-officeuifabric/issues/131","id":128512087,"number":131,"title":"uif-table: Address Failing Tests from jQuery Change in Test Suite","user":{"login":"andrewconnell","id":2068657,"avatar_url":"https://avatars.githubusercontent.com/u/2068657?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewconnell","html_url":"https://github.com/andrewconnell","followers_url":"https://api.github.com/users/andrewconnell/followers","following_url":"https://api.github.com/users/andrewconnell/following{/other_user}","gists_url":"https://api.github.com/users/andrewconnell/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewconnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewconnell/subscriptions","organizations_url":"https://api.github.com/users/andrewconnell/orgs","repos_url":"https://api.github.com/users/andrewconnell/repos","events_url":"https://api.github.com/users/andrewconnell/events{/privacy}","received_events_url":"https://api.github.com/users/andrewconnell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ngOfficeUIFabric/ng-officeuifabric/labels/breaking-change","name":"breaking-change","color":"c7def8"},{"url":"https://api.github.com/repos/ngOfficeUIFabric/ng-officeuifabric/labels/build","name":"build","color":"fef2c0"}],"state":"open","locked":false,"assignee":{"login":"waldekmastykarz","id":11164679,"avatar_url":"https://avatars.githubusercontent.com/u/11164679?v=3","gravatar_id":"","url":"https://api.github.com/users/waldekmastykarz","html_url":"https://github.com/waldekmastykarz","followers_url":"https://api.github.com/users/waldekmastykarz/followers","following_url":"https://api.github.com/users/waldekmastykarz/following{/other_user}","gists_url":"https://api.github.com/users/waldekmastykarz/gists{/gist_id}","starred_url":"https://api.github.com/users/waldekmastykarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waldekmastykarz/subscriptions","organizations_url":"https://api.github.com/users/waldekmastykarz/orgs","repos_url":"https://api.github.com/users/waldekmastykarz/repos","events_url":"https://api.github.com/users/waldekmastykarz/events{/privacy}","received_events_url":"https://api.github.com/users/waldekmastykarz/received_events","type":"User","site_admin":false},"milestone":null,"comments":0,"created_at":"2016-01-25T11:03:04Z","updated_at":"2016-01-25T11:03:04Z","closed_at":null,"body":"Previously use of jasmine-jquery loaded jQuery into the page for testing prior to loading Angular. Angular thus would use jQuery, not jqlite. Because the ngOfficeUiFabric doesn't not depend on jQuery, the tests should assume jQuery is not present. This fix changes the Karma configuration so it doesn't load jQuery before Angular, rather it loads after Angular. Dropped jasmine-jquery from karma frameworks, added to files instead. Added fix for PhantomJS.\r\n\r\nIn adding this change as part of #121 as a result from the discussion in #106, it caused one or more tests to fail in this directive. \r\n\r\n#### Please Note\r\n**Please fix these issues & submit a PR with the fix(es) to the branch** `jQueryTests`... please **do not** submit fixes to the `dev` branch.\r\n\r\nThe [TESTING.md](https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/jQueryTests/docs/guides/TESTING.md) doc within the `jQueryTests` branch demonstrates options for how to address this.\r\n\r\n**It's requested & appreciated that this take precedence over other work you are doing on the ngOfficeUiFabric.** Once all these tests are fixed we can merge the `jQueryTests` branch onto `dev` so we can get everything back to a good state going forward for new directives.\r\n"}}