{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/82343807","pull_request_review_id":3258537,"id":82343807,"diff_hunk":"@@ -1009,20 +1008,13 @@ public void testSingleValueFieldWithExtendedBoundsTimezone() throws Exception {\n \n         DateMathParser parser = new DateMathParser(Joda.getStrictStandardDateFormatter());\n \n-        final Callable<Long> callable = new Callable<Long>() {","path":"core/src/test/java/org/elasticsearch/search/aggregations/bucket/DateHistogramIT.java","position":12,"original_position":12,"commit_id":"bdc06fa7007611d3081244c07ef83113e23e867e","original_commit_id":"bdc06fa7007611d3081244c07ef83113e23e867e","user":{"login":"s1monw","id":973334,"avatar_url":"https://avatars.githubusercontent.com/u/973334?v=3","gravatar_id":"","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false},"body":"can we have a fake `now` here that is reproducible or do we need `System.currentTimeMillis()`?","created_at":"2016-10-07T07:57:09Z","updated_at":"2016-10-07T07:57:21Z","html_url":"https://github.com/elastic/elasticsearch/pull/20796#discussion_r82343807","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20796","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/82343807"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/20796#discussion_r82343807"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/20796"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20796","id":88394063,"html_url":"https://github.com/elastic/elasticsearch/pull/20796","diff_url":"https://github.com/elastic/elasticsearch/pull/20796.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/20796.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20796","number":20796,"state":"open","locked":false,"title":"Removes the now callable in the date math parser in favour of a LongSupplier","user":{"login":"colings86","id":236731,"avatar_url":"https://avatars.githubusercontent.com/u/236731?v=3","gravatar_id":"","url":"https://api.github.com/users/colings86","html_url":"https://github.com/colings86","followers_url":"https://api.github.com/users/colings86/followers","following_url":"https://api.github.com/users/colings86/following{/other_user}","gists_url":"https://api.github.com/users/colings86/gists{/gist_id}","starred_url":"https://api.github.com/users/colings86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colings86/subscriptions","organizations_url":"https://api.github.com/users/colings86/orgs","repos_url":"https://api.github.com/users/colings86/repos","events_url":"https://api.github.com/users/colings86/events{/privacy}","received_events_url":"https://api.github.com/users/colings86/received_events","type":"User","site_admin":false},"body":"Previous to this change the `DateMathParser` accepted a `Callable<Long>` to use for accessing the now value. The implementations of this callable would fall back on `System.currentTimeMillis()` if there was no context object provided. This is no longer necessary for two reasons:\r\n\r\n* We should not fall back to `System.currentTimeMillis()` as a context should always be provided. This ensures consistency between shards for the now value in all cases\r\n* We should use a LongSupplier rather than requiring an implementation of Callable<Long>. This means that we can just pass in `context::noInMillis` for this parameter and not have not implement anything.","created_at":"2016-10-07T07:48:38Z","updated_at":"2016-10-07T07:57:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf8107f499109bbb2db62cf7941666ff1bfe2968","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20796/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20796/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20796/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/bdc06fa7007611d3081244c07ef83113e23e867e","head":{"label":"colings86:refactor/removeNowCallables","ref":"refactor/removeNowCallables","sha":"bdc06fa7007611d3081244c07ef83113e23e867e","user":{"login":"colings86","id":236731,"avatar_url":"https://avatars.githubusercontent.com/u/236731?v=3","gravatar_id":"","url":"https://api.github.com/users/colings86","html_url":"https://github.com/colings86","followers_url":"https://api.github.com/users/colings86/followers","following_url":"https://api.github.com/users/colings86/following{/other_user}","gists_url":"https://api.github.com/users/colings86/gists{/gist_id}","starred_url":"https://api.github.com/users/colings86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colings86/subscriptions","organizations_url":"https://api.github.com/users/colings86/orgs","repos_url":"https://api.github.com/users/colings86/repos","events_url":"https://api.github.com/users/colings86/events{/privacy}","received_events_url":"https://api.github.com/users/colings86/received_events","type":"User","site_admin":false},"repo":{"id":19935914,"name":"elasticsearch","full_name":"colings86/elasticsearch","owner":{"login":"colings86","id":236731,"avatar_url":"https://avatars.githubusercontent.com/u/236731?v=3","gravatar_id":"","url":"https://api.github.com/users/colings86","html_url":"https://github.com/colings86","followers_url":"https://api.github.com/users/colings86/followers","following_url":"https://api.github.com/users/colings86/following{/other_user}","gists_url":"https://api.github.com/users/colings86/gists{/gist_id}","starred_url":"https://api.github.com/users/colings86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colings86/subscriptions","organizations_url":"https://api.github.com/users/colings86/orgs","repos_url":"https://api.github.com/users/colings86/repos","events_url":"https://api.github.com/users/colings86/events{/privacy}","received_events_url":"https://api.github.com/users/colings86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colings86/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/colings86/elasticsearch","forks_url":"https://api.github.com/repos/colings86/elasticsearch/forks","keys_url":"https://api.github.com/repos/colings86/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colings86/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colings86/elasticsearch/teams","hooks_url":"https://api.github.com/repos/colings86/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/colings86/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/colings86/elasticsearch/events","assignees_url":"https://api.github.com/repos/colings86/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/colings86/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/colings86/elasticsearch/tags","blobs_url":"https://api.github.com/repos/colings86/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colings86/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colings86/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/colings86/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colings86/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/colings86/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/colings86/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/colings86/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/colings86/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/colings86/elasticsearch/subscription","commits_url":"https://api.github.com/repos/colings86/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/colings86/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/colings86/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/colings86/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/colings86/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/colings86/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colings86/elasticsearch/merges","archive_url":"https://api.github.com/repos/colings86/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colings86/elasticsearch/downloads","issues_url":"https://api.github.com/repos/colings86/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/colings86/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/colings86/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/colings86/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colings86/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/colings86/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/colings86/elasticsearch/deployments","created_at":"2014-05-19T09:22:57Z","updated_at":"2016-05-11T13:27:13Z","pushed_at":"2016-10-07T07:27:07Z","git_url":"git://github.com/colings86/elasticsearch.git","ssh_url":"git@github.com:colings86/elasticsearch.git","clone_url":"https://github.com/colings86/elasticsearch.git","svn_url":"https://github.com/colings86/elasticsearch","homepage":"http://elasticsearch.org","size":204997,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"5d38248afa138d88a5db4c602b02fb27e6aaf3c4","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2016-10-07T06:05:15Z","pushed_at":"2016-10-07T07:48:39Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":357877,"stargazers_count":18709,"watchers_count":18709,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6377,"mirror_url":null,"open_issues_count":1123,"forks":6377,"open_issues":1123,"watchers":18709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/20796"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/20796"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/20796"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/20796/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/20796/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/20796/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/bdc06fa7007611d3081244c07ef83113e23e867e"}}}}
{"actor":{"display_login":"s1monw"}}