{"action":"created","issue":{"url":"https://api.github.com/repos/rstudio/rmarkdown/issues/827","repository_url":"https://api.github.com/repos/rstudio/rmarkdown","labels_url":"https://api.github.com/repos/rstudio/rmarkdown/issues/827/labels{/name}","comments_url":"https://api.github.com/repos/rstudio/rmarkdown/issues/827/comments","events_url":"https://api.github.com/repos/rstudio/rmarkdown/issues/827/events","html_url":"https://github.com/rstudio/rmarkdown/pull/827","id":181258504,"number":827,"title":"be more permissive of 'params' objects discovered","user":{"login":"kevinushey","id":1976582,"avatar_url":"https://avatars.githubusercontent.com/u/1976582?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinushey","html_url":"https://github.com/kevinushey","followers_url":"https://api.github.com/users/kevinushey/followers","following_url":"https://api.github.com/users/kevinushey/following{/other_user}","gists_url":"https://api.github.com/users/kevinushey/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinushey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinushey/subscriptions","organizations_url":"https://api.github.com/users/kevinushey/orgs","repos_url":"https://api.github.com/users/kevinushey/repos","events_url":"https://api.github.com/users/kevinushey/events{/privacy}","received_events_url":"https://api.github.com/users/kevinushey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-05T20:33:31Z","updated_at":"2016-10-05T20:39:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rstudio/rmarkdown/pulls/827","html_url":"https://github.com/rstudio/rmarkdown/pull/827","diff_url":"https://github.com/rstudio/rmarkdown/pull/827.diff","patch_url":"https://github.com/rstudio/rmarkdown/pull/827.patch"},"body":"This is part one of a fix for parameterized R Notebooks.\r\n\r\nAs part of the Notebook workflow, when parameters are discovered in the YAML header, we inject an object `params` into the global environment to ensure that it's available for code execution. However, this breaks subsequent renders, as `rmarkdown::render()` then detects a pre-existing `params` variable and bails.\r\n\r\nThe fix here is to permit `params` objects with class `knit_param` and `knit_param_list`, and ensure that RStudio injects the `params` object with that class. The `rmarkdown` package will then overwrite that variable as it is known to be 'safe' for overwriting during render.\r\n\r\nLet me know if this sounds reasonable or if you think there's an alternate solution we should consider here.\r\n\r\n(associated change on RStudio side, to be merged: https://github.com/rstudio/rstudio/commit/c8b0c6d786acd105e7858ee49d9a332e1738ca20)\r\n\r\ncc: @jjallaire, @jmcphers"},"comment":{"url":"https://api.github.com/repos/rstudio/rmarkdown/issues/comments/251792723","html_url":"https://github.com/rstudio/rmarkdown/pull/827#issuecomment-251792723","issue_url":"https://api.github.com/repos/rstudio/rmarkdown/issues/827","id":251792723,"user":{"login":"kevinushey","id":1976582,"avatar_url":"https://avatars.githubusercontent.com/u/1976582?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinushey","html_url":"https://github.com/kevinushey","followers_url":"https://api.github.com/users/kevinushey/followers","following_url":"https://api.github.com/users/kevinushey/following{/other_user}","gists_url":"https://api.github.com/users/kevinushey/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinushey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinushey/subscriptions","organizations_url":"https://api.github.com/users/kevinushey/orgs","repos_url":"https://api.github.com/users/kevinushey/repos","events_url":"https://api.github.com/users/kevinushey/events{/privacy}","received_events_url":"https://api.github.com/users/kevinushey/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T20:39:32Z","updated_at":"2016-10-05T20:39:32Z","body":"One more change to make -- the pre-existing `params` object is not restored post-render, so we should see if that's easy to fix."}}
{"actor":{"display_login":"kevinushey"}}