{"push_id":1170261393,"size":1,"distinct_size":1,"ref":"refs/heads/gh3521-text-bounding-box-fix","head":"7be8c1d9557738e47d887dc463de3e727f386476","before":"fee85b48ce3088ffaad3c5362612429cb35718f4","commits":[{"sha":"7be8c1d9557738e47d887dc463de3e727f386476","author":{"name":"Robert Knight","email":"d3a75f012596346a1e294e73943b7403ef1e26c3@gmail.com"},"message":"Fix the implementation of `isNodeInRange()`\n\nThis function failed to account for the case where the node was\ncontained by, but not equal to, the range's startContainer.\n\nIn new browsers we could just use `Range.isPointInRange()`. Since that\nis not available in IE 10/11, add an implementation adapted from\nBlink's `Range::isPointInRange()` C++ impl, minus support for the\n`offset` parameter.\n\nThis fixes an issue where the adder could fail to show up when making\ncertain selections because `getTextBoundingBoxes()` could incorrectly\nfail to find the text nodes within certan ranges.\n\nFixes #3521","distinct":true,"url":"https://api.github.com/repos/hypothesis/h/commits/7be8c1d9557738e47d887dc463de3e727f386476"}]}
{"actor":{"display_login":"robertknight"}}