{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/72241909","id":72241909,"diff_hunk":"@@ -1,11 +1,16 @@\n class ApplicationHelper::Button::VmStop < ApplicationHelper::Button::Basic\n   needs_record\n \n+  def calculate_properties\n+    super\n+    self['title'] = @record.is_available_now_error_message(:stop) if disabled?\n+  end\n+\n   def skip?\n     !@record.is_available?(:stop)\n   end\n \n-  def disable?\n-    @record.is_available_now_error_message(:stop)\n+  def disabled?\n+    !!@record.is_available_now_error_message(:stop)","path":"app/helpers/application_helper/button/vm_stop.rb","position":16,"original_position":16,"commit_id":"8a59652655f91c43c096a3b11ec8b6afa0a23609","original_commit_id":"8a59652655f91c43c096a3b11ec8b6afa0a23609","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"body":"it's going to be skipped anyway, isn't it?","created_at":"2016-07-26T12:49:54Z","updated_at":"2016-07-26T12:49:54Z","html_url":"https://github.com/ManageIQ/manageiq/pull/9964#discussion_r72241909","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9964","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/72241909"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9964#discussion_r72241909"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9964"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9964","id":78285947,"html_url":"https://github.com/ManageIQ/manageiq/pull/9964","diff_url":"https://github.com/ManageIQ/manageiq/pull/9964.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9964.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9964","number":9964,"state":"open","locked":false,"title":"Corrected passing string for disabled buttons","user":{"login":"romanblanco","id":1187051,"avatar_url":"https://avatars.githubusercontent.com/u/1187051?v=3","gravatar_id":"","url":"https://api.github.com/users/romanblanco","html_url":"https://github.com/romanblanco","followers_url":"https://api.github.com/users/romanblanco/followers","following_url":"https://api.github.com/users/romanblanco/following{/other_user}","gists_url":"https://api.github.com/users/romanblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/romanblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanblanco/subscriptions","organizations_url":"https://api.github.com/users/romanblanco/orgs","repos_url":"https://api.github.com/users/romanblanco/repos","events_url":"https://api.github.com/users/romanblanco/events{/privacy}","received_events_url":"https://api.github.com/users/romanblanco/received_events","type":"User","site_admin":false},"body":"Purpose or Intent\r\n-----------------\r\nCorrected passing string for disabled buttons for #9540.\r\n\r\nLinks\r\n-----\r\nissue introduced in:  #9540","created_at":"2016-07-21T09:41:20Z","updated_at":"2016-07-26T12:49:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10cda46fcfc7023c63d7f14676b4a534314ebdb8","assignee":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"assignees":[{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9964/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9964/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9964/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/8a59652655f91c43c096a3b11ec8b6afa0a23609","head":{"label":"romanblanco:toolbar_button_refactoring_vm","ref":"toolbar_button_refactoring_vm","sha":"8a59652655f91c43c096a3b11ec8b6afa0a23609","user":{"login":"romanblanco","id":1187051,"avatar_url":"https://avatars.githubusercontent.com/u/1187051?v=3","gravatar_id":"","url":"https://api.github.com/users/romanblanco","html_url":"https://github.com/romanblanco","followers_url":"https://api.github.com/users/romanblanco/followers","following_url":"https://api.github.com/users/romanblanco/following{/other_user}","gists_url":"https://api.github.com/users/romanblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/romanblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanblanco/subscriptions","organizations_url":"https://api.github.com/users/romanblanco/orgs","repos_url":"https://api.github.com/users/romanblanco/repos","events_url":"https://api.github.com/users/romanblanco/events{/privacy}","received_events_url":"https://api.github.com/users/romanblanco/received_events","type":"User","site_admin":false},"repo":{"id":22988082,"name":"manageiq","full_name":"romanblanco/manageiq","owner":{"login":"romanblanco","id":1187051,"avatar_url":"https://avatars.githubusercontent.com/u/1187051?v=3","gravatar_id":"","url":"https://api.github.com/users/romanblanco","html_url":"https://github.com/romanblanco","followers_url":"https://api.github.com/users/romanblanco/followers","following_url":"https://api.github.com/users/romanblanco/following{/other_user}","gists_url":"https://api.github.com/users/romanblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/romanblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanblanco/subscriptions","organizations_url":"https://api.github.com/users/romanblanco/orgs","repos_url":"https://api.github.com/users/romanblanco/repos","events_url":"https://api.github.com/users/romanblanco/events{/privacy}","received_events_url":"https://api.github.com/users/romanblanco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romanblanco/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/romanblanco/manageiq","forks_url":"https://api.github.com/repos/romanblanco/manageiq/forks","keys_url":"https://api.github.com/repos/romanblanco/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romanblanco/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romanblanco/manageiq/teams","hooks_url":"https://api.github.com/repos/romanblanco/manageiq/hooks","issue_events_url":"https://api.github.com/repos/romanblanco/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/romanblanco/manageiq/events","assignees_url":"https://api.github.com/repos/romanblanco/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/romanblanco/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/romanblanco/manageiq/tags","blobs_url":"https://api.github.com/repos/romanblanco/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romanblanco/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romanblanco/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/romanblanco/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romanblanco/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/romanblanco/manageiq/languages","stargazers_url":"https://api.github.com/repos/romanblanco/manageiq/stargazers","contributors_url":"https://api.github.com/repos/romanblanco/manageiq/contributors","subscribers_url":"https://api.github.com/repos/romanblanco/manageiq/subscribers","subscription_url":"https://api.github.com/repos/romanblanco/manageiq/subscription","commits_url":"https://api.github.com/repos/romanblanco/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/romanblanco/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/romanblanco/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/romanblanco/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/romanblanco/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/romanblanco/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romanblanco/manageiq/merges","archive_url":"https://api.github.com/repos/romanblanco/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romanblanco/manageiq/downloads","issues_url":"https://api.github.com/repos/romanblanco/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/romanblanco/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/romanblanco/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/romanblanco/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romanblanco/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/romanblanco/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/romanblanco/manageiq/deployments","created_at":"2014-08-15T11:50:57Z","updated_at":"2016-01-11T11:44:03Z","pushed_at":"2016-07-26T12:19:18Z","git_url":"git://github.com/romanblanco/manageiq.git","ssh_url":"git@github.com:romanblanco/manageiq.git","clone_url":"https://github.com/romanblanco/manageiq.git","svn_url":"https://github.com/romanblanco/manageiq","homepage":"manageiq.org","size":138499,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"35f118b4afb927212ffb51f749b30a2dec90fa2e","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-07-13T16:26:10Z","pushed_at":"2016-07-26T12:46:16Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":182296,"stargazers_count":299,"watchers_count":299,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":329,"mirror_url":null,"open_issues_count":747,"forks":329,"open_issues":747,"watchers":299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9964"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9964"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9964"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9964/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9964/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9964/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/8a59652655f91c43c096a3b11ec8b6afa0a23609"}}}}
{"actor":{"display_login":"martinpovolny"}}