{"action":"created","issue":{"url":"https://api.github.com/repos/libgit2/rugged/issues/619","repository_url":"https://api.github.com/repos/libgit2/rugged","labels_url":"https://api.github.com/repos/libgit2/rugged/issues/619/labels{/name}","comments_url":"https://api.github.com/repos/libgit2/rugged/issues/619/comments","events_url":"https://api.github.com/repos/libgit2/rugged/issues/619/events","html_url":"https://github.com/libgit2/rugged/pull/619","id":164520497,"number":619,"title":"Tag strings without a known encoding as ASCII-8BIT.","user":{"login":"arthurschreiber","id":2195,"avatar_url":"https://avatars.githubusercontent.com/u/2195?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurschreiber","html_url":"https://github.com/arthurschreiber","followers_url":"https://api.github.com/users/arthurschreiber/followers","following_url":"https://api.github.com/users/arthurschreiber/following{/other_user}","gists_url":"https://api.github.com/users/arthurschreiber/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurschreiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurschreiber/subscriptions","organizations_url":"https://api.github.com/users/arthurschreiber/orgs","repos_url":"https://api.github.com/users/arthurschreiber/repos","events_url":"https://api.github.com/users/arthurschreiber/events{/privacy}","received_events_url":"https://api.github.com/users/arthurschreiber/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-08T12:27:43Z","updated_at":"2016-07-11T13:44:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libgit2/rugged/pulls/619","html_url":"https://github.com/libgit2/rugged/pull/619","diff_url":"https://github.com/libgit2/rugged/pull/619.diff","patch_url":"https://github.com/libgit2/rugged/pull/619.patch"},"body":"Almost all of the string used inside a git repository are encoding unaware.\r\n\r\nThis includes things like refnames, commit metadata, path names, and a lot more. The exception is commit messages, which can optionally be tagged with an encoding through a header in the commit metadata. We should only tag strings with an encoding if we know the exact encoding, and otherwise tag them as ASCII 8-BIT (binary)."},"comment":{"url":"https://api.github.com/repos/libgit2/rugged/issues/comments/231738073","html_url":"https://github.com/libgit2/rugged/pull/619#issuecomment-231738073","issue_url":"https://api.github.com/repos/libgit2/rugged/issues/619","id":231738073,"user":{"login":"ethomson","id":1130014,"avatar_url":"https://avatars.githubusercontent.com/u/1130014?v=3","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":true},"created_at":"2016-07-11T13:44:23Z","updated_at":"2016-07-11T13:44:23Z","body":"> If you have different people that work on a repo, they might have set different encodings on their machines. I don't think that's too uncommon, especially for people working on windows. 😞\r\n\r\nOn Windows, at least, [NTFS stores filenames as UTF-16](https://msdn.microsoft.com/en-us/library/windows/desktop/dd317748%28v=vs.85%29.aspx) and there is, AFAIK, no way to use any other encoding.  This is fortunate, since the Windows Git implementations do an insane amount of UTF16 <-> UTF8 conversion to be able to talk to the Windows APIs, since they all speak UTF-16 (or UCS-2 in some cases.  Yay!)\r\n\r\nSimilarly, HFS+ will use a canonically decomposed UTF-16.\r\n\r\nI'm just providing data here, I still think that returning these as `ASCII-8BIT` probably still makes a lot of sense."}}
{"actor":{"display_login":"ethomson"}}