{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/86069892","pull_request_review_id":6746470,"id":86069892,"diff_hunk":"@@ -8,7 +8,7 @@ import (\n )\n \n func TestFilterByCapNeg(t *testing.T) {\n-\tp := v2.NewPlugin(\"test\", \"1234567890\", \"/run/docker\", \"latest\")\n+\tp := v2.NewPlugin(\"test\", \"1234567890\", \"/run/docker\", \"/var/run/docker/plugins/1234567890\", \"latest\")","path":"plugin/store/store_test.go","position":5,"original_position":5,"commit_id":"12950256398f972e5f4dfb4410f3328c9195f5cb","original_commit_id":"12950256398f972e5f4dfb4410f3328c9195f5cb","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"Having all these as positional arguments does make it hard to grasp. Guess this was decided on already, just notice it now","created_at":"2016-11-02T03:57:08Z","updated_at":"2016-11-02T03:57:08Z","html_url":"https://github.com/docker/docker/pull/27923#discussion_r86069892","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/27923","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/86069892"},"html":{"href":"https://github.com/docker/docker/pull/27923#discussion_r86069892"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/27923"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/27923","id":91716664,"html_url":"https://github.com/docker/docker/pull/27923","diff_url":"https://github.com/docker/docker/pull/27923.diff","patch_url":"https://github.com/docker/docker/pull/27923.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/27923","number":27923,"state":"open","locked":false,"title":"support env for docker plugin set","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"body":"The plugin `vieux/sshfs` was updated to support the evironment variable `DEBUG` to be set\r\n\r\n```json\r\n\t\"env\": [\r\n\t    {\r\n\t\t\"name\":\"DEBUG\",\r\n\t\t\"settable\":[\"value\"],\r\n\t\t\"value\":\"0\"\r\n\t    }\r\n\t]\r\n```\r\n\r\n\r\n---\r\n\r\nThis PR adds support for `docker plugin set vieux/sshfs DEBUG=1`\r\n\r\nping @anusha-ragunathan @tiborvass \r\n\r\nI'm not a big fan of the code I produced :/, feel free to comment! I added unit test.\r\nThe biggest ugliness is the code is how to update the env. It requires parsing it back from string array to key/value to detect if we should append to the env and update an existing variable.","created_at":"2016-11-01T00:41:25Z","updated_at":"2016-11-02T03:57:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b104f9e6ea504561819a49b113b574e60c509135","assignee":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"assignees":[{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":118,"closed_issues":542,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-11-02T03:43:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/27923/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/27923/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/27923/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/12950256398f972e5f4dfb4410f3328c9195f5cb","head":{"label":"vieux:plugin_set_gogogo","ref":"plugin_set_gogogo","sha":"12950256398f972e5f4dfb4410f3328c9195f5cb","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"repo":{"id":9343231,"name":"docker","full_name":"vieux/docker","owner":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vieux/docker","description":"Docker - the Linux container runtime","fork":true,"url":"https://api.github.com/repos/vieux/docker","forks_url":"https://api.github.com/repos/vieux/docker/forks","keys_url":"https://api.github.com/repos/vieux/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vieux/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vieux/docker/teams","hooks_url":"https://api.github.com/repos/vieux/docker/hooks","issue_events_url":"https://api.github.com/repos/vieux/docker/issues/events{/number}","events_url":"https://api.github.com/repos/vieux/docker/events","assignees_url":"https://api.github.com/repos/vieux/docker/assignees{/user}","branches_url":"https://api.github.com/repos/vieux/docker/branches{/branch}","tags_url":"https://api.github.com/repos/vieux/docker/tags","blobs_url":"https://api.github.com/repos/vieux/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vieux/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vieux/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vieux/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vieux/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/vieux/docker/languages","stargazers_url":"https://api.github.com/repos/vieux/docker/stargazers","contributors_url":"https://api.github.com/repos/vieux/docker/contributors","subscribers_url":"https://api.github.com/repos/vieux/docker/subscribers","subscription_url":"https://api.github.com/repos/vieux/docker/subscription","commits_url":"https://api.github.com/repos/vieux/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vieux/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vieux/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vieux/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vieux/docker/contents/{+path}","compare_url":"https://api.github.com/repos/vieux/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vieux/docker/merges","archive_url":"https://api.github.com/repos/vieux/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vieux/docker/downloads","issues_url":"https://api.github.com/repos/vieux/docker/issues{/number}","pulls_url":"https://api.github.com/repos/vieux/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/vieux/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/vieux/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vieux/docker/labels{/name}","releases_url":"https://api.github.com/repos/vieux/docker/releases{/id}","deployments_url":"https://api.github.com/repos/vieux/docker/deployments","created_at":"2013-04-10T09:57:14Z","updated_at":"2014-07-24T21:22:20Z","pushed_at":"2016-11-01T22:03:22Z","git_url":"git://github.com/vieux/docker.git","ssh_url":"git@github.com:vieux/docker.git","clone_url":"https://github.com/vieux/docker.git","svn_url":"https://github.com/vieux/docker","homepage":"http://docker.io","size":111591,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"bf16fa47b7fcf5133818cd12bab1c2f60ba8d363","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-11-02T03:54:20Z","pushed_at":"2016-11-02T03:43:51Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":217824,"stargazers_count":36495,"watchers_count":36495,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10760,"mirror_url":null,"open_issues_count":1886,"forks":10760,"open_issues":1886,"watchers":36495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/27923"},"html":{"href":"https://github.com/docker/docker/pull/27923"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/27923"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/27923/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/27923/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/27923/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/12950256398f972e5f4dfb4410f3328c9195f5cb"}}}}
{"actor":{"display_login":"thaJeztah"}}