{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/75565801","id":75565801,"diff_hunk":"@@ -94,5 +94,18 @@ public static void InvalidInputLength()\n             Assert.Throws<ArgumentOutOfRangeException>(() => Convert.ToBase64CharArray(inputBytes, 0, inputBytes.Length + 1, outputBuffer, 0));\n             Assert.Throws<ArgumentOutOfRangeException>(() => Convert.ToBase64CharArray(inputBytes, 1, inputBytes.Length, outputBuffer, 0));\n         }\n+\n+#if netstandard17","path":"src/System.Runtime.Extensions/tests/System/Convert.ToBase64CharArray.cs","position":5,"original_position":5,"commit_id":"49dce7c755579eb7bd3a7671dd3b04bbaca0e31f","original_commit_id":"49dce7c755579eb7bd3a7671dd3b04bbaca0e31f","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"Similarly for all the @ifdef Convert tests through these files. ","created_at":"2016-08-19T23:42:07Z","updated_at":"2016-08-19T23:42:07Z","html_url":"https://github.com/dotnet/corefx/pull/11007#discussion_r75565801","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/11007","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/75565801"},"html":{"href":"https://github.com/dotnet/corefx/pull/11007#discussion_r75565801"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11007"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/11007","id":82017288,"html_url":"https://github.com/dotnet/corefx/pull/11007","diff_url":"https://github.com/dotnet/corefx/pull/11007.diff","patch_url":"https://github.com/dotnet/corefx/pull/11007.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/11007","number":11007,"state":"open","locked":false,"title":"Fill Out Convert and Add Tests","user":{"login":"Lixire","id":13241824,"avatar_url":"https://avatars.githubusercontent.com/u/13241824?v=3","gravatar_id":"","url":"https://api.github.com/users/Lixire","html_url":"https://github.com/Lixire","followers_url":"https://api.github.com/users/Lixire/followers","following_url":"https://api.github.com/users/Lixire/following{/other_user}","gists_url":"https://api.github.com/users/Lixire/gists{/gist_id}","starred_url":"https://api.github.com/users/Lixire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lixire/subscriptions","organizations_url":"https://api.github.com/users/Lixire/orgs","repos_url":"https://api.github.com/users/Lixire/repos","events_url":"https://api.github.com/users/Lixire/events{/privacy}","received_events_url":"https://api.github.com/users/Lixire/received_events","type":"User","site_admin":false},"body":"Pertaining to issue #9328 \r\n- Exposed new members\r\n- Added new tests (Which run when using @weshaggard 's changes to the project.json and csproj file)\r\n\r\n@ellismg I wasn't sure whether to include your changes for intellisense or not\r\n\r\n@danmosemsft @joperezr ","created_at":"2016-08-19T17:35:55Z","updated_at":"2016-08-19T23:42:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8394755de0d3f27225cc9ea4f0e0a8e6ae1a56b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/11007/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/11007/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/11007/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/49dce7c755579eb7bd3a7671dd3b04bbaca0e31f","head":{"label":"Lixire:fill-convert","ref":"fill-convert","sha":"49dce7c755579eb7bd3a7671dd3b04bbaca0e31f","user":{"login":"Lixire","id":13241824,"avatar_url":"https://avatars.githubusercontent.com/u/13241824?v=3","gravatar_id":"","url":"https://api.github.com/users/Lixire","html_url":"https://github.com/Lixire","followers_url":"https://api.github.com/users/Lixire/followers","following_url":"https://api.github.com/users/Lixire/following{/other_user}","gists_url":"https://api.github.com/users/Lixire/gists{/gist_id}","starred_url":"https://api.github.com/users/Lixire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lixire/subscriptions","organizations_url":"https://api.github.com/users/Lixire/orgs","repos_url":"https://api.github.com/users/Lixire/repos","events_url":"https://api.github.com/users/Lixire/events{/privacy}","received_events_url":"https://api.github.com/users/Lixire/received_events","type":"User","site_admin":false},"repo":{"id":58956450,"name":"corefx","full_name":"Lixire/corefx","owner":{"login":"Lixire","id":13241824,"avatar_url":"https://avatars.githubusercontent.com/u/13241824?v=3","gravatar_id":"","url":"https://api.github.com/users/Lixire","html_url":"https://github.com/Lixire","followers_url":"https://api.github.com/users/Lixire/followers","following_url":"https://api.github.com/users/Lixire/following{/other_user}","gists_url":"https://api.github.com/users/Lixire/gists{/gist_id}","starred_url":"https://api.github.com/users/Lixire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lixire/subscriptions","organizations_url":"https://api.github.com/users/Lixire/orgs","repos_url":"https://api.github.com/users/Lixire/repos","events_url":"https://api.github.com/users/Lixire/events{/privacy}","received_events_url":"https://api.github.com/users/Lixire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lixire/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/Lixire/corefx","forks_url":"https://api.github.com/repos/Lixire/corefx/forks","keys_url":"https://api.github.com/repos/Lixire/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lixire/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lixire/corefx/teams","hooks_url":"https://api.github.com/repos/Lixire/corefx/hooks","issue_events_url":"https://api.github.com/repos/Lixire/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/Lixire/corefx/events","assignees_url":"https://api.github.com/repos/Lixire/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/Lixire/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/Lixire/corefx/tags","blobs_url":"https://api.github.com/repos/Lixire/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lixire/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lixire/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lixire/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lixire/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/Lixire/corefx/languages","stargazers_url":"https://api.github.com/repos/Lixire/corefx/stargazers","contributors_url":"https://api.github.com/repos/Lixire/corefx/contributors","subscribers_url":"https://api.github.com/repos/Lixire/corefx/subscribers","subscription_url":"https://api.github.com/repos/Lixire/corefx/subscription","commits_url":"https://api.github.com/repos/Lixire/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lixire/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lixire/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lixire/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lixire/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/Lixire/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lixire/corefx/merges","archive_url":"https://api.github.com/repos/Lixire/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lixire/corefx/downloads","issues_url":"https://api.github.com/repos/Lixire/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/Lixire/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/Lixire/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/Lixire/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lixire/corefx/labels{/name}","releases_url":"https://api.github.com/repos/Lixire/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/Lixire/corefx/deployments","created_at":"2016-05-16T18:24:27Z","updated_at":"2016-05-16T18:24:53Z","pushed_at":"2016-08-19T22:06:22Z","git_url":"git://github.com/Lixire/corefx.git","ssh_url":"git@github.com:Lixire/corefx.git","clone_url":"https://github.com/Lixire/corefx.git","svn_url":"https://github.com/Lixire/corefx","homepage":"http://dotnet.github.io/","size":89269,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev/api","ref":"dev/api","sha":"e66576aa8290714284848086259b6429d1ce9b54","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-08-19T20:39:17Z","pushed_at":"2016-08-19T23:39:09Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":129876,"stargazers_count":10399,"watchers_count":10399,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2554,"mirror_url":null,"open_issues_count":1377,"forks":2554,"open_issues":1377,"watchers":10399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11007"},"html":{"href":"https://github.com/dotnet/corefx/pull/11007"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/11007"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/11007/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11007/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11007/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/49dce7c755579eb7bd3a7671dd3b04bbaca0e31f"}}}}
{"actor":{"display_login":"weshaggard"}}