{"action":"closed","number":116,"pull_request":{"url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/pulls/116","id":88786649,"html_url":"https://github.com/hmrc/investment-tax-relief-submission-frontend/pull/116","diff_url":"https://github.com/hmrc/investment-tax-relief-submission-frontend/pull/116.diff","patch_url":"https://github.com/hmrc/investment-tax-relief-submission-frontend/pull/116.patch","issue_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/issues/116","number":116,"state":"closed","locked":false,"title":"Tavc 1329","user":{"login":"HarryGull","id":15017045,"avatar_url":"https://avatars.githubusercontent.com/u/15017045?v=3","gravatar_id":"","url":"https://api.github.com/users/HarryGull","html_url":"https://github.com/HarryGull","followers_url":"https://api.github.com/users/HarryGull/followers","following_url":"https://api.github.com/users/HarryGull/following{/other_user}","gists_url":"https://api.github.com/users/HarryGull/gists{/gist_id}","starred_url":"https://api.github.com/users/HarryGull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarryGull/subscriptions","organizations_url":"https://api.github.com/users/HarryGull/orgs","repos_url":"https://api.github.com/users/HarryGull/repos","events_url":"https://api.github.com/users/HarryGull/events{/privacy}","received_events_url":"https://api.github.com/users/HarryGull/received_events","type":"User","site_admin":false},"body":"Implemented Submission of Advanced Assurance.\r\nChanged the response types and methods to support the new mapping and submission.\r\nUpdated the Acknowledgement page.\r\nAdded helper functions and mappings for the whole AA.\r\n \r\nProvided mapping for the  whole TAVC Advanced Assurance including items not yet implemented.\r\n \r\nChanged  fields to have correct field length – e.g 10 year plan to 1024 instead of 2048\r\n \r\nFixed the error summary so it will display the field name for built in errors (e.g. does not just say “(0)  requires a number” as currently)\r\n \r\nSome items (see TODO) have been hard-coded to populate to test the mappings provided work.\r\nFor instance the addresses (company/correspondence)  are not yet captured at the frontend but will work if an the address type provided is used.\r\n \r\nValidation should ensure the data is in a consistent state in most cases but may need tweaking after new forms added.\r\nIf inconsistent the user is currently sent to the introduction page.\r\nIt would seem a good idea to let the user know why when we navigate away because of inconsistent data throughout the application.\r\nA preferred way might be to create a new page that takes a message and redirect url. This could be called to show the message to the user then redirect to the desired page.\r\n \r\n \r\n//TODO:\r\n 1) MostRecent year used in this function will be passed in (used to calculate period ending for costs and turnover)\r\n 2) Address Models (company and correspondence) will need passing in when properly implemented\r\n from ETMP lookup) to replace temp Addresses currently used\r\n 3) 5 years Annual turnover costs to be passed as list (or converted to list) when implemented - mapping in place already\r\n 4) company name required\r\n 5) subsidiary performing trade name is required if subsidiary and needs retrieving from somewhere.\r\n6) Provide a way of telling the user why they have been navigated away if data invalid (e.g. page skipping/url hacking) – see above\r\n \r\nTesters.\r\n10 year plan changed length\r\nAcknowledgement page has different filed names\r\nWhatwillUse has different posted filed names\r\n\r\n","created_at":"2016-10-11T07:58:29Z","updated_at":"2016-10-11T08:47:50Z","closed_at":"2016-10-11T08:47:50Z","merged_at":"2016-10-11T08:47:50Z","merge_commit_sha":"621579e223348d5735054d5fc70755c5d32cf0c5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/pulls/116/commits","review_comments_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/pulls/116/comments","review_comment_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/issues/116/comments","statuses_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/statuses/d1b1a92b75bb159e6e3c58a56bbadec46e5c0f9a","head":{"label":"hmrc:TAVC-1329","ref":"TAVC-1329","sha":"d1b1a92b75bb159e6e3c58a56bbadec46e5c0f9a","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":60769773,"name":"investment-tax-relief-submission-frontend","full_name":"hmrc/investment-tax-relief-submission-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/investment-tax-relief-submission-frontend","description":"","fork":false,"url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend","forks_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/deployments","created_at":"2016-06-09T11:29:28Z","updated_at":"2016-06-09T12:13:49Z","pushed_at":"2016-10-11T08:47:50Z","git_url":"git://github.com/hmrc/investment-tax-relief-submission-frontend.git","ssh_url":"git@github.com:hmrc/investment-tax-relief-submission-frontend.git","clone_url":"https://github.com/hmrc/investment-tax-relief-submission-frontend.git","svn_url":"https://github.com/hmrc/investment-tax-relief-submission-frontend","homepage":"","size":877,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"2a89b1409ca758bcffba70a1f27db05c67ea6811","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":60769773,"name":"investment-tax-relief-submission-frontend","full_name":"hmrc/investment-tax-relief-submission-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/investment-tax-relief-submission-frontend","description":"","fork":false,"url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend","forks_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/deployments","created_at":"2016-06-09T11:29:28Z","updated_at":"2016-06-09T12:13:49Z","pushed_at":"2016-10-11T08:47:50Z","git_url":"git://github.com/hmrc/investment-tax-relief-submission-frontend.git","ssh_url":"git@github.com:hmrc/investment-tax-relief-submission-frontend.git","clone_url":"https://github.com/hmrc/investment-tax-relief-submission-frontend.git","svn_url":"https://github.com/hmrc/investment-tax-relief-submission-frontend","homepage":"","size":877,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/pulls/116"},"html":{"href":"https://github.com/hmrc/investment-tax-relief-submission-frontend/pull/116"},"issue":{"href":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/issues/116"},"comments":{"href":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/investment-tax-relief-submission-frontend/statuses/d1b1a92b75bb159e6e3c58a56bbadec46e5c0f9a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"CoolName1993","id":14073903,"avatar_url":"https://avatars.githubusercontent.com/u/14073903?v=3","gravatar_id":"","url":"https://api.github.com/users/CoolName1993","html_url":"https://github.com/CoolName1993","followers_url":"https://api.github.com/users/CoolName1993/followers","following_url":"https://api.github.com/users/CoolName1993/following{/other_user}","gists_url":"https://api.github.com/users/CoolName1993/gists{/gist_id}","starred_url":"https://api.github.com/users/CoolName1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoolName1993/subscriptions","organizations_url":"https://api.github.com/users/CoolName1993/orgs","repos_url":"https://api.github.com/users/CoolName1993/repos","events_url":"https://api.github.com/users/CoolName1993/events{/privacy}","received_events_url":"https://api.github.com/users/CoolName1993/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":1565,"deletions":200,"changed_files":28}}
{"actor":{"display_login":"CoolName1993"}}