{"action":"created","comment":{"url":"https://api.github.com/repos/dropwizard/dropwizard/pulls/comments/92321492","pull_request_review_id":12834156,"id":92321492,"diff_hunk":"@@ -72,16 +75,21 @@ private CloseableLiquibase openLiquibase(final PooledDataSourceFactory dataSourc\n             throws SQLException, LiquibaseException {\n         final CloseableLiquibase liquibase;\n         final ManagedDataSource dataSource = dataSourceFactory.build(new MetricRegistry(), \"liquibase\");\n-\n+        final Database database = createDatabase(dataSource, namespace);\n         final String migrationsFile = namespace.getString(\"migrations-file\");\n         if (migrationsFile == null) {\n-            liquibase = new CloseableLiquibaseWithClassPathMigrationsFile(dataSource, migrationsFileName) {\n-            };\n+            liquibase = new CloseableLiquibaseWithClassPathMigrationsFile(dataSource, database, migrationsFileName);\n         } else {\n-            liquibase = new CloseableLiquibaseWithFileSystemMigrationsFile(dataSource, migrationsFile);\n+            liquibase = new CloseableLiquibaseWithFileSystemMigrationsFile(dataSource, database, migrationsFile);\n         }\n \n-        final Database database = liquibase.getDatabase();\n+        return liquibase;\n+    }\n+\n+    private Database createDatabase(ManagedDataSource dataSource, Namespace namespace) throws SQLException, LiquibaseException {","path":"dropwizard-migrations/src/main/java/io/dropwizard/migrations/AbstractLiquibaseCommand.java","position":30,"original_position":30,"commit_id":"f04e30254cbb870274ece152c14598c13d992e5d","original_commit_id":"f04e30254cbb870274ece152c14598c13d992e5d","user":{"login":"evnm","id":110020,"avatar_url":"https://avatars.githubusercontent.com/u/110020?v=3","gravatar_id":"","url":"https://api.github.com/users/evnm","html_url":"https://github.com/evnm","followers_url":"https://api.github.com/users/evnm/followers","following_url":"https://api.github.com/users/evnm/following{/other_user}","gists_url":"https://api.github.com/users/evnm/gists{/gist_id}","starred_url":"https://api.github.com/users/evnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evnm/subscriptions","organizations_url":"https://api.github.com/users/evnm/orgs","repos_url":"https://api.github.com/users/evnm/repos","events_url":"https://api.github.com/users/evnm/events{/privacy}","received_events_url":"https://api.github.com/users/evnm/received_events","type":"User","site_admin":false},"body":"Some of these new lines are very long. Let's break them up a bit:\r\n\r\n```\r\n    private Database createDatabase(\r\n        ManagedDataSource dataSource,\r\n        Namespace namespace\r\n    ) throws SQLException, LiquibaseException {\r\n```","created_at":"2016-12-14T04:39:25Z","updated_at":"2016-12-14T04:39:25Z","html_url":"https://github.com/dropwizard/dropwizard/pull/1859#discussion_r92321492","pull_request_url":"https://api.github.com/repos/dropwizard/dropwizard/pulls/1859","_links":{"self":{"href":"https://api.github.com/repos/dropwizard/dropwizard/pulls/comments/92321492"},"html":{"href":"https://github.com/dropwizard/dropwizard/pull/1859#discussion_r92321492"},"pull_request":{"href":"https://api.github.com/repos/dropwizard/dropwizard/pulls/1859"}}},"pull_request":{"url":"https://api.github.com/repos/dropwizard/dropwizard/pulls/1859","id":97607461,"html_url":"https://github.com/dropwizard/dropwizard/pull/1859","diff_url":"https://github.com/dropwizard/dropwizard/pull/1859.diff","patch_url":"https://github.com/dropwizard/dropwizard/pull/1859.patch","issue_url":"https://api.github.com/repos/dropwizard/dropwizard/issues/1859","number":1859,"state":"open","locked":false,"title":"Have the abstract command pass in the Database rather than Connection…","user":{"login":"nathklei","id":1010540,"avatar_url":"https://avatars.githubusercontent.com/u/1010540?v=3","gravatar_id":"","url":"https://api.github.com/users/nathklei","html_url":"https://github.com/nathklei","followers_url":"https://api.github.com/users/nathklei/followers","following_url":"https://api.github.com/users/nathklei/following{/other_user}","gists_url":"https://api.github.com/users/nathklei/gists{/gist_id}","starred_url":"https://api.github.com/users/nathklei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathklei/subscriptions","organizations_url":"https://api.github.com/users/nathklei/orgs","repos_url":"https://api.github.com/users/nathklei/repos","events_url":"https://api.github.com/users/nathklei/events{/privacy}","received_events_url":"https://api.github.com/users/nathklei/received_events","type":"User","site_admin":false},"body":"…, so that default schema / catalog can be provided before constructing Liquibase.\r\n\r\nThis is to address #1857","created_at":"2016-12-12T18:31:38Z","updated_at":"2016-12-14T04:41:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fa61c505d19ac2b4aa96288f824d88f9397bcb0","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dropwizard/dropwizard/milestones/15","html_url":"https://github.com/dropwizard/dropwizard/milestone/15","labels_url":"https://api.github.com/repos/dropwizard/dropwizard/milestones/15/labels","id":1807218,"number":15,"title":"1.1.0","description":"","creator":{"login":"nickbabcock","id":2106129,"avatar_url":"https://avatars.githubusercontent.com/u/2106129?v=3","gravatar_id":"","url":"https://api.github.com/users/nickbabcock","html_url":"https://github.com/nickbabcock","followers_url":"https://api.github.com/users/nickbabcock/followers","following_url":"https://api.github.com/users/nickbabcock/following{/other_user}","gists_url":"https://api.github.com/users/nickbabcock/gists{/gist_id}","starred_url":"https://api.github.com/users/nickbabcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickbabcock/subscriptions","organizations_url":"https://api.github.com/users/nickbabcock/orgs","repos_url":"https://api.github.com/users/nickbabcock/repos","events_url":"https://api.github.com/users/nickbabcock/events{/privacy}","received_events_url":"https://api.github.com/users/nickbabcock/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":88,"state":"open","created_at":"2016-06-03T13:45:41Z","updated_at":"2016-12-13T19:27:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dropwizard/dropwizard/pulls/1859/commits","review_comments_url":"https://api.github.com/repos/dropwizard/dropwizard/pulls/1859/comments","review_comment_url":"https://api.github.com/repos/dropwizard/dropwizard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dropwizard/dropwizard/issues/1859/comments","statuses_url":"https://api.github.com/repos/dropwizard/dropwizard/statuses/f04e30254cbb870274ece152c14598c13d992e5d","head":{"label":"nathklei:allow-default-schema-expansion","ref":"allow-default-schema-expansion","sha":"f04e30254cbb870274ece152c14598c13d992e5d","user":{"login":"nathklei","id":1010540,"avatar_url":"https://avatars.githubusercontent.com/u/1010540?v=3","gravatar_id":"","url":"https://api.github.com/users/nathklei","html_url":"https://github.com/nathklei","followers_url":"https://api.github.com/users/nathklei/followers","following_url":"https://api.github.com/users/nathklei/following{/other_user}","gists_url":"https://api.github.com/users/nathklei/gists{/gist_id}","starred_url":"https://api.github.com/users/nathklei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathklei/subscriptions","organizations_url":"https://api.github.com/users/nathklei/orgs","repos_url":"https://api.github.com/users/nathklei/repos","events_url":"https://api.github.com/users/nathklei/events{/privacy}","received_events_url":"https://api.github.com/users/nathklei/received_events","type":"User","site_admin":false},"repo":{"id":76282244,"name":"dropwizard","full_name":"nathklei/dropwizard","owner":{"login":"nathklei","id":1010540,"avatar_url":"https://avatars.githubusercontent.com/u/1010540?v=3","gravatar_id":"","url":"https://api.github.com/users/nathklei","html_url":"https://github.com/nathklei","followers_url":"https://api.github.com/users/nathklei/followers","following_url":"https://api.github.com/users/nathklei/following{/other_user}","gists_url":"https://api.github.com/users/nathklei/gists{/gist_id}","starred_url":"https://api.github.com/users/nathklei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathklei/subscriptions","organizations_url":"https://api.github.com/users/nathklei/orgs","repos_url":"https://api.github.com/users/nathklei/repos","events_url":"https://api.github.com/users/nathklei/events{/privacy}","received_events_url":"https://api.github.com/users/nathklei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathklei/dropwizard","description":"A damn simple library for building production-ready RESTful web services.","fork":true,"url":"https://api.github.com/repos/nathklei/dropwizard","forks_url":"https://api.github.com/repos/nathklei/dropwizard/forks","keys_url":"https://api.github.com/repos/nathklei/dropwizard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathklei/dropwizard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathklei/dropwizard/teams","hooks_url":"https://api.github.com/repos/nathklei/dropwizard/hooks","issue_events_url":"https://api.github.com/repos/nathklei/dropwizard/issues/events{/number}","events_url":"https://api.github.com/repos/nathklei/dropwizard/events","assignees_url":"https://api.github.com/repos/nathklei/dropwizard/assignees{/user}","branches_url":"https://api.github.com/repos/nathklei/dropwizard/branches{/branch}","tags_url":"https://api.github.com/repos/nathklei/dropwizard/tags","blobs_url":"https://api.github.com/repos/nathklei/dropwizard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathklei/dropwizard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathklei/dropwizard/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathklei/dropwizard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathklei/dropwizard/statuses/{sha}","languages_url":"https://api.github.com/repos/nathklei/dropwizard/languages","stargazers_url":"https://api.github.com/repos/nathklei/dropwizard/stargazers","contributors_url":"https://api.github.com/repos/nathklei/dropwizard/contributors","subscribers_url":"https://api.github.com/repos/nathklei/dropwizard/subscribers","subscription_url":"https://api.github.com/repos/nathklei/dropwizard/subscription","commits_url":"https://api.github.com/repos/nathklei/dropwizard/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathklei/dropwizard/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathklei/dropwizard/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathklei/dropwizard/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathklei/dropwizard/contents/{+path}","compare_url":"https://api.github.com/repos/nathklei/dropwizard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathklei/dropwizard/merges","archive_url":"https://api.github.com/repos/nathklei/dropwizard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathklei/dropwizard/downloads","issues_url":"https://api.github.com/repos/nathklei/dropwizard/issues{/number}","pulls_url":"https://api.github.com/repos/nathklei/dropwizard/pulls{/number}","milestones_url":"https://api.github.com/repos/nathklei/dropwizard/milestones{/number}","notifications_url":"https://api.github.com/repos/nathklei/dropwizard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathklei/dropwizard/labels{/name}","releases_url":"https://api.github.com/repos/nathklei/dropwizard/releases{/id}","deployments_url":"https://api.github.com/repos/nathklei/dropwizard/deployments","created_at":"2016-12-12T18:06:53Z","updated_at":"2016-12-12T18:06:57Z","pushed_at":"2016-12-13T23:54:12Z","git_url":"git://github.com/nathklei/dropwizard.git","ssh_url":"git@github.com:nathklei/dropwizard.git","clone_url":"https://github.com/nathklei/dropwizard.git","svn_url":"https://github.com/nathklei/dropwizard","homepage":"http://www.dropwizard.io","size":42532,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dropwizard:master","ref":"master","sha":"4905023b6b86f79fc14b742cf2b47a14cca7fec7","user":{"login":"dropwizard","id":5478557,"avatar_url":"https://avatars.githubusercontent.com/u/5478557?v=3","gravatar_id":"","url":"https://api.github.com/users/dropwizard","html_url":"https://github.com/dropwizard","followers_url":"https://api.github.com/users/dropwizard/followers","following_url":"https://api.github.com/users/dropwizard/following{/other_user}","gists_url":"https://api.github.com/users/dropwizard/gists{/gist_id}","starred_url":"https://api.github.com/users/dropwizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropwizard/subscriptions","organizations_url":"https://api.github.com/users/dropwizard/orgs","repos_url":"https://api.github.com/users/dropwizard/repos","events_url":"https://api.github.com/users/dropwizard/events{/privacy}","received_events_url":"https://api.github.com/users/dropwizard/received_events","type":"Organization","site_admin":false},"repo":{"id":1272129,"name":"dropwizard","full_name":"dropwizard/dropwizard","owner":{"login":"dropwizard","id":5478557,"avatar_url":"https://avatars.githubusercontent.com/u/5478557?v=3","gravatar_id":"","url":"https://api.github.com/users/dropwizard","html_url":"https://github.com/dropwizard","followers_url":"https://api.github.com/users/dropwizard/followers","following_url":"https://api.github.com/users/dropwizard/following{/other_user}","gists_url":"https://api.github.com/users/dropwizard/gists{/gist_id}","starred_url":"https://api.github.com/users/dropwizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropwizard/subscriptions","organizations_url":"https://api.github.com/users/dropwizard/orgs","repos_url":"https://api.github.com/users/dropwizard/repos","events_url":"https://api.github.com/users/dropwizard/events{/privacy}","received_events_url":"https://api.github.com/users/dropwizard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dropwizard/dropwizard","description":"A damn simple library for building production-ready RESTful web services.","fork":false,"url":"https://api.github.com/repos/dropwizard/dropwizard","forks_url":"https://api.github.com/repos/dropwizard/dropwizard/forks","keys_url":"https://api.github.com/repos/dropwizard/dropwizard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropwizard/dropwizard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropwizard/dropwizard/teams","hooks_url":"https://api.github.com/repos/dropwizard/dropwizard/hooks","issue_events_url":"https://api.github.com/repos/dropwizard/dropwizard/issues/events{/number}","events_url":"https://api.github.com/repos/dropwizard/dropwizard/events","assignees_url":"https://api.github.com/repos/dropwizard/dropwizard/assignees{/user}","branches_url":"https://api.github.com/repos/dropwizard/dropwizard/branches{/branch}","tags_url":"https://api.github.com/repos/dropwizard/dropwizard/tags","blobs_url":"https://api.github.com/repos/dropwizard/dropwizard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropwizard/dropwizard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropwizard/dropwizard/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropwizard/dropwizard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropwizard/dropwizard/statuses/{sha}","languages_url":"https://api.github.com/repos/dropwizard/dropwizard/languages","stargazers_url":"https://api.github.com/repos/dropwizard/dropwizard/stargazers","contributors_url":"https://api.github.com/repos/dropwizard/dropwizard/contributors","subscribers_url":"https://api.github.com/repos/dropwizard/dropwizard/subscribers","subscription_url":"https://api.github.com/repos/dropwizard/dropwizard/subscription","commits_url":"https://api.github.com/repos/dropwizard/dropwizard/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropwizard/dropwizard/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropwizard/dropwizard/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropwizard/dropwizard/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropwizard/dropwizard/contents/{+path}","compare_url":"https://api.github.com/repos/dropwizard/dropwizard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropwizard/dropwizard/merges","archive_url":"https://api.github.com/repos/dropwizard/dropwizard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropwizard/dropwizard/downloads","issues_url":"https://api.github.com/repos/dropwizard/dropwizard/issues{/number}","pulls_url":"https://api.github.com/repos/dropwizard/dropwizard/pulls{/number}","milestones_url":"https://api.github.com/repos/dropwizard/dropwizard/milestones{/number}","notifications_url":"https://api.github.com/repos/dropwizard/dropwizard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropwizard/dropwizard/labels{/name}","releases_url":"https://api.github.com/repos/dropwizard/dropwizard/releases{/id}","deployments_url":"https://api.github.com/repos/dropwizard/dropwizard/deployments","created_at":"2011-01-19T19:52:29Z","updated_at":"2016-12-14T02:12:01Z","pushed_at":"2016-12-13T23:54:13Z","git_url":"git://github.com/dropwizard/dropwizard.git","ssh_url":"git@github.com:dropwizard/dropwizard.git","clone_url":"https://github.com/dropwizard/dropwizard.git","svn_url":"https://github.com/dropwizard/dropwizard","homepage":"http://www.dropwizard.io","size":46773,"stargazers_count":5253,"watchers_count":5253,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2296,"mirror_url":null,"open_issues_count":76,"forks":2296,"open_issues":76,"watchers":5253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dropwizard/dropwizard/pulls/1859"},"html":{"href":"https://github.com/dropwizard/dropwizard/pull/1859"},"issue":{"href":"https://api.github.com/repos/dropwizard/dropwizard/issues/1859"},"comments":{"href":"https://api.github.com/repos/dropwizard/dropwizard/issues/1859/comments"},"review_comments":{"href":"https://api.github.com/repos/dropwizard/dropwizard/pulls/1859/comments"},"review_comment":{"href":"https://api.github.com/repos/dropwizard/dropwizard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dropwizard/dropwizard/pulls/1859/commits"},"statuses":{"href":"https://api.github.com/repos/dropwizard/dropwizard/statuses/f04e30254cbb870274ece152c14598c13d992e5d"}}}}
{"actor":{"display_login":"evnm"}}