{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/comments/65542603","id":65542603,"diff_hunk":"@@ -1062,13 +1042,12 @@ def unitNumberStore(id, event)\n     # @param [String] id string widget id\n     # @param [Hash] event map event that caused storing process\n     # @return [Symbol] always nil\n-    def browseButtonHandle(id, event)\n-      event = deep_copy(event)\n+    def browseButtonHandle(_id, _event)\n       current = Convert.to_string(UI.QueryWidget(Id(\"device\"), :Value))\n       current = \"/dev\" if current == \"\"\n       # popup header\n       current = UI.AskForExistingFile(current, \"\", _(\"Select the Device\"))\n-      UI.ChangeWidget(Id(\"device\"), :Value, current) if current != nil\n+      UI.ChangeWidget(Id(\"device\"), :Value, current) if !current.nil?","path":"src/include/ntp-client/widgets.rb","position":445,"original_position":445,"commit_id":"ec3de519b3da57ae4461747812a65f2917fce91f","original_commit_id":"ec3de519b3da57ae4461747812a65f2917fce91f","user":{"login":"imobach","id":15836,"avatar_url":"https://avatars.githubusercontent.com/u/15836?v=3","gravatar_id":"","url":"https://api.github.com/users/imobach","html_url":"https://github.com/imobach","followers_url":"https://api.github.com/users/imobach/followers","following_url":"https://api.github.com/users/imobach/following{/other_user}","gists_url":"https://api.github.com/users/imobach/gists{/gist_id}","starred_url":"https://api.github.com/users/imobach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imobach/subscriptions","organizations_url":"https://api.github.com/users/imobach/orgs","repos_url":"https://api.github.com/users/imobach/repos","events_url":"https://api.github.com/users/imobach/events{/privacy}","received_events_url":"https://api.github.com/users/imobach/received_events","type":"User","site_admin":false},"body":"Or you could use `unless current.nil?`","created_at":"2016-06-02T13:51:44Z","updated_at":"2016-06-02T13:51:44Z","html_url":"https://github.com/yast/yast-ntp-client/pull/57#discussion_r65542603","pull_request_url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/comments/65542603"},"html":{"href":"https://github.com/yast/yast-ntp-client/pull/57#discussion_r65542603"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/57","id":71195756,"html_url":"https://github.com/yast/yast-ntp-client/pull/57","diff_url":"https://github.com/yast/yast-ntp-client/pull/57.diff","patch_url":"https://github.com/yast/yast-ntp-client/pull/57.patch","issue_url":"https://api.github.com/repos/yast/yast-ntp-client/issues/57","number":57,"state":"open","locked":false,"title":"Check if server is not reachable (bsc#977610)","user":{"login":"teclator","id":7056681,"avatar_url":"https://avatars.githubusercontent.com/u/7056681?v=3","gravatar_id":"","url":"https://api.github.com/users/teclator","html_url":"https://github.com/teclator","followers_url":"https://api.github.com/users/teclator/followers","following_url":"https://api.github.com/users/teclator/following{/other_user}","gists_url":"https://api.github.com/users/teclator/gists{/gist_id}","starred_url":"https://api.github.com/users/teclator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teclator/subscriptions","organizations_url":"https://api.github.com/users/teclator/orgs","repos_url":"https://api.github.com/users/teclator/repos","events_url":"https://api.github.com/users/teclator/events{/privacy}","received_events_url":"https://api.github.com/users/teclator/received_events","type":"User","site_admin":false},"body":"It started from this PBI [trello card](https://trello.com/c/jUAYDPQD/891-sles12-sp2-p3-977610-yast2-ntp-client-configuration-returns-always-successful-message-for-test-public-ntp-server) and as consequence of [(bsc#977610)](https://bugzilla.suse.com/show_bug.cgi?id=977610), but some code is very old and not well tested.\r\n\r\nTaking this in account old testsuite tests have been replaced by Rspec ones and new methods are already tested, i have also enable rubocop and test coveralls.\r\n","created_at":"2016-05-24T10:30:50Z","updated_at":"2016-06-02T13:51:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0e8c98500c265e5ca8d54e1cd34ada6f24c022d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/57/commits","review_comments_url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/57/comments","review_comment_url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-ntp-client/issues/57/comments","statuses_url":"https://api.github.com/repos/yast/yast-ntp-client/statuses/ec3de519b3da57ae4461747812a65f2917fce91f","head":{"label":"teclator:lookup_error","ref":"lookup_error","sha":"ec3de519b3da57ae4461747812a65f2917fce91f","user":{"login":"teclator","id":7056681,"avatar_url":"https://avatars.githubusercontent.com/u/7056681?v=3","gravatar_id":"","url":"https://api.github.com/users/teclator","html_url":"https://github.com/teclator","followers_url":"https://api.github.com/users/teclator/followers","following_url":"https://api.github.com/users/teclator/following{/other_user}","gists_url":"https://api.github.com/users/teclator/gists{/gist_id}","starred_url":"https://api.github.com/users/teclator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teclator/subscriptions","organizations_url":"https://api.github.com/users/teclator/orgs","repos_url":"https://api.github.com/users/teclator/repos","events_url":"https://api.github.com/users/teclator/events{/privacy}","received_events_url":"https://api.github.com/users/teclator/received_events","type":"User","site_admin":false},"repo":{"id":55755713,"name":"yast-ntp-client","full_name":"teclator/yast-ntp-client","owner":{"login":"teclator","id":7056681,"avatar_url":"https://avatars.githubusercontent.com/u/7056681?v=3","gravatar_id":"","url":"https://api.github.com/users/teclator","html_url":"https://github.com/teclator","followers_url":"https://api.github.com/users/teclator/followers","following_url":"https://api.github.com/users/teclator/following{/other_user}","gists_url":"https://api.github.com/users/teclator/gists{/gist_id}","starred_url":"https://api.github.com/users/teclator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teclator/subscriptions","organizations_url":"https://api.github.com/users/teclator/orgs","repos_url":"https://api.github.com/users/teclator/repos","events_url":"https://api.github.com/users/teclator/events{/privacy}","received_events_url":"https://api.github.com/users/teclator/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teclator/yast-ntp-client","description":"YaST module ntp-client","fork":true,"url":"https://api.github.com/repos/teclator/yast-ntp-client","forks_url":"https://api.github.com/repos/teclator/yast-ntp-client/forks","keys_url":"https://api.github.com/repos/teclator/yast-ntp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teclator/yast-ntp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teclator/yast-ntp-client/teams","hooks_url":"https://api.github.com/repos/teclator/yast-ntp-client/hooks","issue_events_url":"https://api.github.com/repos/teclator/yast-ntp-client/issues/events{/number}","events_url":"https://api.github.com/repos/teclator/yast-ntp-client/events","assignees_url":"https://api.github.com/repos/teclator/yast-ntp-client/assignees{/user}","branches_url":"https://api.github.com/repos/teclator/yast-ntp-client/branches{/branch}","tags_url":"https://api.github.com/repos/teclator/yast-ntp-client/tags","blobs_url":"https://api.github.com/repos/teclator/yast-ntp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teclator/yast-ntp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teclator/yast-ntp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/teclator/yast-ntp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teclator/yast-ntp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/teclator/yast-ntp-client/languages","stargazers_url":"https://api.github.com/repos/teclator/yast-ntp-client/stargazers","contributors_url":"https://api.github.com/repos/teclator/yast-ntp-client/contributors","subscribers_url":"https://api.github.com/repos/teclator/yast-ntp-client/subscribers","subscription_url":"https://api.github.com/repos/teclator/yast-ntp-client/subscription","commits_url":"https://api.github.com/repos/teclator/yast-ntp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/teclator/yast-ntp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/teclator/yast-ntp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/teclator/yast-ntp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/teclator/yast-ntp-client/contents/{+path}","compare_url":"https://api.github.com/repos/teclator/yast-ntp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teclator/yast-ntp-client/merges","archive_url":"https://api.github.com/repos/teclator/yast-ntp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teclator/yast-ntp-client/downloads","issues_url":"https://api.github.com/repos/teclator/yast-ntp-client/issues{/number}","pulls_url":"https://api.github.com/repos/teclator/yast-ntp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/teclator/yast-ntp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/teclator/yast-ntp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teclator/yast-ntp-client/labels{/name}","releases_url":"https://api.github.com/repos/teclator/yast-ntp-client/releases{/id}","deployments_url":"https://api.github.com/repos/teclator/yast-ntp-client/deployments","created_at":"2016-04-08T06:26:50Z","updated_at":"2016-04-08T06:26:50Z","pushed_at":"2016-06-02T12:22:29Z","git_url":"git://github.com/teclator/yast-ntp-client.git","ssh_url":"git@github.com:teclator/yast-ntp-client.git","clone_url":"https://github.com/teclator/yast-ntp-client.git","svn_url":"https://github.com/teclator/yast-ntp-client","homepage":"http://en.opensuse.org/Portal:YaST","size":839,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"0210c556806a3000763fb3d819bb65594ce325fc","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368165,"name":"yast-ntp-client","full_name":"yast/yast-ntp-client","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-ntp-client","description":"YaST module ntp-client","fork":false,"url":"https://api.github.com/repos/yast/yast-ntp-client","forks_url":"https://api.github.com/repos/yast/yast-ntp-client/forks","keys_url":"https://api.github.com/repos/yast/yast-ntp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-ntp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-ntp-client/teams","hooks_url":"https://api.github.com/repos/yast/yast-ntp-client/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-ntp-client/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-ntp-client/events","assignees_url":"https://api.github.com/repos/yast/yast-ntp-client/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-ntp-client/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-ntp-client/tags","blobs_url":"https://api.github.com/repos/yast/yast-ntp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-ntp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-ntp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-ntp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-ntp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-ntp-client/languages","stargazers_url":"https://api.github.com/repos/yast/yast-ntp-client/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-ntp-client/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-ntp-client/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-ntp-client/subscription","commits_url":"https://api.github.com/repos/yast/yast-ntp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-ntp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-ntp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-ntp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-ntp-client/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-ntp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-ntp-client/merges","archive_url":"https://api.github.com/repos/yast/yast-ntp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-ntp-client/downloads","issues_url":"https://api.github.com/repos/yast/yast-ntp-client/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-ntp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-ntp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-ntp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-ntp-client/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-ntp-client/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-ntp-client/deployments","created_at":"2012-05-18T10:25:00Z","updated_at":"2016-02-18T10:01:50Z","pushed_at":"2016-06-02T12:22:29Z","git_url":"git://github.com/yast/yast-ntp-client.git","ssh_url":"git@github.com:yast/yast-ntp-client.git","clone_url":"https://github.com/yast/yast-ntp-client.git","svn_url":"https://github.com/yast/yast-ntp-client","homepage":"http://en.opensuse.org/Portal:YaST","size":831,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":1,"forks":14,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/57"},"html":{"href":"https://github.com/yast/yast-ntp-client/pull/57"},"issue":{"href":"https://api.github.com/repos/yast/yast-ntp-client/issues/57"},"comments":{"href":"https://api.github.com/repos/yast/yast-ntp-client/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-ntp-client/statuses/ec3de519b3da57ae4461747812a65f2917fce91f"}}}}
{"actor":{"display_login":"imobach"}}