{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/Shopify/active_utils/pulls/69","id":76190292,"html_url":"https://github.com/Shopify/active_utils/pull/69","diff_url":"https://github.com/Shopify/active_utils/pull/69.diff","patch_url":"https://github.com/Shopify/active_utils/pull/69.patch","issue_url":"https://api.github.com/repos/Shopify/active_utils/issues/69","number":69,"state":"closed","locked":false,"title":"Test for Rails 5 support","user":{"login":"jonathankwok","id":4521864,"avatar_url":"https://avatars.githubusercontent.com/u/4521864?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathankwok","html_url":"https://github.com/jonathankwok","followers_url":"https://api.github.com/users/jonathankwok/followers","following_url":"https://api.github.com/users/jonathankwok/following{/other_user}","gists_url":"https://api.github.com/users/jonathankwok/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathankwok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathankwok/subscriptions","organizations_url":"https://api.github.com/users/jonathankwok/orgs","repos_url":"https://api.github.com/users/jonathankwok/repos","events_url":"https://api.github.com/users/jonathankwok/events{/privacy}","received_events_url":"https://api.github.com/users/jonathankwok/received_events","type":"User","site_admin":false},"body":"There shouldn't be any Rails 5 compatibility issues, but this PR adds some tests to be certain. It also adds an upper version restriction on the ActiveSupport dependency so that we'll have to explicitly support it when the version goes up.\r\n\r\n@kmcphillips @wvanbergen ","created_at":"2016-07-04T17:48:06Z","updated_at":"2016-07-04T18:09:04Z","closed_at":"2016-07-04T18:09:03Z","merged_at":"2016-07-04T18:09:03Z","merge_commit_sha":"6bcec6e2ac3e8063997a619589634aac89eb9371","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/active_utils/pulls/69/commits","review_comments_url":"https://api.github.com/repos/Shopify/active_utils/pulls/69/comments","review_comment_url":"https://api.github.com/repos/Shopify/active_utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/active_utils/issues/69/comments","statuses_url":"https://api.github.com/repos/Shopify/active_utils/statuses/c65fe2b6f5166421a5e7023d515dd1228fed1695","head":{"label":"Shopify:activesupport-5","ref":"activesupport-5","sha":"c65fe2b6f5166421a5e7023d515dd1228fed1695","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":2230026,"name":"active_utils","full_name":"Shopify/active_utils","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/active_utils","description":"Active Utils extracts commonly used modules and classes used by Active Merchant, Active Shipping, and Active Fulfillment","fork":false,"url":"https://api.github.com/repos/Shopify/active_utils","forks_url":"https://api.github.com/repos/Shopify/active_utils/forks","keys_url":"https://api.github.com/repos/Shopify/active_utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/active_utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/active_utils/teams","hooks_url":"https://api.github.com/repos/Shopify/active_utils/hooks","issue_events_url":"https://api.github.com/repos/Shopify/active_utils/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/active_utils/events","assignees_url":"https://api.github.com/repos/Shopify/active_utils/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/active_utils/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/active_utils/tags","blobs_url":"https://api.github.com/repos/Shopify/active_utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/active_utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/active_utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/active_utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/active_utils/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/active_utils/languages","stargazers_url":"https://api.github.com/repos/Shopify/active_utils/stargazers","contributors_url":"https://api.github.com/repos/Shopify/active_utils/contributors","subscribers_url":"https://api.github.com/repos/Shopify/active_utils/subscribers","subscription_url":"https://api.github.com/repos/Shopify/active_utils/subscription","commits_url":"https://api.github.com/repos/Shopify/active_utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/active_utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/active_utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/active_utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/active_utils/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/active_utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/active_utils/merges","archive_url":"https://api.github.com/repos/Shopify/active_utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/active_utils/downloads","issues_url":"https://api.github.com/repos/Shopify/active_utils/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/active_utils/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/active_utils/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/active_utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/active_utils/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/active_utils/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/active_utils/deployments","created_at":"2011-08-18T19:50:14Z","updated_at":"2016-06-18T07:04:21Z","pushed_at":"2016-07-04T18:09:04Z","git_url":"git://github.com/Shopify/active_utils.git","ssh_url":"git@github.com:Shopify/active_utils.git","clone_url":"https://github.com/Shopify/active_utils.git","svn_url":"https://github.com/Shopify/active_utils","homepage":"http://shopify.github.io/active_utils","size":1113,"stargazers_count":45,"watchers_count":45,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":2,"forks":62,"open_issues":2,"watchers":45,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"71dc12abe1f0a3db589bbd1c5a78485977a197d9","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":2230026,"name":"active_utils","full_name":"Shopify/active_utils","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/active_utils","description":"Active Utils extracts commonly used modules and classes used by Active Merchant, Active Shipping, and Active Fulfillment","fork":false,"url":"https://api.github.com/repos/Shopify/active_utils","forks_url":"https://api.github.com/repos/Shopify/active_utils/forks","keys_url":"https://api.github.com/repos/Shopify/active_utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/active_utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/active_utils/teams","hooks_url":"https://api.github.com/repos/Shopify/active_utils/hooks","issue_events_url":"https://api.github.com/repos/Shopify/active_utils/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/active_utils/events","assignees_url":"https://api.github.com/repos/Shopify/active_utils/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/active_utils/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/active_utils/tags","blobs_url":"https://api.github.com/repos/Shopify/active_utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/active_utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/active_utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/active_utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/active_utils/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/active_utils/languages","stargazers_url":"https://api.github.com/repos/Shopify/active_utils/stargazers","contributors_url":"https://api.github.com/repos/Shopify/active_utils/contributors","subscribers_url":"https://api.github.com/repos/Shopify/active_utils/subscribers","subscription_url":"https://api.github.com/repos/Shopify/active_utils/subscription","commits_url":"https://api.github.com/repos/Shopify/active_utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/active_utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/active_utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/active_utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/active_utils/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/active_utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/active_utils/merges","archive_url":"https://api.github.com/repos/Shopify/active_utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/active_utils/downloads","issues_url":"https://api.github.com/repos/Shopify/active_utils/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/active_utils/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/active_utils/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/active_utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/active_utils/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/active_utils/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/active_utils/deployments","created_at":"2011-08-18T19:50:14Z","updated_at":"2016-06-18T07:04:21Z","pushed_at":"2016-07-04T18:09:04Z","git_url":"git://github.com/Shopify/active_utils.git","ssh_url":"git@github.com:Shopify/active_utils.git","clone_url":"https://github.com/Shopify/active_utils.git","svn_url":"https://github.com/Shopify/active_utils","homepage":"http://shopify.github.io/active_utils","size":1113,"stargazers_count":45,"watchers_count":45,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":2,"forks":62,"open_issues":2,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/active_utils/pulls/69"},"html":{"href":"https://github.com/Shopify/active_utils/pull/69"},"issue":{"href":"https://api.github.com/repos/Shopify/active_utils/issues/69"},"comments":{"href":"https://api.github.com/repos/Shopify/active_utils/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/active_utils/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/active_utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/active_utils/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/active_utils/statuses/c65fe2b6f5166421a5e7023d515dd1228fed1695"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jonathankwok","id":4521864,"avatar_url":"https://avatars.githubusercontent.com/u/4521864?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathankwok","html_url":"https://github.com/jonathankwok","followers_url":"https://api.github.com/users/jonathankwok/followers","following_url":"https://api.github.com/users/jonathankwok/following{/other_user}","gists_url":"https://api.github.com/users/jonathankwok/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathankwok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathankwok/subscriptions","organizations_url":"https://api.github.com/users/jonathankwok/orgs","repos_url":"https://api.github.com/users/jonathankwok/repos","events_url":"https://api.github.com/users/jonathankwok/events{/privacy}","received_events_url":"https://api.github.com/users/jonathankwok/received_events","type":"User","site_admin":false},"comments":2,"review_comments":5,"commits":1,"additions":16,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"jonathankwok"}}