{"action":"created","issue":{"url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/76","repository_url":"https://api.github.com/repos/Keno/Polynomials.jl","labels_url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/76/comments","events_url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/76/events","html_url":"https://github.com/Keno/Polynomials.jl/pull/76","id":192553897,"number":76,"title":"Cosmetic changes","user":{"login":"aytekinar","id":8845951,"avatar_url":"https://avatars.githubusercontent.com/u/8845951?v=3","gravatar_id":"","url":"https://api.github.com/users/aytekinar","html_url":"https://github.com/aytekinar","followers_url":"https://api.github.com/users/aytekinar/followers","following_url":"https://api.github.com/users/aytekinar/following{/other_user}","gists_url":"https://api.github.com/users/aytekinar/gists{/gist_id}","starred_url":"https://api.github.com/users/aytekinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aytekinar/subscriptions","organizations_url":"https://api.github.com/users/aytekinar/orgs","repos_url":"https://api.github.com/users/aytekinar/repos","events_url":"https://api.github.com/users/aytekinar/events{/privacy}","received_events_url":"https://api.github.com/users/aytekinar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-30T12:30:52Z","updated_at":"2016-11-30T17:13:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Keno/Polynomials.jl/pulls/76","html_url":"https://github.com/Keno/Polynomials.jl/pull/76","diff_url":"https://github.com/Keno/Polynomials.jl/pull/76.diff","patch_url":"https://github.com/Keno/Polynomials.jl/pull/76.patch"},"body":"Some cosmetic changes are made related to:\r\n\r\n- **Inner constructor.** Now, `Poly` is defined only for `SymbolLike`\r\n  objects, *i.e.*, `Char`, `AbstractString` and `Symbol`s,\r\n- **Poly from variables.** Since `Poly(\"x\")` could have resulted in\r\n  arguments related to what the default constructor should do (maybe a\r\n  default behaviour of constructing a `zero` polynomial with the given\r\n  variable is needed), I dropped my previous changes and extended\r\n  e29591d to include `SymbolLike` objects for `variable`. Also, an outer\r\n  constructor for `Number`s is added for convenience,\r\n  - [x] Fixes: #71.\r\n- **Version checks.** Dropped `VERSION >= v\"0.4\"` checks as the support\r\n  for v\"0.3\" has already been dropped,\r\n- **Base overloads.** Moved all implicitly overloaded base functions to\r\n  the import section on top.\r\n\r\nI hope you would agree with the changes."},"comment":{"url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/comments/263933896","html_url":"https://github.com/Keno/Polynomials.jl/pull/76#issuecomment-263933896","issue_url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/76","id":263933896,"user":{"login":"jverzani","id":421708,"avatar_url":"https://avatars.githubusercontent.com/u/421708?v=3","gravatar_id":"","url":"https://api.github.com/users/jverzani","html_url":"https://github.com/jverzani","followers_url":"https://api.github.com/users/jverzani/followers","following_url":"https://api.github.com/users/jverzani/following{/other_user}","gists_url":"https://api.github.com/users/jverzani/gists{/gist_id}","starred_url":"https://api.github.com/users/jverzani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverzani/subscriptions","organizations_url":"https://api.github.com/users/jverzani/orgs","repos_url":"https://api.github.com/users/jverzani/repos","events_url":"https://api.github.com/users/jverzani/events{/privacy}","received_events_url":"https://api.github.com/users/jverzani/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T17:13:51Z","updated_at":"2016-11-30T17:13:51Z","body":"I added a few comments, but overall this looks like a nice cleanup."}}
{"actor":{"display_login":"jverzani"}}