{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/76817945","id":76817945,"diff_hunk":"@@ -0,0 +1,171 @@\n+<!-- BEGIN MUNGE: UNVERSIONED_WARNING -->\n+\n+<!-- BEGIN STRIP_FOR_RELEASE -->\n+\n+<img src=\"http://kubernetes.io/kubernetes/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/kubernetes/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/kubernetes/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/kubernetes/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/kubernetes/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+\n+<h2>PLEASE NOTE: This document applies to the HEAD of the source tree</h2>\n+\n+If you are using a released version of Kubernetes, you should\n+refer to the docs that go with that version.\n+\n+Documentation for other releases can be found at\n+[releases.k8s.io](http://releases.k8s.io).\n+</strong>\n+--\n+\n+<!-- END STRIP_FOR_RELEASE -->\n+\n+<!-- END MUNGE: UNVERSIONED_WARNING -->\n+\n+# ConfigMap management\n+\n+## Abstract\n+\n+A proposal for implementing management of ConfigMaps in the context of a\n+[Deployment](http://kubernetes.io/docs/user-guide/deployments/).\n+\n+Users should be able to have their apps automatically pick up changes to\n+their configuration and also have the ability to rollback to previous\n+configuration similar to the ability to rollback to previous pod template\n+revisions.\n+\n+Currently, in order to apply updated configuration into a running app, users\n+need to 1) either do it manually: copy the ConfigMap that holds their old\n+behavior, update it, store it back as a different ConfigMap, and mount the\n+new ConfigMap into the Deployment, or 2) edit the original ConfigMap and\n+trigger the deployment controller to start a new ReplicaSet (either by\n+adding a dummy environment value in the pod template of the Deployment or\n+by including the update as part of another update) losing the ability to\n+rollback to previous configuration.\n+\n+This doc proposes a solution for removing the burden of ConfigMap management\n+from users by providing a mechanism that will work out of the box without\n+having to manually rollout new ReplicaSets.\n+\n+## Implementation\n+\n+### Proposed solution\n+\n+Users should only ever need to create and update a single ConfigMap \"foo\".\n+\n+```sh\n+$ kubectl create configmap foo --from-file=config.yml\n+configmap \"foo\" created\n+```\n+\n+We need a way to link \"foo\" to an owner. Owner references in ConfigMaps\n+should enable their management. ConfigMaps without owner references will\n+continue to work as expected today.\n+\n+```sh\n+$ kubectl set owner configmap/foo deployment/bar\n+configmap \"foo\" updated\n+```\n+\n+The ConfigMap needs to be mounted as a volume in the Deployment it references as an owner.\n+\n+```sh\n+$ kubectl set volume deployment/bar -t configmap --configmapname foo\n+deployment \"bar\" updated\n+```\n+\n+A new controller needs to watch for Deployments and ConfigMaps. Whenever it\n+spots a Deployment with a mounted ConfigMap that has an owner reference\n+pointing back to the Deployment, it will create a copy of the ConfigMap, \n+remove the original owner reference, and mount the copy in the owner. It \n+should generally track ConfigMaps with owner references to Deployments, \n+create new copies on updates, and mount them back in the owner. The only ","path":"docs/proposals/configmap-rollout.md","position":87,"original_position":87,"commit_id":"ee95bd578a66afa9de3902e03419449d6a016620","original_commit_id":"ee95bd578a66afa9de3902e03419449d6a016620","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"I see, the user writes to the original configmap, and the controller creates copies of the original for mounting.","created_at":"2016-08-30T15:24:04Z","updated_at":"2016-08-30T15:24:04Z","html_url":"https://github.com/kubernetes/kubernetes/pull/31701#discussion_r76817945","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31701","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/76817945"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/31701#discussion_r76817945"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31701"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31701","id":83281868,"html_url":"https://github.com/kubernetes/kubernetes/pull/31701","diff_url":"https://github.com/kubernetes/kubernetes/pull/31701.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/31701.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31701","number":31701,"state":"open","locked":false,"title":"docs: add proposal for ConfigMap management","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"A proposal for https://github.com/kubernetes/kubernetes/issues/22368\r\n\r\n@kubernetes/deployment @kubernetes/sig-apps\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/31701)\n<!-- Reviewable:end -->\n","created_at":"2016-08-30T14:27:57Z","updated_at":"2016-08-30T15:24:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b70b8d525c8ad8a023ebfd85a9252466c6e07198","assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31701/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31701/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31701/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ee95bd578a66afa9de3902e03419449d6a016620","head":{"label":"kargakis:configmap-rollout-proposal","ref":"configmap-rollout-proposal","sha":"ee95bd578a66afa9de3902e03419449d6a016620","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"repo":{"id":33254730,"name":"kubernetes","full_name":"kargakis/kubernetes","owner":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kargakis/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/kargakis/kubernetes","forks_url":"https://api.github.com/repos/kargakis/kubernetes/forks","keys_url":"https://api.github.com/repos/kargakis/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kargakis/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kargakis/kubernetes/teams","hooks_url":"https://api.github.com/repos/kargakis/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kargakis/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kargakis/kubernetes/events","assignees_url":"https://api.github.com/repos/kargakis/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kargakis/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kargakis/kubernetes/tags","blobs_url":"https://api.github.com/repos/kargakis/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kargakis/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kargakis/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kargakis/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kargakis/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kargakis/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kargakis/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kargakis/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kargakis/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kargakis/kubernetes/subscription","commits_url":"https://api.github.com/repos/kargakis/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kargakis/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kargakis/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kargakis/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kargakis/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kargakis/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kargakis/kubernetes/merges","archive_url":"https://api.github.com/repos/kargakis/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kargakis/kubernetes/downloads","issues_url":"https://api.github.com/repos/kargakis/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kargakis/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kargakis/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kargakis/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kargakis/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kargakis/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kargakis/kubernetes/deployments","created_at":"2015-04-01T15:11:37Z","updated_at":"2016-01-12T10:44:51Z","pushed_at":"2016-08-30T14:50:15Z","git_url":"git://github.com/kargakis/kubernetes.git","ssh_url":"git@github.com:kargakis/kubernetes.git","clone_url":"https://github.com/kargakis/kubernetes.git","svn_url":"https://github.com/kargakis/kubernetes","homepage":"http://kubernetes.io","size":316369,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3ccb99d87d74a90053e1e14eb906ae036337bb98","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-30T15:13:15Z","pushed_at":"2016-08-30T15:23:27Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":552978,"stargazers_count":16412,"watchers_count":16412,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5295,"mirror_url":null,"open_issues_count":4331,"forks":5295,"open_issues":4331,"watchers":16412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31701"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/31701"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/31701"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/31701/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31701/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31701/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ee95bd578a66afa9de3902e03419449d6a016620"}}}}
{"actor":{"display_login":"liggitt"}}