{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/severb/graypy/pulls/33","id":6149360,"html_url":"https://github.com/severb/graypy/pull/33","diff_url":"https://github.com/severb/graypy/pull/33.diff","patch_url":"https://github.com/severb/graypy/pull/33.patch","issue_url":"https://api.github.com/repos/severb/graypy/issues/33","number":33,"state":"closed","locked":false,"title":"makePickle calls the formatter before compression","user":{"login":"diezguerra","id":751169,"avatar_url":"https://avatars.githubusercontent.com/u/751169?v=3","gravatar_id":"","url":"https://api.github.com/users/diezguerra","html_url":"https://github.com/diezguerra","followers_url":"https://api.github.com/users/diezguerra/followers","following_url":"https://api.github.com/users/diezguerra/following{/other_user}","gists_url":"https://api.github.com/users/diezguerra/gists{/gist_id}","starred_url":"https://api.github.com/users/diezguerra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diezguerra/subscriptions","organizations_url":"https://api.github.com/users/diezguerra/orgs","repos_url":"https://api.github.com/users/diezguerra/repos","events_url":"https://api.github.com/users/diezguerra/events{/privacy}","received_events_url":"https://api.github.com/users/diezguerra/received_events","type":"User","site_admin":false},"body":"I am creating streams in Graylog using regexes by parsing a token at the begging of the message, which is added via a simple formatter.\r\n\r\nAfter a close look at the python logging library source code, my conclusion is that  DatagramHandler doesn't use formatters cause it is extends from SocketHandler and overrides it's makePickle without calling format like its super. I assume DatagramHandler is meant for low level use cases where formatting is not needed (?), or maybe because of serializing problems.\r\n\r\nIn any case, there is no reason, as far as I know, why Graylog couldn't receive formatted messages, and thus I've added it to makePickle again.\r\n\r\nCheers.","created_at":"2013-06-06T01:45:21Z","updated_at":"2016-05-24T18:40:14Z","closed_at":"2016-05-24T18:40:14Z","merged_at":null,"merge_commit_sha":"eb4e375ef5d20330f267bde03b8cbaaf66c8fa3b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/severb/graypy/pulls/33/commits","review_comments_url":"https://api.github.com/repos/severb/graypy/pulls/33/comments","review_comment_url":"https://api.github.com/repos/severb/graypy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/severb/graypy/issues/33/comments","statuses_url":"https://api.github.com/repos/severb/graypy/statuses/7a5aaf7dc22ec0ac59f5eeafeace5730a73328df","head":{"label":"diezguerra:feature/formatter","ref":"feature/formatter","sha":"7a5aaf7dc22ec0ac59f5eeafeace5730a73328df","user":{"login":"diezguerra","id":751169,"avatar_url":"https://avatars.githubusercontent.com/u/751169?v=3","gravatar_id":"","url":"https://api.github.com/users/diezguerra","html_url":"https://github.com/diezguerra","followers_url":"https://api.github.com/users/diezguerra/followers","following_url":"https://api.github.com/users/diezguerra/following{/other_user}","gists_url":"https://api.github.com/users/diezguerra/gists{/gist_id}","starred_url":"https://api.github.com/users/diezguerra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diezguerra/subscriptions","organizations_url":"https://api.github.com/users/diezguerra/orgs","repos_url":"https://api.github.com/users/diezguerra/repos","events_url":"https://api.github.com/users/diezguerra/events{/privacy}","received_events_url":"https://api.github.com/users/diezguerra/received_events","type":"User","site_admin":false},"repo":{"id":10515952,"name":"graypy","full_name":"diezguerra/graypy","owner":{"login":"diezguerra","id":751169,"avatar_url":"https://avatars.githubusercontent.com/u/751169?v=3","gravatar_id":"","url":"https://api.github.com/users/diezguerra","html_url":"https://github.com/diezguerra","followers_url":"https://api.github.com/users/diezguerra/followers","following_url":"https://api.github.com/users/diezguerra/following{/other_user}","gists_url":"https://api.github.com/users/diezguerra/gists{/gist_id}","starred_url":"https://api.github.com/users/diezguerra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diezguerra/subscriptions","organizations_url":"https://api.github.com/users/diezguerra/orgs","repos_url":"https://api.github.com/users/diezguerra/repos","events_url":"https://api.github.com/users/diezguerra/events{/privacy}","received_events_url":"https://api.github.com/users/diezguerra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diezguerra/graypy","description":"Python logging handler for Graylog2 that sends messages in GELF (Graylog Extended Log Format).","fork":true,"url":"https://api.github.com/repos/diezguerra/graypy","forks_url":"https://api.github.com/repos/diezguerra/graypy/forks","keys_url":"https://api.github.com/repos/diezguerra/graypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diezguerra/graypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diezguerra/graypy/teams","hooks_url":"https://api.github.com/repos/diezguerra/graypy/hooks","issue_events_url":"https://api.github.com/repos/diezguerra/graypy/issues/events{/number}","events_url":"https://api.github.com/repos/diezguerra/graypy/events","assignees_url":"https://api.github.com/repos/diezguerra/graypy/assignees{/user}","branches_url":"https://api.github.com/repos/diezguerra/graypy/branches{/branch}","tags_url":"https://api.github.com/repos/diezguerra/graypy/tags","blobs_url":"https://api.github.com/repos/diezguerra/graypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diezguerra/graypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diezguerra/graypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/diezguerra/graypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diezguerra/graypy/statuses/{sha}","languages_url":"https://api.github.com/repos/diezguerra/graypy/languages","stargazers_url":"https://api.github.com/repos/diezguerra/graypy/stargazers","contributors_url":"https://api.github.com/repos/diezguerra/graypy/contributors","subscribers_url":"https://api.github.com/repos/diezguerra/graypy/subscribers","subscription_url":"https://api.github.com/repos/diezguerra/graypy/subscription","commits_url":"https://api.github.com/repos/diezguerra/graypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/diezguerra/graypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/diezguerra/graypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/diezguerra/graypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/diezguerra/graypy/contents/{+path}","compare_url":"https://api.github.com/repos/diezguerra/graypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diezguerra/graypy/merges","archive_url":"https://api.github.com/repos/diezguerra/graypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diezguerra/graypy/downloads","issues_url":"https://api.github.com/repos/diezguerra/graypy/issues{/number}","pulls_url":"https://api.github.com/repos/diezguerra/graypy/pulls{/number}","milestones_url":"https://api.github.com/repos/diezguerra/graypy/milestones{/number}","notifications_url":"https://api.github.com/repos/diezguerra/graypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diezguerra/graypy/labels{/name}","releases_url":"https://api.github.com/repos/diezguerra/graypy/releases{/id}","deployments_url":"https://api.github.com/repos/diezguerra/graypy/deployments","created_at":"2013-06-06T00:47:39Z","updated_at":"2013-11-21T03:41:14Z","pushed_at":"2013-06-06T01:11:30Z","git_url":"git://github.com/diezguerra/graypy.git","ssh_url":"git@github.com:diezguerra/graypy.git","clone_url":"https://github.com/diezguerra/graypy.git","svn_url":"https://github.com/diezguerra/graypy","homepage":"http://graylog2.org/","size":137,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"severb:master","ref":"master","sha":"181c8b280d68b4142b8610aa40ea2112e52abaed","user":{"login":"severb","id":125867,"avatar_url":"https://avatars.githubusercontent.com/u/125867?v=3","gravatar_id":"","url":"https://api.github.com/users/severb","html_url":"https://github.com/severb","followers_url":"https://api.github.com/users/severb/followers","following_url":"https://api.github.com/users/severb/following{/other_user}","gists_url":"https://api.github.com/users/severb/gists{/gist_id}","starred_url":"https://api.github.com/users/severb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/severb/subscriptions","organizations_url":"https://api.github.com/users/severb/orgs","repos_url":"https://api.github.com/users/severb/repos","events_url":"https://api.github.com/users/severb/events{/privacy}","received_events_url":"https://api.github.com/users/severb/received_events","type":"User","site_admin":false},"repo":{"id":1417372,"name":"graypy","full_name":"severb/graypy","owner":{"login":"severb","id":125867,"avatar_url":"https://avatars.githubusercontent.com/u/125867?v=3","gravatar_id":"","url":"https://api.github.com/users/severb","html_url":"https://github.com/severb","followers_url":"https://api.github.com/users/severb/followers","following_url":"https://api.github.com/users/severb/following{/other_user}","gists_url":"https://api.github.com/users/severb/gists{/gist_id}","starred_url":"https://api.github.com/users/severb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/severb/subscriptions","organizations_url":"https://api.github.com/users/severb/orgs","repos_url":"https://api.github.com/users/severb/repos","events_url":"https://api.github.com/users/severb/events{/privacy}","received_events_url":"https://api.github.com/users/severb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/severb/graypy","description":"Python logging handler for Graylog2 that sends messages in GELF (Graylog Extended Log Format).","fork":false,"url":"https://api.github.com/repos/severb/graypy","forks_url":"https://api.github.com/repos/severb/graypy/forks","keys_url":"https://api.github.com/repos/severb/graypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/severb/graypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/severb/graypy/teams","hooks_url":"https://api.github.com/repos/severb/graypy/hooks","issue_events_url":"https://api.github.com/repos/severb/graypy/issues/events{/number}","events_url":"https://api.github.com/repos/severb/graypy/events","assignees_url":"https://api.github.com/repos/severb/graypy/assignees{/user}","branches_url":"https://api.github.com/repos/severb/graypy/branches{/branch}","tags_url":"https://api.github.com/repos/severb/graypy/tags","blobs_url":"https://api.github.com/repos/severb/graypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/severb/graypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/severb/graypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/severb/graypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/severb/graypy/statuses/{sha}","languages_url":"https://api.github.com/repos/severb/graypy/languages","stargazers_url":"https://api.github.com/repos/severb/graypy/stargazers","contributors_url":"https://api.github.com/repos/severb/graypy/contributors","subscribers_url":"https://api.github.com/repos/severb/graypy/subscribers","subscription_url":"https://api.github.com/repos/severb/graypy/subscription","commits_url":"https://api.github.com/repos/severb/graypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/severb/graypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/severb/graypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/severb/graypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/severb/graypy/contents/{+path}","compare_url":"https://api.github.com/repos/severb/graypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/severb/graypy/merges","archive_url":"https://api.github.com/repos/severb/graypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/severb/graypy/downloads","issues_url":"https://api.github.com/repos/severb/graypy/issues{/number}","pulls_url":"https://api.github.com/repos/severb/graypy/pulls{/number}","milestones_url":"https://api.github.com/repos/severb/graypy/milestones{/number}","notifications_url":"https://api.github.com/repos/severb/graypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/severb/graypy/labels{/name}","releases_url":"https://api.github.com/repos/severb/graypy/releases{/id}","deployments_url":"https://api.github.com/repos/severb/graypy/deployments","created_at":"2011-02-27T09:02:02Z","updated_at":"2016-05-19T08:42:31Z","pushed_at":"2016-05-16T16:06:59Z","git_url":"git://github.com/severb/graypy.git","ssh_url":"git@github.com:severb/graypy.git","clone_url":"https://github.com/severb/graypy.git","svn_url":"https://github.com/severb/graypy","homepage":"http://graylog2.org/","size":85,"stargazers_count":79,"watchers_count":79,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":7,"forks":42,"open_issues":7,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/severb/graypy/pulls/33"},"html":{"href":"https://github.com/severb/graypy/pull/33"},"issue":{"href":"https://api.github.com/repos/severb/graypy/issues/33"},"comments":{"href":"https://api.github.com/repos/severb/graypy/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/severb/graypy/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/severb/graypy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/severb/graypy/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/severb/graypy/statuses/7a5aaf7dc22ec0ac59f5eeafeace5730a73328df"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"diezguerra"}}