{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/65250839","id":65250839,"diff_hunk":"@@ -0,0 +1,455 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.flink.streaming.connectors.rabbitmq.common;\n+\n+import com.google.common.base.Preconditions;\n+import com.rabbitmq.client.ConnectionFactory;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import java.io.Serializable;\n+\n+/**\n+ * Connection Configuration for RMQ.\n+ * If {@link Builder#setUri(String)} has been set then {@link RMQConnectionConfig#RMQConnectionConfig(String, int, boolean, boolean, int, int, int, int)}\n+ * will be used for initialize the RMQ connection or\n+ * {@link RMQConnectionConfig#RMQConnectionConfig(String, int, String, String, String, int, boolean, boolean, int, int, int, int)}\n+ * will be used for initialize the RMQ connection\n+ */\n+public class RMQConnectionConfig implements Serializable {\n+\n+\tprivate static final long serialVersionUID = 1L;\n+\n+\tprivate static final Logger LOG = LoggerFactory.getLogger(RMQConnectionConfig.class);\n+\n+\tprivate String host;\n+\tprivate int port;\n+\tprivate String virtualHost;\n+\tprivate String username;\n+\tprivate String password;\n+\tprivate String uri;\n+\n+\tprivate int networkRecoveryInterval;\n+\tprivate boolean automaticRecovery;\n+\tprivate boolean topologyRecovery;\n+\n+\tprivate int connectionTimeout;\n+\tprivate int requestedChannelMax;\n+\tprivate int requestedFrameMax;\n+\tprivate int requestedHeartbeat;\n+\n+\t/**\n+\t *\n+\t * @param host host name\n+\t * @param port port\n+\t * @param virtualHost virtual host\n+\t * @param username username\n+\t * @param password password\n+\n+\t * @param networkRecoveryInterval connection recovery interval in milliseconds\n+\t * @param automaticRecovery if automatic connection recovery\n+\t * @param topologyRecovery if topology recovery\n+\t * @param connectionTimeout connection timeout\n+\t * @param requestedChannelMax requested maximum channel number\n+\t * @param requestedFrameMax requested maximum frame size\n+\t * @param requestedHeartbeat requested heartbeat interval\n+\t * @throws NullPointerException if host or virtual host or username or password is null\n+     */\n+\tprivate RMQConnectionConfig(String host, int port, String virtualHost, String username, String password,\n+\t\t\t\t\t\t\t\tint networkRecoveryInterval, boolean automaticRecovery,\n+\t\t\t\t\t\t\t\tboolean topologyRecovery, int connectionTimeout, int requestedChannelMax, int requestedFrameMax,\n+\t\t\t\t\t\t\t\tint requestedHeartbeat){\n+\t\tPreconditions.checkNotNull(host, \"host can not be null\");\n+\t\tPreconditions.checkNotNull(virtualHost, \"virtualHost can not be null\");\n+\t\tPreconditions.checkNotNull(username, \"username can not be null\");\n+\t\tPreconditions.checkNotNull(password, \"password can not be null\");\n+\t\tthis.host = host;\n+\t\tthis.port = port;\n+\t\tthis.virtualHost = virtualHost;\n+\t\tthis.username = username;\n+\t\tthis.password = password;\n+\n+\t\tthis.networkRecoveryInterval = networkRecoveryInterval;\n+\t\tthis.automaticRecovery = automaticRecovery;\n+\t\tthis.topologyRecovery = topologyRecovery;\n+\t\tthis.connectionTimeout = connectionTimeout;\n+\t\tthis.requestedChannelMax = requestedChannelMax;\n+\t\tthis.requestedFrameMax = requestedFrameMax;\n+\t\tthis.requestedHeartbeat = requestedHeartbeat;\n+\t}\n+\n+\t/**\n+\t *\n+\t * @param uri the connection URI\n+\t * @param networkRecoveryInterval connection recovery interval in milliseconds\n+\t * @param automaticRecovery if automatic connection recovery\n+\t * @param topologyRecovery if topology recovery\n+\t * @param connectionTimeout connection timeout\n+\t * @param requestedChannelMax requested maximum channel number\n+     * @param requestedFrameMax requested maximum frame size\n+     * @param requestedHeartbeat requested heartbeat interval\n+\t * @throws NullPointerException if URI is null","path":"flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java","position":106,"original_position":106,"commit_id":"0894679aa7dfbb8e0d5f6edd51f5000a08707769","original_commit_id":"0894679aa7dfbb8e0d5f6edd51f5000a08707769","user":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"body":"It seems that the indentation here is done using tabs and spaces.","created_at":"2016-05-31T19:53:35Z","updated_at":"2016-05-31T19:53:35Z","html_url":"https://github.com/apache/flink/pull/2054#discussion_r65250839","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/2054","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/65250839"},"html":{"href":"https://github.com/apache/flink/pull/2054#discussion_r65250839"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/2054"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2054","id":71993948,"html_url":"https://github.com/apache/flink/pull/2054","diff_url":"https://github.com/apache/flink/pull/2054.diff","patch_url":"https://github.com/apache/flink/pull/2054.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/2054","number":2054,"state":"open","locked":false,"title":"[FLINK-3763] RabbitMQ Source/Sink standardize connection parameters","user":{"login":"subhankarb","id":2178361,"avatar_url":"https://avatars.githubusercontent.com/u/2178361?v=3","gravatar_id":"","url":"https://api.github.com/users/subhankarb","html_url":"https://github.com/subhankarb","followers_url":"https://api.github.com/users/subhankarb/followers","following_url":"https://api.github.com/users/subhankarb/following{/other_user}","gists_url":"https://api.github.com/users/subhankarb/gists{/gist_id}","starred_url":"https://api.github.com/users/subhankarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subhankarb/subscriptions","organizations_url":"https://api.github.com/users/subhankarb/orgs","repos_url":"https://api.github.com/users/subhankarb/repos","events_url":"https://api.github.com/users/subhankarb/events{/privacy}","received_events_url":"https://api.github.com/users/subhankarb/received_events","type":"User","site_admin":false},"body":"Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.\r\nIf your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).\r\nIn addition to going through the list, please provide a meaningful description of your changes.\r\n\r\n- [x] General\r\n  - The pull request references the related JIRA issue (\"[FLINK-XXX] Jira title text\")\r\n  - The pull request addresses only one issue\r\n  - Each commit in the PR has a meaningful commit message (including the JIRA id)\r\n\r\n- [x] Documentation\r\n  - Documentation has been added for new functionality\r\n  - Old documentation affected by the pull request has been updated\r\n  - JavaDoc for public methods has been added\r\n\r\n- [x] Tests & Build\r\n  - Functionality added by the pull request is covered by tests\r\n  - `mvn clean verify` has been executed successfully locally or a Travis build has passed\r\n\r\n@rmetzger plz review.","created_at":"2016-05-31T10:42:16Z","updated_at":"2016-05-31T19:53:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"288029268553ad85cfcecb76e3042007f7d548aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/2054/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/2054/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/2054/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/0894679aa7dfbb8e0d5f6edd51f5000a08707769","head":{"label":"subhankarb:FLINK-3763","ref":"FLINK-3763","sha":"0894679aa7dfbb8e0d5f6edd51f5000a08707769","user":{"login":"subhankarb","id":2178361,"avatar_url":"https://avatars.githubusercontent.com/u/2178361?v=3","gravatar_id":"","url":"https://api.github.com/users/subhankarb","html_url":"https://github.com/subhankarb","followers_url":"https://api.github.com/users/subhankarb/followers","following_url":"https://api.github.com/users/subhankarb/following{/other_user}","gists_url":"https://api.github.com/users/subhankarb/gists{/gist_id}","starred_url":"https://api.github.com/users/subhankarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subhankarb/subscriptions","organizations_url":"https://api.github.com/users/subhankarb/orgs","repos_url":"https://api.github.com/users/subhankarb/repos","events_url":"https://api.github.com/users/subhankarb/events{/privacy}","received_events_url":"https://api.github.com/users/subhankarb/received_events","type":"User","site_admin":false},"repo":{"id":49247731,"name":"flink","full_name":"subhankarb/flink","owner":{"login":"subhankarb","id":2178361,"avatar_url":"https://avatars.githubusercontent.com/u/2178361?v=3","gravatar_id":"","url":"https://api.github.com/users/subhankarb","html_url":"https://github.com/subhankarb","followers_url":"https://api.github.com/users/subhankarb/followers","following_url":"https://api.github.com/users/subhankarb/following{/other_user}","gists_url":"https://api.github.com/users/subhankarb/gists{/gist_id}","starred_url":"https://api.github.com/users/subhankarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subhankarb/subscriptions","organizations_url":"https://api.github.com/users/subhankarb/orgs","repos_url":"https://api.github.com/users/subhankarb/repos","events_url":"https://api.github.com/users/subhankarb/events{/privacy}","received_events_url":"https://api.github.com/users/subhankarb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/subhankarb/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/subhankarb/flink","forks_url":"https://api.github.com/repos/subhankarb/flink/forks","keys_url":"https://api.github.com/repos/subhankarb/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/subhankarb/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/subhankarb/flink/teams","hooks_url":"https://api.github.com/repos/subhankarb/flink/hooks","issue_events_url":"https://api.github.com/repos/subhankarb/flink/issues/events{/number}","events_url":"https://api.github.com/repos/subhankarb/flink/events","assignees_url":"https://api.github.com/repos/subhankarb/flink/assignees{/user}","branches_url":"https://api.github.com/repos/subhankarb/flink/branches{/branch}","tags_url":"https://api.github.com/repos/subhankarb/flink/tags","blobs_url":"https://api.github.com/repos/subhankarb/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/subhankarb/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/subhankarb/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/subhankarb/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/subhankarb/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/subhankarb/flink/languages","stargazers_url":"https://api.github.com/repos/subhankarb/flink/stargazers","contributors_url":"https://api.github.com/repos/subhankarb/flink/contributors","subscribers_url":"https://api.github.com/repos/subhankarb/flink/subscribers","subscription_url":"https://api.github.com/repos/subhankarb/flink/subscription","commits_url":"https://api.github.com/repos/subhankarb/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/subhankarb/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/subhankarb/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/subhankarb/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/subhankarb/flink/contents/{+path}","compare_url":"https://api.github.com/repos/subhankarb/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/subhankarb/flink/merges","archive_url":"https://api.github.com/repos/subhankarb/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/subhankarb/flink/downloads","issues_url":"https://api.github.com/repos/subhankarb/flink/issues{/number}","pulls_url":"https://api.github.com/repos/subhankarb/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/subhankarb/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/subhankarb/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/subhankarb/flink/labels{/name}","releases_url":"https://api.github.com/repos/subhankarb/flink/releases{/id}","deployments_url":"https://api.github.com/repos/subhankarb/flink/deployments","created_at":"2016-01-08T03:45:37Z","updated_at":"2016-01-08T03:45:49Z","pushed_at":"2016-05-31T10:38:59Z","git_url":"git://github.com/subhankarb/flink.git","ssh_url":"git@github.com:subhankarb/flink.git","clone_url":"https://github.com/subhankarb/flink.git","svn_url":"https://github.com/subhankarb/flink","homepage":null,"size":89095,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8a6bdf4c18b5b5b8daff0aabe01ffd427773f815","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2016-05-31T17:30:27Z","pushed_at":"2016-05-31T18:04:46Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":117188,"stargazers_count":1330,"watchers_count":1330,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":840,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":99,"forks":840,"open_issues":99,"watchers":1330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/2054"},"html":{"href":"https://github.com/apache/flink/pull/2054"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/2054"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/2054/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/2054/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/2054/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/0894679aa7dfbb8e0d5f6edd51f5000a08707769"}}}}
{"actor":{"display_login":"rmetzger"}}