{"action":"created","comment":{"url":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments/81551457","pull_request_review_id":2522790,"id":81551457,"diff_hunk":"@@ -226,6 +233,10 @@ public Long create(Sample sample) throws IOException {\n           throw new IOException(e.getMessage(), e);\n         }\n         validateHierarchy(detailed);\n+\n+        if (detailed.getDetailedQcStatus() != null) {","path":"miso-service/src/main/java/uk/ac/bbsrc/tgac/miso/service/impl/DefaultSampleService.java","position":49,"original_position":49,"commit_id":"457c4b4a17391ea8bec92cce11070c7c9fe0a7f8","original_commit_id":"457c4b4a17391ea8bec92cce11070c7c9fe0a7f8","user":{"login":"callunity","id":8324996,"avatar_url":"https://avatars.githubusercontent.com/u/8324996?v=3","gravatar_id":"","url":"https://api.github.com/users/callunity","html_url":"https://github.com/callunity","followers_url":"https://api.github.com/users/callunity/followers","following_url":"https://api.github.com/users/callunity/following{/other_user}","gists_url":"https://api.github.com/users/callunity/gists{/gist_id}","starred_url":"https://api.github.com/users/callunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callunity/subscriptions","organizations_url":"https://api.github.com/users/callunity/orgs","repos_url":"https://api.github.com/users/callunity/repos","events_url":"https://api.github.com/users/callunity/events{/privacy}","received_events_url":"https://api.github.com/users/callunity/received_events","type":"User","site_admin":false},"body":"Hmm, looks like that code is already present in `loadChildEntities`. I'll delete it from `create` and `update`.","created_at":"2016-10-03T13:38:12Z","updated_at":"2016-10-03T13:38:12Z","html_url":"https://github.com/TGAC/miso-lims/pull/464#discussion_r81551457","pull_request_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/464","_links":{"self":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments/81551457"},"html":{"href":"https://github.com/TGAC/miso-lims/pull/464#discussion_r81551457"},"pull_request":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/464"}}},"pull_request":{"url":"https://api.github.com/repos/TGAC/miso-lims/pulls/464","id":87203560,"html_url":"https://github.com/TGAC/miso-lims/pull/464","diff_url":"https://github.com/TGAC/miso-lims/pull/464.diff","patch_url":"https://github.com/TGAC/miso-lims/pull/464.patch","issue_url":"https://api.github.com/repos/TGAC/miso-lims/issues/464","number":464,"state":"open","locked":false,"title":"GLT-1065 hide qcPassed & use detailedQcStatus","user":{"login":"callunity","id":8324996,"avatar_url":"https://avatars.githubusercontent.com/u/8324996?v=3","gravatar_id":"","url":"https://api.github.com/users/callunity","html_url":"https://github.com/callunity","followers_url":"https://api.github.com/users/callunity/followers","following_url":"https://api.github.com/users/callunity/following{/other_user}","gists_url":"https://api.github.com/users/callunity/gists{/gist_id}","starred_url":"https://api.github.com/users/callunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callunity/subscriptions","organizations_url":"https://api.github.com/users/callunity/orgs","repos_url":"https://api.github.com/users/callunity/repos","events_url":"https://api.github.com/users/callunity/events{/privacy}","received_events_url":"https://api.github.com/users/callunity/received_events","type":"User","site_admin":false},"body":"- changes `QcPassedDetail` to `DetailedQcStatus`\r\n- hides QC Passed if `detailedSample` is enabled, and uses `DetailedQcStatus` in lieu.\r\n- null `DetailedQcStatus` is shown to user as `Not Ready`\r\n- some formatting changes on JSPs","created_at":"2016-09-28T21:18:17Z","updated_at":"2016-10-03T13:38:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53505b7e410527b685339e37dfd69e476a3e1ec9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/464/commits","review_comments_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/464/comments","review_comment_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TGAC/miso-lims/issues/464/comments","statuses_url":"https://api.github.com/repos/TGAC/miso-lims/statuses/457c4b4a17391ea8bec92cce11070c7c9fe0a7f8","head":{"label":"oicr-gsi:GLT-1065_use_qcpd","ref":"GLT-1065_use_qcpd","sha":"457c4b4a17391ea8bec92cce11070c7c9fe0a7f8","user":{"login":"oicr-gsi","id":4701585,"avatar_url":"https://avatars.githubusercontent.com/u/4701585?v=3","gravatar_id":"","url":"https://api.github.com/users/oicr-gsi","html_url":"https://github.com/oicr-gsi","followers_url":"https://api.github.com/users/oicr-gsi/followers","following_url":"https://api.github.com/users/oicr-gsi/following{/other_user}","gists_url":"https://api.github.com/users/oicr-gsi/gists{/gist_id}","starred_url":"https://api.github.com/users/oicr-gsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oicr-gsi/subscriptions","organizations_url":"https://api.github.com/users/oicr-gsi/orgs","repos_url":"https://api.github.com/users/oicr-gsi/repos","events_url":"https://api.github.com/users/oicr-gsi/events{/privacy}","received_events_url":"https://api.github.com/users/oicr-gsi/received_events","type":"Organization","site_admin":false},"repo":{"id":37474147,"name":"miso-lims","full_name":"oicr-gsi/miso-lims","owner":{"login":"oicr-gsi","id":4701585,"avatar_url":"https://avatars.githubusercontent.com/u/4701585?v=3","gravatar_id":"","url":"https://api.github.com/users/oicr-gsi","html_url":"https://github.com/oicr-gsi","followers_url":"https://api.github.com/users/oicr-gsi/followers","following_url":"https://api.github.com/users/oicr-gsi/following{/other_user}","gists_url":"https://api.github.com/users/oicr-gsi/gists{/gist_id}","starred_url":"https://api.github.com/users/oicr-gsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oicr-gsi/subscriptions","organizations_url":"https://api.github.com/users/oicr-gsi/orgs","repos_url":"https://api.github.com/users/oicr-gsi/repos","events_url":"https://api.github.com/users/oicr-gsi/events{/privacy}","received_events_url":"https://api.github.com/users/oicr-gsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oicr-gsi/miso-lims","description":"MISO: An open-source LIMS for NGS sequencing centres","fork":true,"url":"https://api.github.com/repos/oicr-gsi/miso-lims","forks_url":"https://api.github.com/repos/oicr-gsi/miso-lims/forks","keys_url":"https://api.github.com/repos/oicr-gsi/miso-lims/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oicr-gsi/miso-lims/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oicr-gsi/miso-lims/teams","hooks_url":"https://api.github.com/repos/oicr-gsi/miso-lims/hooks","issue_events_url":"https://api.github.com/repos/oicr-gsi/miso-lims/issues/events{/number}","events_url":"https://api.github.com/repos/oicr-gsi/miso-lims/events","assignees_url":"https://api.github.com/repos/oicr-gsi/miso-lims/assignees{/user}","branches_url":"https://api.github.com/repos/oicr-gsi/miso-lims/branches{/branch}","tags_url":"https://api.github.com/repos/oicr-gsi/miso-lims/tags","blobs_url":"https://api.github.com/repos/oicr-gsi/miso-lims/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oicr-gsi/miso-lims/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oicr-gsi/miso-lims/git/refs{/sha}","trees_url":"https://api.github.com/repos/oicr-gsi/miso-lims/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oicr-gsi/miso-lims/statuses/{sha}","languages_url":"https://api.github.com/repos/oicr-gsi/miso-lims/languages","stargazers_url":"https://api.github.com/repos/oicr-gsi/miso-lims/stargazers","contributors_url":"https://api.github.com/repos/oicr-gsi/miso-lims/contributors","subscribers_url":"https://api.github.com/repos/oicr-gsi/miso-lims/subscribers","subscription_url":"https://api.github.com/repos/oicr-gsi/miso-lims/subscription","commits_url":"https://api.github.com/repos/oicr-gsi/miso-lims/commits{/sha}","git_commits_url":"https://api.github.com/repos/oicr-gsi/miso-lims/git/commits{/sha}","comments_url":"https://api.github.com/repos/oicr-gsi/miso-lims/comments{/number}","issue_comment_url":"https://api.github.com/repos/oicr-gsi/miso-lims/issues/comments{/number}","contents_url":"https://api.github.com/repos/oicr-gsi/miso-lims/contents/{+path}","compare_url":"https://api.github.com/repos/oicr-gsi/miso-lims/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oicr-gsi/miso-lims/merges","archive_url":"https://api.github.com/repos/oicr-gsi/miso-lims/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oicr-gsi/miso-lims/downloads","issues_url":"https://api.github.com/repos/oicr-gsi/miso-lims/issues{/number}","pulls_url":"https://api.github.com/repos/oicr-gsi/miso-lims/pulls{/number}","milestones_url":"https://api.github.com/repos/oicr-gsi/miso-lims/milestones{/number}","notifications_url":"https://api.github.com/repos/oicr-gsi/miso-lims/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oicr-gsi/miso-lims/labels{/name}","releases_url":"https://api.github.com/repos/oicr-gsi/miso-lims/releases{/id}","deployments_url":"https://api.github.com/repos/oicr-gsi/miso-lims/deployments","created_at":"2015-06-15T15:35:57Z","updated_at":"2016-02-09T02:26:47Z","pushed_at":"2016-09-30T21:45:49Z","git_url":"git://github.com/oicr-gsi/miso-lims.git","ssh_url":"git@github.com:oicr-gsi/miso-lims.git","clone_url":"https://github.com/oicr-gsi/miso-lims.git","svn_url":"https://github.com/oicr-gsi/miso-lims","homepage":"http://oicr-gsi.github.io/miso-lims/","size":85501,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":4,"default_branch":"oicr"}},"base":{"label":"TGAC:develop","ref":"develop","sha":"772ffafa6bd50038c9dd8eac4dc6c48f76d71173","user":{"login":"TGAC","id":1872319,"avatar_url":"https://avatars.githubusercontent.com/u/1872319?v=3","gravatar_id":"","url":"https://api.github.com/users/TGAC","html_url":"https://github.com/TGAC","followers_url":"https://api.github.com/users/TGAC/followers","following_url":"https://api.github.com/users/TGAC/following{/other_user}","gists_url":"https://api.github.com/users/TGAC/gists{/gist_id}","starred_url":"https://api.github.com/users/TGAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGAC/subscriptions","organizations_url":"https://api.github.com/users/TGAC/orgs","repos_url":"https://api.github.com/users/TGAC/repos","events_url":"https://api.github.com/users/TGAC/events{/privacy}","received_events_url":"https://api.github.com/users/TGAC/received_events","type":"Organization","site_admin":false},"repo":{"id":4726428,"name":"miso-lims","full_name":"TGAC/miso-lims","owner":{"login":"TGAC","id":1872319,"avatar_url":"https://avatars.githubusercontent.com/u/1872319?v=3","gravatar_id":"","url":"https://api.github.com/users/TGAC","html_url":"https://github.com/TGAC","followers_url":"https://api.github.com/users/TGAC/followers","following_url":"https://api.github.com/users/TGAC/following{/other_user}","gists_url":"https://api.github.com/users/TGAC/gists{/gist_id}","starred_url":"https://api.github.com/users/TGAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGAC/subscriptions","organizations_url":"https://api.github.com/users/TGAC/orgs","repos_url":"https://api.github.com/users/TGAC/repos","events_url":"https://api.github.com/users/TGAC/events{/privacy}","received_events_url":"https://api.github.com/users/TGAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TGAC/miso-lims","description":"MISO: An open-source LIMS for NGS sequencing centres","fork":false,"url":"https://api.github.com/repos/TGAC/miso-lims","forks_url":"https://api.github.com/repos/TGAC/miso-lims/forks","keys_url":"https://api.github.com/repos/TGAC/miso-lims/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TGAC/miso-lims/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TGAC/miso-lims/teams","hooks_url":"https://api.github.com/repos/TGAC/miso-lims/hooks","issue_events_url":"https://api.github.com/repos/TGAC/miso-lims/issues/events{/number}","events_url":"https://api.github.com/repos/TGAC/miso-lims/events","assignees_url":"https://api.github.com/repos/TGAC/miso-lims/assignees{/user}","branches_url":"https://api.github.com/repos/TGAC/miso-lims/branches{/branch}","tags_url":"https://api.github.com/repos/TGAC/miso-lims/tags","blobs_url":"https://api.github.com/repos/TGAC/miso-lims/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TGAC/miso-lims/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TGAC/miso-lims/git/refs{/sha}","trees_url":"https://api.github.com/repos/TGAC/miso-lims/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TGAC/miso-lims/statuses/{sha}","languages_url":"https://api.github.com/repos/TGAC/miso-lims/languages","stargazers_url":"https://api.github.com/repos/TGAC/miso-lims/stargazers","contributors_url":"https://api.github.com/repos/TGAC/miso-lims/contributors","subscribers_url":"https://api.github.com/repos/TGAC/miso-lims/subscribers","subscription_url":"https://api.github.com/repos/TGAC/miso-lims/subscription","commits_url":"https://api.github.com/repos/TGAC/miso-lims/commits{/sha}","git_commits_url":"https://api.github.com/repos/TGAC/miso-lims/git/commits{/sha}","comments_url":"https://api.github.com/repos/TGAC/miso-lims/comments{/number}","issue_comment_url":"https://api.github.com/repos/TGAC/miso-lims/issues/comments{/number}","contents_url":"https://api.github.com/repos/TGAC/miso-lims/contents/{+path}","compare_url":"https://api.github.com/repos/TGAC/miso-lims/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TGAC/miso-lims/merges","archive_url":"https://api.github.com/repos/TGAC/miso-lims/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TGAC/miso-lims/downloads","issues_url":"https://api.github.com/repos/TGAC/miso-lims/issues{/number}","pulls_url":"https://api.github.com/repos/TGAC/miso-lims/pulls{/number}","milestones_url":"https://api.github.com/repos/TGAC/miso-lims/milestones{/number}","notifications_url":"https://api.github.com/repos/TGAC/miso-lims/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TGAC/miso-lims/labels{/name}","releases_url":"https://api.github.com/repos/TGAC/miso-lims/releases{/id}","deployments_url":"https://api.github.com/repos/TGAC/miso-lims/deployments","created_at":"2012-06-20T13:17:28Z","updated_at":"2016-09-29T21:57:34Z","pushed_at":"2016-10-03T11:42:49Z","git_url":"git://github.com/TGAC/miso-lims.git","ssh_url":"git@github.com:TGAC/miso-lims.git","clone_url":"https://github.com/TGAC/miso-lims.git","svn_url":"https://github.com/TGAC/miso-lims","homepage":null,"size":155505,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":8,"forks":23,"open_issues":8,"watchers":46,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/464"},"html":{"href":"https://github.com/TGAC/miso-lims/pull/464"},"issue":{"href":"https://api.github.com/repos/TGAC/miso-lims/issues/464"},"comments":{"href":"https://api.github.com/repos/TGAC/miso-lims/issues/464/comments"},"review_comments":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/464/comments"},"review_comment":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/464/commits"},"statuses":{"href":"https://api.github.com/repos/TGAC/miso-lims/statuses/457c4b4a17391ea8bec92cce11070c7c9fe0a7f8"}}}}
{"actor":{"display_login":"callunity"}}