{"push_id":1087855713,"size":10,"distinct_size":10,"ref":"refs/heads/master","head":"bf7307558e42e0ad9f41316f397d880e6d4981b6","before":"d6176bb03add9c03b0ef83617648f34496713fe2","commits":[{"sha":"ee4bd806ba6ccac0013eb812e7f30bfcfe12d22a","author":{"email":"765086fe2e0c1f980161f127fec596800f327f62@outlook.com","name":"Yong Tang"},"message":"API/CLI discrepancy on hostname validation (#21595).\n\nThis fix tries to fix the discrepancy between API and CLI on hostname\nvalidation. Previously, the hostname validation was handled at the\nCLI interface in runconfig/opts/parse.go and return an error if the\nhostname is invalid. However, if an end user use the remote API to\npass the hostname, the error will not be returned immediately.\nInstead the error will only be thrown out when the container creation\nfails. This creates behavior discrepancy between API and CLI.\n\nIn this fix, the hostname validation was moved to\nverifyContainerSettings so the behavior will be the same for API and\nCLI.\n\nAfter the change, since CLI does not handle the hostname validation\nany more, the previous unit tests about hostname validation on CLI\nin runconfig/opts/parse_test.go has to be updated as well because\nthere is no validation at this stage. All those unit tests are moved\nto integration test TestRunTooLongHostname so that the hostname\nvalidation is still properly covered as before.\n\nNote: Since the hostname validation moved to API, the error message\nchanges from `invalid hostname format for --hostname:` to\n`invalid hostname format:` as well because `--hostname` is passed\nto CLI only.\n\nThis fix fixes #21595.\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/thaJeztah/docker/commits/ee4bd806ba6ccac0013eb812e7f30bfcfe12d22a"},{"sha":"1e44bba4af6c417e10cbf7aa459a8225dfb89d6c","author":{"email":"ff3bde741799c0eff815b83a54eda3fc494df54f@us.ibm.com","name":"Doug Davis"},"message":"Remain extra \\n on INFO log msg\n\nSigned-off-by: Doug Davis <dug@us.ibm.com>","distinct":true,"url":"https://api.github.com/repos/thaJeztah/docker/commits/1e44bba4af6c417e10cbf7aa459a8225dfb89d6c"},{"sha":"8fec7c26d4e831481674bcab7a0539affc91da29","author":{"email":"292dfe45c1441a8dd79593877a4b049d567dfa32@zju.edu.cn","name":"Hao Zhang"},"message":"update cgroup link in doc of run\n\nSigned-off-by: Hao Zhang <21521210@zju.edu.cn>","distinct":true,"url":"https://api.github.com/repos/thaJeztah/docker/commits/8fec7c26d4e831481674bcab7a0539affc91da29"},{"sha":"77da3bcb72ba4f936c428cb2b912c007a94cb87a","author":{"email":"97794a5efeea78234636d4fba0f499c15a92f5e3@docker.com","name":"Riyaz Faizullabhoy"},"message":"Update DCT docs with 1.11 info, fix typos\n\nSigned-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>","distinct":true,"url":"https://api.github.com/repos/thaJeztah/docker/commits/77da3bcb72ba4f936c428cb2b912c007a94cb87a"},{"sha":"861815a3252b88a118a91a164246401fa24fa549","author":{"email":"5665331b9b819ac358165f8c38970dc8c7ddb47d@docker.com","name":"moxiegirl"},"message":"Merge pull request #22229 from riyazdf/notary-doc-update\n\nUpdate DCT docs with 1.11 info, fix typos","distinct":true,"url":"https://api.github.com/repos/thaJeztah/docker/commits/861815a3252b88a118a91a164246401fa24fa549"},{"sha":"1158c921ab49793d87fc35e15eff23434822d6ab","author":{"email":"2043cda4df124b840b98ee1c4307c199042efdf7@gmail.com","name":"Alexander Morozov"},"message":"Merge pull request #22361 from duglin/removeCR\n\nRemain extra \\n on INFO log msg","distinct":true,"url":"https://api.github.com/repos/thaJeztah/docker/commits/1158c921ab49793d87fc35e15eff23434822d6ab"},{"sha":"deb6ea4702924ff390e4a57414f735b18e4d7185","author":{"email":"2b34a3e3e055981c6c83bcd4f9afd06751b4ac0e@users.noreply.github.com","name":"Sebastiaan van Stijn"},"message":"Merge pull request #22362 from ZJU-SEL/update-doc\n\nupdate cgroup link in doc of run","distinct":true,"url":"https://api.github.com/repos/thaJeztah/docker/commits/deb6ea4702924ff390e4a57414f735b18e4d7185"},{"sha":"9ab0aa43365cd648d7681a58b60e91f791bc920a","author":{"email":"9ac444d2b5df3db1f31aa1c6462ac8e9e2bde241@huawei.com","name":"Lei Jitang"},"message":"Skip TestBuildNotVerboseFailure if no network\n\nTestBuildNotVerboseFailure use a non-exist image busybox1,\nit requires network connection to access to Dockerhub, skip\nthis test if there is no network.\n\nSigned-off-by: Lei Jitang <leijitang@huawei.com>","distinct":true,"url":"https://api.github.com/repos/thaJeztah/docker/commits/9ab0aa43365cd648d7681a58b60e91f791bc920a"},{"sha":"78eb8a5fb932c2b11df47e7a22c05fe485e03adb","author":{"email":"87e1f221a672a14a323e57bb65eaea19d3ed3804@sbr.pm","name":"Vincent Demeester"},"message":"Merge pull request #21641 from yongtang/21595-discrepancy-on-hostname-validation\n\nAPI/CLI discrepancy on hostname validation (#21595).","distinct":true,"url":"https://api.github.com/repos/thaJeztah/docker/commits/78eb8a5fb932c2b11df47e7a22c05fe485e03adb"},{"sha":"bf7307558e42e0ad9f41316f397d880e6d4981b6","author":{"email":"2b34a3e3e055981c6c83bcd4f9afd06751b4ac0e@users.noreply.github.com","name":"Sebastiaan van Stijn"},"message":"Merge pull request #22269 from coolljt0725/skip\n\nSkip TestBuildNotVerboseFailure if no network","distinct":true,"url":"https://api.github.com/repos/thaJeztah/docker/commits/bf7307558e42e0ad9f41316f397d880e6d4981b6"}]}