{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/73763464","id":73763464,"diff_hunk":"@@ -83,6 +89,11 @@ object MirrorMaker extends Logging with KafkaMetricsGroup {\n   def main(args: Array[String]) {\n \n     info(\"Starting mirror maker\")\n+    println(\"WARNING: The default partition assignment strategy of mirror maker will change from 'range' to 'roundrobin' \" +","path":"core/src/main/scala/kafka/tools/MirrorMaker.scala","position":17,"original_position":17,"commit_id":"4ee0fd612f0e34a8a218de237fb869904b49af7e","original_commit_id":"4ee0fd612f0e34a8a218de237fb869904b49af7e","user":{"login":"vahidhashemian","id":13593506,"avatar_url":"https://avatars.githubusercontent.com/u/13593506?v=3","gravatar_id":"","url":"https://api.github.com/users/vahidhashemian","html_url":"https://github.com/vahidhashemian","followers_url":"https://api.github.com/users/vahidhashemian/followers","following_url":"https://api.github.com/users/vahidhashemian/following{/other_user}","gists_url":"https://api.github.com/users/vahidhashemian/gists{/gist_id}","starred_url":"https://api.github.com/users/vahidhashemian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vahidhashemian/subscriptions","organizations_url":"https://api.github.com/users/vahidhashemian/orgs","repos_url":"https://api.github.com/users/vahidhashemian/repos","events_url":"https://api.github.com/users/vahidhashemian/events{/privacy}","received_events_url":"https://api.github.com/users/vahidhashemian/received_events","type":"User","site_admin":false},"body":"@hachikuji Yes, thanks. That's what I realized when I guess you were writing your last post :)\r\nI'm going to look further into that last piece, which is how it would work in the new consumer, as you explained. I might bug you again for clarification. Thanks for bearing with me no this.","created_at":"2016-08-05T21:39:27Z","updated_at":"2016-08-05T21:39:27Z","html_url":"https://github.com/apache/kafka/pull/1499#discussion_r73763464","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1499","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/73763464"},"html":{"href":"https://github.com/apache/kafka/pull/1499#discussion_r73763464"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1499"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1499","id":73611055,"html_url":"https://github.com/apache/kafka/pull/1499","diff_url":"https://github.com/apache/kafka/pull/1499.diff","patch_url":"https://github.com/apache/kafka/pull/1499.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1499","number":1499,"state":"open","locked":false,"title":"KAFKA-3831: Prepare for updating Mirror Maker's default partition assignment strategy to round robin","user":{"login":"vahidhashemian","id":13593506,"avatar_url":"https://avatars.githubusercontent.com/u/13593506?v=3","gravatar_id":"","url":"https://api.github.com/users/vahidhashemian","html_url":"https://github.com/vahidhashemian","followers_url":"https://api.github.com/users/vahidhashemian/followers","following_url":"https://api.github.com/users/vahidhashemian/following{/other_user}","gists_url":"https://api.github.com/users/vahidhashemian/gists{/gist_id}","starred_url":"https://api.github.com/users/vahidhashemian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vahidhashemian/subscriptions","organizations_url":"https://api.github.com/users/vahidhashemian/orgs","repos_url":"https://api.github.com/users/vahidhashemian/repos","events_url":"https://api.github.com/users/vahidhashemian/events{/privacy}","received_events_url":"https://api.github.com/users/vahidhashemian/received_events","type":"User","site_admin":false},"body":"This patch adds proper warning message and necessary doc updates for updating the default partition assignment strategy of Mirror Maker from range to round robin. The actual switch would occur as part of a major release cycle (to be scheduled).","created_at":"2016-06-13T17:14:12Z","updated_at":"2016-08-05T21:39:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"765901d9a44e0ff3e3eca13f9e8182d9e2b9e234","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1499/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1499/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1499/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/4ee0fd612f0e34a8a218de237fb869904b49af7e","head":{"label":"vahidhashemian:KAFKA-3831","ref":"KAFKA-3831","sha":"4ee0fd612f0e34a8a218de237fb869904b49af7e","user":{"login":"vahidhashemian","id":13593506,"avatar_url":"https://avatars.githubusercontent.com/u/13593506?v=3","gravatar_id":"","url":"https://api.github.com/users/vahidhashemian","html_url":"https://github.com/vahidhashemian","followers_url":"https://api.github.com/users/vahidhashemian/followers","following_url":"https://api.github.com/users/vahidhashemian/following{/other_user}","gists_url":"https://api.github.com/users/vahidhashemian/gists{/gist_id}","starred_url":"https://api.github.com/users/vahidhashemian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vahidhashemian/subscriptions","organizations_url":"https://api.github.com/users/vahidhashemian/orgs","repos_url":"https://api.github.com/users/vahidhashemian/repos","events_url":"https://api.github.com/users/vahidhashemian/events{/privacy}","received_events_url":"https://api.github.com/users/vahidhashemian/received_events","type":"User","site_admin":false},"repo":{"id":47428717,"name":"kafka","full_name":"vahidhashemian/kafka","owner":{"login":"vahidhashemian","id":13593506,"avatar_url":"https://avatars.githubusercontent.com/u/13593506?v=3","gravatar_id":"","url":"https://api.github.com/users/vahidhashemian","html_url":"https://github.com/vahidhashemian","followers_url":"https://api.github.com/users/vahidhashemian/followers","following_url":"https://api.github.com/users/vahidhashemian/following{/other_user}","gists_url":"https://api.github.com/users/vahidhashemian/gists{/gist_id}","starred_url":"https://api.github.com/users/vahidhashemian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vahidhashemian/subscriptions","organizations_url":"https://api.github.com/users/vahidhashemian/orgs","repos_url":"https://api.github.com/users/vahidhashemian/repos","events_url":"https://api.github.com/users/vahidhashemian/events{/privacy}","received_events_url":"https://api.github.com/users/vahidhashemian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vahidhashemian/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/vahidhashemian/kafka","forks_url":"https://api.github.com/repos/vahidhashemian/kafka/forks","keys_url":"https://api.github.com/repos/vahidhashemian/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vahidhashemian/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vahidhashemian/kafka/teams","hooks_url":"https://api.github.com/repos/vahidhashemian/kafka/hooks","issue_events_url":"https://api.github.com/repos/vahidhashemian/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/vahidhashemian/kafka/events","assignees_url":"https://api.github.com/repos/vahidhashemian/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/vahidhashemian/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/vahidhashemian/kafka/tags","blobs_url":"https://api.github.com/repos/vahidhashemian/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vahidhashemian/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vahidhashemian/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/vahidhashemian/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vahidhashemian/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/vahidhashemian/kafka/languages","stargazers_url":"https://api.github.com/repos/vahidhashemian/kafka/stargazers","contributors_url":"https://api.github.com/repos/vahidhashemian/kafka/contributors","subscribers_url":"https://api.github.com/repos/vahidhashemian/kafka/subscribers","subscription_url":"https://api.github.com/repos/vahidhashemian/kafka/subscription","commits_url":"https://api.github.com/repos/vahidhashemian/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/vahidhashemian/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/vahidhashemian/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/vahidhashemian/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/vahidhashemian/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/vahidhashemian/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vahidhashemian/kafka/merges","archive_url":"https://api.github.com/repos/vahidhashemian/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vahidhashemian/kafka/downloads","issues_url":"https://api.github.com/repos/vahidhashemian/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/vahidhashemian/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/vahidhashemian/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/vahidhashemian/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vahidhashemian/kafka/labels{/name}","releases_url":"https://api.github.com/repos/vahidhashemian/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/vahidhashemian/kafka/deployments","created_at":"2015-12-04T21:04:22Z","updated_at":"2016-01-14T22:16:55Z","pushed_at":"2016-08-04T18:24:12Z","git_url":"git://github.com/vahidhashemian/kafka.git","ssh_url":"git@github.com:vahidhashemian/kafka.git","clone_url":"https://github.com/vahidhashemian/kafka.git","svn_url":"https://github.com/vahidhashemian/kafka","homepage":null,"size":31492,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"6e8c6f17f5ccdcc12f6d568a15af7c3ee893e22c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-08-05T17:27:53Z","pushed_at":"2016-08-05T19:08:22Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":45319,"stargazers_count":3575,"watchers_count":3575,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2183,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":230,"forks":2183,"open_issues":230,"watchers":3575,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1499"},"html":{"href":"https://github.com/apache/kafka/pull/1499"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1499"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1499/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1499/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1499/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/4ee0fd612f0e34a8a218de237fb869904b49af7e"}}}}
{"actor":{"display_login":"vahidhashemian"}}