{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/62286736","id":62286736,"diff_hunk":"@@ -40,7 +40,7 @@\n             :tables        => 'flavor',\n             :controller    => 'ems_cloud')\n         - if role_allows(:feature => \"security_group_show_list\")\n-          = li_link(:count => @record.number_of(:security_groups),\n+          = li_link(:count => @record.security_groups && @record.number_of(:security_groups),","path":"app/views/layouts/listnav/_ems_cloud.html.haml","position":5,"original_position":5,"commit_id":"8305be6ee7b0a0b72f5e60861442451fbcd791ae","original_commit_id":"8305be6ee7b0a0b72f5e60861442451fbcd791ae","user":{"login":"blomquisg","id":14183,"avatar_url":"https://avatars.githubusercontent.com/u/14183?v=3","gravatar_id":"","url":"https://api.github.com/users/blomquisg","html_url":"https://github.com/blomquisg","followers_url":"https://api.github.com/users/blomquisg/followers","following_url":"https://api.github.com/users/blomquisg/following{/other_user}","gists_url":"https://api.github.com/users/blomquisg/gists{/gist_id}","starred_url":"https://api.github.com/users/blomquisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blomquisg/subscriptions","organizations_url":"https://api.github.com/users/blomquisg/orgs","repos_url":"https://api.github.com/users/blomquisg/repos","events_url":"https://api.github.com/users/blomquisg/events{/privacy}","received_events_url":"https://api.github.com/users/blomquisg/received_events","type":"User","site_admin":false},"body":"I'll start by saying that I was including it only because it was in @Ladas' code.  I didn't even know it existed before this. \r\n\r\nBut, what's worrying about it?  [It looks pretty simple](https://github.com/ManageIQ/manageiq/blob/85fdc0a5bdd96d8e39d080d95c0fd3389a3b78bf/lib/extensions/ar_number_of.rb).\r\n\r\nIt's strange that we'd cache the count like that, but in the time it takes for the request to complete and this AR object to come into and out of existence, that count probably won't change, I guess.  And, if it does, it's arguable whether it's \"wrong\" at the time the page is built anyway.","created_at":"2016-05-06T04:05:10Z","updated_at":"2016-05-06T04:05:10Z","html_url":"https://github.com/ManageIQ/manageiq/pull/8253#discussion_r62286736","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8253","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/62286736"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/8253#discussion_r62286736"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8253"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8253","id":67895913,"html_url":"https://github.com/ManageIQ/manageiq/pull/8253","diff_url":"https://github.com/ManageIQ/manageiq/pull/8253.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/8253.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8253","number":8253,"state":"open","locked":false,"title":"Handle gracefully when cloud -> network relation gets deleted","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"body":"Handle gracefully when CloudManager -> NetworkManager relation\r\ngets deleted. This should not happened since both creation\r\nand deletion of cloud_manager is always packed with network\r\nmanager in a transaction. And yet, I had reported this occurred.\r\n\r\nWhich would probably point to some lowlevel consistency bug.\r\nIt has not been reproduced yet.\r\n\r\nThis PR allows us to display and delete disconnected CloudManager\r\nand NetworkManager, without presenting any 500 error to the\r\nuser.","created_at":"2016-04-26T14:29:43Z","updated_at":"2016-05-06T04:05:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8332b7ec4a7dfca7c1a70e14867601036cfadb1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8253/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8253/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8253/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/8305be6ee7b0a0b72f5e60861442451fbcd791ae","head":{"label":"Ladas:handle_gracefully_when_cloud_manager_network_manager_relation_is_deleted","ref":"handle_gracefully_when_cloud_manager_network_manager_relation_is_deleted","sha":"8305be6ee7b0a0b72f5e60861442451fbcd791ae","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"repo":{"id":27175121,"name":"manageiq","full_name":"Ladas/manageiq","owner":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ladas/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/Ladas/manageiq","forks_url":"https://api.github.com/repos/Ladas/manageiq/forks","keys_url":"https://api.github.com/repos/Ladas/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ladas/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ladas/manageiq/teams","hooks_url":"https://api.github.com/repos/Ladas/manageiq/hooks","issue_events_url":"https://api.github.com/repos/Ladas/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/Ladas/manageiq/events","assignees_url":"https://api.github.com/repos/Ladas/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/Ladas/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/Ladas/manageiq/tags","blobs_url":"https://api.github.com/repos/Ladas/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ladas/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ladas/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ladas/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ladas/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/Ladas/manageiq/languages","stargazers_url":"https://api.github.com/repos/Ladas/manageiq/stargazers","contributors_url":"https://api.github.com/repos/Ladas/manageiq/contributors","subscribers_url":"https://api.github.com/repos/Ladas/manageiq/subscribers","subscription_url":"https://api.github.com/repos/Ladas/manageiq/subscription","commits_url":"https://api.github.com/repos/Ladas/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ladas/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ladas/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ladas/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ladas/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/Ladas/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ladas/manageiq/merges","archive_url":"https://api.github.com/repos/Ladas/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ladas/manageiq/downloads","issues_url":"https://api.github.com/repos/Ladas/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/Ladas/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/Ladas/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/Ladas/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ladas/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/Ladas/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/Ladas/manageiq/deployments","created_at":"2014-11-26T12:09:24Z","updated_at":"2016-02-04T14:54:45Z","pushed_at":"2016-05-05T13:07:55Z","git_url":"git://github.com/Ladas/manageiq.git","ssh_url":"git@github.com:Ladas/manageiq.git","clone_url":"https://github.com/Ladas/manageiq.git","svn_url":"https://github.com/Ladas/manageiq","homepage":"manageiq.org","size":123183,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"78dc56cc2d3a8bb91f2116048e00610ab97619c2","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-05-05T13:46:55Z","pushed_at":"2016-05-06T02:23:17Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":161884,"stargazers_count":263,"watchers_count":263,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":275,"mirror_url":null,"open_issues_count":615,"forks":275,"open_issues":615,"watchers":263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8253"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/8253"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/8253"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/8253/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8253/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8253/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/8305be6ee7b0a0b72f5e60861442451fbcd791ae"}}}}