{"action":"closed","number":109,"pull_request":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/109","id":75390708,"html_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/109","diff_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/109.diff","patch_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/109.patch","issue_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/109","number":109,"state":"closed","locked":false,"title":"Fix subscription for Websocket transport","user":{"login":"stevegury","id":376195,"avatar_url":"https://avatars.githubusercontent.com/u/376195?v=3","gravatar_id":"","url":"https://api.github.com/users/stevegury","html_url":"https://github.com/stevegury","followers_url":"https://api.github.com/users/stevegury/followers","following_url":"https://api.github.com/users/stevegury/following{/other_user}","gists_url":"https://api.github.com/users/stevegury/gists{/gist_id}","starred_url":"https://api.github.com/users/stevegury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevegury/subscriptions","organizations_url":"https://api.github.com/users/stevegury/orgs","repos_url":"https://api.github.com/users/stevegury/repos","events_url":"https://api.github.com/users/stevegury/events{/privacy}","received_events_url":"https://api.github.com/users/stevegury/received_events","type":"User","site_admin":false},"body":"**Problem**\r\nThe websocket DuplexConnection doesn't initialize the Publisher chain\r\nin every cases.\r\n\r\n**Solution**\r\nMove the initialization code `onSubscribe` up, and also rename the subscriber\r\n`subscriber` instead of `s` to avoid confusion with the `Subscription`.","created_at":"2016-06-27T22:29:03Z","updated_at":"2016-06-28T02:05:38Z","closed_at":"2016-06-28T02:05:38Z","merged_at":"2016-06-28T02:05:38Z","merge_commit_sha":"8d6c83d07d383d2412488bd94f8ef1c26d1b2ce2","assignee":{"login":"NiteshKant","id":820005,"avatar_url":"https://avatars.githubusercontent.com/u/820005?v=3","gravatar_id":"","url":"https://api.github.com/users/NiteshKant","html_url":"https://github.com/NiteshKant","followers_url":"https://api.github.com/users/NiteshKant/followers","following_url":"https://api.github.com/users/NiteshKant/following{/other_user}","gists_url":"https://api.github.com/users/NiteshKant/gists{/gist_id}","starred_url":"https://api.github.com/users/NiteshKant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiteshKant/subscriptions","organizations_url":"https://api.github.com/users/NiteshKant/orgs","repos_url":"https://api.github.com/users/NiteshKant/repos","events_url":"https://api.github.com/users/NiteshKant/events{/privacy}","received_events_url":"https://api.github.com/users/NiteshKant/received_events","type":"User","site_admin":false},"assignees":[{"login":"NiteshKant","id":820005,"avatar_url":"https://avatars.githubusercontent.com/u/820005?v=3","gravatar_id":"","url":"https://api.github.com/users/NiteshKant","html_url":"https://github.com/NiteshKant","followers_url":"https://api.github.com/users/NiteshKant/followers","following_url":"https://api.github.com/users/NiteshKant/following{/other_user}","gists_url":"https://api.github.com/users/NiteshKant/gists{/gist_id}","starred_url":"https://api.github.com/users/NiteshKant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiteshKant/subscriptions","organizations_url":"https://api.github.com/users/NiteshKant/orgs","repos_url":"https://api.github.com/users/NiteshKant/repos","events_url":"https://api.github.com/users/NiteshKant/events{/privacy}","received_events_url":"https://api.github.com/users/NiteshKant/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/109/commits","review_comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/109/comments","review_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/109/comments","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/68977b7a43772fcb75823539ea0c0375e8743bcf","head":{"label":"ReactiveSocket:stevegury/websocket_subscription","ref":"stevegury/websocket_subscription","sha":"68977b7a43772fcb75823539ea0c0375e8743bcf","user":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"repo":{"id":38732107,"name":"reactivesocket-java","full_name":"ReactiveSocket/reactivesocket-java","owner":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveSocket/reactivesocket-java","description":"ReactiveSocket Protocol for Client/Server for Java","fork":false,"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java","forks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/forks","keys_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/teams","hooks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/hooks","issue_events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/events","assignees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/tags","blobs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/languages","stargazers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/stargazers","contributors_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/contributors","subscribers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/subscribers","subscription_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/subscription","commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/merges","archive_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/downloads","issues_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/deployments","created_at":"2015-07-08T04:36:42Z","updated_at":"2016-06-23T21:33:11Z","pushed_at":"2016-06-28T02:05:38Z","git_url":"git://github.com/ReactiveSocket/reactivesocket-java.git","ssh_url":"git@github.com:ReactiveSocket/reactivesocket-java.git","clone_url":"https://github.com/ReactiveSocket/reactivesocket-java.git","svn_url":"https://github.com/ReactiveSocket/reactivesocket-java","homepage":"reactivesocket.io","size":1246,"stargazers_count":72,"watchers_count":72,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":16,"forks":14,"open_issues":16,"watchers":72,"default_branch":"master"}},"base":{"label":"ReactiveSocket:master","ref":"master","sha":"45ec974e09e6588289b60f80283a7e5dc8b2e400","user":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"repo":{"id":38732107,"name":"reactivesocket-java","full_name":"ReactiveSocket/reactivesocket-java","owner":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveSocket/reactivesocket-java","description":"ReactiveSocket Protocol for Client/Server for Java","fork":false,"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java","forks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/forks","keys_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/teams","hooks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/hooks","issue_events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/events","assignees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/tags","blobs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/languages","stargazers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/stargazers","contributors_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/contributors","subscribers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/subscribers","subscription_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/subscription","commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/merges","archive_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/downloads","issues_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/deployments","created_at":"2015-07-08T04:36:42Z","updated_at":"2016-06-23T21:33:11Z","pushed_at":"2016-06-28T02:05:38Z","git_url":"git://github.com/ReactiveSocket/reactivesocket-java.git","ssh_url":"git@github.com:ReactiveSocket/reactivesocket-java.git","clone_url":"https://github.com/ReactiveSocket/reactivesocket-java.git","svn_url":"https://github.com/ReactiveSocket/reactivesocket-java","homepage":"reactivesocket.io","size":1246,"stargazers_count":72,"watchers_count":72,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":16,"forks":14,"open_issues":16,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/109"},"html":{"href":"https://github.com/ReactiveSocket/reactivesocket-java/pull/109"},"issue":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/109"},"comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/68977b7a43772fcb75823539ea0c0375e8743bcf"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"NiteshKant","id":820005,"avatar_url":"https://avatars.githubusercontent.com/u/820005?v=3","gravatar_id":"","url":"https://api.github.com/users/NiteshKant","html_url":"https://github.com/NiteshKant","followers_url":"https://api.github.com/users/NiteshKant/followers","following_url":"https://api.github.com/users/NiteshKant/following{/other_user}","gists_url":"https://api.github.com/users/NiteshKant/gists{/gist_id}","starred_url":"https://api.github.com/users/NiteshKant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiteshKant/subscriptions","organizations_url":"https://api.github.com/users/NiteshKant/orgs","repos_url":"https://api.github.com/users/NiteshKant/repos","events_url":"https://api.github.com/users/NiteshKant/events{/privacy}","received_events_url":"https://api.github.com/users/NiteshKant/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"NiteshKant"}}