{"action":"created","issue":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/3497","repository_url":"https://api.github.com/repos/checkstyle/checkstyle","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/3497/labels{/name}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/3497/comments","events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/3497/events","html_url":"https://github.com/checkstyle/checkstyle/issues/3497","id":181007948,"number":3497,"title":"split Guard class into two","user":{"login":"romani","id":812984,"avatar_url":"https://avatars.githubusercontent.com/u/812984?v=3","gravatar_id":"","url":"https://api.github.com/users/romani","html_url":"https://github.com/romani","followers_url":"https://api.github.com/users/romani/followers","following_url":"https://api.github.com/users/romani/following{/other_user}","gists_url":"https://api.github.com/users/romani/gists{/gist_id}","starred_url":"https://api.github.com/users/romani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romani/subscriptions","organizations_url":"https://api.github.com/users/romani/orgs","repos_url":"https://api.github.com/users/romani/repos","events_url":"https://api.github.com/users/romani/events{/privacy}","received_events_url":"https://api.github.com/users/romani/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/checkstyle/checkstyle/labels/approved","name":"approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-04T21:20:16Z","updated_at":"2016-10-22T11:40:52Z","closed_at":null,"body":"https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/Guard.java\r\n\r\nit serves two differend modes that are managed by null values in fields.\r\n\r\nTask: create two classes from one to avoid checking for null. Names should be different \"Guard\" and named close to what they represent from XML.\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/38138234-split-guard-class-into-two?utm_campaign=plugin&utm_content=tracker%2F500528&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F500528&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments/255523557","html_url":"https://github.com/checkstyle/checkstyle/issues/3497#issuecomment-255523557","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/3497","id":255523557,"user":{"login":"jochenvdv","id":6173051,"avatar_url":"https://avatars.githubusercontent.com/u/6173051?v=3","gravatar_id":"","url":"https://api.github.com/users/jochenvdv","html_url":"https://github.com/jochenvdv","followers_url":"https://api.github.com/users/jochenvdv/followers","following_url":"https://api.github.com/users/jochenvdv/following{/other_user}","gists_url":"https://api.github.com/users/jochenvdv/gists{/gist_id}","starred_url":"https://api.github.com/users/jochenvdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jochenvdv/subscriptions","organizations_url":"https://api.github.com/users/jochenvdv/orgs","repos_url":"https://api.github.com/users/jochenvdv/repos","events_url":"https://api.github.com/users/jochenvdv/events{/privacy}","received_events_url":"https://api.github.com/users/jochenvdv/received_events","type":"User","site_admin":false},"created_at":"2016-10-22T11:40:52Z","updated_at":"2016-10-22T11:40:52Z","body":"I have started working on this.\r\n\r\n- `GuardTest.java` contained some tests for `AccessResult`, I move them into its own test file\r\n- I think `PkgControl` should also be renamed to `ImportControl`\r\n- The unit tests for `PkgControl` only test for packages, so I will also add some tests for classes\r\n\r\nI'm gonna do what I think is best for now. I will make a PR once references to `Guard` and `PkgControl` have been replaced, I can then still change things if needed."}}
{"actor":{"display_login":"jochenvdv"}}