{"action":"created","comment":{"url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/comments/75901071","id":75901071,"diff_hunk":"@@ -118,6 +119,12 @@ function segmentDefault(el) {\n     el.clip = General.string(\"end\");\n }\n \n+\n+function polygonDefault(el) {\n+    el.filled = (el.filled !== \"undefined\" ? General.bool(el.filled) : General.bool(true));","path":"src/js/libgeo/GeoBasics.js","position":14,"original_position":14,"commit_id":"95a7394e6a94eeb474c1a90f14ae42d791a9445c","original_commit_id":"95a7394e6a94eeb474c1a90f14ae42d791a9445c","user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"body":"You mean `el.filled !== undefined` without the quotes. And you should use `General.bool(!!el.filled)` or some such, since we don't know whether `el.filled` really is a boolean value.","created_at":"2016-08-23T16:20:55Z","updated_at":"2016-08-23T16:20:55Z","html_url":"https://github.com/CindyJS/CindyJS/pull/173#discussion_r75901071","pull_request_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/comments/75901071"},"html":{"href":"https://github.com/CindyJS/CindyJS/pull/173#discussion_r75901071"},"pull_request":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/173","id":56492645,"html_url":"https://github.com/CindyJS/CindyJS/pull/173","diff_url":"https://github.com/CindyJS/CindyJS/pull/173.diff","patch_url":"https://github.com/CindyJS/CindyJS/pull/173.patch","issue_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/173","number":173,"state":"open","locked":false,"title":"initial version of polygons in gslp","user":{"login":"strobelm","id":14185442,"avatar_url":"https://avatars.githubusercontent.com/u/14185442?v=3","gravatar_id":"","url":"https://api.github.com/users/strobelm","html_url":"https://github.com/strobelm","followers_url":"https://api.github.com/users/strobelm/followers","following_url":"https://api.github.com/users/strobelm/following{/other_user}","gists_url":"https://api.github.com/users/strobelm/gists{/gist_id}","starred_url":"https://api.github.com/users/strobelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strobelm/subscriptions","organizations_url":"https://api.github.com/users/strobelm/orgs","repos_url":"https://api.github.com/users/strobelm/repos","events_url":"https://api.github.com/users/strobelm/events{/privacy}","received_events_url":"https://api.github.com/users/strobelm/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nthis is not really intended to be a pull request, rather code to open up discussion.\r\n\r\nI was looking into issue #166 which deals also with polygons in the gslp. Currently the signatures in geoOps expect the number of arguments to be of fixed size. \r\n\r\nThis raises some questions:\r\n1) How to handle arbitrary sized arguments (like in polygons)\r\n2) do we want to have mixed sets of Lines, Points, Conics etc... as arguments? Is there a use case?\r\n3) Do we need a new GeoOps type for polygons?\r\n\r\nAdditionally i wasn't sure how to handle the arguments in a proper way fitting for eval_helper.drawpolygon. I would really appreciate comment on that.","created_at":"2016-01-19T16:47:56Z","updated_at":"2016-08-23T16:20:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22f17b10f8dd1bfc54a8524d720b91ec4e9bca9b","assignee":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"assignees":[{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},{"login":"kranich","id":7249754,"avatar_url":"https://avatars.githubusercontent.com/u/7249754?v=3","gravatar_id":"","url":"https://api.github.com/users/kranich","html_url":"https://github.com/kranich","followers_url":"https://api.github.com/users/kranich/followers","following_url":"https://api.github.com/users/kranich/following{/other_user}","gists_url":"https://api.github.com/users/kranich/gists{/gist_id}","starred_url":"https://api.github.com/users/kranich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kranich/subscriptions","organizations_url":"https://api.github.com/users/kranich/orgs","repos_url":"https://api.github.com/users/kranich/repos","events_url":"https://api.github.com/users/kranich/events{/privacy}","received_events_url":"https://api.github.com/users/kranich/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/173/commits","review_comments_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/173/comments","review_comment_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/173/comments","statuses_url":"https://api.github.com/repos/CindyJS/CindyJS/statuses/95a7394e6a94eeb474c1a90f14ae42d791a9445c","head":{"label":"strobelm:GeoPoly","ref":"GeoPoly","sha":"95a7394e6a94eeb474c1a90f14ae42d791a9445c","user":{"login":"strobelm","id":14185442,"avatar_url":"https://avatars.githubusercontent.com/u/14185442?v=3","gravatar_id":"","url":"https://api.github.com/users/strobelm","html_url":"https://github.com/strobelm","followers_url":"https://api.github.com/users/strobelm/followers","following_url":"https://api.github.com/users/strobelm/following{/other_user}","gists_url":"https://api.github.com/users/strobelm/gists{/gist_id}","starred_url":"https://api.github.com/users/strobelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strobelm/subscriptions","organizations_url":"https://api.github.com/users/strobelm/orgs","repos_url":"https://api.github.com/users/strobelm/repos","events_url":"https://api.github.com/users/strobelm/events{/privacy}","received_events_url":"https://api.github.com/users/strobelm/received_events","type":"User","site_admin":false},"repo":{"id":42131318,"name":"CindyJS","full_name":"strobelm/CindyJS","owner":{"login":"strobelm","id":14185442,"avatar_url":"https://avatars.githubusercontent.com/u/14185442?v=3","gravatar_id":"","url":"https://api.github.com/users/strobelm","html_url":"https://github.com/strobelm","followers_url":"https://api.github.com/users/strobelm/followers","following_url":"https://api.github.com/users/strobelm/following{/other_user}","gists_url":"https://api.github.com/users/strobelm/gists{/gist_id}","starred_url":"https://api.github.com/users/strobelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strobelm/subscriptions","organizations_url":"https://api.github.com/users/strobelm/orgs","repos_url":"https://api.github.com/users/strobelm/repos","events_url":"https://api.github.com/users/strobelm/events{/privacy}","received_events_url":"https://api.github.com/users/strobelm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/strobelm/CindyJS","description":"A JavaScript framework for interactive (mathematical) content","fork":true,"url":"https://api.github.com/repos/strobelm/CindyJS","forks_url":"https://api.github.com/repos/strobelm/CindyJS/forks","keys_url":"https://api.github.com/repos/strobelm/CindyJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strobelm/CindyJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strobelm/CindyJS/teams","hooks_url":"https://api.github.com/repos/strobelm/CindyJS/hooks","issue_events_url":"https://api.github.com/repos/strobelm/CindyJS/issues/events{/number}","events_url":"https://api.github.com/repos/strobelm/CindyJS/events","assignees_url":"https://api.github.com/repos/strobelm/CindyJS/assignees{/user}","branches_url":"https://api.github.com/repos/strobelm/CindyJS/branches{/branch}","tags_url":"https://api.github.com/repos/strobelm/CindyJS/tags","blobs_url":"https://api.github.com/repos/strobelm/CindyJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strobelm/CindyJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strobelm/CindyJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/strobelm/CindyJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strobelm/CindyJS/statuses/{sha}","languages_url":"https://api.github.com/repos/strobelm/CindyJS/languages","stargazers_url":"https://api.github.com/repos/strobelm/CindyJS/stargazers","contributors_url":"https://api.github.com/repos/strobelm/CindyJS/contributors","subscribers_url":"https://api.github.com/repos/strobelm/CindyJS/subscribers","subscription_url":"https://api.github.com/repos/strobelm/CindyJS/subscription","commits_url":"https://api.github.com/repos/strobelm/CindyJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/strobelm/CindyJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/strobelm/CindyJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/strobelm/CindyJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/strobelm/CindyJS/contents/{+path}","compare_url":"https://api.github.com/repos/strobelm/CindyJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strobelm/CindyJS/merges","archive_url":"https://api.github.com/repos/strobelm/CindyJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strobelm/CindyJS/downloads","issues_url":"https://api.github.com/repos/strobelm/CindyJS/issues{/number}","pulls_url":"https://api.github.com/repos/strobelm/CindyJS/pulls{/number}","milestones_url":"https://api.github.com/repos/strobelm/CindyJS/milestones{/number}","notifications_url":"https://api.github.com/repos/strobelm/CindyJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strobelm/CindyJS/labels{/name}","releases_url":"https://api.github.com/repos/strobelm/CindyJS/releases{/id}","deployments_url":"https://api.github.com/repos/strobelm/CindyJS/deployments","created_at":"2015-09-08T18:30:47Z","updated_at":"2016-01-18T15:41:22Z","pushed_at":"2016-08-23T07:30:52Z","git_url":"git://github.com/strobelm/CindyJS.git","ssh_url":"git@github.com:strobelm/CindyJS.git","clone_url":"https://github.com/strobelm/CindyJS.git","svn_url":"https://github.com/strobelm/CindyJS","homepage":null,"size":13084,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CindyJS:master","ref":"master","sha":"cb4026161e9e6f8a71f9703b1e3771bf2335be3d","user":{"login":"CindyJS","id":14181218,"avatar_url":"https://avatars.githubusercontent.com/u/14181218?v=3","gravatar_id":"","url":"https://api.github.com/users/CindyJS","html_url":"https://github.com/CindyJS","followers_url":"https://api.github.com/users/CindyJS/followers","following_url":"https://api.github.com/users/CindyJS/following{/other_user}","gists_url":"https://api.github.com/users/CindyJS/gists{/gist_id}","starred_url":"https://api.github.com/users/CindyJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CindyJS/subscriptions","organizations_url":"https://api.github.com/users/CindyJS/orgs","repos_url":"https://api.github.com/users/CindyJS/repos","events_url":"https://api.github.com/users/CindyJS/events{/privacy}","received_events_url":"https://api.github.com/users/CindyJS/received_events","type":"Organization","site_admin":false},"repo":{"id":42122684,"name":"CindyJS","full_name":"CindyJS/CindyJS","owner":{"login":"CindyJS","id":14181218,"avatar_url":"https://avatars.githubusercontent.com/u/14181218?v=3","gravatar_id":"","url":"https://api.github.com/users/CindyJS","html_url":"https://github.com/CindyJS","followers_url":"https://api.github.com/users/CindyJS/followers","following_url":"https://api.github.com/users/CindyJS/following{/other_user}","gists_url":"https://api.github.com/users/CindyJS/gists{/gist_id}","starred_url":"https://api.github.com/users/CindyJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CindyJS/subscriptions","organizations_url":"https://api.github.com/users/CindyJS/orgs","repos_url":"https://api.github.com/users/CindyJS/repos","events_url":"https://api.github.com/users/CindyJS/events{/privacy}","received_events_url":"https://api.github.com/users/CindyJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CindyJS/CindyJS","description":"A JavaScript framework for interactive (mathematical) content","fork":false,"url":"https://api.github.com/repos/CindyJS/CindyJS","forks_url":"https://api.github.com/repos/CindyJS/CindyJS/forks","keys_url":"https://api.github.com/repos/CindyJS/CindyJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CindyJS/CindyJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CindyJS/CindyJS/teams","hooks_url":"https://api.github.com/repos/CindyJS/CindyJS/hooks","issue_events_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/events{/number}","events_url":"https://api.github.com/repos/CindyJS/CindyJS/events","assignees_url":"https://api.github.com/repos/CindyJS/CindyJS/assignees{/user}","branches_url":"https://api.github.com/repos/CindyJS/CindyJS/branches{/branch}","tags_url":"https://api.github.com/repos/CindyJS/CindyJS/tags","blobs_url":"https://api.github.com/repos/CindyJS/CindyJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CindyJS/CindyJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CindyJS/CindyJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/CindyJS/CindyJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CindyJS/CindyJS/statuses/{sha}","languages_url":"https://api.github.com/repos/CindyJS/CindyJS/languages","stargazers_url":"https://api.github.com/repos/CindyJS/CindyJS/stargazers","contributors_url":"https://api.github.com/repos/CindyJS/CindyJS/contributors","subscribers_url":"https://api.github.com/repos/CindyJS/CindyJS/subscribers","subscription_url":"https://api.github.com/repos/CindyJS/CindyJS/subscription","commits_url":"https://api.github.com/repos/CindyJS/CindyJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/CindyJS/CindyJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/CindyJS/CindyJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/CindyJS/CindyJS/contents/{+path}","compare_url":"https://api.github.com/repos/CindyJS/CindyJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CindyJS/CindyJS/merges","archive_url":"https://api.github.com/repos/CindyJS/CindyJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CindyJS/CindyJS/downloads","issues_url":"https://api.github.com/repos/CindyJS/CindyJS/issues{/number}","pulls_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls{/number}","milestones_url":"https://api.github.com/repos/CindyJS/CindyJS/milestones{/number}","notifications_url":"https://api.github.com/repos/CindyJS/CindyJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CindyJS/CindyJS/labels{/name}","releases_url":"https://api.github.com/repos/CindyJS/CindyJS/releases{/id}","deployments_url":"https://api.github.com/repos/CindyJS/CindyJS/deployments","created_at":"2015-09-08T15:51:32Z","updated_at":"2016-08-19T19:04:08Z","pushed_at":"2016-08-23T16:16:36Z","git_url":"git://github.com/CindyJS/CindyJS.git","ssh_url":"git@github.com:CindyJS/CindyJS.git","clone_url":"https://github.com/CindyJS/CindyJS.git","svn_url":"https://github.com/CindyJS/CindyJS","homepage":"http://cindyjs.org/","size":14628,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":103,"forks":13,"open_issues":103,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/173"},"html":{"href":"https://github.com/CindyJS/CindyJS/pull/173"},"issue":{"href":"https://api.github.com/repos/CindyJS/CindyJS/issues/173"},"comments":{"href":"https://api.github.com/repos/CindyJS/CindyJS/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/CindyJS/CindyJS/statuses/95a7394e6a94eeb474c1a90f14ae42d791a9445c"}}}}
{"actor":{"display_login":"gagern"}}