{"action":"closed","number":75,"pull_request":{"url":"https://api.github.com/repos/taskcluster/taskcluster-auth/pulls/75","id":87802933,"html_url":"https://github.com/taskcluster/taskcluster-auth/pull/75","diff_url":"https://github.com/taskcluster/taskcluster-auth/pull/75.diff","patch_url":"https://github.com/taskcluster/taskcluster-auth/pull/75.patch","issue_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/issues/75","number":75,"state":"closed","locked":false,"title":"Bug 1302753: log all successful authentications","user":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"body":"This logs messages like\r\n```\r\nAuthenticated mozilla-user/dmitchell@mozilla.com for PUT access to https://localhost:60551/v1/clients/nobody%2Fsds%3Aad_asd%2Fdf-sAdSfchsdfsdfs%2Fbb%2F1\r\n```\r\n\r\nAn important thing to note here is, this will log all successful *authentications* regardless of whether the operation was *authorized* (which is determined by the service calling authenticateHawk).  So this doesn't completely solve the bug, but does give us a simple and effective way to determine whether and how a particular clientId was used during a particular timeframe.","created_at":"2016-10-03T22:23:07Z","updated_at":"2016-10-04T17:18:45Z","closed_at":"2016-10-04T17:18:45Z","merged_at":"2016-10-04T17:18:45Z","merge_commit_sha":"8417ab0280457c00714e30556cc153925445f609","assignee":{"login":"jonasfj","id":149732,"avatar_url":"https://avatars.githubusercontent.com/u/149732?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasfj","html_url":"https://github.com/jonasfj","followers_url":"https://api.github.com/users/jonasfj/followers","following_url":"https://api.github.com/users/jonasfj/following{/other_user}","gists_url":"https://api.github.com/users/jonasfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasfj/subscriptions","organizations_url":"https://api.github.com/users/jonasfj/orgs","repos_url":"https://api.github.com/users/jonasfj/repos","events_url":"https://api.github.com/users/jonasfj/events{/privacy}","received_events_url":"https://api.github.com/users/jonasfj/received_events","type":"User","site_admin":false},"assignees":[{"login":"jonasfj","id":149732,"avatar_url":"https://avatars.githubusercontent.com/u/149732?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasfj","html_url":"https://github.com/jonasfj","followers_url":"https://api.github.com/users/jonasfj/followers","following_url":"https://api.github.com/users/jonasfj/following{/other_user}","gists_url":"https://api.github.com/users/jonasfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasfj/subscriptions","organizations_url":"https://api.github.com/users/jonasfj/orgs","repos_url":"https://api.github.com/users/jonasfj/repos","events_url":"https://api.github.com/users/jonasfj/events{/privacy}","received_events_url":"https://api.github.com/users/jonasfj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/pulls/75/commits","review_comments_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/pulls/75/comments","review_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/issues/75/comments","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/statuses/8417ab0280457c00714e30556cc153925445f609","head":{"label":"djmitche:bug1302753","ref":"bug1302753","sha":"8417ab0280457c00714e30556cc153925445f609","user":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"repo":{"id":38646792,"name":"taskcluster-auth","full_name":"djmitche/taskcluster-auth","owner":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djmitche/taskcluster-auth","description":"Authentication and authorization manager for taskcluster","fork":true,"url":"https://api.github.com/repos/djmitche/taskcluster-auth","forks_url":"https://api.github.com/repos/djmitche/taskcluster-auth/forks","keys_url":"https://api.github.com/repos/djmitche/taskcluster-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djmitche/taskcluster-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djmitche/taskcluster-auth/teams","hooks_url":"https://api.github.com/repos/djmitche/taskcluster-auth/hooks","issue_events_url":"https://api.github.com/repos/djmitche/taskcluster-auth/issues/events{/number}","events_url":"https://api.github.com/repos/djmitche/taskcluster-auth/events","assignees_url":"https://api.github.com/repos/djmitche/taskcluster-auth/assignees{/user}","branches_url":"https://api.github.com/repos/djmitche/taskcluster-auth/branches{/branch}","tags_url":"https://api.github.com/repos/djmitche/taskcluster-auth/tags","blobs_url":"https://api.github.com/repos/djmitche/taskcluster-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djmitche/taskcluster-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djmitche/taskcluster-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/djmitche/taskcluster-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djmitche/taskcluster-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/djmitche/taskcluster-auth/languages","stargazers_url":"https://api.github.com/repos/djmitche/taskcluster-auth/stargazers","contributors_url":"https://api.github.com/repos/djmitche/taskcluster-auth/contributors","subscribers_url":"https://api.github.com/repos/djmitche/taskcluster-auth/subscribers","subscription_url":"https://api.github.com/repos/djmitche/taskcluster-auth/subscription","commits_url":"https://api.github.com/repos/djmitche/taskcluster-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/djmitche/taskcluster-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/djmitche/taskcluster-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/djmitche/taskcluster-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/djmitche/taskcluster-auth/contents/{+path}","compare_url":"https://api.github.com/repos/djmitche/taskcluster-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djmitche/taskcluster-auth/merges","archive_url":"https://api.github.com/repos/djmitche/taskcluster-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djmitche/taskcluster-auth/downloads","issues_url":"https://api.github.com/repos/djmitche/taskcluster-auth/issues{/number}","pulls_url":"https://api.github.com/repos/djmitche/taskcluster-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/djmitche/taskcluster-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/djmitche/taskcluster-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djmitche/taskcluster-auth/labels{/name}","releases_url":"https://api.github.com/repos/djmitche/taskcluster-auth/releases{/id}","deployments_url":"https://api.github.com/repos/djmitche/taskcluster-auth/deployments","created_at":"2015-07-06T21:17:45Z","updated_at":"2016-01-26T14:22:55Z","pushed_at":"2016-10-03T22:21:10Z","git_url":"git://github.com/djmitche/taskcluster-auth.git","ssh_url":"git@github.com:djmitche/taskcluster-auth.git","clone_url":"https://github.com/djmitche/taskcluster-auth.git","svn_url":"https://github.com/djmitche/taskcluster-auth","homepage":null,"size":10236,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"taskcluster:master","ref":"master","sha":"c6cce15bc13b9ec36134c6a69c74cc8d41b12540","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":20000474,"name":"taskcluster-auth","full_name":"taskcluster/taskcluster-auth","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-auth","description":"Authentication and authorization manager for taskcluster","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-auth","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-auth/deployments","created_at":"2014-05-20T22:55:57Z","updated_at":"2016-05-15T19:43:33Z","pushed_at":"2016-10-04T17:18:45Z","git_url":"git://github.com/taskcluster/taskcluster-auth.git","ssh_url":"git@github.com:taskcluster/taskcluster-auth.git","clone_url":"https://github.com/taskcluster/taskcluster-auth.git","svn_url":"https://github.com/taskcluster/taskcluster-auth","homepage":null,"size":10302,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-auth/pulls/75"},"html":{"href":"https://github.com/taskcluster/taskcluster-auth/pull/75"},"issue":{"href":"https://api.github.com/repos/taskcluster/taskcluster-auth/issues/75"},"comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-auth/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-auth/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/taskcluster-auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/taskcluster-auth/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/taskcluster-auth/statuses/8417ab0280457c00714e30556cc153925445f609"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":6,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"djmitche"}}