{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/91847085","pull_request_review_id":12358997,"id":91847085,"diff_hunk":"@@ -758,55 +844,72 @@ def _stop(self, *args):\n     def save(self, filename, writer=None, fps=None, dpi=None, codec=None,\n              bitrate=None, extra_args=None, metadata=None, extra_anim=None,\n              savefig_kwargs=None):\n-        '''\n-        Saves a movie file by drawing every frame.\n-\n-        *filename* is the output filename, e.g., :file:`mymovie.mp4`\n-\n-        *writer* is either an instance of :class:`MovieWriter` or a string\n-        key that identifies a class to use, such as 'ffmpeg' or 'mencoder'.\n-        If nothing is passed, the value of the rcparam `animation.writer` is\n-        used.\n-\n-        *dpi* controls the dots per inch for the movie frames. This combined\n-        with the figure's size in inches controls the size of the movie.\n-\n-        *savefig_kwargs* is a dictionary containing keyword arguments to be\n-        passed on to the 'savefig' command which is called repeatedly to save\n-        the individual frames. This can be used to set tight bounding boxes,\n-        for example.\n-\n-        *extra_anim* is a list of additional `Animation` objects that should\n-        be included in the saved movie file. These need to be from the same\n-        `matplotlib.Figure` instance. Also, animation frames will just be\n-        simply combined, so there should be a 1:1 correspondence between\n-        the frames from the different animations.\n-\n-        These remaining arguments are used to construct a :class:`MovieWriter`\n-        instance when necessary and are only considered valid if *writer* is\n-        not a :class:`MovieWriter` instance.\n-\n-        *fps* is the frames per second in the movie. Defaults to None,\n-        which will use the animation's specified interval to set the frames\n-        per second.\n-\n-        *codec* is the video codec to be used. Not all codecs are supported\n-        by a given :class:`MovieWriter`. If none is given, this defaults to the\n-        value specified by the rcparam `animation.codec`.\n-\n-        *bitrate* specifies the amount of bits used per second in the\n-        compressed movie, in kilobits per second. A higher number means a\n-        higher quality movie, but at the cost of increased file size. If no\n-        value is given, this defaults to the value given by the rcparam\n-        `animation.bitrate`.\n-\n-        *extra_args* is a list of extra string arguments to be passed to the\n-        underlying movie utility. The default is None, which passes the\n-        additional arguments in the 'animation.extra_args' rcParam.\n-\n-        *metadata* is a dictionary of keys and values for metadata to include\n-        in the output file. Some keys that may be of use include:\n-        title, artist, genre, subject, copyright, srcform, comment.\n+        '''Saves a movie file by drawing every frame.\n+\n+        Parameters\n+        ----------\n+\n+        filename : str\n+            The output filename, e.g., :file:`mymovie.mp4`\n+\n+        writer : :class:`MovieWriter` or str, optional\n+            A `MovieWriter` instance to use or a key that identifies a\n+            class to use, such as 'ffmpeg' or 'mencoder'. If `None`,\n+            defaults to ``rcParams['animation.writer']``\n+\n+        fps : number, optional\n+           frames per second in the movie. Defaults to None,\n+           which will use the animation's specified interval to set\n+           the frames per second.\n+\n+        dpi : number, optional\n+           Controls the dots per inch for the movie frames.  This\n+           combined with the figure's size in inches controls the size of\n+           the movie.  If None, defaults to ``rcparam['savefig.dpi']``\n+\n+        codec : str, optional\n+           The video codec to be used. Not all codecs are supported by\n+           a given :class:`MovieWriter`. If `None`,\n+           default to ``rcParams['animation.codec']``\n+\n+        bitrate : number, optional\n+           Specifies the amount of bits used per second in the","path":"lib/matplotlib/animation.py","position":382,"original_position":382,"commit_id":"1a6c61c8fa6215b74453e5ebebf0ec516796a609","original_commit_id":"1a6c61c8fa6215b74453e5ebebf0ec516796a609","user":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars.githubusercontent.com/u/302469?v=3","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"body":"amount -> number","created_at":"2016-12-11T03:42:54Z","updated_at":"2016-12-11T03:43:56Z","html_url":"https://github.com/matplotlib/matplotlib/pull/7589#discussion_r91847085","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7589","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/91847085"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/7589#discussion_r91847085"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7589"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7589","id":97062186,"html_url":"https://github.com/matplotlib/matplotlib/pull/7589","diff_url":"https://github.com/matplotlib/matplotlib/pull/7589.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/7589.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7589","number":7589,"state":"open","locked":false,"title":"Doc animation","user":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"body":"The plan (if I have time to get to it is to flesh out the FuncAnimation section with the same example implemented the other 3 ways, but I think that as-is it is still a major improvement.","created_at":"2016-12-08T05:38:31Z","updated_at":"2016-12-11T03:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e1500eba82be77d4c1d7870e227688af4fc4109","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/14","html_url":"https://github.com/matplotlib/matplotlib/milestone/14","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/14/labels","id":662004,"number":14,"title":"2.0 (style change major release)","description":"Style changes only","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":839,"state":"open","created_at":"2014-05-17T14:28:22Z","updated_at":"2016-12-11T03:12:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7589/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7589/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7589/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/1a6c61c8fa6215b74453e5ebebf0ec516796a609","head":{"label":"tacaswell:doc_animation","ref":"doc_animation","sha":"1a6c61c8fa6215b74453e5ebebf0ec516796a609","user":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"repo":{"id":5345572,"name":"matplotlib","full_name":"tacaswell/matplotlib","owner":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tacaswell/matplotlib","description":null,"fork":true,"url":"https://api.github.com/repos/tacaswell/matplotlib","forks_url":"https://api.github.com/repos/tacaswell/matplotlib/forks","keys_url":"https://api.github.com/repos/tacaswell/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tacaswell/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tacaswell/matplotlib/teams","hooks_url":"https://api.github.com/repos/tacaswell/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/tacaswell/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/tacaswell/matplotlib/events","assignees_url":"https://api.github.com/repos/tacaswell/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/tacaswell/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/tacaswell/matplotlib/tags","blobs_url":"https://api.github.com/repos/tacaswell/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tacaswell/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tacaswell/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/tacaswell/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tacaswell/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/tacaswell/matplotlib/languages","stargazers_url":"https://api.github.com/repos/tacaswell/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/tacaswell/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/tacaswell/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/tacaswell/matplotlib/subscription","commits_url":"https://api.github.com/repos/tacaswell/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/tacaswell/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/tacaswell/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/tacaswell/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/tacaswell/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/tacaswell/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tacaswell/matplotlib/merges","archive_url":"https://api.github.com/repos/tacaswell/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tacaswell/matplotlib/downloads","issues_url":"https://api.github.com/repos/tacaswell/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/tacaswell/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/tacaswell/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/tacaswell/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tacaswell/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/tacaswell/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/tacaswell/matplotlib/deployments","created_at":"2012-08-08T18:19:38Z","updated_at":"2016-11-11T21:59:38Z","pushed_at":"2016-12-11T03:05:53Z","git_url":"git://github.com/tacaswell/matplotlib.git","ssh_url":"git@github.com:tacaswell/matplotlib.git","clone_url":"https://github.com/tacaswell/matplotlib.git","svn_url":"https://github.com/tacaswell/matplotlib","homepage":"","size":383407,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:v2.x","ref":"v2.x","sha":"7371b522869947e0e498d2e01271fa5bd2a2041f","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2016-12-10T19:04:12Z","pushed_at":"2016-12-11T03:13:30Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":409114,"stargazers_count":4454,"watchers_count":4454,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2190,"mirror_url":null,"open_issues_count":1042,"forks":2190,"open_issues":1042,"watchers":4454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7589"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/7589"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/7589"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/7589/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7589/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7589/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/1a6c61c8fa6215b74453e5ebebf0ec516796a609"}}}}
{"actor":{"display_login":"QuLogic"}}