{"action":"created","issue":{"url":"https://api.github.com/repos/TUM-LRR/era-gp-sim/issues/56","repository_url":"https://api.github.com/repos/TUM-LRR/era-gp-sim","labels_url":"https://api.github.com/repos/TUM-LRR/era-gp-sim/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/TUM-LRR/era-gp-sim/issues/56/comments","events_url":"https://api.github.com/repos/TUM-LRR/era-gp-sim/issues/56/events","html_url":"https://github.com/TUM-LRR/era-gp-sim/issues/56","id":169135452,"number":56,"title":"Parse directives","user":{"login":"DXIS","id":12698011,"avatar_url":"https://avatars.githubusercontent.com/u/12698011?v=3","gravatar_id":"","url":"https://api.github.com/users/DXIS","html_url":"https://github.com/DXIS","followers_url":"https://api.github.com/users/DXIS/followers","following_url":"https://api.github.com/users/DXIS/following{/other_user}","gists_url":"https://api.github.com/users/DXIS/gists{/gist_id}","starred_url":"https://api.github.com/users/DXIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DXIS/subscriptions","organizations_url":"https://api.github.com/users/DXIS/orgs","repos_url":"https://api.github.com/users/DXIS/repos","events_url":"https://api.github.com/users/DXIS/events{/privacy}","received_events_url":"https://api.github.com/users/DXIS/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TUM-LRR/era-gp-sim/labels/parser","name":"parser","color":"0000FF"},{"url":"https://api.github.com/repos/TUM-LRR/era-gp-sim/labels/review","name":"review","color":"7FFF00"}],"state":"open","locked":false,"assignee":{"login":"kreudom","id":3519965,"avatar_url":"https://avatars.githubusercontent.com/u/3519965?v=3","gravatar_id":"","url":"https://api.github.com/users/kreudom","html_url":"https://github.com/kreudom","followers_url":"https://api.github.com/users/kreudom/followers","following_url":"https://api.github.com/users/kreudom/following{/other_user}","gists_url":"https://api.github.com/users/kreudom/gists{/gist_id}","starred_url":"https://api.github.com/users/kreudom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreudom/subscriptions","organizations_url":"https://api.github.com/users/kreudom/orgs","repos_url":"https://api.github.com/users/kreudom/repos","events_url":"https://api.github.com/users/kreudom/events{/privacy}","received_events_url":"https://api.github.com/users/kreudom/received_events","type":"User","site_admin":false},"assignees":[{"login":"kreudom","id":3519965,"avatar_url":"https://avatars.githubusercontent.com/u/3519965?v=3","gravatar_id":"","url":"https://api.github.com/users/kreudom","html_url":"https://github.com/kreudom","followers_url":"https://api.github.com/users/kreudom/followers","following_url":"https://api.github.com/users/kreudom/following{/other_user}","gists_url":"https://api.github.com/users/kreudom/gists{/gist_id}","starred_url":"https://api.github.com/users/kreudom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreudom/subscriptions","organizations_url":"https://api.github.com/users/kreudom/orgs","repos_url":"https://api.github.com/users/kreudom/repos","events_url":"https://api.github.com/users/kreudom/events{/privacy}","received_events_url":"https://api.github.com/users/kreudom/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-08-03T13:46:55Z","updated_at":"2016-10-25T11:45:30Z","closed_at":null,"body":null},"comment":{"url":"https://api.github.com/repos/TUM-LRR/era-gp-sim/issues/comments/256012570","html_url":"https://github.com/TUM-LRR/era-gp-sim/issues/56#issuecomment-256012570","issue_url":"https://api.github.com/repos/TUM-LRR/era-gp-sim/issues/56","id":256012570,"user":{"login":"DXIS","id":12698011,"avatar_url":"https://avatars.githubusercontent.com/u/12698011?v=3","gravatar_id":"","url":"https://api.github.com/users/DXIS","html_url":"https://github.com/DXIS","followers_url":"https://api.github.com/users/DXIS/followers","following_url":"https://api.github.com/users/DXIS/following{/other_user}","gists_url":"https://api.github.com/users/DXIS/gists{/gist_id}","starred_url":"https://api.github.com/users/DXIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DXIS/subscriptions","organizations_url":"https://api.github.com/users/DXIS/orgs","repos_url":"https://api.github.com/users/DXIS/repos","events_url":"https://api.github.com/users/DXIS/events{/privacy}","received_events_url":"https://api.github.com/users/DXIS/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T11:45:30Z","updated_at":"2016-10-25T11:45:30Z","body":"Hi, looking over it I got to say that I like it. The methods are separated and clean (making the review faster to do, sorry for the delay though).\n\nSome minor issues:\n\n* There is a function pointer. Maybe consider replacing it by an `std::function`?\n* With the `clone` method I do not feel 100%ly comfortable... (b/c it has to be implemented for every subclass) But I do not see a good way to do it otherwise (except maybe for an external templated method, but ok).\n* Might it be possible to even include issue #53, it you like it like it is right now? (it contains something similar to the riscv-directive-factory which can be removed)\n* Maybe now issue #79 maybe also pushed to review if it is already included here (and the code of it looks fine as I shortly looked over it at least)\n* For the future, we might even add a register alias macro... Just thinking (as the arithmetic constants have brackets around it right now).\n\nApart from that, I think it is fine (at least I got nothing to complain about), keep up the great work and until next time!"}}
{"actor":{"display_login":"DXIS"}}