{"action":"closed","number":409,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/409","id":56315325,"html_url":"https://github.com/ReactiveX/RxSwift/pull/409","diff_url":"https://github.com/ReactiveX/RxSwift/pull/409.diff","patch_url":"https://github.com/ReactiveX/RxSwift/pull/409.patch","issue_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/409","number":409,"state":"closed","locked":false,"title":"Make UIBarButtonItem.rx_tap to shareable.","user":{"login":"tarunon","id":1830205,"avatar_url":"https://avatars.githubusercontent.com/u/1830205?v=3","gravatar_id":"","url":"https://api.github.com/users/tarunon","html_url":"https://github.com/tarunon","followers_url":"https://api.github.com/users/tarunon/followers","following_url":"https://api.github.com/users/tarunon/following{/other_user}","gists_url":"https://api.github.com/users/tarunon/gists{/gist_id}","starred_url":"https://api.github.com/users/tarunon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarunon/subscriptions","organizations_url":"https://api.github.com/users/tarunon/orgs","repos_url":"https://api.github.com/users/tarunon/repos","events_url":"https://api.github.com/users/tarunon/events{/privacy}","received_events_url":"https://api.github.com/users/tarunon/received_events","type":"User","site_admin":false},"body":"UIBarButtonItem has only one target, so UIBarButtonItem.rx_tap cannot share now.\r\n```swift\r\nlet barButton = UIBarButtonItem()\r\nbarButton.rx_tap\r\n  .subscribeNext { [weak self] _ in\r\n    // Never not be called.\r\n  }\r\n  .addDisposable(disposeBag)\r\nbarButton.rx_tap\r\n  .subscribeNext { [weak self] _ in\r\n    ...\r\n  }\r\n  .addDisposable(disposeBag)\r\n```\r\n\r\nI move ControlEvent initializer to BarButtonItemTarget, and reuse it.\r\nThen, UIBarButtonItem.rx_tap can share.\r\n\r\nPlease check this pr :3","created_at":"2016-01-18T08:55:47Z","updated_at":"2016-01-22T21:31:27Z","closed_at":"2016-01-22T21:31:27Z","merged_at":"2016-01-22T21:31:27Z","merge_commit_sha":"ea239bef42d073f4844300ae9cf59ecc915999db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/409/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/409/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/409/comments","statuses_url":"https://api.github.com/repos/ReactiveX/RxSwift/statuses/ed9a996b1592cc4289e2d31408038ba91478304a","head":{"label":"tarunon:fix/UIBarButtonItem_rx_tap_cannot_share","ref":"fix/UIBarButtonItem_rx_tap_cannot_share","sha":"ed9a996b1592cc4289e2d31408038ba91478304a","user":{"login":"tarunon","id":1830205,"avatar_url":"https://avatars.githubusercontent.com/u/1830205?v=3","gravatar_id":"","url":"https://api.github.com/users/tarunon","html_url":"https://github.com/tarunon","followers_url":"https://api.github.com/users/tarunon/followers","following_url":"https://api.github.com/users/tarunon/following{/other_user}","gists_url":"https://api.github.com/users/tarunon/gists{/gist_id}","starred_url":"https://api.github.com/users/tarunon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarunon/subscriptions","organizations_url":"https://api.github.com/users/tarunon/orgs","repos_url":"https://api.github.com/users/tarunon/repos","events_url":"https://api.github.com/users/tarunon/events{/privacy}","received_events_url":"https://api.github.com/users/tarunon/received_events","type":"User","site_admin":false},"repo":{"id":48079444,"name":"RxSwift","full_name":"tarunon/RxSwift","owner":{"login":"tarunon","id":1830205,"avatar_url":"https://avatars.githubusercontent.com/u/1830205?v=3","gravatar_id":"","url":"https://api.github.com/users/tarunon","html_url":"https://github.com/tarunon","followers_url":"https://api.github.com/users/tarunon/followers","following_url":"https://api.github.com/users/tarunon/following{/other_user}","gists_url":"https://api.github.com/users/tarunon/gists{/gist_id}","starred_url":"https://api.github.com/users/tarunon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarunon/subscriptions","organizations_url":"https://api.github.com/users/tarunon/orgs","repos_url":"https://api.github.com/users/tarunon/repos","events_url":"https://api.github.com/users/tarunon/events{/privacy}","received_events_url":"https://api.github.com/users/tarunon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tarunon/RxSwift","description":"Reactive Programming in Swift","fork":true,"url":"https://api.github.com/repos/tarunon/RxSwift","forks_url":"https://api.github.com/repos/tarunon/RxSwift/forks","keys_url":"https://api.github.com/repos/tarunon/RxSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tarunon/RxSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tarunon/RxSwift/teams","hooks_url":"https://api.github.com/repos/tarunon/RxSwift/hooks","issue_events_url":"https://api.github.com/repos/tarunon/RxSwift/issues/events{/number}","events_url":"https://api.github.com/repos/tarunon/RxSwift/events","assignees_url":"https://api.github.com/repos/tarunon/RxSwift/assignees{/user}","branches_url":"https://api.github.com/repos/tarunon/RxSwift/branches{/branch}","tags_url":"https://api.github.com/repos/tarunon/RxSwift/tags","blobs_url":"https://api.github.com/repos/tarunon/RxSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tarunon/RxSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tarunon/RxSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/tarunon/RxSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tarunon/RxSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/tarunon/RxSwift/languages","stargazers_url":"https://api.github.com/repos/tarunon/RxSwift/stargazers","contributors_url":"https://api.github.com/repos/tarunon/RxSwift/contributors","subscribers_url":"https://api.github.com/repos/tarunon/RxSwift/subscribers","subscription_url":"https://api.github.com/repos/tarunon/RxSwift/subscription","commits_url":"https://api.github.com/repos/tarunon/RxSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/tarunon/RxSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/tarunon/RxSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/tarunon/RxSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/tarunon/RxSwift/contents/{+path}","compare_url":"https://api.github.com/repos/tarunon/RxSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tarunon/RxSwift/merges","archive_url":"https://api.github.com/repos/tarunon/RxSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tarunon/RxSwift/downloads","issues_url":"https://api.github.com/repos/tarunon/RxSwift/issues{/number}","pulls_url":"https://api.github.com/repos/tarunon/RxSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/tarunon/RxSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/tarunon/RxSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tarunon/RxSwift/labels{/name}","releases_url":"https://api.github.com/repos/tarunon/RxSwift/releases{/id}","deployments_url":"https://api.github.com/repos/tarunon/RxSwift/deployments","created_at":"2015-12-16T01:30:39Z","updated_at":"2015-12-16T01:30:41Z","pushed_at":"2016-01-21T02:28:28Z","git_url":"git://github.com/tarunon/RxSwift.git","ssh_url":"git@github.com:tarunon/RxSwift.git","clone_url":"https://github.com/tarunon/RxSwift.git","svn_url":"https://github.com/tarunon/RxSwift","homepage":"","size":5646,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:develop","ref":"develop","sha":"a50c6e59e9188467cd8bdf75194e2b5eb0f7ea58","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":33569135,"name":"RxSwift","full_name":"ReactiveX/RxSwift","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/RxSwift","description":"Reactive Programming in Swift","fork":false,"url":"https://api.github.com/repos/ReactiveX/RxSwift","forks_url":"https://api.github.com/repos/ReactiveX/RxSwift/forks","keys_url":"https://api.github.com/repos/ReactiveX/RxSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/RxSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/RxSwift/teams","hooks_url":"https://api.github.com/repos/ReactiveX/RxSwift/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/RxSwift/events","assignees_url":"https://api.github.com/repos/ReactiveX/RxSwift/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/RxSwift/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/RxSwift/tags","blobs_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/RxSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/RxSwift/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/RxSwift/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/RxSwift/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/RxSwift/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/RxSwift/subscription","commits_url":"https://api.github.com/repos/ReactiveX/RxSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/RxSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/RxSwift/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/RxSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/RxSwift/merges","archive_url":"https://api.github.com/repos/ReactiveX/RxSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/RxSwift/downloads","issues_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/RxSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/RxSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/RxSwift/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/RxSwift/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/RxSwift/deployments","created_at":"2015-04-07T21:25:17Z","updated_at":"2016-01-22T18:26:05Z","pushed_at":"2016-01-22T21:31:27Z","git_url":"git://github.com/ReactiveX/RxSwift.git","ssh_url":"git@github.com:ReactiveX/RxSwift.git","clone_url":"https://github.com/ReactiveX/RxSwift.git","svn_url":"https://github.com/ReactiveX/RxSwift","homepage":"","size":10200,"stargazers_count":2926,"watchers_count":2926,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"open_issues_count":22,"forks":254,"open_issues":22,"watchers":2926,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/409"},"html":{"href":"https://github.com/ReactiveX/RxSwift/pull/409"},"issue":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/issues/409"},"comments":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/issues/409/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/409/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/409/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/statuses/ed9a996b1592cc4289e2d31408038ba91478304a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kzaher","id":1641148,"avatar_url":"https://avatars.githubusercontent.com/u/1641148?v=3","gravatar_id":"","url":"https://api.github.com/users/kzaher","html_url":"https://github.com/kzaher","followers_url":"https://api.github.com/users/kzaher/followers","following_url":"https://api.github.com/users/kzaher/following{/other_user}","gists_url":"https://api.github.com/users/kzaher/gists{/gist_id}","starred_url":"https://api.github.com/users/kzaher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzaher/subscriptions","organizations_url":"https://api.github.com/users/kzaher/orgs","repos_url":"https://api.github.com/users/kzaher/repos","events_url":"https://api.github.com/users/kzaher/events{/privacy}","received_events_url":"https://api.github.com/users/kzaher/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":3,"additions":33,"deletions":28,"changed_files":3}}