{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/comments/54147456","id":54147456,"diff_hunk":"@@ -2,5 +2,9 @@\n \n (defprotocol MetricsService\n   \"A service that tracks runtime metrics for the process.\"\n-  (get-metrics-registry [this] \"Provides access to the MetricsRegistry instance\n-                                where metrics are stored.\"))\n\\ No newline at end of file\n+  (get-metrics-registry\n+    [this]\n+    [this registry opts]\n+    \"Provides access to a MetricsRegistry configured with ops where `registry`\n+     is the key used to look up the registry. Specifing no `registry` will\n+     return the default MetricsRegistry\"))","path":"src/puppetlabs/trapperkeeper/services/protocols/metrics.clj","position":12,"original_position":12,"commit_id":"0e86d4ea52bb4cd0278d0f13fc20d87982505d7f","original_commit_id":"0e86d4ea52bb4cd0278d0f13fc20d87982505d7f","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"body":"What is the type for `registry`?  Docs on what `opts` can include?  A reference to a prismatic schema would be ideal.","created_at":"2016-02-25T19:15:33Z","updated_at":"2016-02-25T19:15:33Z","html_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/13#discussion_r54147456","pull_request_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/comments/54147456"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/13#discussion_r54147456"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/13","id":60433575,"html_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/13","diff_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/13.diff","patch_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/13.patch","issue_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/13","number":13,"state":"open","locked":false,"title":"(PDB-1531) Add mbeans handler and ability to configure multiple registries","user":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"body":"This PR adds the ability to use multiple registries with tk-metrics by adding a protocol function that \"upserts\" registries on calls to `(get-metrics-registry <name of registry> <opts>)`","created_at":"2016-02-24T00:05:12Z","updated_at":"2016-02-25T19:15:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e5cc9255f11d4ab7592cbfc8392784b3fdd49c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/13/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/13/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/13/comments","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/statuses/0e86d4ea52bb4cd0278d0f13fc20d87982505d7f","head":{"label":"ajroetker:ticket/master/pdb-1531/prepare_tk_metrics_for_pdb_usage","ref":"ticket/master/pdb-1531/prepare_tk_metrics_for_pdb_usage","sha":"0e86d4ea52bb4cd0278d0f13fc20d87982505d7f","user":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"repo":{"id":49911017,"name":"trapperkeeper-metrics","full_name":"ajroetker/trapperkeeper-metrics","owner":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajroetker/trapperkeeper-metrics","description":"","fork":true,"url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics","forks_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/forks","keys_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/teams","hooks_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/hooks","issue_events_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/events","assignees_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/tags","blobs_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/languages","stargazers_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/stargazers","contributors_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/contributors","subscribers_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/subscribers","subscription_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/subscription","commits_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/merges","archive_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/downloads","issues_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/labels{/name}","releases_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/ajroetker/trapperkeeper-metrics/deployments","created_at":"2016-01-18T22:58:16Z","updated_at":"2016-01-18T22:58:16Z","pushed_at":"2016-02-25T19:03:34Z","git_url":"git://github.com/ajroetker/trapperkeeper-metrics.git","ssh_url":"git@github.com:ajroetker/trapperkeeper-metrics.git","clone_url":"https://github.com/ajroetker/trapperkeeper-metrics.git","svn_url":"https://github.com/ajroetker/trapperkeeper-metrics","homepage":null,"size":26,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"95409a2aefa5eba03f752fdc4abd04043630bed6","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":37654950,"name":"trapperkeeper-metrics","full_name":"puppetlabs/trapperkeeper-metrics","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/trapperkeeper-metrics","description":"","fork":false,"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics","forks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/forks","keys_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/teams","hooks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/events","assignees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/tags","blobs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/subscription","commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/merges","archive_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/downloads","issues_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/deployments","created_at":"2015-06-18T11:13:03Z","updated_at":"2015-06-24T10:50:10Z","pushed_at":"2016-02-25T19:03:35Z","git_url":"git://github.com/puppetlabs/trapperkeeper-metrics.git","ssh_url":"git@github.com:puppetlabs/trapperkeeper-metrics.git","clone_url":"https://github.com/puppetlabs/trapperkeeper-metrics.git","svn_url":"https://github.com/puppetlabs/trapperkeeper-metrics","homepage":null,"size":199,"stargazers_count":1,"watchers_count":1,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/13"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/13"},"issue":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/13"},"comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/statuses/0e86d4ea52bb4cd0278d0f13fc20d87982505d7f"}}}}