{"action":"created","comment":{"url":"https://api.github.com/repos/amalgam8/amalgam8/pulls/comments/88545897","pull_request_review_id":9117562,"id":88545897,"diff_hunk":"@@ -26,12 +26,12 @@ http {\n   keepalive_requests 10000;\n   types_hash_max_size 2048;\n \n-  include /etc/nginx/conf.d/*.http.conf;\n+  include /etc/nginx/conf.d/*.conf;","path":"sidecar/nginx/conf/nginx.conf","position":null,"original_position":5,"commit_id":"45acea18223d1b478e0df1cf6f6a0ce6f6cfc37a","original_commit_id":"45acea18223d1b478e0df1cf6f6a0ce6f6cfc37a","user":{"login":"frankbu","id":2752495,"avatar_url":"https://avatars.githubusercontent.com/u/2752495?v=3","gravatar_id":"","url":"https://api.github.com/users/frankbu","html_url":"https://github.com/frankbu","followers_url":"https://api.github.com/users/frankbu/followers","following_url":"https://api.github.com/users/frankbu/following{/other_user}","gists_url":"https://api.github.com/users/frankbu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankbu/subscriptions","organizations_url":"https://api.github.com/users/frankbu/orgs","repos_url":"https://api.github.com/users/frankbu/repos","events_url":"https://api.github.com/users/frankbu/events{/privacy}","received_events_url":"https://api.github.com/users/frankbu/received_events","type":"User","site_admin":false},"body":"won't this also pull in the xxx.stream.conf files?","created_at":"2016-11-17T21:06:24Z","updated_at":"2016-11-17T21:06:24Z","html_url":"https://github.com/amalgam8/amalgam8/pull/403#discussion_r88545897","pull_request_url":"https://api.github.com/repos/amalgam8/amalgam8/pulls/403","_links":{"self":{"href":"https://api.github.com/repos/amalgam8/amalgam8/pulls/comments/88545897"},"html":{"href":"https://github.com/amalgam8/amalgam8/pull/403#discussion_r88545897"},"pull_request":{"href":"https://api.github.com/repos/amalgam8/amalgam8/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/amalgam8/amalgam8/pulls/403","id":94199092,"html_url":"https://github.com/amalgam8/amalgam8/pull/403","diff_url":"https://github.com/amalgam8/amalgam8/pull/403.diff","patch_url":"https://github.com/amalgam8/amalgam8/pull/403.patch","issue_url":"https://api.github.com/repos/amalgam8/amalgam8/issues/403","number":403,"state":"open","locked":false,"title":"add stream block to nginx.conf","user":{"login":"rshriram","id":8202871,"avatar_url":"https://avatars.githubusercontent.com/u/8202871?v=3","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"This PR addresses issue #402 reported by @greglanthier. Users can include configurations for proxying TCP services as part of their sidecar customization. This is an interim fix until we support generating TCP config files as part of the config reload process.","created_at":"2016-11-17T16:16:45Z","updated_at":"2016-11-17T21:06:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec0519b3a40ae5df6ca615f4e1ba112b62e34956","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/amalgam8/amalgam8/pulls/403/commits","review_comments_url":"https://api.github.com/repos/amalgam8/amalgam8/pulls/403/comments","review_comment_url":"https://api.github.com/repos/amalgam8/amalgam8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amalgam8/amalgam8/issues/403/comments","statuses_url":"https://api.github.com/repos/amalgam8/amalgam8/statuses/45acea18223d1b478e0df1cf6f6a0ce6f6cfc37a","head":{"label":"amalgam8:support_stream_proxy","ref":"support_stream_proxy","sha":"45acea18223d1b478e0df1cf6f6a0ce6f6cfc37a","user":{"login":"amalgam8","id":19418902,"avatar_url":"https://avatars.githubusercontent.com/u/19418902?v=3","gravatar_id":"","url":"https://api.github.com/users/amalgam8","html_url":"https://github.com/amalgam8","followers_url":"https://api.github.com/users/amalgam8/followers","following_url":"https://api.github.com/users/amalgam8/following{/other_user}","gists_url":"https://api.github.com/users/amalgam8/gists{/gist_id}","starred_url":"https://api.github.com/users/amalgam8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amalgam8/subscriptions","organizations_url":"https://api.github.com/users/amalgam8/orgs","repos_url":"https://api.github.com/users/amalgam8/repos","events_url":"https://api.github.com/users/amalgam8/events{/privacy}","received_events_url":"https://api.github.com/users/amalgam8/received_events","type":"Organization","site_admin":false},"repo":{"id":67527666,"name":"amalgam8","full_name":"amalgam8/amalgam8","owner":{"login":"amalgam8","id":19418902,"avatar_url":"https://avatars.githubusercontent.com/u/19418902?v=3","gravatar_id":"","url":"https://api.github.com/users/amalgam8","html_url":"https://github.com/amalgam8","followers_url":"https://api.github.com/users/amalgam8/followers","following_url":"https://api.github.com/users/amalgam8/following{/other_user}","gists_url":"https://api.github.com/users/amalgam8/gists{/gist_id}","starred_url":"https://api.github.com/users/amalgam8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amalgam8/subscriptions","organizations_url":"https://api.github.com/users/amalgam8/orgs","repos_url":"https://api.github.com/users/amalgam8/repos","events_url":"https://api.github.com/users/amalgam8/events{/privacy}","received_events_url":"https://api.github.com/users/amalgam8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amalgam8/amalgam8","description":"Content and Version-based Routing Fabric for Polyglot Microservices","fork":false,"url":"https://api.github.com/repos/amalgam8/amalgam8","forks_url":"https://api.github.com/repos/amalgam8/amalgam8/forks","keys_url":"https://api.github.com/repos/amalgam8/amalgam8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amalgam8/amalgam8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amalgam8/amalgam8/teams","hooks_url":"https://api.github.com/repos/amalgam8/amalgam8/hooks","issue_events_url":"https://api.github.com/repos/amalgam8/amalgam8/issues/events{/number}","events_url":"https://api.github.com/repos/amalgam8/amalgam8/events","assignees_url":"https://api.github.com/repos/amalgam8/amalgam8/assignees{/user}","branches_url":"https://api.github.com/repos/amalgam8/amalgam8/branches{/branch}","tags_url":"https://api.github.com/repos/amalgam8/amalgam8/tags","blobs_url":"https://api.github.com/repos/amalgam8/amalgam8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amalgam8/amalgam8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amalgam8/amalgam8/git/refs{/sha}","trees_url":"https://api.github.com/repos/amalgam8/amalgam8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amalgam8/amalgam8/statuses/{sha}","languages_url":"https://api.github.com/repos/amalgam8/amalgam8/languages","stargazers_url":"https://api.github.com/repos/amalgam8/amalgam8/stargazers","contributors_url":"https://api.github.com/repos/amalgam8/amalgam8/contributors","subscribers_url":"https://api.github.com/repos/amalgam8/amalgam8/subscribers","subscription_url":"https://api.github.com/repos/amalgam8/amalgam8/subscription","commits_url":"https://api.github.com/repos/amalgam8/amalgam8/commits{/sha}","git_commits_url":"https://api.github.com/repos/amalgam8/amalgam8/git/commits{/sha}","comments_url":"https://api.github.com/repos/amalgam8/amalgam8/comments{/number}","issue_comment_url":"https://api.github.com/repos/amalgam8/amalgam8/issues/comments{/number}","contents_url":"https://api.github.com/repos/amalgam8/amalgam8/contents/{+path}","compare_url":"https://api.github.com/repos/amalgam8/amalgam8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amalgam8/amalgam8/merges","archive_url":"https://api.github.com/repos/amalgam8/amalgam8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amalgam8/amalgam8/downloads","issues_url":"https://api.github.com/repos/amalgam8/amalgam8/issues{/number}","pulls_url":"https://api.github.com/repos/amalgam8/amalgam8/pulls{/number}","milestones_url":"https://api.github.com/repos/amalgam8/amalgam8/milestones{/number}","notifications_url":"https://api.github.com/repos/amalgam8/amalgam8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amalgam8/amalgam8/labels{/name}","releases_url":"https://api.github.com/repos/amalgam8/amalgam8/releases{/id}","deployments_url":"https://api.github.com/repos/amalgam8/amalgam8/deployments","created_at":"2016-09-06T16:43:20Z","updated_at":"2016-11-10T20:02:49Z","pushed_at":"2016-11-17T20:44:45Z","git_url":"git://github.com/amalgam8/amalgam8.git","ssh_url":"git@github.com:amalgam8/amalgam8.git","clone_url":"https://github.com/amalgam8/amalgam8.git","svn_url":"https://github.com/amalgam8/amalgam8","homepage":null,"size":36624,"stargazers_count":49,"watchers_count":49,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":43,"forks":23,"open_issues":43,"watchers":49,"default_branch":"master"}},"base":{"label":"amalgam8:master","ref":"master","sha":"749025292eb3185cbef3da16f680880f378b879a","user":{"login":"amalgam8","id":19418902,"avatar_url":"https://avatars.githubusercontent.com/u/19418902?v=3","gravatar_id":"","url":"https://api.github.com/users/amalgam8","html_url":"https://github.com/amalgam8","followers_url":"https://api.github.com/users/amalgam8/followers","following_url":"https://api.github.com/users/amalgam8/following{/other_user}","gists_url":"https://api.github.com/users/amalgam8/gists{/gist_id}","starred_url":"https://api.github.com/users/amalgam8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amalgam8/subscriptions","organizations_url":"https://api.github.com/users/amalgam8/orgs","repos_url":"https://api.github.com/users/amalgam8/repos","events_url":"https://api.github.com/users/amalgam8/events{/privacy}","received_events_url":"https://api.github.com/users/amalgam8/received_events","type":"Organization","site_admin":false},"repo":{"id":67527666,"name":"amalgam8","full_name":"amalgam8/amalgam8","owner":{"login":"amalgam8","id":19418902,"avatar_url":"https://avatars.githubusercontent.com/u/19418902?v=3","gravatar_id":"","url":"https://api.github.com/users/amalgam8","html_url":"https://github.com/amalgam8","followers_url":"https://api.github.com/users/amalgam8/followers","following_url":"https://api.github.com/users/amalgam8/following{/other_user}","gists_url":"https://api.github.com/users/amalgam8/gists{/gist_id}","starred_url":"https://api.github.com/users/amalgam8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amalgam8/subscriptions","organizations_url":"https://api.github.com/users/amalgam8/orgs","repos_url":"https://api.github.com/users/amalgam8/repos","events_url":"https://api.github.com/users/amalgam8/events{/privacy}","received_events_url":"https://api.github.com/users/amalgam8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amalgam8/amalgam8","description":"Content and Version-based Routing Fabric for Polyglot Microservices","fork":false,"url":"https://api.github.com/repos/amalgam8/amalgam8","forks_url":"https://api.github.com/repos/amalgam8/amalgam8/forks","keys_url":"https://api.github.com/repos/amalgam8/amalgam8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amalgam8/amalgam8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amalgam8/amalgam8/teams","hooks_url":"https://api.github.com/repos/amalgam8/amalgam8/hooks","issue_events_url":"https://api.github.com/repos/amalgam8/amalgam8/issues/events{/number}","events_url":"https://api.github.com/repos/amalgam8/amalgam8/events","assignees_url":"https://api.github.com/repos/amalgam8/amalgam8/assignees{/user}","branches_url":"https://api.github.com/repos/amalgam8/amalgam8/branches{/branch}","tags_url":"https://api.github.com/repos/amalgam8/amalgam8/tags","blobs_url":"https://api.github.com/repos/amalgam8/amalgam8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amalgam8/amalgam8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amalgam8/amalgam8/git/refs{/sha}","trees_url":"https://api.github.com/repos/amalgam8/amalgam8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amalgam8/amalgam8/statuses/{sha}","languages_url":"https://api.github.com/repos/amalgam8/amalgam8/languages","stargazers_url":"https://api.github.com/repos/amalgam8/amalgam8/stargazers","contributors_url":"https://api.github.com/repos/amalgam8/amalgam8/contributors","subscribers_url":"https://api.github.com/repos/amalgam8/amalgam8/subscribers","subscription_url":"https://api.github.com/repos/amalgam8/amalgam8/subscription","commits_url":"https://api.github.com/repos/amalgam8/amalgam8/commits{/sha}","git_commits_url":"https://api.github.com/repos/amalgam8/amalgam8/git/commits{/sha}","comments_url":"https://api.github.com/repos/amalgam8/amalgam8/comments{/number}","issue_comment_url":"https://api.github.com/repos/amalgam8/amalgam8/issues/comments{/number}","contents_url":"https://api.github.com/repos/amalgam8/amalgam8/contents/{+path}","compare_url":"https://api.github.com/repos/amalgam8/amalgam8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amalgam8/amalgam8/merges","archive_url":"https://api.github.com/repos/amalgam8/amalgam8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amalgam8/amalgam8/downloads","issues_url":"https://api.github.com/repos/amalgam8/amalgam8/issues{/number}","pulls_url":"https://api.github.com/repos/amalgam8/amalgam8/pulls{/number}","milestones_url":"https://api.github.com/repos/amalgam8/amalgam8/milestones{/number}","notifications_url":"https://api.github.com/repos/amalgam8/amalgam8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amalgam8/amalgam8/labels{/name}","releases_url":"https://api.github.com/repos/amalgam8/amalgam8/releases{/id}","deployments_url":"https://api.github.com/repos/amalgam8/amalgam8/deployments","created_at":"2016-09-06T16:43:20Z","updated_at":"2016-11-10T20:02:49Z","pushed_at":"2016-11-17T20:44:45Z","git_url":"git://github.com/amalgam8/amalgam8.git","ssh_url":"git@github.com:amalgam8/amalgam8.git","clone_url":"https://github.com/amalgam8/amalgam8.git","svn_url":"https://github.com/amalgam8/amalgam8","homepage":null,"size":36624,"stargazers_count":49,"watchers_count":49,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":43,"forks":23,"open_issues":43,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amalgam8/amalgam8/pulls/403"},"html":{"href":"https://github.com/amalgam8/amalgam8/pull/403"},"issue":{"href":"https://api.github.com/repos/amalgam8/amalgam8/issues/403"},"comments":{"href":"https://api.github.com/repos/amalgam8/amalgam8/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/amalgam8/amalgam8/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/amalgam8/amalgam8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amalgam8/amalgam8/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/amalgam8/amalgam8/statuses/45acea18223d1b478e0df1cf6f6a0ce6f6cfc37a"}}}}
{"actor":{"display_login":"frankbu"}}