{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/comments/65976799","id":65976799,"diff_hunk":"@@ -1056,7 +1057,6 @@ pub fn rewrite_associated_type(ident: ast::Ident,\n         let bounds: &[_] = &ty_param_bounds;\n         let bound_str = bounds.iter()\n             .filter_map(|ty_bound| ty_bound.rewrite(context, context.config.max_width, indent))\n-            .collect::<Vec<String>>()","path":"src/items.rs","position":12,"original_position":12,"commit_id":"2ea99869a7372c533c6289ec609b75a430d156ce","original_commit_id":"2ea99869a7372c533c6289ec609b75a430d156ce","user":{"login":"marcusklaas","id":1255413,"avatar_url":"https://avatars.githubusercontent.com/u/1255413?v=3","gravatar_id":"","url":"https://api.github.com/users/marcusklaas","html_url":"https://github.com/marcusklaas","followers_url":"https://api.github.com/users/marcusklaas/followers","following_url":"https://api.github.com/users/marcusklaas/following{/other_user}","gists_url":"https://api.github.com/users/marcusklaas/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusklaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusklaas/subscriptions","organizations_url":"https://api.github.com/users/marcusklaas/orgs","repos_url":"https://api.github.com/users/marcusklaas/repos","events_url":"https://api.github.com/users/marcusklaas/events{/privacy}","received_events_url":"https://api.github.com/users/marcusklaas/received_events","type":"User","site_admin":false},"body":"Actually, I think this was a bug! Could you refactor this into an intersperse -> option collect -> try_opt!, like you did with the others?","created_at":"2016-06-06T21:55:29Z","updated_at":"2016-06-06T21:55:29Z","html_url":"https://github.com/rust-lang-nursery/rustfmt/pull/1042#discussion_r65976799","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/1042","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/comments/65976799"},"html":{"href":"https://github.com/rust-lang-nursery/rustfmt/pull/1042#discussion_r65976799"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/1042"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/1042","id":72781750,"html_url":"https://github.com/rust-lang-nursery/rustfmt/pull/1042","diff_url":"https://github.com/rust-lang-nursery/rustfmt/pull/1042.diff","patch_url":"https://github.com/rust-lang-nursery/rustfmt/pull/1042.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1042","number":1042,"state":"open","locked":false,"title":"Refactor string collects to itertools join","user":{"login":"imjacobclark","id":1641689,"avatar_url":"https://avatars.githubusercontent.com/u/1641689?v=3","gravatar_id":"","url":"https://api.github.com/users/imjacobclark","html_url":"https://github.com/imjacobclark","followers_url":"https://api.github.com/users/imjacobclark/followers","following_url":"https://api.github.com/users/imjacobclark/following{/other_user}","gists_url":"https://api.github.com/users/imjacobclark/gists{/gist_id}","starred_url":"https://api.github.com/users/imjacobclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imjacobclark/subscriptions","organizations_url":"https://api.github.com/users/imjacobclark/orgs","repos_url":"https://api.github.com/users/imjacobclark/repos","events_url":"https://api.github.com/users/imjacobclark/events{/privacy}","received_events_url":"https://api.github.com/users/imjacobclark/received_events","type":"User","site_admin":false},"body":"Potentially refactored several other joins that _may_ not have been in the scope of this issue, happy to weed those out if they shouldn't be covered in this PR.\r\n\r\nThis resolves #1014.","created_at":"2016-06-06T21:33:02Z","updated_at":"2016-06-06T21:55:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"139865294aae77ec637a13a9ce6c9212ff2cf3b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/1042/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/1042/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1042/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/statuses/2ea99869a7372c533c6289ec609b75a430d156ce","head":{"label":"imjacobclark:1014-refactoring-vector-string-to-join","ref":"1014-refactoring-vector-string-to-join","sha":"2ea99869a7372c533c6289ec609b75a430d156ce","user":{"login":"imjacobclark","id":1641689,"avatar_url":"https://avatars.githubusercontent.com/u/1641689?v=3","gravatar_id":"","url":"https://api.github.com/users/imjacobclark","html_url":"https://github.com/imjacobclark","followers_url":"https://api.github.com/users/imjacobclark/followers","following_url":"https://api.github.com/users/imjacobclark/following{/other_user}","gists_url":"https://api.github.com/users/imjacobclark/gists{/gist_id}","starred_url":"https://api.github.com/users/imjacobclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imjacobclark/subscriptions","organizations_url":"https://api.github.com/users/imjacobclark/orgs","repos_url":"https://api.github.com/users/imjacobclark/repos","events_url":"https://api.github.com/users/imjacobclark/events{/privacy}","received_events_url":"https://api.github.com/users/imjacobclark/received_events","type":"User","site_admin":false},"repo":{"id":60562156,"name":"rustfmt","full_name":"imjacobclark/rustfmt","owner":{"login":"imjacobclark","id":1641689,"avatar_url":"https://avatars.githubusercontent.com/u/1641689?v=3","gravatar_id":"","url":"https://api.github.com/users/imjacobclark","html_url":"https://github.com/imjacobclark","followers_url":"https://api.github.com/users/imjacobclark/followers","following_url":"https://api.github.com/users/imjacobclark/following{/other_user}","gists_url":"https://api.github.com/users/imjacobclark/gists{/gist_id}","starred_url":"https://api.github.com/users/imjacobclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imjacobclark/subscriptions","organizations_url":"https://api.github.com/users/imjacobclark/orgs","repos_url":"https://api.github.com/users/imjacobclark/repos","events_url":"https://api.github.com/users/imjacobclark/events{/privacy}","received_events_url":"https://api.github.com/users/imjacobclark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imjacobclark/rustfmt","description":"Format Rust code","fork":true,"url":"https://api.github.com/repos/imjacobclark/rustfmt","forks_url":"https://api.github.com/repos/imjacobclark/rustfmt/forks","keys_url":"https://api.github.com/repos/imjacobclark/rustfmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imjacobclark/rustfmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imjacobclark/rustfmt/teams","hooks_url":"https://api.github.com/repos/imjacobclark/rustfmt/hooks","issue_events_url":"https://api.github.com/repos/imjacobclark/rustfmt/issues/events{/number}","events_url":"https://api.github.com/repos/imjacobclark/rustfmt/events","assignees_url":"https://api.github.com/repos/imjacobclark/rustfmt/assignees{/user}","branches_url":"https://api.github.com/repos/imjacobclark/rustfmt/branches{/branch}","tags_url":"https://api.github.com/repos/imjacobclark/rustfmt/tags","blobs_url":"https://api.github.com/repos/imjacobclark/rustfmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imjacobclark/rustfmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imjacobclark/rustfmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/imjacobclark/rustfmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imjacobclark/rustfmt/statuses/{sha}","languages_url":"https://api.github.com/repos/imjacobclark/rustfmt/languages","stargazers_url":"https://api.github.com/repos/imjacobclark/rustfmt/stargazers","contributors_url":"https://api.github.com/repos/imjacobclark/rustfmt/contributors","subscribers_url":"https://api.github.com/repos/imjacobclark/rustfmt/subscribers","subscription_url":"https://api.github.com/repos/imjacobclark/rustfmt/subscription","commits_url":"https://api.github.com/repos/imjacobclark/rustfmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/imjacobclark/rustfmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/imjacobclark/rustfmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/imjacobclark/rustfmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/imjacobclark/rustfmt/contents/{+path}","compare_url":"https://api.github.com/repos/imjacobclark/rustfmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imjacobclark/rustfmt/merges","archive_url":"https://api.github.com/repos/imjacobclark/rustfmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imjacobclark/rustfmt/downloads","issues_url":"https://api.github.com/repos/imjacobclark/rustfmt/issues{/number}","pulls_url":"https://api.github.com/repos/imjacobclark/rustfmt/pulls{/number}","milestones_url":"https://api.github.com/repos/imjacobclark/rustfmt/milestones{/number}","notifications_url":"https://api.github.com/repos/imjacobclark/rustfmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imjacobclark/rustfmt/labels{/name}","releases_url":"https://api.github.com/repos/imjacobclark/rustfmt/releases{/id}","deployments_url":"https://api.github.com/repos/imjacobclark/rustfmt/deployments","created_at":"2016-06-06T21:29:18Z","updated_at":"2016-06-06T21:29:19Z","pushed_at":"2016-06-06T21:49:01Z","git_url":"git://github.com/imjacobclark/rustfmt.git","ssh_url":"git@github.com:imjacobclark/rustfmt.git","clone_url":"https://github.com/imjacobclark/rustfmt.git","svn_url":"https://github.com/imjacobclark/rustfmt","homepage":null,"size":2097,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"3d4bc8c84ac1ee50c97217d863a6eb0a7556c405","user":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars.githubusercontent.com/u/14631425?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":31830551,"name":"rustfmt","full_name":"rust-lang-nursery/rustfmt","owner":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars.githubusercontent.com/u/14631425?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/rustfmt","description":"Format Rust code","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/rustfmt","forks_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/deployments","created_at":"2015-03-07T22:51:56Z","updated_at":"2016-06-06T06:38:48Z","pushed_at":"2016-06-06T21:50:59Z","git_url":"git://github.com/rust-lang-nursery/rustfmt.git","ssh_url":"git@github.com:rust-lang-nursery/rustfmt.git","clone_url":"https://github.com/rust-lang-nursery/rustfmt.git","svn_url":"https://github.com/rust-lang-nursery/rustfmt","homepage":null,"size":2669,"stargazers_count":746,"watchers_count":746,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":167,"forks":119,"open_issues":167,"watchers":746,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/1042"},"html":{"href":"https://github.com/rust-lang-nursery/rustfmt/pull/1042"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1042"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1042/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/1042/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/rustfmt/pulls/1042/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/rustfmt/statuses/2ea99869a7372c533c6289ec609b75a430d156ce"}}}}
{"actor":{"display_login":"marcusklaas"}}