{"action":"created","comment":{"url":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/comments/93545436","pull_request_review_id":14070678,"id":93545436,"diff_hunk":"@@ -0,0 +1,36 @@\n+defmodule Lexmag3Naming3PredicateFunsName do\n+  @moduledoc \"\"\"\n+  Source: [predicate-funs-name](https://github.com/lexmag/elixir-style-guide/blob/master/README.md#predicate-funs-name)\n+   from section: [Naming](https://github.com/lexmag/elixir-style-guide/blob/master/README.md#naming)\n+   in: [Elixir Style Guide](https://github.com/lexmag/elixir-style-guide)\n+   owned by: [@lexmag](https://github.com/lexmag).\n+  This work was created by Aleksei Magusev and is licensed under [the CC BY 4.0 license](https://creativecommons.org/licenses/by/4.0).\n+\n+  ![Creative Commons License](http://i.creativecommons.org/l/by/4.0/88x31.png)\n+  \"\"\"\n+\n+  @doc \"\"\"\n+  The names of predicate functions (a function that return a boolean value) should have a trailing question mark `?` rather than a leading `has_` or similar.\n+\n+  ```elixir\n+  def leap?(year) do\n+    #...\n+  end\n+  ```\n+\n+  Always use a leading `is_` when naming guard-safe predicate macros.\n+\n+  ```elixir\n+  defmacro is_date(month, day) do\n+    #...\n+  end\n+  ```\n+  \"\"\"\n+  @spec ok?(sample :: any) :: boolean\n+  def ok?(:ok), do: true\n+  def ok?(_), do: false\n+\n+  @spec is_ok?(sample :: any) :: boolean\n+  defmacro is_ok?(:ok), do: true","path":"examples/nested-jsbeautifyrc/elixir/expected/lexmag_3_naming_3_predicate_funs_name.ex","position":34,"original_position":34,"commit_id":"0366866152dfadf4d644b9c2946e80788bb387f0","original_commit_id":"0366866152dfadf4d644b9c2946e80788bb387f0","user":{"login":"lexmag","id":248290,"avatar_url":"https://avatars.githubusercontent.com/u/248290?v=3","gravatar_id":"","url":"https://api.github.com/users/lexmag","html_url":"https://github.com/lexmag","followers_url":"https://api.github.com/users/lexmag/followers","following_url":"https://api.github.com/users/lexmag/following{/other_user}","gists_url":"https://api.github.com/users/lexmag/gists{/gist_id}","starred_url":"https://api.github.com/users/lexmag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexmag/subscriptions","organizations_url":"https://api.github.com/users/lexmag/orgs","repos_url":"https://api.github.com/users/lexmag/repos","events_url":"https://api.github.com/users/lexmag/events{/privacy}","received_events_url":"https://api.github.com/users/lexmag/received_events","type":"User","site_admin":false},"body":"We should not use `?` if we have `is_` prefix.","created_at":"2016-12-22T00:08:28Z","updated_at":"2016-12-22T00:08:28Z","html_url":"https://github.com/Glavin001/atom-beautify/pull/1421#discussion_r93545436","pull_request_url":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/1421","_links":{"self":{"href":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/comments/93545436"},"html":{"href":"https://github.com/Glavin001/atom-beautify/pull/1421#discussion_r93545436"},"pull_request":{"href":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/1421"}}},"pull_request":{"url":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/1421","id":98767673,"html_url":"https://github.com/Glavin001/atom-beautify/pull/1421","diff_url":"https://github.com/Glavin001/atom-beautify/pull/1421.diff","patch_url":"https://github.com/Glavin001/atom-beautify/pull/1421.patch","issue_url":"https://api.github.com/repos/Glavin001/atom-beautify/issues/1421","number":1421,"state":"open","locked":false,"title":"Elixir examples based on @lexmag Elixir Style Guide","user":{"login":"Eiji7","id":10956022,"avatar_url":"https://avatars.githubusercontent.com/u/10956022?v=3","gravatar_id":"","url":"https://api.github.com/users/Eiji7","html_url":"https://github.com/Eiji7","followers_url":"https://api.github.com/users/Eiji7/followers","following_url":"https://api.github.com/users/Eiji7/following{/other_user}","gists_url":"https://api.github.com/users/Eiji7/gists{/gist_id}","starred_url":"https://api.github.com/users/Eiji7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eiji7/subscriptions","organizations_url":"https://api.github.com/users/Eiji7/orgs","repos_url":"https://api.github.com/users/Eiji7/repos","events_url":"https://api.github.com/users/Eiji7/events{/privacy}","received_events_url":"https://api.github.com/users/Eiji7/received_events","type":"User","site_admin":false},"body":"### What does this implement/fix? Explain your changes.\r\nExamples for [elixir](https://github.com/elixir-lang/elixir) (Elixir language).\r\nElixir Original <=> Expected examples based on @lexmag https://github.com/lexmag/elixir-style-guide\r\nFor more information see related issue: #545.\r\n\r\n### Checklist\r\n\r\nCheck all those that are applicable and complete.\r\n\r\n- [x] Merged with latest `master` branch\r\n- [x] Added examples for testing to [examples/ directory](examples/)\r\n- [ ] Travis CI passes (Mac support)\r\n- [ ] AppVeyor passes (Windows support)\r\n","created_at":"2016-12-20T15:20:25Z","updated_at":"2016-12-22T00:56:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b8ec15603f3e2beb1b796ee33044d115bd9e8b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/1421/commits","review_comments_url":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/1421/comments","review_comment_url":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Glavin001/atom-beautify/issues/1421/comments","statuses_url":"https://api.github.com/repos/Glavin001/atom-beautify/statuses/0366866152dfadf4d644b9c2946e80788bb387f0","head":{"label":"Eiji7:master","ref":"master","sha":"0366866152dfadf4d644b9c2946e80788bb387f0","user":{"login":"Eiji7","id":10956022,"avatar_url":"https://avatars.githubusercontent.com/u/10956022?v=3","gravatar_id":"","url":"https://api.github.com/users/Eiji7","html_url":"https://github.com/Eiji7","followers_url":"https://api.github.com/users/Eiji7/followers","following_url":"https://api.github.com/users/Eiji7/following{/other_user}","gists_url":"https://api.github.com/users/Eiji7/gists{/gist_id}","starred_url":"https://api.github.com/users/Eiji7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eiji7/subscriptions","organizations_url":"https://api.github.com/users/Eiji7/orgs","repos_url":"https://api.github.com/users/Eiji7/repos","events_url":"https://api.github.com/users/Eiji7/events{/privacy}","received_events_url":"https://api.github.com/users/Eiji7/received_events","type":"User","site_admin":false},"repo":{"id":76966784,"name":"atom-beautify","full_name":"Eiji7/atom-beautify","owner":{"login":"Eiji7","id":10956022,"avatar_url":"https://avatars.githubusercontent.com/u/10956022?v=3","gravatar_id":"","url":"https://api.github.com/users/Eiji7","html_url":"https://github.com/Eiji7","followers_url":"https://api.github.com/users/Eiji7/followers","following_url":"https://api.github.com/users/Eiji7/following{/other_user}","gists_url":"https://api.github.com/users/Eiji7/gists{/gist_id}","starred_url":"https://api.github.com/users/Eiji7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eiji7/subscriptions","organizations_url":"https://api.github.com/users/Eiji7/orgs","repos_url":"https://api.github.com/users/Eiji7/repos","events_url":"https://api.github.com/users/Eiji7/events{/privacy}","received_events_url":"https://api.github.com/users/Eiji7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Eiji7/atom-beautify","description":":lipstick: Beautification abstraction package for Atom editor","fork":true,"url":"https://api.github.com/repos/Eiji7/atom-beautify","forks_url":"https://api.github.com/repos/Eiji7/atom-beautify/forks","keys_url":"https://api.github.com/repos/Eiji7/atom-beautify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eiji7/atom-beautify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eiji7/atom-beautify/teams","hooks_url":"https://api.github.com/repos/Eiji7/atom-beautify/hooks","issue_events_url":"https://api.github.com/repos/Eiji7/atom-beautify/issues/events{/number}","events_url":"https://api.github.com/repos/Eiji7/atom-beautify/events","assignees_url":"https://api.github.com/repos/Eiji7/atom-beautify/assignees{/user}","branches_url":"https://api.github.com/repos/Eiji7/atom-beautify/branches{/branch}","tags_url":"https://api.github.com/repos/Eiji7/atom-beautify/tags","blobs_url":"https://api.github.com/repos/Eiji7/atom-beautify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eiji7/atom-beautify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eiji7/atom-beautify/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eiji7/atom-beautify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eiji7/atom-beautify/statuses/{sha}","languages_url":"https://api.github.com/repos/Eiji7/atom-beautify/languages","stargazers_url":"https://api.github.com/repos/Eiji7/atom-beautify/stargazers","contributors_url":"https://api.github.com/repos/Eiji7/atom-beautify/contributors","subscribers_url":"https://api.github.com/repos/Eiji7/atom-beautify/subscribers","subscription_url":"https://api.github.com/repos/Eiji7/atom-beautify/subscription","commits_url":"https://api.github.com/repos/Eiji7/atom-beautify/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eiji7/atom-beautify/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eiji7/atom-beautify/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eiji7/atom-beautify/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eiji7/atom-beautify/contents/{+path}","compare_url":"https://api.github.com/repos/Eiji7/atom-beautify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eiji7/atom-beautify/merges","archive_url":"https://api.github.com/repos/Eiji7/atom-beautify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eiji7/atom-beautify/downloads","issues_url":"https://api.github.com/repos/Eiji7/atom-beautify/issues{/number}","pulls_url":"https://api.github.com/repos/Eiji7/atom-beautify/pulls{/number}","milestones_url":"https://api.github.com/repos/Eiji7/atom-beautify/milestones{/number}","notifications_url":"https://api.github.com/repos/Eiji7/atom-beautify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eiji7/atom-beautify/labels{/name}","releases_url":"https://api.github.com/repos/Eiji7/atom-beautify/releases{/id}","deployments_url":"https://api.github.com/repos/Eiji7/atom-beautify/deployments","created_at":"2016-12-20T15:12:39Z","updated_at":"2016-12-20T15:12:43Z","pushed_at":"2016-12-20T15:15:44Z","git_url":"git://github.com/Eiji7/atom-beautify.git","ssh_url":"git@github.com:Eiji7/atom-beautify.git","clone_url":"https://github.com/Eiji7/atom-beautify.git","svn_url":"https://github.com/Eiji7/atom-beautify","homepage":"http://glavin001.github.io/atom-beautify/docs/code/","size":1777,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Glavin001:master","ref":"master","sha":"84abff4d13a7f7652bb6998c688e91d677548998","user":{"login":"Glavin001","id":1885333,"avatar_url":"https://avatars.githubusercontent.com/u/1885333?v=3","gravatar_id":"","url":"https://api.github.com/users/Glavin001","html_url":"https://github.com/Glavin001","followers_url":"https://api.github.com/users/Glavin001/followers","following_url":"https://api.github.com/users/Glavin001/following{/other_user}","gists_url":"https://api.github.com/users/Glavin001/gists{/gist_id}","starred_url":"https://api.github.com/users/Glavin001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glavin001/subscriptions","organizations_url":"https://api.github.com/users/Glavin001/orgs","repos_url":"https://api.github.com/users/Glavin001/repos","events_url":"https://api.github.com/users/Glavin001/events{/privacy}","received_events_url":"https://api.github.com/users/Glavin001/received_events","type":"User","site_admin":false},"repo":{"id":17356911,"name":"atom-beautify","full_name":"Glavin001/atom-beautify","owner":{"login":"Glavin001","id":1885333,"avatar_url":"https://avatars.githubusercontent.com/u/1885333?v=3","gravatar_id":"","url":"https://api.github.com/users/Glavin001","html_url":"https://github.com/Glavin001","followers_url":"https://api.github.com/users/Glavin001/followers","following_url":"https://api.github.com/users/Glavin001/following{/other_user}","gists_url":"https://api.github.com/users/Glavin001/gists{/gist_id}","starred_url":"https://api.github.com/users/Glavin001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glavin001/subscriptions","organizations_url":"https://api.github.com/users/Glavin001/orgs","repos_url":"https://api.github.com/users/Glavin001/repos","events_url":"https://api.github.com/users/Glavin001/events{/privacy}","received_events_url":"https://api.github.com/users/Glavin001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Glavin001/atom-beautify","description":":lipstick: Beautification abstraction package for Atom editor","fork":false,"url":"https://api.github.com/repos/Glavin001/atom-beautify","forks_url":"https://api.github.com/repos/Glavin001/atom-beautify/forks","keys_url":"https://api.github.com/repos/Glavin001/atom-beautify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Glavin001/atom-beautify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Glavin001/atom-beautify/teams","hooks_url":"https://api.github.com/repos/Glavin001/atom-beautify/hooks","issue_events_url":"https://api.github.com/repos/Glavin001/atom-beautify/issues/events{/number}","events_url":"https://api.github.com/repos/Glavin001/atom-beautify/events","assignees_url":"https://api.github.com/repos/Glavin001/atom-beautify/assignees{/user}","branches_url":"https://api.github.com/repos/Glavin001/atom-beautify/branches{/branch}","tags_url":"https://api.github.com/repos/Glavin001/atom-beautify/tags","blobs_url":"https://api.github.com/repos/Glavin001/atom-beautify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Glavin001/atom-beautify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Glavin001/atom-beautify/git/refs{/sha}","trees_url":"https://api.github.com/repos/Glavin001/atom-beautify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Glavin001/atom-beautify/statuses/{sha}","languages_url":"https://api.github.com/repos/Glavin001/atom-beautify/languages","stargazers_url":"https://api.github.com/repos/Glavin001/atom-beautify/stargazers","contributors_url":"https://api.github.com/repos/Glavin001/atom-beautify/contributors","subscribers_url":"https://api.github.com/repos/Glavin001/atom-beautify/subscribers","subscription_url":"https://api.github.com/repos/Glavin001/atom-beautify/subscription","commits_url":"https://api.github.com/repos/Glavin001/atom-beautify/commits{/sha}","git_commits_url":"https://api.github.com/repos/Glavin001/atom-beautify/git/commits{/sha}","comments_url":"https://api.github.com/repos/Glavin001/atom-beautify/comments{/number}","issue_comment_url":"https://api.github.com/repos/Glavin001/atom-beautify/issues/comments{/number}","contents_url":"https://api.github.com/repos/Glavin001/atom-beautify/contents/{+path}","compare_url":"https://api.github.com/repos/Glavin001/atom-beautify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Glavin001/atom-beautify/merges","archive_url":"https://api.github.com/repos/Glavin001/atom-beautify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Glavin001/atom-beautify/downloads","issues_url":"https://api.github.com/repos/Glavin001/atom-beautify/issues{/number}","pulls_url":"https://api.github.com/repos/Glavin001/atom-beautify/pulls{/number}","milestones_url":"https://api.github.com/repos/Glavin001/atom-beautify/milestones{/number}","notifications_url":"https://api.github.com/repos/Glavin001/atom-beautify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Glavin001/atom-beautify/labels{/name}","releases_url":"https://api.github.com/repos/Glavin001/atom-beautify/releases{/id}","deployments_url":"https://api.github.com/repos/Glavin001/atom-beautify/deployments","created_at":"2014-03-03T06:09:24Z","updated_at":"2016-12-21T19:21:09Z","pushed_at":"2016-12-20T15:20:26Z","git_url":"git://github.com/Glavin001/atom-beautify.git","ssh_url":"git@github.com:Glavin001/atom-beautify.git","clone_url":"https://github.com/Glavin001/atom-beautify.git","svn_url":"https://github.com/Glavin001/atom-beautify","homepage":"http://glavin001.github.io/atom-beautify/docs/code/","size":1756,"stargazers_count":755,"watchers_count":755,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":269,"mirror_url":null,"open_issues_count":561,"forks":269,"open_issues":561,"watchers":755,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/1421"},"html":{"href":"https://github.com/Glavin001/atom-beautify/pull/1421"},"issue":{"href":"https://api.github.com/repos/Glavin001/atom-beautify/issues/1421"},"comments":{"href":"https://api.github.com/repos/Glavin001/atom-beautify/issues/1421/comments"},"review_comments":{"href":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/1421/comments"},"review_comment":{"href":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Glavin001/atom-beautify/pulls/1421/commits"},"statuses":{"href":"https://api.github.com/repos/Glavin001/atom-beautify/statuses/0366866152dfadf4d644b9c2946e80788bb387f0"}}}}
{"actor":{"display_login":"lexmag"}}