{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/hhvm/issues/7480","repository_url":"https://api.github.com/repos/facebook/hhvm","labels_url":"https://api.github.com/repos/facebook/hhvm/issues/7480/labels{/name}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/7480/comments","events_url":"https://api.github.com/repos/facebook/hhvm/issues/7480/events","html_url":"https://github.com/facebook/hhvm/pull/7480","id":188277308,"number":7480,"title":"remove unneeded assertions (Aarch64)","user":{"login":"swalk-cavium","id":23059300,"avatar_url":"https://avatars.githubusercontent.com/u/23059300?v=3","gravatar_id":"","url":"https://api.github.com/users/swalk-cavium","html_url":"https://github.com/swalk-cavium","followers_url":"https://api.github.com/users/swalk-cavium/followers","following_url":"https://api.github.com/users/swalk-cavium/following{/other_user}","gists_url":"https://api.github.com/users/swalk-cavium/gists{/gist_id}","starred_url":"https://api.github.com/users/swalk-cavium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalk-cavium/subscriptions","organizations_url":"https://api.github.com/users/swalk-cavium/orgs","repos_url":"https://api.github.com/users/swalk-cavium/repos","events_url":"https://api.github.com/users/swalk-cavium/events{/privacy}","received_events_url":"https://api.github.com/users/swalk-cavium/received_events","type":"User","site_admin":false},"labels":[{"id":196857004,"url":"https://api.github.com/repos/facebook/hhvm/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false},{"id":434441950,"url":"https://api.github.com/repos/facebook/hhvm/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"mxw","id":1013739,"avatar_url":"https://avatars.githubusercontent.com/u/1013739?v=3","gravatar_id":"","url":"https://api.github.com/users/mxw","html_url":"https://github.com/mxw","followers_url":"https://api.github.com/users/mxw/followers","following_url":"https://api.github.com/users/mxw/following{/other_user}","gists_url":"https://api.github.com/users/mxw/gists{/gist_id}","starred_url":"https://api.github.com/users/mxw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxw/subscriptions","organizations_url":"https://api.github.com/users/mxw/orgs","repos_url":"https://api.github.com/users/mxw/repos","events_url":"https://api.github.com/users/mxw/events{/privacy}","received_events_url":"https://api.github.com/users/mxw/received_events","type":"User","site_admin":false},"assignees":[{"login":"mxw","id":1013739,"avatar_url":"https://avatars.githubusercontent.com/u/1013739?v=3","gravatar_id":"","url":"https://api.github.com/users/mxw","html_url":"https://github.com/mxw","followers_url":"https://api.github.com/users/mxw/followers","following_url":"https://api.github.com/users/mxw/following{/other_user}","gists_url":"https://api.github.com/users/mxw/gists{/gist_id}","starred_url":"https://api.github.com/users/mxw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxw/subscriptions","organizations_url":"https://api.github.com/users/mxw/orgs","repos_url":"https://api.github.com/users/mxw/repos","events_url":"https://api.github.com/users/mxw/events{/privacy}","received_events_url":"https://api.github.com/users/mxw/received_events","type":"User","site_admin":false}],"milestone":null,"comments":24,"created_at":"2016-11-09T15:38:22Z","updated_at":"2016-11-29T17:04:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/hhvm/pulls/7480","html_url":"https://github.com/facebook/hhvm/pull/7480","diff_url":"https://github.com/facebook/hhvm/pull/7480.diff","patch_url":"https://github.com/facebook/hhvm/pull/7480.patch"},"body":"\r\nOn a debug build for an Aarch64 host  the following test was failing due to an assertion:\r\n\r\nhphp/test/zend/good/ext/intl/tests/grapheme.php\r\n\r\nThe assertion was not needed since the call to the macro assembler will use a temporary\r\nif the immediate is out of range.\r\n\r\nAdditionally, two other regression tests now pass.  They are:\r\n\r\nhphp/test/slow/stack-overflow/reenter.php\r\nhphp/test/slow/stack-overflow/catch-trace-rematerialize.php\r\n\r\nThe change was tested with 6 different option sets.\r\n\r\n/usr/bin/php hphp/test/run -v --no-fun -m interp  \r\n/usr/bin/php hphp/test/run -v --no-fun -m interp -r \r\n/usr/bin/php hphp/test/run -v --no-fun -m jit -a '-vEval.JitPGO=0' \r\n/usr/bin/php hphp/test/run -v --no-fun -m jit -r -a '-vEval.JitPGO=0' \r\n/usr/bin/php hphp/test/run -v --no-fun -m jit -a '-vEval.JitPGO=1' \r\n/usr/bin/php hphp/test/run -v --no-fun -m jit -r -a '-vEval.JitPGO=1'  \r\n\r\nThis was the git log for the repository before commit\r\nswalk@1scrb-7:~/master/hhvm$ git log | head\r\ncommit 7e3addb8bc1cf1e3dbbab2de6f1690050ea33b71\r\nAuthor: Michael O'Farrell <michaelofarrell@fb.com>\r\nDate:   Mon Nov 7 07:04:47 2016 -0800\r\n\r\nThis was the repository before I pushed the change to github\r\nswalk@1scrb-7:~/master/hhvm_110816/hhvm$ git log | head\r\ncommit 8f964f0cc101acdc8e8c5e3d43497a6d41a6b0d0\r\nAuthor: Steve Walk <Steve.Walk@cavium.com>\r\nDate:   Wed Nov 9 07:08:25 2016 -0800\r\n\r\nA CLA was submitted last week.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/hhvm/issues/comments/263631839","html_url":"https://github.com/facebook/hhvm/pull/7480#issuecomment-263631839","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/7480","id":263631839,"user":{"login":"cmuellner","id":92810,"avatar_url":"https://avatars.githubusercontent.com/u/92810?v=3","gravatar_id":"","url":"https://api.github.com/users/cmuellner","html_url":"https://github.com/cmuellner","followers_url":"https://api.github.com/users/cmuellner/followers","following_url":"https://api.github.com/users/cmuellner/following{/other_user}","gists_url":"https://api.github.com/users/cmuellner/gists{/gist_id}","starred_url":"https://api.github.com/users/cmuellner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmuellner/subscriptions","organizations_url":"https://api.github.com/users/cmuellner/orgs","repos_url":"https://api.github.com/users/cmuellner/repos","events_url":"https://api.github.com/users/cmuellner/events{/privacy}","received_events_url":"https://api.github.com/users/cmuellner/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T17:04:46Z","updated_at":"2016-11-29T17:04:46Z","body":"@dave-estes, I think it's worth mentioning here, that Mov(temp, addr.offset()) is again a\r\nMacroAssember function, which allows 64-bit immediates (for 64-bit destination registers).\r\nIt also minimises the emitted mov instructions (to build up the offset in a register)."}}
{"actor":{"display_login":"cmuellner"}}