{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/65692862","id":65692862,"diff_hunk":"@@ -341,6 +341,21 @@ include(\"docs/Docs.jl\")\n using .Docs, .Markdown\n Docs.loaddocs(Core.Inference.CoreDocs.DOCS)\n \n+# String constructor docstring, ugly workaround for #16730\n+Docs.doc!(Docs.Binding(current_module(),:String), Docs.docstr(Core.svec(\n+\"\"\"\n+    String(v::Vector{UInt8})\n+\n+Create a new `String` from a vector `v` of bytes containing\n+UTF-8 encoded characters.   This function takes \"ownership\" of\n+the array, which means that you should not subsequently modify\n+`v` (since strings are supposed to be immutable in Julia) for\n+as long as the string exists.\n+\n+If you need to subsequently modify `v`, use `String(copy(v))` instead.\n+\"\"\"\n+), Dict(:source => :(String(v::Vector{UInt8}) = new(v)), :path=>\"boot.jl\", :linenumber=>219, :module=>current_module())), Tuple{Vector{UInt8}})\n+","path":"base/sysimg.jl","position":18,"original_position":18,"commit_id":"92ad69cb9fab5bd3fc82e0ada32c7526a13a4f8d","original_commit_id":"92ad69cb9fab5bd3fc82e0ada32c7526a13a4f8d","user":{"login":"stevengj","id":2913679,"avatar_url":"https://avatars.githubusercontent.com/u/2913679?v=3","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"body":"Ah, I didn't know that you could use a docstring with the call syntax.   Is this documented anywhere?  If not, it should be.","created_at":"2016-06-03T11:24:52Z","updated_at":"2016-06-03T11:24:52Z","html_url":"https://github.com/JuliaLang/julia/pull/16731#discussion_r65692862","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/16731","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/65692862"},"html":{"href":"https://github.com/JuliaLang/julia/pull/16731#discussion_r65692862"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/16731"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/16731","id":72446003,"html_url":"https://github.com/JuliaLang/julia/pull/16731","diff_url":"https://github.com/JuliaLang/julia/pull/16731.diff","patch_url":"https://github.com/JuliaLang/julia/pull/16731.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/16731","number":16731,"state":"open","locked":false,"title":"restore non-copying String behavior, add unsafe_string*, ...","user":{"login":"stevengj","id":2913679,"avatar_url":"https://avatars.githubusercontent.com/u/2913679?v=3","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"body":"This PR closes #16470 and #16713.    It:\r\n\r\n* Restores the old non-copying behavior of the `String(a::Vector{UInt8})` constructor, which once again takes ownership of the array.  `bytestring(a)` is now deprecated to `String(copy(a))`.\r\n\r\n* Renames `String(ptr, len)` to `unsafe_string(ptr, len)` (this function makes a copy from a pointer).\r\n\r\n* Renames `pointer_to_string(ptr, len)` to `unsafe_string_wrapper(ptr, len)`, which is hopefully more descriptive and now begins with `unsafe` as people seem to prefer.  (This function does not copy the date, but simply \"wraps\" a `String` around the data.)\r\n\r\n* Renames `pointer_to_array` to `unsafe_array_wrapper` for consistency.\r\n\r\n(Note that I had to work around #16730 to document the  `String(a::Vector{UInt8})` constructor by calling `doc!` manually.)\r\n\r\nIn the course of making this change, I had to manually inspect every call to `String(...)`, and I cleaned up many of the call sites somewhat.","created_at":"2016-06-03T02:32:56Z","updated_at":"2016-06-03T11:24:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8b3311dd3cc2937545916696270168fca105bae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/16731/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/16731/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/16731/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/92ad69cb9fab5bd3fc82e0ada32c7526a13a4f8d","head":{"label":"stevengj:unsafe_string","ref":"unsafe_string","sha":"92ad69cb9fab5bd3fc82e0ada32c7526a13a4f8d","user":{"login":"stevengj","id":2913679,"avatar_url":"https://avatars.githubusercontent.com/u/2913679?v=3","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"repo":{"id":7264997,"name":"julia","full_name":"stevengj/julia","owner":{"login":"stevengj","id":2913679,"avatar_url":"https://avatars.githubusercontent.com/u/2913679?v=3","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevengj/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/stevengj/julia","forks_url":"https://api.github.com/repos/stevengj/julia/forks","keys_url":"https://api.github.com/repos/stevengj/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevengj/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevengj/julia/teams","hooks_url":"https://api.github.com/repos/stevengj/julia/hooks","issue_events_url":"https://api.github.com/repos/stevengj/julia/issues/events{/number}","events_url":"https://api.github.com/repos/stevengj/julia/events","assignees_url":"https://api.github.com/repos/stevengj/julia/assignees{/user}","branches_url":"https://api.github.com/repos/stevengj/julia/branches{/branch}","tags_url":"https://api.github.com/repos/stevengj/julia/tags","blobs_url":"https://api.github.com/repos/stevengj/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevengj/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevengj/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevengj/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevengj/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/stevengj/julia/languages","stargazers_url":"https://api.github.com/repos/stevengj/julia/stargazers","contributors_url":"https://api.github.com/repos/stevengj/julia/contributors","subscribers_url":"https://api.github.com/repos/stevengj/julia/subscribers","subscription_url":"https://api.github.com/repos/stevengj/julia/subscription","commits_url":"https://api.github.com/repos/stevengj/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevengj/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevengj/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevengj/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevengj/julia/contents/{+path}","compare_url":"https://api.github.com/repos/stevengj/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevengj/julia/merges","archive_url":"https://api.github.com/repos/stevengj/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevengj/julia/downloads","issues_url":"https://api.github.com/repos/stevengj/julia/issues{/number}","pulls_url":"https://api.github.com/repos/stevengj/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/stevengj/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/stevengj/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevengj/julia/labels{/name}","releases_url":"https://api.github.com/repos/stevengj/julia/releases{/id}","deployments_url":"https://api.github.com/repos/stevengj/julia/deployments","created_at":"2012-12-20T21:59:35Z","updated_at":"2015-11-06T22:23:44Z","pushed_at":"2016-06-03T02:27:15Z","git_url":"git://github.com/stevengj/julia.git","ssh_url":"git@github.com:stevengj/julia.git","clone_url":"https://github.com/stevengj/julia.git","svn_url":"https://github.com/stevengj/julia","homepage":"http://julialang.org/","size":84986,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"02bd2db7577a33a470ef48df6103a6b1cfa0d555","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-06-03T06:48:33Z","pushed_at":"2016-06-03T11:06:54Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":386792,"stargazers_count":7090,"watchers_count":7090,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1639,"mirror_url":null,"open_issues_count":1805,"forks":1639,"open_issues":1805,"watchers":7090,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/16731"},"html":{"href":"https://github.com/JuliaLang/julia/pull/16731"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/16731"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/16731/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/16731/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/16731/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/92ad69cb9fab5bd3fc82e0ada32c7526a13a4f8d"}}}}
{"actor":{"display_login":"stevengj"}}