{"action":"created","issue":{"url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/91","repository_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule","labels_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/91/labels{/name}","comments_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/91/comments","events_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/91/events","html_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule/pull/91","id":168428968,"number":91,"title":"removed ServiceEndpoint magic number for port","user":{"login":"hakanson","id":414500,"avatar_url":"https://avatars.githubusercontent.com/u/414500?v=3","gravatar_id":"","url":"https://api.github.com/users/hakanson","html_url":"https://github.com/hakanson","followers_url":"https://api.github.com/users/hakanson/followers","following_url":"https://api.github.com/users/hakanson/following{/other_user}","gists_url":"https://api.github.com/users/hakanson/gists{/gist_id}","starred_url":"https://api.github.com/users/hakanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakanson/subscriptions","organizations_url":"https://api.github.com/users/hakanson/orgs","repos_url":"https://api.github.com/users/hakanson/repos","events_url":"https://api.github.com/users/hakanson/events{/privacy}","received_events_url":"https://api.github.com/users/hakanson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-29T22:47:08Z","updated_at":"2016-08-01T12:38:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/91","html_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule/pull/91","diff_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule/pull/91.diff","patch_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule/pull/91.patch"},"body":"require port to be passed in to all GetLocalEndpoint calls, and derive\nfrom domain.Port in SpanTracer (similar to how serviceName is derived\nfrom domain.Host)"},"comment":{"url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/comments/236569128","html_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule/pull/91#issuecomment-236569128","issue_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/91","id":236569128,"user":{"login":"hakanson","id":414500,"avatar_url":"https://avatars.githubusercontent.com/u/414500?v=3","gravatar_id":"","url":"https://api.github.com/users/hakanson","html_url":"https://github.com/hakanson","followers_url":"https://api.github.com/users/hakanson/followers","following_url":"https://api.github.com/users/hakanson/following{/other_user}","gists_url":"https://api.github.com/users/hakanson/gists{/gist_id}","starred_url":"https://api.github.com/users/hakanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakanson/subscriptions","organizations_url":"https://api.github.com/users/hakanson/orgs","repos_url":"https://api.github.com/users/hakanson/repos","events_url":"https://api.github.com/users/hakanson/events{/privacy}","received_events_url":"https://api.github.com/users/hakanson/received_events","type":"User","site_admin":false},"created_at":"2016-08-01T12:38:28Z","updated_at":"2016-08-01T12:38:28Z","body":"@cabbott I guess it would be a breaking change for any external callers of the `GetLocalEndpoint` method which could be fixed by adding the parameter default value back.  If so, would you still default as `443` or change to `0` per my previous comment?"}}
{"actor":{"display_login":"hakanson"}}