{"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/64725720","id":64725720,"diff_hunk":"@@ -15,4 +16,9 @@ def migrate(*args, **kwargs):\n             distributor[key] = distributor['last_publish']","path":"server/pulp/server/db/migrations/0024_distributor_last_updated.py","position":13,"original_position":13,"commit_id":"57574f6e9318cf5775789ac2f1bf7ca4fd059a13","original_commit_id":"57574f6e9318cf5775789ac2f1bf7ca4fd059a13","user":{"login":"goosemania","id":16638409,"avatar_url":"https://avatars.githubusercontent.com/u/16638409?v=3","gravatar_id":"","url":"https://api.github.com/users/goosemania","html_url":"https://github.com/goosemania","followers_url":"https://api.github.com/users/goosemania/followers","following_url":"https://api.github.com/users/goosemania/following{/other_user}","gists_url":"https://api.github.com/users/goosemania/gists{/gist_id}","starred_url":"https://api.github.com/users/goosemania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goosemania/subscriptions","organizations_url":"https://api.github.com/users/goosemania/orgs","repos_url":"https://api.github.com/users/goosemania/repos","events_url":"https://api.github.com/users/goosemania/events{/privacy}","received_events_url":"https://api.github.com/users/goosemania/received_events","type":"User","site_admin":false},"body":"This first `continue` will prevent you to check the `key2`, you will just move on to the next distributor.\r\nMy suggestion is not to use `continue` at all in this case. How about this:\r\n```\r\nif 'last_publish' in distributor:\r\n    distributor[key] = distributor['last_publish']\r\nelif key not in distributor:\r\n    distributor[key] = dateutils.now_utc_datetime_with_tzinfo()\r\n```\r\nDoes it make sense or maybe I am missing something?\r\n ","created_at":"2016-05-26T10:46:17Z","updated_at":"2016-05-26T10:46:17Z","html_url":"https://github.com/pulp/pulp/pull/2584#discussion_r64725720","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/2584","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/64725720"},"html":{"href":"https://github.com/pulp/pulp/pull/2584#discussion_r64725720"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2584"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp/pulls/2584","id":71521471,"html_url":"https://github.com/pulp/pulp/pull/2584","diff_url":"https://github.com/pulp/pulp/pull/2584.diff","patch_url":"https://github.com/pulp/pulp/pull/2584.patch","issue_url":"https://api.github.com/repos/pulp/pulp/issues/2584","number":2584,"state":"open","locked":false,"title":"Publish should be operational if override config values were specified","user":{"login":"ipanova","id":4253816,"avatar_url":"https://avatars.githubusercontent.com/u/4253816?v=3","gravatar_id":"","url":"https://api.github.com/users/ipanova","html_url":"https://github.com/ipanova","followers_url":"https://api.github.com/users/ipanova/followers","following_url":"https://api.github.com/users/ipanova/following{/other_user}","gists_url":"https://api.github.com/users/ipanova/gists{/gist_id}","starred_url":"https://api.github.com/users/ipanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipanova/subscriptions","organizations_url":"https://api.github.com/users/ipanova/orgs","repos_url":"https://api.github.com/users/ipanova/repos","events_url":"https://api.github.com/users/ipanova/events{/privacy}","received_events_url":"https://api.github.com/users/ipanova/received_events","type":"User","site_admin":false},"body":"closes #1928\r\nhttps://pulp.plan.io/issues/1928","created_at":"2016-05-26T08:58:24Z","updated_at":"2016-05-26T10:46:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5452ff7023e21951e84c72f0a561bdf95e7002dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp/pulls/2584/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp/pulls/2584/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulp/pulp/issues/2584/comments","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/57574f6e9318cf5775789ac2f1bf7ca4fd059a13","head":{"label":"ipanova:override-conf","ref":"override-conf","sha":"57574f6e9318cf5775789ac2f1bf7ca4fd059a13","user":{"login":"ipanova","id":4253816,"avatar_url":"https://avatars.githubusercontent.com/u/4253816?v=3","gravatar_id":"","url":"https://api.github.com/users/ipanova","html_url":"https://github.com/ipanova","followers_url":"https://api.github.com/users/ipanova/followers","following_url":"https://api.github.com/users/ipanova/following{/other_user}","gists_url":"https://api.github.com/users/ipanova/gists{/gist_id}","starred_url":"https://api.github.com/users/ipanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipanova/subscriptions","organizations_url":"https://api.github.com/users/ipanova/orgs","repos_url":"https://api.github.com/users/ipanova/repos","events_url":"https://api.github.com/users/ipanova/events{/privacy}","received_events_url":"https://api.github.com/users/ipanova/received_events","type":"User","site_admin":false},"repo":{"id":17410078,"name":"pulp","full_name":"ipanova/pulp","owner":{"login":"ipanova","id":4253816,"avatar_url":"https://avatars.githubusercontent.com/u/4253816?v=3","gravatar_id":"","url":"https://api.github.com/users/ipanova","html_url":"https://github.com/ipanova","followers_url":"https://api.github.com/users/ipanova/followers","following_url":"https://api.github.com/users/ipanova/following{/other_user}","gists_url":"https://api.github.com/users/ipanova/gists{/gist_id}","starred_url":"https://api.github.com/users/ipanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipanova/subscriptions","organizations_url":"https://api.github.com/users/ipanova/orgs","repos_url":"https://api.github.com/users/ipanova/repos","events_url":"https://api.github.com/users/ipanova/events{/privacy}","received_events_url":"https://api.github.com/users/ipanova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ipanova/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":true,"url":"https://api.github.com/repos/ipanova/pulp","forks_url":"https://api.github.com/repos/ipanova/pulp/forks","keys_url":"https://api.github.com/repos/ipanova/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipanova/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipanova/pulp/teams","hooks_url":"https://api.github.com/repos/ipanova/pulp/hooks","issue_events_url":"https://api.github.com/repos/ipanova/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/ipanova/pulp/events","assignees_url":"https://api.github.com/repos/ipanova/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/ipanova/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/ipanova/pulp/tags","blobs_url":"https://api.github.com/repos/ipanova/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipanova/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipanova/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipanova/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipanova/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/ipanova/pulp/languages","stargazers_url":"https://api.github.com/repos/ipanova/pulp/stargazers","contributors_url":"https://api.github.com/repos/ipanova/pulp/contributors","subscribers_url":"https://api.github.com/repos/ipanova/pulp/subscribers","subscription_url":"https://api.github.com/repos/ipanova/pulp/subscription","commits_url":"https://api.github.com/repos/ipanova/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipanova/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipanova/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipanova/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipanova/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/ipanova/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipanova/pulp/merges","archive_url":"https://api.github.com/repos/ipanova/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipanova/pulp/downloads","issues_url":"https://api.github.com/repos/ipanova/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/ipanova/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/ipanova/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/ipanova/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipanova/pulp/labels{/name}","releases_url":"https://api.github.com/repos/ipanova/pulp/releases{/id}","deployments_url":"https://api.github.com/repos/ipanova/pulp/deployments","created_at":"2014-03-04T17:13:28Z","updated_at":"2015-01-06T12:05:33Z","pushed_at":"2016-05-26T09:07:14Z","git_url":"git://github.com/ipanova/pulp.git","ssh_url":"git@github.com:ipanova/pulp.git","clone_url":"https://github.com/ipanova/pulp.git","svn_url":"https://github.com/ipanova/pulp","homepage":"","size":91295,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:master","ref":"master","sha":"9129e7b9b7585c0e8ad6f68d27032f474ebefa12","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":5314652,"name":"pulp","full_name":"pulp/pulp","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":false,"url":"https://api.github.com/repos/pulp/pulp","forks_url":"https://api.github.com/repos/pulp/pulp/forks","keys_url":"https://api.github.com/repos/pulp/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp/teams","hooks_url":"https://api.github.com/repos/pulp/pulp/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp/events","assignees_url":"https://api.github.com/repos/pulp/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp/tags","blobs_url":"https://api.github.com/repos/pulp/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp/subscription","commits_url":"https://api.github.com/repos/pulp/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp/merges","archive_url":"https://api.github.com/repos/pulp/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp/downloads","issues_url":"https://api.github.com/repos/pulp/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp/releases{/id}","deployments_url":"https://api.github.com/repos/pulp/pulp/deployments","created_at":"2012-08-06T13:49:20Z","updated_at":"2016-04-28T23:19:54Z","pushed_at":"2016-05-26T09:07:15Z","git_url":"git://github.com/pulp/pulp.git","ssh_url":"git@github.com:pulp/pulp.git","clone_url":"https://github.com/pulp/pulp.git","svn_url":"https://github.com/pulp/pulp","homepage":"","size":103274,"stargazers_count":265,"watchers_count":265,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":14,"forks":104,"open_issues":14,"watchers":265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2584"},"html":{"href":"https://github.com/pulp/pulp/pull/2584"},"issue":{"href":"https://api.github.com/repos/pulp/pulp/issues/2584"},"comments":{"href":"https://api.github.com/repos/pulp/pulp/issues/2584/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2584/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2584/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp/statuses/57574f6e9318cf5775789ac2f1bf7ca4fd059a13"}}}}
{"actor":{"display_login":"goosemania"}}