{"action":"created","comment":{"url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/comments/51637521","id":51637521,"diff_hunk":"@@ -110,6 +110,25 @@ describe('FullStory', function() {\n         analytics.identify('id3', { name: 'Steven', registered: true });\n         analytics.called(window.FS.identify, 'id3', { displayName: 'Steven', registered_bool: true });\n       });\n+\n+      it('should map arrays properly', function() {\n+        analytics.identify('id3', { teams: ['eng', 'redsox'] });\n+        analytics.called(window.FS.identify, 'id3', { teams: [ 'eng', 'redsox'] });","path":"test/index.test.js","position":7,"original_position":7,"commit_id":"483e6901e7f37137566678b2583795756debb2a7","original_commit_id":"483e6901e7f37137566678b2583795756debb2a7","user":{"login":"sbrubaker","id":1949968,"avatar_url":"https://avatars.githubusercontent.com/u/1949968?v=3","gravatar_id":"","url":"https://api.github.com/users/sbrubaker","html_url":"https://github.com/sbrubaker","followers_url":"https://api.github.com/users/sbrubaker/followers","following_url":"https://api.github.com/users/sbrubaker/following{/other_user}","gists_url":"https://api.github.com/users/sbrubaker/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrubaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrubaker/subscriptions","organizations_url":"https://api.github.com/users/sbrubaker/orgs","repos_url":"https://api.github.com/users/sbrubaker/repos","events_url":"https://api.github.com/users/sbrubaker/events{/privacy}","received_events_url":"https://api.github.com/users/sbrubaker/received_events","type":"User","site_admin":false},"body":"Ah, right, I forgot that those checks are in _our_ code, not theirs.","created_at":"2016-02-02T21:24:40Z","updated_at":"2016-02-02T21:24:40Z","html_url":"https://github.com/fullstorydev/segment-integration-fullstory/pull/2#discussion_r51637521","pull_request_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/comments/51637521"},"html":{"href":"https://github.com/fullstorydev/segment-integration-fullstory/pull/2#discussion_r51637521"},"pull_request":{"href":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/2","id":57127275,"html_url":"https://github.com/fullstorydev/segment-integration-fullstory/pull/2","diff_url":"https://github.com/fullstorydev/segment-integration-fullstory/pull/2.diff","patch_url":"https://github.com/fullstorydev/segment-integration-fullstory/pull/2.patch","issue_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/issues/2","number":2,"state":"open","locked":false,"title":"Allow Segment to map componound (array and object) traits into multiple FS user variables","user":{"login":"fka3","id":1714141,"avatar_url":"https://avatars.githubusercontent.com/u/1714141?v=3","gravatar_id":"","url":"https://api.github.com/users/fka3","html_url":"https://github.com/fka3","followers_url":"https://api.github.com/users/fka3/followers","following_url":"https://api.github.com/users/fka3/following{/other_user}","gists_url":"https://api.github.com/users/fka3/gists{/gist_id}","starred_url":"https://api.github.com/users/fka3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fka3/subscriptions","organizations_url":"https://api.github.com/users/fka3/orgs","repos_url":"https://api.github.com/users/fka3/repos","events_url":"https://api.github.com/users/fka3/events{/privacy}","received_events_url":"https://api.github.com/users/fka3/received_events","type":"User","site_admin":false},"body":"This from that user issue in which they passed object traits to segment, which failed to find a supported type for them, but ended up assigning the result to \"undefined\" as a string instead.  We could trap the object type, of course, to keep the original name... but eventually we still have to decide what to do with the object value!\r\n\r\nThe camel caser doesn't like syntex like array[3] or parent.child (they become array3 and parentChild),\r\nbut I didn't bother to fight with it over those.","created_at":"2016-01-25T20:41:41Z","updated_at":"2016-02-02T21:24:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26ee55786c21e85d4ed4410ce4017a53622027c4","assignee":{"login":"sbrubaker","id":1949968,"avatar_url":"https://avatars.githubusercontent.com/u/1949968?v=3","gravatar_id":"","url":"https://api.github.com/users/sbrubaker","html_url":"https://github.com/sbrubaker","followers_url":"https://api.github.com/users/sbrubaker/followers","following_url":"https://api.github.com/users/sbrubaker/following{/other_user}","gists_url":"https://api.github.com/users/sbrubaker/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrubaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrubaker/subscriptions","organizations_url":"https://api.github.com/users/sbrubaker/orgs","repos_url":"https://api.github.com/users/sbrubaker/repos","events_url":"https://api.github.com/users/sbrubaker/events{/privacy}","received_events_url":"https://api.github.com/users/sbrubaker/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/2/commits","review_comments_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/2/comments","review_comment_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/issues/2/comments","statuses_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/statuses/483e6901e7f37137566678b2583795756debb2a7","head":{"label":"fullstorydev:fka3/flattenobjects","ref":"fka3/flattenobjects","sha":"483e6901e7f37137566678b2583795756debb2a7","user":{"login":"fullstorydev","id":1509102,"avatar_url":"https://avatars.githubusercontent.com/u/1509102?v=3","gravatar_id":"","url":"https://api.github.com/users/fullstorydev","html_url":"https://github.com/fullstorydev","followers_url":"https://api.github.com/users/fullstorydev/followers","following_url":"https://api.github.com/users/fullstorydev/following{/other_user}","gists_url":"https://api.github.com/users/fullstorydev/gists{/gist_id}","starred_url":"https://api.github.com/users/fullstorydev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fullstorydev/subscriptions","organizations_url":"https://api.github.com/users/fullstorydev/orgs","repos_url":"https://api.github.com/users/fullstorydev/repos","events_url":"https://api.github.com/users/fullstorydev/events{/privacy}","received_events_url":"https://api.github.com/users/fullstorydev/received_events","type":"Organization","site_admin":false},"repo":{"id":47706215,"name":"segment-integration-fullstory","full_name":"fullstorydev/segment-integration-fullstory","owner":{"login":"fullstorydev","id":1509102,"avatar_url":"https://avatars.githubusercontent.com/u/1509102?v=3","gravatar_id":"","url":"https://api.github.com/users/fullstorydev","html_url":"https://github.com/fullstorydev","followers_url":"https://api.github.com/users/fullstorydev/followers","following_url":"https://api.github.com/users/fullstorydev/following{/other_user}","gists_url":"https://api.github.com/users/fullstorydev/gists{/gist_id}","starred_url":"https://api.github.com/users/fullstorydev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fullstorydev/subscriptions","organizations_url":"https://api.github.com/users/fullstorydev/orgs","repos_url":"https://api.github.com/users/fullstorydev/repos","events_url":"https://api.github.com/users/fullstorydev/events{/privacy}","received_events_url":"https://api.github.com/users/fullstorydev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fullstorydev/segment-integration-fullstory","description":"The Fullstory analytics.js integration.","fork":true,"url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory","forks_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/forks","keys_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/teams","hooks_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/hooks","issue_events_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/issues/events{/number}","events_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/events","assignees_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/assignees{/user}","branches_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/branches{/branch}","tags_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/tags","blobs_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/git/refs{/sha}","trees_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/statuses/{sha}","languages_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/languages","stargazers_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/stargazers","contributors_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/contributors","subscribers_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/subscribers","subscription_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/subscription","commits_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/commits{/sha}","git_commits_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/git/commits{/sha}","comments_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/comments{/number}","issue_comment_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/issues/comments{/number}","contents_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/contents/{+path}","compare_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/merges","archive_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/downloads","issues_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/issues{/number}","pulls_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls{/number}","milestones_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/milestones{/number}","notifications_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/labels{/name}","releases_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/releases{/id}","deployments_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/deployments","created_at":"2015-12-09T17:06:02Z","updated_at":"2015-12-09T17:06:29Z","pushed_at":"2016-02-02T19:53:59Z","git_url":"git://github.com/fullstorydev/segment-integration-fullstory.git","ssh_url":"git@github.com:fullstorydev/segment-integration-fullstory.git","clone_url":"https://github.com/fullstorydev/segment-integration-fullstory.git","svn_url":"https://github.com/fullstorydev/segment-integration-fullstory","homepage":"https://segment.com/docs/integrations/fullstory/","size":17,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"fullstorydev:master","ref":"master","sha":"801b98e7ceb6ba9045a1e75fdd7f966fe427f4d4","user":{"login":"fullstorydev","id":1509102,"avatar_url":"https://avatars.githubusercontent.com/u/1509102?v=3","gravatar_id":"","url":"https://api.github.com/users/fullstorydev","html_url":"https://github.com/fullstorydev","followers_url":"https://api.github.com/users/fullstorydev/followers","following_url":"https://api.github.com/users/fullstorydev/following{/other_user}","gists_url":"https://api.github.com/users/fullstorydev/gists{/gist_id}","starred_url":"https://api.github.com/users/fullstorydev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fullstorydev/subscriptions","organizations_url":"https://api.github.com/users/fullstorydev/orgs","repos_url":"https://api.github.com/users/fullstorydev/repos","events_url":"https://api.github.com/users/fullstorydev/events{/privacy}","received_events_url":"https://api.github.com/users/fullstorydev/received_events","type":"Organization","site_admin":false},"repo":{"id":47706215,"name":"segment-integration-fullstory","full_name":"fullstorydev/segment-integration-fullstory","owner":{"login":"fullstorydev","id":1509102,"avatar_url":"https://avatars.githubusercontent.com/u/1509102?v=3","gravatar_id":"","url":"https://api.github.com/users/fullstorydev","html_url":"https://github.com/fullstorydev","followers_url":"https://api.github.com/users/fullstorydev/followers","following_url":"https://api.github.com/users/fullstorydev/following{/other_user}","gists_url":"https://api.github.com/users/fullstorydev/gists{/gist_id}","starred_url":"https://api.github.com/users/fullstorydev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fullstorydev/subscriptions","organizations_url":"https://api.github.com/users/fullstorydev/orgs","repos_url":"https://api.github.com/users/fullstorydev/repos","events_url":"https://api.github.com/users/fullstorydev/events{/privacy}","received_events_url":"https://api.github.com/users/fullstorydev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fullstorydev/segment-integration-fullstory","description":"The Fullstory analytics.js integration.","fork":true,"url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory","forks_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/forks","keys_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/teams","hooks_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/hooks","issue_events_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/issues/events{/number}","events_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/events","assignees_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/assignees{/user}","branches_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/branches{/branch}","tags_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/tags","blobs_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/git/refs{/sha}","trees_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/statuses/{sha}","languages_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/languages","stargazers_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/stargazers","contributors_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/contributors","subscribers_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/subscribers","subscription_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/subscription","commits_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/commits{/sha}","git_commits_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/git/commits{/sha}","comments_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/comments{/number}","issue_comment_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/issues/comments{/number}","contents_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/contents/{+path}","compare_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/merges","archive_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/downloads","issues_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/issues{/number}","pulls_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls{/number}","milestones_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/milestones{/number}","notifications_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/labels{/name}","releases_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/releases{/id}","deployments_url":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/deployments","created_at":"2015-12-09T17:06:02Z","updated_at":"2015-12-09T17:06:29Z","pushed_at":"2016-02-02T19:53:59Z","git_url":"git://github.com/fullstorydev/segment-integration-fullstory.git","ssh_url":"git@github.com:fullstorydev/segment-integration-fullstory.git","clone_url":"https://github.com/fullstorydev/segment-integration-fullstory.git","svn_url":"https://github.com/fullstorydev/segment-integration-fullstory","homepage":"https://segment.com/docs/integrations/fullstory/","size":17,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/2"},"html":{"href":"https://github.com/fullstorydev/segment-integration-fullstory/pull/2"},"issue":{"href":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/issues/2"},"comments":{"href":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/fullstorydev/segment-integration-fullstory/statuses/483e6901e7f37137566678b2583795756debb2a7"}}}}