{"action":"opened","issue":{"url":"https://api.github.com/repos/jpauley16/MTGStorage/issues/2","repository_url":"https://api.github.com/repos/jpauley16/MTGStorage","labels_url":"https://api.github.com/repos/jpauley16/MTGStorage/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/jpauley16/MTGStorage/issues/2/comments","events_url":"https://api.github.com/repos/jpauley16/MTGStorage/issues/2/events","html_url":"https://github.com/jpauley16/MTGStorage/issues/2","id":179863662,"number":2,"title":"Code Review","user":{"login":"mdhanson3","id":15114622,"avatar_url":"https://avatars.githubusercontent.com/u/15114622?v=3","gravatar_id":"","url":"https://api.github.com/users/mdhanson3","html_url":"https://github.com/mdhanson3","followers_url":"https://api.github.com/users/mdhanson3/followers","following_url":"https://api.github.com/users/mdhanson3/following{/other_user}","gists_url":"https://api.github.com/users/mdhanson3/gists{/gist_id}","starred_url":"https://api.github.com/users/mdhanson3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdhanson3/subscriptions","organizations_url":"https://api.github.com/users/mdhanson3/orgs","repos_url":"https://api.github.com/users/mdhanson3/repos","events_url":"https://api.github.com/users/mdhanson3/events{/privacy}","received_events_url":"https://api.github.com/users/mdhanson3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-28T19:22:10Z","updated_at":"2016-09-28T19:22:10Z","closed_at":null,"body":"# Design/Code Review 1\r\n\r\n## Project: MTG Storage\r\n\r\n### Developer: Jeff\r\n\r\n#### Reviewer: Mitch Hanson\r\n\r\n|Category|Criteria|Rating/Comments|\r\n|--------|---------|---------------|\r\n|**Problem Statement**|Does it exist?| Yes.|\r\n||Does the problem statement accurately describe project purpose?| Yes. |\r\n||Is the problem statement professional? Think of prospective employers viewing this as part of the developer's portfolio.| Yes.  Really good project for this class. |\r\n||What is good?| Good start.  Have most of the necessary parts added, or ideas about how to add any missing pieces.|\r\n||What could be improved?| Get more required components done.|\r\n|**Design Documentation**|Does it exist?| Yep|\r\n||Is the navigation/flow through the application logical and easy to use?| Yes.|\r\n||Is the order in which the fields are displayed and form fields entered logical and easy to use?| Makes sense to me.|\r\n||What data is missing?| None.|\r\n||Is there data that is not used?| No, all data will be presented to the user. |\r\n||What is good?| Well put together and presented!|\r\n||What could be improved?|  |\r\n|**Data model**|Does it exist?| Yes.|\r\n||Is everything on the screens represented in the model?| I think so.|\r\n||Does the model represent good database design? | What is there, yes.|\r\n||What is good?| Good tables. |\r\n||What could be better?| Needs more built to comment.  Make sure figure out complex relationships (like the many-to-many connection between users and cards that we discussed).|\r\n|**Additional design documents**| | |\r\n|**Application structure in IntelliJ**|Does it exist?| Yes.|\r\n||Is the structure correct for a Maven project?| Yes. |\r\n||Are packages and classs appropriately named?   | Yes. |\r\n||Other comments/notes?| Maybe break out files into more packages if you end up having many classes / files. |\r\n|**JSPs**|Do they exist?| Yes. |\r\n||Is templating used (for example, header.jsp, footer.jsp, etc.)?| No. |\r\n||Is there business logic mixed in the JSPs?| No. |\r\n||CSS?| N/A  |\r\n||Other comments/notes?| Good start. |\r\n|**Entities/DAOs/Controllers**|Do they exist?| They are started. |\r\n|**Java code quality**|Are methods single-purpose?| Yes. |\r\n||Are classes appropriately-sized classes (no monster classes)?| Yes. |\r\n||Are the same lines of code repeated at all?| No. | \r\n||Do any classes perform very similar functions that could be candidates for super/subclass relationships?| No. |\r\n||Are any values hard-coded that should be in a properties file?| No. |\r\n||Are variable names descriptive?| Good 'nuff.|\r\n||Are there many branches or loops that could be simplified or broken up into smaller methods?| No. |\r\n||Do the DAOs use Hibernate? No hard-coded sql!| Yes. |\r\n||Other comments/notes?| Good start.  Needs more code to make more meaningful comments. |\r\n|**Logging**|Has log4J been added?| Yes.  |\r\n||Are there logging statements in the code?| No. |\r\n||Are appropriate logging levels used? Info, debug, error, for example.| Not yet. |\r\n||Are there any System.out.printlns in the code?| No. |\r\n||Other comments/notes?| N/A |\r\n|**Unit Tests**|Do they exist?| Yes. |\r\n||Do the tests pass?| No.  |\r\n||What is the current code coverage?| High.  |\r\n||Is each test truly a unit test or are they functional tests?| Good single unit test.  Make sure the others follow the guidelines as well. |\r\n||Other comments/notes?| |\r\n|**Web Service/API integration**|Has a web service/api been selected? | No. |\r\n||What web services/apis might work well with this application?| Any that have MTG information to retrieve (maybe to initially populate the database with cards?).  Not sure what is a good idea to actually integrate on the fly in your application. |\r\n|**Independent research topic**| Has a topic been selected?| Considering bootstrap.  Considering not doing angular. |\r\n||What topic/s might fit well in this application?| Unknown. |\r\n  \r\n  \r\n  \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"mdhanson3"}}