{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/comments/81338085","pull_request_review_id":2325262,"id":81338085,"diff_hunk":"@@ -1,50 +1,149 @@\n require 'spec_helper'\n \n+describe Griddler::Cloudmailin::Adapter do\n+  it 'registers itself with griddler' do\n+    expect(Griddler.adapter_registry[:cloudmailin]).to be(\n+      Griddler::Cloudmailin::Adapter\n+    )\n+  end\n+end\n+\n describe Griddler::Cloudmailin::Adapter, '.normalize_params' do\n-  it_should_behave_like 'Griddler adapter', :cloudmailin, {\n-    envelope: {\n-      to: 'Hello World <hi@example.com>',\n-      from: 'There <there@example.com>',\n-    },\n-    plain: 'hi',\n-    headers: { Cc: 'emily@example.com' },\n-  }\n+  context 'without bcc' do\n+    it_should_behave_like(\n+      'Griddler adapter',\n+      :cloudmailin,\n+      envelope: {\n+        to: 'hi@example.com',\n+        from: 'there@example.com'\n+      },\n+      plain: 'hi',\n+      headers: {\n+        From: 'there@example.com',\n+        To: 'Hello World <hi@example.com>',\n+        Cc: 'emily@example.com'\n+      }\n+    )\n+  end\n+\n+  context 'with bcc' do\n+    it_should_behave_like(\n+      'Griddler adapter',\n+      :cloudmailin,\n+      envelope: {\n+        to: 'sandra@example.com',\n+        from: 'there@example.com'\n+      },\n+      plain: 'hi',\n+      headers: {\n+        From: 'there@example.com',\n+        To: 'Hello World <hi@example.com>',\n+        Cc: 'emily@example.com'","path":"spec/griddler/cloudmailin/adapter_spec.rb","position":32,"original_position":49,"commit_id":"a025ab4a476dec7098d69d40353cfb26aa1ac0f0","original_commit_id":"a025ab4a476dec7098d69d40353cfb26aa1ac0f0","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Put a comma after the last item of a multiline hash.","created_at":"2016-09-30T13:27:44Z","updated_at":"2016-09-30T13:27:44Z","html_url":"https://github.com/thoughtbot/griddler-cloudmailin/pull/9#discussion_r81338085","pull_request_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/comments/81338085"},"html":{"href":"https://github.com/thoughtbot/griddler-cloudmailin/pull/9#discussion_r81338085"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/9","id":87476170,"html_url":"https://github.com/thoughtbot/griddler-cloudmailin/pull/9","diff_url":"https://github.com/thoughtbot/griddler-cloudmailin/pull/9.diff","patch_url":"https://github.com/thoughtbot/griddler-cloudmailin/pull/9.patch","issue_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/issues/9","number":9,"state":"open","locked":false,"title":"Add date and BCC, and fix the \"to\" field","user":{"login":"dominicsayers","id":34939,"avatar_url":"https://avatars.githubusercontent.com/u/34939?v=3","gravatar_id":"","url":"https://api.github.com/users/dominicsayers","html_url":"https://github.com/dominicsayers","followers_url":"https://api.github.com/users/dominicsayers/followers","following_url":"https://api.github.com/users/dominicsayers/following{/other_user}","gists_url":"https://api.github.com/users/dominicsayers/gists{/gist_id}","starred_url":"https://api.github.com/users/dominicsayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominicsayers/subscriptions","organizations_url":"https://api.github.com/users/dominicsayers/orgs","repos_url":"https://api.github.com/users/dominicsayers/repos","events_url":"https://api.github.com/users/dominicsayers/events{/privacy}","received_events_url":"https://api.github.com/users/dominicsayers/received_events","type":"User","site_admin":false},"body":"Additional features:\r\n\r\n1.  The adapter now returns the email date as a `date` member, derived from the email's `Date` header.\r\n2.  The adapter returns any recipients who were BCCed as a `bcc` array.\r\n\r\nFixes:\r\n\r\n1.  In version 0.0.1, the `to` member was incorrectly derived from the envelope's `to` member. In fact this never contains the data that was expected; it is a single valued field containing only the email address that received this email. Now we correctly derive the `to` data from the `To` header which includes full details of all the recipients.\r\n\r\nOther minor changes:\r\n\r\n1.  Added specs so this is tested to the same extent as the Sendgrid adapter.\r\n2.  Added Rubocop and Hound configuration files so that pull requests are not spammed by Hound messages.\r\n3.  Incremented the major version number because the behaviour of the `to` member has now slightly changed as described above.","created_at":"2016-09-30T11:18:17Z","updated_at":"2016-09-30T13:27:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bf62c77e2e721d3fb5a0f2319a5fbfcd3774f88","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/9/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/9/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/issues/9/comments","statuses_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/statuses/a025ab4a476dec7098d69d40353cfb26aa1ac0f0","head":{"label":"Xenapto:master","ref":"master","sha":"a025ab4a476dec7098d69d40353cfb26aa1ac0f0","user":{"login":"Xenapto","id":1461353,"avatar_url":"https://avatars.githubusercontent.com/u/1461353?v=3","gravatar_id":"","url":"https://api.github.com/users/Xenapto","html_url":"https://github.com/Xenapto","followers_url":"https://api.github.com/users/Xenapto/followers","following_url":"https://api.github.com/users/Xenapto/following{/other_user}","gists_url":"https://api.github.com/users/Xenapto/gists{/gist_id}","starred_url":"https://api.github.com/users/Xenapto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xenapto/subscriptions","organizations_url":"https://api.github.com/users/Xenapto/orgs","repos_url":"https://api.github.com/users/Xenapto/repos","events_url":"https://api.github.com/users/Xenapto/events{/privacy}","received_events_url":"https://api.github.com/users/Xenapto/received_events","type":"Organization","site_admin":false},"repo":{"id":36945855,"name":"griddler-cloudmailin","full_name":"Xenapto/griddler-cloudmailin","owner":{"login":"Xenapto","id":1461353,"avatar_url":"https://avatars.githubusercontent.com/u/1461353?v=3","gravatar_id":"","url":"https://api.github.com/users/Xenapto","html_url":"https://github.com/Xenapto","followers_url":"https://api.github.com/users/Xenapto/followers","following_url":"https://api.github.com/users/Xenapto/following{/other_user}","gists_url":"https://api.github.com/users/Xenapto/gists{/gist_id}","starred_url":"https://api.github.com/users/Xenapto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xenapto/subscriptions","organizations_url":"https://api.github.com/users/Xenapto/orgs","repos_url":"https://api.github.com/users/Xenapto/repos","events_url":"https://api.github.com/users/Xenapto/events{/privacy}","received_events_url":"https://api.github.com/users/Xenapto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Xenapto/griddler-cloudmailin","description":"","fork":true,"url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin","forks_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/forks","keys_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/teams","hooks_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/hooks","issue_events_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/issues/events{/number}","events_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/events","assignees_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/assignees{/user}","branches_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/branches{/branch}","tags_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/tags","blobs_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/statuses/{sha}","languages_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/languages","stargazers_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/stargazers","contributors_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/contributors","subscribers_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/subscribers","subscription_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/subscription","commits_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/contents/{+path}","compare_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/merges","archive_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/downloads","issues_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/issues{/number}","pulls_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/pulls{/number}","milestones_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/milestones{/number}","notifications_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/labels{/name}","releases_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/releases{/id}","deployments_url":"https://api.github.com/repos/Xenapto/griddler-cloudmailin/deployments","created_at":"2015-06-05T17:28:04Z","updated_at":"2016-02-23T12:10:49Z","pushed_at":"2016-09-30T13:26:25Z","git_url":"git://github.com/Xenapto/griddler-cloudmailin.git","ssh_url":"git@github.com:Xenapto/griddler-cloudmailin.git","clone_url":"https://github.com/Xenapto/griddler-cloudmailin.git","svn_url":"https://github.com/Xenapto/griddler-cloudmailin","homepage":null,"size":20,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"d1e2e397c42879269b57ffdfb7cb7f2c6f36ea33","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":21004659,"name":"griddler-cloudmailin","full_name":"thoughtbot/griddler-cloudmailin","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/griddler-cloudmailin","description":"","fork":false,"url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin","forks_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/forks","keys_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/teams","hooks_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/events","assignees_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/tags","blobs_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/subscription","commits_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/merges","archive_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/downloads","issues_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/deployments","created_at":"2014-06-19T15:06:40Z","updated_at":"2016-01-02T12:25:28Z","pushed_at":"2016-09-30T13:26:26Z","git_url":"git://github.com/thoughtbot/griddler-cloudmailin.git","ssh_url":"git@github.com:thoughtbot/griddler-cloudmailin.git","clone_url":"https://github.com/thoughtbot/griddler-cloudmailin.git","svn_url":"https://github.com/thoughtbot/griddler-cloudmailin","homepage":null,"size":167,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/9"},"html":{"href":"https://github.com/thoughtbot/griddler-cloudmailin/pull/9"},"issue":{"href":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/issues/9"},"comments":{"href":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/griddler-cloudmailin/statuses/a025ab4a476dec7098d69d40353cfb26aa1ac0f0"}}}}
{"actor":{"display_login":"houndci-bot"}}