{"action":"created","comment":{"url":"https://api.github.com/repos/rakyll/boom/pulls/comments/65233499","id":65233499,"diff_hunk":"@@ -127,6 +131,9 @@ func (b *Boomer) runWorker(n int) {\n \t\tTLSHandshakeTimeout: time.Duration(b.Timeout) * time.Millisecond,\n \t\tProxy:               http.ProxyURL(b.ProxyAddr),\n \t}\n+\tif b.H2 {\n+\t\thttp2.ConfigureTransport(tr)","path":"boomer/boomer.go","position":23,"original_position":23,"commit_id":"1812960bd73099b2083c3da8602c47967702c897","original_commit_id":"1812960bd73099b2083c3da8602c47967702c897","user":{"login":"rakyll","id":108380,"avatar_url":"https://avatars.githubusercontent.com/u/108380?v=3","gravatar_id":"","url":"https://api.github.com/users/rakyll","html_url":"https://github.com/rakyll","followers_url":"https://api.github.com/users/rakyll/followers","following_url":"https://api.github.com/users/rakyll/following{/other_user}","gists_url":"https://api.github.com/users/rakyll/gists{/gist_id}","starred_url":"https://api.github.com/users/rakyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakyll/subscriptions","organizations_url":"https://api.github.com/users/rakyll/orgs","repos_url":"https://api.github.com/users/rakyll/repos","events_url":"https://api.github.com/users/rakyll/events{/privacy}","received_events_url":"https://api.github.com/users/rakyll/received_events","type":"User","site_admin":false},"body":"We need to figure if it failed because it is already HTTP2 or for another reason. If it cannot switch to HTTP2, it will silently make HTTP1 requests which is contracting to the -h2 flag. Brad gave a talk a while ago that explains how to enable/disable HTTP2: https://www.youtube.com/watch?v=FARQMJndUn0. It would be awesome if we are disabling http2 if -h2 is not, and enable it otherwise the way he recommends on the video.","created_at":"2016-05-31T18:06:38Z","updated_at":"2016-05-31T18:06:38Z","html_url":"https://github.com/rakyll/boom/pull/120#discussion_r65233499","pull_request_url":"https://api.github.com/repos/rakyll/boom/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/rakyll/boom/pulls/comments/65233499"},"html":{"href":"https://github.com/rakyll/boom/pull/120#discussion_r65233499"},"pull_request":{"href":"https://api.github.com/repos/rakyll/boom/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/rakyll/boom/pulls/120","id":71524795,"html_url":"https://github.com/rakyll/boom/pull/120","diff_url":"https://github.com/rakyll/boom/pull/120.diff","patch_url":"https://github.com/rakyll/boom/pull/120.patch","issue_url":"https://api.github.com/repos/rakyll/boom/issues/120","number":120,"state":"open","locked":false,"title":"feat: h2 - make HTTP2 request","user":{"login":"xuqingfeng","id":3715820,"avatar_url":"https://avatars.githubusercontent.com/u/3715820?v=3","gravatar_id":"","url":"https://api.github.com/users/xuqingfeng","html_url":"https://github.com/xuqingfeng","followers_url":"https://api.github.com/users/xuqingfeng/followers","following_url":"https://api.github.com/users/xuqingfeng/following{/other_user}","gists_url":"https://api.github.com/users/xuqingfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/xuqingfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuqingfeng/subscriptions","organizations_url":"https://api.github.com/users/xuqingfeng/orgs","repos_url":"https://api.github.com/users/xuqingfeng/repos","events_url":"https://api.github.com/users/xuqingfeng/events{/privacy}","received_events_url":"https://api.github.com/users/xuqingfeng/received_events","type":"User","site_admin":false},"body":"`boom -n 1000 -c 100 -h2 https://google.com`","created_at":"2016-05-26T09:23:36Z","updated_at":"2016-05-31T18:06:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15deae292f3dece8671658bd30492cbb447b8b7e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rakyll/boom/pulls/120/commits","review_comments_url":"https://api.github.com/repos/rakyll/boom/pulls/120/comments","review_comment_url":"https://api.github.com/repos/rakyll/boom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rakyll/boom/issues/120/comments","statuses_url":"https://api.github.com/repos/rakyll/boom/statuses/1812960bd73099b2083c3da8602c47967702c897","head":{"label":"xuqingfeng:h2","ref":"h2","sha":"1812960bd73099b2083c3da8602c47967702c897","user":{"login":"xuqingfeng","id":3715820,"avatar_url":"https://avatars.githubusercontent.com/u/3715820?v=3","gravatar_id":"","url":"https://api.github.com/users/xuqingfeng","html_url":"https://github.com/xuqingfeng","followers_url":"https://api.github.com/users/xuqingfeng/followers","following_url":"https://api.github.com/users/xuqingfeng/following{/other_user}","gists_url":"https://api.github.com/users/xuqingfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/xuqingfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuqingfeng/subscriptions","organizations_url":"https://api.github.com/users/xuqingfeng/orgs","repos_url":"https://api.github.com/users/xuqingfeng/repos","events_url":"https://api.github.com/users/xuqingfeng/events{/privacy}","received_events_url":"https://api.github.com/users/xuqingfeng/received_events","type":"User","site_admin":false},"repo":{"id":59734377,"name":"boom","full_name":"xuqingfeng/boom","owner":{"login":"xuqingfeng","id":3715820,"avatar_url":"https://avatars.githubusercontent.com/u/3715820?v=3","gravatar_id":"","url":"https://api.github.com/users/xuqingfeng","html_url":"https://github.com/xuqingfeng","followers_url":"https://api.github.com/users/xuqingfeng/followers","following_url":"https://api.github.com/users/xuqingfeng/following{/other_user}","gists_url":"https://api.github.com/users/xuqingfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/xuqingfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuqingfeng/subscriptions","organizations_url":"https://api.github.com/users/xuqingfeng/orgs","repos_url":"https://api.github.com/users/xuqingfeng/repos","events_url":"https://api.github.com/users/xuqingfeng/events{/privacy}","received_events_url":"https://api.github.com/users/xuqingfeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xuqingfeng/boom","description":"HTTP(S) load generator, ApacheBench (ab) replacement, written in Go","fork":true,"url":"https://api.github.com/repos/xuqingfeng/boom","forks_url":"https://api.github.com/repos/xuqingfeng/boom/forks","keys_url":"https://api.github.com/repos/xuqingfeng/boom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xuqingfeng/boom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xuqingfeng/boom/teams","hooks_url":"https://api.github.com/repos/xuqingfeng/boom/hooks","issue_events_url":"https://api.github.com/repos/xuqingfeng/boom/issues/events{/number}","events_url":"https://api.github.com/repos/xuqingfeng/boom/events","assignees_url":"https://api.github.com/repos/xuqingfeng/boom/assignees{/user}","branches_url":"https://api.github.com/repos/xuqingfeng/boom/branches{/branch}","tags_url":"https://api.github.com/repos/xuqingfeng/boom/tags","blobs_url":"https://api.github.com/repos/xuqingfeng/boom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xuqingfeng/boom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xuqingfeng/boom/git/refs{/sha}","trees_url":"https://api.github.com/repos/xuqingfeng/boom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xuqingfeng/boom/statuses/{sha}","languages_url":"https://api.github.com/repos/xuqingfeng/boom/languages","stargazers_url":"https://api.github.com/repos/xuqingfeng/boom/stargazers","contributors_url":"https://api.github.com/repos/xuqingfeng/boom/contributors","subscribers_url":"https://api.github.com/repos/xuqingfeng/boom/subscribers","subscription_url":"https://api.github.com/repos/xuqingfeng/boom/subscription","commits_url":"https://api.github.com/repos/xuqingfeng/boom/commits{/sha}","git_commits_url":"https://api.github.com/repos/xuqingfeng/boom/git/commits{/sha}","comments_url":"https://api.github.com/repos/xuqingfeng/boom/comments{/number}","issue_comment_url":"https://api.github.com/repos/xuqingfeng/boom/issues/comments{/number}","contents_url":"https://api.github.com/repos/xuqingfeng/boom/contents/{+path}","compare_url":"https://api.github.com/repos/xuqingfeng/boom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xuqingfeng/boom/merges","archive_url":"https://api.github.com/repos/xuqingfeng/boom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xuqingfeng/boom/downloads","issues_url":"https://api.github.com/repos/xuqingfeng/boom/issues{/number}","pulls_url":"https://api.github.com/repos/xuqingfeng/boom/pulls{/number}","milestones_url":"https://api.github.com/repos/xuqingfeng/boom/milestones{/number}","notifications_url":"https://api.github.com/repos/xuqingfeng/boom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xuqingfeng/boom/labels{/name}","releases_url":"https://api.github.com/repos/xuqingfeng/boom/releases{/id}","deployments_url":"https://api.github.com/repos/xuqingfeng/boom/deployments","created_at":"2016-05-26T08:42:11Z","updated_at":"2016-05-26T08:42:11Z","pushed_at":"2016-05-26T09:22:49Z","git_url":"git://github.com/xuqingfeng/boom.git","ssh_url":"git@github.com:xuqingfeng/boom.git","clone_url":"https://github.com/xuqingfeng/boom.git","svn_url":"https://github.com/xuqingfeng/boom","homepage":"","size":139,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rakyll:master","ref":"master","sha":"1881f0a61667048ed30ed60474ae73f27dd4564b","user":{"login":"rakyll","id":108380,"avatar_url":"https://avatars.githubusercontent.com/u/108380?v=3","gravatar_id":"","url":"https://api.github.com/users/rakyll","html_url":"https://github.com/rakyll","followers_url":"https://api.github.com/users/rakyll/followers","following_url":"https://api.github.com/users/rakyll/following{/other_user}","gists_url":"https://api.github.com/users/rakyll/gists{/gist_id}","starred_url":"https://api.github.com/users/rakyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakyll/subscriptions","organizations_url":"https://api.github.com/users/rakyll/orgs","repos_url":"https://api.github.com/users/rakyll/repos","events_url":"https://api.github.com/users/rakyll/events{/privacy}","received_events_url":"https://api.github.com/users/rakyll/received_events","type":"User","site_admin":false},"repo":{"id":15633115,"name":"boom","full_name":"rakyll/boom","owner":{"login":"rakyll","id":108380,"avatar_url":"https://avatars.githubusercontent.com/u/108380?v=3","gravatar_id":"","url":"https://api.github.com/users/rakyll","html_url":"https://github.com/rakyll","followers_url":"https://api.github.com/users/rakyll/followers","following_url":"https://api.github.com/users/rakyll/following{/other_user}","gists_url":"https://api.github.com/users/rakyll/gists{/gist_id}","starred_url":"https://api.github.com/users/rakyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakyll/subscriptions","organizations_url":"https://api.github.com/users/rakyll/orgs","repos_url":"https://api.github.com/users/rakyll/repos","events_url":"https://api.github.com/users/rakyll/events{/privacy}","received_events_url":"https://api.github.com/users/rakyll/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rakyll/boom","description":"HTTP(S) load generator, ApacheBench (ab) replacement, written in Go","fork":false,"url":"https://api.github.com/repos/rakyll/boom","forks_url":"https://api.github.com/repos/rakyll/boom/forks","keys_url":"https://api.github.com/repos/rakyll/boom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rakyll/boom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rakyll/boom/teams","hooks_url":"https://api.github.com/repos/rakyll/boom/hooks","issue_events_url":"https://api.github.com/repos/rakyll/boom/issues/events{/number}","events_url":"https://api.github.com/repos/rakyll/boom/events","assignees_url":"https://api.github.com/repos/rakyll/boom/assignees{/user}","branches_url":"https://api.github.com/repos/rakyll/boom/branches{/branch}","tags_url":"https://api.github.com/repos/rakyll/boom/tags","blobs_url":"https://api.github.com/repos/rakyll/boom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rakyll/boom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rakyll/boom/git/refs{/sha}","trees_url":"https://api.github.com/repos/rakyll/boom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rakyll/boom/statuses/{sha}","languages_url":"https://api.github.com/repos/rakyll/boom/languages","stargazers_url":"https://api.github.com/repos/rakyll/boom/stargazers","contributors_url":"https://api.github.com/repos/rakyll/boom/contributors","subscribers_url":"https://api.github.com/repos/rakyll/boom/subscribers","subscription_url":"https://api.github.com/repos/rakyll/boom/subscription","commits_url":"https://api.github.com/repos/rakyll/boom/commits{/sha}","git_commits_url":"https://api.github.com/repos/rakyll/boom/git/commits{/sha}","comments_url":"https://api.github.com/repos/rakyll/boom/comments{/number}","issue_comment_url":"https://api.github.com/repos/rakyll/boom/issues/comments{/number}","contents_url":"https://api.github.com/repos/rakyll/boom/contents/{+path}","compare_url":"https://api.github.com/repos/rakyll/boom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rakyll/boom/merges","archive_url":"https://api.github.com/repos/rakyll/boom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rakyll/boom/downloads","issues_url":"https://api.github.com/repos/rakyll/boom/issues{/number}","pulls_url":"https://api.github.com/repos/rakyll/boom/pulls{/number}","milestones_url":"https://api.github.com/repos/rakyll/boom/milestones{/number}","notifications_url":"https://api.github.com/repos/rakyll/boom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rakyll/boom/labels{/name}","releases_url":"https://api.github.com/repos/rakyll/boom/releases{/id}","deployments_url":"https://api.github.com/repos/rakyll/boom/deployments","created_at":"2014-01-04T14:08:53Z","updated_at":"2016-05-31T16:03:54Z","pushed_at":"2016-05-26T09:23:36Z","git_url":"git://github.com/rakyll/boom.git","ssh_url":"git@github.com:rakyll/boom.git","clone_url":"https://github.com/rakyll/boom.git","svn_url":"https://github.com/rakyll/boom","homepage":"","size":3513,"stargazers_count":4331,"watchers_count":4331,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":319,"mirror_url":null,"open_issues_count":54,"forks":319,"open_issues":54,"watchers":4331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rakyll/boom/pulls/120"},"html":{"href":"https://github.com/rakyll/boom/pull/120"},"issue":{"href":"https://api.github.com/repos/rakyll/boom/issues/120"},"comments":{"href":"https://api.github.com/repos/rakyll/boom/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/rakyll/boom/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/rakyll/boom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rakyll/boom/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/rakyll/boom/statuses/1812960bd73099b2083c3da8602c47967702c897"}}}}
{"actor":{"display_login":"rakyll"}}