{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/comments/63401353","id":63401353,"diff_hunk":"@@ -347,6 +358,24 @@ public void poll(long timeoutMs, List<NetworkSend> sends)\n           close(key);\n         }\n       }\n+\n+      Iterator<Transmission> sslTransIter = pendingSslHandshakes.iterator();\n+      while (sslTransIter.hasNext()) {\n+        Transmission sslTransmission = sslTransIter.next();\n+        if (sslTransmission != null && sslTransmission.ready()) {","path":"ambry-network/src/main/java/com.github.ambry.network/Selector.java","position":45,"original_position":45,"commit_id":"81a9256e2b9eee7dcfd21bad9d909377f2f70f2c","original_commit_id":"81a9256e2b9eee7dcfd21bad9d909377f2f70f2c","user":{"login":"xiahome","id":8271368,"avatar_url":"https://avatars.githubusercontent.com/u/8271368?v=3","gravatar_id":"","url":"https://api.github.com/users/xiahome","html_url":"https://github.com/xiahome","followers_url":"https://api.github.com/users/xiahome/followers","following_url":"https://api.github.com/users/xiahome/following{/other_user}","gists_url":"https://api.github.com/users/xiahome/gists{/gist_id}","starred_url":"https://api.github.com/users/xiahome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiahome/subscriptions","organizations_url":"https://api.github.com/users/xiahome/orgs","repos_url":"https://api.github.com/users/xiahome/repos","events_url":"https://api.github.com/users/xiahome/events{/privacy}","received_events_url":"https://api.github.com/users/xiahome/received_events","type":"User","site_admin":false},"body":"Would the first condition ever be `false`?","created_at":"2016-05-16T18:31:28Z","updated_at":"2016-05-16T18:31:28Z","html_url":"https://github.com/linkedin/ambry/pull/310#discussion_r63401353","pull_request_url":"https://api.github.com/repos/linkedin/ambry/pulls/310","_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments/63401353"},"html":{"href":"https://github.com/linkedin/ambry/pull/310#discussion_r63401353"},"pull_request":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/310","id":70225156,"html_url":"https://github.com/linkedin/ambry/pull/310","diff_url":"https://github.com/linkedin/ambry/pull/310.diff","patch_url":"https://github.com/linkedin/ambry/pull/310.patch","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/310","number":310,"state":"open","locked":false,"title":"Fixing the way Selector handles SSL connection handshakes","user":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"body":"Currently, for connections over SSL, the ambry selector returns an established connection after a poll even before the handshake is completed. This is not very useful as the caller will then have to repeatedly check outside of the selector poll on whether the handshake is complete, which is not ideal.\r\n\r\nThis patch fixes this issue.\r\nThe selector will only return a connection after the connection is established and the handshake is complete. If the handshake does not complete for any reason, then it should be treated as a connection establishment failure. This way the callers of the selector can be agnostic to SSL, and can interact with the selector in a completely non-blocking way.\r\n\r\nSLA: 10 mins\r\nReviewers: Priyesh, Ming\r\n","created_at":"2016-05-16T16:50:02Z","updated_at":"2016-05-16T18:31:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7cde950cefed99e581cf9a34c13a478d8c18637","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/ambry/pulls/310/commits","review_comments_url":"https://api.github.com/repos/linkedin/ambry/pulls/310/comments","review_comment_url":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/310/comments","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/81a9256e2b9eee7dcfd21bad9d909377f2f70f2c","head":{"label":"nsivabalan:SelectorSSLFix","ref":"SelectorSSLFix","sha":"81a9256e2b9eee7dcfd21bad9d909377f2f70f2c","user":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"repo":{"id":20119917,"name":"ambry","full_name":"nsivabalan/ambry","owner":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsivabalan/ambry","description":"Immutable blob store","fork":true,"url":"https://api.github.com/repos/nsivabalan/ambry","forks_url":"https://api.github.com/repos/nsivabalan/ambry/forks","keys_url":"https://api.github.com/repos/nsivabalan/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsivabalan/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsivabalan/ambry/teams","hooks_url":"https://api.github.com/repos/nsivabalan/ambry/hooks","issue_events_url":"https://api.github.com/repos/nsivabalan/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/nsivabalan/ambry/events","assignees_url":"https://api.github.com/repos/nsivabalan/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/nsivabalan/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/nsivabalan/ambry/tags","blobs_url":"https://api.github.com/repos/nsivabalan/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsivabalan/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsivabalan/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsivabalan/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsivabalan/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/nsivabalan/ambry/languages","stargazers_url":"https://api.github.com/repos/nsivabalan/ambry/stargazers","contributors_url":"https://api.github.com/repos/nsivabalan/ambry/contributors","subscribers_url":"https://api.github.com/repos/nsivabalan/ambry/subscribers","subscription_url":"https://api.github.com/repos/nsivabalan/ambry/subscription","commits_url":"https://api.github.com/repos/nsivabalan/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsivabalan/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsivabalan/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsivabalan/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsivabalan/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/nsivabalan/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsivabalan/ambry/merges","archive_url":"https://api.github.com/repos/nsivabalan/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsivabalan/ambry/downloads","issues_url":"https://api.github.com/repos/nsivabalan/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/nsivabalan/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/nsivabalan/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/nsivabalan/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsivabalan/ambry/labels{/name}","releases_url":"https://api.github.com/repos/nsivabalan/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/nsivabalan/ambry/deployments","created_at":"2014-05-24T02:15:09Z","updated_at":"2016-05-04T20:45:58Z","pushed_at":"2016-05-16T16:44:39Z","git_url":"git://github.com/nsivabalan/ambry.git","ssh_url":"git@github.com:nsivabalan/ambry.git","clone_url":"https://github.com/nsivabalan/ambry.git","svn_url":"https://github.com/nsivabalan/ambry","homepage":null,"size":6629,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"59974cb875c9606f35535031ffc66eec0d8cca13","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":13870893,"name":"ambry","full_name":"linkedin/ambry","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/ambry","description":"Distributed object store","fork":false,"url":"https://api.github.com/repos/linkedin/ambry","forks_url":"https://api.github.com/repos/linkedin/ambry/forks","keys_url":"https://api.github.com/repos/linkedin/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/ambry/teams","hooks_url":"https://api.github.com/repos/linkedin/ambry/hooks","issue_events_url":"https://api.github.com/repos/linkedin/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/ambry/events","assignees_url":"https://api.github.com/repos/linkedin/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/ambry/tags","blobs_url":"https://api.github.com/repos/linkedin/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/ambry/languages","stargazers_url":"https://api.github.com/repos/linkedin/ambry/stargazers","contributors_url":"https://api.github.com/repos/linkedin/ambry/contributors","subscribers_url":"https://api.github.com/repos/linkedin/ambry/subscribers","subscription_url":"https://api.github.com/repos/linkedin/ambry/subscription","commits_url":"https://api.github.com/repos/linkedin/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/ambry/merges","archive_url":"https://api.github.com/repos/linkedin/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/ambry/downloads","issues_url":"https://api.github.com/repos/linkedin/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/ambry/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/ambry/deployments","created_at":"2013-10-25T20:04:54Z","updated_at":"2016-05-16T18:31:09Z","pushed_at":"2016-05-16T16:50:02Z","git_url":"git://github.com/linkedin/ambry.git","ssh_url":"git@github.com:linkedin/ambry.git","clone_url":"https://github.com/linkedin/ambry.git","svn_url":"https://github.com/linkedin/ambry","homepage":"https://github.com/linkedin/ambry/wiki","size":6950,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":17,"forks":8,"open_issues":17,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/310"},"html":{"href":"https://github.com/linkedin/ambry/pull/310"},"issue":{"href":"https://api.github.com/repos/linkedin/ambry/issues/310"},"comments":{"href":"https://api.github.com/repos/linkedin/ambry/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/ambry/statuses/81a9256e2b9eee7dcfd21bad9d909377f2f70f2c"}}}}