{"action":"closed","number":288,"pull_request":{"url":"https://api.github.com/repos/babel/babel-eslint/pulls/288","id":64921232,"html_url":"https://github.com/babel/babel-eslint/pull/288","diff_url":"https://github.com/babel/babel-eslint/pull/288.diff","patch_url":"https://github.com/babel/babel-eslint/pull/288.patch","issue_url":"https://api.github.com/repos/babel/babel-eslint/issues/288","number":288,"state":"closed","locked":false,"title":"Fix escope to take sourceType and ecmaVersion from options","user":{"login":"danez","id":231804,"avatar_url":"https://avatars.githubusercontent.com/u/231804?v=3","gravatar_id":"","url":"https://api.github.com/users/danez","html_url":"https://github.com/danez","followers_url":"https://api.github.com/users/danez/followers","following_url":"https://api.github.com/users/danez/following{/other_user}","gists_url":"https://api.github.com/users/danez/gists{/gist_id}","starred_url":"https://api.github.com/users/danez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danez/subscriptions","organizations_url":"https://api.github.com/users/danez/orgs","repos_url":"https://api.github.com/users/danez/repos","events_url":"https://api.github.com/users/danez/events{/privacy}","received_events_url":"https://api.github.com/users/danez/received_events","type":"User","site_admin":false},"body":"escope was hardcoded to sourcetype: \"module\" and ecmaVersion: \"6\"\r\nThis changes it to take the configuration from the eslint options and still\r\ndefaulting to \"module\" and \"6\".\r\nThis is done by having the variables in the upper scope, as monkeypatch is only triggered once and would therefore stick to the options that are supplied the first time. But the options can change as in our tests or different eslintrc files in different directories.\r\n\r\nFixes #287 and #217 (217 was failing without the fix in script mode)","created_at":"2016-04-01T09:57:21Z","updated_at":"2016-04-20T00:56:15Z","closed_at":"2016-04-20T00:56:15Z","merged_at":"2016-04-20T00:56:15Z","merge_commit_sha":"991ec90290d4c62ab5bfdddada4aa9bbac625bd3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/babel/babel-eslint/pulls/288/commits","review_comments_url":"https://api.github.com/repos/babel/babel-eslint/pulls/288/comments","review_comment_url":"https://api.github.com/repos/babel/babel-eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/babel/babel-eslint/issues/288/comments","statuses_url":"https://api.github.com/repos/babel/babel-eslint/statuses/4e569bcca629fb20f21f8ca49d4f99e41518ae4a","head":{"label":"danez:fix-escope-monkey","ref":"fix-escope-monkey","sha":"4e569bcca629fb20f21f8ca49d4f99e41518ae4a","user":{"login":"danez","id":231804,"avatar_url":"https://avatars.githubusercontent.com/u/231804?v=3","gravatar_id":"","url":"https://api.github.com/users/danez","html_url":"https://github.com/danez","followers_url":"https://api.github.com/users/danez/followers","following_url":"https://api.github.com/users/danez/following{/other_user}","gists_url":"https://api.github.com/users/danez/gists{/gist_id}","starred_url":"https://api.github.com/users/danez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danez/subscriptions","organizations_url":"https://api.github.com/users/danez/orgs","repos_url":"https://api.github.com/users/danez/repos","events_url":"https://api.github.com/users/danez/events{/privacy}","received_events_url":"https://api.github.com/users/danez/received_events","type":"User","site_admin":false},"repo":{"id":53319577,"name":"babel-eslint","full_name":"danez/babel-eslint","owner":{"login":"danez","id":231804,"avatar_url":"https://avatars.githubusercontent.com/u/231804?v=3","gravatar_id":"","url":"https://api.github.com/users/danez","html_url":"https://github.com/danez","followers_url":"https://api.github.com/users/danez/followers","following_url":"https://api.github.com/users/danez/following{/other_user}","gists_url":"https://api.github.com/users/danez/gists{/gist_id}","starred_url":"https://api.github.com/users/danez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danez/subscriptions","organizations_url":"https://api.github.com/users/danez/orgs","repos_url":"https://api.github.com/users/danez/repos","events_url":"https://api.github.com/users/danez/events{/privacy}","received_events_url":"https://api.github.com/users/danez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danez/babel-eslint","description":"ESLint using Babel as the parser.","fork":true,"url":"https://api.github.com/repos/danez/babel-eslint","forks_url":"https://api.github.com/repos/danez/babel-eslint/forks","keys_url":"https://api.github.com/repos/danez/babel-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danez/babel-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danez/babel-eslint/teams","hooks_url":"https://api.github.com/repos/danez/babel-eslint/hooks","issue_events_url":"https://api.github.com/repos/danez/babel-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/danez/babel-eslint/events","assignees_url":"https://api.github.com/repos/danez/babel-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/danez/babel-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/danez/babel-eslint/tags","blobs_url":"https://api.github.com/repos/danez/babel-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danez/babel-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danez/babel-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/danez/babel-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danez/babel-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/danez/babel-eslint/languages","stargazers_url":"https://api.github.com/repos/danez/babel-eslint/stargazers","contributors_url":"https://api.github.com/repos/danez/babel-eslint/contributors","subscribers_url":"https://api.github.com/repos/danez/babel-eslint/subscribers","subscription_url":"https://api.github.com/repos/danez/babel-eslint/subscription","commits_url":"https://api.github.com/repos/danez/babel-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/danez/babel-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/danez/babel-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/danez/babel-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/danez/babel-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/danez/babel-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danez/babel-eslint/merges","archive_url":"https://api.github.com/repos/danez/babel-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danez/babel-eslint/downloads","issues_url":"https://api.github.com/repos/danez/babel-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/danez/babel-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/danez/babel-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/danez/babel-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danez/babel-eslint/labels{/name}","releases_url":"https://api.github.com/repos/danez/babel-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/danez/babel-eslint/deployments","created_at":"2016-03-07T11:14:20Z","updated_at":"2016-03-07T11:14:22Z","pushed_at":"2016-04-04T12:13:58Z","git_url":"git://github.com/danez/babel-eslint.git","ssh_url":"git@github.com:danez/babel-eslint.git","clone_url":"https://github.com/danez/babel-eslint.git","svn_url":"https://github.com/danez/babel-eslint","homepage":"","size":269,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"babel:master","ref":"master","sha":"27debee58f0395516c1f37a9ad5cf23c55cb2c51","user":{"login":"babel","id":9637642,"avatar_url":"https://avatars.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"repo":{"id":31404632,"name":"babel-eslint","full_name":"babel/babel-eslint","owner":{"login":"babel","id":9637642,"avatar_url":"https://avatars.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/babel/babel-eslint","description":"ESLint using Babel as the parser.","fork":false,"url":"https://api.github.com/repos/babel/babel-eslint","forks_url":"https://api.github.com/repos/babel/babel-eslint/forks","keys_url":"https://api.github.com/repos/babel/babel-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babel/babel-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babel/babel-eslint/teams","hooks_url":"https://api.github.com/repos/babel/babel-eslint/hooks","issue_events_url":"https://api.github.com/repos/babel/babel-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/babel/babel-eslint/events","assignees_url":"https://api.github.com/repos/babel/babel-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/babel/babel-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/babel/babel-eslint/tags","blobs_url":"https://api.github.com/repos/babel/babel-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babel/babel-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babel/babel-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/babel/babel-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babel/babel-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/babel/babel-eslint/languages","stargazers_url":"https://api.github.com/repos/babel/babel-eslint/stargazers","contributors_url":"https://api.github.com/repos/babel/babel-eslint/contributors","subscribers_url":"https://api.github.com/repos/babel/babel-eslint/subscribers","subscription_url":"https://api.github.com/repos/babel/babel-eslint/subscription","commits_url":"https://api.github.com/repos/babel/babel-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/babel/babel-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/babel/babel-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/babel/babel-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/babel/babel-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/babel/babel-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babel/babel-eslint/merges","archive_url":"https://api.github.com/repos/babel/babel-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babel/babel-eslint/downloads","issues_url":"https://api.github.com/repos/babel/babel-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/babel/babel-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/babel/babel-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/babel/babel-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babel/babel-eslint/labels{/name}","releases_url":"https://api.github.com/repos/babel/babel-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/babel/babel-eslint/deployments","created_at":"2015-02-27T05:17:07Z","updated_at":"2016-04-19T21:39:34Z","pushed_at":"2016-04-20T00:56:15Z","git_url":"git://github.com/babel/babel-eslint.git","ssh_url":"git@github.com:babel/babel-eslint.git","clone_url":"https://github.com/babel/babel-eslint.git","svn_url":"https://github.com/babel/babel-eslint","homepage":"","size":501,"stargazers_count":843,"watchers_count":843,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":34,"forks":54,"open_issues":34,"watchers":843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/babel/babel-eslint/pulls/288"},"html":{"href":"https://github.com/babel/babel-eslint/pull/288"},"issue":{"href":"https://api.github.com/repos/babel/babel-eslint/issues/288"},"comments":{"href":"https://api.github.com/repos/babel/babel-eslint/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/babel/babel-eslint/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/babel/babel-eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/babel/babel-eslint/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/babel/babel-eslint/statuses/4e569bcca629fb20f21f8ca49d4f99e41518ae4a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hzoo","id":588473,"avatar_url":"https://avatars.githubusercontent.com/u/588473?v=3","gravatar_id":"","url":"https://api.github.com/users/hzoo","html_url":"https://github.com/hzoo","followers_url":"https://api.github.com/users/hzoo/followers","following_url":"https://api.github.com/users/hzoo/following{/other_user}","gists_url":"https://api.github.com/users/hzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/hzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzoo/subscriptions","organizations_url":"https://api.github.com/users/hzoo/orgs","repos_url":"https://api.github.com/users/hzoo/repos","events_url":"https://api.github.com/users/hzoo/events{/privacy}","received_events_url":"https://api.github.com/users/hzoo/received_events","type":"User","site_admin":false},"comments":8,"review_comments":2,"commits":1,"additions":99,"deletions":22,"changed_files":2}}