{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/682","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/682/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/682/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/682/events","html_url":"https://github.com/solidusio/solidus/pull/682","id":126064464,"number":682,"title":"[RFC] Allow zero dollar order adjustments","user":{"login":"brendandeere","id":6353433,"avatar_url":"https://avatars.githubusercontent.com/u/6353433?v=3","gravatar_id":"","url":"https://api.github.com/users/brendandeere","html_url":"https://github.com/brendandeere","followers_url":"https://api.github.com/users/brendandeere/followers","following_url":"https://api.github.com/users/brendandeere/following{/other_user}","gists_url":"https://api.github.com/users/brendandeere/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandeere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandeere/subscriptions","organizations_url":"https://api.github.com/users/brendandeere/orgs","repos_url":"https://api.github.com/users/brendandeere/repos","events_url":"https://api.github.com/users/brendandeere/events{/privacy}","received_events_url":"https://api.github.com/users/brendandeere/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-11T23:45:07Z","updated_at":"2016-01-14T23:52:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/682","html_url":"https://github.com/solidusio/solidus/pull/682","diff_url":"https://github.com/solidusio/solidus/pull/682.diff","patch_url":"https://github.com/solidusio/solidus/pull/682.patch"},"body":"Sometimes the current value of a promotion is zero dollars, however with the return check here the Spree::OrderPromotion will not be created and so the promotion can never be applied in the future by order.update!\r\n\r\nThis check was added in spree/spree@17c59ec as an aesthetic change which should not affect promotion logic this deep into the modeling.\r\n\r\nA more appropriate place that change would have been a view override of some kind. As mentioned by @jormon here:\r\n\r\nspree/spree#3966 (comment)"},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/171820525","html_url":"https://github.com/solidusio/solidus/pull/682#issuecomment-171820525","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/682","id":171820525,"user":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars.githubusercontent.com/u/131752?v=3","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"created_at":"2016-01-14T23:52:50Z","updated_at":"2016-01-14T23:52:50Z","body":"Also we could consider marking $0 adjustments as ineligible, which would have the same effect of hiding them."}}