{"push_id":1049501106,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"d6f84f2cf7005c59289cdc68777cec697dba76cb","before":"5b62b452066d14a15a2568023402db68e31e6279","commits":[{"sha":"d6f84f2cf7005c59289cdc68777cec697dba76cb","author":{"email":"20d921fc546146872790792fbd1b5fc4bad0eb3d@apple.com","name":"Duncan P. N. Exon Smith"},"message":"ValueMapper: Remove old FIXMEs; almost NFC\n\nRemove a few old FIXMEs from the original commit of the Metadata/Value\nsplit in r223802.  These are commented out assertions to the effect that\ncalls between mapValue and mapMetadata never return nullptr.\n\n(The only behaviour change is that Mapper::mapSimpleMetadata memoizes\nthe nullptr return.)\n\nWhen I originally rewrote the mapping code, I thought we could be\nstricter in the new metadata hierarchy and never return nullptr when\nRF_NullMapMissingGlobalValues was off.  It's still not entirely clear to\nme why these assertions failed (a few months ago, I had a theory that I\nforgot to write down, but that's helping no one).\n\nUnderstood or not, I no longer see how these commented-out assertions\nwould be useful.  I'm relegating them to the annals of source control\nbefore making significant changes to ValueMapper.cpp.\n\ngit-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@265282 91177308-0d34-0410-b5e6-96231b3b80d8","distinct":true,"url":"https://api.github.com/repos/llvm-beanz/llvm/commits/d6f84f2cf7005c59289cdc68777cec697dba76cb"}]}