{"action":"created","issue":{"url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/1825","repository_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP","labels_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/1825/labels{/name}","comments_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/1825/comments","events_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/1825/events","html_url":"https://github.com/AffiliateWP/AffiliateWP/issues/1825","id":190417560,"number":1825,"title":"Add schema support to core REST routes and endpoints","user":{"login":"DrewAPicture","id":995399,"avatar_url":"https://avatars.githubusercontent.com/u/995399?v=3","gravatar_id":"","url":"https://api.github.com/users/DrewAPicture","html_url":"https://github.com/DrewAPicture","followers_url":"https://api.github.com/users/DrewAPicture/followers","following_url":"https://api.github.com/users/DrewAPicture/following{/other_user}","gists_url":"https://api.github.com/users/DrewAPicture/gists{/gist_id}","starred_url":"https://api.github.com/users/DrewAPicture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrewAPicture/subscriptions","organizations_url":"https://api.github.com/users/DrewAPicture/orgs","repos_url":"https://api.github.com/users/DrewAPicture/repos","events_url":"https://api.github.com/users/DrewAPicture/events{/privacy}","received_events_url":"https://api.github.com/users/DrewAPicture/received_events","type":"User","site_admin":false},"labels":[{"id":72778873,"url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/labels/enhancement","name":"enhancement","color":"70adee","default":true},{"id":230490395,"url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/labels/Has%20PR","name":"Has PR","color":"bfe5bf","default":false},{"id":407594531,"url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/labels/REST","name":"REST","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"DrewAPicture","id":995399,"avatar_url":"https://avatars.githubusercontent.com/u/995399?v=3","gravatar_id":"","url":"https://api.github.com/users/DrewAPicture","html_url":"https://github.com/DrewAPicture","followers_url":"https://api.github.com/users/DrewAPicture/followers","following_url":"https://api.github.com/users/DrewAPicture/following{/other_user}","gists_url":"https://api.github.com/users/DrewAPicture/gists{/gist_id}","starred_url":"https://api.github.com/users/DrewAPicture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrewAPicture/subscriptions","organizations_url":"https://api.github.com/users/DrewAPicture/orgs","repos_url":"https://api.github.com/users/DrewAPicture/repos","events_url":"https://api.github.com/users/DrewAPicture/events{/privacy}","received_events_url":"https://api.github.com/users/DrewAPicture/received_events","type":"User","site_admin":false},"assignees":[{"login":"DrewAPicture","id":995399,"avatar_url":"https://avatars.githubusercontent.com/u/995399?v=3","gravatar_id":"","url":"https://api.github.com/users/DrewAPicture","html_url":"https://github.com/DrewAPicture","followers_url":"https://api.github.com/users/DrewAPicture/followers","following_url":"https://api.github.com/users/DrewAPicture/following{/other_user}","gists_url":"https://api.github.com/users/DrewAPicture/gists{/gist_id}","starred_url":"https://api.github.com/users/DrewAPicture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrewAPicture/subscriptions","organizations_url":"https://api.github.com/users/DrewAPicture/orgs","repos_url":"https://api.github.com/users/DrewAPicture/repos","events_url":"https://api.github.com/users/DrewAPicture/events{/privacy}","received_events_url":"https://api.github.com/users/DrewAPicture/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/milestones/53","html_url":"https://github.com/AffiliateWP/AffiliateWP/milestones/2.0","labels_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/milestones/53/labels","id":1416664,"number":53,"title":"2.0","description":"","creator":{"login":"pippinsplugins","id":1034109,"avatar_url":"https://avatars.githubusercontent.com/u/1034109?v=3","gravatar_id":"","url":"https://api.github.com/users/pippinsplugins","html_url":"https://github.com/pippinsplugins","followers_url":"https://api.github.com/users/pippinsplugins/followers","following_url":"https://api.github.com/users/pippinsplugins/following{/other_user}","gists_url":"https://api.github.com/users/pippinsplugins/gists{/gist_id}","starred_url":"https://api.github.com/users/pippinsplugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pippinsplugins/subscriptions","organizations_url":"https://api.github.com/users/pippinsplugins/orgs","repos_url":"https://api.github.com/users/pippinsplugins/repos","events_url":"https://api.github.com/users/pippinsplugins/events{/privacy}","received_events_url":"https://api.github.com/users/pippinsplugins/received_events","type":"User","site_admin":false},"open_issues":99,"closed_issues":0,"state":"open","created_at":"2015-11-17T20:46:05Z","updated_at":"2016-11-22T22:57:53Z","due_on":"2017-01-10T00:00:00Z","closed_at":null},"comments":3,"created_at":"2016-11-18T20:44:38Z","updated_at":"2016-11-25T19:13:52Z","closed_at":null,"body":"This is a companion project to the pro REST API add-on currently in development. The new writeable and editable endpoints require schema support to build their respective argument lists. We _could_ do it as a shim in the add-on, but I think the best route forward would be to add the schema support to core, and then simply require 1.9.x or 2.x for the add-on to operate.\r\n\r\nMy best suggestion would be to continue in the v1 namespace regardless of the pending 4.7 release. And then when we're ready (and tested) we can do a v2 leveraging the core controller and API.\r\n\r\nMust haves:\r\n\r\n* [x] `get_endpoint_args_for_item_schema()` method shim in the controller\r\n* [x] `add_additional_fields_schema()`\r\n* `get_item_schema()` methods in the core endpoint classes (and thereby reuseable by add-ons extending the core endpoints\r\n* [x] `get_item_schema()` Affiliates\r\n* [x] `get_item_schema()` Creatives\r\n* [x] `get_item_schema()` Payouts\r\n* [x] `get_item_schema()` Referrals\r\n* [x] `get_item_schema()` Visits\r\n* will update as other stuff comes up"},"comment":{"url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/comments/263012658","html_url":"https://github.com/AffiliateWP/AffiliateWP/issues/1825#issuecomment-263012658","issue_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/1825","id":263012658,"user":{"login":"DrewAPicture","id":995399,"avatar_url":"https://avatars.githubusercontent.com/u/995399?v=3","gravatar_id":"","url":"https://api.github.com/users/DrewAPicture","html_url":"https://github.com/DrewAPicture","followers_url":"https://api.github.com/users/DrewAPicture/followers","following_url":"https://api.github.com/users/DrewAPicture/following{/other_user}","gists_url":"https://api.github.com/users/DrewAPicture/gists{/gist_id}","starred_url":"https://api.github.com/users/DrewAPicture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrewAPicture/subscriptions","organizations_url":"https://api.github.com/users/DrewAPicture/orgs","repos_url":"https://api.github.com/users/DrewAPicture/repos","events_url":"https://api.github.com/users/DrewAPicture/events{/privacy}","received_events_url":"https://api.github.com/users/DrewAPicture/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T19:13:52Z","updated_at":"2016-11-25T19:13:52Z","body":"@pippinsplugins The PR: #1826 is ready for review. All v1 create/edit/delete endpoints have been [implemented](https://github.com/AffiliateWP/affiliatewp-rest-api/issues/3) in the pro add-on and rely on these item schema."}}
{"actor":{"display_login":"DrewAPicture"}}