{"action":"created","issue":{"url":"https://api.github.com/repos/reactioncommerce/reaction/issues/1367","repository_url":"https://api.github.com/repos/reactioncommerce/reaction","labels_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/1367/labels{/name}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/1367/comments","events_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/1367/events","html_url":"https://github.com/reactioncommerce/reaction/pull/1367","id":176444624,"number":1367,"title":"Better email","user":{"login":"jshimko","id":3077956,"avatar_url":"https://avatars.githubusercontent.com/u/3077956?v=3","gravatar_id":"","url":"https://api.github.com/users/jshimko","html_url":"https://github.com/jshimko","followers_url":"https://api.github.com/users/jshimko/followers","following_url":"https://api.github.com/users/jshimko/following{/other_user}","gists_url":"https://api.github.com/users/jshimko/gists{/gist_id}","starred_url":"https://api.github.com/users/jshimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshimko/subscriptions","organizations_url":"https://api.github.com/users/jshimko/orgs","repos_url":"https://api.github.com/users/jshimko/repos","events_url":"https://api.github.com/users/jshimko/events{/privacy}","received_events_url":"https://api.github.com/users/jshimko/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/reactioncommerce/reaction/labels/review","name":"review","color":"d90380"}],"state":"open","locked":false,"assignee":{"login":"mikemurray","id":42217,"avatar_url":"https://avatars.githubusercontent.com/u/42217?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemurray","html_url":"https://github.com/mikemurray","followers_url":"https://api.github.com/users/mikemurray/followers","following_url":"https://api.github.com/users/mikemurray/following{/other_user}","gists_url":"https://api.github.com/users/mikemurray/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemurray/subscriptions","organizations_url":"https://api.github.com/users/mikemurray/orgs","repos_url":"https://api.github.com/users/mikemurray/repos","events_url":"https://api.github.com/users/mikemurray/events{/privacy}","received_events_url":"https://api.github.com/users/mikemurray/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikemurray","id":42217,"avatar_url":"https://avatars.githubusercontent.com/u/42217?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemurray","html_url":"https://github.com/mikemurray","followers_url":"https://api.github.com/users/mikemurray/followers","following_url":"https://api.github.com/users/mikemurray/following{/other_user}","gists_url":"https://api.github.com/users/mikemurray/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemurray/subscriptions","organizations_url":"https://api.github.com/users/mikemurray/orgs","repos_url":"https://api.github.com/users/mikemurray/repos","events_url":"https://api.github.com/users/mikemurray/events{/privacy}","received_events_url":"https://api.github.com/users/mikemurray/received_events","type":"User","site_admin":false},{"login":"aaronjudd","id":439959,"avatar_url":"https://avatars.githubusercontent.com/u/439959?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronjudd","html_url":"https://github.com/aaronjudd","followers_url":"https://api.github.com/users/aaronjudd/followers","following_url":"https://api.github.com/users/aaronjudd/following{/other_user}","gists_url":"https://api.github.com/users/aaronjudd/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronjudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronjudd/subscriptions","organizations_url":"https://api.github.com/users/aaronjudd/orgs","repos_url":"https://api.github.com/users/aaronjudd/repos","events_url":"https://api.github.com/users/aaronjudd/events{/privacy}","received_events_url":"https://api.github.com/users/aaronjudd/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/reactioncommerce/reaction/milestones/35","html_url":"https://github.com/reactioncommerce/reaction/milestones/v0.16.0","labels_url":"https://api.github.com/repos/reactioncommerce/reaction/milestones/35/labels","id":1895497,"number":35,"title":"v0.16.0","description":"- Search\r\n- Email engine\r\n- Shipping updates\r\n","creator":{"login":"aaronjudd","id":439959,"avatar_url":"https://avatars.githubusercontent.com/u/439959?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronjudd","html_url":"https://github.com/aaronjudd","followers_url":"https://api.github.com/users/aaronjudd/followers","following_url":"https://api.github.com/users/aaronjudd/following{/other_user}","gists_url":"https://api.github.com/users/aaronjudd/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronjudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronjudd/subscriptions","organizations_url":"https://api.github.com/users/aaronjudd/orgs","repos_url":"https://api.github.com/users/aaronjudd/repos","events_url":"https://api.github.com/users/aaronjudd/events{/privacy}","received_events_url":"https://api.github.com/users/aaronjudd/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":16,"state":"open","created_at":"2016-07-21T00:48:43Z","updated_at":"2016-09-14T05:33:30Z","due_on":"2016-09-20T00:00:00Z","closed_at":null},"comments":8,"created_at":"2016-09-12T18:11:35Z","updated_at":"2016-09-15T20:28:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/reactioncommerce/reaction/pulls/1367","html_url":"https://github.com/reactioncommerce/reaction/pull/1367","diff_url":"https://github.com/reactioncommerce/reaction/pull/1367.diff","patch_url":"https://github.com/reactioncommerce/reaction/pull/1367.patch"},"body":"- update all email API's to use Nodemailer and a job queue for sending \r\n- completely removes dependency on Meteor's email package\r\n- new UI for email dashboard\r\n\r\nMore PR notes coming shortly..."},"comment":{"url":"https://api.github.com/repos/reactioncommerce/reaction/issues/comments/247444998","html_url":"https://github.com/reactioncommerce/reaction/pull/1367#issuecomment-247444998","issue_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/1367","id":247444998,"user":{"login":"Capt-Slow","id":321416,"avatar_url":"https://avatars.githubusercontent.com/u/321416?v=3","gravatar_id":"","url":"https://api.github.com/users/Capt-Slow","html_url":"https://github.com/Capt-Slow","followers_url":"https://api.github.com/users/Capt-Slow/followers","following_url":"https://api.github.com/users/Capt-Slow/following{/other_user}","gists_url":"https://api.github.com/users/Capt-Slow/gists{/gist_id}","starred_url":"https://api.github.com/users/Capt-Slow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Capt-Slow/subscriptions","organizations_url":"https://api.github.com/users/Capt-Slow/orgs","repos_url":"https://api.github.com/users/Capt-Slow/repos","events_url":"https://api.github.com/users/Capt-Slow/events{/privacy}","received_events_url":"https://api.github.com/users/Capt-Slow/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T20:28:16Z","updated_at":"2016-09-15T20:28:16Z","body":"A couple of concerns I have. First, I feel uneasy about the 'Show' password functionality. Not quite sure what purpose having this in there serves.\r\n\r\nSecond, I opened up Wireshark while loading.`http://localhost:3000/reaction/dashboard/email/status`\r\n\r\nWhat I found while following the TCP stream.\r\n\r\n```\r\nGET http://localhost:3000/reaction/dashboard/email/status HTTP/1.1\r\n.....\r\n....\r\n<script type=\"text/inject-data\">%7B%22fast-render-data%22%3A%7B%22collectionData%22%3A%7B%22users%22%3A%5B%5B%7B%22emails%22%3A%5B%7B%22address%22%3A%22prwtfizd%40localhost%22%2C%22verified%22%3Atrue%2C%22provides%22%3A%22default%22%7D%5D%2C%22username%22%3A%22admin%22%2C%22_id%22%3A%22tgGnreWqhhgERJ7AC%22%7D%5D%5D%7D%2C%22subscriptions%22%3A%7B%7D%2C%22loginToken%22%3A%22Ia7D74N7P1hUnstui316qydP6TAH9F1A0kKuvznvytH%22%7D%7D</script>\r\n<script type=\"text/javascript\">__meteor_runtime_config__ = JSON.parse(decodeURIComponent(\"%7B%22meteorRelease%22%3A%22METEOR%401.4.1.1%22%2C%22meteorEnv%22%3A%7B%22NODE_ENV%22%3A%22development%22%2C%22TEST_METADATA%22%3A%22%7B%7D%22%7D%2C%22PUBLIC_SETTINGS%22%3A%7B%7D%2C%22ROOT_URL%22%3A%22http%3A%2F%2Flocalhost%3A3000%2F%22%2C%22ROOT_URL_PATH_PREFIX%22%3A%22%22%2C%22appId%22%3A%2216fc7k11cajtkx5sgjml%22%2C%22autoupdateVersion%22%3A%226b3e4bd076a053843533ffd654ce25a51c6a6809%22%2C%22autoupdateVersionRefreshable%22%3A%22286205febfbadbc10f35848a54e1cc5706a2f4b5%22%2C%22autoupdateVersionCordova%22%3A%22none%22%7D\"));</script>\r\n```\r\n\r\nemails%22%3A%5B%7B%22address%22%3A%22**prwtfizd%40localhost**\r\n^My login email\r\n\r\nusername%22%3A%22admin\r\n^My username\r\n\r\nMight be out of scope of this ticket. However, not liking we expose this info. As an attacker I have login and assertion info for successful break in attempt."}}
{"actor":{"display_login":"Capt-Slow"}}