{"action":"created","issue":{"url":"https://api.github.com/repos/logary/logary/issues/167","repository_url":"https://api.github.com/repos/logary/logary","labels_url":"https://api.github.com/repos/logary/logary/issues/167/labels{/name}","comments_url":"https://api.github.com/repos/logary/logary/issues/167/comments","events_url":"https://api.github.com/repos/logary/logary/issues/167/events","html_url":"https://github.com/logary/logary/pull/167","id":179064708,"number":167,"title":"Upgrade FsMessageTemplates and mark internal","user":{"login":"adamchester","id":570470,"avatar_url":"https://avatars.githubusercontent.com/u/570470?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchester","html_url":"https://github.com/adamchester","followers_url":"https://api.github.com/users/adamchester/followers","following_url":"https://api.github.com/users/adamchester/following{/other_user}","gists_url":"https://api.github.com/users/adamchester/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchester/subscriptions","organizations_url":"https://api.github.com/users/adamchester/orgs","repos_url":"https://api.github.com/users/adamchester/repos","events_url":"https://api.github.com/users/adamchester/events{/privacy}","received_events_url":"https://api.github.com/users/adamchester/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-25T03:03:58Z","updated_at":"2016-09-25T21:20:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/logary/logary/pulls/167","html_url":"https://github.com/logary/logary/pull/167","diff_url":"https://github.com/logary/logary/pull/167.diff","patch_url":"https://github.com/logary/logary/pull/167.patch"},"body":"The biggest impact with this PR is that I've marked FsMessageTemplates as internal. \r\n\r\nThe main changes in FsMessageTemplates are:\r\n\r\n * Support for `ICustomFormatter` (does not impact Logary, because Logary doesn't use FsMessageTemplates formatting)\r\n * `Token.Text|Prop` --> `Token.TextToken|PropToken`\r\n * `PropertyToken` --> `Property`\r\n * reworked `findNextNonPropText` which allows a similar usage provided by the cut-down Facade parser (where the caller provides callbacks for `foundProperty` and `foundText`)\r\n * Ability to reflect over fsharp types (does not impact Logary, since Logary currently implements it's own data model for capturing logged properties).\r\n\r\nfrom https://github.com/messagetemplates/messagetemplates-fsharp/blob/78a7c2ade80cccd6ebdffacf03393bdd68f622b8/src/FsMessageTemplates/MessageTemplates.fs"},"comment":{"url":"https://api.github.com/repos/logary/logary/issues/comments/249447406","html_url":"https://github.com/logary/logary/pull/167#issuecomment-249447406","issue_url":"https://api.github.com/repos/logary/logary/issues/167","id":249447406,"user":{"login":"haf","id":193115,"avatar_url":"https://avatars.githubusercontent.com/u/193115?v=3","gravatar_id":"","url":"https://api.github.com/users/haf","html_url":"https://github.com/haf","followers_url":"https://api.github.com/users/haf/followers","following_url":"https://api.github.com/users/haf/following{/other_user}","gists_url":"https://api.github.com/users/haf/gists{/gist_id}","starred_url":"https://api.github.com/users/haf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haf/subscriptions","organizations_url":"https://api.github.com/users/haf/orgs","repos_url":"https://api.github.com/users/haf/repos","events_url":"https://api.github.com/users/haf/events{/privacy}","received_events_url":"https://api.github.com/users/haf/received_events","type":"User","site_admin":false},"created_at":"2016-09-25T21:20:06Z","updated_at":"2016-09-25T21:20:06Z","body":"Are there corresponding unit tests to test the added code? Briefly skimming the code says it looks good."}}
{"actor":{"display_login":"haf"}}