{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/vorto/issues/35","labels_url":"https://api.github.com/repos/eclipse/vorto/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/vorto/issues/35/comments","events_url":"https://api.github.com/repos/eclipse/vorto/issues/35/events","html_url":"https://github.com/eclipse/vorto/pull/35","id":127544700,"number":35,"title":"ThingWorx Example Code Generato","user":{"login":"StephenHarmon","id":871628,"avatar_url":"https://avatars.githubusercontent.com/u/871628?v=3","gravatar_id":"","url":"https://api.github.com/users/StephenHarmon","html_url":"https://github.com/StephenHarmon","followers_url":"https://api.github.com/users/StephenHarmon/followers","following_url":"https://api.github.com/users/StephenHarmon/following{/other_user}","gists_url":"https://api.github.com/users/StephenHarmon/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenHarmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenHarmon/subscriptions","organizations_url":"https://api.github.com/users/StephenHarmon/orgs","repos_url":"https://api.github.com/users/StephenHarmon/repos","events_url":"https://api.github.com/users/StephenHarmon/events{/privacy}","received_events_url":"https://api.github.com/users/StephenHarmon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-19T21:38:09Z","updated_at":"2016-01-21T02:27:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eclipse/vorto/pulls/35","html_url":"https://github.com/eclipse/vorto/pull/35","diff_url":"https://github.com/eclipse/vorto/pull/35.diff","patch_url":"https://github.com/eclipse/vorto/pull/35.patch"},"body":"Author: Stephen Harmon <stephen.harmon@thingworx.com>\r\nDate: Mon Jan 18 17:00:00 2016\r\nCLA: Valid CLA on file\r\n\r\n[485502] - ThingWorx Example Code Generator\r\n\r\nThe ThingWorx Vorto Code Generator generates ThingWorx specific code that links Vorto Models to ThingWorx Things.\r\nThis pull request contains the functionality that has been presented at the LiveWorx Stuttgart last year.\r\n\r\nThe current version represents a minimum viable demo of the code generator. Enhancements being worked on now include:\r\n\r\n* The current version supports the mapping of simple data types like int, String, and double. Vorto provides rich functionality for modeling custom data types. The next version will contain added support for custom data types.\r\n* This version uses the jackson-core-2.6.0 JSON library. It is imported as a jar in a lib directory. The preferred OSGI pattern is for libraries to be embedded in a bundle. The next version will package the library as a bundle.\r\n\r\nBug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=485502\r\nSigned-off-by: Stephen Harmon <stephen.harmon@thingworx.com>"},"comment":{"url":"https://api.github.com/repos/eclipse/vorto/issues/comments/173431844","html_url":"https://github.com/eclipse/vorto/pull/35#issuecomment-173431844","issue_url":"https://api.github.com/repos/eclipse/vorto/issues/35","id":173431844,"user":{"login":"kartben","id":128251,"avatar_url":"https://avatars.githubusercontent.com/u/128251?v=3","gravatar_id":"","url":"https://api.github.com/users/kartben","html_url":"https://github.com/kartben","followers_url":"https://api.github.com/users/kartben/followers","following_url":"https://api.github.com/users/kartben/following{/other_user}","gists_url":"https://api.github.com/users/kartben/gists{/gist_id}","starred_url":"https://api.github.com/users/kartben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kartben/subscriptions","organizations_url":"https://api.github.com/users/kartben/orgs","repos_url":"https://api.github.com/users/kartben/repos","events_url":"https://api.github.com/users/kartben/events{/privacy}","received_events_url":"https://api.github.com/users/kartben/received_events","type":"User","site_admin":false},"created_at":"2016-01-21T02:27:22Z","updated_at":"2016-01-21T02:27:22Z","body":"Steve,\r\n\r\nThe Signed-off-by header should be inserted at the commit level, not in the description of the PR.\r\nWhat's more, you should rely on eg the \"-s\" Git command line parameter to create the Signed-off-by header so as it has the proper format (it looks like the Signed-off-by header in your PR comment does not put the email address between < > signs, for example)...\r\n\r\nYour best move would be to amend the commits in your StephenHarmon:thingworx-code-generator branch so as they include the Signed-off-by header, and push-force that branch. See e.g http://stackoverflow.com/a/13043757\r\n\r\nHTH"}}