{"action":"created","comment":{"url":"https://api.github.com/repos/hughsie/PackageKit/pulls/comments/68936002","id":68936002,"diff_hunk":"@@ -1171,33 +1172,14 @@ pk_backend_get_updates (PkBackend *backend,\n \tpk_backend_job_thread_create (job, pk_backend_search_thread, NULL, NULL);\n }\n \n-/* Obviously hardcoded and Fedora specific.  Colin Walters thinks this\n- * concept should be based on user's trust of a GPG key or something\n- * more flexible.\n+/* Obviously hardcoded based on the repository ID labels.\n+ * Colin Walters thinks this concept should be based on\n+ * user's trust of a GPG key or something more flexible.\n  */\n static gboolean\n source_is_supported (HifSource *source)\n {\n-\tconst char *id = hif_source_get_id (source);\n-\tguint i;\n-\tconst gchar *valid[] = { \"fedora\",\n-\t\t\t\t \"fedora-debuginfo\",\n-\t\t\t\t \"fedora-source\",\n-\t\t\t\t \"rawhide\",\n-\t\t\t\t \"rawhide-debuginfo\",\n-\t\t\t\t \"rawhide-source\",\n-\t\t\t\t \"updates\",\n-\t\t\t\t \"updates-debuginfo\",\n-\t\t\t\t \"updates-source\",\n-\t\t\t\t \"updates-testing\",\n-\t\t\t\t \"updates-testing-debuginfo\",\n-\t\t\t\t \"updates-testing-source\",\n-\t\t\t\t NULL };\n-\tfor (i = 0; valid[i] != NULL; i++) {\n-\t\tif (g_strcmp0 (id, valid[i]) == 0)\n-\t\t\treturn TRUE;\n-\t}\n-\treturn FALSE;\n+\treturn hif_validate_supported_source(hif_source_get_id (source));","path":"backends/hif/pk-backend-hif.c","position":51,"original_position":51,"commit_id":"a6940506798c6c7ef854a7a8336adfd3c8f7f032","original_commit_id":"a6940506798c6c7ef854a7a8336adfd3c8f7f032","user":{"login":"kalev","id":498858,"avatar_url":"https://avatars.githubusercontent.com/u/498858?v=3","gravatar_id":"","url":"https://api.github.com/users/kalev","html_url":"https://github.com/kalev","followers_url":"https://api.github.com/users/kalev/followers","following_url":"https://api.github.com/users/kalev/following{/other_user}","gists_url":"https://api.github.com/users/kalev/gists{/gist_id}","starred_url":"https://api.github.com/users/kalev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalev/subscriptions","organizations_url":"https://api.github.com/users/kalev/orgs","repos_url":"https://api.github.com/users/kalev/repos","events_url":"https://api.github.com/users/kalev/events{/privacy}","received_events_url":"https://api.github.com/users/kalev/received_events","type":"User","site_admin":false},"body":"missing paren before opening (","created_at":"2016-06-29T12:23:01Z","updated_at":"2016-06-29T12:23:01Z","html_url":"https://github.com/hughsie/PackageKit/pull/121#discussion_r68936002","pull_request_url":"https://api.github.com/repos/hughsie/PackageKit/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/hughsie/PackageKit/pulls/comments/68936002"},"html":{"href":"https://github.com/hughsie/PackageKit/pull/121#discussion_r68936002"},"pull_request":{"href":"https://api.github.com/repos/hughsie/PackageKit/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/hughsie/PackageKit/pulls/121","id":68497431,"html_url":"https://github.com/hughsie/PackageKit/pull/121","diff_url":"https://github.com/hughsie/PackageKit/pull/121.diff","patch_url":"https://github.com/hughsie/PackageKit/pull/121.patch","issue_url":"https://api.github.com/repos/hughsie/PackageKit/issues/121","number":121,"state":"open","locked":false,"title":"hif: Add support for build-time vendor configurations","user":{"login":"Conan-Kudo","id":276796,"avatar_url":"https://avatars.githubusercontent.com/u/276796?v=3","gravatar_id":"","url":"https://api.github.com/users/Conan-Kudo","html_url":"https://github.com/Conan-Kudo","followers_url":"https://api.github.com/users/Conan-Kudo/followers","following_url":"https://api.github.com/users/Conan-Kudo/following{/other_user}","gists_url":"https://api.github.com/users/Conan-Kudo/gists{/gist_id}","starred_url":"https://api.github.com/users/Conan-Kudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Conan-Kudo/subscriptions","organizations_url":"https://api.github.com/users/Conan-Kudo/orgs","repos_url":"https://api.github.com/users/Conan-Kudo/repos","events_url":"https://api.github.com/users/Conan-Kudo/events{/privacy}","received_events_url":"https://api.github.com/users/Conan-Kudo/received_events","type":"User","site_admin":false},"body":"With Mageia moving forward to adopt the PackageKit-Hif backend, it is now necessary to support switching out Fedora-specific and Mageia-specific configurations at build time.\r\n\r\nFor now, this only contains <strike>swapping out repository directory locations and validating the appropriate prefixes for verifying</strike> supported sources.<strike> Fedora isn't yet using `/etc/distro.repos.d`, and other distributions in the future may use other locations</strike>. Obviously sources would differ among distributions.\r\n\r\nIn the future, support may be added for dealing with groups, which different distributions use different conventions.\r\n\r\nI'm somewhat uncertain about the `configure.ac` modifications, because I'm not very good with autotools, but it seemed to select as I wanted to.\r\n\r\nThis pull request fixes #119.","created_at":"2016-05-01T14:37:12Z","updated_at":"2016-06-29T12:23:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccbb770b20de6232cb67285a00e28ed594bfba5f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hughsie/PackageKit/pulls/121/commits","review_comments_url":"https://api.github.com/repos/hughsie/PackageKit/pulls/121/comments","review_comment_url":"https://api.github.com/repos/hughsie/PackageKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hughsie/PackageKit/issues/121/comments","statuses_url":"https://api.github.com/repos/hughsie/PackageKit/statuses/a6940506798c6c7ef854a7a8336adfd3c8f7f032","head":{"label":"Conan-Kudo:hif-vendors","ref":"hif-vendors","sha":"a6940506798c6c7ef854a7a8336adfd3c8f7f032","user":{"login":"Conan-Kudo","id":276796,"avatar_url":"https://avatars.githubusercontent.com/u/276796?v=3","gravatar_id":"","url":"https://api.github.com/users/Conan-Kudo","html_url":"https://github.com/Conan-Kudo","followers_url":"https://api.github.com/users/Conan-Kudo/followers","following_url":"https://api.github.com/users/Conan-Kudo/following{/other_user}","gists_url":"https://api.github.com/users/Conan-Kudo/gists{/gist_id}","starred_url":"https://api.github.com/users/Conan-Kudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Conan-Kudo/subscriptions","organizations_url":"https://api.github.com/users/Conan-Kudo/orgs","repos_url":"https://api.github.com/users/Conan-Kudo/repos","events_url":"https://api.github.com/users/Conan-Kudo/events{/privacy}","received_events_url":"https://api.github.com/users/Conan-Kudo/received_events","type":"User","site_admin":false},"repo":{"id":46182193,"name":"PackageKit","full_name":"Conan-Kudo/PackageKit","owner":{"login":"Conan-Kudo","id":276796,"avatar_url":"https://avatars.githubusercontent.com/u/276796?v=3","gravatar_id":"","url":"https://api.github.com/users/Conan-Kudo","html_url":"https://github.com/Conan-Kudo","followers_url":"https://api.github.com/users/Conan-Kudo/followers","following_url":"https://api.github.com/users/Conan-Kudo/following{/other_user}","gists_url":"https://api.github.com/users/Conan-Kudo/gists{/gist_id}","starred_url":"https://api.github.com/users/Conan-Kudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Conan-Kudo/subscriptions","organizations_url":"https://api.github.com/users/Conan-Kudo/orgs","repos_url":"https://api.github.com/users/Conan-Kudo/repos","events_url":"https://api.github.com/users/Conan-Kudo/events{/privacy}","received_events_url":"https://api.github.com/users/Conan-Kudo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Conan-Kudo/PackageKit","description":"A D-BUS abstraction layer that allows the user to manage packages in a secure way using a cross-distro, cross-architecture API.","fork":true,"url":"https://api.github.com/repos/Conan-Kudo/PackageKit","forks_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/forks","keys_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/teams","hooks_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/hooks","issue_events_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/issues/events{/number}","events_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/events","assignees_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/assignees{/user}","branches_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/branches{/branch}","tags_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/tags","blobs_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/statuses/{sha}","languages_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/languages","stargazers_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/stargazers","contributors_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/contributors","subscribers_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/subscribers","subscription_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/subscription","commits_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/contents/{+path}","compare_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/merges","archive_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/downloads","issues_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/issues{/number}","pulls_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/pulls{/number}","milestones_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/milestones{/number}","notifications_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/labels{/name}","releases_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/releases{/id}","deployments_url":"https://api.github.com/repos/Conan-Kudo/PackageKit/deployments","created_at":"2015-11-14T16:31:01Z","updated_at":"2016-02-15T17:46:47Z","pushed_at":"2016-06-28T15:07:15Z","git_url":"git://github.com/Conan-Kudo/PackageKit.git","ssh_url":"git@github.com:Conan-Kudo/PackageKit.git","clone_url":"https://github.com/Conan-Kudo/PackageKit.git","svn_url":"https://github.com/Conan-Kudo/PackageKit","homepage":null,"size":28236,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hughsie:master","ref":"master","sha":"de1b0c911524b456a7ce65ff7a470cbef2668cfb","user":{"login":"hughsie","id":151380,"avatar_url":"https://avatars.githubusercontent.com/u/151380?v=3","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"repo":{"id":23841887,"name":"PackageKit","full_name":"hughsie/PackageKit","owner":{"login":"hughsie","id":151380,"avatar_url":"https://avatars.githubusercontent.com/u/151380?v=3","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughsie/PackageKit","description":"A D-BUS abstraction layer that allows the user to manage packages in a secure way using a cross-distro, cross-architecture API.","fork":false,"url":"https://api.github.com/repos/hughsie/PackageKit","forks_url":"https://api.github.com/repos/hughsie/PackageKit/forks","keys_url":"https://api.github.com/repos/hughsie/PackageKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughsie/PackageKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughsie/PackageKit/teams","hooks_url":"https://api.github.com/repos/hughsie/PackageKit/hooks","issue_events_url":"https://api.github.com/repos/hughsie/PackageKit/issues/events{/number}","events_url":"https://api.github.com/repos/hughsie/PackageKit/events","assignees_url":"https://api.github.com/repos/hughsie/PackageKit/assignees{/user}","branches_url":"https://api.github.com/repos/hughsie/PackageKit/branches{/branch}","tags_url":"https://api.github.com/repos/hughsie/PackageKit/tags","blobs_url":"https://api.github.com/repos/hughsie/PackageKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughsie/PackageKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughsie/PackageKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughsie/PackageKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughsie/PackageKit/statuses/{sha}","languages_url":"https://api.github.com/repos/hughsie/PackageKit/languages","stargazers_url":"https://api.github.com/repos/hughsie/PackageKit/stargazers","contributors_url":"https://api.github.com/repos/hughsie/PackageKit/contributors","subscribers_url":"https://api.github.com/repos/hughsie/PackageKit/subscribers","subscription_url":"https://api.github.com/repos/hughsie/PackageKit/subscription","commits_url":"https://api.github.com/repos/hughsie/PackageKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughsie/PackageKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughsie/PackageKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughsie/PackageKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughsie/PackageKit/contents/{+path}","compare_url":"https://api.github.com/repos/hughsie/PackageKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughsie/PackageKit/merges","archive_url":"https://api.github.com/repos/hughsie/PackageKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughsie/PackageKit/downloads","issues_url":"https://api.github.com/repos/hughsie/PackageKit/issues{/number}","pulls_url":"https://api.github.com/repos/hughsie/PackageKit/pulls{/number}","milestones_url":"https://api.github.com/repos/hughsie/PackageKit/milestones{/number}","notifications_url":"https://api.github.com/repos/hughsie/PackageKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughsie/PackageKit/labels{/name}","releases_url":"https://api.github.com/repos/hughsie/PackageKit/releases{/id}","deployments_url":"https://api.github.com/repos/hughsie/PackageKit/deployments","created_at":"2014-09-09T16:37:54Z","updated_at":"2016-05-16T18:41:21Z","pushed_at":"2016-06-28T15:07:15Z","git_url":"git://github.com/hughsie/PackageKit.git","ssh_url":"git@github.com:hughsie/PackageKit.git","clone_url":"https://github.com/hughsie/PackageKit.git","svn_url":"https://github.com/hughsie/PackageKit","homepage":null,"size":28431,"stargazers_count":31,"watchers_count":31,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":39,"forks":36,"open_issues":39,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hughsie/PackageKit/pulls/121"},"html":{"href":"https://github.com/hughsie/PackageKit/pull/121"},"issue":{"href":"https://api.github.com/repos/hughsie/PackageKit/issues/121"},"comments":{"href":"https://api.github.com/repos/hughsie/PackageKit/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/hughsie/PackageKit/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/hughsie/PackageKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hughsie/PackageKit/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/hughsie/PackageKit/statuses/a6940506798c6c7ef854a7a8336adfd3c8f7f032"}}}}
{"actor":{"display_login":"kalev"}}