{"action":"created","comment":{"url":"https://api.github.com/repos/numenta/numenta-apps/pulls/comments/67249615","id":67249615,"diff_hunk":"@@ -84,6 +87,11 @@ def parseDatetime(dateString, dateFormat):\n       raise ValueError(\n         \"Expected non-negative Unix Timestamp, but got {}\".format(dateString))\n \n+    # check to see if the timestamp float is beyond the range of UNIX SECONDS\n+    # if it is interpret is as a ms timestamp\n+    if timestampFloat > _MAX_UNIX_SECONDS:\n+      timestampFloat /= 1000","path":"unicorn/py/unicorn_backend/utils/date_time_utils.py","position":17,"original_position":17,"commit_id":"ecc9daa6b4774e9156d40205b244a95ab4ef249b","original_commit_id":"ecc9daa6b4774e9156d40205b244a95ab4ef249b","user":{"login":"marionleborgne","id":2488251,"avatar_url":"https://avatars.githubusercontent.com/u/2488251?v=3","gravatar_id":"","url":"https://api.github.com/users/marionleborgne","html_url":"https://github.com/marionleborgne","followers_url":"https://api.github.com/users/marionleborgne/followers","following_url":"https://api.github.com/users/marionleborgne/following{/other_user}","gists_url":"https://api.github.com/users/marionleborgne/gists{/gist_id}","starred_url":"https://api.github.com/users/marionleborgne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionleborgne/subscriptions","organizations_url":"https://api.github.com/users/marionleborgne/orgs","repos_url":"https://api.github.com/users/marionleborgne/repos","events_url":"https://api.github.com/users/marionleborgne/events{/privacy}","received_events_url":"https://api.github.com/users/marionleborgne/received_events","type":"User","site_admin":false},"body":"@andrewmalta13 @vitaly-krugl I commented on the JIRA.\r\n\r\nThe convention that we are taking is that we only support unix timestamps in s  that are above `253402300.800` ( `1978-01-11T21:31:40+00:00`) and below `253402300800`  (`10000-01-01T00:00:00+00:00`) \r\n\r\nThis should be reflected in the code and in the comments so that other people taking over understand that it's a convention that we are taking.  \r\n\r\n\r\nAlso @andrewmalta13 use 253402300800.0 instead of 253402300799.0 for _MAX_UNIX_SECONDS","created_at":"2016-06-15T21:31:40Z","updated_at":"2016-06-15T21:31:41Z","html_url":"https://github.com/numenta/numenta-apps/pull/849#discussion_r67249615","pull_request_url":"https://api.github.com/repos/numenta/numenta-apps/pulls/849","_links":{"self":{"href":"https://api.github.com/repos/numenta/numenta-apps/pulls/comments/67249615"},"html":{"href":"https://github.com/numenta/numenta-apps/pull/849#discussion_r67249615"},"pull_request":{"href":"https://api.github.com/repos/numenta/numenta-apps/pulls/849"}}},"pull_request":{"url":"https://api.github.com/repos/numenta/numenta-apps/pulls/849","id":73407614,"html_url":"https://github.com/numenta/numenta-apps/pull/849","diff_url":"https://github.com/numenta/numenta-apps/pull/849.diff","patch_url":"https://github.com/numenta/numenta-apps/pull/849.patch","issue_url":"https://api.github.com/repos/numenta/numenta-apps/issues/849","number":849,"state":"open","locked":false,"title":"UNI-545 fixes exception and date_time_utils.py bug","user":{"login":"andrewmalta13","id":7546926,"avatar_url":"https://avatars.githubusercontent.com/u/7546926?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewmalta13","html_url":"https://github.com/andrewmalta13","followers_url":"https://api.github.com/users/andrewmalta13/followers","following_url":"https://api.github.com/users/andrewmalta13/following{/other_user}","gists_url":"https://api.github.com/users/andrewmalta13/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmalta13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmalta13/subscriptions","organizations_url":"https://api.github.com/users/andrewmalta13/orgs","repos_url":"https://api.github.com/users/andrewmalta13/repos","events_url":"https://api.github.com/users/andrewmalta13/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmalta13/received_events","type":"User","site_admin":false},"body":"please review @marionleborgne \r\n\r\nNote the file in the UNI-545 JIRA will still fail param finder and get UNI-528 like symptoms however, the error message it now gets is in line with @lscheinkman  sees on the other files that exhibit the UNI-528 bug which is:\r\n\r\n{\"errorText\": \"negative dimensions are not allowed\", \"diagnosticInfo\": \"Traceback (most recent call last):\\n  File \\\"build/bdist.macosx-10.5-x86_64/egg/unicorn_backend/param_finder_runner.py\\\", line 201, in main\\n  File \\\"build/bdist.macosx-10.5-x86_64/egg/unicorn_backend/param_finder.py\\\", line 241, in findParameters\\n    medianSamplingInterval)\\n  File \\\"build/bdist.macosx-10.5-x86_64/egg/unicorn_backend/param_finder.py\\\", line 363, in _resampleData\\n    newTimeStamps = numpy.empty(nSampleNew, dtype=\\\"datetime64[s]\\\")\\nValueError: negative dimensions are not allowed\\n\"}","created_at":"2016-06-10T17:25:27Z","updated_at":"2016-06-15T21:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57a6c581f86b7a915ded50c8f30ebf099a1955f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/numenta/numenta-apps/pulls/849/commits","review_comments_url":"https://api.github.com/repos/numenta/numenta-apps/pulls/849/comments","review_comment_url":"https://api.github.com/repos/numenta/numenta-apps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numenta/numenta-apps/issues/849/comments","statuses_url":"https://api.github.com/repos/numenta/numenta-apps/statuses/ecc9daa6b4774e9156d40205b244a95ab4ef249b","head":{"label":"andrewmalta13:UNI-545","ref":"UNI-545","sha":"ecc9daa6b4774e9156d40205b244a95ab4ef249b","user":{"login":"andrewmalta13","id":7546926,"avatar_url":"https://avatars.githubusercontent.com/u/7546926?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewmalta13","html_url":"https://github.com/andrewmalta13","followers_url":"https://api.github.com/users/andrewmalta13/followers","following_url":"https://api.github.com/users/andrewmalta13/following{/other_user}","gists_url":"https://api.github.com/users/andrewmalta13/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmalta13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmalta13/subscriptions","organizations_url":"https://api.github.com/users/andrewmalta13/orgs","repos_url":"https://api.github.com/users/andrewmalta13/repos","events_url":"https://api.github.com/users/andrewmalta13/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmalta13/received_events","type":"User","site_admin":false},"repo":{"id":59605262,"name":"numenta-apps","full_name":"andrewmalta13/numenta-apps","owner":{"login":"andrewmalta13","id":7546926,"avatar_url":"https://avatars.githubusercontent.com/u/7546926?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewmalta13","html_url":"https://github.com/andrewmalta13","followers_url":"https://api.github.com/users/andrewmalta13/followers","following_url":"https://api.github.com/users/andrewmalta13/following{/other_user}","gists_url":"https://api.github.com/users/andrewmalta13/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmalta13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmalta13/subscriptions","organizations_url":"https://api.github.com/users/andrewmalta13/orgs","repos_url":"https://api.github.com/users/andrewmalta13/repos","events_url":"https://api.github.com/users/andrewmalta13/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmalta13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewmalta13/numenta-apps","description":"HTM based applications and support libraries. Includes Grok for IT Analytics and Grok for Stocks (code name \"Taurus\").","fork":true,"url":"https://api.github.com/repos/andrewmalta13/numenta-apps","forks_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/forks","keys_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/teams","hooks_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/hooks","issue_events_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/issues/events{/number}","events_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/events","assignees_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/assignees{/user}","branches_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/branches{/branch}","tags_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/tags","blobs_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/languages","stargazers_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/stargazers","contributors_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/contributors","subscribers_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/subscribers","subscription_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/subscription","commits_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/contents/{+path}","compare_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/merges","archive_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/downloads","issues_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/issues{/number}","pulls_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/labels{/name}","releases_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/releases{/id}","deployments_url":"https://api.github.com/repos/andrewmalta13/numenta-apps/deployments","created_at":"2016-05-24T20:12:22Z","updated_at":"2016-05-24T20:12:27Z","pushed_at":"2016-06-14T18:22:58Z","git_url":"git://github.com/andrewmalta13/numenta-apps.git","ssh_url":"git@github.com:andrewmalta13/numenta-apps.git","clone_url":"https://github.com/andrewmalta13/numenta-apps.git","svn_url":"https://github.com/andrewmalta13/numenta-apps","homepage":"http://numenta.com","size":58141,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numenta:master","ref":"master","sha":"e87070075686dc115abfcf9ce498031c0836aab1","user":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"repo":{"id":36754402,"name":"numenta-apps","full_name":"numenta/numenta-apps","owner":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numenta/numenta-apps","description":"HTM based applications and support libraries. Includes Grok for IT Analytics and Grok for Stocks (code name \"Taurus\").","fork":false,"url":"https://api.github.com/repos/numenta/numenta-apps","forks_url":"https://api.github.com/repos/numenta/numenta-apps/forks","keys_url":"https://api.github.com/repos/numenta/numenta-apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numenta/numenta-apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numenta/numenta-apps/teams","hooks_url":"https://api.github.com/repos/numenta/numenta-apps/hooks","issue_events_url":"https://api.github.com/repos/numenta/numenta-apps/issues/events{/number}","events_url":"https://api.github.com/repos/numenta/numenta-apps/events","assignees_url":"https://api.github.com/repos/numenta/numenta-apps/assignees{/user}","branches_url":"https://api.github.com/repos/numenta/numenta-apps/branches{/branch}","tags_url":"https://api.github.com/repos/numenta/numenta-apps/tags","blobs_url":"https://api.github.com/repos/numenta/numenta-apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numenta/numenta-apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numenta/numenta-apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/numenta/numenta-apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numenta/numenta-apps/statuses/{sha}","languages_url":"https://api.github.com/repos/numenta/numenta-apps/languages","stargazers_url":"https://api.github.com/repos/numenta/numenta-apps/stargazers","contributors_url":"https://api.github.com/repos/numenta/numenta-apps/contributors","subscribers_url":"https://api.github.com/repos/numenta/numenta-apps/subscribers","subscription_url":"https://api.github.com/repos/numenta/numenta-apps/subscription","commits_url":"https://api.github.com/repos/numenta/numenta-apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/numenta/numenta-apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/numenta/numenta-apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/numenta/numenta-apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/numenta/numenta-apps/contents/{+path}","compare_url":"https://api.github.com/repos/numenta/numenta-apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numenta/numenta-apps/merges","archive_url":"https://api.github.com/repos/numenta/numenta-apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numenta/numenta-apps/downloads","issues_url":"https://api.github.com/repos/numenta/numenta-apps/issues{/number}","pulls_url":"https://api.github.com/repos/numenta/numenta-apps/pulls{/number}","milestones_url":"https://api.github.com/repos/numenta/numenta-apps/milestones{/number}","notifications_url":"https://api.github.com/repos/numenta/numenta-apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numenta/numenta-apps/labels{/name}","releases_url":"https://api.github.com/repos/numenta/numenta-apps/releases{/id}","deployments_url":"https://api.github.com/repos/numenta/numenta-apps/deployments","created_at":"2015-06-02T18:49:30Z","updated_at":"2016-05-30T07:50:43Z","pushed_at":"2016-06-15T20:51:19Z","git_url":"git://github.com/numenta/numenta-apps.git","ssh_url":"git@github.com:numenta/numenta-apps.git","clone_url":"https://github.com/numenta/numenta-apps.git","svn_url":"https://github.com/numenta/numenta-apps","homepage":"http://numenta.com","size":59558,"stargazers_count":103,"watchers_count":103,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":12,"forks":65,"open_issues":12,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numenta/numenta-apps/pulls/849"},"html":{"href":"https://github.com/numenta/numenta-apps/pull/849"},"issue":{"href":"https://api.github.com/repos/numenta/numenta-apps/issues/849"},"comments":{"href":"https://api.github.com/repos/numenta/numenta-apps/issues/849/comments"},"review_comments":{"href":"https://api.github.com/repos/numenta/numenta-apps/pulls/849/comments"},"review_comment":{"href":"https://api.github.com/repos/numenta/numenta-apps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numenta/numenta-apps/pulls/849/commits"},"statuses":{"href":"https://api.github.com/repos/numenta/numenta-apps/statuses/ecc9daa6b4774e9156d40205b244a95ab4ef249b"}}}}
{"actor":{"display_login":"marionleborgne"}}