{"action":"created","comment":{"url":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/comments/66907432","id":66907432,"diff_hunk":"@@ -395,16 +397,17 @@ data LazySplit f a = LazySplit (Lazy (f a)) a (Lazy (f a))\n unsafeSplitDigit :: forall a v. (Monoid v, Measured a v) =>\n   (v -> Boolean) -> v -> Digit a -> Split Array a\n unsafeSplitDigit p i as =\n-  case A.length as of\n-    1 -> Split [] (as ! 0) []\n-    _ ->\n-      let a = as ! 0\n-          bs = A.drop 1 as\n-          i' = i <> measure a\n-      in if p i'\n-           then Split [] a bs\n-           else case unsafeSplitDigit p i' bs of\n-                  Split l x r -> Split (A.cons a l) x r\n+  unsafePartial $","path":"src/Data/FingerTree.purs","position":169,"original_position":177,"commit_id":"b23bcbcdb3d77c16221bf0d0f5b24e4cd5899d87","original_commit_id":"03fa866f4779d60ec3da72492ef6df7163fa465e","user":{"login":"bkonkle","id":30199,"avatar_url":"https://avatars.githubusercontent.com/u/30199?v=3","gravatar_id":"","url":"https://api.github.com/users/bkonkle","html_url":"https://github.com/bkonkle","followers_url":"https://api.github.com/users/bkonkle/followers","following_url":"https://api.github.com/users/bkonkle/following{/other_user}","gists_url":"https://api.github.com/users/bkonkle/gists{/gist_id}","starred_url":"https://api.github.com/users/bkonkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkonkle/subscriptions","organizations_url":"https://api.github.com/users/bkonkle/orgs","repos_url":"https://api.github.com/users/bkonkle/repos","events_url":"https://api.github.com/users/bkonkle/events{/privacy}","received_events_url":"https://api.github.com/users/bkonkle/received_events","type":"User","site_admin":false},"body":"So, in pushing out the Partial constraints, I'm ending up using `unsafePartial` a lot in `Data.Sequence.Ordered`. In some cases it makes perfect sense - `toUnfoldable` and `toUnfoldableDescending` are just using the left and right side for performance, no need to push the constraint up - correct?\r\n\r\nWhat about places where `FingerTree.split` is used, like `partition`, `insert`, `merge`, etc? Should I be taking the unsafe escape hatch everywhere, or does it make sense to push it out to the library consumer anywhere?\r\n\r\nThanks!","created_at":"2016-06-14T04:29:39Z","updated_at":"2016-06-14T04:29:39Z","html_url":"https://github.com/hdgarrood/purescript-sequences/pull/23#discussion_r66907432","pull_request_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/comments/66907432"},"html":{"href":"https://github.com/hdgarrood/purescript-sequences/pull/23#discussion_r66907432"},"pull_request":{"href":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/23","id":73553645,"html_url":"https://github.com/hdgarrood/purescript-sequences/pull/23","diff_url":"https://github.com/hdgarrood/purescript-sequences/pull/23.diff","patch_url":"https://github.com/hdgarrood/purescript-sequences/pull/23.patch","issue_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/issues/23","number":23,"state":"open","locked":false,"title":"Purescript 0.9.1","user":{"login":"kika","id":207889,"avatar_url":"https://avatars.githubusercontent.com/u/207889?v=3","gravatar_id":"","url":"https://api.github.com/users/kika","html_url":"https://github.com/kika","followers_url":"https://api.github.com/users/kika/followers","following_url":"https://api.github.com/users/kika/following{/other_user}","gists_url":"https://api.github.com/users/kika/gists{/gist_id}","starred_url":"https://api.github.com/users/kika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kika/subscriptions","organizations_url":"https://api.github.com/users/kika/orgs","repos_url":"https://api.github.com/users/kika/repos","events_url":"https://api.github.com/users/kika/events{/privacy}","received_events_url":"https://api.github.com/users/kika/received_events","type":"User","site_admin":false},"body":"This is WIP - it fails at least one test out of many successful. \r\n\r\nI'd love to have a review of my usage of `unsafePartial`, not sure if convenient cowboy approach of shooting first and thinking later works here. \r\n\r\nI skimmed through the paper, but can't say I fully understand the algorithm, that could have contributed to not very successful update.\r\nCC @bkonkle re #22","created_at":"2016-06-13T10:30:37Z","updated_at":"2016-06-14T04:29:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2cdf25ef24ccb88ab8b1086d10eb92f7f7a20a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/23/commits","review_comments_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/23/comments","review_comment_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/issues/23/comments","statuses_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/statuses/b23bcbcdb3d77c16221bf0d0f5b24e4cd5899d87","head":{"label":"kika:purescript-0.9.1","ref":"purescript-0.9.1","sha":"b23bcbcdb3d77c16221bf0d0f5b24e4cd5899d87","user":{"login":"kika","id":207889,"avatar_url":"https://avatars.githubusercontent.com/u/207889?v=3","gravatar_id":"","url":"https://api.github.com/users/kika","html_url":"https://github.com/kika","followers_url":"https://api.github.com/users/kika/followers","following_url":"https://api.github.com/users/kika/following{/other_user}","gists_url":"https://api.github.com/users/kika/gists{/gist_id}","starred_url":"https://api.github.com/users/kika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kika/subscriptions","organizations_url":"https://api.github.com/users/kika/orgs","repos_url":"https://api.github.com/users/kika/repos","events_url":"https://api.github.com/users/kika/events{/privacy}","received_events_url":"https://api.github.com/users/kika/received_events","type":"User","site_admin":false},"repo":{"id":60936415,"name":"purescript-sequences","full_name":"kika/purescript-sequences","owner":{"login":"kika","id":207889,"avatar_url":"https://avatars.githubusercontent.com/u/207889?v=3","gravatar_id":"","url":"https://api.github.com/users/kika","html_url":"https://github.com/kika","followers_url":"https://api.github.com/users/kika/followers","following_url":"https://api.github.com/users/kika/following{/other_user}","gists_url":"https://api.github.com/users/kika/gists{/gist_id}","starred_url":"https://api.github.com/users/kika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kika/subscriptions","organizations_url":"https://api.github.com/users/kika/orgs","repos_url":"https://api.github.com/users/kika/repos","events_url":"https://api.github.com/users/kika/events{/privacy}","received_events_url":"https://api.github.com/users/kika/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kika/purescript-sequences","description":"Various efficient-ish sequence types for PureScript.","fork":true,"url":"https://api.github.com/repos/kika/purescript-sequences","forks_url":"https://api.github.com/repos/kika/purescript-sequences/forks","keys_url":"https://api.github.com/repos/kika/purescript-sequences/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kika/purescript-sequences/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kika/purescript-sequences/teams","hooks_url":"https://api.github.com/repos/kika/purescript-sequences/hooks","issue_events_url":"https://api.github.com/repos/kika/purescript-sequences/issues/events{/number}","events_url":"https://api.github.com/repos/kika/purescript-sequences/events","assignees_url":"https://api.github.com/repos/kika/purescript-sequences/assignees{/user}","branches_url":"https://api.github.com/repos/kika/purescript-sequences/branches{/branch}","tags_url":"https://api.github.com/repos/kika/purescript-sequences/tags","blobs_url":"https://api.github.com/repos/kika/purescript-sequences/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kika/purescript-sequences/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kika/purescript-sequences/git/refs{/sha}","trees_url":"https://api.github.com/repos/kika/purescript-sequences/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kika/purescript-sequences/statuses/{sha}","languages_url":"https://api.github.com/repos/kika/purescript-sequences/languages","stargazers_url":"https://api.github.com/repos/kika/purescript-sequences/stargazers","contributors_url":"https://api.github.com/repos/kika/purescript-sequences/contributors","subscribers_url":"https://api.github.com/repos/kika/purescript-sequences/subscribers","subscription_url":"https://api.github.com/repos/kika/purescript-sequences/subscription","commits_url":"https://api.github.com/repos/kika/purescript-sequences/commits{/sha}","git_commits_url":"https://api.github.com/repos/kika/purescript-sequences/git/commits{/sha}","comments_url":"https://api.github.com/repos/kika/purescript-sequences/comments{/number}","issue_comment_url":"https://api.github.com/repos/kika/purescript-sequences/issues/comments{/number}","contents_url":"https://api.github.com/repos/kika/purescript-sequences/contents/{+path}","compare_url":"https://api.github.com/repos/kika/purescript-sequences/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kika/purescript-sequences/merges","archive_url":"https://api.github.com/repos/kika/purescript-sequences/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kika/purescript-sequences/downloads","issues_url":"https://api.github.com/repos/kika/purescript-sequences/issues{/number}","pulls_url":"https://api.github.com/repos/kika/purescript-sequences/pulls{/number}","milestones_url":"https://api.github.com/repos/kika/purescript-sequences/milestones{/number}","notifications_url":"https://api.github.com/repos/kika/purescript-sequences/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kika/purescript-sequences/labels{/name}","releases_url":"https://api.github.com/repos/kika/purescript-sequences/releases{/id}","deployments_url":"https://api.github.com/repos/kika/purescript-sequences/deployments","created_at":"2016-06-12T01:55:52Z","updated_at":"2016-06-12T01:55:53Z","pushed_at":"2016-06-14T03:51:27Z","git_url":"git://github.com/kika/purescript-sequences.git","ssh_url":"git@github.com:kika/purescript-sequences.git","clone_url":"https://github.com/kika/purescript-sequences.git","svn_url":"https://github.com/kika/purescript-sequences","homepage":"http://pursuit.purescript.org/packages/purescript-sequences","size":2287,"stargazers_count":0,"watchers_count":0,"language":"PureScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hdgarrood:master","ref":"master","sha":"6a68dda0c9dc77d2cdb9caf890a68983343d0e26","user":{"login":"hdgarrood","id":1270186,"avatar_url":"https://avatars.githubusercontent.com/u/1270186?v=3","gravatar_id":"","url":"https://api.github.com/users/hdgarrood","html_url":"https://github.com/hdgarrood","followers_url":"https://api.github.com/users/hdgarrood/followers","following_url":"https://api.github.com/users/hdgarrood/following{/other_user}","gists_url":"https://api.github.com/users/hdgarrood/gists{/gist_id}","starred_url":"https://api.github.com/users/hdgarrood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdgarrood/subscriptions","organizations_url":"https://api.github.com/users/hdgarrood/orgs","repos_url":"https://api.github.com/users/hdgarrood/repos","events_url":"https://api.github.com/users/hdgarrood/events{/privacy}","received_events_url":"https://api.github.com/users/hdgarrood/received_events","type":"User","site_admin":false},"repo":{"id":31577077,"name":"purescript-sequences","full_name":"hdgarrood/purescript-sequences","owner":{"login":"hdgarrood","id":1270186,"avatar_url":"https://avatars.githubusercontent.com/u/1270186?v=3","gravatar_id":"","url":"https://api.github.com/users/hdgarrood","html_url":"https://github.com/hdgarrood","followers_url":"https://api.github.com/users/hdgarrood/followers","following_url":"https://api.github.com/users/hdgarrood/following{/other_user}","gists_url":"https://api.github.com/users/hdgarrood/gists{/gist_id}","starred_url":"https://api.github.com/users/hdgarrood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdgarrood/subscriptions","organizations_url":"https://api.github.com/users/hdgarrood/orgs","repos_url":"https://api.github.com/users/hdgarrood/repos","events_url":"https://api.github.com/users/hdgarrood/events{/privacy}","received_events_url":"https://api.github.com/users/hdgarrood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hdgarrood/purescript-sequences","description":"Various efficient-ish sequence types for PureScript.","fork":true,"url":"https://api.github.com/repos/hdgarrood/purescript-sequences","forks_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/forks","keys_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/teams","hooks_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/hooks","issue_events_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/issues/events{/number}","events_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/events","assignees_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/assignees{/user}","branches_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/branches{/branch}","tags_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/tags","blobs_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/git/refs{/sha}","trees_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/statuses/{sha}","languages_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/languages","stargazers_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/stargazers","contributors_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/contributors","subscribers_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/subscribers","subscription_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/subscription","commits_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/commits{/sha}","git_commits_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/git/commits{/sha}","comments_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/comments{/number}","issue_comment_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/issues/comments{/number}","contents_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/contents/{+path}","compare_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/merges","archive_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/downloads","issues_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/issues{/number}","pulls_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls{/number}","milestones_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/milestones{/number}","notifications_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/labels{/name}","releases_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/releases{/id}","deployments_url":"https://api.github.com/repos/hdgarrood/purescript-sequences/deployments","created_at":"2015-03-03T03:18:32Z","updated_at":"2016-06-13T10:29:24Z","pushed_at":"2016-06-14T03:51:27Z","git_url":"git://github.com/hdgarrood/purescript-sequences.git","ssh_url":"git@github.com:hdgarrood/purescript-sequences.git","clone_url":"https://github.com/hdgarrood/purescript-sequences.git","svn_url":"https://github.com/hdgarrood/purescript-sequences","homepage":"http://pursuit.purescript.org/packages/purescript-sequences","size":2270,"stargazers_count":16,"watchers_count":16,"language":"PureScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/23"},"html":{"href":"https://github.com/hdgarrood/purescript-sequences/pull/23"},"issue":{"href":"https://api.github.com/repos/hdgarrood/purescript-sequences/issues/23"},"comments":{"href":"https://api.github.com/repos/hdgarrood/purescript-sequences/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hdgarrood/purescript-sequences/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/hdgarrood/purescript-sequences/statuses/b23bcbcdb3d77c16221bf0d0f5b24e4cd5899d87"}}}}
{"actor":{"display_login":"bkonkle"}}