{"push_id":1254295885,"size":11,"distinct_size":11,"ref":"refs/heads/master","head":"338cf6237b9613a4c674f8563473e0dc4d61c5fe","before":"300bee831bf0f412277b9fdd93ad548b1a546365","commits":[{"sha":"9461ef93c4c2fec29a9009b7669c6c3d763b6448","author":{"name":"Vivek Goyal","email":"6391e95e691e142b04089fc8c5919bb65a4d1a63@redhat.com"},"message":"test: Export TEST_DEVS instead of DEVS\n\nDEVS is parsed by docker-storage-setup. So if some test does not want to\nuse it, still it is used by the test and that can lead to unexpected\nresults. For example, when somebody tries to test overlay, DEVS is\nstill set and all the disks are unexpectedly added to volume group\nbacking root lv. That's not what overlay test wanted to test.\n\nSigned-off-by: Vivek Goyal <vgoyal@redhat.com>\n\nCloses: #134\nApproved by: rhatdan","distinct":true,"url":"https://api.github.com/repos/rhvgoyal/docker-storage-setup/commits/9461ef93c4c2fec29a9009b7669c6c3d763b6448"},{"sha":"194eca25fd0d180b62f3ecf1b7b408992fd6a083","author":{"name":"Dan Walsh","email":"6a27605abc9dbaa0594764ee8d1278451ea19a31@redhat.com"},"message":"Add reset function to cleanup docker-storage-setup configuration\n\nThis script should cleanup devicemapper storage as well as\nremove /etc/sysconfig/docker-storage\n\nCloses: #128\nApproved by: rhvgoyal","distinct":true,"url":"https://api.github.com/repos/rhvgoyal/docker-storage-setup/commits/194eca25fd0d180b62f3ecf1b7b408992fd6a083"},{"sha":"0f1b96bd68add4d5fd3b33f82e2636ab0d775f4b","author":{"name":"Jonathan Lebon","email":"c31c287be0fa99fb99ffcd1860ce22cdd2c0c5ae@redhat.com"},"message":"tests: rename logs file to txt extension\n\nIt's useful to have a \".txt\" extension to the logs file so that e.g.\nwhen uploading it to a web server, the file will be displayed directly\nin the browser.\n\nCloses: #139\nApproved by: rhatdan","distinct":true,"url":"https://api.github.com/repos/rhvgoyal/docker-storage-setup/commits/0f1b96bd68add4d5fd3b33f82e2636ab0d775f4b"},{"sha":"07661904ada47e5c140a03dd84bc2d2c4c161d8c","author":{"name":"stephen679","email":"41d78b5f30fd9ecc7ccafafd535e122ac1601843@redhat.com"},"message":"modified old tests to use vg_exists helper function\n\nCloses: #143\nApproved by: rhvgoyal","distinct":true,"url":"https://api.github.com/repos/rhvgoyal/docker-storage-setup/commits/07661904ada47e5c140a03dd84bc2d2c4c161d8c"},{"sha":"12e4e23741833f0f6e307abc6ad2561df4b5854d","author":{"name":"stephen679","email":"41d78b5f30fd9ecc7ccafafd535e122ac1601843@redhat.com"},"message":"Syntax error with variable $vg_name\n\nWhen calling the function vg_exists, there is a missing \"$\" in front of vg_name.\nAdd this back in to pass in the actual value of $vg_name.\n\nSigned-off-by: Stephen Chung <schung@redhat.com>\n\nCloses: #145\nApproved by: rhvgoyal","distinct":true,"url":"https://api.github.com/repos/rhvgoyal/docker-storage-setup/commits/12e4e23741833f0f6e307abc6ad2561df4b5854d"},{"sha":"2b61a959d0c73e6e36959ee2fe26b165e846f704","author":{"name":"stephen679","email":"41d78b5f30fd9ecc7ccafafd535e122ac1601843@redhat.com"},"message":"Remove redundant calls to create_config_files\n\nrun-tests.sh ensures that all config files are clean before the first test, and each\ntest calls clean_config_files before they return. Thus, calling\nclean_config_files at the beginning of each test is unnecessary\nsince these tests ensure that the config files are clean before\nmoving on to the next test.\n\nSigned-off-by: Stephen Chung <schung@redhat.com>\n\nCloses: #145\nApproved by: rhvgoyal","distinct":true,"url":"https://api.github.com/repos/rhvgoyal/docker-storage-setup/commits/2b61a959d0c73e6e36959ee2fe26b165e846f704"},{"sha":"b4e178a6985e1f42d0d58caf6b88a0f8243fc930","author":{"name":"stephen679","email":"41d78b5f30fd9ecc7ccafafd535e122ac1601843@redhat.com"},"message":"Cleanup $test_status initialization\n\nSet $test_status=1 during declaration. This avoids initialization later\nresulting in less lines of code.\n\nSigned-off-by: Stephen Chung <schung@redhat.com>\n\nCloses: #145\nApproved by: rhvgoyal","distinct":true,"url":"https://api.github.com/repos/rhvgoyal/docker-storage-setup/commits/b4e178a6985e1f42d0d58caf6b88a0f8243fc930"},{"sha":"9ede69f4841f84a03dc03c4faba5be797aa0cf07","author":{"name":"stephen679","email":"41d78b5f30fd9ecc7ccafafd535e122ac1601843@redhat.com"},"message":"Return $test_status\n\nInstead of explicitly returning 0 or 1 for success/failure,\nreturn $test_status to maintain consistency about the result\nthroughout each test.\n\nSigned-off-by: Stephen Chung <schung@redhat.com>\n\nCloses: #145\nApproved by: rhvgoyal","distinct":true,"url":"https://api.github.com/repos/rhvgoyal/docker-storage-setup/commits/9ede69f4841f84a03dc03c4faba5be797aa0cf07"},{"sha":"6fd88c70531e8b59d2947742b849b59f3278ae6a","author":{"name":"Stephen Chung","email":"41d78b5f30fd9ecc7ccafafd535e122ac1601843@redhat.com"},"message":"Test 007: Check EXTRA_DOCKER_STORAGE_OPTIONS\n\nWhen a user specifies extra docker storage options by\nsetting the EXTRA_DOCKER_STORAGE_OPTIONS variable in\n/etc/sysconfig/docker-storage-setup, d-s-s should modify\n/etc/sysconfig/docker-storage config file by appending\nthis value to DOCKER_STORAGE_OPTIONS. This test checks to\nmake sure that d-s-s successfully appends this value.\n\nSigned-off-by: Stephen Chung <schung@redhat.com>\n\nCloses: #146\nApproved by: rhvgoyal","distinct":true,"url":"https://api.github.com/repos/rhvgoyal/docker-storage-setup/commits/6fd88c70531e8b59d2947742b849b59f3278ae6a"},{"sha":"be1c81c76c3b1b5db744a66a0d9e7b0fd5d48b0e","author":{"name":"Stephen Chung","email":"41d78b5f30fd9ecc7ccafafd535e122ac1601843@redhat.com"},"message":"error out if docker.service is running before tests\n\nIf docker.service is already running before user executes\n./run-tests.sh, this implies docker-storage-setup has\nalready configured storage and that ultimately affects\noutcome of the tests. docker.service status should instead\nbe detected and run-tests.sh should error out accordingly.\n\nSigned-off-by: Stephen Chung <schung@redhat.com>\n\nCloses: #148\nApproved by: rhvgoyal","distinct":true,"url":"https://api.github.com/repos/rhvgoyal/docker-storage-setup/commits/be1c81c76c3b1b5db744a66a0d9e7b0fd5d48b0e"},{"sha":"338cf6237b9613a4c674f8563473e0dc4d61c5fe","author":{"name":"Stephen Chung","email":"41d78b5f30fd9ecc7ccafafd535e122ac1601843@redhat.com"},"message":"Check that no metadata exists if using devmapper\n\nrun-tests.sh needs to make sure docker metadata is\ndoesn't exist if using devicemapper because it could\npotentially affect results of d-s-s\n\nSigned-off-by: Stephen Chung <schung@redhat.com>\n\nCloses: #148\nApproved by: rhvgoyal","distinct":true,"url":"https://api.github.com/repos/rhvgoyal/docker-storage-setup/commits/338cf6237b9613a4c674f8563473e0dc4d61c5fe"}]}
{"actor":{"display_login":"rhvgoyal"}}