{"action":"created","issue":{"url":"https://api.github.com/repos/sendgrid/sendgrid-nodejs/issues/219","repository_url":"https://api.github.com/repos/sendgrid/sendgrid-nodejs","labels_url":"https://api.github.com/repos/sendgrid/sendgrid-nodejs/issues/219/labels{/name}","comments_url":"https://api.github.com/repos/sendgrid/sendgrid-nodejs/issues/219/comments","events_url":"https://api.github.com/repos/sendgrid/sendgrid-nodejs/issues/219/events","html_url":"https://github.com/sendgrid/sendgrid-nodejs/pull/219","id":145901211,"number":219,"title":"added read stream support + test","user":{"login":"sourabhdesai","id":3005241,"avatar_url":"https://avatars.githubusercontent.com/u/3005241?v=3","gravatar_id":"","url":"https://api.github.com/users/sourabhdesai","html_url":"https://github.com/sourabhdesai","followers_url":"https://api.github.com/users/sourabhdesai/followers","following_url":"https://api.github.com/users/sourabhdesai/following{/other_user}","gists_url":"https://api.github.com/users/sourabhdesai/gists{/gist_id}","starred_url":"https://api.github.com/users/sourabhdesai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourabhdesai/subscriptions","organizations_url":"https://api.github.com/users/sourabhdesai/orgs","repos_url":"https://api.github.com/users/sourabhdesai/repos","events_url":"https://api.github.com/users/sourabhdesai/events{/privacy}","received_events_url":"https://api.github.com/users/sourabhdesai/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-05T06:29:18Z","updated_at":"2016-05-21T20:07:53Z","closed_at":"2016-05-21T20:07:53Z","pull_request":{"url":"https://api.github.com/repos/sendgrid/sendgrid-nodejs/pulls/219","html_url":"https://github.com/sendgrid/sendgrid-nodejs/pull/219","diff_url":"https://github.com/sendgrid/sendgrid-nodejs/pull/219.diff","patch_url":"https://github.com/sendgrid/sendgrid-nodejs/pull/219.patch"},"body":"[Issue-148](https://github.com/sendgrid/sendgrid-nodejs/issues/148)\r\nAdds ReadStream support for email attachments\r\n\r\nPossible Use Case:\r\n- Generating PDFs from within node app. Many PDF generation libraries in node return the result pdf as a ReadStream. If one wanted to attach the generated PDF to an email, they would need to save the PDF locally and then give the `Email` object the path to the file. With this, there is an intermediary step of storing the stream contents into a file, and then attaching the file to the email. With this pull request, you can attach it directly with the `stream` option:\r\n\r\n```\r\nvar pdfStream = generatePDFStream({ ... });\r\nemail.addFile({\r\n  filename: 'foo.pdf',\r\n  contentType: 'application/pdf',\r\n  stream: pdfStream\r\n});\r\n```"},"comment":{"url":"https://api.github.com/repos/sendgrid/sendgrid-nodejs/issues/comments/220797814","html_url":"https://github.com/sendgrid/sendgrid-nodejs/pull/219#issuecomment-220797814","issue_url":"https://api.github.com/repos/sendgrid/sendgrid-nodejs/issues/219","id":220797814,"user":{"login":"thinkingserious","id":146695,"avatar_url":"https://avatars.githubusercontent.com/u/146695?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkingserious","html_url":"https://github.com/thinkingserious","followers_url":"https://api.github.com/users/thinkingserious/followers","following_url":"https://api.github.com/users/thinkingserious/following{/other_user}","gists_url":"https://api.github.com/users/thinkingserious/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkingserious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkingserious/subscriptions","organizations_url":"https://api.github.com/users/thinkingserious/orgs","repos_url":"https://api.github.com/users/thinkingserious/repos","events_url":"https://api.github.com/users/thinkingserious/events{/privacy}","received_events_url":"https://api.github.com/users/thinkingserious/received_events","type":"User","site_admin":false},"created_at":"2016-05-21T20:07:52Z","updated_at":"2016-05-21T20:07:52Z","body":"Hello @sourabhdesai,\r\n\r\nThanks for your pull request!\r\n\r\nThis library is being replaced within a few weeks: https://github.com/sendgrid/sendgrid-nodejs/tree/v3beta and it relies on our new v3 /mail/send endpoint: https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/index.html\r\n\r\nIf you would like to add this functionality, we would need you to make a pull request against the v3beta branch and sign our CLA: https://github.com/sendgrid/sendgrid-nodejs/blob/v3beta/CONTRIBUTING.md#cla\r\n\r\nThank you for your support!\r\n\r\nWith Best Regards,\r\n\r\nElmer"}}
{"actor":{"display_login":"thinkingserious"}}