{"push_id":1368259741,"size":49,"distinct_size":49,"ref":"refs/heads/master","head":"a78a4df1cd11e2b97415b9c476912283348d33c1","before":"70a13c0d984b338b91940104f170582a22e5c9d6","commits":[{"sha":"8edfd127a8ba0d7428ecb4174b279397195c5345","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"introduce logic to buck doctor\n\nSummary:\nThe new buck doctor command is going to be used to help users debug their build by\nproviding fixes or suggestions. The command gathers information about only **one** build\nand sends it to a remote endpoint that is doing the debugging and returns the suggested\nsolutions.\n\nThe communication is happening in Json or in a post request.\nIf more arguments are needed then an extra section needs to be defined in the form of\n[doctor_extra_request_args] and all the fields are added as parameters in the request.\n\nBoth are supported and the values can be set in the buckconfig along with the endpoint.\n\nFormat of request: `AbstractDoctorEndpointRequest`.\nFormat of response: `AbstractDoctorEndpointResponse`\n\nDocumentation:\n{F64093755}\n{F64093756}\n\nNote: the documentation is missing the rage stuff, it will be done in another diff since it's unrelated to this.\n\nTest Plan:\n- new integration test that constructs, communicates and present the information.\n- tests for error messages\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 80dd631","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/8edfd127a8ba0d7428ecb4174b279397195c5345"},{"sha":"fecac691dadf10eb9962582fe44190211ce336a5","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"assertThat for DoctorIntegrationTest\n\nTest Plan: CI\n\nReviewed By: k21\n\nfbshipit-source-id: 6cd6b23","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/fecac691dadf10eb9962582fe44190211ce336a5"},{"sha":"999ad2cae3b708a62ccdfccca7e68b4901abbcb1","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Remove MaxPermSize.\n\nSummary:\nAs noted by davido in https://github.com/facebook/buck/commit/277a8866e59d53a3faf2e2bb2ddbb1df180fac68#commitcomment-19537270,\nthis was originally in the else branch of the Java 8 check as Java 8 does not\nsupport it.\n\nTest Plan: CI\n\nReviewed By: ruibm\n\nfbshipit-source-id: fd07408","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/999ad2cae3b708a62ccdfccca7e68b4901abbcb1"},{"sha":"69af21152f03a5f77c85744383d17eb36ee824e1","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Remove UseAssertTrueInsteadOfAssertEquals.\n\nSummary:\nSeems like the new PMD doesn't have the issue that caused us to\nadd these in the first place.\n\nTest Plan: CI\n\nReviewed By: aiked\n\nfbshipit-source-id: 6c0a9e4","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/69af21152f03a5f77c85744383d17eb36ee824e1"},{"sha":"531e9e2bfae4ad600a7571d97d67e007f57fe65b","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"InputBasedRuleKeyBuilderFactory: make size limit per-rule\n\nSummary:\nPreviously, the change to add input-based rule key size limits made\nthe limits members of the factory, which meant the factory would\nstop producing input-based rule keys after calculating enough rule\nkeys to push it past the limit.  This also meant that whether we'd\nget an input-based rule key for a particular rule would be non-\ndeterministic, as it'd depend on the exact build targts included in\nthe build and the order by which they were built.\n\nThis diff makes the size limits members of the per-rule builder class,\nso that the size limit calculation is done per-rule.\n\nTest Plan: added unittest\n\nReviewed By: k21\n\nfbshipit-source-id: c1b61af","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/531e9e2bfae4ad600a7571d97d67e007f57fe65b"},{"sha":"6031f4143cd634ce4fd785679b66d5fe07dd125b","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"remove one of doctor testdata dir\n\nSummary:\nDepending the generatio of the temp folder the order could change. So, keep only the one folder\nwe actually need.\n\nTest Plan: CI\n\nReviewed By: k21\n\nfbshipit-source-id: 2206247","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/6031f4143cd634ce4fd785679b66d5fe07dd125b"},{"sha":"4dbe8681e3850c82c759f965edc0f2858269cc5c","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Use streams in DependencyAggregationTestUtil.\n\nTest Plan: CI\n\nReviewed By: k21\n\nfbshipit-source-id: 6474074","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/4dbe8681e3850c82c759f965edc0f2858269cc5c"},{"sha":"921b6213dd070365fdc0f13cf3ece81c4e6644a2","author":{"name":"Tho Nguyen","email":"414eeaa0a4a25695f7528a10c50ce999acef71c2@uber.com"},"message":"Support apple_library as a dependency of swift_library\n\nSummary:\nThis PR will enable `apple_library` to be a (transparent) dependency of `swift_library`, yet only for `apple_library` without objc source that is referenced from library that depends on it.\nCloses https://github.com/facebook/buck/pull/962\n\nReviewed By: ryu2\n\nfbshipit-source-id: 9813f0d","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/921b6213dd070365fdc0f13cf3ece81c4e6644a2"},{"sha":"9af743ba1fa8a4043d949bcdbd9c9871815fdbe8","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"delete unused methods in AppleDescriptions and friends\n\nSummary: Was converting guava functions, and then I noticed this is only used in a test...\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 4003aaf","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/9af743ba1fa8a4043d949bcdbd9c9871815fdbe8"},{"sha":"24204a0caa50d58623718caaeaae0e39c7eb49c6","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Replace explicit functions in rules.args.Arg\n\nSummary:\nReplacing explicit functions with lambdas and function references improves\ninteroperability when using them with guava and java function apis.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: a4966ed","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/24204a0caa50d58623718caaeaae0e39c7eb49c6"},{"sha":"e26c866e31d48b9f49483de7b930cc59fa05fa16","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Remove FluentIterable used only to construct a collection\n\nSummary: Cases of: FluentIterable.from($x$).toY().\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 627fdc1","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/e26c866e31d48b9f49483de7b930cc59fa05fa16"},{"sha":"951198b9486ba0c233875207164f6e47c74e64d5","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Predicates.instanceOf(X.class) -> X.class::isInstance\n\nSummary: Use lambda equivalent of guava util function.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 7541e33","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/951198b9486ba0c233875207164f6e47c74e64d5"},{"sha":"a442b4e43b53627abd96df7443539bc0221ea98e","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Predicates.in(x) -> x::contains\n\nSummary: Use method reference instead of guava helper.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 95b261d","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/a442b4e43b53627abd96df7443539bc0221ea98e"},{"sha":"a1c3bd976ba26ce1a883961bf72920c0be22a9d2","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Predicates.notNull() -> Objects::nonNull\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: d067620","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/a1c3bd976ba26ce1a883961bf72920c0be22a9d2"},{"sha":"2e21d5401d316dadd565fcd816fcfe47437d27c4","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Predicates.equalTo(x) -> x::equals\n\nSummary: Same behavior when x is not null. In our uses X is never null.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 65ef691","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/2e21d5401d316dadd565fcd816fcfe47437d27c4"},{"sha":"31c75fa3ca33fe21aafb4bb7d0ff3ad378cf3c57","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Replace Predicates.alwaysTrue() with x -> true\n\nSummary:\nPer StackOverflow answer by JDK developer: http://stackoverflow.com/a/26553481/560137\n\nSimple lambdas are preferred over built-in predicate functions.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 33d7f43","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/31c75fa3ca33fe21aafb4bb7d0ff3ad378cf3c57"},{"sha":"949a2d98a76eba6c26e60a77ce511a7ff5ff1f4d","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Remove more trivial explicitly declared functions and predicates.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 55c5928","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/949a2d98a76eba6c26e60a77ce511a7ff5ff1f4d"},{"sha":"1acf9dec3a6b4beb1ebbda35c6cab4c3278d2269","author":{"name":"Chris Hopman","email":"b4caa24f9de55f461e4c51db2576ccfc3b9fb18e@fb.com"},"message":"Refactor ZipScrubberStep\n\nSummary: This just simplifies the logic of ZipScrubberStep a bit.\n\nTest Plan: run tests, should be no behavior change\n\nReviewed By: Coneko\n\nfbshipit-source-id: 620f3b6","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/1acf9dec3a6b4beb1ebbda35c6cab4c3278d2269"},{"sha":"0992730d62958198c5a79f5fdc196686e01c9535","author":{"name":"Chris Hopman","email":"b4caa24f9de55f461e4c51db2576ccfc3b9fb18e@fb.com"},"message":"Make ZipScrubberStep scrub extended timestamps\n\nSummary:\nMany tools write timestamps into the extended timestamp extra fields\n(see http://mdfs.net/Docs/Comp/Archiving/Zip/ExtraField).\n\nThis change makes ZipScrubberStep also scrub timestamps stored in that\nway.\n\nTest Plan: added test\n\nReviewed By: Coneko\n\nfbshipit-source-id: 8f1a88a","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/0992730d62958198c5a79f5fdc196686e01c9535"},{"sha":"fb9ba8823ec056980ee7ef8133267a9d2604cd64","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Always use_linear_alloc_split_dex in android_binary\n\nSummary:\nBecause zip splitting is no longer done for debug builds, it no longer\nneeds to be super fast.  Therefore, we no longer need to support the\nLinearAlloc-oblivious zip splitter.  Drop it and simplify a bunch of\ncode.\n\nAdd a warning if the argument is present, but we can drop this after a\nwhile.  It was never documented.\n\nTest Plan: CI\n\nReviewed By: asp2insp\n\nfbshipit-source-id: cdbd7d7","distinct":true,"url":"https://api.github.com/repos/brettwooldridge/buck/commits/fb9ba8823ec056980ee7ef8133267a9d2604cd64"}]}
{"actor":{"display_login":"brettwooldridge"}}