{"action":"created","issue":{"url":"https://api.github.com/repos/Zimbra-Community/zimbra-docker/issues/8","repository_url":"https://api.github.com/repos/Zimbra-Community/zimbra-docker","labels_url":"https://api.github.com/repos/Zimbra-Community/zimbra-docker/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/Zimbra-Community/zimbra-docker/issues/8/comments","events_url":"https://api.github.com/repos/Zimbra-Community/zimbra-docker/issues/8/events","html_url":"https://github.com/Zimbra-Community/zimbra-docker/pull/8","id":134305900,"number":8,"title":"Refactor","user":{"login":"washingtoneg","id":180458,"avatar_url":"https://avatars.githubusercontent.com/u/180458?v=3","gravatar_id":"","url":"https://api.github.com/users/washingtoneg","html_url":"https://github.com/washingtoneg","followers_url":"https://api.github.com/users/washingtoneg/followers","following_url":"https://api.github.com/users/washingtoneg/following{/other_user}","gists_url":"https://api.github.com/users/washingtoneg/gists{/gist_id}","starred_url":"https://api.github.com/users/washingtoneg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/washingtoneg/subscriptions","organizations_url":"https://api.github.com/users/washingtoneg/orgs","repos_url":"https://api.github.com/users/washingtoneg/repos","events_url":"https://api.github.com/users/washingtoneg/events{/privacy}","received_events_url":"https://api.github.com/users/washingtoneg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-17T15:12:15Z","updated_at":"2016-03-24T10:45:14Z","closed_at":"2016-02-17T15:14:11Z","pull_request":{"url":"https://api.github.com/repos/Zimbra-Community/zimbra-docker/pulls/8","html_url":"https://github.com/Zimbra-Community/zimbra-docker/pull/8","diff_url":"https://github.com/Zimbra-Community/zimbra-docker/pull/8.diff","patch_url":"https://github.com/Zimbra-Community/zimbra-docker/pull/8.patch"},"body":"This pull request introduces the following:\r\n\r\ndfa5188 - Remove extra whitespace from README\r\n25267e3 - Add Makefile and usage instructions in the README\r\n41e8628 - Clean/Refactor start.sh script\r\n- Move file definitions to files in etc/ and opt/\r\n- Create /opt/zimbra-install/ for the installZimbra* files and `wget`'ing the Zimbra Collaboration software\r\n\r\nae3a9c6 - Clean up Dockerfile\r\n- Move all apt-get commands from start.sh script to Dockerfile (so dependencies are built into the image)\r\n- Group common operations (apt-get, EXPOSE)\r\n- COPY local files to the image/containers filesystem\r\n\r\n9a3c3cc - Sort arguments to apt-get alphanumerically to ease later changes"},"comment":{"url":"https://api.github.com/repos/Zimbra-Community/zimbra-docker/issues/comments/200783527","html_url":"https://github.com/Zimbra-Community/zimbra-docker/pull/8#issuecomment-200783527","issue_url":"https://api.github.com/repos/Zimbra-Community/zimbra-docker/issues/8","id":200783527,"user":{"login":"washingtoneg","id":180458,"avatar_url":"https://avatars.githubusercontent.com/u/180458?v=3","gravatar_id":"","url":"https://api.github.com/users/washingtoneg","html_url":"https://github.com/washingtoneg","followers_url":"https://api.github.com/users/washingtoneg/followers","following_url":"https://api.github.com/users/washingtoneg/following{/other_user}","gists_url":"https://api.github.com/users/washingtoneg/gists{/gist_id}","starred_url":"https://api.github.com/users/washingtoneg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/washingtoneg/subscriptions","organizations_url":"https://api.github.com/users/washingtoneg/orgs","repos_url":"https://api.github.com/users/washingtoneg/repos","events_url":"https://api.github.com/users/washingtoneg/events{/privacy}","received_events_url":"https://api.github.com/users/washingtoneg/received_events","type":"User","site_admin":false},"created_at":"2016-03-24T10:45:14Z","updated_at":"2016-03-24T10:45:14Z","body":"Hey @barrydegraaff. I tried to explain myself thoroughly in the initial comment I made on the pull request that introduced these changes. In there you'll see that I list all of the commits with an explanation of what each of them sets out to do.\r\n\r\nI believe the commit in my PR that you are interested in is 41e8628 - Clean/Refactor start.sh script. The startup script wasn't deleted, it was moved to `docker/opt`. This was (along with some of the other commits) was done in an effort to minimize the number of layers in the Zimbra Docker image and clean up the Dockerfile. That allows us to now utilize a [couple of `Copy` commands](https://github.com/Zimbra-Community/zimbra-docker/blob/master/docker/Dockerfile#L33-L35) in the Dockerfile to place all of the necessary files in our container as well as breakout the file definitions that used to exist in `start.sh`. "}}