{"action":"created","issue":{"url":"https://api.github.com/repos/tbeu/Modelica/issues/1175","repository_url":"https://api.github.com/repos/tbeu/Modelica","labels_url":"https://api.github.com/repos/tbeu/Modelica/issues/1175/labels{/name}","comments_url":"https://api.github.com/repos/tbeu/Modelica/issues/1175/comments","events_url":"https://api.github.com/repos/tbeu/Modelica/issues/1175/events","html_url":"https://github.com/tbeu/Modelica/issues/1175","id":197572546,"number":1175,"title":"Unspecified format of tables text files","user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"labels":[{"id":506762997,"url":"https://api.github.com/repos/tbeu/Modelica/labels/bug","name":"bug","color":"ee0701","default":true},{"id":506768921,"url":"https://api.github.com/repos/tbeu/Modelica/labels/L:Blocks","name":"L:Blocks","color":"0000aa","default":false}],"state":"open","locked":false,"assignee":{"login":"beutlich","id":14896695,"avatar_url":"https://avatars.githubusercontent.com/u/14896695?v=3","gravatar_id":"","url":"https://api.github.com/users/beutlich","html_url":"https://github.com/beutlich","followers_url":"https://api.github.com/users/beutlich/followers","following_url":"https://api.github.com/users/beutlich/following{/other_user}","gists_url":"https://api.github.com/users/beutlich/gists{/gist_id}","starred_url":"https://api.github.com/users/beutlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beutlich/subscriptions","organizations_url":"https://api.github.com/users/beutlich/orgs","repos_url":"https://api.github.com/users/beutlich/repos","events_url":"https://api.github.com/users/beutlich/events{/privacy}","received_events_url":"https://api.github.com/users/beutlich/received_events","type":"User","site_admin":false},"assignees":[{"login":"beutlich","id":14896695,"avatar_url":"https://avatars.githubusercontent.com/u/14896695?v=3","gravatar_id":"","url":"https://api.github.com/users/beutlich","html_url":"https://github.com/beutlich","followers_url":"https://api.github.com/users/beutlich/followers","following_url":"https://api.github.com/users/beutlich/following{/other_user}","gists_url":"https://api.github.com/users/beutlich/gists{/gist_id}","starred_url":"https://api.github.com/users/beutlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beutlich/subscriptions","organizations_url":"https://api.github.com/users/beutlich/orgs","repos_url":"https://api.github.com/users/beutlich/repos","events_url":"https://api.github.com/users/beutlich/events{/privacy}","received_events_url":"https://api.github.com/users/beutlich/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/tbeu/Modelica/milestones/47","html_url":"https://github.com/tbeu/Modelica/milestone/47","labels_url":"https://api.github.com/repos/tbeu/Modelica/milestones/47/labels","id":2214850,"number":47,"title":"MSL3.2.1","description":"Backward compatible bug-fix release.","creator":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":299,"state":"closed","created_at":"2016-12-25T13:00:27Z","updated_at":"2016-12-26T10:31:26Z","due_on":"2013-03-31T07:00:00Z","closed_at":"2016-12-25T13:00:27Z"},"comments":2,"created_at":"2016-12-26T10:30:25Z","updated_at":"2016-12-26T10:31:37Z","closed_at":null,"body":"**Reported by beutlich on 24 Jun 2013 13:20 UTC**\nA proper format specification of the table ASCII text files (see source:Modelica/trunk/Modelica/Resources/Data/Tables/test.txt for an example) is missing. This shortcoming lead to problems like\n\n * #1174 (newlines are allowed in matrix rows)\n * f94a72e7daa6d828945883fe585a65e60bac4f27 for #1151 (trailing non-comments are not allowed in matrix rows)\n * 94c235d4baccc9dbe53984ebf8129cbb8a51b66e (line comments are allowed in matrix rows)\n * comment:50:ticket:1151 (unspecified delimiters for numbers)\n\nthat could have been avoided beforehand.\n\n----\n\nMigrated-From: https://trac.modelica.org/Modelica/ticket/1175"},"comment":{"url":"https://api.github.com/repos/tbeu/Modelica/issues/comments/269197770","html_url":"https://github.com/tbeu/Modelica/issues/1175#issuecomment-269197770","issue_url":"https://api.github.com/repos/tbeu/Modelica/issues/1175","id":269197770,"user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"created_at":"2016-12-26T10:31:37Z","updated_at":"2016-12-26T10:31:37Z","body":"**Comment by otter on 25 Jun 2013 08:11 UTC**\nReplying to [comment:2 beutlich]:\n> Thanks for this comments.\n> \n> I noticed that the old table implementation allows multiple matrix rows on one line of the text file. This is currently not supported by the new table implementation where it is expected that each matrix row starts on a new line. E.g. if a table `double B(m,n)` is found and it is not the one requested then the following `m` lines are skipped.\n> \n> How shall we proceed?\n>  1. For backward compatibility also allow multiple matrix rows per line.\n>  1. Specify in the table doc that each row has to start on a new line.\n\nThe tables need to be as backwards compatible as possible, since otherwise end users will be very upset.\n\nTherefore, to allow multiple matrix rows per line needs to be supported.\n\nI understand the view point: Assume a (3,5) matrix, then 3\\*5 numbers are expected in sequence according to row-wise ordering.\n\nI think error handling can be simple: If any of the tables does not fulfill the definition, an error is raised. So, it seems not necessary to skip a wrong definition and continue with the next. If you still want to support it, then one can scan until the next non-numeric character appears at the beginning of a line, and this must be the type name of the next array.\n\nRecognized that I have forgotten one thing in the description: \"type,name,dimensions\" must be in one line and the line must start with the type (and only optional blanks between line start and the type name).\n\nWill update the table documentation.\n\n\n\n"}}
{"actor":{"display_login":"modelica-trac-importer"}}