{"action":"created","issue":{"url":"https://api.github.com/repos/whatwg/html/issues/1636","repository_url":"https://api.github.com/repos/whatwg/html","labels_url":"https://api.github.com/repos/whatwg/html/issues/1636/labels{/name}","comments_url":"https://api.github.com/repos/whatwg/html/issues/1636/comments","events_url":"https://api.github.com/repos/whatwg/html/issues/1636/events","html_url":"https://github.com/whatwg/html/issues/1636","id":169868874,"number":1636,"title":"\"create an element for a token\" does not account for duplicate attributes","user":{"login":"annevk","id":1544111,"avatar_url":"https://avatars.githubusercontent.com/u/1544111?v=3","gravatar_id":"","url":"https://api.github.com/users/annevk","html_url":"https://github.com/annevk","followers_url":"https://api.github.com/users/annevk/followers","following_url":"https://api.github.com/users/annevk/following{/other_user}","gists_url":"https://api.github.com/users/annevk/gists{/gist_id}","starred_url":"https://api.github.com/users/annevk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annevk/subscriptions","organizations_url":"https://api.github.com/users/annevk/orgs","repos_url":"https://api.github.com/users/annevk/repos","events_url":"https://api.github.com/users/annevk/events{/privacy}","received_events_url":"https://api.github.com/users/annevk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/whatwg/html/labels/topic:%20custom%20elements","name":"topic: custom elements","color":"009800"},{"url":"https://api.github.com/repos/whatwg/html/labels/topic:%20parser","name":"topic: parser","color":"009800"}],"state":"closed","locked":false,"assignee":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"assignees":[{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-08-08T08:29:34Z","updated_at":"2016-08-10T18:19:37Z","closed_at":"2016-08-10T18:19:37Z","body":"As far as I can tell the tokenizer creates tokens with duplicate attributes. The idea being that the tree builder throws these away. However, the append operation in step 8 does not do that. We should probably first check if the attribute already exists? (And we should somehow account for attributes on tokens also having a namespace, see \"adjust foreign attributes\", although maybe that is already sufficiently clear.)\r\n\r\nThe other problem here is that step 3 seems to grab any `is` attribute. It should probably be specific that it wants the first one.\r\n\r\nNoticed while doing research for https://github.com/w3c/webappsec-csp/issues/98."},"comment":{"url":"https://api.github.com/repos/whatwg/html/issues/comments/238956168","html_url":"https://github.com/whatwg/html/issues/1636#issuecomment-238956168","issue_url":"https://api.github.com/repos/whatwg/html/issues/1636","id":238956168,"user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T18:19:37Z","updated_at":"2016-08-10T18:19:37Z","body":"As discovered in https://github.com/whatwg/html/pull/1637#issuecomment-238490231 this is handled at an earlier stage; the token will not contain duplicate attributes."}}
{"actor":{"display_login":"domenic"}}