{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7856","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7856/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7856/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7856/events","html_url":"https://github.com/nodejs/node/pull/7856","id":167202876,"number":7856,"title":"fs: Fix default params for fs.write","user":{"login":"papandreou","id":373545,"avatar_url":"https://avatars.githubusercontent.com/u/373545?v=3","gravatar_id":"","url":"https://api.github.com/users/papandreou","html_url":"https://github.com/papandreou","followers_url":"https://api.github.com/users/papandreou/followers","following_url":"https://api.github.com/users/papandreou/following{/other_user}","gists_url":"https://api.github.com/users/papandreou/gists{/gist_id}","starred_url":"https://api.github.com/users/papandreou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papandreou/subscriptions","organizations_url":"https://api.github.com/users/papandreou/orgs","repos_url":"https://api.github.com/users/papandreou/repos","events_url":"https://api.github.com/users/papandreou/events{/privacy}","received_events_url":"https://api.github.com/users/papandreou/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-07-23T20:49:58Z","updated_at":"2016-08-18T18:31:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7856","html_url":"https://github.com/nodejs/node/pull/7856","diff_url":"https://github.com/nodejs/node/pull/7856.diff","patch_url":"https://github.com/nodejs/node/pull/7856.patch"},"body":"##### Checklist\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nfs\r\n\r\n##### Description of change\r\nAdd support for `fs.write(fd, buffer, cb)` and `fs.write(fd, buffer, offset, cb)` as documented at https://nodejs.org/api/fs.html#fs_fs_write_fd_data_position_encoding_callback (it says that `data` can be either a string or a Buffer).\r\n\r\nUpdate: Extended to apply to `fs.writeSync` as well, which turned out to have the same issue (#7879)."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/240813910","html_url":"https://github.com/nodejs/node/pull/7856#issuecomment-240813910","issue_url":"https://api.github.com/repos/nodejs/node/issues/7856","id":240813910,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T18:31:32Z","updated_at":"2016-08-18T18:31:32Z","body":"@trevnorris should I count that as a LGTM?"}}
{"actor":{"display_login":"jasnell"}}