{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/89027178","pull_request_review_id":9579990,"id":89027178,"diff_hunk":"@@ -7060,7 +7060,13 @@ void Compiler::fgMorphTailCall(GenTreeCall* call)\n         }\n #endif // _TARGET_X86_\n \n+#if !defined(_TARGET_X86_)\n         if (call->NeedsNullCheck())\n+#else\n+        // When targeting x86, we always need to perform a null check on the `this` argument before tail calling to a\n+        // virtual dispatch stub.","path":"src/jit/morph.cpp","position":8,"original_position":8,"commit_id":"59726b88a36be8017c61c98f8c900d3d0380b650","original_commit_id":"59726b88a36be8017c61c98f8c900d3d0380b650","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"> Can you add to the comment a description of why we need to do this?\r\n\r\nI wish I could. Neither the legacy backend nor the JIT32 backend offer any explanation.\r\n\r\n>Also, I'd prefer you write it as:\r\n\r\nOkay. ","created_at":"2016-11-22T01:25:57Z","updated_at":"2016-11-22T01:25:57Z","html_url":"https://github.com/dotnet/coreclr/pull/8242#discussion_r89027178","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/8242","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/89027178"},"html":{"href":"https://github.com/dotnet/coreclr/pull/8242#discussion_r89027178"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8242"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/8242","id":94727224,"html_url":"https://github.com/dotnet/coreclr/pull/8242","diff_url":"https://github.com/dotnet/coreclr/pull/8242.diff","patch_url":"https://github.com/dotnet/coreclr/pull/8242.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/8242","number":8242,"state":"open","locked":false,"title":"Always nullcheck VSD tail calls on x86.","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"This is a requirement of the runtime ABI: failing to perform this check\r\ncauses the runtime to AV in the virtual dispatch stub and crash.","created_at":"2016-11-22T00:44:49Z","updated_at":"2016-11-22T01:25:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7dda372fcbb50b3a11f1e2b3d3cc9f3e40506ba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/8242/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/8242/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/8242/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/59726b88a36be8017c61c98f8c900d3d0380b650","head":{"label":"pgavlin:gh8232","ref":"gh8232","sha":"59726b88a36be8017c61c98f8c900d3d0380b650","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"repo":{"id":30321049,"name":"coreclr","full_name":"pgavlin/coreclr","owner":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgavlin/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/pgavlin/coreclr","forks_url":"https://api.github.com/repos/pgavlin/coreclr/forks","keys_url":"https://api.github.com/repos/pgavlin/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgavlin/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgavlin/coreclr/teams","hooks_url":"https://api.github.com/repos/pgavlin/coreclr/hooks","issue_events_url":"https://api.github.com/repos/pgavlin/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/pgavlin/coreclr/events","assignees_url":"https://api.github.com/repos/pgavlin/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/pgavlin/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/pgavlin/coreclr/tags","blobs_url":"https://api.github.com/repos/pgavlin/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgavlin/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgavlin/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgavlin/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgavlin/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/pgavlin/coreclr/languages","stargazers_url":"https://api.github.com/repos/pgavlin/coreclr/stargazers","contributors_url":"https://api.github.com/repos/pgavlin/coreclr/contributors","subscribers_url":"https://api.github.com/repos/pgavlin/coreclr/subscribers","subscription_url":"https://api.github.com/repos/pgavlin/coreclr/subscription","commits_url":"https://api.github.com/repos/pgavlin/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgavlin/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgavlin/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgavlin/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgavlin/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/pgavlin/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgavlin/coreclr/merges","archive_url":"https://api.github.com/repos/pgavlin/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgavlin/coreclr/downloads","issues_url":"https://api.github.com/repos/pgavlin/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/pgavlin/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/pgavlin/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/pgavlin/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgavlin/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/pgavlin/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/pgavlin/coreclr/deployments","created_at":"2015-02-04T21:04:39Z","updated_at":"2016-02-26T17:14:54Z","pushed_at":"2016-11-22T00:48:06Z","git_url":"git://github.com/pgavlin/coreclr.git","ssh_url":"git@github.com:pgavlin/coreclr.git","clone_url":"https://github.com/pgavlin/coreclr.git","svn_url":"https://github.com/pgavlin/coreclr","homepage":"","size":119553,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"fcf8c0a4a646d874285db0c50d5e70122e568d7b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-11-21T23:59:10Z","pushed_at":"2016-11-22T00:54:00Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":134416,"stargazers_count":7076,"watchers_count":7076,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1719,"mirror_url":null,"open_issues_count":1029,"forks":1719,"open_issues":1029,"watchers":7076,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8242"},"html":{"href":"https://github.com/dotnet/coreclr/pull/8242"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/8242"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/8242/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8242/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/8242/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/59726b88a36be8017c61c98f8c900d3d0380b650"}}}}
{"actor":{"display_login":"pgavlin"}}