{"action":"opened","issue":{"url":"https://api.github.com/repos/ProseMirror/prosemirror/issues/460","repository_url":"https://api.github.com/repos/ProseMirror/prosemirror","labels_url":"https://api.github.com/repos/ProseMirror/prosemirror/issues/460/labels{/name}","comments_url":"https://api.github.com/repos/ProseMirror/prosemirror/issues/460/comments","events_url":"https://api.github.com/repos/ProseMirror/prosemirror/issues/460/events","html_url":"https://github.com/ProseMirror/prosemirror/issues/460","id":179534720,"number":460,"title":"Editor enters bad state - no clikcOn fired - view.shiftKey get's stuck on \"true\"","user":{"login":"wes-r","id":1568246,"avatar_url":"https://avatars.githubusercontent.com/u/1568246?v=3","gravatar_id":"","url":"https://api.github.com/users/wes-r","html_url":"https://github.com/wes-r","followers_url":"https://api.github.com/users/wes-r/followers","following_url":"https://api.github.com/users/wes-r/following{/other_user}","gists_url":"https://api.github.com/users/wes-r/gists{/gist_id}","starred_url":"https://api.github.com/users/wes-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wes-r/subscriptions","organizations_url":"https://api.github.com/users/wes-r/orgs","repos_url":"https://api.github.com/users/wes-r/repos","events_url":"https://api.github.com/users/wes-r/events{/privacy}","received_events_url":"https://api.github.com/users/wes-r/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-27T15:54:12Z","updated_at":"2016-09-27T15:54:12Z","closed_at":null,"body":"Seemingly randomly my editor will enter a bad state where my `clickOn` handlers are no longer getting called. I've chased it down to https://github.com/ProseMirror/prosemirror-view/blob/9680e1bdbf3902e40e21d1e7b6e4301978e1f726/src/input.js#L240\r\n\r\nWhat I think is happening is that a shift keyup event is failing to trigger the setting of `view.shiftKey = false`. So when we go to create the `MouseDown` object, it gets set with `allowDefault = true`.\r\n\r\nLooks like we can remove `allowDefault` all together and instead use the raw event. I only see two uses: `handlers.paste` which has an event object and we use shift to paste as plaintext, and in `up` handler which skips firing click handlers. Both of these uses can use the event they are provided to check for shiftKey which will avoid the book keeping of this state."}}
{"actor":{"display_login":"wes-r"}}