{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/api-umbrella/issues/243","repository_url":"https://api.github.com/repos/NREL/api-umbrella","labels_url":"https://api.github.com/repos/NREL/api-umbrella/issues/243/labels{/name}","comments_url":"https://api.github.com/repos/NREL/api-umbrella/issues/243/comments","events_url":"https://api.github.com/repos/NREL/api-umbrella/issues/243/events","html_url":"https://github.com/NREL/api-umbrella/pull/243","id":157149904,"number":243,"title":"Webapp test","user":{"login":"ThibautGery","id":5861569,"avatar_url":"https://avatars.githubusercontent.com/u/5861569?v=3","gravatar_id":"","url":"https://api.github.com/users/ThibautGery","html_url":"https://github.com/ThibautGery","followers_url":"https://api.github.com/users/ThibautGery/followers","following_url":"https://api.github.com/users/ThibautGery/following{/other_user}","gists_url":"https://api.github.com/users/ThibautGery/gists{/gist_id}","starred_url":"https://api.github.com/users/ThibautGery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThibautGery/subscriptions","organizations_url":"https://api.github.com/users/ThibautGery/orgs","repos_url":"https://api.github.com/users/ThibautGery/repos","events_url":"https://api.github.com/users/ThibautGery/events{/privacy}","received_events_url":"https://api.github.com/users/ThibautGery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-27T07:52:51Z","updated_at":"2016-05-27T16:00:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NREL/api-umbrella/pulls/243","html_url":"https://github.com/NREL/api-umbrella/pull/243","diff_url":"https://github.com/NREL/api-umbrella/pull/243.diff","patch_url":"https://github.com/NREL/api-umbrella/pull/243.patch"},"body":"In order to easily run the tests of the web application\r\n\r\n * Run the middleware (mongo & elasticsearch) on the correct port using docker\r\n * Add the commands in the readme"},"comment":{"url":"https://api.github.com/repos/NREL/api-umbrella/issues/comments/222185414","html_url":"https://github.com/NREL/api-umbrella/pull/243#issuecomment-222185414","issue_url":"https://api.github.com/repos/NREL/api-umbrella/issues/243","id":222185414,"user":{"login":"GUI","id":12112,"avatar_url":"https://avatars.githubusercontent.com/u/12112?v=3","gravatar_id":"","url":"https://api.github.com/users/GUI","html_url":"https://github.com/GUI","followers_url":"https://api.github.com/users/GUI/followers","following_url":"https://api.github.com/users/GUI/following{/other_user}","gists_url":"https://api.github.com/users/GUI/gists{/gist_id}","starred_url":"https://api.github.com/users/GUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GUI/subscriptions","organizations_url":"https://api.github.com/users/GUI/orgs","repos_url":"https://api.github.com/users/GUI/repos","events_url":"https://api.github.com/users/GUI/events{/privacy}","received_events_url":"https://api.github.com/users/GUI/received_events","type":"User","site_admin":false},"created_at":"2016-05-27T16:00:19Z","updated_at":"2016-05-27T16:00:19Z","body":"Thanks for the contribution!\r\n\r\nThat CircleCI test failure is really odd. I think it must have been a temporary fluke on CircleCI's end. After triggering a retry in Circle it looks like it's successfully building (although, unfortunately it took 2 retries, since the first one errored on some integration tests that do seem to randomly fail in the CI environment--we obviously need to debug that to eliminate those).\r\n\r\nI did have some questions/comments about this pull request:\r\n\r\n- Are you using [Vagrant development environment](https://api-umbrella.readthedocs.io/en/latest/developer/dev-setup.html) for development? Or are you running things directly on your computer? The Vagrant development environment should already provide ElasticSearch and MongoDB running on the appropriate ports, but if you're interested in developing without Vagrant, that would be great to know. If you are running without Vagrant, are you only running the `web-app` Rails application or are you also running the full stack (nginx, etc) locally?\r\n  - More generally, we are still trying to figure out how to best leverage Docker, so if you have any suggestions, we're open to suggestions. For running API Umbrella (rather than developing), we have a [Docker container](https://hub.docker.com/r/nrel/api-umbrella/), but I think we're also still interested in providing system packages (RPMs and DEBs), so that may complicate things a bit versus providing a Docker-only solution.\r\n  - It would be nice to figure out better ways to leverage Docker for the development environment like what you've done here, since the Vagrant environment does take quite a while to setup the first time (since we need to compile a bunch of things from source). This looks good for the web app, and maybe we start there, but I'm just trying to think of how this looks with the rest of our non-Rails components (and how it also integrates with our RPM/DEP build/packaging process).\r\n- Was there a reason for ignoring the `Gemfile.lock` file? We actually do [commit](https://github.com/NREL/api-umbrella/blob/master/src/api-umbrella/web-app/Gemfile.lock) that file to our repo and want to track changes. I typically take the approach of only ignoring Gemfile.lock when [working on gems](http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/), but if you were running into any issues with this, let us know..\r\n- For the IDEA gitignore additions, I think we'd actually prefer to keep those out of our application gitignore files and move those into a [global gitignore file](https://github.com/NREL/api-umbrella/blob/master/src/api-umbrella/web-app/.gitignore#L1-L5) that's specific to your computer. If you haven't used global gitignores before, they're actually quite handy, since then you only have to set your editor ignores once on your computer (rather than in each project). It also means we don't have to track all the possible combination of tempfiles different editors might generate for different developers on the project.\r\n\r\nSorry for the long response, but does all that make sense? Let us know if you have any questions. But thanks again for diving in and for the contributions!"}}
{"actor":{"display_login":"GUI"}}