{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/68139821","id":68139821,"diff_hunk":"@@ -977,15 +977,14 @@ OverlayImpl::relay (protocol::TMProposeSet& m,\n {\n     if (m.has_hops() && m.hops() >= maxTTL)\n         return;\n-    std::set<Peer::id_t> skip;\n-    if (! app_.getHashRouter().prepRelay (\n-            uid, skip))\n+    auto const skip = app_.getHashRouter().shouldRelay(uid);\n+    if (! skip)","path":"src/ripple/overlay/impl/OverlayImpl.cpp","position":null,"original_position":34,"commit_id":"52b87b1e7940931153cc20bce7ec3dcc6b00bf7f","original_commit_id":"52b87b1e7940931153cc20bce7ec3dcc6b00bf7f","user":{"login":"seelabs","id":5853458,"avatar_url":"https://avatars.githubusercontent.com/u/5853458?v=3","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false},"body":"Nit: The code reads a little weird. It looks like \"if I don't want to skip, then return (thereby skipping)\". Maybe don't use auto so it's clear the variable is an optional collection and not a bool, or consider renaming the variable so it sounds more like a collection and less like a bool. Maybe `toSkip`?\r\n\r\nI understand the code, and it's correct, but consider renaming the variable. ","created_at":"2016-06-22T21:35:49Z","updated_at":"2016-06-22T21:35:49Z","html_url":"https://github.com/ripple/rippled/pull/1749#discussion_r68139821","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/1749","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/68139821"},"html":{"href":"https://github.com/ripple/rippled/pull/1749#discussion_r68139821"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1749"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1749","id":74299999,"html_url":"https://github.com/ripple/rippled/pull/1749","diff_url":"https://github.com/ripple/rippled/pull/1749.diff","patch_url":"https://github.com/ripple/rippled/pull/1749.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1749","number":1749,"state":"open","locked":false,"title":"Improve TxQ edge-case handling logic (RIPD-1200):","user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"body":"* HashRouter: Track relay expiration separately from item lifespan.\r\n  * Renamed `swapSet` to `prepRelay`.\r\n  * Cleaned up `HashRouter` member names and removed unused code.\r\n  * Remove `SF_RELAYED` flag.\r\n* Fix TxQ edge case replacing dropped transactions.\r\n* Fix TxQ bug in maximumTxnPerAccount check.\r\n\r\n@seelabs found the dropped transactions issue. @JoelKatz suggested the HashRouter changes.","created_at":"2016-06-17T20:23:26Z","updated_at":"2016-06-22T21:35:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"650c695be773987cbc14cf2f50bf5e3769d91269","assignee":{"login":"JoelKatz","id":877549,"avatar_url":"https://avatars.githubusercontent.com/u/877549?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelKatz","html_url":"https://github.com/JoelKatz","followers_url":"https://api.github.com/users/JoelKatz/followers","following_url":"https://api.github.com/users/JoelKatz/following{/other_user}","gists_url":"https://api.github.com/users/JoelKatz/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelKatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelKatz/subscriptions","organizations_url":"https://api.github.com/users/JoelKatz/orgs","repos_url":"https://api.github.com/users/JoelKatz/repos","events_url":"https://api.github.com/users/JoelKatz/events{/privacy}","received_events_url":"https://api.github.com/users/JoelKatz/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/1749/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/1749/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1749/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/52b87b1e7940931153cc20bce7ec3dcc6b00bf7f","head":{"label":"ximinez:txq-assert","ref":"txq-assert","sha":"52b87b1e7940931153cc20bce7ec3dcc6b00bf7f","user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"repo":{"id":17236735,"name":"rippled","full_name":"ximinez/rippled","owner":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ximinez/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/ximinez/rippled","forks_url":"https://api.github.com/repos/ximinez/rippled/forks","keys_url":"https://api.github.com/repos/ximinez/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ximinez/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ximinez/rippled/teams","hooks_url":"https://api.github.com/repos/ximinez/rippled/hooks","issue_events_url":"https://api.github.com/repos/ximinez/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ximinez/rippled/events","assignees_url":"https://api.github.com/repos/ximinez/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ximinez/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ximinez/rippled/tags","blobs_url":"https://api.github.com/repos/ximinez/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ximinez/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ximinez/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ximinez/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ximinez/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ximinez/rippled/languages","stargazers_url":"https://api.github.com/repos/ximinez/rippled/stargazers","contributors_url":"https://api.github.com/repos/ximinez/rippled/contributors","subscribers_url":"https://api.github.com/repos/ximinez/rippled/subscribers","subscription_url":"https://api.github.com/repos/ximinez/rippled/subscription","commits_url":"https://api.github.com/repos/ximinez/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ximinez/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ximinez/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ximinez/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ximinez/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ximinez/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ximinez/rippled/merges","archive_url":"https://api.github.com/repos/ximinez/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ximinez/rippled/downloads","issues_url":"https://api.github.com/repos/ximinez/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ximinez/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ximinez/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ximinez/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ximinez/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ximinez/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ximinez/rippled/deployments","created_at":"2014-02-27T04:33:56Z","updated_at":"2015-04-30T15:50:19Z","pushed_at":"2016-06-21T23:37:30Z","git_url":"git://github.com/ximinez/rippled.git","ssh_url":"git@github.com:ximinez/rippled.git","clone_url":"https://github.com/ximinez/rippled.git","svn_url":"https://github.com/ximinez/rippled","homepage":"https://ripple.com","size":62730,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"5dd8f282905c70d92790fde3f1d384e43c925ff3","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2016-06-21T21:57:25Z","pushed_at":"2016-06-22T21:18:58Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":113664,"stargazers_count":1104,"watchers_count":1104,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":331,"mirror_url":null,"open_issues_count":121,"forks":331,"open_issues":121,"watchers":1104,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1749"},"html":{"href":"https://github.com/ripple/rippled/pull/1749"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/1749"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/1749/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1749/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1749/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/52b87b1e7940931153cc20bce7ec3dcc6b00bf7f"}}}}
{"actor":{"display_login":"seelabs"}}