{"action":"created","comment":{"url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/comments/63970320","id":63970320,"diff_hunk":"@@ -65,6 +65,28 @@ public void toSql(StringBuilder builder) {\n \t\tcheckElement(elements, type, setFunctionSpecification);\r\n \t}\r\n \r\n+\t@Override\r\n+\tpublic HasQuoteValue getReferencedColumn() {\r\n+\t\t// Handle functions first\r\n+\t\tif(setFunctionSpecification != null){\r\n+\t\t\tif(setFunctionSpecification.getCountAsterisk() != null){\r\n+\t\t\t\t// count(*) does not reference a column\r\n+\t\t\t\treturn null;\r\n+\t\t\t}else{\r\n+\t\t\t\t// first unquoted value starting at the value expression.\r\n+\t\t\t\treturn setFunctionSpecification.getValueExpression().getFirstElementOfType(HasQuoteValue.class);\r\n+\t\t\t}\r\n+\t\t}else{\r\n+\t\t\t// This is not a function so get the first unquoted.\r\n+\t\t\treturn this.getFirstElementOfType(HasQuoteValue.class);\r\n+\t\t}\r\n+\t}\r\n+\r\n+\t@Override\r\n+\tpublic boolean isReferenceInFunction() {\r","path":"lib/lib-table-query/src/main/java/org/sagebionetworks/table/query/model/ValueExpressionPrimary.java","position":31,"original_position":31,"commit_id":"24dbf9c0b539ffb856025894690335a1ba6b5f38","original_commit_id":"24dbf9c0b539ffb856025894690335a1ba6b5f38","user":{"login":"john-hill","id":1728181,"avatar_url":"https://avatars.githubusercontent.com/u/1728181?v=3","gravatar_id":"","url":"https://api.github.com/users/john-hill","html_url":"https://github.com/john-hill","followers_url":"https://api.github.com/users/john-hill/followers","following_url":"https://api.github.com/users/john-hill/following{/other_user}","gists_url":"https://api.github.com/users/john-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/john-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-hill/subscriptions","organizations_url":"https://api.github.com/users/john-hill/orgs","repos_url":"https://api.github.com/users/john-hill/repos","events_url":"https://api.github.com/users/john-hill/events{/privacy}","received_events_url":"https://api.github.com/users/john-hill/received_events","type":"User","site_admin":false},"body":"throw an exception if reference is null for this method","created_at":"2016-05-19T23:26:29Z","updated_at":"2016-05-19T23:26:29Z","html_url":"https://github.com/Sage-Bionetworks/Synapse-Repository-Services/pull/2436#discussion_r63970320","pull_request_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/2436","_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/comments/63970320"},"html":{"href":"https://github.com/Sage-Bionetworks/Synapse-Repository-Services/pull/2436#discussion_r63970320"},"pull_request":{"href":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/2436"}}},"pull_request":{"url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/2436","id":70610511,"html_url":"https://github.com/Sage-Bionetworks/Synapse-Repository-Services/pull/2436","diff_url":"https://github.com/Sage-Bionetworks/Synapse-Repository-Services/pull/2436.diff","patch_url":"https://github.com/Sage-Bionetworks/Synapse-Repository-Services/pull/2436.patch","issue_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/issues/2436","number":2436,"state":"open","locked":false,"title":"Table query refactor","user":{"login":"john-hill","id":1728181,"avatar_url":"https://avatars.githubusercontent.com/u/1728181?v=3","gravatar_id":"","url":"https://api.github.com/users/john-hill","html_url":"https://github.com/john-hill","followers_url":"https://api.github.com/users/john-hill/followers","following_url":"https://api.github.com/users/john-hill/following{/other_user}","gists_url":"https://api.github.com/users/john-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/john-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-hill/subscriptions","organizations_url":"https://api.github.com/users/john-hill/orgs","repos_url":"https://api.github.com/users/john-hill/repos","events_url":"https://api.github.com/users/john-hill/events{/privacy}","received_events_url":"https://api.github.com/users/john-hill/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-18T22:32:29Z","updated_at":"2016-05-19T23:26:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a672b2f8f57ede05aaebba2629d16117e75e3419","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/2436/commits","review_comments_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/2436/comments","review_comment_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/issues/2436/comments","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/statuses/24dbf9c0b539ffb856025894690335a1ba6b5f38","head":{"label":"john-hill:table-query-refactor","ref":"table-query-refactor","sha":"24dbf9c0b539ffb856025894690335a1ba6b5f38","user":{"login":"john-hill","id":1728181,"avatar_url":"https://avatars.githubusercontent.com/u/1728181?v=3","gravatar_id":"","url":"https://api.github.com/users/john-hill","html_url":"https://github.com/john-hill","followers_url":"https://api.github.com/users/john-hill/followers","following_url":"https://api.github.com/users/john-hill/following{/other_user}","gists_url":"https://api.github.com/users/john-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/john-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-hill/subscriptions","organizations_url":"https://api.github.com/users/john-hill/orgs","repos_url":"https://api.github.com/users/john-hill/repos","events_url":"https://api.github.com/users/john-hill/events{/privacy}","received_events_url":"https://api.github.com/users/john-hill/received_events","type":"User","site_admin":false},"repo":{"id":4755426,"name":"Synapse-Repository-Services","full_name":"john-hill/Synapse-Repository-Services","owner":{"login":"john-hill","id":1728181,"avatar_url":"https://avatars.githubusercontent.com/u/1728181?v=3","gravatar_id":"","url":"https://api.github.com/users/john-hill","html_url":"https://github.com/john-hill","followers_url":"https://api.github.com/users/john-hill/followers","following_url":"https://api.github.com/users/john-hill/following{/other_user}","gists_url":"https://api.github.com/users/john-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/john-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-hill/subscriptions","organizations_url":"https://api.github.com/users/john-hill/orgs","repos_url":"https://api.github.com/users/john-hill/repos","events_url":"https://api.github.com/users/john-hill/events{/privacy}","received_events_url":"https://api.github.com/users/john-hill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/john-hill/Synapse-Repository-Services","description":"The Synapse Repository Services project is the home of the JSON REST web services for Synapse.","fork":true,"url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services","forks_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/forks","keys_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/teams","hooks_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/hooks","issue_events_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/issues/events{/number}","events_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/events","assignees_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/assignees{/user}","branches_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/branches{/branch}","tags_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/tags","blobs_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/git/refs{/sha}","trees_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/statuses/{sha}","languages_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/languages","stargazers_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/stargazers","contributors_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/contributors","subscribers_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/subscribers","subscription_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/subscription","commits_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/commits{/sha}","git_commits_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/git/commits{/sha}","comments_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/comments{/number}","issue_comment_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/issues/comments{/number}","contents_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/contents/{+path}","compare_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/merges","archive_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/downloads","issues_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/issues{/number}","pulls_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/pulls{/number}","milestones_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/milestones{/number}","notifications_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/labels{/name}","releases_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/releases{/id}","deployments_url":"https://api.github.com/repos/john-hill/Synapse-Repository-Services/deployments","created_at":"2012-06-22T20:23:07Z","updated_at":"2014-06-21T15:36:46Z","pushed_at":"2016-05-19T19:45:45Z","git_url":"git://github.com/john-hill/Synapse-Repository-Services.git","ssh_url":"git@github.com:john-hill/Synapse-Repository-Services.git","clone_url":"https://github.com/john-hill/Synapse-Repository-Services.git","svn_url":"https://github.com/john-hill/Synapse-Repository-Services","homepage":null,"size":51449,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Sage-Bionetworks:develop","ref":"develop","sha":"40196fba4849aca61f1f1a5a39c47a3592b7cc9b","user":{"login":"Sage-Bionetworks","id":1250897,"avatar_url":"https://avatars.githubusercontent.com/u/1250897?v=3","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":4400676,"name":"Synapse-Repository-Services","full_name":"Sage-Bionetworks/Synapse-Repository-Services","owner":{"login":"Sage-Bionetworks","id":1250897,"avatar_url":"https://avatars.githubusercontent.com/u/1250897?v=3","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sage-Bionetworks/Synapse-Repository-Services","description":"The Synapse Repository Services project is the home of the JSON REST web services for Synapse.","fork":false,"url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services","forks_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/forks","keys_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/teams","hooks_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/hooks","issue_events_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/issues/events{/number}","events_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/events","assignees_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/assignees{/user}","branches_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/branches{/branch}","tags_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/tags","blobs_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/statuses/{sha}","languages_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/languages","stargazers_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/stargazers","contributors_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/contributors","subscribers_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/subscribers","subscription_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/subscription","commits_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/contents/{+path}","compare_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/merges","archive_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/downloads","issues_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/issues{/number}","pulls_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls{/number}","milestones_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/milestones{/number}","notifications_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/labels{/name}","releases_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/releases{/id}","deployments_url":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/deployments","created_at":"2012-05-22T01:06:50Z","updated_at":"2016-04-26T20:56:44Z","pushed_at":"2016-05-19T19:45:46Z","git_url":"git://github.com/Sage-Bionetworks/Synapse-Repository-Services.git","ssh_url":"git@github.com:Sage-Bionetworks/Synapse-Repository-Services.git","clone_url":"https://github.com/Sage-Bionetworks/Synapse-Repository-Services.git","svn_url":"https://github.com/Sage-Bionetworks/Synapse-Repository-Services","homepage":null,"size":61323,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":3,"forks":25,"open_issues":3,"watchers":20,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/2436"},"html":{"href":"https://github.com/Sage-Bionetworks/Synapse-Repository-Services/pull/2436"},"issue":{"href":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/issues/2436"},"comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/issues/2436/comments"},"review_comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/2436/comments"},"review_comment":{"href":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/pulls/2436/commits"},"statuses":{"href":"https://api.github.com/repos/Sage-Bionetworks/Synapse-Repository-Services/statuses/24dbf9c0b539ffb856025894690335a1ba6b5f38"}}}}
{"actor":{"display_login":"john-hill"}}