{"action":"created","issue":{"url":"https://api.github.com/repos/zcaudate/vinyasa/issues/31","repository_url":"https://api.github.com/repos/zcaudate/vinyasa","labels_url":"https://api.github.com/repos/zcaudate/vinyasa/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/zcaudate/vinyasa/issues/31/comments","events_url":"https://api.github.com/repos/zcaudate/vinyasa/issues/31/events","html_url":"https://github.com/zcaudate/vinyasa/pull/31","id":171028059,"number":31,"title":"Make inject/inject act the same as inject/in","user":{"login":"raxod502","id":6559064,"avatar_url":"https://avatars.githubusercontent.com/u/6559064?v=3","gravatar_id":"","url":"https://api.github.com/users/raxod502","html_url":"https://github.com/raxod502","followers_url":"https://api.github.com/users/raxod502/followers","following_url":"https://api.github.com/users/raxod502/following{/other_user}","gists_url":"https://api.github.com/users/raxod502/gists{/gist_id}","starred_url":"https://api.github.com/users/raxod502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raxod502/subscriptions","organizations_url":"https://api.github.com/users/raxod502/orgs","repos_url":"https://api.github.com/users/raxod502/repos","events_url":"https://api.github.com/users/raxod502/events{/privacy}","received_events_url":"https://api.github.com/users/raxod502/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-13T21:23:03Z","updated_at":"2016-08-16T01:08:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zcaudate/vinyasa/pulls/31","html_url":"https://github.com/zcaudate/vinyasa/pull/31","diff_url":"https://github.com/zcaudate/vinyasa/pull/31.diff","patch_url":"https://github.com/zcaudate/vinyasa/pull/31.patch"},"body":"With the current version of `vinyasa.inject`, I can do the following to inject some functions:\r\n\r\n```\r\n(vinyasa.inject/in [alembic.still distill lein])\r\n```\r\n\r\nHowever, the following does **not** work:\r\n\r\n```\r\n(vinyasa.inject/inject '[alembic.still distill lein])\r\n```\r\n\r\nYou actually have to do this in order for the functions to be injected correctly:\r\n\r\n```\r\n(vinyasa.inject/inject '[[alembic.still distill lein]])\r\n```\r\n\r\nThis is quite surprising to me. When I looked at the code, I noticed that [`vinyasa.inject/inject`](https://github.com/zcaudate/vinyasa/blob/b6d48100278a4601fb5e51859349c3b6455221a2/src/vinyasa/inject.clj#L88) had two `mapcat`s instead of just one (like [`vinyasa.inject/in`](https://github.com/zcaudate/vinyasa/blob/b6d48100278a4601fb5e51859349c3b6455221a2/src/vinyasa/inject.clj#L95)). This pull request removes the extra `mapcat`, so that\r\n\r\n```\r\n(vinyasa.inject/inject '[alembic.still distill lein])\r\n```\r\n\r\nwill work correctly."},"comment":{"url":"https://api.github.com/repos/zcaudate/vinyasa/issues/comments/239975029","html_url":"https://github.com/zcaudate/vinyasa/pull/31#issuecomment-239975029","issue_url":"https://api.github.com/repos/zcaudate/vinyasa/issues/31","id":239975029,"user":{"login":"raxod502","id":6559064,"avatar_url":"https://avatars.githubusercontent.com/u/6559064?v=3","gravatar_id":"","url":"https://api.github.com/users/raxod502","html_url":"https://github.com/raxod502","followers_url":"https://api.github.com/users/raxod502/followers","following_url":"https://api.github.com/users/raxod502/following{/other_user}","gists_url":"https://api.github.com/users/raxod502/gists{/gist_id}","starred_url":"https://api.github.com/users/raxod502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raxod502/subscriptions","organizations_url":"https://api.github.com/users/raxod502/orgs","repos_url":"https://api.github.com/users/raxod502/repos","events_url":"https://api.github.com/users/raxod502/events{/privacy}","received_events_url":"https://api.github.com/users/raxod502/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T01:08:43Z","updated_at":"2016-08-16T01:08:43Z","body":"I can't see how it would, since `inject/in` doesn't call `inject/inject`. But, now that I look at https://github.com/zcaudate/vinyasa/blob/master/profiles.clj.sample, it looks like the syntax for `inject/inject` might actually be intended behavior?"}}
{"actor":{"display_login":"raxod502"}}