{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/comments/57585224","id":57585224,"diff_hunk":"@@ -139,19 +139,16 @@ public String toString() {\n      * @see Actionable#getAllActions\n      * @since FIXME\n      */\n-    @NonNull\n+    @Nonnull\n     @Exported(name=\"actions\")\n     public List<? extends Action> getAllActions() {\n         List<Action> actions = new ArrayList<Action>();\n-        Jenkins j = Jenkins.getInstance(); // TODO 1.572+ ExtensionList.lookup\n-        if (j != null) {\n-            for (TransientActionFactory<?> taf : j.getExtensionList(TransientActionFactory.class)) {\n-                if (taf.type().isInstance(this)) {\n-                    try {\n-                        actions.addAll(createFor(taf));\n-                    } catch (Exception e) {\n-                        LOGGER.log(Level.SEVERE, \"Could not load actions from \" + taf + \" for \" + this, e);\n-                    }\n+        for (TransientActionFactory<?> taf : ExtensionList.lookup(TransientActionFactory.class)) {","path":"src/main/java/jenkins/scm/api/SCMHead.java","position":21,"original_position":70,"commit_id":"2d8499a99d3abc8c8f56bd9a04e12255332283f9","original_commit_id":"f852f8bf9cc523f3e0ef5199325db7ca660d6fff","user":{"login":"amuniz","id":1017585,"avatar_url":"https://avatars.githubusercontent.com/u/1017585?v=3","gravatar_id":"","url":"https://api.github.com/users/amuniz","html_url":"https://github.com/amuniz","followers_url":"https://api.github.com/users/amuniz/followers","following_url":"https://api.github.com/users/amuniz/following{/other_user}","gists_url":"https://api.github.com/users/amuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/amuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuniz/subscriptions","organizations_url":"https://api.github.com/users/amuniz/orgs","repos_url":"https://api.github.com/users/amuniz/repos","events_url":"https://api.github.com/users/amuniz/events{/privacy}","received_events_url":"https://api.github.com/users/amuniz/received_events","type":"User","site_admin":false},"body":"Why is this change here?","created_at":"2016-03-28T15:35:07Z","updated_at":"2016-03-28T15:35:07Z","html_url":"https://github.com/jenkinsci/scm-api-plugin/pull/8#discussion_r57585224","pull_request_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/comments/57585224"},"html":{"href":"https://github.com/jenkinsci/scm-api-plugin/pull/8#discussion_r57585224"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/8","id":62359908,"html_url":"https://github.com/jenkinsci/scm-api-plugin/pull/8","diff_url":"https://github.com/jenkinsci/scm-api-plugin/pull/8.diff","patch_url":"https://github.com/jenkinsci/scm-api-plugin/pull/8.patch","issue_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/issues/8","number":8,"state":"open","locked":false,"title":"Clean up after PR#6","user":{"login":"andresrc","id":500424,"avatar_url":"https://avatars.githubusercontent.com/u/500424?v=3","gravatar_id":"","url":"https://api.github.com/users/andresrc","html_url":"https://github.com/andresrc","followers_url":"https://api.github.com/users/andresrc/followers","following_url":"https://api.github.com/users/andresrc/following{/other_user}","gists_url":"https://api.github.com/users/andresrc/gists{/gist_id}","starred_url":"https://api.github.com/users/andresrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresrc/subscriptions","organizations_url":"https://api.github.com/users/andresrc/orgs","repos_url":"https://api.github.com/users/andresrc/repos","events_url":"https://api.github.com/users/andresrc/events{/privacy}","received_events_url":"https://api.github.com/users/andresrc/received_events","type":"User","site_admin":false},"body":"Follow up to https://github.com/jenkinsci/scm-api-plugin/pull/6\r\n\r\nThat PR upgrades the baseline but did not address `TODO` comments pending on such upgrade.\r\n\r\nThis PR fixes this. Some small additional cleanups (substitute deprecated findbugs annotations) are also included in the modified files.\r\n\r\nThanks @stephenc and @jglick for comments on the previous PR.\r\n\r\n@reviewbybees ","created_at":"2016-03-10T09:19:42Z","updated_at":"2016-03-28T15:35:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ec45c8a47a3fe143c298ca93e476f2c6e698300","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/8/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/8/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/issues/8/comments","statuses_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/statuses/2d8499a99d3abc8c8f56bd9a04e12255332283f9","head":{"label":"andresrc:clean-todo","ref":"clean-todo","sha":"2d8499a99d3abc8c8f56bd9a04e12255332283f9","user":{"login":"andresrc","id":500424,"avatar_url":"https://avatars.githubusercontent.com/u/500424?v=3","gravatar_id":"","url":"https://api.github.com/users/andresrc","html_url":"https://github.com/andresrc","followers_url":"https://api.github.com/users/andresrc/followers","following_url":"https://api.github.com/users/andresrc/following{/other_user}","gists_url":"https://api.github.com/users/andresrc/gists{/gist_id}","starred_url":"https://api.github.com/users/andresrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresrc/subscriptions","organizations_url":"https://api.github.com/users/andresrc/orgs","repos_url":"https://api.github.com/users/andresrc/repos","events_url":"https://api.github.com/users/andresrc/events{/privacy}","received_events_url":"https://api.github.com/users/andresrc/received_events","type":"User","site_admin":false},"repo":{"id":50185232,"name":"scm-api-plugin","full_name":"andresrc/scm-api-plugin","owner":{"login":"andresrc","id":500424,"avatar_url":"https://avatars.githubusercontent.com/u/500424?v=3","gravatar_id":"","url":"https://api.github.com/users/andresrc","html_url":"https://github.com/andresrc","followers_url":"https://api.github.com/users/andresrc/followers","following_url":"https://api.github.com/users/andresrc/following{/other_user}","gists_url":"https://api.github.com/users/andresrc/gists{/gist_id}","starred_url":"https://api.github.com/users/andresrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresrc/subscriptions","organizations_url":"https://api.github.com/users/andresrc/orgs","repos_url":"https://api.github.com/users/andresrc/repos","events_url":"https://api.github.com/users/andresrc/events{/privacy}","received_events_url":"https://api.github.com/users/andresrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andresrc/scm-api-plugin","description":"","fork":true,"url":"https://api.github.com/repos/andresrc/scm-api-plugin","forks_url":"https://api.github.com/repos/andresrc/scm-api-plugin/forks","keys_url":"https://api.github.com/repos/andresrc/scm-api-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresrc/scm-api-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresrc/scm-api-plugin/teams","hooks_url":"https://api.github.com/repos/andresrc/scm-api-plugin/hooks","issue_events_url":"https://api.github.com/repos/andresrc/scm-api-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/andresrc/scm-api-plugin/events","assignees_url":"https://api.github.com/repos/andresrc/scm-api-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/andresrc/scm-api-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/andresrc/scm-api-plugin/tags","blobs_url":"https://api.github.com/repos/andresrc/scm-api-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresrc/scm-api-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresrc/scm-api-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresrc/scm-api-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresrc/scm-api-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/andresrc/scm-api-plugin/languages","stargazers_url":"https://api.github.com/repos/andresrc/scm-api-plugin/stargazers","contributors_url":"https://api.github.com/repos/andresrc/scm-api-plugin/contributors","subscribers_url":"https://api.github.com/repos/andresrc/scm-api-plugin/subscribers","subscription_url":"https://api.github.com/repos/andresrc/scm-api-plugin/subscription","commits_url":"https://api.github.com/repos/andresrc/scm-api-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresrc/scm-api-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresrc/scm-api-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresrc/scm-api-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresrc/scm-api-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/andresrc/scm-api-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresrc/scm-api-plugin/merges","archive_url":"https://api.github.com/repos/andresrc/scm-api-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresrc/scm-api-plugin/downloads","issues_url":"https://api.github.com/repos/andresrc/scm-api-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/andresrc/scm-api-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/andresrc/scm-api-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/andresrc/scm-api-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresrc/scm-api-plugin/labels{/name}","releases_url":"https://api.github.com/repos/andresrc/scm-api-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/andresrc/scm-api-plugin/deployments","created_at":"2016-01-22T14:12:21Z","updated_at":"2016-01-22T14:12:21Z","pushed_at":"2016-03-11T10:20:01Z","git_url":"git://github.com/andresrc/scm-api-plugin.git","ssh_url":"git@github.com:andresrc/scm-api-plugin.git","clone_url":"https://github.com/andresrc/scm-api-plugin.git","svn_url":"https://github.com/andresrc/scm-api-plugin","homepage":"","size":73,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"cfa781a93d0aa82a03b306fdca8f5f38a9ef434e","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":12713417,"name":"scm-api-plugin","full_name":"jenkinsci/scm-api-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/scm-api-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/scm-api-plugin","forks_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/scm-api-plugin/deployments","created_at":"2013-09-09T21:29:01Z","updated_at":"2016-03-08T22:19:06Z","pushed_at":"2016-03-11T10:20:01Z","git_url":"git://github.com/jenkinsci/scm-api-plugin.git","ssh_url":"git@github.com:jenkinsci/scm-api-plugin.git","clone_url":"https://github.com/jenkinsci/scm-api-plugin.git","svn_url":"https://github.com/jenkinsci/scm-api-plugin","homepage":"","size":78,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/8"},"html":{"href":"https://github.com/jenkinsci/scm-api-plugin/pull/8"},"issue":{"href":"https://api.github.com/repos/jenkinsci/scm-api-plugin/issues/8"},"comments":{"href":"https://api.github.com/repos/jenkinsci/scm-api-plugin/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/scm-api-plugin/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/scm-api-plugin/statuses/2d8499a99d3abc8c8f56bd9a04e12255332283f9"}}}}