{"action":"closed","issue":{"url":"https://api.github.com/repos/servo/servo/issues/8756","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/8756/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/8756/comments","events_url":"https://api.github.com/repos/servo/servo/issues/8756/events","html_url":"https://github.com/servo/servo/issues/8756","id":119571116,"number":8756,"title":"Add extensive cookie tests to wpt","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/A-testing","name":"A-testing","color":"d7e102"},{"url":"https://api.github.com/repos/servo/servo/labels/C-assigned","name":"C-assigned","color":"02d7e1"},{"url":"https://api.github.com/repos/servo/servo/labels/C-has%20open%20PR","name":"C-has open PR","color":"02d7e1"},{"url":"https://api.github.com/repos/servo/servo/labels/E-less%20easy","name":"E-less easy","color":"02e10c"},{"url":"https://api.github.com/repos/servo/servo/labels/L-javascript","name":"L-javascript","color":"bfd4f2"},{"url":"https://api.github.com/repos/servo/servo/labels/L-python","name":"L-python","color":"bfd4f2"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2015-11-30T20:13:14Z","updated_at":"2016-10-16T15:34:13Z","closed_at":"2016-10-16T15:34:13Z","body":"Our cookie code was rather broken. https://github.com/servo/servo/pull/8752 fixed it and added some unit tests, but there should be wpt tests for cookie setting behavior as well.\r\n\r\nI'm envisioning something which uses a custom python server (see XMLHttpRequest/resources or cors/resources in wpt for examples of these) that sets various cookies based on its parameters, and write tests around that.\r\n\r\nThese tests would set cookies (via the server using `Set-Cookie`, not via `document.cookie`) with various paths, and ensure that they're sent back to the server later when on a matching path. There should also be false positive tests.\r\n\r\ncc @jgraham @Wafflespeanut "}}
{"actor":{"display_login":"bors-servo"}}