{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/918","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/918/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/918/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/918/events","html_url":"https://github.com/greenplum-db/gpdb/pull/918","id":164080599,"number":918,"title":"Compiler warnings sweep","user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-06T13:52:35Z","updated_at":"2016-07-11T12:16:48Z","closed_at":"2016-07-11T12:16:48Z","pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/918","html_url":"https://github.com/greenplum-db/gpdb/pull/918","diff_url":"https://github.com/greenplum-db/gpdb/pull/918.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/918.patch"},"body":"In an attempt to get us closer to compiling without warnings I did a little sweep across a few warnings that clang throws during a fresh compilation. This PR needs to be reviewed per commit as the commits are for different things across the codebase, their only common denominator being that they fix code to avoid warnings (I didn't want to create a torrent of tiny PR's since that seemed counterproductive). Where possible I've cherry-picked the fixes from upstream, where not possible (due to the fix being part of a muc larger commit) I've noted the upstream commit sha that has the change.\r\n\r\nSome of these warnings uncovered minor bugs but non that I can attribute to being very interesting, ICG for me runs with the expected outcome with these patches.\r\n\r\nWe are still not at a clean state after this but around half of the warnings or so are removed, further PR's will be opened to fix the rest."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/231717743","html_url":"https://github.com/greenplum-db/gpdb/pull/918#issuecomment-231717743","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/918","id":231717743,"user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T12:16:47Z","updated_at":"2016-07-11T12:16:47Z","body":"Pushed to master, thanks for review!"}}
{"actor":{"display_login":"danielgustafsson"}}