{"action":"created","issue":{"url":"https://api.github.com/repos/substancelab/rconomic/issues/44","repository_url":"https://api.github.com/repos/substancelab/rconomic","labels_url":"https://api.github.com/repos/substancelab/rconomic/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/substancelab/rconomic/issues/44/comments","events_url":"https://api.github.com/repos/substancelab/rconomic/issues/44/events","html_url":"https://github.com/substancelab/rconomic/pull/44","id":147659369,"number":44,"title":"Extends Order and introduce OrderLine","user":{"login":"mathiasjakobsen","id":1573748,"avatar_url":"https://avatars.githubusercontent.com/u/1573748?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiasjakobsen","html_url":"https://github.com/mathiasjakobsen","followers_url":"https://api.github.com/users/mathiasjakobsen/followers","following_url":"https://api.github.com/users/mathiasjakobsen/following{/other_user}","gists_url":"https://api.github.com/users/mathiasjakobsen/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasjakobsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasjakobsen/subscriptions","organizations_url":"https://api.github.com/users/mathiasjakobsen/orgs","repos_url":"https://api.github.com/users/mathiasjakobsen/repos","events_url":"https://api.github.com/users/mathiasjakobsen/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasjakobsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-12T07:27:43Z","updated_at":"2016-04-22T16:11:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/substancelab/rconomic/pulls/44","html_url":"https://github.com/substancelab/rconomic/pull/44","diff_url":"https://github.com/substancelab/rconomic/pull/44.diff","patch_url":"https://github.com/substancelab/rconomic/pull/44.patch"},"body":"**Order**\r\n- Extends with (almost) full schema\r\n\r\n**OrderLine**\r\n- Introduces Orderline\r\n\r\n**CurrentInvoice**\r\n- Adds a `.pdf` method to get draft PDF invoice\r\n- Adds some reference handles\r\n\r\n**Debtor**\r\n- Fixes som handles, which never called `.to_hash` and resulted in an Schema Exception from the API\r\n- Adds a method `.get_current_invoices` on a Debtor instance"},"comment":{"url":"https://api.github.com/repos/substancelab/rconomic/issues/comments/213494603","html_url":"https://github.com/substancelab/rconomic/pull/44#issuecomment-213494603","issue_url":"https://api.github.com/repos/substancelab/rconomic/issues/44","id":213494603,"user":{"login":"koppen","id":6480,"avatar_url":"https://avatars.githubusercontent.com/u/6480?v=3","gravatar_id":"","url":"https://api.github.com/users/koppen","html_url":"https://github.com/koppen","followers_url":"https://api.github.com/users/koppen/followers","following_url":"https://api.github.com/users/koppen/following{/other_user}","gists_url":"https://api.github.com/users/koppen/gists{/gist_id}","starred_url":"https://api.github.com/users/koppen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koppen/subscriptions","organizations_url":"https://api.github.com/users/koppen/orgs","repos_url":"https://api.github.com/users/koppen/repos","events_url":"https://api.github.com/users/koppen/events{/privacy}","received_events_url":"https://api.github.com/users/koppen/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T16:11:03Z","updated_at":"2016-04-22T16:11:03Z","body":"Thank you so much for your contribution. This is a ton of work I'd love to get merged to master.\r\n\r\nHowever, there seems to be a lot of independent changes, making this pull request even larger than it needs to be. Any chance you could split it into many smaller pull requests? Off the top of my head it seems like there are some bugfixes, additions to Order, additions to OrderLine, additions to Debtor, additions to CurrentInvoice.\r\n\r\nAlso, the test suite has a bunch of failures after all these changes. Perhaps more and more focused pull requests would make it easier to spot and fix those issues?"}}