{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/assets-frontend/pulls/comments/57298121","id":57298121,"diff_hunk":"@@ -163,7 +163,8 @@\n }\n \n .highlight-message--icon-top {\n-  background-position-y: em(20);\n+  background-position: em(20) em(20);\n+  background-size: em(27) em(27);","path":"assets/scss/modules/_notifications.scss","position":6,"original_position":6,"commit_id":"35e14c446d2abb55280e18166eb762e1a388659a","original_commit_id":"35e14c446d2abb55280e18166eb762e1a388659a","user":{"login":"feedmypixel","id":2305016,"avatar_url":"https://avatars.githubusercontent.com/u/2305016?v=3","gravatar_id":"","url":"https://api.github.com/users/feedmypixel","html_url":"https://github.com/feedmypixel","followers_url":"https://api.github.com/users/feedmypixel/followers","following_url":"https://api.github.com/users/feedmypixel/following{/other_user}","gists_url":"https://api.github.com/users/feedmypixel/gists{/gist_id}","starred_url":"https://api.github.com/users/feedmypixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedmypixel/subscriptions","organizations_url":"https://api.github.com/users/feedmypixel/orgs","repos_url":"https://api.github.com/users/feedmypixel/repos","events_url":"https://api.github.com/users/feedmypixel/events{/privacy}","received_events_url":"https://api.github.com/users/feedmypixel/received_events","type":"User","site_admin":false},"body":"is `background-size` actually needed here - cant we just go with the default 34px x 34px? ","created_at":"2016-03-24T10:27:58Z","updated_at":"2016-03-24T10:27:58Z","html_url":"https://github.com/hmrc/assets-frontend/pull/488#discussion_r57298121","pull_request_url":"https://api.github.com/repos/hmrc/assets-frontend/pulls/488","_links":{"self":{"href":"https://api.github.com/repos/hmrc/assets-frontend/pulls/comments/57298121"},"html":{"href":"https://github.com/hmrc/assets-frontend/pull/488#discussion_r57298121"},"pull_request":{"href":"https://api.github.com/repos/hmrc/assets-frontend/pulls/488"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/assets-frontend/pulls/488","id":63921964,"html_url":"https://github.com/hmrc/assets-frontend/pull/488","diff_url":"https://github.com/hmrc/assets-frontend/pull/488.diff","patch_url":"https://github.com/hmrc/assets-frontend/pull/488.patch","issue_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/488","number":488,"state":"open","locked":false,"title":"Fixes notification icon alignment in Firefox","user":{"login":"mattpepper","id":5468091,"avatar_url":"https://avatars.githubusercontent.com/u/5468091?v=3","gravatar_id":"","url":"https://api.github.com/users/mattpepper","html_url":"https://github.com/mattpepper","followers_url":"https://api.github.com/users/mattpepper/followers","following_url":"https://api.github.com/users/mattpepper/following{/other_user}","gists_url":"https://api.github.com/users/mattpepper/gists{/gist_id}","starred_url":"https://api.github.com/users/mattpepper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattpepper/subscriptions","organizations_url":"https://api.github.com/users/mattpepper/orgs","repos_url":"https://api.github.com/users/mattpepper/repos","events_url":"https://api.github.com/users/mattpepper/events{/privacy}","received_events_url":"https://api.github.com/users/mattpepper/received_events","type":"User","site_admin":false},"body":"### Fixes notification icon alignment on `.highlight-message--icon-top` in Firefox.\r\n* `background-position-y` not supported in Firefox - update to supported `background-position`\r\n* `device-pixel-ratio` not supported in Firefox - add `background-size` as used in `device-pixel-ratio` media-query on `.highlight-message`\r\n\r\n#### Before (left) and After (right) - `.highlight-message--icon-top` positioning fix for Firefox\r\n\r\n<img width=\"1680\" alt=\".highlight-message--icon-top notification positioning fix for firefox - Before and After\" src=\"https://cloud.githubusercontent.com/assets/5468091/13994484/e7ba1242-f11c-11e5-98d1-868c06c30635.png\">","created_at":"2016-03-23T17:32:58Z","updated_at":"2016-03-24T10:27:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b2e7257d7dc792670bda65c37e60897a2edf75b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/assets-frontend/pulls/488/commits","review_comments_url":"https://api.github.com/repos/hmrc/assets-frontend/pulls/488/comments","review_comment_url":"https://api.github.com/repos/hmrc/assets-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/488/comments","statuses_url":"https://api.github.com/repos/hmrc/assets-frontend/statuses/35e14c446d2abb55280e18166eb762e1a388659a","head":{"label":"hmrc:AOSS-926-icon-positioning-firefox","ref":"AOSS-926-icon-positioning-firefox","sha":"35e14c446d2abb55280e18166eb762e1a388659a","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":26324661,"name":"assets-frontend","full_name":"hmrc/assets-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/assets-frontend","description":"Shared static assets for frontends on the Multichannel Digital Tax Platform","fork":false,"url":"https://api.github.com/repos/hmrc/assets-frontend","forks_url":"https://api.github.com/repos/hmrc/assets-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/assets-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/assets-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/assets-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/assets-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/assets-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/assets-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/assets-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/assets-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/assets-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/assets-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/assets-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/assets-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/assets-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/assets-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/assets-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/assets-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/assets-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/assets-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/assets-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/assets-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/assets-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/assets-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/assets-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/assets-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/assets-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/assets-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/assets-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/assets-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/assets-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/assets-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/assets-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/assets-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/assets-frontend/deployments","created_at":"2014-11-07T15:11:39Z","updated_at":"2016-03-18T16:11:49Z","pushed_at":"2016-03-24T10:25:01Z","git_url":"git://github.com/hmrc/assets-frontend.git","ssh_url":"git@github.com:hmrc/assets-frontend.git","clone_url":"https://github.com/hmrc/assets-frontend.git","svn_url":"https://github.com/hmrc/assets-frontend","homepage":"","size":16391,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":49,"forks":34,"open_issues":49,"watchers":4,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"6722dd4fbd44178a1c55e7157ea2af3159fcb75c","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":26324661,"name":"assets-frontend","full_name":"hmrc/assets-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/assets-frontend","description":"Shared static assets for frontends on the Multichannel Digital Tax Platform","fork":false,"url":"https://api.github.com/repos/hmrc/assets-frontend","forks_url":"https://api.github.com/repos/hmrc/assets-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/assets-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/assets-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/assets-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/assets-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/assets-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/assets-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/assets-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/assets-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/assets-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/assets-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/assets-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/assets-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/assets-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/assets-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/assets-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/assets-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/assets-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/assets-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/assets-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/assets-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/assets-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/assets-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/assets-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/assets-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/assets-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/assets-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/assets-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/assets-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/assets-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/assets-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/assets-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/assets-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/assets-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/assets-frontend/deployments","created_at":"2014-11-07T15:11:39Z","updated_at":"2016-03-18T16:11:49Z","pushed_at":"2016-03-24T10:25:01Z","git_url":"git://github.com/hmrc/assets-frontend.git","ssh_url":"git@github.com:hmrc/assets-frontend.git","clone_url":"https://github.com/hmrc/assets-frontend.git","svn_url":"https://github.com/hmrc/assets-frontend","homepage":"","size":16391,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":49,"forks":34,"open_issues":49,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/assets-frontend/pulls/488"},"html":{"href":"https://github.com/hmrc/assets-frontend/pull/488"},"issue":{"href":"https://api.github.com/repos/hmrc/assets-frontend/issues/488"},"comments":{"href":"https://api.github.com/repos/hmrc/assets-frontend/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/assets-frontend/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/assets-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/assets-frontend/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/assets-frontend/statuses/35e14c446d2abb55280e18166eb762e1a388659a"}}}}