{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/tofino/pulls/comments/83458733","pull_request_review_id":4299031,"id":83458733,"diff_hunk":"@@ -0,0 +1,27 @@\n+/*\n+Copyright 2016 Mozilla\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use\n+this file except in compliance with the License. You may obtain a copy of the\n+License at http://www.apache.org/licenses/LICENSE-2.0\n+Unless required by applicable law or agreed to in writing, software distributed\n+under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR\n+CONDITIONS OF ANY KIND, either express or implied. See the License for the\n+specific language governing permissions and limitations under the License.\n+*/\n+\n+import * as ActionTypes from '../constants/action-types';","path":"app/ui/browser-modern/reducers/all.js","position":13,"original_position":13,"commit_id":"4548cd7a5ee1d00dce7bc10ece2f57e37f4ebee8","original_commit_id":"66d2556d3cf7cb1a0caa664f05b3496f60611489","user":{"login":"ncalexan","id":1097182,"avatar_url":"https://avatars.githubusercontent.com/u/1097182?v=3","gravatar_id":"","url":"https://api.github.com/users/ncalexan","html_url":"https://github.com/ncalexan","followers_url":"https://api.github.com/users/ncalexan/followers","following_url":"https://api.github.com/users/ncalexan/following{/other_user}","gists_url":"https://api.github.com/users/ncalexan/gists{/gist_id}","starred_url":"https://api.github.com/users/ncalexan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncalexan/subscriptions","organizations_url":"https://api.github.com/users/ncalexan/orgs","repos_url":"https://api.github.com/users/ncalexan/repos","events_url":"https://api.github.com/users/ncalexan/events{/privacy}","received_events_url":"https://api.github.com/users/ncalexan/received_events","type":"User","site_admin":false},"body":"Is it worth providing some hints as to what these reducers allow (do anything to the whole state!) and why it's necessary?","created_at":"2016-10-14T16:43:55Z","updated_at":"2016-10-14T16:43:55Z","html_url":"https://github.com/mozilla/tofino/pull/1415#discussion_r83458733","pull_request_url":"https://api.github.com/repos/mozilla/tofino/pulls/1415","_links":{"self":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/comments/83458733"},"html":{"href":"https://github.com/mozilla/tofino/pull/1415#discussion_r83458733"},"pull_request":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/1415"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/tofino/pulls/1415","id":89395635,"html_url":"https://github.com/mozilla/tofino/pull/1415","diff_url":"https://github.com/mozilla/tofino/pull/1415.diff","patch_url":"https://github.com/mozilla/tofino/pull/1415.patch","issue_url":"https://api.github.com/repos/mozilla/tofino/issues/1415","number":1415,"state":"open","locked":false,"title":"Implement session restore","user":{"login":"victorporof","id":248899,"avatar_url":"https://avatars.githubusercontent.com/u/248899?v=3","gravatar_id":"","url":"https://api.github.com/users/victorporof","html_url":"https://github.com/victorporof","followers_url":"https://api.github.com/users/victorporof/followers","following_url":"https://api.github.com/users/victorporof/following{/other_user}","gists_url":"https://api.github.com/users/victorporof/gists{/gist_id}","starred_url":"https://api.github.com/users/victorporof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorporof/subscriptions","organizations_url":"https://api.github.com/users/victorporof/orgs","repos_url":"https://api.github.com/users/victorporof/repos","events_url":"https://api.github.com/users/victorporof/events{/privacy}","received_events_url":"https://api.github.com/users/victorporof/received_events","type":"User","site_admin":false},"body":"This is a big one. I'd like two sets of eyes on this. @jsantell @joewalker please take a look.\r\n\r\nThe most interesting bits are the last 5 commits.\r\n\r\nNot implemented yet: injecting history into webviews.\r\n\r\nKnown issue: after a session restore, typing in the location bar results in 500 internal server errors from the UAS when trying to fetch autocompletions.","created_at":"2016-10-14T14:34:58Z","updated_at":"2016-10-14T16:54:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b99c919381a00148e6627ec7c4c1eb70ec9ad43d","assignee":{"login":"joewalker","id":76258,"avatar_url":"https://avatars.githubusercontent.com/u/76258?v=3","gravatar_id":"","url":"https://api.github.com/users/joewalker","html_url":"https://github.com/joewalker","followers_url":"https://api.github.com/users/joewalker/followers","following_url":"https://api.github.com/users/joewalker/following{/other_user}","gists_url":"https://api.github.com/users/joewalker/gists{/gist_id}","starred_url":"https://api.github.com/users/joewalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joewalker/subscriptions","organizations_url":"https://api.github.com/users/joewalker/orgs","repos_url":"https://api.github.com/users/joewalker/repos","events_url":"https://api.github.com/users/joewalker/events{/privacy}","received_events_url":"https://api.github.com/users/joewalker/received_events","type":"User","site_admin":false},"assignees":[{"login":"joewalker","id":76258,"avatar_url":"https://avatars.githubusercontent.com/u/76258?v=3","gravatar_id":"","url":"https://api.github.com/users/joewalker","html_url":"https://github.com/joewalker","followers_url":"https://api.github.com/users/joewalker/followers","following_url":"https://api.github.com/users/joewalker/following{/other_user}","gists_url":"https://api.github.com/users/joewalker/gists{/gist_id}","starred_url":"https://api.github.com/users/joewalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joewalker/subscriptions","organizations_url":"https://api.github.com/users/joewalker/orgs","repos_url":"https://api.github.com/users/joewalker/repos","events_url":"https://api.github.com/users/joewalker/events{/privacy}","received_events_url":"https://api.github.com/users/joewalker/received_events","type":"User","site_admin":false},{"login":"jsantell","id":641267,"avatar_url":"https://avatars.githubusercontent.com/u/641267?v=3","gravatar_id":"","url":"https://api.github.com/users/jsantell","html_url":"https://github.com/jsantell","followers_url":"https://api.github.com/users/jsantell/followers","following_url":"https://api.github.com/users/jsantell/following{/other_user}","gists_url":"https://api.github.com/users/jsantell/gists{/gist_id}","starred_url":"https://api.github.com/users/jsantell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsantell/subscriptions","organizations_url":"https://api.github.com/users/jsantell/orgs","repos_url":"https://api.github.com/users/jsantell/repos","events_url":"https://api.github.com/users/jsantell/events{/privacy}","received_events_url":"https://api.github.com/users/jsantell/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/tofino/pulls/1415/commits","review_comments_url":"https://api.github.com/repos/mozilla/tofino/pulls/1415/comments","review_comment_url":"https://api.github.com/repos/mozilla/tofino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/tofino/issues/1415/comments","statuses_url":"https://api.github.com/repos/mozilla/tofino/statuses/4548cd7a5ee1d00dce7bc10ece2f57e37f4ebee8","head":{"label":"victorporof:session-restore","ref":"session-restore","sha":"4548cd7a5ee1d00dce7bc10ece2f57e37f4ebee8","user":{"login":"victorporof","id":248899,"avatar_url":"https://avatars.githubusercontent.com/u/248899?v=3","gravatar_id":"","url":"https://api.github.com/users/victorporof","html_url":"https://github.com/victorporof","followers_url":"https://api.github.com/users/victorporof/followers","following_url":"https://api.github.com/users/victorporof/following{/other_user}","gists_url":"https://api.github.com/users/victorporof/gists{/gist_id}","starred_url":"https://api.github.com/users/victorporof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorporof/subscriptions","organizations_url":"https://api.github.com/users/victorporof/orgs","repos_url":"https://api.github.com/users/victorporof/repos","events_url":"https://api.github.com/users/victorporof/events{/privacy}","received_events_url":"https://api.github.com/users/victorporof/received_events","type":"User","site_admin":false},"repo":{"id":56032341,"name":"tofino","full_name":"victorporof/tofino","owner":{"login":"victorporof","id":248899,"avatar_url":"https://avatars.githubusercontent.com/u/248899?v=3","gravatar_id":"","url":"https://api.github.com/users/victorporof","html_url":"https://github.com/victorporof","followers_url":"https://api.github.com/users/victorporof/followers","following_url":"https://api.github.com/users/victorporof/following{/other_user}","gists_url":"https://api.github.com/users/victorporof/gists{/gist_id}","starred_url":"https://api.github.com/users/victorporof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorporof/subscriptions","organizations_url":"https://api.github.com/users/victorporof/orgs","repos_url":"https://api.github.com/users/victorporof/repos","events_url":"https://api.github.com/users/victorporof/events{/privacy}","received_events_url":"https://api.github.com/users/victorporof/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/victorporof/tofino","description":"Project Tofino is a browser interaction experiment.","fork":true,"url":"https://api.github.com/repos/victorporof/tofino","forks_url":"https://api.github.com/repos/victorporof/tofino/forks","keys_url":"https://api.github.com/repos/victorporof/tofino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victorporof/tofino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victorporof/tofino/teams","hooks_url":"https://api.github.com/repos/victorporof/tofino/hooks","issue_events_url":"https://api.github.com/repos/victorporof/tofino/issues/events{/number}","events_url":"https://api.github.com/repos/victorporof/tofino/events","assignees_url":"https://api.github.com/repos/victorporof/tofino/assignees{/user}","branches_url":"https://api.github.com/repos/victorporof/tofino/branches{/branch}","tags_url":"https://api.github.com/repos/victorporof/tofino/tags","blobs_url":"https://api.github.com/repos/victorporof/tofino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victorporof/tofino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victorporof/tofino/git/refs{/sha}","trees_url":"https://api.github.com/repos/victorporof/tofino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victorporof/tofino/statuses/{sha}","languages_url":"https://api.github.com/repos/victorporof/tofino/languages","stargazers_url":"https://api.github.com/repos/victorporof/tofino/stargazers","contributors_url":"https://api.github.com/repos/victorporof/tofino/contributors","subscribers_url":"https://api.github.com/repos/victorporof/tofino/subscribers","subscription_url":"https://api.github.com/repos/victorporof/tofino/subscription","commits_url":"https://api.github.com/repos/victorporof/tofino/commits{/sha}","git_commits_url":"https://api.github.com/repos/victorporof/tofino/git/commits{/sha}","comments_url":"https://api.github.com/repos/victorporof/tofino/comments{/number}","issue_comment_url":"https://api.github.com/repos/victorporof/tofino/issues/comments{/number}","contents_url":"https://api.github.com/repos/victorporof/tofino/contents/{+path}","compare_url":"https://api.github.com/repos/victorporof/tofino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victorporof/tofino/merges","archive_url":"https://api.github.com/repos/victorporof/tofino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victorporof/tofino/downloads","issues_url":"https://api.github.com/repos/victorporof/tofino/issues{/number}","pulls_url":"https://api.github.com/repos/victorporof/tofino/pulls{/number}","milestones_url":"https://api.github.com/repos/victorporof/tofino/milestones{/number}","notifications_url":"https://api.github.com/repos/victorporof/tofino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victorporof/tofino/labels{/name}","releases_url":"https://api.github.com/repos/victorporof/tofino/releases{/id}","deployments_url":"https://api.github.com/repos/victorporof/tofino/deployments","created_at":"2016-04-12T04:57:51Z","updated_at":"2016-06-03T13:00:36Z","pushed_at":"2016-10-14T16:22:38Z","git_url":"git://github.com/victorporof/tofino.git","ssh_url":"git@github.com:victorporof/tofino.git","clone_url":"https://github.com/victorporof/tofino.git","svn_url":"https://github.com/victorporof/tofino","homepage":"https://medium.com/project-tofino","size":4669,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"c905c10883c0724bd5e55bd81bfdbec46a2c5536","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":55401807,"name":"tofino","full_name":"mozilla/tofino","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/tofino","description":"Project Tofino is a browser interaction experiment.","fork":false,"url":"https://api.github.com/repos/mozilla/tofino","forks_url":"https://api.github.com/repos/mozilla/tofino/forks","keys_url":"https://api.github.com/repos/mozilla/tofino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/tofino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/tofino/teams","hooks_url":"https://api.github.com/repos/mozilla/tofino/hooks","issue_events_url":"https://api.github.com/repos/mozilla/tofino/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/tofino/events","assignees_url":"https://api.github.com/repos/mozilla/tofino/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/tofino/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/tofino/tags","blobs_url":"https://api.github.com/repos/mozilla/tofino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/tofino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/tofino/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/tofino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/tofino/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/tofino/languages","stargazers_url":"https://api.github.com/repos/mozilla/tofino/stargazers","contributors_url":"https://api.github.com/repos/mozilla/tofino/contributors","subscribers_url":"https://api.github.com/repos/mozilla/tofino/subscribers","subscription_url":"https://api.github.com/repos/mozilla/tofino/subscription","commits_url":"https://api.github.com/repos/mozilla/tofino/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/tofino/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/tofino/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/tofino/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/tofino/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/tofino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/tofino/merges","archive_url":"https://api.github.com/repos/mozilla/tofino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/tofino/downloads","issues_url":"https://api.github.com/repos/mozilla/tofino/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/tofino/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/tofino/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/tofino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/tofino/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/tofino/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/tofino/deployments","created_at":"2016-04-04T10:13:26Z","updated_at":"2016-10-14T12:00:15Z","pushed_at":"2016-10-14T16:22:38Z","git_url":"git://github.com/mozilla/tofino.git","ssh_url":"git@github.com:mozilla/tofino.git","clone_url":"https://github.com/mozilla/tofino.git","svn_url":"https://github.com/mozilla/tofino","homepage":"https://mozilla.github.io/tofino","size":6318,"stargazers_count":532,"watchers_count":532,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"open_issues_count":140,"forks":57,"open_issues":140,"watchers":532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/1415"},"html":{"href":"https://github.com/mozilla/tofino/pull/1415"},"issue":{"href":"https://api.github.com/repos/mozilla/tofino/issues/1415"},"comments":{"href":"https://api.github.com/repos/mozilla/tofino/issues/1415/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/1415/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/1415/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/tofino/statuses/4548cd7a5ee1d00dce7bc10ece2f57e37f4ebee8"}}}}
{"actor":{"display_login":"ncalexan"}}