{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8304","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8304/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8304/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8304/events","html_url":"https://github.com/nodejs/node/pull/8304","id":173611640,"number":8304,"title":"crypto: re-add crypto.timingSafeEqual","user":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars.githubusercontent.com/u/11638619?v=3","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/crypto","name":"crypto","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-08-27T19:32:51Z","updated_at":"2016-08-28T19:44:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8304","html_url":"https://github.com/nodejs/node/pull/8304","diff_url":"https://github.com/nodejs/node/pull/8304.diff","patch_url":"https://github.com/nodejs/node/pull/8304.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\ncrypto test\r\n\r\n##### Description of change\r\n\r\nRefs: #8040, #8203, #8225\r\n\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nThis re-adds crypto.timingSafeEqual, which was previously reverted due to test failures and concerns that the implementation might not be timing-safe.\r\n\r\nSome investigation is still needed to determine why the tests are failing on ARM systems."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/242994984","html_url":"https://github.com/nodejs/node/pull/8304#issuecomment-242994984","issue_url":"https://api.github.com/repos/nodejs/node/issues/8304","id":242994984,"user":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars.githubusercontent.com/u/11638619?v=3","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"created_at":"2016-08-28T19:44:18Z","updated_at":"2016-08-28T19:44:18Z","body":"I think this is ready for review; the tests are slightly flaky on ARM, but they seem to pass fairly consistently on other platforms, and we have [fairly good reason](/nodejs/node/pull/8304#issuecomment-242959871) to believe that the inconsistencies are not a security problem.\r\n\r\n(The implementation in this PR is the same as in #8040; only the tests have changed.)"}}
{"actor":{"display_login":"not-an-aardvark"}}