{"action":"created","comment":{"url":"https://api.github.com/repos/go-clang/gen/pulls/comments/77547919","id":77547919,"diff_hunk":"@@ -145,7 +145,12 @@ func (fa *ASTFunc) generateParameters() []ast.Expr {\n \t\tif p.Type.IsSlice && !p.Type.IsReturnArgument {\n \t\t\thasDeclaration = true\n \n-\t\t\tfa.addGoToCSliceConversion(p.Name, p.Type)\n+\t\t\t\n+\t\t\tif _, ok := p.Heuristics[\"pass_c\"]; !ok {","path":"ast.go","position":6,"original_position":6,"commit_id":"7365504149eba13d3ac4b2d9f3b009232264f16f","original_commit_id":"7365504149eba13d3ac4b2d9f3b009232264f16f","user":{"login":"zimmski","id":1847950,"avatar_url":"https://avatars.githubusercontent.com/u/1847950?v=3","gravatar_id":"","url":"https://api.github.com/users/zimmski","html_url":"https://github.com/zimmski","followers_url":"https://api.github.com/users/zimmski/followers","following_url":"https://api.github.com/users/zimmski/following{/other_user}","gists_url":"https://api.github.com/users/zimmski/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmski/subscriptions","organizations_url":"https://api.github.com/users/zimmski/orgs","repos_url":"https://api.github.com/users/zimmski/repos","events_url":"https://api.github.com/users/zimmski/events{/privacy}","received_events_url":"https://api.github.com/users/zimmski/received_events","type":"User","site_admin":false},"body":"You might kill me for this but I do not think that we should add a \"Heuristics\" map to any struct:\r\n- Your intention for the maps was probably to make future similar changes easier but the future type interaction is very limited even later, but even then I think that it is easier and type-safer to add a flag.\r\n- The only map that is currently used is of the FunctionParameter, so the other maps are not needed at all right now.\r\n- Using keys makes it harder to safely use an API -> no compile errors\r\n\r\nSo I would be proposing to add a flag to the FunctionParameter struct BUT I am wondering. Shouldn't this be the default anyhow?","created_at":"2016-09-05T17:52:41Z","updated_at":"2016-09-05T17:52:41Z","html_url":"https://github.com/go-clang/gen/pull/112#discussion_r77547919","pull_request_url":"https://api.github.com/repos/go-clang/gen/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/go-clang/gen/pulls/comments/77547919"},"html":{"href":"https://github.com/go-clang/gen/pull/112#discussion_r77547919"},"pull_request":{"href":"https://api.github.com/repos/go-clang/gen/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/go-clang/gen/pulls/112","id":58551247,"html_url":"https://github.com/go-clang/gen/pull/112","diff_url":"https://github.com/go-clang/gen/pull/112.diff","patch_url":"https://github.com/go-clang/gen/pull/112.patch","issue_url":"https://api.github.com/repos/go-clang/gen/issues/112","number":112,"state":"open","locked":false,"title":"Dispose functions must free original c memory, not generated go memory","user":{"login":"marxriedl","id":805311,"avatar_url":"https://avatars.githubusercontent.com/u/805311?v=3","gravatar_id":"","url":"https://api.github.com/users/marxriedl","html_url":"https://github.com/marxriedl","followers_url":"https://api.github.com/users/marxriedl/followers","following_url":"https://api.github.com/users/marxriedl/following{/other_user}","gists_url":"https://api.github.com/users/marxriedl/gists{/gist_id}","starred_url":"https://api.github.com/users/marxriedl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marxriedl/subscriptions","organizations_url":"https://api.github.com/users/marxriedl/orgs","repos_url":"https://api.github.com/users/marxriedl/repos","events_url":"https://api.github.com/users/marxriedl/events{/privacy}","received_events_url":"https://api.github.com/users/marxriedl/received_events","type":"User","site_admin":false},"body":"Fixes #108","created_at":"2016-02-07T17:17:39Z","updated_at":"2016-09-05T17:52:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c98275a23b4a585a6f6286551172741e4936a25","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-clang/gen/pulls/112/commits","review_comments_url":"https://api.github.com/repos/go-clang/gen/pulls/112/comments","review_comment_url":"https://api.github.com/repos/go-clang/gen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-clang/gen/issues/112/comments","statuses_url":"https://api.github.com/repos/go-clang/gen/statuses/7365504149eba13d3ac4b2d9f3b009232264f16f","head":{"label":"go-clang:issue-108-free-methods-must-release-orig-memory","ref":"issue-108-free-methods-must-release-orig-memory","sha":"7365504149eba13d3ac4b2d9f3b009232264f16f","user":{"login":"go-clang","id":15632095,"avatar_url":"https://avatars.githubusercontent.com/u/15632095?v=3","gravatar_id":"","url":"https://api.github.com/users/go-clang","html_url":"https://github.com/go-clang","followers_url":"https://api.github.com/users/go-clang/followers","following_url":"https://api.github.com/users/go-clang/following{/other_user}","gists_url":"https://api.github.com/users/go-clang/gists{/gist_id}","starred_url":"https://api.github.com/users/go-clang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-clang/subscriptions","organizations_url":"https://api.github.com/users/go-clang/orgs","repos_url":"https://api.github.com/users/go-clang/repos","events_url":"https://api.github.com/users/go-clang/events{/privacy}","received_events_url":"https://api.github.com/users/go-clang/received_events","type":"Organization","site_admin":false},"repo":{"id":44170554,"name":"gen","full_name":"go-clang/gen","owner":{"login":"go-clang","id":15632095,"avatar_url":"https://avatars.githubusercontent.com/u/15632095?v=3","gravatar_id":"","url":"https://api.github.com/users/go-clang","html_url":"https://github.com/go-clang","followers_url":"https://api.github.com/users/go-clang/followers","following_url":"https://api.github.com/users/go-clang/following{/other_user}","gists_url":"https://api.github.com/users/go-clang/gists{/gist_id}","starred_url":"https://api.github.com/users/go-clang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-clang/subscriptions","organizations_url":"https://api.github.com/users/go-clang/orgs","repos_url":"https://api.github.com/users/go-clang/repos","events_url":"https://api.github.com/users/go-clang/events{/privacy}","received_events_url":"https://api.github.com/users/go-clang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-clang/gen","description":"Generate Go bindings for Clang's C API","fork":false,"url":"https://api.github.com/repos/go-clang/gen","forks_url":"https://api.github.com/repos/go-clang/gen/forks","keys_url":"https://api.github.com/repos/go-clang/gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-clang/gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-clang/gen/teams","hooks_url":"https://api.github.com/repos/go-clang/gen/hooks","issue_events_url":"https://api.github.com/repos/go-clang/gen/issues/events{/number}","events_url":"https://api.github.com/repos/go-clang/gen/events","assignees_url":"https://api.github.com/repos/go-clang/gen/assignees{/user}","branches_url":"https://api.github.com/repos/go-clang/gen/branches{/branch}","tags_url":"https://api.github.com/repos/go-clang/gen/tags","blobs_url":"https://api.github.com/repos/go-clang/gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-clang/gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-clang/gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-clang/gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-clang/gen/statuses/{sha}","languages_url":"https://api.github.com/repos/go-clang/gen/languages","stargazers_url":"https://api.github.com/repos/go-clang/gen/stargazers","contributors_url":"https://api.github.com/repos/go-clang/gen/contributors","subscribers_url":"https://api.github.com/repos/go-clang/gen/subscribers","subscription_url":"https://api.github.com/repos/go-clang/gen/subscription","commits_url":"https://api.github.com/repos/go-clang/gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-clang/gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-clang/gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-clang/gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-clang/gen/contents/{+path}","compare_url":"https://api.github.com/repos/go-clang/gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-clang/gen/merges","archive_url":"https://api.github.com/repos/go-clang/gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-clang/gen/downloads","issues_url":"https://api.github.com/repos/go-clang/gen/issues{/number}","pulls_url":"https://api.github.com/repos/go-clang/gen/pulls{/number}","milestones_url":"https://api.github.com/repos/go-clang/gen/milestones{/number}","notifications_url":"https://api.github.com/repos/go-clang/gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-clang/gen/labels{/name}","releases_url":"https://api.github.com/repos/go-clang/gen/releases{/id}","deployments_url":"https://api.github.com/repos/go-clang/gen/deployments","created_at":"2015-10-13T11:05:45Z","updated_at":"2016-08-23T14:00:06Z","pushed_at":"2016-09-05T17:44:35Z","git_url":"git://github.com/go-clang/gen.git","ssh_url":"git@github.com:go-clang/gen.git","clone_url":"https://github.com/go-clang/gen.git","svn_url":"https://github.com/go-clang/gen","homepage":"","size":709,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":36,"forks":1,"open_issues":36,"watchers":7,"default_branch":"master"}},"base":{"label":"go-clang:master","ref":"master","sha":"4290fb63056aa6d6e87c4022c5f81e580ff17085","user":{"login":"go-clang","id":15632095,"avatar_url":"https://avatars.githubusercontent.com/u/15632095?v=3","gravatar_id":"","url":"https://api.github.com/users/go-clang","html_url":"https://github.com/go-clang","followers_url":"https://api.github.com/users/go-clang/followers","following_url":"https://api.github.com/users/go-clang/following{/other_user}","gists_url":"https://api.github.com/users/go-clang/gists{/gist_id}","starred_url":"https://api.github.com/users/go-clang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-clang/subscriptions","organizations_url":"https://api.github.com/users/go-clang/orgs","repos_url":"https://api.github.com/users/go-clang/repos","events_url":"https://api.github.com/users/go-clang/events{/privacy}","received_events_url":"https://api.github.com/users/go-clang/received_events","type":"Organization","site_admin":false},"repo":{"id":44170554,"name":"gen","full_name":"go-clang/gen","owner":{"login":"go-clang","id":15632095,"avatar_url":"https://avatars.githubusercontent.com/u/15632095?v=3","gravatar_id":"","url":"https://api.github.com/users/go-clang","html_url":"https://github.com/go-clang","followers_url":"https://api.github.com/users/go-clang/followers","following_url":"https://api.github.com/users/go-clang/following{/other_user}","gists_url":"https://api.github.com/users/go-clang/gists{/gist_id}","starred_url":"https://api.github.com/users/go-clang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-clang/subscriptions","organizations_url":"https://api.github.com/users/go-clang/orgs","repos_url":"https://api.github.com/users/go-clang/repos","events_url":"https://api.github.com/users/go-clang/events{/privacy}","received_events_url":"https://api.github.com/users/go-clang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-clang/gen","description":"Generate Go bindings for Clang's C API","fork":false,"url":"https://api.github.com/repos/go-clang/gen","forks_url":"https://api.github.com/repos/go-clang/gen/forks","keys_url":"https://api.github.com/repos/go-clang/gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-clang/gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-clang/gen/teams","hooks_url":"https://api.github.com/repos/go-clang/gen/hooks","issue_events_url":"https://api.github.com/repos/go-clang/gen/issues/events{/number}","events_url":"https://api.github.com/repos/go-clang/gen/events","assignees_url":"https://api.github.com/repos/go-clang/gen/assignees{/user}","branches_url":"https://api.github.com/repos/go-clang/gen/branches{/branch}","tags_url":"https://api.github.com/repos/go-clang/gen/tags","blobs_url":"https://api.github.com/repos/go-clang/gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-clang/gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-clang/gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-clang/gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-clang/gen/statuses/{sha}","languages_url":"https://api.github.com/repos/go-clang/gen/languages","stargazers_url":"https://api.github.com/repos/go-clang/gen/stargazers","contributors_url":"https://api.github.com/repos/go-clang/gen/contributors","subscribers_url":"https://api.github.com/repos/go-clang/gen/subscribers","subscription_url":"https://api.github.com/repos/go-clang/gen/subscription","commits_url":"https://api.github.com/repos/go-clang/gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-clang/gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-clang/gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-clang/gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-clang/gen/contents/{+path}","compare_url":"https://api.github.com/repos/go-clang/gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-clang/gen/merges","archive_url":"https://api.github.com/repos/go-clang/gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-clang/gen/downloads","issues_url":"https://api.github.com/repos/go-clang/gen/issues{/number}","pulls_url":"https://api.github.com/repos/go-clang/gen/pulls{/number}","milestones_url":"https://api.github.com/repos/go-clang/gen/milestones{/number}","notifications_url":"https://api.github.com/repos/go-clang/gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-clang/gen/labels{/name}","releases_url":"https://api.github.com/repos/go-clang/gen/releases{/id}","deployments_url":"https://api.github.com/repos/go-clang/gen/deployments","created_at":"2015-10-13T11:05:45Z","updated_at":"2016-08-23T14:00:06Z","pushed_at":"2016-09-05T17:44:35Z","git_url":"git://github.com/go-clang/gen.git","ssh_url":"git@github.com:go-clang/gen.git","clone_url":"https://github.com/go-clang/gen.git","svn_url":"https://github.com/go-clang/gen","homepage":"","size":709,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":36,"forks":1,"open_issues":36,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-clang/gen/pulls/112"},"html":{"href":"https://github.com/go-clang/gen/pull/112"},"issue":{"href":"https://api.github.com/repos/go-clang/gen/issues/112"},"comments":{"href":"https://api.github.com/repos/go-clang/gen/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/go-clang/gen/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/go-clang/gen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-clang/gen/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/go-clang/gen/statuses/7365504149eba13d3ac4b2d9f3b009232264f16f"}}}}
{"actor":{"display_login":"zimmski"}}