{"action":"created","comment":{"url":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/comments/80113947","id":80113947,"diff_hunk":"@@ -38,199 +43,493 @@ public function testCreate()\n \t\t$testfield = TextElement::create('TestField');\n \n \t\t$this->assertInstanceOf('Staple\\Form\\Validate\\DependentFieldValidator', new DependentFieldValidator($testfield));\n+\t}\n+\n+\t/**\n+\t * Test static method equal for instantiation of DependentFieldValidator\n+\t */\n+\tpublic function testEqualCreate()\n+\t{\n+\t\t// Test field for instantiation\n+\t\t$testfield = TextElement::create('TestField');\n \n \t\t$this->assertInstanceOf('Staple\\Form\\Validate\\DependentFieldValidator', DependentFieldValidator::equal($testfield));\n+\t}\n+\n+\t/**\n+\t * Test static method lessThan for instantiation of DependentFieldValidator\n+\t */\n+\tpublic function testLessThanCreate()\n+\t{\n+\t\t// Test field for instantiation\n+\t\t$testfield = TextElement::create('TestField');\n \n \t\t$this->assertInstanceOf('Staple\\Form\\Validate\\DependentFieldValidator', DependentFieldValidator::lessThan($testfield));\n+\t}\n+\n+\t/**\n+\t * Test static method greaterThan for instantiation of DependentFieldValidator\n+\t */\n+\tpublic function testGreaterThanCreate()\n+\t{\n+\t\t// Test field for instantiation\n+\t\t$testfield = TextElement::create('TestField');\n \n \t\t$this->assertInstanceOf('Staple\\Form\\Validate\\DependentFieldValidator', DependentFieldValidator::greaterThan($testfield));\n+\t}\n+\n+\t/**\n+\t * Test static method lessThanEqualTo for instantiation of DependentFieldValidator\n+\t */\n+\tpublic function testLessThanEqualToCreate()\n+\t{\n+\t\t// Test field for instantiation\n+\t\t$testfield = TextElement::create('TestField');\n \n \t\t$this->assertInstanceOf('Staple\\Form\\Validate\\DependentFieldValidator', DependentFieldValidator::lessThanEqualTo($testfield));\n+\t}\n+\n+\t/**\n+\t * Test static method greaterThanEqualTo for instantiation of DependentFieldValidator\n+\t */\n+\tpublic function testGreaterThanEqualToCreate()\n+\t{\n+\t\t// Test field for instantiation\n+\t\t$testfield = TextElement::create('TestField');\n \n \t\t$this->assertInstanceOf('Staple\\Form\\Validate\\DependentFieldValidator', DependentFieldValidator::greaterThanEqualTo($testfield));\n \t}\n \n+\n+\n \t/**\n-\t * Test DependentFieldValidator Getters and Setters\n+\t * ***** Getters and Setters Tests *****\n \t */\n-\tpublic function testGettersAndSetters()\n+\n+\t/*\n+\t * Field Getter and Setter Test\n+\t */\n+\tpublic function testFieldGetterAndSetter()\n \t{\n \t\t// Instantiate DependentFieldValidator with test field.\n \t\t$testfield = TextElement::create('TestField');\n \t\t$dependentFieldValidator = new DependentFieldValidator($testfield);\n \n-\t\t// Create different field to set Field value to using Setter\n+\t\t// Create different field to set Field to using Setter\n \t\t$testarea = TextareaElement::create('TestArea');\n \n \t\t// Test Field Getter and Setter\n \t\t$dependentFieldValidator->setField($testarea);\n \t\t$this->assertInstanceOf('Staple\\Form\\TextareaElement', $dependentFieldValidator->getField());\n+\t}\n+\n+\t/*\n+\t * FieldValue Getter and Setter Test\n+\t */\n+\tpublic function testFieldValueGetterAndSetter()\n+\t{\n+\t\t// Instantiate DependentFieldValidator with test field.\n+\t\t$testfield = TextElement::create('TestField');\n+\t\t$dependentFieldValidator = new DependentFieldValidator($testfield);\n \n \t\t//Test Fieldvalue Getter\n \t\t$testfield->setValue(1);\n \t\t$dependentFieldValidator->setField($testfield);\n-\t\t$this->assertEquals(1, $dependentFieldValidator->getFieldvalue());\n-\t\t$this->assertNotEquals(2, $dependentFieldValidator->getFieldvalue());\n+\t\t$this->assertEquals(1, $dependentFieldValidator->getFieldValue());\n+\t\t$this->assertNotEquals(2, $dependentFieldValidator->getFieldValue());\n+\n+\t}\n+\n+\t/*\n+\t * Operation Getter and Setter Test\n+\t */\n+\tpublic function testOperationGetterAndSetter()\n+\t{\n+\t\t// Instantiate DependentFieldValidator with test field.\n+\t\t$testfield = TextElement::create('TestField');\n+\t\t$dependentFieldValidator = new DependentFieldValidator($testfield);\n \n \t\t// Test Operation Getter and Setter\n \t\t$dependentFieldValidator->setOperation($dependentFieldValidator::GREATERTHAN);\n \t\t$this->assertEquals($dependentFieldValidator::GREATERTHAN, $dependentFieldValidator->getOperation());\n \t}\n \n-\tpublic function testOperationComparisonOperations()\n+\t/*\n+\t * ***** Comparison Operations Tests *****\n+\t *\n+\t * ** Numerical Values **\n+\t */\n+\n+\t/*\n+\t * Test equal to functionality\n+\t */\n+\tpublic function testEqaulFunctionalityEqualValues()","path":"tests/Staple/Form/Validators/DependentFieldValidatorTest.php","position":166,"original_position":142,"commit_id":"ff09972b2af934a4bdf96993418ab10a34251e24","original_commit_id":"ff09972b2af934a4bdf96993418ab10a34251e24","user":{"login":"ironpilot","id":1167789,"avatar_url":"https://avatars.githubusercontent.com/u/1167789?v=3","gravatar_id":"","url":"https://api.github.com/users/ironpilot","html_url":"https://github.com/ironpilot","followers_url":"https://api.github.com/users/ironpilot/followers","following_url":"https://api.github.com/users/ironpilot/following{/other_user}","gists_url":"https://api.github.com/users/ironpilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ironpilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironpilot/subscriptions","organizations_url":"https://api.github.com/users/ironpilot/orgs","repos_url":"https://api.github.com/users/ironpilot/repos","events_url":"https://api.github.com/users/ironpilot/events{/privacy}","received_events_url":"https://api.github.com/users/ironpilot/received_events","type":"User","site_admin":false},"body":"`Equal` is spelled wrong.","created_at":"2016-09-22T19:08:08Z","updated_at":"2016-09-22T19:08:08Z","html_url":"https://github.com/ironpilot/Staple-Code/pull/64#discussion_r80113947","pull_request_url":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/comments/80113947"},"html":{"href":"https://github.com/ironpilot/Staple-Code/pull/64#discussion_r80113947"},"pull_request":{"href":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/64","id":85737679,"html_url":"https://github.com/ironpilot/Staple-Code/pull/64","diff_url":"https://github.com/ironpilot/Staple-Code/pull/64.diff","patch_url":"https://github.com/ironpilot/Staple-Code/pull/64.patch","issue_url":"https://api.github.com/repos/ironpilot/Staple-Code/issues/64","number":64,"state":"open","locked":false,"title":"Dependent field validator","user":{"login":"hansheeling","id":6426774,"avatar_url":"https://avatars.githubusercontent.com/u/6426774?v=3","gravatar_id":"","url":"https://api.github.com/users/hansheeling","html_url":"https://github.com/hansheeling","followers_url":"https://api.github.com/users/hansheeling/followers","following_url":"https://api.github.com/users/hansheeling/following{/other_user}","gists_url":"https://api.github.com/users/hansheeling/gists{/gist_id}","starred_url":"https://api.github.com/users/hansheeling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansheeling/subscriptions","organizations_url":"https://api.github.com/users/hansheeling/orgs","repos_url":"https://api.github.com/users/hansheeling/repos","events_url":"https://api.github.com/users/hansheeling/events{/privacy}","received_events_url":"https://api.github.com/users/hansheeling/received_events","type":"User","site_admin":false},"body":"fixes #37 ","created_at":"2016-09-19T04:41:32Z","updated_at":"2016-09-22T19:20:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d65403bba5363c5853378252bd986775e7b4bb07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/64/commits","review_comments_url":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/64/comments","review_comment_url":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ironpilot/Staple-Code/issues/64/comments","statuses_url":"https://api.github.com/repos/ironpilot/Staple-Code/statuses/ff09972b2af934a4bdf96993418ab10a34251e24","head":{"label":"ironpilot:DependentFieldValidator","ref":"DependentFieldValidator","sha":"ff09972b2af934a4bdf96993418ab10a34251e24","user":{"login":"ironpilot","id":1167789,"avatar_url":"https://avatars.githubusercontent.com/u/1167789?v=3","gravatar_id":"","url":"https://api.github.com/users/ironpilot","html_url":"https://github.com/ironpilot","followers_url":"https://api.github.com/users/ironpilot/followers","following_url":"https://api.github.com/users/ironpilot/following{/other_user}","gists_url":"https://api.github.com/users/ironpilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ironpilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironpilot/subscriptions","organizations_url":"https://api.github.com/users/ironpilot/orgs","repos_url":"https://api.github.com/users/ironpilot/repos","events_url":"https://api.github.com/users/ironpilot/events{/privacy}","received_events_url":"https://api.github.com/users/ironpilot/received_events","type":"User","site_admin":false},"repo":{"id":2696249,"name":"Staple-Code","full_name":"ironpilot/Staple-Code","owner":{"login":"ironpilot","id":1167789,"avatar_url":"https://avatars.githubusercontent.com/u/1167789?v=3","gravatar_id":"","url":"https://api.github.com/users/ironpilot","html_url":"https://github.com/ironpilot","followers_url":"https://api.github.com/users/ironpilot/followers","following_url":"https://api.github.com/users/ironpilot/following{/other_user}","gists_url":"https://api.github.com/users/ironpilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ironpilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironpilot/subscriptions","organizations_url":"https://api.github.com/users/ironpilot/orgs","repos_url":"https://api.github.com/users/ironpilot/repos","events_url":"https://api.github.com/users/ironpilot/events{/privacy}","received_events_url":"https://api.github.com/users/ironpilot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ironpilot/Staple-Code","description":"","fork":false,"url":"https://api.github.com/repos/ironpilot/Staple-Code","forks_url":"https://api.github.com/repos/ironpilot/Staple-Code/forks","keys_url":"https://api.github.com/repos/ironpilot/Staple-Code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironpilot/Staple-Code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironpilot/Staple-Code/teams","hooks_url":"https://api.github.com/repos/ironpilot/Staple-Code/hooks","issue_events_url":"https://api.github.com/repos/ironpilot/Staple-Code/issues/events{/number}","events_url":"https://api.github.com/repos/ironpilot/Staple-Code/events","assignees_url":"https://api.github.com/repos/ironpilot/Staple-Code/assignees{/user}","branches_url":"https://api.github.com/repos/ironpilot/Staple-Code/branches{/branch}","tags_url":"https://api.github.com/repos/ironpilot/Staple-Code/tags","blobs_url":"https://api.github.com/repos/ironpilot/Staple-Code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironpilot/Staple-Code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironpilot/Staple-Code/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironpilot/Staple-Code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironpilot/Staple-Code/statuses/{sha}","languages_url":"https://api.github.com/repos/ironpilot/Staple-Code/languages","stargazers_url":"https://api.github.com/repos/ironpilot/Staple-Code/stargazers","contributors_url":"https://api.github.com/repos/ironpilot/Staple-Code/contributors","subscribers_url":"https://api.github.com/repos/ironpilot/Staple-Code/subscribers","subscription_url":"https://api.github.com/repos/ironpilot/Staple-Code/subscription","commits_url":"https://api.github.com/repos/ironpilot/Staple-Code/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironpilot/Staple-Code/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironpilot/Staple-Code/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironpilot/Staple-Code/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironpilot/Staple-Code/contents/{+path}","compare_url":"https://api.github.com/repos/ironpilot/Staple-Code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironpilot/Staple-Code/merges","archive_url":"https://api.github.com/repos/ironpilot/Staple-Code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironpilot/Staple-Code/downloads","issues_url":"https://api.github.com/repos/ironpilot/Staple-Code/issues{/number}","pulls_url":"https://api.github.com/repos/ironpilot/Staple-Code/pulls{/number}","milestones_url":"https://api.github.com/repos/ironpilot/Staple-Code/milestones{/number}","notifications_url":"https://api.github.com/repos/ironpilot/Staple-Code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironpilot/Staple-Code/labels{/name}","releases_url":"https://api.github.com/repos/ironpilot/Staple-Code/releases{/id}","deployments_url":"https://api.github.com/repos/ironpilot/Staple-Code/deployments","created_at":"2011-11-02T16:25:28Z","updated_at":"2015-06-26T03:30:00Z","pushed_at":"2016-09-22T19:05:06Z","git_url":"git://github.com/ironpilot/Staple-Code.git","ssh_url":"git@github.com:ironpilot/Staple-Code.git","clone_url":"https://github.com/ironpilot/Staple-Code.git","svn_url":"https://github.com/ironpilot/Staple-Code","homepage":"http://www.staplecode.org/","size":4407,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":19,"forks":1,"open_issues":19,"watchers":4,"default_branch":"master"}},"base":{"label":"ironpilot:development","ref":"development","sha":"35ac979910a5877f7129b1bf92c002fde9650551","user":{"login":"ironpilot","id":1167789,"avatar_url":"https://avatars.githubusercontent.com/u/1167789?v=3","gravatar_id":"","url":"https://api.github.com/users/ironpilot","html_url":"https://github.com/ironpilot","followers_url":"https://api.github.com/users/ironpilot/followers","following_url":"https://api.github.com/users/ironpilot/following{/other_user}","gists_url":"https://api.github.com/users/ironpilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ironpilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironpilot/subscriptions","organizations_url":"https://api.github.com/users/ironpilot/orgs","repos_url":"https://api.github.com/users/ironpilot/repos","events_url":"https://api.github.com/users/ironpilot/events{/privacy}","received_events_url":"https://api.github.com/users/ironpilot/received_events","type":"User","site_admin":false},"repo":{"id":2696249,"name":"Staple-Code","full_name":"ironpilot/Staple-Code","owner":{"login":"ironpilot","id":1167789,"avatar_url":"https://avatars.githubusercontent.com/u/1167789?v=3","gravatar_id":"","url":"https://api.github.com/users/ironpilot","html_url":"https://github.com/ironpilot","followers_url":"https://api.github.com/users/ironpilot/followers","following_url":"https://api.github.com/users/ironpilot/following{/other_user}","gists_url":"https://api.github.com/users/ironpilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ironpilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironpilot/subscriptions","organizations_url":"https://api.github.com/users/ironpilot/orgs","repos_url":"https://api.github.com/users/ironpilot/repos","events_url":"https://api.github.com/users/ironpilot/events{/privacy}","received_events_url":"https://api.github.com/users/ironpilot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ironpilot/Staple-Code","description":"","fork":false,"url":"https://api.github.com/repos/ironpilot/Staple-Code","forks_url":"https://api.github.com/repos/ironpilot/Staple-Code/forks","keys_url":"https://api.github.com/repos/ironpilot/Staple-Code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironpilot/Staple-Code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironpilot/Staple-Code/teams","hooks_url":"https://api.github.com/repos/ironpilot/Staple-Code/hooks","issue_events_url":"https://api.github.com/repos/ironpilot/Staple-Code/issues/events{/number}","events_url":"https://api.github.com/repos/ironpilot/Staple-Code/events","assignees_url":"https://api.github.com/repos/ironpilot/Staple-Code/assignees{/user}","branches_url":"https://api.github.com/repos/ironpilot/Staple-Code/branches{/branch}","tags_url":"https://api.github.com/repos/ironpilot/Staple-Code/tags","blobs_url":"https://api.github.com/repos/ironpilot/Staple-Code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironpilot/Staple-Code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironpilot/Staple-Code/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironpilot/Staple-Code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironpilot/Staple-Code/statuses/{sha}","languages_url":"https://api.github.com/repos/ironpilot/Staple-Code/languages","stargazers_url":"https://api.github.com/repos/ironpilot/Staple-Code/stargazers","contributors_url":"https://api.github.com/repos/ironpilot/Staple-Code/contributors","subscribers_url":"https://api.github.com/repos/ironpilot/Staple-Code/subscribers","subscription_url":"https://api.github.com/repos/ironpilot/Staple-Code/subscription","commits_url":"https://api.github.com/repos/ironpilot/Staple-Code/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironpilot/Staple-Code/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironpilot/Staple-Code/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironpilot/Staple-Code/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironpilot/Staple-Code/contents/{+path}","compare_url":"https://api.github.com/repos/ironpilot/Staple-Code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironpilot/Staple-Code/merges","archive_url":"https://api.github.com/repos/ironpilot/Staple-Code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironpilot/Staple-Code/downloads","issues_url":"https://api.github.com/repos/ironpilot/Staple-Code/issues{/number}","pulls_url":"https://api.github.com/repos/ironpilot/Staple-Code/pulls{/number}","milestones_url":"https://api.github.com/repos/ironpilot/Staple-Code/milestones{/number}","notifications_url":"https://api.github.com/repos/ironpilot/Staple-Code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironpilot/Staple-Code/labels{/name}","releases_url":"https://api.github.com/repos/ironpilot/Staple-Code/releases{/id}","deployments_url":"https://api.github.com/repos/ironpilot/Staple-Code/deployments","created_at":"2011-11-02T16:25:28Z","updated_at":"2015-06-26T03:30:00Z","pushed_at":"2016-09-22T19:05:06Z","git_url":"git://github.com/ironpilot/Staple-Code.git","ssh_url":"git@github.com:ironpilot/Staple-Code.git","clone_url":"https://github.com/ironpilot/Staple-Code.git","svn_url":"https://github.com/ironpilot/Staple-Code","homepage":"http://www.staplecode.org/","size":4407,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":19,"forks":1,"open_issues":19,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/64"},"html":{"href":"https://github.com/ironpilot/Staple-Code/pull/64"},"issue":{"href":"https://api.github.com/repos/ironpilot/Staple-Code/issues/64"},"comments":{"href":"https://api.github.com/repos/ironpilot/Staple-Code/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ironpilot/Staple-Code/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/ironpilot/Staple-Code/statuses/ff09972b2af934a4bdf96993418ab10a34251e24"}}}}
{"actor":{"display_login":"ironpilot"}}