{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/4287","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/4287/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/4287/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/4287/events","html_url":"https://github.com/facebook/react-native/pull/4287","id":118288089,"number":4287,"title":"Fixed crash when polyfillGlobal attempts to polyfill a property with a getter","user":{"login":"brianreavis","id":118480,"avatar_url":"https://avatars.githubusercontent.com/u/118480?v=3","gravatar_id":"","url":"https://api.github.com/users/brianreavis","html_url":"https://github.com/brianreavis","followers_url":"https://api.github.com/users/brianreavis/followers","following_url":"https://api.github.com/users/brianreavis/following{/other_user}","gists_url":"https://api.github.com/users/brianreavis/gists{/gist_id}","starred_url":"https://api.github.com/users/brianreavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianreavis/subscriptions","organizations_url":"https://api.github.com/users/brianreavis/orgs","repos_url":"https://api.github.com/users/brianreavis/repos","events_url":"https://api.github.com/users/brianreavis/events{/privacy}","received_events_url":"https://api.github.com/users/brianreavis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"},{"url":"https://api.github.com/repos/facebook/react-native/labels/Needs%20Response%20from%20Author","name":"Needs Response from Author","color":"eb6420"},{"url":"https://api.github.com/repos/facebook/react-native/labels/Triage%20-%20In%20Progress","name":"Triage - In Progress","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-11-22T20:58:25Z","updated_at":"2016-03-20T16:15:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/4287","html_url":"https://github.com/facebook/react-native/pull/4287","diff_url":"https://github.com/facebook/react-native/pull/4287.diff","patch_url":"https://github.com/facebook/react-native/pull/4287.patch"},"body":"This PR fixes an exception that occurs when `polyfillGlobal()` attempts to polyfill a property that has a getter defined instead of a value. This seems to affect `geolocation` in `setUpGeolocation()` on device. My app was working last night... then I woke up to it not working (screenshot below). Maybe the OS updated overnight? Who knows... regardless, this should be safer.\r\n\r\n```\r\nInvalid property. 'value' present on property with getter or setter.\r\n```\r\n\r\nThe fix boils down to these lines:\r\nhttps://github.com/facebook/react-native/pull/4287/files#diff-5fb096262c3668e49ebaf855d35cdd49R40\r\n\r\n<img src=\"https://cloud.githubusercontent.com/assets/118480/11326173/7c2fd564-911f-11e5-9ad8-df27a74ac04f.PNG\" width=\"300\" />"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/198956583","html_url":"https://github.com/facebook/react-native/pull/4287#issuecomment-198956583","issue_url":"https://api.github.com/repos/facebook/react-native/issues/4287","id":198956583,"user":{"login":"mkonicek","id":346214,"avatar_url":"https://avatars.githubusercontent.com/u/346214?v=3","gravatar_id":"","url":"https://api.github.com/users/mkonicek","html_url":"https://github.com/mkonicek","followers_url":"https://api.github.com/users/mkonicek/followers","following_url":"https://api.github.com/users/mkonicek/following{/other_user}","gists_url":"https://api.github.com/users/mkonicek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkonicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkonicek/subscriptions","organizations_url":"https://api.github.com/users/mkonicek/orgs","repos_url":"https://api.github.com/users/mkonicek/repos","events_url":"https://api.github.com/users/mkonicek/events{/privacy}","received_events_url":"https://api.github.com/users/mkonicek/received_events","type":"User","site_admin":false},"created_at":"2016-03-20T16:15:50Z","updated_at":"2016-03-20T16:15:50Z","body":"@brianreavis What's the status of this PR? Do you plan to continue working on it? Do you need someone to review it?"}}