{"action":"created","comment":{"url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/comments/88868377","pull_request_review_id":9426695,"id":88868377,"diff_hunk":"@@ -18,7 +22,41 @@\n \n import java.util.List;\n \n-public abstract class NewVolumeCustomizer extends BasicJcloudsLocationCustomizer {\n+/**\n+ * Creates a location customizer that:\n+ * <ul>\n+ * <li>configures the EC2 availability zone</li>\n+ * <li>attaches the specified (existing) volume to the newly-provisioned EC2 instance</li>\n+ * <li>mounts the filesystem under the requested path</li>\n+ * </ul>\n+ *\n+ * Can be used for attaching additional disk on provisioning time for AWS.\n+ * Below is shown an example:\n+ *\n+ * <pre>\n+ *   provisioning.properties:\n+ *     customizers:\n+ *     - $brooklyn:object:\n+ *         type: io.brooklyn.blockstore.brooklyn-blockstore:brooklyn.location.blockstore.ec2.Ec2NewVolumeCustomizer","path":"blockstore/src/main/java/brooklyn/location/blockstore/NewVolumeCustomizer.java","position":37,"original_position":37,"commit_id":"6d30a969bc8c151a684fcd0aa1bc28fdd34cf886","original_commit_id":"6d30a969bc8c151a684fcd0aa1bc28fdd34cf886","user":{"login":"iyovcheva","id":4160133,"avatar_url":"https://avatars.githubusercontent.com/u/4160133?v=3","gravatar_id":"","url":"https://api.github.com/users/iyovcheva","html_url":"https://github.com/iyovcheva","followers_url":"https://api.github.com/users/iyovcheva/followers","following_url":"https://api.github.com/users/iyovcheva/following{/other_user}","gists_url":"https://api.github.com/users/iyovcheva/gists{/gist_id}","starred_url":"https://api.github.com/users/iyovcheva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iyovcheva/subscriptions","organizations_url":"https://api.github.com/users/iyovcheva/orgs","repos_url":"https://api.github.com/users/iyovcheva/repos","events_url":"https://api.github.com/users/iyovcheva/events{/privacy}","received_events_url":"https://api.github.com/users/iyovcheva/received_events","type":"User","site_admin":false},"body":"The example here is with `Ec2NewVolumeCustomizer` which is not appropriate for other clouds. If it should be `NewVolumeCustomizer`, better correct it here.\r\n","created_at":"2016-11-21T10:43:22Z","updated_at":"2016-11-21T10:43:22Z","html_url":"https://github.com/cloudsoft/brooklyn-blockstore/pull/8#discussion_r88868377","pull_request_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/comments/88868377"},"html":{"href":"https://github.com/cloudsoft/brooklyn-blockstore/pull/8#discussion_r88868377"},"pull_request":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/8","id":94191483,"html_url":"https://github.com/cloudsoft/brooklyn-blockstore/pull/8","diff_url":"https://github.com/cloudsoft/brooklyn-blockstore/pull/8.diff","patch_url":"https://github.com/cloudsoft/brooklyn-blockstore/pull/8.patch","issue_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/issues/8","number":8,"state":"open","locked":false,"title":"Vcloud director","user":{"login":"bostko","id":1595054,"avatar_url":"https://avatars.githubusercontent.com/u/1595054?v=3","gravatar_id":"","url":"https://api.github.com/users/bostko","html_url":"https://github.com/bostko","followers_url":"https://api.github.com/users/bostko/followers","following_url":"https://api.github.com/users/bostko/following{/other_user}","gists_url":"https://api.github.com/users/bostko/gists{/gist_id}","starred_url":"https://api.github.com/users/bostko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bostko/subscriptions","organizations_url":"https://api.github.com/users/bostko/orgs","repos_url":"https://api.github.com/users/bostko/repos","events_url":"https://api.github.com/users/bostko/events{/privacy}","received_events_url":"https://api.github.com/users/bostko/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-17T15:41:23Z","updated_at":"2016-11-21T10:43:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e43c19f030755d453bf4e125133680e4fdb38e9f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/8/commits","review_comments_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/8/comments","review_comment_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/issues/8/comments","statuses_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/statuses/6d30a969bc8c151a684fcd0aa1bc28fdd34cf886","head":{"label":"cloudsoft:vcloud-director","ref":"vcloud-director","sha":"6d30a969bc8c151a684fcd0aa1bc28fdd34cf886","user":{"login":"cloudsoft","id":831459,"avatar_url":"https://avatars.githubusercontent.com/u/831459?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudsoft","html_url":"https://github.com/cloudsoft","followers_url":"https://api.github.com/users/cloudsoft/followers","following_url":"https://api.github.com/users/cloudsoft/following{/other_user}","gists_url":"https://api.github.com/users/cloudsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudsoft/subscriptions","organizations_url":"https://api.github.com/users/cloudsoft/orgs","repos_url":"https://api.github.com/users/cloudsoft/repos","events_url":"https://api.github.com/users/cloudsoft/events{/privacy}","received_events_url":"https://api.github.com/users/cloudsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":12131992,"name":"brooklyn-blockstore","full_name":"cloudsoft/brooklyn-blockstore","owner":{"login":"cloudsoft","id":831459,"avatar_url":"https://avatars.githubusercontent.com/u/831459?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudsoft","html_url":"https://github.com/cloudsoft","followers_url":"https://api.github.com/users/cloudsoft/followers","following_url":"https://api.github.com/users/cloudsoft/following{/other_user}","gists_url":"https://api.github.com/users/cloudsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudsoft/subscriptions","organizations_url":"https://api.github.com/users/cloudsoft/orgs","repos_url":"https://api.github.com/users/cloudsoft/repos","events_url":"https://api.github.com/users/cloudsoft/events{/privacy}","received_events_url":"https://api.github.com/users/cloudsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudsoft/brooklyn-blockstore","description":"Cloud volumes abstraction","fork":false,"url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore","forks_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/forks","keys_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/teams","hooks_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/hooks","issue_events_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/issues/events{/number}","events_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/events","assignees_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/assignees{/user}","branches_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/branches{/branch}","tags_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/tags","blobs_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/languages","stargazers_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/stargazers","contributors_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/contributors","subscribers_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/subscribers","subscription_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/subscription","commits_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/contents/{+path}","compare_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/merges","archive_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/downloads","issues_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/issues{/number}","pulls_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/labels{/name}","releases_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/releases{/id}","deployments_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/deployments","created_at":"2013-08-15T10:24:01Z","updated_at":"2016-02-15T21:34:42Z","pushed_at":"2016-11-20T23:05:49Z","git_url":"git://github.com/cloudsoft/brooklyn-blockstore.git","ssh_url":"git@github.com:cloudsoft/brooklyn-blockstore.git","clone_url":"https://github.com/cloudsoft/brooklyn-blockstore.git","svn_url":"https://github.com/cloudsoft/brooklyn-blockstore","homepage":null,"size":195,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudsoft:master","ref":"master","sha":"2850bea0dba3e48053f48f1da213dd16ffda0284","user":{"login":"cloudsoft","id":831459,"avatar_url":"https://avatars.githubusercontent.com/u/831459?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudsoft","html_url":"https://github.com/cloudsoft","followers_url":"https://api.github.com/users/cloudsoft/followers","following_url":"https://api.github.com/users/cloudsoft/following{/other_user}","gists_url":"https://api.github.com/users/cloudsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudsoft/subscriptions","organizations_url":"https://api.github.com/users/cloudsoft/orgs","repos_url":"https://api.github.com/users/cloudsoft/repos","events_url":"https://api.github.com/users/cloudsoft/events{/privacy}","received_events_url":"https://api.github.com/users/cloudsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":12131992,"name":"brooklyn-blockstore","full_name":"cloudsoft/brooklyn-blockstore","owner":{"login":"cloudsoft","id":831459,"avatar_url":"https://avatars.githubusercontent.com/u/831459?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudsoft","html_url":"https://github.com/cloudsoft","followers_url":"https://api.github.com/users/cloudsoft/followers","following_url":"https://api.github.com/users/cloudsoft/following{/other_user}","gists_url":"https://api.github.com/users/cloudsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudsoft/subscriptions","organizations_url":"https://api.github.com/users/cloudsoft/orgs","repos_url":"https://api.github.com/users/cloudsoft/repos","events_url":"https://api.github.com/users/cloudsoft/events{/privacy}","received_events_url":"https://api.github.com/users/cloudsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudsoft/brooklyn-blockstore","description":"Cloud volumes abstraction","fork":false,"url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore","forks_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/forks","keys_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/teams","hooks_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/hooks","issue_events_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/issues/events{/number}","events_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/events","assignees_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/assignees{/user}","branches_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/branches{/branch}","tags_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/tags","blobs_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/languages","stargazers_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/stargazers","contributors_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/contributors","subscribers_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/subscribers","subscription_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/subscription","commits_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/contents/{+path}","compare_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/merges","archive_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/downloads","issues_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/issues{/number}","pulls_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/labels{/name}","releases_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/releases{/id}","deployments_url":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/deployments","created_at":"2013-08-15T10:24:01Z","updated_at":"2016-02-15T21:34:42Z","pushed_at":"2016-11-20T23:05:49Z","git_url":"git://github.com/cloudsoft/brooklyn-blockstore.git","ssh_url":"git@github.com:cloudsoft/brooklyn-blockstore.git","clone_url":"https://github.com/cloudsoft/brooklyn-blockstore.git","svn_url":"https://github.com/cloudsoft/brooklyn-blockstore","homepage":null,"size":195,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/8"},"html":{"href":"https://github.com/cloudsoft/brooklyn-blockstore/pull/8"},"issue":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/issues/8"},"comments":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-blockstore/statuses/6d30a969bc8c151a684fcd0aa1bc28fdd34cf886"}}}}
{"actor":{"display_login":"iyovcheva"}}