{"action":"created","comment":{"url":"https://api.github.com/repos/Jasig/email-preview/pulls/comments/86690718","pull_request_review_id":7335757,"id":86690718,"diff_hunk":"@@ -489,39 +713,56 @@ var jasig = jasig || {};\n                 anchor.attr(\"title\", that.options.jsMessages['deleteNotAvailableTitle']);\n                 that.locate(\"deleteMessageButton\").hide();\n             }\n-            that.locate(\"returnLink\").click(function(){ showEmailList(that); });\n+            /*that.locate(\"returnLink\").click(function(){ that.refresh(); // showEmailList(that);\n+                                               });*/\n+            that.locate(\"returnLink\").click(function(){ that.toggleSelectAndHideToolbar;removeActiveClassOnEmailList(); showEmailList(that);setTimeout(function(){ $('#content-middle-area').focus(); }, 200); });\n             that.locate(\"previousMsg\").click(function(){ displayMessage(that, this); });\n             that.locate(\"nextMsg\").click(function(){ displayMessage(that, this); });\n             that.locate(\"markMessageReadButton\").click(function(){ doToggleSeen(that.locate(\"messageForm\").serializeArray(), 'true'); });\n             that.locate(\"markMessageUnreadButton\").click(function(){ doToggleSeen(that.locate(\"messageForm\").serializeArray(), 'false'); });\n             that.locate(\"allFolders\").ready(function(){ getFoldersList();});\n-            that.locate(\"allFolders\").change(\n-            \tfunction(){\n+            that.locate(\"allFolders\").on(\"selected:folder:change\",\n+            \tfunction(event, param1){\n+                    //console.log(\"selectedButton = \"+ that.locate(\"selectedButton\").attr(\"data-quickselect-value\"));\n+                    //console.log(\"selectedFolder = \"+ param1);\n                     clearCache = \"true\";\n-\t            \tgetEmail(that, 0, that.options.batchSize, undefined, undefined,that.locate(\"allFolders\").val());\n+\t            \tgetEmail(that, 0, that.options.batchSize, undefined, undefined, param1);\n \t            \tlocation.reload();\n-            \t});             \n+            \t});    ","path":"src/main/webapp/js/email-browser.js","position":487,"original_position":487,"commit_id":"3a68f3413c79609733d7c2ab7d9c2977980302f3","original_commit_id":"3a68f3413c79609733d7c2ab7d9c2977980302f3","user":{"login":"ChristianMurphy","id":3107513,"avatar_url":"https://avatars.githubusercontent.com/u/3107513?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristianMurphy","html_url":"https://github.com/ChristianMurphy","followers_url":"https://api.github.com/users/ChristianMurphy/followers","following_url":"https://api.github.com/users/ChristianMurphy/following{/other_user}","gists_url":"https://api.github.com/users/ChristianMurphy/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianMurphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianMurphy/subscriptions","organizations_url":"https://api.github.com/users/ChristianMurphy/orgs","repos_url":"https://api.github.com/users/ChristianMurphy/repos","events_url":"https://api.github.com/users/ChristianMurphy/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianMurphy/received_events","type":"User","site_admin":false},"body":"🎨 remove trailing spaces","created_at":"2016-11-06T16:56:18Z","updated_at":"2016-11-06T16:58:58Z","html_url":"https://github.com/Jasig/email-preview/pull/70#discussion_r86690718","pull_request_url":"https://api.github.com/repos/Jasig/email-preview/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/Jasig/email-preview/pulls/comments/86690718"},"html":{"href":"https://github.com/Jasig/email-preview/pull/70#discussion_r86690718"},"pull_request":{"href":"https://api.github.com/repos/Jasig/email-preview/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/Jasig/email-preview/pulls/70","id":79379856,"html_url":"https://github.com/Jasig/email-preview/pull/70","diff_url":"https://github.com/Jasig/email-preview/pull/70.diff","patch_url":"https://github.com/Jasig/email-preview/pull/70.patch","issue_url":"https://api.github.com/repos/Jasig/email-preview/issues/70","number":70,"state":"open","locked":false,"title":"EMAILPLT-190 Refactor styles and update jQuery, jQuery UI and fluid","user":{"login":"cousquer","id":1481430,"avatar_url":"https://avatars.githubusercontent.com/u/1481430?v=3","gravatar_id":"","url":"https://api.github.com/users/cousquer","html_url":"https://github.com/cousquer","followers_url":"https://api.github.com/users/cousquer/followers","following_url":"https://api.github.com/users/cousquer/following{/other_user}","gists_url":"https://api.github.com/users/cousquer/gists{/gist_id}","starred_url":"https://api.github.com/users/cousquer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cousquer/subscriptions","organizations_url":"https://api.github.com/users/cousquer/orgs","repos_url":"https://api.github.com/users/cousquer/repos","events_url":"https://api.github.com/users/cousquer/events{/privacy}","received_events_url":"https://api.github.com/users/cousquer/received_events","type":"User","site_admin":false},"body":"**Refactoring of Email-preview Portlet and Library updates**\nmore informations and screencap at : \n[https://issues.jasig.org/browse/EMAILPLT-190](https://issues.jasig.org/browse/EMAILPLT-190)\n\n3 breackpoints : mobile, tablet, desktop\n- Double inner offcanvas Options&folder block (offcanvas1)- Emailmessages&toolbar&pagination bock - selected email block (offcanvas2)\n- fix select all-checkboxes checkbox\n- transform allFolder select into a list of button (with unread message badge) with Quick[select](MIT Licence) [https://github.com/eggboxio/quick-select](https://github.com/eggboxio/quick-select) - [http://quick-select.eggbox.io/](http://quick-select.eggbox.io/)\n- improvement in i18n and l10n\n- Accessibility improvements\n- keyboard navigation with tab, space and enter keys on windows and linux\n- update to fluid 1.4 -> done\n- update of jquery, jquery UI\n- use the same less mixin than uPortal less mixin -> it will be easy to update bootstrap to 4 and SASS or LESS, or change to Material\n\nThe update to fluid 1.5 is in progress (WIP). it will be in another PR after.\nThe implementation of mobile view in desktop multicolumns dashboard will be in another PR.\nThere 's a lot of Accessibility Improvements : keyboard navigation, aria attributes additions, etc.\nSome issues due to role=\"application\" added by fluid complicate the navigation for blind people on IOS iphone and Mac... (I'll try to fix them in another PR).\n\ntest ok with uPortal.4.4-snapshot with gmail and a linux webmail.\n\ntested on : \nIOS : safari FF, Chrome \nAndroid : chrome, FF \nWin10 : chrome, FF, safari, edge, ie11, ie10\nOSX : chrome, safari, FF\n","created_at":"2016-07-29T15:40:16Z","updated_at":"2016-11-06T16:58:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18d8ad90cfaca060707fad25cbe2cc4f1b56a36a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Jasig/email-preview/pulls/70/commits","review_comments_url":"https://api.github.com/repos/Jasig/email-preview/pulls/70/comments","review_comment_url":"https://api.github.com/repos/Jasig/email-preview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Jasig/email-preview/issues/70/comments","statuses_url":"https://api.github.com/repos/Jasig/email-preview/statuses/3a68f3413c79609733d7c2ab7d9c2977980302f3","head":{"label":"cousquer:EMAILPLT-190","ref":"EMAILPLT-190","sha":"3a68f3413c79609733d7c2ab7d9c2977980302f3","user":{"login":"cousquer","id":1481430,"avatar_url":"https://avatars.githubusercontent.com/u/1481430?v=3","gravatar_id":"","url":"https://api.github.com/users/cousquer","html_url":"https://github.com/cousquer","followers_url":"https://api.github.com/users/cousquer/followers","following_url":"https://api.github.com/users/cousquer/following{/other_user}","gists_url":"https://api.github.com/users/cousquer/gists{/gist_id}","starred_url":"https://api.github.com/users/cousquer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cousquer/subscriptions","organizations_url":"https://api.github.com/users/cousquer/orgs","repos_url":"https://api.github.com/users/cousquer/repos","events_url":"https://api.github.com/users/cousquer/events{/privacy}","received_events_url":"https://api.github.com/users/cousquer/received_events","type":"User","site_admin":false},"repo":{"id":64424191,"name":"email-preview","full_name":"cousquer/email-preview","owner":{"login":"cousquer","id":1481430,"avatar_url":"https://avatars.githubusercontent.com/u/1481430?v=3","gravatar_id":"","url":"https://api.github.com/users/cousquer","html_url":"https://github.com/cousquer","followers_url":"https://api.github.com/users/cousquer/followers","following_url":"https://api.github.com/users/cousquer/following{/other_user}","gists_url":"https://api.github.com/users/cousquer/gists{/gist_id}","starred_url":"https://api.github.com/users/cousquer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cousquer/subscriptions","organizations_url":"https://api.github.com/users/cousquer/orgs","repos_url":"https://api.github.com/users/cousquer/repos","events_url":"https://api.github.com/users/cousquer/events{/privacy}","received_events_url":"https://api.github.com/users/cousquer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cousquer/email-preview","description":null,"fork":true,"url":"https://api.github.com/repos/cousquer/email-preview","forks_url":"https://api.github.com/repos/cousquer/email-preview/forks","keys_url":"https://api.github.com/repos/cousquer/email-preview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cousquer/email-preview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cousquer/email-preview/teams","hooks_url":"https://api.github.com/repos/cousquer/email-preview/hooks","issue_events_url":"https://api.github.com/repos/cousquer/email-preview/issues/events{/number}","events_url":"https://api.github.com/repos/cousquer/email-preview/events","assignees_url":"https://api.github.com/repos/cousquer/email-preview/assignees{/user}","branches_url":"https://api.github.com/repos/cousquer/email-preview/branches{/branch}","tags_url":"https://api.github.com/repos/cousquer/email-preview/tags","blobs_url":"https://api.github.com/repos/cousquer/email-preview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cousquer/email-preview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cousquer/email-preview/git/refs{/sha}","trees_url":"https://api.github.com/repos/cousquer/email-preview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cousquer/email-preview/statuses/{sha}","languages_url":"https://api.github.com/repos/cousquer/email-preview/languages","stargazers_url":"https://api.github.com/repos/cousquer/email-preview/stargazers","contributors_url":"https://api.github.com/repos/cousquer/email-preview/contributors","subscribers_url":"https://api.github.com/repos/cousquer/email-preview/subscribers","subscription_url":"https://api.github.com/repos/cousquer/email-preview/subscription","commits_url":"https://api.github.com/repos/cousquer/email-preview/commits{/sha}","git_commits_url":"https://api.github.com/repos/cousquer/email-preview/git/commits{/sha}","comments_url":"https://api.github.com/repos/cousquer/email-preview/comments{/number}","issue_comment_url":"https://api.github.com/repos/cousquer/email-preview/issues/comments{/number}","contents_url":"https://api.github.com/repos/cousquer/email-preview/contents/{+path}","compare_url":"https://api.github.com/repos/cousquer/email-preview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cousquer/email-preview/merges","archive_url":"https://api.github.com/repos/cousquer/email-preview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cousquer/email-preview/downloads","issues_url":"https://api.github.com/repos/cousquer/email-preview/issues{/number}","pulls_url":"https://api.github.com/repos/cousquer/email-preview/pulls{/number}","milestones_url":"https://api.github.com/repos/cousquer/email-preview/milestones{/number}","notifications_url":"https://api.github.com/repos/cousquer/email-preview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cousquer/email-preview/labels{/name}","releases_url":"https://api.github.com/repos/cousquer/email-preview/releases{/id}","deployments_url":"https://api.github.com/repos/cousquer/email-preview/deployments","created_at":"2016-07-28T19:56:31Z","updated_at":"2016-07-28T19:56:33Z","pushed_at":"2016-09-15T07:20:51Z","git_url":"git://github.com/cousquer/email-preview.git","ssh_url":"git@github.com:cousquer/email-preview.git","clone_url":"https://github.com/cousquer/email-preview.git","svn_url":"https://github.com/cousquer/email-preview","homepage":"","size":1296,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Jasig:master","ref":"master","sha":"bdb4838c423a0d17f70673f0be2bba030dcc0fe0","user":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"repo":{"id":3722305,"name":"email-preview","full_name":"Jasig/email-preview","owner":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jasig/email-preview","description":null,"fork":false,"url":"https://api.github.com/repos/Jasig/email-preview","forks_url":"https://api.github.com/repos/Jasig/email-preview/forks","keys_url":"https://api.github.com/repos/Jasig/email-preview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jasig/email-preview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jasig/email-preview/teams","hooks_url":"https://api.github.com/repos/Jasig/email-preview/hooks","issue_events_url":"https://api.github.com/repos/Jasig/email-preview/issues/events{/number}","events_url":"https://api.github.com/repos/Jasig/email-preview/events","assignees_url":"https://api.github.com/repos/Jasig/email-preview/assignees{/user}","branches_url":"https://api.github.com/repos/Jasig/email-preview/branches{/branch}","tags_url":"https://api.github.com/repos/Jasig/email-preview/tags","blobs_url":"https://api.github.com/repos/Jasig/email-preview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jasig/email-preview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jasig/email-preview/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jasig/email-preview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jasig/email-preview/statuses/{sha}","languages_url":"https://api.github.com/repos/Jasig/email-preview/languages","stargazers_url":"https://api.github.com/repos/Jasig/email-preview/stargazers","contributors_url":"https://api.github.com/repos/Jasig/email-preview/contributors","subscribers_url":"https://api.github.com/repos/Jasig/email-preview/subscribers","subscription_url":"https://api.github.com/repos/Jasig/email-preview/subscription","commits_url":"https://api.github.com/repos/Jasig/email-preview/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jasig/email-preview/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jasig/email-preview/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jasig/email-preview/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jasig/email-preview/contents/{+path}","compare_url":"https://api.github.com/repos/Jasig/email-preview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jasig/email-preview/merges","archive_url":"https://api.github.com/repos/Jasig/email-preview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jasig/email-preview/downloads","issues_url":"https://api.github.com/repos/Jasig/email-preview/issues{/number}","pulls_url":"https://api.github.com/repos/Jasig/email-preview/pulls{/number}","milestones_url":"https://api.github.com/repos/Jasig/email-preview/milestones{/number}","notifications_url":"https://api.github.com/repos/Jasig/email-preview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jasig/email-preview/labels{/name}","releases_url":"https://api.github.com/repos/Jasig/email-preview/releases{/id}","deployments_url":"https://api.github.com/repos/Jasig/email-preview/deployments","created_at":"2012-03-14T21:02:46Z","updated_at":"2015-08-20T02:52:44Z","pushed_at":"2016-09-15T07:20:51Z","git_url":"git://github.com/Jasig/email-preview.git","ssh_url":"git@github.com:Jasig/email-preview.git","clone_url":"https://github.com/Jasig/email-preview.git","svn_url":"https://github.com/Jasig/email-preview","homepage":"","size":1554,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":4,"forks":18,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jasig/email-preview/pulls/70"},"html":{"href":"https://github.com/Jasig/email-preview/pull/70"},"issue":{"href":"https://api.github.com/repos/Jasig/email-preview/issues/70"},"comments":{"href":"https://api.github.com/repos/Jasig/email-preview/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/Jasig/email-preview/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/Jasig/email-preview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Jasig/email-preview/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/Jasig/email-preview/statuses/3a68f3413c79609733d7c2ab7d9c2977980302f3"}}}}
{"actor":{"display_login":"ChristianMurphy"}}