{"action":"closed","issue":{"url":"https://api.github.com/repos/spring-projects/spring-reactive/issues/72","repository_url":"https://api.github.com/repos/spring-projects/spring-reactive","labels_url":"https://api.github.com/repos/spring-projects/spring-reactive/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-reactive/issues/72/comments","events_url":"https://api.github.com/repos/spring-projects/spring-reactive/issues/72/events","html_url":"https://github.com/spring-projects/spring-reactive/issues/72","id":141812206,"number":72,"title":"Fix failing integration tests for Reactor and RxNetty","user":{"login":"poutsma","id":330665,"avatar_url":"https://avatars.githubusercontent.com/u/330665?v=3","gravatar_id":"","url":"https://api.github.com/users/poutsma","html_url":"https://github.com/poutsma","followers_url":"https://api.github.com/users/poutsma/followers","following_url":"https://api.github.com/users/poutsma/following{/other_user}","gists_url":"https://api.github.com/users/poutsma/gists{/gist_id}","starred_url":"https://api.github.com/users/poutsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poutsma/subscriptions","organizations_url":"https://api.github.com/users/poutsma/orgs","repos_url":"https://api.github.com/users/poutsma/repos","events_url":"https://api.github.com/users/poutsma/events{/privacy}","received_events_url":"https://api.github.com/users/poutsma/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"smaldini","id":76718,"avatar_url":"https://avatars.githubusercontent.com/u/76718?v=3","gravatar_id":"","url":"https://api.github.com/users/smaldini","html_url":"https://github.com/smaldini","followers_url":"https://api.github.com/users/smaldini/followers","following_url":"https://api.github.com/users/smaldini/following{/other_user}","gists_url":"https://api.github.com/users/smaldini/gists{/gist_id}","starred_url":"https://api.github.com/users/smaldini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaldini/subscriptions","organizations_url":"https://api.github.com/users/smaldini/orgs","repos_url":"https://api.github.com/users/smaldini/repos","events_url":"https://api.github.com/users/smaldini/events{/privacy}","received_events_url":"https://api.github.com/users/smaldini/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-03-18T09:14:38Z","updated_at":"2016-05-02T07:59:46Z","closed_at":"2016-05-02T07:59:46Z","body":"I've improved our integration tests so that they actually verify the request before sending out a response. Previously, the response was sent out without checking the request. See https://github.com/spring-projects/spring-reactive/commit/5803e381698a1a8288a1a892223b61eac2bb0de4\r\n\r\nUnfortunately this resulted in test failures in the `XmlHandlerIntegrationTests` and `RandomHandlerIntegrationTests`. I've ignored these test for Reactor/RxNetty by using an `assumeFalse`, as can be seen here, for instance: https://github.com/spring-projects/spring-reactive/commit/5803e381698a1a8288a1a892223b61eac2bb0de4#diff-aab430d73bebefc4cccd023d6ce6e3c0R63\r\n\r\nWe should fix our Reactor-netty and RxNetty support so that these tests succeed, as they do for our Servlet 3.1 and Undertow support."}}