{"push_id":989848360,"size":14,"distinct_size":2,"ref":"refs/heads/seclabels3","head":"a98aa2fbabd243932ba14371650564abfe05004d","before":"6f2022e311415291df586d2cb7ace47241ea925b","commits":[{"sha":"6dce0b3016e385a6ba51694c1e38ca6cde22c16b","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"cmdNetworkUpdate: Prefer VSH_EXCLUSIVE_OPTIONS over if-else tree\n\nWe have macros that check and reject mutually exclusive\nparameters to our commands. Use those instead of if-else tree.\nAt the same time, the variable @current becomes useless therefore\nit is dropped.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/6dce0b3016e385a6ba51694c1e38ca6cde22c16b"},{"sha":"4a3ae388baf286af8ea2c0d6c064ac45f05e11cb","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"cmdSaveImageEdit: Prefer VSH_EXCLUSIVE_OPTIONS over by hand check\n\nSince we have the macro there's no need for us to unwind it by\nhand and check for mutually exclusive flags ourselves.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/4a3ae388baf286af8ea2c0d6c064ac45f05e11cb"},{"sha":"dad0ae1c1f43dfa9e67a660ec9bfad1788f39d1a","author":{"email":"3ada0bee826c753786fdbba72243dfba997094cf@redhat.com","name":"Andrea Bolognani"},"message":"hostdev: Minor style adjustments\n\nMostly labels names and whitespace.\n\nNo functional changes.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/dad0ae1c1f43dfa9e67a660ec9bfad1788f39d1a"},{"sha":"8910ceaf1bd6782170188844abad4f2c4ff09e05","author":{"email":"39929b5b86d72d51fceac59b52303e3fe8a3083e@suse.com","name":"Jim Fehlig"},"message":"xenconfig: replace text 'xm' with 'xl' in xlconfigtest\n\nWhile at it, improve a few comments. No functional change.\n\nSigned-off-by: Jim Fehlig <jfehlig@suse.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/8910ceaf1bd6782170188844abad4f2c4ff09e05"},{"sha":"a44f1f85f96b443a7a6e02189d6f1f0c6b4a1dcf","author":{"email":"39929b5b86d72d51fceac59b52303e3fe8a3083e@suse.com","name":"Jim Fehlig"},"message":"xenconfig: produce key=value disk config syntax in xl formatter\n\nThe most formal form of xl disk configuration uses key=value\nsyntax to define each configuration item, e.g.\n\nformat=raw, vdev=xvda, access=rw, backendtype=phy, target=disksrc\n\nChange the xl disk formatter to produce this syntax, which allows\ntarget= to contain meta info needed to setup a network-based\ndisksrc (e.g. rbd, nbd, iscsi). For details on xl disk config\nformat, see  $xen-src/docs/misc/xl-disk-configuration.txt\n\nUpdate the disk config in the tests to use the formal syntax.\nBut add tests to ensure disks specified with the positional\nparameter syntax are correctly converted to <disk> XML.\n\nSigned-off-by: Jim Fehlig <jfehlig@suse.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/a44f1f85f96b443a7a6e02189d6f1f0c6b4a1dcf"},{"sha":"6604a3dd9f83cf2ff3686f2caba50bc06922f0f7","author":{"email":"39929b5b86d72d51fceac59b52303e3fe8a3083e@suse.com","name":"Jim Fehlig"},"message":"xenconfig: support xl<->xml conversion of rbd disk devices\n\nThe target= setting in xl disk configuration can be used to encode\nmeta info that is meaningful to a backend. Leverage this fact to\nsupport qdisk network disk types such as rbd. E.g. <disk> config\nsuch as\n\n   <disk type='network' device='disk'>\n     <driver name='qemu' type='raw'/>\n     <source protocol='rbd' name='pool/image'>\n       <host name='mon1.example.org' port='6321'/>\n       <host name='mon2.example.org' port='6322'/>\n       <host name='mon3.example.org' port='6322'/>\n     </source>\n     <target dev='hdb' bus='ide'/>\n     <address type='drive' controller='0' bus='0' target='0' unit='1'/>\n   </disk>\n\ncan be converted to the following xl config (and vice versa)\n\n  disk = [ \"format=raw,vdev=hdb,access=rw,backendtype=qdisk,\n            target=rbd:pool/image:auth_supported=none:mon_host=mon1.example.org\\\\:6321\\\\;mon2.example.org\\\\:6322\\\\;mon3.example.org\\\\:6322\"\n         ]\n\nNote that in xl disk config, a literal backslash in target= must\nbe escaped with a backslash. Conversion of <auth> config is not\nhandled in this patch, but can be done in a follow-up patch.\n\nAlso add a test for the conversions.\n\nSigned-off-by: Jim Fehlig <jfehlig@suse.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/6604a3dd9f83cf2ff3686f2caba50bc06922f0f7"},{"sha":"fb2bd208e52bda2d329b95d9545baa8bf04558af","author":{"email":"39929b5b86d72d51fceac59b52303e3fe8a3083e@suse.com","name":"Jim Fehlig"},"message":"libxl: add support for rbd qdisk\n\nxl/libxl already supports qemu's network-based block backends\nsuch as nbd and rbd. libvirt has supported configuring such\n<disk>s for long time too. This patch adds support for rbd\ndisks in the libxl driver by generating a rbd device URL from\nthe virDomainDiskDef object. The URL is passed to libxl via the\npdev_path field of libxl_device_disk struct. libxl then passes\nthe URL to qemu for cosumption by the rbd backend.\n\nSigned-off-by: Jim Fehlig <jfehlig@suse.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/fb2bd208e52bda2d329b95d9545baa8bf04558af"},{"sha":"73fc46511babab41d95a1717d56a355fd1d7393e","author":{"email":"3ada0bee826c753786fdbba72243dfba997094cf@redhat.com","name":"Andrea Bolognani"},"message":"tests: Fix typo oaque -> opaque\n\nNo functional changes.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/73fc46511babab41d95a1717d56a355fd1d7393e"},{"sha":"0f396a41595edd9107e1ffcb7c6bf49316bcc90b","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"docs: Try harder to uninstall\n\nImagine you have partially installed libvirt, or maybe you're\njust running 'make uninstall' from a different version than 'make\ninstall' has been ran. One way or another, we are doing plain\n'rm' instead of 'rm -f' and thus not trying hard enough when\nuninstalling. In the rest of our code we stick with -f switch. Do\nthat for docs too.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/0f396a41595edd9107e1ffcb7c6bf49316bcc90b"},{"sha":"a0e5faaf66a185966ea8656799ead4703675a233","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"vbox: Avoid signed and unsigned comparison\n\nAfter 457ff97fa there are two defects in our code. In both of\nthem we use a signed variable to hold up a number of snapshots\nthat domain has. We use a helper function to count the number.\nHowever, the helper function may fail in which case it returns\na negative one and control jumps to cleanup label where an\nunsigned variable is used to iterate over array of snapshots. The\nloop condition thus compare signed and unsigned variables which\nin this specific case ends up badly for us.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/a0e5faaf66a185966ea8656799ead4703675a233"},{"sha":"e0392f5a747dc771808086a3cc0f940b9287eaf5","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"xen: Check return value of virStringReplace\n\nAfter 6604a3dd9f8 in which new helper function has been\nintroduced, the code calls virStringReplace and dereference the\nresult immediately. The string function can, however, return NULL\nso this would SIGSEGV right away. Check for the return value of\nthe string function.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/e0392f5a747dc771808086a3cc0f940b9287eaf5"},{"sha":"01c318529804929c54f6817517cb044c7173f950","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"qemuBuildCommandLine: Change the condition for -nographics\n\nThere's this check when building command line that whenever\ndomain has no graphics card configured we put -nographics onto\nqemu command line. The check is 'if (!def->graphics)'. This\nmakes coverity think that def->graphics can be NULL, which is\ntrue. But later in the code every access to def->graphics is\nguarded by check for def->ngraphics, so no crash occurs. But this\nis something that coverity fails to deduct.\nIn order to shut coverity up lets change the condition to\n'if (!def->ngraphics)'.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/01c318529804929c54f6817517cb044c7173f950"},{"sha":"2972d1751d784c33ab891637519a0276f93af738","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"lock_protocol: Add two new remote procedures\n\nThese procedures will be used to store and bring back security\nlabels. So far, the idea is that tuple (path, model, label) is\nenough. Well, certainly for DAC and SELinux. The functions are:\n\n  VIR_LOCK_SPACE_PROTOCOL_PROC_REMEMBER_SECLABEL\n  VIR_LOCK_SPACE_PROTOCOL_PROC_RECALL_SECLABEL\n\nYeah, they really need that VIR_LOCK_SPACE_PROTOCOL_PROC prefix\ndue to way we call gendispatch.pl.\n\nSo the former will take the whole tuple and remember it. The\nlatter will then take just pair of (path, model) and return label\nstored previously. Moreover, the return value of recall will be\nimportant: value greater than zero means @path is still in use,\ndon't relabel it. Value of zero means @path is no longer used,\nand a negative value means an error (e.g. @path not found, OOM,\netc.).\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/2972d1751d784c33ab891637519a0276f93af738"},{"sha":"a98aa2fbabd243932ba14371650564abfe05004d","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"locking: Introduce virSeclabelSpace\n\nThis module will handle all the security label remembering and\nrecalling for virlockd. We need to record a tuple of (path,\nsecurity model, security label). So I'm going with a hash table,\nwhere @path would be the key, and tuple of (model, label) is\ngoing to be the payload. Well, the payload tuple is wrapped into\nself inflating array (virSeclabelSpaceLabels). So for each path,\nwe will have to traverse through array of various models to find\nthe needed one. But since there's gonna be many paths and just a\nfew security models, it's going to be the best approach.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/a98aa2fbabd243932ba14371650564abfe05004d"}]}