{"action":"closed","number":43,"pull_request":{"url":"https://api.github.com/repos/BrewPi/firmware/pulls/43","id":58233349,"html_url":"https://github.com/BrewPi/firmware/pull/43","diff_url":"https://github.com/BrewPi/firmware/pull/43.diff","patch_url":"https://github.com/BrewPi/firmware/pull/43.patch","issue_url":"https://api.github.com/repos/BrewPi/firmware/issues/43","number":43,"state":"closed","locked":false,"title":"Feature/app lib separation","user":{"login":"m-mcgowan","id":2465470,"avatar_url":"https://avatars.githubusercontent.com/u/2465470?v=3","gravatar_id":"","url":"https://api.github.com/users/m-mcgowan","html_url":"https://github.com/m-mcgowan","followers_url":"https://api.github.com/users/m-mcgowan/followers","following_url":"https://api.github.com/users/m-mcgowan/following{/other_user}","gists_url":"https://api.github.com/users/m-mcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/m-mcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-mcgowan/subscriptions","organizations_url":"https://api.github.com/users/m-mcgowan/orgs","repos_url":"https://api.github.com/users/m-mcgowan/repos","events_url":"https://api.github.com/users/m-mcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/m-mcgowan/received_events","type":"User","site_admin":false},"body":"separates application and library responsibilities. a bit of hacking so will need revisiting, particularly replacing use of object pointers to object references which will allow more implicit conversion from app types to library types. \r\n\r\nsaves 492 bytes. :-/\r\n\r\n\r\nUntested, probably needs debugging since the unit tests segfault. I'll need convincing that the restructing and increase in complexity is worth it. ","created_at":"2016-02-04T02:29:39Z","updated_at":"2016-02-14T06:58:23Z","closed_at":"2016-02-14T06:58:23Z","merged_at":null,"merge_commit_sha":"735d28ef182221c19a2600840de65b3bdfa86854","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BrewPi/firmware/pulls/43/commits","review_comments_url":"https://api.github.com/repos/BrewPi/firmware/pulls/43/comments","review_comment_url":"https://api.github.com/repos/BrewPi/firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BrewPi/firmware/issues/43/comments","statuses_url":"https://api.github.com/repos/BrewPi/firmware/statuses/8288cef21ff78e1044845ae279142468a5bbd844","head":{"label":"BrewPi:feature/app-lib-separation","ref":"feature/app-lib-separation","sha":"8288cef21ff78e1044845ae279142468a5bbd844","user":{"login":"BrewPi","id":2395822,"avatar_url":"https://avatars.githubusercontent.com/u/2395822?v=3","gravatar_id":"","url":"https://api.github.com/users/BrewPi","html_url":"https://github.com/BrewPi","followers_url":"https://api.github.com/users/BrewPi/followers","following_url":"https://api.github.com/users/BrewPi/following{/other_user}","gists_url":"https://api.github.com/users/BrewPi/gists{/gist_id}","starred_url":"https://api.github.com/users/BrewPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrewPi/subscriptions","organizations_url":"https://api.github.com/users/BrewPi/orgs","repos_url":"https://api.github.com/users/BrewPi/repos","events_url":"https://api.github.com/users/BrewPi/events{/privacy}","received_events_url":"https://api.github.com/users/BrewPi/received_events","type":"Organization","site_admin":false},"repo":{"id":28893057,"name":"firmware","full_name":"BrewPi/firmware","owner":{"login":"BrewPi","id":2395822,"avatar_url":"https://avatars.githubusercontent.com/u/2395822?v=3","gravatar_id":"","url":"https://api.github.com/users/BrewPi","html_url":"https://github.com/BrewPi","followers_url":"https://api.github.com/users/BrewPi/followers","following_url":"https://api.github.com/users/BrewPi/following{/other_user}","gists_url":"https://api.github.com/users/BrewPi/gists{/gist_id}","starred_url":"https://api.github.com/users/BrewPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrewPi/subscriptions","organizations_url":"https://api.github.com/users/BrewPi/orgs","repos_url":"https://api.github.com/users/BrewPi/repos","events_url":"https://api.github.com/users/BrewPi/events{/privacy}","received_events_url":"https://api.github.com/users/BrewPi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BrewPi/firmware","description":"Brewing temperature control firmware for Spark Core and Arduino","fork":false,"url":"https://api.github.com/repos/BrewPi/firmware","forks_url":"https://api.github.com/repos/BrewPi/firmware/forks","keys_url":"https://api.github.com/repos/BrewPi/firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrewPi/firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrewPi/firmware/teams","hooks_url":"https://api.github.com/repos/BrewPi/firmware/hooks","issue_events_url":"https://api.github.com/repos/BrewPi/firmware/issues/events{/number}","events_url":"https://api.github.com/repos/BrewPi/firmware/events","assignees_url":"https://api.github.com/repos/BrewPi/firmware/assignees{/user}","branches_url":"https://api.github.com/repos/BrewPi/firmware/branches{/branch}","tags_url":"https://api.github.com/repos/BrewPi/firmware/tags","blobs_url":"https://api.github.com/repos/BrewPi/firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrewPi/firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrewPi/firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrewPi/firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrewPi/firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/BrewPi/firmware/languages","stargazers_url":"https://api.github.com/repos/BrewPi/firmware/stargazers","contributors_url":"https://api.github.com/repos/BrewPi/firmware/contributors","subscribers_url":"https://api.github.com/repos/BrewPi/firmware/subscribers","subscription_url":"https://api.github.com/repos/BrewPi/firmware/subscription","commits_url":"https://api.github.com/repos/BrewPi/firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrewPi/firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrewPi/firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrewPi/firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrewPi/firmware/contents/{+path}","compare_url":"https://api.github.com/repos/BrewPi/firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrewPi/firmware/merges","archive_url":"https://api.github.com/repos/BrewPi/firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrewPi/firmware/downloads","issues_url":"https://api.github.com/repos/BrewPi/firmware/issues{/number}","pulls_url":"https://api.github.com/repos/BrewPi/firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/BrewPi/firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/BrewPi/firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrewPi/firmware/labels{/name}","releases_url":"https://api.github.com/repos/BrewPi/firmware/releases{/id}","deployments_url":"https://api.github.com/repos/BrewPi/firmware/deployments","created_at":"2015-01-07T01:52:02Z","updated_at":"2016-01-03T23:45:37Z","pushed_at":"2016-02-14T06:50:25Z","git_url":"git://github.com/BrewPi/firmware.git","ssh_url":"git@github.com:BrewPi/firmware.git","clone_url":"https://github.com/BrewPi/firmware.git","svn_url":"https://github.com/BrewPi/firmware","homepage":"http://www.brewpi.com","size":19706,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":17,"forks":26,"open_issues":17,"watchers":19,"default_branch":"master"}},"base":{"label":"BrewPi:develop","ref":"develop","sha":"76c83d2f203416d3d91f51318f6ce716cf801718","user":{"login":"BrewPi","id":2395822,"avatar_url":"https://avatars.githubusercontent.com/u/2395822?v=3","gravatar_id":"","url":"https://api.github.com/users/BrewPi","html_url":"https://github.com/BrewPi","followers_url":"https://api.github.com/users/BrewPi/followers","following_url":"https://api.github.com/users/BrewPi/following{/other_user}","gists_url":"https://api.github.com/users/BrewPi/gists{/gist_id}","starred_url":"https://api.github.com/users/BrewPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrewPi/subscriptions","organizations_url":"https://api.github.com/users/BrewPi/orgs","repos_url":"https://api.github.com/users/BrewPi/repos","events_url":"https://api.github.com/users/BrewPi/events{/privacy}","received_events_url":"https://api.github.com/users/BrewPi/received_events","type":"Organization","site_admin":false},"repo":{"id":28893057,"name":"firmware","full_name":"BrewPi/firmware","owner":{"login":"BrewPi","id":2395822,"avatar_url":"https://avatars.githubusercontent.com/u/2395822?v=3","gravatar_id":"","url":"https://api.github.com/users/BrewPi","html_url":"https://github.com/BrewPi","followers_url":"https://api.github.com/users/BrewPi/followers","following_url":"https://api.github.com/users/BrewPi/following{/other_user}","gists_url":"https://api.github.com/users/BrewPi/gists{/gist_id}","starred_url":"https://api.github.com/users/BrewPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrewPi/subscriptions","organizations_url":"https://api.github.com/users/BrewPi/orgs","repos_url":"https://api.github.com/users/BrewPi/repos","events_url":"https://api.github.com/users/BrewPi/events{/privacy}","received_events_url":"https://api.github.com/users/BrewPi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BrewPi/firmware","description":"Brewing temperature control firmware for Spark Core and Arduino","fork":false,"url":"https://api.github.com/repos/BrewPi/firmware","forks_url":"https://api.github.com/repos/BrewPi/firmware/forks","keys_url":"https://api.github.com/repos/BrewPi/firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrewPi/firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrewPi/firmware/teams","hooks_url":"https://api.github.com/repos/BrewPi/firmware/hooks","issue_events_url":"https://api.github.com/repos/BrewPi/firmware/issues/events{/number}","events_url":"https://api.github.com/repos/BrewPi/firmware/events","assignees_url":"https://api.github.com/repos/BrewPi/firmware/assignees{/user}","branches_url":"https://api.github.com/repos/BrewPi/firmware/branches{/branch}","tags_url":"https://api.github.com/repos/BrewPi/firmware/tags","blobs_url":"https://api.github.com/repos/BrewPi/firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrewPi/firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrewPi/firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrewPi/firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrewPi/firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/BrewPi/firmware/languages","stargazers_url":"https://api.github.com/repos/BrewPi/firmware/stargazers","contributors_url":"https://api.github.com/repos/BrewPi/firmware/contributors","subscribers_url":"https://api.github.com/repos/BrewPi/firmware/subscribers","subscription_url":"https://api.github.com/repos/BrewPi/firmware/subscription","commits_url":"https://api.github.com/repos/BrewPi/firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrewPi/firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrewPi/firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrewPi/firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrewPi/firmware/contents/{+path}","compare_url":"https://api.github.com/repos/BrewPi/firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrewPi/firmware/merges","archive_url":"https://api.github.com/repos/BrewPi/firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrewPi/firmware/downloads","issues_url":"https://api.github.com/repos/BrewPi/firmware/issues{/number}","pulls_url":"https://api.github.com/repos/BrewPi/firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/BrewPi/firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/BrewPi/firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrewPi/firmware/labels{/name}","releases_url":"https://api.github.com/repos/BrewPi/firmware/releases{/id}","deployments_url":"https://api.github.com/repos/BrewPi/firmware/deployments","created_at":"2015-01-07T01:52:02Z","updated_at":"2016-01-03T23:45:37Z","pushed_at":"2016-02-14T06:50:25Z","git_url":"git://github.com/BrewPi/firmware.git","ssh_url":"git@github.com:BrewPi/firmware.git","clone_url":"https://github.com/BrewPi/firmware.git","svn_url":"https://github.com/BrewPi/firmware","homepage":"http://www.brewpi.com","size":19706,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":17,"forks":26,"open_issues":17,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BrewPi/firmware/pulls/43"},"html":{"href":"https://github.com/BrewPi/firmware/pull/43"},"issue":{"href":"https://api.github.com/repos/BrewPi/firmware/issues/43"},"comments":{"href":"https://api.github.com/repos/BrewPi/firmware/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/BrewPi/firmware/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/BrewPi/firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BrewPi/firmware/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/BrewPi/firmware/statuses/8288cef21ff78e1044845ae279142468a5bbd844"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":4,"additions":1182,"deletions":690,"changed_files":89}}