{"action":"created","issue":{"url":"https://api.github.com/repos/driftyco/ionic-package-hooks/issues/10","repository_url":"https://api.github.com/repos/driftyco/ionic-package-hooks","labels_url":"https://api.github.com/repos/driftyco/ionic-package-hooks/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/driftyco/ionic-package-hooks/issues/10/comments","events_url":"https://api.github.com/repos/driftyco/ionic-package-hooks/issues/10/events","html_url":"https://github.com/driftyco/ionic-package-hooks/pull/10","id":136848018,"number":10,"title":"Dloprodu","user":{"login":"dloprodu","id":664947,"avatar_url":"https://avatars.githubusercontent.com/u/664947?v=3","gravatar_id":"","url":"https://api.github.com/users/dloprodu","html_url":"https://github.com/dloprodu","followers_url":"https://api.github.com/users/dloprodu/followers","following_url":"https://api.github.com/users/dloprodu/following{/other_user}","gists_url":"https://api.github.com/users/dloprodu/gists{/gist_id}","starred_url":"https://api.github.com/users/dloprodu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dloprodu/subscriptions","organizations_url":"https://api.github.com/users/dloprodu/orgs","repos_url":"https://api.github.com/users/dloprodu/repos","events_url":"https://api.github.com/users/dloprodu/events{/privacy}","received_events_url":"https://api.github.com/users/dloprodu/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"dwieeb","id":236501,"avatar_url":"https://avatars.githubusercontent.com/u/236501?v=3","gravatar_id":"","url":"https://api.github.com/users/dwieeb","html_url":"https://github.com/dwieeb","followers_url":"https://api.github.com/users/dwieeb/followers","following_url":"https://api.github.com/users/dwieeb/following{/other_user}","gists_url":"https://api.github.com/users/dwieeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dwieeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwieeb/subscriptions","organizations_url":"https://api.github.com/users/dwieeb/orgs","repos_url":"https://api.github.com/users/dwieeb/repos","events_url":"https://api.github.com/users/dwieeb/events{/privacy}","received_events_url":"https://api.github.com/users/dwieeb/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-02-26T23:56:48Z","updated_at":"2016-03-12T00:13:25Z","closed_at":"2016-03-12T00:13:25Z","pull_request":{"url":"https://api.github.com/repos/driftyco/ionic-package-hooks/pulls/10","html_url":"https://github.com/driftyco/ionic-package-hooks/pull/10","diff_url":"https://github.com/driftyco/ionic-package-hooks/pull/10.diff","patch_url":"https://github.com/driftyco/ionic-package-hooks/pull/10.patch"},"body":"It would be possible adding this script (build_minimize.js) that allow to minimize a typical ionic app.\r\nProcess:\r\n1. compress index.html\r\n2. minimizes css, images, html and js\r\n3. updates index.html\r\n4. removes unnecessary folders and files "},"comment":{"url":"https://api.github.com/repos/driftyco/ionic-package-hooks/issues/comments/195611923","html_url":"https://github.com/driftyco/ionic-package-hooks/pull/10#issuecomment-195611923","issue_url":"https://api.github.com/repos/driftyco/ionic-package-hooks/issues/10","id":195611923,"user":{"login":"dwieeb","id":236501,"avatar_url":"https://avatars.githubusercontent.com/u/236501?v=3","gravatar_id":"","url":"https://api.github.com/users/dwieeb","html_url":"https://github.com/dwieeb","followers_url":"https://api.github.com/users/dwieeb/followers","following_url":"https://api.github.com/users/dwieeb/following{/other_user}","gists_url":"https://api.github.com/users/dwieeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dwieeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwieeb/subscriptions","organizations_url":"https://api.github.com/users/dwieeb/orgs","repos_url":"https://api.github.com/users/dwieeb/repos","events_url":"https://api.github.com/users/dwieeb/events{/privacy}","received_events_url":"https://api.github.com/users/dwieeb/received_events","type":"User","site_admin":false},"created_at":"2016-03-12T00:13:25Z","updated_at":"2016-03-12T00:13:25Z","body":"@dloprodu Unfortunately we may have to hold off on this feature. It is a much larger task than I anticipated when I asked you to make a PR, and I apologize.\r\n\r\nWe're in the middle of a shift at Ionic to improve quality and part of that means standardizing the way things are done. I can't accept this PR because it assumes too much about project structure and preferences. The CLI is getting a config overhaul which I intend to use in Ionic Package as well as the other services. Right now this takes on too many dependencies for these hooks and I'd like a lot of thought put into how minification services can be added for all sorts of Ionic projects. Basically, I think Ionic should do this.\r\n\r\nAs a side note, when you copy and modify [someone else's code](https://github.com/rossmartin/cordova-uglify), it's common courtesy to give them credit as the original author."}}