{"action":"created","comment":{"url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/comments/83972361","pull_request_review_id":4780796,"id":83972361,"diff_hunk":"@@ -1 +1,63 @@\n-# PlyIO\n+# Ply polygon file IO\n+\n+**PlyIO** is a package for reading and writing data in the\n+[Ply](http://paulbourke.net/dataformats/ply/) polygon file format, also called\n+the Stanford triangle format.\n+\n+## Quick start\n+\n+Here's an example of how to write a basic ply file containing random triangles\n+and edges:\n+\n+```julia\n+using PlyIO\n+\n+ply = Ply()\n+push!(ply, PlyComment(\"An example ply file\"))\n+\n+nverts = 1000\n+\n+# Random vertices with position and color\n+vertex = PlyElement(\"vertex\",","path":"README.md","position":22,"original_position":22,"commit_id":"7e01cc561c0ae6d11540bae11652d4309d5bb84b","original_commit_id":"7e01cc561c0ae6d11540bae11652d4309d5bb84b","user":{"login":"andyferris","id":2974526,"avatar_url":"https://avatars.githubusercontent.com/u/2974526?v=3","gravatar_id":"","url":"https://api.github.com/users/andyferris","html_url":"https://github.com/andyferris","followers_url":"https://api.github.com/users/andyferris/followers","following_url":"https://api.github.com/users/andyferris/following{/other_user}","gists_url":"https://api.github.com/users/andyferris/gists{/gist_id}","starred_url":"https://api.github.com/users/andyferris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyferris/subscriptions","organizations_url":"https://api.github.com/users/andyferris/orgs","repos_url":"https://api.github.com/users/andyferris/repos","events_url":"https://api.github.com/users/andyferris/events{/privacy}","received_events_url":"https://api.github.com/users/andyferris/received_events","type":"User","site_admin":false},"body":"Right. I'm not sure either. It probably made most sense the first way you had it. What do you think? \r\n\r\nThe only other question I had was why `ArrayProperty` instead of `Property`, to match the file format? Is \"Array\" a Ply concept?","created_at":"2016-10-18T23:29:14Z","updated_at":"2016-10-18T23:29:14Z","html_url":"https://github.com/FugroRoames/PlyIO.jl/pull/1#discussion_r83972361","pull_request_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/comments/83972361"},"html":{"href":"https://github.com/FugroRoames/PlyIO.jl/pull/1#discussion_r83972361"},"pull_request":{"href":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/1","id":88975962,"html_url":"https://github.com/FugroRoames/PlyIO.jl/pull/1","diff_url":"https://github.com/FugroRoames/PlyIO.jl/pull/1.diff","patch_url":"https://github.com/FugroRoames/PlyIO.jl/pull/1.patch","issue_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/issues/1","number":1,"state":"open","locked":false,"title":"RFC: Initial version of PlyIO","user":{"login":"c42f","id":601473,"avatar_url":"https://avatars.githubusercontent.com/u/601473?v=3","gravatar_id":"","url":"https://api.github.com/users/c42f","html_url":"https://github.com/c42f","followers_url":"https://api.github.com/users/c42f/followers","following_url":"https://api.github.com/users/c42f/following{/other_user}","gists_url":"https://api.github.com/users/c42f/gists{/gist_id}","starred_url":"https://api.github.com/users/c42f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c42f/subscriptions","organizations_url":"https://api.github.com/users/c42f/orgs","repos_url":"https://api.github.com/users/c42f/repos","events_url":"https://api.github.com/users/c42f/events{/privacy}","received_events_url":"https://api.github.com/users/c42f/received_events","type":"User","site_admin":false},"body":"Hi all,\r\n\r\nI've spruced up a generic ply writer I was using for some experiments and made an API which is hopefully somewhat OK to use.  The design goals were to have a flexible generic reader and writer (ie, not specific to geometry), which is also very efficient for the kind of ply I want to write for Displaz.jl.  You can see the simple README here:\r\n\r\nhttps://github.com/FugroRoames/PlyIO.jl/tree/initial-code\r\n\r\nComments on the overall design and API are most welcome (to get a taste, see the README).  The API could be streamlined, but I'm assuming this package will be used mostly as infrastructure so it might not matter that it's a bit verbose.  \r\n\r\n@OmriRoames @awbsmith @janzill @JoshChristie @andyferris - if some subset of you want to take a quick browse that would be great. This is by no means a critical package so feel free to ignore this PR, in which case I'll just merge as-is in a few days ;-)","created_at":"2016-10-12T08:48:45Z","updated_at":"2016-10-18T23:29:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad9b5861437e3135fb6186ff2d93105cd80be709","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/1/commits","review_comments_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/1/comments","review_comment_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/issues/1/comments","statuses_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/statuses/7e01cc561c0ae6d11540bae11652d4309d5bb84b","head":{"label":"FugroRoames:initial-code","ref":"initial-code","sha":"7e01cc561c0ae6d11540bae11652d4309d5bb84b","user":{"login":"FugroRoames","id":7897460,"avatar_url":"https://avatars.githubusercontent.com/u/7897460?v=3","gravatar_id":"","url":"https://api.github.com/users/FugroRoames","html_url":"https://github.com/FugroRoames","followers_url":"https://api.github.com/users/FugroRoames/followers","following_url":"https://api.github.com/users/FugroRoames/following{/other_user}","gists_url":"https://api.github.com/users/FugroRoames/gists{/gist_id}","starred_url":"https://api.github.com/users/FugroRoames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FugroRoames/subscriptions","organizations_url":"https://api.github.com/users/FugroRoames/orgs","repos_url":"https://api.github.com/users/FugroRoames/repos","events_url":"https://api.github.com/users/FugroRoames/events{/privacy}","received_events_url":"https://api.github.com/users/FugroRoames/received_events","type":"Organization","site_admin":false},"repo":{"id":70383745,"name":"PlyIO.jl","full_name":"FugroRoames/PlyIO.jl","owner":{"login":"FugroRoames","id":7897460,"avatar_url":"https://avatars.githubusercontent.com/u/7897460?v=3","gravatar_id":"","url":"https://api.github.com/users/FugroRoames","html_url":"https://github.com/FugroRoames","followers_url":"https://api.github.com/users/FugroRoames/followers","following_url":"https://api.github.com/users/FugroRoames/following{/other_user}","gists_url":"https://api.github.com/users/FugroRoames/gists{/gist_id}","starred_url":"https://api.github.com/users/FugroRoames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FugroRoames/subscriptions","organizations_url":"https://api.github.com/users/FugroRoames/orgs","repos_url":"https://api.github.com/users/FugroRoames/repos","events_url":"https://api.github.com/users/FugroRoames/events{/privacy}","received_events_url":"https://api.github.com/users/FugroRoames/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FugroRoames/PlyIO.jl","description":"Read and write polygon ply files from julia","fork":false,"url":"https://api.github.com/repos/FugroRoames/PlyIO.jl","forks_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/forks","keys_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/teams","hooks_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/hooks","issue_events_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/issues/events{/number}","events_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/events","assignees_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/assignees{/user}","branches_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/branches{/branch}","tags_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/tags","blobs_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/languages","stargazers_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/stargazers","contributors_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/contributors","subscribers_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/subscribers","subscription_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/subscription","commits_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/contents/{+path}","compare_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/merges","archive_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/downloads","issues_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/issues{/number}","pulls_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/labels{/name}","releases_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/releases{/id}","deployments_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/deployments","created_at":"2016-10-09T06:59:37Z","updated_at":"2016-10-10T00:01:47Z","pushed_at":"2016-10-18T21:50:01Z","git_url":"git://github.com/FugroRoames/PlyIO.jl.git","ssh_url":"git@github.com:FugroRoames/PlyIO.jl.git","clone_url":"https://github.com/FugroRoames/PlyIO.jl.git","svn_url":"https://github.com/FugroRoames/PlyIO.jl","homepage":null,"size":126,"stargazers_count":1,"watchers_count":1,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"FugroRoames:master","ref":"master","sha":"c5c36b8230f64548ab42e53370d488853fc37e11","user":{"login":"FugroRoames","id":7897460,"avatar_url":"https://avatars.githubusercontent.com/u/7897460?v=3","gravatar_id":"","url":"https://api.github.com/users/FugroRoames","html_url":"https://github.com/FugroRoames","followers_url":"https://api.github.com/users/FugroRoames/followers","following_url":"https://api.github.com/users/FugroRoames/following{/other_user}","gists_url":"https://api.github.com/users/FugroRoames/gists{/gist_id}","starred_url":"https://api.github.com/users/FugroRoames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FugroRoames/subscriptions","organizations_url":"https://api.github.com/users/FugroRoames/orgs","repos_url":"https://api.github.com/users/FugroRoames/repos","events_url":"https://api.github.com/users/FugroRoames/events{/privacy}","received_events_url":"https://api.github.com/users/FugroRoames/received_events","type":"Organization","site_admin":false},"repo":{"id":70383745,"name":"PlyIO.jl","full_name":"FugroRoames/PlyIO.jl","owner":{"login":"FugroRoames","id":7897460,"avatar_url":"https://avatars.githubusercontent.com/u/7897460?v=3","gravatar_id":"","url":"https://api.github.com/users/FugroRoames","html_url":"https://github.com/FugroRoames","followers_url":"https://api.github.com/users/FugroRoames/followers","following_url":"https://api.github.com/users/FugroRoames/following{/other_user}","gists_url":"https://api.github.com/users/FugroRoames/gists{/gist_id}","starred_url":"https://api.github.com/users/FugroRoames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FugroRoames/subscriptions","organizations_url":"https://api.github.com/users/FugroRoames/orgs","repos_url":"https://api.github.com/users/FugroRoames/repos","events_url":"https://api.github.com/users/FugroRoames/events{/privacy}","received_events_url":"https://api.github.com/users/FugroRoames/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FugroRoames/PlyIO.jl","description":"Read and write polygon ply files from julia","fork":false,"url":"https://api.github.com/repos/FugroRoames/PlyIO.jl","forks_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/forks","keys_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/teams","hooks_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/hooks","issue_events_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/issues/events{/number}","events_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/events","assignees_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/assignees{/user}","branches_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/branches{/branch}","tags_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/tags","blobs_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/languages","stargazers_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/stargazers","contributors_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/contributors","subscribers_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/subscribers","subscription_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/subscription","commits_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/contents/{+path}","compare_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/merges","archive_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/downloads","issues_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/issues{/number}","pulls_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/labels{/name}","releases_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/releases{/id}","deployments_url":"https://api.github.com/repos/FugroRoames/PlyIO.jl/deployments","created_at":"2016-10-09T06:59:37Z","updated_at":"2016-10-10T00:01:47Z","pushed_at":"2016-10-18T21:50:01Z","git_url":"git://github.com/FugroRoames/PlyIO.jl.git","ssh_url":"git@github.com:FugroRoames/PlyIO.jl.git","clone_url":"https://github.com/FugroRoames/PlyIO.jl.git","svn_url":"https://github.com/FugroRoames/PlyIO.jl","homepage":null,"size":126,"stargazers_count":1,"watchers_count":1,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/1"},"html":{"href":"https://github.com/FugroRoames/PlyIO.jl/pull/1"},"issue":{"href":"https://api.github.com/repos/FugroRoames/PlyIO.jl/issues/1"},"comments":{"href":"https://api.github.com/repos/FugroRoames/PlyIO.jl/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FugroRoames/PlyIO.jl/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/FugroRoames/PlyIO.jl/statuses/7e01cc561c0ae6d11540bae11652d4309d5bb84b"}}}}
{"actor":{"display_login":"andyferris"}}