{"action":"created","issue":{"url":"https://api.github.com/repos/geowarin/boot-react/issues/26","repository_url":"https://api.github.com/repos/geowarin/boot-react","labels_url":"https://api.github.com/repos/geowarin/boot-react/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/geowarin/boot-react/issues/26/comments","events_url":"https://api.github.com/repos/geowarin/boot-react/issues/26/events","html_url":"https://github.com/geowarin/boot-react/issues/26","id":166324926,"number":26,"title":"Missing resources resolution","user":{"login":"Opalo","id":1519236,"avatar_url":"https://avatars.githubusercontent.com/u/1519236?v=3","gravatar_id":"","url":"https://api.github.com/users/Opalo","html_url":"https://github.com/Opalo","followers_url":"https://api.github.com/users/Opalo/followers","following_url":"https://api.github.com/users/Opalo/following{/other_user}","gists_url":"https://api.github.com/users/Opalo/gists{/gist_id}","starred_url":"https://api.github.com/users/Opalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opalo/subscriptions","organizations_url":"https://api.github.com/users/Opalo/orgs","repos_url":"https://api.github.com/users/Opalo/repos","events_url":"https://api.github.com/users/Opalo/events{/privacy}","received_events_url":"https://api.github.com/users/Opalo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-19T12:58:51Z","updated_at":"2016-07-26T12:05:12Z","closed_at":null,"body":"Hi,\r\n\r\nFirst of all, great job! Thanks!\r\n\r\nI've question regarding missing resources resolution, [SinglePageAppConfig](https://github.com/geowarin/boot-react/blob/master/backend/src/main/java/react/config/SinglePageAppConfig.java) class in particular.\r\n\r\nFirst of all, please replace `orElseGet(null)` with `orElse(null)`. `orElseGet` will throw NPE when null is passed whereas `orElse` will return `null`.\r\n\r\nSecondly, you wrote that if a requested view is not found it should be redirected to `index.html`. It will not work. `some.html` is handled - according to extension - then it's not found and null will be returned - this is how `resolve` method logic works now."},"comment":{"url":"https://api.github.com/repos/geowarin/boot-react/issues/comments/235248019","html_url":"https://github.com/geowarin/boot-react/issues/26#issuecomment-235248019","issue_url":"https://api.github.com/repos/geowarin/boot-react/issues/26","id":235248019,"user":{"login":"Opalo","id":1519236,"avatar_url":"https://avatars.githubusercontent.com/u/1519236?v=3","gravatar_id":"","url":"https://api.github.com/users/Opalo","html_url":"https://github.com/Opalo","followers_url":"https://api.github.com/users/Opalo/followers","following_url":"https://api.github.com/users/Opalo/following{/other_user}","gists_url":"https://api.github.com/users/Opalo/gists{/gist_id}","starred_url":"https://api.github.com/users/Opalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opalo/subscriptions","organizations_url":"https://api.github.com/users/Opalo/orgs","repos_url":"https://api.github.com/users/Opalo/repos","events_url":"https://api.github.com/users/Opalo/events{/privacy}","received_events_url":"https://api.github.com/users/Opalo/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T12:05:11Z","updated_at":"2016-07-26T12:05:11Z","body":"@geowarin, thanks for the input. The algorithm you specified is possible to implement in `resolveResource` method. There's also a second method called `resolveUrlPath` which need to be implemented in this interface - how it should be implemented then? Maybe my questions are trivial however I consider myself as a spring beginner."}}
{"actor":{"display_login":"Opalo"}}