{"action":"created","issue":{"url":"https://api.github.com/repos/deejballa/SCRABBLE/issues/1","repository_url":"https://api.github.com/repos/deejballa/SCRABBLE","labels_url":"https://api.github.com/repos/deejballa/SCRABBLE/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/deejballa/SCRABBLE/issues/1/comments","events_url":"https://api.github.com/repos/deejballa/SCRABBLE/issues/1/events","html_url":"https://github.com/deejballa/SCRABBLE/issues/1","id":147175581,"number":1,"title":"Feedback","user":{"login":"kcalmes","id":777253,"avatar_url":"https://avatars.githubusercontent.com/u/777253?v=3","gravatar_id":"","url":"https://api.github.com/users/kcalmes","html_url":"https://github.com/kcalmes","followers_url":"https://api.github.com/users/kcalmes/followers","following_url":"https://api.github.com/users/kcalmes/following{/other_user}","gists_url":"https://api.github.com/users/kcalmes/gists{/gist_id}","starred_url":"https://api.github.com/users/kcalmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcalmes/subscriptions","organizations_url":"https://api.github.com/users/kcalmes/orgs","repos_url":"https://api.github.com/users/kcalmes/repos","events_url":"https://api.github.com/users/kcalmes/events{/privacy}","received_events_url":"https://api.github.com/users/kcalmes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-09T23:33:05Z","updated_at":"2016-04-13T03:46:07Z","closed_at":"2016-04-12T13:27:07Z","body":"*Some ideas of things you can do to improve your implementation.*\r\n\r\n### Create a Word model\r\n\r\nThis will allow you to demonstrate you can use models and the database. You can use the database migration to seed your csv of words in. You will then be able to use ActiveRecord. You can then make a method on your class that states wether or not a word is valid for the given set of characters. Move as much logic as you can to the model. There is a phrase on the rails community which is \"Fat models, skinny controllers\" meaning do as little as possible in the controller. Once you construct a good Word model (object) this will happen naturally as you move logic of reading the csv into a migration (or seed script) and move the logic for determining if a word is valid into the model in a method. \r\n\r\n### Set view variables in 1 method\r\n\r\nSet all variables that will be used by the view in the index controller. Right now you initialize @result_set on the method you call. Instead return the set, if you still end up with a method like this, and set in the index method.\r\n\r\n### Don't use double negative\r\n\r\nYour view template is fine, buy I would personally use @result_set.present? instead of the not nil double negative, but that is just a personal style preference I guess."},"comment":{"url":"https://api.github.com/repos/deejballa/SCRABBLE/issues/comments/209214148","html_url":"https://github.com/deejballa/SCRABBLE/issues/1#issuecomment-209214148","issue_url":"https://api.github.com/repos/deejballa/SCRABBLE/issues/1","id":209214148,"user":{"login":"kcalmes","id":777253,"avatar_url":"https://avatars.githubusercontent.com/u/777253?v=3","gravatar_id":"","url":"https://api.github.com/users/kcalmes","html_url":"https://github.com/kcalmes","followers_url":"https://api.github.com/users/kcalmes/followers","following_url":"https://api.github.com/users/kcalmes/following{/other_user}","gists_url":"https://api.github.com/users/kcalmes/gists{/gist_id}","starred_url":"https://api.github.com/users/kcalmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcalmes/subscriptions","organizations_url":"https://api.github.com/users/kcalmes/orgs","repos_url":"https://api.github.com/users/kcalmes/repos","events_url":"https://api.github.com/users/kcalmes/events{/privacy}","received_events_url":"https://api.github.com/users/kcalmes/received_events","type":"User","site_admin":false},"created_at":"2016-04-13T03:46:07Z","updated_at":"2016-04-13T03:46:07Z","body":"Looks great! Hope it does the trick!"}}