{"action":"created","comment":{"url":"https://api.github.com/repos/PecanProject/pecan/pulls/comments/90406842","pull_request_review_id":10924152,"id":90406842,"diff_hunk":"@@ -20,10 +20,10 @@ check.inputs <- function(settings) {\n   }\n   \n   # get list of inputs associated with model type\n-  dbcon <- db.open(settings$database$bety)\n-  on.exit(db.close(dbcon))\n+  dbcon <- PEcAn.DB::db.open(settings$database$bety)","path":"settings/R/check.all.settings.R","position":6,"original_position":6,"commit_id":"e3a5eabea2b4d13abac6049a58ba7700b920ceb6","original_commit_id":"e3a5eabea2b4d13abac6049a58ba7700b920ceb6","user":{"login":"bcow","id":5503595,"avatar_url":"https://avatars.githubusercontent.com/u/5503595?v=3","gravatar_id":"","url":"https://api.github.com/users/bcow","html_url":"https://github.com/bcow","followers_url":"https://api.github.com/users/bcow/followers","following_url":"https://api.github.com/users/bcow/following{/other_user}","gists_url":"https://api.github.com/users/bcow/gists{/gist_id}","starred_url":"https://api.github.com/users/bcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcow/subscriptions","organizations_url":"https://api.github.com/users/bcow/orgs","repos_url":"https://api.github.com/users/bcow/repos","events_url":"https://api.github.com/users/bcow/events{/privacy}","received_events_url":"https://api.github.com/users/bcow/received_events","type":"User","site_admin":false},"body":"For now this works (especially since I haven't fixed `betyConnect` like I said I would) but we really should be switching over to `dplyr` functions. Essentially any time we use `db.query` with `SELECT` we can replace that with the `dplyr` functions `tbl` and `filter` and `select`.  I can tackle the full transition after AGU/Christmas but the sooner people get used to the `dplyr` functions, the better. ","created_at":"2016-12-01T09:11:41Z","updated_at":"2016-12-01T09:13:38Z","html_url":"https://github.com/PecanProject/pecan/pull/1213#discussion_r90406842","pull_request_url":"https://api.github.com/repos/PecanProject/pecan/pulls/1213","_links":{"self":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/comments/90406842"},"html":{"href":"https://github.com/PecanProject/pecan/pull/1213#discussion_r90406842"},"pull_request":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/1213"}}},"pull_request":{"url":"https://api.github.com/repos/PecanProject/pecan/pulls/1213","id":96045870,"html_url":"https://github.com/PecanProject/pecan/pull/1213","diff_url":"https://github.com/PecanProject/pecan/pull/1213.diff","patch_url":"https://github.com/PecanProject/pecan/pull/1213.patch","issue_url":"https://api.github.com/repos/PecanProject/pecan/issues/1213","number":1213,"state":"open","locked":false,"title":"FATES BCI PDA debugging","user":{"login":"mdietze","id":3081466,"avatar_url":"https://avatars.githubusercontent.com/u/3081466?v=3","gravatar_id":"","url":"https://api.github.com/users/mdietze","html_url":"https://github.com/mdietze","followers_url":"https://api.github.com/users/mdietze/followers","following_url":"https://api.github.com/users/mdietze/following{/other_user}","gists_url":"https://api.github.com/users/mdietze/gists{/gist_id}","starred_url":"https://api.github.com/users/mdietze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdietze/subscriptions","organizations_url":"https://api.github.com/users/mdietze/orgs","repos_url":"https://api.github.com/users/mdietze/repos","events_url":"https://api.github.com/users/mdietze/events{/privacy}","received_events_url":"https://api.github.com/users/mdietze/received_events","type":"User","site_admin":false},"body":"FATES:\r\n* catch non-numeric lat/lon\r\n* try to catch missing pft names\r\n\r\nEmulator:\r\n* wasn't writing pft names to models\r\n\r\npda.utils:\r\n* added a case to catch when posteriorid not specified in settings explicitly but available in current workflow/PFT directories via meta-analysis output. Needs a more general solution.\r\n\r\nstart.model.runs\r\n* skip if no list of runs (runs.txt)\r\n\r\nworkflow.R\r\n* skip ensemble and sensitivity analysis if not in settings\r\n\r\nmisc namespace and Roxygen","created_at":"2016-12-01T08:35:36Z","updated_at":"2016-12-01T09:13:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df075759fa8d7670c5ff02c0d4e03a3d044f38f7","assignee":{"login":"bcow","id":5503595,"avatar_url":"https://avatars.githubusercontent.com/u/5503595?v=3","gravatar_id":"","url":"https://api.github.com/users/bcow","html_url":"https://github.com/bcow","followers_url":"https://api.github.com/users/bcow/followers","following_url":"https://api.github.com/users/bcow/following{/other_user}","gists_url":"https://api.github.com/users/bcow/gists{/gist_id}","starred_url":"https://api.github.com/users/bcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcow/subscriptions","organizations_url":"https://api.github.com/users/bcow/orgs","repos_url":"https://api.github.com/users/bcow/repos","events_url":"https://api.github.com/users/bcow/events{/privacy}","received_events_url":"https://api.github.com/users/bcow/received_events","type":"User","site_admin":false},"assignees":[{"login":"bcow","id":5503595,"avatar_url":"https://avatars.githubusercontent.com/u/5503595?v=3","gravatar_id":"","url":"https://api.github.com/users/bcow","html_url":"https://github.com/bcow","followers_url":"https://api.github.com/users/bcow/followers","following_url":"https://api.github.com/users/bcow/following{/other_user}","gists_url":"https://api.github.com/users/bcow/gists{/gist_id}","starred_url":"https://api.github.com/users/bcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcow/subscriptions","organizations_url":"https://api.github.com/users/bcow/orgs","repos_url":"https://api.github.com/users/bcow/repos","events_url":"https://api.github.com/users/bcow/events{/privacy}","received_events_url":"https://api.github.com/users/bcow/received_events","type":"User","site_admin":false},{"login":"istfer","id":13728388,"avatar_url":"https://avatars.githubusercontent.com/u/13728388?v=3","gravatar_id":"","url":"https://api.github.com/users/istfer","html_url":"https://github.com/istfer","followers_url":"https://api.github.com/users/istfer/followers","following_url":"https://api.github.com/users/istfer/following{/other_user}","gists_url":"https://api.github.com/users/istfer/gists{/gist_id}","starred_url":"https://api.github.com/users/istfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istfer/subscriptions","organizations_url":"https://api.github.com/users/istfer/orgs","repos_url":"https://api.github.com/users/istfer/repos","events_url":"https://api.github.com/users/istfer/events{/privacy}","received_events_url":"https://api.github.com/users/istfer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PecanProject/pecan/pulls/1213/commits","review_comments_url":"https://api.github.com/repos/PecanProject/pecan/pulls/1213/comments","review_comment_url":"https://api.github.com/repos/PecanProject/pecan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PecanProject/pecan/issues/1213/comments","statuses_url":"https://api.github.com/repos/PecanProject/pecan/statuses/e3a5eabea2b4d13abac6049a58ba7700b920ceb6","head":{"label":"mdietze:FATES_BCI_Benchmark","ref":"FATES_BCI_Benchmark","sha":"e3a5eabea2b4d13abac6049a58ba7700b920ceb6","user":{"login":"mdietze","id":3081466,"avatar_url":"https://avatars.githubusercontent.com/u/3081466?v=3","gravatar_id":"","url":"https://api.github.com/users/mdietze","html_url":"https://github.com/mdietze","followers_url":"https://api.github.com/users/mdietze/followers","following_url":"https://api.github.com/users/mdietze/following{/other_user}","gists_url":"https://api.github.com/users/mdietze/gists{/gist_id}","starred_url":"https://api.github.com/users/mdietze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdietze/subscriptions","organizations_url":"https://api.github.com/users/mdietze/orgs","repos_url":"https://api.github.com/users/mdietze/repos","events_url":"https://api.github.com/users/mdietze/events{/privacy}","received_events_url":"https://api.github.com/users/mdietze/received_events","type":"User","site_admin":false},"repo":{"id":19536232,"name":"pecan","full_name":"mdietze/pecan","owner":{"login":"mdietze","id":3081466,"avatar_url":"https://avatars.githubusercontent.com/u/3081466?v=3","gravatar_id":"","url":"https://api.github.com/users/mdietze","html_url":"https://github.com/mdietze","followers_url":"https://api.github.com/users/mdietze/followers","following_url":"https://api.github.com/users/mdietze/following{/other_user}","gists_url":"https://api.github.com/users/mdietze/gists{/gist_id}","starred_url":"https://api.github.com/users/mdietze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdietze/subscriptions","organizations_url":"https://api.github.com/users/mdietze/orgs","repos_url":"https://api.github.com/users/mdietze/repos","events_url":"https://api.github.com/users/mdietze/events{/privacy}","received_events_url":"https://api.github.com/users/mdietze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdietze/pecan","description":"The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.","fork":true,"url":"https://api.github.com/repos/mdietze/pecan","forks_url":"https://api.github.com/repos/mdietze/pecan/forks","keys_url":"https://api.github.com/repos/mdietze/pecan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdietze/pecan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdietze/pecan/teams","hooks_url":"https://api.github.com/repos/mdietze/pecan/hooks","issue_events_url":"https://api.github.com/repos/mdietze/pecan/issues/events{/number}","events_url":"https://api.github.com/repos/mdietze/pecan/events","assignees_url":"https://api.github.com/repos/mdietze/pecan/assignees{/user}","branches_url":"https://api.github.com/repos/mdietze/pecan/branches{/branch}","tags_url":"https://api.github.com/repos/mdietze/pecan/tags","blobs_url":"https://api.github.com/repos/mdietze/pecan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdietze/pecan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdietze/pecan/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdietze/pecan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdietze/pecan/statuses/{sha}","languages_url":"https://api.github.com/repos/mdietze/pecan/languages","stargazers_url":"https://api.github.com/repos/mdietze/pecan/stargazers","contributors_url":"https://api.github.com/repos/mdietze/pecan/contributors","subscribers_url":"https://api.github.com/repos/mdietze/pecan/subscribers","subscription_url":"https://api.github.com/repos/mdietze/pecan/subscription","commits_url":"https://api.github.com/repos/mdietze/pecan/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdietze/pecan/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdietze/pecan/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdietze/pecan/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdietze/pecan/contents/{+path}","compare_url":"https://api.github.com/repos/mdietze/pecan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdietze/pecan/merges","archive_url":"https://api.github.com/repos/mdietze/pecan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdietze/pecan/downloads","issues_url":"https://api.github.com/repos/mdietze/pecan/issues{/number}","pulls_url":"https://api.github.com/repos/mdietze/pecan/pulls{/number}","milestones_url":"https://api.github.com/repos/mdietze/pecan/milestones{/number}","notifications_url":"https://api.github.com/repos/mdietze/pecan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdietze/pecan/labels{/name}","releases_url":"https://api.github.com/repos/mdietze/pecan/releases{/id}","deployments_url":"https://api.github.com/repos/mdietze/pecan/deployments","created_at":"2014-05-07T13:49:54Z","updated_at":"2016-03-23T13:14:28Z","pushed_at":"2016-12-01T08:29:12Z","git_url":"git://github.com/mdietze/pecan.git","ssh_url":"git@github.com:mdietze/pecan.git","clone_url":"https://github.com/mdietze/pecan.git","svn_url":"https://github.com/mdietze/pecan","homepage":"www.pecanproject.org","size":125068,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PecanProject:master","ref":"master","sha":"5ad620b90ad0292a681a09524f52411aedc0bc57","user":{"login":"PecanProject","id":2879854,"avatar_url":"https://avatars.githubusercontent.com/u/2879854?v=3","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"repo":{"id":6857384,"name":"pecan","full_name":"PecanProject/pecan","owner":{"login":"PecanProject","id":2879854,"avatar_url":"https://avatars.githubusercontent.com/u/2879854?v=3","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PecanProject/pecan","description":"The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.","fork":false,"url":"https://api.github.com/repos/PecanProject/pecan","forks_url":"https://api.github.com/repos/PecanProject/pecan/forks","keys_url":"https://api.github.com/repos/PecanProject/pecan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PecanProject/pecan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PecanProject/pecan/teams","hooks_url":"https://api.github.com/repos/PecanProject/pecan/hooks","issue_events_url":"https://api.github.com/repos/PecanProject/pecan/issues/events{/number}","events_url":"https://api.github.com/repos/PecanProject/pecan/events","assignees_url":"https://api.github.com/repos/PecanProject/pecan/assignees{/user}","branches_url":"https://api.github.com/repos/PecanProject/pecan/branches{/branch}","tags_url":"https://api.github.com/repos/PecanProject/pecan/tags","blobs_url":"https://api.github.com/repos/PecanProject/pecan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PecanProject/pecan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PecanProject/pecan/git/refs{/sha}","trees_url":"https://api.github.com/repos/PecanProject/pecan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PecanProject/pecan/statuses/{sha}","languages_url":"https://api.github.com/repos/PecanProject/pecan/languages","stargazers_url":"https://api.github.com/repos/PecanProject/pecan/stargazers","contributors_url":"https://api.github.com/repos/PecanProject/pecan/contributors","subscribers_url":"https://api.github.com/repos/PecanProject/pecan/subscribers","subscription_url":"https://api.github.com/repos/PecanProject/pecan/subscription","commits_url":"https://api.github.com/repos/PecanProject/pecan/commits{/sha}","git_commits_url":"https://api.github.com/repos/PecanProject/pecan/git/commits{/sha}","comments_url":"https://api.github.com/repos/PecanProject/pecan/comments{/number}","issue_comment_url":"https://api.github.com/repos/PecanProject/pecan/issues/comments{/number}","contents_url":"https://api.github.com/repos/PecanProject/pecan/contents/{+path}","compare_url":"https://api.github.com/repos/PecanProject/pecan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PecanProject/pecan/merges","archive_url":"https://api.github.com/repos/PecanProject/pecan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PecanProject/pecan/downloads","issues_url":"https://api.github.com/repos/PecanProject/pecan/issues{/number}","pulls_url":"https://api.github.com/repos/PecanProject/pecan/pulls{/number}","milestones_url":"https://api.github.com/repos/PecanProject/pecan/milestones{/number}","notifications_url":"https://api.github.com/repos/PecanProject/pecan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PecanProject/pecan/labels{/name}","releases_url":"https://api.github.com/repos/PecanProject/pecan/releases{/id}","deployments_url":"https://api.github.com/repos/PecanProject/pecan/deployments","created_at":"2012-11-25T23:48:26Z","updated_at":"2016-11-01T15:52:45Z","pushed_at":"2016-12-01T08:35:36Z","git_url":"git://github.com/PecanProject/pecan.git","ssh_url":"git@github.com:PecanProject/pecan.git","clone_url":"https://github.com/PecanProject/pecan.git","svn_url":"https://github.com/PecanProject/pecan","homepage":"www.pecanproject.org","size":351173,"stargazers_count":49,"watchers_count":49,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":84,"mirror_url":null,"open_issues_count":231,"forks":84,"open_issues":231,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/1213"},"html":{"href":"https://github.com/PecanProject/pecan/pull/1213"},"issue":{"href":"https://api.github.com/repos/PecanProject/pecan/issues/1213"},"comments":{"href":"https://api.github.com/repos/PecanProject/pecan/issues/1213/comments"},"review_comments":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/1213/comments"},"review_comment":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/1213/commits"},"statuses":{"href":"https://api.github.com/repos/PecanProject/pecan/statuses/e3a5eabea2b4d13abac6049a58ba7700b920ceb6"}}}}
{"actor":{"display_login":"bcow"}}