{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/comments/64554336","id":64554336,"diff_hunk":"@@ -0,0 +1,35 @@\n+/**\n+ * @license Copyright (c) 2003-2016, CKSource - Frederico Knabben. All rights reserved.\n+ * For licensing, see LICENSE.md.\n+ */\n+\n+'use strict';\n+\n+import DropdownView from '/ckeditor5/ui/dropdown/dropdownview.js';\n+\n+/**\n+ * The basic list dropdown view class.\n+ *\n+ * @memberOf ui.dropdown\n+ * @extends ui.View\n+ */\n+\n+export default class ListDropdownView extends DropdownView {\n+\tconstructor( model ) {\n+\t\tsuper( model );\n+\n+\t\tthis.listenTo( this.model, 'change:isOn', ( evt, name, value ) => {","path":"src/dropdown/list/listdropdownview.js","position":20,"original_position":21,"commit_id":"7e2576f0daae6fbc1fe8a573f8abab8b4a90ccf5","original_commit_id":"c900a25b8f605a2fc3f74b7c715a1fb44349d598","user":{"login":"Reinmar","id":156149,"avatar_url":"https://avatars.githubusercontent.com/u/156149?v=3","gravatar_id":"","url":"https://api.github.com/users/Reinmar","html_url":"https://github.com/Reinmar","followers_url":"https://api.github.com/users/Reinmar/followers","following_url":"https://api.github.com/users/Reinmar/following{/other_user}","gists_url":"https://api.github.com/users/Reinmar/gists{/gist_id}","starred_url":"https://api.github.com/users/Reinmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reinmar/subscriptions","organizations_url":"https://api.github.com/users/Reinmar/orgs","repos_url":"https://api.github.com/users/Reinmar/repos","events_url":"https://api.github.com/users/Reinmar/events{/privacy}","received_events_url":"https://api.github.com/users/Reinmar/received_events","type":"User","site_admin":false},"body":"The whole cost of these callbacks combined for the whole world in next 10 years will be less than me writing this comment ;).\r\n\r\nBut ok. Since you already implemented this in this way, let's keep it.","created_at":"2016-05-25T11:10:11Z","updated_at":"2016-05-25T11:10:12Z","html_url":"https://github.com/ckeditor/ckeditor5-ui-default/pull/15#discussion_r64554336","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/comments/64554336"},"html":{"href":"https://github.com/ckeditor/ckeditor5-ui-default/pull/15#discussion_r64554336"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/15","id":71225646,"html_url":"https://github.com/ckeditor/ckeditor5-ui-default/pull/15","diff_url":"https://github.com/ckeditor/ckeditor5-ui-default/pull/15.diff","patch_url":"https://github.com/ckeditor/ckeditor5-ui-default/pull/15.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/issues/15","number":15,"state":"open","locked":false,"title":"T/12: Implement dropdown component","user":{"login":"oleq","id":1099479,"avatar_url":"https://avatars.githubusercontent.com/u/1099479?v=3","gravatar_id":"","url":"https://api.github.com/users/oleq","html_url":"https://github.com/oleq","followers_url":"https://api.github.com/users/oleq/followers","following_url":"https://api.github.com/users/oleq/following{/other_user}","gists_url":"https://api.github.com/users/oleq/gists{/gist_id}","starred_url":"https://api.github.com/users/oleq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleq/subscriptions","organizations_url":"https://api.github.com/users/oleq/orgs","repos_url":"https://api.github.com/users/oleq/repos","events_url":"https://api.github.com/users/oleq/events{/privacy}","received_events_url":"https://api.github.com/users/oleq/received_events","type":"User","site_admin":false},"body":"Closes #12.\r\n\r\nRequires https://github.com/ckeditor/ckeditor5/tree/t/ckeditor5-ui-default/12 for proper dependencies.","created_at":"2016-05-24T14:02:24Z","updated_at":"2016-05-25T11:10:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1af991ba57bf310843e9066b4befe97048fb18d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/15/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/15/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/issues/15/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/statuses/7e2576f0daae6fbc1fe8a573f8abab8b4a90ccf5","head":{"label":"ckeditor:t/12","ref":"t/12","sha":"7e2576f0daae6fbc1fe8a573f8abab8b4a90ccf5","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":49419430,"name":"ckeditor5-ui-default","full_name":"ckeditor/ckeditor5-ui-default","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-ui-default","description":"The default library of UI components for CKEditor 5.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/deployments","created_at":"2016-01-11T10:41:25Z","updated_at":"2016-03-11T09:31:50Z","pushed_at":"2016-05-25T10:43:00Z","git_url":"git://github.com/ckeditor/ckeditor5-ui-default.git","ssh_url":"git@github.com:ckeditor/ckeditor5-ui-default.git","clone_url":"https://github.com/ckeditor/ckeditor5-ui-default.git","svn_url":"https://github.com/ckeditor/ckeditor5-ui-default","homepage":"","size":82,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"ckeditor:master","ref":"master","sha":"f1ef58dc6b9428a9c17e76791b726bd423071c35","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":49419430,"name":"ckeditor5-ui-default","full_name":"ckeditor/ckeditor5-ui-default","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-ui-default","description":"The default library of UI components for CKEditor 5.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/deployments","created_at":"2016-01-11T10:41:25Z","updated_at":"2016-03-11T09:31:50Z","pushed_at":"2016-05-25T10:43:00Z","git_url":"git://github.com/ckeditor/ckeditor5-ui-default.git","ssh_url":"git@github.com:ckeditor/ckeditor5-ui-default.git","clone_url":"https://github.com/ckeditor/ckeditor5-ui-default.git","svn_url":"https://github.com/ckeditor/ckeditor5-ui-default","homepage":"","size":82,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/15"},"html":{"href":"https://github.com/ckeditor/ckeditor5-ui-default/pull/15"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/issues/15"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui-default/statuses/7e2576f0daae6fbc1fe8a573f8abab8b4a90ccf5"}}}}
{"actor":{"display_login":"Reinmar"}}