{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/10648","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/10648/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/10648/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/10648/events","html_url":"https://github.com/facebook/react-native/pull/10648","id":186226342,"number":10648,"title":"Added components support to PickerIOS","user":{"login":"VojtechBartos","id":1526646,"avatar_url":"https://avatars.githubusercontent.com/u/1526646?v=3","gravatar_id":"","url":"https://api.github.com/users/VojtechBartos","html_url":"https://github.com/VojtechBartos","followers_url":"https://api.github.com/users/VojtechBartos/followers","following_url":"https://api.github.com/users/VojtechBartos/following{/other_user}","gists_url":"https://api.github.com/users/VojtechBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/VojtechBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VojtechBartos/subscriptions","organizations_url":"https://api.github.com/users/VojtechBartos/orgs","repos_url":"https://api.github.com/users/VojtechBartos/repos","events_url":"https://api.github.com/users/VojtechBartos/events{/privacy}","received_events_url":"https://api.github.com/users/VojtechBartos/received_events","type":"User","site_admin":false},"labels":[{"id":172176599,"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-31T08:11:22Z","updated_at":"2016-10-31T08:13:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/10648","html_url":"https://github.com/facebook/react-native/pull/10648","diff_url":"https://github.com/facebook/react-native/pull/10648.diff","patch_url":"https://github.com/facebook/react-native/pull/10648.patch"},"body":"Hey guys,\r\nthe issue is that current `PickerIOS` component doesn't support having multiple components and rendering everything to single one. Multiple components means that inside one picker you can have multiple \"sub\" pickers (Take a look on attached screenshots below). \r\n\r\n<img width=\"378\" alt=\"screen shot 2016-10-29 at 18 56 43\" src=\"https://cloud.githubusercontent.com/assets/1526646/19847467/63ace180-9f47-11e6-95e0-c37c2f65e0a2.png\">\r\n\r\nvs \r\n\r\n<img width=\"374\" alt=\"screen shot 2016-10-29 at 18 54 35\" src=\"https://cloud.githubusercontent.com/assets/1526646/19847471/6a174650-9f47-11e6-82d0-18ce90839d47.png\">\r\n\r\nThis PR adding support to `PickerIOS` component and slightly changing component API.\r\n\r\n- added child component `PickerIOS.Component` and the already existing component `PickerIOS.Item` should be child of the new `PickerIOS.Component`\r\n- removed property `selectedValue` from `PickerIOS` and moved it to `PickerIOS.Component`\r\n- `PickerIOS` property `onChangeValue` receiving instead of `(newValue, newIndex)` one additional argument `component`, describing index of the component. So `(component, newValue, newIndex)`\r\n\r\n**Test plan**\r\n\r\n- `Picker`\r\n  - make sure everything works correctly as before, because of changing API of the `PickerIOS` i have to slightly tweak `Picker` to support just 1 component\r\n- `PickerIOS`\r\n  -  Test in UI explorer the PickerIOS works correctly (including new example with multiple components)\r\n  - `onValueChange` should be receiving new first extra argument `component`, describing component index\r\n  - changing `PickerIOS.Component` `selectedValue` should be changing selected value in specific picker component"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/257235596","html_url":"https://github.com/facebook/react-native/pull/10648#issuecomment-257235596","issue_url":"https://api.github.com/repos/facebook/react-native/issues/10648","id":257235596,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T08:13:45Z","updated_at":"2016-10-31T08:13:45Z","body":"Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.\n\nBefore we can review or merge your code, **we need you to email cla@fb.com** with your details so we can update your status."}}
{"actor":{"display_login":"facebook-github-bot"}}