{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/85246534","pull_request_review_id":5973420,"id":85246534,"diff_hunk":"@@ -39,12 +36,17 @@ public static CatalogSchemaTableName valueOf(String catalogSchemaTableName)\n \n     public CatalogSchemaTableName(String catalogName, SchemaTableName schemaTableName)\n     {\n+        checkNotEmpty(catalogName, \"catalogName\");\n+        requireNonNull(schemaTableName, \"schemaTableName is null\");\n         this.catalogName = catalogName;\n         this.schemaTableName = schemaTableName;\n     }\n \n     public CatalogSchemaTableName(String catalogName, String schemaName, String tableName)\n     {\n+        checkNotEmpty(catalogName, \"catalogName\");","path":"presto-spi/src/main/java/com/facebook/presto/spi/CatalogSchemaTableName.java","position":34,"original_position":34,"commit_id":"834d282f3da5c16c622525b0f9e8776ff25e8979","original_commit_id":"834d282f3da5c16c622525b0f9e8776ff25e8979","user":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"body":"This check can be inline.","created_at":"2016-10-27T00:19:26Z","updated_at":"2016-10-27T00:24:41Z","html_url":"https://github.com/prestodb/presto/pull/6439#discussion_r85246534","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/6439","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/85246534"},"html":{"href":"https://github.com/prestodb/presto/pull/6439#discussion_r85246534"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6439"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/6439","id":91057530,"html_url":"https://github.com/prestodb/presto/pull/6439","diff_url":"https://github.com/prestodb/presto/pull/6439.diff","patch_url":"https://github.com/prestodb/presto/pull/6439.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/6439","number":6439,"state":"open","locked":false,"title":"Cleaning up CatalogSchemaTableName","user":{"login":"paulrevere4","id":5481194,"avatar_url":"https://avatars.githubusercontent.com/u/5481194?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrevere4","html_url":"https://github.com/paulrevere4","followers_url":"https://api.github.com/users/paulrevere4/followers","following_url":"https://api.github.com/users/paulrevere4/following{/other_user}","gists_url":"https://api.github.com/users/paulrevere4/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrevere4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrevere4/subscriptions","organizations_url":"https://api.github.com/users/paulrevere4/orgs","repos_url":"https://api.github.com/users/paulrevere4/repos","events_url":"https://api.github.com/users/paulrevere4/events{/privacy}","received_events_url":"https://api.github.com/users/paulrevere4/received_events","type":"User","site_admin":false},"body":"# Overview\r\nThis PR is to resolve issue #6145. \r\n\r\n# Changes\r\n\r\n- Removed Jackson annotations\r\n- Changed class from `public` to `public final`\r\n- Added null checks on constructor arguments","created_at":"2016-10-26T18:09:02Z","updated_at":"2016-10-27T00:24:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad03bfd25f038f925e460911bb7851e321944e2f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/6439/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/6439/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/6439/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/834d282f3da5c16c622525b0f9e8776ff25e8979","head":{"label":"paulrevere4:cleanup_catalog_schema_table_name","ref":"cleanup_catalog_schema_table_name","sha":"834d282f3da5c16c622525b0f9e8776ff25e8979","user":{"login":"paulrevere4","id":5481194,"avatar_url":"https://avatars.githubusercontent.com/u/5481194?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrevere4","html_url":"https://github.com/paulrevere4","followers_url":"https://api.github.com/users/paulrevere4/followers","following_url":"https://api.github.com/users/paulrevere4/following{/other_user}","gists_url":"https://api.github.com/users/paulrevere4/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrevere4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrevere4/subscriptions","organizations_url":"https://api.github.com/users/paulrevere4/orgs","repos_url":"https://api.github.com/users/paulrevere4/repos","events_url":"https://api.github.com/users/paulrevere4/events{/privacy}","received_events_url":"https://api.github.com/users/paulrevere4/received_events","type":"User","site_admin":false},"repo":{"id":68143457,"name":"presto","full_name":"paulrevere4/presto","owner":{"login":"paulrevere4","id":5481194,"avatar_url":"https://avatars.githubusercontent.com/u/5481194?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrevere4","html_url":"https://github.com/paulrevere4","followers_url":"https://api.github.com/users/paulrevere4/followers","following_url":"https://api.github.com/users/paulrevere4/following{/other_user}","gists_url":"https://api.github.com/users/paulrevere4/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrevere4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrevere4/subscriptions","organizations_url":"https://api.github.com/users/paulrevere4/orgs","repos_url":"https://api.github.com/users/paulrevere4/repos","events_url":"https://api.github.com/users/paulrevere4/events{/privacy}","received_events_url":"https://api.github.com/users/paulrevere4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulrevere4/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/paulrevere4/presto","forks_url":"https://api.github.com/repos/paulrevere4/presto/forks","keys_url":"https://api.github.com/repos/paulrevere4/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulrevere4/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulrevere4/presto/teams","hooks_url":"https://api.github.com/repos/paulrevere4/presto/hooks","issue_events_url":"https://api.github.com/repos/paulrevere4/presto/issues/events{/number}","events_url":"https://api.github.com/repos/paulrevere4/presto/events","assignees_url":"https://api.github.com/repos/paulrevere4/presto/assignees{/user}","branches_url":"https://api.github.com/repos/paulrevere4/presto/branches{/branch}","tags_url":"https://api.github.com/repos/paulrevere4/presto/tags","blobs_url":"https://api.github.com/repos/paulrevere4/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulrevere4/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulrevere4/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulrevere4/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulrevere4/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/paulrevere4/presto/languages","stargazers_url":"https://api.github.com/repos/paulrevere4/presto/stargazers","contributors_url":"https://api.github.com/repos/paulrevere4/presto/contributors","subscribers_url":"https://api.github.com/repos/paulrevere4/presto/subscribers","subscription_url":"https://api.github.com/repos/paulrevere4/presto/subscription","commits_url":"https://api.github.com/repos/paulrevere4/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulrevere4/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulrevere4/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulrevere4/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulrevere4/presto/contents/{+path}","compare_url":"https://api.github.com/repos/paulrevere4/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulrevere4/presto/merges","archive_url":"https://api.github.com/repos/paulrevere4/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulrevere4/presto/downloads","issues_url":"https://api.github.com/repos/paulrevere4/presto/issues{/number}","pulls_url":"https://api.github.com/repos/paulrevere4/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/paulrevere4/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/paulrevere4/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulrevere4/presto/labels{/name}","releases_url":"https://api.github.com/repos/paulrevere4/presto/releases{/id}","deployments_url":"https://api.github.com/repos/paulrevere4/presto/deployments","created_at":"2016-09-13T20:08:34Z","updated_at":"2016-09-13T20:08:49Z","pushed_at":"2016-10-26T03:15:09Z","git_url":"git://github.com/paulrevere4/presto.git","ssh_url":"git@github.com:paulrevere4/presto.git","clone_url":"https://github.com/paulrevere4/presto.git","svn_url":"https://github.com/paulrevere4/presto","homepage":"https://prestodb.io","size":61711,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"a430da59f0860eac098acd53f21e1df836a4a224","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2016-10-26T18:12:10Z","pushed_at":"2016-10-27T00:13:52Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":169718,"stargazers_count":5229,"watchers_count":5229,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1626,"mirror_url":null,"open_issues_count":705,"forks":1626,"open_issues":705,"watchers":5229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6439"},"html":{"href":"https://github.com/prestodb/presto/pull/6439"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/6439"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/6439/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6439/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6439/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/834d282f3da5c16c622525b0f9e8776ff25e8979"}}}}
{"actor":{"display_login":"electrum"}}