{"action":"created","issue":{"url":"https://api.github.com/repos/compose/transporter/issues/211","repository_url":"https://api.github.com/repos/compose/transporter","labels_url":"https://api.github.com/repos/compose/transporter/issues/211/labels{/name}","comments_url":"https://api.github.com/repos/compose/transporter/issues/211/comments","events_url":"https://api.github.com/repos/compose/transporter/issues/211/events","html_url":"https://github.com/compose/transporter/pull/211","id":194400380,"number":211,"title":"use a listening flag for mongo node reuse","user":{"login":"jipperinbham","id":829493,"avatar_url":"https://avatars.githubusercontent.com/u/829493?v=3","gravatar_id":"","url":"https://api.github.com/users/jipperinbham","html_url":"https://github.com/jipperinbham","followers_url":"https://api.github.com/users/jipperinbham/followers","following_url":"https://api.github.com/users/jipperinbham/following{/other_user}","gists_url":"https://api.github.com/users/jipperinbham/gists{/gist_id}","starred_url":"https://api.github.com/users/jipperinbham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jipperinbham/subscriptions","organizations_url":"https://api.github.com/users/jipperinbham/orgs","repos_url":"https://api.github.com/users/jipperinbham/repos","events_url":"https://api.github.com/users/jipperinbham/events{/privacy}","received_events_url":"https://api.github.com/users/jipperinbham/received_events","type":"User","site_admin":false},"labels":[{"id":497138139,"url":"https://api.github.com/repos/compose/transporter/labels/review","name":"review","color":"e6e6e6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-08T17:47:19Z","updated_at":"2016-12-09T23:00:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/compose/transporter/pulls/211","html_url":"https://github.com/compose/transporter/pull/211","diff_url":"https://github.com/compose/transporter/pull/211.diff","patch_url":"https://github.com/compose/transporter/pull/211.patch"},"body":"- [ ] CHANGELOG.md updated (feel free to wait until changes have been reviewed by a maintainer)\r\n\r\nWhen a mongodb adaptor is defined in the `config.yaml` with `bulk=true` and is used for the `Source` and `Sink` in the `application.js`, transporter will never shutdown properly.\r\n\r\nThe following change adds a new field to the adaptor and sets it when the `Listen` func is called and checked with `Stop` is called.\r\n\r\nfixes #152 "},"comment":{"url":"https://api.github.com/repos/compose/transporter/issues/comments/266146699","html_url":"https://github.com/compose/transporter/pull/211#issuecomment-266146699","issue_url":"https://api.github.com/repos/compose/transporter/issues/211","id":266146699,"user":{"login":"trinchan","id":3772659,"avatar_url":"https://avatars.githubusercontent.com/u/3772659?v=3","gravatar_id":"","url":"https://api.github.com/users/trinchan","html_url":"https://github.com/trinchan","followers_url":"https://api.github.com/users/trinchan/followers","following_url":"https://api.github.com/users/trinchan/following{/other_user}","gists_url":"https://api.github.com/users/trinchan/gists{/gist_id}","starred_url":"https://api.github.com/users/trinchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trinchan/subscriptions","organizations_url":"https://api.github.com/users/trinchan/orgs","repos_url":"https://api.github.com/users/trinchan/repos","events_url":"https://api.github.com/users/trinchan/events{/privacy}","received_events_url":"https://api.github.com/users/trinchan/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T23:00:23Z","updated_at":"2016-12-09T23:00:23Z","body":" I'm having a hard time figuring out how the bulkWriter close blocks, causing the app to hang. From what I understand, the only exit from that bulkWriter is through the quit channel and we're skipping over that here because it presumably blocks. Is the final data flush hanging? If so, I think it's more natural to leave the quit/cleanup in and attacking the bug from the bulk writer end.\r\n\r\nIf you could a quick execution path summary of the blocking state, that'd be awesome.\r\n\r\nI don't doubt this works, I just want to make sure I understand the code path properly."}}
{"actor":{"display_login":"trinchan"}}