{"action":"created","issue":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/10265","repository_url":"https://api.github.com/repos/mrdoob/three.js","labels_url":"https://api.github.com/repos/mrdoob/three.js/issues/10265/labels{/name}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/10265/comments","events_url":"https://api.github.com/repos/mrdoob/three.js/issues/10265/events","html_url":"https://github.com/mrdoob/three.js/issues/10265","id":192926049,"number":10265,"title":"Matrix4.makePerspective() is never used","user":{"login":"looeee","id":5307958,"avatar_url":"https://avatars.githubusercontent.com/u/5307958?v=3","gravatar_id":"","url":"https://api.github.com/users/looeee","html_url":"https://github.com/looeee","followers_url":"https://api.github.com/users/looeee/followers","following_url":"https://api.github.com/users/looeee/following{/other_user}","gists_url":"https://api.github.com/users/looeee/gists{/gist_id}","starred_url":"https://api.github.com/users/looeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/looeee/subscriptions","organizations_url":"https://api.github.com/users/looeee/orgs","repos_url":"https://api.github.com/users/looeee/repos","events_url":"https://api.github.com/users/looeee/events{/privacy}","received_events_url":"https://api.github.com/users/looeee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-12-01T18:31:42Z","updated_at":"2016-12-06T07:51:05Z","closed_at":null,"body":"I'm updating the Matrix4 docs and there's a method called Matrix4.makePerspective( fov, aspect, near, far ) \r\n\r\nInternally this calculates the values of left, right, top and bottom and calls\r\nMatrix4.makeFrustum( left, right, bottom, top, near, far )\r\nand it looks like it is intended for use in PerspectiveCamera.updateProjectionMatrix()\r\n\r\nHowever the PerspectiveCamera calculates its own versions of left, right, top and bottom in a slightly more complex way, taking into account zoom, view (if set) and filmOffset, and then calls Matrix4.makeFrustum directly. \r\n\r\nSo it seems that Matrix4.makePerspective() is superfluous - is there a use case that I am missing?\r\n"},"comment":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/265083645","html_url":"https://github.com/mrdoob/three.js/issues/10265#issuecomment-265083645","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/10265","id":265083645,"user":{"login":"Mugen87","id":12612165,"avatar_url":"https://avatars.githubusercontent.com/u/12612165?v=3","gravatar_id":"","url":"https://api.github.com/users/Mugen87","html_url":"https://github.com/Mugen87","followers_url":"https://api.github.com/users/Mugen87/followers","following_url":"https://api.github.com/users/Mugen87/following{/other_user}","gists_url":"https://api.github.com/users/Mugen87/gists{/gist_id}","starred_url":"https://api.github.com/users/Mugen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mugen87/subscriptions","organizations_url":"https://api.github.com/users/Mugen87/orgs","repos_url":"https://api.github.com/users/Mugen87/repos","events_url":"https://api.github.com/users/Mugen87/events{/privacy}","received_events_url":"https://api.github.com/users/Mugen87/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T07:51:05Z","updated_at":"2016-12-06T07:51:05Z","body":"I just wanted to highlight that i'm not a fan of the current method signature of `makePerspective` (so `fov`, `aspect` etc.). But renaming `makeFrustum` to `makePerspective` is a good solution."}}
{"actor":{"display_login":"Mugen87"}}