{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/pulls/1","id":57280370,"html_url":"https://github.com/marktimemedia/MLP-JQuery-Testing-Playground/pull/1","diff_url":"https://github.com/marktimemedia/MLP-JQuery-Testing-Playground/pull/1.diff","patch_url":"https://github.com/marktimemedia/MLP-JQuery-Testing-Playground/pull/1.patch","issue_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/issues/1","number":1,"state":"open","locked":false,"title":"Js cleanup","user":{"login":"ssmathias","id":746211,"avatar_url":"https://avatars.githubusercontent.com/u/746211?v=3","gravatar_id":"","url":"https://api.github.com/users/ssmathias","html_url":"https://github.com/ssmathias","followers_url":"https://api.github.com/users/ssmathias/followers","following_url":"https://api.github.com/users/ssmathias/following{/other_user}","gists_url":"https://api.github.com/users/ssmathias/gists{/gist_id}","starred_url":"https://api.github.com/users/ssmathias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssmathias/subscriptions","organizations_url":"https://api.github.com/users/ssmathias/orgs","repos_url":"https://api.github.com/users/ssmathias/repos","events_url":"https://api.github.com/users/ssmathias/events{/privacy}","received_events_url":"https://api.github.com/users/ssmathias/received_events","type":"User","site_admin":false},"body":"Hey,\r\n\r\nI ran into your code through one of our developers, @dannyb195, utilizing the magic-gallery-pony.js file within one of our projects. He had me review it, and I came up with a bit of feedback. He encouraged me to reach out to you with that feedback, and I saw that this code is largely a playground for learning jQuery and JavaScript.\r\n\r\nAnyway, I took the opportunity to refactor the JS code in this file significantly, partly to improve readability, and partly to improve performance. I tried to use the commit messages and comments that I've added in order to explain the reasoning and benefits, but I'd also be happy to go over them further with you if you're interested.\r\n\r\nGreat work so far, though! This sort of plugin is a bit complicated, and the code was relatively clean and well-structured. Certainly enough so that I was able to get through it and follow what it was doing!","created_at":"2016-01-26T22:06:35Z","updated_at":"2016-01-26T22:06:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/pulls/1/commits","review_comments_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/pulls/1/comments","review_comment_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/issues/1/comments","statuses_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/statuses/4b8d3e5c047ffedbb30c03887760859ebee332f1","head":{"label":"ssmathias:js-cleanup","ref":"js-cleanup","sha":"4b8d3e5c047ffedbb30c03887760859ebee332f1","user":{"login":"ssmathias","id":746211,"avatar_url":"https://avatars.githubusercontent.com/u/746211?v=3","gravatar_id":"","url":"https://api.github.com/users/ssmathias","html_url":"https://github.com/ssmathias","followers_url":"https://api.github.com/users/ssmathias/followers","following_url":"https://api.github.com/users/ssmathias/following{/other_user}","gists_url":"https://api.github.com/users/ssmathias/gists{/gist_id}","starred_url":"https://api.github.com/users/ssmathias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssmathias/subscriptions","organizations_url":"https://api.github.com/users/ssmathias/orgs","repos_url":"https://api.github.com/users/ssmathias/repos","events_url":"https://api.github.com/users/ssmathias/events{/privacy}","received_events_url":"https://api.github.com/users/ssmathias/received_events","type":"User","site_admin":false},"repo":{"id":50385832,"name":"MLP-JQuery-Testing-Playground","full_name":"ssmathias/MLP-JQuery-Testing-Playground","owner":{"login":"ssmathias","id":746211,"avatar_url":"https://avatars.githubusercontent.com/u/746211?v=3","gravatar_id":"","url":"https://api.github.com/users/ssmathias","html_url":"https://github.com/ssmathias","followers_url":"https://api.github.com/users/ssmathias/followers","following_url":"https://api.github.com/users/ssmathias/following{/other_user}","gists_url":"https://api.github.com/users/ssmathias/gists{/gist_id}","starred_url":"https://api.github.com/users/ssmathias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssmathias/subscriptions","organizations_url":"https://api.github.com/users/ssmathias/orgs","repos_url":"https://api.github.com/users/ssmathias/repos","events_url":"https://api.github.com/users/ssmathias/events{/privacy}","received_events_url":"https://api.github.com/users/ssmathias/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssmathias/MLP-JQuery-Testing-Playground","description":"The heaviest Static HTML site ever, but with ponies!","fork":true,"url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground","forks_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/forks","keys_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/teams","hooks_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/hooks","issue_events_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/issues/events{/number}","events_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/events","assignees_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/assignees{/user}","branches_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/branches{/branch}","tags_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/tags","blobs_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/statuses/{sha}","languages_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/languages","stargazers_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/stargazers","contributors_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/contributors","subscribers_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/subscribers","subscription_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/subscription","commits_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/contents/{+path}","compare_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/merges","archive_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/downloads","issues_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/issues{/number}","pulls_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/pulls{/number}","milestones_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/milestones{/number}","notifications_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/labels{/name}","releases_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/releases{/id}","deployments_url":"https://api.github.com/repos/ssmathias/MLP-JQuery-Testing-Playground/deployments","created_at":"2016-01-25T22:32:32Z","updated_at":"2016-01-25T22:32:33Z","pushed_at":"2016-01-26T17:03:39Z","git_url":"git://github.com/ssmathias/MLP-JQuery-Testing-Playground.git","ssh_url":"git@github.com:ssmathias/MLP-JQuery-Testing-Playground.git","clone_url":"https://github.com/ssmathias/MLP-JQuery-Testing-Playground.git","svn_url":"https://github.com/ssmathias/MLP-JQuery-Testing-Playground","homepage":null,"size":4821,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marktimemedia:master","ref":"master","sha":"e6f0110f4f75fba1c76924005af44ba27da8eb18","user":{"login":"marktimemedia","id":5798380,"avatar_url":"https://avatars.githubusercontent.com/u/5798380?v=3","gravatar_id":"","url":"https://api.github.com/users/marktimemedia","html_url":"https://github.com/marktimemedia","followers_url":"https://api.github.com/users/marktimemedia/followers","following_url":"https://api.github.com/users/marktimemedia/following{/other_user}","gists_url":"https://api.github.com/users/marktimemedia/gists{/gist_id}","starred_url":"https://api.github.com/users/marktimemedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marktimemedia/subscriptions","organizations_url":"https://api.github.com/users/marktimemedia/orgs","repos_url":"https://api.github.com/users/marktimemedia/repos","events_url":"https://api.github.com/users/marktimemedia/events{/privacy}","received_events_url":"https://api.github.com/users/marktimemedia/received_events","type":"User","site_admin":false},"repo":{"id":35445662,"name":"MLP-JQuery-Testing-Playground","full_name":"marktimemedia/MLP-JQuery-Testing-Playground","owner":{"login":"marktimemedia","id":5798380,"avatar_url":"https://avatars.githubusercontent.com/u/5798380?v=3","gravatar_id":"","url":"https://api.github.com/users/marktimemedia","html_url":"https://github.com/marktimemedia","followers_url":"https://api.github.com/users/marktimemedia/followers","following_url":"https://api.github.com/users/marktimemedia/following{/other_user}","gists_url":"https://api.github.com/users/marktimemedia/gists{/gist_id}","starred_url":"https://api.github.com/users/marktimemedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marktimemedia/subscriptions","organizations_url":"https://api.github.com/users/marktimemedia/orgs","repos_url":"https://api.github.com/users/marktimemedia/repos","events_url":"https://api.github.com/users/marktimemedia/events{/privacy}","received_events_url":"https://api.github.com/users/marktimemedia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marktimemedia/MLP-JQuery-Testing-Playground","description":"The heaviest Static HTML site ever, but with ponies!","fork":false,"url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground","forks_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/forks","keys_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/teams","hooks_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/hooks","issue_events_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/issues/events{/number}","events_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/events","assignees_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/assignees{/user}","branches_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/branches{/branch}","tags_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/tags","blobs_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/git/refs{/sha}","trees_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/statuses/{sha}","languages_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/languages","stargazers_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/stargazers","contributors_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/contributors","subscribers_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/subscribers","subscription_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/subscription","commits_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/commits{/sha}","git_commits_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/git/commits{/sha}","comments_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/comments{/number}","issue_comment_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/issues/comments{/number}","contents_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/contents/{+path}","compare_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/merges","archive_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/downloads","issues_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/issues{/number}","pulls_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/pulls{/number}","milestones_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/milestones{/number}","notifications_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/labels{/name}","releases_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/releases{/id}","deployments_url":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/deployments","created_at":"2015-05-11T19:36:42Z","updated_at":"2016-01-23T04:29:59Z","pushed_at":"2016-01-26T22:06:35Z","git_url":"git://github.com/marktimemedia/MLP-JQuery-Testing-Playground.git","ssh_url":"git@github.com:marktimemedia/MLP-JQuery-Testing-Playground.git","clone_url":"https://github.com/marktimemedia/MLP-JQuery-Testing-Playground.git","svn_url":"https://github.com/marktimemedia/MLP-JQuery-Testing-Playground","homepage":null,"size":4766,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/pulls/1"},"html":{"href":"https://github.com/marktimemedia/MLP-JQuery-Testing-Playground/pull/1"},"issue":{"href":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/issues/1"},"comments":{"href":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/marktimemedia/MLP-JQuery-Testing-Playground/statuses/4b8d3e5c047ffedbb30c03887760859ebee332f1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":13,"additions":254,"deletions":236,"changed_files":1}}