{"action":"created","comment":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/comments/90234553","pull_request_review_id":10755933,"id":90234553,"diff_hunk":"@@ -344,13 +352,23 @@ pub fn create_connected_nodes_with_cache_till_split(network: &Network) -> Vec<Te\n                     Event::NodeAdded(..) |\n                     Event::Connected |\n                     Event::Tick => (),\n-                    Event::GroupSplit(..) => break 'outer,\n+                    Event::GroupSplit(prefix) => {\n+                        let _ = split_events.insert(prefix);\n+                        if split_events.len() == split_count {\n+                            break 'outer;","path":"tests/mock_crust/utils.rs","position":28,"original_position":28,"commit_id":"6d98ede79f206b4abd4ab89861bd47cad475dd72","original_commit_id":"6d98ede79f206b4abd4ab89861bd47cad475dd72","user":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"body":"Right, I missed that. Makes sense! :+1: ","created_at":"2016-11-30T13:49:24Z","updated_at":"2016-11-30T13:52:13Z","html_url":"https://github.com/maidsafe/routing/pull/1254#discussion_r90234553","pull_request_url":"https://api.github.com/repos/maidsafe/routing/pulls/1254","_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments/90234553"},"html":{"href":"https://github.com/maidsafe/routing/pull/1254#discussion_r90234553"},"pull_request":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1254"}}},"pull_request":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/1254","id":95886135,"html_url":"https://github.com/maidsafe/routing/pull/1254","diff_url":"https://github.com/maidsafe/routing/pull/1254.diff","patch_url":"https://github.com/maidsafe/routing/pull/1254.patch","issue_url":"https://api.github.com/repos/maidsafe/routing/issues/1254","number":1254,"state":"open","locked":false,"title":"MAID-1827 MAID-1831: fixed handling of 'OwnGroupMerge' messages","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"body":"Also added a basic regression test for merging three groups into one.","created_at":"2016-11-30T12:55:45Z","updated_at":"2016-11-30T13:52:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66b6676843544dae76636651028200176c533ba9","assignee":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"assignees":[{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/routing/pulls/1254/commits","review_comments_url":"https://api.github.com/repos/maidsafe/routing/pulls/1254/comments","review_comment_url":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/routing/issues/1254/comments","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/6d98ede79f206b4abd4ab89861bd47cad475dd72","head":{"label":"Fraser999:MAID-1827","ref":"MAID-1827","sha":"6d98ede79f206b4abd4ab89861bd47cad475dd72","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"repo":{"id":32315702,"name":"routing","full_name":"Fraser999/routing","owner":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fraser999/routing","description":"Routing - specialised storage DHT","fork":true,"url":"https://api.github.com/repos/Fraser999/routing","forks_url":"https://api.github.com/repos/Fraser999/routing/forks","keys_url":"https://api.github.com/repos/Fraser999/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fraser999/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fraser999/routing/teams","hooks_url":"https://api.github.com/repos/Fraser999/routing/hooks","issue_events_url":"https://api.github.com/repos/Fraser999/routing/issues/events{/number}","events_url":"https://api.github.com/repos/Fraser999/routing/events","assignees_url":"https://api.github.com/repos/Fraser999/routing/assignees{/user}","branches_url":"https://api.github.com/repos/Fraser999/routing/branches{/branch}","tags_url":"https://api.github.com/repos/Fraser999/routing/tags","blobs_url":"https://api.github.com/repos/Fraser999/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fraser999/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fraser999/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fraser999/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fraser999/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/Fraser999/routing/languages","stargazers_url":"https://api.github.com/repos/Fraser999/routing/stargazers","contributors_url":"https://api.github.com/repos/Fraser999/routing/contributors","subscribers_url":"https://api.github.com/repos/Fraser999/routing/subscribers","subscription_url":"https://api.github.com/repos/Fraser999/routing/subscription","commits_url":"https://api.github.com/repos/Fraser999/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fraser999/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fraser999/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fraser999/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fraser999/routing/contents/{+path}","compare_url":"https://api.github.com/repos/Fraser999/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fraser999/routing/merges","archive_url":"https://api.github.com/repos/Fraser999/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fraser999/routing/downloads","issues_url":"https://api.github.com/repos/Fraser999/routing/issues{/number}","pulls_url":"https://api.github.com/repos/Fraser999/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/Fraser999/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/Fraser999/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fraser999/routing/labels{/name}","releases_url":"https://api.github.com/repos/Fraser999/routing/releases{/id}","deployments_url":"https://api.github.com/repos/Fraser999/routing/deployments","created_at":"2015-03-16T09:53:56Z","updated_at":"2016-01-11T11:52:43Z","pushed_at":"2016-11-30T12:58:02Z","git_url":"git://github.com/Fraser999/routing.git","ssh_url":"git@github.com:Fraser999/routing.git","clone_url":"https://github.com/Fraser999/routing.git","svn_url":"https://github.com/Fraser999/routing","homepage":null,"size":8301,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"46751245ba76743307bcec7b9cc06c3020bf33a8","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":31270514,"name":"routing","full_name":"maidsafe/routing","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/routing","description":"Routing - specialised storage DHT","fork":false,"url":"https://api.github.com/repos/maidsafe/routing","forks_url":"https://api.github.com/repos/maidsafe/routing/forks","keys_url":"https://api.github.com/repos/maidsafe/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/routing/teams","hooks_url":"https://api.github.com/repos/maidsafe/routing/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/routing/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/routing/events","assignees_url":"https://api.github.com/repos/maidsafe/routing/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/routing/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/routing/tags","blobs_url":"https://api.github.com/repos/maidsafe/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/routing/languages","stargazers_url":"https://api.github.com/repos/maidsafe/routing/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/routing/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/routing/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/routing/subscription","commits_url":"https://api.github.com/repos/maidsafe/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/routing/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/routing/merges","archive_url":"https://api.github.com/repos/maidsafe/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/routing/downloads","issues_url":"https://api.github.com/repos/maidsafe/routing/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/routing/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/routing/releases{/id}","deployments_url":"https://api.github.com/repos/maidsafe/routing/deployments","created_at":"2015-02-24T16:52:53Z","updated_at":"2016-11-19T11:03:39Z","pushed_at":"2016-11-30T12:58:02Z","git_url":"git://github.com/maidsafe/routing.git","ssh_url":"git@github.com:maidsafe/routing.git","clone_url":"https://github.com/maidsafe/routing.git","svn_url":"https://github.com/maidsafe/routing","homepage":null,"size":110626,"stargazers_count":107,"watchers_count":107,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":10,"forks":39,"open_issues":10,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1254"},"html":{"href":"https://github.com/maidsafe/routing/pull/1254"},"issue":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1254"},"comments":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1254/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1254/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1254/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/routing/statuses/6d98ede79f206b4abd4ab89861bd47cad475dd72"}}}}
{"actor":{"display_login":"afck"}}