{"action":"created","comment":{"url":"https://api.github.com/repos/castleproject/Core/pulls/comments/55934550","id":55934550,"diff_hunk":"@@ -0,0 +1,58 @@\n+<#\n+\n+.SYNOPSIS\n+\n+Extracts build version information from Settings.proj and the\n+environment. Then constructs several flavor version strings and\n+uses them, along with the current year to\n+\n+  - update buildscripts/CommonAssemblyInfo.cs,\n+  - update all project.json files, and\n+  - emit TeamCity directives so it can know about the values\n+\n+#>\n+\n+[xml] $settings = Get-Content 'Settings.proj'\n+$version_group = $settings.Project.PropertyGroup[1]\n+\n+$major = $version_group.Project_Major\n+$minor = $version_group.Project_Minor\n+$build = $version_group.Project_Build\n+\n+if ( $env:release_build -eq \"true\" )\n+{\n+    $version_suffix = \"\"\n+}\n+else\n+{\n+    $version_suffix = \"-ci{0:00000}\" -f [int]$env:build_number\n+}\n+\n+$assembly_version = \"$major.$minor.0\";","path":"buildscripts/Set-VersionInfo.ps1","position":31,"original_position":31,"commit_id":"2757cc4aa7293149913bbafec71d920d6391c5a6","original_commit_id":"2757cc4aa7293149913bbafec71d920d6391c5a6","user":{"login":"jonorossi","id":126297,"avatar_url":"https://avatars.githubusercontent.com/u/126297?v=3","gravatar_id":"","url":"https://api.github.com/users/jonorossi","html_url":"https://github.com/jonorossi","followers_url":"https://api.github.com/users/jonorossi/followers","following_url":"https://api.github.com/users/jonorossi/following{/other_user}","gists_url":"https://api.github.com/users/jonorossi/gists{/gist_id}","starred_url":"https://api.github.com/users/jonorossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonorossi/subscriptions","organizations_url":"https://api.github.com/users/jonorossi/orgs","repos_url":"https://api.github.com/users/jonorossi/repos","events_url":"https://api.github.com/users/jonorossi/events{/privacy}","received_events_url":"https://api.github.com/users/jonorossi/received_events","type":"User","site_admin":false},"body":"I wonder if making the assembly version \"M.0.0.0\" is a better idea, otherwise it becomes a breaking change for the .NET Framework since it is strong named. Realised this when I saw Serilog does that.","created_at":"2016-03-13T09:39:45Z","updated_at":"2016-03-13T09:39:45Z","html_url":"https://github.com/castleproject/Core/pull/153#discussion_r55934550","pull_request_url":"https://api.github.com/repos/castleproject/Core/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/castleproject/Core/pulls/comments/55934550"},"html":{"href":"https://github.com/castleproject/Core/pull/153#discussion_r55934550"},"pull_request":{"href":"https://api.github.com/repos/castleproject/Core/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/castleproject/Core/pulls/153","id":62344766,"html_url":"https://github.com/castleproject/Core/pull/153","diff_url":"https://github.com/castleproject/Core/pull/153.diff","patch_url":"https://github.com/castleproject/Core/pull/153.patch","issue_url":"https://api.github.com/repos/castleproject/Core/issues/153","number":153,"state":"open","locked":false,"title":"Consolidate version numbers","user":{"login":"blairconrad","id":3275797,"avatar_url":"https://avatars.githubusercontent.com/u/3275797?v=3","gravatar_id":"","url":"https://api.github.com/users/blairconrad","html_url":"https://github.com/blairconrad","followers_url":"https://api.github.com/users/blairconrad/followers","following_url":"https://api.github.com/users/blairconrad/following{/other_user}","gists_url":"https://api.github.com/users/blairconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/blairconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blairconrad/subscriptions","organizations_url":"https://api.github.com/users/blairconrad/orgs","repos_url":"https://api.github.com/users/blairconrad/repos","events_url":"https://api.github.com/users/blairconrad/events{/privacy}","received_events_url":"https://api.github.com/users/blairconrad/received_events","type":"User","site_admin":false},"body":"For discussion, here's _an_ approach that consolidates version numbers (#152).\r\nIt restores file generation, just to write in the TeamCity `build_number`, as I could not figure out how to supply it.\r\nWorse, in order to support a \"clone and build in the IDE\" experience, it generates the file in a pre-build step.\r\n\r\nI'm not sure how well-regarded any of this is, but present it for consideration/discussion.\r\n\r\n**Update - wildly different implementation added**","created_at":"2016-03-10T06:20:39Z","updated_at":"2016-03-13T09:39:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cb5efb4ddb6c465801a993485ad9ce27b232b7e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/castleproject/Core/pulls/153/commits","review_comments_url":"https://api.github.com/repos/castleproject/Core/pulls/153/comments","review_comment_url":"https://api.github.com/repos/castleproject/Core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/castleproject/Core/issues/153/comments","statuses_url":"https://api.github.com/repos/castleproject/Core/statuses/2757cc4aa7293149913bbafec71d920d6391c5a6","head":{"label":"blairconrad:consolidate-version-numbers","ref":"consolidate-version-numbers","sha":"2757cc4aa7293149913bbafec71d920d6391c5a6","user":{"login":"blairconrad","id":3275797,"avatar_url":"https://avatars.githubusercontent.com/u/3275797?v=3","gravatar_id":"","url":"https://api.github.com/users/blairconrad","html_url":"https://github.com/blairconrad","followers_url":"https://api.github.com/users/blairconrad/followers","following_url":"https://api.github.com/users/blairconrad/following{/other_user}","gists_url":"https://api.github.com/users/blairconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/blairconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blairconrad/subscriptions","organizations_url":"https://api.github.com/users/blairconrad/orgs","repos_url":"https://api.github.com/users/blairconrad/repos","events_url":"https://api.github.com/users/blairconrad/events{/privacy}","received_events_url":"https://api.github.com/users/blairconrad/received_events","type":"User","site_admin":false},"repo":{"id":13232948,"name":"Core","full_name":"blairconrad/Core","owner":{"login":"blairconrad","id":3275797,"avatar_url":"https://avatars.githubusercontent.com/u/3275797?v=3","gravatar_id":"","url":"https://api.github.com/users/blairconrad","html_url":"https://github.com/blairconrad","followers_url":"https://api.github.com/users/blairconrad/followers","following_url":"https://api.github.com/users/blairconrad/following{/other_user}","gists_url":"https://api.github.com/users/blairconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/blairconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blairconrad/subscriptions","organizations_url":"https://api.github.com/users/blairconrad/orgs","repos_url":"https://api.github.com/users/blairconrad/repos","events_url":"https://api.github.com/users/blairconrad/events{/privacy}","received_events_url":"https://api.github.com/users/blairconrad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blairconrad/Core","description":"","fork":true,"url":"https://api.github.com/repos/blairconrad/Core","forks_url":"https://api.github.com/repos/blairconrad/Core/forks","keys_url":"https://api.github.com/repos/blairconrad/Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blairconrad/Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blairconrad/Core/teams","hooks_url":"https://api.github.com/repos/blairconrad/Core/hooks","issue_events_url":"https://api.github.com/repos/blairconrad/Core/issues/events{/number}","events_url":"https://api.github.com/repos/blairconrad/Core/events","assignees_url":"https://api.github.com/repos/blairconrad/Core/assignees{/user}","branches_url":"https://api.github.com/repos/blairconrad/Core/branches{/branch}","tags_url":"https://api.github.com/repos/blairconrad/Core/tags","blobs_url":"https://api.github.com/repos/blairconrad/Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blairconrad/Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blairconrad/Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/blairconrad/Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blairconrad/Core/statuses/{sha}","languages_url":"https://api.github.com/repos/blairconrad/Core/languages","stargazers_url":"https://api.github.com/repos/blairconrad/Core/stargazers","contributors_url":"https://api.github.com/repos/blairconrad/Core/contributors","subscribers_url":"https://api.github.com/repos/blairconrad/Core/subscribers","subscription_url":"https://api.github.com/repos/blairconrad/Core/subscription","commits_url":"https://api.github.com/repos/blairconrad/Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/blairconrad/Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/blairconrad/Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/blairconrad/Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/blairconrad/Core/contents/{+path}","compare_url":"https://api.github.com/repos/blairconrad/Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blairconrad/Core/merges","archive_url":"https://api.github.com/repos/blairconrad/Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blairconrad/Core/downloads","issues_url":"https://api.github.com/repos/blairconrad/Core/issues{/number}","pulls_url":"https://api.github.com/repos/blairconrad/Core/pulls{/number}","milestones_url":"https://api.github.com/repos/blairconrad/Core/milestones{/number}","notifications_url":"https://api.github.com/repos/blairconrad/Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blairconrad/Core/labels{/name}","releases_url":"https://api.github.com/repos/blairconrad/Core/releases{/id}","deployments_url":"https://api.github.com/repos/blairconrad/Core/deployments","created_at":"2013-10-01T02:28:11Z","updated_at":"2015-01-14T03:36:27Z","pushed_at":"2016-03-12T12:21:51Z","git_url":"git://github.com/blairconrad/Core.git","ssh_url":"git@github.com:blairconrad/Core.git","clone_url":"https://github.com/blairconrad/Core.git","svn_url":"https://github.com/blairconrad/Core","homepage":"","size":76030,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"castleproject:netcore","ref":"netcore","sha":"37684a9e8f36055c6e34459862e1e62e6589a82f","user":{"login":"castleproject","id":124839,"avatar_url":"https://avatars.githubusercontent.com/u/124839?v=3","gravatar_id":"","url":"https://api.github.com/users/castleproject","html_url":"https://github.com/castleproject","followers_url":"https://api.github.com/users/castleproject/followers","following_url":"https://api.github.com/users/castleproject/following{/other_user}","gists_url":"https://api.github.com/users/castleproject/gists{/gist_id}","starred_url":"https://api.github.com/users/castleproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castleproject/subscriptions","organizations_url":"https://api.github.com/users/castleproject/orgs","repos_url":"https://api.github.com/users/castleproject/repos","events_url":"https://api.github.com/users/castleproject/events{/privacy}","received_events_url":"https://api.github.com/users/castleproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2629424,"name":"Core","full_name":"castleproject/Core","owner":{"login":"castleproject","id":124839,"avatar_url":"https://avatars.githubusercontent.com/u/124839?v=3","gravatar_id":"","url":"https://api.github.com/users/castleproject","html_url":"https://github.com/castleproject","followers_url":"https://api.github.com/users/castleproject/followers","following_url":"https://api.github.com/users/castleproject/following{/other_user}","gists_url":"https://api.github.com/users/castleproject/gists{/gist_id}","starred_url":"https://api.github.com/users/castleproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castleproject/subscriptions","organizations_url":"https://api.github.com/users/castleproject/orgs","repos_url":"https://api.github.com/users/castleproject/repos","events_url":"https://api.github.com/users/castleproject/events{/privacy}","received_events_url":"https://api.github.com/users/castleproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/castleproject/Core","description":"Castle Core, including Castle DynamicProxy, Logging Services and DictionaryAdapter","fork":false,"url":"https://api.github.com/repos/castleproject/Core","forks_url":"https://api.github.com/repos/castleproject/Core/forks","keys_url":"https://api.github.com/repos/castleproject/Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/castleproject/Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/castleproject/Core/teams","hooks_url":"https://api.github.com/repos/castleproject/Core/hooks","issue_events_url":"https://api.github.com/repos/castleproject/Core/issues/events{/number}","events_url":"https://api.github.com/repos/castleproject/Core/events","assignees_url":"https://api.github.com/repos/castleproject/Core/assignees{/user}","branches_url":"https://api.github.com/repos/castleproject/Core/branches{/branch}","tags_url":"https://api.github.com/repos/castleproject/Core/tags","blobs_url":"https://api.github.com/repos/castleproject/Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/castleproject/Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/castleproject/Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/castleproject/Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/castleproject/Core/statuses/{sha}","languages_url":"https://api.github.com/repos/castleproject/Core/languages","stargazers_url":"https://api.github.com/repos/castleproject/Core/stargazers","contributors_url":"https://api.github.com/repos/castleproject/Core/contributors","subscribers_url":"https://api.github.com/repos/castleproject/Core/subscribers","subscription_url":"https://api.github.com/repos/castleproject/Core/subscription","commits_url":"https://api.github.com/repos/castleproject/Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/castleproject/Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/castleproject/Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/castleproject/Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/castleproject/Core/contents/{+path}","compare_url":"https://api.github.com/repos/castleproject/Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/castleproject/Core/merges","archive_url":"https://api.github.com/repos/castleproject/Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/castleproject/Core/downloads","issues_url":"https://api.github.com/repos/castleproject/Core/issues{/number}","pulls_url":"https://api.github.com/repos/castleproject/Core/pulls{/number}","milestones_url":"https://api.github.com/repos/castleproject/Core/milestones{/number}","notifications_url":"https://api.github.com/repos/castleproject/Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/castleproject/Core/labels{/name}","releases_url":"https://api.github.com/repos/castleproject/Core/releases{/id}","deployments_url":"https://api.github.com/repos/castleproject/Core/deployments","created_at":"2011-10-23T05:01:52Z","updated_at":"2016-03-10T22:00:54Z","pushed_at":"2016-03-13T08:22:23Z","git_url":"git://github.com/castleproject/Core.git","ssh_url":"git@github.com:castleproject/Core.git","clone_url":"https://github.com/castleproject/Core.git","svn_url":"https://github.com/castleproject/Core","homepage":"http://www.castleproject.org/","size":79341,"stargazers_count":303,"watchers_count":303,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":38,"forks":192,"open_issues":38,"watchers":303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/castleproject/Core/pulls/153"},"html":{"href":"https://github.com/castleproject/Core/pull/153"},"issue":{"href":"https://api.github.com/repos/castleproject/Core/issues/153"},"comments":{"href":"https://api.github.com/repos/castleproject/Core/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/castleproject/Core/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/castleproject/Core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/castleproject/Core/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/castleproject/Core/statuses/2757cc4aa7293149913bbafec71d920d6391c5a6"}}}}