{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/84753315","pull_request_review_id":5503667,"id":84753315,"diff_hunk":"@@ -0,0 +1,29 @@\n+//\n+//  ASControlTargetAction.h\n+//  AsyncDisplayKit\n+//\n+//  Copyright (c) 2014-present, Facebook, Inc.  All rights reserved.\n+//  This source code is licensed under the BSD-style license found in the\n+//  LICENSE file in the root directory of this source tree. An additional grant\n+//  of patent rights can be found in the PATENTS file in the same directory.\n+//\n+\n+#import <Foundation/Foundation.h>\n+\n+/**\n+ @abstract ASControlTargetAction stores target action pairs registered for specific ASControlNodeEvent values.\n+ ASControlNode This class stores target action pairs similar to the UIControlTargetAction class.","path":"AsyncDisplayKit/Private/ASControlTargetAction.h","position":15,"original_position":15,"commit_id":"8a5da1451b99dd48d4fa223f7bdd38089e57c29d","original_commit_id":"8a5da1451b99dd48d4fa223f7bdd38089e57c29d","user":{"login":"Adlai-Holler","id":2466893,"avatar_url":"https://avatars.githubusercontent.com/u/2466893?v=3","gravatar_id":"","url":"https://api.github.com/users/Adlai-Holler","html_url":"https://github.com/Adlai-Holler","followers_url":"https://api.github.com/users/Adlai-Holler/followers","following_url":"https://api.github.com/users/Adlai-Holler/following{/other_user}","gists_url":"https://api.github.com/users/Adlai-Holler/gists{/gist_id}","starred_url":"https://api.github.com/users/Adlai-Holler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adlai-Holler/subscriptions","organizations_url":"https://api.github.com/users/Adlai-Holler/orgs","repos_url":"https://api.github.com/users/Adlai-Holler/repos","events_url":"https://api.github.com/users/Adlai-Holler/events{/privacy}","received_events_url":"https://api.github.com/users/Adlai-Holler/received_events","type":"User","site_admin":false},"body":"Just to be sure, let's remove the private Apple class name. They don't like those.","created_at":"2016-10-24T18:33:33Z","updated_at":"2016-10-24T18:33:40Z","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/2456#discussion_r84753315","pull_request_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/2456","_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/84753315"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/2456#discussion_r84753315"},"pull_request":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/2456"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/2456","id":90420668,"html_url":"https://github.com/facebook/AsyncDisplayKit/pull/2456","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/2456.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/2456.patch","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/2456","number":2456,"state":"open","locked":false,"title":"[ASControlNode] Invoke target actions in the same order as they were added","user":{"login":"tamaskarai","id":4365684,"avatar_url":"https://avatars.githubusercontent.com/u/4365684?v=3","gravatar_id":"","url":"https://api.github.com/users/tamaskarai","html_url":"https://github.com/tamaskarai","followers_url":"https://api.github.com/users/tamaskarai/followers","following_url":"https://api.github.com/users/tamaskarai/following{/other_user}","gists_url":"https://api.github.com/users/tamaskarai/gists{/gist_id}","starred_url":"https://api.github.com/users/tamaskarai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamaskarai/subscriptions","organizations_url":"https://api.github.com/users/tamaskarai/orgs","repos_url":"https://api.github.com/users/tamaskarai/repos","events_url":"https://api.github.com/users/tamaskarai/events{/privacy}","received_events_url":"https://api.github.com/users/tamaskarai/received_events","type":"User","site_admin":false},"body":"Issue #2428 implementation\r\n\r\nIn the end I chose to store `ASControlTargetAction` objects in a `NSMutableArray` instead of storing C structs in a `std::vector`.\r\n\r\nLet me know if you need me to change anything on the implementation.","created_at":"2016-10-21T17:48:16Z","updated_at":"2016-10-24T18:33:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccbf409414e328ddfe6bc73cd7b9a6909e0981f0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/2456/commits","review_comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/2456/comments","review_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/2456/comments","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/8a5da1451b99dd48d4fa223f7bdd38089e57c29d","head":{"label":"tamaskarai:ASControlNodeActionOrder","ref":"ASControlNodeActionOrder","sha":"8a5da1451b99dd48d4fa223f7bdd38089e57c29d","user":{"login":"tamaskarai","id":4365684,"avatar_url":"https://avatars.githubusercontent.com/u/4365684?v=3","gravatar_id":"","url":"https://api.github.com/users/tamaskarai","html_url":"https://github.com/tamaskarai","followers_url":"https://api.github.com/users/tamaskarai/followers","following_url":"https://api.github.com/users/tamaskarai/following{/other_user}","gists_url":"https://api.github.com/users/tamaskarai/gists{/gist_id}","starred_url":"https://api.github.com/users/tamaskarai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamaskarai/subscriptions","organizations_url":"https://api.github.com/users/tamaskarai/orgs","repos_url":"https://api.github.com/users/tamaskarai/repos","events_url":"https://api.github.com/users/tamaskarai/events{/privacy}","received_events_url":"https://api.github.com/users/tamaskarai/received_events","type":"User","site_admin":false},"repo":{"id":71464233,"name":"AsyncDisplayKit","full_name":"tamaskarai/AsyncDisplayKit","owner":{"login":"tamaskarai","id":4365684,"avatar_url":"https://avatars.githubusercontent.com/u/4365684?v=3","gravatar_id":"","url":"https://api.github.com/users/tamaskarai","html_url":"https://github.com/tamaskarai","followers_url":"https://api.github.com/users/tamaskarai/followers","following_url":"https://api.github.com/users/tamaskarai/following{/other_user}","gists_url":"https://api.github.com/users/tamaskarai/gists{/gist_id}","starred_url":"https://api.github.com/users/tamaskarai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamaskarai/subscriptions","organizations_url":"https://api.github.com/users/tamaskarai/orgs","repos_url":"https://api.github.com/users/tamaskarai/repos","events_url":"https://api.github.com/users/tamaskarai/events{/privacy}","received_events_url":"https://api.github.com/users/tamaskarai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamaskarai/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":true,"url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit","forks_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/tamaskarai/AsyncDisplayKit/deployments","created_at":"2016-10-20T13:09:03Z","updated_at":"2016-10-20T13:09:06Z","pushed_at":"2016-10-24T11:37:52Z","git_url":"git://github.com/tamaskarai/AsyncDisplayKit.git","ssh_url":"git@github.com:tamaskarai/AsyncDisplayKit.git","clone_url":"https://github.com/tamaskarai/AsyncDisplayKit.git","svn_url":"https://github.com/tamaskarai/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":77875,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"4dca05767bf7f5d555746d8cb9e444de51bd458b","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21265042,"name":"AsyncDisplayKit","full_name":"facebook/AsyncDisplayKit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/facebook/AsyncDisplayKit","forks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/deployments","created_at":"2014-06-27T05:29:02Z","updated_at":"2016-10-24T14:32:25Z","pushed_at":"2016-10-24T18:16:08Z","git_url":"git://github.com/facebook/AsyncDisplayKit.git","ssh_url":"git@github.com:facebook/AsyncDisplayKit.git","clone_url":"https://github.com/facebook/AsyncDisplayKit.git","svn_url":"https://github.com/facebook/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":84077,"stargazers_count":9592,"watchers_count":9592,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1657,"mirror_url":null,"open_issues_count":194,"forks":1657,"open_issues":194,"watchers":9592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/2456"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/2456"},"issue":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/2456"},"comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/2456/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/2456/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/2456/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/8a5da1451b99dd48d4fa223f7bdd38089e57c29d"}}}}
{"actor":{"display_login":"Adlai-Holler"}}