{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/87824371","pull_request_review_id":8419837,"id":87824371,"diff_hunk":"@@ -33,66 +30,56 @@ var DefaultDetectors = Detectors{\n }\n \n // DetectRuby detects Ruby source\n-func DetectRuby(dir string) (*Info, bool) {\n+func DetectRuby(dir string) *Info {\n \treturn detect(\"ruby\", dir, \"Gemfile\", \"Rakefile\", \"config.ru\")\n }\n \n // DetectJava detects Java source\n-func DetectJava(dir string) (*Info, bool) {\n+func DetectJava(dir string) *Info {\n \treturn detect(\"jee\", dir, \"pom.xml\")\n }\n \n // DetectNodeJS detects NodeJS source\n-func DetectNodeJS(dir string) (*Info, bool) {\n+func DetectNodeJS(dir string) *Info {\n \treturn detect(\"nodejs\", dir, \"app.json\", \"package.json\")\n }\n \n // DetectPHP detects PHP source\n-func DetectPHP(dir string) (*Info, bool) {\n+func DetectPHP(dir string) *Info {\n \treturn detect(\"php\", dir, \"index.php\", \"composer.json\")\n }\n \n // DetectPython detects Python source\n-func DetectPython(dir string) (*Info, bool) {\n+func DetectPython(dir string) *Info {\n \treturn detect(\"python\", dir, \"requirements.txt\", \"setup.py\")\n }\n \n // DetectPerl detects Perl source\n-func DetectPerl(dir string) (*Info, bool) {\n+func DetectPerl(dir string) *Info {\n \treturn detect(\"perl\", dir, \"index.pl\", \"cpanfile\")\n }\n \n // DetectScala detects Scala source\n-func DetectScala(dir string) (*Info, bool) {\n+func DetectScala(dir string) *Info {\n \treturn detect(\"scala\", dir, \"build.sbt\")\n }\n \n // DetectDotNet detects .NET source and matches it to a dotnet supported annotatin or dotnet imagestream name","path":"pkg/generate/source/detector.go","position":65,"original_position":65,"commit_id":"90d47d2fd5d5bac560c3103c4aca119f2d0a8a34","original_commit_id":"90d47d2fd5d5bac560c3103c4aca119f2d0a8a34","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"annotation (i know, not your fault but it's bugging me now :) )\r\n","created_at":"2016-11-14T15:36:48Z","updated_at":"2016-11-14T15:36:48Z","html_url":"https://github.com/openshift/origin/pull/11896#discussion_r87824371","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/11896","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/87824371"},"html":{"href":"https://github.com/openshift/origin/pull/11896#discussion_r87824371"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/11896"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/11896","id":93549187,"html_url":"https://github.com/openshift/origin/pull/11896","diff_url":"https://github.com/openshift/origin/pull/11896.diff","patch_url":"https://github.com/openshift/origin/pull/11896.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/11896","number":11896,"state":"open","locked":false,"title":"Support csproj files for identifying .NET Core projects","user":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars.githubusercontent.com/u/1038301?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"Fixes #11842 \r\n\r\n@bparees ptal - I removed DetectLiteralDotNet() because I couldn't see how it could possibly be triggered?","created_at":"2016-11-14T11:22:21Z","updated_at":"2016-11-14T15:36:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63bf964d632365da56b3fd63159ccb3391818b1f","assignee":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"assignees":[{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/11896/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/11896/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/11896/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/90d47d2fd5d5bac560c3103c4aca119f2d0a8a34","head":{"label":"jim-minter:issue11842","ref":"issue11842","sha":"90d47d2fd5d5bac560c3103c4aca119f2d0a8a34","user":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars.githubusercontent.com/u/1038301?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"repo":{"id":63237830,"name":"origin","full_name":"jim-minter/origin","owner":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars.githubusercontent.com/u/1038301?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jim-minter/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":true,"url":"https://api.github.com/repos/jim-minter/origin","forks_url":"https://api.github.com/repos/jim-minter/origin/forks","keys_url":"https://api.github.com/repos/jim-minter/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jim-minter/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jim-minter/origin/teams","hooks_url":"https://api.github.com/repos/jim-minter/origin/hooks","issue_events_url":"https://api.github.com/repos/jim-minter/origin/issues/events{/number}","events_url":"https://api.github.com/repos/jim-minter/origin/events","assignees_url":"https://api.github.com/repos/jim-minter/origin/assignees{/user}","branches_url":"https://api.github.com/repos/jim-minter/origin/branches{/branch}","tags_url":"https://api.github.com/repos/jim-minter/origin/tags","blobs_url":"https://api.github.com/repos/jim-minter/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jim-minter/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jim-minter/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jim-minter/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jim-minter/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/jim-minter/origin/languages","stargazers_url":"https://api.github.com/repos/jim-minter/origin/stargazers","contributors_url":"https://api.github.com/repos/jim-minter/origin/contributors","subscribers_url":"https://api.github.com/repos/jim-minter/origin/subscribers","subscription_url":"https://api.github.com/repos/jim-minter/origin/subscription","commits_url":"https://api.github.com/repos/jim-minter/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jim-minter/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jim-minter/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jim-minter/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jim-minter/origin/contents/{+path}","compare_url":"https://api.github.com/repos/jim-minter/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jim-minter/origin/merges","archive_url":"https://api.github.com/repos/jim-minter/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jim-minter/origin/downloads","issues_url":"https://api.github.com/repos/jim-minter/origin/issues{/number}","pulls_url":"https://api.github.com/repos/jim-minter/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/jim-minter/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/jim-minter/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jim-minter/origin/labels{/name}","releases_url":"https://api.github.com/repos/jim-minter/origin/releases{/id}","deployments_url":"https://api.github.com/repos/jim-minter/origin/deployments","created_at":"2016-07-13T10:39:40Z","updated_at":"2016-07-13T10:39:49Z","pushed_at":"2016-11-14T15:29:34Z","git_url":"git://github.com/jim-minter/origin.git","ssh_url":"git@github.com:jim-minter/origin.git","clone_url":"https://github.com/jim-minter/origin.git","svn_url":"https://github.com/jim-minter/origin","homepage":"http://www.openshift.org","size":374189,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"9c4f9eeced93c12c275e477aa21045a56f956916","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-11-14T10:34:36Z","pushed_at":"2016-11-14T15:29:35Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":626582,"stargazers_count":2005,"watchers_count":2005,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1344,"mirror_url":null,"open_issues_count":1157,"forks":1344,"open_issues":1157,"watchers":2005,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/11896"},"html":{"href":"https://github.com/openshift/origin/pull/11896"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/11896"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/11896/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/11896/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/11896/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/90d47d2fd5d5bac560c3103c4aca119f2d0a8a34"}}}}
{"actor":{"display_login":"bparees"}}