{"action":"created","comment":{"url":"https://api.github.com/repos/dropbox/kafka/pulls/comments/73594955","id":73594955,"diff_hunk":"@@ -175,17 +181,18 @@ type BrokerConf struct {\n \n func NewBrokerConf(clientID string) BrokerConf {\n \treturn BrokerConf{\n-\t\tClientID:               clientID,\n-\t\tDialTimeout:            10 * time.Second,\n-\t\tDialRetryLimit:         10,\n-\t\tDialRetryWait:          500 * time.Millisecond,\n-\t\tAllowTopicCreation:     false,\n-\t\tLeaderRetryLimit:       10,\n-\t\tLeaderRetryWait:        500 * time.Millisecond,\n-\t\tMetadataRefreshTimeout: 30 * time.Second,\n-\t\tConnectionLimit:        10,\n-\t\tIdleConnectionLimit:    5,\n-\t\tIdleConnectionWait:     200 * time.Millisecond,\n+\t\tClientID:                 clientID,\n+\t\tDialTimeout:              10 * time.Second,\n+\t\tDialRetryLimit:           10,\n+\t\tDialRetryWait:            500 * time.Millisecond,\n+\t\tAllowTopicCreation:       false,\n+\t\tLeaderRetryLimit:         10,\n+\t\tLeaderRetryWait:          500 * time.Millisecond,\n+\t\tMetadataRefreshTimeout:   30 * time.Second,\n+\t\tMetadataRefreshFrequency: 0,","path":"broker.go","position":36,"original_position":36,"commit_id":"766754217822ed306b46a68a98c082057c4e000f","original_commit_id":"766754217822ed306b46a68a98c082057c4e000f","user":{"login":"DrTall","id":4100658,"avatar_url":"https://avatars.githubusercontent.com/u/4100658?v=3","gravatar_id":"","url":"https://api.github.com/users/DrTall","html_url":"https://github.com/DrTall","followers_url":"https://api.github.com/users/DrTall/followers","following_url":"https://api.github.com/users/DrTall/following{/other_user}","gists_url":"https://api.github.com/users/DrTall/gists{/gist_id}","starred_url":"https://api.github.com/users/DrTall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrTall/subscriptions","organizations_url":"https://api.github.com/users/DrTall/orgs","repos_url":"https://api.github.com/users/DrTall/repos","events_url":"https://api.github.com/users/DrTall/events{/privacy}","received_events_url":"https://api.github.com/users/DrTall/received_events","type":"User","site_admin":false},"body":"I really don't have a good idea of what is a reasonable default, since it is pretty expensive. I figured if anybody else is using this client we can spare them a cluster meltdown by making them find the feature rather than surprising them.","created_at":"2016-08-04T20:19:27Z","updated_at":"2016-08-04T20:19:27Z","html_url":"https://github.com/dropbox/kafka/pull/8#discussion_r73594955","pull_request_url":"https://api.github.com/repos/dropbox/kafka/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/dropbox/kafka/pulls/comments/73594955"},"html":{"href":"https://github.com/dropbox/kafka/pull/8#discussion_r73594955"},"pull_request":{"href":"https://api.github.com/repos/dropbox/kafka/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/dropbox/kafka/pulls/8","id":80126364,"html_url":"https://github.com/dropbox/kafka/pull/8","diff_url":"https://github.com/dropbox/kafka/pull/8.diff","patch_url":"https://github.com/dropbox/kafka/pull/8.patch","issue_url":"https://api.github.com/repos/dropbox/kafka/issues/8","number":8,"state":"open","locked":false,"title":"Periodically refresh metadata","user":{"login":"DrTall","id":4100658,"avatar_url":"https://avatars.githubusercontent.com/u/4100658?v=3","gravatar_id":"","url":"https://api.github.com/users/DrTall","html_url":"https://github.com/DrTall","followers_url":"https://api.github.com/users/DrTall/followers","following_url":"https://api.github.com/users/DrTall/following{/other_user}","gists_url":"https://api.github.com/users/DrTall/gists{/gist_id}","starred_url":"https://api.github.com/users/DrTall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrTall/subscriptions","organizations_url":"https://api.github.com/users/DrTall/orgs","repos_url":"https://api.github.com/users/DrTall/repos","events_url":"https://api.github.com/users/DrTall/events{/privacy}","received_events_url":"https://api.github.com/users/DrTall/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-04T18:26:55Z","updated_at":"2016-08-04T20:19:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baa51093fa6ef2a52581723752e9550d5316f28d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dropbox/kafka/pulls/8/commits","review_comments_url":"https://api.github.com/repos/dropbox/kafka/pulls/8/comments","review_comment_url":"https://api.github.com/repos/dropbox/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dropbox/kafka/issues/8/comments","statuses_url":"https://api.github.com/repos/dropbox/kafka/statuses/766754217822ed306b46a68a98c082057c4e000f","head":{"label":"DrTall:autogen_wjsmkteg","ref":"autogen_wjsmkteg","sha":"766754217822ed306b46a68a98c082057c4e000f","user":{"login":"DrTall","id":4100658,"avatar_url":"https://avatars.githubusercontent.com/u/4100658?v=3","gravatar_id":"","url":"https://api.github.com/users/DrTall","html_url":"https://github.com/DrTall","followers_url":"https://api.github.com/users/DrTall/followers","following_url":"https://api.github.com/users/DrTall/following{/other_user}","gists_url":"https://api.github.com/users/DrTall/gists{/gist_id}","starred_url":"https://api.github.com/users/DrTall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrTall/subscriptions","organizations_url":"https://api.github.com/users/DrTall/orgs","repos_url":"https://api.github.com/users/DrTall/repos","events_url":"https://api.github.com/users/DrTall/events{/privacy}","received_events_url":"https://api.github.com/users/DrTall/received_events","type":"User","site_admin":false},"repo":{"id":57236007,"name":"kafka","full_name":"DrTall/kafka","owner":{"login":"DrTall","id":4100658,"avatar_url":"https://avatars.githubusercontent.com/u/4100658?v=3","gravatar_id":"","url":"https://api.github.com/users/DrTall","html_url":"https://github.com/DrTall","followers_url":"https://api.github.com/users/DrTall/followers","following_url":"https://api.github.com/users/DrTall/following{/other_user}","gists_url":"https://api.github.com/users/DrTall/gists{/gist_id}","starred_url":"https://api.github.com/users/DrTall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrTall/subscriptions","organizations_url":"https://api.github.com/users/DrTall/orgs","repos_url":"https://api.github.com/users/DrTall/repos","events_url":"https://api.github.com/users/DrTall/events{/privacy}","received_events_url":"https://api.github.com/users/DrTall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DrTall/kafka","description":"Go driver for Kafka","fork":true,"url":"https://api.github.com/repos/DrTall/kafka","forks_url":"https://api.github.com/repos/DrTall/kafka/forks","keys_url":"https://api.github.com/repos/DrTall/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DrTall/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DrTall/kafka/teams","hooks_url":"https://api.github.com/repos/DrTall/kafka/hooks","issue_events_url":"https://api.github.com/repos/DrTall/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/DrTall/kafka/events","assignees_url":"https://api.github.com/repos/DrTall/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/DrTall/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/DrTall/kafka/tags","blobs_url":"https://api.github.com/repos/DrTall/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DrTall/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DrTall/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/DrTall/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DrTall/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/DrTall/kafka/languages","stargazers_url":"https://api.github.com/repos/DrTall/kafka/stargazers","contributors_url":"https://api.github.com/repos/DrTall/kafka/contributors","subscribers_url":"https://api.github.com/repos/DrTall/kafka/subscribers","subscription_url":"https://api.github.com/repos/DrTall/kafka/subscription","commits_url":"https://api.github.com/repos/DrTall/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/DrTall/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/DrTall/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/DrTall/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/DrTall/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/DrTall/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DrTall/kafka/merges","archive_url":"https://api.github.com/repos/DrTall/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DrTall/kafka/downloads","issues_url":"https://api.github.com/repos/DrTall/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/DrTall/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/DrTall/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/DrTall/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DrTall/kafka/labels{/name}","releases_url":"https://api.github.com/repos/DrTall/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/DrTall/kafka/deployments","created_at":"2016-04-27T18:20:45Z","updated_at":"2016-04-27T18:20:46Z","pushed_at":"2016-08-04T19:12:17Z","git_url":"git://github.com/DrTall/kafka.git","ssh_url":"git@github.com:DrTall/kafka.git","clone_url":"https://github.com/DrTall/kafka.git","svn_url":"https://github.com/DrTall/kafka","homepage":"https://godoc.org/github.com/optiopay/kafka","size":403,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dropbox:master","ref":"master","sha":"3ece58671f083835314f02e69f1d8fdd486dff12","user":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"repo":{"id":50959249,"name":"kafka","full_name":"dropbox/kafka","owner":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dropbox/kafka","description":"Go driver for Kafka","fork":true,"url":"https://api.github.com/repos/dropbox/kafka","forks_url":"https://api.github.com/repos/dropbox/kafka/forks","keys_url":"https://api.github.com/repos/dropbox/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropbox/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropbox/kafka/teams","hooks_url":"https://api.github.com/repos/dropbox/kafka/hooks","issue_events_url":"https://api.github.com/repos/dropbox/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/dropbox/kafka/events","assignees_url":"https://api.github.com/repos/dropbox/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/dropbox/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/dropbox/kafka/tags","blobs_url":"https://api.github.com/repos/dropbox/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropbox/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropbox/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropbox/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropbox/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/dropbox/kafka/languages","stargazers_url":"https://api.github.com/repos/dropbox/kafka/stargazers","contributors_url":"https://api.github.com/repos/dropbox/kafka/contributors","subscribers_url":"https://api.github.com/repos/dropbox/kafka/subscribers","subscription_url":"https://api.github.com/repos/dropbox/kafka/subscription","commits_url":"https://api.github.com/repos/dropbox/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropbox/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropbox/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropbox/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropbox/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/dropbox/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropbox/kafka/merges","archive_url":"https://api.github.com/repos/dropbox/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropbox/kafka/downloads","issues_url":"https://api.github.com/repos/dropbox/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/dropbox/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/dropbox/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/dropbox/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropbox/kafka/labels{/name}","releases_url":"https://api.github.com/repos/dropbox/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/dropbox/kafka/deployments","created_at":"2016-02-02T23:23:47Z","updated_at":"2016-07-22T22:45:34Z","pushed_at":"2016-08-04T19:12:26Z","git_url":"git://github.com/dropbox/kafka.git","ssh_url":"git@github.com:dropbox/kafka.git","clone_url":"https://github.com/dropbox/kafka.git","svn_url":"https://github.com/dropbox/kafka","homepage":"https://godoc.org/github.com/optiopay/kafka","size":404,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dropbox/kafka/pulls/8"},"html":{"href":"https://github.com/dropbox/kafka/pull/8"},"issue":{"href":"https://api.github.com/repos/dropbox/kafka/issues/8"},"comments":{"href":"https://api.github.com/repos/dropbox/kafka/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/dropbox/kafka/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/dropbox/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dropbox/kafka/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/dropbox/kafka/statuses/766754217822ed306b46a68a98c082057c4e000f"}}}}
{"actor":{"display_login":"DrTall"}}