{"action":"created","comment":{"url":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/comments/89918927","pull_request_review_id":10447376,"id":89918927,"diff_hunk":"@@ -15,42 +18,10 @@ export default class Home extends React.Component {\n       <div>\n         <div className={ this.styler('grid') }>\n           <h1>Overview</h1>\n-          <p className={ this.styler('page-dek') }>The dashboard provides an overview of your organizations, spaces, and applications. For full management and deployment of applications, use the <a href=\"https://docs.cloud.gov/getting-started/setup/\">command line interface</a>.\n+          <p className={ this.styler('page-dek') }>The dashboard provides an overview of your organizations, spaces, and applications. For full management and deployment of applications, use the <a href={ skinConfig.docs.cli }>command line interface</a>.","path":"static_src/components/home.jsx","position":16,"original_position":16,"commit_id":"71f3e5691ed1eb41b0b865bc19647a8ba37438f4","original_commit_id":"71f3e5691ed1eb41b0b865bc19647a8ba37438f4","user":{"login":"msecret","id":1701077,"avatar_url":"https://avatars.githubusercontent.com/u/1701077?v=3","gravatar_id":"","url":"https://api.github.com/users/msecret","html_url":"https://github.com/msecret","followers_url":"https://api.github.com/users/msecret/followers","following_url":"https://api.github.com/users/msecret/following{/other_user}","gists_url":"https://api.github.com/users/msecret/gists{/gist_id}","starred_url":"https://api.github.com/users/msecret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msecret/subscriptions","organizations_url":"https://api.github.com/users/msecret/orgs","repos_url":"https://api.github.com/users/msecret/repos","events_url":"https://api.github.com/users/msecret/events{/privacy}","received_events_url":"https://api.github.com/users/msecret/received_events","type":"User","site_admin":false},"body":"While I think this solution for docs links works for now, I do think there's a better solution for them. I'll starting thinking about it. That being said, we might not have much need for a more robust solution, maybe there won't be that many docs links.","created_at":"2016-11-29T00:43:03Z","updated_at":"2016-11-29T00:46:26Z","html_url":"https://github.com/AusDTO/cg-dashboard/pull/2#discussion_r89918927","pull_request_url":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/comments/89918927"},"html":{"href":"https://github.com/AusDTO/cg-dashboard/pull/2#discussion_r89918927"},"pull_request":{"href":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/2","id":95126352,"html_url":"https://github.com/AusDTO/cg-dashboard/pull/2","diff_url":"https://github.com/AusDTO/cg-dashboard/pull/2.diff","patch_url":"https://github.com/AusDTO/cg-dashboard/pull/2.patch","issue_url":"https://api.github.com/repos/AusDTO/cg-dashboard/issues/2","number":2,"state":"open","locked":false,"title":"Allow for slightly different content for different deployments","user":{"login":"tessereth","id":4583474,"avatar_url":"https://avatars.githubusercontent.com/u/4583474?v=3","gravatar_id":"","url":"https://api.github.com/users/tessereth","html_url":"https://github.com/tessereth","followers_url":"https://api.github.com/users/tessereth/followers","following_url":"https://api.github.com/users/tessereth/following{/other_user}","gists_url":"https://api.github.com/users/tessereth/gists{/gist_id}","starred_url":"https://api.github.com/users/tessereth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tessereth/subscriptions","organizations_url":"https://api.github.com/users/tessereth/orgs","repos_url":"https://api.github.com/users/tessereth/repos","events_url":"https://api.github.com/users/tessereth/events{/privacy}","received_events_url":"https://api.github.com/users/tessereth/received_events","type":"User","site_admin":false},"body":"There are some differences we need between our deployment and 18F. This PR is tackling the content differences. There are a few different ways this could be done, including just changing the content. But I wanted to explore an approach where 18F and DTA could use the same code base. This PR does not change everything we need to update but provides a proof of concept that changes:\r\n\r\n* some static text (eg the disclaimer)\r\n* some links (eg CLI docs)\r\n* The links in the top nav\r\n* The content of the home page\r\n\r\nIt works by creating config files for each \"skin\" and aliasing the `skin` module in the webpack config based on the `$CG_SKIN` environment variable. This seems to work but given this is the first javascript codebase I've worked with (let alone react/webpack etc), I don't know if that's a good idea or not. Also, naming things is hard so some of the names could use a little work.\r\n\r\nMost of it was pretty straight forward but the home page was a little more interesting. The home page seemed to be a collection of blocks, some of which applied to DTA and some of which didn't. Because the blocks include markup (lists, links etc) it seemed odd to put them in the config file. Instead I split them into components and put a list of components in the config file and dynamically put them in the grid. I did have to change the markup of the home page slightly for this to work.\r\n\r\nSo I have a few questions for 18F folk about this:\r\n\r\n1. Does this seem like a sensible way of doing this?\r\n2. Is this something you could see merging in upstream? I was thinking it might even be useful for you to be able to change a few things between the eastwest and govcloud deployments (eg the link to govcloud on the home page).\r\n3. Anything else you feel like mentioning.\r\n\r\nThanks for your help!","created_at":"2016-11-24T07:02:57Z","updated_at":"2016-11-29T00:46:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"412986df20ecf97f05f74c3d0287d44fbe8d990f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/2/commits","review_comments_url":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/2/comments","review_comment_url":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AusDTO/cg-dashboard/issues/2/comments","statuses_url":"https://api.github.com/repos/AusDTO/cg-dashboard/statuses/71f3e5691ed1eb41b0b865bc19647a8ba37438f4","head":{"label":"AusDTO:feature/skin","ref":"feature/skin","sha":"71f3e5691ed1eb41b0b865bc19647a8ba37438f4","user":{"login":"AusDTO","id":11763427,"avatar_url":"https://avatars.githubusercontent.com/u/11763427?v=3","gravatar_id":"","url":"https://api.github.com/users/AusDTO","html_url":"https://github.com/AusDTO","followers_url":"https://api.github.com/users/AusDTO/followers","following_url":"https://api.github.com/users/AusDTO/following{/other_user}","gists_url":"https://api.github.com/users/AusDTO/gists{/gist_id}","starred_url":"https://api.github.com/users/AusDTO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AusDTO/subscriptions","organizations_url":"https://api.github.com/users/AusDTO/orgs","repos_url":"https://api.github.com/users/AusDTO/repos","events_url":"https://api.github.com/users/AusDTO/events{/privacy}","received_events_url":"https://api.github.com/users/AusDTO/received_events","type":"Organization","site_admin":false},"repo":{"id":68174060,"name":"cg-dashboard","full_name":"AusDTO/cg-dashboard","owner":{"login":"AusDTO","id":11763427,"avatar_url":"https://avatars.githubusercontent.com/u/11763427?v=3","gravatar_id":"","url":"https://api.github.com/users/AusDTO","html_url":"https://github.com/AusDTO","followers_url":"https://api.github.com/users/AusDTO/followers","following_url":"https://api.github.com/users/AusDTO/following{/other_user}","gists_url":"https://api.github.com/users/AusDTO/gists{/gist_id}","starred_url":"https://api.github.com/users/AusDTO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AusDTO/subscriptions","organizations_url":"https://api.github.com/users/AusDTO/orgs","repos_url":"https://api.github.com/users/AusDTO/repos","events_url":"https://api.github.com/users/AusDTO/events{/privacy}","received_events_url":"https://api.github.com/users/AusDTO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AusDTO/cg-dashboard","description":"A web dashboard for managing Cloud Foundry Apps","fork":true,"url":"https://api.github.com/repos/AusDTO/cg-dashboard","forks_url":"https://api.github.com/repos/AusDTO/cg-dashboard/forks","keys_url":"https://api.github.com/repos/AusDTO/cg-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AusDTO/cg-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AusDTO/cg-dashboard/teams","hooks_url":"https://api.github.com/repos/AusDTO/cg-dashboard/hooks","issue_events_url":"https://api.github.com/repos/AusDTO/cg-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/AusDTO/cg-dashboard/events","assignees_url":"https://api.github.com/repos/AusDTO/cg-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/AusDTO/cg-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/AusDTO/cg-dashboard/tags","blobs_url":"https://api.github.com/repos/AusDTO/cg-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AusDTO/cg-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AusDTO/cg-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/AusDTO/cg-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AusDTO/cg-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/AusDTO/cg-dashboard/languages","stargazers_url":"https://api.github.com/repos/AusDTO/cg-dashboard/stargazers","contributors_url":"https://api.github.com/repos/AusDTO/cg-dashboard/contributors","subscribers_url":"https://api.github.com/repos/AusDTO/cg-dashboard/subscribers","subscription_url":"https://api.github.com/repos/AusDTO/cg-dashboard/subscription","commits_url":"https://api.github.com/repos/AusDTO/cg-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/AusDTO/cg-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/AusDTO/cg-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/AusDTO/cg-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/AusDTO/cg-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/AusDTO/cg-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AusDTO/cg-dashboard/merges","archive_url":"https://api.github.com/repos/AusDTO/cg-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AusDTO/cg-dashboard/downloads","issues_url":"https://api.github.com/repos/AusDTO/cg-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/AusDTO/cg-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/AusDTO/cg-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AusDTO/cg-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/AusDTO/cg-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/AusDTO/cg-dashboard/deployments","created_at":"2016-09-14T04:46:24Z","updated_at":"2016-09-14T04:46:25Z","pushed_at":"2016-11-24T07:02:57Z","git_url":"git://github.com/AusDTO/cg-dashboard.git","ssh_url":"git@github.com:AusDTO/cg-dashboard.git","clone_url":"https://github.com/AusDTO/cg-dashboard.git","svn_url":"https://github.com/AusDTO/cg-dashboard","homepage":"https://dashboard.cloud.gov","size":4127,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"AusDTO:master","ref":"master","sha":"8922ad474c53d7251d87f0ae311fec3c0056b80f","user":{"login":"AusDTO","id":11763427,"avatar_url":"https://avatars.githubusercontent.com/u/11763427?v=3","gravatar_id":"","url":"https://api.github.com/users/AusDTO","html_url":"https://github.com/AusDTO","followers_url":"https://api.github.com/users/AusDTO/followers","following_url":"https://api.github.com/users/AusDTO/following{/other_user}","gists_url":"https://api.github.com/users/AusDTO/gists{/gist_id}","starred_url":"https://api.github.com/users/AusDTO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AusDTO/subscriptions","organizations_url":"https://api.github.com/users/AusDTO/orgs","repos_url":"https://api.github.com/users/AusDTO/repos","events_url":"https://api.github.com/users/AusDTO/events{/privacy}","received_events_url":"https://api.github.com/users/AusDTO/received_events","type":"Organization","site_admin":false},"repo":{"id":68174060,"name":"cg-dashboard","full_name":"AusDTO/cg-dashboard","owner":{"login":"AusDTO","id":11763427,"avatar_url":"https://avatars.githubusercontent.com/u/11763427?v=3","gravatar_id":"","url":"https://api.github.com/users/AusDTO","html_url":"https://github.com/AusDTO","followers_url":"https://api.github.com/users/AusDTO/followers","following_url":"https://api.github.com/users/AusDTO/following{/other_user}","gists_url":"https://api.github.com/users/AusDTO/gists{/gist_id}","starred_url":"https://api.github.com/users/AusDTO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AusDTO/subscriptions","organizations_url":"https://api.github.com/users/AusDTO/orgs","repos_url":"https://api.github.com/users/AusDTO/repos","events_url":"https://api.github.com/users/AusDTO/events{/privacy}","received_events_url":"https://api.github.com/users/AusDTO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AusDTO/cg-dashboard","description":"A web dashboard for managing Cloud Foundry Apps","fork":true,"url":"https://api.github.com/repos/AusDTO/cg-dashboard","forks_url":"https://api.github.com/repos/AusDTO/cg-dashboard/forks","keys_url":"https://api.github.com/repos/AusDTO/cg-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AusDTO/cg-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AusDTO/cg-dashboard/teams","hooks_url":"https://api.github.com/repos/AusDTO/cg-dashboard/hooks","issue_events_url":"https://api.github.com/repos/AusDTO/cg-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/AusDTO/cg-dashboard/events","assignees_url":"https://api.github.com/repos/AusDTO/cg-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/AusDTO/cg-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/AusDTO/cg-dashboard/tags","blobs_url":"https://api.github.com/repos/AusDTO/cg-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AusDTO/cg-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AusDTO/cg-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/AusDTO/cg-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AusDTO/cg-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/AusDTO/cg-dashboard/languages","stargazers_url":"https://api.github.com/repos/AusDTO/cg-dashboard/stargazers","contributors_url":"https://api.github.com/repos/AusDTO/cg-dashboard/contributors","subscribers_url":"https://api.github.com/repos/AusDTO/cg-dashboard/subscribers","subscription_url":"https://api.github.com/repos/AusDTO/cg-dashboard/subscription","commits_url":"https://api.github.com/repos/AusDTO/cg-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/AusDTO/cg-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/AusDTO/cg-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/AusDTO/cg-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/AusDTO/cg-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/AusDTO/cg-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AusDTO/cg-dashboard/merges","archive_url":"https://api.github.com/repos/AusDTO/cg-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AusDTO/cg-dashboard/downloads","issues_url":"https://api.github.com/repos/AusDTO/cg-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/AusDTO/cg-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/AusDTO/cg-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AusDTO/cg-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/AusDTO/cg-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/AusDTO/cg-dashboard/deployments","created_at":"2016-09-14T04:46:24Z","updated_at":"2016-09-14T04:46:25Z","pushed_at":"2016-11-24T07:02:57Z","git_url":"git://github.com/AusDTO/cg-dashboard.git","ssh_url":"git@github.com:AusDTO/cg-dashboard.git","clone_url":"https://github.com/AusDTO/cg-dashboard.git","svn_url":"https://github.com/AusDTO/cg-dashboard","homepage":"https://dashboard.cloud.gov","size":4127,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/2"},"html":{"href":"https://github.com/AusDTO/cg-dashboard/pull/2"},"issue":{"href":"https://api.github.com/repos/AusDTO/cg-dashboard/issues/2"},"comments":{"href":"https://api.github.com/repos/AusDTO/cg-dashboard/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AusDTO/cg-dashboard/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/AusDTO/cg-dashboard/statuses/71f3e5691ed1eb41b0b865bc19647a8ba37438f4"}}}}
{"actor":{"display_login":"msecret"}}