{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/90491679","pull_request_review_id":10890354,"id":90491679,"diff_hunk":"@@ -508,6 +517,20 @@ public void onTimer(TimerInternals.TimerData timer) throws Exception {\n     return MoreObjects.firstNonNull(elems, Collections.<WindowedValue<T>>emptyList());\n   }\n \n+  @SuppressWarnings({\"unchecked\", \"rawtypes\"})\n+  public <T> List<WindowedValue<T>> getOrCreateOutput(TupleTag<T> tag) {","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java","position":21,"original_position":21,"commit_id":"63f20be58108d8d5c2d99cd60b2eb6a9b95d3991","original_commit_id":"63f20be58108d8d5c2d99cd60b2eb6a9b95d3991","user":{"login":"tgroh","id":429866,"avatar_url":"https://avatars.githubusercontent.com/u/429866?v=3","gravatar_id":"","url":"https://api.github.com/users/tgroh","html_url":"https://github.com/tgroh","followers_url":"https://api.github.com/users/tgroh/followers","following_url":"https://api.github.com/users/tgroh/following{/other_user}","gists_url":"https://api.github.com/users/tgroh/gists{/gist_id}","starred_url":"https://api.github.com/users/tgroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgroh/subscriptions","organizations_url":"https://api.github.com/users/tgroh/orgs","repos_url":"https://api.github.com/users/tgroh/repos","events_url":"https://api.github.com/users/tgroh/events{/privacy}","received_events_url":"https://api.github.com/users/tgroh/received_events","type":"User","site_admin":false},"body":"Unless there's a mirrored `getOuput` which throws if it doesn't exist, this should just be `getOutput`","created_at":"2016-12-01T17:06:48Z","updated_at":"2016-12-01T17:08:29Z","html_url":"https://github.com/apache/incubator-beam/pull/1261#discussion_r90491679","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1261","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/90491679"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1261#discussion_r90491679"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1261"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1261","id":92027275,"html_url":"https://github.com/apache/incubator-beam/pull/1261","diff_url":"https://github.com/apache/incubator-beam/pull/1261.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1261.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1261","number":1261,"state":"open","locked":false,"title":"[BEAM-801, BEAM-787] Improvements to Splittable DoFn","user":{"login":"jkff","id":343722,"avatar_url":"https://avatars.githubusercontent.com/u/343722?v=3","gravatar_id":"","url":"https://api.github.com/users/jkff","html_url":"https://github.com/jkff","followers_url":"https://api.github.com/users/jkff/followers","following_url":"https://api.github.com/users/jkff/following{/other_user}","gists_url":"https://api.github.com/users/jkff/gists{/gist_id}","starred_url":"https://api.github.com/users/jkff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkff/subscriptions","organizations_url":"https://api.github.com/users/jkff/orgs","repos_url":"https://api.github.com/users/jkff/repos","events_url":"https://api.github.com/users/jkff/events{/privacy}","received_events_url":"https://api.github.com/users/jkff/received_events","type":"User","site_admin":false},"body":"Makes Splittable DoFn be more like a real DoFn:\r\n- Adds support for side inputs and outputs to SDF\r\n- Teaches `ProcessFn` to work with exploded windows inside the\r\n  `KeyedWorkItem`. It works with them by un-exploding the windows\r\n  in the `Iterable<WindowedValue<ElementAndRestriction>>` into a\r\n  single `WindowedValue`, since the values and timestamps are\r\n  guaranteed to be the same.\r\n\r\nMakes SplittableParDo.ProcessFn not use the (now unavailable)\r\nOldDoFn state and timers API:\r\n- Makes `ProcessFn` be a primitive transform with its own\r\n  `ParDoEvaluator`. As a nice side effect, this enables the runner to\r\n  provide additional hooks into it - e.g. for giving the runner access\r\n  to the restriction tracker (in later PRs)\r\n- For consistency, moves declaration of `GBKIntoKeyedWorkItems`\r\n  primitive transform into `SplittableParDo`, alongside the\r\n  `SplittableProcessElements` transform\r\n- Preserves compressed representation of `WindowedValue`'s in\r\n  `PushbackSideInputDoFnRunner`\r\n\r\nTODO: Tests for new features\r\nTODO: Trigger on the GBK between initial split and ProcessFn\r\nshould be like the ReshuffleTrigger.\r\nR: @kennknowles @tgroh ","created_at":"2016-11-02T18:19:29Z","updated_at":"2016-12-01T17:08:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2d12eb91afd24fa6137becb5eb5d2d0cfa4e0ef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1261/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1261/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1261/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/63f20be58108d8d5c2d99cd60b2eb6a9b95d3991","head":{"label":"jkff:enable-sdf","ref":"enable-sdf","sha":"63f20be58108d8d5c2d99cd60b2eb6a9b95d3991","user":{"login":"jkff","id":343722,"avatar_url":"https://avatars.githubusercontent.com/u/343722?v=3","gravatar_id":"","url":"https://api.github.com/users/jkff","html_url":"https://github.com/jkff","followers_url":"https://api.github.com/users/jkff/followers","following_url":"https://api.github.com/users/jkff/following{/other_user}","gists_url":"https://api.github.com/users/jkff/gists{/gist_id}","starred_url":"https://api.github.com/users/jkff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkff/subscriptions","organizations_url":"https://api.github.com/users/jkff/orgs","repos_url":"https://api.github.com/users/jkff/repos","events_url":"https://api.github.com/users/jkff/events{/privacy}","received_events_url":"https://api.github.com/users/jkff/received_events","type":"User","site_admin":false},"repo":{"id":53902119,"name":"incubator-beam","full_name":"jkff/incubator-beam","owner":{"login":"jkff","id":343722,"avatar_url":"https://avatars.githubusercontent.com/u/343722?v=3","gravatar_id":"","url":"https://api.github.com/users/jkff","html_url":"https://github.com/jkff","followers_url":"https://api.github.com/users/jkff/followers","following_url":"https://api.github.com/users/jkff/following{/other_user}","gists_url":"https://api.github.com/users/jkff/gists{/gist_id}","starred_url":"https://api.github.com/users/jkff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkff/subscriptions","organizations_url":"https://api.github.com/users/jkff/orgs","repos_url":"https://api.github.com/users/jkff/repos","events_url":"https://api.github.com/users/jkff/events{/privacy}","received_events_url":"https://api.github.com/users/jkff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkff/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/jkff/incubator-beam","forks_url":"https://api.github.com/repos/jkff/incubator-beam/forks","keys_url":"https://api.github.com/repos/jkff/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkff/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkff/incubator-beam/teams","hooks_url":"https://api.github.com/repos/jkff/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/jkff/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/jkff/incubator-beam/events","assignees_url":"https://api.github.com/repos/jkff/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/jkff/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/jkff/incubator-beam/tags","blobs_url":"https://api.github.com/repos/jkff/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkff/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkff/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkff/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkff/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/jkff/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/jkff/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/jkff/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/jkff/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/jkff/incubator-beam/subscription","commits_url":"https://api.github.com/repos/jkff/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkff/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkff/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkff/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkff/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/jkff/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkff/incubator-beam/merges","archive_url":"https://api.github.com/repos/jkff/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkff/incubator-beam/downloads","issues_url":"https://api.github.com/repos/jkff/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/jkff/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/jkff/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/jkff/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkff/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/jkff/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/jkff/incubator-beam/deployments","created_at":"2016-03-15T00:32:38Z","updated_at":"2016-03-15T00:32:41Z","pushed_at":"2016-12-01T01:22:08Z","git_url":"git://github.com/jkff/incubator-beam.git","ssh_url":"git@github.com:jkff/incubator-beam.git","clone_url":"https://github.com/jkff/incubator-beam.git","svn_url":"https://github.com/jkff/incubator-beam","homepage":null,"size":22292,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"711c68092fd771c3f9be4a5d0dd0ecf077f1aeab","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-12-01T09:45:06Z","pushed_at":"2016-12-01T16:21:00Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":36879,"stargazers_count":506,"watchers_count":506,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":298,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":67,"forks":298,"open_issues":67,"watchers":506,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1261"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1261"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1261"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1261/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1261/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1261/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/63f20be58108d8d5c2d99cd60b2eb6a9b95d3991"}}}}
{"actor":{"display_login":"tgroh"}}