{"action":"created","comment":{"url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/comments/78285653","id":78285653,"diff_hunk":"@@ -43,11 +43,11 @@\n var google_conversion_value = 0;\n /* ]]> */\n </script>\n-<script type=\"text/javascript\" src=\"http://www.googleadservices.com/pagead/conversion.js\">\n+<script type=\"text/javascript\" src=\"//www.googleadservices.com/pagead/conversion.js\">","path":"templates/about/contact-us/form/thank-you.html","position":5,"original_position":5,"commit_id":"c96fd1d000ff33e7f595cc608482492f74aac08b","original_commit_id":"c96fd1d000ff33e7f595cc608482492f74aac08b","user":{"login":"nottrobin","id":519935,"avatar_url":"https://avatars.githubusercontent.com/u/519935?v=3","gravatar_id":"","url":"https://api.github.com/users/nottrobin","html_url":"https://github.com/nottrobin","followers_url":"https://api.github.com/users/nottrobin/followers","following_url":"https://api.github.com/users/nottrobin/following{/other_user}","gists_url":"https://api.github.com/users/nottrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/nottrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nottrobin/subscriptions","organizations_url":"https://api.github.com/users/nottrobin/orgs","repos_url":"https://api.github.com/users/nottrobin/repos","events_url":"https://api.github.com/users/nottrobin/events{/privacy}","received_events_url":"https://api.github.com/users/nottrobin/received_events","type":"User","site_admin":false},"body":"HTTPS please","created_at":"2016-09-10T23:31:37Z","updated_at":"2016-09-10T23:31:37Z","html_url":"https://github.com/ubuntudesign/www.ubuntu.com/pull/846#discussion_r78285653","pull_request_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/846","_links":{"self":{"href":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/comments/78285653"},"html":{"href":"https://github.com/ubuntudesign/www.ubuntu.com/pull/846#discussion_r78285653"},"pull_request":{"href":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/846"}}},"pull_request":{"url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/846","id":84770016,"html_url":"https://github.com/ubuntudesign/www.ubuntu.com/pull/846","diff_url":"https://github.com/ubuntudesign/www.ubuntu.com/pull/846.diff","patch_url":"https://github.com/ubuntudesign/www.ubuntu.com/pull/846.patch","issue_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/issues/846","number":846,"state":"open","locked":false,"title":"Tidy up the local js","user":{"login":"anthonydillon","id":1413534,"avatar_url":"https://avatars.githubusercontent.com/u/1413534?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonydillon","html_url":"https://github.com/anthonydillon","followers_url":"https://api.github.com/users/anthonydillon/followers","following_url":"https://api.github.com/users/anthonydillon/following{/other_user}","gists_url":"https://api.github.com/users/anthonydillon/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydillon/subscriptions","organizations_url":"https://api.github.com/users/anthonydillon/orgs","repos_url":"https://api.github.com/users/anthonydillon/repos","events_url":"https://api.github.com/users/anthonydillon/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydillon/received_events","type":"User","site_admin":false},"body":"## Done\r\n- Removed jQuery from every page and added it to the form pages\r\n- Removed import protocols\r\n- Replace http iframes to https\r\n\r\n### QA\r\nSorry this is again a long QA. I think I have now removed all YUI completely once this and the scratch branch lands. Apart from the sliders. They will require a discussion and a follow up branch.\r\n \r\n - [ ] Go to /about/contact-us/form and check there are no js errors. Submit an empty form and it should validate\r\n - [ ] Go to /cloud/contact-us and check there are no js errors. Submit an empty form and it should validate\r\n - [ ] Go to /cloud and check there are no js errors. Check the D3 chart renders in the \"Use Ubuntu on certified public clouds\" section\r\n - [ ] Go to /cloud/openstack and check there are no js errors.\r\n - [ ] Go to /cloud/openstack/managed-cloud and check there are no js errors.\r\n - [ ] Go to /cloud/openstack/managed-cloud/contact-us and check there are no js errors.\r\n - [ ] Go to /cloud/openstack/managed-cloud/thank-you you will see a jQuery error but that is resolved in the Tidy up scratch branch\r\n - [ ] Go to /cloud/partners/ You will find some YUI in the footer but that has been replaced in the Tidy up scratch branch\r\n - [ ] Go to /cloud/storage/contact-us and you should find no js errors\r\n - [ ] Go to /cloud/thank-you and you should see a missing jQuery dep. This function is coming from scratch and has been rewritten in ES5 in the Tidy up scratch branch\r\n - [ ] Go to /cloud/training/classroom-contact-us and check there are no js errors\r\n - [ ] Go to /cloud/training/contact-us and there should be no js errors\r\n - [ ] Go to /cloud/training/onsite-contact-us and check there are no errors\r\n - [ ] Go to /cloud/training/server-admin-onsite-contact-us and check there are no js errors\r\n - [ ] Go to /cloud/training/thank-you and you will see a jQuery in scratch that is resolved with the Tidy up scratch branch\r\n - [ ] Go to /desktop/contact-us and you should see no errors\r\n - [ ] Go to /desktop/features and scroll to the 'Photos' section and it should have a background image with a caption in the bottom right. There will be a jQuery error from scratch but that is fixed in the scratch branch\r\n - [ ] Go to /desktop/partners and scroll to 'A SELECTION OF OUR DESKTOP PARTNERS' and check there is a list of logos\r\n - [ ] Go to /desktop/tenders-contact-us and check there are no js errors and the validation works\r\n - [ ] Go to /download/desktop/thank-you?version=16.04.1&architecture=amd64 and check the download starts\r\n - [ ] Go to /download/server/thank-you-linuxone and check there are no errors\r\n - [ ] Go to /download/server/thank-you?version=16.04.1&architecture=amd64 and check the download kicks off. There will be a jQuery error.\r\n - [ ] Go to /internet-of-things/contact-us and chec kthere is no errors.\r\n - [ ] Go to /internet-of-things/digital-signage/contact-us and check there are no errors.\r\n - [ ] Go to /internet-of-things/digital-signage/thank-you and check there is just the jquery scratch error\r\n - [ ] Go to /legal/contributors/submit and check you get the same errors as live\r\n - [ ] Go to /legal/terms-and-policies/contact-us and check you get the same errors as live\r\n - [ ] Go to /management/contact-us and check there are no errors and the validation works\r\n - [ ] Go to /server/contact-us and check there is no errors\r\n - [ ] Go to /tablet/contact-us and check for errors","created_at":"2016-09-10T22:34:56Z","updated_at":"2016-09-10T23:31:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2f8ac100ee7f9e29436097fe1b34d2f52fd1b07","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/milestones/3","html_url":"https://github.com/ubuntudesign/www.ubuntu.com/milestones/HTTPS","labels_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/milestones/3/labels","id":1995664,"number":3,"title":"HTTPS","description":"Switch the site to using HTTPS, once all insecure resources have been removed.","creator":{"login":"nottrobin","id":519935,"avatar_url":"https://avatars.githubusercontent.com/u/519935?v=3","gravatar_id":"","url":"https://api.github.com/users/nottrobin","html_url":"https://github.com/nottrobin","followers_url":"https://api.github.com/users/nottrobin/followers","following_url":"https://api.github.com/users/nottrobin/following{/other_user}","gists_url":"https://api.github.com/users/nottrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/nottrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nottrobin/subscriptions","organizations_url":"https://api.github.com/users/nottrobin/orgs","repos_url":"https://api.github.com/users/nottrobin/repos","events_url":"https://api.github.com/users/nottrobin/events{/privacy}","received_events_url":"https://api.github.com/users/nottrobin/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2016-09-10T18:47:50Z","updated_at":"2016-09-10T23:20:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/846/commits","review_comments_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/846/comments","review_comment_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/issues/846/comments","statuses_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/statuses/c96fd1d000ff33e7f595cc608482492f74aac08b","head":{"label":"anthonydillon:tidy-up-local-js","ref":"tidy-up-local-js","sha":"c96fd1d000ff33e7f595cc608482492f74aac08b","user":{"login":"anthonydillon","id":1413534,"avatar_url":"https://avatars.githubusercontent.com/u/1413534?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonydillon","html_url":"https://github.com/anthonydillon","followers_url":"https://api.github.com/users/anthonydillon/followers","following_url":"https://api.github.com/users/anthonydillon/following{/other_user}","gists_url":"https://api.github.com/users/anthonydillon/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydillon/subscriptions","organizations_url":"https://api.github.com/users/anthonydillon/orgs","repos_url":"https://api.github.com/users/anthonydillon/repos","events_url":"https://api.github.com/users/anthonydillon/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydillon/received_events","type":"User","site_admin":false},"repo":{"id":63166647,"name":"www.ubuntu.com","full_name":"anthonydillon/www.ubuntu.com","owner":{"login":"anthonydillon","id":1413534,"avatar_url":"https://avatars.githubusercontent.com/u/1413534?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonydillon","html_url":"https://github.com/anthonydillon","followers_url":"https://api.github.com/users/anthonydillon/followers","following_url":"https://api.github.com/users/anthonydillon/following{/other_user}","gists_url":"https://api.github.com/users/anthonydillon/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydillon/subscriptions","organizations_url":"https://api.github.com/users/anthonydillon/orgs","repos_url":"https://api.github.com/users/anthonydillon/repos","events_url":"https://api.github.com/users/anthonydillon/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydillon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anthonydillon/www.ubuntu.com","description":"Ubuntu website project using Vanilla Framework","fork":true,"url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com","forks_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/forks","keys_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/teams","hooks_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/hooks","issue_events_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/issues/events{/number}","events_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/events","assignees_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/assignees{/user}","branches_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/branches{/branch}","tags_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/tags","blobs_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/statuses/{sha}","languages_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/languages","stargazers_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/stargazers","contributors_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/contributors","subscribers_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/subscribers","subscription_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/subscription","commits_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/contents/{+path}","compare_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/merges","archive_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/downloads","issues_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/issues{/number}","pulls_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/pulls{/number}","milestones_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/milestones{/number}","notifications_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/labels{/name}","releases_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/releases{/id}","deployments_url":"https://api.github.com/repos/anthonydillon/www.ubuntu.com/deployments","created_at":"2016-07-12T14:52:04Z","updated_at":"2016-07-12T14:53:00Z","pushed_at":"2016-09-10T23:16:10Z","git_url":"git://github.com/anthonydillon/www.ubuntu.com.git","ssh_url":"git@github.com:anthonydillon/www.ubuntu.com.git","clone_url":"https://github.com/anthonydillon/www.ubuntu.com.git","svn_url":"https://github.com/anthonydillon/www.ubuntu.com","homepage":"http://www.ubuntu.com","size":4346,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ubuntudesign:master","ref":"master","sha":"16907ee55cda764d8015ea5ae762eddb16e0c8e5","user":{"login":"ubuntudesign","id":8777739,"avatar_url":"https://avatars.githubusercontent.com/u/8777739?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntudesign","html_url":"https://github.com/ubuntudesign","followers_url":"https://api.github.com/users/ubuntudesign/followers","following_url":"https://api.github.com/users/ubuntudesign/following{/other_user}","gists_url":"https://api.github.com/users/ubuntudesign/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntudesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntudesign/subscriptions","organizations_url":"https://api.github.com/users/ubuntudesign/orgs","repos_url":"https://api.github.com/users/ubuntudesign/repos","events_url":"https://api.github.com/users/ubuntudesign/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntudesign/received_events","type":"Organization","site_admin":false},"repo":{"id":23468646,"name":"www.ubuntu.com","full_name":"ubuntudesign/www.ubuntu.com","owner":{"login":"ubuntudesign","id":8777739,"avatar_url":"https://avatars.githubusercontent.com/u/8777739?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntudesign","html_url":"https://github.com/ubuntudesign","followers_url":"https://api.github.com/users/ubuntudesign/followers","following_url":"https://api.github.com/users/ubuntudesign/following{/other_user}","gists_url":"https://api.github.com/users/ubuntudesign/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntudesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntudesign/subscriptions","organizations_url":"https://api.github.com/users/ubuntudesign/orgs","repos_url":"https://api.github.com/users/ubuntudesign/repos","events_url":"https://api.github.com/users/ubuntudesign/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntudesign/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubuntudesign/www.ubuntu.com","description":"Ubuntu website project using Vanilla Framework","fork":false,"url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com","forks_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/forks","keys_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/teams","hooks_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/hooks","issue_events_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/issues/events{/number}","events_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/events","assignees_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/assignees{/user}","branches_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/branches{/branch}","tags_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/tags","blobs_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/statuses/{sha}","languages_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/languages","stargazers_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/stargazers","contributors_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/contributors","subscribers_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/subscribers","subscription_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/subscription","commits_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/contents/{+path}","compare_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/merges","archive_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/downloads","issues_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/issues{/number}","pulls_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls{/number}","milestones_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/milestones{/number}","notifications_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/labels{/name}","releases_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/releases{/id}","deployments_url":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/deployments","created_at":"2014-08-29T15:34:24Z","updated_at":"2016-07-05T10:22:46Z","pushed_at":"2016-09-10T23:20:57Z","git_url":"git://github.com/ubuntudesign/www.ubuntu.com.git","ssh_url":"git@github.com:ubuntudesign/www.ubuntu.com.git","clone_url":"https://github.com/ubuntudesign/www.ubuntu.com.git","svn_url":"https://github.com/ubuntudesign/www.ubuntu.com","homepage":"http://www.ubuntu.com","size":220070,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":33,"forks":8,"open_issues":33,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/846"},"html":{"href":"https://github.com/ubuntudesign/www.ubuntu.com/pull/846"},"issue":{"href":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/issues/846"},"comments":{"href":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/issues/846/comments"},"review_comments":{"href":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/846/comments"},"review_comment":{"href":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/pulls/846/commits"},"statuses":{"href":"https://api.github.com/repos/ubuntudesign/www.ubuntu.com/statuses/c96fd1d000ff33e7f595cc608482492f74aac08b"}}}}
{"actor":{"display_login":"nottrobin"}}