{"action":"created","issue":{"url":"https://api.github.com/repos/chowdhurya/rust-uritemplate/issues/2","repository_url":"https://api.github.com/repos/chowdhurya/rust-uritemplate","labels_url":"https://api.github.com/repos/chowdhurya/rust-uritemplate/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/chowdhurya/rust-uritemplate/issues/2/comments","events_url":"https://api.github.com/repos/chowdhurya/rust-uritemplate/issues/2/events","html_url":"https://github.com/chowdhurya/rust-uritemplate/pull/2","id":180536214,"number":2,"title":"ref: removing dependency to regex crate","user":{"login":"dfa1","id":5798698,"avatar_url":"https://avatars.githubusercontent.com/u/5798698?v=3","gravatar_id":"","url":"https://api.github.com/users/dfa1","html_url":"https://github.com/dfa1","followers_url":"https://api.github.com/users/dfa1/followers","following_url":"https://api.github.com/users/dfa1/following{/other_user}","gists_url":"https://api.github.com/users/dfa1/gists{/gist_id}","starred_url":"https://api.github.com/users/dfa1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfa1/subscriptions","organizations_url":"https://api.github.com/users/dfa1/orgs","repos_url":"https://api.github.com/users/dfa1/repos","events_url":"https://api.github.com/users/dfa1/events{/privacy}","received_events_url":"https://api.github.com/users/dfa1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-02T21:20:16Z","updated_at":"2016-10-16T20:30:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chowdhurya/rust-uritemplate/pulls/2","html_url":"https://github.com/chowdhurya/rust-uritemplate/pull/2","diff_url":"https://github.com/chowdhurya/rust-uritemplate/pull/2.diff","patch_url":"https://github.com/chowdhurya/rust-uritemplate/pull/2.patch"},"body":"I'm removing the regex crate since it is used only to correct any percent-encoded triplets whose percent signs were reencoded. \r\n\r\nThis behaviour could be confusing, if not wrong, since the url template according a unit test the string `\"hey!%%25\"` is expanded as ` \"hey!%25%25\"` instead of `\"hey!%25%2525\"`. Each `%` must be encoded separately as `%25`, IMHO.\r\n\r\nThis is also the behaviour of two uri template libraries that I use: spring-mvc (java) and  URI.js (javascript).\r\n\r\ndisclaimer: this is my first contribute to a rust library, please be patient :-)"},"comment":{"url":"https://api.github.com/repos/chowdhurya/rust-uritemplate/issues/comments/254072534","html_url":"https://github.com/chowdhurya/rust-uritemplate/pull/2#issuecomment-254072534","issue_url":"https://api.github.com/repos/chowdhurya/rust-uritemplate/issues/2","id":254072534,"user":{"login":"dfa1","id":5798698,"avatar_url":"https://avatars.githubusercontent.com/u/5798698?v=3","gravatar_id":"","url":"https://api.github.com/users/dfa1","html_url":"https://github.com/dfa1","followers_url":"https://api.github.com/users/dfa1/followers","following_url":"https://api.github.com/users/dfa1/following{/other_user}","gists_url":"https://api.github.com/users/dfa1/gists{/gist_id}","starred_url":"https://api.github.com/users/dfa1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfa1/subscriptions","organizations_url":"https://api.github.com/users/dfa1/orgs","repos_url":"https://api.github.com/users/dfa1/repos","events_url":"https://api.github.com/users/dfa1/events{/privacy}","received_events_url":"https://api.github.com/users/dfa1/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T20:30:50Z","updated_at":"2016-10-16T20:30:50Z","body":"According to 2.3 of RFC6570:\r\n> A varname MAY contain one or more pct-encoded triplets.  These\r\n   triplets are considered an essential part of the variable name and\r\n   are not decoded during processing.\r\n\r\nthis has been fixed in [this commit](https://github.com/chowdhurya/rust-uritemplate/pull/2/commits/4cffebeecd866c702e8ac5e6a879d98a36cb4c31)\r\n"}}
{"actor":{"display_login":"dfa1"}}