{"action":"opened","number":8,"pull_request":{"url":"https://api.github.com/repos/apsoto/lita-alias/pulls/8","id":98471292,"html_url":"https://github.com/apsoto/lita-alias/pull/8","diff_url":"https://github.com/apsoto/lita-alias/pull/8.diff","patch_url":"https://github.com/apsoto/lita-alias/pull/8.patch","issue_url":"https://api.github.com/repos/apsoto/lita-alias/issues/8","number":8,"state":"open","locked":false,"title":"Send alias extra arguments to original command","user":{"login":"babelop","id":3771540,"avatar_url":"https://avatars.githubusercontent.com/u/3771540?v=3","gravatar_id":"","url":"https://api.github.com/users/babelop","html_url":"https://github.com/babelop","followers_url":"https://api.github.com/users/babelop/followers","following_url":"https://api.github.com/users/babelop/following{/other_user}","gists_url":"https://api.github.com/users/babelop/gists{/gist_id}","starred_url":"https://api.github.com/users/babelop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babelop/subscriptions","organizations_url":"https://api.github.com/users/babelop/orgs","repos_url":"https://api.github.com/users/babelop/repos","events_url":"https://api.github.com/users/babelop/events{/privacy}","received_events_url":"https://api.github.com/users/babelop/received_events","type":"User","site_admin":false},"body":"Extra arguments given to invoked aliases may now be passed along to the original command. This allows whole classes of to be aliased/renamed `/alias jenkins jk` as well as commands that would otherwise require dynamic input `/alias build jenkins build job` -> `/build my-project`.\r\n\r\n* Will not impact aliases run without arguments\r\n* Includes appropriate spec testing\r\n* Feature description added to README\r\n\r\nI also noticed some unexpected behavior when aliases shared common substrings in their names. There was an edge case of infinite recursion in such instances, re-triggering the alias instead of the command. By updating the alias master route to require either whitespace or the EOL this ensures aliases are triggered only by \"whole words\".\r\n\r\nChanging the master route interfered with the maintenance methods (exists/delete) which previously relied on trying to reverse match the alias name to the added route. These methods now use Lita's [route extensions flag](https://github.com/litaio/lita/blob/master/lib/lita/handler/chat_router.rb#L49) to directly store the name of the alias for future reference.","created_at":"2016-12-18T11:10:21Z","updated_at":"2016-12-18T11:10:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apsoto/lita-alias/pulls/8/commits","review_comments_url":"https://api.github.com/repos/apsoto/lita-alias/pulls/8/comments","review_comment_url":"https://api.github.com/repos/apsoto/lita-alias/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apsoto/lita-alias/issues/8/comments","statuses_url":"https://api.github.com/repos/apsoto/lita-alias/statuses/4f41da56a1a72fce075d28eb6ffdd1e5290b4090","head":{"label":"babelop:alias-extra-args","ref":"alias-extra-args","sha":"4f41da56a1a72fce075d28eb6ffdd1e5290b4090","user":{"login":"babelop","id":3771540,"avatar_url":"https://avatars.githubusercontent.com/u/3771540?v=3","gravatar_id":"","url":"https://api.github.com/users/babelop","html_url":"https://github.com/babelop","followers_url":"https://api.github.com/users/babelop/followers","following_url":"https://api.github.com/users/babelop/following{/other_user}","gists_url":"https://api.github.com/users/babelop/gists{/gist_id}","starred_url":"https://api.github.com/users/babelop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babelop/subscriptions","organizations_url":"https://api.github.com/users/babelop/orgs","repos_url":"https://api.github.com/users/babelop/repos","events_url":"https://api.github.com/users/babelop/events{/privacy}","received_events_url":"https://api.github.com/users/babelop/received_events","type":"User","site_admin":false},"repo":{"id":76774059,"name":"lita-alias","full_name":"babelop/lita-alias","owner":{"login":"babelop","id":3771540,"avatar_url":"https://avatars.githubusercontent.com/u/3771540?v=3","gravatar_id":"","url":"https://api.github.com/users/babelop","html_url":"https://github.com/babelop","followers_url":"https://api.github.com/users/babelop/followers","following_url":"https://api.github.com/users/babelop/following{/other_user}","gists_url":"https://api.github.com/users/babelop/gists{/gist_id}","starred_url":"https://api.github.com/users/babelop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babelop/subscriptions","organizations_url":"https://api.github.com/users/babelop/orgs","repos_url":"https://api.github.com/users/babelop/repos","events_url":"https://api.github.com/users/babelop/events{/privacy}","received_events_url":"https://api.github.com/users/babelop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/babelop/lita-alias","description":"lita chatbot plugin for aliasing commands","fork":true,"url":"https://api.github.com/repos/babelop/lita-alias","forks_url":"https://api.github.com/repos/babelop/lita-alias/forks","keys_url":"https://api.github.com/repos/babelop/lita-alias/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babelop/lita-alias/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babelop/lita-alias/teams","hooks_url":"https://api.github.com/repos/babelop/lita-alias/hooks","issue_events_url":"https://api.github.com/repos/babelop/lita-alias/issues/events{/number}","events_url":"https://api.github.com/repos/babelop/lita-alias/events","assignees_url":"https://api.github.com/repos/babelop/lita-alias/assignees{/user}","branches_url":"https://api.github.com/repos/babelop/lita-alias/branches{/branch}","tags_url":"https://api.github.com/repos/babelop/lita-alias/tags","blobs_url":"https://api.github.com/repos/babelop/lita-alias/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babelop/lita-alias/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babelop/lita-alias/git/refs{/sha}","trees_url":"https://api.github.com/repos/babelop/lita-alias/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babelop/lita-alias/statuses/{sha}","languages_url":"https://api.github.com/repos/babelop/lita-alias/languages","stargazers_url":"https://api.github.com/repos/babelop/lita-alias/stargazers","contributors_url":"https://api.github.com/repos/babelop/lita-alias/contributors","subscribers_url":"https://api.github.com/repos/babelop/lita-alias/subscribers","subscription_url":"https://api.github.com/repos/babelop/lita-alias/subscription","commits_url":"https://api.github.com/repos/babelop/lita-alias/commits{/sha}","git_commits_url":"https://api.github.com/repos/babelop/lita-alias/git/commits{/sha}","comments_url":"https://api.github.com/repos/babelop/lita-alias/comments{/number}","issue_comment_url":"https://api.github.com/repos/babelop/lita-alias/issues/comments{/number}","contents_url":"https://api.github.com/repos/babelop/lita-alias/contents/{+path}","compare_url":"https://api.github.com/repos/babelop/lita-alias/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babelop/lita-alias/merges","archive_url":"https://api.github.com/repos/babelop/lita-alias/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babelop/lita-alias/downloads","issues_url":"https://api.github.com/repos/babelop/lita-alias/issues{/number}","pulls_url":"https://api.github.com/repos/babelop/lita-alias/pulls{/number}","milestones_url":"https://api.github.com/repos/babelop/lita-alias/milestones{/number}","notifications_url":"https://api.github.com/repos/babelop/lita-alias/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babelop/lita-alias/labels{/name}","releases_url":"https://api.github.com/repos/babelop/lita-alias/releases{/id}","deployments_url":"https://api.github.com/repos/babelop/lita-alias/deployments","created_at":"2016-12-18T09:26:52Z","updated_at":"2016-12-18T09:26:53Z","pushed_at":"2016-12-18T10:54:20Z","git_url":"git://github.com/babelop/lita-alias.git","ssh_url":"git@github.com:babelop/lita-alias.git","clone_url":"https://github.com/babelop/lita-alias.git","svn_url":"https://github.com/babelop/lita-alias","homepage":"","size":160,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apsoto:master","ref":"master","sha":"ecfd58a152b12470ba1839982ee3388a75507fcb","user":{"login":"apsoto","id":11692,"avatar_url":"https://avatars.githubusercontent.com/u/11692?v=3","gravatar_id":"","url":"https://api.github.com/users/apsoto","html_url":"https://github.com/apsoto","followers_url":"https://api.github.com/users/apsoto/followers","following_url":"https://api.github.com/users/apsoto/following{/other_user}","gists_url":"https://api.github.com/users/apsoto/gists{/gist_id}","starred_url":"https://api.github.com/users/apsoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apsoto/subscriptions","organizations_url":"https://api.github.com/users/apsoto/orgs","repos_url":"https://api.github.com/users/apsoto/repos","events_url":"https://api.github.com/users/apsoto/events{/privacy}","received_events_url":"https://api.github.com/users/apsoto/received_events","type":"User","site_admin":false},"repo":{"id":38146389,"name":"lita-alias","full_name":"apsoto/lita-alias","owner":{"login":"apsoto","id":11692,"avatar_url":"https://avatars.githubusercontent.com/u/11692?v=3","gravatar_id":"","url":"https://api.github.com/users/apsoto","html_url":"https://github.com/apsoto","followers_url":"https://api.github.com/users/apsoto/followers","following_url":"https://api.github.com/users/apsoto/following{/other_user}","gists_url":"https://api.github.com/users/apsoto/gists{/gist_id}","starred_url":"https://api.github.com/users/apsoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apsoto/subscriptions","organizations_url":"https://api.github.com/users/apsoto/orgs","repos_url":"https://api.github.com/users/apsoto/repos","events_url":"https://api.github.com/users/apsoto/events{/privacy}","received_events_url":"https://api.github.com/users/apsoto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apsoto/lita-alias","description":"lita chatbot plugin for aliasing commands","fork":false,"url":"https://api.github.com/repos/apsoto/lita-alias","forks_url":"https://api.github.com/repos/apsoto/lita-alias/forks","keys_url":"https://api.github.com/repos/apsoto/lita-alias/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apsoto/lita-alias/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apsoto/lita-alias/teams","hooks_url":"https://api.github.com/repos/apsoto/lita-alias/hooks","issue_events_url":"https://api.github.com/repos/apsoto/lita-alias/issues/events{/number}","events_url":"https://api.github.com/repos/apsoto/lita-alias/events","assignees_url":"https://api.github.com/repos/apsoto/lita-alias/assignees{/user}","branches_url":"https://api.github.com/repos/apsoto/lita-alias/branches{/branch}","tags_url":"https://api.github.com/repos/apsoto/lita-alias/tags","blobs_url":"https://api.github.com/repos/apsoto/lita-alias/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apsoto/lita-alias/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apsoto/lita-alias/git/refs{/sha}","trees_url":"https://api.github.com/repos/apsoto/lita-alias/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apsoto/lita-alias/statuses/{sha}","languages_url":"https://api.github.com/repos/apsoto/lita-alias/languages","stargazers_url":"https://api.github.com/repos/apsoto/lita-alias/stargazers","contributors_url":"https://api.github.com/repos/apsoto/lita-alias/contributors","subscribers_url":"https://api.github.com/repos/apsoto/lita-alias/subscribers","subscription_url":"https://api.github.com/repos/apsoto/lita-alias/subscription","commits_url":"https://api.github.com/repos/apsoto/lita-alias/commits{/sha}","git_commits_url":"https://api.github.com/repos/apsoto/lita-alias/git/commits{/sha}","comments_url":"https://api.github.com/repos/apsoto/lita-alias/comments{/number}","issue_comment_url":"https://api.github.com/repos/apsoto/lita-alias/issues/comments{/number}","contents_url":"https://api.github.com/repos/apsoto/lita-alias/contents/{+path}","compare_url":"https://api.github.com/repos/apsoto/lita-alias/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apsoto/lita-alias/merges","archive_url":"https://api.github.com/repos/apsoto/lita-alias/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apsoto/lita-alias/downloads","issues_url":"https://api.github.com/repos/apsoto/lita-alias/issues{/number}","pulls_url":"https://api.github.com/repos/apsoto/lita-alias/pulls{/number}","milestones_url":"https://api.github.com/repos/apsoto/lita-alias/milestones{/number}","notifications_url":"https://api.github.com/repos/apsoto/lita-alias/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apsoto/lita-alias/labels{/name}","releases_url":"https://api.github.com/repos/apsoto/lita-alias/releases{/id}","deployments_url":"https://api.github.com/repos/apsoto/lita-alias/deployments","created_at":"2015-06-27T04:14:35Z","updated_at":"2016-12-01T08:35:59Z","pushed_at":"2015-09-30T16:56:13Z","git_url":"git://github.com/apsoto/lita-alias.git","ssh_url":"git@github.com:apsoto/lita-alias.git","clone_url":"https://github.com/apsoto/lita-alias.git","svn_url":"https://github.com/apsoto/lita-alias","homepage":"","size":160,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apsoto/lita-alias/pulls/8"},"html":{"href":"https://github.com/apsoto/lita-alias/pull/8"},"issue":{"href":"https://api.github.com/repos/apsoto/lita-alias/issues/8"},"comments":{"href":"https://api.github.com/repos/apsoto/lita-alias/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/apsoto/lita-alias/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/apsoto/lita-alias/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apsoto/lita-alias/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/apsoto/lita-alias/statuses/4f41da56a1a72fce075d28eb6ffdd1e5290b4090"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":20,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"babelop"}}