{"action":"created","comment":{"url":"https://api.github.com/repos/plated/vantiv-ruby/pulls/comments/68588263","id":68588263,"diff_hunk":"@@ -5,17 +5,18 @@\n module Vantiv\n   module Certification\n     class PaypageServer\n-      def initialize(threaded: true)\n-        @threaded = threaded\n+      def initialize\n         @template = \"#{Vantiv.root}/lib/vantiv/certification/views/index.html.erb\"\n         @static_file_dir = \"#{Vantiv.root}/tmp/e-protect\"\n       end\n \n       def start\n-        if threaded\n-          @server_thread = Thread.new { start_server }\n-        else\n-          start_server\n+        @server_thread = Thread.new do","path":"lib/vantiv/certification/paypage_server.rb","position":16,"original_position":16,"commit_id":"d22439915e90be271dea2bbd9cc948b584c23f28","original_commit_id":"d22439915e90be271dea2bbd9cc948b584c23f28","user":{"login":"joshuaballoch","id":538482,"avatar_url":"https://avatars.githubusercontent.com/u/538482?v=3","gravatar_id":"","url":"https://api.github.com/users/joshuaballoch","html_url":"https://github.com/joshuaballoch","followers_url":"https://api.github.com/users/joshuaballoch/followers","following_url":"https://api.github.com/users/joshuaballoch/following{/other_user}","gists_url":"https://api.github.com/users/joshuaballoch/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuaballoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuaballoch/subscriptions","organizations_url":"https://api.github.com/users/joshuaballoch/orgs","repos_url":"https://api.github.com/users/joshuaballoch/repos","events_url":"https://api.github.com/users/joshuaballoch/events{/privacy}","received_events_url":"https://api.github.com/users/joshuaballoch/received_events","type":"User","site_admin":false},"body":"would prefer `self.server_thread = ` here. ","created_at":"2016-06-27T14:41:34Z","updated_at":"2016-06-27T14:41:34Z","html_url":"https://github.com/plated/vantiv-ruby/pull/52#discussion_r68588263","pull_request_url":"https://api.github.com/repos/plated/vantiv-ruby/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/plated/vantiv-ruby/pulls/comments/68588263"},"html":{"href":"https://github.com/plated/vantiv-ruby/pull/52#discussion_r68588263"},"pull_request":{"href":"https://api.github.com/repos/plated/vantiv-ruby/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/plated/vantiv-ruby/pulls/52","id":75322741,"html_url":"https://github.com/plated/vantiv-ruby/pull/52","diff_url":"https://github.com/plated/vantiv-ruby/pull/52.diff","patch_url":"https://github.com/plated/vantiv-ruby/pull/52.patch","issue_url":"https://api.github.com/repos/plated/vantiv-ruby/issues/52","number":52,"state":"open","locked":false,"title":"Handle threaded server in tests correctly","user":{"login":"ChrisVoxland","id":2336288,"avatar_url":"https://avatars.githubusercontent.com/u/2336288?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisVoxland","html_url":"https://github.com/ChrisVoxland","followers_url":"https://api.github.com/users/ChrisVoxland/followers","following_url":"https://api.github.com/users/ChrisVoxland/following{/other_user}","gists_url":"https://api.github.com/users/ChrisVoxland/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisVoxland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisVoxland/subscriptions","organizations_url":"https://api.github.com/users/ChrisVoxland/orgs","repos_url":"https://api.github.com/users/ChrisVoxland/repos","events_url":"https://api.github.com/users/ChrisVoxland/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisVoxland/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-27T14:40:05Z","updated_at":"2016-06-27T14:41:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aeea96935f43aba438ab6e8542a42cc8d7736eb8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/plated/vantiv-ruby/pulls/52/commits","review_comments_url":"https://api.github.com/repos/plated/vantiv-ruby/pulls/52/comments","review_comment_url":"https://api.github.com/repos/plated/vantiv-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plated/vantiv-ruby/issues/52/comments","statuses_url":"https://api.github.com/repos/plated/vantiv-ruby/statuses/d22439915e90be271dea2bbd9cc948b584c23f28","head":{"label":"plated:handle-threaded-server-in-tests-correctly","ref":"handle-threaded-server-in-tests-correctly","sha":"d22439915e90be271dea2bbd9cc948b584c23f28","user":{"login":"plated","id":4378191,"avatar_url":"https://avatars.githubusercontent.com/u/4378191?v=3","gravatar_id":"","url":"https://api.github.com/users/plated","html_url":"https://github.com/plated","followers_url":"https://api.github.com/users/plated/followers","following_url":"https://api.github.com/users/plated/following{/other_user}","gists_url":"https://api.github.com/users/plated/gists{/gist_id}","starred_url":"https://api.github.com/users/plated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plated/subscriptions","organizations_url":"https://api.github.com/users/plated/orgs","repos_url":"https://api.github.com/users/plated/repos","events_url":"https://api.github.com/users/plated/events{/privacy}","received_events_url":"https://api.github.com/users/plated/received_events","type":"Organization","site_admin":false},"repo":{"id":52479361,"name":"vantiv-ruby","full_name":"plated/vantiv-ruby","owner":{"login":"plated","id":4378191,"avatar_url":"https://avatars.githubusercontent.com/u/4378191?v=3","gravatar_id":"","url":"https://api.github.com/users/plated","html_url":"https://github.com/plated","followers_url":"https://api.github.com/users/plated/followers","following_url":"https://api.github.com/users/plated/following{/other_user}","gists_url":"https://api.github.com/users/plated/gists{/gist_id}","starred_url":"https://api.github.com/users/plated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plated/subscriptions","organizations_url":"https://api.github.com/users/plated/orgs","repos_url":"https://api.github.com/users/plated/repos","events_url":"https://api.github.com/users/plated/events{/privacy}","received_events_url":"https://api.github.com/users/plated/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plated/vantiv-ruby","description":"A simple ruby client to use Vantiv's DevHub API","fork":false,"url":"https://api.github.com/repos/plated/vantiv-ruby","forks_url":"https://api.github.com/repos/plated/vantiv-ruby/forks","keys_url":"https://api.github.com/repos/plated/vantiv-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plated/vantiv-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plated/vantiv-ruby/teams","hooks_url":"https://api.github.com/repos/plated/vantiv-ruby/hooks","issue_events_url":"https://api.github.com/repos/plated/vantiv-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/plated/vantiv-ruby/events","assignees_url":"https://api.github.com/repos/plated/vantiv-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/plated/vantiv-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/plated/vantiv-ruby/tags","blobs_url":"https://api.github.com/repos/plated/vantiv-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plated/vantiv-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plated/vantiv-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/plated/vantiv-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plated/vantiv-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/plated/vantiv-ruby/languages","stargazers_url":"https://api.github.com/repos/plated/vantiv-ruby/stargazers","contributors_url":"https://api.github.com/repos/plated/vantiv-ruby/contributors","subscribers_url":"https://api.github.com/repos/plated/vantiv-ruby/subscribers","subscription_url":"https://api.github.com/repos/plated/vantiv-ruby/subscription","commits_url":"https://api.github.com/repos/plated/vantiv-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/plated/vantiv-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/plated/vantiv-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/plated/vantiv-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/plated/vantiv-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/plated/vantiv-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plated/vantiv-ruby/merges","archive_url":"https://api.github.com/repos/plated/vantiv-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plated/vantiv-ruby/downloads","issues_url":"https://api.github.com/repos/plated/vantiv-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/plated/vantiv-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/plated/vantiv-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/plated/vantiv-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plated/vantiv-ruby/labels{/name}","releases_url":"https://api.github.com/repos/plated/vantiv-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/plated/vantiv-ruby/deployments","created_at":"2016-02-24T22:34:04Z","updated_at":"2016-05-04T20:23:58Z","pushed_at":"2016-06-27T14:40:05Z","git_url":"git://github.com/plated/vantiv-ruby.git","ssh_url":"git@github.com:plated/vantiv-ruby.git","clone_url":"https://github.com/plated/vantiv-ruby.git","svn_url":"https://github.com/plated/vantiv-ruby","homepage":"","size":180,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"plated:master","ref":"master","sha":"f5817f1ef070529a1d7d54a219b3b10a1b47b0ba","user":{"login":"plated","id":4378191,"avatar_url":"https://avatars.githubusercontent.com/u/4378191?v=3","gravatar_id":"","url":"https://api.github.com/users/plated","html_url":"https://github.com/plated","followers_url":"https://api.github.com/users/plated/followers","following_url":"https://api.github.com/users/plated/following{/other_user}","gists_url":"https://api.github.com/users/plated/gists{/gist_id}","starred_url":"https://api.github.com/users/plated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plated/subscriptions","organizations_url":"https://api.github.com/users/plated/orgs","repos_url":"https://api.github.com/users/plated/repos","events_url":"https://api.github.com/users/plated/events{/privacy}","received_events_url":"https://api.github.com/users/plated/received_events","type":"Organization","site_admin":false},"repo":{"id":52479361,"name":"vantiv-ruby","full_name":"plated/vantiv-ruby","owner":{"login":"plated","id":4378191,"avatar_url":"https://avatars.githubusercontent.com/u/4378191?v=3","gravatar_id":"","url":"https://api.github.com/users/plated","html_url":"https://github.com/plated","followers_url":"https://api.github.com/users/plated/followers","following_url":"https://api.github.com/users/plated/following{/other_user}","gists_url":"https://api.github.com/users/plated/gists{/gist_id}","starred_url":"https://api.github.com/users/plated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plated/subscriptions","organizations_url":"https://api.github.com/users/plated/orgs","repos_url":"https://api.github.com/users/plated/repos","events_url":"https://api.github.com/users/plated/events{/privacy}","received_events_url":"https://api.github.com/users/plated/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plated/vantiv-ruby","description":"A simple ruby client to use Vantiv's DevHub API","fork":false,"url":"https://api.github.com/repos/plated/vantiv-ruby","forks_url":"https://api.github.com/repos/plated/vantiv-ruby/forks","keys_url":"https://api.github.com/repos/plated/vantiv-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plated/vantiv-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plated/vantiv-ruby/teams","hooks_url":"https://api.github.com/repos/plated/vantiv-ruby/hooks","issue_events_url":"https://api.github.com/repos/plated/vantiv-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/plated/vantiv-ruby/events","assignees_url":"https://api.github.com/repos/plated/vantiv-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/plated/vantiv-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/plated/vantiv-ruby/tags","blobs_url":"https://api.github.com/repos/plated/vantiv-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plated/vantiv-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plated/vantiv-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/plated/vantiv-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plated/vantiv-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/plated/vantiv-ruby/languages","stargazers_url":"https://api.github.com/repos/plated/vantiv-ruby/stargazers","contributors_url":"https://api.github.com/repos/plated/vantiv-ruby/contributors","subscribers_url":"https://api.github.com/repos/plated/vantiv-ruby/subscribers","subscription_url":"https://api.github.com/repos/plated/vantiv-ruby/subscription","commits_url":"https://api.github.com/repos/plated/vantiv-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/plated/vantiv-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/plated/vantiv-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/plated/vantiv-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/plated/vantiv-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/plated/vantiv-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plated/vantiv-ruby/merges","archive_url":"https://api.github.com/repos/plated/vantiv-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plated/vantiv-ruby/downloads","issues_url":"https://api.github.com/repos/plated/vantiv-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/plated/vantiv-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/plated/vantiv-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/plated/vantiv-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plated/vantiv-ruby/labels{/name}","releases_url":"https://api.github.com/repos/plated/vantiv-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/plated/vantiv-ruby/deployments","created_at":"2016-02-24T22:34:04Z","updated_at":"2016-05-04T20:23:58Z","pushed_at":"2016-06-27T14:40:05Z","git_url":"git://github.com/plated/vantiv-ruby.git","ssh_url":"git@github.com:plated/vantiv-ruby.git","clone_url":"https://github.com/plated/vantiv-ruby.git","svn_url":"https://github.com/plated/vantiv-ruby","homepage":"","size":180,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plated/vantiv-ruby/pulls/52"},"html":{"href":"https://github.com/plated/vantiv-ruby/pull/52"},"issue":{"href":"https://api.github.com/repos/plated/vantiv-ruby/issues/52"},"comments":{"href":"https://api.github.com/repos/plated/vantiv-ruby/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/plated/vantiv-ruby/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/plated/vantiv-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plated/vantiv-ruby/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/plated/vantiv-ruby/statuses/d22439915e90be271dea2bbd9cc948b584c23f28"}}}}
{"actor":{"display_login":"joshuaballoch"}}