{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/57995010","id":57995010,"diff_hunk":"@@ -97,10 +97,16 @@ func findOrCreateIngress(route *routeapi.Route, name string) (_ *routeapi.RouteI\n // setIngressCondition records the condition on the ingress, returning true if the ingress was changed and\n // false if no modification was made.\n func setIngressCondition(ingress *routeapi.RouteIngress, condition routeapi.RouteIngressCondition) bool {\n-\tfor _, existing := range ingress.Conditions {\n+\tfor i, existing := range ingress.Conditions {\n \t\t// ensures that the comparison is based on the actual value, not the time\n \t\texisting.LastTransitionTime = condition.LastTransitionTime\n \t\tif existing == condition {\n+\t\t\t// This will always be the case if we're receiving an update on the host\n+\t\t\t// value (or the like), since findOrCreateIngress sets that for us.  We\n+\t\t\t// still need to set the last-touched time so that others can tell we've\n+\t\t\t// modified this Ingress value\n+\t\t\tnow := nowFn()\n+\t\t\tingress.Conditions[i].LastTransitionTime = &now","path":"pkg/router/controller/status.go","position":14,"original_position":14,"commit_id":"3df79a4f90b13bc1d5432e58da10a45caf740c0d","original_commit_id":"d5cdfdb4b5d32cb8cd8647f7226a21eea5212679","user":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"body":"I think it actually should stay as `False` -- it's only used in the rejection path, and it's actually in a path where we don't want to update if that's the only thing that would be changed, AFAICT, but I'll double check in the morning when I'm more awake ;-).","created_at":"2016-03-31T02:50:59Z","updated_at":"2016-03-31T02:50:59Z","html_url":"https://github.com/openshift/origin/pull/8309#discussion_r57995010","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/8309","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/57995010"},"html":{"href":"https://github.com/openshift/origin/pull/8309#discussion_r57995010"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/8309"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8309","id":64725309,"html_url":"https://github.com/openshift/origin/pull/8309","diff_url":"https://github.com/openshift/origin/pull/8309.diff","patch_url":"https://github.com/openshift/origin/pull/8309.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/8309","number":8309,"state":"open","locked":false,"title":"Allow multiple routers to update route status","user":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"body":"Previously, if multiple differently-named routers attempted to update\r\ntheir respective Ingress entries in a route status, one would go\r\nthrough, while the others would recieve conflict errors.\r\n\r\nThe last-touched cache, designed to prevent fighting between two\r\nsame-named routers (for example, on a rolling update), would get\r\nthe route added with the zero-time, meaning that the router would\r\nnot submit further updates for that route (and consequently that\r\nrouter would never set the proper status on the route).\r\n\r\nNow, conflicts no longer insert an entry into the last-touched cache.\r\nInstead, the code now properly updates the last-touched time, which\r\nprevents the fighting between instances of the same router while\r\ntolerating conflicts inbetween instances of different routers.\r\n\r\nAdditionally, cache entries now expire after a period of time\r\n(the \"contention period\"), as originally intended.","created_at":"2016-03-31T02:13:50Z","updated_at":"2016-03-31T02:50:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"173f2400ef0a01f72154b24b5d4090e6f6595274","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/8309/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/8309/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8309/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/3df79a4f90b13bc1d5432e58da10a45caf740c0d","head":{"label":"DirectXMan12:bug/route-update-conflicts","ref":"bug/route-update-conflicts","sha":"3df79a4f90b13bc1d5432e58da10a45caf740c0d","user":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"repo":{"id":44701804,"name":"origin","full_name":"DirectXMan12/origin","owner":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DirectXMan12/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/DirectXMan12/origin","forks_url":"https://api.github.com/repos/DirectXMan12/origin/forks","keys_url":"https://api.github.com/repos/DirectXMan12/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DirectXMan12/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DirectXMan12/origin/teams","hooks_url":"https://api.github.com/repos/DirectXMan12/origin/hooks","issue_events_url":"https://api.github.com/repos/DirectXMan12/origin/issues/events{/number}","events_url":"https://api.github.com/repos/DirectXMan12/origin/events","assignees_url":"https://api.github.com/repos/DirectXMan12/origin/assignees{/user}","branches_url":"https://api.github.com/repos/DirectXMan12/origin/branches{/branch}","tags_url":"https://api.github.com/repos/DirectXMan12/origin/tags","blobs_url":"https://api.github.com/repos/DirectXMan12/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DirectXMan12/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DirectXMan12/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/DirectXMan12/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DirectXMan12/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/DirectXMan12/origin/languages","stargazers_url":"https://api.github.com/repos/DirectXMan12/origin/stargazers","contributors_url":"https://api.github.com/repos/DirectXMan12/origin/contributors","subscribers_url":"https://api.github.com/repos/DirectXMan12/origin/subscribers","subscription_url":"https://api.github.com/repos/DirectXMan12/origin/subscription","commits_url":"https://api.github.com/repos/DirectXMan12/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/DirectXMan12/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/DirectXMan12/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/DirectXMan12/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/DirectXMan12/origin/contents/{+path}","compare_url":"https://api.github.com/repos/DirectXMan12/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DirectXMan12/origin/merges","archive_url":"https://api.github.com/repos/DirectXMan12/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DirectXMan12/origin/downloads","issues_url":"https://api.github.com/repos/DirectXMan12/origin/issues{/number}","pulls_url":"https://api.github.com/repos/DirectXMan12/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/DirectXMan12/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/DirectXMan12/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DirectXMan12/origin/labels{/name}","releases_url":"https://api.github.com/repos/DirectXMan12/origin/releases{/id}","deployments_url":"https://api.github.com/repos/DirectXMan12/origin/deployments","created_at":"2015-10-21T20:18:34Z","updated_at":"2015-10-21T20:19:02Z","pushed_at":"2016-03-31T02:40:33Z","git_url":"git://github.com/DirectXMan12/origin.git","ssh_url":"git@github.com:DirectXMan12/origin.git","clone_url":"https://github.com/DirectXMan12/origin.git","svn_url":"https://github.com/DirectXMan12/origin","homepage":"http://www.openshift.org","size":235031,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"f243e7bde74cb071c93b352b4f4cdf9b4697ce46","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-03-30T23:35:57Z","pushed_at":"2016-03-31T02:40:34Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":306799,"stargazers_count":1174,"watchers_count":1174,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":718,"mirror_url":null,"open_issues_count":979,"forks":718,"open_issues":979,"watchers":1174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/8309"},"html":{"href":"https://github.com/openshift/origin/pull/8309"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/8309"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/8309/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/8309/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/8309/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/3df79a4f90b13bc1d5432e58da10a45caf740c0d"}}}}