{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/73189603","id":73189603,"diff_hunk":"@@ -1100,11 +1102,14 @@ void Geocoder::MatchPOIsAndBuildings(BaseContext & ctx, size_t curToken)\n       CBV filtered = m_postcodes.m_features;\n       if (m_filter->NeedToFilter(m_postcodes.m_features))\n         filtered = m_filter->Filter(m_postcodes.m_features);\n-      filtered.ForEach([&](uint32_t id)\n-                       {\n-                         EmitResult(m_context->GetId(), id, GetSearchTypeInGeocoding(ctx, id),\n-                                    m_postcodes.m_startToken, m_postcodes.m_endToken);\n-                       });\n+      filtered.ForEach([&](uint32_t id) {","path":"search/geocoder.cpp","position":29,"original_position":29,"commit_id":"454c87db9c892431148e88cb9e812af3d505f6ab","original_commit_id":"e4a2897f6244f4af28156c6f4d8e289ae2f62d74","user":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars.githubusercontent.com/u/10366009?v=3","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"body":"Мы это много обсуждали оффлайн, но сошлись на том, что лучше плохой, да стандарт. В 3.9 нет опции для форматирования лябмд, в 3.6 форматирование было другим, так что подождём 4.0 и, если ничего не изменится, отпишем им.\r\n\r\nМне тоже не нравится, что скобки здесь отличаются от наших соглашений.","created_at":"2016-08-02T16:28:52Z","updated_at":"2016-08-02T16:28:52Z","html_url":"https://github.com/mapsme/omim/pull/3930#discussion_r73189603","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/3930","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/73189603"},"html":{"href":"https://github.com/mapsme/omim/pull/3930#discussion_r73189603"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/3930"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/3930","id":79760824,"html_url":"https://github.com/mapsme/omim/pull/3930","diff_url":"https://github.com/mapsme/omim/pull/3930.diff","patch_url":"https://github.com/mapsme/omim/pull/3930.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/3930","number":3930,"state":"open","locked":false,"title":"[search] Fixed a crash.","user":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars.githubusercontent.com/u/10366009?v=3","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-02T15:54:43Z","updated_at":"2016-08-02T16:28:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7db9734e61a5f59af21f77e0d54ee70265c65f0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/3930/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/3930/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/3930/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/454c87db9c892431148e88cb9e812af3d505f6ab","head":{"label":"mpimenov:fix-obsolete","ref":"fix-obsolete","sha":"454c87db9c892431148e88cb9e812af3d505f6ab","user":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars.githubusercontent.com/u/10366009?v=3","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"repo":{"id":43427925,"name":"omim","full_name":"mpimenov/omim","owner":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars.githubusercontent.com/u/10366009?v=3","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpimenov/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/mpimenov/omim","forks_url":"https://api.github.com/repos/mpimenov/omim/forks","keys_url":"https://api.github.com/repos/mpimenov/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpimenov/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpimenov/omim/teams","hooks_url":"https://api.github.com/repos/mpimenov/omim/hooks","issue_events_url":"https://api.github.com/repos/mpimenov/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mpimenov/omim/events","assignees_url":"https://api.github.com/repos/mpimenov/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mpimenov/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mpimenov/omim/tags","blobs_url":"https://api.github.com/repos/mpimenov/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpimenov/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpimenov/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpimenov/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpimenov/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mpimenov/omim/languages","stargazers_url":"https://api.github.com/repos/mpimenov/omim/stargazers","contributors_url":"https://api.github.com/repos/mpimenov/omim/contributors","subscribers_url":"https://api.github.com/repos/mpimenov/omim/subscribers","subscription_url":"https://api.github.com/repos/mpimenov/omim/subscription","commits_url":"https://api.github.com/repos/mpimenov/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpimenov/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpimenov/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpimenov/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpimenov/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mpimenov/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpimenov/omim/merges","archive_url":"https://api.github.com/repos/mpimenov/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpimenov/omim/downloads","issues_url":"https://api.github.com/repos/mpimenov/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mpimenov/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mpimenov/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mpimenov/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpimenov/omim/labels{/name}","releases_url":"https://api.github.com/repos/mpimenov/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mpimenov/omim/deployments","created_at":"2015-09-30T10:55:18Z","updated_at":"2016-01-15T13:41:49Z","pushed_at":"2016-08-02T16:00:53Z","git_url":"git://github.com/mpimenov/omim.git","ssh_url":"git@github.com:mpimenov/omim.git","clone_url":"https://github.com/mpimenov/omim.git","svn_url":"https://github.com/mpimenov/omim","homepage":null,"size":2522158,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"04a96a39ac937d2a0892a725b2e43e1433f609fb","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2016-08-02T09:42:08Z","pushed_at":"2016-08-02T16:00:54Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":2673856,"stargazers_count":1892,"watchers_count":1892,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":324,"mirror_url":null,"open_issues_count":225,"forks":324,"open_issues":225,"watchers":1892,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/3930"},"html":{"href":"https://github.com/mapsme/omim/pull/3930"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/3930"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/3930/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/3930/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/3930/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/454c87db9c892431148e88cb9e812af3d505f6ab"}}}}
{"actor":{"display_login":"mpimenov"}}