{"action":"created","comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/49270884","id":49270884,"diff_hunk":"@@ -11416,20 +11416,39 @@ void clif_parse_ItemIdentify(int fd,struct map_session_data *sd) __attribute__((\n ///     -1 = cancel\n void clif_parse_ItemIdentify(int fd,struct map_session_data *sd)\n {\n-\tshort idx = RFIFOW(fd,2);\n+\tshort idx = RFIFOW(fd, 2) - 2;\n \n \tif (sd->menuskill_id != MC_IDENTIFY)\n \t\treturn;\n-\tif( idx == -1 ) {// cancel pressed\n+\tif( idx < 0 ) {// cancel pressed","path":"src/map/clif.c","position":10,"original_position":10,"commit_id":"e38e7d2b5613fe92286d751c3b74e54874e997a1","original_commit_id":"e38e7d2b5613fe92286d751c3b74e54874e997a1","user":{"login":"MishimaHaruna","id":4590397,"avatar_url":"https://avatars.githubusercontent.com/u/4590397?v=3","gravatar_id":"","url":"https://api.github.com/users/MishimaHaruna","html_url":"https://github.com/MishimaHaruna","followers_url":"https://api.github.com/users/MishimaHaruna/followers","following_url":"https://api.github.com/users/MishimaHaruna/following{/other_user}","gists_url":"https://api.github.com/users/MishimaHaruna/gists{/gist_id}","starred_url":"https://api.github.com/users/MishimaHaruna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishimaHaruna/subscriptions","organizations_url":"https://api.github.com/users/MishimaHaruna/orgs","repos_url":"https://api.github.com/users/MishimaHaruna/repos","events_url":"https://api.github.com/users/MishimaHaruna/events{/privacy}","received_events_url":"https://api.github.com/users/MishimaHaruna/received_events","type":"User","site_admin":false},"body":"Just to make sure, what value does it send when pressing cancel?\r\n\r\nBefore this commit, cancel was when `RFIFOW(fd, 2) == -1`. After this commit, it is when `RFIFOW(fd, 2) == 1` (because you moved the -2 to line 11419)","created_at":"2016-01-10T02:51:39Z","updated_at":"2016-01-10T02:51:39Z","html_url":"https://github.com/HerculesWS/Hercules/pull/1031#discussion_r49270884","pull_request_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1031","_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/49270884"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/1031#discussion_r49270884"},"pull_request":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1031"}}},"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1031","id":54614610,"html_url":"https://github.com/HerculesWS/Hercules/pull/1031","diff_url":"https://github.com/HerculesWS/Hercules/pull/1031.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/1031.patch","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1031","number":1031,"state":"open","locked":false,"title":"Added OneClickIdentify packet","user":{"login":"dastgir","id":2889931,"avatar_url":"https://avatars.githubusercontent.com/u/2889931?v=3","gravatar_id":"","url":"https://api.github.com/users/dastgir","html_url":"https://github.com/dastgir","followers_url":"https://api.github.com/users/dastgir/followers","following_url":"https://api.github.com/users/dastgir/following{/other_user}","gists_url":"https://api.github.com/users/dastgir/gists{/gist_id}","starred_url":"https://api.github.com/users/dastgir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dastgir/subscriptions","organizations_url":"https://api.github.com/users/dastgir/orgs","repos_url":"https://api.github.com/users/dastgir/repos","events_url":"https://api.github.com/users/dastgir/events{/privacy}","received_events_url":"https://api.github.com/users/dastgir/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-27T09:32:56Z","updated_at":"2016-01-10T02:51:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"264dec91fb8dee9f7098b236b80900c1866c50be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1031/commits","review_comments_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1031/comments","review_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1031/comments","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/e38e7d2b5613fe92286d751c3b74e54874e997a1","head":{"label":"dastgir:12-OneClickIdentify","ref":"12-OneClickIdentify","sha":"e38e7d2b5613fe92286d751c3b74e54874e997a1","user":{"login":"dastgir","id":2889931,"avatar_url":"https://avatars.githubusercontent.com/u/2889931?v=3","gravatar_id":"","url":"https://api.github.com/users/dastgir","html_url":"https://github.com/dastgir","followers_url":"https://api.github.com/users/dastgir/followers","following_url":"https://api.github.com/users/dastgir/following{/other_user}","gists_url":"https://api.github.com/users/dastgir/gists{/gist_id}","starred_url":"https://api.github.com/users/dastgir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dastgir/subscriptions","organizations_url":"https://api.github.com/users/dastgir/orgs","repos_url":"https://api.github.com/users/dastgir/repos","events_url":"https://api.github.com/users/dastgir/events{/privacy}","received_events_url":"https://api.github.com/users/dastgir/received_events","type":"User","site_admin":false},"repo":{"id":13668158,"name":"Hercules","full_name":"dastgir/Hercules","owner":{"login":"dastgir","id":2889931,"avatar_url":"https://avatars.githubusercontent.com/u/2889931?v=3","gravatar_id":"","url":"https://api.github.com/users/dastgir","html_url":"https://github.com/dastgir","followers_url":"https://api.github.com/users/dastgir/followers","following_url":"https://api.github.com/users/dastgir/following{/other_user}","gists_url":"https://api.github.com/users/dastgir/gists{/gist_id}","starred_url":"https://api.github.com/users/dastgir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dastgir/subscriptions","organizations_url":"https://api.github.com/users/dastgir/orgs","repos_url":"https://api.github.com/users/dastgir/repos","events_url":"https://api.github.com/users/dastgir/events{/privacy}","received_events_url":"https://api.github.com/users/dastgir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dastgir/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":true,"url":"https://api.github.com/repos/dastgir/Hercules","forks_url":"https://api.github.com/repos/dastgir/Hercules/forks","keys_url":"https://api.github.com/repos/dastgir/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dastgir/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dastgir/Hercules/teams","hooks_url":"https://api.github.com/repos/dastgir/Hercules/hooks","issue_events_url":"https://api.github.com/repos/dastgir/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/dastgir/Hercules/events","assignees_url":"https://api.github.com/repos/dastgir/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/dastgir/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/dastgir/Hercules/tags","blobs_url":"https://api.github.com/repos/dastgir/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dastgir/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dastgir/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/dastgir/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dastgir/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/dastgir/Hercules/languages","stargazers_url":"https://api.github.com/repos/dastgir/Hercules/stargazers","contributors_url":"https://api.github.com/repos/dastgir/Hercules/contributors","subscribers_url":"https://api.github.com/repos/dastgir/Hercules/subscribers","subscription_url":"https://api.github.com/repos/dastgir/Hercules/subscription","commits_url":"https://api.github.com/repos/dastgir/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/dastgir/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/dastgir/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/dastgir/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/dastgir/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/dastgir/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dastgir/Hercules/merges","archive_url":"https://api.github.com/repos/dastgir/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dastgir/Hercules/downloads","issues_url":"https://api.github.com/repos/dastgir/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/dastgir/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/dastgir/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/dastgir/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dastgir/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/dastgir/Hercules/releases{/id}","created_at":"2013-10-18T03:33:23Z","updated_at":"2015-01-21T06:27:34Z","pushed_at":"2016-01-05T11:25:35Z","git_url":"git://github.com/dastgir/Hercules.git","ssh_url":"git@github.com:dastgir/Hercules.git","clone_url":"https://github.com/dastgir/Hercules.git","svn_url":"https://github.com/dastgir/Hercules","homepage":"http://hercules.ws","size":128564,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HerculesWS:master","ref":"master","sha":"296e6c04a4c1a01a233c937bd198a31fa849f49c","user":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars.githubusercontent.com/u/3220669?v=3","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"repo":{"id":7551429,"name":"Hercules","full_name":"HerculesWS/Hercules","owner":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars.githubusercontent.com/u/3220669?v=3","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HerculesWS/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":false,"url":"https://api.github.com/repos/HerculesWS/Hercules","forks_url":"https://api.github.com/repos/HerculesWS/Hercules/forks","keys_url":"https://api.github.com/repos/HerculesWS/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerculesWS/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerculesWS/Hercules/teams","hooks_url":"https://api.github.com/repos/HerculesWS/Hercules/hooks","issue_events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/HerculesWS/Hercules/events","assignees_url":"https://api.github.com/repos/HerculesWS/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/HerculesWS/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/HerculesWS/Hercules/tags","blobs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerculesWS/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerculesWS/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/HerculesWS/Hercules/languages","stargazers_url":"https://api.github.com/repos/HerculesWS/Hercules/stargazers","contributors_url":"https://api.github.com/repos/HerculesWS/Hercules/contributors","subscribers_url":"https://api.github.com/repos/HerculesWS/Hercules/subscribers","subscription_url":"https://api.github.com/repos/HerculesWS/Hercules/subscription","commits_url":"https://api.github.com/repos/HerculesWS/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerculesWS/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerculesWS/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/HerculesWS/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerculesWS/Hercules/merges","archive_url":"https://api.github.com/repos/HerculesWS/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerculesWS/Hercules/downloads","issues_url":"https://api.github.com/repos/HerculesWS/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/HerculesWS/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/HerculesWS/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/HerculesWS/Hercules/releases{/id}","created_at":"2013-01-11T00:29:38Z","updated_at":"2016-01-04T20:56:10Z","pushed_at":"2016-01-10T02:25:45Z","git_url":"git://github.com/HerculesWS/Hercules.git","ssh_url":"git@github.com:HerculesWS/Hercules.git","clone_url":"https://github.com/HerculesWS/Hercules.git","svn_url":"https://github.com/HerculesWS/Hercules","homepage":"http://herc.ws","size":143460,"stargazers_count":241,"watchers_count":241,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":372,"mirror_url":null,"open_issues_count":260,"forks":372,"open_issues":260,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1031"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/1031"},"issue":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/1031"},"comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/1031/comments"},"review_comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1031/comments"},"review_comment":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1031/commits"},"statuses":{"href":"https://api.github.com/repos/HerculesWS/Hercules/statuses/e38e7d2b5613fe92286d751c3b74e54874e997a1"}}}}