{"action":"created","issue":{"url":"https://api.github.com/repos/steph-del/eveg/issues/16","repository_url":"https://api.github.com/repos/steph-del/eveg","labels_url":"https://api.github.com/repos/steph-del/eveg/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/steph-del/eveg/issues/16/comments","events_url":"https://api.github.com/repos/steph-del/eveg/issues/16/events","html_url":"https://github.com/steph-del/eveg/issues/16","id":181646637,"number":16,"title":"[Insight] Commented code should not be committed - in src/eveg/AppBundle/Menu/MenuBuilder.php, line 282","user":{"login":"steph-del","id":13241830,"avatar_url":"https://avatars.githubusercontent.com/u/13241830?v=3","gravatar_id":"","url":"https://api.github.com/users/steph-del","html_url":"https://github.com/steph-del","followers_url":"https://api.github.com/users/steph-del/followers","following_url":"https://api.github.com/users/steph-del/following{/other_user}","gists_url":"https://api.github.com/users/steph-del/gists{/gist_id}","starred_url":"https://api.github.com/users/steph-del/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steph-del/subscriptions","organizations_url":"https://api.github.com/users/steph-del/orgs","repos_url":"https://api.github.com/users/steph-del/repos","events_url":"https://api.github.com/users/steph-del/events{/privacy}","received_events_url":"https://api.github.com/users/steph-del/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-07T11:32:59Z","updated_at":"2016-10-07T11:34:18Z","closed_at":"2016-10-07T11:34:18Z","body":"**[in src/eveg/AppBundle/Menu/MenuBuilder.php, line 282](https://github.com/steph-del/eveg/blob/694831be361426b1825884b6bf494238301b03ee/src/eveg/AppBundle/Menu/MenuBuilder.php#L282)**\r\n\r\n> Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.\r\n\r\n```php\r\n                     ->setAttribute('role', 'separator')\r\n                     ->setAttribute('class', 'divider');\r\n      $menu['Import']->addChild('Logs', array('route' => 'eveg_admin_import_logs', 'label' => 'Logs'));\r\n    }\r\n\r\n\t\t//$menu->addChild('Baseveg', array('route' => 'admin_syntaxon', 'label' => 'Baseveg'));\r\n\t\t//$menu->addChild('Translation', array('route' => 'eveg_app_contact', 'label' => 'Traduction'));\r\n\t\t//$menu->addChild('LiveTest', array('route' => 'eveg_admin_test', 'label' => 'Test@dev'));\r\n \r\n        return $menu;\r\n    }\r\n```\r\n\r\n---------------------\r\n\r\n_Posted from [SensioLabsInsight](https://insight.sensiolabs.com/projects/7501993e-3fcf-4101-8272-cd4f61df4ada/analyses/7?status=violations)_"},"comment":{"url":"https://api.github.com/repos/steph-del/eveg/issues/comments/252228233","html_url":"https://github.com/steph-del/eveg/issues/16#issuecomment-252228233","issue_url":"https://api.github.com/repos/steph-del/eveg/issues/16","id":252228233,"user":{"login":"steph-del","id":13241830,"avatar_url":"https://avatars.githubusercontent.com/u/13241830?v=3","gravatar_id":"","url":"https://api.github.com/users/steph-del","html_url":"https://github.com/steph-del","followers_url":"https://api.github.com/users/steph-del/followers","following_url":"https://api.github.com/users/steph-del/following{/other_user}","gists_url":"https://api.github.com/users/steph-del/gists{/gist_id}","starred_url":"https://api.github.com/users/steph-del/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steph-del/subscriptions","organizations_url":"https://api.github.com/users/steph-del/orgs","repos_url":"https://api.github.com/users/steph-del/repos","events_url":"https://api.github.com/users/steph-del/events{/privacy}","received_events_url":"https://api.github.com/users/steph-del/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T11:34:18Z","updated_at":"2016-10-07T11:34:18Z","body":"fixed in 168cd06890ad2b847d0ae2e6e2b3268e35a569f7"}}
{"actor":{"display_login":"steph-del"}}