{"action":"created","comment":{"url":"https://api.github.com/repos/wallabag/wallabag/pulls/comments/57582242","id":57582242,"diff_hunk":"@@ -99,7 +99,10 @@\n             \"Sensio\\\\Bundle\\\\DistributionBundle\\\\Composer\\\\ScriptHandler::clearCache\",\n             \"Sensio\\\\Bundle\\\\DistributionBundle\\\\Composer\\\\ScriptHandler::installAssets\",\n             \"Sensio\\\\Bundle\\\\DistributionBundle\\\\Composer\\\\ScriptHandler::installRequirementsFile\",\n-            \"Sensio\\\\Bundle\\\\DistributionBundle\\\\Composer\\\\ScriptHandler::prepareDeploymentTarget\"\n+            \"Sensio\\\\Bundle\\\\DistributionBundle\\\\Composer\\\\ScriptHandler::prepareDeploymentTarget\",\n+            \"npm install\",\n+            \"bower install\",\n+            \"grunt\"","path":"composer.json","position":26,"original_position":26,"commit_id":"83c01c53f143c35dd625e28ddc955bd10b8f1700","original_commit_id":"83c01c53f143c35dd625e28ddc955bd10b8f1700","user":{"login":"j0k3r","id":62333,"avatar_url":"https://avatars.githubusercontent.com/u/62333?v=3","gravatar_id":"","url":"https://api.github.com/users/j0k3r","html_url":"https://github.com/j0k3r","followers_url":"https://api.github.com/users/j0k3r/followers","following_url":"https://api.github.com/users/j0k3r/following{/other_user}","gists_url":"https://api.github.com/users/j0k3r/gists{/gist_id}","starred_url":"https://api.github.com/users/j0k3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0k3r/subscriptions","organizations_url":"https://api.github.com/users/j0k3r/orgs","repos_url":"https://api.github.com/users/j0k3r/repos","events_url":"https://api.github.com/users/j0k3r/events{/privacy}","received_events_url":"https://api.github.com/users/j0k3r/received_events","type":"User","site_admin":false},"body":"This won't allow us to use a separate build on travis to run asset install.\r\nDon't you started something with a .sh file to handle that ?","created_at":"2016-03-28T15:13:39Z","updated_at":"2016-03-28T15:13:39Z","html_url":"https://github.com/wallabag/wallabag/pull/1782#discussion_r57582242","pull_request_url":"https://api.github.com/repos/wallabag/wallabag/pulls/1782","_links":{"self":{"href":"https://api.github.com/repos/wallabag/wallabag/pulls/comments/57582242"},"html":{"href":"https://github.com/wallabag/wallabag/pull/1782#discussion_r57582242"},"pull_request":{"href":"https://api.github.com/repos/wallabag/wallabag/pulls/1782"}}},"pull_request":{"url":"https://api.github.com/repos/wallabag/wallabag/pulls/1782","id":62666044,"html_url":"https://github.com/wallabag/wallabag/pull/1782","diff_url":"https://github.com/wallabag/wallabag/pull/1782.diff","patch_url":"https://github.com/wallabag/wallabag/pull/1782.patch","issue_url":"https://api.github.com/repos/wallabag/wallabag/issues/1782","number":1782,"state":"open","locked":false,"title":"V2 use npm","user":{"login":"tcitworld","id":2197836,"avatar_url":"https://avatars.githubusercontent.com/u/2197836?v=3","gravatar_id":"","url":"https://api.github.com/users/tcitworld","html_url":"https://github.com/tcitworld","followers_url":"https://api.github.com/users/tcitworld/followers","following_url":"https://api.github.com/users/tcitworld/following{/other_user}","gists_url":"https://api.github.com/users/tcitworld/gists{/gist_id}","starred_url":"https://api.github.com/users/tcitworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcitworld/subscriptions","organizations_url":"https://api.github.com/users/tcitworld/orgs","repos_url":"https://api.github.com/users/tcitworld/repos","events_url":"https://api.github.com/users/tcitworld/events{/privacy}","received_events_url":"https://api.github.com/users/tcitworld/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | kinda\r\n| Documentation | no\r\n| Translation   | no\r\n| Fixed tickets | #1759\r\n| License       | MIT\r\n\r\nWhat it does :\r\n\r\n* Removes Assetic Bundle\r\n* Uses npm to fetch most of the assets libraries\r\n* Uses bower to fetch a few more (fonts)\r\n* Uses grunt to :\r\n   * concat css and js files\r\n   * use browserify for all scripts that call `require()`\r\n   * minify css & js\r\n   * Symlink and copy the rest of assets\r\n* moved our own assets to `app/Ressources/static` \r\n* moved imgs used by both themes to `_global`.\r\n\r\nWhat doesn't work :\r\n\r\n* [x] Annotator isn't detected for some reason (inline js maybe the cause)\r\n* [x] Icomoon icons in Material theme don't show up (wrong path to font file ?)\r\n* [ ] Can't make Travis build assets on only one build and in the same time make npm launched by composer.\r\n* [ ] Find a way to add MathJax #1408","created_at":"2016-03-13T09:04:40Z","updated_at":"2016-03-28T15:13:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aa6ca3db8207535af87b7d7867d92c255d2c529","assignee":null,"milestone":{"url":"https://api.github.com/repos/wallabag/wallabag/milestones/6","html_url":"https://github.com/wallabag/wallabag/milestones/2.0.0","labels_url":"https://api.github.com/repos/wallabag/wallabag/milestones/6/labels","id":402907,"number":6,"title":"2.0.0","description":"","creator":{"login":"nicosomb","id":121870,"avatar_url":"https://avatars.githubusercontent.com/u/121870?v=3","gravatar_id":"","url":"https://api.github.com/users/nicosomb","html_url":"https://github.com/nicosomb","followers_url":"https://api.github.com/users/nicosomb/followers","following_url":"https://api.github.com/users/nicosomb/following{/other_user}","gists_url":"https://api.github.com/users/nicosomb/gists{/gist_id}","starred_url":"https://api.github.com/users/nicosomb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicosomb/subscriptions","organizations_url":"https://api.github.com/users/nicosomb/orgs","repos_url":"https://api.github.com/users/nicosomb/repos","events_url":"https://api.github.com/users/nicosomb/events{/privacy}","received_events_url":"https://api.github.com/users/nicosomb/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":66,"state":"open","created_at":"2013-08-15T19:39:25Z","updated_at":"2016-03-28T14:45:54Z","due_on":"2016-04-02T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/wallabag/wallabag/pulls/1782/commits","review_comments_url":"https://api.github.com/repos/wallabag/wallabag/pulls/1782/comments","review_comment_url":"https://api.github.com/repos/wallabag/wallabag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wallabag/wallabag/issues/1782/comments","statuses_url":"https://api.github.com/repos/wallabag/wallabag/statuses/83c01c53f143c35dd625e28ddc955bd10b8f1700","head":{"label":"wallabag:v2-use-npm","ref":"v2-use-npm","sha":"83c01c53f143c35dd625e28ddc955bd10b8f1700","user":{"login":"wallabag","id":4143872,"avatar_url":"https://avatars.githubusercontent.com/u/4143872?v=3","gravatar_id":"","url":"https://api.github.com/users/wallabag","html_url":"https://github.com/wallabag","followers_url":"https://api.github.com/users/wallabag/followers","following_url":"https://api.github.com/users/wallabag/following{/other_user}","gists_url":"https://api.github.com/users/wallabag/gists{/gist_id}","starred_url":"https://api.github.com/users/wallabag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallabag/subscriptions","organizations_url":"https://api.github.com/users/wallabag/orgs","repos_url":"https://api.github.com/users/wallabag/repos","events_url":"https://api.github.com/users/wallabag/events{/privacy}","received_events_url":"https://api.github.com/users/wallabag/received_events","type":"Organization","site_admin":false},"repo":{"id":9193949,"name":"wallabag","full_name":"wallabag/wallabag","owner":{"login":"wallabag","id":4143872,"avatar_url":"https://avatars.githubusercontent.com/u/4143872?v=3","gravatar_id":"","url":"https://api.github.com/users/wallabag","html_url":"https://github.com/wallabag","followers_url":"https://api.github.com/users/wallabag/followers","following_url":"https://api.github.com/users/wallabag/following{/other_user}","gists_url":"https://api.github.com/users/wallabag/gists{/gist_id}","starred_url":"https://api.github.com/users/wallabag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallabag/subscriptions","organizations_url":"https://api.github.com/users/wallabag/orgs","repos_url":"https://api.github.com/users/wallabag/repos","events_url":"https://api.github.com/users/wallabag/events{/privacy}","received_events_url":"https://api.github.com/users/wallabag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wallabag/wallabag","description":"open source self hostable read-it-later web app. Download the latest stable version: https://www.wallabag.org/pages/download-wallabag.html","fork":false,"url":"https://api.github.com/repos/wallabag/wallabag","forks_url":"https://api.github.com/repos/wallabag/wallabag/forks","keys_url":"https://api.github.com/repos/wallabag/wallabag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wallabag/wallabag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wallabag/wallabag/teams","hooks_url":"https://api.github.com/repos/wallabag/wallabag/hooks","issue_events_url":"https://api.github.com/repos/wallabag/wallabag/issues/events{/number}","events_url":"https://api.github.com/repos/wallabag/wallabag/events","assignees_url":"https://api.github.com/repos/wallabag/wallabag/assignees{/user}","branches_url":"https://api.github.com/repos/wallabag/wallabag/branches{/branch}","tags_url":"https://api.github.com/repos/wallabag/wallabag/tags","blobs_url":"https://api.github.com/repos/wallabag/wallabag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wallabag/wallabag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wallabag/wallabag/git/refs{/sha}","trees_url":"https://api.github.com/repos/wallabag/wallabag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wallabag/wallabag/statuses/{sha}","languages_url":"https://api.github.com/repos/wallabag/wallabag/languages","stargazers_url":"https://api.github.com/repos/wallabag/wallabag/stargazers","contributors_url":"https://api.github.com/repos/wallabag/wallabag/contributors","subscribers_url":"https://api.github.com/repos/wallabag/wallabag/subscribers","subscription_url":"https://api.github.com/repos/wallabag/wallabag/subscription","commits_url":"https://api.github.com/repos/wallabag/wallabag/commits{/sha}","git_commits_url":"https://api.github.com/repos/wallabag/wallabag/git/commits{/sha}","comments_url":"https://api.github.com/repos/wallabag/wallabag/comments{/number}","issue_comment_url":"https://api.github.com/repos/wallabag/wallabag/issues/comments{/number}","contents_url":"https://api.github.com/repos/wallabag/wallabag/contents/{+path}","compare_url":"https://api.github.com/repos/wallabag/wallabag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wallabag/wallabag/merges","archive_url":"https://api.github.com/repos/wallabag/wallabag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wallabag/wallabag/downloads","issues_url":"https://api.github.com/repos/wallabag/wallabag/issues{/number}","pulls_url":"https://api.github.com/repos/wallabag/wallabag/pulls{/number}","milestones_url":"https://api.github.com/repos/wallabag/wallabag/milestones{/number}","notifications_url":"https://api.github.com/repos/wallabag/wallabag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wallabag/wallabag/labels{/name}","releases_url":"https://api.github.com/repos/wallabag/wallabag/releases{/id}","deployments_url":"https://api.github.com/repos/wallabag/wallabag/deployments","created_at":"2013-04-03T12:21:14Z","updated_at":"2016-03-28T14:04:37Z","pushed_at":"2016-03-28T14:45:55Z","git_url":"git://github.com/wallabag/wallabag.git","ssh_url":"git@github.com:wallabag/wallabag.git","clone_url":"https://github.com/wallabag/wallabag.git","svn_url":"https://github.com/wallabag/wallabag","homepage":"https://www.wallabag.org","size":42586,"stargazers_count":1804,"watchers_count":1804,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":282,"mirror_url":null,"open_issues_count":218,"forks":282,"open_issues":218,"watchers":1804,"default_branch":"v2"}},"base":{"label":"wallabag:v2","ref":"v2","sha":"ba2157b270095757eb5af8062df72ce16c497637","user":{"login":"wallabag","id":4143872,"avatar_url":"https://avatars.githubusercontent.com/u/4143872?v=3","gravatar_id":"","url":"https://api.github.com/users/wallabag","html_url":"https://github.com/wallabag","followers_url":"https://api.github.com/users/wallabag/followers","following_url":"https://api.github.com/users/wallabag/following{/other_user}","gists_url":"https://api.github.com/users/wallabag/gists{/gist_id}","starred_url":"https://api.github.com/users/wallabag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallabag/subscriptions","organizations_url":"https://api.github.com/users/wallabag/orgs","repos_url":"https://api.github.com/users/wallabag/repos","events_url":"https://api.github.com/users/wallabag/events{/privacy}","received_events_url":"https://api.github.com/users/wallabag/received_events","type":"Organization","site_admin":false},"repo":{"id":9193949,"name":"wallabag","full_name":"wallabag/wallabag","owner":{"login":"wallabag","id":4143872,"avatar_url":"https://avatars.githubusercontent.com/u/4143872?v=3","gravatar_id":"","url":"https://api.github.com/users/wallabag","html_url":"https://github.com/wallabag","followers_url":"https://api.github.com/users/wallabag/followers","following_url":"https://api.github.com/users/wallabag/following{/other_user}","gists_url":"https://api.github.com/users/wallabag/gists{/gist_id}","starred_url":"https://api.github.com/users/wallabag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallabag/subscriptions","organizations_url":"https://api.github.com/users/wallabag/orgs","repos_url":"https://api.github.com/users/wallabag/repos","events_url":"https://api.github.com/users/wallabag/events{/privacy}","received_events_url":"https://api.github.com/users/wallabag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wallabag/wallabag","description":"open source self hostable read-it-later web app. Download the latest stable version: https://www.wallabag.org/pages/download-wallabag.html","fork":false,"url":"https://api.github.com/repos/wallabag/wallabag","forks_url":"https://api.github.com/repos/wallabag/wallabag/forks","keys_url":"https://api.github.com/repos/wallabag/wallabag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wallabag/wallabag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wallabag/wallabag/teams","hooks_url":"https://api.github.com/repos/wallabag/wallabag/hooks","issue_events_url":"https://api.github.com/repos/wallabag/wallabag/issues/events{/number}","events_url":"https://api.github.com/repos/wallabag/wallabag/events","assignees_url":"https://api.github.com/repos/wallabag/wallabag/assignees{/user}","branches_url":"https://api.github.com/repos/wallabag/wallabag/branches{/branch}","tags_url":"https://api.github.com/repos/wallabag/wallabag/tags","blobs_url":"https://api.github.com/repos/wallabag/wallabag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wallabag/wallabag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wallabag/wallabag/git/refs{/sha}","trees_url":"https://api.github.com/repos/wallabag/wallabag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wallabag/wallabag/statuses/{sha}","languages_url":"https://api.github.com/repos/wallabag/wallabag/languages","stargazers_url":"https://api.github.com/repos/wallabag/wallabag/stargazers","contributors_url":"https://api.github.com/repos/wallabag/wallabag/contributors","subscribers_url":"https://api.github.com/repos/wallabag/wallabag/subscribers","subscription_url":"https://api.github.com/repos/wallabag/wallabag/subscription","commits_url":"https://api.github.com/repos/wallabag/wallabag/commits{/sha}","git_commits_url":"https://api.github.com/repos/wallabag/wallabag/git/commits{/sha}","comments_url":"https://api.github.com/repos/wallabag/wallabag/comments{/number}","issue_comment_url":"https://api.github.com/repos/wallabag/wallabag/issues/comments{/number}","contents_url":"https://api.github.com/repos/wallabag/wallabag/contents/{+path}","compare_url":"https://api.github.com/repos/wallabag/wallabag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wallabag/wallabag/merges","archive_url":"https://api.github.com/repos/wallabag/wallabag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wallabag/wallabag/downloads","issues_url":"https://api.github.com/repos/wallabag/wallabag/issues{/number}","pulls_url":"https://api.github.com/repos/wallabag/wallabag/pulls{/number}","milestones_url":"https://api.github.com/repos/wallabag/wallabag/milestones{/number}","notifications_url":"https://api.github.com/repos/wallabag/wallabag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wallabag/wallabag/labels{/name}","releases_url":"https://api.github.com/repos/wallabag/wallabag/releases{/id}","deployments_url":"https://api.github.com/repos/wallabag/wallabag/deployments","created_at":"2013-04-03T12:21:14Z","updated_at":"2016-03-28T14:04:37Z","pushed_at":"2016-03-28T14:45:55Z","git_url":"git://github.com/wallabag/wallabag.git","ssh_url":"git@github.com:wallabag/wallabag.git","clone_url":"https://github.com/wallabag/wallabag.git","svn_url":"https://github.com/wallabag/wallabag","homepage":"https://www.wallabag.org","size":42586,"stargazers_count":1804,"watchers_count":1804,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":282,"mirror_url":null,"open_issues_count":218,"forks":282,"open_issues":218,"watchers":1804,"default_branch":"v2"}},"_links":{"self":{"href":"https://api.github.com/repos/wallabag/wallabag/pulls/1782"},"html":{"href":"https://github.com/wallabag/wallabag/pull/1782"},"issue":{"href":"https://api.github.com/repos/wallabag/wallabag/issues/1782"},"comments":{"href":"https://api.github.com/repos/wallabag/wallabag/issues/1782/comments"},"review_comments":{"href":"https://api.github.com/repos/wallabag/wallabag/pulls/1782/comments"},"review_comment":{"href":"https://api.github.com/repos/wallabag/wallabag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wallabag/wallabag/pulls/1782/commits"},"statuses":{"href":"https://api.github.com/repos/wallabag/wallabag/statuses/83c01c53f143c35dd625e28ddc955bd10b8f1700"}}}}