{"action":"created","comment":{"url":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/comments/53734966","id":53734966,"diff_hunk":"@@ -312,4 +292,49 @@ def create_test_obj(rfml_test)\n \n     test_obj\n   end\n+\n+  def make_test_priority_groups\n+    # Prioritize embedded tests before other tests\n+    upload_groups = []\n+    unordered_tests = []\n+    queued_tests = test_files.test_data.dup\n+\n+    until queued_tests.empty?\n+      new_ordered_group = []\n+      ordered_ids = upload_groups.flatten.map(&:rfml_id)\n+\n+      queued_tests.each do |rfml_test|\n+        if (rfml_test.embedded_ids - ordered_ids).empty?\n+          new_ordered_group << rfml_test\n+        else\n+          unordered_tests << rfml_test\n+        end\n+      end\n+\n+      # If all the queued tests make it to the unordered tests group, then\n+      # they contain non-existent RFML ids.","path":"lib/rainforest/cli/test_importer.rb","position":62,"original_position":62,"commit_id":"bc717fbc2e2e8a9891107739f4ab05bb640dcd7b","original_commit_id":"bc717fbc2e2e8a9891107739f4ab05bb640dcd7b","user":{"login":"epaulet","id":9178278,"avatar_url":"https://avatars.githubusercontent.com/u/9178278?v=3","gravatar_id":"","url":"https://api.github.com/users/epaulet","html_url":"https://github.com/epaulet","followers_url":"https://api.github.com/users/epaulet/followers","following_url":"https://api.github.com/users/epaulet/following{/other_user}","gists_url":"https://api.github.com/users/epaulet/gists{/gist_id}","starred_url":"https://api.github.com/users/epaulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epaulet/subscriptions","organizations_url":"https://api.github.com/users/epaulet/orgs","repos_url":"https://api.github.com/users/epaulet/repos","events_url":"https://api.github.com/users/epaulet/events{/privacy}","received_events_url":"https://api.github.com/users/epaulet/received_events","type":"User","site_admin":false},"body":"I'll try refactoring to a clearer approach.","created_at":"2016-02-23T04:22:05Z","updated_at":"2016-02-23T04:22:05Z","html_url":"https://github.com/rainforestapp/rainforest-cli/pull/56#discussion_r53734966","pull_request_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/comments/53734966"},"html":{"href":"https://github.com/rainforestapp/rainforest-cli/pull/56#discussion_r53734966"},"pull_request":{"href":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/56","id":60035491,"html_url":"https://github.com/rainforestapp/rainforest-cli/pull/56","diff_url":"https://github.com/rainforestapp/rainforest-cli/pull/56.diff","patch_url":"https://github.com/rainforestapp/rainforest-cli/pull/56.patch","issue_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/issues/56","number":56,"state":"open","locked":false,"title":"Reject incorrect RFML ids","user":{"login":"epaulet","id":9178278,"avatar_url":"https://avatars.githubusercontent.com/u/9178278?v=3","gravatar_id":"","url":"https://api.github.com/users/epaulet","html_url":"https://github.com/epaulet","followers_url":"https://api.github.com/users/epaulet/followers","following_url":"https://api.github.com/users/epaulet/following{/other_user}","gists_url":"https://api.github.com/users/epaulet/gists{/gist_id}","starred_url":"https://api.github.com/users/epaulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epaulet/subscriptions","organizations_url":"https://api.github.com/users/epaulet/orgs","repos_url":"https://api.github.com/users/epaulet/repos","events_url":"https://api.github.com/users/epaulet/events{/privacy}","received_events_url":"https://api.github.com/users/epaulet/received_events","type":"User","site_admin":false},"body":"fixes #54 ","created_at":"2016-02-20T03:12:56Z","updated_at":"2016-02-23T04:22:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba39fe21c90bb84c881c685ab779c95092bcc4ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/56/commits","review_comments_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/56/comments","review_comment_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/issues/56/comments","statuses_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/statuses/bc717fbc2e2e8a9891107739f4ab05bb640dcd7b","head":{"label":"rainforestapp:validate-test-ids","ref":"validate-test-ids","sha":"bc717fbc2e2e8a9891107739f4ab05bb640dcd7b","user":{"login":"rainforestapp","id":1892571,"avatar_url":"https://avatars.githubusercontent.com/u/1892571?v=3","gravatar_id":"","url":"https://api.github.com/users/rainforestapp","html_url":"https://github.com/rainforestapp","followers_url":"https://api.github.com/users/rainforestapp/followers","following_url":"https://api.github.com/users/rainforestapp/following{/other_user}","gists_url":"https://api.github.com/users/rainforestapp/gists{/gist_id}","starred_url":"https://api.github.com/users/rainforestapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainforestapp/subscriptions","organizations_url":"https://api.github.com/users/rainforestapp/orgs","repos_url":"https://api.github.com/users/rainforestapp/repos","events_url":"https://api.github.com/users/rainforestapp/events{/privacy}","received_events_url":"https://api.github.com/users/rainforestapp/received_events","type":"Organization","site_admin":false},"repo":{"id":11987995,"name":"rainforest-cli","full_name":"rainforestapp/rainforest-cli","owner":{"login":"rainforestapp","id":1892571,"avatar_url":"https://avatars.githubusercontent.com/u/1892571?v=3","gravatar_id":"","url":"https://api.github.com/users/rainforestapp","html_url":"https://github.com/rainforestapp","followers_url":"https://api.github.com/users/rainforestapp/followers","following_url":"https://api.github.com/users/rainforestapp/following{/other_user}","gists_url":"https://api.github.com/users/rainforestapp/gists{/gist_id}","starred_url":"https://api.github.com/users/rainforestapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainforestapp/subscriptions","organizations_url":"https://api.github.com/users/rainforestapp/orgs","repos_url":"https://api.github.com/users/rainforestapp/repos","events_url":"https://api.github.com/users/rainforestapp/events{/privacy}","received_events_url":"https://api.github.com/users/rainforestapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rainforestapp/rainforest-cli","description":"Command line interface to Rainforest","fork":false,"url":"https://api.github.com/repos/rainforestapp/rainforest-cli","forks_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/forks","keys_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/teams","hooks_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/hooks","issue_events_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/issues/events{/number}","events_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/events","assignees_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/assignees{/user}","branches_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/branches{/branch}","tags_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/tags","blobs_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/languages","stargazers_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/stargazers","contributors_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/contributors","subscribers_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/subscribers","subscription_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/subscription","commits_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/contents/{+path}","compare_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/merges","archive_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/downloads","issues_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/issues{/number}","pulls_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/labels{/name}","releases_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/releases{/id}","deployments_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/deployments","created_at":"2013-08-08T22:23:18Z","updated_at":"2016-02-05T17:57:56Z","pushed_at":"2016-02-23T02:11:49Z","git_url":"git://github.com/rainforestapp/rainforest-cli.git","ssh_url":"git@github.com:rainforestapp/rainforest-cli.git","clone_url":"https://github.com/rainforestapp/rainforest-cli.git","svn_url":"https://github.com/rainforestapp/rainforest-cli","homepage":"https://www.rainforestqa.com/","size":198,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":12,"default_branch":"master"}},"base":{"label":"rainforestapp:master","ref":"master","sha":"ec474ba8b9724edc38d27087c58bc611eb42a129","user":{"login":"rainforestapp","id":1892571,"avatar_url":"https://avatars.githubusercontent.com/u/1892571?v=3","gravatar_id":"","url":"https://api.github.com/users/rainforestapp","html_url":"https://github.com/rainforestapp","followers_url":"https://api.github.com/users/rainforestapp/followers","following_url":"https://api.github.com/users/rainforestapp/following{/other_user}","gists_url":"https://api.github.com/users/rainforestapp/gists{/gist_id}","starred_url":"https://api.github.com/users/rainforestapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainforestapp/subscriptions","organizations_url":"https://api.github.com/users/rainforestapp/orgs","repos_url":"https://api.github.com/users/rainforestapp/repos","events_url":"https://api.github.com/users/rainforestapp/events{/privacy}","received_events_url":"https://api.github.com/users/rainforestapp/received_events","type":"Organization","site_admin":false},"repo":{"id":11987995,"name":"rainforest-cli","full_name":"rainforestapp/rainforest-cli","owner":{"login":"rainforestapp","id":1892571,"avatar_url":"https://avatars.githubusercontent.com/u/1892571?v=3","gravatar_id":"","url":"https://api.github.com/users/rainforestapp","html_url":"https://github.com/rainforestapp","followers_url":"https://api.github.com/users/rainforestapp/followers","following_url":"https://api.github.com/users/rainforestapp/following{/other_user}","gists_url":"https://api.github.com/users/rainforestapp/gists{/gist_id}","starred_url":"https://api.github.com/users/rainforestapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainforestapp/subscriptions","organizations_url":"https://api.github.com/users/rainforestapp/orgs","repos_url":"https://api.github.com/users/rainforestapp/repos","events_url":"https://api.github.com/users/rainforestapp/events{/privacy}","received_events_url":"https://api.github.com/users/rainforestapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rainforestapp/rainforest-cli","description":"Command line interface to Rainforest","fork":false,"url":"https://api.github.com/repos/rainforestapp/rainforest-cli","forks_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/forks","keys_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/teams","hooks_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/hooks","issue_events_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/issues/events{/number}","events_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/events","assignees_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/assignees{/user}","branches_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/branches{/branch}","tags_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/tags","blobs_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/languages","stargazers_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/stargazers","contributors_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/contributors","subscribers_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/subscribers","subscription_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/subscription","commits_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/contents/{+path}","compare_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/merges","archive_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/downloads","issues_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/issues{/number}","pulls_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/labels{/name}","releases_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/releases{/id}","deployments_url":"https://api.github.com/repos/rainforestapp/rainforest-cli/deployments","created_at":"2013-08-08T22:23:18Z","updated_at":"2016-02-05T17:57:56Z","pushed_at":"2016-02-23T02:11:49Z","git_url":"git://github.com/rainforestapp/rainforest-cli.git","ssh_url":"git@github.com:rainforestapp/rainforest-cli.git","clone_url":"https://github.com/rainforestapp/rainforest-cli.git","svn_url":"https://github.com/rainforestapp/rainforest-cli","homepage":"https://www.rainforestqa.com/","size":198,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/56"},"html":{"href":"https://github.com/rainforestapp/rainforest-cli/pull/56"},"issue":{"href":"https://api.github.com/repos/rainforestapp/rainforest-cli/issues/56"},"comments":{"href":"https://api.github.com/repos/rainforestapp/rainforest-cli/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rainforestapp/rainforest-cli/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/rainforestapp/rainforest-cli/statuses/bc717fbc2e2e8a9891107739f4ab05bb640dcd7b"}}}}