{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/49785720","id":49785720,"diff_hunk":"@@ -33,67 +39,67 @@ public function __construct( User $user ) {\n \t}\n \n \t/**\n-\t * Gets top wikis from DB for devboxes from method UserIdentityBox::getTestData()\n+\t * Gets top wikis from stats DB based on number of edits\n \t *\n \t * @param Integer|null $limit\n \t *\n \t * @return array\n \t */\n-\tprivate function getTopWikisFromDb( $limit = null ) {\n-\t\tglobal $wgCityId, $wgDevelEnvironment, $wgSpecialsDB;\n-\n-\t\tif ( is_null( $limit ) ) {\n-\t\t\t$limit = self::MAX_FAV_WIKIS;\n-\t\t}\n+\tprivate function getTopWikisFromDb( $limit = self::MAX_FAV_WIKIS ) {\n+\t\tglobal $wgCityId, $wgSpecialsDB;\n \n \t\tif ( empty( $wgCityId ) ) {\n \t\t\t// staff/internal does not have stats db\n \t\t\t$wikis = [];\n-\t\t} else if ( $wgDevelEnvironment ) {","path":"extensions/wikia/UserProfilePageV3/models/FavoriteWikisModel.class.php","position":50,"original_position":50,"commit_id":"a86647cb78477004bf22a434fd55a380f8041ffe","original_commit_id":"a86647cb78477004bf22a434fd55a380f8041ffe","user":{"login":"garthwebb","id":72574,"avatar_url":"https://avatars.githubusercontent.com/u/72574?v=3","gravatar_id":"","url":"https://api.github.com/users/garthwebb","html_url":"https://github.com/garthwebb","followers_url":"https://api.github.com/users/garthwebb/followers","following_url":"https://api.github.com/users/garthwebb/following{/other_user}","gists_url":"https://api.github.com/users/garthwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/garthwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garthwebb/subscriptions","organizations_url":"https://api.github.com/users/garthwebb/orgs","repos_url":"https://api.github.com/users/garthwebb/repos","events_url":"https://api.github.com/users/garthwebb/events{/privacy}","received_events_url":"https://api.github.com/users/garthwebb/received_events","type":"User","site_admin":false},"body":"They were using $wgDevelEnvironment as a way to cook the data in dev for what was essentially guided unit tests.  The `getTestData` method returned a set of preselected wikis, one of which was one that should be filtered.  This really belongs in a unit test somehwere.  Also, there wasn't any \"strange behavior\" that I could tell, so I thought it was best to get rid of this fake code path.","created_at":"2016-01-14T21:11:50Z","updated_at":"2016-01-14T21:11:50Z","html_url":"https://github.com/Wikia/app/pull/9431#discussion_r49785720","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/9431","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/49785720"},"html":{"href":"https://github.com/Wikia/app/pull/9431#discussion_r49785720"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/9431"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/9431","id":55819508,"html_url":"https://github.com/Wikia/app/pull/9431","diff_url":"https://github.com/Wikia/app/pull/9431.diff","patch_url":"https://github.com/Wikia/app/pull/9431.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/9431","number":9431,"state":"open","locked":false,"title":"SOC-1857 Cache results from getTopWikis query","user":{"login":"garthwebb","id":72574,"avatar_url":"https://avatars.githubusercontent.com/u/72574?v=3","gravatar_id":"","url":"https://api.github.com/users/garthwebb","html_url":"https://github.com/garthwebb","followers_url":"https://api.github.com/users/garthwebb/followers","following_url":"https://api.github.com/users/garthwebb/following{/other_user}","gists_url":"https://api.github.com/users/garthwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/garthwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garthwebb/subscriptions","organizations_url":"https://api.github.com/users/garthwebb/orgs","repos_url":"https://api.github.com/users/garthwebb/repos","events_url":"https://api.github.com/users/garthwebb/events{/privacy}","received_events_url":"https://api.github.com/users/garthwebb/received_events","type":"User","site_admin":false},"body":"Implemented caching of often run query.  Note that this builds off cleanup pull request #9430.\r\n\r\nhttps://wikia-inc.atlassian.net/browse/SOC-1857","created_at":"2016-01-12T21:27:36Z","updated_at":"2016-01-14T21:11:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"404d5fe4792b1a06133fadf7e0fec00f92037684","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/9431/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/9431/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/9431/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/a86647cb78477004bf22a434fd55a380f8041ffe","head":{"label":"Wikia:SOC-1857-work","ref":"SOC-1857-work","sha":"a86647cb78477004bf22a434fd55a380f8041ffe","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-01-11T09:19:27Z","pushed_at":"2016-01-14T20:30:41Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":663808,"stargazers_count":95,"watchers_count":95,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":83,"forks":72,"open_issues":83,"watchers":95,"default_branch":"dev"}},"base":{"label":"Wikia:SOC-1857-cleanup","ref":"SOC-1857-cleanup","sha":"e141349467660a3766689f92758e73b371f8a6a1","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-01-11T09:19:27Z","pushed_at":"2016-01-14T20:30:41Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":663808,"stargazers_count":95,"watchers_count":95,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":83,"forks":72,"open_issues":83,"watchers":95,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/9431"},"html":{"href":"https://github.com/Wikia/app/pull/9431"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/9431"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/9431/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/9431/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/9431/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/a86647cb78477004bf22a434fd55a380f8041ffe"}}}}