{"action":"created","issue":{"url":"https://api.github.com/repos/rstoenescu/quasar-framework/issues/139","repository_url":"https://api.github.com/repos/rstoenescu/quasar-framework","labels_url":"https://api.github.com/repos/rstoenescu/quasar-framework/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/rstoenescu/quasar-framework/issues/139/comments","events_url":"https://api.github.com/repos/rstoenescu/quasar-framework/issues/139/events","html_url":"https://github.com/rstoenescu/quasar-framework/issues/139","id":184877422,"number":139,"title":"IE9 support for docs","user":{"login":"plievone","id":134936,"avatar_url":"https://avatars.githubusercontent.com/u/134936?v=3","gravatar_id":"","url":"https://api.github.com/users/plievone","html_url":"https://github.com/plievone","followers_url":"https://api.github.com/users/plievone/followers","following_url":"https://api.github.com/users/plievone/following{/other_user}","gists_url":"https://api.github.com/users/plievone/gists{/gist_id}","starred_url":"https://api.github.com/users/plievone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plievone/subscriptions","organizations_url":"https://api.github.com/users/plievone/orgs","repos_url":"https://api.github.com/users/plievone/repos","events_url":"https://api.github.com/users/plievone/events{/privacy}","received_events_url":"https://api.github.com/users/plievone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-24T15:40:17Z","updated_at":"2016-10-24T20:40:02Z","closed_at":null,"body":"Hi, would you consider adding necessary polyfills for docs to work in IE9? I haven't looked into the internals yet, but I suspect at least `classList` is needed, if you use it directly. I'm ok with some visual layout errors but it would be nice to be able to experiment with quasar via BrowserStack, now it throws an error.\r\n\r\nI will also experiment with some polyfills locally, but adding them to docs would benefit more people."},"comment":{"url":"https://api.github.com/repos/rstoenescu/quasar-framework/issues/comments/255859455","html_url":"https://github.com/rstoenescu/quasar-framework/issues/139#issuecomment-255859455","issue_url":"https://api.github.com/repos/rstoenescu/quasar-framework/issues/139","id":255859455,"user":{"login":"plievone","id":134936,"avatar_url":"https://avatars.githubusercontent.com/u/134936?v=3","gravatar_id":"","url":"https://api.github.com/users/plievone","html_url":"https://github.com/plievone","followers_url":"https://api.github.com/users/plievone/followers","following_url":"https://api.github.com/users/plievone/following{/other_user}","gists_url":"https://api.github.com/users/plievone/gists{/gist_id}","starred_url":"https://api.github.com/users/plievone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plievone/subscriptions","organizations_url":"https://api.github.com/users/plievone/orgs","repos_url":"https://api.github.com/users/plievone/repos","events_url":"https://api.github.com/users/plievone/events{/privacy}","received_events_url":"https://api.github.com/users/plievone/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T20:40:02Z","updated_at":"2016-10-24T20:40:02Z","body":"Ok, got it working in IE9 mostly without js errors. Layout for docs work fine, but framework components are all over the place, there's some general styling issue I guess and some pretty major visual errors preventing some components being used. In my brief testing, Javascript errors could be prevented with these three modifications:\r\n\r\n`Element.classList`. Polyfilled with some general classList script. But note that vue.js doesn't need a polyfill, perhaps Quasar could follow similar route or document that it is needed: https://github.com/vuejs/vue/blob/ae93d2b/src/platforms/web/runtime/class-util.js\r\n\r\n`Element.dataset`, which is IE11 only, but luckily quasar only reads from dataset so it could be somewhat polyfilled with some general dataset script utilizing getters. Maybe you could use data-* attributes directly or document that it is needed. It is used in a couple of places here: https://github.com/rstoenescu/quasar-framework/blob/1d7e6f9/src/utils/store.js#L7\r\n\r\n`Array.prototype.find` which is a ES2015 feature and not available in IE11. Could be polyfilled with some general Array.prototype.find script. So that should be documented. It is used in some or all of these lines:\r\nhttps://github.com/rstoenescu/quasar-framework/blob/c569360/src/vue-components/tab/Tabs.vue#L173\r\nhttps://github.com/rstoenescu/quasar-framework/blob/c569360/src/vue-components/select/DialogSelect.vue#L61\r\nhttps://github.com/rstoenescu/quasar-framework/blob/c569360/src/vue-components/select/Select.vue#L128\r\n\r\nIn some of those places where Array.prototype.find is used, does it also use Array.prototype.includes, which is ES2016, but I didn't come across those error yet.\r\n"}}
{"actor":{"display_login":"plievone"}}