{"action":"created","issue":{"url":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/99","labels_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/99/comments","events_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/99/events","html_url":"https://github.com/projectatomic/docker-storage-setup/issues/99","id":125346162,"number":99,"title":"Devices /dev/cciss/c0d1 detected as partition","user":{"login":"baboune","id":547556,"avatar_url":"https://avatars.githubusercontent.com/u/547556?v=3","gravatar_id":"","url":"https://api.github.com/users/baboune","html_url":"https://github.com/baboune","followers_url":"https://api.github.com/users/baboune/followers","following_url":"https://api.github.com/users/baboune/following{/other_user}","gists_url":"https://api.github.com/users/baboune/gists{/gist_id}","starred_url":"https://api.github.com/users/baboune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baboune/subscriptions","organizations_url":"https://api.github.com/users/baboune/orgs","repos_url":"https://api.github.com/users/baboune/repos","events_url":"https://api.github.com/users/baboune/events{/privacy}","received_events_url":"https://api.github.com/users/baboune/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-07T08:12:58Z","updated_at":"2016-01-07T08:16:24Z","closed_at":null,"body":"Hi,\r\n\r\nSpecifying DEVS=\"/dev/cciss/c0d1\" which is a correct device label fails with the following error:\r\n\"Partition specification unsupported at this time.\"\r\n\r\nThe following on line 426\r\n    if [[ $dev =~ .*[0-9]$ ]]; then\r\n       Fatal \"Partition specification unsupported at this time.\"\r\n    fi\r\n\r\nIdentifies any number as a partition which is false in the above case.\r\n\r\n/dev/cciss/c0d1 is the device name of a logical drive on an HP DL 380 server using a RAID controller.\r\n\r\nMy suggestion would be to remove the test for the number as it is not sufficient, and creates false answers.\r\n"},"comment":{"url":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/comments/169592218","html_url":"https://github.com/projectatomic/docker-storage-setup/issues/99#issuecomment-169592218","issue_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/99","id":169592218,"user":{"login":"baboune","id":547556,"avatar_url":"https://avatars.githubusercontent.com/u/547556?v=3","gravatar_id":"","url":"https://api.github.com/users/baboune","html_url":"https://github.com/baboune","followers_url":"https://api.github.com/users/baboune/followers","following_url":"https://api.github.com/users/baboune/following{/other_user}","gists_url":"https://api.github.com/users/baboune/gists{/gist_id}","starred_url":"https://api.github.com/users/baboune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baboune/subscriptions","organizations_url":"https://api.github.com/users/baboune/orgs","repos_url":"https://api.github.com/users/baboune/repos","events_url":"https://api.github.com/users/baboune/events{/privacy}","received_events_url":"https://api.github.com/users/baboune/received_events","type":"User","site_admin":false},"created_at":"2016-01-07T08:16:24Z","updated_at":"2016-01-07T08:16:24Z","body":"Note that disabling the lines in question is not sufficient:\r\n\r\n```\r\ndocker-storage-setup \r\nChecking that no-one is using this disk right now ... OK\r\n\r\nDisk /dev/cciss/c0d1: 931.5 GiB, 1000171331584 bytes, 1953459632 sectors\r\nUnits: sectors of 1 * 512 = 512 bytes\r\nSector size (logical/physical): 512 bytes / 512 bytes\r\nI/O size (minimum/optimal): 512 bytes / 512 bytes\r\nDisklabel type: dos\r\nDisk identifier: 0x6073abbd\r\n\r\nOld situation:\r\n\r\n>>> Script header accepted.\r\n>>> Created a new DOS disklabel with disk identifier 0xdea5060a.\r\nFailed to add partition: Numerical result out of range\r\nLeaving.\r\n```"}}