{"action":"created","comment":{"url":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/comments/77168289","id":77168289,"diff_hunk":"@@ -105,7 +84,33 @@\n         return new BasicTransformModellingResult<>(loopStatement, errors);\n     }\n \n-    private boolean isContainInvalidChars(String varName) {\n-        return StringUtils.containsAny(varName, \" \\t\\r\\n\\b\");\n+    private LoopStatement createMapForLoopStatement(String keyName, String valueName, String collectionExpression, Accumulator dependencyAccumulator) {\n+        validateChars(keyName);\n+        validateChars(valueName);\n+        return new MapForLoopStatement(\n+                keyName,\n+                valueName,\n+                collectionExpression,\n+                dependencyAccumulator.getFunctionDependencies(),\n+                dependencyAccumulator.getSystemPropertyDependencies());\n+    }\n+\n+    private LoopStatement createLoopStatement(String varName, String collectionExpression, Accumulator dependencyAccumulator, boolean isParallelLoop) {\n+        validateChars(varName);\n+        LoopStatement loopStatement;\n+        if (isParallelLoop) {\n+            loopStatement = new ParallelLoopStatement(varName, collectionExpression,\n+                    dependencyAccumulator.getFunctionDependencies(),\n+                    dependencyAccumulator.getSystemPropertyDependencies());\n+        } else {\n+            loopStatement = new ListForLoopStatement(varName, collectionExpression,\n+                    dependencyAccumulator.getFunctionDependencies(),\n+                    dependencyAccumulator.getSystemPropertyDependencies());\n+        }\n+        return loopStatement;\n+    }\n+\n+    private void validateChars(String name) {","path":"cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/modeller/transformers/AbstractForTransformer.java","position":111,"original_position":111,"commit_id":"df9d728c705dceb01ae862c9ce8edfe71bb679e0","original_commit_id":"df9d728c705dceb01ae862c9ce8edfe71bb679e0","user":{"login":"gituser173","id":12094982,"avatar_url":"https://avatars.githubusercontent.com/u/12094982?v=3","gravatar_id":"","url":"https://api.github.com/users/gituser173","html_url":"https://github.com/gituser173","followers_url":"https://api.github.com/users/gituser173/followers","following_url":"https://api.github.com/users/gituser173/following{/other_user}","gists_url":"https://api.github.com/users/gituser173/gists{/gist_id}","starred_url":"https://api.github.com/users/gituser173/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gituser173/subscriptions","organizations_url":"https://api.github.com/users/gituser173/orgs","repos_url":"https://api.github.com/users/gituser173/repos","events_url":"https://api.github.com/users/gituser173/events{/privacy}","received_events_url":"https://api.github.com/users/gituser173/received_events","type":"User","site_admin":false},"body":"do we need this small method? seems reduntant","created_at":"2016-09-01T13:00:47Z","updated_at":"2016-09-01T13:00:47Z","html_url":"https://github.com/CloudSlang/cloud-slang/pull/823#discussion_r77168289","pull_request_url":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/823","_links":{"self":{"href":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/comments/77168289"},"html":{"href":"https://github.com/CloudSlang/cloud-slang/pull/823#discussion_r77168289"},"pull_request":{"href":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/823"}}},"pull_request":{"url":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/823","id":82534789,"html_url":"https://github.com/CloudSlang/cloud-slang/pull/823","diff_url":"https://github.com/CloudSlang/cloud-slang/pull/823.diff","patch_url":"https://github.com/CloudSlang/cloud-slang/pull/823.patch","issue_url":"https://api.github.com/repos/CloudSlang/cloud-slang/issues/823","number":823,"state":"open","locked":false,"title":"Characters convention","user":{"login":"Bonczidai","id":8058961,"avatar_url":"https://avatars.githubusercontent.com/u/8058961?v=3","gravatar_id":"","url":"https://api.github.com/users/Bonczidai","html_url":"https://github.com/Bonczidai","followers_url":"https://api.github.com/users/Bonczidai/followers","following_url":"https://api.github.com/users/Bonczidai/following{/other_user}","gists_url":"https://api.github.com/users/Bonczidai/gists{/gist_id}","starred_url":"https://api.github.com/users/Bonczidai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bonczidai/subscriptions","organizations_url":"https://api.github.com/users/Bonczidai/orgs","repos_url":"https://api.github.com/users/Bonczidai/repos","events_url":"https://api.github.com/users/Bonczidai/events{/privacy}","received_events_url":"https://api.github.com/users/Bonczidai/received_events","type":"User","site_admin":false},"body":"fixes #817\r\n\r\nSigned-off-by: Bonczidai Levente <levente.bonczidai@hpe.com>","created_at":"2016-08-24T12:42:27Z","updated_at":"2016-09-01T13:00:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e8fe82528541502de80e36f73042da9d2e6f3c1","assignee":{"login":"gituser173","id":12094982,"avatar_url":"https://avatars.githubusercontent.com/u/12094982?v=3","gravatar_id":"","url":"https://api.github.com/users/gituser173","html_url":"https://github.com/gituser173","followers_url":"https://api.github.com/users/gituser173/followers","following_url":"https://api.github.com/users/gituser173/following{/other_user}","gists_url":"https://api.github.com/users/gituser173/gists{/gist_id}","starred_url":"https://api.github.com/users/gituser173/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gituser173/subscriptions","organizations_url":"https://api.github.com/users/gituser173/orgs","repos_url":"https://api.github.com/users/gituser173/repos","events_url":"https://api.github.com/users/gituser173/events{/privacy}","received_events_url":"https://api.github.com/users/gituser173/received_events","type":"User","site_admin":false},"assignees":[{"login":"gituser173","id":12094982,"avatar_url":"https://avatars.githubusercontent.com/u/12094982?v=3","gravatar_id":"","url":"https://api.github.com/users/gituser173","html_url":"https://github.com/gituser173","followers_url":"https://api.github.com/users/gituser173/followers","following_url":"https://api.github.com/users/gituser173/following{/other_user}","gists_url":"https://api.github.com/users/gituser173/gists{/gist_id}","starred_url":"https://api.github.com/users/gituser173/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gituser173/subscriptions","organizations_url":"https://api.github.com/users/gituser173/orgs","repos_url":"https://api.github.com/users/gituser173/repos","events_url":"https://api.github.com/users/gituser173/events{/privacy}","received_events_url":"https://api.github.com/users/gituser173/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/CloudSlang/cloud-slang/milestones/36","html_url":"https://github.com/CloudSlang/cloud-slang/milestones/1.0-Stabilization","labels_url":"https://api.github.com/repos/CloudSlang/cloud-slang/milestones/36/labels","id":1953517,"number":36,"title":"1.0-Stabilization","description":"","creator":{"login":"meshipeer","id":6988387,"avatar_url":"https://avatars.githubusercontent.com/u/6988387?v=3","gravatar_id":"","url":"https://api.github.com/users/meshipeer","html_url":"https://github.com/meshipeer","followers_url":"https://api.github.com/users/meshipeer/followers","following_url":"https://api.github.com/users/meshipeer/following{/other_user}","gists_url":"https://api.github.com/users/meshipeer/gists{/gist_id}","starred_url":"https://api.github.com/users/meshipeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meshipeer/subscriptions","organizations_url":"https://api.github.com/users/meshipeer/orgs","repos_url":"https://api.github.com/users/meshipeer/repos","events_url":"https://api.github.com/users/meshipeer/events{/privacy}","received_events_url":"https://api.github.com/users/meshipeer/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":10,"state":"open","created_at":"2016-08-21T12:34:24Z","updated_at":"2016-09-01T09:43:32Z","due_on":"2016-09-19T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/823/commits","review_comments_url":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/823/comments","review_comment_url":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CloudSlang/cloud-slang/issues/823/comments","statuses_url":"https://api.github.com/repos/CloudSlang/cloud-slang/statuses/df9d728c705dceb01ae862c9ce8edfe71bb679e0","head":{"label":"CloudSlang:validate_chars","ref":"validate_chars","sha":"df9d728c705dceb01ae862c9ce8edfe71bb679e0","user":{"login":"CloudSlang","id":10261505,"avatar_url":"https://avatars.githubusercontent.com/u/10261505?v=3","gravatar_id":"","url":"https://api.github.com/users/CloudSlang","html_url":"https://github.com/CloudSlang","followers_url":"https://api.github.com/users/CloudSlang/followers","following_url":"https://api.github.com/users/CloudSlang/following{/other_user}","gists_url":"https://api.github.com/users/CloudSlang/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudSlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudSlang/subscriptions","organizations_url":"https://api.github.com/users/CloudSlang/orgs","repos_url":"https://api.github.com/users/CloudSlang/repos","events_url":"https://api.github.com/users/CloudSlang/events{/privacy}","received_events_url":"https://api.github.com/users/CloudSlang/received_events","type":"Organization","site_admin":false},"repo":{"id":28305425,"name":"cloud-slang","full_name":"CloudSlang/cloud-slang","owner":{"login":"CloudSlang","id":10261505,"avatar_url":"https://avatars.githubusercontent.com/u/10261505?v=3","gravatar_id":"","url":"https://api.github.com/users/CloudSlang","html_url":"https://github.com/CloudSlang","followers_url":"https://api.github.com/users/CloudSlang/followers","following_url":"https://api.github.com/users/CloudSlang/following{/other_user}","gists_url":"https://api.github.com/users/CloudSlang/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudSlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudSlang/subscriptions","organizations_url":"https://api.github.com/users/CloudSlang/orgs","repos_url":"https://api.github.com/users/CloudSlang/repos","events_url":"https://api.github.com/users/CloudSlang/events{/privacy}","received_events_url":"https://api.github.com/users/CloudSlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CloudSlang/cloud-slang","description":"CloudSlang Language, CLI and Builder","fork":false,"url":"https://api.github.com/repos/CloudSlang/cloud-slang","forks_url":"https://api.github.com/repos/CloudSlang/cloud-slang/forks","keys_url":"https://api.github.com/repos/CloudSlang/cloud-slang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CloudSlang/cloud-slang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CloudSlang/cloud-slang/teams","hooks_url":"https://api.github.com/repos/CloudSlang/cloud-slang/hooks","issue_events_url":"https://api.github.com/repos/CloudSlang/cloud-slang/issues/events{/number}","events_url":"https://api.github.com/repos/CloudSlang/cloud-slang/events","assignees_url":"https://api.github.com/repos/CloudSlang/cloud-slang/assignees{/user}","branches_url":"https://api.github.com/repos/CloudSlang/cloud-slang/branches{/branch}","tags_url":"https://api.github.com/repos/CloudSlang/cloud-slang/tags","blobs_url":"https://api.github.com/repos/CloudSlang/cloud-slang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CloudSlang/cloud-slang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CloudSlang/cloud-slang/git/refs{/sha}","trees_url":"https://api.github.com/repos/CloudSlang/cloud-slang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CloudSlang/cloud-slang/statuses/{sha}","languages_url":"https://api.github.com/repos/CloudSlang/cloud-slang/languages","stargazers_url":"https://api.github.com/repos/CloudSlang/cloud-slang/stargazers","contributors_url":"https://api.github.com/repos/CloudSlang/cloud-slang/contributors","subscribers_url":"https://api.github.com/repos/CloudSlang/cloud-slang/subscribers","subscription_url":"https://api.github.com/repos/CloudSlang/cloud-slang/subscription","commits_url":"https://api.github.com/repos/CloudSlang/cloud-slang/commits{/sha}","git_commits_url":"https://api.github.com/repos/CloudSlang/cloud-slang/git/commits{/sha}","comments_url":"https://api.github.com/repos/CloudSlang/cloud-slang/comments{/number}","issue_comment_url":"https://api.github.com/repos/CloudSlang/cloud-slang/issues/comments{/number}","contents_url":"https://api.github.com/repos/CloudSlang/cloud-slang/contents/{+path}","compare_url":"https://api.github.com/repos/CloudSlang/cloud-slang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CloudSlang/cloud-slang/merges","archive_url":"https://api.github.com/repos/CloudSlang/cloud-slang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CloudSlang/cloud-slang/downloads","issues_url":"https://api.github.com/repos/CloudSlang/cloud-slang/issues{/number}","pulls_url":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls{/number}","milestones_url":"https://api.github.com/repos/CloudSlang/cloud-slang/milestones{/number}","notifications_url":"https://api.github.com/repos/CloudSlang/cloud-slang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CloudSlang/cloud-slang/labels{/name}","releases_url":"https://api.github.com/repos/CloudSlang/cloud-slang/releases{/id}","deployments_url":"https://api.github.com/repos/CloudSlang/cloud-slang/deployments","created_at":"2014-12-21T16:32:24Z","updated_at":"2016-09-01T06:38:18Z","pushed_at":"2016-08-31T14:31:19Z","git_url":"git://github.com/CloudSlang/cloud-slang.git","ssh_url":"git@github.com:CloudSlang/cloud-slang.git","clone_url":"https://github.com/CloudSlang/cloud-slang.git","svn_url":"https://github.com/CloudSlang/cloud-slang","homepage":"http://cloudslang.io","size":32791,"stargazers_count":130,"watchers_count":130,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":79,"forks":40,"open_issues":79,"watchers":130,"default_branch":"master"}},"base":{"label":"CloudSlang:master","ref":"master","sha":"3a6be36940552227feebd458245c8537579eade0","user":{"login":"CloudSlang","id":10261505,"avatar_url":"https://avatars.githubusercontent.com/u/10261505?v=3","gravatar_id":"","url":"https://api.github.com/users/CloudSlang","html_url":"https://github.com/CloudSlang","followers_url":"https://api.github.com/users/CloudSlang/followers","following_url":"https://api.github.com/users/CloudSlang/following{/other_user}","gists_url":"https://api.github.com/users/CloudSlang/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudSlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudSlang/subscriptions","organizations_url":"https://api.github.com/users/CloudSlang/orgs","repos_url":"https://api.github.com/users/CloudSlang/repos","events_url":"https://api.github.com/users/CloudSlang/events{/privacy}","received_events_url":"https://api.github.com/users/CloudSlang/received_events","type":"Organization","site_admin":false},"repo":{"id":28305425,"name":"cloud-slang","full_name":"CloudSlang/cloud-slang","owner":{"login":"CloudSlang","id":10261505,"avatar_url":"https://avatars.githubusercontent.com/u/10261505?v=3","gravatar_id":"","url":"https://api.github.com/users/CloudSlang","html_url":"https://github.com/CloudSlang","followers_url":"https://api.github.com/users/CloudSlang/followers","following_url":"https://api.github.com/users/CloudSlang/following{/other_user}","gists_url":"https://api.github.com/users/CloudSlang/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudSlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudSlang/subscriptions","organizations_url":"https://api.github.com/users/CloudSlang/orgs","repos_url":"https://api.github.com/users/CloudSlang/repos","events_url":"https://api.github.com/users/CloudSlang/events{/privacy}","received_events_url":"https://api.github.com/users/CloudSlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CloudSlang/cloud-slang","description":"CloudSlang Language, CLI and Builder","fork":false,"url":"https://api.github.com/repos/CloudSlang/cloud-slang","forks_url":"https://api.github.com/repos/CloudSlang/cloud-slang/forks","keys_url":"https://api.github.com/repos/CloudSlang/cloud-slang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CloudSlang/cloud-slang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CloudSlang/cloud-slang/teams","hooks_url":"https://api.github.com/repos/CloudSlang/cloud-slang/hooks","issue_events_url":"https://api.github.com/repos/CloudSlang/cloud-slang/issues/events{/number}","events_url":"https://api.github.com/repos/CloudSlang/cloud-slang/events","assignees_url":"https://api.github.com/repos/CloudSlang/cloud-slang/assignees{/user}","branches_url":"https://api.github.com/repos/CloudSlang/cloud-slang/branches{/branch}","tags_url":"https://api.github.com/repos/CloudSlang/cloud-slang/tags","blobs_url":"https://api.github.com/repos/CloudSlang/cloud-slang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CloudSlang/cloud-slang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CloudSlang/cloud-slang/git/refs{/sha}","trees_url":"https://api.github.com/repos/CloudSlang/cloud-slang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CloudSlang/cloud-slang/statuses/{sha}","languages_url":"https://api.github.com/repos/CloudSlang/cloud-slang/languages","stargazers_url":"https://api.github.com/repos/CloudSlang/cloud-slang/stargazers","contributors_url":"https://api.github.com/repos/CloudSlang/cloud-slang/contributors","subscribers_url":"https://api.github.com/repos/CloudSlang/cloud-slang/subscribers","subscription_url":"https://api.github.com/repos/CloudSlang/cloud-slang/subscription","commits_url":"https://api.github.com/repos/CloudSlang/cloud-slang/commits{/sha}","git_commits_url":"https://api.github.com/repos/CloudSlang/cloud-slang/git/commits{/sha}","comments_url":"https://api.github.com/repos/CloudSlang/cloud-slang/comments{/number}","issue_comment_url":"https://api.github.com/repos/CloudSlang/cloud-slang/issues/comments{/number}","contents_url":"https://api.github.com/repos/CloudSlang/cloud-slang/contents/{+path}","compare_url":"https://api.github.com/repos/CloudSlang/cloud-slang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CloudSlang/cloud-slang/merges","archive_url":"https://api.github.com/repos/CloudSlang/cloud-slang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CloudSlang/cloud-slang/downloads","issues_url":"https://api.github.com/repos/CloudSlang/cloud-slang/issues{/number}","pulls_url":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls{/number}","milestones_url":"https://api.github.com/repos/CloudSlang/cloud-slang/milestones{/number}","notifications_url":"https://api.github.com/repos/CloudSlang/cloud-slang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CloudSlang/cloud-slang/labels{/name}","releases_url":"https://api.github.com/repos/CloudSlang/cloud-slang/releases{/id}","deployments_url":"https://api.github.com/repos/CloudSlang/cloud-slang/deployments","created_at":"2014-12-21T16:32:24Z","updated_at":"2016-09-01T06:38:18Z","pushed_at":"2016-08-31T14:31:19Z","git_url":"git://github.com/CloudSlang/cloud-slang.git","ssh_url":"git@github.com:CloudSlang/cloud-slang.git","clone_url":"https://github.com/CloudSlang/cloud-slang.git","svn_url":"https://github.com/CloudSlang/cloud-slang","homepage":"http://cloudslang.io","size":32791,"stargazers_count":130,"watchers_count":130,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":79,"forks":40,"open_issues":79,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/823"},"html":{"href":"https://github.com/CloudSlang/cloud-slang/pull/823"},"issue":{"href":"https://api.github.com/repos/CloudSlang/cloud-slang/issues/823"},"comments":{"href":"https://api.github.com/repos/CloudSlang/cloud-slang/issues/823/comments"},"review_comments":{"href":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/823/comments"},"review_comment":{"href":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CloudSlang/cloud-slang/pulls/823/commits"},"statuses":{"href":"https://api.github.com/repos/CloudSlang/cloud-slang/statuses/df9d728c705dceb01ae862c9ce8edfe71bb679e0"}}}}
{"actor":{"display_login":"gituser173"}}