{"action":"created","issue":{"url":"https://api.github.com/repos/librenms/librenms/issues/4767","repository_url":"https://api.github.com/repos/librenms/librenms","labels_url":"https://api.github.com/repos/librenms/librenms/issues/4767/labels{/name}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/4767/comments","events_url":"https://api.github.com/repos/librenms/librenms/issues/4767/events","html_url":"https://github.com/librenms/librenms/issues/4767","id":182263607,"number":4767,"title":"Adding support for Samsung ML series printer","user":{"login":"jquagga","id":5832772,"avatar_url":"https://avatars.githubusercontent.com/u/5832772?v=3","gravatar_id":"","url":"https://api.github.com/users/jquagga","html_url":"https://github.com/jquagga","followers_url":"https://api.github.com/users/jquagga/followers","following_url":"https://api.github.com/users/jquagga/following{/other_user}","gists_url":"https://api.github.com/users/jquagga/gists{/gist_id}","starred_url":"https://api.github.com/users/jquagga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquagga/subscriptions","organizations_url":"https://api.github.com/users/jquagga/orgs","repos_url":"https://api.github.com/users/jquagga/repos","events_url":"https://api.github.com/users/jquagga/events{/privacy}","received_events_url":"https://api.github.com/users/jquagga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-11T13:27:45Z","updated_at":"2016-10-12T14:42:41Z","closed_at":null,"body":"DO NOT DELETE THIS INFORMATION.\r\n\r\n> Please read this information carefully.\r\n\r\n- [X] Is your install up to date? [Updating your install](http://docs.librenms.org/General/Updating/)\r\n      Please do not submit an issue if your install is not up to date within the last 24 hours or on a stable monthly release.\r\n- [X] Please include all of the information between the `====================================` section of `./validate.php`.\r\n\r\nLibreNMS Version: ead6b5b8ac7b05f36780eb6727648dc69a5d6c4d\r\nDB Schema: 142\r\nPHP: 7.0.11\r\nMySQL: 10.1.17-MariaDB\r\nRRDTool: 1.5.6\r\nSNMP: NET-SNMP 5.7.3\r\n\r\n- [X] If you would like us to add a new device then please provide the information asked for [here](http://docs.librenms.org/Support/FAQ/#faq20)\r\n\r\nhttp://pastebin.com/m0P8EFPZ - Discovery\r\nhttp://pastebin.com/tub9nE8a - Poller\r\nhttp://pastebin.com/T1RmZtHu - SNMPWALk\r\n\r\n**Please note these are AFTER applying the diff attached below.**\r\n\r\n- [X] Please provide as much detail as possible.\r\n\r\nGood day LibreNMS folks,\r\n\r\nI'm trying to add support for my Samsung ML-2850ND printer.  The first part of that I think I have working nicely.  \r\n```diff\r\ndiff --git a/includes/discovery/os/samsungprinter.inc.php b/includes/discovery/os/samsungprinter.inc.php\r\nindex 4738f20..2ae610f 100644\r\n--- a/includes/discovery/os/samsungprinter.inc.php\r\n+++ b/includes/discovery/os/samsungprinter.inc.php\r\n@@ -1,5 +1,5 @@\r\n <?php\r\n \r\n-if (str_contains($sysDescr, array('Samsung CLX', 'Samsung SCX', 'Samsung C', 'Samsung S'))) {\r\n+if (str_contains($sysDescr, array('Samsung CLX', 'Samsung SCX', 'Samsung C', 'Samsung S', 'Samsung ML'))) {\r\n     $os = 'samsungprinter';\r\n }\r\n```\r\n\r\nSo once that lands, the device switches from a Generic device to a Samsung Printer. I get the Serial Number and the model make and it identifies the device as a printer.  However the toner graphing does not work and if I look at the output from discover / poller, it doesn't look like it's getting any of the toner info.  I'm not sure why; the SNMPwalk shows the OIDs and the data there.  So that's the part that is still a mystery to me.  \r\n\r\nI'd be happy to provide any other information needed to help get the toner graphing up and running and device support added.\r\n"},"comment":{"url":"https://api.github.com/repos/librenms/librenms/issues/comments/253232925","html_url":"https://github.com/librenms/librenms/issues/4767#issuecomment-253232925","issue_url":"https://api.github.com/repos/librenms/librenms/issues/4767","id":253232925,"user":{"login":"crcro","id":3048315,"avatar_url":"https://avatars.githubusercontent.com/u/3048315?v=3","gravatar_id":"","url":"https://api.github.com/users/crcro","html_url":"https://github.com/crcro","followers_url":"https://api.github.com/users/crcro/followers","following_url":"https://api.github.com/users/crcro/following{/other_user}","gists_url":"https://api.github.com/users/crcro/gists{/gist_id}","starred_url":"https://api.github.com/users/crcro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crcro/subscriptions","organizations_url":"https://api.github.com/users/crcro/orgs","repos_url":"https://api.github.com/users/crcro/repos","events_url":"https://api.github.com/users/crcro/events{/privacy}","received_events_url":"https://api.github.com/users/crcro/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T14:42:41Z","updated_at":"2016-10-12T14:42:41Z","body":"please set snmp to v2 and try again, submitted PR to support ML series"}}
{"actor":{"display_login":"crcro"}}