{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/81221555","pull_request_review_id":2218009,"id":81221555,"diff_hunk":"@@ -31,8 +31,10 @@ class IBDSuite extends SparkSuite {\n   implicit object ibdAbsoluteFuzzyComparable extends AbsoluteFuzzyComparable[IBDInfo] {\n     def absoluteEq(tolerance: Double, x: IBDInfo, y: IBDInfo) = {\n       def feq(x: Double, y: Double) = AbsoluteFuzzyComparable.absoluteEq(tolerance, x, y)\n+      def NaNorFeq(x: Double, y: Double) =\n+        x.isNaN && y.isNaN || feq(x, y)","path":"src/test/scala/org/broadinstitute/hail/methods/IBDSuite.scala","position":5,"original_position":5,"commit_id":"44cc6d1892c67e34abca5b601cd865540ff32e05","original_commit_id":"12cf4d141dadb792dd31f803e2964faeb201cadd","user":{"login":"danking","id":106194,"avatar_url":"https://avatars.githubusercontent.com/u/106194?v=3","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"body":"cc @cseed\r\n\r\nIn general, I'm not sure this is the right approach. I wanted some way to handle doubles no matter where they appear. I also wanted to avoid re-writing this code. This seemed like an understandable solution, but it feels a bit more complex than I wanted.\r\n\r\nI think `D_==` is actually `RelativeFuzzyComparable` (which I should probably change to have consistent behavior wrt to NaNs).","created_at":"2016-09-29T19:59:37Z","updated_at":"2016-09-29T19:59:37Z","html_url":"https://github.com/hail-is/hail/pull/867#discussion_r81221555","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/867","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/81221555"},"html":{"href":"https://github.com/hail-is/hail/pull/867#discussion_r81221555"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/867"}}},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/867","id":87214806,"html_url":"https://github.com/hail-is/hail/pull/867","diff_url":"https://github.com/hail-is/hail/pull/867.diff","patch_url":"https://github.com/hail-is/hail/pull/867.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/867","number":867,"state":"open","locked":false,"title":"Add a threshold flag for IBD output filtering","user":{"login":"danking","id":106194,"avatar_url":"https://avatars.githubusercontent.com/u/106194?v=3","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"body":"This PR depends on PR #738. Merge that first.\r\n\r\nThis adds `--min` and `--max` flags to the `ibd` command. The resulting TSV will only contain sample pairs with `pi_hat` above the minimum and below the maximum, inclusively of both.","created_at":"2016-09-28T22:37:06Z","updated_at":"2016-09-29T19:59:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc5f15d411d3151dededb3114451652840ec80c6","assignee":{"login":"tpoterba","id":10562794,"avatar_url":"https://avatars.githubusercontent.com/u/10562794?v=3","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"assignees":[{"login":"tpoterba","id":10562794,"avatar_url":"https://avatars.githubusercontent.com/u/10562794?v=3","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/867/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/867/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/867/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/44cc6d1892c67e34abca5b601cd865540ff32e05","head":{"label":"danking:issue-866","ref":"issue-866","sha":"44cc6d1892c67e34abca5b601cd865540ff32e05","user":{"login":"danking","id":106194,"avatar_url":"https://avatars.githubusercontent.com/u/106194?v=3","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"repo":{"id":64700952,"name":"hail","full_name":"danking/hail","owner":{"login":"danking","id":106194,"avatar_url":"https://avatars.githubusercontent.com/u/106194?v=3","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danking/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/danking/hail","forks_url":"https://api.github.com/repos/danking/hail/forks","keys_url":"https://api.github.com/repos/danking/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danking/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danking/hail/teams","hooks_url":"https://api.github.com/repos/danking/hail/hooks","issue_events_url":"https://api.github.com/repos/danking/hail/issues/events{/number}","events_url":"https://api.github.com/repos/danking/hail/events","assignees_url":"https://api.github.com/repos/danking/hail/assignees{/user}","branches_url":"https://api.github.com/repos/danking/hail/branches{/branch}","tags_url":"https://api.github.com/repos/danking/hail/tags","blobs_url":"https://api.github.com/repos/danking/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danking/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danking/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/danking/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danking/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/danking/hail/languages","stargazers_url":"https://api.github.com/repos/danking/hail/stargazers","contributors_url":"https://api.github.com/repos/danking/hail/contributors","subscribers_url":"https://api.github.com/repos/danking/hail/subscribers","subscription_url":"https://api.github.com/repos/danking/hail/subscription","commits_url":"https://api.github.com/repos/danking/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/danking/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/danking/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/danking/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/danking/hail/contents/{+path}","compare_url":"https://api.github.com/repos/danking/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danking/hail/merges","archive_url":"https://api.github.com/repos/danking/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danking/hail/downloads","issues_url":"https://api.github.com/repos/danking/hail/issues{/number}","pulls_url":"https://api.github.com/repos/danking/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/danking/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/danking/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danking/hail/labels{/name}","releases_url":"https://api.github.com/repos/danking/hail/releases{/id}","deployments_url":"https://api.github.com/repos/danking/hail/deployments","created_at":"2016-08-01T20:55:06Z","updated_at":"2016-08-01T20:55:08Z","pushed_at":"2016-09-29T19:57:06Z","git_url":"git://github.com/danking/hail.git","ssh_url":"git@github.com:danking/hail.git","clone_url":"https://github.com/danking/hail.git","svn_url":"https://github.com/danking/hail","homepage":"","size":8141,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"e5ef386530c710f38f36a4ca595171f0f9a7544c","user":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars.githubusercontent.com/u/20861792?v=3","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"name":"hail","full_name":"hail-is/hail","owner":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars.githubusercontent.com/u/20861792?v=3","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hail-is/hail","description":"Scalable genetic data analysis","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2016-09-19T20:14:01Z","pushed_at":"2016-09-29T19:57:06Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":7845,"stargazers_count":52,"watchers_count":52,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":242,"forks":23,"open_issues":242,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/867"},"html":{"href":"https://github.com/hail-is/hail/pull/867"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/867"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/867/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/867/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/867/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/44cc6d1892c67e34abca5b601cd865540ff32e05"}}}}
{"actor":{"display_login":"danking"}}