{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/22445","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/22445/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/22445/comments","events_url":"https://api.github.com/repos/docker/docker/issues/22445/events","html_url":"https://github.com/docker/docker/pull/22445","id":152456964,"number":22445,"title":"Docker pull/push with max concurrency limits.","user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/impact/changelog","name":"impact/changelog","color":"bfe5bf"},{"url":"https://api.github.com/repos/docker/docker/labels/status/3-docs-review","name":"status/3-docs-review","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/53","html_url":"https://github.com/docker/docker/milestones/1.12.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/53/labels","id":1657301,"number":53,"title":"1.12.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":53,"state":"open","created_at":"2016-03-21T13:47:53Z","updated_at":"2016-05-10T14:25:42Z","due_on":null,"closed_at":null},"comments":24,"created_at":"2016-05-01T21:45:44Z","updated_at":"2016-05-10T17:06:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/22445","html_url":"https://github.com/docker/docker/pull/22445","diff_url":"https://github.com/docker/docker/pull/22445.diff","patch_url":"https://github.com/docker/docker/pull/22445.patch"},"body":"**- What I did**\r\n\r\nThis fix tries to address issues raised in #20936 and #22443 where `docker pull` or `docker push` fails because of the concurrent connection failing.\r\nCurrently, the number of maximum concurrent connections is controlled by `maxDownloadConcurrency` and `maxUploadConcurrency` which are set to 3 and 5 respectively. Therefore, in situations where network connections don't support multiple downloads/uploads, failures may encounter for `docker push` or `docker pull`.\r\n\r\n**- How I did it**\r\n\r\nThis fix changes `maxDownloadConcurrency` and `maxUploadConcurrency` to adjustable by passing `--max-upload-concurrency` and `--max-download-concurrency` to `docker daemon` command.\r\n\r\nThe documentation related to docker daemon has been updated.\r\n\r\n**- How to verify it**\r\n\r\nAdditional test case have been added to cover the changes in this fix.\r\n\r\n**- Description for the changelog**\r\n\r\nAdd  `--max-upload-concurrency` and `--max-download-concurrency` to `docker daemon` command so that `docker pull` and `docker push` could control the max number of concurrent connections during uploads or downloads.\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\nThis fix fixes #20936. This fix fixes #22443.\r\n\r\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/218224230","html_url":"https://github.com/docker/docker/pull/22445#issuecomment-218224230","issue_url":"https://api.github.com/repos/docker/docker/issues/22445","id":218224230,"user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"created_at":"2016-05-10T17:06:03Z","updated_at":"2016-05-10T17:06:03Z","body":"@thaJeztah documentation updates right ?\r\n@yongtang `man/dockerd.8.md` should be updated too :angel: "}}