{"push_id":958141305,"size":14,"distinct_size":3,"ref":"refs/heads/lr/default-unmanaged-bgo746566","head":"6e8c2d4215192a78339f7fb57fe433e01be66447","before":"453aa29ea9caa354cb495fa970828833bb0c82d6","commits":[{"sha":"a77ec45110fa34ab26cd3885b7faa0aadb4d5971","author":{"email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk","name":"Lubomir Rintel"},"message":"ifcfg: make Coverity happy\n\nCID 59382 (#1 of 1): Dereference null return value (NULL_RETURNS)\n10.  dereference: Dereferencing a pointer that might be null value\nwhen calling strcmp.\n\nNot exactly true, since we ruled out the posibility earlier; but\nwe could still get rid of a couple of strcmps.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/a77ec45110fa34ab26cd3885b7faa0aadb4d5971"},{"sha":"9b8517984018434b12cd6bd390b3659529db28fc","author":{"email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk","name":"Lubomir Rintel"},"message":"fake-platform: check link_get return\n\nCan not fail no fake platform, but makes Coverity worried:\n\nCID 59381 (#1 of 1): Dereference null return value (NULL_RETURNS)\n6.  dereference: Dereferencing a null pointer device.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/9b8517984018434b12cd6bd390b3659529db28fc"},{"sha":"503b714f15dd7c9369ed13dfb324739a386ceb03","author":{"email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk","name":"Lubomir Rintel"},"message":"wext: avoid division by zero\n\nCoverity is angry:\n\nCID 59367 (#1-3 of 3): Division or modulo by float zero (DIVIDE_BY_ZERO)\n30. divide_by_zero: In expression\n  ((double)max_level - (double)level) /\n  ((double)max_level - (double)noise),\ndivision by expression (double)max_level - (double)noise which may be zero has\nundefined behavior.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/503b714f15dd7c9369ed13dfb324739a386ceb03"},{"sha":"60b7ed3bdc3941a3b7c56824fba4b7291e79041f","author":{"email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk","name":"Lubomir Rintel"},"message":"ifcfg,keyfile: fix temporary file races (CVE-2016-0764)\n\nTwo of these raised Coverity's eyebrows.\n\nCID 59389 (#1 of 1): Insecure temporary file (SECURE_TEMP)\n5.  secure_temp: Calling mkstemp without securely setting umask first.\n\nCID 59388 (#1 of 1): Insecure temporary file (SECURE_TEMP)\n1.  secure_temp: Calling mkstemp without securely setting umask first.\n\nLast one raised mine.\n\nWhen a connection is edited and saved, there's a small window during which and\nunprivileged authenticated local user can read out connection secrets (e.g. a\nVPN or Wi-Fi password). The security impact is perhaps of low severity as\nthere's no way to force another user to save their connection.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/60b7ed3bdc3941a3b7c56824fba4b7291e79041f"},{"sha":"a76a1abb49f5286e1bec82eb1ce2442ee98a365d","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"ifcfg-rh/tests: fix test after changing behavior for setting NM_SETTING_IP_CONFIG_GATEWAY\n\nSince commit bb868770, setting a gateway of \"0.0.0.0\"\nor \"::\" in NMSettingIPConfig means to set the gateway\nto NULL. There is indeed no difference between an unset\ngateway and an any gateway. This change was done to have\na consistent behavior in NMSettingIPConfig.\n\nFixes: bb868770316fbc19231b3f0aaed7d7cc5c89c30f","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/a76a1abb49f5286e1bec82eb1ce2442ee98a365d"},{"sha":"c2709eac4066f725fc7329e079cde775def6e1b3","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"ifcfg-rh/tests: fix variable scope for test arguments\n\nThe @read_wired_static array is passed on as test function. But defining\nit in a local scope is strictly speaking not correct because the lifetime\nof the array ends before the test run. Move it to the outer scope, which\nexists during the test runs.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/c2709eac4066f725fc7329e079cde775def6e1b3"},{"sha":"2d1638bba95fa19f2e20caf016460eaecc8ee496","author":{"email":"aeade43d0f8ae14e7c44fa81fe17c1635ae376fe@redhat.com","name":"Dan Williams"},"message":"core,dhcp: look for IPv6LL address in composite config\n\nIt will only be in ext_ip6_config if it was added by the kernel,\nwhich isn't usually the case since NM handles IPv6LL address\ngeneration on new enough kernels.\n\nIf the LL address isn't found, IPv6 configuration will never\ncomplete because DHCPv6 was started already but lack of an LL\naddress bails out early without handling the error.\n\nFixes: b8c2fc26c12d4732d112237c8210fef4255c43e7","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/2d1638bba95fa19f2e20caf016460eaecc8ee496"},{"sha":"d442dcd1747ea33d2322472faa744256a77a8fea","author":{"email":"aeade43d0f8ae14e7c44fa81fe17c1635ae376fe@redhat.com","name":"Dan Williams"},"message":"platform: ignore permanent MAC addresses of all ones (FF:FF:FF:FF:FF:FF)\n\nDrivers are stupid, and just like the platform ignores an all zeros\npermanent address, so should it ignore all ones.\n\nNetworkManager[509]: <debug> [1453743778.854919] [devices/nm-device.c:8885] nm_device_update_hw_address(): [0x190370] (eth0): hardware address now 86:18:52:xx:xx:xx\nNetworkManager[509]: <debug> [1453743778.855438] [devices/nm-device.c:9138] constructed(): [0x190370] (eth0): read initial MAC address 86:18:52:xx:xx:xx\nNetworkManager[509]: <debug> [1453743778.861602] [devices/nm-device.c:9148] constructed(): [0x190370] (eth0): read permanent MAC address FF:FF:FF:FF:FF:FF","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/d442dcd1747ea33d2322472faa744256a77a8fea"},{"sha":"f04e554f082496dd4fd2c622c20191a3503e96c7","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"dnsmasq-manager: lazy create debug logging string\n\nThe logging macros evaluate their arguments only when necessary.\nThis saves creating the message in case debug logging is disabled.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/f04e554f082496dd4fd2c622c20191a3503e96c7"},{"sha":"9cbf3be7794a667e03b3f569c737adec518c176f","author":{"email":"ae97abb322d2eaf7857ea9c31d5584d688a5311d@gmail.com","name":"Piotr Drąg"},"message":"po: update Polish (pl) translation (bgo #761367)\n\nhttps://bugzilla.gnome.org/show_bug.cgi?id=761367","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/9cbf3be7794a667e03b3f569c737adec518c176f"},{"sha":"4441dbf3f3a8eb63e1749e43bf19e4e05934f7f3","author":{"email":"3fbc59b3f186410e83a376c1c55f697fdd0cac37@foramnagaidhlig.net","name":"GunChleoc"},"message":"po: add Gaelic (gd) translation (bgo #761282)\n\nhttps://bugzilla.gnome.org/show_bug.cgi?id=761282","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/4441dbf3f3a8eb63e1749e43bf19e4e05934f7f3"},{"sha":"3a3f7782a885bdceb6940e6dc218aa40c826a5d5","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device: for available connections check whether they are available for user-request\n\nBut not with ignoring-carrier and ignoring-ap.","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/3a3f7782a885bdceb6940e6dc218aa40c826a5d5"},{"sha":"d26e1e1b0f8871d5161da9df9778661dbc6b6633","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device/trivial: rename nm_device_set_unmanaged_flags()","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/d26e1e1b0f8871d5161da9df9778661dbc6b6633"},{"sha":"6e8c2d4215192a78339f7fb57fe433e01be66447","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device: remove default-unmanaged and refactor unmanaged flags\n\nGet rid of NM_UNMANAGED_DEFAULT and refine the interaction between\nunmanaged flags, device state and managed property.\n\nPreviously, the NM_UNMANAGED_DEFAULT was special in that a device was\nstill considered managed if it had solely the NM_UNMANAGED_DEFAULT flag\nset and its state was managed. Thus, whether the device (state) was managed,\ndepended on the device state too.\n\nNow, a device is considered managed (or unmanaged) based on the unmanaged\nflags and realization state alone. At the same time, the device state\ndirectly corresponds to the managed property of the device. Of course,\nwhile changing the unmanaged flags, that invariant is shortly violated\nuntil the state transistion is complete.\n\nIntroduce more unmanaged flags whereas some of them are non-authorative.\nFor example, the EXTERNAL_DOWN flag has only effect as long as the user\ndidn't explicitly manage the device (NM_UNMANAGED_USER_EXPLICIT). In other\nwords, certain flags can render other flags ineffective. Whether the device\nis considered managed depends on the flags but also at the explicitly unset flags.\nIn a way, this is similar to previous where NM_UNMANAGED_DEFAULT was ignored\n(if no other flags were present).\n\nAlso, previously a device that was NM_UNMANAGED_DEFAULT and in disconnected\nstate would transition back to unmanaged. No longer do that. Once a device is\nmanaged, it stays managed as long as the flags indicate it should be managed.\nHowever, the user can also modify the unmanaged flags via the D-Bus API.\n\nAlso get rid or nm_device_finish_init(). That was previously called\nby NMManager after add_device(). As we now realize devices (possibly\nmultiple times) this should be handled during realization.\n\nhttps://bugzilla.gnome.org/show_bug.cgi?id=746566","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/6e8c2d4215192a78339f7fb57fe433e01be66447"}]}