{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/61676039","id":61676039,"diff_hunk":"@@ -2461,8 +2461,7 @@ enum FlushStateMode {\n  * if they're too large, if it's been a while since the last write,\n  * or always and in all cases if we're in prune mode and are deleting files.\n  */\n-bool static FlushStateToDisk(CValidationState &state, FlushStateMode mode) {\n-    const CChainParams& chainparams = Params();\n+bool static FlushStateToDisk(CValidationState &state, const CChainParams& chainparams, FlushStateMode mode) {","path":"src/main.cpp","position":15,"original_position":15,"commit_id":"418d9627def477be903897238c73c24b491554cf","original_commit_id":"418d9627def477be903897238c73c24b491554cf","user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"body":"If you don't want to do that manually (or remember the exact \"rules\"), you can just do `$ git diff HEAD~ -U0|cfd`. Where `cfd` is an alias for  `./contrib/devtools/clang-format-diff.py -p1 -i -v`.","created_at":"2016-04-30T22:00:21Z","updated_at":"2016-04-30T22:00:21Z","html_url":"https://github.com/bitcoin/bitcoin/pull/7947#discussion_r61676039","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7947","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/61676039"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/7947#discussion_r61676039"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7947"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7947","id":67874480,"html_url":"https://github.com/bitcoin/bitcoin/pull/7947","diff_url":"https://github.com/bitcoin/bitcoin/pull/7947.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/7947.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7947","number":7947,"state":"open","locked":false,"title":"Global params cleanup","user":{"login":"hmel","id":3381475,"avatar_url":"https://avatars.githubusercontent.com/u/3381475?v=3","gravatar_id":"","url":"https://api.github.com/users/hmel","html_url":"https://github.com/hmel","followers_url":"https://api.github.com/users/hmel/followers","following_url":"https://api.github.com/users/hmel/following{/other_user}","gists_url":"https://api.github.com/users/hmel/gists{/gist_id}","starred_url":"https://api.github.com/users/hmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmel/subscriptions","organizations_url":"https://api.github.com/users/hmel/orgs","repos_url":"https://api.github.com/users/hmel/repos","events_url":"https://api.github.com/users/hmel/events{/privacy}","received_events_url":"https://api.github.com/users/hmel/received_events","type":"User","site_admin":false},"body":"Some more work on global Params() cleanup as part of #7829 \r\nChanged FlushStateToDisk(), CheckBlockHeader(), CheckBlock() and ContextualCheckBlockHeader() to accept relevant ChainParams instead of calling global Params()","created_at":"2016-04-26T12:14:20Z","updated_at":"2016-04-30T22:00:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5880978301b82fc48af0744a2964488df04e5249","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7947/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7947/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7947/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/418d9627def477be903897238c73c24b491554cf","head":{"label":"hmel:global-params-cleanup","ref":"global-params-cleanup","sha":"418d9627def477be903897238c73c24b491554cf","user":{"login":"hmel","id":3381475,"avatar_url":"https://avatars.githubusercontent.com/u/3381475?v=3","gravatar_id":"","url":"https://api.github.com/users/hmel","html_url":"https://github.com/hmel","followers_url":"https://api.github.com/users/hmel/followers","following_url":"https://api.github.com/users/hmel/following{/other_user}","gists_url":"https://api.github.com/users/hmel/gists{/gist_id}","starred_url":"https://api.github.com/users/hmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmel/subscriptions","organizations_url":"https://api.github.com/users/hmel/orgs","repos_url":"https://api.github.com/users/hmel/repos","events_url":"https://api.github.com/users/hmel/events{/privacy}","received_events_url":"https://api.github.com/users/hmel/received_events","type":"User","site_admin":false},"repo":{"id":56221841,"name":"bitcoin","full_name":"hmel/bitcoin","owner":{"login":"hmel","id":3381475,"avatar_url":"https://avatars.githubusercontent.com/u/3381475?v=3","gravatar_id":"","url":"https://api.github.com/users/hmel","html_url":"https://github.com/hmel","followers_url":"https://api.github.com/users/hmel/followers","following_url":"https://api.github.com/users/hmel/following{/other_user}","gists_url":"https://api.github.com/users/hmel/gists{/gist_id}","starred_url":"https://api.github.com/users/hmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmel/subscriptions","organizations_url":"https://api.github.com/users/hmel/orgs","repos_url":"https://api.github.com/users/hmel/repos","events_url":"https://api.github.com/users/hmel/events{/privacy}","received_events_url":"https://api.github.com/users/hmel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hmel/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/hmel/bitcoin","forks_url":"https://api.github.com/repos/hmel/bitcoin/forks","keys_url":"https://api.github.com/repos/hmel/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmel/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmel/bitcoin/teams","hooks_url":"https://api.github.com/repos/hmel/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/hmel/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/hmel/bitcoin/events","assignees_url":"https://api.github.com/repos/hmel/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/hmel/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/hmel/bitcoin/tags","blobs_url":"https://api.github.com/repos/hmel/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmel/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmel/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmel/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmel/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/hmel/bitcoin/languages","stargazers_url":"https://api.github.com/repos/hmel/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/hmel/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/hmel/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/hmel/bitcoin/subscription","commits_url":"https://api.github.com/repos/hmel/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmel/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmel/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmel/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmel/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/hmel/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmel/bitcoin/merges","archive_url":"https://api.github.com/repos/hmel/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmel/bitcoin/downloads","issues_url":"https://api.github.com/repos/hmel/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/hmel/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/hmel/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/hmel/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmel/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/hmel/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/hmel/bitcoin/deployments","created_at":"2016-04-14T08:48:22Z","updated_at":"2016-04-14T08:48:33Z","pushed_at":"2016-04-26T15:55:56Z","git_url":"git://github.com/hmel/bitcoin.git","ssh_url":"git@github.com:hmel/bitcoin.git","clone_url":"https://github.com/hmel/bitcoin.git","svn_url":"https://github.com/hmel/bitcoin","homepage":"https://bitcoin.org/en/download","size":65565,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"e26b62093ae21e89ed7d36a24a6b863f38ec631d","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2016-04-30T17:07:18Z","pushed_at":"2016-04-30T21:42:40Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":136348,"stargazers_count":8919,"watchers_count":8919,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6020,"mirror_url":null,"open_issues_count":463,"forks":6020,"open_issues":463,"watchers":8919,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7947"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/7947"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/7947"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/7947/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7947/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7947/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/418d9627def477be903897238c73c24b491554cf"}}}}