{"action":"created","comment":{"url":"https://api.github.com/repos/thelia-modules/Team/pulls/comments/66753681","id":66753681,"diff_hunk":"@@ -50,8 +51,37 @@ protected function createProcess(Event $event)\n \n     protected function updateProcess(Event $event)\n     {\n-        /** @var PersonEvent $event */\n-        $event->getPerson()->save();\n+        /**\n+         * @var PersonEvent $event\n+         * @var Person $person\n+         */\n+        $person = $event->getPerson();\n+\n+        $existingPersonQuery = PersonQuery::create()\n+            ->filterById($person->getId())","path":"Service/PersonService.php","position":21,"original_position":21,"commit_id":"a4881042b7ada1a4e64453807587489538748264","original_commit_id":"a4881042b7ada1a4e64453807587489538748264","user":{"login":"Soldras","id":11573385,"avatar_url":"https://avatars.githubusercontent.com/u/11573385?v=3","gravatar_id":"","url":"https://api.github.com/users/Soldras","html_url":"https://github.com/Soldras","followers_url":"https://api.github.com/users/Soldras/followers","following_url":"https://api.github.com/users/Soldras/following{/other_user}","gists_url":"https://api.github.com/users/Soldras/gists{/gist_id}","starred_url":"https://api.github.com/users/Soldras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soldras/subscriptions","organizations_url":"https://api.github.com/users/Soldras/orgs","repos_url":"https://api.github.com/users/Soldras/repos","events_url":"https://api.github.com/users/Soldras/events{/privacy}","received_events_url":"https://api.github.com/users/Soldras/received_events","type":"User","site_admin":false},"body":"Si tu filtre par id tu as pas besoin de filtrer par le reste\r\n","created_at":"2016-06-13T08:13:52Z","updated_at":"2016-06-13T08:13:52Z","html_url":"https://github.com/thelia-modules/Team/pull/1#discussion_r66753681","pull_request_url":"https://api.github.com/repos/thelia-modules/Team/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/thelia-modules/Team/pulls/comments/66753681"},"html":{"href":"https://github.com/thelia-modules/Team/pull/1#discussion_r66753681"},"pull_request":{"href":"https://api.github.com/repos/thelia-modules/Team/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/thelia-modules/Team/pulls/1","id":73535608,"html_url":"https://github.com/thelia-modules/Team/pull/1","diff_url":"https://github.com/thelia-modules/Team/pull/1.diff","patch_url":"https://github.com/thelia-modules/Team/pull/1.patch","issue_url":"https://api.github.com/repos/thelia-modules/Team/issues/1","number":1,"state":"open","locked":false,"title":"Avoid infinte loops during person saving","user":{"login":"TomPradat","id":16164512,"avatar_url":"https://avatars.githubusercontent.com/u/16164512?v=3","gravatar_id":"","url":"https://api.github.com/users/TomPradat","html_url":"https://github.com/TomPradat","followers_url":"https://api.github.com/users/TomPradat/followers","following_url":"https://api.github.com/users/TomPradat/following{/other_user}","gists_url":"https://api.github.com/users/TomPradat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomPradat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomPradat/subscriptions","organizations_url":"https://api.github.com/users/TomPradat/orgs","repos_url":"https://api.github.com/users/TomPradat/repos","events_url":"https://api.github.com/users/TomPradat/events{/privacy}","received_events_url":"https://api.github.com/users/TomPradat/received_events","type":"User","site_admin":false},"body":"Due to propel versioning, as the i18n is not versionable, if you only changed the description in a person setting, there is an infinite loop created because the model cannot resolve if versionning is necessary.\r\n\r\nHere i check the event and save the description by hand if the firstname and lastname haven't changed.","created_at":"2016-06-13T08:02:21Z","updated_at":"2016-06-13T08:13:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"529241a294559d5fba94c001ea77b97670005059","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thelia-modules/Team/pulls/1/commits","review_comments_url":"https://api.github.com/repos/thelia-modules/Team/pulls/1/comments","review_comment_url":"https://api.github.com/repos/thelia-modules/Team/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thelia-modules/Team/issues/1/comments","statuses_url":"https://api.github.com/repos/thelia-modules/Team/statuses/a4881042b7ada1a4e64453807587489538748264","head":{"label":"TomPradat:fix/person-save","ref":"fix/person-save","sha":"a4881042b7ada1a4e64453807587489538748264","user":{"login":"TomPradat","id":16164512,"avatar_url":"https://avatars.githubusercontent.com/u/16164512?v=3","gravatar_id":"","url":"https://api.github.com/users/TomPradat","html_url":"https://github.com/TomPradat","followers_url":"https://api.github.com/users/TomPradat/followers","following_url":"https://api.github.com/users/TomPradat/following{/other_user}","gists_url":"https://api.github.com/users/TomPradat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomPradat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomPradat/subscriptions","organizations_url":"https://api.github.com/users/TomPradat/orgs","repos_url":"https://api.github.com/users/TomPradat/repos","events_url":"https://api.github.com/users/TomPradat/events{/privacy}","received_events_url":"https://api.github.com/users/TomPradat/received_events","type":"User","site_admin":false},"repo":{"id":61016997,"name":"Team","full_name":"TomPradat/Team","owner":{"login":"TomPradat","id":16164512,"avatar_url":"https://avatars.githubusercontent.com/u/16164512?v=3","gravatar_id":"","url":"https://api.github.com/users/TomPradat","html_url":"https://github.com/TomPradat","followers_url":"https://api.github.com/users/TomPradat/followers","following_url":"https://api.github.com/users/TomPradat/following{/other_user}","gists_url":"https://api.github.com/users/TomPradat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomPradat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomPradat/subscriptions","organizations_url":"https://api.github.com/users/TomPradat/orgs","repos_url":"https://api.github.com/users/TomPradat/repos","events_url":"https://api.github.com/users/TomPradat/events{/privacy}","received_events_url":"https://api.github.com/users/TomPradat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomPradat/Team","description":"This module allow you to create team member for your shop","fork":true,"url":"https://api.github.com/repos/TomPradat/Team","forks_url":"https://api.github.com/repos/TomPradat/Team/forks","keys_url":"https://api.github.com/repos/TomPradat/Team/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomPradat/Team/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomPradat/Team/teams","hooks_url":"https://api.github.com/repos/TomPradat/Team/hooks","issue_events_url":"https://api.github.com/repos/TomPradat/Team/issues/events{/number}","events_url":"https://api.github.com/repos/TomPradat/Team/events","assignees_url":"https://api.github.com/repos/TomPradat/Team/assignees{/user}","branches_url":"https://api.github.com/repos/TomPradat/Team/branches{/branch}","tags_url":"https://api.github.com/repos/TomPradat/Team/tags","blobs_url":"https://api.github.com/repos/TomPradat/Team/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomPradat/Team/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomPradat/Team/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomPradat/Team/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomPradat/Team/statuses/{sha}","languages_url":"https://api.github.com/repos/TomPradat/Team/languages","stargazers_url":"https://api.github.com/repos/TomPradat/Team/stargazers","contributors_url":"https://api.github.com/repos/TomPradat/Team/contributors","subscribers_url":"https://api.github.com/repos/TomPradat/Team/subscribers","subscription_url":"https://api.github.com/repos/TomPradat/Team/subscription","commits_url":"https://api.github.com/repos/TomPradat/Team/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomPradat/Team/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomPradat/Team/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomPradat/Team/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomPradat/Team/contents/{+path}","compare_url":"https://api.github.com/repos/TomPradat/Team/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomPradat/Team/merges","archive_url":"https://api.github.com/repos/TomPradat/Team/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomPradat/Team/downloads","issues_url":"https://api.github.com/repos/TomPradat/Team/issues{/number}","pulls_url":"https://api.github.com/repos/TomPradat/Team/pulls{/number}","milestones_url":"https://api.github.com/repos/TomPradat/Team/milestones{/number}","notifications_url":"https://api.github.com/repos/TomPradat/Team/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomPradat/Team/labels{/name}","releases_url":"https://api.github.com/repos/TomPradat/Team/releases{/id}","deployments_url":"https://api.github.com/repos/TomPradat/Team/deployments","created_at":"2016-06-13T07:41:43Z","updated_at":"2016-06-13T07:41:45Z","pushed_at":"2016-06-13T07:58:58Z","git_url":"git://github.com/TomPradat/Team.git","ssh_url":"git@github.com:TomPradat/Team.git","clone_url":"https://github.com/TomPradat/Team.git","svn_url":"https://github.com/TomPradat/Team","homepage":"","size":212,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thelia-modules:master","ref":"master","sha":"05c979ae5ebf15e622f677ceff52a881a76a0823","user":{"login":"thelia-modules","id":6458845,"avatar_url":"https://avatars.githubusercontent.com/u/6458845?v=3","gravatar_id":"","url":"https://api.github.com/users/thelia-modules","html_url":"https://github.com/thelia-modules","followers_url":"https://api.github.com/users/thelia-modules/followers","following_url":"https://api.github.com/users/thelia-modules/following{/other_user}","gists_url":"https://api.github.com/users/thelia-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/thelia-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelia-modules/subscriptions","organizations_url":"https://api.github.com/users/thelia-modules/orgs","repos_url":"https://api.github.com/users/thelia-modules/repos","events_url":"https://api.github.com/users/thelia-modules/events{/privacy}","received_events_url":"https://api.github.com/users/thelia-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":48990815,"name":"Team","full_name":"thelia-modules/Team","owner":{"login":"thelia-modules","id":6458845,"avatar_url":"https://avatars.githubusercontent.com/u/6458845?v=3","gravatar_id":"","url":"https://api.github.com/users/thelia-modules","html_url":"https://github.com/thelia-modules","followers_url":"https://api.github.com/users/thelia-modules/followers","following_url":"https://api.github.com/users/thelia-modules/following{/other_user}","gists_url":"https://api.github.com/users/thelia-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/thelia-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelia-modules/subscriptions","organizations_url":"https://api.github.com/users/thelia-modules/orgs","repos_url":"https://api.github.com/users/thelia-modules/repos","events_url":"https://api.github.com/users/thelia-modules/events{/privacy}","received_events_url":"https://api.github.com/users/thelia-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thelia-modules/Team","description":"This module allow you to create team member for your shop","fork":false,"url":"https://api.github.com/repos/thelia-modules/Team","forks_url":"https://api.github.com/repos/thelia-modules/Team/forks","keys_url":"https://api.github.com/repos/thelia-modules/Team/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thelia-modules/Team/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thelia-modules/Team/teams","hooks_url":"https://api.github.com/repos/thelia-modules/Team/hooks","issue_events_url":"https://api.github.com/repos/thelia-modules/Team/issues/events{/number}","events_url":"https://api.github.com/repos/thelia-modules/Team/events","assignees_url":"https://api.github.com/repos/thelia-modules/Team/assignees{/user}","branches_url":"https://api.github.com/repos/thelia-modules/Team/branches{/branch}","tags_url":"https://api.github.com/repos/thelia-modules/Team/tags","blobs_url":"https://api.github.com/repos/thelia-modules/Team/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thelia-modules/Team/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thelia-modules/Team/git/refs{/sha}","trees_url":"https://api.github.com/repos/thelia-modules/Team/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thelia-modules/Team/statuses/{sha}","languages_url":"https://api.github.com/repos/thelia-modules/Team/languages","stargazers_url":"https://api.github.com/repos/thelia-modules/Team/stargazers","contributors_url":"https://api.github.com/repos/thelia-modules/Team/contributors","subscribers_url":"https://api.github.com/repos/thelia-modules/Team/subscribers","subscription_url":"https://api.github.com/repos/thelia-modules/Team/subscription","commits_url":"https://api.github.com/repos/thelia-modules/Team/commits{/sha}","git_commits_url":"https://api.github.com/repos/thelia-modules/Team/git/commits{/sha}","comments_url":"https://api.github.com/repos/thelia-modules/Team/comments{/number}","issue_comment_url":"https://api.github.com/repos/thelia-modules/Team/issues/comments{/number}","contents_url":"https://api.github.com/repos/thelia-modules/Team/contents/{+path}","compare_url":"https://api.github.com/repos/thelia-modules/Team/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thelia-modules/Team/merges","archive_url":"https://api.github.com/repos/thelia-modules/Team/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thelia-modules/Team/downloads","issues_url":"https://api.github.com/repos/thelia-modules/Team/issues{/number}","pulls_url":"https://api.github.com/repos/thelia-modules/Team/pulls{/number}","milestones_url":"https://api.github.com/repos/thelia-modules/Team/milestones{/number}","notifications_url":"https://api.github.com/repos/thelia-modules/Team/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thelia-modules/Team/labels{/name}","releases_url":"https://api.github.com/repos/thelia-modules/Team/releases{/id}","deployments_url":"https://api.github.com/repos/thelia-modules/Team/deployments","created_at":"2016-01-04T10:41:20Z","updated_at":"2016-01-18T14:03:06Z","pushed_at":"2016-06-13T08:02:22Z","git_url":"git://github.com/thelia-modules/Team.git","ssh_url":"git@github.com:thelia-modules/Team.git","clone_url":"https://github.com/thelia-modules/Team.git","svn_url":"https://github.com/thelia-modules/Team","homepage":"","size":211,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thelia-modules/Team/pulls/1"},"html":{"href":"https://github.com/thelia-modules/Team/pull/1"},"issue":{"href":"https://api.github.com/repos/thelia-modules/Team/issues/1"},"comments":{"href":"https://api.github.com/repos/thelia-modules/Team/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/thelia-modules/Team/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/thelia-modules/Team/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thelia-modules/Team/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/thelia-modules/Team/statuses/a4881042b7ada1a4e64453807587489538748264"}}}}
{"actor":{"display_login":"Soldras"}}