{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/5556","labels_url":"https://api.github.com/repos/facebook/react-native/issues/5556/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/5556/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/5556/events","html_url":"https://github.com/facebook/react-native/pull/5556","id":128873023,"number":5556,"title":"Update version number in repo for ecosystem compatibility","user":{"login":"corbt","id":176426,"avatar_url":"https://avatars.githubusercontent.com/u/176426?v=3","gravatar_id":"","url":"https://api.github.com/users/corbt","html_url":"https://github.com/corbt","followers_url":"https://api.github.com/users/corbt/followers","following_url":"https://api.github.com/users/corbt/following{/other_user}","gists_url":"https://api.github.com/users/corbt/gists{/gist_id}","starred_url":"https://api.github.com/users/corbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corbt/subscriptions","organizations_url":"https://api.github.com/users/corbt/orgs","repos_url":"https://api.github.com/users/corbt/repos","events_url":"https://api.github.com/users/corbt/events{/privacy}","received_events_url":"https://api.github.com/users/corbt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-26T16:37:41Z","updated_at":"2016-01-29T19:38:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/5556","html_url":"https://github.com/facebook/react-native/pull/5556","diff_url":"https://github.com/facebook/react-native/pull/5556.diff","patch_url":"https://github.com/facebook/react-native/pull/5556.patch"},"body":"In https://github.com/facebook/react-native/pull/5241 @ide updated the version number to be a fake one so that people wouldn't send in PRs just bumping the version.\r\n\r\nUnfortunately, this leads to compatibility issues when developing against `master` with 3rd-party components that declare React Native as a `peerDependency`. For example, I'm using [react-native-orientation](https://github.com/yamill/react-native-orientation) which has a peerDependency of `\"react-native\": \">=0.5\"`.\r\n\r\nI see a few ways to deal with this:\r\n\r\n1. Only develop against the releases on npm, not git snapshots.\r\n2. Ask ecosystem projects to not include a minimum version of `react-native` in their peerDependencies.\r\n3. Track the RN release numbers in the git repository (eg it would be 0.19 right now).\r\n4. Make the release number on master huge (1000 in this PR) so it's obviously a fake number but will still comply with >= checks.\r\n\r\nI don't think option 2 is good because it's reasonable for a package author to want to specify a minimum RN version. Option 3 would be fine, although it would take manual effort to keep the version in sync. Option 4 (this PR) is my favorite because it's obvious that the version number is fake, but it maintains ecosystem compatibility."},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/176932306","html_url":"https://github.com/facebook/react-native/pull/5556#issuecomment-176932306","issue_url":"https://api.github.com/repos/facebook/react-native/issues/5556","id":176932306,"user":{"login":"brentvatne","id":90494,"avatar_url":"https://avatars.githubusercontent.com/u/90494?v=3","gravatar_id":"","url":"https://api.github.com/users/brentvatne","html_url":"https://github.com/brentvatne","followers_url":"https://api.github.com/users/brentvatne/followers","following_url":"https://api.github.com/users/brentvatne/following{/other_user}","gists_url":"https://api.github.com/users/brentvatne/gists{/gist_id}","starred_url":"https://api.github.com/users/brentvatne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentvatne/subscriptions","organizations_url":"https://api.github.com/users/brentvatne/orgs","repos_url":"https://api.github.com/users/brentvatne/repos","events_url":"https://api.github.com/users/brentvatne/events{/privacy}","received_events_url":"https://api.github.com/users/brentvatne/received_events","type":"User","site_admin":false},"created_at":"2016-01-29T19:38:02Z","updated_at":"2016-01-29T19:38:02Z","body":"Have to think about this more, but as a funny aside: http://tenver.org/"}}