{"action":"created","issue":{"url":"https://api.github.com/repos/openbabel/openbabel/issues/319","repository_url":"https://api.github.com/repos/openbabel/openbabel","labels_url":"https://api.github.com/repos/openbabel/openbabel/issues/319/labels{/name}","comments_url":"https://api.github.com/repos/openbabel/openbabel/issues/319/comments","events_url":"https://api.github.com/repos/openbabel/openbabel/issues/319/events","html_url":"https://github.com/openbabel/openbabel/pull/319","id":162791024,"number":319,"title":"Fixed a bug with using the --fillUC feature","user":{"login":"psavery","id":9558430,"avatar_url":"https://avatars.githubusercontent.com/u/9558430?v=3","gravatar_id":"","url":"https://api.github.com/users/psavery","html_url":"https://github.com/psavery","followers_url":"https://api.github.com/users/psavery/followers","following_url":"https://api.github.com/users/psavery/following{/other_user}","gists_url":"https://api.github.com/users/psavery/gists{/gist_id}","starred_url":"https://api.github.com/users/psavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psavery/subscriptions","organizations_url":"https://api.github.com/users/psavery/orgs","repos_url":"https://api.github.com/users/psavery/repos","events_url":"https://api.github.com/users/psavery/events{/privacy}","received_events_url":"https://api.github.com/users/psavery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-28T21:24:04Z","updated_at":"2016-06-29T19:04:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openbabel/openbabel/pulls/319","html_url":"https://github.com/openbabel/openbabel/pull/319","diff_url":"https://github.com/openbabel/openbabel/pull/319.diff","patch_url":"https://github.com/openbabel/openbabel/pull/319.patch"},"body":"If pOptions is not NULL but no transforms are found, then\r\nthe SpaceGroup object (spacegroup) will contain nothing. This commit adds\r\na check so that pSG gets set to pUC->GetSpaceGroup() when pOptions is not\r\nNULL but there are no transformations. Because of C++ short-circuits in\r\noperators such as &&, we know that pOptions->find() will never be called\r\nif pOptions is NULL."},"comment":{"url":"https://api.github.com/repos/openbabel/openbabel/issues/comments/229456074","html_url":"https://github.com/openbabel/openbabel/pull/319#issuecomment-229456074","issue_url":"https://api.github.com/repos/openbabel/openbabel/issues/319","id":229456074,"user":{"login":"psavery","id":9558430,"avatar_url":"https://avatars.githubusercontent.com/u/9558430?v=3","gravatar_id":"","url":"https://api.github.com/users/psavery","html_url":"https://github.com/psavery","followers_url":"https://api.github.com/users/psavery/followers","following_url":"https://api.github.com/users/psavery/following{/other_user}","gists_url":"https://api.github.com/users/psavery/gists{/gist_id}","starred_url":"https://api.github.com/users/psavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psavery/subscriptions","organizations_url":"https://api.github.com/users/psavery/orgs","repos_url":"https://api.github.com/users/psavery/repos","events_url":"https://api.github.com/users/psavery/events{/privacy}","received_events_url":"https://api.github.com/users/psavery/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T19:04:34Z","updated_at":"2016-06-29T19:04:34Z","body":"Yeah, that makes sense. I fixed the atom ordering issue for my POSCAR writer in Avogadro2 (it was an issue if a supercell was built, for example). I'll fix the one in OpenBabel sooner or later as well. "}}
{"actor":{"display_login":"psavery"}}