{"action":"created","comment":{"url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments/68519407","id":68519407,"diff_hunk":"@@ -102,7 +102,8 @@ namespace dsn {\n         rpc_session_ptr asio_network_provider::create_client_session(::dsn::rpc_address server_addr)\n         {\n             auto sock = std::shared_ptr<boost::asio::ip::tcp::socket>(new boost::asio::ip::tcp::socket(_io_service));\n-            return rpc_session_ptr(new asio_rpc_session(*this, server_addr, sock, new_message_parser(), true));\n+            auto parser = new_message_parser(_client_hdr_format);\n+            return rpc_session_ptr(new asio_rpc_session(*this, server_addr, sock, parser, true));","path":"src/core/tools/common/asio_net_provider.cpp","position":6,"original_position":6,"commit_id":"4b54786104ee053be682f4ea4f02ea66dd4aafd5","original_commit_id":"4b54786104ee053be682f4ea4f02ea66dd4aafd5","user":{"login":"qinzuoyan","id":528445,"avatar_url":"https://avatars.githubusercontent.com/u/528445?v=3","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},"body":"I'll explain the reason in the email.","created_at":"2016-06-27T03:39:12Z","updated_at":"2016-06-27T03:39:12Z","html_url":"https://github.com/imzhenyu/rDSN/pull/413#discussion_r68519407","pull_request_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments/68519407"},"html":{"href":"https://github.com/imzhenyu/rDSN/pull/413#discussion_r68519407"},"pull_request":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/413","id":74951139,"html_url":"https://github.com/imzhenyu/rDSN/pull/413","diff_url":"https://github.com/imzhenyu/rDSN/pull/413.diff","patch_url":"https://github.com/imzhenyu/rDSN/pull/413.patch","issue_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/413","number":413,"state":"open","locked":false,"title":"add general message parser support","user":{"login":"qinzuoyan","id":528445,"avatar_url":"https://avatars.githubusercontent.com/u/528445?v=3","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-23T13:05:20Z","updated_at":"2016-06-27T03:39:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"940112e8c1d1e608e7068da6e3a5c642cf5355fa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/413/commits","review_comments_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/413/comments","review_comment_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments{/number}","comments_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/413/comments","statuses_url":"https://api.github.com/repos/imzhenyu/rDSN/statuses/4b54786104ee053be682f4ea4f02ea66dd4aafd5","head":{"label":"imzhenyu:master-merge-parser","ref":"master-merge-parser","sha":"4b54786104ee053be682f4ea4f02ea66dd4aafd5","user":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"repo":{"id":37038578,"name":"rDSN","full_name":"imzhenyu/rDSN","owner":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imzhenyu/rDSN","description":"Robust Distributed System Nucleus (rDSN) is an open framework for quickly building and managing high performance and robust distributed systems.","fork":true,"url":"https://api.github.com/repos/imzhenyu/rDSN","forks_url":"https://api.github.com/repos/imzhenyu/rDSN/forks","keys_url":"https://api.github.com/repos/imzhenyu/rDSN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imzhenyu/rDSN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imzhenyu/rDSN/teams","hooks_url":"https://api.github.com/repos/imzhenyu/rDSN/hooks","issue_events_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/events{/number}","events_url":"https://api.github.com/repos/imzhenyu/rDSN/events","assignees_url":"https://api.github.com/repos/imzhenyu/rDSN/assignees{/user}","branches_url":"https://api.github.com/repos/imzhenyu/rDSN/branches{/branch}","tags_url":"https://api.github.com/repos/imzhenyu/rDSN/tags","blobs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imzhenyu/rDSN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/refs{/sha}","trees_url":"https://api.github.com/repos/imzhenyu/rDSN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imzhenyu/rDSN/statuses/{sha}","languages_url":"https://api.github.com/repos/imzhenyu/rDSN/languages","stargazers_url":"https://api.github.com/repos/imzhenyu/rDSN/stargazers","contributors_url":"https://api.github.com/repos/imzhenyu/rDSN/contributors","subscribers_url":"https://api.github.com/repos/imzhenyu/rDSN/subscribers","subscription_url":"https://api.github.com/repos/imzhenyu/rDSN/subscription","commits_url":"https://api.github.com/repos/imzhenyu/rDSN/commits{/sha}","git_commits_url":"https://api.github.com/repos/imzhenyu/rDSN/git/commits{/sha}","comments_url":"https://api.github.com/repos/imzhenyu/rDSN/comments{/number}","issue_comment_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/comments{/number}","contents_url":"https://api.github.com/repos/imzhenyu/rDSN/contents/{+path}","compare_url":"https://api.github.com/repos/imzhenyu/rDSN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imzhenyu/rDSN/merges","archive_url":"https://api.github.com/repos/imzhenyu/rDSN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imzhenyu/rDSN/downloads","issues_url":"https://api.github.com/repos/imzhenyu/rDSN/issues{/number}","pulls_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls{/number}","milestones_url":"https://api.github.com/repos/imzhenyu/rDSN/milestones{/number}","notifications_url":"https://api.github.com/repos/imzhenyu/rDSN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imzhenyu/rDSN/labels{/name}","releases_url":"https://api.github.com/repos/imzhenyu/rDSN/releases{/id}","deployments_url":"https://api.github.com/repos/imzhenyu/rDSN/deployments","created_at":"2015-06-08T00:54:11Z","updated_at":"2016-05-31T09:59:35Z","pushed_at":"2016-06-27T02:20:48Z","git_url":"git://github.com/imzhenyu/rDSN.git","ssh_url":"git@github.com:imzhenyu/rDSN.git","clone_url":"https://github.com/imzhenyu/rDSN.git","svn_url":"https://github.com/imzhenyu/rDSN","homepage":null,"size":78258,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":25,"forks":10,"open_issues":25,"watchers":14,"default_branch":"master"}},"base":{"label":"imzhenyu:master","ref":"master","sha":"30891cc97b5f70894f5ace3d206603f78261a8b8","user":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"repo":{"id":37038578,"name":"rDSN","full_name":"imzhenyu/rDSN","owner":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imzhenyu/rDSN","description":"Robust Distributed System Nucleus (rDSN) is an open framework for quickly building and managing high performance and robust distributed systems.","fork":true,"url":"https://api.github.com/repos/imzhenyu/rDSN","forks_url":"https://api.github.com/repos/imzhenyu/rDSN/forks","keys_url":"https://api.github.com/repos/imzhenyu/rDSN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imzhenyu/rDSN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imzhenyu/rDSN/teams","hooks_url":"https://api.github.com/repos/imzhenyu/rDSN/hooks","issue_events_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/events{/number}","events_url":"https://api.github.com/repos/imzhenyu/rDSN/events","assignees_url":"https://api.github.com/repos/imzhenyu/rDSN/assignees{/user}","branches_url":"https://api.github.com/repos/imzhenyu/rDSN/branches{/branch}","tags_url":"https://api.github.com/repos/imzhenyu/rDSN/tags","blobs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imzhenyu/rDSN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/refs{/sha}","trees_url":"https://api.github.com/repos/imzhenyu/rDSN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imzhenyu/rDSN/statuses/{sha}","languages_url":"https://api.github.com/repos/imzhenyu/rDSN/languages","stargazers_url":"https://api.github.com/repos/imzhenyu/rDSN/stargazers","contributors_url":"https://api.github.com/repos/imzhenyu/rDSN/contributors","subscribers_url":"https://api.github.com/repos/imzhenyu/rDSN/subscribers","subscription_url":"https://api.github.com/repos/imzhenyu/rDSN/subscription","commits_url":"https://api.github.com/repos/imzhenyu/rDSN/commits{/sha}","git_commits_url":"https://api.github.com/repos/imzhenyu/rDSN/git/commits{/sha}","comments_url":"https://api.github.com/repos/imzhenyu/rDSN/comments{/number}","issue_comment_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/comments{/number}","contents_url":"https://api.github.com/repos/imzhenyu/rDSN/contents/{+path}","compare_url":"https://api.github.com/repos/imzhenyu/rDSN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imzhenyu/rDSN/merges","archive_url":"https://api.github.com/repos/imzhenyu/rDSN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imzhenyu/rDSN/downloads","issues_url":"https://api.github.com/repos/imzhenyu/rDSN/issues{/number}","pulls_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls{/number}","milestones_url":"https://api.github.com/repos/imzhenyu/rDSN/milestones{/number}","notifications_url":"https://api.github.com/repos/imzhenyu/rDSN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imzhenyu/rDSN/labels{/name}","releases_url":"https://api.github.com/repos/imzhenyu/rDSN/releases{/id}","deployments_url":"https://api.github.com/repos/imzhenyu/rDSN/deployments","created_at":"2015-06-08T00:54:11Z","updated_at":"2016-05-31T09:59:35Z","pushed_at":"2016-06-27T02:20:48Z","git_url":"git://github.com/imzhenyu/rDSN.git","ssh_url":"git@github.com:imzhenyu/rDSN.git","clone_url":"https://github.com/imzhenyu/rDSN.git","svn_url":"https://github.com/imzhenyu/rDSN","homepage":null,"size":78258,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":25,"forks":10,"open_issues":25,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/413"},"html":{"href":"https://github.com/imzhenyu/rDSN/pull/413"},"issue":{"href":"https://api.github.com/repos/imzhenyu/rDSN/issues/413"},"comments":{"href":"https://api.github.com/repos/imzhenyu/rDSN/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/imzhenyu/rDSN/statuses/4b54786104ee053be682f4ea4f02ea66dd4aafd5"}}}}
{"actor":{"display_login":"qinzuoyan"}}