{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/4875","repository_url":"https://api.github.com/repos/puppetlabs/puppet","labels_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4875/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4875/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4875/events","html_url":"https://github.com/puppetlabs/puppet/pull/4875","id":147808420,"number":4875,"title":"(PUP-3827) Return errors matching schema from indirected routes","user":{"login":"justinstoller","id":241423,"avatar_url":"https://avatars.githubusercontent.com/u/241423?v=3","gravatar_id":"","url":"https://api.github.com/users/justinstoller","html_url":"https://github.com/justinstoller","followers_url":"https://api.github.com/users/justinstoller/followers","following_url":"https://api.github.com/users/justinstoller/following{/other_user}","gists_url":"https://api.github.com/users/justinstoller/gists{/gist_id}","starred_url":"https://api.github.com/users/justinstoller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinstoller/subscriptions","organizations_url":"https://api.github.com/users/justinstoller/orgs","repos_url":"https://api.github.com/users/justinstoller/repos","events_url":"https://api.github.com/users/justinstoller/events{/privacy}","received_events_url":"https://api.github.com/users/justinstoller/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-12T16:39:28Z","updated_at":"2016-04-12T18:00:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4875","html_url":"https://github.com/puppetlabs/puppet/pull/4875","diff_url":"https://github.com/puppetlabs/puppet/pull/4875.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/4875.patch"},"body":"Prior to this the indirected routes would intercept any issues that\r\narose in processing the request and format them into a plain text\r\nresponse with the proper error code.\r\n\r\nAll other routes pass issues up to the generic route handler which will\r\nformat them according to a documented schema.\r\n\r\nThis moves the indirected routes handler from never raising to always\r\nraising on error, similar to other route handlers. This allows the\r\nindirected routes to share the error handling code with other routes\r\nand provides consistently formatted errors throughout the rest api.\r\n\r\n\r\nRunning the acceptance suite locally (via `SHA=$(git rev-parse HEAD) TEST_TARGET=ubuntu1404-64a bundle exec rake ci:test:git` I get:\r\n```\r\nErrored Tests Cases:\r\n            Test Case tests/direct_puppet/static_catalog_env_control.rb reported: #<Beaker::Host::CommandFailure: Host 'y383sdp13cn6x5a.delivery.puppetlabs.net' exited with 1 runn\r\ning:\r\n           mv /etc/puppetserver/conf.d/puppetserver.conf.bak /etc/puppetserver/conf.d/puppetserver.conf\r\n          Last 10 lines of output were:\r\n                mv: cannot stat ‘/etc/puppetserver/conf.d/puppetserver.conf.bak’: No such file or directory>\r\n            Test Case tests/language/exported_resources.rb reported: #<Beaker::Host::CommandFailure: Host 'y383sdp13cn6x5a.delivery.puppetlabs.net' exited with 1 running:\r\n           ln -sf /tmp/exported_resources_9p4y75k3 /etc/puppetlabs/code/environments/exported_resources_9p4y75k3\r\n          Last 10 lines of output were:\r\n                ln: failed to create symbolic link ‘/etc/puppetlabs/code/environments/exported_resources_9p4y75k3’: No such file or directory>\r\n```\r\n\r\nBoth failures above are during the setup phases of the tests and have to do with files, I think, would normally be managed by packages. I reran the suite against the commit in master I branched from and it also failed with the same two failures. So I think those are an issue with either the current code base, or running from git."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/209031422","html_url":"https://github.com/puppetlabs/puppet/pull/4875#issuecomment-209031422","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4875","id":209031422,"user":{"login":"puppetcla","id":3835957,"avatar_url":"https://avatars.githubusercontent.com/u/3835957?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetcla","html_url":"https://github.com/puppetcla","followers_url":"https://api.github.com/users/puppetcla/followers","following_url":"https://api.github.com/users/puppetcla/following{/other_user}","gists_url":"https://api.github.com/users/puppetcla/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetcla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetcla/subscriptions","organizations_url":"https://api.github.com/users/puppetcla/orgs","repos_url":"https://api.github.com/users/puppetcla/repos","events_url":"https://api.github.com/users/puppetcla/events{/privacy}","received_events_url":"https://api.github.com/users/puppetcla/received_events","type":"User","site_admin":false},"created_at":"2016-04-12T18:00:17Z","updated_at":"2016-04-12T18:00:17Z","body":"CLA signed by all contributors."}}