{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/comments/75515803","id":75515803,"diff_hunk":"@@ -516,12 +528,112 @@ class JedisExecutionRepositorySpec extends ExecutionRepositoryTck<JedisExecution\n     retrieved.size() == actual\n \n     where:\n-    limit  || actual\n-    0      || 0\n-    1      || 1\n-    2      || 2\n-    4      || 4\n-    100    || 4\n+    limit || actual\n+    0     || 0\n+    1     || 1\n+    2     || 2\n+    4     || 4\n+    100   || 4\n+  }\n+\n+  def \"can retrieve orchestrations from multiple redis stores\"() {\n+    given:\n+    repository.store(new Orchestration(application: \"orca\", executingInstance: \"current\"))\n+    repository.store(new Orchestration(application: \"orca\", executingInstance: \"current\"))\n+    repository.store(new Orchestration(application: \"orca\", executingInstance: \"current\"))\n+\n+    and:\n+    def previousRepository = new JedisExecutionRepository(new NoopRegistry(), jedisPoolPrevious, Optional.empty(), 1, 50)\n+    previousRepository.store(new Orchestration(application: \"orca\", executingInstance: \"previous\"))\n+    previousRepository.store(new Orchestration(application: \"orca\", executingInstance: \"previous\"))\n+    previousRepository.store(new Orchestration(application: \"orca\", executingInstance: \"previous\"))\n+\n+    when:\n+    // TODO-AJ limits are current applied to each backing redis","path":"orca-core/src/test/groovy/com/netflix/spinnaker/orca/pipeline/persistence/ExecutionRepositoryTck.groovy","position":96,"original_position":96,"commit_id":"0ce57686756657c7087e5daf44ed754efc8aaa1f","original_commit_id":"0ce57686756657c7087e5daf44ed754efc8aaa1f","user":{"login":"robfletcher","id":95210,"avatar_url":"https://avatars.githubusercontent.com/u/95210?v=3","gravatar_id":"","url":"https://api.github.com/users/robfletcher","html_url":"https://github.com/robfletcher","followers_url":"https://api.github.com/users/robfletcher/followers","following_url":"https://api.github.com/users/robfletcher/following{/other_user}","gists_url":"https://api.github.com/users/robfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/robfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfletcher/subscriptions","organizations_url":"https://api.github.com/users/robfletcher/orgs","repos_url":"https://api.github.com/users/robfletcher/repos","events_url":"https://api.github.com/users/robfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/robfletcher/received_events","type":"User","site_admin":false},"body":"You could maybe apply the limit to the merged one using `take(limit)` but I'm not sure if it would preserve ordering correctly or that would require more work","created_at":"2016-08-19T16:57:29Z","updated_at":"2016-08-19T16:57:29Z","html_url":"https://github.com/spinnaker/orca/pull/945#discussion_r75515803","pull_request_url":"https://api.github.com/repos/spinnaker/orca/pulls/945","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments/75515803"},"html":{"href":"https://github.com/spinnaker/orca/pull/945#discussion_r75515803"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/945"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/945","id":81904210,"html_url":"https://github.com/spinnaker/orca/pull/945","diff_url":"https://github.com/spinnaker/orca/pull/945.diff","patch_url":"https://github.com/spinnaker/orca/pull/945.patch","issue_url":"https://api.github.com/repos/spinnaker/orca/issues/945","number":945,"state":"open","locked":false,"title":"`JedisExecutionRespository` support for multiple redis backends","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"body":"Supports a migration scenario from one redis instance to another\r\n\r\n- Still need to sort out how best to handle `PipelineStartTracker`\r\n- Tools (likely a background agent) to support moving of completed pipelines/orchestrations from old -> new redis will be forthcoming","created_at":"2016-08-18T23:18:20Z","updated_at":"2016-08-19T16:57:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c73a6f56827d56d47e050732bc996c3e32a02709","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/orca/pulls/945/commits","review_comments_url":"https://api.github.com/repos/spinnaker/orca/pulls/945/comments","review_comment_url":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/orca/issues/945/comments","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/0ce57686756657c7087e5daf44ed754efc8aaa1f","head":{"label":"ajordens:dual-mode-redis","ref":"dual-mode-redis","sha":"0ce57686756657c7087e5daf44ed754efc8aaa1f","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"repo":{"id":63391290,"name":"orca","full_name":"ajordens/orca","owner":{"login":"ajordens","id":388652,"avatar_url":"https://avatars.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajordens/orca","description":"orchestration engine","fork":true,"url":"https://api.github.com/repos/ajordens/orca","forks_url":"https://api.github.com/repos/ajordens/orca/forks","keys_url":"https://api.github.com/repos/ajordens/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajordens/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajordens/orca/teams","hooks_url":"https://api.github.com/repos/ajordens/orca/hooks","issue_events_url":"https://api.github.com/repos/ajordens/orca/issues/events{/number}","events_url":"https://api.github.com/repos/ajordens/orca/events","assignees_url":"https://api.github.com/repos/ajordens/orca/assignees{/user}","branches_url":"https://api.github.com/repos/ajordens/orca/branches{/branch}","tags_url":"https://api.github.com/repos/ajordens/orca/tags","blobs_url":"https://api.github.com/repos/ajordens/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajordens/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajordens/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajordens/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajordens/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/ajordens/orca/languages","stargazers_url":"https://api.github.com/repos/ajordens/orca/stargazers","contributors_url":"https://api.github.com/repos/ajordens/orca/contributors","subscribers_url":"https://api.github.com/repos/ajordens/orca/subscribers","subscription_url":"https://api.github.com/repos/ajordens/orca/subscription","commits_url":"https://api.github.com/repos/ajordens/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajordens/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajordens/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajordens/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajordens/orca/contents/{+path}","compare_url":"https://api.github.com/repos/ajordens/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajordens/orca/merges","archive_url":"https://api.github.com/repos/ajordens/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajordens/orca/downloads","issues_url":"https://api.github.com/repos/ajordens/orca/issues{/number}","pulls_url":"https://api.github.com/repos/ajordens/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/ajordens/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/ajordens/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajordens/orca/labels{/name}","releases_url":"https://api.github.com/repos/ajordens/orca/releases{/id}","deployments_url":"https://api.github.com/repos/ajordens/orca/deployments","created_at":"2016-07-15T04:19:37Z","updated_at":"2016-07-15T04:19:43Z","pushed_at":"2016-08-18T23:18:12Z","git_url":"git://github.com/ajordens/orca.git","ssh_url":"git@github.com:ajordens/orca.git","clone_url":"https://github.com/ajordens/orca.git","svn_url":"https://github.com/ajordens/orca","homepage":"","size":6699,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"8e75b955ea3d646e919e3020b72473fa33a42d9a","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":19834314,"name":"orca","full_name":"spinnaker/orca","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/orca","description":"orchestration engine","fork":false,"url":"https://api.github.com/repos/spinnaker/orca","forks_url":"https://api.github.com/repos/spinnaker/orca/forks","keys_url":"https://api.github.com/repos/spinnaker/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/orca/teams","hooks_url":"https://api.github.com/repos/spinnaker/orca/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/orca/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/orca/events","assignees_url":"https://api.github.com/repos/spinnaker/orca/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/orca/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/orca/tags","blobs_url":"https://api.github.com/repos/spinnaker/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/orca/languages","stargazers_url":"https://api.github.com/repos/spinnaker/orca/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/orca/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/orca/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/orca/subscription","commits_url":"https://api.github.com/repos/spinnaker/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/orca/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/orca/merges","archive_url":"https://api.github.com/repos/spinnaker/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/orca/downloads","issues_url":"https://api.github.com/repos/spinnaker/orca/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/orca/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/orca/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/orca/deployments","created_at":"2014-05-15T20:33:00Z","updated_at":"2016-07-27T09:42:32Z","pushed_at":"2016-08-19T16:54:43Z","git_url":"git://github.com/spinnaker/orca.git","ssh_url":"git@github.com:spinnaker/orca.git","clone_url":"https://github.com/spinnaker/orca.git","svn_url":"https://github.com/spinnaker/orca","homepage":"","size":9866,"stargazers_count":33,"watchers_count":33,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":52,"forks":62,"open_issues":52,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/945"},"html":{"href":"https://github.com/spinnaker/orca/pull/945"},"issue":{"href":"https://api.github.com/repos/spinnaker/orca/issues/945"},"comments":{"href":"https://api.github.com/repos/spinnaker/orca/issues/945/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/945/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/945/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/orca/statuses/0ce57686756657c7087e5daf44ed754efc8aaa1f"}}}}
{"actor":{"display_login":"robfletcher"}}