{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/etoile/EtoileFoundation/pulls/4","id":57139855,"html_url":"https://github.com/etoile/EtoileFoundation/pull/4","diff_url":"https://github.com/etoile/EtoileFoundation/pull/4.diff","patch_url":"https://github.com/etoile/EtoileFoundation/pull/4.patch","issue_url":"https://api.github.com/repos/etoile/EtoileFoundation/issues/4","number":4,"state":"closed","locked":false,"title":"S() macro: enforce that all arguments are unique.","user":{"login":"ericwa","id":239161,"avatar_url":"https://avatars.githubusercontent.com/u/239161?v=3","gravatar_id":"","url":"https://api.github.com/users/ericwa","html_url":"https://github.com/ericwa","followers_url":"https://api.github.com/users/ericwa/followers","following_url":"https://api.github.com/users/ericwa/following{/other_user}","gists_url":"https://api.github.com/users/ericwa/gists{/gist_id}","starred_url":"https://api.github.com/users/ericwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericwa/subscriptions","organizations_url":"https://api.github.com/users/ericwa/orgs","repos_url":"https://api.github.com/users/ericwa/repos","events_url":"https://api.github.com/users/ericwa/events{/privacy}","received_events_url":"https://api.github.com/users/ericwa/received_events","type":"User","site_admin":false},"body":"This will throw an exception if you do S(@\"a\", @\"a).\r\n\r\nI don't know if we should change the semantics of S() like this, but I think this will help catch bugs. If you are using the S() macro with duplicates, it's probably an error.\r\n\r\nWith the latest commits I made to CO, the full CO test suite passes with this change.\r\n\r\nI was trying to understand some tests, and it was very confusing to have S(a, b, c, d, e), but actually c, d, and e were equal, so the set was really just S(a, b, c).\r\n\r\n","created_at":"2016-01-25T22:19:03Z","updated_at":"2016-01-27T01:38:58Z","closed_at":"2016-01-27T01:38:58Z","merged_at":null,"merge_commit_sha":"29f0e713dcc2ab2019d073f2b89449774b6e4f0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/etoile/EtoileFoundation/pulls/4/commits","review_comments_url":"https://api.github.com/repos/etoile/EtoileFoundation/pulls/4/comments","review_comment_url":"https://api.github.com/repos/etoile/EtoileFoundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/etoile/EtoileFoundation/issues/4/comments","statuses_url":"https://api.github.com/repos/etoile/EtoileFoundation/statuses/a90a0656ce646f8f25f8859b38394d0ffb7a532c","head":{"label":"etoile:s-macro-unique","ref":"s-macro-unique","sha":"a90a0656ce646f8f25f8859b38394d0ffb7a532c","user":{"login":"etoile","id":641984,"avatar_url":"https://avatars.githubusercontent.com/u/641984?v=3","gravatar_id":"","url":"https://api.github.com/users/etoile","html_url":"https://github.com/etoile","followers_url":"https://api.github.com/users/etoile/followers","following_url":"https://api.github.com/users/etoile/following{/other_user}","gists_url":"https://api.github.com/users/etoile/gists{/gist_id}","starred_url":"https://api.github.com/users/etoile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etoile/subscriptions","organizations_url":"https://api.github.com/users/etoile/orgs","repos_url":"https://api.github.com/users/etoile/repos","events_url":"https://api.github.com/users/etoile/events{/privacy}","received_events_url":"https://api.github.com/users/etoile/received_events","type":"Organization","site_admin":false},"repo":{"id":15924189,"name":"EtoileFoundation","full_name":"etoile/EtoileFoundation","owner":{"login":"etoile","id":641984,"avatar_url":"https://avatars.githubusercontent.com/u/641984?v=3","gravatar_id":"","url":"https://api.github.com/users/etoile","html_url":"https://github.com/etoile","followers_url":"https://api.github.com/users/etoile/followers","following_url":"https://api.github.com/users/etoile/following{/other_user}","gists_url":"https://api.github.com/users/etoile/gists{/gist_id}","starred_url":"https://api.github.com/users/etoile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etoile/subscriptions","organizations_url":"https://api.github.com/users/etoile/orgs","repos_url":"https://api.github.com/users/etoile/repos","events_url":"https://api.github.com/users/etoile/events{/privacy}","received_events_url":"https://api.github.com/users/etoile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/etoile/EtoileFoundation","description":"Étoilé core framework – traits, collection protocols, high order functions, metamodel, UTI etc.","fork":false,"url":"https://api.github.com/repos/etoile/EtoileFoundation","forks_url":"https://api.github.com/repos/etoile/EtoileFoundation/forks","keys_url":"https://api.github.com/repos/etoile/EtoileFoundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etoile/EtoileFoundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etoile/EtoileFoundation/teams","hooks_url":"https://api.github.com/repos/etoile/EtoileFoundation/hooks","issue_events_url":"https://api.github.com/repos/etoile/EtoileFoundation/issues/events{/number}","events_url":"https://api.github.com/repos/etoile/EtoileFoundation/events","assignees_url":"https://api.github.com/repos/etoile/EtoileFoundation/assignees{/user}","branches_url":"https://api.github.com/repos/etoile/EtoileFoundation/branches{/branch}","tags_url":"https://api.github.com/repos/etoile/EtoileFoundation/tags","blobs_url":"https://api.github.com/repos/etoile/EtoileFoundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etoile/EtoileFoundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etoile/EtoileFoundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/etoile/EtoileFoundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etoile/EtoileFoundation/statuses/{sha}","languages_url":"https://api.github.com/repos/etoile/EtoileFoundation/languages","stargazers_url":"https://api.github.com/repos/etoile/EtoileFoundation/stargazers","contributors_url":"https://api.github.com/repos/etoile/EtoileFoundation/contributors","subscribers_url":"https://api.github.com/repos/etoile/EtoileFoundation/subscribers","subscription_url":"https://api.github.com/repos/etoile/EtoileFoundation/subscription","commits_url":"https://api.github.com/repos/etoile/EtoileFoundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/etoile/EtoileFoundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/etoile/EtoileFoundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/etoile/EtoileFoundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/etoile/EtoileFoundation/contents/{+path}","compare_url":"https://api.github.com/repos/etoile/EtoileFoundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etoile/EtoileFoundation/merges","archive_url":"https://api.github.com/repos/etoile/EtoileFoundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etoile/EtoileFoundation/downloads","issues_url":"https://api.github.com/repos/etoile/EtoileFoundation/issues{/number}","pulls_url":"https://api.github.com/repos/etoile/EtoileFoundation/pulls{/number}","milestones_url":"https://api.github.com/repos/etoile/EtoileFoundation/milestones{/number}","notifications_url":"https://api.github.com/repos/etoile/EtoileFoundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etoile/EtoileFoundation/labels{/name}","releases_url":"https://api.github.com/repos/etoile/EtoileFoundation/releases{/id}","deployments_url":"https://api.github.com/repos/etoile/EtoileFoundation/deployments","created_at":"2014-01-15T03:44:09Z","updated_at":"2016-01-22T17:54:07Z","pushed_at":"2016-01-25T22:19:03Z","git_url":"git://github.com/etoile/EtoileFoundation.git","ssh_url":"git@github.com:etoile/EtoileFoundation.git","clone_url":"https://github.com/etoile/EtoileFoundation.git","svn_url":"https://github.com/etoile/EtoileFoundation","homepage":"","size":2177,"stargazers_count":21,"watchers_count":21,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":21,"default_branch":"master"}},"base":{"label":"etoile:master","ref":"master","sha":"14d804ff72c07c1e81c8e86f0aaf8dde0bd0066e","user":{"login":"etoile","id":641984,"avatar_url":"https://avatars.githubusercontent.com/u/641984?v=3","gravatar_id":"","url":"https://api.github.com/users/etoile","html_url":"https://github.com/etoile","followers_url":"https://api.github.com/users/etoile/followers","following_url":"https://api.github.com/users/etoile/following{/other_user}","gists_url":"https://api.github.com/users/etoile/gists{/gist_id}","starred_url":"https://api.github.com/users/etoile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etoile/subscriptions","organizations_url":"https://api.github.com/users/etoile/orgs","repos_url":"https://api.github.com/users/etoile/repos","events_url":"https://api.github.com/users/etoile/events{/privacy}","received_events_url":"https://api.github.com/users/etoile/received_events","type":"Organization","site_admin":false},"repo":{"id":15924189,"name":"EtoileFoundation","full_name":"etoile/EtoileFoundation","owner":{"login":"etoile","id":641984,"avatar_url":"https://avatars.githubusercontent.com/u/641984?v=3","gravatar_id":"","url":"https://api.github.com/users/etoile","html_url":"https://github.com/etoile","followers_url":"https://api.github.com/users/etoile/followers","following_url":"https://api.github.com/users/etoile/following{/other_user}","gists_url":"https://api.github.com/users/etoile/gists{/gist_id}","starred_url":"https://api.github.com/users/etoile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etoile/subscriptions","organizations_url":"https://api.github.com/users/etoile/orgs","repos_url":"https://api.github.com/users/etoile/repos","events_url":"https://api.github.com/users/etoile/events{/privacy}","received_events_url":"https://api.github.com/users/etoile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/etoile/EtoileFoundation","description":"Étoilé core framework – traits, collection protocols, high order functions, metamodel, UTI etc.","fork":false,"url":"https://api.github.com/repos/etoile/EtoileFoundation","forks_url":"https://api.github.com/repos/etoile/EtoileFoundation/forks","keys_url":"https://api.github.com/repos/etoile/EtoileFoundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etoile/EtoileFoundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etoile/EtoileFoundation/teams","hooks_url":"https://api.github.com/repos/etoile/EtoileFoundation/hooks","issue_events_url":"https://api.github.com/repos/etoile/EtoileFoundation/issues/events{/number}","events_url":"https://api.github.com/repos/etoile/EtoileFoundation/events","assignees_url":"https://api.github.com/repos/etoile/EtoileFoundation/assignees{/user}","branches_url":"https://api.github.com/repos/etoile/EtoileFoundation/branches{/branch}","tags_url":"https://api.github.com/repos/etoile/EtoileFoundation/tags","blobs_url":"https://api.github.com/repos/etoile/EtoileFoundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etoile/EtoileFoundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etoile/EtoileFoundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/etoile/EtoileFoundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etoile/EtoileFoundation/statuses/{sha}","languages_url":"https://api.github.com/repos/etoile/EtoileFoundation/languages","stargazers_url":"https://api.github.com/repos/etoile/EtoileFoundation/stargazers","contributors_url":"https://api.github.com/repos/etoile/EtoileFoundation/contributors","subscribers_url":"https://api.github.com/repos/etoile/EtoileFoundation/subscribers","subscription_url":"https://api.github.com/repos/etoile/EtoileFoundation/subscription","commits_url":"https://api.github.com/repos/etoile/EtoileFoundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/etoile/EtoileFoundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/etoile/EtoileFoundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/etoile/EtoileFoundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/etoile/EtoileFoundation/contents/{+path}","compare_url":"https://api.github.com/repos/etoile/EtoileFoundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etoile/EtoileFoundation/merges","archive_url":"https://api.github.com/repos/etoile/EtoileFoundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etoile/EtoileFoundation/downloads","issues_url":"https://api.github.com/repos/etoile/EtoileFoundation/issues{/number}","pulls_url":"https://api.github.com/repos/etoile/EtoileFoundation/pulls{/number}","milestones_url":"https://api.github.com/repos/etoile/EtoileFoundation/milestones{/number}","notifications_url":"https://api.github.com/repos/etoile/EtoileFoundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etoile/EtoileFoundation/labels{/name}","releases_url":"https://api.github.com/repos/etoile/EtoileFoundation/releases{/id}","deployments_url":"https://api.github.com/repos/etoile/EtoileFoundation/deployments","created_at":"2014-01-15T03:44:09Z","updated_at":"2016-01-22T17:54:07Z","pushed_at":"2016-01-25T22:19:03Z","git_url":"git://github.com/etoile/EtoileFoundation.git","ssh_url":"git@github.com:etoile/EtoileFoundation.git","clone_url":"https://github.com/etoile/EtoileFoundation.git","svn_url":"https://github.com/etoile/EtoileFoundation","homepage":"","size":2177,"stargazers_count":21,"watchers_count":21,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etoile/EtoileFoundation/pulls/4"},"html":{"href":"https://github.com/etoile/EtoileFoundation/pull/4"},"issue":{"href":"https://api.github.com/repos/etoile/EtoileFoundation/issues/4"},"comments":{"href":"https://api.github.com/repos/etoile/EtoileFoundation/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/etoile/EtoileFoundation/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/etoile/EtoileFoundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/etoile/EtoileFoundation/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/etoile/EtoileFoundation/statuses/a90a0656ce646f8f25f8859b38394d0ffb7a532c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":2,"deletions":20,"changed_files":2}}