{"action":"created","comment":{"url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/comments/82284801","pull_request_review_id":3204052,"id":82284801,"diff_hunk":"@@ -218,18 +218,6 @@\n     end\n   end\n \n-  context \"with site.github.url\" do\n-    let(:github_namespace) { { \"url\" => \"http://example.invalid\" } }\n-    let(:site) { make_site(\"github\" => github_namespace) }\n-\n-    it \"uses site.github.url to build the seo url\" do\n-      expected = %r!<link rel=\"canonical\" href=\"http://example.invalid/page.html\" \\/>!\n-      expect(output).to match(expected)\n-      expected = %r!<meta property=\"og:url\" content=\"http://example.invalid/page.html\" />!\n-      expect(output).to match(expected)\n-    end\n-  end\n-","path":"spec/jekyll_seo_tag_spec.rb","position":15,"original_position":15,"commit_id":"df09740757543e6f5a5cf59401c9c7ec7e67362f","original_commit_id":"df09740757543e6f5a5cf59401c9c7ec7e67362f","user":{"login":"benbalter","id":282759,"avatar_url":"https://avatars.githubusercontent.com/u/282759?v=3","gravatar_id":"","url":"https://api.github.com/users/benbalter","html_url":"https://github.com/benbalter","followers_url":"https://api.github.com/users/benbalter/followers","following_url":"https://api.github.com/users/benbalter/following{/other_user}","gists_url":"https://api.github.com/users/benbalter/gists{/gist_id}","starred_url":"https://api.github.com/users/benbalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbalter/subscriptions","organizations_url":"https://api.github.com/users/benbalter/orgs","repos_url":"https://api.github.com/users/benbalter/repos","events_url":"https://api.github.com/users/benbalter/events{/privacy}","received_events_url":"https://api.github.com/users/benbalter/received_events","type":"User","site_admin":true},"body":"Yep. This plugin can now rely on `absolute_url`, which will be based on `site.url`, which Pages will set... no need to bake proprietary namespaces into open source plugins. :smile:","created_at":"2016-10-06T21:04:23Z","updated_at":"2016-10-06T21:09:02Z","html_url":"https://github.com/jekyll/jekyll-seo-tag/pull/123#discussion_r82284801","pull_request_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/comments/82284801"},"html":{"href":"https://github.com/jekyll/jekyll-seo-tag/pull/123#discussion_r82284801"},"pull_request":{"href":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/123","id":88339577,"html_url":"https://github.com/jekyll/jekyll-seo-tag/pull/123","diff_url":"https://github.com/jekyll/jekyll-seo-tag/pull/123.diff","patch_url":"https://github.com/jekyll/jekyll-seo-tag/pull/123.patch","issue_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/issues/123","number":123,"state":"open","locked":false,"title":"Use new URL filters","user":{"login":"pathawks","id":251545,"avatar_url":"https://avatars.githubusercontent.com/u/251545?v=3","gravatar_id":"","url":"https://api.github.com/users/pathawks","html_url":"https://github.com/pathawks","followers_url":"https://api.github.com/users/pathawks/followers","following_url":"https://api.github.com/users/pathawks/following{/other_user}","gists_url":"https://api.github.com/users/pathawks/gists{/gist_id}","starred_url":"https://api.github.com/users/pathawks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathawks/subscriptions","organizations_url":"https://api.github.com/users/pathawks/orgs","repos_url":"https://api.github.com/users/pathawks/repos","events_url":"https://api.github.com/users/pathawks/events{/privacy}","received_events_url":"https://api.github.com/users/pathawks/received_events","type":"User","site_admin":false},"body":"I had to change some tests in addition to logic in this one, so let's give it a very close review.\r\n\r\nFixes #122","created_at":"2016-10-06T20:57:09Z","updated_at":"2016-10-06T21:09:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25194b91c32470f6951b434ec3b27a6d46d137fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/123/commits","review_comments_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/123/comments","review_comment_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/issues/123/comments","statuses_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/statuses/df09740757543e6f5a5cf59401c9c7ec7e67362f","head":{"label":"jekyll:pr/newfilters","ref":"pr/newfilters","sha":"df09740757543e6f5a5cf59401c9c7ec7e67362f","user":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"repo":{"id":44931313,"name":"jekyll-seo-tag","full_name":"jekyll/jekyll-seo-tag","owner":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jekyll/jekyll-seo-tag","description":"A Jekyll plugin to add metadata tags for search engines and social networks to better index and display your site's content.","fork":false,"url":"https://api.github.com/repos/jekyll/jekyll-seo-tag","forks_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/forks","keys_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/teams","hooks_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/hooks","issue_events_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/issues/events{/number}","events_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/events","assignees_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/assignees{/user}","branches_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/branches{/branch}","tags_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/tags","blobs_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/statuses/{sha}","languages_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/languages","stargazers_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/stargazers","contributors_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/contributors","subscribers_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/subscribers","subscription_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/subscription","commits_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/issues/comments{/number}","contents_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/contents/{+path}","compare_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/merges","archive_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/downloads","issues_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/issues{/number}","pulls_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls{/number}","milestones_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/milestones{/number}","notifications_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/labels{/name}","releases_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/releases{/id}","deployments_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/deployments","created_at":"2015-10-25T21:45:01Z","updated_at":"2016-10-06T03:50:23Z","pushed_at":"2016-10-06T20:57:09Z","git_url":"git://github.com/jekyll/jekyll-seo-tag.git","ssh_url":"git@github.com:jekyll/jekyll-seo-tag.git","clone_url":"https://github.com/jekyll/jekyll-seo-tag.git","svn_url":"https://github.com/jekyll/jekyll-seo-tag","homepage":null,"size":149,"stargazers_count":274,"watchers_count":274,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":21,"forks":34,"open_issues":21,"watchers":274,"default_branch":"master"}},"base":{"label":"jekyll:master","ref":"master","sha":"2631e3ea77c5863fbc81f55222fdf3c06eda0f88","user":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"repo":{"id":44931313,"name":"jekyll-seo-tag","full_name":"jekyll/jekyll-seo-tag","owner":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jekyll/jekyll-seo-tag","description":"A Jekyll plugin to add metadata tags for search engines and social networks to better index and display your site's content.","fork":false,"url":"https://api.github.com/repos/jekyll/jekyll-seo-tag","forks_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/forks","keys_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/teams","hooks_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/hooks","issue_events_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/issues/events{/number}","events_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/events","assignees_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/assignees{/user}","branches_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/branches{/branch}","tags_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/tags","blobs_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/statuses/{sha}","languages_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/languages","stargazers_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/stargazers","contributors_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/contributors","subscribers_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/subscribers","subscription_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/subscription","commits_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/issues/comments{/number}","contents_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/contents/{+path}","compare_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/merges","archive_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/downloads","issues_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/issues{/number}","pulls_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls{/number}","milestones_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/milestones{/number}","notifications_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/labels{/name}","releases_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/releases{/id}","deployments_url":"https://api.github.com/repos/jekyll/jekyll-seo-tag/deployments","created_at":"2015-10-25T21:45:01Z","updated_at":"2016-10-06T03:50:23Z","pushed_at":"2016-10-06T20:57:09Z","git_url":"git://github.com/jekyll/jekyll-seo-tag.git","ssh_url":"git@github.com:jekyll/jekyll-seo-tag.git","clone_url":"https://github.com/jekyll/jekyll-seo-tag.git","svn_url":"https://github.com/jekyll/jekyll-seo-tag","homepage":null,"size":149,"stargazers_count":274,"watchers_count":274,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":21,"forks":34,"open_issues":21,"watchers":274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/123"},"html":{"href":"https://github.com/jekyll/jekyll-seo-tag/pull/123"},"issue":{"href":"https://api.github.com/repos/jekyll/jekyll-seo-tag/issues/123"},"comments":{"href":"https://api.github.com/repos/jekyll/jekyll-seo-tag/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jekyll/jekyll-seo-tag/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/jekyll/jekyll-seo-tag/statuses/df09740757543e6f5a5cf59401c9c7ec7e67362f"}}}}
{"actor":{"display_login":"benbalter"}}