{"action":"created","issue":{"url":"https://api.github.com/repos/aetrion/erl-dns/issues/47","repository_url":"https://api.github.com/repos/aetrion/erl-dns","labels_url":"https://api.github.com/repos/aetrion/erl-dns/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/aetrion/erl-dns/issues/47/comments","events_url":"https://api.github.com/repos/aetrion/erl-dns/issues/47/events","html_url":"https://github.com/aetrion/erl-dns/pull/47","id":156141300,"number":47,"title":"Add some rebar3 / dialyzer related build stuff","user":{"login":"sargun","id":750148,"avatar_url":"https://avatars.githubusercontent.com/u/750148?v=3","gravatar_id":"","url":"https://api.github.com/users/sargun","html_url":"https://github.com/sargun","followers_url":"https://api.github.com/users/sargun/followers","following_url":"https://api.github.com/users/sargun/following{/other_user}","gists_url":"https://api.github.com/users/sargun/gists{/gist_id}","starred_url":"https://api.github.com/users/sargun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sargun/subscriptions","organizations_url":"https://api.github.com/users/sargun/orgs","repos_url":"https://api.github.com/users/sargun/repos","events_url":"https://api.github.com/users/sargun/events{/privacy}","received_events_url":"https://api.github.com/users/sargun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-22T08:25:08Z","updated_at":"2016-05-23T05:57:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aetrion/erl-dns/pulls/47","html_url":"https://github.com/aetrion/erl-dns/pull/47","diff_url":"https://github.com/aetrion/erl-dns/pull/47.diff","patch_url":"https://github.com/aetrion/erl-dns/pull/47.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/aetrion/erl-dns/issues/comments/220893277","html_url":"https://github.com/aetrion/erl-dns/pull/47#issuecomment-220893277","issue_url":"https://api.github.com/repos/aetrion/erl-dns/issues/47","id":220893277,"user":{"login":"sargun","id":750148,"avatar_url":"https://avatars.githubusercontent.com/u/750148?v=3","gravatar_id":"","url":"https://api.github.com/users/sargun","html_url":"https://github.com/sargun","followers_url":"https://api.github.com/users/sargun/followers","following_url":"https://api.github.com/users/sargun/following{/other_user}","gists_url":"https://api.github.com/users/sargun/gists{/gist_id}","starred_url":"https://api.github.com/users/sargun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sargun/subscriptions","organizations_url":"https://api.github.com/users/sargun/orgs","repos_url":"https://api.github.com/users/sargun/repos","events_url":"https://api.github.com/users/sargun/events{/privacy}","received_events_url":"https://api.github.com/users/sargun/received_events","type":"User","site_admin":false},"created_at":"2016-05-23T05:57:15Z","updated_at":"2016-05-23T05:57:15Z","body":"One of the comments that seems to have gotten lost is the issue with `erldns_resolver`. I had changed the error case here: https://github.com/aetrion/erl-dns/blob/master/src/erldns_resolver.erl#L143-L153 to `{error, _}`. The problem is that `erldns_zone_cache:get_authority` has the typespec to return `{'error','no_question'}` as well.\r\n\r\nWhat do you propose we do? How should that error case be handled?"}}
{"actor":{"display_login":"sargun"}}