{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/77768114","id":77768114,"diff_hunk":"@@ -11,79 +11,74 @@\n \n -->\n \n-<container xmlns=\"http://symfony.com/schema/dic/services\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd\">\n+<container xmlns=\"http://symfony.com/schema/dic/services\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+           xsi:schemaLocation=\"http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd\">\n     <services>\n-        <service id=\"sylius.order_processing.inventory_handler\" class=\"Sylius\\Component\\Core\\OrderProcessing\\InventoryHandler\">\n-            <argument type=\"service\" id=\"sylius.inventory_operator\" />\n-            <argument type=\"service\" id=\"sylius.factory.order_item_unit\" />\n-            <argument type=\"service\" id=\"sm.factory\" />\n+        <service id=\"sylius.order_processing.inventory_handler\"\n+                 class=\"Sylius\\Component\\Core\\OrderProcessing\\InventoryHandler\">\n+            <argument type=\"service\" id=\"sylius.inventory_operator\"/>\n+            <argument type=\"service\" id=\"sylius.factory.order_item_unit\"/>\n+            <argument type=\"service\" id=\"sm.factory\"/>\n         </service>\n \n-        <service id=\"sylius.order_processing.state_resolver\" class=\"Sylius\\Component\\Core\\OrderProcessing\\StateResolver\">\n-            <argument type=\"service\" id=\"sm.factory\" />\n+        <service id=\"sylius.order_processing.state_resolver\"\n+                 class=\"Sylius\\Component\\Core\\OrderProcessing\\StateResolver\">\n+            <argument type=\"service\" id=\"sm.factory\"/>\n         </service>\n \n-        <service id=\"sylius.order_processing.order_processor\" class=\"Sylius\\Component\\Order\\Processor\\CompositeOrderProcessor\">\n-            <call method=\"addProcessor\">\n-                <argument type=\"service\">\n-                    <service class=\"Sylius\\Component\\Core\\OrderProcessing\\OrderExchangeRateProcessor\">\n-                        <argument type=\"service\" id=\"sylius.updater.order.exchange_rate\" />\n-                    </service>\n-                </argument>\n-            </call>\n-            <call method=\"addProcessor\">\n-                <argument type=\"service\">\n-                    <service class=\"Sylius\\Component\\Core\\OrderProcessing\\OrderShipmentProcessor\">\n-                        <argument type=\"service\" id=\"sylius.resolver.default_shipping_method\" />\n-                        <argument type=\"service\" id=\"sylius.factory.shipment\" />\n-                    </service>\n-                </argument>\n-            </call>\n-            <call method=\"addProcessor\">\n-                <argument type=\"service\">\n-                    <service class=\"Sylius\\Component\\Core\\OrderProcessing\\OrderPaymentProcessor\">\n-                        <argument type=\"service\" id=\"sylius.factory.payment\" />\n-                        <argument type=\"service\" id=\"sylius.repository.payment_method\" />\n-                    </service>\n-                </argument>\n-            </call>\n-            <call method=\"addProcessor\">\n-                <argument type=\"service\">\n-                    <service class=\"Sylius\\Component\\Core\\OrderProcessing\\OrderAdjustmentsClearer\" />\n-                </argument>\n-            </call>\n-            <call method=\"addProcessor\">\n-                <argument type=\"service\">\n-                    <service class=\"Sylius\\Component\\Core\\OrderProcessing\\ShippingChargesProcessor\">\n-                        <argument type=\"service\" id=\"sylius.factory.adjustment\" />\n-                        <argument type=\"service\" id=\"sylius.shipping_calculator\" />\n-                    </service>\n-                </argument>\n-            </call>\n-            <call method=\"addProcessor\">\n-                <argument type=\"service\">\n-                    <service class=\"Sylius\\Component\\Core\\OrderProcessing\\OrderPricesRecalculator\">\n-                        <argument type=\"service\" id=\"sylius.price_calculator\" />\n-                    </service>\n-                </argument>\n-            </call>\n-            <call method=\"addProcessor\">\n-                <argument type=\"service\">\n-                    <service class=\"Sylius\\Component\\Core\\OrderProcessing\\OrderPromotionProcessor\">\n-                        <argument type=\"service\" id=\"sylius.promotion_processor\" />\n-                    </service>\n-                </argument>\n-            </call>\n-            <call method=\"addProcessor\">\n-                <argument type=\"service\">\n-                    <service class=\"Sylius\\Component\\Core\\OrderProcessing\\OrderTaxesProcessor\">\n-                        <argument type=\"service\" id=\"sylius.provider.channel_based_default_zone_provider\" />\n-                        <argument type=\"service\" id=\"sylius.zone_matcher\" />\n-                        <argument type=\"service\" id=\"sylius.registry.tax_calculation_strategy\" />\n-                    </service>\n-                </argument>\n-            </call>\n+        <service id=\"sylius.order_processing.order_processor\"\n+                 class=\"Sylius\\Component\\Order\\Processor\\CompositeOrderProcessor\"/>","path":"src/Sylius/Bundle/CoreBundle/Resources/config/order_processor.xml","position":87,"original_position":87,"commit_id":"6231aedea58b7c2a1e72981f9a45fc214756df79","original_commit_id":"6231aedea58b7c2a1e72981f9a45fc214756df79","user":{"login":"lchrusciel","id":6213903,"avatar_url":"https://avatars.githubusercontent.com/u/6213903?v=3","gravatar_id":"","url":"https://api.github.com/users/lchrusciel","html_url":"https://github.com/lchrusciel","followers_url":"https://api.github.com/users/lchrusciel/followers","following_url":"https://api.github.com/users/lchrusciel/following{/other_user}","gists_url":"https://api.github.com/users/lchrusciel/gists{/gist_id}","starred_url":"https://api.github.com/users/lchrusciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lchrusciel/subscriptions","organizations_url":"https://api.github.com/users/lchrusciel/orgs","repos_url":"https://api.github.com/users/lchrusciel/repos","events_url":"https://api.github.com/users/lchrusciel/events{/privacy}","received_events_url":"https://api.github.com/users/lchrusciel/received_events","type":"User","site_admin":false},"body":"I would leave this services definition in a one line","created_at":"2016-09-07T06:52:59Z","updated_at":"2016-09-07T06:52:59Z","html_url":"https://github.com/Sylius/Sylius/pull/5998#discussion_r77768114","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/5998","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/77768114"},"html":{"href":"https://github.com/Sylius/Sylius/pull/5998#discussion_r77768114"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5998"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/5998","id":84145163,"html_url":"https://github.com/Sylius/Sylius/pull/5998","diff_url":"https://github.com/Sylius/Sylius/pull/5998.diff","patch_url":"https://github.com/Sylius/Sylius/pull/5998.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/5998","number":5998,"state":"open","locked":false,"title":"Compiler pass added to register order processors using service tags","user":{"login":"gorkalaucirica","id":1749891,"avatar_url":"https://avatars.githubusercontent.com/u/1749891?v=3","gravatar_id":"","url":"https://api.github.com/users/gorkalaucirica","html_url":"https://github.com/gorkalaucirica","followers_url":"https://api.github.com/users/gorkalaucirica/followers","following_url":"https://api.github.com/users/gorkalaucirica/following{/other_user}","gists_url":"https://api.github.com/users/gorkalaucirica/gists{/gist_id}","starred_url":"https://api.github.com/users/gorkalaucirica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorkalaucirica/subscriptions","organizations_url":"https://api.github.com/users/gorkalaucirica/orgs","repos_url":"https://api.github.com/users/gorkalaucirica/repos","events_url":"https://api.github.com/users/gorkalaucirica/events{/privacy}","received_events_url":"https://api.github.com/users/gorkalaucirica/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | no\r\n| New feature?    | yes\r\n| BC breaks?      | no\r\n| Related tickets | mentioned in #5986 \r\n| License         | MIT\r\n\r\nThis PR allows registering custom OrderProcessors using `sylius.order_processor` service tag","created_at":"2016-09-06T15:35:30Z","updated_at":"2016-09-07T06:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"700c299efbb27634bf4ec1e146f2b155ab170afd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/5998/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/5998/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/5998/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/6231aedea58b7c2a1e72981f9a45fc214756df79","head":{"label":"gorkalaucirica:feature/order-processor-compiler-pass","ref":"feature/order-processor-compiler-pass","sha":"6231aedea58b7c2a1e72981f9a45fc214756df79","user":{"login":"gorkalaucirica","id":1749891,"avatar_url":"https://avatars.githubusercontent.com/u/1749891?v=3","gravatar_id":"","url":"https://api.github.com/users/gorkalaucirica","html_url":"https://github.com/gorkalaucirica","followers_url":"https://api.github.com/users/gorkalaucirica/followers","following_url":"https://api.github.com/users/gorkalaucirica/following{/other_user}","gists_url":"https://api.github.com/users/gorkalaucirica/gists{/gist_id}","starred_url":"https://api.github.com/users/gorkalaucirica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorkalaucirica/subscriptions","organizations_url":"https://api.github.com/users/gorkalaucirica/orgs","repos_url":"https://api.github.com/users/gorkalaucirica/repos","events_url":"https://api.github.com/users/gorkalaucirica/events{/privacy}","received_events_url":"https://api.github.com/users/gorkalaucirica/received_events","type":"User","site_admin":false},"repo":{"id":64747731,"name":"Sylius","full_name":"gorkalaucirica/Sylius","owner":{"login":"gorkalaucirica","id":1749891,"avatar_url":"https://avatars.githubusercontent.com/u/1749891?v=3","gravatar_id":"","url":"https://api.github.com/users/gorkalaucirica","html_url":"https://github.com/gorkalaucirica","followers_url":"https://api.github.com/users/gorkalaucirica/followers","following_url":"https://api.github.com/users/gorkalaucirica/following{/other_user}","gists_url":"https://api.github.com/users/gorkalaucirica/gists{/gist_id}","starred_url":"https://api.github.com/users/gorkalaucirica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorkalaucirica/subscriptions","organizations_url":"https://api.github.com/users/gorkalaucirica/orgs","repos_url":"https://api.github.com/users/gorkalaucirica/repos","events_url":"https://api.github.com/users/gorkalaucirica/events{/privacy}","received_events_url":"https://api.github.com/users/gorkalaucirica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gorkalaucirica/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":true,"url":"https://api.github.com/repos/gorkalaucirica/Sylius","forks_url":"https://api.github.com/repos/gorkalaucirica/Sylius/forks","keys_url":"https://api.github.com/repos/gorkalaucirica/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gorkalaucirica/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gorkalaucirica/Sylius/teams","hooks_url":"https://api.github.com/repos/gorkalaucirica/Sylius/hooks","issue_events_url":"https://api.github.com/repos/gorkalaucirica/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/gorkalaucirica/Sylius/events","assignees_url":"https://api.github.com/repos/gorkalaucirica/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/gorkalaucirica/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/gorkalaucirica/Sylius/tags","blobs_url":"https://api.github.com/repos/gorkalaucirica/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gorkalaucirica/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gorkalaucirica/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/gorkalaucirica/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gorkalaucirica/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/gorkalaucirica/Sylius/languages","stargazers_url":"https://api.github.com/repos/gorkalaucirica/Sylius/stargazers","contributors_url":"https://api.github.com/repos/gorkalaucirica/Sylius/contributors","subscribers_url":"https://api.github.com/repos/gorkalaucirica/Sylius/subscribers","subscription_url":"https://api.github.com/repos/gorkalaucirica/Sylius/subscription","commits_url":"https://api.github.com/repos/gorkalaucirica/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/gorkalaucirica/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/gorkalaucirica/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/gorkalaucirica/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/gorkalaucirica/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/gorkalaucirica/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gorkalaucirica/Sylius/merges","archive_url":"https://api.github.com/repos/gorkalaucirica/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gorkalaucirica/Sylius/downloads","issues_url":"https://api.github.com/repos/gorkalaucirica/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/gorkalaucirica/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/gorkalaucirica/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/gorkalaucirica/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gorkalaucirica/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/gorkalaucirica/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/gorkalaucirica/Sylius/deployments","created_at":"2016-08-02T10:28:00Z","updated_at":"2016-08-02T10:28:12Z","pushed_at":"2016-09-06T15:34:18Z","git_url":"git://github.com/gorkalaucirica/Sylius.git","ssh_url":"git@github.com:gorkalaucirica/Sylius.git","clone_url":"https://github.com/gorkalaucirica/Sylius.git","svn_url":"https://github.com/gorkalaucirica/Sylius","homepage":"http://Sylius.org","size":41409,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"d9bfda096143de63662dc34f9f16dfc9f258bd72","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2016-09-07T00:47:19Z","pushed_at":"2016-09-07T06:41:32Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":77865,"stargazers_count":2436,"watchers_count":2436,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":911,"mirror_url":null,"open_issues_count":804,"forks":911,"open_issues":804,"watchers":2436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5998"},"html":{"href":"https://github.com/Sylius/Sylius/pull/5998"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/5998"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/5998/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5998/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5998/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/6231aedea58b7c2a1e72981f9a45fc214756df79"}}}}
{"actor":{"display_login":"lchrusciel"}}