{"action":"created","comment":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/comments/76869756","id":76869756,"diff_hunk":"@@ -14,294 +14,446 @@\n  * limitations under the License.\n  */\n /**\n- * @fileoverview Definitions from the Streams API as of 22 June 2015.\n- * @see https://streams.spec.whatwg.org/commit-snapshots/b2131ef6460c446817767d7575698f9fcfa554a3/\n+ * @fileoverview Streams API definitions\n+ * \n+ * Based on Living Standard — Last Updated 5 August 2016\n+ * https://streams.spec.whatwg.org/commit-snapshots/34ecaadbcce8df9943d7a2cdb7fca4dc25914df4/\n+ * \n+ * @see https://streams.spec.whatwg.org/\n  * @externs\n  */\n \n+\n+/** @typedef {{ value:*, done:boolean }} */\n+var IteratorResult;\n+\n+\n /**\n- * @typedef {{ value: (*|undefined), done: boolean }}\n+ * @typedef {!CountQueuingStrategy|!ByteLengthQueuingStrategy|{\n+ *     size: (undefined|function(*): number),\n+ *     highWaterMark: number\n+ * }}\n  */\n-var IteratorResult;\n+var QueuingStrategy;\n+\n \n /**\n- * @param {{ highWaterMark: number }} config\n- * @constructor\n+ * @record\n  */\n-function ByteLengthQueuingStrategy(config) {}\n+function TransformStream() {};\n+\n+/** @type {!WritableStream} */\n+TransformStream.prototype.writable;\n+\n+/** @type {!ReadableStream} */\n+TransformStream.prototype.readable;\n+\n \n /**\n- * @param {*} chunk\n- * @return {number}\n+ * @record\n  */\n-ByteLengthQueuingStrategy.prototype.size = function(chunk) {};\n+function PipeOptions() {};\n+\n+/** @type {boolean} */\n+PipeOptions.prototype.preventClose;\n+\n+/** @type {boolean} */\n+PipeOptions.prototype.preventAbort;\n+\n+/** @type {boolean} */\n+PipeOptions.prototype.preventCancel;\n+\n+\n+/**\n+ * @record\n+ */\n+function ReadableStreamSource() {};\n+\n+/** @type {(undefined|function((!ReadableByteStreamController|!ReadableStreamDefaultController)):(!Promise<*>|undefined))}*/\n+ReadableStreamSource.prototype.start;","path":"externs/browser/streamsapi.js","position":70,"original_position":70,"commit_id":"7097feb89d11941b1b360c04bc558de61f4ad716","original_commit_id":"7097feb89d11941b1b360c04bc558de61f4ad716","user":{"login":"vobruba-martin","id":6897988,"avatar_url":"https://avatars.githubusercontent.com/u/6897988?v=3","gravatar_id":"","url":"https://api.github.com/users/vobruba-martin","html_url":"https://github.com/vobruba-martin","followers_url":"https://api.github.com/users/vobruba-martin/followers","following_url":"https://api.github.com/users/vobruba-martin/following{/other_user}","gists_url":"https://api.github.com/users/vobruba-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/vobruba-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vobruba-martin/subscriptions","organizations_url":"https://api.github.com/users/vobruba-martin/orgs","repos_url":"https://api.github.com/users/vobruba-martin/repos","events_url":"https://api.github.com/users/vobruba-martin/events{/privacy}","received_events_url":"https://api.github.com/users/vobruba-martin/received_events","type":"User","site_admin":false},"body":"I would like to change this and `ReadableStreamSource.prototype.pull;` to \r\n```\r\n{(undefined\r\n|function(!ReadableByteStreamController):(!Promise<*>|undefined)\r\n|function(!ReadableStreamDefaultController):(!Promise<*>|undefined))}\r\n```\r\nbecause currently I have to deal with `!ReadableByteStreamController|!ReadableStreamDefaultController` type inside these methods.\r\n\r\nWhat do you think @MatrixFrog ? Will it be OK if I update this PR? Or would be better to leave it for another PR after this one is merged?","created_at":"2016-08-30T20:10:43Z","updated_at":"2016-08-30T20:10:43Z","html_url":"https://github.com/google/closure-compiler/pull/1968#discussion_r76869756","pull_request_url":"https://api.github.com/repos/google/closure-compiler/pulls/1968","_links":{"self":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/comments/76869756"},"html":{"href":"https://github.com/google/closure-compiler/pull/1968#discussion_r76869756"},"pull_request":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1968"}}},"pull_request":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/1968","id":82007622,"html_url":"https://github.com/google/closure-compiler/pull/1968","diff_url":"https://github.com/google/closure-compiler/pull/1968.diff","patch_url":"https://github.com/google/closure-compiler/pull/1968.patch","issue_url":"https://api.github.com/repos/google/closure-compiler/issues/1968","number":1968,"state":"open","locked":false,"title":"Streams API updated based on Living Standard — Last Updated 5 August 2016","user":{"login":"vobruba-martin","id":6897988,"avatar_url":"https://avatars.githubusercontent.com/u/6897988?v=3","gravatar_id":"","url":"https://api.github.com/users/vobruba-martin","html_url":"https://github.com/vobruba-martin","followers_url":"https://api.github.com/users/vobruba-martin/followers","following_url":"https://api.github.com/users/vobruba-martin/following{/other_user}","gists_url":"https://api.github.com/users/vobruba-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/vobruba-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vobruba-martin/subscriptions","organizations_url":"https://api.github.com/users/vobruba-martin/orgs","repos_url":"https://api.github.com/users/vobruba-martin/repos","events_url":"https://api.github.com/users/vobruba-martin/events{/privacy}","received_events_url":"https://api.github.com/users/vobruba-martin/received_events","type":"User","site_admin":false},"body":"See https://streams.spec.whatwg.org/","created_at":"2016-08-19T16:21:47Z","updated_at":"2016-08-30T20:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a747de9aa15bd0502b17ff54e7bdc6f535f2d019","assignee":{"login":"MatrixFrog","id":244381,"avatar_url":"https://avatars.githubusercontent.com/u/244381?v=3","gravatar_id":"","url":"https://api.github.com/users/MatrixFrog","html_url":"https://github.com/MatrixFrog","followers_url":"https://api.github.com/users/MatrixFrog/followers","following_url":"https://api.github.com/users/MatrixFrog/following{/other_user}","gists_url":"https://api.github.com/users/MatrixFrog/gists{/gist_id}","starred_url":"https://api.github.com/users/MatrixFrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatrixFrog/subscriptions","organizations_url":"https://api.github.com/users/MatrixFrog/orgs","repos_url":"https://api.github.com/users/MatrixFrog/repos","events_url":"https://api.github.com/users/MatrixFrog/events{/privacy}","received_events_url":"https://api.github.com/users/MatrixFrog/received_events","type":"User","site_admin":false},"assignees":[{"login":"MatrixFrog","id":244381,"avatar_url":"https://avatars.githubusercontent.com/u/244381?v=3","gravatar_id":"","url":"https://api.github.com/users/MatrixFrog","html_url":"https://github.com/MatrixFrog","followers_url":"https://api.github.com/users/MatrixFrog/followers","following_url":"https://api.github.com/users/MatrixFrog/following{/other_user}","gists_url":"https://api.github.com/users/MatrixFrog/gists{/gist_id}","starred_url":"https://api.github.com/users/MatrixFrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatrixFrog/subscriptions","organizations_url":"https://api.github.com/users/MatrixFrog/orgs","repos_url":"https://api.github.com/users/MatrixFrog/repos","events_url":"https://api.github.com/users/MatrixFrog/events{/privacy}","received_events_url":"https://api.github.com/users/MatrixFrog/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/closure-compiler/pulls/1968/commits","review_comments_url":"https://api.github.com/repos/google/closure-compiler/pulls/1968/comments","review_comment_url":"https://api.github.com/repos/google/closure-compiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/closure-compiler/issues/1968/comments","statuses_url":"https://api.github.com/repos/google/closure-compiler/statuses/7097feb89d11941b1b360c04bc558de61f4ad716","head":{"label":"vobruba-martin:streams-api","ref":"streams-api","sha":"7097feb89d11941b1b360c04bc558de61f4ad716","user":{"login":"vobruba-martin","id":6897988,"avatar_url":"https://avatars.githubusercontent.com/u/6897988?v=3","gravatar_id":"","url":"https://api.github.com/users/vobruba-martin","html_url":"https://github.com/vobruba-martin","followers_url":"https://api.github.com/users/vobruba-martin/followers","following_url":"https://api.github.com/users/vobruba-martin/following{/other_user}","gists_url":"https://api.github.com/users/vobruba-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/vobruba-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vobruba-martin/subscriptions","organizations_url":"https://api.github.com/users/vobruba-martin/orgs","repos_url":"https://api.github.com/users/vobruba-martin/repos","events_url":"https://api.github.com/users/vobruba-martin/events{/privacy}","received_events_url":"https://api.github.com/users/vobruba-martin/received_events","type":"User","site_admin":false},"repo":{"id":46872188,"name":"closure-compiler","full_name":"vobruba-martin/closure-compiler","owner":{"login":"vobruba-martin","id":6897988,"avatar_url":"https://avatars.githubusercontent.com/u/6897988?v=3","gravatar_id":"","url":"https://api.github.com/users/vobruba-martin","html_url":"https://github.com/vobruba-martin","followers_url":"https://api.github.com/users/vobruba-martin/followers","following_url":"https://api.github.com/users/vobruba-martin/following{/other_user}","gists_url":"https://api.github.com/users/vobruba-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/vobruba-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vobruba-martin/subscriptions","organizations_url":"https://api.github.com/users/vobruba-martin/orgs","repos_url":"https://api.github.com/users/vobruba-martin/repos","events_url":"https://api.github.com/users/vobruba-martin/events{/privacy}","received_events_url":"https://api.github.com/users/vobruba-martin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vobruba-martin/closure-compiler","description":"A JavaScript checker and optimizer.","fork":true,"url":"https://api.github.com/repos/vobruba-martin/closure-compiler","forks_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/forks","keys_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/teams","hooks_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/events","assignees_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/tags","blobs_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/languages","stargazers_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/subscription","commits_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/merges","archive_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/downloads","issues_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/releases{/id}","deployments_url":"https://api.github.com/repos/vobruba-martin/closure-compiler/deployments","created_at":"2015-11-25T16:06:38Z","updated_at":"2016-01-12T21:42:59Z","pushed_at":"2016-08-30T06:00:03Z","git_url":"git://github.com/vobruba-martin/closure-compiler.git","ssh_url":"git@github.com:vobruba-martin/closure-compiler.git","clone_url":"https://github.com/vobruba-martin/closure-compiler.git","svn_url":"https://github.com/vobruba-martin/closure-compiler","homepage":" https://developers.google.com/closure/compiler/","size":111551,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"05846a2161ecdc2c0572b6ea7feca321d7944076","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":18845024,"name":"closure-compiler","full_name":"google/closure-compiler","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/closure-compiler","description":"A JavaScript checker and optimizer.","fork":false,"url":"https://api.github.com/repos/google/closure-compiler","forks_url":"https://api.github.com/repos/google/closure-compiler/forks","keys_url":"https://api.github.com/repos/google/closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/closure-compiler/teams","hooks_url":"https://api.github.com/repos/google/closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/google/closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/google/closure-compiler/events","assignees_url":"https://api.github.com/repos/google/closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/google/closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/google/closure-compiler/tags","blobs_url":"https://api.github.com/repos/google/closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/google/closure-compiler/languages","stargazers_url":"https://api.github.com/repos/google/closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/google/closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/google/closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/google/closure-compiler/subscription","commits_url":"https://api.github.com/repos/google/closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/google/closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/closure-compiler/merges","archive_url":"https://api.github.com/repos/google/closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/closure-compiler/downloads","issues_url":"https://api.github.com/repos/google/closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/google/closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/google/closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/google/closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/google/closure-compiler/releases{/id}","deployments_url":"https://api.github.com/repos/google/closure-compiler/deployments","created_at":"2014-04-16T15:30:36Z","updated_at":"2016-08-30T15:28:42Z","pushed_at":"2016-08-30T06:00:04Z","git_url":"git://github.com/google/closure-compiler.git","ssh_url":"git@github.com:google/closure-compiler.git","clone_url":"https://github.com/google/closure-compiler.git","svn_url":"https://github.com/google/closure-compiler","homepage":"https://developers.google.com/closure/compiler/","size":122352,"stargazers_count":2543,"watchers_count":2543,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":543,"mirror_url":null,"open_issues_count":543,"forks":543,"open_issues":543,"watchers":2543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1968"},"html":{"href":"https://github.com/google/closure-compiler/pull/1968"},"issue":{"href":"https://api.github.com/repos/google/closure-compiler/issues/1968"},"comments":{"href":"https://api.github.com/repos/google/closure-compiler/issues/1968/comments"},"review_comments":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1968/comments"},"review_comment":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1968/commits"},"statuses":{"href":"https://api.github.com/repos/google/closure-compiler/statuses/7097feb89d11941b1b360c04bc558de61f4ad716"}}}}
{"actor":{"display_login":"vobruba-martin"}}