{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/37546","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/37546/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/37546/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/37546/events","html_url":"https://github.com/rust-lang/rust/issues/37546","id":186958858,"number":37546,"title":"Implement `Default` for `std::time::Duration`","user":{"login":"luser","id":286001,"avatar_url":"https://avatars.githubusercontent.com/u/286001?v=3","gravatar_id":"","url":"https://api.github.com/users/luser","html_url":"https://github.com/luser","followers_url":"https://api.github.com/users/luser/followers","following_url":"https://api.github.com/users/luser/following{/other_user}","gists_url":"https://api.github.com/users/luser/gists{/gist_id}","starred_url":"https://api.github.com/users/luser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luser/subscriptions","organizations_url":"https://api.github.com/users/luser/orgs","repos_url":"https://api.github.com/users/luser/repos","events_url":"https://api.github.com/users/luser/events{/privacy}","received_events_url":"https://api.github.com/users/luser/received_events","type":"User","site_admin":false},"labels":[{"id":36955,"url":"https://api.github.com/repos/rust-lang/rust/labels/A-libs","name":"A-libs","color":"d7e102","default":false},{"id":211668062,"url":"https://api.github.com/repos/rust-lang/rust/labels/T-libs","name":"T-libs","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-11-03T01:00:59Z","updated_at":"2016-11-06T23:29:11Z","closed_at":null,"body":"`Duration` doesn't implement `Default`. I found this out because I had a struct with `#[derive(Default)]` and I tried to add a `Duration` member to it, and that no longer worked. This means that I'd have to manually implement `Default`, which stinks because the struct has quite a few members. It seems like we could give `Duration` an implementation that just returns a zero-length `Duration`."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/258719871","html_url":"https://github.com/rust-lang/rust/issues/37546#issuecomment-258719871","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/37546","id":258719871,"user":{"login":"aturon","id":709807,"avatar_url":"https://avatars.githubusercontent.com/u/709807?v=3","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"created_at":"2016-11-06T23:29:11Z","updated_at":"2016-11-06T23:29:11Z","body":"@luser Thanks, makes perfect sense! \r\n\r\nTLDR: a good reason for a default duration is accumulation, and zero is the right starting point. And I can't really see any way in which this is a footgun (as we all keep saying, zero's the only value that could make sense anyway). So :+1:.\r\n\r\nHowever, given that there was some contention about this before, I'm going to run this change by the full libs team for approval:\r\n\r\n@rfcbot fcp merge"}}
{"actor":{"display_login":"aturon"}}