{"action":"created","issue":{"url":"https://api.github.com/repos/junit-team/junit5/issues/116","labels_url":"https://api.github.com/repos/junit-team/junit5/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/junit-team/junit5/issues/116/comments","events_url":"https://api.github.com/repos/junit-team/junit5/issues/116/events","html_url":"https://github.com/junit-team/junit5/issues/116","id":126862556,"number":116,"title":"Provide better names for the test plan specification","user":{"login":"bechte","id":453673,"avatar_url":"https://avatars.githubusercontent.com/u/453673?v=3","gravatar_id":"","url":"https://api.github.com/users/bechte","html_url":"https://github.com/bechte","followers_url":"https://api.github.com/users/bechte/followers","following_url":"https://api.github.com/users/bechte/following{/other_user}","gists_url":"https://api.github.com/users/bechte/gists{/gist_id}","starred_url":"https://api.github.com/users/bechte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bechte/subscriptions","organizations_url":"https://api.github.com/users/bechte/orgs","repos_url":"https://api.github.com/users/bechte/repos","events_url":"https://api.github.com/users/bechte/events{/privacy}","received_events_url":"https://api.github.com/users/bechte/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/junit-team/junit5/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"bechte","id":453673,"avatar_url":"https://avatars.githubusercontent.com/u/453673?v=3","gravatar_id":"","url":"https://api.github.com/users/bechte","html_url":"https://github.com/bechte","followers_url":"https://api.github.com/users/bechte/followers","following_url":"https://api.github.com/users/bechte/following{/other_user}","gists_url":"https://api.github.com/users/bechte/gists{/gist_id}","starred_url":"https://api.github.com/users/bechte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bechte/subscriptions","organizations_url":"https://api.github.com/users/bechte/orgs","repos_url":"https://api.github.com/users/bechte/repos","events_url":"https://api.github.com/users/bechte/events{/privacy}","received_events_url":"https://api.github.com/users/bechte/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-01-15T12:20:31Z","updated_at":"2016-01-16T18:07:02Z","closed_at":null,"body":"## Status Quo\r\n\r\nThe names `TestPlanSpecification`, `EngineFilter` and `DescriptionFilter` do not communicate their intent very well and should be changed.\r\n\r\n## Deliverables\r\nRenaming:\r\n- [x] Rename class `TestPlanSpecification` to `DiscoveryRequest`\r\n- [x] Rename class `TestPlanSpecificationElement` to `DiscoverySelector`\r\n- [x] Rename class `TestPlanSpecificationElementVisitor` to `DiscoverySelectorVisitor`\r\n- [x] Rename class `TestPlanSpecification` to `DiscoveryRequest`\r\n- [x] Rename filter classes\r\n\r\nChanges:\r\n- [x] create class `FilterResult` based on `ConditionEvaluationResult`\r\n- [x] extract generic interface `GenericFIlter<T>` providing a method `FilterResult filter(T object);`\r\n- [x] let `EngineIdFilter`, `DiscoveryFilter`, and `PostDiscoveryFilter` extend it.\r\n- [x] let the `Launcher` execute the `EngineIdFilter`\r\n\r\nOptional:\r\n- [ ] Remove the specification DSL if possible from the codebase (saving it to a feature branch)\r\n- [ ] move `EngineIdFilter` & `PostDiscoveryFilter` to `junit-launcher-api`\r\n- [ ] make `DiscoveryRequest` immutable and implement `Serializable`\r\n"},"comment":{"url":"https://api.github.com/repos/junit-team/junit5/issues/comments/172238799","html_url":"https://github.com/junit-team/junit5/issues/116#issuecomment-172238799","issue_url":"https://api.github.com/repos/junit-team/junit5/issues/116","id":172238799,"user":{"login":"bechte","id":453673,"avatar_url":"https://avatars.githubusercontent.com/u/453673?v=3","gravatar_id":"","url":"https://api.github.com/users/bechte","html_url":"https://github.com/bechte","followers_url":"https://api.github.com/users/bechte/followers","following_url":"https://api.github.com/users/bechte/following{/other_user}","gists_url":"https://api.github.com/users/bechte/gists{/gist_id}","starred_url":"https://api.github.com/users/bechte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bechte/subscriptions","organizations_url":"https://api.github.com/users/bechte/orgs","repos_url":"https://api.github.com/users/bechte/repos","events_url":"https://api.github.com/users/bechte/events{/privacy}","received_events_url":"https://api.github.com/users/bechte/received_events","type":"User","site_admin":false},"created_at":"2016-01-16T18:07:02Z","updated_at":"2016-01-16T18:07:02Z","body":"Changes have been pushed to feature branch 'feature-116-providenewnames'.\r\n\r\nI will need to rebase it onto master, but don't have time right now. Still, I wanted to provide it to you guys for review purposes. Therefore, I've already created a pull request: #119"}}