{"action":"created","comment":{"url":"https://api.github.com/repos/borgbackup/borg/pulls/comments/79235590","id":79235590,"diff_hunk":"@@ -1322,6 +1322,8 @@ def build_parser(self, prog=None):\n                                   help='set umask to M (local and remote, default: %(default)04o)')\n         common_group.add_argument('--remote-path', dest='remote_path', metavar='PATH',\n                                   help='set remote path to executable (default: \"borg\")')\n+        common_group.add_argument('--remote-ratelimit', dest='remote_ratelimit', type=int, metavar='rate',\n+                                  help='set remote network rate limit in kbyte/s (default: unlimited)')","path":"src/borg/archiver.py","position":5,"original_position":5,"commit_id":"1d5ddf16326254b482b786c5269bdec56af783b8","original_commit_id":"1d5ddf16326254b482b786c5269bdec56af783b8","user":{"login":"textshell","id":6579711,"avatar_url":"https://avatars.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false},"body":"yes, i should either document that or implement limiting for the other side too. I tend to just document it for now. Because i believe one of the main use cases is asymmetrical (slow) lines and it’s not too clear what would be what users want here. Also i expect the main use case where the user is not actively waiting for borg to be the create case.","created_at":"2016-09-16T19:27:10Z","updated_at":"2016-09-16T19:27:10Z","html_url":"https://github.com/borgbackup/borg/pull/1604#discussion_r79235590","pull_request_url":"https://api.github.com/repos/borgbackup/borg/pulls/1604","_links":{"self":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/comments/79235590"},"html":{"href":"https://github.com/borgbackup/borg/pull/1604#discussion_r79235590"},"pull_request":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1604"}}},"pull_request":{"url":"https://api.github.com/repos/borgbackup/borg/pulls/1604","id":85472510,"html_url":"https://github.com/borgbackup/borg/pull/1604","diff_url":"https://github.com/borgbackup/borg/pull/1604.diff","patch_url":"https://github.com/borgbackup/borg/pull/1604.patch","issue_url":"https://api.github.com/repos/borgbackup/borg/issues/1604","number":1604,"state":"open","locked":false,"title":"Add --remote-ratelimit","user":{"login":"textshell","id":6579711,"avatar_url":"https://avatars.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false},"body":"The --remote-ratelimit option adds a very simple rate limit for the\r\nsending data to the remote.\r\n\r\nCurrently implemented by sleeping if the transmission speed is greater\r\nthan the limit.","created_at":"2016-09-15T20:16:54Z","updated_at":"2016-09-16T19:27:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe904fa834076c31ff2e76b68e50d1985681a930","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/borgbackup/borg/pulls/1604/commits","review_comments_url":"https://api.github.com/repos/borgbackup/borg/pulls/1604/comments","review_comment_url":"https://api.github.com/repos/borgbackup/borg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/borgbackup/borg/issues/1604/comments","statuses_url":"https://api.github.com/repos/borgbackup/borg/statuses/1d5ddf16326254b482b786c5269bdec56af783b8","head":{"label":"textshell:feature/remote-ratelimit","ref":"feature/remote-ratelimit","sha":"1d5ddf16326254b482b786c5269bdec56af783b8","user":{"login":"textshell","id":6579711,"avatar_url":"https://avatars.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false},"repo":{"id":64159641,"name":"borg","full_name":"textshell/borg","owner":{"login":"textshell","id":6579711,"avatar_url":"https://avatars.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/textshell/borg","description":"Deduplicating backup program with compression and authenticated encryption.","fork":true,"url":"https://api.github.com/repos/textshell/borg","forks_url":"https://api.github.com/repos/textshell/borg/forks","keys_url":"https://api.github.com/repos/textshell/borg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/textshell/borg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/textshell/borg/teams","hooks_url":"https://api.github.com/repos/textshell/borg/hooks","issue_events_url":"https://api.github.com/repos/textshell/borg/issues/events{/number}","events_url":"https://api.github.com/repos/textshell/borg/events","assignees_url":"https://api.github.com/repos/textshell/borg/assignees{/user}","branches_url":"https://api.github.com/repos/textshell/borg/branches{/branch}","tags_url":"https://api.github.com/repos/textshell/borg/tags","blobs_url":"https://api.github.com/repos/textshell/borg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/textshell/borg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/textshell/borg/git/refs{/sha}","trees_url":"https://api.github.com/repos/textshell/borg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/textshell/borg/statuses/{sha}","languages_url":"https://api.github.com/repos/textshell/borg/languages","stargazers_url":"https://api.github.com/repos/textshell/borg/stargazers","contributors_url":"https://api.github.com/repos/textshell/borg/contributors","subscribers_url":"https://api.github.com/repos/textshell/borg/subscribers","subscription_url":"https://api.github.com/repos/textshell/borg/subscription","commits_url":"https://api.github.com/repos/textshell/borg/commits{/sha}","git_commits_url":"https://api.github.com/repos/textshell/borg/git/commits{/sha}","comments_url":"https://api.github.com/repos/textshell/borg/comments{/number}","issue_comment_url":"https://api.github.com/repos/textshell/borg/issues/comments{/number}","contents_url":"https://api.github.com/repos/textshell/borg/contents/{+path}","compare_url":"https://api.github.com/repos/textshell/borg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/textshell/borg/merges","archive_url":"https://api.github.com/repos/textshell/borg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/textshell/borg/downloads","issues_url":"https://api.github.com/repos/textshell/borg/issues{/number}","pulls_url":"https://api.github.com/repos/textshell/borg/pulls{/number}","milestones_url":"https://api.github.com/repos/textshell/borg/milestones{/number}","notifications_url":"https://api.github.com/repos/textshell/borg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/textshell/borg/labels{/name}","releases_url":"https://api.github.com/repos/textshell/borg/releases{/id}","deployments_url":"https://api.github.com/repos/textshell/borg/deployments","created_at":"2016-07-25T18:46:52Z","updated_at":"2016-07-25T18:46:53Z","pushed_at":"2016-09-15T21:24:43Z","git_url":"git://github.com/textshell/borg.git","ssh_url":"git@github.com:textshell/borg.git","clone_url":"https://github.com/textshell/borg.git","svn_url":"https://github.com/textshell/borg","homepage":"https://borgbackup.readthedocs.io/","size":5583,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"borgbackup:master","ref":"master","sha":"783d01f62101a75efadc12ec4550a66cdedc6adb","user":{"login":"borgbackup","id":12418060,"avatar_url":"https://avatars.githubusercontent.com/u/12418060?v=3","gravatar_id":"","url":"https://api.github.com/users/borgbackup","html_url":"https://github.com/borgbackup","followers_url":"https://api.github.com/users/borgbackup/followers","following_url":"https://api.github.com/users/borgbackup/following{/other_user}","gists_url":"https://api.github.com/users/borgbackup/gists{/gist_id}","starred_url":"https://api.github.com/users/borgbackup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borgbackup/subscriptions","organizations_url":"https://api.github.com/users/borgbackup/orgs","repos_url":"https://api.github.com/users/borgbackup/repos","events_url":"https://api.github.com/users/borgbackup/events{/privacy}","received_events_url":"https://api.github.com/users/borgbackup/received_events","type":"Organization","site_admin":false},"repo":{"id":35517126,"name":"borg","full_name":"borgbackup/borg","owner":{"login":"borgbackup","id":12418060,"avatar_url":"https://avatars.githubusercontent.com/u/12418060?v=3","gravatar_id":"","url":"https://api.github.com/users/borgbackup","html_url":"https://github.com/borgbackup","followers_url":"https://api.github.com/users/borgbackup/followers","following_url":"https://api.github.com/users/borgbackup/following{/other_user}","gists_url":"https://api.github.com/users/borgbackup/gists{/gist_id}","starred_url":"https://api.github.com/users/borgbackup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borgbackup/subscriptions","organizations_url":"https://api.github.com/users/borgbackup/orgs","repos_url":"https://api.github.com/users/borgbackup/repos","events_url":"https://api.github.com/users/borgbackup/events{/privacy}","received_events_url":"https://api.github.com/users/borgbackup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/borgbackup/borg","description":"Deduplicating backup program with compression and authenticated encryption.","fork":false,"url":"https://api.github.com/repos/borgbackup/borg","forks_url":"https://api.github.com/repos/borgbackup/borg/forks","keys_url":"https://api.github.com/repos/borgbackup/borg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borgbackup/borg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borgbackup/borg/teams","hooks_url":"https://api.github.com/repos/borgbackup/borg/hooks","issue_events_url":"https://api.github.com/repos/borgbackup/borg/issues/events{/number}","events_url":"https://api.github.com/repos/borgbackup/borg/events","assignees_url":"https://api.github.com/repos/borgbackup/borg/assignees{/user}","branches_url":"https://api.github.com/repos/borgbackup/borg/branches{/branch}","tags_url":"https://api.github.com/repos/borgbackup/borg/tags","blobs_url":"https://api.github.com/repos/borgbackup/borg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borgbackup/borg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borgbackup/borg/git/refs{/sha}","trees_url":"https://api.github.com/repos/borgbackup/borg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borgbackup/borg/statuses/{sha}","languages_url":"https://api.github.com/repos/borgbackup/borg/languages","stargazers_url":"https://api.github.com/repos/borgbackup/borg/stargazers","contributors_url":"https://api.github.com/repos/borgbackup/borg/contributors","subscribers_url":"https://api.github.com/repos/borgbackup/borg/subscribers","subscription_url":"https://api.github.com/repos/borgbackup/borg/subscription","commits_url":"https://api.github.com/repos/borgbackup/borg/commits{/sha}","git_commits_url":"https://api.github.com/repos/borgbackup/borg/git/commits{/sha}","comments_url":"https://api.github.com/repos/borgbackup/borg/comments{/number}","issue_comment_url":"https://api.github.com/repos/borgbackup/borg/issues/comments{/number}","contents_url":"https://api.github.com/repos/borgbackup/borg/contents/{+path}","compare_url":"https://api.github.com/repos/borgbackup/borg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borgbackup/borg/merges","archive_url":"https://api.github.com/repos/borgbackup/borg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borgbackup/borg/downloads","issues_url":"https://api.github.com/repos/borgbackup/borg/issues{/number}","pulls_url":"https://api.github.com/repos/borgbackup/borg/pulls{/number}","milestones_url":"https://api.github.com/repos/borgbackup/borg/milestones{/number}","notifications_url":"https://api.github.com/repos/borgbackup/borg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borgbackup/borg/labels{/name}","releases_url":"https://api.github.com/repos/borgbackup/borg/releases{/id}","deployments_url":"https://api.github.com/repos/borgbackup/borg/deployments","created_at":"2015-05-12T23:10:47Z","updated_at":"2016-09-16T16:17:02Z","pushed_at":"2016-09-16T18:31:34Z","git_url":"git://github.com/borgbackup/borg.git","ssh_url":"git@github.com:borgbackup/borg.git","clone_url":"https://github.com/borgbackup/borg.git","svn_url":"https://github.com/borgbackup/borg","homepage":"https://borgbackup.readthedocs.io/","size":6602,"stargazers_count":1496,"watchers_count":1496,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":214,"forks":140,"open_issues":214,"watchers":1496,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1604"},"html":{"href":"https://github.com/borgbackup/borg/pull/1604"},"issue":{"href":"https://api.github.com/repos/borgbackup/borg/issues/1604"},"comments":{"href":"https://api.github.com/repos/borgbackup/borg/issues/1604/comments"},"review_comments":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1604/comments"},"review_comment":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1604/commits"},"statuses":{"href":"https://api.github.com/repos/borgbackup/borg/statuses/1d5ddf16326254b482b786c5269bdec56af783b8"}}}}
{"actor":{"display_login":"textshell"}}