{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/49718813","id":49718813,"diff_hunk":"@@ -183,4 +183,21 @@ def self.stringify_symbols(o)\n       o\n     end\n   end\n+\n+  def self.deep_clone(o)\n+    case o\n+    when Hash\n+      o.inject({}) {|h, (k,v)| h[k] = deep_clone(v); h }\n+    when Array\n+      o.map {|v| deep_clone(v) }\n+    when Fixnum, Symbol, IO, TrueClass, FalseClass, NilClass\n+      o\n+    when LogStash::Codecs::Base\n+      o.clone","path":"logstash-core/lib/logstash/util.rb","position":null,"original_position":14,"commit_id":"91d23d8b6622018bb84cbd632b51be4577e60ce9","original_commit_id":"10dcddc351111a710f1022c2922915301c2c202d","user":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"body":"seeing what clone is doing for codecs, makes  sense for me. \r\n\r\n@guyboertje calling register makes sense too.","created_at":"2016-01-14T12:13:16Z","updated_at":"2016-01-14T12:13:16Z","html_url":"https://github.com/elastic/logstash/pull/4473#discussion_r49718813","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/4473","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/49718813"},"html":{"href":"https://github.com/elastic/logstash/pull/4473#discussion_r49718813"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/4473"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/4473","id":55907241,"html_url":"https://github.com/elastic/logstash/pull/4473","diff_url":"https://github.com/elastic/logstash/pull/4473.diff","patch_url":"https://github.com/elastic/logstash/pull/4473.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/4473","number":4473,"state":"open","locked":false,"title":"Fix no. 2 for 4444: Too verbose deprecations warnings","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"body":"Better method of ensuring that args are not mutated by plugin initialize.\r\n\r\nNOTE:\r\n- I had to introduce `LogStash::Util.deep_clone` as `Marshal.load(Marshal.dump(o))` does not work directly on args because there is logger instance in args and Marshal can't dump IO.\r\n- I had to alter all the codec, filter, input and output base.rb `initialize` to deep_clone params, as well as the plugin.rb `initialize` to do `config_init(@params)`.","created_at":"2016-01-13T14:56:10Z","updated_at":"2016-01-14T12:13:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2a04b7a534f0431ec14d8dfeafeb569450da1f0","assignee":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/4473/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/4473/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/4473/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/91d23d8b6622018bb84cbd632b51be4577e60ce9","head":{"label":"guyboertje:fix/4444a","ref":"fix/4444a","sha":"91d23d8b6622018bb84cbd632b51be4577e60ce9","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"repo":{"id":44548170,"name":"logstash","full_name":"guyboertje/logstash","owner":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guyboertje/logstash","description":"logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/guyboertje/logstash","forks_url":"https://api.github.com/repos/guyboertje/logstash/forks","keys_url":"https://api.github.com/repos/guyboertje/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guyboertje/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guyboertje/logstash/teams","hooks_url":"https://api.github.com/repos/guyboertje/logstash/hooks","issue_events_url":"https://api.github.com/repos/guyboertje/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/guyboertje/logstash/events","assignees_url":"https://api.github.com/repos/guyboertje/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/guyboertje/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/guyboertje/logstash/tags","blobs_url":"https://api.github.com/repos/guyboertje/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guyboertje/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guyboertje/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/guyboertje/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guyboertje/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/guyboertje/logstash/languages","stargazers_url":"https://api.github.com/repos/guyboertje/logstash/stargazers","contributors_url":"https://api.github.com/repos/guyboertje/logstash/contributors","subscribers_url":"https://api.github.com/repos/guyboertje/logstash/subscribers","subscription_url":"https://api.github.com/repos/guyboertje/logstash/subscription","commits_url":"https://api.github.com/repos/guyboertje/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/guyboertje/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/guyboertje/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/guyboertje/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/guyboertje/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/guyboertje/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guyboertje/logstash/merges","archive_url":"https://api.github.com/repos/guyboertje/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guyboertje/logstash/downloads","issues_url":"https://api.github.com/repos/guyboertje/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/guyboertje/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/guyboertje/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/guyboertje/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guyboertje/logstash/labels{/name}","releases_url":"https://api.github.com/repos/guyboertje/logstash/releases{/id}","created_at":"2015-10-19T16:26:52Z","updated_at":"2016-01-12T15:34:23Z","pushed_at":"2016-01-14T09:45:00Z","git_url":"git://github.com/guyboertje/logstash.git","ssh_url":"git@github.com:guyboertje/logstash.git","clone_url":"https://github.com/guyboertje/logstash.git","svn_url":"https://github.com/guyboertje/logstash","homepage":"https://www.elastic.co/products/logstash","size":73951,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"69ca10a9d2472132851078d8a463cb68a8110d45","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","created_at":"2010-11-18T01:31:50Z","updated_at":"2016-01-14T09:27:14Z","pushed_at":"2016-01-14T09:45:01Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":78782,"stargazers_count":5279,"watchers_count":5279,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1672,"mirror_url":null,"open_issues_count":698,"forks":1672,"open_issues":698,"watchers":5279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/4473"},"html":{"href":"https://github.com/elastic/logstash/pull/4473"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/4473"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/4473/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/4473/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/4473/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/91d23d8b6622018bb84cbd632b51be4577e60ce9"}}}}