{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4033","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4033/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4033/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4033/events","html_url":"https://github.com/RobotLocomotion/drake/pull/4033","id":187459787,"number":4033,"title":"Error controlled integrator","user":{"login":"edrumwri","id":2224335,"avatar_url":"https://avatars.githubusercontent.com/u/2224335?v=3","gravatar_id":"","url":"https://api.github.com/users/edrumwri","html_url":"https://github.com/edrumwri","followers_url":"https://api.github.com/users/edrumwri/followers","following_url":"https://api.github.com/users/edrumwri/following{/other_user}","gists_url":"https://api.github.com/users/edrumwri/gists{/gist_id}","starred_url":"https://api.github.com/users/edrumwri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edrumwri/subscriptions","organizations_url":"https://api.github.com/users/edrumwri/orgs","repos_url":"https://api.github.com/users/edrumwri/repos","events_url":"https://api.github.com/users/edrumwri/events{/privacy}","received_events_url":"https://api.github.com/users/edrumwri/received_events","type":"User","site_admin":false},"labels":[{"id":470891318,"url":"https://api.github.com/repos/RobotLocomotion/drake/labels/status:%20curate%20commits%20before%20merging","name":"status: curate commits before merging","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":{"login":"david-german-tri","id":17437069,"avatar_url":"https://avatars.githubusercontent.com/u/17437069?v=3","gravatar_id":"","url":"https://api.github.com/users/david-german-tri","html_url":"https://github.com/david-german-tri","followers_url":"https://api.github.com/users/david-german-tri/followers","following_url":"https://api.github.com/users/david-german-tri/following{/other_user}","gists_url":"https://api.github.com/users/david-german-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/david-german-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-german-tri/subscriptions","organizations_url":"https://api.github.com/users/david-german-tri/orgs","repos_url":"https://api.github.com/users/david-german-tri/repos","events_url":"https://api.github.com/users/david-german-tri/events{/privacy}","received_events_url":"https://api.github.com/users/david-german-tri/received_events","type":"User","site_admin":false},"assignees":[{"login":"sherm1","id":4088016,"avatar_url":"https://avatars.githubusercontent.com/u/4088016?v=3","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},{"login":"david-german-tri","id":17437069,"avatar_url":"https://avatars.githubusercontent.com/u/17437069?v=3","gravatar_id":"","url":"https://api.github.com/users/david-german-tri","html_url":"https://github.com/david-german-tri","followers_url":"https://api.github.com/users/david-german-tri/followers","following_url":"https://api.github.com/users/david-german-tri/following{/other_user}","gists_url":"https://api.github.com/users/david-german-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/david-german-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-german-tri/subscriptions","organizations_url":"https://api.github.com/users/david-german-tri/orgs","repos_url":"https://api.github.com/users/david-german-tri/repos","events_url":"https://api.github.com/users/david-german-tri/events{/privacy}","received_events_url":"https://api.github.com/users/david-german-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":20,"created_at":"2016-11-04T23:31:41Z","updated_at":"2016-11-11T01:54:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/4033","html_url":"https://github.com/RobotLocomotion/drake/pull/4033","diff_url":"https://github.com/RobotLocomotion/drake/pull/4033.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/4033.patch"},"body":"This PR introduces error-controlled integrators to drake. It's a reconstituted version of PR #3876, for which the modifications to the System class were removed and submitted (and already merged) as a separate PR.\n\n<!-- Reviewable:start -->\n\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/4033)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/259861082","html_url":"https://github.com/RobotLocomotion/drake/pull/4033#issuecomment-259861082","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4033","id":259861082,"user":{"login":"david-german-tri","id":17437069,"avatar_url":"https://avatars.githubusercontent.com/u/17437069?v=3","gravatar_id":"","url":"https://api.github.com/users/david-german-tri","html_url":"https://github.com/david-german-tri","followers_url":"https://api.github.com/users/david-german-tri/followers","following_url":"https://api.github.com/users/david-german-tri/following{/other_user}","gists_url":"https://api.github.com/users/david-german-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/david-german-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-german-tri/subscriptions","organizations_url":"https://api.github.com/users/david-german-tri/orgs","repos_url":"https://api.github.com/users/david-german-tri/repos","events_url":"https://api.github.com/users/david-german-tri/events{/privacy}","received_events_url":"https://api.github.com/users/david-german-tri/received_events","type":"User","site_admin":false},"created_at":"2016-11-11T01:54:39Z","updated_at":"2016-11-11T01:54:39Z","body":"\n\n\n\nReview status: 11 of 12 files reviewed at latest revision, 10 unresolved discussions.\n\n---\n\n*[drake/systems/analysis/test/runge_kutta3_integrator_test.cc, line 178 at r8](https://reviewable.io:443/reviews/robotlocomotion/drake/4033#-KWFAGdHjAhVIPWc9B7n:-KWG4Yjrf0NLViPDwTmQ:brw3j6j) ([raw file](https://github.com/robotlocomotion/drake/blob/f244b2f0a7c2ea804f35d30709e27cc64e602c86/drake/systems/analysis/test/runge_kutta3_integrator_test.cc#L178)):*\n<details><summary><i>Previously, edrumwri (Evan Drumwright) wrote…</i></summary>\n> The error estimation capability is being stressed elsewhere. It's achieving faster performance for the same level of accuracy as we're getting out of the non-error estimated version (run the SpringMassTest and compare performance against the SpringMassECTest). Assessing correctness of error estimation beyond _that_ is a not inconsiderable task.\n</details>\nStressed, fine, but not asserted?  I'm not questioning whether your code works _now_.  I'm questioning whether, when I ignorantly break this awesome new feature in a future PR, a test will fail to let me know I broke it.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/4033)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"david-german-tri"}}