{"action":"created","comment":{"url":"https://api.github.com/repos/randombit/botan/pulls/comments/65094905","id":65094905,"diff_hunk":"@@ -61,15 +61,15 @@ Session_Keys::Session_Keys(const Handshake_State* state,\n          salt += state->server_hello()->random();\n          }\n \n-      m_master_sec = prf->derive_key(48, pre_master_secret, salt);\n+      m_master_sec = prf->derive_key(48, pre_master_secret, salt, secure_vector<byte>());","path":"src/lib/tls/tls_session_key.cpp","position":5,"original_position":5,"commit_id":"57a3f3272c96a83c5c87c36761caee83982be498","original_commit_id":"57a3f3272c96a83c5c87c36761caee83982be498","user":{"login":"flanfly","id":5614769,"avatar_url":"https://avatars.githubusercontent.com/u/5614769?v=3","gravatar_id":"","url":"https://api.github.com/users/flanfly","html_url":"https://github.com/flanfly","followers_url":"https://api.github.com/users/flanfly/followers","following_url":"https://api.github.com/users/flanfly/following{/other_user}","gists_url":"https://api.github.com/users/flanfly/gists{/gist_id}","starred_url":"https://api.github.com/users/flanfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flanfly/subscriptions","organizations_url":"https://api.github.com/users/flanfly/orgs","repos_url":"https://api.github.com/users/flanfly/repos","events_url":"https://api.github.com/users/flanfly/events{/privacy}","received_events_url":"https://api.github.com/users/flanfly/received_events","type":"User","site_admin":false},"body":"I agree.","created_at":"2016-05-30T17:32:12Z","updated_at":"2016-05-30T17:32:12Z","html_url":"https://github.com/randombit/botan/pull/495#discussion_r65094905","pull_request_url":"https://api.github.com/repos/randombit/botan/pulls/495","_links":{"self":{"href":"https://api.github.com/repos/randombit/botan/pulls/comments/65094905"},"html":{"href":"https://github.com/randombit/botan/pull/495#discussion_r65094905"},"pull_request":{"href":"https://api.github.com/repos/randombit/botan/pulls/495"}}},"pull_request":{"url":"https://api.github.com/repos/randombit/botan/pulls/495","id":70698625,"html_url":"https://github.com/randombit/botan/pull/495","diff_url":"https://github.com/randombit/botan/pull/495.diff","patch_url":"https://github.com/randombit/botan/pull/495.patch","issue_url":"https://api.github.com/repos/randombit/botan/issues/495","number":495,"state":"open","locked":false,"title":"Allow labels for KDF::derive_key, finish SP800-108","user":{"login":"flanfly","id":5614769,"avatar_url":"https://avatars.githubusercontent.com/u/5614769?v=3","gravatar_id":"","url":"https://api.github.com/users/flanfly","html_url":"https://github.com/flanfly","followers_url":"https://api.github.com/users/flanfly/followers","following_url":"https://api.github.com/users/flanfly/following{/other_user}","gists_url":"https://api.github.com/users/flanfly/gists{/gist_id}","starred_url":"https://api.github.com/users/flanfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flanfly/subscriptions","organizations_url":"https://api.github.com/users/flanfly/orgs","repos_url":"https://api.github.com/users/flanfly/repos","events_url":"https://api.github.com/users/flanfly/events{/privacy}","received_events_url":"https://api.github.com/users/flanfly/received_events","type":"User","site_admin":false},"body":"This PR adds a `label` argument to the `derive_key` function. Labels are used in the SP800-108 and 56c KDFs. This allows the implementation of SP800-108 to be completed. See #481 and #476 ","created_at":"2016-05-19T13:58:01Z","updated_at":"2016-05-30T17:32:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcfa64065691699a732bb3e28062cf273de6420f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/randombit/botan/pulls/495/commits","review_comments_url":"https://api.github.com/repos/randombit/botan/pulls/495/comments","review_comment_url":"https://api.github.com/repos/randombit/botan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/randombit/botan/issues/495/comments","statuses_url":"https://api.github.com/repos/randombit/botan/statuses/57a3f3272c96a83c5c87c36761caee83982be498","head":{"label":"Sirrix-AG:kdf-label","ref":"kdf-label","sha":"57a3f3272c96a83c5c87c36761caee83982be498","user":{"login":"Sirrix-AG","id":8842680,"avatar_url":"https://avatars.githubusercontent.com/u/8842680?v=3","gravatar_id":"","url":"https://api.github.com/users/Sirrix-AG","html_url":"https://github.com/Sirrix-AG","followers_url":"https://api.github.com/users/Sirrix-AG/followers","following_url":"https://api.github.com/users/Sirrix-AG/following{/other_user}","gists_url":"https://api.github.com/users/Sirrix-AG/gists{/gist_id}","starred_url":"https://api.github.com/users/Sirrix-AG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sirrix-AG/subscriptions","organizations_url":"https://api.github.com/users/Sirrix-AG/orgs","repos_url":"https://api.github.com/users/Sirrix-AG/repos","events_url":"https://api.github.com/users/Sirrix-AG/events{/privacy}","received_events_url":"https://api.github.com/users/Sirrix-AG/received_events","type":"Organization","site_admin":false},"repo":{"id":52816996,"name":"botan","full_name":"Sirrix-AG/botan","owner":{"login":"Sirrix-AG","id":8842680,"avatar_url":"https://avatars.githubusercontent.com/u/8842680?v=3","gravatar_id":"","url":"https://api.github.com/users/Sirrix-AG","html_url":"https://github.com/Sirrix-AG","followers_url":"https://api.github.com/users/Sirrix-AG/followers","following_url":"https://api.github.com/users/Sirrix-AG/following{/other_user}","gists_url":"https://api.github.com/users/Sirrix-AG/gists{/gist_id}","starred_url":"https://api.github.com/users/Sirrix-AG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sirrix-AG/subscriptions","organizations_url":"https://api.github.com/users/Sirrix-AG/orgs","repos_url":"https://api.github.com/users/Sirrix-AG/repos","events_url":"https://api.github.com/users/Sirrix-AG/events{/privacy}","received_events_url":"https://api.github.com/users/Sirrix-AG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sirrix-AG/botan","description":"Crypto and TLS for C++11","fork":true,"url":"https://api.github.com/repos/Sirrix-AG/botan","forks_url":"https://api.github.com/repos/Sirrix-AG/botan/forks","keys_url":"https://api.github.com/repos/Sirrix-AG/botan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sirrix-AG/botan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sirrix-AG/botan/teams","hooks_url":"https://api.github.com/repos/Sirrix-AG/botan/hooks","issue_events_url":"https://api.github.com/repos/Sirrix-AG/botan/issues/events{/number}","events_url":"https://api.github.com/repos/Sirrix-AG/botan/events","assignees_url":"https://api.github.com/repos/Sirrix-AG/botan/assignees{/user}","branches_url":"https://api.github.com/repos/Sirrix-AG/botan/branches{/branch}","tags_url":"https://api.github.com/repos/Sirrix-AG/botan/tags","blobs_url":"https://api.github.com/repos/Sirrix-AG/botan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sirrix-AG/botan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sirrix-AG/botan/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sirrix-AG/botan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sirrix-AG/botan/statuses/{sha}","languages_url":"https://api.github.com/repos/Sirrix-AG/botan/languages","stargazers_url":"https://api.github.com/repos/Sirrix-AG/botan/stargazers","contributors_url":"https://api.github.com/repos/Sirrix-AG/botan/contributors","subscribers_url":"https://api.github.com/repos/Sirrix-AG/botan/subscribers","subscription_url":"https://api.github.com/repos/Sirrix-AG/botan/subscription","commits_url":"https://api.github.com/repos/Sirrix-AG/botan/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sirrix-AG/botan/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sirrix-AG/botan/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sirrix-AG/botan/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sirrix-AG/botan/contents/{+path}","compare_url":"https://api.github.com/repos/Sirrix-AG/botan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sirrix-AG/botan/merges","archive_url":"https://api.github.com/repos/Sirrix-AG/botan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sirrix-AG/botan/downloads","issues_url":"https://api.github.com/repos/Sirrix-AG/botan/issues{/number}","pulls_url":"https://api.github.com/repos/Sirrix-AG/botan/pulls{/number}","milestones_url":"https://api.github.com/repos/Sirrix-AG/botan/milestones{/number}","notifications_url":"https://api.github.com/repos/Sirrix-AG/botan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sirrix-AG/botan/labels{/name}","releases_url":"https://api.github.com/repos/Sirrix-AG/botan/releases{/id}","deployments_url":"https://api.github.com/repos/Sirrix-AG/botan/deployments","created_at":"2016-02-29T19:22:51Z","updated_at":"2016-02-29T19:22:55Z","pushed_at":"2016-05-19T13:50:27Z","git_url":"git://github.com/Sirrix-AG/botan.git","ssh_url":"git@github.com:Sirrix-AG/botan.git","clone_url":"https://github.com/Sirrix-AG/botan.git","svn_url":"https://github.com/Sirrix-AG/botan","homepage":"http://botan.randombit.net","size":51632,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"randombit:master","ref":"master","sha":"8578e0fc758b81d176d0c5092417f4cc77676895","user":{"login":"randombit","id":469092,"avatar_url":"https://avatars.githubusercontent.com/u/469092?v=3","gravatar_id":"","url":"https://api.github.com/users/randombit","html_url":"https://github.com/randombit","followers_url":"https://api.github.com/users/randombit/followers","following_url":"https://api.github.com/users/randombit/following{/other_user}","gists_url":"https://api.github.com/users/randombit/gists{/gist_id}","starred_url":"https://api.github.com/users/randombit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randombit/subscriptions","organizations_url":"https://api.github.com/users/randombit/orgs","repos_url":"https://api.github.com/users/randombit/repos","events_url":"https://api.github.com/users/randombit/events{/privacy}","received_events_url":"https://api.github.com/users/randombit/received_events","type":"User","site_admin":false},"repo":{"id":8608254,"name":"botan","full_name":"randombit/botan","owner":{"login":"randombit","id":469092,"avatar_url":"https://avatars.githubusercontent.com/u/469092?v=3","gravatar_id":"","url":"https://api.github.com/users/randombit","html_url":"https://github.com/randombit","followers_url":"https://api.github.com/users/randombit/followers","following_url":"https://api.github.com/users/randombit/following{/other_user}","gists_url":"https://api.github.com/users/randombit/gists{/gist_id}","starred_url":"https://api.github.com/users/randombit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randombit/subscriptions","organizations_url":"https://api.github.com/users/randombit/orgs","repos_url":"https://api.github.com/users/randombit/repos","events_url":"https://api.github.com/users/randombit/events{/privacy}","received_events_url":"https://api.github.com/users/randombit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/randombit/botan","description":"Crypto and TLS for C++11","fork":false,"url":"https://api.github.com/repos/randombit/botan","forks_url":"https://api.github.com/repos/randombit/botan/forks","keys_url":"https://api.github.com/repos/randombit/botan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/randombit/botan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/randombit/botan/teams","hooks_url":"https://api.github.com/repos/randombit/botan/hooks","issue_events_url":"https://api.github.com/repos/randombit/botan/issues/events{/number}","events_url":"https://api.github.com/repos/randombit/botan/events","assignees_url":"https://api.github.com/repos/randombit/botan/assignees{/user}","branches_url":"https://api.github.com/repos/randombit/botan/branches{/branch}","tags_url":"https://api.github.com/repos/randombit/botan/tags","blobs_url":"https://api.github.com/repos/randombit/botan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/randombit/botan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/randombit/botan/git/refs{/sha}","trees_url":"https://api.github.com/repos/randombit/botan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/randombit/botan/statuses/{sha}","languages_url":"https://api.github.com/repos/randombit/botan/languages","stargazers_url":"https://api.github.com/repos/randombit/botan/stargazers","contributors_url":"https://api.github.com/repos/randombit/botan/contributors","subscribers_url":"https://api.github.com/repos/randombit/botan/subscribers","subscription_url":"https://api.github.com/repos/randombit/botan/subscription","commits_url":"https://api.github.com/repos/randombit/botan/commits{/sha}","git_commits_url":"https://api.github.com/repos/randombit/botan/git/commits{/sha}","comments_url":"https://api.github.com/repos/randombit/botan/comments{/number}","issue_comment_url":"https://api.github.com/repos/randombit/botan/issues/comments{/number}","contents_url":"https://api.github.com/repos/randombit/botan/contents/{+path}","compare_url":"https://api.github.com/repos/randombit/botan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/randombit/botan/merges","archive_url":"https://api.github.com/repos/randombit/botan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/randombit/botan/downloads","issues_url":"https://api.github.com/repos/randombit/botan/issues{/number}","pulls_url":"https://api.github.com/repos/randombit/botan/pulls{/number}","milestones_url":"https://api.github.com/repos/randombit/botan/milestones{/number}","notifications_url":"https://api.github.com/repos/randombit/botan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/randombit/botan/labels{/name}","releases_url":"https://api.github.com/repos/randombit/botan/releases{/id}","deployments_url":"https://api.github.com/repos/randombit/botan/deployments","created_at":"2013-03-06T16:51:39Z","updated_at":"2016-05-28T13:34:45Z","pushed_at":"2016-05-30T10:58:42Z","git_url":"git://github.com/randombit/botan.git","ssh_url":"git@github.com:randombit/botan.git","clone_url":"https://github.com/randombit/botan.git","svn_url":"https://github.com/randombit/botan","homepage":"http://botan.randombit.net","size":62806,"stargazers_count":278,"watchers_count":278,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":65,"forks":85,"open_issues":65,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/randombit/botan/pulls/495"},"html":{"href":"https://github.com/randombit/botan/pull/495"},"issue":{"href":"https://api.github.com/repos/randombit/botan/issues/495"},"comments":{"href":"https://api.github.com/repos/randombit/botan/issues/495/comments"},"review_comments":{"href":"https://api.github.com/repos/randombit/botan/pulls/495/comments"},"review_comment":{"href":"https://api.github.com/repos/randombit/botan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/randombit/botan/pulls/495/commits"},"statuses":{"href":"https://api.github.com/repos/randombit/botan/statuses/57a3f3272c96a83c5c87c36761caee83982be498"}}}}
{"actor":{"display_login":"flanfly"}}