{"action":"created","comment":{"url":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/comments/92066494","pull_request_review_id":12576138,"id":92066494,"diff_hunk":"@@ -113,3 +113,22 @@ func TestUpsertChangeList(t *testing.T) {\n \t\t}\n \t}\n }\n+\n+var fstest = []string{\n+\t\"\",\n+\t\"a,b\",\n+\t\"a,,a,,c,,\",\n+}\n+\n+func TestFilterSet(t *testing.T) {\n+\tfor _, s := range fstest {\n+\t\tt.Run(s, func(t *testing.T) {\n+\t\t\tvar f Filter\n+\t\t\t_ = f.Set(s)\n+\t\t\tj := strings.Join(f, \",\")\n+\t\t\tif s != j {\n+\t\t\t\tt.Error(j, \" doesn't match\")","path":"mcc/ttl/ttl_test.go","position":18,"original_position":18,"commit_id":"9bf6c3b5c2a6d1d42391b737056d707ad7dcfd2d","original_commit_id":"9bf6c3b5c2a6d1d42391b737056d707ad7dcfd2d","user":{"login":"ifosch","id":2912400,"avatar_url":"https://avatars.githubusercontent.com/u/2912400?v=3","gravatar_id":"","url":"https://api.github.com/users/ifosch","html_url":"https://github.com/ifosch","followers_url":"https://api.github.com/users/ifosch/followers","following_url":"https://api.github.com/users/ifosch/following{/other_user}","gists_url":"https://api.github.com/users/ifosch/gists{/gist_id}","starred_url":"https://api.github.com/users/ifosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifosch/subscriptions","organizations_url":"https://api.github.com/users/ifosch/orgs","repos_url":"https://api.github.com/users/ifosch/repos","events_url":"https://api.github.com/users/ifosch/events{/privacy}","received_events_url":"https://api.github.com/users/ifosch/received_events","type":"User","site_admin":false},"body":"Just for clarity, I might add which is the value not matching with.","created_at":"2016-12-12T23:34:16Z","updated_at":"2016-12-12T23:34:16Z","html_url":"https://github.com/poka-yoke/spaceflight/pull/29#discussion_r92066494","pull_request_url":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/comments/92066494"},"html":{"href":"https://github.com/poka-yoke/spaceflight/pull/29#discussion_r92066494"},"pull_request":{"href":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/29","id":97262826,"html_url":"https://github.com/poka-yoke/spaceflight/pull/29","diff_url":"https://github.com/poka-yoke/spaceflight/pull/29.diff","patch_url":"https://github.com/poka-yoke/spaceflight/pull/29.patch","issue_url":"https://api.github.com/repos/poka-yoke/spaceflight/issues/29","number":29,"state":"open","locked":false,"title":"Add test for Filter","user":{"login":"miguelbernadi","id":731219,"avatar_url":"https://avatars.githubusercontent.com/u/731219?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelbernadi","html_url":"https://github.com/miguelbernadi","followers_url":"https://api.github.com/users/miguelbernadi/followers","following_url":"https://api.github.com/users/miguelbernadi/following{/other_user}","gists_url":"https://api.github.com/users/miguelbernadi/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelbernadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelbernadi/subscriptions","organizations_url":"https://api.github.com/users/miguelbernadi/orgs","repos_url":"https://api.github.com/users/miguelbernadi/repos","events_url":"https://api.github.com/users/miguelbernadi/events{/privacy}","received_events_url":"https://api.github.com/users/miguelbernadi/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-09T07:27:01Z","updated_at":"2016-12-12T23:34:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5817ae7c27295f8f6ea79cdb0cda9e7f7e66b224","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/29/commits","review_comments_url":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/29/comments","review_comment_url":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poka-yoke/spaceflight/issues/29/comments","statuses_url":"https://api.github.com/repos/poka-yoke/spaceflight/statuses/9bf6c3b5c2a6d1d42391b737056d707ad7dcfd2d","head":{"label":"poka-yoke:tests/ttl","ref":"tests/ttl","sha":"9bf6c3b5c2a6d1d42391b737056d707ad7dcfd2d","user":{"login":"poka-yoke","id":20926241,"avatar_url":"https://avatars.githubusercontent.com/u/20926241?v=3","gravatar_id":"","url":"https://api.github.com/users/poka-yoke","html_url":"https://github.com/poka-yoke","followers_url":"https://api.github.com/users/poka-yoke/followers","following_url":"https://api.github.com/users/poka-yoke/following{/other_user}","gists_url":"https://api.github.com/users/poka-yoke/gists{/gist_id}","starred_url":"https://api.github.com/users/poka-yoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poka-yoke/subscriptions","organizations_url":"https://api.github.com/users/poka-yoke/orgs","repos_url":"https://api.github.com/users/poka-yoke/repos","events_url":"https://api.github.com/users/poka-yoke/events{/privacy}","received_events_url":"https://api.github.com/users/poka-yoke/received_events","type":"Organization","site_admin":false},"repo":{"id":70784586,"name":"spaceflight","full_name":"poka-yoke/spaceflight","owner":{"login":"poka-yoke","id":20926241,"avatar_url":"https://avatars.githubusercontent.com/u/20926241?v=3","gravatar_id":"","url":"https://api.github.com/users/poka-yoke","html_url":"https://github.com/poka-yoke","followers_url":"https://api.github.com/users/poka-yoke/followers","following_url":"https://api.github.com/users/poka-yoke/following{/other_user}","gists_url":"https://api.github.com/users/poka-yoke/gists{/gist_id}","starred_url":"https://api.github.com/users/poka-yoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poka-yoke/subscriptions","organizations_url":"https://api.github.com/users/poka-yoke/orgs","repos_url":"https://api.github.com/users/poka-yoke/repos","events_url":"https://api.github.com/users/poka-yoke/events{/privacy}","received_events_url":"https://api.github.com/users/poka-yoke/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poka-yoke/spaceflight","description":null,"fork":false,"url":"https://api.github.com/repos/poka-yoke/spaceflight","forks_url":"https://api.github.com/repos/poka-yoke/spaceflight/forks","keys_url":"https://api.github.com/repos/poka-yoke/spaceflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poka-yoke/spaceflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poka-yoke/spaceflight/teams","hooks_url":"https://api.github.com/repos/poka-yoke/spaceflight/hooks","issue_events_url":"https://api.github.com/repos/poka-yoke/spaceflight/issues/events{/number}","events_url":"https://api.github.com/repos/poka-yoke/spaceflight/events","assignees_url":"https://api.github.com/repos/poka-yoke/spaceflight/assignees{/user}","branches_url":"https://api.github.com/repos/poka-yoke/spaceflight/branches{/branch}","tags_url":"https://api.github.com/repos/poka-yoke/spaceflight/tags","blobs_url":"https://api.github.com/repos/poka-yoke/spaceflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poka-yoke/spaceflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poka-yoke/spaceflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/poka-yoke/spaceflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poka-yoke/spaceflight/statuses/{sha}","languages_url":"https://api.github.com/repos/poka-yoke/spaceflight/languages","stargazers_url":"https://api.github.com/repos/poka-yoke/spaceflight/stargazers","contributors_url":"https://api.github.com/repos/poka-yoke/spaceflight/contributors","subscribers_url":"https://api.github.com/repos/poka-yoke/spaceflight/subscribers","subscription_url":"https://api.github.com/repos/poka-yoke/spaceflight/subscription","commits_url":"https://api.github.com/repos/poka-yoke/spaceflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/poka-yoke/spaceflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/poka-yoke/spaceflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/poka-yoke/spaceflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/poka-yoke/spaceflight/contents/{+path}","compare_url":"https://api.github.com/repos/poka-yoke/spaceflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poka-yoke/spaceflight/merges","archive_url":"https://api.github.com/repos/poka-yoke/spaceflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poka-yoke/spaceflight/downloads","issues_url":"https://api.github.com/repos/poka-yoke/spaceflight/issues{/number}","pulls_url":"https://api.github.com/repos/poka-yoke/spaceflight/pulls{/number}","milestones_url":"https://api.github.com/repos/poka-yoke/spaceflight/milestones{/number}","notifications_url":"https://api.github.com/repos/poka-yoke/spaceflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poka-yoke/spaceflight/labels{/name}","releases_url":"https://api.github.com/repos/poka-yoke/spaceflight/releases{/id}","deployments_url":"https://api.github.com/repos/poka-yoke/spaceflight/deployments","created_at":"2016-10-13T08:18:53Z","updated_at":"2016-11-03T17:54:42Z","pushed_at":"2016-12-09T16:44:22Z","git_url":"git://github.com/poka-yoke/spaceflight.git","ssh_url":"git@github.com:poka-yoke/spaceflight.git","clone_url":"https://github.com/poka-yoke/spaceflight.git","svn_url":"https://github.com/poka-yoke/spaceflight","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"poka-yoke:master","ref":"master","sha":"74133f111ace47ec78e43b607a807d5d086c9f66","user":{"login":"poka-yoke","id":20926241,"avatar_url":"https://avatars.githubusercontent.com/u/20926241?v=3","gravatar_id":"","url":"https://api.github.com/users/poka-yoke","html_url":"https://github.com/poka-yoke","followers_url":"https://api.github.com/users/poka-yoke/followers","following_url":"https://api.github.com/users/poka-yoke/following{/other_user}","gists_url":"https://api.github.com/users/poka-yoke/gists{/gist_id}","starred_url":"https://api.github.com/users/poka-yoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poka-yoke/subscriptions","organizations_url":"https://api.github.com/users/poka-yoke/orgs","repos_url":"https://api.github.com/users/poka-yoke/repos","events_url":"https://api.github.com/users/poka-yoke/events{/privacy}","received_events_url":"https://api.github.com/users/poka-yoke/received_events","type":"Organization","site_admin":false},"repo":{"id":70784586,"name":"spaceflight","full_name":"poka-yoke/spaceflight","owner":{"login":"poka-yoke","id":20926241,"avatar_url":"https://avatars.githubusercontent.com/u/20926241?v=3","gravatar_id":"","url":"https://api.github.com/users/poka-yoke","html_url":"https://github.com/poka-yoke","followers_url":"https://api.github.com/users/poka-yoke/followers","following_url":"https://api.github.com/users/poka-yoke/following{/other_user}","gists_url":"https://api.github.com/users/poka-yoke/gists{/gist_id}","starred_url":"https://api.github.com/users/poka-yoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poka-yoke/subscriptions","organizations_url":"https://api.github.com/users/poka-yoke/orgs","repos_url":"https://api.github.com/users/poka-yoke/repos","events_url":"https://api.github.com/users/poka-yoke/events{/privacy}","received_events_url":"https://api.github.com/users/poka-yoke/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poka-yoke/spaceflight","description":null,"fork":false,"url":"https://api.github.com/repos/poka-yoke/spaceflight","forks_url":"https://api.github.com/repos/poka-yoke/spaceflight/forks","keys_url":"https://api.github.com/repos/poka-yoke/spaceflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poka-yoke/spaceflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poka-yoke/spaceflight/teams","hooks_url":"https://api.github.com/repos/poka-yoke/spaceflight/hooks","issue_events_url":"https://api.github.com/repos/poka-yoke/spaceflight/issues/events{/number}","events_url":"https://api.github.com/repos/poka-yoke/spaceflight/events","assignees_url":"https://api.github.com/repos/poka-yoke/spaceflight/assignees{/user}","branches_url":"https://api.github.com/repos/poka-yoke/spaceflight/branches{/branch}","tags_url":"https://api.github.com/repos/poka-yoke/spaceflight/tags","blobs_url":"https://api.github.com/repos/poka-yoke/spaceflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poka-yoke/spaceflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poka-yoke/spaceflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/poka-yoke/spaceflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poka-yoke/spaceflight/statuses/{sha}","languages_url":"https://api.github.com/repos/poka-yoke/spaceflight/languages","stargazers_url":"https://api.github.com/repos/poka-yoke/spaceflight/stargazers","contributors_url":"https://api.github.com/repos/poka-yoke/spaceflight/contributors","subscribers_url":"https://api.github.com/repos/poka-yoke/spaceflight/subscribers","subscription_url":"https://api.github.com/repos/poka-yoke/spaceflight/subscription","commits_url":"https://api.github.com/repos/poka-yoke/spaceflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/poka-yoke/spaceflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/poka-yoke/spaceflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/poka-yoke/spaceflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/poka-yoke/spaceflight/contents/{+path}","compare_url":"https://api.github.com/repos/poka-yoke/spaceflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poka-yoke/spaceflight/merges","archive_url":"https://api.github.com/repos/poka-yoke/spaceflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poka-yoke/spaceflight/downloads","issues_url":"https://api.github.com/repos/poka-yoke/spaceflight/issues{/number}","pulls_url":"https://api.github.com/repos/poka-yoke/spaceflight/pulls{/number}","milestones_url":"https://api.github.com/repos/poka-yoke/spaceflight/milestones{/number}","notifications_url":"https://api.github.com/repos/poka-yoke/spaceflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poka-yoke/spaceflight/labels{/name}","releases_url":"https://api.github.com/repos/poka-yoke/spaceflight/releases{/id}","deployments_url":"https://api.github.com/repos/poka-yoke/spaceflight/deployments","created_at":"2016-10-13T08:18:53Z","updated_at":"2016-11-03T17:54:42Z","pushed_at":"2016-12-09T16:44:22Z","git_url":"git://github.com/poka-yoke/spaceflight.git","ssh_url":"git@github.com:poka-yoke/spaceflight.git","clone_url":"https://github.com/poka-yoke/spaceflight.git","svn_url":"https://github.com/poka-yoke/spaceflight","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/29"},"html":{"href":"https://github.com/poka-yoke/spaceflight/pull/29"},"issue":{"href":"https://api.github.com/repos/poka-yoke/spaceflight/issues/29"},"comments":{"href":"https://api.github.com/repos/poka-yoke/spaceflight/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poka-yoke/spaceflight/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/poka-yoke/spaceflight/statuses/9bf6c3b5c2a6d1d42391b737056d707ad7dcfd2d"}}}}
{"actor":{"display_login":"ifosch"}}