{"action":"created","comment":{"url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments/69525680","id":69525680,"diff_hunk":"@@ -72,8 +72,13 @@ def load_plugins(self):\n             raise TypeError('Server must be specified')\n         config = pdc_client.read_config_file(server)\n         plugins = DEFAULT_PLUGINS\n-        if config and config[CONFIG_PLUGINS_KEY_NAME]:\n-            plugins = config[CONFIG_PLUGINS_KEY_NAME]\n+        if config:\n+            try:\n+                plugins = config[CONFIG_PLUGINS_KEY_NAME]\n+            except KeyError:\n+                pass\n+        if not isinstance(plugins, list):\n+            raise TypeError('Plugins must be a list')","path":"pdc_client/runner.py","position":12,"original_position":12,"commit_id":"0a62d3248327b70c92f09597039861ebe36985fd","original_commit_id":"0a62d3248327b70c92f09597039861ebe36985fd","user":{"login":"simozhan","id":1744192,"avatar_url":"https://avatars.githubusercontent.com/u/1744192?v=3","gravatar_id":"","url":"https://api.github.com/users/simozhan","html_url":"https://github.com/simozhan","followers_url":"https://api.github.com/users/simozhan/followers","following_url":"https://api.github.com/users/simozhan/following{/other_user}","gists_url":"https://api.github.com/users/simozhan/gists{/gist_id}","starred_url":"https://api.github.com/users/simozhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simozhan/subscriptions","organizations_url":"https://api.github.com/users/simozhan/orgs","repos_url":"https://api.github.com/users/simozhan/repos","events_url":"https://api.github.com/users/simozhan/events{/privacy}","received_events_url":"https://api.github.com/users/simozhan/received_events","type":"User","site_admin":false},"body":"for the json file, it can be a dict, but the setting is \"plugins\": [\"image.py\", \"rpm.py\"...], i think list is the proper format. and for set, it is a python type, i don't know if there is same idea in json. ","created_at":"2016-07-05T08:42:01Z","updated_at":"2016-07-05T08:42:02Z","html_url":"https://github.com/product-definition-center/pdc-client/pull/60#discussion_r69525680","pull_request_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments/69525680"},"html":{"href":"https://github.com/product-definition-center/pdc-client/pull/60#discussion_r69525680"},"pull_request":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/60","id":76232699,"html_url":"https://github.com/product-definition-center/pdc-client/pull/60","diff_url":"https://github.com/product-definition-center/pdc-client/pull/60.diff","patch_url":"https://github.com/product-definition-center/pdc-client/pull/60.patch","issue_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/60","number":60,"state":"open","locked":false,"title":"Fix bugs when no plugins input or wrong input","user":{"login":"simozhan","id":1744192,"avatar_url":"https://avatars.githubusercontent.com/u/1744192?v=3","gravatar_id":"","url":"https://api.github.com/users/simozhan","html_url":"https://github.com/simozhan","followers_url":"https://api.github.com/users/simozhan/followers","following_url":"https://api.github.com/users/simozhan/following{/other_user}","gists_url":"https://api.github.com/users/simozhan/gists{/gist_id}","starred_url":"https://api.github.com/users/simozhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simozhan/subscriptions","organizations_url":"https://api.github.com/users/simozhan/orgs","repos_url":"https://api.github.com/users/simozhan/repos","events_url":"https://api.github.com/users/simozhan/events{/privacy}","received_events_url":"https://api.github.com/users/simozhan/received_events","type":"User","site_admin":false},"body":"JIRA: PDC-1564","created_at":"2016-07-05T08:07:01Z","updated_at":"2016-07-05T08:42:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"545ac2c915d8f50d7c148c8025e7d134170d1829","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/60/commits","review_comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/60/comments","review_comment_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/60/comments","statuses_url":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/0a62d3248327b70c92f09597039861ebe36985fd","head":{"label":"product-definition-center:PDC-1564_minor_bugfix","ref":"PDC-1564_minor_bugfix","sha":"0a62d3248327b70c92f09597039861ebe36985fd","user":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars.githubusercontent.com/u/15812210?v=3","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"repo":{"id":46246883,"name":"pdc-client","full_name":"product-definition-center/pdc-client","owner":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars.githubusercontent.com/u/15812210?v=3","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/product-definition-center/pdc-client","description":"Client for Product Definition Center (PDC) in Python","fork":false,"url":"https://api.github.com/repos/product-definition-center/pdc-client","forks_url":"https://api.github.com/repos/product-definition-center/pdc-client/forks","keys_url":"https://api.github.com/repos/product-definition-center/pdc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/product-definition-center/pdc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/product-definition-center/pdc-client/teams","hooks_url":"https://api.github.com/repos/product-definition-center/pdc-client/hooks","issue_events_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/events{/number}","events_url":"https://api.github.com/repos/product-definition-center/pdc-client/events","assignees_url":"https://api.github.com/repos/product-definition-center/pdc-client/assignees{/user}","branches_url":"https://api.github.com/repos/product-definition-center/pdc-client/branches{/branch}","tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/tags","blobs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/product-definition-center/pdc-client/languages","stargazers_url":"https://api.github.com/repos/product-definition-center/pdc-client/stargazers","contributors_url":"https://api.github.com/repos/product-definition-center/pdc-client/contributors","subscribers_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscribers","subscription_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscription","commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/product-definition-center/pdc-client/contents/{+path}","compare_url":"https://api.github.com/repos/product-definition-center/pdc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/product-definition-center/pdc-client/merges","archive_url":"https://api.github.com/repos/product-definition-center/pdc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/product-definition-center/pdc-client/downloads","issues_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues{/number}","pulls_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/product-definition-center/pdc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/product-definition-center/pdc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/product-definition-center/pdc-client/labels{/name}","releases_url":"https://api.github.com/repos/product-definition-center/pdc-client/releases{/id}","deployments_url":"https://api.github.com/repos/product-definition-center/pdc-client/deployments","created_at":"2015-11-16T02:23:01Z","updated_at":"2016-04-29T08:18:17Z","pushed_at":"2016-07-05T08:07:01Z","git_url":"git://github.com/product-definition-center/pdc-client.git","ssh_url":"git@github.com:product-definition-center/pdc-client.git","clone_url":"https://github.com/product-definition-center/pdc-client.git","svn_url":"https://github.com/product-definition-center/pdc-client","homepage":"","size":459,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"product-definition-center:master","ref":"master","sha":"bfb223e8003bfbfaa96fd95c077b429fdfa4642a","user":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars.githubusercontent.com/u/15812210?v=3","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"repo":{"id":46246883,"name":"pdc-client","full_name":"product-definition-center/pdc-client","owner":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars.githubusercontent.com/u/15812210?v=3","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/product-definition-center/pdc-client","description":"Client for Product Definition Center (PDC) in Python","fork":false,"url":"https://api.github.com/repos/product-definition-center/pdc-client","forks_url":"https://api.github.com/repos/product-definition-center/pdc-client/forks","keys_url":"https://api.github.com/repos/product-definition-center/pdc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/product-definition-center/pdc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/product-definition-center/pdc-client/teams","hooks_url":"https://api.github.com/repos/product-definition-center/pdc-client/hooks","issue_events_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/events{/number}","events_url":"https://api.github.com/repos/product-definition-center/pdc-client/events","assignees_url":"https://api.github.com/repos/product-definition-center/pdc-client/assignees{/user}","branches_url":"https://api.github.com/repos/product-definition-center/pdc-client/branches{/branch}","tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/tags","blobs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/product-definition-center/pdc-client/languages","stargazers_url":"https://api.github.com/repos/product-definition-center/pdc-client/stargazers","contributors_url":"https://api.github.com/repos/product-definition-center/pdc-client/contributors","subscribers_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscribers","subscription_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscription","commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/product-definition-center/pdc-client/contents/{+path}","compare_url":"https://api.github.com/repos/product-definition-center/pdc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/product-definition-center/pdc-client/merges","archive_url":"https://api.github.com/repos/product-definition-center/pdc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/product-definition-center/pdc-client/downloads","issues_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues{/number}","pulls_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/product-definition-center/pdc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/product-definition-center/pdc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/product-definition-center/pdc-client/labels{/name}","releases_url":"https://api.github.com/repos/product-definition-center/pdc-client/releases{/id}","deployments_url":"https://api.github.com/repos/product-definition-center/pdc-client/deployments","created_at":"2015-11-16T02:23:01Z","updated_at":"2016-04-29T08:18:17Z","pushed_at":"2016-07-05T08:07:01Z","git_url":"git://github.com/product-definition-center/pdc-client.git","ssh_url":"git@github.com:product-definition-center/pdc-client.git","clone_url":"https://github.com/product-definition-center/pdc-client.git","svn_url":"https://github.com/product-definition-center/pdc-client","homepage":"","size":459,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/60"},"html":{"href":"https://github.com/product-definition-center/pdc-client/pull/60"},"issue":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/issues/60"},"comments":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/0a62d3248327b70c92f09597039861ebe36985fd"}}}}
{"actor":{"display_login":"simozhan"}}