{"action":"created","issue":{"url":"https://api.github.com/repos/USGS-R/gsplot/issues/402","repository_url":"https://api.github.com/repos/USGS-R/gsplot","labels_url":"https://api.github.com/repos/USGS-R/gsplot/issues/402/labels{/name}","comments_url":"https://api.github.com/repos/USGS-R/gsplot/issues/402/comments","events_url":"https://api.github.com/repos/USGS-R/gsplot/issues/402/events","html_url":"https://github.com/USGS-R/gsplot/pull/402","id":171214419,"number":402,"title":"Config branch...","user":{"login":"ldecicco-USGS","id":1105215,"avatar_url":"https://avatars.githubusercontent.com/u/1105215?v=3","gravatar_id":"","url":"https://api.github.com/users/ldecicco-USGS","html_url":"https://github.com/ldecicco-USGS","followers_url":"https://api.github.com/users/ldecicco-USGS/followers","following_url":"https://api.github.com/users/ldecicco-USGS/following{/other_user}","gists_url":"https://api.github.com/users/ldecicco-USGS/gists{/gist_id}","starred_url":"https://api.github.com/users/ldecicco-USGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldecicco-USGS/subscriptions","organizations_url":"https://api.github.com/users/ldecicco-USGS/orgs","repos_url":"https://api.github.com/users/ldecicco-USGS/repos","events_url":"https://api.github.com/users/ldecicco-USGS/events{/privacy}","received_events_url":"https://api.github.com/users/ldecicco-USGS/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-15T17:06:03Z","updated_at":"2016-08-19T16:56:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/USGS-R/gsplot/pulls/402","html_url":"https://github.com/USGS-R/gsplot/pull/402","diff_url":"https://github.com/USGS-R/gsplot/pull/402.diff","patch_url":"https://github.com/USGS-R/gsplot/pull/402.patch"},"body":"I had been using the dev.off to fix the bleeding par, but that had an unintended consequence when kniting. This PR instead goes back to the original scheme where we'd save the original par in the gsconfig, then reset all of those pars if someone changes the config (either with loadConfig or in the call to the gsplot object). This somewhat alters all the figures because now the background tends to be translucent instead of white. I actually think that's better, but would like to hear more discussion. "},"comment":{"url":"https://api.github.com/repos/USGS-R/gsplot/issues/comments/241073093","html_url":"https://github.com/USGS-R/gsplot/pull/402#issuecomment-241073093","issue_url":"https://api.github.com/repos/USGS-R/gsplot/issues/402","id":241073093,"user":{"login":"lindsaycarr","id":13220910,"avatar_url":"https://avatars.githubusercontent.com/u/13220910?v=3","gravatar_id":"","url":"https://api.github.com/users/lindsaycarr","html_url":"https://github.com/lindsaycarr","followers_url":"https://api.github.com/users/lindsaycarr/followers","following_url":"https://api.github.com/users/lindsaycarr/following{/other_user}","gists_url":"https://api.github.com/users/lindsaycarr/gists{/gist_id}","starred_url":"https://api.github.com/users/lindsaycarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindsaycarr/subscriptions","organizations_url":"https://api.github.com/users/lindsaycarr/orgs","repos_url":"https://api.github.com/users/lindsaycarr/repos","events_url":"https://api.github.com/users/lindsaycarr/events{/privacy}","received_events_url":"https://api.github.com/users/lindsaycarr/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T16:56:33Z","updated_at":"2016-08-19T16:56:33Z","body":"@ldecicco-USGS I'm on your branch (and built/reloaded), but this is still causing an issue. It's like the way legend handles par is messing it up because it looks ok when I exclude `legend.name`. However, not sure why the `axis()` call is being ignored for changing `side.2$lim`.\r\n\r\n```r\r\ng1 <- gsplot() %>% \r\n  lines(1:9, seq(1,3, by=0.25), \r\n        legend.name=\"second line\") %>% \r\n  \r\n  # formatting y axes\r\n  axis(side=2, at=1:10) \r\n\r\nlayout(matrix(1:2, 1, 2))\r\ng1\r\ng1\r\n```\r\n\r\n![image](https://cloud.githubusercontent.com/assets/13220910/17817393/ec8bc46c-6603-11e6-92ae-d3c30051bb8c.png)\r\n"}}
{"actor":{"display_login":"lindsaycarr"}}