{"action":"created","issue":{"url":"https://api.github.com/repos/nottrobin/documentation-builder/issues/3","repository_url":"https://api.github.com/repos/nottrobin/documentation-builder","labels_url":"https://api.github.com/repos/nottrobin/documentation-builder/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/nottrobin/documentation-builder/issues/3/comments","events_url":"https://api.github.com/repos/nottrobin/documentation-builder/issues/3/events","html_url":"https://github.com/nottrobin/documentation-builder/pull/3","id":186363480,"number":3,"title":"Implement breadcrumbs","user":{"login":"nottrobin","id":519935,"avatar_url":"https://avatars.githubusercontent.com/u/519935?v=3","gravatar_id":"","url":"https://api.github.com/users/nottrobin","html_url":"https://github.com/nottrobin","followers_url":"https://api.github.com/users/nottrobin/followers","following_url":"https://api.github.com/users/nottrobin/following{/other_user}","gists_url":"https://api.github.com/users/nottrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/nottrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nottrobin/subscriptions","organizations_url":"https://api.github.com/users/nottrobin/orgs","repos_url":"https://api.github.com/users/nottrobin/repos","events_url":"https://api.github.com/users/nottrobin/events{/privacy}","received_events_url":"https://api.github.com/users/nottrobin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-31T18:40:35Z","updated_at":"2016-11-01T13:50:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nottrobin/documentation-builder/pulls/3","html_url":"https://github.com/nottrobin/documentation-builder/pull/3","diff_url":"https://github.com/nottrobin/documentation-builder/pull/3.diff","patch_url":"https://github.com/nottrobin/documentation-builder/pull/3.patch"},"body":"Traverse the metadata tree to perform two tasks:\r\n\r\n- identify and set the \"active\" item in the navigation tree (replacing the old JavaScript solution)\r\n- build a list of \"breadcrumb\" items - the current active item and all of its parents\r\n\r\nThen pass these items through to the template.\r\n\r\nTests are included - we should still have 100% test coverage.\r\n\r\nQA\r\n---\r\n\r\nFirst run tests:\r\n\r\n``` bash\r\n./setup.py test\r\n```\r\n\r\nLook for `tests/test_operations.py::test_set_active_navigation_items PASSED`, and see that we still have 100% code coverage (100-freaking-percent baby!).\r\n\r\nNow build some documentation:\r\n\r\n``` bash\r\ngit clone -b 1.0.0-structure https://github.com/nottrobin/ubuntu-core-docs.git\r\npip3 install --user --upgrade .  # Install python modules\r\nbin/documentation-builder --base-directory ubuntu-code-docs  # Build the docs\r\nxdg-open build/en/index.html  # Check the built docs\r\n```\r\n\r\nCheck that the breadcrumbs are visible on small screen only and look good.\r\n"},"comment":{"url":"https://api.github.com/repos/nottrobin/documentation-builder/issues/comments/257570946","html_url":"https://github.com/nottrobin/documentation-builder/pull/3#issuecomment-257570946","issue_url":"https://api.github.com/repos/nottrobin/documentation-builder/issues/3","id":257570946,"user":{"login":"nottrobin","id":519935,"avatar_url":"https://avatars.githubusercontent.com/u/519935?v=3","gravatar_id":"","url":"https://api.github.com/users/nottrobin","html_url":"https://github.com/nottrobin","followers_url":"https://api.github.com/users/nottrobin/followers","following_url":"https://api.github.com/users/nottrobin/following{/other_user}","gists_url":"https://api.github.com/users/nottrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/nottrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nottrobin/subscriptions","organizations_url":"https://api.github.com/users/nottrobin/orgs","repos_url":"https://api.github.com/users/nottrobin/repos","events_url":"https://api.github.com/users/nottrobin/events{/privacy}","received_events_url":"https://api.github.com/users/nottrobin/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T13:50:25Z","updated_at":"2016-11-01T13:50:25Z","body":"@WillMoggridge since I'm simply using the [default component](https://docs.vanillaframework.io/patterns/breadcrumbs/) I assume that must be a bug in vanilla-framework. Care to file it [over here](https://github.com/ubuntudesign/vanilla-framework/issues/new)? \r\n\r\nMaybe we should also file it as a bug [in this project](https://github.com/CanonicalLtd/documentation-builder/issues/new) to keep track of it. But apart from that, I don't think this should block this PR."}}
{"actor":{"display_login":"nottrobin"}}