{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments/49976689","id":49976689,"diff_hunk":"@@ -65,6 +66,7 @@ public TraceWebAspect traceWebAspect() {\n \t}\n \n \t@Bean\n+\t@ConditionalOnMissingBean","path":"spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/TraceWebAutoConfiguration.java","position":12,"original_position":12,"commit_id":"2b2496e7a11ca5beb8a2d1d856edd29928c701c8","original_commit_id":"94bd640d343a186b9081bcd124c10b6d1a13ecb4","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"ok will revert to the previous approach cc @spencergibb ","created_at":"2016-01-18T09:35:40Z","updated_at":"2016-01-18T09:35:40Z","html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/115#discussion_r49976689","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments/49976689"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/115#discussion_r49976689"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/115","id":56305153,"html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/115","diff_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/115.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/115.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/115","number":115,"state":"open","locked":false,"title":"Pares down default http tags, but opens apis for adding more","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"Previously, sleuth logged more data than necessary. This led to issues\r\nincluding spans approaching megabytes each. This pares down default keys\r\nto a minimal set, but allows users to opt-into logging more by extending\r\n`TraceFilter`.\r\n\r\nCloses #82\r\nCloses #95 (Obviates)","created_at":"2016-01-18T06:10:27Z","updated_at":"2016-01-18T09:35:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d183e1a079ac83d6b11af51f0410dec0d8e2adeb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/115/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/115/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/115/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/statuses/2b2496e7a11ca5beb8a2d1d856edd29928c701c8","head":{"label":"spring-cloud:pare-down-http","ref":"pare-down-http","sha":"2b2496e7a11ca5beb8a2d1d856edd29928c701c8","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":31788540,"name":"spring-cloud-sleuth","full_name":"spring-cloud/spring-cloud-sleuth","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-sleuth","description":"Distributed tracing for spring cloud","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/releases{/id}","created_at":"2015-03-06T20:51:47Z","updated_at":"2016-01-17T08:04:05Z","pushed_at":"2016-01-18T09:33:31Z","git_url":"git://github.com/spring-cloud/spring-cloud-sleuth.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-sleuth.git","clone_url":"https://github.com/spring-cloud/spring-cloud-sleuth.git","svn_url":"https://github.com/spring-cloud/spring-cloud-sleuth","homepage":"http://cloud.spring.io","size":1841,"stargazers_count":58,"watchers_count":58,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":29,"forks":17,"open_issues":29,"watchers":58,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"483737fdc1f0a2dbfb6eaca372d45610d046a877","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":31788540,"name":"spring-cloud-sleuth","full_name":"spring-cloud/spring-cloud-sleuth","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-sleuth","description":"Distributed tracing for spring cloud","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/releases{/id}","created_at":"2015-03-06T20:51:47Z","updated_at":"2016-01-17T08:04:05Z","pushed_at":"2016-01-18T09:33:31Z","git_url":"git://github.com/spring-cloud/spring-cloud-sleuth.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-sleuth.git","clone_url":"https://github.com/spring-cloud/spring-cloud-sleuth.git","svn_url":"https://github.com/spring-cloud/spring-cloud-sleuth","homepage":"http://cloud.spring.io","size":1841,"stargazers_count":58,"watchers_count":58,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":29,"forks":17,"open_issues":29,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/115"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/115"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/115"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/statuses/2b2496e7a11ca5beb8a2d1d856edd29928c701c8"}}}}