{"action":"opened","number":527,"pull_request":{"url":"https://api.github.com/repos/mavlink/mavros/pulls/527","id":64280382,"html_url":"https://github.com/mavlink/mavros/pull/527","diff_url":"https://github.com/mavlink/mavros/pull/527.diff","patch_url":"https://github.com/mavlink/mavros/pull/527.patch","issue_url":"https://api.github.com/repos/mavlink/mavros/issues/527","number":527,"state":"open","locked":false,"title":"MAVConnSerial: Stop io_service before closing serial device (Fixes #130)","user":{"login":"kartikmohta","id":92570,"avatar_url":"https://avatars.githubusercontent.com/u/92570?v=3","gravatar_id":"","url":"https://api.github.com/users/kartikmohta","html_url":"https://github.com/kartikmohta","followers_url":"https://api.github.com/users/kartikmohta/followers","following_url":"https://api.github.com/users/kartikmohta/following{/other_user}","gists_url":"https://api.github.com/users/kartikmohta/gists{/gist_id}","starred_url":"https://api.github.com/users/kartikmohta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kartikmohta/subscriptions","organizations_url":"https://api.github.com/users/kartikmohta/orgs","repos_url":"https://api.github.com/users/kartikmohta/repos","events_url":"https://api.github.com/users/kartikmohta/events{/privacy}","received_events_url":"https://api.github.com/users/kartikmohta/received_events","type":"User","site_admin":false},"body":"The serial device was closed before calling io_service.stop() so io_service::run() never returned, leading to hang on join in MAVConnSerial::close()\r\n\r\nBacktrace when mavros_node gets SIGINT:\r\n```\r\n#0  0x00007f80217e966b in pthread_join (threadid=140188059690752, thread_return=0x0) at pthread_join.c:92\r\n#1  0x00007f80215602d7 in std::thread::join() ()\r\n#2  0x00007f8020ccc674 in mavconn::MAVConnSerial::close() ()\r\n#3  0x00007f8020ccc6f5 in mavconn::MAVConnSerial::~MAVConnSerial() ()\r\n#4  0x00007f8020cc7b2e in boost::detail::sp_counted_impl_pd<mavconn::MAVConnSerial*, boost::detail::sp_ms_deleter<mavconn::MAVConnSerial> >::dispose() ()\r\n#5  0x000000000040ee0a in boost::detail::sp_counted_base::release() [clone .part.27] [clone .constprop.472] ()\r\n#6  0x000000000041eb22 in mavros::MavRos::~MavRos() ()\r\n#7  0x000000000040eb38 in main ()\r\n```","created_at":"2016-03-28T00:54:32Z","updated_at":"2016-03-28T00:54:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mavlink/mavros/pulls/527/commits","review_comments_url":"https://api.github.com/repos/mavlink/mavros/pulls/527/comments","review_comment_url":"https://api.github.com/repos/mavlink/mavros/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mavlink/mavros/issues/527/comments","statuses_url":"https://api.github.com/repos/mavlink/mavros/statuses/29af3a3c14da0e5b92ebad40b8befa8e0141b63d","head":{"label":"kartikmohta:patch-1","ref":"patch-1","sha":"29af3a3c14da0e5b92ebad40b8befa8e0141b63d","user":{"login":"kartikmohta","id":92570,"avatar_url":"https://avatars.githubusercontent.com/u/92570?v=3","gravatar_id":"","url":"https://api.github.com/users/kartikmohta","html_url":"https://github.com/kartikmohta","followers_url":"https://api.github.com/users/kartikmohta/followers","following_url":"https://api.github.com/users/kartikmohta/following{/other_user}","gists_url":"https://api.github.com/users/kartikmohta/gists{/gist_id}","starred_url":"https://api.github.com/users/kartikmohta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kartikmohta/subscriptions","organizations_url":"https://api.github.com/users/kartikmohta/orgs","repos_url":"https://api.github.com/users/kartikmohta/repos","events_url":"https://api.github.com/users/kartikmohta/events{/privacy}","received_events_url":"https://api.github.com/users/kartikmohta/received_events","type":"User","site_admin":false},"repo":{"id":54854991,"name":"mavros","full_name":"kartikmohta/mavros","owner":{"login":"kartikmohta","id":92570,"avatar_url":"https://avatars.githubusercontent.com/u/92570?v=3","gravatar_id":"","url":"https://api.github.com/users/kartikmohta","html_url":"https://github.com/kartikmohta","followers_url":"https://api.github.com/users/kartikmohta/followers","following_url":"https://api.github.com/users/kartikmohta/following{/other_user}","gists_url":"https://api.github.com/users/kartikmohta/gists{/gist_id}","starred_url":"https://api.github.com/users/kartikmohta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kartikmohta/subscriptions","organizations_url":"https://api.github.com/users/kartikmohta/orgs","repos_url":"https://api.github.com/users/kartikmohta/repos","events_url":"https://api.github.com/users/kartikmohta/events{/privacy}","received_events_url":"https://api.github.com/users/kartikmohta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kartikmohta/mavros","description":"MAVLink to ROS gateway with UDP proxy for Ground Control Station","fork":true,"url":"https://api.github.com/repos/kartikmohta/mavros","forks_url":"https://api.github.com/repos/kartikmohta/mavros/forks","keys_url":"https://api.github.com/repos/kartikmohta/mavros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kartikmohta/mavros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kartikmohta/mavros/teams","hooks_url":"https://api.github.com/repos/kartikmohta/mavros/hooks","issue_events_url":"https://api.github.com/repos/kartikmohta/mavros/issues/events{/number}","events_url":"https://api.github.com/repos/kartikmohta/mavros/events","assignees_url":"https://api.github.com/repos/kartikmohta/mavros/assignees{/user}","branches_url":"https://api.github.com/repos/kartikmohta/mavros/branches{/branch}","tags_url":"https://api.github.com/repos/kartikmohta/mavros/tags","blobs_url":"https://api.github.com/repos/kartikmohta/mavros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kartikmohta/mavros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kartikmohta/mavros/git/refs{/sha}","trees_url":"https://api.github.com/repos/kartikmohta/mavros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kartikmohta/mavros/statuses/{sha}","languages_url":"https://api.github.com/repos/kartikmohta/mavros/languages","stargazers_url":"https://api.github.com/repos/kartikmohta/mavros/stargazers","contributors_url":"https://api.github.com/repos/kartikmohta/mavros/contributors","subscribers_url":"https://api.github.com/repos/kartikmohta/mavros/subscribers","subscription_url":"https://api.github.com/repos/kartikmohta/mavros/subscription","commits_url":"https://api.github.com/repos/kartikmohta/mavros/commits{/sha}","git_commits_url":"https://api.github.com/repos/kartikmohta/mavros/git/commits{/sha}","comments_url":"https://api.github.com/repos/kartikmohta/mavros/comments{/number}","issue_comment_url":"https://api.github.com/repos/kartikmohta/mavros/issues/comments{/number}","contents_url":"https://api.github.com/repos/kartikmohta/mavros/contents/{+path}","compare_url":"https://api.github.com/repos/kartikmohta/mavros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kartikmohta/mavros/merges","archive_url":"https://api.github.com/repos/kartikmohta/mavros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kartikmohta/mavros/downloads","issues_url":"https://api.github.com/repos/kartikmohta/mavros/issues{/number}","pulls_url":"https://api.github.com/repos/kartikmohta/mavros/pulls{/number}","milestones_url":"https://api.github.com/repos/kartikmohta/mavros/milestones{/number}","notifications_url":"https://api.github.com/repos/kartikmohta/mavros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kartikmohta/mavros/labels{/name}","releases_url":"https://api.github.com/repos/kartikmohta/mavros/releases{/id}","deployments_url":"https://api.github.com/repos/kartikmohta/mavros/deployments","created_at":"2016-03-28T00:43:38Z","updated_at":"2016-03-28T00:43:39Z","pushed_at":"2016-03-28T00:53:24Z","git_url":"git://github.com/kartikmohta/mavros.git","ssh_url":"git@github.com:kartikmohta/mavros.git","clone_url":"https://github.com/kartikmohta/mavros.git","svn_url":"https://github.com/kartikmohta/mavros","homepage":null,"size":1838,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mavlink:master","ref":"master","sha":"7b742cfdab5f8af5cef35481e9ce8c214a9a335a","user":{"login":"mavlink","id":961247,"avatar_url":"https://avatars.githubusercontent.com/u/961247?v=3","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"repo":{"id":15189073,"name":"mavros","full_name":"mavlink/mavros","owner":{"login":"mavlink","id":961247,"avatar_url":"https://avatars.githubusercontent.com/u/961247?v=3","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mavlink/mavros","description":"MAVLink to ROS gateway with UDP proxy for Ground Control Station","fork":false,"url":"https://api.github.com/repos/mavlink/mavros","forks_url":"https://api.github.com/repos/mavlink/mavros/forks","keys_url":"https://api.github.com/repos/mavlink/mavros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavlink/mavros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavlink/mavros/teams","hooks_url":"https://api.github.com/repos/mavlink/mavros/hooks","issue_events_url":"https://api.github.com/repos/mavlink/mavros/issues/events{/number}","events_url":"https://api.github.com/repos/mavlink/mavros/events","assignees_url":"https://api.github.com/repos/mavlink/mavros/assignees{/user}","branches_url":"https://api.github.com/repos/mavlink/mavros/branches{/branch}","tags_url":"https://api.github.com/repos/mavlink/mavros/tags","blobs_url":"https://api.github.com/repos/mavlink/mavros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavlink/mavros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavlink/mavros/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavlink/mavros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavlink/mavros/statuses/{sha}","languages_url":"https://api.github.com/repos/mavlink/mavros/languages","stargazers_url":"https://api.github.com/repos/mavlink/mavros/stargazers","contributors_url":"https://api.github.com/repos/mavlink/mavros/contributors","subscribers_url":"https://api.github.com/repos/mavlink/mavros/subscribers","subscription_url":"https://api.github.com/repos/mavlink/mavros/subscription","commits_url":"https://api.github.com/repos/mavlink/mavros/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavlink/mavros/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavlink/mavros/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavlink/mavros/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavlink/mavros/contents/{+path}","compare_url":"https://api.github.com/repos/mavlink/mavros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavlink/mavros/merges","archive_url":"https://api.github.com/repos/mavlink/mavros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavlink/mavros/downloads","issues_url":"https://api.github.com/repos/mavlink/mavros/issues{/number}","pulls_url":"https://api.github.com/repos/mavlink/mavros/pulls{/number}","milestones_url":"https://api.github.com/repos/mavlink/mavros/milestones{/number}","notifications_url":"https://api.github.com/repos/mavlink/mavros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavlink/mavros/labels{/name}","releases_url":"https://api.github.com/repos/mavlink/mavros/releases{/id}","deployments_url":"https://api.github.com/repos/mavlink/mavros/deployments","created_at":"2013-12-14T16:58:11Z","updated_at":"2016-03-07T06:05:58Z","pushed_at":"2016-03-27T09:43:49Z","git_url":"git://github.com/mavlink/mavros.git","ssh_url":"git@github.com:mavlink/mavros.git","clone_url":"https://github.com/mavlink/mavros.git","svn_url":"https://github.com/mavlink/mavros","homepage":null,"size":1932,"stargazers_count":59,"watchers_count":59,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":45,"forks":132,"open_issues":45,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mavlink/mavros/pulls/527"},"html":{"href":"https://github.com/mavlink/mavros/pull/527"},"issue":{"href":"https://api.github.com/repos/mavlink/mavros/issues/527"},"comments":{"href":"https://api.github.com/repos/mavlink/mavros/issues/527/comments"},"review_comments":{"href":"https://api.github.com/repos/mavlink/mavros/pulls/527/comments"},"review_comment":{"href":"https://api.github.com/repos/mavlink/mavros/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mavlink/mavros/pulls/527/commits"},"statuses":{"href":"https://api.github.com/repos/mavlink/mavros/statuses/29af3a3c14da0e5b92ebad40b8befa8e0141b63d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}