{"action":"created","issue":{"url":"https://api.github.com/repos/ARUP-NGS/BMFtools/issues/88","repository_url":"https://api.github.com/repos/ARUP-NGS/BMFtools","labels_url":"https://api.github.com/repos/ARUP-NGS/BMFtools/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/ARUP-NGS/BMFtools/issues/88/comments","events_url":"https://api.github.com/repos/ARUP-NGS/BMFtools/issues/88/events","html_url":"https://github.com/ARUP-NGS/BMFtools/pull/88","id":180132918,"number":88,"title":"Fix ordering of LD flag in Makefile","user":{"login":"brendanofallon","id":425575,"avatar_url":"https://avatars.githubusercontent.com/u/425575?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanofallon","html_url":"https://github.com/brendanofallon","followers_url":"https://api.github.com/users/brendanofallon/followers","following_url":"https://api.github.com/users/brendanofallon/following{/other_user}","gists_url":"https://api.github.com/users/brendanofallon/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanofallon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanofallon/subscriptions","organizations_url":"https://api.github.com/users/brendanofallon/orgs","repos_url":"https://api.github.com/users/brendanofallon/repos","events_url":"https://api.github.com/users/brendanofallon/events{/privacy}","received_events_url":"https://api.github.com/users/brendanofallon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-29T18:56:06Z","updated_at":"2016-09-29T19:40:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ARUP-NGS/BMFtools/pulls/88","html_url":"https://github.com/ARUP-NGS/BMFtools/pull/88","diff_url":"https://github.com/ARUP-NGS/BMFtools/pull/88.diff","patch_url":"https://github.com/ARUP-NGS/BMFtools/pull/88.patch"},"body":" On Ubuntu Xenial (gcc 5.4), BMFTools won't compile unless the LD flags are included after the files, otherwise linker errors otherwise. This PR moves the $(LD) variable in the Makefile to later in the command, allowing successful compilation.  "},"comment":{"url":"https://api.github.com/repos/ARUP-NGS/BMFtools/issues/comments/250569768","html_url":"https://github.com/ARUP-NGS/BMFtools/pull/88#issuecomment-250569768","issue_url":"https://api.github.com/repos/ARUP-NGS/BMFtools/issues/88","id":250569768,"user":{"login":"NoSeatbelts","id":6412885,"avatar_url":"https://avatars.githubusercontent.com/u/6412885?v=3","gravatar_id":"","url":"https://api.github.com/users/NoSeatbelts","html_url":"https://github.com/NoSeatbelts","followers_url":"https://api.github.com/users/NoSeatbelts/followers","following_url":"https://api.github.com/users/NoSeatbelts/following{/other_user}","gists_url":"https://api.github.com/users/NoSeatbelts/gists{/gist_id}","starred_url":"https://api.github.com/users/NoSeatbelts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NoSeatbelts/subscriptions","organizations_url":"https://api.github.com/users/NoSeatbelts/orgs","repos_url":"https://api.github.com/users/NoSeatbelts/repos","events_url":"https://api.github.com/users/NoSeatbelts/events{/privacy}","received_events_url":"https://api.github.com/users/NoSeatbelts/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T19:40:32Z","updated_at":"2016-09-29T19:40:32Z","body":"The change looks good to me and likely explains an error a user on Ubuntu was reporting which I couldn't reproduce on any of 4 servers plus a laptop.\r\n\r\nWe've been only merging into master after running a lot of large-scale and small-scale tests. This should instead go into the dev branch. If master needs to be updated ASAP, we should rerun the rest suite in BMFTest and ensure it passes before incrementing versions and releases."}}
{"actor":{"display_login":"NoSeatbelts"}}