{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/58436697","id":58436697,"diff_hunk":"@@ -37,3 +37,43 @@\n - set_fact:\n     docker_options: \"{{ openshift.docker.options | default(omit) }}\"\n   when: not openshift.docker.hosted_registry_insecure | default(False) | bool\n+\n+# Avoid docker 1.9 when installing origin < 1.2 or OSE < 3.2 on RHEL/Centos and\n+# See: https://bugzilla.redhat.com/show_bug.cgi?id=1304038\n+- name: Set docker defaults\n+  set_fact:\n+    docker_version: ''\n+    docker_downgrade: False\n+    repoquery_cmd: \"{{ 'dnf repoquery --latest-limit 1 -d 0' if ansible_pkg_mgr == 'dnf' else 'repoquery' }}\"","path":"roles/openshift_docker_facts/tasks/main.yml","position":11,"original_position":11,"commit_id":"77c6d961ced1d32c1c1dd344ab24b16a09e31a9e","original_commit_id":"77c6d961ced1d32c1c1dd344ab24b16a09e31a9e","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"repoquery_cmd can be set in vars/main.yml instead of using set_fact.","created_at":"2016-04-04T19:51:57Z","updated_at":"2016-04-04T19:51:57Z","html_url":"https://github.com/openshift/openshift-ansible/pull/1655#discussion_r58436697","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1655","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/58436697"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1655#discussion_r58436697"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1655"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1655","id":63943334,"html_url":"https://github.com/openshift/openshift-ansible/pull/1655","diff_url":"https://github.com/openshift/openshift-ansible/pull/1655.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/1655.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1655","number":1655,"state":"open","locked":false,"title":"Downgrade to docker 1.8.2 if installing < 1.2/3.2","user":{"login":"sdodson","id":48161,"avatar_url":"https://avatars.githubusercontent.com/u/48161?v=3","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"body":"This ignores the situation of Origin by way of only working when version is 3.0 or 3.1. The current version of origin should be fine with docker-1.9.\r\n\r\nI've tested\r\n- [x] Installing 3.1.x without docker installed, you get docker-1.8.2\r\n- [x] Installing 3.1.x with docker-1.9 installed, downgrades to 1.8.2\r\n- [x] Upgrading to 3.2 using playbooks/byo/openshift-cluster/upgrades/...\r\n- [x] Installing 3.2 without docker installed, it installs docker-1.9.1 as that's the latest.\r\n- [x] Installing 3.2 with docker-1.8.2 installed, upgrades to 1.9.1 due to RPM deps\r\n- [x] Installing 3.2 with docker-1.9 installed","created_at":"2016-03-23T19:58:00Z","updated_at":"2016-04-04T19:51:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22f401348604222f1062b8b620d1d7d51316e7e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1655/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1655/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1655/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/77c6d961ced1d32c1c1dd344ab24b16a09e31a9e","head":{"label":"sdodson:more-docker19","ref":"more-docker19","sha":"77c6d961ced1d32c1c1dd344ab24b16a09e31a9e","user":{"login":"sdodson","id":48161,"avatar_url":"https://avatars.githubusercontent.com/u/48161?v=3","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"repo":{"id":32589211,"name":"openshift-ansible","full_name":"sdodson/openshift-ansible","owner":{"login":"sdodson","id":48161,"avatar_url":"https://avatars.githubusercontent.com/u/48161?v=3","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdodson/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/sdodson/openshift-ansible","forks_url":"https://api.github.com/repos/sdodson/openshift-ansible/forks","keys_url":"https://api.github.com/repos/sdodson/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdodson/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdodson/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/sdodson/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/sdodson/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/sdodson/openshift-ansible/events","assignees_url":"https://api.github.com/repos/sdodson/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/sdodson/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/sdodson/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdodson/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/sdodson/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/sdodson/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/sdodson/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/sdodson/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/sdodson/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/sdodson/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdodson/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdodson/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdodson/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/sdodson/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdodson/openshift-ansible/merges","archive_url":"https://api.github.com/repos/sdodson/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdodson/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/sdodson/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/sdodson/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/sdodson/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/sdodson/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdodson/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/sdodson/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/sdodson/openshift-ansible/deployments","created_at":"2015-03-20T14:44:06Z","updated_at":"2015-05-01T15:04:21Z","pushed_at":"2016-04-04T19:45:19Z","git_url":"git://github.com/sdodson/openshift-ansible.git","ssh_url":"git@github.com:sdodson/openshift-ansible.git","clone_url":"https://github.com/sdodson/openshift-ansible.git","svn_url":"https://github.com/sdodson/openshift-ansible","homepage":"","size":4152,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"ff86a5d3e4caa6eaba2d77833278998105bd9fd0","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2016-04-04T19:40:25Z","pushed_at":"2016-04-04T19:45:20Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":5569,"stargazers_count":144,"watchers_count":144,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":263,"mirror_url":null,"open_issues_count":277,"forks":263,"open_issues":277,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1655"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1655"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1655"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1655/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1655/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1655/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/77c6d961ced1d32c1c1dd344ab24b16a09e31a9e"}}}}