{"action":"opened","number":70,"pull_request":{"url":"https://api.github.com/repos/shadow-robot/sr_core/pulls/70","id":84715152,"html_url":"https://github.com/shadow-robot/sr_core/pull/70","diff_url":"https://github.com/shadow-robot/sr_core/pull/70.diff","patch_url":"https://github.com/shadow-robot/sr_core/pull/70.patch","issue_url":"https://api.github.com/repos/shadow-robot/sr_core/issues/70","number":70,"state":"open","locked":false,"title":"B#69 clamp correct range","user":{"login":"guihomework","id":6583181,"avatar_url":"https://avatars.githubusercontent.com/u/6583181?v=3","gravatar_id":"","url":"https://api.github.com/users/guihomework","html_url":"https://github.com/guihomework","followers_url":"https://api.github.com/users/guihomework/followers","following_url":"https://api.github.com/users/guihomework/following{/other_user}","gists_url":"https://api.github.com/users/guihomework/gists{/gist_id}","starred_url":"https://api.github.com/users/guihomework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guihomework/subscriptions","organizations_url":"https://api.github.com/users/guihomework/orgs","repos_url":"https://api.github.com/users/guihomework/repos","events_url":"https://api.github.com/users/guihomework/events{/privacy}","received_events_url":"https://api.github.com/users/guihomework/received_events","type":"User","site_admin":false},"body":"_sr_controller_ now extracts and stores all the limits (angle, velocities, effort)\r\n_sr_controller_ provides a generic clamp function with a default implementation for angle (backward compatibility)\r\nvelocity and effort controllers re-implement their own clamp using vel or eff min/max\r\n\r\nsolves #69 \r\n\r\nEffortController had remains with no clamp applied to the input because the effort range is not calibrated (commands are in gauge units currently so do not match URDF values in newtonmeter)\r\n","created_at":"2016-09-09T20:37:35Z","updated_at":"2016-09-09T20:37:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2965b3434c7fba3c0de50d90b6ebeea9b0740dc6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shadow-robot/sr_core/pulls/70/commits","review_comments_url":"https://api.github.com/repos/shadow-robot/sr_core/pulls/70/comments","review_comment_url":"https://api.github.com/repos/shadow-robot/sr_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shadow-robot/sr_core/issues/70/comments","statuses_url":"https://api.github.com/repos/shadow-robot/sr_core/statuses/61f88a57a3b4840f16c5fe43f53e3d439b243f12","head":{"label":"ubi-agni:B#69_clamp_correct_range","ref":"B#69_clamp_correct_range","sha":"61f88a57a3b4840f16c5fe43f53e3d439b243f12","user":{"login":"ubi-agni","id":7883789,"avatar_url":"https://avatars.githubusercontent.com/u/7883789?v=3","gravatar_id":"","url":"https://api.github.com/users/ubi-agni","html_url":"https://github.com/ubi-agni","followers_url":"https://api.github.com/users/ubi-agni/followers","following_url":"https://api.github.com/users/ubi-agni/following{/other_user}","gists_url":"https://api.github.com/users/ubi-agni/gists{/gist_id}","starred_url":"https://api.github.com/users/ubi-agni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubi-agni/subscriptions","organizations_url":"https://api.github.com/users/ubi-agni/orgs","repos_url":"https://api.github.com/users/ubi-agni/repos","events_url":"https://api.github.com/users/ubi-agni/events{/privacy}","received_events_url":"https://api.github.com/users/ubi-agni/received_events","type":"Organization","site_admin":false},"repo":{"id":43505768,"name":"sr_core","full_name":"ubi-agni/sr_core","owner":{"login":"ubi-agni","id":7883789,"avatar_url":"https://avatars.githubusercontent.com/u/7883789?v=3","gravatar_id":"","url":"https://api.github.com/users/ubi-agni","html_url":"https://github.com/ubi-agni","followers_url":"https://api.github.com/users/ubi-agni/followers","following_url":"https://api.github.com/users/ubi-agni/following{/other_user}","gists_url":"https://api.github.com/users/ubi-agni/gists{/gist_id}","starred_url":"https://api.github.com/users/ubi-agni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubi-agni/subscriptions","organizations_url":"https://api.github.com/users/ubi-agni/orgs","repos_url":"https://api.github.com/users/ubi-agni/repos","events_url":"https://api.github.com/users/ubi-agni/events{/privacy}","received_events_url":"https://api.github.com/users/ubi-agni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubi-agni/sr_core","description":"These are the core packages for the Shadow Robot hardware and simulation.","fork":true,"url":"https://api.github.com/repos/ubi-agni/sr_core","forks_url":"https://api.github.com/repos/ubi-agni/sr_core/forks","keys_url":"https://api.github.com/repos/ubi-agni/sr_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubi-agni/sr_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubi-agni/sr_core/teams","hooks_url":"https://api.github.com/repos/ubi-agni/sr_core/hooks","issue_events_url":"https://api.github.com/repos/ubi-agni/sr_core/issues/events{/number}","events_url":"https://api.github.com/repos/ubi-agni/sr_core/events","assignees_url":"https://api.github.com/repos/ubi-agni/sr_core/assignees{/user}","branches_url":"https://api.github.com/repos/ubi-agni/sr_core/branches{/branch}","tags_url":"https://api.github.com/repos/ubi-agni/sr_core/tags","blobs_url":"https://api.github.com/repos/ubi-agni/sr_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubi-agni/sr_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubi-agni/sr_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubi-agni/sr_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubi-agni/sr_core/statuses/{sha}","languages_url":"https://api.github.com/repos/ubi-agni/sr_core/languages","stargazers_url":"https://api.github.com/repos/ubi-agni/sr_core/stargazers","contributors_url":"https://api.github.com/repos/ubi-agni/sr_core/contributors","subscribers_url":"https://api.github.com/repos/ubi-agni/sr_core/subscribers","subscription_url":"https://api.github.com/repos/ubi-agni/sr_core/subscription","commits_url":"https://api.github.com/repos/ubi-agni/sr_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubi-agni/sr_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubi-agni/sr_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubi-agni/sr_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubi-agni/sr_core/contents/{+path}","compare_url":"https://api.github.com/repos/ubi-agni/sr_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubi-agni/sr_core/merges","archive_url":"https://api.github.com/repos/ubi-agni/sr_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubi-agni/sr_core/downloads","issues_url":"https://api.github.com/repos/ubi-agni/sr_core/issues{/number}","pulls_url":"https://api.github.com/repos/ubi-agni/sr_core/pulls{/number}","milestones_url":"https://api.github.com/repos/ubi-agni/sr_core/milestones{/number}","notifications_url":"https://api.github.com/repos/ubi-agni/sr_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubi-agni/sr_core/labels{/name}","releases_url":"https://api.github.com/repos/ubi-agni/sr_core/releases{/id}","deployments_url":"https://api.github.com/repos/ubi-agni/sr_core/deployments","created_at":"2015-10-01T15:53:32Z","updated_at":"2016-02-11T19:53:33Z","pushed_at":"2016-09-09T20:32:36Z","git_url":"git://github.com/ubi-agni/sr_core.git","ssh_url":"git@github.com:ubi-agni/sr_core.git","clone_url":"https://github.com/ubi-agni/sr_core.git","svn_url":"https://github.com/ubi-agni/sr_core","homepage":null,"size":74762,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"indigo-devel"}},"base":{"label":"shadow-robot:indigo-devel","ref":"indigo-devel","sha":"365e200e35975c6368c28060673d8471c01bc11b","user":{"login":"shadow-robot","id":3306493,"avatar_url":"https://avatars.githubusercontent.com/u/3306493?v=3","gravatar_id":"","url":"https://api.github.com/users/shadow-robot","html_url":"https://github.com/shadow-robot","followers_url":"https://api.github.com/users/shadow-robot/followers","following_url":"https://api.github.com/users/shadow-robot/following{/other_user}","gists_url":"https://api.github.com/users/shadow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/shadow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadow-robot/subscriptions","organizations_url":"https://api.github.com/users/shadow-robot/orgs","repos_url":"https://api.github.com/users/shadow-robot/repos","events_url":"https://api.github.com/users/shadow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/shadow-robot/received_events","type":"Organization","site_admin":false},"repo":{"id":41487496,"name":"sr_core","full_name":"shadow-robot/sr_core","owner":{"login":"shadow-robot","id":3306493,"avatar_url":"https://avatars.githubusercontent.com/u/3306493?v=3","gravatar_id":"","url":"https://api.github.com/users/shadow-robot","html_url":"https://github.com/shadow-robot","followers_url":"https://api.github.com/users/shadow-robot/followers","following_url":"https://api.github.com/users/shadow-robot/following{/other_user}","gists_url":"https://api.github.com/users/shadow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/shadow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadow-robot/subscriptions","organizations_url":"https://api.github.com/users/shadow-robot/orgs","repos_url":"https://api.github.com/users/shadow-robot/repos","events_url":"https://api.github.com/users/shadow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/shadow-robot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shadow-robot/sr_core","description":"These are the core packages for the Shadow Robot hardware and simulation.","fork":false,"url":"https://api.github.com/repos/shadow-robot/sr_core","forks_url":"https://api.github.com/repos/shadow-robot/sr_core/forks","keys_url":"https://api.github.com/repos/shadow-robot/sr_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shadow-robot/sr_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shadow-robot/sr_core/teams","hooks_url":"https://api.github.com/repos/shadow-robot/sr_core/hooks","issue_events_url":"https://api.github.com/repos/shadow-robot/sr_core/issues/events{/number}","events_url":"https://api.github.com/repos/shadow-robot/sr_core/events","assignees_url":"https://api.github.com/repos/shadow-robot/sr_core/assignees{/user}","branches_url":"https://api.github.com/repos/shadow-robot/sr_core/branches{/branch}","tags_url":"https://api.github.com/repos/shadow-robot/sr_core/tags","blobs_url":"https://api.github.com/repos/shadow-robot/sr_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shadow-robot/sr_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shadow-robot/sr_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/shadow-robot/sr_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shadow-robot/sr_core/statuses/{sha}","languages_url":"https://api.github.com/repos/shadow-robot/sr_core/languages","stargazers_url":"https://api.github.com/repos/shadow-robot/sr_core/stargazers","contributors_url":"https://api.github.com/repos/shadow-robot/sr_core/contributors","subscribers_url":"https://api.github.com/repos/shadow-robot/sr_core/subscribers","subscription_url":"https://api.github.com/repos/shadow-robot/sr_core/subscription","commits_url":"https://api.github.com/repos/shadow-robot/sr_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/shadow-robot/sr_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/shadow-robot/sr_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/shadow-robot/sr_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/shadow-robot/sr_core/contents/{+path}","compare_url":"https://api.github.com/repos/shadow-robot/sr_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shadow-robot/sr_core/merges","archive_url":"https://api.github.com/repos/shadow-robot/sr_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shadow-robot/sr_core/downloads","issues_url":"https://api.github.com/repos/shadow-robot/sr_core/issues{/number}","pulls_url":"https://api.github.com/repos/shadow-robot/sr_core/pulls{/number}","milestones_url":"https://api.github.com/repos/shadow-robot/sr_core/milestones{/number}","notifications_url":"https://api.github.com/repos/shadow-robot/sr_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shadow-robot/sr_core/labels{/name}","releases_url":"https://api.github.com/repos/shadow-robot/sr_core/releases{/id}","deployments_url":"https://api.github.com/repos/shadow-robot/sr_core/deployments","created_at":"2015-08-27T13:14:34Z","updated_at":"2016-02-12T07:04:30Z","pushed_at":"2016-09-09T20:37:35Z","git_url":"git://github.com/shadow-robot/sr_core.git","ssh_url":"git@github.com:shadow-robot/sr_core.git","clone_url":"https://github.com/shadow-robot/sr_core.git","svn_url":"https://github.com/shadow-robot/sr_core","homepage":null,"size":30991,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":18,"forks":2,"open_issues":18,"watchers":0,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/shadow-robot/sr_core/pulls/70"},"html":{"href":"https://github.com/shadow-robot/sr_core/pull/70"},"issue":{"href":"https://api.github.com/repos/shadow-robot/sr_core/issues/70"},"comments":{"href":"https://api.github.com/repos/shadow-robot/sr_core/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/shadow-robot/sr_core/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/shadow-robot/sr_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shadow-robot/sr_core/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/shadow-robot/sr_core/statuses/61f88a57a3b4840f16c5fe43f53e3d439b243f12"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":62,"deletions":9,"changed_files":6}}
{"actor":{"display_login":"guihomework"}}