{"action":"created","comment":{"url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments/81882912","pull_request_review_id":2830501,"id":81882912,"diff_hunk":"@@ -0,0 +1,12 @@\n+# `cc-shim`\n+\n+`cc-shim` is a process spawned by the runtime per container.The runtime \n+provides the pid of the cc-shim process to containerd-shim on OCI create command.\n+\n+`cc-shim` forwards all signals to the cc-proxy process to be handled by the agent\n+in the VM.\n+\n+TODO:\n+It should also forward any input received from containerd-shim to cc-proxy and \n+forward the stdout/stderr received from the proxy to containerd-shim.","path":"shim/README.md","position":11,"original_position":11,"commit_id":"995d5012a8ecb04f713e2cd02c83a72a7b47fc1a","original_commit_id":"45c6923609a142c013dd6c0f7a5d9d1d3167c585","user":{"login":"jcvenegas","id":20407785,"avatar_url":"https://avatars.githubusercontent.com/u/20407785?v=3","gravatar_id":"","url":"https://api.github.com/users/jcvenegas","html_url":"https://github.com/jcvenegas","followers_url":"https://api.github.com/users/jcvenegas/followers","following_url":"https://api.github.com/users/jcvenegas/following{/other_user}","gists_url":"https://api.github.com/users/jcvenegas/gists{/gist_id}","starred_url":"https://api.github.com/users/jcvenegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcvenegas/subscriptions","organizations_url":"https://api.github.com/users/jcvenegas/orgs","repos_url":"https://api.github.com/users/jcvenegas/repos","events_url":"https://api.github.com/users/jcvenegas/events{/privacy}","received_events_url":"https://api.github.com/users/jcvenegas/received_events","type":"User","site_admin":false},"body":"@dlespiau what is the plan for tty/stdio manage ?\r\ncc-oci-runtime have 3 stdio cases to handle\r\nif ( not config->console ) // not using --console something\r\n        if (detach_mode)\r\n                send io to docker named pipes //send to pipes used by \"docker logs container_id\"\r\n        else if( attach_mode ) // running standalone no console \r\n                send io to console.socket \r\n\r\nelse have config->console // using --console something\r\n        use the console provided to show stdio \r\n","created_at":"2016-10-05T00:39:23Z","updated_at":"2016-10-05T00:39:23Z","html_url":"https://github.com/01org/cc-oci-runtime/pull/310#discussion_r81882912","pull_request_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/310","_links":{"self":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments/81882912"},"html":{"href":"https://github.com/01org/cc-oci-runtime/pull/310#discussion_r81882912"},"pull_request":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/310","id":87568139,"html_url":"https://github.com/01org/cc-oci-runtime/pull/310","diff_url":"https://github.com/01org/cc-oci-runtime/pull/310.diff","patch_url":"https://github.com/01org/cc-oci-runtime/pull/310.patch","issue_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/310","number":310,"state":"open","locked":false,"title":"wip/hyperstart: Initial cc-shim implementation","user":{"login":"amshinde","id":7132811,"avatar_url":"https://avatars.githubusercontent.com/u/7132811?v=3","gravatar_id":"","url":"https://api.github.com/users/amshinde","html_url":"https://github.com/amshinde","followers_url":"https://api.github.com/users/amshinde/followers","following_url":"https://api.github.com/users/amshinde/following{/other_user}","gists_url":"https://api.github.com/users/amshinde/gists{/gist_id}","starred_url":"https://api.github.com/users/amshinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amshinde/subscriptions","organizations_url":"https://api.github.com/users/amshinde/orgs","repos_url":"https://api.github.com/users/amshinde/repos","events_url":"https://api.github.com/users/amshinde/events{/privacy}","received_events_url":"https://api.github.com/users/amshinde/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-30T21:20:27Z","updated_at":"2016-10-05T00:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"amshinde","id":7132811,"avatar_url":"https://avatars.githubusercontent.com/u/7132811?v=3","gravatar_id":"","url":"https://api.github.com/users/amshinde","html_url":"https://github.com/amshinde","followers_url":"https://api.github.com/users/amshinde/followers","following_url":"https://api.github.com/users/amshinde/following{/other_user}","gists_url":"https://api.github.com/users/amshinde/gists{/gist_id}","starred_url":"https://api.github.com/users/amshinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amshinde/subscriptions","organizations_url":"https://api.github.com/users/amshinde/orgs","repos_url":"https://api.github.com/users/amshinde/repos","events_url":"https://api.github.com/users/amshinde/events{/privacy}","received_events_url":"https://api.github.com/users/amshinde/received_events","type":"User","site_admin":false},"assignees":[{"login":"amshinde","id":7132811,"avatar_url":"https://avatars.githubusercontent.com/u/7132811?v=3","gravatar_id":"","url":"https://api.github.com/users/amshinde","html_url":"https://github.com/amshinde","followers_url":"https://api.github.com/users/amshinde/followers","following_url":"https://api.github.com/users/amshinde/following{/other_user}","gists_url":"https://api.github.com/users/amshinde/gists{/gist_id}","starred_url":"https://api.github.com/users/amshinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amshinde/subscriptions","organizations_url":"https://api.github.com/users/amshinde/orgs","repos_url":"https://api.github.com/users/amshinde/repos","events_url":"https://api.github.com/users/amshinde/events{/privacy}","received_events_url":"https://api.github.com/users/amshinde/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/310/commits","review_comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/310/comments","review_comment_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/310/comments","statuses_url":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/995d5012a8ecb04f713e2cd02c83a72a7b47fc1a","head":{"label":"amshinde:re-arch-ccshim2","ref":"re-arch-ccshim2","sha":"995d5012a8ecb04f713e2cd02c83a72a7b47fc1a","user":{"login":"amshinde","id":7132811,"avatar_url":"https://avatars.githubusercontent.com/u/7132811?v=3","gravatar_id":"","url":"https://api.github.com/users/amshinde","html_url":"https://github.com/amshinde","followers_url":"https://api.github.com/users/amshinde/followers","following_url":"https://api.github.com/users/amshinde/following{/other_user}","gists_url":"https://api.github.com/users/amshinde/gists{/gist_id}","starred_url":"https://api.github.com/users/amshinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amshinde/subscriptions","organizations_url":"https://api.github.com/users/amshinde/orgs","repos_url":"https://api.github.com/users/amshinde/repos","events_url":"https://api.github.com/users/amshinde/events{/privacy}","received_events_url":"https://api.github.com/users/amshinde/received_events","type":"User","site_admin":false},"repo":{"id":64413846,"name":"cc-oci-runtime-1","full_name":"amshinde/cc-oci-runtime-1","owner":{"login":"amshinde","id":7132811,"avatar_url":"https://avatars.githubusercontent.com/u/7132811?v=3","gravatar_id":"","url":"https://api.github.com/users/amshinde","html_url":"https://github.com/amshinde","followers_url":"https://api.github.com/users/amshinde/followers","following_url":"https://api.github.com/users/amshinde/following{/other_user}","gists_url":"https://api.github.com/users/amshinde/gists{/gist_id}","starred_url":"https://api.github.com/users/amshinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amshinde/subscriptions","organizations_url":"https://api.github.com/users/amshinde/orgs","repos_url":"https://api.github.com/users/amshinde/repos","events_url":"https://api.github.com/users/amshinde/events{/privacy}","received_events_url":"https://api.github.com/users/amshinde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amshinde/cc-oci-runtime-1","description":"OCI (Open Containers Initiative) compatible runtime","fork":true,"url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1","forks_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/forks","keys_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/teams","hooks_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/hooks","issue_events_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/issues/events{/number}","events_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/events","assignees_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/assignees{/user}","branches_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/branches{/branch}","tags_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/tags","blobs_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/statuses/{sha}","languages_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/languages","stargazers_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/stargazers","contributors_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/contributors","subscribers_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/subscribers","subscription_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/subscription","commits_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/contents/{+path}","compare_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/merges","archive_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/downloads","issues_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/issues{/number}","pulls_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/pulls{/number}","milestones_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/milestones{/number}","notifications_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/labels{/name}","releases_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/releases{/id}","deployments_url":"https://api.github.com/repos/amshinde/cc-oci-runtime-1/deployments","created_at":"2016-07-28T17:09:32Z","updated_at":"2016-07-28T17:09:33Z","pushed_at":"2016-10-04T21:30:06Z","git_url":"git://github.com/amshinde/cc-oci-runtime-1.git","ssh_url":"git@github.com:amshinde/cc-oci-runtime-1.git","clone_url":"https://github.com/amshinde/cc-oci-runtime-1.git","svn_url":"https://github.com/amshinde/cc-oci-runtime-1","homepage":"","size":1028,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:wip/hyperstart","ref":"wip/hyperstart","sha":"08b2a16f271035da080535ad24aa17c75c332d2c","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":62701840,"name":"cc-oci-runtime","full_name":"01org/cc-oci-runtime","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/cc-oci-runtime","description":"OCI (Open Containers Initiative) compatible runtime for Intel® Architecture","fork":false,"url":"https://api.github.com/repos/01org/cc-oci-runtime","forks_url":"https://api.github.com/repos/01org/cc-oci-runtime/forks","keys_url":"https://api.github.com/repos/01org/cc-oci-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/cc-oci-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/cc-oci-runtime/teams","hooks_url":"https://api.github.com/repos/01org/cc-oci-runtime/hooks","issue_events_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/01org/cc-oci-runtime/events","assignees_url":"https://api.github.com/repos/01org/cc-oci-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/01org/cc-oci-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/tags","blobs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/cc-oci-runtime/languages","stargazers_url":"https://api.github.com/repos/01org/cc-oci-runtime/stargazers","contributors_url":"https://api.github.com/repos/01org/cc-oci-runtime/contributors","subscribers_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscribers","subscription_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscription","commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/cc-oci-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/01org/cc-oci-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/cc-oci-runtime/merges","archive_url":"https://api.github.com/repos/01org/cc-oci-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/cc-oci-runtime/downloads","issues_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/cc-oci-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/cc-oci-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/cc-oci-runtime/labels{/name}","releases_url":"https://api.github.com/repos/01org/cc-oci-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/01org/cc-oci-runtime/deployments","created_at":"2016-07-06T07:48:26Z","updated_at":"2016-10-04T10:32:54Z","pushed_at":"2016-10-04T22:13:40Z","git_url":"git://github.com/01org/cc-oci-runtime.git","ssh_url":"git@github.com:01org/cc-oci-runtime.git","clone_url":"https://github.com/01org/cc-oci-runtime.git","svn_url":"https://github.com/01org/cc-oci-runtime","homepage":"","size":1162,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":90,"forks":13,"open_issues":90,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/310"},"html":{"href":"https://github.com/01org/cc-oci-runtime/pull/310"},"issue":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/issues/310"},"comments":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/995d5012a8ecb04f713e2cd02c83a72a7b47fc1a"}}}}
{"actor":{"display_login":"jcvenegas"}}