{"action":"created","issue":{"url":"https://api.github.com/repos/rootselementary/check_in_tool_rails/issues/11","repository_url":"https://api.github.com/repos/rootselementary/check_in_tool_rails","labels_url":"https://api.github.com/repos/rootselementary/check_in_tool_rails/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/rootselementary/check_in_tool_rails/issues/11/comments","events_url":"https://api.github.com/repos/rootselementary/check_in_tool_rails/issues/11/events","html_url":"https://github.com/rootselementary/check_in_tool_rails/pull/11","id":165150124,"number":11,"title":"adds teachers to admin crud functionality","user":{"login":"jedschneider","id":82204,"avatar_url":"https://avatars.githubusercontent.com/u/82204?v=3","gravatar_id":"","url":"https://api.github.com/users/jedschneider","html_url":"https://github.com/jedschneider","followers_url":"https://api.github.com/users/jedschneider/followers","following_url":"https://api.github.com/users/jedschneider/following{/other_user}","gists_url":"https://api.github.com/users/jedschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/jedschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedschneider/subscriptions","organizations_url":"https://api.github.com/users/jedschneider/orgs","repos_url":"https://api.github.com/users/jedschneider/repos","events_url":"https://api.github.com/users/jedschneider/events{/privacy}","received_events_url":"https://api.github.com/users/jedschneider/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-12T18:40:25Z","updated_at":"2016-07-13T14:14:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rootselementary/check_in_tool_rails/pulls/11","html_url":"https://github.com/rootselementary/check_in_tool_rails/pull/11","diff_url":"https://github.com/rootselementary/check_in_tool_rails/pull/11.diff","patch_url":"https://github.com/rootselementary/check_in_tool_rails/pull/11.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/rootselementary/check_in_tool_rails/issues/comments/232368136","html_url":"https://github.com/rootselementary/check_in_tool_rails/pull/11#issuecomment-232368136","issue_url":"https://api.github.com/repos/rootselementary/check_in_tool_rails/issues/11","id":232368136,"user":{"login":"jedschneider","id":82204,"avatar_url":"https://avatars.githubusercontent.com/u/82204?v=3","gravatar_id":"","url":"https://api.github.com/users/jedschneider","html_url":"https://github.com/jedschneider","followers_url":"https://api.github.com/users/jedschneider/followers","following_url":"https://api.github.com/users/jedschneider/following{/other_user}","gists_url":"https://api.github.com/users/jedschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/jedschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedschneider/subscriptions","organizations_url":"https://api.github.com/users/jedschneider/orgs","repos_url":"https://api.github.com/users/jedschneider/repos","events_url":"https://api.github.com/users/jedschneider/events{/privacy}","received_events_url":"https://api.github.com/users/jedschneider/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T14:14:47Z","updated_at":"2016-07-13T14:14:47Z","body":"So in the example of the show? Method in the teacher policy the question is who should be able to view the profile of a teacher? If for example we have things like a phone number or email or birthdate the answer is probably only other teacher or admins within the same school. So I just defaulted to other admins for now but hopefully that helps define the questions you should be asking about access to data. In regards to the student management policy I was just keeping the policies dry to match your concern about duplication. It is more of an interface for concrete policies to inherit from and I have no sting opinion in the name as long as it's accurately named to infer the purpose since ruby doesn't have the true notion of an interface. You could also move to a module and mixin. \n\n> On Jul 12, 2016, at 8:42 PM, Erinna Chen <notifications@github.com> wrote:\n> \n> @jedschneider It feels like we have some semantic disagreements... I would say what you have called teachers is what I would call an admin or a school admin, particularly concerning policies. It seems more intuitive to me:\n> \n> TeacherPolicy (your naming) makes more sense to be AdminPolicy\n> StudentManagementPolicy (your naming) seems like it should be called TeacherPolicy since all teachers will be authorized.\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"jedschneider"}}