{"action":"created","issue":{"url":"https://api.github.com/repos/DoSomething/gambit/issues/518","repository_url":"https://api.github.com/repos/DoSomething/gambit","labels_url":"https://api.github.com/repos/DoSomething/gambit/issues/518/labels{/name}","comments_url":"https://api.github.com/repos/DoSomething/gambit/issues/518/comments","events_url":"https://api.github.com/repos/DoSomething/gambit/issues/518/events","html_url":"https://github.com/DoSomething/gambit/issues/518","id":126906642,"number":518,"title":"Fix NewRelic monitoring","user":{"login":"jonuy","id":696595,"avatar_url":"https://avatars.githubusercontent.com/u/696595?v=3","gravatar_id":"","url":"https://api.github.com/users/jonuy","html_url":"https://github.com/jonuy","followers_url":"https://api.github.com/users/jonuy/followers","following_url":"https://api.github.com/users/jonuy/following{/other_user}","gists_url":"https://api.github.com/users/jonuy/gists{/gist_id}","starred_url":"https://api.github.com/users/jonuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonuy/subscriptions","organizations_url":"https://api.github.com/users/jonuy/orgs","repos_url":"https://api.github.com/users/jonuy/repos","events_url":"https://api.github.com/users/jonuy/events{/privacy}","received_events_url":"https://api.github.com/users/jonuy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DoSomething/gambit/labels/%23infrastructure","name":"#infrastructure","color":"bfdadc"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-01-15T16:28:40Z","updated_at":"2016-08-23T16:46:04Z","closed_at":"2016-08-23T16:46:04Z","body":"*Updated 8/8*\r\n* [x] Get error logging working\r\n\r\n*Updated 7/19 -- next steps per https://github.com/DoSomething/ds-mdata-responder/issues/518#issuecomment-233766089*\r\n* [x] Remove the New Relic add-on\r\n* [x] Remove the custom NR code (require('newrelic');)\r\n* [x] Verify we have no more NR-related log activity\r\n* [x] Re-introduce the newer NR package in code\r\n\r\n*Original description*\r\n\r\nI'm not sure when it stopped, but it seems like we're no longer getting any reporting to our NewRelic account from this app.\r\n\r\nInitially thought that it may be because `require('newrelic')` isn't the first line in [server.js](https://github.com/DoSomething/ds-mdata-responder/blob/dev/server.js#L8) like the NewRelic docs ask for it to be. But that change was done in late 2014 and I'm _pretty_ sure we didn't just go through the entirety of 2015 without getting any NewRelic reporting."},"comment":{"url":"https://api.github.com/repos/DoSomething/gambit/issues/comments/241796944","html_url":"https://github.com/DoSomething/gambit/issues/518#issuecomment-241796944","issue_url":"https://api.github.com/repos/DoSomething/gambit/issues/518","id":241796944,"user":{"login":"aaronschachter","id":1236811,"avatar_url":"https://avatars.githubusercontent.com/u/1236811?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronschachter","html_url":"https://github.com/aaronschachter","followers_url":"https://api.github.com/users/aaronschachter/followers","following_url":"https://api.github.com/users/aaronschachter/following{/other_user}","gists_url":"https://api.github.com/users/aaronschachter/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronschachter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronschachter/subscriptions","organizations_url":"https://api.github.com/users/aaronschachter/orgs","repos_url":"https://api.github.com/users/aaronschachter/repos","events_url":"https://api.github.com/users/aaronschachter/events{/privacy}","received_events_url":"https://api.github.com/users/aaronschachter/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T16:46:04Z","updated_at":"2016-08-23T16:46:04Z","body":"I'm seeing some 403's in our New Relic around the time of yesterday's [deployment](https://github.com/DoSomething/gambit/releases/tag/2.0.0) adding checks for `x-gambit-api-key`, so I think it's safe to close out the last remaining todo for this.\r\n\r\n<img width=\"865\" alt=\"screen shot 2016-08-23 at 9 33 57 am\" src=\"https://cloud.githubusercontent.com/assets/1236811/17900883/f265c756-6915-11e6-9b71-74a3038e2739.png\">\r\n\r\nWhen I've tested with 404 errors, they didn't appear - but that's by default (per New Relic support in our Heroku ticket). \r\n\r\nFor application errors, we can add our own custom events if we want them to appear in new Relic... further progress can be tracked in #562\r\n\r\nRelated reading:\r\n* https://discuss.newrelic.com/t/process-crashing-errors-are-not-being-reported/27765\r\n* https://discuss.newrelic.com/t/how-to-get-notified-about-error-events/31312/4\r\n* http://stackoverflow.com/questions/26964009/detecting-process-crashes-with-new-relic-in-nodejs\r\n"}}
{"actor":{"display_login":"aaronschachter"}}