{"action":"created","comment":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/comments/78939842","id":78939842,"diff_hunk":"@@ -1,29 +1,11 @@\n-# Created by the script cgal_create_cmake_script\n-# This is the CMake script for compiling a CGAL application.\n+project( Triangulation_3_Examples )\n \n-\n-project( Triangulation_3_example )\n-\n-cmake_minimum_required(VERSION 2.8.11)\n+cmake_minimum_required(VERSION 2.8.12)\n \n \n find_package(CGAL QUIET)\n \n if ( CGAL_FOUND )\n-\n-  include( ${CGAL_USE_FILE} )\n-  \n-  find_package( TBB QUIET )\n-\n-  if( TBB_FOUND )\n-    include(${TBB_USE_FILE})\n-    list(APPEND CGAL_3RD_PARTY_LIBRARIES ${TBB_LIBRARIES})\n-  endif()\n-\n-  include( CGAL_CreateSingleSourceCGALProgram )","path":"Triangulation_3/examples/Triangulation_3/CMakeLists.txt","position":25,"original_position":25,"commit_id":"3b2a008c6d154904845ddf0380ddf15e7eb8e496","original_commit_id":"3b2a008c6d154904845ddf0380ddf15e7eb8e496","user":{"login":"cjamin","id":8830802,"avatar_url":"https://avatars.githubusercontent.com/u/8830802?v=3","gravatar_id":"","url":"https://api.github.com/users/cjamin","html_url":"https://github.com/cjamin","followers_url":"https://api.github.com/users/cjamin/followers","following_url":"https://api.github.com/users/cjamin/following{/other_user}","gists_url":"https://api.github.com/users/cjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/cjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjamin/subscriptions","organizations_url":"https://api.github.com/users/cjamin/orgs","repos_url":"https://api.github.com/users/cjamin/repos","events_url":"https://api.github.com/users/cjamin/events{/privacy}","received_events_url":"https://api.github.com/users/cjamin/received_events","type":"User","site_admin":false},"body":"Actually, it is already the case (in both CGALConfig_XXX.cmake.in).","created_at":"2016-09-15T11:14:40Z","updated_at":"2016-09-15T11:14:40Z","html_url":"https://github.com/CGAL/cgal/pull/1436#discussion_r78939842","pull_request_url":"https://api.github.com/repos/CGAL/cgal/pulls/1436","_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments/78939842"},"html":{"href":"https://github.com/CGAL/cgal/pull/1436#discussion_r78939842"},"pull_request":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1436"}}},"pull_request":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/1436","id":84302924,"html_url":"https://github.com/CGAL/cgal/pull/1436","diff_url":"https://github.com/CGAL/cgal/pull/1436.diff","patch_url":"https://github.com/CGAL/cgal/pull/1436.patch","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/1436","number":1436,"state":"open","locked":false,"title":"Renewal of CMake scripts: header-only, ctest, CMake>=2.8.12","user":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"body":"- [ ] The CTest support no longer tries to test demos (should be backported to 4.9).\r\n- [x] The bash script `cgal_create_cmake_script` enables C++14.\r\n- [ ] Document the modification to `cgal_create_cmake_script`\r\n- [x] New feature of `create_single_source_cgal_program` that allows to use C++11/14 features.\r\n- [ ] Document modifications to `create_single_source_cgal_program`\r\n- [x] **The main goal:** Use CMake-2.8.12 new features to renew the configuration of CGAL.\r\n- [x] **The second goal:** header-only step 2 (*pure header only*, without CMake):\r\n  - [x] First implementation done\r\n  - [x] How to generate `<CGAL/compiler_config.h>`?\r\n  - [ ] Handle `make install`\r\n  - [x] Deal with CGAL_Core with GMP disabled\r\n  - [ ] a kind of preconfiguration?\r\n\r\nTODO: not yet finished\r\n","created_at":"2016-09-07T13:45:59Z","updated_at":"2016-09-15T11:14:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a209b2da6e1a6e8d3b8513d93744039560f0b8f","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/CGAL/cgal/milestones/18","html_url":"https://github.com/CGAL/cgal/milestones/4.10-beta","labels_url":"https://api.github.com/repos/CGAL/cgal/milestones/18/labels","id":1878697,"number":18,"title":"4.10-beta","description":"","creator":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"open_issues":111,"closed_issues":2,"state":"open","created_at":"2016-07-12T15:28:34Z","updated_at":"2016-09-14T15:18:43Z","due_on":"2017-01-14T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/CGAL/cgal/pulls/1436/commits","review_comments_url":"https://api.github.com/repos/CGAL/cgal/pulls/1436/comments","review_comment_url":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/1436/comments","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/3b2a008c6d154904845ddf0380ddf15e7eb8e496","head":{"label":"lrineau:CGAL-new_cmake-GF","ref":"CGAL-new_cmake-GF","sha":"3b2a008c6d154904845ddf0380ddf15e7eb8e496","user":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"repo":{"id":33255347,"name":"cgal","full_name":"lrineau/cgal","owner":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lrineau/cgal","description":"The public CGAL repository","fork":true,"url":"https://api.github.com/repos/lrineau/cgal","forks_url":"https://api.github.com/repos/lrineau/cgal/forks","keys_url":"https://api.github.com/repos/lrineau/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lrineau/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lrineau/cgal/teams","hooks_url":"https://api.github.com/repos/lrineau/cgal/hooks","issue_events_url":"https://api.github.com/repos/lrineau/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/lrineau/cgal/events","assignees_url":"https://api.github.com/repos/lrineau/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/lrineau/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/lrineau/cgal/tags","blobs_url":"https://api.github.com/repos/lrineau/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lrineau/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lrineau/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lrineau/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lrineau/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/lrineau/cgal/languages","stargazers_url":"https://api.github.com/repos/lrineau/cgal/stargazers","contributors_url":"https://api.github.com/repos/lrineau/cgal/contributors","subscribers_url":"https://api.github.com/repos/lrineau/cgal/subscribers","subscription_url":"https://api.github.com/repos/lrineau/cgal/subscription","commits_url":"https://api.github.com/repos/lrineau/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lrineau/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lrineau/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lrineau/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lrineau/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/lrineau/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lrineau/cgal/merges","archive_url":"https://api.github.com/repos/lrineau/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lrineau/cgal/downloads","issues_url":"https://api.github.com/repos/lrineau/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/lrineau/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/lrineau/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/lrineau/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lrineau/cgal/labels{/name}","releases_url":"https://api.github.com/repos/lrineau/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/lrineau/cgal/deployments","created_at":"2015-04-01T15:22:57Z","updated_at":"2016-02-17T12:55:18Z","pushed_at":"2016-09-15T10:28:31Z","git_url":"git://github.com/lrineau/cgal.git","ssh_url":"git@github.com:lrineau/cgal.git","clone_url":"https://github.com/lrineau/cgal.git","svn_url":"https://github.com/lrineau/cgal","homepage":"http://www.cgal.org","size":524015,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CGAL:master","ref":"master","sha":"7d3f017ba1a2a89df519dc31a5a50ff45a751697","user":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"repo":{"id":24677392,"name":"cgal","full_name":"CGAL/cgal","owner":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CGAL/cgal","description":"The public CGAL repository, see the README below","fork":false,"url":"https://api.github.com/repos/CGAL/cgal","forks_url":"https://api.github.com/repos/CGAL/cgal/forks","keys_url":"https://api.github.com/repos/CGAL/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CGAL/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CGAL/cgal/teams","hooks_url":"https://api.github.com/repos/CGAL/cgal/hooks","issue_events_url":"https://api.github.com/repos/CGAL/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/CGAL/cgal/events","assignees_url":"https://api.github.com/repos/CGAL/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/CGAL/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/CGAL/cgal/tags","blobs_url":"https://api.github.com/repos/CGAL/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CGAL/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CGAL/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/CGAL/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/CGAL/cgal/languages","stargazers_url":"https://api.github.com/repos/CGAL/cgal/stargazers","contributors_url":"https://api.github.com/repos/CGAL/cgal/contributors","subscribers_url":"https://api.github.com/repos/CGAL/cgal/subscribers","subscription_url":"https://api.github.com/repos/CGAL/cgal/subscription","commits_url":"https://api.github.com/repos/CGAL/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/CGAL/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/CGAL/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/CGAL/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/CGAL/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/CGAL/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CGAL/cgal/merges","archive_url":"https://api.github.com/repos/CGAL/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CGAL/cgal/downloads","issues_url":"https://api.github.com/repos/CGAL/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/CGAL/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/CGAL/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/CGAL/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CGAL/cgal/labels{/name}","releases_url":"https://api.github.com/repos/CGAL/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/CGAL/cgal/deployments","created_at":"2014-10-01T12:22:47Z","updated_at":"2016-09-12T17:00:29Z","pushed_at":"2016-09-15T10:28:32Z","git_url":"git://github.com/CGAL/cgal.git","ssh_url":"git@github.com:CGAL/cgal.git","clone_url":"https://github.com/CGAL/cgal.git","svn_url":"https://github.com/CGAL/cgal","homepage":"https://github.com/CGAL/cgal#readme","size":560375,"stargazers_count":315,"watchers_count":315,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":169,"mirror_url":null,"open_issues_count":209,"forks":169,"open_issues":209,"watchers":315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1436"},"html":{"href":"https://github.com/CGAL/cgal/pull/1436"},"issue":{"href":"https://api.github.com/repos/CGAL/cgal/issues/1436"},"comments":{"href":"https://api.github.com/repos/CGAL/cgal/issues/1436/comments"},"review_comments":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1436/comments"},"review_comment":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1436/commits"},"statuses":{"href":"https://api.github.com/repos/CGAL/cgal/statuses/3b2a008c6d154904845ddf0380ddf15e7eb8e496"}}}}
{"actor":{"display_login":"cjamin"}}