{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/75852003","id":75852003,"diff_hunk":"@@ -78,7 +81,62 @@ class OnSystemRequestNotificationTest\n   MockMessageHelper& message_helper_;\n };\n \n-TEST_F(OnSystemRequestNotificationTest, Run_ProprietaryType_SUCCESS) {\n+#ifdef EXTENDED_POLICY\n+bool CheckHeader(MessageSharedPtr msg) {\n+  struct DataValidator {\n+    bool& is_valid_;\n+    const utils::json::JsonValue& json_data_;\n+\n+    DataValidator(bool& is_valid, const utils::json::JsonValue& data)\n+        : is_valid_(is_valid = true), json_data_(data) {}","path":"src/components/application_manager/test/commands/mobile/on_system_request_notification_test.cc","position":29,"original_position":29,"commit_id":"9faa4733e7c4feae858c959c92172174017958d1","original_commit_id":"9faa4733e7c4feae858c959c92172174017958d1","user":{"login":"vlantonov","id":18260698,"avatar_url":"https://avatars.githubusercontent.com/u/18260698?v=3","gravatar_id":"","url":"https://api.github.com/users/vlantonov","html_url":"https://github.com/vlantonov","followers_url":"https://api.github.com/users/vlantonov/followers","following_url":"https://api.github.com/users/vlantonov/following{/other_user}","gists_url":"https://api.github.com/users/vlantonov/gists{/gist_id}","starred_url":"https://api.github.com/users/vlantonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlantonov/subscriptions","organizations_url":"https://api.github.com/users/vlantonov/orgs","repos_url":"https://api.github.com/users/vlantonov/repos","events_url":"https://api.github.com/users/vlantonov/events{/privacy}","received_events_url":"https://api.github.com/users/vlantonov/received_events","type":"User","site_admin":false},"body":"@LevchenkoS The syntax `is_valid_(is_valid = true)` is confusing. Please consider separate initialization in the constructor.","created_at":"2016-08-23T12:06:42Z","updated_at":"2016-08-23T12:06:42Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/774#discussion_r75852003","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/774","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/75852003"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/774#discussion_r75852003"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/774"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/774","id":82340328,"html_url":"https://github.com/smartdevicelink/sdl_core/pull/774","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/774.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/774.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/774","number":774,"state":"open","locked":false,"title":"Prepare for to entry of fixes from master branch","user":{"login":"LevchenkoS","id":18613689,"avatar_url":"https://avatars.githubusercontent.com/u/18613689?v=3","gravatar_id":"","url":"https://api.github.com/users/LevchenkoS","html_url":"https://github.com/LevchenkoS","followers_url":"https://api.github.com/users/LevchenkoS/followers","following_url":"https://api.github.com/users/LevchenkoS/following{/other_user}","gists_url":"https://api.github.com/users/LevchenkoS/gists{/gist_id}","starred_url":"https://api.github.com/users/LevchenkoS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LevchenkoS/subscriptions","organizations_url":"https://api.github.com/users/LevchenkoS/orgs","repos_url":"https://api.github.com/users/LevchenkoS/repos","events_url":"https://api.github.com/users/LevchenkoS/events{/privacy}","received_events_url":"https://api.github.com/users/LevchenkoS/received_events","type":"User","site_admin":false},"body":"Has been created an unit test to cover\r\nissue fixed in external pull request #642.\r\n\r\nRelated to: [APPLINK-26911](https://adc.luxoft.com/jira/browse/APPLINK-26911)\r\n\r\n@okozlovlux, @LuxoftAKutsan, @vlantonov, @wolfylambova22, @VVeremjova , @pvvasilev, @AByzhynar, please review.","created_at":"2016-08-23T10:31:26Z","updated_at":"2016-08-23T12:06:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da862842b61d79faebdcb3fdb6020a401ccbd543","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/774/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/774/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/774/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/9faa4733e7c4feae858c959c92172174017958d1","head":{"label":"LevchenkoS:feature/Preparation_to_branch_merge","ref":"feature/Preparation_to_branch_merge","sha":"9faa4733e7c4feae858c959c92172174017958d1","user":{"login":"LevchenkoS","id":18613689,"avatar_url":"https://avatars.githubusercontent.com/u/18613689?v=3","gravatar_id":"","url":"https://api.github.com/users/LevchenkoS","html_url":"https://github.com/LevchenkoS","followers_url":"https://api.github.com/users/LevchenkoS/followers","following_url":"https://api.github.com/users/LevchenkoS/following{/other_user}","gists_url":"https://api.github.com/users/LevchenkoS/gists{/gist_id}","starred_url":"https://api.github.com/users/LevchenkoS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LevchenkoS/subscriptions","organizations_url":"https://api.github.com/users/LevchenkoS/orgs","repos_url":"https://api.github.com/users/LevchenkoS/repos","events_url":"https://api.github.com/users/LevchenkoS/events{/privacy}","received_events_url":"https://api.github.com/users/LevchenkoS/received_events","type":"User","site_admin":false},"repo":{"id":60253278,"name":"sdl_core","full_name":"LevchenkoS/sdl_core","owner":{"login":"LevchenkoS","id":18613689,"avatar_url":"https://avatars.githubusercontent.com/u/18613689?v=3","gravatar_id":"","url":"https://api.github.com/users/LevchenkoS","html_url":"https://github.com/LevchenkoS","followers_url":"https://api.github.com/users/LevchenkoS/followers","following_url":"https://api.github.com/users/LevchenkoS/following{/other_user}","gists_url":"https://api.github.com/users/LevchenkoS/gists{/gist_id}","starred_url":"https://api.github.com/users/LevchenkoS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LevchenkoS/subscriptions","organizations_url":"https://api.github.com/users/LevchenkoS/orgs","repos_url":"https://api.github.com/users/LevchenkoS/repos","events_url":"https://api.github.com/users/LevchenkoS/events{/privacy}","received_events_url":"https://api.github.com/users/LevchenkoS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LevchenkoS/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/LevchenkoS/sdl_core","forks_url":"https://api.github.com/repos/LevchenkoS/sdl_core/forks","keys_url":"https://api.github.com/repos/LevchenkoS/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LevchenkoS/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LevchenkoS/sdl_core/teams","hooks_url":"https://api.github.com/repos/LevchenkoS/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/LevchenkoS/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/LevchenkoS/sdl_core/events","assignees_url":"https://api.github.com/repos/LevchenkoS/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/LevchenkoS/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/LevchenkoS/sdl_core/tags","blobs_url":"https://api.github.com/repos/LevchenkoS/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LevchenkoS/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LevchenkoS/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/LevchenkoS/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LevchenkoS/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/LevchenkoS/sdl_core/languages","stargazers_url":"https://api.github.com/repos/LevchenkoS/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/LevchenkoS/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/LevchenkoS/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/LevchenkoS/sdl_core/subscription","commits_url":"https://api.github.com/repos/LevchenkoS/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/LevchenkoS/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/LevchenkoS/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/LevchenkoS/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/LevchenkoS/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/LevchenkoS/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LevchenkoS/sdl_core/merges","archive_url":"https://api.github.com/repos/LevchenkoS/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LevchenkoS/sdl_core/downloads","issues_url":"https://api.github.com/repos/LevchenkoS/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/LevchenkoS/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/LevchenkoS/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/LevchenkoS/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LevchenkoS/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/LevchenkoS/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/LevchenkoS/sdl_core/deployments","created_at":"2016-06-02T10:01:36Z","updated_at":"2016-06-02T10:01:45Z","pushed_at":"2016-08-23T11:31:43Z","git_url":"git://github.com/LevchenkoS/sdl_core.git","ssh_url":"git@github.com:LevchenkoS/sdl_core.git","clone_url":"https://github.com/LevchenkoS/sdl_core.git","svn_url":"https://github.com/LevchenkoS/sdl_core","homepage":"","size":175609,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"01e8cbc70d74e70cd19668c62cd2e11c283bc4af","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2016-07-21T11:12:22Z","pushed_at":"2016-08-23T11:51:42Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":312041,"stargazers_count":74,"watchers_count":74,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":91,"forks":92,"open_issues":91,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/774"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/774"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/774"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/774/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/774/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/774/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/9faa4733e7c4feae858c959c92172174017958d1"}}}}
{"actor":{"display_login":"vlantonov"}}