{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/13475","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/13475/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/13475/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/13475/events","html_url":"https://github.com/dotnet/corefx/pull/13475","id":188066542,"number":13475,"title":"Add AsymmetricAlgorthm.ToXmlString, FromXmlString, and other missing members","user":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"labels":[{"id":163633782,"url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Security","name":"area-System.Security","color":"d4c5f9","default":false},{"id":197706871,"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false},{"id":443823518,"url":"https://api.github.com/repos/dotnet/corefx/labels/netstandard2.0","name":"netstandard2.0","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"assignees":[{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/4","html_url":"https://github.com/dotnet/corefx/milestones/1.2.0","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/4/labels","id":1248719,"number":4,"title":"1.2.0","description":".NET Core 1.2 Placeholder.  https://github.com/dotnet/core/blob/master/roadmap.md","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":499,"closed_issues":1565,"state":"open","created_at":"2015-08-10T18:04:00Z","updated_at":"2016-11-10T19:25:19Z","due_on":"2017-04-30T07:00:00Z","closed_at":null},"comments":3,"created_at":"2016-11-08T18:22:34Z","updated_at":"2016-11-10T19:28:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/13475","html_url":"https://github.com/dotnet/corefx/pull/13475","diff_url":"https://github.com/dotnet/corefx/pull/13475.diff","patch_url":"https://github.com/dotnet/corefx/pull/13475.patch"},"body":"Addresses issue https://github.com/dotnet/corefx/issues/12315\r\n````\r\nOn AsymmetricAlgorithm:\r\nP:KeyExchangeAlgorithm\r\nP:SignatureAlgorithm\r\nM:Clear\r\nM:FromXmlString(string)\r\nM:ToXmlString(bool)\r\n\r\n+ ECDsa changes per ns1.7 and .net 4.6.3\r\nM:FromXmlString(string, ECKeyXmlFormat)\r\nM:ToXmlString(ECKeyXmlFormat)\r\nT:ECKeyXmlFormat\r\n````\r\n\r\nTests are new (not ported). For RSA and DSA, netfx used a different (lower-level) Xml parser; corefx uses XmlReader and XmlWriter. For EcDsa, code was ported directly from netfx including the file Rfc4050KeyFormatter and new enum ECKeyXmlFormat.\r\n\r\n@bartonjs please review"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/259783818","html_url":"https://github.com/dotnet/corefx/pull/13475#issuecomment-259783818","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/13475","id":259783818,"user":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T19:28:02Z","updated_at":"2016-11-10T19:28:02Z","body":"@bartonjs any additional comments? Seed\\counter test in src/System.Security.Cryptography.Algorithms/tests/DSATests.cs"}}
{"actor":{"display_login":"steveharter"}}