{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/comments/87721005","pull_request_review_id":8321866,"id":87721005,"diff_hunk":"@@ -9,9 +9,7 @@\n   \"license\": \"MIT\",\n   \"main\": \"src/main.js\",\n   \"scripts\": {\n-    \"start\": \"./node_modules/.bin/electron . --debug-webview --isNpmStart\",\n-    \"pack:osx\": \"./node_modules/.bin/electron-packager . $npm_package_productName --app-version=$npm_package_version --version=0.36.7 --out=builds --ignore='^/builds$' --platform=darwin --arch=x64 --sign='Developer ID Application: My Company Ltd (ABCDEFGH10)' --icon=icon.icns --overwrite\",","path":"package.json","position":null,"original_position":5,"commit_id":"4708a27e5aaaf87dfbb0bb0406c35aebbfd6f13b","original_commit_id":"4708a27e5aaaf87dfbb0bb0406c35aebbfd6f13b","user":{"login":"OwenBrotherwood","id":866122,"avatar_url":"https://avatars.githubusercontent.com/u/866122?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenBrotherwood","html_url":"https://github.com/OwenBrotherwood","followers_url":"https://api.github.com/users/OwenBrotherwood/followers","following_url":"https://api.github.com/users/OwenBrotherwood/following{/other_user}","gists_url":"https://api.github.com/users/OwenBrotherwood/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenBrotherwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenBrotherwood/subscriptions","organizations_url":"https://api.github.com/users/OwenBrotherwood/orgs","repos_url":"https://api.github.com/users/OwenBrotherwood/repos","events_url":"https://api.github.com/users/OwenBrotherwood/events{/privacy}","received_events_url":"https://api.github.com/users/OwenBrotherwood/received_events","type":"User","site_admin":false},"body":"Ignore this change: I was seeing how packageing was working.\r\nCould mean I should rebase all of the work to get rid of these unimportant changes","created_at":"2016-11-13T20:39:28Z","updated_at":"2016-11-13T20:39:28Z","html_url":"https://github.com/Microsoft/pxt-microbit-electron/pull/25#discussion_r87721005","pull_request_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/comments/87721005"},"html":{"href":"https://github.com/Microsoft/pxt-microbit-electron/pull/25#discussion_r87721005"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/25","id":93485946,"html_url":"https://github.com/Microsoft/pxt-microbit-electron/pull/25","diff_url":"https://github.com/Microsoft/pxt-microbit-electron/pull/25.diff","patch_url":"https://github.com/Microsoft/pxt-microbit-electron/pull/25.patch","issue_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/issues/25","number":25,"state":"open","locked":false,"title":"Rework of main.js","user":{"login":"OwenBrotherwood","id":866122,"avatar_url":"https://avatars.githubusercontent.com/u/866122?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenBrotherwood","html_url":"https://github.com/OwenBrotherwood","followers_url":"https://api.github.com/users/OwenBrotherwood/followers","following_url":"https://api.github.com/users/OwenBrotherwood/following{/other_user}","gists_url":"https://api.github.com/users/OwenBrotherwood/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenBrotherwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenBrotherwood/subscriptions","organizations_url":"https://api.github.com/users/OwenBrotherwood/orgs","repos_url":"https://api.github.com/users/OwenBrotherwood/repos","events_url":"https://api.github.com/users/OwenBrotherwood/events{/privacy}","received_events_url":"https://api.github.com/users/OwenBrotherwood/received_events","type":"User","site_admin":false},"body":"Some ideas of what can be done with what is available just now.\r\n\r\nNote that --npm-start and --electron are removed: and --not-browser is introduced to inform pxt that the requirer is not a browser solution.\r\n\r\nSome work on how the bare electron window container could work with auto hide menus and indications to the user at startup, that the app is starting.","created_at":"2016-11-13T20:37:46Z","updated_at":"2016-11-13T20:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d494c35678e348dd837cdb24fb2fdf3a99fcb987","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/25/commits","review_comments_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/25/comments","review_comment_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/issues/25/comments","statuses_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/statuses/4708a27e5aaaf87dfbb0bb0406c35aebbfd6f13b","head":{"label":"OwenBrotherwood:rework","ref":"rework","sha":"4708a27e5aaaf87dfbb0bb0406c35aebbfd6f13b","user":{"login":"OwenBrotherwood","id":866122,"avatar_url":"https://avatars.githubusercontent.com/u/866122?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenBrotherwood","html_url":"https://github.com/OwenBrotherwood","followers_url":"https://api.github.com/users/OwenBrotherwood/followers","following_url":"https://api.github.com/users/OwenBrotherwood/following{/other_user}","gists_url":"https://api.github.com/users/OwenBrotherwood/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenBrotherwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenBrotherwood/subscriptions","organizations_url":"https://api.github.com/users/OwenBrotherwood/orgs","repos_url":"https://api.github.com/users/OwenBrotherwood/repos","events_url":"https://api.github.com/users/OwenBrotherwood/events{/privacy}","received_events_url":"https://api.github.com/users/OwenBrotherwood/received_events","type":"User","site_admin":false},"repo":{"id":73630244,"name":"pxt-microbit-electron","full_name":"OwenBrotherwood/pxt-microbit-electron","owner":{"login":"OwenBrotherwood","id":866122,"avatar_url":"https://avatars.githubusercontent.com/u/866122?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenBrotherwood","html_url":"https://github.com/OwenBrotherwood","followers_url":"https://api.github.com/users/OwenBrotherwood/followers","following_url":"https://api.github.com/users/OwenBrotherwood/following{/other_user}","gists_url":"https://api.github.com/users/OwenBrotherwood/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenBrotherwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenBrotherwood/subscriptions","organizations_url":"https://api.github.com/users/OwenBrotherwood/orgs","repos_url":"https://api.github.com/users/OwenBrotherwood/repos","events_url":"https://api.github.com/users/OwenBrotherwood/events{/privacy}","received_events_url":"https://api.github.com/users/OwenBrotherwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OwenBrotherwood/pxt-microbit-electron","description":null,"fork":true,"url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron","forks_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/forks","keys_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/teams","hooks_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/hooks","issue_events_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/issues/events{/number}","events_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/events","assignees_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/assignees{/user}","branches_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/branches{/branch}","tags_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/tags","blobs_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/statuses/{sha}","languages_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/languages","stargazers_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/stargazers","contributors_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/contributors","subscribers_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/subscribers","subscription_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/subscription","commits_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/contents/{+path}","compare_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/merges","archive_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/downloads","issues_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/issues{/number}","pulls_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/pulls{/number}","milestones_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/milestones{/number}","notifications_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/labels{/name}","releases_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/releases{/id}","deployments_url":"https://api.github.com/repos/OwenBrotherwood/pxt-microbit-electron/deployments","created_at":"2016-11-13T17:07:13Z","updated_at":"2016-11-13T17:07:14Z","pushed_at":"2016-11-13T20:20:31Z","git_url":"git://github.com/OwenBrotherwood/pxt-microbit-electron.git","ssh_url":"git@github.com:OwenBrotherwood/pxt-microbit-electron.git","clone_url":"https://github.com/OwenBrotherwood/pxt-microbit-electron.git","svn_url":"https://github.com/OwenBrotherwood/pxt-microbit-electron","homepage":null,"size":33,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"da05d420b3b7ae04345b47f9fdf18c35d278a79a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":69303216,"name":"pxt-microbit-electron","full_name":"Microsoft/pxt-microbit-electron","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/pxt-microbit-electron","description":null,"fork":false,"url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron","forks_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/forks","keys_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/teams","hooks_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/events","assignees_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/tags","blobs_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/subscription","commits_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/merges","archive_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/downloads","issues_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/deployments","created_at":"2016-09-27T00:08:29Z","updated_at":"2016-10-31T23:32:25Z","pushed_at":"2016-11-13T20:37:46Z","git_url":"git://github.com/Microsoft/pxt-microbit-electron.git","ssh_url":"git@github.com:Microsoft/pxt-microbit-electron.git","clone_url":"https://github.com/Microsoft/pxt-microbit-electron.git","svn_url":"https://github.com/Microsoft/pxt-microbit-electron","homepage":null,"size":48,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/25"},"html":{"href":"https://github.com/Microsoft/pxt-microbit-electron/pull/25"},"issue":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/issues/25"},"comments":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit-electron/statuses/4708a27e5aaaf87dfbb0bb0406c35aebbfd6f13b"}}}}
{"actor":{"display_login":"OwenBrotherwood"}}