{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/1553","repository_url":"https://api.github.com/repos/apache/flink","labels_url":"https://api.github.com/repos/apache/flink/issues/1553/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/1553/comments","events_url":"https://api.github.com/repos/apache/flink/issues/1553/events","html_url":"https://github.com/apache/flink/pull/1553","id":129198106,"number":1553,"title":"FLINK-3179 Combiner is not injected if Reduce or GroupReduce input is explicitly partitioned (Ram)","user":{"login":"ramkrish86","id":3690658,"avatar_url":"https://avatars.githubusercontent.com/u/3690658?v=3","gravatar_id":"","url":"https://api.github.com/users/ramkrish86","html_url":"https://github.com/ramkrish86","followers_url":"https://api.github.com/users/ramkrish86/followers","following_url":"https://api.github.com/users/ramkrish86/following{/other_user}","gists_url":"https://api.github.com/users/ramkrish86/gists{/gist_id}","starred_url":"https://api.github.com/users/ramkrish86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramkrish86/subscriptions","organizations_url":"https://api.github.com/users/ramkrish86/orgs","repos_url":"https://api.github.com/users/ramkrish86/repos","events_url":"https://api.github.com/users/ramkrish86/events{/privacy}","received_events_url":"https://api.github.com/users/ramkrish86/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2016-01-27T16:33:43Z","updated_at":"2016-03-08T04:09:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/1553","html_url":"https://github.com/apache/flink/pull/1553","diff_url":"https://github.com/apache/flink/pull/1553.diff","patch_url":"https://github.com/apache/flink/pull/1553.patch"},"body":"Followed the guidance given in the description in order to fix this. Is the approach correct here?  Also using this to learn the code. \r\nOnce we see that a partition node is the input of a reduce node or group reduce node -  we try to inject the combiner to the source node (the data source node) and the reducer node will take the actual partition node as the input. \r\nSo now the structure would be DataSource->Combine->Partition->Reduce. \r\nSuggestions and feedback welcome as am not sure if I have covered all the cases here. "},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/193595361","html_url":"https://github.com/apache/flink/pull/1553#issuecomment-193595361","issue_url":"https://api.github.com/repos/apache/flink/issues/1553","id":193595361,"user":{"login":"ramkrish86","id":3690658,"avatar_url":"https://avatars.githubusercontent.com/u/3690658?v=3","gravatar_id":"","url":"https://api.github.com/users/ramkrish86","html_url":"https://github.com/ramkrish86","followers_url":"https://api.github.com/users/ramkrish86/followers","following_url":"https://api.github.com/users/ramkrish86/following{/other_user}","gists_url":"https://api.github.com/users/ramkrish86/gists{/gist_id}","starred_url":"https://api.github.com/users/ramkrish86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramkrish86/subscriptions","organizations_url":"https://api.github.com/users/ramkrish86/orgs","repos_url":"https://api.github.com/users/ramkrish86/repos","events_url":"https://api.github.com/users/ramkrish86/events{/privacy}","received_events_url":"https://api.github.com/users/ramkrish86/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T04:09:23Z","updated_at":"2016-03-08T04:09:23Z","body":"@fhueske \r\nI was looking into the comments and the refactoring I can avoid by creating a new patch altogether. But saying the last comment I think I can hold this off for some time. Felt sad as I wanted to bring this to closure. Anyway you are the expert so I need to adhere to your words here. No problem. Will check if I can take up some other JIRA or do you have any suggestions till then?"}}