{"action":"created","issue":{"url":"https://api.github.com/repos/poteto/ember-metrics/issues/86","repository_url":"https://api.github.com/repos/poteto/ember-metrics","labels_url":"https://api.github.com/repos/poteto/ember-metrics/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/poteto/ember-metrics/issues/86/comments","events_url":"https://api.github.com/repos/poteto/ember-metrics/issues/86/events","html_url":"https://github.com/poteto/ember-metrics/pull/86","id":155878854,"number":86,"title":"custom driver for Adobe DTM metrics","user":{"login":"andrewmartin","id":273842,"avatar_url":"https://avatars.githubusercontent.com/u/273842?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewmartin","html_url":"https://github.com/andrewmartin","followers_url":"https://api.github.com/users/andrewmartin/followers","following_url":"https://api.github.com/users/andrewmartin/following{/other_user}","gists_url":"https://api.github.com/users/andrewmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmartin/subscriptions","organizations_url":"https://api.github.com/users/andrewmartin/orgs","repos_url":"https://api.github.com/users/andrewmartin/repos","events_url":"https://api.github.com/users/andrewmartin/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmartin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-05-20T03:12:52Z","updated_at":"2016-11-05T00:23:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/poteto/ember-metrics/pulls/86","html_url":"https://github.com/poteto/ember-metrics/pull/86","diff_url":"https://github.com/poteto/ember-metrics/pull/86.diff","patch_url":"https://github.com/poteto/ember-metrics/pull/86.patch"},"body":"Hi there, thanks for your hard work on an excellent add on. Over here at DSC we used `ember-metrics` in conjunction with the `Google Tag Manager` adapter, and everything worked great. Our marketing team made the decision to move to `Adobe Metrics`, so we found the need to build a new adapter. \n\nThis is a first pass for you to take a look at; I basically tried to follow the conventions and patterns you had set in your `Google Tag Manager`. \n\nOne thing I was hoping to get a second eye on is the `eventQueue` I set up here. Unfortunately, Adobe's solution (as far as I could tell) doesn't have any sort of a promise or trigger to alert the library has been loaded in, and we ran into a few issues with the library not being ready by the time Ember code was being executed. \n\nI set up a pretty basic poll-based timer to check the `eventQueue` array for items and then fire off events in succession (see line 50 or so of the driver), but this may not be ideal. Would love a second opinion.\n\nAlso, I could use a little help with tests, if you have any suggestions (full disclosure, I'm a little new to the Ember game and whole Javascript unit testing thing).\n\nAnyways, take a look and hopefully this is something helpful for someone down the road.\n"},"comment":{"url":"https://api.github.com/repos/poteto/ember-metrics/issues/comments/258577744","html_url":"https://github.com/poteto/ember-metrics/pull/86#issuecomment-258577744","issue_url":"https://api.github.com/repos/poteto/ember-metrics/issues/86","id":258577744,"user":{"login":"poteto","id":1390709,"avatar_url":"https://avatars.githubusercontent.com/u/1390709?v=3","gravatar_id":"","url":"https://api.github.com/users/poteto","html_url":"https://github.com/poteto","followers_url":"https://api.github.com/users/poteto/followers","following_url":"https://api.github.com/users/poteto/following{/other_user}","gists_url":"https://api.github.com/users/poteto/gists{/gist_id}","starred_url":"https://api.github.com/users/poteto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poteto/subscriptions","organizations_url":"https://api.github.com/users/poteto/orgs","repos_url":"https://api.github.com/users/poteto/repos","events_url":"https://api.github.com/users/poteto/events{/privacy}","received_events_url":"https://api.github.com/users/poteto/received_events","type":"User","site_admin":false},"created_at":"2016-11-05T00:23:29Z","updated_at":"2016-11-05T00:23:29Z","body":"@andrewmartin Sorry this took so long, it completely slipped my mind and I'm super sorry for that. If you rebase this against `master` I'll get it merged and released"}}
{"actor":{"display_login":"poteto"}}