{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/92282348","pull_request_review_id":12795286,"id":92282348,"diff_hunk":"@@ -0,0 +1,38 @@\n+/**\n+ * Copyright 2016 Google Inc. All rights reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+'use strict';\n+\n+require('../../compiled-check.js')('chrome-launcher.js');\n+\n+const ChromeLauncher = require('../../chrome-launcher.js').ChromeLauncher;\n+\n+/* global describe, it */","path":"lighthouse-cli/test/cli/chrome-launcher-test.js","position":23,"original_position":23,"commit_id":"03cdb9c2a63677d2ee51168d2eac6703dc33906a","original_commit_id":"03cdb9c2a63677d2ee51168d2eac6703dc33906a","user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"body":"yeah, I generally prefer keeping PRs contained and we can have a separate PR for that (and/or change as we go since it's functionally equivalent)","created_at":"2016-12-13T22:32:49Z","updated_at":"2016-12-13T22:32:49Z","html_url":"https://github.com/GoogleChrome/lighthouse/pull/1131#discussion_r92282348","pull_request_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1131","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/92282348"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/1131#discussion_r92282348"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1131"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1131","id":97282801,"html_url":"https://github.com/GoogleChrome/lighthouse/pull/1131","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/1131.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/1131.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/1131","number":1131,"state":"open","locked":false,"title":"Eliminate errors from calling ChromeLauncher.kill() twice ","user":{"login":"Janpot","id":2109932,"avatar_url":"https://avatars.githubusercontent.com/u/2109932?v=3","gravatar_id":"","url":"https://api.github.com/users/Janpot","html_url":"https://github.com/Janpot","followers_url":"https://api.github.com/users/Janpot/followers","following_url":"https://api.github.com/users/Janpot/following{/other_user}","gists_url":"https://api.github.com/users/Janpot/gists{/gist_id}","starred_url":"https://api.github.com/users/Janpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Janpot/subscriptions","organizations_url":"https://api.github.com/users/Janpot/orgs","repos_url":"https://api.github.com/users/Janpot/repos","events_url":"https://api.github.com/users/Janpot/events{/privacy}","received_events_url":"https://api.github.com/users/Janpot/received_events","type":"User","site_admin":false},"body":"The error happened outside the Promise chain and is uncatchable.","created_at":"2016-12-09T10:16:07Z","updated_at":"2016-12-13T22:32:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbea98e9b626f873e4708011f0edada93e289eaa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1131/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1131/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/1131/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/03cdb9c2a63677d2ee51168d2eac6703dc33906a","head":{"label":"Janpot:killerror","ref":"killerror","sha":"03cdb9c2a63677d2ee51168d2eac6703dc33906a","user":{"login":"Janpot","id":2109932,"avatar_url":"https://avatars.githubusercontent.com/u/2109932?v=3","gravatar_id":"","url":"https://api.github.com/users/Janpot","html_url":"https://github.com/Janpot","followers_url":"https://api.github.com/users/Janpot/followers","following_url":"https://api.github.com/users/Janpot/following{/other_user}","gists_url":"https://api.github.com/users/Janpot/gists{/gist_id}","starred_url":"https://api.github.com/users/Janpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Janpot/subscriptions","organizations_url":"https://api.github.com/users/Janpot/orgs","repos_url":"https://api.github.com/users/Janpot/repos","events_url":"https://api.github.com/users/Janpot/events{/privacy}","received_events_url":"https://api.github.com/users/Janpot/received_events","type":"User","site_admin":false},"repo":{"id":72923120,"name":"lighthouse","full_name":"Janpot/lighthouse","owner":{"login":"Janpot","id":2109932,"avatar_url":"https://avatars.githubusercontent.com/u/2109932?v=3","gravatar_id":"","url":"https://api.github.com/users/Janpot","html_url":"https://github.com/Janpot","followers_url":"https://api.github.com/users/Janpot/followers","following_url":"https://api.github.com/users/Janpot/following{/other_user}","gists_url":"https://api.github.com/users/Janpot/gists{/gist_id}","starred_url":"https://api.github.com/users/Janpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Janpot/subscriptions","organizations_url":"https://api.github.com/users/Janpot/orgs","repos_url":"https://api.github.com/users/Janpot/repos","events_url":"https://api.github.com/users/Janpot/events{/privacy}","received_events_url":"https://api.github.com/users/Janpot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Janpot/lighthouse","description":"auditing and performance metrics for Progressive Web Apps","fork":true,"url":"https://api.github.com/repos/Janpot/lighthouse","forks_url":"https://api.github.com/repos/Janpot/lighthouse/forks","keys_url":"https://api.github.com/repos/Janpot/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Janpot/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Janpot/lighthouse/teams","hooks_url":"https://api.github.com/repos/Janpot/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/Janpot/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/Janpot/lighthouse/events","assignees_url":"https://api.github.com/repos/Janpot/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/Janpot/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/Janpot/lighthouse/tags","blobs_url":"https://api.github.com/repos/Janpot/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Janpot/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Janpot/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/Janpot/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Janpot/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/Janpot/lighthouse/languages","stargazers_url":"https://api.github.com/repos/Janpot/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/Janpot/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/Janpot/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/Janpot/lighthouse/subscription","commits_url":"https://api.github.com/repos/Janpot/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/Janpot/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/Janpot/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/Janpot/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/Janpot/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/Janpot/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Janpot/lighthouse/merges","archive_url":"https://api.github.com/repos/Janpot/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Janpot/lighthouse/downloads","issues_url":"https://api.github.com/repos/Janpot/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/Janpot/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/Janpot/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/Janpot/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Janpot/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/Janpot/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/Janpot/lighthouse/deployments","created_at":"2016-11-05T11:55:40Z","updated_at":"2016-11-05T11:55:42Z","pushed_at":"2016-12-13T10:09:59Z","git_url":"git://github.com/Janpot/lighthouse.git","ssh_url":"git@github.com:Janpot/lighthouse.git","clone_url":"https://github.com/Janpot/lighthouse.git","svn_url":"https://github.com/Janpot/lighthouse","homepage":"","size":8648,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"81194e4aa8594679483b9eb56d9b18b622f2d27e","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"name":"lighthouse","full_name":"GoogleChrome/lighthouse","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2016-12-13T20:50:32Z","pushed_at":"2016-12-13T21:53:07Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":"","size":9034,"stargazers_count":4975,"watchers_count":4975,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":155,"forks":187,"open_issues":155,"watchers":4975,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1131"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/1131"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/1131"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/1131/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1131/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/1131/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/03cdb9c2a63677d2ee51168d2eac6703dc33906a"}}}}
{"actor":{"display_login":"brendankenny"}}