{"action":"created","issue":{"url":"https://api.github.com/repos/chartjs/Chart.js/issues/2346","repository_url":"https://api.github.com/repos/chartjs/Chart.js","labels_url":"https://api.github.com/repos/chartjs/Chart.js/issues/2346/labels{/name}","comments_url":"https://api.github.com/repos/chartjs/Chart.js/issues/2346/comments","events_url":"https://api.github.com/repos/chartjs/Chart.js/issues/2346/events","html_url":"https://github.com/chartjs/Chart.js/pull/2346","id":150659918,"number":2346,"title":"Shared data between charts","user":{"login":"simonbrunel","id":3874900,"avatar_url":"https://avatars.githubusercontent.com/u/3874900?v=3","gravatar_id":"","url":"https://api.github.com/users/simonbrunel","html_url":"https://github.com/simonbrunel","followers_url":"https://api.github.com/users/simonbrunel/followers","following_url":"https://api.github.com/users/simonbrunel/following{/other_user}","gists_url":"https://api.github.com/users/simonbrunel/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbrunel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbrunel/subscriptions","organizations_url":"https://api.github.com/users/simonbrunel/orgs","repos_url":"https://api.github.com/users/simonbrunel/repos","events_url":"https://api.github.com/users/simonbrunel/events{/privacy}","received_events_url":"https://api.github.com/users/simonbrunel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2016-04-24T13:17:17Z","updated_at":"2016-04-26T10:52:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chartjs/Chart.js/pulls/2346","html_url":"https://github.com/chartjs/Chart.js/pull/2346","diff_url":"https://github.com/chartjs/Chart.js/pull/2346.diff","patch_url":"https://github.com/chartjs/Chart.js/pull/2346.patch"},"body":"**Important:** This PR breaks all tests because now it requires to work on a real chart instance (not a fake chart/context). Modifying all tests will require an important effort, so I prefer to be sure we want to merge these changes before rewriting all tests.\r\n\r\n**Note:** Since this PR is pretty big and touches almost all files, it would be great to consider merging it as soon as possible to avoid too many conflicts with upcoming contributions.\r\n\r\n<hr/>\r\n\r\nThis PR allows sharing config.data between multiple chart instances (charts can be of different types). For details, please review commit messages which should be enough to understand changes. But basically, I moved all meta info under dataset._meta, which is a map from chart id to meta info (chart id is now an integer to speed up lookups).\r\n\r\n![image](https://cloud.githubusercontent.com/assets/3874900/14767729/610091ac-0a2d-11e6-9cf9-eade90d3dd57.png)\r\n<p align=\"center\">left: master | right: PR</p>\r\n\r\nAlso changed (fixed) the polar show/hide animations as talk on Slack:\r\n\r\n![polar-chart-v2](https://cloud.githubusercontent.com/assets/3874900/14767753/c35e1a18-0a2d-11e6-8c3d-8358ff98d828.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/chartjs/Chart.js/issues/comments/214701107","html_url":"https://github.com/chartjs/Chart.js/pull/2346#issuecomment-214701107","issue_url":"https://api.github.com/repos/chartjs/Chart.js/issues/2346","id":214701107,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T10:52:03Z","updated_at":"2016-04-26T10:52:03Z","body":"\n[![Coverage Status](https://coveralls.io/builds/5934376/badge)](https://coveralls.io/builds/5934376)\n\nCoverage decreased (-1.7%) to 70.295% when pulling **e0353dac984719dcd7a7d04b760c74cabff932a5 on simonbrunel:shared-data** into **b615fe8c353fb26e66383817624c2ce04825d320 on chartjs:master**.\n"}}