{"action":"created","comment":{"url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/comments/49041842","id":49041842,"diff_hunk":"@@ -0,0 +1,63 @@\n+package UI.Art;\n+\n+import java.awt.Color;\n+import java.awt.Graphics;\n+\n+import Engine.GameInstance;\n+import Terrain.GameMap;\n+import Terrain.Location;\n+import UI.MapView;\n+import Units.Unit;\n+\n+public class FillRectUnitArtist implements UnitArtist\n+{\n+\tprivate int tileSizePx = MapView.tileSizePx;\n+\t\n+\tGameInstance myGame;\n+\tGameMap gameMap;\n+\t\n+\tpublic static final Color COLOR_TIRED = new Color(128,128,128,160);\n+\t\n+\tpublic FillRectUnitArtist(GameInstance game)\n+\t{\n+\t\tmyGame = game;\n+\t\tgameMap = myGame.gameMap;\n+\t}\n+\t\n+\tpublic void drawUnits(Graphics g)\n+\t{\n+\t\t// TODO: It would be pretty swell if we could just ask the map for a list of units.","path":"src/UI/Art/FillRectUnitArtist.java","position":29,"original_position":29,"commit_id":"4add98a5eaaedf6edf1bfc41a9800d89150bfb4b","original_commit_id":"4add98a5eaaedf6edf1bfc41a9800d89150bfb4b","user":{"login":"ThatIsAUsername","id":16439262,"avatar_url":"https://avatars.githubusercontent.com/u/16439262?v=3","gravatar_id":"","url":"https://api.github.com/users/ThatIsAUsername","html_url":"https://github.com/ThatIsAUsername","followers_url":"https://api.github.com/users/ThatIsAUsername/followers","following_url":"https://api.github.com/users/ThatIsAUsername/following{/other_user}","gists_url":"https://api.github.com/users/ThatIsAUsername/gists{/gist_id}","starred_url":"https://api.github.com/users/ThatIsAUsername/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThatIsAUsername/subscriptions","organizations_url":"https://api.github.com/users/ThatIsAUsername/orgs","repos_url":"https://api.github.com/users/ThatIsAUsername/repos","events_url":"https://api.github.com/users/ThatIsAUsername/events{/privacy}","received_events_url":"https://api.github.com/users/ThatIsAUsername/received_events","type":"User","site_admin":false},"body":"Probs... but then you would also get units in transports, not just those on the map. Still a good idea though, since that should be easy enough to check.","created_at":"2016-01-07T04:49:38Z","updated_at":"2016-01-07T04:49:38Z","html_url":"https://github.com/ThislsAUsername/DefendPeace/pull/25#discussion_r49041842","pull_request_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/comments/49041842"},"html":{"href":"https://github.com/ThislsAUsername/DefendPeace/pull/25#discussion_r49041842"},"pull_request":{"href":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/25","id":55053701,"html_url":"https://github.com/ThislsAUsername/DefendPeace/pull/25","diff_url":"https://github.com/ThislsAUsername/DefendPeace/pull/25.diff","patch_url":"https://github.com/ThislsAUsername/DefendPeace/pull/25.patch","issue_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/issues/25","number":25,"state":"open","locked":false,"title":"Ui reorg","user":{"login":"ThatIsAUsername","id":16439262,"avatar_url":"https://avatars.githubusercontent.com/u/16439262?v=3","gravatar_id":"","url":"https://api.github.com/users/ThatIsAUsername","html_url":"https://github.com/ThatIsAUsername","followers_url":"https://api.github.com/users/ThatIsAUsername/followers","following_url":"https://api.github.com/users/ThatIsAUsername/following{/other_user}","gists_url":"https://api.github.com/users/ThatIsAUsername/gists{/gist_id}","starred_url":"https://api.github.com/users/ThatIsAUsername/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThatIsAUsername/subscriptions","organizations_url":"https://api.github.com/users/ThatIsAUsername/orgs","repos_url":"https://api.github.com/users/ThatIsAUsername/repos","events_url":"https://api.github.com/users/ThatIsAUsername/events{/privacy}","received_events_url":"https://api.github.com/users/ThatIsAUsername/received_events","type":"User","site_admin":false},"body":"I think breaking up the MapView into components may make it easier to maintain/update/replace sections of the drawing code. There will be more changes incoming, as I'm fleshing out how to get action animations to work (I may change MapView's name, and add some animation classes), but I'd like to get your feedback on these changes even if we don't merge them yet, to hopefully catch any issues (also, if you review this now, you'll be able to grok the final version more quickly).","created_at":"2016-01-05T04:29:39Z","updated_at":"2016-01-07T04:49:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3778cd7db3d1d34ea56633c1d2ec9b7e523a8775","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/25/commits","review_comments_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/25/comments","review_comment_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/issues/25/comments","statuses_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/statuses/4add98a5eaaedf6edf1bfc41a9800d89150bfb4b","head":{"label":"ThislsAUsername:UIReorg","ref":"UIReorg","sha":"4add98a5eaaedf6edf1bfc41a9800d89150bfb4b","user":{"login":"ThislsAUsername","id":8674241,"avatar_url":"https://avatars.githubusercontent.com/u/8674241?v=3","gravatar_id":"","url":"https://api.github.com/users/ThislsAUsername","html_url":"https://github.com/ThislsAUsername","followers_url":"https://api.github.com/users/ThislsAUsername/followers","following_url":"https://api.github.com/users/ThislsAUsername/following{/other_user}","gists_url":"https://api.github.com/users/ThislsAUsername/gists{/gist_id}","starred_url":"https://api.github.com/users/ThislsAUsername/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThislsAUsername/subscriptions","organizations_url":"https://api.github.com/users/ThislsAUsername/orgs","repos_url":"https://api.github.com/users/ThislsAUsername/repos","events_url":"https://api.github.com/users/ThislsAUsername/events{/privacy}","received_events_url":"https://api.github.com/users/ThislsAUsername/received_events","type":"User","site_admin":false},"repo":{"id":48552329,"name":"DefendPeace","full_name":"ThislsAUsername/DefendPeace","owner":{"login":"ThislsAUsername","id":8674241,"avatar_url":"https://avatars.githubusercontent.com/u/8674241?v=3","gravatar_id":"","url":"https://api.github.com/users/ThislsAUsername","html_url":"https://github.com/ThislsAUsername","followers_url":"https://api.github.com/users/ThislsAUsername/followers","following_url":"https://api.github.com/users/ThislsAUsername/following{/other_user}","gists_url":"https://api.github.com/users/ThislsAUsername/gists{/gist_id}","starred_url":"https://api.github.com/users/ThislsAUsername/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThislsAUsername/subscriptions","organizations_url":"https://api.github.com/users/ThislsAUsername/orgs","repos_url":"https://api.github.com/users/ThislsAUsername/repos","events_url":"https://api.github.com/users/ThislsAUsername/events{/privacy}","received_events_url":"https://api.github.com/users/ThislsAUsername/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThislsAUsername/DefendPeace","description":"A clone of Advance Wars made in Java","fork":false,"url":"https://api.github.com/repos/ThislsAUsername/DefendPeace","forks_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/forks","keys_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/teams","hooks_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/hooks","issue_events_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/issues/events{/number}","events_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/events","assignees_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/assignees{/user}","branches_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/branches{/branch}","tags_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/tags","blobs_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/statuses/{sha}","languages_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/languages","stargazers_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/stargazers","contributors_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/contributors","subscribers_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/subscribers","subscription_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/subscription","commits_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/contents/{+path}","compare_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/merges","archive_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/downloads","issues_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/issues{/number}","pulls_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls{/number}","milestones_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/milestones{/number}","notifications_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/labels{/name}","releases_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/releases{/id}","created_at":"2015-12-24T17:50:50Z","updated_at":"2016-01-06T01:52:04Z","pushed_at":"2016-01-06T09:26:06Z","git_url":"git://github.com/ThislsAUsername/DefendPeace.git","ssh_url":"git@github.com:ThislsAUsername/DefendPeace.git","clone_url":"https://github.com/ThislsAUsername/DefendPeace.git","svn_url":"https://github.com/ThislsAUsername/DefendPeace","homepage":"","size":185,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"ThislsAUsername:master","ref":"master","sha":"741129033c246add23f0e5435960f24b10c23a6e","user":{"login":"ThislsAUsername","id":8674241,"avatar_url":"https://avatars.githubusercontent.com/u/8674241?v=3","gravatar_id":"","url":"https://api.github.com/users/ThislsAUsername","html_url":"https://github.com/ThislsAUsername","followers_url":"https://api.github.com/users/ThislsAUsername/followers","following_url":"https://api.github.com/users/ThislsAUsername/following{/other_user}","gists_url":"https://api.github.com/users/ThislsAUsername/gists{/gist_id}","starred_url":"https://api.github.com/users/ThislsAUsername/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThislsAUsername/subscriptions","organizations_url":"https://api.github.com/users/ThislsAUsername/orgs","repos_url":"https://api.github.com/users/ThislsAUsername/repos","events_url":"https://api.github.com/users/ThislsAUsername/events{/privacy}","received_events_url":"https://api.github.com/users/ThislsAUsername/received_events","type":"User","site_admin":false},"repo":{"id":48552329,"name":"DefendPeace","full_name":"ThislsAUsername/DefendPeace","owner":{"login":"ThislsAUsername","id":8674241,"avatar_url":"https://avatars.githubusercontent.com/u/8674241?v=3","gravatar_id":"","url":"https://api.github.com/users/ThislsAUsername","html_url":"https://github.com/ThislsAUsername","followers_url":"https://api.github.com/users/ThislsAUsername/followers","following_url":"https://api.github.com/users/ThislsAUsername/following{/other_user}","gists_url":"https://api.github.com/users/ThislsAUsername/gists{/gist_id}","starred_url":"https://api.github.com/users/ThislsAUsername/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThislsAUsername/subscriptions","organizations_url":"https://api.github.com/users/ThislsAUsername/orgs","repos_url":"https://api.github.com/users/ThislsAUsername/repos","events_url":"https://api.github.com/users/ThislsAUsername/events{/privacy}","received_events_url":"https://api.github.com/users/ThislsAUsername/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThislsAUsername/DefendPeace","description":"A clone of Advance Wars made in Java","fork":false,"url":"https://api.github.com/repos/ThislsAUsername/DefendPeace","forks_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/forks","keys_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/teams","hooks_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/hooks","issue_events_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/issues/events{/number}","events_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/events","assignees_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/assignees{/user}","branches_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/branches{/branch}","tags_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/tags","blobs_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/statuses/{sha}","languages_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/languages","stargazers_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/stargazers","contributors_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/contributors","subscribers_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/subscribers","subscription_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/subscription","commits_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/contents/{+path}","compare_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/merges","archive_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/downloads","issues_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/issues{/number}","pulls_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls{/number}","milestones_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/milestones{/number}","notifications_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/labels{/name}","releases_url":"https://api.github.com/repos/ThislsAUsername/DefendPeace/releases{/id}","created_at":"2015-12-24T17:50:50Z","updated_at":"2016-01-06T01:52:04Z","pushed_at":"2016-01-06T09:26:06Z","git_url":"git://github.com/ThislsAUsername/DefendPeace.git","ssh_url":"git@github.com:ThislsAUsername/DefendPeace.git","clone_url":"https://github.com/ThislsAUsername/DefendPeace.git","svn_url":"https://github.com/ThislsAUsername/DefendPeace","homepage":"","size":185,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/25"},"html":{"href":"https://github.com/ThislsAUsername/DefendPeace/pull/25"},"issue":{"href":"https://api.github.com/repos/ThislsAUsername/DefendPeace/issues/25"},"comments":{"href":"https://api.github.com/repos/ThislsAUsername/DefendPeace/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ThislsAUsername/DefendPeace/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/ThislsAUsername/DefendPeace/statuses/4add98a5eaaedf6edf1bfc41a9800d89150bfb4b"}}}}