{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/osquery/issues/2595","repository_url":"https://api.github.com/repos/facebook/osquery","labels_url":"https://api.github.com/repos/facebook/osquery/issues/2595/labels{/name}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/2595/comments","events_url":"https://api.github.com/repos/facebook/osquery/issues/2595/events","html_url":"https://github.com/facebook/osquery/pull/2595","id":181326063,"number":2595,"title":"[Fixes #2594] windows: Implement the etc_services table","user":{"login":"slester","id":104014,"avatar_url":"https://avatars.githubusercontent.com/u/104014?v=3","gravatar_id":"","url":"https://api.github.com/users/slester","html_url":"https://github.com/slester","followers_url":"https://api.github.com/users/slester/followers","following_url":"https://api.github.com/users/slester/following{/other_user}","gists_url":"https://api.github.com/users/slester/gists{/gist_id}","starred_url":"https://api.github.com/users/slester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slester/subscriptions","organizations_url":"https://api.github.com/users/slester/orgs","repos_url":"https://api.github.com/users/slester/repos","events_url":"https://api.github.com/users/slester/events{/privacy}","received_events_url":"https://api.github.com/users/slester/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/osquery/labels/CLA%20Signed","name":"CLA Signed","color":"009900"},{"url":"https://api.github.com/repos/facebook/osquery/labels/Hacktoberfest","name":"Hacktoberfest","color":"d93f0b"},{"url":"https://api.github.com/repos/facebook/osquery/labels/virtual%20tables","name":"virtual tables","color":"207de5"},{"url":"https://api.github.com/repos/facebook/osquery/labels/Windows","name":"Windows","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-10-06T05:13:18Z","updated_at":"2016-10-06T15:01:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/2595","html_url":"https://github.com/facebook/osquery/pull/2595","diff_url":"https://github.com/facebook/osquery/pull/2595.diff","patch_url":"https://github.com/facebook/osquery/pull/2595.patch"},"body":"Fixes #2594 as per request, using #2566 as a guide."},"comment":{"url":"https://api.github.com/repos/facebook/osquery/issues/comments/251989548","html_url":"https://github.com/facebook/osquery/pull/2595#issuecomment-251989548","issue_url":"https://api.github.com/repos/facebook/osquery/issues/2595","id":251989548,"user":{"login":"PoppySeedPlehzr","id":1328916,"avatar_url":"https://avatars.githubusercontent.com/u/1328916?v=3","gravatar_id":"","url":"https://api.github.com/users/PoppySeedPlehzr","html_url":"https://github.com/PoppySeedPlehzr","followers_url":"https://api.github.com/users/PoppySeedPlehzr/followers","following_url":"https://api.github.com/users/PoppySeedPlehzr/following{/other_user}","gists_url":"https://api.github.com/users/PoppySeedPlehzr/gists{/gist_id}","starred_url":"https://api.github.com/users/PoppySeedPlehzr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PoppySeedPlehzr/subscriptions","organizations_url":"https://api.github.com/users/PoppySeedPlehzr/orgs","repos_url":"https://api.github.com/users/PoppySeedPlehzr/repos","events_url":"https://api.github.com/users/PoppySeedPlehzr/events{/privacy}","received_events_url":"https://api.github.com/users/PoppySeedPlehzr/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T15:01:02Z","updated_at":"2016-10-06T15:01:02Z","body":"Huh..\r\n\r\nLooks like it didn't quite get there:\r\n```\r\ndiff --git a/osquery/tables/networking/etc_services.cpp b/osquery/tables/networking/etc_services.cpp\r\nindex 0478ee5..1db87a9 100644\r\n--- a/osquery/tables/networking/etc_services.cpp\r\n+++ b/osquery/tables/networking/etc_services.cpp\r\n@@ -30,7 +30,7 @@ namespace tables {\r\n #ifndef WIN32\r\n fs::path kServicesProtocols = \"/etc/services\";\r\n else fs::path kServicesProtocols =\r\n-  (getSystemRoot() / \"system32\\\\drivers\\\\etc\\\\services\");\r\n+    (getSystemRoot() / \"system32\\\\drivers\\\\etc\\\\services\");\r\n #endif\r\n```\r\n\r\nDo you have the [clang-format plugin for visual studio](http://clang.llvm.org/docs/ClangFormat.html#visual-studio-integration) installed?"}}
{"actor":{"display_login":"PoppySeedPlehzr"}}