{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/49946550","id":49946550,"diff_hunk":"@@ -72,13 +72,116 @@ def install_step(self):\n \n     def sanity_check_step(self):\n         \"\"\"Custom sanity check for picard\"\"\"\n-        jar_files = ['picard']\n-        if LooseVersion(self.version) < LooseVersion('1.115'):\n-            jar_files.append('sam')\n+        \"\"\"All versions prior to 1.124 have these jar files\"\"\"\n+        if LooseVersion(self.version) < LooseVersion('1.124'):\n+            jar_files = [\n+                'picard-%s' % self.version,\n+                \n+                'AddOrReplaceReadGroups',\n+                'BamIndexStats',\n+                'BamToBfq',\n+                'BuildBamIndex',\n+                'CalculateHsMetrics',\n+                'CheckIlluminaDirectory',\n+                'CleanSam',\n+                'CollectAlignmentSummaryMetrics',\n+                'CollectGcBiasMetrics',\n+                'CollectInsertSizeMetrics',\n+                'CollectMultipleMetrics',\n+                'CollectRnaSeqMetrics',\n+                'CollectTargetedPcrMetrics',\n+                'CompareSAMs',\n+                'CreateSequenceDictionary',\n+                'DownsampleSam',\n+                'EstimateLibraryComplexity',\n+                'ExtractIlluminaBarcodes',\n+                'ExtractSequences',\n+                'FastqToSam',\n+                'FilterSamReads',\n+                'FixMateInformation',\n+                'IlluminaBasecallsToFastq',\n+                'IlluminaBasecallsToSam',\n+                'IntervalListTools',\n+                'MakeSitesOnlyVcf',\n+                'MarkDuplicates',\n+                'MarkIlluminaAdapters',\n+                'MeanQualityByCycle',\n+                'MergeBamAlignment',\n+                'MergeSamFiles',\n+                'MergeVcfs',\n+                'NormalizeFasta',\n+                'QualityScoreDistribution',\n+                'ReorderSam',\n+                'ReplaceSamHeader',\n+                'RevertSam',\n+                'SamFormatConverter',\n+                'SamToFastq',\n+                'SortSam',\n+                'SplitVcfs',\n+                'ValidateSamFile',\n+                'VcfFormatConverter',\n+                'ViewSam',\n+            ]","path":"easybuild/easyblocks/p/picard.py","position":56,"original_position":56,"commit_id":"4eb1088d51045eae2343bb4e85bececbbeaa7039","original_commit_id":"4eb1088d51045eae2343bb4e85bececbbeaa7039","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"hmm, do we want this one per line? I'd collapse this by listing multiple items on a single line, but keeping it down to max 120 chars line length?","created_at":"2016-01-17T13:51:01Z","updated_at":"2016-01-17T13:51:01Z","html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/796#discussion_r49946550","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/49946550"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/796#discussion_r49946550"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796","id":55048600,"html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/796","diff_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/796.diff","patch_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/796.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/796","number":796,"state":"open","locked":false,"title":"Updated custom_paths for picard-1.124 and above","user":{"login":"nathanhaigh","id":2037575,"avatar_url":"https://avatars.githubusercontent.com/u/2037575?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanhaigh","html_url":"https://github.com/nathanhaigh","followers_url":"https://api.github.com/users/nathanhaigh/followers","following_url":"https://api.github.com/users/nathanhaigh/following{/other_user}","gists_url":"https://api.github.com/users/nathanhaigh/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhaigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhaigh/subscriptions","organizations_url":"https://api.github.com/users/nathanhaigh/orgs","repos_url":"https://api.github.com/users/nathanhaigh/repos","events_url":"https://api.github.com/users/nathanhaigh/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhaigh/received_events","type":"User","site_admin":false},"body":"A restructure of picard at v1.124 means only a single `picard.jar` file is created","created_at":"2016-01-05T02:35:55Z","updated_at":"2016-01-17T13:51:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00dad17bbdb4a3257671e5bf9a0adfc20a8a4235","assignee":null,"milestone":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones/23","html_url":"https://github.com/hpcugent/easybuild-easyblocks/milestones/v2.6.0","labels_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones/23/labels","id":1460230,"number":23,"title":"v2.6.0","description":"","creator":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":14,"state":"open","created_at":"2015-12-14T21:43:06Z","updated_at":"2016-01-16T22:01:35Z","due_on":"2016-01-25T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/796/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/4eb1088d51045eae2343bb4e85bececbbeaa7039","head":{"label":"nathanhaigh:picard-1.124","ref":"picard-1.124","sha":"4eb1088d51045eae2343bb4e85bececbbeaa7039","user":{"login":"nathanhaigh","id":2037575,"avatar_url":"https://avatars.githubusercontent.com/u/2037575?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanhaigh","html_url":"https://github.com/nathanhaigh","followers_url":"https://api.github.com/users/nathanhaigh/followers","following_url":"https://api.github.com/users/nathanhaigh/following{/other_user}","gists_url":"https://api.github.com/users/nathanhaigh/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhaigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhaigh/subscriptions","organizations_url":"https://api.github.com/users/nathanhaigh/orgs","repos_url":"https://api.github.com/users/nathanhaigh/repos","events_url":"https://api.github.com/users/nathanhaigh/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhaigh/received_events","type":"User","site_admin":false},"repo":{"id":49033316,"name":"easybuild-easyblocks","full_name":"nathanhaigh/easybuild-easyblocks","owner":{"login":"nathanhaigh","id":2037575,"avatar_url":"https://avatars.githubusercontent.com/u/2037575?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanhaigh","html_url":"https://github.com/nathanhaigh","followers_url":"https://api.github.com/users/nathanhaigh/followers","following_url":"https://api.github.com/users/nathanhaigh/following{/other_user}","gists_url":"https://api.github.com/users/nathanhaigh/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhaigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhaigh/subscriptions","organizations_url":"https://api.github.com/users/nathanhaigh/orgs","repos_url":"https://api.github.com/users/nathanhaigh/repos","events_url":"https://api.github.com/users/nathanhaigh/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhaigh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathanhaigh/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":true,"url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks","forks_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/releases{/id}","created_at":"2016-01-05T01:14:20Z","updated_at":"2016-01-05T01:14:23Z","pushed_at":"2016-01-12T06:19:40Z","git_url":"git://github.com/nathanhaigh/easybuild-easyblocks.git","ssh_url":"git@github.com:nathanhaigh/easybuild-easyblocks.git","clone_url":"https://github.com/nathanhaigh/easybuild-easyblocks.git","svn_url":"https://github.com/nathanhaigh/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":8201,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"db456c990732e77d236a18030cdf2d1c2a70d77a","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":6228378,"name":"easybuild-easyblocks","full_name":"hpcugent/easybuild-easyblocks","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks","forks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/releases{/id}","created_at":"2012-10-15T14:31:19Z","updated_at":"2015-12-08T11:13:40Z","pushed_at":"2016-01-16T21:59:18Z","git_url":"git://github.com/hpcugent/easybuild-easyblocks.git","ssh_url":"git@github.com:hpcugent/easybuild-easyblocks.git","clone_url":"https://github.com/hpcugent/easybuild-easyblocks.git","svn_url":"https://github.com/hpcugent/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":9565,"stargazers_count":29,"watchers_count":29,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":121,"forks":88,"open_issues":121,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/796"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/796"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/796/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/4eb1088d51045eae2343bb4e85bececbbeaa7039"}}}}