{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/comments/67354420","id":67354420,"diff_hunk":"@@ -84,9 +87,19 @@ public Logging logging()\n      * Max number of connections per URL for this driver.\n      * @return the max number of connections\n      */\n+    @Deprecated\n     public int connectionPoolSize()\n     {\n-        return connectionPoolSize;\n+        return maxIdleConnectionPoolSize;\n+    }\n+\n+    /**\n+     * Max number of idle connections per URL for this driver.\n+     * @return the max number of connections\n+     */\n+    public int maxIdleConnectionPoolSize()","path":"driver/src/main/java/org/neo4j/driver/v1/Config.java","position":32,"original_position":32,"commit_id":"dd2caa0fd47309cbb7a430ddb9306d4c042c38bd","original_commit_id":"dd2caa0fd47309cbb7a430ddb9306d4c042c38bd","user":{"login":"jakewins","id":182752,"avatar_url":"https://avatars.githubusercontent.com/u/182752?v=3","gravatar_id":"","url":"https://api.github.com/users/jakewins","html_url":"https://github.com/jakewins","followers_url":"https://api.github.com/users/jakewins/followers","following_url":"https://api.github.com/users/jakewins/following{/other_user}","gists_url":"https://api.github.com/users/jakewins/gists{/gist_id}","starred_url":"https://api.github.com/users/jakewins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakewins/subscriptions","organizations_url":"https://api.github.com/users/jakewins/orgs","repos_url":"https://api.github.com/users/jakewins/repos","events_url":"https://api.github.com/users/jakewins/events{/privacy}","received_events_url":"https://api.github.com/users/jakewins/received_events","type":"User","site_admin":false},"body":"Since we're deprecating the other `connectionPoolSize`, and the config option on the builder uses the word `session`, could we stealthily swap to use `session` here as well?","created_at":"2016-06-16T14:27:54Z","updated_at":"2016-06-16T14:27:54Z","html_url":"https://github.com/neo4j/neo4j-java-driver/pull/188#discussion_r67354420","pull_request_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/188","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/comments/67354420"},"html":{"href":"https://github.com/neo4j/neo4j-java-driver/pull/188#discussion_r67354420"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/188","id":73402488,"html_url":"https://github.com/neo4j/neo4j-java-driver/pull/188","diff_url":"https://github.com/neo4j/neo4j-java-driver/pull/188.diff","patch_url":"https://github.com/neo4j/neo4j-java-driver/pull/188.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/issues/188","number":188,"state":"open","locked":false,"title":"Change to a simpler session pool","user":{"login":"pontusmelke","id":88000,"avatar_url":"https://avatars.githubusercontent.com/u/88000?v=3","gravatar_id":"","url":"https://api.github.com/users/pontusmelke","html_url":"https://github.com/pontusmelke","followers_url":"https://api.github.com/users/pontusmelke/followers","following_url":"https://api.github.com/users/pontusmelke/following{/other_user}","gists_url":"https://api.github.com/users/pontusmelke/gists{/gist_id}","starred_url":"https://api.github.com/users/pontusmelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pontusmelke/subscriptions","organizations_url":"https://api.github.com/users/pontusmelke/orgs","repos_url":"https://api.github.com/users/pontusmelke/repos","events_url":"https://api.github.com/users/pontusmelke/events{/privacy}","received_events_url":"https://api.github.com/users/pontusmelke/received_events","type":"User","site_admin":false},"body":"This PR removes the fixed size session pool and replaces it with a simple queue.","created_at":"2016-06-10T16:43:55Z","updated_at":"2016-06-16T14:27:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b6f19b53c570e5bbe1ccbfabd5464f50a387cbd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/188/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/188/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/issues/188/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/statuses/dd2caa0fd47309cbb7a430ddb9306d4c042c38bd","head":{"label":"pontusmelke:1.0-new-pool","ref":"1.0-new-pool","sha":"dd2caa0fd47309cbb7a430ddb9306d4c042c38bd","user":{"login":"pontusmelke","id":88000,"avatar_url":"https://avatars.githubusercontent.com/u/88000?v=3","gravatar_id":"","url":"https://api.github.com/users/pontusmelke","html_url":"https://github.com/pontusmelke","followers_url":"https://api.github.com/users/pontusmelke/followers","following_url":"https://api.github.com/users/pontusmelke/following{/other_user}","gists_url":"https://api.github.com/users/pontusmelke/gists{/gist_id}","starred_url":"https://api.github.com/users/pontusmelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pontusmelke/subscriptions","organizations_url":"https://api.github.com/users/pontusmelke/orgs","repos_url":"https://api.github.com/users/pontusmelke/repos","events_url":"https://api.github.com/users/pontusmelke/events{/privacy}","received_events_url":"https://api.github.com/users/pontusmelke/received_events","type":"User","site_admin":false},"repo":{"id":46676884,"name":"neo4j-java-driver","full_name":"pontusmelke/neo4j-java-driver","owner":{"login":"pontusmelke","id":88000,"avatar_url":"https://avatars.githubusercontent.com/u/88000?v=3","gravatar_id":"","url":"https://api.github.com/users/pontusmelke","html_url":"https://github.com/pontusmelke","followers_url":"https://api.github.com/users/pontusmelke/followers","following_url":"https://api.github.com/users/pontusmelke/following{/other_user}","gists_url":"https://api.github.com/users/pontusmelke/gists{/gist_id}","starred_url":"https://api.github.com/users/pontusmelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pontusmelke/subscriptions","organizations_url":"https://api.github.com/users/pontusmelke/orgs","repos_url":"https://api.github.com/users/pontusmelke/repos","events_url":"https://api.github.com/users/pontusmelke/events{/privacy}","received_events_url":"https://api.github.com/users/pontusmelke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pontusmelke/neo4j-java-driver","description":"[ALPHA] Java driver for Neo4j binary protocol","fork":true,"url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver","forks_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/forks","keys_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/teams","hooks_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/hooks","issue_events_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/issues/events{/number}","events_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/events","assignees_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/assignees{/user}","branches_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/branches{/branch}","tags_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/tags","blobs_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/languages","stargazers_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/stargazers","contributors_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/contributors","subscribers_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/subscribers","subscription_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/subscription","commits_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/contents/{+path}","compare_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/merges","archive_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/downloads","issues_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/issues{/number}","pulls_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/labels{/name}","releases_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/releases{/id}","deployments_url":"https://api.github.com/repos/pontusmelke/neo4j-java-driver/deployments","created_at":"2015-11-22T19:47:37Z","updated_at":"2015-11-22T19:47:38Z","pushed_at":"2016-06-10T16:56:23Z","git_url":"git://github.com/pontusmelke/neo4j-java-driver.git","ssh_url":"git@github.com:pontusmelke/neo4j-java-driver.git","clone_url":"https://github.com/pontusmelke/neo4j-java-driver.git","svn_url":"https://github.com/pontusmelke/neo4j-java-driver","homepage":"","size":1796,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:1.0","ref":"1.0","sha":"c7e0fbae4739cc35357925cab1d03281c84100f3","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":34007506,"name":"neo4j-java-driver","full_name":"neo4j/neo4j-java-driver","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j-java-driver","description":"Neo4j Bolt driver for Java","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j-java-driver","forks_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j-java-driver/deployments","created_at":"2015-04-15T17:08:15Z","updated_at":"2016-06-16T06:47:11Z","pushed_at":"2016-06-15T14:50:11Z","git_url":"git://github.com/neo4j/neo4j-java-driver.git","ssh_url":"git@github.com:neo4j/neo4j-java-driver.git","clone_url":"https://github.com/neo4j/neo4j-java-driver.git","svn_url":"https://github.com/neo4j/neo4j-java-driver","homepage":"","size":2040,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":7,"forks":29,"open_issues":7,"watchers":44,"default_branch":"1.1"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/188"},"html":{"href":"https://github.com/neo4j/neo4j-java-driver/pull/188"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j-java-driver/issues/188"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j-java-driver/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j-java-driver/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j-java-driver/statuses/dd2caa0fd47309cbb7a430ddb9306d4c042c38bd"}}}}
{"actor":{"display_login":"jakewins"}}