{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/comments/92305866","pull_request_review_id":12818559,"id":92305866,"diff_hunk":"@@ -21,5 +21,19 @@ metrics: {\n             enabled: true\n         }\n     }\n+\n+    jolokia {\n+      # Enable or disable the Jolokia-based metrics/v2 endpoint.\n+      # Default is true.\n+      enabled: false\n+\n+      # Configure any of the settings listed at:\n+      #   https://jolokia.org/reference/html/agents.html#war-agent-installation\n+      config: {\n+        # Specify a custom security policy:\n+        #  https://jolokia.org/reference/html/security.html\n+        policyLocation: \"file:///etc/puppetlabs/<service name>/jolokia-access.xml\"","path":"documentation/configuration.md","position":15,"original_position":15,"commit_id":"6634f7a919ed0aea121be8fb642fd44c3b9cf300","original_commit_id":"b343947b03d522bf5e56e2e12dcb474528b3eaf8","user":{"login":"rlinehan","id":1530016,"avatar_url":"https://avatars.githubusercontent.com/u/1530016?v=3","gravatar_id":"","url":"https://api.github.com/users/rlinehan","html_url":"https://github.com/rlinehan","followers_url":"https://api.github.com/users/rlinehan/followers","following_url":"https://api.github.com/users/rlinehan/following{/other_user}","gists_url":"https://api.github.com/users/rlinehan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlinehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlinehan/subscriptions","organizations_url":"https://api.github.com/users/rlinehan/orgs","repos_url":"https://api.github.com/users/rlinehan/repos","events_url":"https://api.github.com/users/rlinehan/events{/privacy}","received_events_url":"https://api.github.com/users/rlinehan/received_events","type":"User","site_admin":false},"body":"The only thing I would say on this is that in the documentation linked, all of these parameters are listed under a table named `Servlet Init Parameters`, so naming this section something like `servlet-init-params` might actually signal that you can use anything in that list.","created_at":"2016-12-14T01:27:33Z","updated_at":"2016-12-14T01:27:33Z","html_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/31#discussion_r92305866","pull_request_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/comments/92305866"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/31#discussion_r92305866"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/31","id":85638444,"html_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/31","diff_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/31.diff","patch_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/31.patch","issue_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/31","number":31,"state":"open","locked":false,"title":"(TK-404) Add jolokia Servlet as metrics/v2","user":{"login":"Sharpie","id":54181,"avatar_url":"https://avatars.githubusercontent.com/u/54181?v=3","gravatar_id":"","url":"https://api.github.com/users/Sharpie","html_url":"https://github.com/Sharpie","followers_url":"https://api.github.com/users/Sharpie/followers","following_url":"https://api.github.com/users/Sharpie/following{/other_user}","gists_url":"https://api.github.com/users/Sharpie/gists{/gist_id}","starred_url":"https://api.github.com/users/Sharpie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sharpie/subscriptions","organizations_url":"https://api.github.com/users/Sharpie/orgs","repos_url":"https://api.github.com/users/Sharpie/repos","events_url":"https://api.github.com/users/Sharpie/events{/privacy}","received_events_url":"https://api.github.com/users/Sharpie/received_events","type":"User","site_admin":false},"body":"This patch adds the jolokia-core library to the dependency list and\nmounts its servlet at 'metrics/v2' when the `metrics-webservice` is in\nuse. Jolokia is a small library that wraps a REST API around JMX and\nprovides great features such as globbing, attribute extraction and much\nmore.\n\nExample query using globbing and parameter extraction:\n\n```\ncurl -k 'https://localhost:8140/metrics/v2/read/java.lang:name=*,type=GarbageCollector/CollectionCount,CollectionTime'\n```\n\n**CAVEATS**\n- The Jolokia API also exposes JMX control functionality, so \"write\"\n  and \"exec\" operations are currently restricted by a static\n  authorization configuration in `resources/jolokia-access.xml`.\n- The servlet is currently mounted directly using the WebserverService\n  add-servlet-handler method, instead of going through the comidi\n  routes defined in:\n  \n  ```\n  puppetlabs.trapperkeeper.services.metrics.metrics-core\n  ```\n","created_at":"2016-09-16T20:54:45Z","updated_at":"2016-12-14T01:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f65a1ff559c4c826bd548576b7f02f8a8419ba55","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/31/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/31/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/31/comments","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/statuses/6634f7a919ed0aea121be8fb642fd44c3b9cf300","head":{"label":"Sharpie:spike-jolokia","ref":"spike-jolokia","sha":"6634f7a919ed0aea121be8fb642fd44c3b9cf300","user":{"login":"Sharpie","id":54181,"avatar_url":"https://avatars.githubusercontent.com/u/54181?v=3","gravatar_id":"","url":"https://api.github.com/users/Sharpie","html_url":"https://github.com/Sharpie","followers_url":"https://api.github.com/users/Sharpie/followers","following_url":"https://api.github.com/users/Sharpie/following{/other_user}","gists_url":"https://api.github.com/users/Sharpie/gists{/gist_id}","starred_url":"https://api.github.com/users/Sharpie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sharpie/subscriptions","organizations_url":"https://api.github.com/users/Sharpie/orgs","repos_url":"https://api.github.com/users/Sharpie/repos","events_url":"https://api.github.com/users/Sharpie/events{/privacy}","received_events_url":"https://api.github.com/users/Sharpie/received_events","type":"User","site_admin":false},"repo":{"id":68411088,"name":"trapperkeeper-metrics","full_name":"Sharpie/trapperkeeper-metrics","owner":{"login":"Sharpie","id":54181,"avatar_url":"https://avatars.githubusercontent.com/u/54181?v=3","gravatar_id":"","url":"https://api.github.com/users/Sharpie","html_url":"https://github.com/Sharpie","followers_url":"https://api.github.com/users/Sharpie/followers","following_url":"https://api.github.com/users/Sharpie/following{/other_user}","gists_url":"https://api.github.com/users/Sharpie/gists{/gist_id}","starred_url":"https://api.github.com/users/Sharpie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sharpie/subscriptions","organizations_url":"https://api.github.com/users/Sharpie/orgs","repos_url":"https://api.github.com/users/Sharpie/repos","events_url":"https://api.github.com/users/Sharpie/events{/privacy}","received_events_url":"https://api.github.com/users/Sharpie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sharpie/trapperkeeper-metrics","description":null,"fork":true,"url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics","forks_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/forks","keys_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/teams","hooks_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/hooks","issue_events_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/events","assignees_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/tags","blobs_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/languages","stargazers_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/stargazers","contributors_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/contributors","subscribers_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/subscribers","subscription_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/subscription","commits_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/merges","archive_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/downloads","issues_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/labels{/name}","releases_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/Sharpie/trapperkeeper-metrics/deployments","created_at":"2016-09-16T20:03:17Z","updated_at":"2016-09-16T20:03:18Z","pushed_at":"2016-12-12T19:13:46Z","git_url":"git://github.com/Sharpie/trapperkeeper-metrics.git","ssh_url":"git@github.com:Sharpie/trapperkeeper-metrics.git","clone_url":"https://github.com/Sharpie/trapperkeeper-metrics.git","svn_url":"https://github.com/Sharpie/trapperkeeper-metrics","homepage":null,"size":75,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"570a2b7d27147ba59e74f0a5253bf1c7bff3dc6a","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":37654950,"name":"trapperkeeper-metrics","full_name":"puppetlabs/trapperkeeper-metrics","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/trapperkeeper-metrics","description":null,"fork":false,"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics","forks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/forks","keys_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/teams","hooks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/events","assignees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/tags","blobs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/subscription","commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/merges","archive_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/downloads","issues_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/deployments","created_at":"2015-06-18T11:13:03Z","updated_at":"2016-12-11T22:31:12Z","pushed_at":"2016-12-13T19:09:24Z","git_url":"git://github.com/puppetlabs/trapperkeeper-metrics.git","ssh_url":"git@github.com:puppetlabs/trapperkeeper-metrics.git","clone_url":"https://github.com/puppetlabs/trapperkeeper-metrics.git","svn_url":"https://github.com/puppetlabs/trapperkeeper-metrics","homepage":null,"size":89,"stargazers_count":3,"watchers_count":3,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/31"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/31"},"issue":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/31"},"comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/statuses/6634f7a919ed0aea121be8fb642fd44c3b9cf300"}}}}
{"actor":{"display_login":"rlinehan"}}