{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1803","repository_url":"https://api.github.com/repos/Microsoft/ChakraCore","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1803/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1803/comments","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1803/events","html_url":"https://github.com/Microsoft/ChakraCore/pull/1803","id":184589169,"number":1803,"title":"Fixing on reentrant parsemodulesource.","user":{"login":"akroshg","id":13008822,"avatar_url":"https://avatars.githubusercontent.com/u/13008822?v=3","gravatar_id":"","url":"https://api.github.com/users/akroshg","html_url":"https://github.com/akroshg","followers_url":"https://api.github.com/users/akroshg/followers","following_url":"https://api.github.com/users/akroshg/following{/other_user}","gists_url":"https://api.github.com/users/akroshg/gists{/gist_id}","starred_url":"https://api.github.com/users/akroshg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akroshg/subscriptions","organizations_url":"https://api.github.com/users/akroshg/orgs","repos_url":"https://api.github.com/users/akroshg/repos","events_url":"https://api.github.com/users/akroshg/events{/privacy}","received_events_url":"https://api.github.com/users/akroshg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/cla-not-required","name":"cla-not-required","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-21T23:11:56Z","updated_at":"2016-10-21T23:12:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1803","html_url":"https://github.com/Microsoft/ChakraCore/pull/1803","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1803.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1803.patch"},"body":"When we get the ParseModuleSource while we fetch module - we go into a state where we don't notify the host about the error or ready state. That makes the module hung.\nFixed that by setting parent and child relation in the InitializeModuleRecord. That way when the ParseModuleSource re-entrancy happens and we can bubble up the error/ready state to parent properly.\nAdded native unittest for forcing the re-entrant parsemodulesource.\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments/255486598","html_url":"https://github.com/Microsoft/ChakraCore/pull/1803#issuecomment-255486598","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1803","id":255486598,"user":{"login":"akroshg","id":13008822,"avatar_url":"https://avatars.githubusercontent.com/u/13008822?v=3","gravatar_id":"","url":"https://api.github.com/users/akroshg","html_url":"https://github.com/akroshg","followers_url":"https://api.github.com/users/akroshg/followers","following_url":"https://api.github.com/users/akroshg/following{/other_user}","gists_url":"https://api.github.com/users/akroshg/gists{/gist_id}","starred_url":"https://api.github.com/users/akroshg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akroshg/subscriptions","organizations_url":"https://api.github.com/users/akroshg/orgs","repos_url":"https://api.github.com/users/akroshg/repos","events_url":"https://api.github.com/users/akroshg/events{/privacy}","received_events_url":"https://api.github.com/users/akroshg/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T23:12:53Z","updated_at":"2016-10-21T23:12:53Z","body":"@boingoing please have a look"}}
{"actor":{"display_login":"akroshg"}}