{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/http-remoting/pulls/comments/58962371","id":58962371,"diff_hunk":"@@ -134,6 +139,41 @@ public static FeignClientFactory of(\n     }\n \n     /**\n+     * Constructs a dynamic proxy for the specified type using the supplied {@link ServiceConfiguration}. If the SSL\n+     * configuration is not present in the {@link ServiceConfiguration}, the fallback SSL configuration will be used.\n+     */\n+    public <T> T createProxies(\n+            ServiceConfiguration serviceConfig,\n+            Optional<SslConfiguration> fallbackSslConfiguration,\n+            Class<T> serviceClass) {\n+\n+        Optional<SSLSocketFactory> socketFactory = Optional.absent();\n+        Optional<SslConfiguration> sslConfig = serviceConfig.security().or(fallbackSslConfiguration);\n+\n+        if (sslConfig.isPresent()) {","path":"http-clients/src/main/java/com/palantir/remoting/http/FeignClientFactory.java","position":27,"original_position":27,"commit_id":"ea734e1b300c6e1719d56ef2f0a15305560d5ecc","original_commit_id":"ea734e1b300c6e1719d56ef2f0a15305560d5ecc","user":{"login":"uschi2000","id":6528449,"avatar_url":"https://avatars.githubusercontent.com/u/6528449?v=3","gravatar_id":"","url":"https://api.github.com/users/uschi2000","html_url":"https://github.com/uschi2000","followers_url":"https://api.github.com/users/uschi2000/followers","following_url":"https://api.github.com/users/uschi2000/following{/other_user}","gists_url":"https://api.github.com/users/uschi2000/gists{/gist_id}","starred_url":"https://api.github.com/users/uschi2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uschi2000/subscriptions","organizations_url":"https://api.github.com/users/uschi2000/orgs","repos_url":"https://api.github.com/users/uschi2000/repos","events_url":"https://api.github.com/users/uschi2000/events{/privacy}","received_events_url":"https://api.github.com/users/uschi2000/received_events","type":"User","site_admin":false},"body":"can probably use the functional primitives of Optional (transform/map)","created_at":"2016-04-07T23:37:46Z","updated_at":"2016-04-07T23:37:46Z","html_url":"https://github.com/palantir/http-remoting/pull/96#discussion_r58962371","pull_request_url":"https://api.github.com/repos/palantir/http-remoting/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/comments/58962371"},"html":{"href":"https://github.com/palantir/http-remoting/pull/96#discussion_r58962371"},"pull_request":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/http-remoting/pulls/96","id":65340699,"html_url":"https://github.com/palantir/http-remoting/pull/96","diff_url":"https://github.com/palantir/http-remoting/pull/96.diff","patch_url":"https://github.com/palantir/http-remoting/pull/96.patch","issue_url":"https://api.github.com/repos/palantir/http-remoting/issues/96","number":96,"state":"open","locked":false,"title":"add service config","user":{"login":"qinfchen","id":8294715,"avatar_url":"https://avatars.githubusercontent.com/u/8294715?v=3","gravatar_id":"","url":"https://api.github.com/users/qinfchen","html_url":"https://github.com/qinfchen","followers_url":"https://api.github.com/users/qinfchen/followers","following_url":"https://api.github.com/users/qinfchen/following{/other_user}","gists_url":"https://api.github.com/users/qinfchen/gists{/gist_id}","starred_url":"https://api.github.com/users/qinfchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinfchen/subscriptions","organizations_url":"https://api.github.com/users/qinfchen/orgs","repos_url":"https://api.github.com/users/qinfchen/repos","events_url":"https://api.github.com/users/qinfchen/events{/privacy}","received_events_url":"https://api.github.com/users/qinfchen/received_events","type":"User","site_admin":false},"body":"https://palantir.quip.com/Ws4jA8hEmDTV","created_at":"2016-04-05T17:10:36Z","updated_at":"2016-04-07T23:37:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"974baa9f33af98f9ec853829f07ab87dfd0019c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/palantir/http-remoting/pulls/96/commits","review_comments_url":"https://api.github.com/repos/palantir/http-remoting/pulls/96/comments","review_comment_url":"https://api.github.com/repos/palantir/http-remoting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/http-remoting/issues/96/comments","statuses_url":"https://api.github.com/repos/palantir/http-remoting/statuses/ea734e1b300c6e1719d56ef2f0a15305560d5ecc","head":{"label":"qinfchen:qchen/serviceConfig","ref":"qchen/serviceConfig","sha":"ea734e1b300c6e1719d56ef2f0a15305560d5ecc","user":{"login":"qinfchen","id":8294715,"avatar_url":"https://avatars.githubusercontent.com/u/8294715?v=3","gravatar_id":"","url":"https://api.github.com/users/qinfchen","html_url":"https://github.com/qinfchen","followers_url":"https://api.github.com/users/qinfchen/followers","following_url":"https://api.github.com/users/qinfchen/following{/other_user}","gists_url":"https://api.github.com/users/qinfchen/gists{/gist_id}","starred_url":"https://api.github.com/users/qinfchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinfchen/subscriptions","organizations_url":"https://api.github.com/users/qinfchen/orgs","repos_url":"https://api.github.com/users/qinfchen/repos","events_url":"https://api.github.com/users/qinfchen/events{/privacy}","received_events_url":"https://api.github.com/users/qinfchen/received_events","type":"User","site_admin":false},"repo":{"id":48061648,"name":"http-remoting","full_name":"qinfchen/http-remoting","owner":{"login":"qinfchen","id":8294715,"avatar_url":"https://avatars.githubusercontent.com/u/8294715?v=3","gravatar_id":"","url":"https://api.github.com/users/qinfchen","html_url":"https://github.com/qinfchen","followers_url":"https://api.github.com/users/qinfchen/followers","following_url":"https://api.github.com/users/qinfchen/following{/other_user}","gists_url":"https://api.github.com/users/qinfchen/gists{/gist_id}","starred_url":"https://api.github.com/users/qinfchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinfchen/subscriptions","organizations_url":"https://api.github.com/users/qinfchen/orgs","repos_url":"https://api.github.com/users/qinfchen/repos","events_url":"https://api.github.com/users/qinfchen/events{/privacy}","received_events_url":"https://api.github.com/users/qinfchen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qinfchen/http-remoting","description":"a collection of useful utilities for use with HTTP remoting setups that use Feign as a client and Jersey as a server","fork":true,"url":"https://api.github.com/repos/qinfchen/http-remoting","forks_url":"https://api.github.com/repos/qinfchen/http-remoting/forks","keys_url":"https://api.github.com/repos/qinfchen/http-remoting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qinfchen/http-remoting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qinfchen/http-remoting/teams","hooks_url":"https://api.github.com/repos/qinfchen/http-remoting/hooks","issue_events_url":"https://api.github.com/repos/qinfchen/http-remoting/issues/events{/number}","events_url":"https://api.github.com/repos/qinfchen/http-remoting/events","assignees_url":"https://api.github.com/repos/qinfchen/http-remoting/assignees{/user}","branches_url":"https://api.github.com/repos/qinfchen/http-remoting/branches{/branch}","tags_url":"https://api.github.com/repos/qinfchen/http-remoting/tags","blobs_url":"https://api.github.com/repos/qinfchen/http-remoting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qinfchen/http-remoting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qinfchen/http-remoting/git/refs{/sha}","trees_url":"https://api.github.com/repos/qinfchen/http-remoting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qinfchen/http-remoting/statuses/{sha}","languages_url":"https://api.github.com/repos/qinfchen/http-remoting/languages","stargazers_url":"https://api.github.com/repos/qinfchen/http-remoting/stargazers","contributors_url":"https://api.github.com/repos/qinfchen/http-remoting/contributors","subscribers_url":"https://api.github.com/repos/qinfchen/http-remoting/subscribers","subscription_url":"https://api.github.com/repos/qinfchen/http-remoting/subscription","commits_url":"https://api.github.com/repos/qinfchen/http-remoting/commits{/sha}","git_commits_url":"https://api.github.com/repos/qinfchen/http-remoting/git/commits{/sha}","comments_url":"https://api.github.com/repos/qinfchen/http-remoting/comments{/number}","issue_comment_url":"https://api.github.com/repos/qinfchen/http-remoting/issues/comments{/number}","contents_url":"https://api.github.com/repos/qinfchen/http-remoting/contents/{+path}","compare_url":"https://api.github.com/repos/qinfchen/http-remoting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qinfchen/http-remoting/merges","archive_url":"https://api.github.com/repos/qinfchen/http-remoting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qinfchen/http-remoting/downloads","issues_url":"https://api.github.com/repos/qinfchen/http-remoting/issues{/number}","pulls_url":"https://api.github.com/repos/qinfchen/http-remoting/pulls{/number}","milestones_url":"https://api.github.com/repos/qinfchen/http-remoting/milestones{/number}","notifications_url":"https://api.github.com/repos/qinfchen/http-remoting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qinfchen/http-remoting/labels{/name}","releases_url":"https://api.github.com/repos/qinfchen/http-remoting/releases{/id}","deployments_url":"https://api.github.com/repos/qinfchen/http-remoting/deployments","created_at":"2015-12-15T18:35:07Z","updated_at":"2016-04-05T21:41:47Z","pushed_at":"2016-04-07T02:07:53Z","git_url":"git://github.com/qinfchen/http-remoting.git","ssh_url":"git@github.com:qinfchen/http-remoting.git","clone_url":"https://github.com/qinfchen/http-remoting.git","svn_url":"https://github.com/qinfchen/http-remoting","homepage":"","size":316,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"cc8d92c6a4cc0e3147bc90404441d31d269f3298","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":43088077,"name":"http-remoting","full_name":"palantir/http-remoting","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/http-remoting","description":"a collection of useful utilities for use with HTTP remoting setups that use Feign as a client and Jersey as a server","fork":false,"url":"https://api.github.com/repos/palantir/http-remoting","forks_url":"https://api.github.com/repos/palantir/http-remoting/forks","keys_url":"https://api.github.com/repos/palantir/http-remoting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/http-remoting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/http-remoting/teams","hooks_url":"https://api.github.com/repos/palantir/http-remoting/hooks","issue_events_url":"https://api.github.com/repos/palantir/http-remoting/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/http-remoting/events","assignees_url":"https://api.github.com/repos/palantir/http-remoting/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/http-remoting/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/http-remoting/tags","blobs_url":"https://api.github.com/repos/palantir/http-remoting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/http-remoting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/http-remoting/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/http-remoting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/http-remoting/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/http-remoting/languages","stargazers_url":"https://api.github.com/repos/palantir/http-remoting/stargazers","contributors_url":"https://api.github.com/repos/palantir/http-remoting/contributors","subscribers_url":"https://api.github.com/repos/palantir/http-remoting/subscribers","subscription_url":"https://api.github.com/repos/palantir/http-remoting/subscription","commits_url":"https://api.github.com/repos/palantir/http-remoting/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/http-remoting/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/http-remoting/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/http-remoting/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/http-remoting/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/http-remoting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/http-remoting/merges","archive_url":"https://api.github.com/repos/palantir/http-remoting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/http-remoting/downloads","issues_url":"https://api.github.com/repos/palantir/http-remoting/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/http-remoting/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/http-remoting/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/http-remoting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/http-remoting/labels{/name}","releases_url":"https://api.github.com/repos/palantir/http-remoting/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/http-remoting/deployments","created_at":"2015-09-24T19:24:22Z","updated_at":"2016-03-21T15:57:44Z","pushed_at":"2016-04-07T23:19:14Z","git_url":"git://github.com/palantir/http-remoting.git","ssh_url":"git@github.com:palantir/http-remoting.git","clone_url":"https://github.com/palantir/http-remoting.git","svn_url":"https://github.com/palantir/http-remoting","homepage":"","size":398,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":13,"forks":16,"open_issues":13,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/96"},"html":{"href":"https://github.com/palantir/http-remoting/pull/96"},"issue":{"href":"https://api.github.com/repos/palantir/http-remoting/issues/96"},"comments":{"href":"https://api.github.com/repos/palantir/http-remoting/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/http-remoting/statuses/ea734e1b300c6e1719d56ef2f0a15305560d5ecc"}}}}