{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/58078713","id":58078713,"diff_hunk":"@@ -698,3 +671,48 @@ def isochrone(self, request, instance):\n                 del resp.journeys[request[\"max_nb_journeys\"]:]\n \n         return resp\n+\n+    def create_next_kraken_request(self, request, responses):\n+        \"\"\"\n+        create a new request dict to call the next (resp previous for non clockwise search) journeys in kraken\n+\n+        to do that we find the best journey (soonest arrival, then shortest journey) found in the responses\n+        and add one second to it's departure.\n+        (if anticlockwise, remove one second to the arrival of the journey with latest departure, then shortest)\n+        \"\"\"\n+        if request[\"clockwise\"]:\n+            request['datetime'] = self.next_journey_datetime([j for r in responses for j in r.journeys])\n+        else:\n+            request['datetime'] = self.previous_journey_datetime([j for r in responses for j in r.journeys])\n+\n+        if request['datetime'] is None:\n+            return None\n+\n+        #TODO forbid ODTs\n+        return request\n+\n+    def __get_best_for_criteria(self, journeys, criteria):","path":"source/jormungandr/jormungandr/scenarios/new_default.py","position":86,"original_position":86,"commit_id":"618286841d61d8cd87858bd0d67e430b4c6fc2b5","original_commit_id":"618286841d61d8cd87858bd0d67e430b4c6fc2b5","user":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"body":"static method?","created_at":"2016-03-31T15:53:33Z","updated_at":"2016-03-31T15:53:33Z","html_url":"https://github.com/CanalTP/navitia/pull/1509#discussion_r58078713","pull_request_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1509","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/58078713"},"html":{"href":"https://github.com/CanalTP/navitia/pull/1509#discussion_r58078713"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1509"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/1509","id":64657591,"html_url":"https://github.com/CanalTP/navitia/pull/1509","diff_url":"https://github.com/CanalTP/navitia/pull/1509.diff","patch_url":"https://github.com/CanalTP/navitia/pull/1509.patch","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/1509","number":1509,"state":"open","locked":false,"title":"Jormungandr: refactor journeys links","user":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?v=3","gravatar_id":"","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"body":"links were done in several places.\r\n\r\nthey are now done in 1 place: the scenarios\r\n\r\nThis way each scenario can use the same mechanims as the internal one to fill the journeys with the min_nb_journeys parameter\r\n\r\nlinked to http://jira.canaltp.fr/browse/NAVITIAII-2079\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/canaltp/navitia/1509)\n<!-- Reviewable:end -->\n","created_at":"2016-03-30T16:32:49Z","updated_at":"2016-03-31T15:53:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6715bd18dc7f884b8eae717a5d7c89a356e1406","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1509/commits","review_comments_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1509/comments","review_comment_url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/1509/comments","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/618286841d61d8cd87858bd0d67e430b4c6fc2b5","head":{"label":"antoine-de:prev-next","ref":"prev-next","sha":"618286841d61d8cd87858bd0d67e430b4c6fc2b5","user":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?v=3","gravatar_id":"","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"repo":{"id":19144843,"name":"navitia","full_name":"antoine-de/navitia","owner":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?v=3","gravatar_id":"","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antoine-de/navitia","description":"","fork":true,"url":"https://api.github.com/repos/antoine-de/navitia","forks_url":"https://api.github.com/repos/antoine-de/navitia/forks","keys_url":"https://api.github.com/repos/antoine-de/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antoine-de/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antoine-de/navitia/teams","hooks_url":"https://api.github.com/repos/antoine-de/navitia/hooks","issue_events_url":"https://api.github.com/repos/antoine-de/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/antoine-de/navitia/events","assignees_url":"https://api.github.com/repos/antoine-de/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/antoine-de/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/antoine-de/navitia/tags","blobs_url":"https://api.github.com/repos/antoine-de/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antoine-de/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antoine-de/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/antoine-de/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antoine-de/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/antoine-de/navitia/languages","stargazers_url":"https://api.github.com/repos/antoine-de/navitia/stargazers","contributors_url":"https://api.github.com/repos/antoine-de/navitia/contributors","subscribers_url":"https://api.github.com/repos/antoine-de/navitia/subscribers","subscription_url":"https://api.github.com/repos/antoine-de/navitia/subscription","commits_url":"https://api.github.com/repos/antoine-de/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/antoine-de/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/antoine-de/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/antoine-de/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/antoine-de/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/antoine-de/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antoine-de/navitia/merges","archive_url":"https://api.github.com/repos/antoine-de/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antoine-de/navitia/downloads","issues_url":"https://api.github.com/repos/antoine-de/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/antoine-de/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/antoine-de/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/antoine-de/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antoine-de/navitia/labels{/name}","releases_url":"https://api.github.com/repos/antoine-de/navitia/releases{/id}","deployments_url":"https://api.github.com/repos/antoine-de/navitia/deployments","created_at":"2014-04-25T12:12:04Z","updated_at":"2016-03-24T10:12:05Z","pushed_at":"2016-03-31T13:18:21Z","git_url":"git://github.com/antoine-de/navitia.git","ssh_url":"git@github.com:antoine-de/navitia.git","clone_url":"https://github.com/antoine-de/navitia.git","svn_url":"https://github.com/antoine-de/navitia","homepage":"http://www.navitia.io/","size":29896,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"CanalTP:dev","ref":"dev","sha":"274041815cfb3bf4f20c30a0e297275cb6cd2f47","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797333,"name":"navitia","full_name":"CanalTP/navitia","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/navitia","description":"The open source software to build responsive stuff with locomotion","fork":false,"url":"https://api.github.com/repos/CanalTP/navitia","forks_url":"https://api.github.com/repos/CanalTP/navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/navitia/releases{/id}","deployments_url":"https://api.github.com/repos/CanalTP/navitia/deployments","created_at":"2013-06-19T15:34:30Z","updated_at":"2016-03-28T10:02:47Z","pushed_at":"2016-03-31T13:48:46Z","git_url":"git://github.com/CanalTP/navitia.git","ssh_url":"git@github.com:CanalTP/navitia.git","clone_url":"https://github.com/CanalTP/navitia.git","svn_url":"https://github.com/CanalTP/navitia","homepage":"http://www.navitia.io","size":34420,"stargazers_count":159,"watchers_count":159,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":15,"forks":53,"open_issues":15,"watchers":159,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1509"},"html":{"href":"https://github.com/CanalTP/navitia/pull/1509"},"issue":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1509"},"comments":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1509/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1509/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1509/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/navitia/statuses/618286841d61d8cd87858bd0d67e430b4c6fc2b5"}}}}