{"action":"created","comment":{"url":"https://api.github.com/repos/ndoit/fenrir/pulls/comments/64459783","id":64459783,"diff_hunk":"@@ -0,0 +1,16 @@\n+// this code changes the read more button to drop down and go back up-\n+// displaying more or displaying less description\n+$(document).ready(function () {\n+  $('#read-button').click(function () {\n+    $('#read-button').toggleClass('read-more-button read-less-button');\n+\n+    if ($('#read-button').text() == 'Read Less') {","path":"app/assets/javascripts/read_more.js","position":7,"original_position":7,"commit_id":"cbc4b3f704b68d5e9d1dd45c7488497ff10e6ef7","original_commit_id":"cbc4b3f704b68d5e9d1dd45c7488497ff10e6ef7","user":{"login":"RyanSnodgrass","id":7104855,"avatar_url":"https://avatars.githubusercontent.com/u/7104855?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanSnodgrass","html_url":"https://github.com/RyanSnodgrass","followers_url":"https://api.github.com/users/RyanSnodgrass/followers","following_url":"https://api.github.com/users/RyanSnodgrass/following{/other_user}","gists_url":"https://api.github.com/users/RyanSnodgrass/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanSnodgrass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanSnodgrass/subscriptions","organizations_url":"https://api.github.com/users/RyanSnodgrass/orgs","repos_url":"https://api.github.com/users/RyanSnodgrass/repos","events_url":"https://api.github.com/users/RyanSnodgrass/events{/privacy}","received_events_url":"https://api.github.com/users/RyanSnodgrass/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [\"$\" is not defined.](https://www.codacy.com/app/ryansnodgrass-dev/fenrir/file/2626709340/issues/source?bid=3285068&fileBranchId=3316712#l7)","created_at":"2016-05-24T19:37:51Z","updated_at":"2016-05-24T19:37:51Z","html_url":"https://github.com/ndoit/fenrir/pull/203#discussion_r64459783","pull_request_url":"https://api.github.com/repos/ndoit/fenrir/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/comments/64459783"},"html":{"href":"https://github.com/ndoit/fenrir/pull/203#discussion_r64459783"},"pull_request":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/ndoit/fenrir/pulls/203","id":71275799,"html_url":"https://github.com/ndoit/fenrir/pull/203","diff_url":"https://github.com/ndoit/fenrir/pull/203.diff","patch_url":"https://github.com/ndoit/fenrir/pull/203.patch","issue_url":"https://api.github.com/repos/ndoit/fenrir/issues/203","number":203,"state":"open","locked":false,"title":"Dev","user":{"login":"RyanSnodgrass","id":7104855,"avatar_url":"https://avatars.githubusercontent.com/u/7104855?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanSnodgrass","html_url":"https://github.com/RyanSnodgrass","followers_url":"https://api.github.com/users/RyanSnodgrass/followers","following_url":"https://api.github.com/users/RyanSnodgrass/following{/other_user}","gists_url":"https://api.github.com/users/RyanSnodgrass/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanSnodgrass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanSnodgrass/subscriptions","organizations_url":"https://api.github.com/users/RyanSnodgrass/orgs","repos_url":"https://api.github.com/users/RyanSnodgrass/repos","events_url":"https://api.github.com/users/RyanSnodgrass/events{/privacy}","received_events_url":"https://api.github.com/users/RyanSnodgrass/received_events","type":"User","site_admin":false},"body":"New Features\r\n===\r\n### True Tableau Pass Through Authentication\r\nRemoving the need for the hideous Tableau login modal.\r\n\r\n@JacobSonner discovered the URL for Tableau's SAML authentication; if we pop open an iframe and set the source to that URL, Tableau will pick up our CAS auth automatically, without requiring the user to click. So we're going back to putting a hidden iframe on the report page.\r\n\r\n### Partial Search\r\nUsers will type 3 or 4 letters in the typeahead, see the suggestions pop up, then hit enter, expecting to see search results matching the typeahead suggestions. While we can't get the search results to exactly match typeahead suggestions, we can get partial search.\r\n\r\n### Description hide feature\r\n\r\nUser feedback has told us that on the report detail page, no one reads the description, instead they blow right over it and start at the pretty pictures. \r\n\r\nSince all of the report descriptions are atleast a paragraph long, we thought that we ought to hide the description with a 'read more' button. check below. \r\n\r\nWe've grayed out the description field and added a border that cuts off the second line, looking like the page slips under the border\r\n\r\nClosed\r\n<img width=\"1163\" alt=\"readmore-closed\" src=\"https://cloud.githubusercontent.com/assets/7104855/15512646/f64cee2a-21ae-11e6-93f1-94bc319aaf6d.png\">\r\n\r\n\r\nOpen\r\n<img width=\"1155\" alt=\"readmore-open\" src=\"https://cloud.githubusercontent.com/assets/7104855/15512661/fea9fd1a-21ae-11e6-8225-36d2205dcd0e.png\">\r\n\r\n### Report Button\r\nAdded css properties to change report tableau filter buttons on hover.\r\n\r\n### Hound CI for Ruby\r\nAdded the ruby defaults from hound into rubocop.yml. Linted several files.\r\n\r\n\r\nfixes #187 \r\nBug Fixes\r\n===\r\n- Added foundation media query breakpoints for tableau buttons.\r\n- Added another button size that increases on smaller screens to fit all the text. - fixes #180 \r\n- Removed hardcoded references to egrantha in jobs.\r\n- guest user reworded. fixes #193 \r\n\r\n### Extrapolated reports helper to 2 files\r\nthe code relating to checking and creating the buttons was extrapolated into it's own helper\r\n\r\n### Office and Terms Listing Switched From 2 Wide to 3\r\nOn PermissionGroup page it lists all terms associated. On office page, it lists all terms it's associated with. Changed this from 2 wide to 3 wide so the page is shorter and easier to scroll. Changed the alignment from centered to left align on all screens, but small will be centered\r\n","created_at":"2016-05-24T19:09:35Z","updated_at":"2016-05-24T19:37:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31a5468373cb1701bc28934d6b81f4e6b619c393","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ndoit/fenrir/pulls/203/commits","review_comments_url":"https://api.github.com/repos/ndoit/fenrir/pulls/203/comments","review_comment_url":"https://api.github.com/repos/ndoit/fenrir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ndoit/fenrir/issues/203/comments","statuses_url":"https://api.github.com/repos/ndoit/fenrir/statuses/cbc4b3f704b68d5e9d1dd45c7488497ff10e6ef7","head":{"label":"ndoit:dev","ref":"dev","sha":"cbc4b3f704b68d5e9d1dd45c7488497ff10e6ef7","user":{"login":"ndoit","id":6223716,"avatar_url":"https://avatars.githubusercontent.com/u/6223716?v=3","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"repo":{"id":39837938,"name":"fenrir","full_name":"ndoit/fenrir","owner":{"login":"ndoit","id":6223716,"avatar_url":"https://avatars.githubusercontent.com/u/6223716?v=3","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndoit/fenrir","description":"BI Portal","fork":false,"url":"https://api.github.com/repos/ndoit/fenrir","forks_url":"https://api.github.com/repos/ndoit/fenrir/forks","keys_url":"https://api.github.com/repos/ndoit/fenrir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndoit/fenrir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndoit/fenrir/teams","hooks_url":"https://api.github.com/repos/ndoit/fenrir/hooks","issue_events_url":"https://api.github.com/repos/ndoit/fenrir/issues/events{/number}","events_url":"https://api.github.com/repos/ndoit/fenrir/events","assignees_url":"https://api.github.com/repos/ndoit/fenrir/assignees{/user}","branches_url":"https://api.github.com/repos/ndoit/fenrir/branches{/branch}","tags_url":"https://api.github.com/repos/ndoit/fenrir/tags","blobs_url":"https://api.github.com/repos/ndoit/fenrir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndoit/fenrir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndoit/fenrir/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndoit/fenrir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndoit/fenrir/statuses/{sha}","languages_url":"https://api.github.com/repos/ndoit/fenrir/languages","stargazers_url":"https://api.github.com/repos/ndoit/fenrir/stargazers","contributors_url":"https://api.github.com/repos/ndoit/fenrir/contributors","subscribers_url":"https://api.github.com/repos/ndoit/fenrir/subscribers","subscription_url":"https://api.github.com/repos/ndoit/fenrir/subscription","commits_url":"https://api.github.com/repos/ndoit/fenrir/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndoit/fenrir/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndoit/fenrir/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndoit/fenrir/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndoit/fenrir/contents/{+path}","compare_url":"https://api.github.com/repos/ndoit/fenrir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndoit/fenrir/merges","archive_url":"https://api.github.com/repos/ndoit/fenrir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndoit/fenrir/downloads","issues_url":"https://api.github.com/repos/ndoit/fenrir/issues{/number}","pulls_url":"https://api.github.com/repos/ndoit/fenrir/pulls{/number}","milestones_url":"https://api.github.com/repos/ndoit/fenrir/milestones{/number}","notifications_url":"https://api.github.com/repos/ndoit/fenrir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndoit/fenrir/labels{/name}","releases_url":"https://api.github.com/repos/ndoit/fenrir/releases{/id}","deployments_url":"https://api.github.com/repos/ndoit/fenrir/deployments","created_at":"2015-07-28T14:14:01Z","updated_at":"2016-02-01T16:13:34Z","pushed_at":"2016-05-24T19:35:40Z","git_url":"git://github.com/ndoit/fenrir.git","ssh_url":"git@github.com:ndoit/fenrir.git","clone_url":"https://github.com/ndoit/fenrir.git","svn_url":"https://github.com/ndoit/fenrir","homepage":"https://data.nd.edu","size":11945,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":21,"forks":0,"open_issues":21,"watchers":1,"default_branch":"master"}},"base":{"label":"ndoit:master","ref":"master","sha":"e1bffe7c37657b95539ea5230b1222c1d060c96e","user":{"login":"ndoit","id":6223716,"avatar_url":"https://avatars.githubusercontent.com/u/6223716?v=3","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"repo":{"id":39837938,"name":"fenrir","full_name":"ndoit/fenrir","owner":{"login":"ndoit","id":6223716,"avatar_url":"https://avatars.githubusercontent.com/u/6223716?v=3","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndoit/fenrir","description":"BI Portal","fork":false,"url":"https://api.github.com/repos/ndoit/fenrir","forks_url":"https://api.github.com/repos/ndoit/fenrir/forks","keys_url":"https://api.github.com/repos/ndoit/fenrir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndoit/fenrir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndoit/fenrir/teams","hooks_url":"https://api.github.com/repos/ndoit/fenrir/hooks","issue_events_url":"https://api.github.com/repos/ndoit/fenrir/issues/events{/number}","events_url":"https://api.github.com/repos/ndoit/fenrir/events","assignees_url":"https://api.github.com/repos/ndoit/fenrir/assignees{/user}","branches_url":"https://api.github.com/repos/ndoit/fenrir/branches{/branch}","tags_url":"https://api.github.com/repos/ndoit/fenrir/tags","blobs_url":"https://api.github.com/repos/ndoit/fenrir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndoit/fenrir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndoit/fenrir/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndoit/fenrir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndoit/fenrir/statuses/{sha}","languages_url":"https://api.github.com/repos/ndoit/fenrir/languages","stargazers_url":"https://api.github.com/repos/ndoit/fenrir/stargazers","contributors_url":"https://api.github.com/repos/ndoit/fenrir/contributors","subscribers_url":"https://api.github.com/repos/ndoit/fenrir/subscribers","subscription_url":"https://api.github.com/repos/ndoit/fenrir/subscription","commits_url":"https://api.github.com/repos/ndoit/fenrir/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndoit/fenrir/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndoit/fenrir/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndoit/fenrir/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndoit/fenrir/contents/{+path}","compare_url":"https://api.github.com/repos/ndoit/fenrir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndoit/fenrir/merges","archive_url":"https://api.github.com/repos/ndoit/fenrir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndoit/fenrir/downloads","issues_url":"https://api.github.com/repos/ndoit/fenrir/issues{/number}","pulls_url":"https://api.github.com/repos/ndoit/fenrir/pulls{/number}","milestones_url":"https://api.github.com/repos/ndoit/fenrir/milestones{/number}","notifications_url":"https://api.github.com/repos/ndoit/fenrir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndoit/fenrir/labels{/name}","releases_url":"https://api.github.com/repos/ndoit/fenrir/releases{/id}","deployments_url":"https://api.github.com/repos/ndoit/fenrir/deployments","created_at":"2015-07-28T14:14:01Z","updated_at":"2016-02-01T16:13:34Z","pushed_at":"2016-05-24T19:35:40Z","git_url":"git://github.com/ndoit/fenrir.git","ssh_url":"git@github.com:ndoit/fenrir.git","clone_url":"https://github.com/ndoit/fenrir.git","svn_url":"https://github.com/ndoit/fenrir","homepage":"https://data.nd.edu","size":11945,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":21,"forks":0,"open_issues":21,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/203"},"html":{"href":"https://github.com/ndoit/fenrir/pull/203"},"issue":{"href":"https://api.github.com/repos/ndoit/fenrir/issues/203"},"comments":{"href":"https://api.github.com/repos/ndoit/fenrir/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/ndoit/fenrir/statuses/cbc4b3f704b68d5e9d1dd45c7488497ff10e6ef7"}}}}
{"actor":{"display_login":"RyanSnodgrass"}}