{"action":"opened","issue":{"url":"https://api.github.com/repos/jrossignol/ContractConfigurator/issues/569","repository_url":"https://api.github.com/repos/jrossignol/ContractConfigurator","labels_url":"https://api.github.com/repos/jrossignol/ContractConfigurator/issues/569/labels{/name}","comments_url":"https://api.github.com/repos/jrossignol/ContractConfigurator/issues/569/comments","events_url":"https://api.github.com/repos/jrossignol/ContractConfigurator/issues/569/events","html_url":"https://github.com/jrossignol/ContractConfigurator/issues/569","id":175041150,"number":569,"title":"NRE in ReachState.CheckBiome","user":{"login":"SamLex","id":733683,"avatar_url":"https://avatars.githubusercontent.com/u/733683?v=3","gravatar_id":"","url":"https://api.github.com/users/SamLex","html_url":"https://github.com/SamLex","followers_url":"https://api.github.com/users/SamLex/followers","following_url":"https://api.github.com/users/SamLex/following{/other_user}","gists_url":"https://api.github.com/users/SamLex/gists{/gist_id}","starred_url":"https://api.github.com/users/SamLex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamLex/subscriptions","organizations_url":"https://api.github.com/users/SamLex/orgs","repos_url":"https://api.github.com/users/SamLex/repos","events_url":"https://api.github.com/users/SamLex/events{/privacy}","received_events_url":"https://api.github.com/users/SamLex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-05T10:21:41Z","updated_at":"2016-09-05T10:21:41Z","closed_at":null,"body":"**Problem**\r\nA NullReferenceException is thrown within _ContractConfigurator.Parameters.ReachState.CheckBiome_ because _Vessel.landedAt_ is null when passed to _Vessel.GetLandedAtString_.\r\n\r\n**Situation**\r\nThis bug manifested while using the [Extraplanetary-Launchpads](https://github.com/taniwha/Extraplanetary-Launchpads) mod to create a vessel in orbit.\r\n\r\n**Log**\r\nRelevant fragment of log file is attached: [nre.txt](https://github.com/jrossignol/ContractConfigurator/files/454849/nre.txt)\r\n\r\n**Potential Solution**\r\nAdd a null check for _Vessel.landedAt_ at ReachState.cs:220:\r\n`if (vessel.landedAt != null && Vessel.GetLandedAtString(vessel.landedAt) == biome)`\r\n\r\n**Alternative**\r\nExtraplanetary-Launchpads should be ensuring that _Vessel.landedAt_ is non-null, even when the vessel is in orbit."}}
{"actor":{"display_login":"SamLex"}}