{"action":"created","comment":{"url":"https://api.github.com/repos/uber-common/luma.gl/pulls/comments/59124247","id":59124247,"diff_hunk":"@@ -220,7 +220,8 @@ export default class Model extends Object3D {\n         data: attribute.value,\n         size: attribute.size,\n         instanced: attribute.instanced ? 1 : 0,\n-        bufferType: attribute.bufferType || program.gl.ARRAY_BUFFER,\n+        bufferType: attribute.bufferType || attributeName === 'indices' ?\n+          program.gl.ELEMENT_ARRAY_BUFFER : program.gl.ARRAY_BUFFER,","path":"src/model.js","position":6,"original_position":6,"commit_id":"18d7086faa846119ab1d27a65cbcb91f83ed56a2","original_commit_id":"18d7086faa846119ab1d27a65cbcb91f83ed56a2","user":{"login":"wwwtyro","id":929443,"avatar_url":"https://avatars.githubusercontent.com/u/929443?v=3","gravatar_id":"","url":"https://api.github.com/users/wwwtyro","html_url":"https://github.com/wwwtyro","followers_url":"https://api.github.com/users/wwwtyro/followers","following_url":"https://api.github.com/users/wwwtyro/following{/other_user}","gists_url":"https://api.github.com/users/wwwtyro/gists{/gist_id}","starred_url":"https://api.github.com/users/wwwtyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwwtyro/subscriptions","organizations_url":"https://api.github.com/users/wwwtyro/orgs","repos_url":"https://api.github.com/users/wwwtyro/repos","events_url":"https://api.github.com/users/wwwtyro/events{/privacy}","received_events_url":"https://api.github.com/users/wwwtyro/received_events","type":"User","site_admin":false},"body":"Might want some way to indicate an ELEMENT_ARRAY_BUFFER is being created other than using the 'indices' string.","created_at":"2016-04-10T00:07:37Z","updated_at":"2016-04-10T00:07:37Z","html_url":"https://github.com/uber-common/luma.gl/pull/69#discussion_r59124247","pull_request_url":"https://api.github.com/repos/uber-common/luma.gl/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/uber-common/luma.gl/pulls/comments/59124247"},"html":{"href":"https://github.com/uber-common/luma.gl/pull/69#discussion_r59124247"},"pull_request":{"href":"https://api.github.com/repos/uber-common/luma.gl/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/uber-common/luma.gl/pulls/69","id":65896454,"html_url":"https://github.com/uber-common/luma.gl/pull/69","diff_url":"https://github.com/uber-common/luma.gl/pull/69.diff","patch_url":"https://github.com/uber-common/luma.gl/pull/69.patch","issue_url":"https://api.github.com/repos/uber-common/luma.gl/issues/69","number":69,"state":"open","locked":false,"title":"Feature/fix examples.b","user":{"login":"wwwtyro","id":929443,"avatar_url":"https://avatars.githubusercontent.com/u/929443?v=3","gravatar_id":"","url":"https://api.github.com/users/wwwtyro","html_url":"https://github.com/wwwtyro","followers_url":"https://api.github.com/users/wwwtyro/followers","following_url":"https://api.github.com/users/wwwtyro/following{/other_user}","gists_url":"https://api.github.com/users/wwwtyro/gists{/gist_id}","starred_url":"https://api.github.com/users/wwwtyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwwtyro/subscriptions","organizations_url":"https://api.github.com/users/wwwtyro/orgs","repos_url":"https://api.github.com/users/wwwtyro/repos","events_url":"https://api.github.com/users/wwwtyro/events{/privacy}","received_events_url":"https://api.github.com/users/wwwtyro/received_events","type":"User","site_admin":false},"body":"@ibgreen @philogb Gets lessons 3 - 8, & 10 - 12 mostly working. It looks like there might be an off-by-one error or the like somewhere that is preventing the rendering of a poly in meshes, see lesson 10 for an obvious example.\r\n\r\nInstead of trampling your refactor, Ib, I've fixed bugs here in a very hacky way to highlight where the issues are. You'll want to come up with fixes that better align to your vision. I'll leave comments in the diff to try to explain some of the issues I found.","created_at":"2016-04-10T00:03:28Z","updated_at":"2016-04-10T00:07:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10ee2d5b31a1ec2c30b429bdf91bb5b72027edb8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber-common/luma.gl/pulls/69/commits","review_comments_url":"https://api.github.com/repos/uber-common/luma.gl/pulls/69/comments","review_comment_url":"https://api.github.com/repos/uber-common/luma.gl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber-common/luma.gl/issues/69/comments","statuses_url":"https://api.github.com/repos/uber-common/luma.gl/statuses/18d7086faa846119ab1d27a65cbcb91f83ed56a2","head":{"label":"wwwtyro:feature/fix-examples.b","ref":"feature/fix-examples.b","sha":"18d7086faa846119ab1d27a65cbcb91f83ed56a2","user":{"login":"wwwtyro","id":929443,"avatar_url":"https://avatars.githubusercontent.com/u/929443?v=3","gravatar_id":"","url":"https://api.github.com/users/wwwtyro","html_url":"https://github.com/wwwtyro","followers_url":"https://api.github.com/users/wwwtyro/followers","following_url":"https://api.github.com/users/wwwtyro/following{/other_user}","gists_url":"https://api.github.com/users/wwwtyro/gists{/gist_id}","starred_url":"https://api.github.com/users/wwwtyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwwtyro/subscriptions","organizations_url":"https://api.github.com/users/wwwtyro/orgs","repos_url":"https://api.github.com/users/wwwtyro/repos","events_url":"https://api.github.com/users/wwwtyro/events{/privacy}","received_events_url":"https://api.github.com/users/wwwtyro/received_events","type":"User","site_admin":false},"repo":{"id":50703532,"name":"luma.gl","full_name":"wwwtyro/luma.gl","owner":{"login":"wwwtyro","id":929443,"avatar_url":"https://avatars.githubusercontent.com/u/929443?v=3","gravatar_id":"","url":"https://api.github.com/users/wwwtyro","html_url":"https://github.com/wwwtyro","followers_url":"https://api.github.com/users/wwwtyro/followers","following_url":"https://api.github.com/users/wwwtyro/following{/other_user}","gists_url":"https://api.github.com/users/wwwtyro/gists{/gist_id}","starred_url":"https://api.github.com/users/wwwtyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwwtyro/subscriptions","organizations_url":"https://api.github.com/users/wwwtyro/orgs","repos_url":"https://api.github.com/users/wwwtyro/repos","events_url":"https://api.github.com/users/wwwtyro/events{/privacy}","received_events_url":"https://api.github.com/users/wwwtyro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wwwtyro/luma.gl","description":"","fork":true,"url":"https://api.github.com/repos/wwwtyro/luma.gl","forks_url":"https://api.github.com/repos/wwwtyro/luma.gl/forks","keys_url":"https://api.github.com/repos/wwwtyro/luma.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wwwtyro/luma.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wwwtyro/luma.gl/teams","hooks_url":"https://api.github.com/repos/wwwtyro/luma.gl/hooks","issue_events_url":"https://api.github.com/repos/wwwtyro/luma.gl/issues/events{/number}","events_url":"https://api.github.com/repos/wwwtyro/luma.gl/events","assignees_url":"https://api.github.com/repos/wwwtyro/luma.gl/assignees{/user}","branches_url":"https://api.github.com/repos/wwwtyro/luma.gl/branches{/branch}","tags_url":"https://api.github.com/repos/wwwtyro/luma.gl/tags","blobs_url":"https://api.github.com/repos/wwwtyro/luma.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wwwtyro/luma.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wwwtyro/luma.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/wwwtyro/luma.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wwwtyro/luma.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/wwwtyro/luma.gl/languages","stargazers_url":"https://api.github.com/repos/wwwtyro/luma.gl/stargazers","contributors_url":"https://api.github.com/repos/wwwtyro/luma.gl/contributors","subscribers_url":"https://api.github.com/repos/wwwtyro/luma.gl/subscribers","subscription_url":"https://api.github.com/repos/wwwtyro/luma.gl/subscription","commits_url":"https://api.github.com/repos/wwwtyro/luma.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/wwwtyro/luma.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/wwwtyro/luma.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/wwwtyro/luma.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/wwwtyro/luma.gl/contents/{+path}","compare_url":"https://api.github.com/repos/wwwtyro/luma.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wwwtyro/luma.gl/merges","archive_url":"https://api.github.com/repos/wwwtyro/luma.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wwwtyro/luma.gl/downloads","issues_url":"https://api.github.com/repos/wwwtyro/luma.gl/issues{/number}","pulls_url":"https://api.github.com/repos/wwwtyro/luma.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/wwwtyro/luma.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/wwwtyro/luma.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wwwtyro/luma.gl/labels{/name}","releases_url":"https://api.github.com/repos/wwwtyro/luma.gl/releases{/id}","deployments_url":"https://api.github.com/repos/wwwtyro/luma.gl/deployments","created_at":"2016-01-30T01:53:41Z","updated_at":"2016-02-03T01:32:33Z","pushed_at":"2016-04-09T23:59:44Z","git_url":"git://github.com/wwwtyro/luma.gl.git","ssh_url":"git@github.com:wwwtyro/luma.gl.git","clone_url":"https://github.com/wwwtyro/luma.gl.git","svn_url":"https://github.com/wwwtyro/luma.gl","homepage":null,"size":79698,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"uber-common:dev","ref":"dev","sha":"05af16fda510e15ec4ad654c845179e7f737b646","user":{"login":"uber-common","id":14812045,"avatar_url":"https://avatars.githubusercontent.com/u/14812045?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-common","html_url":"https://github.com/uber-common","followers_url":"https://api.github.com/users/uber-common/followers","following_url":"https://api.github.com/users/uber-common/following{/other_user}","gists_url":"https://api.github.com/users/uber-common/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-common/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-common/subscriptions","organizations_url":"https://api.github.com/users/uber-common/orgs","repos_url":"https://api.github.com/users/uber-common/repos","events_url":"https://api.github.com/users/uber-common/events{/privacy}","received_events_url":"https://api.github.com/users/uber-common/received_events","type":"Organization","site_admin":false},"repo":{"id":50340928,"name":"luma.gl","full_name":"uber-common/luma.gl","owner":{"login":"uber-common","id":14812045,"avatar_url":"https://avatars.githubusercontent.com/u/14812045?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-common","html_url":"https://github.com/uber-common","followers_url":"https://api.github.com/users/uber-common/followers","following_url":"https://api.github.com/users/uber-common/following{/other_user}","gists_url":"https://api.github.com/users/uber-common/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-common/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-common/subscriptions","organizations_url":"https://api.github.com/users/uber-common/orgs","repos_url":"https://api.github.com/users/uber-common/repos","events_url":"https://api.github.com/users/uber-common/events{/privacy}","received_events_url":"https://api.github.com/users/uber-common/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-common/luma.gl","description":"","fork":false,"url":"https://api.github.com/repos/uber-common/luma.gl","forks_url":"https://api.github.com/repos/uber-common/luma.gl/forks","keys_url":"https://api.github.com/repos/uber-common/luma.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-common/luma.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-common/luma.gl/teams","hooks_url":"https://api.github.com/repos/uber-common/luma.gl/hooks","issue_events_url":"https://api.github.com/repos/uber-common/luma.gl/issues/events{/number}","events_url":"https://api.github.com/repos/uber-common/luma.gl/events","assignees_url":"https://api.github.com/repos/uber-common/luma.gl/assignees{/user}","branches_url":"https://api.github.com/repos/uber-common/luma.gl/branches{/branch}","tags_url":"https://api.github.com/repos/uber-common/luma.gl/tags","blobs_url":"https://api.github.com/repos/uber-common/luma.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-common/luma.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-common/luma.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-common/luma.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-common/luma.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-common/luma.gl/languages","stargazers_url":"https://api.github.com/repos/uber-common/luma.gl/stargazers","contributors_url":"https://api.github.com/repos/uber-common/luma.gl/contributors","subscribers_url":"https://api.github.com/repos/uber-common/luma.gl/subscribers","subscription_url":"https://api.github.com/repos/uber-common/luma.gl/subscription","commits_url":"https://api.github.com/repos/uber-common/luma.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-common/luma.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-common/luma.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-common/luma.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-common/luma.gl/contents/{+path}","compare_url":"https://api.github.com/repos/uber-common/luma.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-common/luma.gl/merges","archive_url":"https://api.github.com/repos/uber-common/luma.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-common/luma.gl/downloads","issues_url":"https://api.github.com/repos/uber-common/luma.gl/issues{/number}","pulls_url":"https://api.github.com/repos/uber-common/luma.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-common/luma.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-common/luma.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-common/luma.gl/labels{/name}","releases_url":"https://api.github.com/repos/uber-common/luma.gl/releases{/id}","deployments_url":"https://api.github.com/repos/uber-common/luma.gl/deployments","created_at":"2016-01-25T09:41:59Z","updated_at":"2016-04-09T19:25:48Z","pushed_at":"2016-04-10T00:03:28Z","git_url":"git://github.com/uber-common/luma.gl.git","ssh_url":"git@github.com:uber-common/luma.gl.git","clone_url":"https://github.com/uber-common/luma.gl.git","svn_url":"https://github.com/uber-common/luma.gl","homepage":null,"size":79598,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":27,"forks":5,"open_issues":27,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber-common/luma.gl/pulls/69"},"html":{"href":"https://github.com/uber-common/luma.gl/pull/69"},"issue":{"href":"https://api.github.com/repos/uber-common/luma.gl/issues/69"},"comments":{"href":"https://api.github.com/repos/uber-common/luma.gl/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/uber-common/luma.gl/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/uber-common/luma.gl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber-common/luma.gl/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/uber-common/luma.gl/statuses/18d7086faa846119ab1d27a65cbcb91f83ed56a2"}}}}