{"action":"closed","number":501,"pull_request":{"url":"https://api.github.com/repos/stoicflame/enunciate/pulls/501","id":85629878,"html_url":"https://github.com/stoicflame/enunciate/pull/501","diff_url":"https://github.com/stoicflame/enunciate/pull/501.diff","patch_url":"https://github.com/stoicflame/enunciate/pull/501.patch","issue_url":"https://api.github.com/repos/stoicflame/enunciate/issues/501","number":501,"state":"closed","locked":false,"title":"Initial support for Lombok annotations","user":{"login":"SpOOnman","id":449529,"avatar_url":"https://avatars.githubusercontent.com/u/449529?v=3","gravatar_id":"","url":"https://api.github.com/users/SpOOnman","html_url":"https://github.com/SpOOnman","followers_url":"https://api.github.com/users/SpOOnman/followers","following_url":"https://api.github.com/users/SpOOnman/following{/other_user}","gists_url":"https://api.github.com/users/SpOOnman/gists{/gist_id}","starred_url":"https://api.github.com/users/SpOOnman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpOOnman/subscriptions","organizations_url":"https://api.github.com/users/SpOOnman/orgs","repos_url":"https://api.github.com/users/SpOOnman/repos","events_url":"https://api.github.com/users/SpOOnman/events{/privacy}","received_events_url":"https://api.github.com/users/SpOOnman/received_events","type":"User","site_admin":false},"body":"I've followed Lombok implementation for IntelliJ IDEA plugin. This plugin generates missing getters and setters on thy fly based on source code analysis and Lombok annotations. These mehods are not visible in the source code, but they are available for code completion, navigation, searching etc. IDEA sees these methods as present, beacuse they're present in PsiClass - their AST representation of a source code you work on.\r\n\r\nFor enunciate I propose to do the same. At the moment of getting original methods from Java source code I check if Lombok annotations are present and generate missing ones. I create fake DecoratedExecutableElements that behave like a real getters and setters.\r\n\r\nI have a doubt about tests. Do you expect any? I've tested manually and it was fine.\r\n\r\nI couldn't build mvn clean install, because JBoss example was failing, I only succeeded with skipping tests.","created_at":"2016-09-16T19:50:19Z","updated_at":"2016-10-06T22:59:16Z","closed_at":"2016-10-06T22:59:16Z","merged_at":null,"merge_commit_sha":"e6e0c2e967411307afec7f8517080de171ee3aea","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/stoicflame/enunciate/milestones/14","html_url":"https://github.com/stoicflame/enunciate/milestones/2.7.0","labels_url":"https://api.github.com/repos/stoicflame/enunciate/milestones/14/labels","id":1961095,"number":14,"title":"2.7.0","description":"","creator":{"login":"stoicflame","id":145838,"avatar_url":"https://avatars.githubusercontent.com/u/145838?v=3","gravatar_id":"","url":"https://api.github.com/users/stoicflame","html_url":"https://github.com/stoicflame","followers_url":"https://api.github.com/users/stoicflame/followers","following_url":"https://api.github.com/users/stoicflame/following{/other_user}","gists_url":"https://api.github.com/users/stoicflame/gists{/gist_id}","starred_url":"https://api.github.com/users/stoicflame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stoicflame/subscriptions","organizations_url":"https://api.github.com/users/stoicflame/orgs","repos_url":"https://api.github.com/users/stoicflame/repos","events_url":"https://api.github.com/users/stoicflame/events{/privacy}","received_events_url":"https://api.github.com/users/stoicflame/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":10,"state":"open","created_at":"2016-08-24T17:26:33Z","updated_at":"2016-10-06T22:59:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/stoicflame/enunciate/pulls/501/commits","review_comments_url":"https://api.github.com/repos/stoicflame/enunciate/pulls/501/comments","review_comment_url":"https://api.github.com/repos/stoicflame/enunciate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stoicflame/enunciate/issues/501/comments","statuses_url":"https://api.github.com/repos/stoicflame/enunciate/statuses/38c9fccb0ffda30997d107318c884ba24bc33cab","head":{"label":"SpOOnman:lombok","ref":"lombok","sha":"38c9fccb0ffda30997d107318c884ba24bc33cab","user":{"login":"SpOOnman","id":449529,"avatar_url":"https://avatars.githubusercontent.com/u/449529?v=3","gravatar_id":"","url":"https://api.github.com/users/SpOOnman","html_url":"https://github.com/SpOOnman","followers_url":"https://api.github.com/users/SpOOnman/followers","following_url":"https://api.github.com/users/SpOOnman/following{/other_user}","gists_url":"https://api.github.com/users/SpOOnman/gists{/gist_id}","starred_url":"https://api.github.com/users/SpOOnman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpOOnman/subscriptions","organizations_url":"https://api.github.com/users/SpOOnman/orgs","repos_url":"https://api.github.com/users/SpOOnman/repos","events_url":"https://api.github.com/users/SpOOnman/events{/privacy}","received_events_url":"https://api.github.com/users/SpOOnman/received_events","type":"User","site_admin":false},"repo":{"id":68365359,"name":"enunciate","full_name":"SpOOnman/enunciate","owner":{"login":"SpOOnman","id":449529,"avatar_url":"https://avatars.githubusercontent.com/u/449529?v=3","gravatar_id":"","url":"https://api.github.com/users/SpOOnman","html_url":"https://github.com/SpOOnman","followers_url":"https://api.github.com/users/SpOOnman/followers","following_url":"https://api.github.com/users/SpOOnman/following{/other_user}","gists_url":"https://api.github.com/users/SpOOnman/gists{/gist_id}","starred_url":"https://api.github.com/users/SpOOnman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpOOnman/subscriptions","organizations_url":"https://api.github.com/users/SpOOnman/orgs","repos_url":"https://api.github.com/users/SpOOnman/repos","events_url":"https://api.github.com/users/SpOOnman/events{/privacy}","received_events_url":"https://api.github.com/users/SpOOnman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SpOOnman/enunciate","description":"Build-time enhancement tool for Java-based Web services projects","fork":true,"url":"https://api.github.com/repos/SpOOnman/enunciate","forks_url":"https://api.github.com/repos/SpOOnman/enunciate/forks","keys_url":"https://api.github.com/repos/SpOOnman/enunciate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpOOnman/enunciate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpOOnman/enunciate/teams","hooks_url":"https://api.github.com/repos/SpOOnman/enunciate/hooks","issue_events_url":"https://api.github.com/repos/SpOOnman/enunciate/issues/events{/number}","events_url":"https://api.github.com/repos/SpOOnman/enunciate/events","assignees_url":"https://api.github.com/repos/SpOOnman/enunciate/assignees{/user}","branches_url":"https://api.github.com/repos/SpOOnman/enunciate/branches{/branch}","tags_url":"https://api.github.com/repos/SpOOnman/enunciate/tags","blobs_url":"https://api.github.com/repos/SpOOnman/enunciate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpOOnman/enunciate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpOOnman/enunciate/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpOOnman/enunciate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpOOnman/enunciate/statuses/{sha}","languages_url":"https://api.github.com/repos/SpOOnman/enunciate/languages","stargazers_url":"https://api.github.com/repos/SpOOnman/enunciate/stargazers","contributors_url":"https://api.github.com/repos/SpOOnman/enunciate/contributors","subscribers_url":"https://api.github.com/repos/SpOOnman/enunciate/subscribers","subscription_url":"https://api.github.com/repos/SpOOnman/enunciate/subscription","commits_url":"https://api.github.com/repos/SpOOnman/enunciate/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpOOnman/enunciate/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpOOnman/enunciate/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpOOnman/enunciate/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpOOnman/enunciate/contents/{+path}","compare_url":"https://api.github.com/repos/SpOOnman/enunciate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpOOnman/enunciate/merges","archive_url":"https://api.github.com/repos/SpOOnman/enunciate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpOOnman/enunciate/downloads","issues_url":"https://api.github.com/repos/SpOOnman/enunciate/issues{/number}","pulls_url":"https://api.github.com/repos/SpOOnman/enunciate/pulls{/number}","milestones_url":"https://api.github.com/repos/SpOOnman/enunciate/milestones{/number}","notifications_url":"https://api.github.com/repos/SpOOnman/enunciate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpOOnman/enunciate/labels{/name}","releases_url":"https://api.github.com/repos/SpOOnman/enunciate/releases{/id}","deployments_url":"https://api.github.com/repos/SpOOnman/enunciate/deployments","created_at":"2016-09-16T08:51:17Z","updated_at":"2016-09-16T08:51:24Z","pushed_at":"2016-10-03T21:52:42Z","git_url":"git://github.com/SpOOnman/enunciate.git","ssh_url":"git@github.com:SpOOnman/enunciate.git","clone_url":"https://github.com/SpOOnman/enunciate.git","svn_url":"https://github.com/SpOOnman/enunciate","homepage":"http://enunciate.webcohesion.com/","size":25420,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stoicflame:master","ref":"master","sha":"e015945aca31eb652b7ce53f3678e0eeb153c9cc","user":{"login":"stoicflame","id":145838,"avatar_url":"https://avatars.githubusercontent.com/u/145838?v=3","gravatar_id":"","url":"https://api.github.com/users/stoicflame","html_url":"https://github.com/stoicflame","followers_url":"https://api.github.com/users/stoicflame/followers","following_url":"https://api.github.com/users/stoicflame/following{/other_user}","gists_url":"https://api.github.com/users/stoicflame/gists{/gist_id}","starred_url":"https://api.github.com/users/stoicflame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stoicflame/subscriptions","organizations_url":"https://api.github.com/users/stoicflame/orgs","repos_url":"https://api.github.com/users/stoicflame/repos","events_url":"https://api.github.com/users/stoicflame/events{/privacy}","received_events_url":"https://api.github.com/users/stoicflame/received_events","type":"User","site_admin":false},"repo":{"id":1707059,"name":"enunciate","full_name":"stoicflame/enunciate","owner":{"login":"stoicflame","id":145838,"avatar_url":"https://avatars.githubusercontent.com/u/145838?v=3","gravatar_id":"","url":"https://api.github.com/users/stoicflame","html_url":"https://github.com/stoicflame","followers_url":"https://api.github.com/users/stoicflame/followers","following_url":"https://api.github.com/users/stoicflame/following{/other_user}","gists_url":"https://api.github.com/users/stoicflame/gists{/gist_id}","starred_url":"https://api.github.com/users/stoicflame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stoicflame/subscriptions","organizations_url":"https://api.github.com/users/stoicflame/orgs","repos_url":"https://api.github.com/users/stoicflame/repos","events_url":"https://api.github.com/users/stoicflame/events{/privacy}","received_events_url":"https://api.github.com/users/stoicflame/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stoicflame/enunciate","description":"Build-time enhancement tool for Java-based Web services projects","fork":false,"url":"https://api.github.com/repos/stoicflame/enunciate","forks_url":"https://api.github.com/repos/stoicflame/enunciate/forks","keys_url":"https://api.github.com/repos/stoicflame/enunciate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stoicflame/enunciate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stoicflame/enunciate/teams","hooks_url":"https://api.github.com/repos/stoicflame/enunciate/hooks","issue_events_url":"https://api.github.com/repos/stoicflame/enunciate/issues/events{/number}","events_url":"https://api.github.com/repos/stoicflame/enunciate/events","assignees_url":"https://api.github.com/repos/stoicflame/enunciate/assignees{/user}","branches_url":"https://api.github.com/repos/stoicflame/enunciate/branches{/branch}","tags_url":"https://api.github.com/repos/stoicflame/enunciate/tags","blobs_url":"https://api.github.com/repos/stoicflame/enunciate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stoicflame/enunciate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stoicflame/enunciate/git/refs{/sha}","trees_url":"https://api.github.com/repos/stoicflame/enunciate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stoicflame/enunciate/statuses/{sha}","languages_url":"https://api.github.com/repos/stoicflame/enunciate/languages","stargazers_url":"https://api.github.com/repos/stoicflame/enunciate/stargazers","contributors_url":"https://api.github.com/repos/stoicflame/enunciate/contributors","subscribers_url":"https://api.github.com/repos/stoicflame/enunciate/subscribers","subscription_url":"https://api.github.com/repos/stoicflame/enunciate/subscription","commits_url":"https://api.github.com/repos/stoicflame/enunciate/commits{/sha}","git_commits_url":"https://api.github.com/repos/stoicflame/enunciate/git/commits{/sha}","comments_url":"https://api.github.com/repos/stoicflame/enunciate/comments{/number}","issue_comment_url":"https://api.github.com/repos/stoicflame/enunciate/issues/comments{/number}","contents_url":"https://api.github.com/repos/stoicflame/enunciate/contents/{+path}","compare_url":"https://api.github.com/repos/stoicflame/enunciate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stoicflame/enunciate/merges","archive_url":"https://api.github.com/repos/stoicflame/enunciate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stoicflame/enunciate/downloads","issues_url":"https://api.github.com/repos/stoicflame/enunciate/issues{/number}","pulls_url":"https://api.github.com/repos/stoicflame/enunciate/pulls{/number}","milestones_url":"https://api.github.com/repos/stoicflame/enunciate/milestones{/number}","notifications_url":"https://api.github.com/repos/stoicflame/enunciate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stoicflame/enunciate/labels{/name}","releases_url":"https://api.github.com/repos/stoicflame/enunciate/releases{/id}","deployments_url":"https://api.github.com/repos/stoicflame/enunciate/deployments","created_at":"2011-05-05T15:54:15Z","updated_at":"2016-09-28T14:36:55Z","pushed_at":"2016-10-06T22:50:55Z","git_url":"git://github.com/stoicflame/enunciate.git","ssh_url":"git@github.com:stoicflame/enunciate.git","clone_url":"https://github.com/stoicflame/enunciate.git","svn_url":"https://github.com/stoicflame/enunciate","homepage":"http://enunciate.webcohesion.com/","size":26359,"stargazers_count":277,"watchers_count":277,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":137,"mirror_url":null,"open_issues_count":49,"forks":137,"open_issues":49,"watchers":277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stoicflame/enunciate/pulls/501"},"html":{"href":"https://github.com/stoicflame/enunciate/pull/501"},"issue":{"href":"https://api.github.com/repos/stoicflame/enunciate/issues/501"},"comments":{"href":"https://api.github.com/repos/stoicflame/enunciate/issues/501/comments"},"review_comments":{"href":"https://api.github.com/repos/stoicflame/enunciate/pulls/501/comments"},"review_comment":{"href":"https://api.github.com/repos/stoicflame/enunciate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stoicflame/enunciate/pulls/501/commits"},"statuses":{"href":"https://api.github.com/repos/stoicflame/enunciate/statuses/38c9fccb0ffda30997d107318c884ba24bc33cab"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":17,"review_comments":0,"commits":1,"additions":229,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"stoicflame"}}