{"action":"opened","number":1986,"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1986","id":86998334,"html_url":"https://github.com/The-Compiler/qutebrowser/pull/1986","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/1986.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/1986.patch","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1986","number":1986,"state":"open","locked":false,"title":"Fix keybinding-related crash","user":{"login":"hcpl","id":17436405,"avatar_url":"https://avatars.githubusercontent.com/u/17436405?v=3","gravatar_id":"","url":"https://api.github.com/users/hcpl","html_url":"https://github.com/hcpl","followers_url":"https://api.github.com/users/hcpl/followers","following_url":"https://api.github.com/users/hcpl/following{/other_user}","gists_url":"https://api.github.com/users/hcpl/gists{/gist_id}","starred_url":"https://api.github.com/users/hcpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcpl/subscriptions","organizations_url":"https://api.github.com/users/hcpl/orgs","repos_url":"https://api.github.com/users/hcpl/repos","events_url":"https://api.github.com/users/hcpl/events{/privacy}","received_events_url":"https://api.github.com/users/hcpl/received_events","type":"User","site_admin":false},"body":"A quick fix for #1835.\r\n\r\nOriginally the code intended to load `~/.config/qutebrowser/keys.conf` first, and then apply default bindings for unset keychains. But due to the broken logic the program can assign different bindings to the same keychain (the only real case so far is when `keys.conf` is present). When this happens, the loading code raises a `DuplicateKeychainError` and aborts execution.\r\n\r\nThere are two solutions:\r\n1. Reorder (default first, `keys.conf` second) + new bindings take precedence (achieved by the `force` parameter of the `KeyConfigParser._add_binding()` method).\r\n2. Fix the original logic.\r\n\r\nCurrently, the first solution is implemented as the easier one.","created_at":"2016-09-27T19:45:11Z","updated_at":"2016-09-27T19:45:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1986/commits","review_comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1986/comments","review_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1986/comments","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/083a12eb449b6279e542feb23b1c35d35a9f550e","head":{"label":"hcpl:master","ref":"master","sha":"083a12eb449b6279e542feb23b1c35d35a9f550e","user":{"login":"hcpl","id":17436405,"avatar_url":"https://avatars.githubusercontent.com/u/17436405?v=3","gravatar_id":"","url":"https://api.github.com/users/hcpl","html_url":"https://github.com/hcpl","followers_url":"https://api.github.com/users/hcpl/followers","following_url":"https://api.github.com/users/hcpl/following{/other_user}","gists_url":"https://api.github.com/users/hcpl/gists{/gist_id}","starred_url":"https://api.github.com/users/hcpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcpl/subscriptions","organizations_url":"https://api.github.com/users/hcpl/orgs","repos_url":"https://api.github.com/users/hcpl/repos","events_url":"https://api.github.com/users/hcpl/events{/privacy}","received_events_url":"https://api.github.com/users/hcpl/received_events","type":"User","site_admin":false},"repo":{"id":69385668,"name":"qutebrowser","full_name":"hcpl/qutebrowser","owner":{"login":"hcpl","id":17436405,"avatar_url":"https://avatars.githubusercontent.com/u/17436405?v=3","gravatar_id":"","url":"https://api.github.com/users/hcpl","html_url":"https://github.com/hcpl","followers_url":"https://api.github.com/users/hcpl/followers","following_url":"https://api.github.com/users/hcpl/following{/other_user}","gists_url":"https://api.github.com/users/hcpl/gists{/gist_id}","starred_url":"https://api.github.com/users/hcpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcpl/subscriptions","organizations_url":"https://api.github.com/users/hcpl/orgs","repos_url":"https://api.github.com/users/hcpl/repos","events_url":"https://api.github.com/users/hcpl/events{/privacy}","received_events_url":"https://api.github.com/users/hcpl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hcpl/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":true,"url":"https://api.github.com/repos/hcpl/qutebrowser","forks_url":"https://api.github.com/repos/hcpl/qutebrowser/forks","keys_url":"https://api.github.com/repos/hcpl/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hcpl/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hcpl/qutebrowser/teams","hooks_url":"https://api.github.com/repos/hcpl/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/hcpl/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/hcpl/qutebrowser/events","assignees_url":"https://api.github.com/repos/hcpl/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/hcpl/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/hcpl/qutebrowser/tags","blobs_url":"https://api.github.com/repos/hcpl/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hcpl/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hcpl/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/hcpl/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hcpl/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/hcpl/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/hcpl/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/hcpl/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/hcpl/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/hcpl/qutebrowser/subscription","commits_url":"https://api.github.com/repos/hcpl/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/hcpl/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/hcpl/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/hcpl/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/hcpl/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/hcpl/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hcpl/qutebrowser/merges","archive_url":"https://api.github.com/repos/hcpl/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hcpl/qutebrowser/downloads","issues_url":"https://api.github.com/repos/hcpl/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/hcpl/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/hcpl/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/hcpl/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hcpl/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/hcpl/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/hcpl/qutebrowser/deployments","created_at":"2016-09-27T18:17:06Z","updated_at":"2016-09-27T18:17:09Z","pushed_at":"2016-09-27T19:10:50Z","git_url":"git://github.com/hcpl/qutebrowser.git","ssh_url":"git@github.com:hcpl/qutebrowser.git","clone_url":"https://github.com/hcpl/qutebrowser.git","svn_url":"https://github.com/hcpl/qutebrowser","homepage":"https://www.qutebrowser.org/","size":24228,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"The-Compiler:master","ref":"master","sha":"05dddf4f132d44e4a8d48c99afb048f3b15c5a23","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"repo":{"id":21244505,"name":"qutebrowser","full_name":"The-Compiler/qutebrowser","owner":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/The-Compiler/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":false,"url":"https://api.github.com/repos/The-Compiler/qutebrowser","forks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/forks","keys_url":"https://api.github.com/repos/The-Compiler/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/The-Compiler/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/The-Compiler/qutebrowser/teams","hooks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/events","assignees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/The-Compiler/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/tags","blobs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/The-Compiler/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscription","commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/The-Compiler/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/The-Compiler/qutebrowser/merges","archive_url":"https://api.github.com/repos/The-Compiler/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/The-Compiler/qutebrowser/downloads","issues_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/The-Compiler/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/The-Compiler/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/The-Compiler/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/deployments","created_at":"2014-06-26T14:59:34Z","updated_at":"2016-09-27T16:36:30Z","pushed_at":"2016-09-27T14:02:30Z","git_url":"git://github.com/The-Compiler/qutebrowser.git","ssh_url":"git@github.com:The-Compiler/qutebrowser.git","clone_url":"https://github.com/The-Compiler/qutebrowser.git","svn_url":"https://github.com/The-Compiler/qutebrowser","homepage":"https://www.qutebrowser.org/","size":24228,"stargazers_count":1516,"watchers_count":1516,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":231,"mirror_url":null,"open_issues_count":429,"forks":231,"open_issues":429,"watchers":1516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1986"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/1986"},"issue":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1986"},"comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1986/comments"},"review_comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1986/comments"},"review_comment":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1986/commits"},"statuses":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/083a12eb449b6279e542feb23b1c35d35a9f550e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"hcpl"}}