{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/65034776","id":65034776,"diff_hunk":"@@ -67,6 +67,29 @@ network packet,\n \n /dev/rfkill rw,\n \n+# Needed for modem connections using PPP\n+/usr/sbin/pppd ix,\n+/etc/ppp/** rwix,\n+/dev/ppp rw,\n+/dev/tty[^0-9]* rw,\n+/run/udev/data/* r,\n+/proc/sys/kernel/modprobe r,\n+/bin/kmod ix,\n+capability sys_module,\n+/run/lock/*tty[^0-9]* rw,\n+/run/ppp* rw,\n+/var/run/ppp* rw,\n+/var/log/ppp* rw,\n+/bin/run-parts ix,\n+@{PROC}/@{pid}/loginuid r,\n+capability setgid,\n+capability setuid,\n+/sbin/resolvconf rix,","path":"interfaces/builtin/network_manager.go","position":21,"original_position":21,"commit_id":"59e04f87671883f6e5e0644f5ffbd2664624913f","original_commit_id":"59e04f87671883f6e5e0644f5ffbd2664624913f","user":{"login":"alfonsosanchezbeato","id":3833021,"avatar_url":"https://avatars.githubusercontent.com/u/3833021?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonsosanchezbeato","html_url":"https://github.com/alfonsosanchezbeato","followers_url":"https://api.github.com/users/alfonsosanchezbeato/followers","following_url":"https://api.github.com/users/alfonsosanchezbeato/following{/other_user}","gists_url":"https://api.github.com/users/alfonsosanchezbeato/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsosanchezbeato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsosanchezbeato/subscriptions","organizations_url":"https://api.github.com/users/alfonsosanchezbeato/orgs","repos_url":"https://api.github.com/users/alfonsosanchezbeato/repos","events_url":"https://api.github.com/users/alfonsosanchezbeato/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsosanchezbeato/received_events","type":"User","site_admin":false},"body":"Which one?","created_at":"2016-05-30T07:38:08Z","updated_at":"2016-05-30T07:38:08Z","html_url":"https://github.com/snapcore/snapd/pull/1226#discussion_r65034776","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/1226","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/65034776"},"html":{"href":"https://github.com/snapcore/snapd/pull/1226#discussion_r65034776"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/1226"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/1226","id":71420470,"html_url":"https://github.com/snapcore/snapd/pull/1226","diff_url":"https://github.com/snapcore/snapd/pull/1226.diff","patch_url":"https://github.com/snapcore/snapd/pull/1226.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/1226","number":1226,"state":"open","locked":false,"title":"Interface for modem manager","user":{"login":"alfonsosanchezbeato","id":3833021,"avatar_url":"https://avatars.githubusercontent.com/u/3833021?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonsosanchezbeato","html_url":"https://github.com/alfonsosanchezbeato","followers_url":"https://api.github.com/users/alfonsosanchezbeato/followers","following_url":"https://api.github.com/users/alfonsosanchezbeato/following{/other_user}","gists_url":"https://api.github.com/users/alfonsosanchezbeato/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsosanchezbeato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsosanchezbeato/subscriptions","organizations_url":"https://api.github.com/users/alfonsosanchezbeato/orgs","repos_url":"https://api.github.com/users/alfonsosanchezbeato/repos","events_url":"https://api.github.com/users/alfonsosanchezbeato/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsosanchezbeato/received_events","type":"User","site_admin":false},"body":"Initial proposal for interface to enable modem-manager snap.\r\n\r\nSome additional changes needed for network-manager are included in this PR too.","created_at":"2016-05-25T16:16:02Z","updated_at":"2016-05-30T07:38:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9999b9020c2fd03a1ff8da86a8d1e9be5f49770","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/1226/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/1226/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/1226/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/59e04f87671883f6e5e0644f5ffbd2664624913f","head":{"label":"alfonsosanchezbeato:modem-manager-iface","ref":"modem-manager-iface","sha":"59e04f87671883f6e5e0644f5ffbd2664624913f","user":{"login":"alfonsosanchezbeato","id":3833021,"avatar_url":"https://avatars.githubusercontent.com/u/3833021?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonsosanchezbeato","html_url":"https://github.com/alfonsosanchezbeato","followers_url":"https://api.github.com/users/alfonsosanchezbeato/followers","following_url":"https://api.github.com/users/alfonsosanchezbeato/following{/other_user}","gists_url":"https://api.github.com/users/alfonsosanchezbeato/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsosanchezbeato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsosanchezbeato/subscriptions","organizations_url":"https://api.github.com/users/alfonsosanchezbeato/orgs","repos_url":"https://api.github.com/users/alfonsosanchezbeato/repos","events_url":"https://api.github.com/users/alfonsosanchezbeato/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsosanchezbeato/received_events","type":"User","site_admin":false},"repo":{"id":59465766,"name":"snappy","full_name":"alfonsosanchezbeato/snappy","owner":{"login":"alfonsosanchezbeato","id":3833021,"avatar_url":"https://avatars.githubusercontent.com/u/3833021?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonsosanchezbeato","html_url":"https://github.com/alfonsosanchezbeato","followers_url":"https://api.github.com/users/alfonsosanchezbeato/followers","following_url":"https://api.github.com/users/alfonsosanchezbeato/following{/other_user}","gists_url":"https://api.github.com/users/alfonsosanchezbeato/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsosanchezbeato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsosanchezbeato/subscriptions","organizations_url":"https://api.github.com/users/alfonsosanchezbeato/orgs","repos_url":"https://api.github.com/users/alfonsosanchezbeato/repos","events_url":"https://api.github.com/users/alfonsosanchezbeato/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsosanchezbeato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alfonsosanchezbeato/snappy","description":"Snappy is the software at the heart of Ubuntu Core.","fork":true,"url":"https://api.github.com/repos/alfonsosanchezbeato/snappy","forks_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/forks","keys_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/teams","hooks_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/hooks","issue_events_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/issues/events{/number}","events_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/events","assignees_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/assignees{/user}","branches_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/branches{/branch}","tags_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/tags","blobs_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/git/refs{/sha}","trees_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/statuses/{sha}","languages_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/languages","stargazers_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/stargazers","contributors_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/contributors","subscribers_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/subscribers","subscription_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/subscription","commits_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/commits{/sha}","git_commits_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/git/commits{/sha}","comments_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/comments{/number}","issue_comment_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/issues/comments{/number}","contents_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/contents/{+path}","compare_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/merges","archive_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/downloads","issues_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/issues{/number}","pulls_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/pulls{/number}","milestones_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/milestones{/number}","notifications_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/labels{/name}","releases_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/releases{/id}","deployments_url":"https://api.github.com/repos/alfonsosanchezbeato/snappy/deployments","created_at":"2016-05-23T08:33:03Z","updated_at":"2016-05-23T08:33:05Z","pushed_at":"2016-05-26T07:05:48Z","git_url":"git://github.com/alfonsosanchezbeato/snappy.git","ssh_url":"git@github.com:alfonsosanchezbeato/snappy.git","clone_url":"https://github.com/alfonsosanchezbeato/snappy.git","svn_url":"https://github.com/alfonsosanchezbeato/snappy","homepage":null,"size":30117,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"ddd67b1917d1a53cf0fc857fd774e9ff42476580","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"name":"snapd","full_name":"snapcore/snapd","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2016-05-25T16:47:30Z","pushed_at":"2016-05-30T07:10:44Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":31709,"stargazers_count":200,"watchers_count":200,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":16,"forks":50,"open_issues":16,"watchers":200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/1226"},"html":{"href":"https://github.com/snapcore/snapd/pull/1226"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/1226"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/1226/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/1226/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/1226/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/59e04f87671883f6e5e0644f5ffbd2664624913f"}}}}
{"actor":{"display_login":"alfonsosanchezbeato"}}