{"action":"opened","issue":{"url":"https://api.github.com/repos/abcminiuser/dmbs/issues/15","repository_url":"https://api.github.com/repos/abcminiuser/dmbs","labels_url":"https://api.github.com/repos/abcminiuser/dmbs/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/abcminiuser/dmbs/issues/15/comments","events_url":"https://api.github.com/repos/abcminiuser/dmbs/issues/15/events","html_url":"https://github.com/abcminiuser/dmbs/issues/15","id":180956086,"number":15,"title":"Add include guard for core modules","user":{"login":"NicoHood","id":6888294,"avatar_url":"https://avatars.githubusercontent.com/u/6888294?v=3","gravatar_id":"","url":"https://api.github.com/users/NicoHood","html_url":"https://github.com/NicoHood","followers_url":"https://api.github.com/users/NicoHood/followers","following_url":"https://api.github.com/users/NicoHood/following{/other_user}","gists_url":"https://api.github.com/users/NicoHood/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoHood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoHood/subscriptions","organizations_url":"https://api.github.com/users/NicoHood/orgs","repos_url":"https://api.github.com/users/NicoHood/repos","events_url":"https://api.github.com/users/NicoHood/events{/privacy}","received_events_url":"https://api.github.com/users/NicoHood/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-04T17:32:05Z","updated_at":"2016-10-04T17:32:05Z","closed_at":null,"body":"If you include the core (or other) modules with other modules it should not be included again. Its a similar technique as in c header files. Its better to add the inclusion check into the core module than into your own module if you ask me. Correct me if I am wrong.\r\n\r\n```make\r\nifeq ($(findstring CORE, $(DMBS_BUILD_MODULES)),)\r\n...\r\nendif\r\n```\r\n\r\nI am willing to prepare a PR for this if you say this makes sense."}}
{"actor":{"display_login":"NicoHood"}}