{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/apollo/pulls/comments/64374262","id":64374262,"diff_hunk":"@@ -366,16 +375,8 @@ public void testSignalShutdown() throws Exception {\n     Service service = ServiceImpl.builder(\"test\").build();\n     try (final Service.Instance instance = service.start(\"--syslog=false\")) {\n \n-      // Force predictable concurrency of signal and main loop start\n-      final CountDownLatch countDownLatch = new CountDownLatch(1);\n-      instance.getExecutorService().submit(() -> {\n-        countDownLatch.await();\n-        Thread.sleep(200);\n-        instance.getSignaller().signalShutdown();\n-        return null;\n-      });\n+      instance.getSignaller().signalShutdown();","path":"apollo-core/src/test/java/com/spotify/apollo/core/ServiceImplTest.java","position":42,"original_position":42,"commit_id":"a2367fee2e4c7f4b39cfc504042a5d5a4ab622bd","original_commit_id":"a2367fee2e4c7f4b39cfc504042a5d5a4ab622bd","user":{"login":"pettermahlen","id":353687,"avatar_url":"https://avatars.githubusercontent.com/u/353687?v=3","gravatar_id":"","url":"https://api.github.com/users/pettermahlen","html_url":"https://github.com/pettermahlen","followers_url":"https://api.github.com/users/pettermahlen/followers","following_url":"https://api.github.com/users/pettermahlen/following{/other_user}","gists_url":"https://api.github.com/users/pettermahlen/gists{/gist_id}","starred_url":"https://api.github.com/users/pettermahlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pettermahlen/subscriptions","organizations_url":"https://api.github.com/users/pettermahlen/orgs","repos_url":"https://api.github.com/users/pettermahlen/repos","events_url":"https://api.github.com/users/pettermahlen/events{/privacy}","received_events_url":"https://api.github.com/users/pettermahlen/received_events","type":"User","site_admin":false},"body":"Yes. I didn't see much added value in doing shutdown and wait on separate threads, though, so I simplified the test case. Do you think there is value there?","created_at":"2016-05-24T11:33:22Z","updated_at":"2016-05-24T11:33:22Z","html_url":"https://github.com/spotify/apollo/pull/109#discussion_r64374262","pull_request_url":"https://api.github.com/repos/spotify/apollo/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/spotify/apollo/pulls/comments/64374262"},"html":{"href":"https://github.com/spotify/apollo/pull/109#discussion_r64374262"},"pull_request":{"href":"https://api.github.com/repos/spotify/apollo/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/spotify/apollo/pulls/109","id":70948898,"html_url":"https://github.com/spotify/apollo/pull/109","diff_url":"https://github.com/spotify/apollo/pull/109.diff","patch_url":"https://github.com/spotify/apollo/pull/109.patch","issue_url":"https://api.github.com/repos/spotify/apollo/issues/109","number":109,"state":"open","locked":false,"title":"Remove instance executors","user":{"login":"pettermahlen","id":353687,"avatar_url":"https://avatars.githubusercontent.com/u/353687?v=3","gravatar_id":"","url":"https://api.github.com/users/pettermahlen","html_url":"https://github.com/pettermahlen","followers_url":"https://api.github.com/users/pettermahlen/followers","following_url":"https://api.github.com/users/pettermahlen/following{/other_user}","gists_url":"https://api.github.com/users/pettermahlen/gists{/gist_id}","starred_url":"https://api.github.com/users/pettermahlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pettermahlen/subscriptions","organizations_url":"https://api.github.com/users/pettermahlen/orgs","repos_url":"https://api.github.com/users/pettermahlen/repos","events_url":"https://api.github.com/users/pettermahlen/events{/privacy}","received_events_url":"https://api.github.com/users/pettermahlen/received_events","type":"User","site_admin":false},"body":"The idea is that executors are easy to provide at the application level, if needed, and that the ones provided by Apollo are very rarely used in practice. So it's a feature of Apollo that doesn't carry its weight.\r\n\r\nThis PR also does some minor cleanup of the ServiceImpl class.","created_at":"2016-05-21T12:58:09Z","updated_at":"2016-05-24T11:33:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f5d7242466433aab6f64791dd45e9a5aae3264a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spotify/apollo/pulls/109/commits","review_comments_url":"https://api.github.com/repos/spotify/apollo/pulls/109/comments","review_comment_url":"https://api.github.com/repos/spotify/apollo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/apollo/issues/109/comments","statuses_url":"https://api.github.com/repos/spotify/apollo/statuses/a2367fee2e4c7f4b39cfc504042a5d5a4ab622bd","head":{"label":"pettermahlen:remove-instance-executors","ref":"remove-instance-executors","sha":"a2367fee2e4c7f4b39cfc504042a5d5a4ab622bd","user":{"login":"pettermahlen","id":353687,"avatar_url":"https://avatars.githubusercontent.com/u/353687?v=3","gravatar_id":"","url":"https://api.github.com/users/pettermahlen","html_url":"https://github.com/pettermahlen","followers_url":"https://api.github.com/users/pettermahlen/followers","following_url":"https://api.github.com/users/pettermahlen/following{/other_user}","gists_url":"https://api.github.com/users/pettermahlen/gists{/gist_id}","starred_url":"https://api.github.com/users/pettermahlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pettermahlen/subscriptions","organizations_url":"https://api.github.com/users/pettermahlen/orgs","repos_url":"https://api.github.com/users/pettermahlen/repos","events_url":"https://api.github.com/users/pettermahlen/events{/privacy}","received_events_url":"https://api.github.com/users/pettermahlen/received_events","type":"User","site_admin":false},"repo":{"id":46419365,"name":"apollo","full_name":"pettermahlen/apollo","owner":{"login":"pettermahlen","id":353687,"avatar_url":"https://avatars.githubusercontent.com/u/353687?v=3","gravatar_id":"","url":"https://api.github.com/users/pettermahlen","html_url":"https://github.com/pettermahlen","followers_url":"https://api.github.com/users/pettermahlen/followers","following_url":"https://api.github.com/users/pettermahlen/following{/other_user}","gists_url":"https://api.github.com/users/pettermahlen/gists{/gist_id}","starred_url":"https://api.github.com/users/pettermahlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pettermahlen/subscriptions","organizations_url":"https://api.github.com/users/pettermahlen/orgs","repos_url":"https://api.github.com/users/pettermahlen/repos","events_url":"https://api.github.com/users/pettermahlen/events{/privacy}","received_events_url":"https://api.github.com/users/pettermahlen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pettermahlen/apollo","description":"Java libraries for writing composable microservices","fork":true,"url":"https://api.github.com/repos/pettermahlen/apollo","forks_url":"https://api.github.com/repos/pettermahlen/apollo/forks","keys_url":"https://api.github.com/repos/pettermahlen/apollo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pettermahlen/apollo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pettermahlen/apollo/teams","hooks_url":"https://api.github.com/repos/pettermahlen/apollo/hooks","issue_events_url":"https://api.github.com/repos/pettermahlen/apollo/issues/events{/number}","events_url":"https://api.github.com/repos/pettermahlen/apollo/events","assignees_url":"https://api.github.com/repos/pettermahlen/apollo/assignees{/user}","branches_url":"https://api.github.com/repos/pettermahlen/apollo/branches{/branch}","tags_url":"https://api.github.com/repos/pettermahlen/apollo/tags","blobs_url":"https://api.github.com/repos/pettermahlen/apollo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pettermahlen/apollo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pettermahlen/apollo/git/refs{/sha}","trees_url":"https://api.github.com/repos/pettermahlen/apollo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pettermahlen/apollo/statuses/{sha}","languages_url":"https://api.github.com/repos/pettermahlen/apollo/languages","stargazers_url":"https://api.github.com/repos/pettermahlen/apollo/stargazers","contributors_url":"https://api.github.com/repos/pettermahlen/apollo/contributors","subscribers_url":"https://api.github.com/repos/pettermahlen/apollo/subscribers","subscription_url":"https://api.github.com/repos/pettermahlen/apollo/subscription","commits_url":"https://api.github.com/repos/pettermahlen/apollo/commits{/sha}","git_commits_url":"https://api.github.com/repos/pettermahlen/apollo/git/commits{/sha}","comments_url":"https://api.github.com/repos/pettermahlen/apollo/comments{/number}","issue_comment_url":"https://api.github.com/repos/pettermahlen/apollo/issues/comments{/number}","contents_url":"https://api.github.com/repos/pettermahlen/apollo/contents/{+path}","compare_url":"https://api.github.com/repos/pettermahlen/apollo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pettermahlen/apollo/merges","archive_url":"https://api.github.com/repos/pettermahlen/apollo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pettermahlen/apollo/downloads","issues_url":"https://api.github.com/repos/pettermahlen/apollo/issues{/number}","pulls_url":"https://api.github.com/repos/pettermahlen/apollo/pulls{/number}","milestones_url":"https://api.github.com/repos/pettermahlen/apollo/milestones{/number}","notifications_url":"https://api.github.com/repos/pettermahlen/apollo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pettermahlen/apollo/labels{/name}","releases_url":"https://api.github.com/repos/pettermahlen/apollo/releases{/id}","deployments_url":"https://api.github.com/repos/pettermahlen/apollo/deployments","created_at":"2015-11-18T13:08:59Z","updated_at":"2015-11-18T13:09:01Z","pushed_at":"2016-05-24T09:42:34Z","git_url":"git://github.com/pettermahlen/apollo.git","ssh_url":"git@github.com:pettermahlen/apollo.git","clone_url":"https://github.com/pettermahlen/apollo.git","svn_url":"https://github.com/pettermahlen/apollo","homepage":"http://spotify.github.io/apollo/","size":850,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"116a9af89ae6b9511a827185ec76d5f34d5dcd38","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":45644056,"name":"apollo","full_name":"spotify/apollo","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/apollo","description":"Java libraries for writing composable microservices","fork":false,"url":"https://api.github.com/repos/spotify/apollo","forks_url":"https://api.github.com/repos/spotify/apollo/forks","keys_url":"https://api.github.com/repos/spotify/apollo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/apollo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/apollo/teams","hooks_url":"https://api.github.com/repos/spotify/apollo/hooks","issue_events_url":"https://api.github.com/repos/spotify/apollo/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/apollo/events","assignees_url":"https://api.github.com/repos/spotify/apollo/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/apollo/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/apollo/tags","blobs_url":"https://api.github.com/repos/spotify/apollo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/apollo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/apollo/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/apollo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/apollo/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/apollo/languages","stargazers_url":"https://api.github.com/repos/spotify/apollo/stargazers","contributors_url":"https://api.github.com/repos/spotify/apollo/contributors","subscribers_url":"https://api.github.com/repos/spotify/apollo/subscribers","subscription_url":"https://api.github.com/repos/spotify/apollo/subscription","commits_url":"https://api.github.com/repos/spotify/apollo/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/apollo/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/apollo/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/apollo/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/apollo/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/apollo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/apollo/merges","archive_url":"https://api.github.com/repos/spotify/apollo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/apollo/downloads","issues_url":"https://api.github.com/repos/spotify/apollo/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/apollo/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/apollo/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/apollo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/apollo/labels{/name}","releases_url":"https://api.github.com/repos/spotify/apollo/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/apollo/deployments","created_at":"2015-11-05T22:40:39Z","updated_at":"2016-05-24T10:59:46Z","pushed_at":"2016-05-24T09:42:36Z","git_url":"git://github.com/spotify/apollo.git","ssh_url":"git@github.com:spotify/apollo.git","clone_url":"https://github.com/spotify/apollo.git","svn_url":"https://github.com/spotify/apollo","homepage":"http://spotify.github.io/apollo/","size":1737,"stargazers_count":676,"watchers_count":676,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"open_issues_count":11,"forks":65,"open_issues":11,"watchers":676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/apollo/pulls/109"},"html":{"href":"https://github.com/spotify/apollo/pull/109"},"issue":{"href":"https://api.github.com/repos/spotify/apollo/issues/109"},"comments":{"href":"https://api.github.com/repos/spotify/apollo/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/apollo/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/apollo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/apollo/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/apollo/statuses/a2367fee2e4c7f4b39cfc504042a5d5a4ab622bd"}}}}
{"actor":{"display_login":"pettermahlen"}}