{"action":"created","comment":{"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/comments/71744978","id":71744978,"diff_hunk":"@@ -27,6 +27,31 @@ import (\n \t. \"github.com/smartystreets/goconvey/convey\"\n )\n \n+// -------------------- init ---------------------------\n+// init connects to a local RabbitMQ server for testing and\n+// creates a 'snap' exchange and 'snapq' queue for test purposes.\n+// With the way the RabbitMQ API works, some metrics are not available\n+// until a queue or exchange exist. For certain tests in this\n+// file to succeed, we must first create an exchange and queue.\n+\n+func initRMQServer() {\n+\tcon, err := NewConsumer(\n+\t\t\"localhost:5672\",\n+\t\t\"snap\",\n+\t\t\"fanout\",\n+\t\t\"snapq\",\n+\t\t\"metrics\",\n+\t\t\"conTag\",\n+\t)\n+\tif err != nil {","path":"rabbitmq/client_integration_test.go","position":20,"original_position":20,"commit_id":"d33dc605712d400b8eed595dc41f8b7271da900d","original_commit_id":"d33dc605712d400b8eed595dc41f8b7271da900d","user":{"login":"candysmurf","id":13841563,"avatar_url":"https://avatars.githubusercontent.com/u/13841563?v=3","gravatar_id":"","url":"https://api.github.com/users/candysmurf","html_url":"https://github.com/candysmurf","followers_url":"https://api.github.com/users/candysmurf/followers","following_url":"https://api.github.com/users/candysmurf/following{/other_user}","gists_url":"https://api.github.com/users/candysmurf/gists{/gist_id}","starred_url":"https://api.github.com/users/candysmurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candysmurf/subscriptions","organizations_url":"https://api.github.com/users/candysmurf/orgs","repos_url":"https://api.github.com/users/candysmurf/repos","events_url":"https://api.github.com/users/candysmurf/events{/privacy}","received_events_url":"https://api.github.com/users/candysmurf/received_events","type":"User","site_admin":false},"body":"what if the RabbitMQ server was not started, do like to give a user more descriptive message instead of a panic?","created_at":"2016-07-21T17:02:45Z","updated_at":"2016-07-21T17:02:45Z","html_url":"https://github.com/intelsdi-x/snap-plugin-collector-rabbitmq/pull/6#discussion_r71744978","pull_request_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/comments/71744978"},"html":{"href":"https://github.com/intelsdi-x/snap-plugin-collector-rabbitmq/pull/6#discussion_r71744978"},"pull_request":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/6","id":77850659,"html_url":"https://github.com/intelsdi-x/snap-plugin-collector-rabbitmq/pull/6","diff_url":"https://github.com/intelsdi-x/snap-plugin-collector-rabbitmq/pull/6.diff","patch_url":"https://github.com/intelsdi-x/snap-plugin-collector-rabbitmq/pull/6.patch","issue_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/issues/6","number":6,"state":"open","locked":false,"title":"Download dependency before running integration tests","user":{"login":"geauxvirtual","id":1395030,"avatar_url":"https://avatars.githubusercontent.com/u/1395030?v=3","gravatar_id":"","url":"https://api.github.com/users/geauxvirtual","html_url":"https://github.com/geauxvirtual","followers_url":"https://api.github.com/users/geauxvirtual/followers","following_url":"https://api.github.com/users/geauxvirtual/following{/other_user}","gists_url":"https://api.github.com/users/geauxvirtual/gists{/gist_id}","starred_url":"https://api.github.com/users/geauxvirtual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geauxvirtual/subscriptions","organizations_url":"https://api.github.com/users/geauxvirtual/orgs","repos_url":"https://api.github.com/users/geauxvirtual/repos","events_url":"https://api.github.com/users/geauxvirtual/events{/privacy}","received_events_url":"https://api.github.com/users/geauxvirtual/received_events","type":"User","site_admin":false},"body":"Updates for integration tests to pass in Travis.\r\n- Download client dependency (amqp) before tests are run\r\n- Update Travis to test Go 1.5.4 and Go 1.6.3.\r\n- plugin.PluginMetricType -> plugin.MetricType changes in integration tests\r\n- Connect to RMQ server to create exchange and queue before running exchange and queue API tests.","created_at":"2016-07-18T18:01:01Z","updated_at":"2016-07-21T17:02:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d54bedc11541e0e09db6eee65e7df9139b54a63c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/6/commits","review_comments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/6/comments","review_comment_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/issues/6/comments","statuses_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/statuses/d33dc605712d400b8eed595dc41f8b7271da900d","head":{"label":"geauxvirtual:tb/fix_travis_tests","ref":"tb/fix_travis_tests","sha":"d33dc605712d400b8eed595dc41f8b7271da900d","user":{"login":"geauxvirtual","id":1395030,"avatar_url":"https://avatars.githubusercontent.com/u/1395030?v=3","gravatar_id":"","url":"https://api.github.com/users/geauxvirtual","html_url":"https://github.com/geauxvirtual","followers_url":"https://api.github.com/users/geauxvirtual/followers","following_url":"https://api.github.com/users/geauxvirtual/following{/other_user}","gists_url":"https://api.github.com/users/geauxvirtual/gists{/gist_id}","starred_url":"https://api.github.com/users/geauxvirtual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geauxvirtual/subscriptions","organizations_url":"https://api.github.com/users/geauxvirtual/orgs","repos_url":"https://api.github.com/users/geauxvirtual/repos","events_url":"https://api.github.com/users/geauxvirtual/events{/privacy}","received_events_url":"https://api.github.com/users/geauxvirtual/received_events","type":"User","site_admin":false},"repo":{"id":61918364,"name":"snap-plugin-collector-rabbitmq","full_name":"geauxvirtual/snap-plugin-collector-rabbitmq","owner":{"login":"geauxvirtual","id":1395030,"avatar_url":"https://avatars.githubusercontent.com/u/1395030?v=3","gravatar_id":"","url":"https://api.github.com/users/geauxvirtual","html_url":"https://github.com/geauxvirtual","followers_url":"https://api.github.com/users/geauxvirtual/followers","following_url":"https://api.github.com/users/geauxvirtual/following{/other_user}","gists_url":"https://api.github.com/users/geauxvirtual/gists{/gist_id}","starred_url":"https://api.github.com/users/geauxvirtual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geauxvirtual/subscriptions","organizations_url":"https://api.github.com/users/geauxvirtual/orgs","repos_url":"https://api.github.com/users/geauxvirtual/repos","events_url":"https://api.github.com/users/geauxvirtual/events{/privacy}","received_events_url":"https://api.github.com/users/geauxvirtual/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geauxvirtual/snap-plugin-collector-rabbitmq","description":"snap plugin for collecting metrics for a Rabbitmq node or cluster through the management API","fork":true,"url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq","forks_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/forks","keys_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/teams","hooks_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/hooks","issue_events_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/issues/events{/number}","events_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/events","assignees_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/assignees{/user}","branches_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/branches{/branch}","tags_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/tags","blobs_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/statuses/{sha}","languages_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/languages","stargazers_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/stargazers","contributors_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/contributors","subscribers_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/subscribers","subscription_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/subscription","commits_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/contents/{+path}","compare_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/merges","archive_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/downloads","issues_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/issues{/number}","pulls_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/pulls{/number}","milestones_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/milestones{/number}","notifications_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/labels{/name}","releases_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/releases{/id}","deployments_url":"https://api.github.com/repos/geauxvirtual/snap-plugin-collector-rabbitmq/deployments","created_at":"2016-06-24T23:47:11Z","updated_at":"2016-06-24T23:47:11Z","pushed_at":"2016-07-19T23:05:58Z","git_url":"git://github.com/geauxvirtual/snap-plugin-collector-rabbitmq.git","ssh_url":"git@github.com:geauxvirtual/snap-plugin-collector-rabbitmq.git","clone_url":"https://github.com/geauxvirtual/snap-plugin-collector-rabbitmq.git","svn_url":"https://github.com/geauxvirtual/snap-plugin-collector-rabbitmq","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intelsdi-x:master","ref":"master","sha":"fae3373f3fab1f913061c41da8872f36a57110ff","user":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"repo":{"id":48139545,"name":"snap-plugin-collector-rabbitmq","full_name":"intelsdi-x/snap-plugin-collector-rabbitmq","owner":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intelsdi-x/snap-plugin-collector-rabbitmq","description":"Collects RabbitMQ metrics from management API","fork":false,"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq","forks_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/forks","keys_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/teams","hooks_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/hooks","issue_events_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/issues/events{/number}","events_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/events","assignees_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/assignees{/user}","branches_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/branches{/branch}","tags_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/tags","blobs_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/statuses/{sha}","languages_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/languages","stargazers_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/stargazers","contributors_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/contributors","subscribers_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/subscribers","subscription_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/subscription","commits_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/contents/{+path}","compare_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/merges","archive_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/downloads","issues_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/issues{/number}","pulls_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls{/number}","milestones_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/milestones{/number}","notifications_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/labels{/name}","releases_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/releases{/id}","deployments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/deployments","created_at":"2015-12-16T22:47:54Z","updated_at":"2016-07-15T23:24:28Z","pushed_at":"2016-07-19T23:05:58Z","git_url":"git://github.com/intelsdi-x/snap-plugin-collector-rabbitmq.git","ssh_url":"git@github.com:intelsdi-x/snap-plugin-collector-rabbitmq.git","clone_url":"https://github.com/intelsdi-x/snap-plugin-collector-rabbitmq.git","svn_url":"https://github.com/intelsdi-x/snap-plugin-collector-rabbitmq","homepage":"http://snap-telemetry.io/","size":32,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/6"},"html":{"href":"https://github.com/intelsdi-x/snap-plugin-collector-rabbitmq/pull/6"},"issue":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/issues/6"},"comments":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-rabbitmq/statuses/d33dc605712d400b8eed595dc41f8b7271da900d"}}}}
{"actor":{"display_login":"candysmurf"}}