{"action":"created","issue":{"url":"https://api.github.com/repos/mlr-org/mlr/issues/959","repository_url":"https://api.github.com/repos/mlr-org/mlr","labels_url":"https://api.github.com/repos/mlr-org/mlr/issues/959/labels{/name}","comments_url":"https://api.github.com/repos/mlr-org/mlr/issues/959/comments","events_url":"https://api.github.com/repos/mlr-org/mlr/issues/959/events","html_url":"https://github.com/mlr-org/mlr/pull/959","id":161187735,"number":959,"title":"Create test for all survival learners (don't merge, still in review)","user":{"login":"MariaErdmann","id":18098454,"avatar_url":"https://avatars.githubusercontent.com/u/18098454?v=3","gravatar_id":"","url":"https://api.github.com/users/MariaErdmann","html_url":"https://github.com/MariaErdmann","followers_url":"https://api.github.com/users/MariaErdmann/followers","following_url":"https://api.github.com/users/MariaErdmann/following{/other_user}","gists_url":"https://api.github.com/users/MariaErdmann/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaErdmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaErdmann/subscriptions","organizations_url":"https://api.github.com/users/MariaErdmann/orgs","repos_url":"https://api.github.com/users/MariaErdmann/repos","events_url":"https://api.github.com/users/MariaErdmann/events{/privacy}","received_events_url":"https://api.github.com/users/MariaErdmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-20T12:51:27Z","updated_at":"2016-06-30T08:14:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mlr-org/mlr/pulls/959","html_url":"https://github.com/mlr-org/mlr/pull/959","diff_url":"https://github.com/mlr-org/mlr/pull/959.diff","patch_url":"https://github.com/mlr-org/mlr/pull/959.patch"},"body":"creates a test for all survival learners with more \"generic\" functions"},"comment":{"url":"https://api.github.com/repos/mlr-org/mlr/issues/comments/229592344","html_url":"https://github.com/mlr-org/mlr/pull/959#issuecomment-229592344","issue_url":"https://api.github.com/repos/mlr-org/mlr/issues/959","id":229592344,"user":{"login":"MariaErdmann","id":18098454,"avatar_url":"https://avatars.githubusercontent.com/u/18098454?v=3","gravatar_id":"","url":"https://api.github.com/users/MariaErdmann","html_url":"https://github.com/MariaErdmann","followers_url":"https://api.github.com/users/MariaErdmann/followers","following_url":"https://api.github.com/users/MariaErdmann/following{/other_user}","gists_url":"https://api.github.com/users/MariaErdmann/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaErdmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaErdmann/subscriptions","organizations_url":"https://api.github.com/users/MariaErdmann/orgs","repos_url":"https://api.github.com/users/MariaErdmann/repos","events_url":"https://api.github.com/users/MariaErdmann/events{/privacy}","received_events_url":"https://api.github.com/users/MariaErdmann/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T08:14:26Z","updated_at":"2016-06-30T08:14:26Z","body":"This is what happened:\r\n\r\nhelper_learners_all: \r\n\r\n- arguments that are used multiple times in header now\r\n- changed name\r\n- added some more functionality to testThatLearnerCanTrainPredict(): now it tests also whether learner can predict probs and se. Maybe the part with setPredictType.Learner() should better be setPredictType()?\r\n\r\ntest_learners_all_regr, test_learners_all_classif, test_learners_all_cluster were adapted:\r\n\r\n- test_learners_all_cluster:\r\n There was a FIXME line saying \"Remove this if DBScan runs stable\". Since !inherits(lrn, \"cluster.DBScan\") was always TRUE I removed the FIXME and line. Please tell me, if this lines should be kept.\r\n- The tests do produce some warnings. Some of them cannot be avoided, but some of them may be resolved by manipulating the data a little bit more (i.e. glm.fit fitted probabilities numerically 0 or 1)?\r\n- When testing probabilities in the od scripts, there was a line getPredictionProbabilities(). I don't think this line is necessary, so I removed it.\r\n\r\n\r\nAdded test_learners_all_multilabel\r\n\r\nDid some layout adaption on test_learners_all_surv\r\n\r\n"}}
{"actor":{"display_login":"MariaErdmann"}}