{"action":"created","issue":{"url":"https://api.github.com/repos/lalten/rpg_dvs_ros/issues/1","labels_url":"https://api.github.com/repos/lalten/rpg_dvs_ros/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/lalten/rpg_dvs_ros/issues/1/comments","events_url":"https://api.github.com/repos/lalten/rpg_dvs_ros/issues/1/events","html_url":"https://github.com/lalten/rpg_dvs_ros/pull/1","id":124796459,"number":1,"title":"Feature: Publish and Inspect detected patterns","user":{"login":"plieningerweb","id":481107,"avatar_url":"https://avatars.githubusercontent.com/u/481107?v=3","gravatar_id":"","url":"https://api.github.com/users/plieningerweb","html_url":"https://github.com/plieningerweb","followers_url":"https://api.github.com/users/plieningerweb/followers","following_url":"https://api.github.com/users/plieningerweb/following{/other_user}","gists_url":"https://api.github.com/users/plieningerweb/gists{/gist_id}","starred_url":"https://api.github.com/users/plieningerweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plieningerweb/subscriptions","organizations_url":"https://api.github.com/users/plieningerweb/orgs","repos_url":"https://api.github.com/users/plieningerweb/repos","events_url":"https://api.github.com/users/plieningerweb/events{/privacy}","received_events_url":"https://api.github.com/users/plieningerweb/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-04T16:59:13Z","updated_at":"2016-01-04T17:02:04Z","closed_at":"2016-01-04T17:02:01Z","pull_request":{"url":"https://api.github.com/repos/lalten/rpg_dvs_ros/pulls/1","html_url":"https://github.com/lalten/rpg_dvs_ros/pull/1","diff_url":"https://github.com/lalten/rpg_dvs_ros/pull/1.diff","patch_url":"https://github.com/lalten/rpg_dvs_ros/pull/1.patch"},"body":"Problem:\r\nSometimes, wrong patterns get detected. These wrong pattern have a bad influence on the calibration. \r\n\r\nSolution:\r\nInspect detected patterns before using them for calibration\r\n\r\nHow?\r\nThe detected points and the transition pattern will get published. Then, a new tool helps to pick the patterns. It asks the user, whether to take it or not (yes/no). If the user takes it, it will get published on a new topic, where the calibration process is subscribed to.\r\n\r\nDoes it break the existing way?\r\nYes - because the topic names are now different. \r\n\r\nCan it still work without the manual pattern picker tool?\r\nIn order to work like before, the calibration process has to subscribe to its own published detected patterns. This can be achieved by remapping the topics in a launch file.\r\n\r\nUtilities:\r\nIn order to further investigate the problems, one can use rosbag and python scripts to plot the detected points.\r\n"},"comment":{"url":"https://api.github.com/repos/lalten/rpg_dvs_ros/issues/comments/168735069","html_url":"https://github.com/lalten/rpg_dvs_ros/pull/1#issuecomment-168735069","issue_url":"https://api.github.com/repos/lalten/rpg_dvs_ros/issues/1","id":168735069,"user":{"login":"lalten","id":11611719,"avatar_url":"https://avatars.githubusercontent.com/u/11611719?v=3","gravatar_id":"","url":"https://api.github.com/users/lalten","html_url":"https://github.com/lalten","followers_url":"https://api.github.com/users/lalten/followers","following_url":"https://api.github.com/users/lalten/following{/other_user}","gists_url":"https://api.github.com/users/lalten/gists{/gist_id}","starred_url":"https://api.github.com/users/lalten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lalten/subscriptions","organizations_url":"https://api.github.com/users/lalten/orgs","repos_url":"https://api.github.com/users/lalten/repos","events_url":"https://api.github.com/users/lalten/events{/privacy}","received_events_url":"https://api.github.com/users/lalten/received_events","type":"User","site_admin":false},"created_at":"2016-01-04T17:02:04Z","updated_at":"2016-01-04T17:02:04Z","body":":+1:, here is a :cookie: for you :smile: "}}