{"action":"created","issue":{"url":"https://api.github.com/repos/google/lovefield/issues/166","repository_url":"https://api.github.com/repos/google/lovefield","labels_url":"https://api.github.com/repos/google/lovefield/issues/166/labels{/name}","comments_url":"https://api.github.com/repos/google/lovefield/issues/166/comments","events_url":"https://api.github.com/repos/google/lovefield/issues/166/events","html_url":"https://github.com/google/lovefield/issues/166","id":162304619,"number":166,"title":"Wrong RawForeignKeySpec.timing type","user":{"login":"mattblang","id":1845257,"avatar_url":"https://avatars.githubusercontent.com/u/1845257?v=3","gravatar_id":"","url":"https://api.github.com/users/mattblang","html_url":"https://github.com/mattblang","followers_url":"https://api.github.com/users/mattblang/followers","following_url":"https://api.github.com/users/mattblang/following{/other_user}","gists_url":"https://api.github.com/users/mattblang/gists{/gist_id}","starred_url":"https://api.github.com/users/mattblang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattblang/subscriptions","organizations_url":"https://api.github.com/users/mattblang/orgs","repos_url":"https://api.github.com/users/mattblang/repos","events_url":"https://api.github.com/users/mattblang/events{/privacy}","received_events_url":"https://api.github.com/users/mattblang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-25T23:31:27Z","updated_at":"2016-06-27T17:31:27Z","closed_at":null,"body":"I noticed that `RawForeignKeySpec.timing` is set to `ConstraintAction`. It appears in [the tests](https://github.com/google/lovefield/blob/master/tests/schema/builder_test.js#L57) that it should be `ConstraintTiming`. I submitted [a PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9821) at DefinitelyTyped; I wanted to make an issue here to ensure that the fix in my PR is indeed correct."},"comment":{"url":"https://api.github.com/repos/google/lovefield/issues/comments/228816007","html_url":"https://github.com/google/lovefield/issues/166#issuecomment-228816007","issue_url":"https://api.github.com/repos/google/lovefield/issues/166","id":228816007,"user":{"login":"freshp86","id":7547039,"avatar_url":"https://avatars.githubusercontent.com/u/7547039?v=3","gravatar_id":"","url":"https://api.github.com/users/freshp86","html_url":"https://github.com/freshp86","followers_url":"https://api.github.com/users/freshp86/followers","following_url":"https://api.github.com/users/freshp86/following{/other_user}","gists_url":"https://api.github.com/users/freshp86/gists{/gist_id}","starred_url":"https://api.github.com/users/freshp86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freshp86/subscriptions","organizations_url":"https://api.github.com/users/freshp86/orgs","repos_url":"https://api.github.com/users/freshp86/repos","events_url":"https://api.github.com/users/freshp86/events{/privacy}","received_events_url":"https://api.github.com/users/freshp86/received_events","type":"User","site_admin":false},"created_at":"2016-06-27T17:31:27Z","updated_at":"2016-06-27T17:31:27Z","body":"Responded in the PR. The canonical source of truth for our Typescript definitions is at https://github.com/google/lovefield/blob/master/dist/lovefield.d.ts#L212-217. Thanks for noticing the discrepancy."}}
{"actor":{"display_login":"freshp86"}}