{"action":"created","issue":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3339","repository_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End","labels_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3339/labels{/name}","comments_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3339/comments","events_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3339/events","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3339","id":195916599,"number":3339,"title":"Play video on click","user":{"login":"wgranger","id":14099077,"avatar_url":"https://avatars.githubusercontent.com/u/14099077?v=3","gravatar_id":"","url":"https://api.github.com/users/wgranger","html_url":"https://github.com/wgranger","followers_url":"https://api.github.com/users/wgranger/followers","following_url":"https://api.github.com/users/wgranger/following{/other_user}","gists_url":"https://api.github.com/users/wgranger/gists{/gist_id}","starred_url":"https://api.github.com/users/wgranger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wgranger/subscriptions","organizations_url":"https://api.github.com/users/wgranger/orgs","repos_url":"https://api.github.com/users/wgranger/repos","events_url":"https://api.github.com/users/wgranger/events{/privacy}","received_events_url":"https://api.github.com/users/wgranger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"eatyourgreens","id":59547,"avatar_url":"https://avatars.githubusercontent.com/u/59547?v=3","gravatar_id":"","url":"https://api.github.com/users/eatyourgreens","html_url":"https://github.com/eatyourgreens","followers_url":"https://api.github.com/users/eatyourgreens/followers","following_url":"https://api.github.com/users/eatyourgreens/following{/other_user}","gists_url":"https://api.github.com/users/eatyourgreens/gists{/gist_id}","starred_url":"https://api.github.com/users/eatyourgreens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatyourgreens/subscriptions","organizations_url":"https://api.github.com/users/eatyourgreens/orgs","repos_url":"https://api.github.com/users/eatyourgreens/repos","events_url":"https://api.github.com/users/eatyourgreens/events{/privacy}","received_events_url":"https://api.github.com/users/eatyourgreens/received_events","type":"User","site_admin":false},"assignees":[{"login":"eatyourgreens","id":59547,"avatar_url":"https://avatars.githubusercontent.com/u/59547?v=3","gravatar_id":"","url":"https://api.github.com/users/eatyourgreens","html_url":"https://github.com/eatyourgreens","followers_url":"https://api.github.com/users/eatyourgreens/followers","following_url":"https://api.github.com/users/eatyourgreens/following{/other_user}","gists_url":"https://api.github.com/users/eatyourgreens/gists{/gist_id}","starred_url":"https://api.github.com/users/eatyourgreens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatyourgreens/subscriptions","organizations_url":"https://api.github.com/users/eatyourgreens/orgs","repos_url":"https://api.github.com/users/eatyourgreens/repos","events_url":"https://api.github.com/users/eatyourgreens/events{/privacy}","received_events_url":"https://api.github.com/users/eatyourgreens/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2016-12-15T21:10:07Z","updated_at":"2016-12-21T10:02:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/pulls/3339","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3339","diff_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3339.diff","patch_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3339.patch"},"body":"Describe your changes.\r\nThis allows the ability for a video to play when clicking on the still image. A boolean prop is also added to give the component the ability to hide controls, if needed. Bat detective has video subjects to test functionality.\r\n\r\n# Review Checklist\r\n\r\n- [x] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?\r\n- [x] Does it work on mobile?\r\n- [x] Can you `rm -rf node_modules/ && npm install` and app works as expected?\r\n- [x] Did you deploy a staging branch?\r\n- [ ] Did you get any type checking errors from [Babel Typecheck](https://github.com/codemix/babel-plugin-typecheck)\r\n\r\nhttps://video-click-play.pfe-preview.zooniverse.org/\r\n\r\n## Optional\r\n\r\n- [ ] If it's a new component, is it in ES6? Is it clear of warnings from ESLint?\r\n- [ ] Have you replaced any `ChangeListener` or `PromiseRenderer` components with code that updates component state?\r\n- [ ] If changes are made to the classifier, does the dev classifier still work?\r\n- [ ] Have you added in [flow type annotations](https://flowtype.org/docs/type-annotations.html)?"},"comment":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/comments/268483417","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3339#issuecomment-268483417","issue_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3339","id":268483417,"user":{"login":"eatyourgreens","id":59547,"avatar_url":"https://avatars.githubusercontent.com/u/59547?v=3","gravatar_id":"","url":"https://api.github.com/users/eatyourgreens","html_url":"https://github.com/eatyourgreens","followers_url":"https://api.github.com/users/eatyourgreens/followers","following_url":"https://api.github.com/users/eatyourgreens/following{/other_user}","gists_url":"https://api.github.com/users/eatyourgreens/gists{/gist_id}","starred_url":"https://api.github.com/users/eatyourgreens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatyourgreens/subscriptions","organizations_url":"https://api.github.com/users/eatyourgreens/orgs","repos_url":"https://api.github.com/users/eatyourgreens/repos","events_url":"https://api.github.com/users/eatyourgreens/events{/privacy}","received_events_url":"https://api.github.com/users/eatyourgreens/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T10:02:39Z","updated_at":"2016-12-21T10:02:39Z","body":"I've just done a quick check using the keyboard in Chrome for Arizona Batwatch and the native video controls at https://www.zooniverse.org/projects/zooniverse/arizona-batwatch/talk/tags/insect. You can tab to individual videos and the video element will receive focus. You can then tab to the play button, within the video element (it's hidden in the shadow DOM for that element), and toggle it with the spacebar when it has focus.\r\n\r\nI didn't check any other browsers, but I think that `jsx-a11y` warning about adding click to elements without corresponding keyboard interaction is wrong here. Keyboard support might vary between browsers, though."}}
{"actor":{"display_login":"eatyourgreens"}}