{"action":"closed","issue":{"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2482","repository_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons","labels_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2482/labels{/name}","comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2482/comments","events_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2482/events","html_url":"https://github.com/unknown-horizons/unknown-horizons/issues/2482","id":177568158,"number":2482,"title":"Discuss code style checks","user":{"login":"squiddy","id":50333,"avatar_url":"https://avatars.githubusercontent.com/u/50333?v=3","gravatar_id":"","url":"https://api.github.com/users/squiddy","html_url":"https://github.com/squiddy","followers_url":"https://api.github.com/users/squiddy/followers","following_url":"https://api.github.com/users/squiddy/following{/other_user}","gists_url":"https://api.github.com/users/squiddy/gists{/gist_id}","starred_url":"https://api.github.com/users/squiddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squiddy/subscriptions","organizations_url":"https://api.github.com/users/squiddy/orgs","repos_url":"https://api.github.com/users/squiddy/repos","events_url":"https://api.github.com/users/squiddy/events{/privacy}","received_events_url":"https://api.github.com/users/squiddy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/labels/tests","name":"tests","color":"fef2c0"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-09-17T10:20:23Z","updated_at":"2016-10-19T22:05:28Z","closed_at":"2016-10-19T22:05:28Z","body":"As someone that hasn't contributed to this project in years, it's easier for me to run a tool that will yell at me when code doesn't adhere to the style guide.\r\n\r\nI guess we used to run the `pep8` tool, because there are some settings in `setup.cfg` related to it. However, c289a5173e744bf8f61adc8758ee7d982971e4c4 added a (seemingly more complete) configuration for pylint.\r\n\r\nUnfortunately, running `pylint horizons` spits out thousands (26483 for me) of warnings and errors (whitespace issues, indentation, variable names...). I was going to suggest running code style checks in CI, but at this point it's just not feasible.\r\n\r\nI guess we have two options:\r\n\r\n1) fix warnings and/or adjust code style configuration\r\n2) remove .pylintrc\r\n\r\nPersonally I'd vote for option 1.\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/37992567-discuss-code-style-checks?utm_campaign=plugin&utm_content=tracker%2F287396&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F287396&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"}}
{"actor":{"display_login":"squiddy"}}