{"action":"closed","issue":{"url":"https://api.github.com/repos/tilezen/mapbox-vector-tile/issues/61","repository_url":"https://api.github.com/repos/tilezen/mapbox-vector-tile","labels_url":"https://api.github.com/repos/tilezen/mapbox-vector-tile/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/tilezen/mapbox-vector-tile/issues/61/comments","events_url":"https://api.github.com/repos/tilezen/mapbox-vector-tile/issues/61/events","html_url":"https://github.com/tilezen/mapbox-vector-tile/issues/61","id":167981957,"number":61,"title":"quantize_bounds documentation problem","user":{"login":"alpha-beta-soup","id":5925045,"avatar_url":"https://avatars.githubusercontent.com/u/5925045?v=3","gravatar_id":"","url":"https://api.github.com/users/alpha-beta-soup","html_url":"https://github.com/alpha-beta-soup","followers_url":"https://api.github.com/users/alpha-beta-soup/followers","following_url":"https://api.github.com/users/alpha-beta-soup/following{/other_user}","gists_url":"https://api.github.com/users/alpha-beta-soup/gists{/gist_id}","starred_url":"https://api.github.com/users/alpha-beta-soup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpha-beta-soup/subscriptions","organizations_url":"https://api.github.com/users/alpha-beta-soup/orgs","repos_url":"https://api.github.com/users/alpha-beta-soup/repos","events_url":"https://api.github.com/users/alpha-beta-soup/events{/privacy}","received_events_url":"https://api.github.com/users/alpha-beta-soup/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-27T23:42:30Z","updated_at":"2016-07-28T13:12:20Z","closed_at":"2016-07-28T13:12:20Z","body":"Nice work on this encoder.\r\n\r\nLooking at the documentation for [quantisation](https://github.com/tilezen/mapbox-vector-tile#quantization), it states that:\r\n\r\n> When encoding, pass in the bounds in the form (minx, maxx, miny, maxy) and the coordinates will be scaled appropriately during encoding.\r\n\r\nThe following example then has:\r\n\r\n```python\r\nmapbox_vector_tile.encode([\r\n      {\r\n        \"name\": \"water\",\r\n        \"features\": [\r\n          {\r\n            \"geometry\":\"POINT(15 15)\",\r\n            \"properties\":{\r\n              \"foo\":\"bar\",\r\n            }\r\n          }\r\n        ]\r\n      }\r\n    ], quantize_bounds=(10.0, 10.0, 20.0, 20.0))\r\n```\r\nThose bounds look like minx, miny, maxx, maxy, and indeed the source code:\r\n\r\n```python\r\ndef quantize(self, shape, bounds):\r\n        minx, miny, maxx, maxy = bounds\r\n```\r\n\r\nEasy fix that only affects that bit of documentation in the readme."}}
{"actor":{"display_login":"zerebubuth"}}