{"action":"created","issue":{"url":"https://api.github.com/repos/VcDevel/Vc/issues/141","repository_url":"https://api.github.com/repos/VcDevel/Vc","labels_url":"https://api.github.com/repos/VcDevel/Vc/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/VcDevel/Vc/issues/141/comments","events_url":"https://api.github.com/repos/VcDevel/Vc/issues/141/events","html_url":"https://github.com/VcDevel/Vc/pull/141","id":176265042,"number":141,"title":"Fixing msvc","user":{"login":"hkaiser","id":568063,"avatar_url":"https://avatars.githubusercontent.com/u/568063?v=3","gravatar_id":"","url":"https://api.github.com/users/hkaiser","html_url":"https://github.com/hkaiser","followers_url":"https://api.github.com/users/hkaiser/followers","following_url":"https://api.github.com/users/hkaiser/following{/other_user}","gists_url":"https://api.github.com/users/hkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaiser/subscriptions","organizations_url":"https://api.github.com/users/hkaiser/orgs","repos_url":"https://api.github.com/users/hkaiser/repos","events_url":"https://api.github.com/users/hkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/hkaiser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-11T21:03:27Z","updated_at":"2016-09-13T08:17:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/VcDevel/Vc/pulls/141","html_url":"https://github.com/VcDevel/Vc/pull/141","diff_url":"https://github.com/VcDevel/Vc/pull/141.diff","patch_url":"https://github.com/VcDevel/Vc/pull/141.patch"},"body":"This PR proposes some changes to enable compilation using MSVC. It also adds a new algorithm `simd_for_each_n`.\r\n\r\nThe main change is related to `min()` and `max()` which could be defined as macros. The change protects any use of either of those symbols from being macro expanded."},"comment":{"url":"https://api.github.com/repos/VcDevel/Vc/issues/comments/246609088","html_url":"https://github.com/VcDevel/Vc/pull/141#issuecomment-246609088","issue_url":"https://api.github.com/repos/VcDevel/Vc/issues/141","id":246609088,"user":{"login":"mattkretz","id":3306474,"avatar_url":"https://avatars.githubusercontent.com/u/3306474?v=3","gravatar_id":"","url":"https://api.github.com/users/mattkretz","html_url":"https://github.com/mattkretz","followers_url":"https://api.github.com/users/mattkretz/followers","following_url":"https://api.github.com/users/mattkretz/following{/other_user}","gists_url":"https://api.github.com/users/mattkretz/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkretz/subscriptions","organizations_url":"https://api.github.com/users/mattkretz/orgs","repos_url":"https://api.github.com/users/mattkretz/repos","events_url":"https://api.github.com/users/mattkretz/events{/privacy}","received_events_url":"https://api.github.com/users/mattkretz/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T08:17:23Z","updated_at":"2016-09-13T08:17:23Z","body":"Thanks a lot. I prefer to merge the `simd_for_each_n` addition directly to master.\r\n\r\nThe MSVC min/max workaround looks scary. What is it needed for? ADL issues? I see you did a complete search and replace, changing some unrelated comments on the way. Would you be able to reduce the changes to the code where it's actually needed?\r\n\r\nIn the meantime I'll get my MSVC VM up and running again, so I can finally work on integration of the branch."}}
{"actor":{"display_login":"mattkretz"}}