{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/69383115","id":69383115,"diff_hunk":"@@ -396,7 +396,7 @@ def check(dtype, N, M_=None):\n         k_symb = numpy.asarray(0)\n         out = T.eye(N_symb, M_symb, k_symb, dtype=dtype)\n         f = theano.function([N_symb, M_symb],\n-                            out,\n+                            T.stack(out),","path":"theano/gpuarray/tests/test_basic_ops.py","position":5,"original_position":5,"commit_id":"e5bb1110c62872539d64ca0628fdc9d0ae70fdc2","original_commit_id":"e5bb1110c62872539d64ca0628fdc9d0ae70fdc2","user":{"login":"lamblin","id":178249,"avatar_url":"https://avatars.githubusercontent.com/u/178249?v=3","gravatar_id":"","url":"https://api.github.com/users/lamblin","html_url":"https://github.com/lamblin","followers_url":"https://api.github.com/users/lamblin/followers","following_url":"https://api.github.com/users/lamblin/following{/other_user}","gists_url":"https://api.github.com/users/lamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/lamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamblin/subscriptions","organizations_url":"https://api.github.com/users/lamblin/orgs","repos_url":"https://api.github.com/users/lamblin/repos","events_url":"https://api.github.com/users/lamblin/events{/privacy}","received_events_url":"https://api.github.com/users/lamblin/received_events","type":"User","site_admin":false},"body":"Oh, nevermind, I remember. Can you add a comment explaining that we add `stack` so that eye gets lifted to the GPU, since its inputs are not on the GPU, if that is actually the case?\r\nActually, I don't even know how that would help, since stack does not have any input on the GPU either... Can you check if it is still needed?","created_at":"2016-07-02T21:51:34Z","updated_at":"2016-07-02T21:51:34Z","html_url":"https://github.com/Theano/Theano/pull/4570#discussion_r69383115","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/4570","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/69383115"},"html":{"href":"https://github.com/Theano/Theano/pull/4570#discussion_r69383115"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4570"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/4570","id":72236658,"html_url":"https://github.com/Theano/Theano/pull/4570","diff_url":"https://github.com/Theano/Theano/pull/4570.diff","patch_url":"https://github.com/Theano/Theano/pull/4570.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/4570","number":4570,"state":"open","locked":false,"title":"New graph2gpu","user":{"login":"Sentient07","id":6195312,"avatar_url":"https://avatars.githubusercontent.com/u/6195312?v=3","gravatar_id":"","url":"https://api.github.com/users/Sentient07","html_url":"https://github.com/Sentient07","followers_url":"https://api.github.com/users/Sentient07/followers","following_url":"https://api.github.com/users/Sentient07/following{/other_user}","gists_url":"https://api.github.com/users/Sentient07/gists{/gist_id}","starred_url":"https://api.github.com/users/Sentient07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sentient07/subscriptions","organizations_url":"https://api.github.com/users/Sentient07/orgs","repos_url":"https://api.github.com/users/Sentient07/repos","events_url":"https://api.github.com/users/Sentient07/events{/privacy}","received_events_url":"https://api.github.com/users/Sentient07/received_events","type":"User","site_admin":false},"body":"The continuation of https://github.com/Theano/Theano/pull/4551 after a pathetic rebase. \r\n\r\nTODO (Updated): \r\n\r\n- [x]  Make the test on GpuCumSum op's test pass (Addressed in #4672  )\r\n\r\n- [ ] Make the AbstractConv2d optimization work\r\n\r\n- [x] Add the missed out opt to register_opt2\r\n\r\n- [x] Cache GpuCAReduceCuda, GpuElemwise and others(if possible)\r\n\r\n- [x] Profile with Line_profiler \r\n\r\n- [x] Documentation ","created_at":"2016-06-01T19:18:54Z","updated_at":"2016-07-02T21:51:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcd52dd9b9ab15813f53e5a81149aae5df064862","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/4570/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/4570/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/4570/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/e5bb1110c62872539d64ca0628fdc9d0ae70fdc2","head":{"label":"Sentient07:new_graph2gpu","ref":"new_graph2gpu","sha":"e5bb1110c62872539d64ca0628fdc9d0ae70fdc2","user":{"login":"Sentient07","id":6195312,"avatar_url":"https://avatars.githubusercontent.com/u/6195312?v=3","gravatar_id":"","url":"https://api.github.com/users/Sentient07","html_url":"https://github.com/Sentient07","followers_url":"https://api.github.com/users/Sentient07/followers","following_url":"https://api.github.com/users/Sentient07/following{/other_user}","gists_url":"https://api.github.com/users/Sentient07/gists{/gist_id}","starred_url":"https://api.github.com/users/Sentient07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sentient07/subscriptions","organizations_url":"https://api.github.com/users/Sentient07/orgs","repos_url":"https://api.github.com/users/Sentient07/repos","events_url":"https://api.github.com/users/Sentient07/events{/privacy}","received_events_url":"https://api.github.com/users/Sentient07/received_events","type":"User","site_admin":false},"repo":{"id":46736322,"name":"Theano","full_name":"Sentient07/Theano","owner":{"login":"Sentient07","id":6195312,"avatar_url":"https://avatars.githubusercontent.com/u/6195312?v=3","gravatar_id":"","url":"https://api.github.com/users/Sentient07","html_url":"https://github.com/Sentient07","followers_url":"https://api.github.com/users/Sentient07/followers","following_url":"https://api.github.com/users/Sentient07/following{/other_user}","gists_url":"https://api.github.com/users/Sentient07/gists{/gist_id}","starred_url":"https://api.github.com/users/Sentient07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sentient07/subscriptions","organizations_url":"https://api.github.com/users/Sentient07/orgs","repos_url":"https://api.github.com/users/Sentient07/repos","events_url":"https://api.github.com/users/Sentient07/events{/privacy}","received_events_url":"https://api.github.com/users/Sentient07/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sentient07/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/Sentient07/Theano","forks_url":"https://api.github.com/repos/Sentient07/Theano/forks","keys_url":"https://api.github.com/repos/Sentient07/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sentient07/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sentient07/Theano/teams","hooks_url":"https://api.github.com/repos/Sentient07/Theano/hooks","issue_events_url":"https://api.github.com/repos/Sentient07/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Sentient07/Theano/events","assignees_url":"https://api.github.com/repos/Sentient07/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Sentient07/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Sentient07/Theano/tags","blobs_url":"https://api.github.com/repos/Sentient07/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sentient07/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sentient07/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sentient07/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sentient07/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Sentient07/Theano/languages","stargazers_url":"https://api.github.com/repos/Sentient07/Theano/stargazers","contributors_url":"https://api.github.com/repos/Sentient07/Theano/contributors","subscribers_url":"https://api.github.com/repos/Sentient07/Theano/subscribers","subscription_url":"https://api.github.com/repos/Sentient07/Theano/subscription","commits_url":"https://api.github.com/repos/Sentient07/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sentient07/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sentient07/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sentient07/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sentient07/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Sentient07/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sentient07/Theano/merges","archive_url":"https://api.github.com/repos/Sentient07/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sentient07/Theano/downloads","issues_url":"https://api.github.com/repos/Sentient07/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Sentient07/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Sentient07/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Sentient07/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sentient07/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Sentient07/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Sentient07/Theano/deployments","created_at":"2015-11-23T17:21:47Z","updated_at":"2016-02-10T20:45:26Z","pushed_at":"2016-07-01T20:13:11Z","git_url":"git://github.com/Sentient07/Theano.git","ssh_url":"git@github.com:Sentient07/Theano.git","clone_url":"https://github.com/Sentient07/Theano.git","svn_url":"https://github.com/Sentient07/Theano","homepage":"http://www.deeplearning.net/software/theano","size":54035,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"c0b294ec4fd63ff34d13ab36ac2201dbae3a7897","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-07-02T19:50:42Z","pushed_at":"2016-07-02T08:01:23Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":74967,"stargazers_count":4059,"watchers_count":4059,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1458,"mirror_url":null,"open_issues_count":688,"forks":1458,"open_issues":688,"watchers":4059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4570"},"html":{"href":"https://github.com/Theano/Theano/pull/4570"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/4570"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/4570/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4570/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4570/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/e5bb1110c62872539d64ca0628fdc9d0ae70fdc2"}}}}
{"actor":{"display_login":"lamblin"}}