{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments/88546889","pull_request_review_id":9118589,"id":88546889,"diff_hunk":"@@ -183,15 +183,29 @@ internal sealed class ConnectionViewModel : BindableBase, IConnectionViewModel {\n             IsRemote = !(uri?.IsFile ?? true);\n         }\n \n-       public string GetCompletePath() {\n+        public void PathEditCompleted() {\n+            // After the user is done editing the path, we fix it up automatically\n+            Path = GetCompletePath();\n+\n+            // Conveniently populate the name, if the user directly edited the path\n+            // without specifying a name.\n+            if (string.IsNullOrWhiteSpace(Name)) {","path":"src/R/Components/Impl/ConnectionManager/Implementation/ViewModel/ConnectionViewModel.cs","position":20,"original_position":20,"commit_id":"ff365724b3f6faa505414f1ddc261ae8b95de002","original_commit_id":"ff365724b3f6faa505414f1ddc261ae8b95de002","user":{"login":"huguesv","id":1696845,"avatar_url":"https://avatars.githubusercontent.com/u/1696845?v=3","gravatar_id":"","url":"https://api.github.com/users/huguesv","html_url":"https://github.com/huguesv","followers_url":"https://api.github.com/users/huguesv/followers","following_url":"https://api.github.com/users/huguesv/following{/other_user}","gists_url":"https://api.github.com/users/huguesv/gists{/gist_id}","starred_url":"https://api.github.com/users/huguesv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguesv/subscriptions","organizations_url":"https://api.github.com/users/huguesv/orgs","repos_url":"https://api.github.com/users/huguesv/repos","events_url":"https://api.github.com/users/huguesv/events{/privacy}","received_events_url":"https://api.github.com/users/huguesv/received_events","type":"User","site_admin":false},"body":"Oh wait, I don't know what the previous path was, it's already been updated.","created_at":"2016-11-17T21:12:25Z","updated_at":"2016-11-17T21:12:25Z","html_url":"https://github.com/Microsoft/RTVS/pull/2710#discussion_r88546889","pull_request_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2710","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments/88546889"},"html":{"href":"https://github.com/Microsoft/RTVS/pull/2710#discussion_r88546889"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2710"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2710","id":94249536,"html_url":"https://github.com/Microsoft/RTVS/pull/2710","diff_url":"https://github.com/Microsoft/RTVS/pull/2710.diff","patch_url":"https://github.com/Microsoft/RTVS/pull/2710.patch","issue_url":"https://api.github.com/repos/Microsoft/RTVS/issues/2710","number":2710,"state":"open","locked":false,"title":"Workspace fixes","user":{"login":"huguesv","id":1696845,"avatar_url":"https://avatars.githubusercontent.com/u/1696845?v=3","gravatar_id":"","url":"https://api.github.com/users/huguesv","html_url":"https://github.com/huguesv","followers_url":"https://api.github.com/users/huguesv/followers","following_url":"https://api.github.com/users/huguesv/following{/other_user}","gists_url":"https://api.github.com/users/huguesv/gists{/gist_id}","starred_url":"https://api.github.com/users/huguesv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguesv/subscriptions","organizations_url":"https://api.github.com/users/huguesv/orgs","repos_url":"https://api.github.com/users/huguesv/repos","events_url":"https://api.github.com/users/huguesv/events{/privacy}","received_events_url":"https://api.github.com/users/huguesv/received_events","type":"User","site_admin":false},"body":"Fix #2632 Test connection does not work when supplying just the machine name\r\nFix #2634 Delete connection should show confirmation dialog\r\nFix #2635 Trailing space in the machine name make 'Save' disabled\r\n","created_at":"2016-11-17T21:00:59Z","updated_at":"2016-11-17T21:12:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a02e72059b3bb93252ca9c3ec0bfa2b23cda23e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2710/commits","review_comments_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2710/comments","review_comment_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/issues/2710/comments","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/ff365724b3f6faa505414f1ddc261ae8b95de002","head":{"label":"huguesv:workspace","ref":"workspace","sha":"ff365724b3f6faa505414f1ddc261ae8b95de002","user":{"login":"huguesv","id":1696845,"avatar_url":"https://avatars.githubusercontent.com/u/1696845?v=3","gravatar_id":"","url":"https://api.github.com/users/huguesv","html_url":"https://github.com/huguesv","followers_url":"https://api.github.com/users/huguesv/followers","following_url":"https://api.github.com/users/huguesv/following{/other_user}","gists_url":"https://api.github.com/users/huguesv/gists{/gist_id}","starred_url":"https://api.github.com/users/huguesv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguesv/subscriptions","organizations_url":"https://api.github.com/users/huguesv/orgs","repos_url":"https://api.github.com/users/huguesv/repos","events_url":"https://api.github.com/users/huguesv/events{/privacy}","received_events_url":"https://api.github.com/users/huguesv/received_events","type":"User","site_admin":false},"repo":{"id":53520855,"name":"RTVS","full_name":"huguesv/RTVS","owner":{"login":"huguesv","id":1696845,"avatar_url":"https://avatars.githubusercontent.com/u/1696845?v=3","gravatar_id":"","url":"https://api.github.com/users/huguesv","html_url":"https://github.com/huguesv","followers_url":"https://api.github.com/users/huguesv/followers","following_url":"https://api.github.com/users/huguesv/following{/other_user}","gists_url":"https://api.github.com/users/huguesv/gists{/gist_id}","starred_url":"https://api.github.com/users/huguesv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguesv/subscriptions","organizations_url":"https://api.github.com/users/huguesv/orgs","repos_url":"https://api.github.com/users/huguesv/repos","events_url":"https://api.github.com/users/huguesv/events{/privacy}","received_events_url":"https://api.github.com/users/huguesv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huguesv/RTVS","description":"R Tools for Visual Studio.","fork":true,"url":"https://api.github.com/repos/huguesv/RTVS","forks_url":"https://api.github.com/repos/huguesv/RTVS/forks","keys_url":"https://api.github.com/repos/huguesv/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huguesv/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huguesv/RTVS/teams","hooks_url":"https://api.github.com/repos/huguesv/RTVS/hooks","issue_events_url":"https://api.github.com/repos/huguesv/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/huguesv/RTVS/events","assignees_url":"https://api.github.com/repos/huguesv/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/huguesv/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/huguesv/RTVS/tags","blobs_url":"https://api.github.com/repos/huguesv/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huguesv/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huguesv/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/huguesv/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huguesv/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/huguesv/RTVS/languages","stargazers_url":"https://api.github.com/repos/huguesv/RTVS/stargazers","contributors_url":"https://api.github.com/repos/huguesv/RTVS/contributors","subscribers_url":"https://api.github.com/repos/huguesv/RTVS/subscribers","subscription_url":"https://api.github.com/repos/huguesv/RTVS/subscription","commits_url":"https://api.github.com/repos/huguesv/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/huguesv/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/huguesv/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/huguesv/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/huguesv/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/huguesv/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huguesv/RTVS/merges","archive_url":"https://api.github.com/repos/huguesv/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huguesv/RTVS/downloads","issues_url":"https://api.github.com/repos/huguesv/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/huguesv/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/huguesv/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/huguesv/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huguesv/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/huguesv/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/huguesv/RTVS/deployments","created_at":"2016-03-09T18:22:52Z","updated_at":"2016-10-24T16:53:32Z","pushed_at":"2016-11-17T20:52:49Z","git_url":"git://github.com/huguesv/RTVS.git","ssh_url":"git@github.com:huguesv/RTVS.git","clone_url":"https://github.com/huguesv/RTVS.git","svn_url":"https://github.com/huguesv/RTVS","homepage":null,"size":53683,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"650acdbf1173a4872f4397c789d2e2cb8bd27457","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38640473,"name":"RTVS","full_name":"Microsoft/RTVS","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/RTVS","description":"R Tools for Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/RTVS","forks_url":"https://api.github.com/repos/Microsoft/RTVS/forks","keys_url":"https://api.github.com/repos/Microsoft/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/RTVS/teams","hooks_url":"https://api.github.com/repos/Microsoft/RTVS/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/RTVS/events","assignees_url":"https://api.github.com/repos/Microsoft/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/RTVS/tags","blobs_url":"https://api.github.com/repos/Microsoft/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/RTVS/languages","stargazers_url":"https://api.github.com/repos/Microsoft/RTVS/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/RTVS/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/RTVS/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/RTVS/subscription","commits_url":"https://api.github.com/repos/Microsoft/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/RTVS/merges","archive_url":"https://api.github.com/repos/Microsoft/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/RTVS/downloads","issues_url":"https://api.github.com/repos/Microsoft/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/RTVS/deployments","created_at":"2015-07-06T19:14:09Z","updated_at":"2016-11-17T12:52:40Z","pushed_at":"2016-11-17T21:03:54Z","git_url":"git://github.com/Microsoft/RTVS.git","ssh_url":"git@github.com:Microsoft/RTVS.git","clone_url":"https://github.com/Microsoft/RTVS.git","svn_url":"https://github.com/Microsoft/RTVS","homepage":null,"size":54431,"stargazers_count":217,"watchers_count":217,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":344,"forks":63,"open_issues":344,"watchers":217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2710"},"html":{"href":"https://github.com/Microsoft/RTVS/pull/2710"},"issue":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/2710"},"comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/2710/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2710/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2710/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/RTVS/statuses/ff365724b3f6faa505414f1ddc261ae8b95de002"}}}}
{"actor":{"display_login":"huguesv"}}