{"action":"created","comment":{"url":"https://api.github.com/repos/zalando-stups/taupage/pulls/comments/74422368","id":74422368,"diff_hunk":"@@ -125,6 +125,9 @@ def format():\n         def mount():\n             mount_partition(partition, mountpoint, options, filesystem, os.path.isdir(mountpoint), already_mounted)\n \n+        def resize():\n+            subprocess.check_call(['resize2fs', partition])","path":"runtime/opt/taupage/init.d/10-prepare-disks.py","position":5,"original_position":5,"commit_id":"2541c9b8ee2d69cf916505843bf67f79bbaa0ea0","original_commit_id":"2541c9b8ee2d69cf916505843bf67f79bbaa0ea0","user":{"login":"feikesteenbergen","id":8860819,"avatar_url":"https://avatars.githubusercontent.com/u/8860819?v=3","gravatar_id":"","url":"https://api.github.com/users/feikesteenbergen","html_url":"https://github.com/feikesteenbergen","followers_url":"https://api.github.com/users/feikesteenbergen/followers","following_url":"https://api.github.com/users/feikesteenbergen/following{/other_user}","gists_url":"https://api.github.com/users/feikesteenbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/feikesteenbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feikesteenbergen/subscriptions","organizations_url":"https://api.github.com/users/feikesteenbergen/orgs","repos_url":"https://api.github.com/users/feikesteenbergen/repos","events_url":"https://api.github.com/users/feikesteenbergen/events{/privacy}","received_events_url":"https://api.github.com/users/feikesteenbergen/received_events","type":"User","site_admin":false},"body":"Yes, we need that","created_at":"2016-08-11T13:35:06Z","updated_at":"2016-08-11T13:35:06Z","html_url":"https://github.com/zalando-stups/taupage/pull/264#discussion_r74422368","pull_request_url":"https://api.github.com/repos/zalando-stups/taupage/pulls/264","_links":{"self":{"href":"https://api.github.com/repos/zalando-stups/taupage/pulls/comments/74422368"},"html":{"href":"https://github.com/zalando-stups/taupage/pull/264#discussion_r74422368"},"pull_request":{"href":"https://api.github.com/repos/zalando-stups/taupage/pulls/264"}}},"pull_request":{"url":"https://api.github.com/repos/zalando-stups/taupage/pulls/264","id":80920764,"html_url":"https://github.com/zalando-stups/taupage/pull/264","diff_url":"https://github.com/zalando-stups/taupage/pull/264.diff","patch_url":"https://github.com/zalando-stups/taupage/pull/264.patch","issue_url":"https://api.github.com/repos/zalando-stups/taupage/issues/264","number":264,"state":"open","locked":false,"title":"Resize mounts by default","user":{"login":"feikesteenbergen","id":8860819,"avatar_url":"https://avatars.githubusercontent.com/u/8860819?v=3","gravatar_id":"","url":"https://api.github.com/users/feikesteenbergen","html_url":"https://github.com/feikesteenbergen","followers_url":"https://api.github.com/users/feikesteenbergen/followers","following_url":"https://api.github.com/users/feikesteenbergen/following{/other_user}","gists_url":"https://api.github.com/users/feikesteenbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/feikesteenbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feikesteenbergen/subscriptions","organizations_url":"https://api.github.com/users/feikesteenbergen/orgs","repos_url":"https://api.github.com/users/feikesteenbergen/repos","events_url":"https://api.github.com/users/feikesteenbergen/events{/privacy}","received_events_url":"https://api.github.com/users/feikesteenbergen/received_events","type":"User","site_admin":false},"body":"Volumes that should not be erased_on_boot may have been created\r\nfrom different snapshots. One of the reasons to do this is to be able\r\nto scale data stores (PostgreSQL, Cassandra) once they fill up.\r\nWhat happens in this case is that the volume is resized, however the\r\nfilesystem still has the previous size.\r\nResizing the filesystem to the volume seems like a win, we can do\r\nit unconditionally as resize2fs will figure out by itself whether\r\na resize is needed.\r\n\r\nAddresses issue #252","created_at":"2016-08-11T08:36:18Z","updated_at":"2016-08-11T13:35:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5e1024895998f863ec34055d561b35dac402879","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando-stups/taupage/pulls/264/commits","review_comments_url":"https://api.github.com/repos/zalando-stups/taupage/pulls/264/comments","review_comment_url":"https://api.github.com/repos/zalando-stups/taupage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-stups/taupage/issues/264/comments","statuses_url":"https://api.github.com/repos/zalando-stups/taupage/statuses/2541c9b8ee2d69cf916505843bf67f79bbaa0ea0","head":{"label":"feikesteenbergen:issue#252","ref":"issue#252","sha":"2541c9b8ee2d69cf916505843bf67f79bbaa0ea0","user":{"login":"feikesteenbergen","id":8860819,"avatar_url":"https://avatars.githubusercontent.com/u/8860819?v=3","gravatar_id":"","url":"https://api.github.com/users/feikesteenbergen","html_url":"https://github.com/feikesteenbergen","followers_url":"https://api.github.com/users/feikesteenbergen/followers","following_url":"https://api.github.com/users/feikesteenbergen/following{/other_user}","gists_url":"https://api.github.com/users/feikesteenbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/feikesteenbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feikesteenbergen/subscriptions","organizations_url":"https://api.github.com/users/feikesteenbergen/orgs","repos_url":"https://api.github.com/users/feikesteenbergen/repos","events_url":"https://api.github.com/users/feikesteenbergen/events{/privacy}","received_events_url":"https://api.github.com/users/feikesteenbergen/received_events","type":"User","site_admin":false},"repo":{"id":46727790,"name":"taupage","full_name":"feikesteenbergen/taupage","owner":{"login":"feikesteenbergen","id":8860819,"avatar_url":"https://avatars.githubusercontent.com/u/8860819?v=3","gravatar_id":"","url":"https://api.github.com/users/feikesteenbergen","html_url":"https://github.com/feikesteenbergen","followers_url":"https://api.github.com/users/feikesteenbergen/followers","following_url":"https://api.github.com/users/feikesteenbergen/following{/other_user}","gists_url":"https://api.github.com/users/feikesteenbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/feikesteenbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feikesteenbergen/subscriptions","organizations_url":"https://api.github.com/users/feikesteenbergen/orgs","repos_url":"https://api.github.com/users/feikesteenbergen/repos","events_url":"https://api.github.com/users/feikesteenbergen/events{/privacy}","received_events_url":"https://api.github.com/users/feikesteenbergen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feikesteenbergen/taupage","description":"Amazon Machine Image (AMI) with Docker runtime https://docs.stups.io/en/latest/components/taupage.html","fork":true,"url":"https://api.github.com/repos/feikesteenbergen/taupage","forks_url":"https://api.github.com/repos/feikesteenbergen/taupage/forks","keys_url":"https://api.github.com/repos/feikesteenbergen/taupage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feikesteenbergen/taupage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feikesteenbergen/taupage/teams","hooks_url":"https://api.github.com/repos/feikesteenbergen/taupage/hooks","issue_events_url":"https://api.github.com/repos/feikesteenbergen/taupage/issues/events{/number}","events_url":"https://api.github.com/repos/feikesteenbergen/taupage/events","assignees_url":"https://api.github.com/repos/feikesteenbergen/taupage/assignees{/user}","branches_url":"https://api.github.com/repos/feikesteenbergen/taupage/branches{/branch}","tags_url":"https://api.github.com/repos/feikesteenbergen/taupage/tags","blobs_url":"https://api.github.com/repos/feikesteenbergen/taupage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feikesteenbergen/taupage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feikesteenbergen/taupage/git/refs{/sha}","trees_url":"https://api.github.com/repos/feikesteenbergen/taupage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feikesteenbergen/taupage/statuses/{sha}","languages_url":"https://api.github.com/repos/feikesteenbergen/taupage/languages","stargazers_url":"https://api.github.com/repos/feikesteenbergen/taupage/stargazers","contributors_url":"https://api.github.com/repos/feikesteenbergen/taupage/contributors","subscribers_url":"https://api.github.com/repos/feikesteenbergen/taupage/subscribers","subscription_url":"https://api.github.com/repos/feikesteenbergen/taupage/subscription","commits_url":"https://api.github.com/repos/feikesteenbergen/taupage/commits{/sha}","git_commits_url":"https://api.github.com/repos/feikesteenbergen/taupage/git/commits{/sha}","comments_url":"https://api.github.com/repos/feikesteenbergen/taupage/comments{/number}","issue_comment_url":"https://api.github.com/repos/feikesteenbergen/taupage/issues/comments{/number}","contents_url":"https://api.github.com/repos/feikesteenbergen/taupage/contents/{+path}","compare_url":"https://api.github.com/repos/feikesteenbergen/taupage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feikesteenbergen/taupage/merges","archive_url":"https://api.github.com/repos/feikesteenbergen/taupage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feikesteenbergen/taupage/downloads","issues_url":"https://api.github.com/repos/feikesteenbergen/taupage/issues{/number}","pulls_url":"https://api.github.com/repos/feikesteenbergen/taupage/pulls{/number}","milestones_url":"https://api.github.com/repos/feikesteenbergen/taupage/milestones{/number}","notifications_url":"https://api.github.com/repos/feikesteenbergen/taupage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feikesteenbergen/taupage/labels{/name}","releases_url":"https://api.github.com/repos/feikesteenbergen/taupage/releases{/id}","deployments_url":"https://api.github.com/repos/feikesteenbergen/taupage/deployments","created_at":"2015-11-23T15:04:04Z","updated_at":"2015-11-23T15:04:06Z","pushed_at":"2016-08-11T08:35:55Z","git_url":"git://github.com/feikesteenbergen/taupage.git","ssh_url":"git@github.com:feikesteenbergen/taupage.git","clone_url":"https://github.com/feikesteenbergen/taupage.git","svn_url":"https://github.com/feikesteenbergen/taupage","homepage":"","size":55291,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zalando-stups:master","ref":"master","sha":"06098ebb370c6b49b10f6ed652d1a7093c2a7b97","user":{"login":"zalando-stups","id":11431876,"avatar_url":"https://avatars.githubusercontent.com/u/11431876?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-stups","html_url":"https://github.com/zalando-stups","followers_url":"https://api.github.com/users/zalando-stups/followers","following_url":"https://api.github.com/users/zalando-stups/following{/other_user}","gists_url":"https://api.github.com/users/zalando-stups/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-stups/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-stups/subscriptions","organizations_url":"https://api.github.com/users/zalando-stups/orgs","repos_url":"https://api.github.com/users/zalando-stups/repos","events_url":"https://api.github.com/users/zalando-stups/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-stups/received_events","type":"Organization","site_admin":false},"repo":{"id":32066393,"name":"taupage","full_name":"zalando-stups/taupage","owner":{"login":"zalando-stups","id":11431876,"avatar_url":"https://avatars.githubusercontent.com/u/11431876?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-stups","html_url":"https://github.com/zalando-stups","followers_url":"https://api.github.com/users/zalando-stups/followers","following_url":"https://api.github.com/users/zalando-stups/following{/other_user}","gists_url":"https://api.github.com/users/zalando-stups/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-stups/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-stups/subscriptions","organizations_url":"https://api.github.com/users/zalando-stups/orgs","repos_url":"https://api.github.com/users/zalando-stups/repos","events_url":"https://api.github.com/users/zalando-stups/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-stups/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-stups/taupage","description":"The base Amazon Machine Image (AMI) allowing dockerized applications to run with STUPS","fork":false,"url":"https://api.github.com/repos/zalando-stups/taupage","forks_url":"https://api.github.com/repos/zalando-stups/taupage/forks","keys_url":"https://api.github.com/repos/zalando-stups/taupage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-stups/taupage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-stups/taupage/teams","hooks_url":"https://api.github.com/repos/zalando-stups/taupage/hooks","issue_events_url":"https://api.github.com/repos/zalando-stups/taupage/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-stups/taupage/events","assignees_url":"https://api.github.com/repos/zalando-stups/taupage/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-stups/taupage/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-stups/taupage/tags","blobs_url":"https://api.github.com/repos/zalando-stups/taupage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-stups/taupage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-stups/taupage/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-stups/taupage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-stups/taupage/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-stups/taupage/languages","stargazers_url":"https://api.github.com/repos/zalando-stups/taupage/stargazers","contributors_url":"https://api.github.com/repos/zalando-stups/taupage/contributors","subscribers_url":"https://api.github.com/repos/zalando-stups/taupage/subscribers","subscription_url":"https://api.github.com/repos/zalando-stups/taupage/subscription","commits_url":"https://api.github.com/repos/zalando-stups/taupage/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-stups/taupage/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-stups/taupage/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-stups/taupage/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-stups/taupage/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-stups/taupage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-stups/taupage/merges","archive_url":"https://api.github.com/repos/zalando-stups/taupage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-stups/taupage/downloads","issues_url":"https://api.github.com/repos/zalando-stups/taupage/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-stups/taupage/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-stups/taupage/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-stups/taupage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-stups/taupage/labels{/name}","releases_url":"https://api.github.com/repos/zalando-stups/taupage/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-stups/taupage/deployments","created_at":"2015-03-12T08:43:40Z","updated_at":"2016-07-28T09:24:23Z","pushed_at":"2016-08-11T10:01:27Z","git_url":"git://github.com/zalando-stups/taupage.git","ssh_url":"git@github.com:zalando-stups/taupage.git","clone_url":"https://github.com/zalando-stups/taupage.git","svn_url":"https://github.com/zalando-stups/taupage","homepage":"https://docs.stups.io/en/latest/components/taupage.html","size":55362,"stargazers_count":22,"watchers_count":22,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":36,"forks":28,"open_issues":36,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-stups/taupage/pulls/264"},"html":{"href":"https://github.com/zalando-stups/taupage/pull/264"},"issue":{"href":"https://api.github.com/repos/zalando-stups/taupage/issues/264"},"comments":{"href":"https://api.github.com/repos/zalando-stups/taupage/issues/264/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-stups/taupage/pulls/264/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-stups/taupage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-stups/taupage/pulls/264/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-stups/taupage/statuses/2541c9b8ee2d69cf916505843bf67f79bbaa0ea0"}}}}
{"actor":{"display_login":"feikesteenbergen"}}