{"action":"opened","issue":{"url":"https://api.github.com/repos/lynn0zhang/WebTesting/issues/1","repository_url":"https://api.github.com/repos/lynn0zhang/WebTesting","labels_url":"https://api.github.com/repos/lynn0zhang/WebTesting/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/lynn0zhang/WebTesting/issues/1/comments","events_url":"https://api.github.com/repos/lynn0zhang/WebTesting/issues/1/events","html_url":"https://github.com/lynn0zhang/WebTesting/issues/1","id":186455265,"number":1,"title":"Grading notes","user":{"login":"asphaltpanthers","id":17188102,"avatar_url":"https://avatars.githubusercontent.com/u/17188102?v=3","gravatar_id":"","url":"https://api.github.com/users/asphaltpanthers","html_url":"https://github.com/asphaltpanthers","followers_url":"https://api.github.com/users/asphaltpanthers/followers","following_url":"https://api.github.com/users/asphaltpanthers/following{/other_user}","gists_url":"https://api.github.com/users/asphaltpanthers/gists{/gist_id}","starred_url":"https://api.github.com/users/asphaltpanthers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asphaltpanthers/subscriptions","organizations_url":"https://api.github.com/users/asphaltpanthers/orgs","repos_url":"https://api.github.com/users/asphaltpanthers/repos","events_url":"https://api.github.com/users/asphaltpanthers/events{/privacy}","received_events_url":"https://api.github.com/users/asphaltpanthers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-01T04:11:58Z","updated_at":"2016-11-01T04:11:58Z","closed_at":null,"body":"Hello @lynn0zhang,\r\n\r\nNice job building the user stories and scenarios. Also, your selenium tests look good to. Here are my notes:\r\n\r\nOne of the tests fails intermittently, Addtocart0. It looks to me like you need a WebDriverWait in between clicking the link text 'iPhone 5' and clicking the 'Buy' button.\r\n\r\nOne of your xpath selectors is very brittle. In Addtocart1 there is an xpath selector that looks like this, '//div[@id='checkout_page_container']/div/table/tbody/tr[2]/td[2]/a'. If the smallest thing about the website changes, this xpath will break. Searching for the text 'iPhone 5' would have been less brittle.\r\n\r\nThere were several places where Thread.sleep() was used. This is always considered bad practice and should be avoided.\r\n\r\nCheck CourseWeb for your grade."}}
{"actor":{"display_login":"asphaltpanthers"}}