{"action":"closed","number":6865,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/6865","id":66178797,"html_url":"https://github.com/elastic/kibana/pull/6865","diff_url":"https://github.com/elastic/kibana/pull/6865.diff","patch_url":"https://github.com/elastic/kibana/pull/6865.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/6865","number":6865,"state":"closed","locked":false,"title":"[internal] Replace var assignments with let in ui tests","user":{"login":"epixa","id":53814,"avatar_url":"https://avatars.githubusercontent.com/u/53814?v=3","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false},"body":"This change was applied to any .js files under `__tests__` directories in\r\nthe ui module.\r\n\r\nThis was an automatic replacement from var to let for any variable\r\ndeclaration that doubles as the initial assignment. Ultimately we want\r\nmost of these to be converted to const, but this commit is so large that\r\nit warrants breaking each step of automation up into its own commit.\r\n\r\nFor example:\r\n\r\n`var foo = 'bar';` becomes `let foo = 'var';`\r\n\r\nThis was accomplished by replacing:\r\nfind: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\\s+)=`\r\nreplace: `let $1$2=`","created_at":"2016-04-12T15:33:18Z","updated_at":"2016-04-13T13:40:34Z","closed_at":"2016-04-13T13:40:34Z","merged_at":"2016-04-13T13:40:34Z","merge_commit_sha":"721eb2d0884acc9e3c3740ca8bc6ed3381d8fd5c","assignee":{"login":"panda01","id":549944,"avatar_url":"https://avatars.githubusercontent.com/u/549944?v=3","gravatar_id":"","url":"https://api.github.com/users/panda01","html_url":"https://github.com/panda01","followers_url":"https://api.github.com/users/panda01/followers","following_url":"https://api.github.com/users/panda01/following{/other_user}","gists_url":"https://api.github.com/users/panda01/gists{/gist_id}","starred_url":"https://api.github.com/users/panda01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panda01/subscriptions","organizations_url":"https://api.github.com/users/panda01/orgs","repos_url":"https://api.github.com/users/panda01/repos","events_url":"https://api.github.com/users/panda01/events{/privacy}","received_events_url":"https://api.github.com/users/panda01/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/6865/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/6865/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/6865/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/863228de379846b54d6a2dbfd56cb90ecaf86bb8","head":{"label":"epixa:uiletconst","ref":"uiletconst","sha":"863228de379846b54d6a2dbfd56cb90ecaf86bb8","user":{"login":"epixa","id":53814,"avatar_url":"https://avatars.githubusercontent.com/u/53814?v=3","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false},"repo":{"id":42147349,"name":"kibana","full_name":"epixa/kibana","owner":{"login":"epixa","id":53814,"avatar_url":"https://avatars.githubusercontent.com/u/53814?v=3","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/epixa/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/epixa/kibana","forks_url":"https://api.github.com/repos/epixa/kibana/forks","keys_url":"https://api.github.com/repos/epixa/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epixa/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epixa/kibana/teams","hooks_url":"https://api.github.com/repos/epixa/kibana/hooks","issue_events_url":"https://api.github.com/repos/epixa/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/epixa/kibana/events","assignees_url":"https://api.github.com/repos/epixa/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/epixa/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/epixa/kibana/tags","blobs_url":"https://api.github.com/repos/epixa/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epixa/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epixa/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/epixa/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epixa/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/epixa/kibana/languages","stargazers_url":"https://api.github.com/repos/epixa/kibana/stargazers","contributors_url":"https://api.github.com/repos/epixa/kibana/contributors","subscribers_url":"https://api.github.com/repos/epixa/kibana/subscribers","subscription_url":"https://api.github.com/repos/epixa/kibana/subscription","commits_url":"https://api.github.com/repos/epixa/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/epixa/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/epixa/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/epixa/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/epixa/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/epixa/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epixa/kibana/merges","archive_url":"https://api.github.com/repos/epixa/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epixa/kibana/downloads","issues_url":"https://api.github.com/repos/epixa/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/epixa/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/epixa/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/epixa/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epixa/kibana/labels{/name}","releases_url":"https://api.github.com/repos/epixa/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/epixa/kibana/deployments","created_at":"2015-09-09T00:54:59Z","updated_at":"2016-02-27T18:24:43Z","pushed_at":"2016-04-12T23:45:27Z","git_url":"git://github.com/epixa/kibana.git","ssh_url":"git@github.com:epixa/kibana.git","clone_url":"https://github.com/epixa/kibana.git","svn_url":"https://github.com/epixa/kibana","homepage":"https://www.elastic.co/products/kibana","size":102169,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"4545b808c374a71bc73641b73851275c6380febc","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2016-04-13T08:02:31Z","pushed_at":"2016-04-13T13:40:34Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":143566,"stargazers_count":5134,"watchers_count":5134,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1939,"mirror_url":null,"open_issues_count":954,"forks":1939,"open_issues":954,"watchers":5134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/6865"},"html":{"href":"https://github.com/elastic/kibana/pull/6865"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/6865"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/6865/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/6865/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/6865/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/863228de379846b54d6a2dbfd56cb90ecaf86bb8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"panda01","id":549944,"avatar_url":"https://avatars.githubusercontent.com/u/549944?v=3","gravatar_id":"","url":"https://api.github.com/users/panda01","html_url":"https://github.com/panda01","followers_url":"https://api.github.com/users/panda01/followers","following_url":"https://api.github.com/users/panda01/following{/other_user}","gists_url":"https://api.github.com/users/panda01/gists{/gist_id}","starred_url":"https://api.github.com/users/panda01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panda01/subscriptions","organizations_url":"https://api.github.com/users/panda01/orgs","repos_url":"https://api.github.com/users/panda01/repos","events_url":"https://api.github.com/users/panda01/events{/privacy}","received_events_url":"https://api.github.com/users/panda01/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":1566,"deletions":1566,"changed_files":204}}