{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/heapster/issues/1313","repository_url":"https://api.github.com/repos/kubernetes/heapster","labels_url":"https://api.github.com/repos/kubernetes/heapster/issues/1313/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/heapster/issues/1313/comments","events_url":"https://api.github.com/repos/kubernetes/heapster/issues/1313/events","html_url":"https://github.com/kubernetes/heapster/pull/1313","id":178964328,"number":1313,"title":"Feature/elasticsearch new mapping","user":{"login":"AlmogBaku","id":98982,"avatar_url":"https://avatars.githubusercontent.com/u/98982?v=3","gravatar_id":"","url":"https://api.github.com/users/AlmogBaku","html_url":"https://github.com/AlmogBaku","followers_url":"https://api.github.com/users/AlmogBaku/followers","following_url":"https://api.github.com/users/AlmogBaku/following{/other_user}","gists_url":"https://api.github.com/users/AlmogBaku/gists{/gist_id}","starred_url":"https://api.github.com/users/AlmogBaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlmogBaku/subscriptions","organizations_url":"https://api.github.com/users/AlmogBaku/orgs","repos_url":"https://api.github.com/users/AlmogBaku/repos","events_url":"https://api.github.com/users/AlmogBaku/events{/privacy}","received_events_url":"https://api.github.com/users/AlmogBaku/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/heapster/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"huangyuqi","id":13324377,"avatar_url":"https://avatars.githubusercontent.com/u/13324377?v=3","gravatar_id":"","url":"https://api.github.com/users/huangyuqi","html_url":"https://github.com/huangyuqi","followers_url":"https://api.github.com/users/huangyuqi/followers","following_url":"https://api.github.com/users/huangyuqi/following{/other_user}","gists_url":"https://api.github.com/users/huangyuqi/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyuqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyuqi/subscriptions","organizations_url":"https://api.github.com/users/huangyuqi/orgs","repos_url":"https://api.github.com/users/huangyuqi/repos","events_url":"https://api.github.com/users/huangyuqi/events{/privacy}","received_events_url":"https://api.github.com/users/huangyuqi/received_events","type":"User","site_admin":false},"assignees":[{"login":"huangyuqi","id":13324377,"avatar_url":"https://avatars.githubusercontent.com/u/13324377?v=3","gravatar_id":"","url":"https://api.github.com/users/huangyuqi","html_url":"https://github.com/huangyuqi","followers_url":"https://api.github.com/users/huangyuqi/followers","following_url":"https://api.github.com/users/huangyuqi/following{/other_user}","gists_url":"https://api.github.com/users/huangyuqi/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyuqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyuqi/subscriptions","organizations_url":"https://api.github.com/users/huangyuqi/orgs","repos_url":"https://api.github.com/users/huangyuqi/repos","events_url":"https://api.github.com/users/huangyuqi/events{/privacy}","received_events_url":"https://api.github.com/users/huangyuqi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2016-09-23T20:15:52Z","updated_at":"2016-10-26T07:31:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/heapster/pulls/1313","html_url":"https://github.com/kubernetes/heapster/pull/1313","diff_url":"https://github.com/kubernetes/heapster/pull/1313.diff","patch_url":"https://github.com/kubernetes/heapster/pull/1313.patch"},"body":"fixes #1310, #1278 #1263  #1262:\r\n\r\nThis PR brings a lot of changes, most of them caused by refactoring the schema .\r\nIn order to allow effective usage of the ELK stack, we had to modify the schema so it'll work properly with Kibana(otherwise, it require development of a custom special dashboard! which is insane!)\r\n\r\nThis PR fixes the following issues:\r\n - Types per \"metric family\"(cpu/memory/network/fs/etc): each entry includes more than one parameter that related to its family; allowing us to correlate the data(such as \"usage VS limit\")\r\n- Uses bulk functionalities of ES\r\n- Creates daily indexes (allowing easy removal of old data, as Logstash and others do)\r\n- Create aliases for the indexes\r\n\r\n\r\nThis is a big PR, which bring breaking changes(old schema not valid anymore). However- I have to admit that the old schema is totally unusable, and probably not many users use it if any(but me)\r\n\r\ncc @huangyuqi @DirectXMan12 @piosz @thermi\r\n\r\nYou can see the exported schema here: https://gist.github.com/AlmogBaku/8fe24fd9c61df5a72402a4d25992cb36\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/heapster/1313)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/heapster/issues/comments/256270830","html_url":"https://github.com/kubernetes/heapster/pull/1313#issuecomment-256270830","issue_url":"https://api.github.com/repos/kubernetes/heapster/issues/1313","id":256270830,"user":{"login":"huangyuqi","id":13324377,"avatar_url":"https://avatars.githubusercontent.com/u/13324377?v=3","gravatar_id":"","url":"https://api.github.com/users/huangyuqi","html_url":"https://github.com/huangyuqi","followers_url":"https://api.github.com/users/huangyuqi/followers","following_url":"https://api.github.com/users/huangyuqi/following{/other_user}","gists_url":"https://api.github.com/users/huangyuqi/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyuqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyuqi/subscriptions","organizations_url":"https://api.github.com/users/huangyuqi/orgs","repos_url":"https://api.github.com/users/huangyuqi/repos","events_url":"https://api.github.com/users/huangyuqi/events{/privacy}","received_events_url":"https://api.github.com/users/huangyuqi/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T07:31:12Z","updated_at":"2016-10-26T07:31:12Z","body":"@piosz , the reason of `Your test run exceeded 120 minutes` may be the `scope` of unit test is wrong.\r\n```\r\n        k8s.io/heapster/vendor/cloud.google.com/go/internal\t[no test files]\r\n?   \tk8s.io/heapster/vendor/github.com/Azure/azure-sdk-for-go/arm/compute\t[no test files]\r\n?   \tk8s.io/heapster/vendor/github.com/Azure/azure-sdk-for-go/arm/network\t[no test files]\r\n?   \tk8s.io/heapster/vendor/github.com/Azure/go-autorest/autorest\t[no test files]\r\n?   \tk8s.io/heapster/vendor/github.com/Azure/go-autorest/autorest/azure\t[no test files]\r\n?   \tk8s.io/heapster/vendor/github.com/Azure/go-autorest/autorest/date\t[no test files]\r\n?   \tk8s.io/heapster/vendor/github.com/Azure/go-autorest/autorest/to\t[no test files]\r\n?   \tk8s.io/heapster/vendor/github.com/PuerkitoBio/purell\t[no test files]\r\n?   \tk8s.io/heapster/vendor/github.com/PuerkitoBio/urlesc\t[no test files]\r\n?   \tk8s.io/heapster/vendor/github.com/aws/aws-sdk-go/aws\t[no test files]\r\n\r\n```\r\nthe script of `go unit-test` in file https://github.com/kubernetes/heapster/blob/master/Makefile#L22\r\n\r\n```\r\ntest-unit: clean deps sanitize build\r\n\tGOOS=linux GOARCH=amd64 godep go test --test.short -race ./... $(FLAGS)\r\n```\r\nit runs `go test` in all file path including `k8s.io/heapster/vendor/`. \r\nI want to bring a new issue and take a PR to fix. Any suggestion?\r\n\r\n"}}
{"actor":{"display_login":"huangyuqi"}}