{"action":"created","comment":{"url":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/comments/65670092","id":65670092,"diff_hunk":"@@ -337,6 +337,14 @@ class CarbonSqlParser()\n         }\n     }\n \n+  private def getScaleAndPrecision(dataType: String): (Int, Int) = {","path":"integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala","position":4,"original_position":4,"commit_id":"d8d6eaeb1a503ac78d1698e8b6680a3bed812d93","original_commit_id":"d8d6eaeb1a503ac78d1698e8b6680a3bed812d93","user":{"login":"manishgupta88","id":12965647,"avatar_url":"https://avatars.githubusercontent.com/u/12965647?v=3","gravatar_id":"","url":"https://api.github.com/users/manishgupta88","html_url":"https://github.com/manishgupta88","followers_url":"https://api.github.com/users/manishgupta88/followers","following_url":"https://api.github.com/users/manishgupta88/following{/other_user}","gists_url":"https://api.github.com/users/manishgupta88/gists{/gist_id}","starred_url":"https://api.github.com/users/manishgupta88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishgupta88/subscriptions","organizations_url":"https://api.github.com/users/manishgupta88/orgs","repos_url":"https://api.github.com/users/manishgupta88/repos","events_url":"https://api.github.com/users/manishgupta88/events{/privacy}","received_events_url":"https://api.github.com/users/manishgupta88/received_events","type":"User","site_admin":false},"body":"If user dont provide scale and precision, its already ahndled same as hive and default values are (10,0)","created_at":"2016-06-03T08:06:50Z","updated_at":"2016-06-03T08:06:50Z","html_url":"https://github.com/HuaweiBigData/carbondata/pull/555#discussion_r65670092","pull_request_url":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/555","_links":{"self":{"href":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/comments/65670092"},"html":{"href":"https://github.com/HuaweiBigData/carbondata/pull/555#discussion_r65670092"},"pull_request":{"href":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/555"}}},"pull_request":{"url":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/555","id":72135520,"html_url":"https://github.com/HuaweiBigData/carbondata/pull/555","diff_url":"https://github.com/HuaweiBigData/carbondata/pull/555.diff","patch_url":"https://github.com/HuaweiBigData/carbondata/pull/555.patch","issue_url":"https://api.github.com/repos/HuaweiBigData/carbondata/issues/555","number":555,"state":"open","locked":false,"title":"[Issue-556] Support for bigInt and decimal data type","user":{"login":"manishgupta88","id":12965647,"avatar_url":"https://avatars.githubusercontent.com/u/12965647?v=3","gravatar_id":"","url":"https://api.github.com/users/manishgupta88","html_url":"https://github.com/manishgupta88","followers_url":"https://api.github.com/users/manishgupta88/followers","following_url":"https://api.github.com/users/manishgupta88/following{/other_user}","gists_url":"https://api.github.com/users/manishgupta88/gists{/gist_id}","starred_url":"https://api.github.com/users/manishgupta88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishgupta88/subscriptions","organizations_url":"https://api.github.com/users/manishgupta88/orgs","repos_url":"https://api.github.com/users/manishgupta88/repos","events_url":"https://api.github.com/users/manishgupta88/events{/privacy}","received_events_url":"https://api.github.com/users/manishgupta88/received_events","type":"User","site_admin":false},"body":"Code Modifications done:\r\n1. Modified code to parse decimal and bigInt datatype in create table command (handled by @nareshpr ).\r\n2. Modified data load flow to load data with big decimal and bigInt data type.\r\n3. Added test cases for testing decimal and bigInt datatype functionality.\r\n\r\nUsage example:\r\nCreate table tablename (col1 String, col2 decimal(9,2)) stored by 'org.apache.carbondata.format'\r\nCreate table tablename (col1 String, col2 bigInt) stored by 'org.apache.carbondata.format'\r\n","created_at":"2016-06-01T07:41:22Z","updated_at":"2016-06-03T08:06:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e56c9ed1d2496d603fe8fa873834efc6128daed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/555/commits","review_comments_url":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/555/comments","review_comment_url":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HuaweiBigData/carbondata/issues/555/comments","statuses_url":"https://api.github.com/repos/HuaweiBigData/carbondata/statuses/d8d6eaeb1a503ac78d1698e8b6680a3bed812d93","head":{"label":"manishgupta88:bigdecimal_fix","ref":"bigdecimal_fix","sha":"d8d6eaeb1a503ac78d1698e8b6680a3bed812d93","user":{"login":"manishgupta88","id":12965647,"avatar_url":"https://avatars.githubusercontent.com/u/12965647?v=3","gravatar_id":"","url":"https://api.github.com/users/manishgupta88","html_url":"https://github.com/manishgupta88","followers_url":"https://api.github.com/users/manishgupta88/followers","following_url":"https://api.github.com/users/manishgupta88/following{/other_user}","gists_url":"https://api.github.com/users/manishgupta88/gists{/gist_id}","starred_url":"https://api.github.com/users/manishgupta88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishgupta88/subscriptions","organizations_url":"https://api.github.com/users/manishgupta88/orgs","repos_url":"https://api.github.com/users/manishgupta88/repos","events_url":"https://api.github.com/users/manishgupta88/events{/privacy}","received_events_url":"https://api.github.com/users/manishgupta88/received_events","type":"User","site_admin":false},"repo":{"id":58724848,"name":"carbondata-1","full_name":"manishgupta88/carbondata-1","owner":{"login":"manishgupta88","id":12965647,"avatar_url":"https://avatars.githubusercontent.com/u/12965647?v=3","gravatar_id":"","url":"https://api.github.com/users/manishgupta88","html_url":"https://github.com/manishgupta88","followers_url":"https://api.github.com/users/manishgupta88/followers","following_url":"https://api.github.com/users/manishgupta88/following{/other_user}","gists_url":"https://api.github.com/users/manishgupta88/gists{/gist_id}","starred_url":"https://api.github.com/users/manishgupta88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishgupta88/subscriptions","organizations_url":"https://api.github.com/users/manishgupta88/orgs","repos_url":"https://api.github.com/users/manishgupta88/repos","events_url":"https://api.github.com/users/manishgupta88/events{/privacy}","received_events_url":"https://api.github.com/users/manishgupta88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manishgupta88/carbondata-1","description":"CarbonData is a new hadoop native file format for faster interactive query","fork":true,"url":"https://api.github.com/repos/manishgupta88/carbondata-1","forks_url":"https://api.github.com/repos/manishgupta88/carbondata-1/forks","keys_url":"https://api.github.com/repos/manishgupta88/carbondata-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manishgupta88/carbondata-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manishgupta88/carbondata-1/teams","hooks_url":"https://api.github.com/repos/manishgupta88/carbondata-1/hooks","issue_events_url":"https://api.github.com/repos/manishgupta88/carbondata-1/issues/events{/number}","events_url":"https://api.github.com/repos/manishgupta88/carbondata-1/events","assignees_url":"https://api.github.com/repos/manishgupta88/carbondata-1/assignees{/user}","branches_url":"https://api.github.com/repos/manishgupta88/carbondata-1/branches{/branch}","tags_url":"https://api.github.com/repos/manishgupta88/carbondata-1/tags","blobs_url":"https://api.github.com/repos/manishgupta88/carbondata-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manishgupta88/carbondata-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manishgupta88/carbondata-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/manishgupta88/carbondata-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manishgupta88/carbondata-1/statuses/{sha}","languages_url":"https://api.github.com/repos/manishgupta88/carbondata-1/languages","stargazers_url":"https://api.github.com/repos/manishgupta88/carbondata-1/stargazers","contributors_url":"https://api.github.com/repos/manishgupta88/carbondata-1/contributors","subscribers_url":"https://api.github.com/repos/manishgupta88/carbondata-1/subscribers","subscription_url":"https://api.github.com/repos/manishgupta88/carbondata-1/subscription","commits_url":"https://api.github.com/repos/manishgupta88/carbondata-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/manishgupta88/carbondata-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/manishgupta88/carbondata-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/manishgupta88/carbondata-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/manishgupta88/carbondata-1/contents/{+path}","compare_url":"https://api.github.com/repos/manishgupta88/carbondata-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manishgupta88/carbondata-1/merges","archive_url":"https://api.github.com/repos/manishgupta88/carbondata-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manishgupta88/carbondata-1/downloads","issues_url":"https://api.github.com/repos/manishgupta88/carbondata-1/issues{/number}","pulls_url":"https://api.github.com/repos/manishgupta88/carbondata-1/pulls{/number}","milestones_url":"https://api.github.com/repos/manishgupta88/carbondata-1/milestones{/number}","notifications_url":"https://api.github.com/repos/manishgupta88/carbondata-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manishgupta88/carbondata-1/labels{/name}","releases_url":"https://api.github.com/repos/manishgupta88/carbondata-1/releases{/id}","deployments_url":"https://api.github.com/repos/manishgupta88/carbondata-1/deployments","created_at":"2016-05-13T09:40:59Z","updated_at":"2016-05-13T09:41:03Z","pushed_at":"2016-06-03T02:52:37Z","git_url":"git://github.com/manishgupta88/carbondata-1.git","ssh_url":"git@github.com:manishgupta88/carbondata-1.git","clone_url":"https://github.com/manishgupta88/carbondata-1.git","svn_url":"https://github.com/manishgupta88/carbondata-1","homepage":"","size":33110,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HuaweiBigData:master","ref":"master","sha":"70d4f744d9aeee7718a8c3d0ff1c2e8d74c6a997","user":{"login":"HuaweiBigData","id":13159946,"avatar_url":"https://avatars.githubusercontent.com/u/13159946?v=3","gravatar_id":"","url":"https://api.github.com/users/HuaweiBigData","html_url":"https://github.com/HuaweiBigData","followers_url":"https://api.github.com/users/HuaweiBigData/followers","following_url":"https://api.github.com/users/HuaweiBigData/following{/other_user}","gists_url":"https://api.github.com/users/HuaweiBigData/gists{/gist_id}","starred_url":"https://api.github.com/users/HuaweiBigData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuaweiBigData/subscriptions","organizations_url":"https://api.github.com/users/HuaweiBigData/orgs","repos_url":"https://api.github.com/users/HuaweiBigData/repos","events_url":"https://api.github.com/users/HuaweiBigData/events{/privacy}","received_events_url":"https://api.github.com/users/HuaweiBigData/received_events","type":"Organization","site_admin":false},"repo":{"id":52943921,"name":"carbondata","full_name":"HuaweiBigData/carbondata","owner":{"login":"HuaweiBigData","id":13159946,"avatar_url":"https://avatars.githubusercontent.com/u/13159946?v=3","gravatar_id":"","url":"https://api.github.com/users/HuaweiBigData","html_url":"https://github.com/HuaweiBigData","followers_url":"https://api.github.com/users/HuaweiBigData/followers","following_url":"https://api.github.com/users/HuaweiBigData/following{/other_user}","gists_url":"https://api.github.com/users/HuaweiBigData/gists{/gist_id}","starred_url":"https://api.github.com/users/HuaweiBigData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuaweiBigData/subscriptions","organizations_url":"https://api.github.com/users/HuaweiBigData/orgs","repos_url":"https://api.github.com/users/HuaweiBigData/repos","events_url":"https://api.github.com/users/HuaweiBigData/events{/privacy}","received_events_url":"https://api.github.com/users/HuaweiBigData/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HuaweiBigData/carbondata","description":"CarbonData is a new hadoop native file format for faster interactive query","fork":false,"url":"https://api.github.com/repos/HuaweiBigData/carbondata","forks_url":"https://api.github.com/repos/HuaweiBigData/carbondata/forks","keys_url":"https://api.github.com/repos/HuaweiBigData/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HuaweiBigData/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HuaweiBigData/carbondata/teams","hooks_url":"https://api.github.com/repos/HuaweiBigData/carbondata/hooks","issue_events_url":"https://api.github.com/repos/HuaweiBigData/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/HuaweiBigData/carbondata/events","assignees_url":"https://api.github.com/repos/HuaweiBigData/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/HuaweiBigData/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/HuaweiBigData/carbondata/tags","blobs_url":"https://api.github.com/repos/HuaweiBigData/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HuaweiBigData/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HuaweiBigData/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/HuaweiBigData/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HuaweiBigData/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/HuaweiBigData/carbondata/languages","stargazers_url":"https://api.github.com/repos/HuaweiBigData/carbondata/stargazers","contributors_url":"https://api.github.com/repos/HuaweiBigData/carbondata/contributors","subscribers_url":"https://api.github.com/repos/HuaweiBigData/carbondata/subscribers","subscription_url":"https://api.github.com/repos/HuaweiBigData/carbondata/subscription","commits_url":"https://api.github.com/repos/HuaweiBigData/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/HuaweiBigData/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/HuaweiBigData/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/HuaweiBigData/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/HuaweiBigData/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/HuaweiBigData/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HuaweiBigData/carbondata/merges","archive_url":"https://api.github.com/repos/HuaweiBigData/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HuaweiBigData/carbondata/downloads","issues_url":"https://api.github.com/repos/HuaweiBigData/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/HuaweiBigData/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/HuaweiBigData/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HuaweiBigData/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/HuaweiBigData/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/HuaweiBigData/carbondata/deployments","created_at":"2016-03-02T07:44:41Z","updated_at":"2016-05-31T06:13:03Z","pushed_at":"2016-06-03T07:39:33Z","git_url":"git://github.com/HuaweiBigData/carbondata.git","ssh_url":"git@github.com:HuaweiBigData/carbondata.git","clone_url":"https://github.com/HuaweiBigData/carbondata.git","svn_url":"https://github.com/HuaweiBigData/carbondata","homepage":"","size":62889,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":109,"forks":24,"open_issues":109,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/555"},"html":{"href":"https://github.com/HuaweiBigData/carbondata/pull/555"},"issue":{"href":"https://api.github.com/repos/HuaweiBigData/carbondata/issues/555"},"comments":{"href":"https://api.github.com/repos/HuaweiBigData/carbondata/issues/555/comments"},"review_comments":{"href":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/555/comments"},"review_comment":{"href":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HuaweiBigData/carbondata/pulls/555/commits"},"statuses":{"href":"https://api.github.com/repos/HuaweiBigData/carbondata/statuses/d8d6eaeb1a503ac78d1698e8b6680a3bed812d93"}}}}
{"actor":{"display_login":"manishgupta88"}}