{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/73575541","id":73575541,"diff_hunk":"@@ -0,0 +1,114 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package org.apache.storm.druid.bolt;\n+\n+import com.metamx.tranquility.tranquilizer.Tranquilizer;\n+\n+import java.io.Serializable;\n+\n+public class DruidConfig implements Serializable {\n+\n+    //Tranquilizer configs for DruidBeamBolt\n+    private int maxBatchSize;\n+    private int maxPendingBatches;\n+    private long lingerMillis;\n+    private boolean blockOnFull;\n+    private boolean enableDiscardStream;\n+    private String discardStreamId;\n+\n+    public int getMaxBatchSize() {\n+        return maxBatchSize;\n+    }\n+\n+    public int getMaxPendingBatches() {\n+        return maxPendingBatches;\n+    }\n+\n+    public long getLingerMillis() {\n+        return lingerMillis;\n+    }\n+\n+    public boolean isBlockOnFull() {\n+        return blockOnFull;\n+    }\n+\n+    public boolean isEnableDiscardStream() {\n+        return enableDiscardStream;\n+    }\n+\n+    public String getDiscardStreamId() {\n+        return discardStreamId;\n+    }\n+\n+    private DruidConfig(Builder builder) {\n+        this.maxBatchSize = builder.maxBatchSize;\n+        this.maxPendingBatches = builder.maxPendingBatches;\n+        this.lingerMillis = builder.lingerMillis;\n+        this.blockOnFull = builder.blockOnFull;\n+        this.enableDiscardStream = builder.enableDiscardStream;\n+        this.discardStreamId = builder.discardStreamId;\n+    }\n+\n+    public static DruidConfig.Builder newBuilder() {\n+        return new Builder();\n+    }\n+\n+    public static class Builder {\n+        private int maxBatchSize = Tranquilizer.DefaultMaxBatchSize();\n+        private int maxPendingBatches = Tranquilizer.DefaultMaxPendingBatches();\n+        private long lingerMillis = Tranquilizer.DefaultLingerMillis();\n+        private boolean blockOnFull =  Tranquilizer.DefaultBlockOnFull();\n+        private boolean enableDiscardStream = false;\n+        private String discardStreamId =\"druid-discard-stream\";","path":"external/storm-druid/src/main/java/org/apache/storm/druid/bolt/DruidConfig.java","position":78,"original_position":78,"commit_id":"70b11e52e2626bc202150a94c118481a88c2b014","original_commit_id":"70b11e52e2626bc202150a94c118481a88c2b014","user":{"login":"satishd","id":2577761,"avatar_url":"https://avatars.githubusercontent.com/u/2577761?v=3","gravatar_id":"","url":"https://api.github.com/users/satishd","html_url":"https://github.com/satishd","followers_url":"https://api.github.com/users/satishd/followers","following_url":"https://api.github.com/users/satishd/following{/other_user}","gists_url":"https://api.github.com/users/satishd/gists{/gist_id}","starred_url":"https://api.github.com/users/satishd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satishd/subscriptions","organizations_url":"https://api.github.com/users/satishd/orgs","repos_url":"https://api.github.com/users/satishd/repos","events_url":"https://api.github.com/users/satishd/events{/privacy}","received_events_url":"https://api.github.com/users/satishd/received_events","type":"User","site_admin":false},"body":"@harshachlet me know your opinion on the above comment.","created_at":"2016-08-04T18:20:01Z","updated_at":"2016-08-04T18:20:01Z","html_url":"https://github.com/apache/storm/pull/1583#discussion_r73575541","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/1583","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/73575541"},"html":{"href":"https://github.com/apache/storm/pull/1583#discussion_r73575541"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/1583"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/1583","id":78326234,"html_url":"https://github.com/apache/storm/pull/1583","diff_url":"https://github.com/apache/storm/pull/1583.diff","patch_url":"https://github.com/apache/storm/pull/1583.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/1583","number":1583,"state":"open","locked":false,"title":"STORM-1979: Storm Druid Connector implementation.","user":{"login":"omkreddy","id":8134545,"avatar_url":"https://avatars.githubusercontent.com/u/8134545?v=3","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-21T14:31:23Z","updated_at":"2016-08-04T18:20:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d964fa783164961599131ee1c218f96f7ba6c354","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/1583/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/1583/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/1583/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/70b11e52e2626bc202150a94c118481a88c2b014","head":{"label":"omkreddy:storm-druid","ref":"storm-druid","sha":"70b11e52e2626bc202150a94c118481a88c2b014","user":{"login":"omkreddy","id":8134545,"avatar_url":"https://avatars.githubusercontent.com/u/8134545?v=3","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"repo":{"id":61175659,"name":"storm","full_name":"omkreddy/storm","owner":{"login":"omkreddy","id":8134545,"avatar_url":"https://avatars.githubusercontent.com/u/8134545?v=3","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omkreddy/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/omkreddy/storm","forks_url":"https://api.github.com/repos/omkreddy/storm/forks","keys_url":"https://api.github.com/repos/omkreddy/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omkreddy/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omkreddy/storm/teams","hooks_url":"https://api.github.com/repos/omkreddy/storm/hooks","issue_events_url":"https://api.github.com/repos/omkreddy/storm/issues/events{/number}","events_url":"https://api.github.com/repos/omkreddy/storm/events","assignees_url":"https://api.github.com/repos/omkreddy/storm/assignees{/user}","branches_url":"https://api.github.com/repos/omkreddy/storm/branches{/branch}","tags_url":"https://api.github.com/repos/omkreddy/storm/tags","blobs_url":"https://api.github.com/repos/omkreddy/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omkreddy/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omkreddy/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/omkreddy/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omkreddy/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/omkreddy/storm/languages","stargazers_url":"https://api.github.com/repos/omkreddy/storm/stargazers","contributors_url":"https://api.github.com/repos/omkreddy/storm/contributors","subscribers_url":"https://api.github.com/repos/omkreddy/storm/subscribers","subscription_url":"https://api.github.com/repos/omkreddy/storm/subscription","commits_url":"https://api.github.com/repos/omkreddy/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/omkreddy/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/omkreddy/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/omkreddy/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/omkreddy/storm/contents/{+path}","compare_url":"https://api.github.com/repos/omkreddy/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omkreddy/storm/merges","archive_url":"https://api.github.com/repos/omkreddy/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omkreddy/storm/downloads","issues_url":"https://api.github.com/repos/omkreddy/storm/issues{/number}","pulls_url":"https://api.github.com/repos/omkreddy/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/omkreddy/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/omkreddy/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omkreddy/storm/labels{/name}","releases_url":"https://api.github.com/repos/omkreddy/storm/releases{/id}","deployments_url":"https://api.github.com/repos/omkreddy/storm/deployments","created_at":"2016-06-15T03:46:28Z","updated_at":"2016-06-15T03:46:34Z","pushed_at":"2016-08-04T18:09:01Z","git_url":"git://github.com/omkreddy/storm.git","ssh_url":"git@github.com:omkreddy/storm.git","clone_url":"https://github.com/omkreddy/storm.git","svn_url":"https://github.com/omkreddy/storm","homepage":null,"size":158808,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"23ec2f13bfbfd3b725104b58291221b115ada6df","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","deployments_url":"https://api.github.com/repos/apache/storm/deployments","created_at":"2013-11-05T08:00:14Z","updated_at":"2016-08-04T12:28:31Z","pushed_at":"2016-08-04T18:09:02Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":172646,"stargazers_count":3415,"watchers_count":3415,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2534,"mirror_url":"git://git.apache.org/storm.git","open_issues_count":135,"forks":2534,"open_issues":135,"watchers":3415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/1583"},"html":{"href":"https://github.com/apache/storm/pull/1583"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/1583"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/1583/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/1583/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/1583/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/70b11e52e2626bc202150a94c118481a88c2b014"}}}}
{"actor":{"display_login":"satishd"}}