{"action":"created","issue":{"url":"https://api.github.com/repos/Esri/military-tools-geoprocessing-toolbox/issues/137","repository_url":"https://api.github.com/repos/Esri/military-tools-geoprocessing-toolbox","labels_url":"https://api.github.com/repos/Esri/military-tools-geoprocessing-toolbox/issues/137/labels{/name}","comments_url":"https://api.github.com/repos/Esri/military-tools-geoprocessing-toolbox/issues/137/comments","events_url":"https://api.github.com/repos/Esri/military-tools-geoprocessing-toolbox/issues/137/events","html_url":"https://github.com/Esri/military-tools-geoprocessing-toolbox/pull/137","id":189535219,"number":137,"title":"Toolbox fix for Desktop 10.3 and Pro 1.2","user":{"login":"mfunk","id":3093182,"avatar_url":"https://avatars.githubusercontent.com/u/3093182?v=3","gravatar_id":"","url":"https://api.github.com/users/mfunk","html_url":"https://github.com/mfunk","followers_url":"https://api.github.com/users/mfunk/followers","following_url":"https://api.github.com/users/mfunk/following{/other_user}","gists_url":"https://api.github.com/users/mfunk/gists{/gist_id}","starred_url":"https://api.github.com/users/mfunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfunk/subscriptions","organizations_url":"https://api.github.com/users/mfunk/orgs","repos_url":"https://api.github.com/users/mfunk/repos","events_url":"https://api.github.com/users/mfunk/events{/privacy}","received_events_url":"https://api.github.com/users/mfunk/received_events","type":"User","site_admin":false},"labels":[{"id":318789893,"url":"https://api.github.com/repos/Esri/military-tools-geoprocessing-toolbox/labels/V%20-%2010.3.1","name":"V - 10.3.1","color":"5319e7","default":false},{"id":318789983,"url":"https://api.github.com/repos/Esri/military-tools-geoprocessing-toolbox/labels/V%20-%20Pro%201.2","name":"V - Pro 1.2","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"csmoore","id":3090809,"avatar_url":"https://avatars.githubusercontent.com/u/3090809?v=3","gravatar_id":"","url":"https://api.github.com/users/csmoore","html_url":"https://github.com/csmoore","followers_url":"https://api.github.com/users/csmoore/followers","following_url":"https://api.github.com/users/csmoore/following{/other_user}","gists_url":"https://api.github.com/users/csmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/csmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csmoore/subscriptions","organizations_url":"https://api.github.com/users/csmoore/orgs","repos_url":"https://api.github.com/users/csmoore/repos","events_url":"https://api.github.com/users/csmoore/events{/privacy}","received_events_url":"https://api.github.com/users/csmoore/received_events","type":"User","site_admin":false},"assignees":[{"login":"csmoore","id":3090809,"avatar_url":"https://avatars.githubusercontent.com/u/3090809?v=3","gravatar_id":"","url":"https://api.github.com/users/csmoore","html_url":"https://github.com/csmoore","followers_url":"https://api.github.com/users/csmoore/followers","following_url":"https://api.github.com/users/csmoore/following{/other_user}","gists_url":"https://api.github.com/users/csmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/csmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csmoore/subscriptions","organizations_url":"https://api.github.com/users/csmoore/orgs","repos_url":"https://api.github.com/users/csmoore/repos","events_url":"https://api.github.com/users/csmoore/events{/privacy}","received_events_url":"https://api.github.com/users/csmoore/received_events","type":"User","site_admin":false},{"login":"topowright","id":5488313,"avatar_url":"https://avatars.githubusercontent.com/u/5488313?v=3","gravatar_id":"","url":"https://api.github.com/users/topowright","html_url":"https://github.com/topowright","followers_url":"https://api.github.com/users/topowright/followers","following_url":"https://api.github.com/users/topowright/following{/other_user}","gists_url":"https://api.github.com/users/topowright/gists{/gist_id}","starred_url":"https://api.github.com/users/topowright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topowright/subscriptions","organizations_url":"https://api.github.com/users/topowright/orgs","repos_url":"https://api.github.com/users/topowright/repos","events_url":"https://api.github.com/users/topowright/events{/privacy}","received_events_url":"https://api.github.com/users/topowright/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-11-15T23:15:50Z","updated_at":"2016-11-15T23:23:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Esri/military-tools-geoprocessing-toolbox/pulls/137","html_url":"https://github.com/Esri/military-tools-geoprocessing-toolbox/pull/137","diff_url":"https://github.com/Esri/military-tools-geoprocessing-toolbox/pull/137.diff","patch_url":"https://github.com/Esri/military-tools-geoprocessing-toolbox/pull/137.patch"},"body":"Lots of fixes in the commits. Generally needed to make the tools work in:\r\n* ArcGIS 10.3.1 for Desktop\r\n* ArcGIS Pro 1.2\r\n\r\n## Description\r\nToo many to really describe here. Had to export tools from Pro 1.4 and *Save As* 10.3 toolbox to get the process started. Then had to go back and fix each model one at a time to get it running on 10.3.1. Some of the problems were originally reported back in April, and fixes done in 10.4+, however this does not help 10.3. For Table To Polygon we had to move to a script tool to get around Model Builder limitations in downstream field picks. This will probably have to be done again for other tools in Conversion toolset. Also had to update for Feature Sets lost in export from Pro (where feature sets aren't functional). This affected Visibility tools. Also some fixes for symbology for tools. Basically at this point the test cases run with exception of anything with Feature Compare. \r\n\r\n## Related Issue\r\nSHOULD fix:\r\n- #135\r\n- #134 \r\n- #130 \r\n- #119 \r\n- #117 \r\n- #110 \r\n- #96 \r\n- #104\r\n\r\nPartial fix for:\r\n- #133 \r\n\r\n\r\n## Motivation and Context\r\nSolves multiple bugs and preps for release.\r\n\r\n## How Has This Been Tested?\r\ntest framework (utils/tests) is successful with exception of Feature Compare in several tests (where extent and precision differ). Feature Compare is a little too stringent in testing at this time.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n"},"comment":{"url":"https://api.github.com/repos/Esri/military-tools-geoprocessing-toolbox/issues/comments/260802974","html_url":"https://github.com/Esri/military-tools-geoprocessing-toolbox/pull/137#issuecomment-260802974","issue_url":"https://api.github.com/repos/Esri/military-tools-geoprocessing-toolbox/issues/137","id":260802974,"user":{"login":"mfunk","id":3093182,"avatar_url":"https://avatars.githubusercontent.com/u/3093182?v=3","gravatar_id":"","url":"https://api.github.com/users/mfunk","html_url":"https://github.com/mfunk","followers_url":"https://api.github.com/users/mfunk/followers","following_url":"https://api.github.com/users/mfunk/following{/other_user}","gists_url":"https://api.github.com/users/mfunk/gists{/gist_id}","starred_url":"https://api.github.com/users/mfunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfunk/subscriptions","organizations_url":"https://api.github.com/users/mfunk/orgs","repos_url":"https://api.github.com/users/mfunk/repos","events_url":"https://api.github.com/users/mfunk/events{/privacy}","received_events_url":"https://api.github.com/users/mfunk/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T23:23:35Z","updated_at":"2016-11-15T23:23:35Z","body":"To summarize what we are seeing with Feature Compare is as follows:\r\n\r\n- test_table_to_ellipse_desktop: Feature class extents are different.\r\n- test_table_to_lineofbearing_desktop: Tables have different number of fields (Base: 15, Test: 7)\r\n- test_table_to_point_desktop: Tables have different number of fields (Base: 74, Test: 38)\r\n- test_table_to_polygon_desktop: Spatial References have different XY precision (Base: -400.000000000000, -400.000000000000, 999999999.999999880000, Test: -400.000000000000, -400.000000000000, 11258999068426.238000000000).\r\n- test_radial_line_of_sight_desktop: self.assertEqual(featureCount, expectedFeatures, \"Expected %s features, but got %s\" % (str(expectedFeatures), str(featureCount)))\r\nAssertionError: Expected 3501 features, but got 155\r\n\r\n\r\n```\r\nERROR: 2016-11-15 14:44:05,053 FAILURES ===============================================\r\n\r\ntest_table_to_ellipse_desktop (conversion_tests.TableToEllipseTestCase.TableToEllipseTestCase)Traceback (most recent call last):\r\n  File \"D:\\GitHub\\military-tools-geoprocessing-toolbox\\utils\\test\\conversion_tests\\TableToEllipseTestCase.py\", line 83, in test_table_to_ellipse_desktop\r\n    self.assertEqual(identical, \"true\", \"Feature Compare failed: \\n %s\" % arcpy.GetMessages())\r\nAssertionError: Feature Compare failed: \r\n Executing: FeatureCompare D:\\GitHub\\military-tools-geoprocessing-toolbox\\testdata\\Results.gdb\\ExpectedOutputTableToEllipse D:\\GitHub\\military-tools-geoprocessing-toolbox\\testdata\\scratch.gdb\\outputEllipses JoinID ALL # \"0.000000008983 Unknown\" 0.001 0.001 # # NO_CONTINUE_COMPARE #\r\nStart Time: Tue Nov 15 14:37:50 2016\r\nFeatureClass: Feature class extents are different.\r\nFeatureClass: Shape types are the same.\r\nFeatureClass: Feature types are the same.\r\nTable: Table row counts are the same.\r\nSucceeded at Tue Nov 15 14:37:50 2016 (Elapsed Time: 0.07 seconds)\r\n\r\n..............................................................\r\ntest_table_to_lineofbearing_desktop (conversion_tests.TableToLineOfBearingTestCase.TableToLineOfBearingTestCase)Traceback (most recent call last):\r\n  File \"D:\\GitHub\\military-tools-geoprocessing-toolbox\\utils\\test\\conversion_tests\\TableToLineOfBearingTestCase.py\", line 83, in test_table_to_lineofbearing_desktop\r\n    self.assertEqual(identical, \"true\", \"Feature compare failed: \\n %s\" % arcpy.GetMessages())\r\nAssertionError: Feature compare failed: \r\n Executing: FeatureCompare D:\\GitHub\\military-tools-geoprocessing-toolbox\\testdata\\Results.gdb\\ExpectedOutputTableToLOB D:\\GitHub\\military-tools-geoprocessing-toolbox\\testdata\\scratch.gdb\\outputLines OID ALL # \"0.000000008983 Unknown\" 0.001 0.001 # # NO_CONTINUE_COMPARE #\r\nStart Time: Tue Nov 15 14:38:05 2016\r\nTable: Tables have different number of fields (Base: 15, Test: 7).\r\nFeatureClass: Shape types are the same.\r\nFeatureClass: Feature types are the same.\r\nTable: Table row counts are the same.\r\nFeatureClass: Feature class extents are the same.\r\nGeometryDef: GeometryDefs are the same.\r\nField: Field properties are the same.\r\nSucceeded at Tue Nov 15 14:38:05 2016 (Elapsed Time: 0.06 seconds)\r\n\r\n..............................................................\r\ntest_table_to_point_desktop (conversion_tests.TableToPointTestCase.TableToPointTestCase)Traceback (most recent call last):\r\n  File \"D:\\GitHub\\military-tools-geoprocessing-toolbox\\utils\\test\\conversion_tests\\TableToPointTestCase.py\", line 82, in test_table_to_point_desktop\r\n    self.assertEqual(identical, \"true\", \"Feature compare failed: \\n %s\" % arcpy.GetMessages())\r\nAssertionError: Feature compare failed: \r\n Executing: FeatureCompare D:\\GitHub\\military-tools-geoprocessing-toolbox\\testdata\\Results.gdb\\ExpectedOutputTableToPoint D:\\GitHub\\military-tools-geoprocessing-toolbox\\testdata\\scratch.gdb\\outputTableToPoint OID ALL # \"0.000000008983 Unknown\" 0.001 0.001 # # NO_CONTINUE_COMPARE #\r\nStart Time: Tue Nov 15 14:38:18 2016\r\nTable: Tables have different number of fields (Base: 74, Test: 38).\r\nFeatureClass: Shape types are the same.\r\nFeatureClass: Feature types are the same.\r\nTable: Table row counts are the same.\r\nFeatureClass: Feature class extents are the same.\r\nGeometryDef: GeometryDefs are the same.\r\nField: Field properties are the same.\r\nSucceeded at Tue Nov 15 14:38:18 2016 (Elapsed Time: 0.07 seconds)\r\n\r\n..............................................................\r\ntest_table_to_polyline_desktop (conversion_tests.TableToPolylineTestCase.TableToPolylineTestCase)Traceback (most recent call last):\r\n  File \"D:\\GitHub\\military-tools-geoprocessing-toolbox\\utils\\test\\conversion_tests\\TableToPolylineTestCase.py\", line 83, in test_table_to_polyline_desktop\r\n    self.assertEqual(identical, \"true\", \"Feature compare failed: \\n %s\" % arcpy.GetMessages())\r\nAssertionError: Feature compare failed: \r\n Executing: FeatureCompare D:\\GitHub\\military-tools-geoprocessing-toolbox\\testdata\\Results.gdb\\ExpectedOutputTableToPolyline D:\\GitHub\\military-tools-geoprocessing-toolbox\\testdata\\scratch.gdb\\outputPolylines Shape_Length ALL # \"0.000000008983 Unknown\" 0.001 0.001 # # NO_CONTINUE_COMPARE #\r\nStart Time: Tue Nov 15 14:38:45 2016\r\nSpatialReference: Spatial References have different XY precision (Base: -400.000000000000, -400.000000000000, 999999999.999999880000, Test: -400.000000000000, -400.000000000000, 11258999068426.238000000000).\r\nFeatureClass: Shape types are the same.\r\nFeatureClass: Feature types are the same.\r\nTable: Table row counts are the same.\r\nFeatureClass: Feature class extents are the same.\r\nGeometryDef: GeometryDefs are the same.\r\nField: Field properties are the same.\r\nTable: Table row counts are the same.\r\nSucceeded at Tue Nov 15 14:38:45 2016 (Elapsed Time: 0.12 seconds)\r\n\r\n```\r\n"}}
{"actor":{"display_login":"mfunk"}}