{"action":"created","comment":{"url":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/comments/78284702","id":78284702,"diff_hunk":"@@ -193,6 +194,12 @@ def render_files(reldata=None):\n     target = os.path.join(rendered_manifest_dir, 'kubedns-rc.yaml')\n     # Render files/kubernetes/kubedns-rc.yaml for the DNS pod.\n     render('kubedns-rc.yaml', target, context)\n+    # when files change on disk, we need to inform systemd of the changes\n+    try:\n+        check_call(['systemctl', 'daemon-reload'])","path":"cluster/juju/layers/kubernetes-master/reactive/kubernetes_master.py","position":14,"original_position":14,"commit_id":"81aad372ed3c4600f08cb592fbd980a2d579fe0a","original_commit_id":"81aad372ed3c4600f08cb592fbd980a2d579fe0a","user":{"login":"mbruzek","id":6385185,"avatar_url":"https://avatars.githubusercontent.com/u/6385185?v=3","gravatar_id":"","url":"https://api.github.com/users/mbruzek","html_url":"https://github.com/mbruzek","followers_url":"https://api.github.com/users/mbruzek/followers","following_url":"https://api.github.com/users/mbruzek/following{/other_user}","gists_url":"https://api.github.com/users/mbruzek/gists{/gist_id}","starred_url":"https://api.github.com/users/mbruzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbruzek/subscriptions","organizations_url":"https://api.github.com/users/mbruzek/orgs","repos_url":"https://api.github.com/users/mbruzek/repos","events_url":"https://api.github.com/users/mbruzek/events{/privacy}","received_events_url":"https://api.github.com/users/mbruzek/received_events","type":"User","site_admin":false},"body":"Why wouldn't we recycle/reload just the 3 kubernetes services? The way I read the daemon-reload it reloads the systemd manager configuration and reload all unit files.","created_at":"2016-09-10T22:14:44Z","updated_at":"2016-09-10T22:14:44Z","html_url":"https://github.com/juju-solutions/kubernetes/pull/18#discussion_r78284702","pull_request_url":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/comments/78284702"},"html":{"href":"https://github.com/juju-solutions/kubernetes/pull/18#discussion_r78284702"},"pull_request":{"href":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/18","id":84727387,"html_url":"https://github.com/juju-solutions/kubernetes/pull/18","diff_url":"https://github.com/juju-solutions/kubernetes/pull/18.diff","patch_url":"https://github.com/juju-solutions/kubernetes/pull/18.patch","issue_url":"https://api.github.com/repos/juju-solutions/kubernetes/issues/18","number":18,"state":"open","locked":false,"title":"Adds sdn-plugin interface","user":{"login":"chuckbutler","id":246944,"avatar_url":"https://avatars.githubusercontent.com/u/246944?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckbutler","html_url":"https://github.com/chuckbutler","followers_url":"https://api.github.com/users/chuckbutler/followers","following_url":"https://api.github.com/users/chuckbutler/following{/other_user}","gists_url":"https://api.github.com/users/chuckbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckbutler/subscriptions","organizations_url":"https://api.github.com/users/chuckbutler/orgs","repos_url":"https://api.github.com/users/chuckbutler/repos","events_url":"https://api.github.com/users/chuckbutler/events{/privacy}","received_events_url":"https://api.github.com/users/chuckbutler/received_events","type":"User","site_admin":false},"body":"- I added the sdn-plugin interface, and tweaked the post-render to\r\n  ensure we have reloaded our daemons, so systemd will quit complianing\r\n  at us that we have changes since initial launch.","created_at":"2016-09-09T22:12:39Z","updated_at":"2016-09-10T22:14:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67e2e226ef3eec13be4a9ed7bb12737d611650b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/18/commits","review_comments_url":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/18/comments","review_comment_url":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju-solutions/kubernetes/issues/18/comments","statuses_url":"https://api.github.com/repos/juju-solutions/kubernetes/statuses/81aad372ed3c4600f08cb592fbd980a2d579fe0a","head":{"label":"chuckbutler:supporting-files-for-services","ref":"supporting-files-for-services","sha":"81aad372ed3c4600f08cb592fbd980a2d579fe0a","user":{"login":"chuckbutler","id":246944,"avatar_url":"https://avatars.githubusercontent.com/u/246944?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckbutler","html_url":"https://github.com/chuckbutler","followers_url":"https://api.github.com/users/chuckbutler/followers","following_url":"https://api.github.com/users/chuckbutler/following{/other_user}","gists_url":"https://api.github.com/users/chuckbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckbutler/subscriptions","organizations_url":"https://api.github.com/users/chuckbutler/orgs","repos_url":"https://api.github.com/users/chuckbutler/repos","events_url":"https://api.github.com/users/chuckbutler/events{/privacy}","received_events_url":"https://api.github.com/users/chuckbutler/received_events","type":"User","site_admin":false},"repo":{"id":31685696,"name":"kubernetes","full_name":"chuckbutler/kubernetes","owner":{"login":"chuckbutler","id":246944,"avatar_url":"https://avatars.githubusercontent.com/u/246944?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckbutler","html_url":"https://github.com/chuckbutler","followers_url":"https://api.github.com/users/chuckbutler/followers","following_url":"https://api.github.com/users/chuckbutler/following{/other_user}","gists_url":"https://api.github.com/users/chuckbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckbutler/subscriptions","organizations_url":"https://api.github.com/users/chuckbutler/orgs","repos_url":"https://api.github.com/users/chuckbutler/repos","events_url":"https://api.github.com/users/chuckbutler/events{/privacy}","received_events_url":"https://api.github.com/users/chuckbutler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chuckbutler/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/chuckbutler/kubernetes","forks_url":"https://api.github.com/repos/chuckbutler/kubernetes/forks","keys_url":"https://api.github.com/repos/chuckbutler/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chuckbutler/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chuckbutler/kubernetes/teams","hooks_url":"https://api.github.com/repos/chuckbutler/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/chuckbutler/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/chuckbutler/kubernetes/events","assignees_url":"https://api.github.com/repos/chuckbutler/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/chuckbutler/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/chuckbutler/kubernetes/tags","blobs_url":"https://api.github.com/repos/chuckbutler/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chuckbutler/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chuckbutler/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/chuckbutler/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chuckbutler/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/chuckbutler/kubernetes/languages","stargazers_url":"https://api.github.com/repos/chuckbutler/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/chuckbutler/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/chuckbutler/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/chuckbutler/kubernetes/subscription","commits_url":"https://api.github.com/repos/chuckbutler/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/chuckbutler/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/chuckbutler/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/chuckbutler/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/chuckbutler/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/chuckbutler/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chuckbutler/kubernetes/merges","archive_url":"https://api.github.com/repos/chuckbutler/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chuckbutler/kubernetes/downloads","issues_url":"https://api.github.com/repos/chuckbutler/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/chuckbutler/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/chuckbutler/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/chuckbutler/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chuckbutler/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/chuckbutler/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/chuckbutler/kubernetes/deployments","created_at":"2015-03-04T23:32:36Z","updated_at":"2016-03-07T22:20:02Z","pushed_at":"2016-09-09T22:12:09Z","git_url":"git://github.com/chuckbutler/kubernetes.git","ssh_url":"git@github.com:chuckbutler/kubernetes.git","clone_url":"https://github.com/chuckbutler/kubernetes.git","svn_url":"https://github.com/chuckbutler/kubernetes","homepage":"http://kubernetes.io","size":311799,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju-solutions:master-node-split","ref":"master-node-split","sha":"ab61fc32f00cfb36896617a0736ee5144056a762","user":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars.githubusercontent.com/u/8684561?v=3","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":66970811,"name":"kubernetes","full_name":"juju-solutions/kubernetes","owner":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars.githubusercontent.com/u/8684561?v=3","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju-solutions/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/juju-solutions/kubernetes","forks_url":"https://api.github.com/repos/juju-solutions/kubernetes/forks","keys_url":"https://api.github.com/repos/juju-solutions/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju-solutions/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju-solutions/kubernetes/teams","hooks_url":"https://api.github.com/repos/juju-solutions/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/juju-solutions/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/juju-solutions/kubernetes/events","assignees_url":"https://api.github.com/repos/juju-solutions/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/juju-solutions/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/juju-solutions/kubernetes/tags","blobs_url":"https://api.github.com/repos/juju-solutions/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju-solutions/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju-solutions/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju-solutions/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju-solutions/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/juju-solutions/kubernetes/languages","stargazers_url":"https://api.github.com/repos/juju-solutions/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/juju-solutions/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/juju-solutions/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/juju-solutions/kubernetes/subscription","commits_url":"https://api.github.com/repos/juju-solutions/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju-solutions/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju-solutions/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju-solutions/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju-solutions/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/juju-solutions/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju-solutions/kubernetes/merges","archive_url":"https://api.github.com/repos/juju-solutions/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju-solutions/kubernetes/downloads","issues_url":"https://api.github.com/repos/juju-solutions/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/juju-solutions/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/juju-solutions/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/juju-solutions/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju-solutions/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/juju-solutions/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/juju-solutions/kubernetes/deployments","created_at":"2016-08-30T19:24:00Z","updated_at":"2016-08-30T19:24:34Z","pushed_at":"2016-09-09T22:12:39Z","git_url":"git://github.com/juju-solutions/kubernetes.git","ssh_url":"git@github.com:juju-solutions/kubernetes.git","clone_url":"https://github.com/juju-solutions/kubernetes.git","svn_url":"https://github.com/juju-solutions/kubernetes","homepage":"http://kubernetes.io","size":319609,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/18"},"html":{"href":"https://github.com/juju-solutions/kubernetes/pull/18"},"issue":{"href":"https://api.github.com/repos/juju-solutions/kubernetes/issues/18"},"comments":{"href":"https://api.github.com/repos/juju-solutions/kubernetes/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju-solutions/kubernetes/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/juju-solutions/kubernetes/statuses/81aad372ed3c4600f08cb592fbd980a2d579fe0a"}}}}
{"actor":{"display_login":"mbruzek"}}