{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/comments/88105488","pull_request_review_id":8688927,"id":88105488,"diff_hunk":"@@ -22,105 +22,58 @@\n \n package org.jboss.as.ejb3.remote;\n \n-import java.io.IOException;\n-import java.util.Map;\n-import java.util.concurrent.TimeUnit;\n-\n-import org.jboss.as.ejb3.logging.EjbLogger;\n-import org.jboss.as.remoting.AbstractOutboundConnectionService;\n-import org.jboss.ejb.client.EJBClientConfiguration;\n import org.jboss.ejb.client.EJBClientContext;\n-import org.jboss.ejb.client.EJBReceiver;\n-import org.jboss.ejb.client.remoting.IoFutureHelper;\n-import org.jboss.ejb.client.remoting.ReconnectHandler;\n-import org.jboss.ejb.client.remoting.RemotingConnectionEJBReceiver;\n+import org.jboss.ejb.client.EJBTransportProvider;\n import org.jboss.msc.inject.Injector;\n import org.jboss.msc.service.Service;\n-import org.jboss.msc.service.ServiceController;\n import org.jboss.msc.service.ServiceName;\n-import org.jboss.msc.service.ServiceRegistry;\n import org.jboss.msc.service.StartContext;\n import org.jboss.msc.service.StartException;\n import org.jboss.msc.service.StopContext;\n import org.jboss.msc.value.InjectedValue;\n-import org.jboss.remoting3.Connection;\n-import org.xnio.IoFuture;\n-import org.xnio.IoUtils;\n-import org.xnio.OptionMap;\n+import org.jboss.msc.value.Value;\n+import org.wildfly.discovery.impl.StaticDiscoveryProvider;\n+import org.wildfly.discovery.spi.DiscoveryProvider;\n \n /**\n  * A service which sets up the {@link EJBClientContext} with appropriate remoting receivers and local receivers.\n  * The receivers and the client context are configured in a jboss-ejb-client.xml.\n  *\n+ * TODO emulate old configuration using discovery","path":"ejb3/src/main/java/org/jboss/as/ejb3/remote/DescriptorBasedEJBClientContextService.java","position":38,"original_position":38,"commit_id":"633562b80056a77473ad7f6451ccbf15f2c9a114","original_commit_id":"b0db1bff4deb97fb2bcd02b0dfc80995c3075839","user":{"login":"fjuma","id":1486286,"avatar_url":"https://avatars.githubusercontent.com/u/1486286?v=3","gravatar_id":"","url":"https://api.github.com/users/fjuma","html_url":"https://github.com/fjuma","followers_url":"https://api.github.com/users/fjuma/followers","following_url":"https://api.github.com/users/fjuma/following{/other_user}","gists_url":"https://api.github.com/users/fjuma/gists{/gist_id}","starred_url":"https://api.github.com/users/fjuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjuma/subscriptions","organizations_url":"https://api.github.com/users/fjuma/orgs","repos_url":"https://api.github.com/users/fjuma/repos","events_url":"https://api.github.com/users/fjuma/events{/privacy}","received_events_url":"https://api.github.com/users/fjuma/received_events","type":"User","site_admin":false},"body":"'TODO Elytron'","created_at":"2016-11-15T20:26:51Z","updated_at":"2016-11-15T20:26:51Z","html_url":"https://github.com/wildfly-security-incubator/wildfly/pull/44#discussion_r88105488","pull_request_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/comments/88105488"},"html":{"href":"https://github.com/wildfly-security-incubator/wildfly/pull/44#discussion_r88105488"},"pull_request":{"href":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/44","id":93802561,"html_url":"https://github.com/wildfly-security-incubator/wildfly/pull/44","diff_url":"https://github.com/wildfly-security-incubator/wildfly/pull/44.diff","patch_url":"https://github.com/wildfly-security-incubator/wildfly/pull/44.patch","issue_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/issues/44","number":44,"state":"open","locked":false,"title":"Current status of new client invocation integration","user":{"login":"tadamski","id":3254037,"avatar_url":"https://avatars.githubusercontent.com/u/3254037?v=3","gravatar_id":"","url":"https://api.github.com/users/tadamski","html_url":"https://github.com/tadamski","followers_url":"https://api.github.com/users/tadamski/followers","following_url":"https://api.github.com/users/tadamski/following{/other_user}","gists_url":"https://api.github.com/users/tadamski/gists{/gist_id}","starred_url":"https://api.github.com/users/tadamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadamski/subscriptions","organizations_url":"https://api.github.com/users/tadamski/orgs","repos_url":"https://api.github.com/users/tadamski/repos","events_url":"https://api.github.com/users/tadamski/events{/privacy}","received_events_url":"https://api.github.com/users/tadamski/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-15T16:42:27Z","updated_at":"2016-11-15T20:26:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77bf7ae5a057fe56e8541d02479b98607c050506","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/44/commits","review_comments_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/44/comments","review_comment_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/issues/44/comments","statuses_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/statuses/633562b80056a77473ad7f6451ccbf15f2c9a114","head":{"label":"tadamski:invocation_integration","ref":"invocation_integration","sha":"633562b80056a77473ad7f6451ccbf15f2c9a114","user":{"login":"tadamski","id":3254037,"avatar_url":"https://avatars.githubusercontent.com/u/3254037?v=3","gravatar_id":"","url":"https://api.github.com/users/tadamski","html_url":"https://github.com/tadamski","followers_url":"https://api.github.com/users/tadamski/followers","following_url":"https://api.github.com/users/tadamski/following{/other_user}","gists_url":"https://api.github.com/users/tadamski/gists{/gist_id}","starred_url":"https://api.github.com/users/tadamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadamski/subscriptions","organizations_url":"https://api.github.com/users/tadamski/orgs","repos_url":"https://api.github.com/users/tadamski/repos","events_url":"https://api.github.com/users/tadamski/events{/privacy}","received_events_url":"https://api.github.com/users/tadamski/received_events","type":"User","site_admin":false},"repo":{"id":7704420,"name":"wildfly","full_name":"tadamski/wildfly","owner":{"login":"tadamski","id":3254037,"avatar_url":"https://avatars.githubusercontent.com/u/3254037?v=3","gravatar_id":"","url":"https://api.github.com/users/tadamski","html_url":"https://github.com/tadamski","followers_url":"https://api.github.com/users/tadamski/followers","following_url":"https://api.github.com/users/tadamski/following{/other_user}","gists_url":"https://api.github.com/users/tadamski/gists{/gist_id}","starred_url":"https://api.github.com/users/tadamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadamski/subscriptions","organizations_url":"https://api.github.com/users/tadamski/orgs","repos_url":"https://api.github.com/users/tadamski/repos","events_url":"https://api.github.com/users/tadamski/events{/privacy}","received_events_url":"https://api.github.com/users/tadamski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tadamski/wildfly","description":"JBoss Application Server","fork":true,"url":"https://api.github.com/repos/tadamski/wildfly","forks_url":"https://api.github.com/repos/tadamski/wildfly/forks","keys_url":"https://api.github.com/repos/tadamski/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tadamski/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tadamski/wildfly/teams","hooks_url":"https://api.github.com/repos/tadamski/wildfly/hooks","issue_events_url":"https://api.github.com/repos/tadamski/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/tadamski/wildfly/events","assignees_url":"https://api.github.com/repos/tadamski/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/tadamski/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/tadamski/wildfly/tags","blobs_url":"https://api.github.com/repos/tadamski/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tadamski/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tadamski/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/tadamski/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tadamski/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/tadamski/wildfly/languages","stargazers_url":"https://api.github.com/repos/tadamski/wildfly/stargazers","contributors_url":"https://api.github.com/repos/tadamski/wildfly/contributors","subscribers_url":"https://api.github.com/repos/tadamski/wildfly/subscribers","subscription_url":"https://api.github.com/repos/tadamski/wildfly/subscription","commits_url":"https://api.github.com/repos/tadamski/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/tadamski/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/tadamski/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/tadamski/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/tadamski/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/tadamski/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tadamski/wildfly/merges","archive_url":"https://api.github.com/repos/tadamski/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tadamski/wildfly/downloads","issues_url":"https://api.github.com/repos/tadamski/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/tadamski/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/tadamski/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/tadamski/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tadamski/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/tadamski/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/tadamski/wildfly/deployments","created_at":"2013-01-19T14:54:55Z","updated_at":"2015-04-22T12:23:48Z","pushed_at":"2016-11-15T19:46:14Z","git_url":"git://github.com/tadamski/wildfly.git","ssh_url":"git@github.com:tadamski/wildfly.git","clone_url":"https://github.com/tadamski/wildfly.git","svn_url":"https://github.com/tadamski/wildfly","homepage":"","size":174443,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly-security-incubator:invocation_integration","ref":"invocation_integration","sha":"5af7895d1355530ccfcbcc39747531244735e837","user":{"login":"wildfly-security-incubator","id":11571905,"avatar_url":"https://avatars.githubusercontent.com/u/11571905?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-security-incubator","html_url":"https://github.com/wildfly-security-incubator","followers_url":"https://api.github.com/users/wildfly-security-incubator/followers","following_url":"https://api.github.com/users/wildfly-security-incubator/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security-incubator/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security-incubator/orgs","repos_url":"https://api.github.com/users/wildfly-security-incubator/repos","events_url":"https://api.github.com/users/wildfly-security-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":33733220,"name":"wildfly","full_name":"wildfly-security-incubator/wildfly","owner":{"login":"wildfly-security-incubator","id":11571905,"avatar_url":"https://avatars.githubusercontent.com/u/11571905?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-security-incubator","html_url":"https://github.com/wildfly-security-incubator","followers_url":"https://api.github.com/users/wildfly-security-incubator/followers","following_url":"https://api.github.com/users/wildfly-security-incubator/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security-incubator/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security-incubator/orgs","repos_url":"https://api.github.com/users/wildfly-security-incubator/repos","events_url":"https://api.github.com/users/wildfly-security-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly-security-incubator/wildfly","description":"WildFly Application Server","fork":true,"url":"https://api.github.com/repos/wildfly-security-incubator/wildfly","forks_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/forks","keys_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/teams","hooks_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/hooks","issue_events_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/events","assignees_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/tags","blobs_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/languages","stargazers_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/stargazers","contributors_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/contributors","subscribers_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/subscribers","subscription_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/subscription","commits_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/merges","archive_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/downloads","issues_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly/deployments","created_at":"2015-04-10T14:36:51Z","updated_at":"2016-07-21T10:45:19Z","pushed_at":"2016-11-15T19:46:15Z","git_url":"git://github.com/wildfly-security-incubator/wildfly.git","ssh_url":"git@github.com:wildfly-security-incubator/wildfly.git","clone_url":"https://github.com/wildfly-security-incubator/wildfly.git","svn_url":"https://github.com/wildfly-security-incubator/wildfly","homepage":"http://wildfly.org","size":163676,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"elytron_integration"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/44"},"html":{"href":"https://github.com/wildfly-security-incubator/wildfly/pull/44"},"issue":{"href":"https://api.github.com/repos/wildfly-security-incubator/wildfly/issues/44"},"comments":{"href":"https://api.github.com/repos/wildfly-security-incubator/wildfly/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly-security-incubator/wildfly/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly-security-incubator/wildfly/statuses/633562b80056a77473ad7f6451ccbf15f2c9a114"}}}}
{"actor":{"display_login":"fjuma"}}