{"action":"created","comment":{"url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/comments/61338325","id":61338325,"diff_hunk":"@@ -654,17 +653,19 @@ public void processTypeParameters(List<TypeParameter> params) throws ConversionE\n \t\t}\n \t}\n \t\n-\tpublic void processParameters(List<SingleVariableDeclaration> params) throws ConversionException\n+\tpublic void processParameters(List<VariableDeclaration> params) throws ConversionException\n \t{\n \t\tint i = 0;\n-\t\tfor(SingleVariableDeclaration arg : params)\n+\t\tfor(VariableDeclaration arg : params)\n \t\t{\n \t\t\tNode a = containers.peek().child(\"arguments\").add(new Node(null,\"FormalArgument\", i++));\n \t\t\ta.setSymbol(arg.getName().getIdentifier());\n \t\t\tsetModifiersAndAnnotations(a, Modifier.PUBLIC, null);\n \t\t\t\n-\t\t\tNode type = typeExpression(arg.getType(), \"typeExpression\");\n-\t\t\ta.setChild(\"typeExpression\", addExtraDimensions(type,arg.getExtraDimensions()));\n+\t\t\tif (arg instanceof SingleVariableDeclaration) {","path":"JavaImportTool/src/javaImportTool/ASTConverter.java","position":40,"original_position":40,"commit_id":"a4aceadeb4f040e7b70908b0bc9c171f9c6a89ac","original_commit_id":"a4aceadeb4f040e7b70908b0bc9c171f9c6a89ac","user":{"login":"lukedirtwalker","id":3530769,"avatar_url":"https://avatars.githubusercontent.com/u/3530769?v=3","gravatar_id":"","url":"https://api.github.com/users/lukedirtwalker","html_url":"https://github.com/lukedirtwalker","followers_url":"https://api.github.com/users/lukedirtwalker/followers","following_url":"https://api.github.com/users/lukedirtwalker/following{/other_user}","gists_url":"https://api.github.com/users/lukedirtwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/lukedirtwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukedirtwalker/subscriptions","organizations_url":"https://api.github.com/users/lukedirtwalker/orgs","repos_url":"https://api.github.com/users/lukedirtwalker/repos","events_url":"https://api.github.com/users/lukedirtwalker/events{/privacy}","received_events_url":"https://api.github.com/users/lukedirtwalker/received_events","type":"User","site_admin":false},"body":"True but I don't see how we can easily solve this: the parent node will be just any ASTNode, not sure how we would get the type from it.\r\n\r\nOn the other hand I doubt it can ever be the second case in this method, since we process parameters to a method or a lambda here.","created_at":"2016-04-27T21:19:49Z","updated_at":"2016-04-27T21:19:49Z","html_url":"https://github.com/dimitar-asenov/Envision/pull/351#discussion_r61338325","pull_request_url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/351","_links":{"self":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/comments/61338325"},"html":{"href":"https://github.com/dimitar-asenov/Envision/pull/351#discussion_r61338325"},"pull_request":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/351"}}},"pull_request":{"url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/351","id":63848046,"html_url":"https://github.com/dimitar-asenov/Envision/pull/351","diff_url":"https://github.com/dimitar-asenov/Envision/pull/351.diff","patch_url":"https://github.com/dimitar-asenov/Envision/pull/351.patch","issue_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/351","number":351,"state":"open","locked":false,"title":"Initial support for Java 8 import","user":{"login":"lukedirtwalker","id":3530769,"avatar_url":"https://avatars.githubusercontent.com/u/3530769?v=3","gravatar_id":"","url":"https://api.github.com/users/lukedirtwalker","html_url":"https://github.com/lukedirtwalker","followers_url":"https://api.github.com/users/lukedirtwalker/followers","following_url":"https://api.github.com/users/lukedirtwalker/following{/other_user}","gists_url":"https://api.github.com/users/lukedirtwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/lukedirtwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukedirtwalker/subscriptions","organizations_url":"https://api.github.com/users/lukedirtwalker/orgs","repos_url":"https://api.github.com/users/lukedirtwalker/repos","events_url":"https://api.github.com/users/lukedirtwalker/events{/privacy}","received_events_url":"https://api.github.com/users/lukedirtwalker/received_events","type":"User","site_admin":false},"body":"<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23issuecomment-200269590%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23issuecomment-215191862%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61335264%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61335548%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61335802%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61335840%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61336287%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23issuecomment-215229601%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61336795%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61337050%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61337117%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61337161%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23issuecomment-200269590%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Hmm%2C%20I%20will%20wait%20with%20this%20for%20now.%20I%20pushed%20a%20fix%20for%20the%20critical%20things%20only.%22%2C%20%22created_at%22%3A%20%222016-03-23T09%3A36%3A23Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%20updated%20this%20and%20fixed%20the%20array%20issue.%22%2C%20%22created_at%22%3A%20%222016-04-27T18%3A53%3A01Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3530769%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/lukedirtwalker%22%7D%7D%2C%20%7B%22body%22%3A%20%22Hey%2C%20thanks%20a%20lot%20for%20this%20stuff.%20Could%20you%2C%20please%2C%20just%20answer%20the%20questions%20and%20I%27ll%20merge%20it.%22%2C%20%22created_at%22%3A%20%222016-04-27T21%3A07%3A32Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%20a4aceadeb4f040e7b70908b0bc9c171f9c6a89ac%20JavaImportTool/src/javaImportTool/ASTConverter.java%2040%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61335264%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22What%20happens%2C%20if%20it%20is%20not%20a%20single%20variable%20declaration%3F%20Don%27t%20we%20need%20to%20handle%20that%20case%3F%22%2C%20%22created_at%22%3A%20%222016-04-27T21%3A01%3A06Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%2C%20%7B%22body%22%3A%20%22Then%20it%20is%20a%20%5BVariableDeclarationFragment%5D%28http%3A//help.eclipse.org/mars/index.jsp%3Ftopic%3D%252Forg.eclipse.jdt.doc.isv%252Freference%252Fapi%252Forg%252Feclipse%252Fjdt%252Fcore%252Fdom%252FVariableDeclarationFragment.html%29%20which%20doesn%27t%20have%20a%20type.%20Maybe%20we%20should%20then%20set%20the%20type%20to%20an%20EmptyExpression%3F%22%2C%20%22created_at%22%3A%20%222016-04-27T21%3A04%3A22Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3530769%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/lukedirtwalker%22%7D%7D%2C%20%7B%22body%22%3A%20%22Well%2C%20the%20doc%20says%20that%20in%20the%20fragment%20case%2C%20there%20is%20either%20no%20type%20%28lambda%29%20or%20the%20type%20is%20part%20of%20the%20parent%20%28I%20guess%20in%20cases%20like%20%60public%20int%20a%2C%20b%60%20the%20b%20is%20a%20fragment.%5Cr%5Cn%5Cr%5CnThe%20ideal%20thing%20is%20to%20distinguish%20those%20two%20cases%20and%20do%20nothing%20in%20the%20first%20but%20actually%20put%20the%20proper%20type%20in%20the%20second.%22%2C%20%22created_at%22%3A%20%222016-04-27T21%3A11%3A16Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20JavaImportTool/src/javaImportTool/ASTConverter.java%3AL653-672%22%7D%2C%20%22Pull%20a4aceadeb4f040e7b70908b0bc9c171f9c6a89ac%20JavaImportTool/src/javaImportTool/ASTConverter.java%2088%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61336287%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Oh%20cool.%20Have%20you%20had%20the%20chance%20to%20test%20this%3F%22%2C%20%22created_at%22%3A%20%222016-04-27T21%3A06%3A12Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%20tested%20the%20following%20two%20lambdas%3A%5Cr%5Cn%60%60%60java%5Cr%5Cn%5Ct%5CtList%3CString%3E%20barList%20%3D%20new%20ArrayList%3C%3E%28%29%3B%5Cr%5Cn%5Ct%5CtbarList.stream%28%29.forEach%28name%20-%3E%20%5Cr%5Cn%5Ct%5Ct%5CtSystem.out.println%28name%29%5Cr%5Cn%5Ct%5Ct%29%3B%5Cr%5Cn%5Ct%5CtbarList.stream%28%29.map%28String%3A%3Alength%29%3B%5Cr%5Cn%60%60%60%22%2C%20%22created_at%22%3A%20%222016-04-27T21%3A09%3A30Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3530769%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/lukedirtwalker%22%7D%7D%2C%20%7B%22body%22%3A%20%22nice.%20Thanks.%22%2C%20%22created_at%22%3A%20%222016-04-27T21%3A11%3A44Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20JavaImportTool/src/javaImportTool/ASTConverter.java%3AL1157-1192%22%7D%2C%20%22Pull%20a4aceadeb4f040e7b70908b0bc9c171f9c6a89ac%20JavaImportTool/src/javaImportTool/ASTConverter.java%2079%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov/Envision/pull/351%23discussion_r61335548%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22In%20java%208%2C%20is%20the%20inner%20type%20never%20an%20array%20type%20any%20more%3F%22%2C%20%22created_at%22%3A%20%222016-04-27T21%3A02%3A52Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%2C%20%7B%22body%22%3A%20%22Or%20is%20the%20new%20%60getDimensions%28%29%60%20enough%3F%22%2C%20%22created_at%22%3A%20%222016-04-27T21%3A04%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%2C%20%7B%22body%22%3A%20%22As%20far%20as%20I%20understand%20%60getDimensions%28%29%60%20is%20enough.%20This%20is%20not%20related%20to%20Java%208%20but%20to%20an%20API%20change%20in%20the%20eclipse%20APIs%20%28see%20%5BArrayType%5D%28http%3A//help.eclipse.org/mars/index.jsp%3Ftopic%3D%252Forg.eclipse.jdt.doc.isv%252Freference%252Fapi%252Forg%252Feclipse%252Fjdt%252Fcore%252Fdom%252FVariableDeclarationFragment.html%29%29%22%2C%20%22created_at%22%3A%20%222016-04-27T21%3A12%3A02Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3530769%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/lukedirtwalker%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20JavaImportTool/src/javaImportTool/ASTConverter.java%3AL854-862%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/dimitar-asenov/Envision/pull/351#issuecomment-200269590'>General Comment</a></b>\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> Hmm, I will wait with this for now. I pushed a fix for the critical things only.\n- <a href='https://github.com/lukedirtwalker'><img border=0 src='https://avatars.githubusercontent.com/u/3530769?v=3' height=16 width=16'></a> I updated this and fixed the array issue.\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> Hey, thanks a lot for this stuff. Could you, please, just answer the questions and I'll merge it.\n- [ ] <a href='#crh-comment-Pull a4aceadeb4f040e7b70908b0bc9c171f9c6a89ac JavaImportTool/src/javaImportTool/ASTConverter.java 40'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/dimitar-asenov/Envision/pull/351#discussion_r61335264'>File: JavaImportTool/src/javaImportTool/ASTConverter.java:L653-672</a></b>\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> What happens, if it is not a single variable declaration? Don't we need to handle that case?\n- <a href='https://github.com/lukedirtwalker'><img border=0 src='https://avatars.githubusercontent.com/u/3530769?v=3' height=16 width=16'></a> Then it is a [VariableDeclarationFragment](http://help.eclipse.org/mars/index.jsp?topic=%2Forg.eclipse.jdt.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fjdt%2Fcore%2Fdom%2FVariableDeclarationFragment.html) which doesn't have a type. Maybe we should then set the type to an EmptyExpression?\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> Well, the doc says that in the fragment case, there is either no type (lambda) or the type is part of the parent (I guess in cases like `public int a, b` the b is a fragment.\nThe ideal thing is to distinguish those two cases and do nothing in the first but actually put the proper type in the second.\n- [ ] <a href='#crh-comment-Pull a4aceadeb4f040e7b70908b0bc9c171f9c6a89ac JavaImportTool/src/javaImportTool/ASTConverter.java 79'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/dimitar-asenov/Envision/pull/351#discussion_r61335548'>File: JavaImportTool/src/javaImportTool/ASTConverter.java:L854-862</a></b>\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> In java 8, is the inner type never an array type any more?\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> Or is the new `getDimensions()` enough?\n- <a href='https://github.com/lukedirtwalker'><img border=0 src='https://avatars.githubusercontent.com/u/3530769?v=3' height=16 width=16'></a> As far as I understand `getDimensions()` is enough. This is not related to Java 8 but to an API change in the eclipse APIs (see [ArrayType](http://help.eclipse.org/mars/index.jsp?topic=%2Forg.eclipse.jdt.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fjdt%2Fcore%2Fdom%2FVariableDeclarationFragment.html))\n- [ ] <a href='#crh-comment-Pull a4aceadeb4f040e7b70908b0bc9c171f9c6a89ac JavaImportTool/src/javaImportTool/ASTConverter.java 88'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/dimitar-asenov/Envision/pull/351#discussion_r61336287'>File: JavaImportTool/src/javaImportTool/ASTConverter.java:L1157-1192</a></b>\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> Oh cool. Have you had the chance to test this?\n- <a href='https://github.com/lukedirtwalker'><img border=0 src='https://avatars.githubusercontent.com/u/3530769?v=3' height=16 width=16'></a> I tested the following two lambdas:\n```java\nList<String> barList = new ArrayList<>();\nbarList.stream().forEach(name ->\nSystem.out.println(name)\n);\nbarList.stream().map(String::length);\n```\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> nice. Thanks.\n\n\n<a href='https://www.codereviewhub.com/dimitar-asenov/Envision/pull/351?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/dimitar-asenov/Envision/pull/351?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/dimitar-asenov/Envision/pull/351'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2016-03-23T08:47:30Z","updated_at":"2016-04-27T21:19:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb63f22682a0bb4052c052b0d5a7f32c9b7ab1f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/351/commits","review_comments_url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/351/comments","review_comment_url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/351/comments","statuses_url":"https://api.github.com/repos/dimitar-asenov/Envision/statuses/a4aceadeb4f040e7b70908b0bc9c171f9c6a89ac","head":{"label":"lukedirtwalker:java_import","ref":"java_import","sha":"a4aceadeb4f040e7b70908b0bc9c171f9c6a89ac","user":{"login":"lukedirtwalker","id":3530769,"avatar_url":"https://avatars.githubusercontent.com/u/3530769?v=3","gravatar_id":"","url":"https://api.github.com/users/lukedirtwalker","html_url":"https://github.com/lukedirtwalker","followers_url":"https://api.github.com/users/lukedirtwalker/followers","following_url":"https://api.github.com/users/lukedirtwalker/following{/other_user}","gists_url":"https://api.github.com/users/lukedirtwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/lukedirtwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukedirtwalker/subscriptions","organizations_url":"https://api.github.com/users/lukedirtwalker/orgs","repos_url":"https://api.github.com/users/lukedirtwalker/repos","events_url":"https://api.github.com/users/lukedirtwalker/events{/privacy}","received_events_url":"https://api.github.com/users/lukedirtwalker/received_events","type":"User","site_admin":false},"repo":{"id":8235811,"name":"Envision","full_name":"lukedirtwalker/Envision","owner":{"login":"lukedirtwalker","id":3530769,"avatar_url":"https://avatars.githubusercontent.com/u/3530769?v=3","gravatar_id":"","url":"https://api.github.com/users/lukedirtwalker","html_url":"https://github.com/lukedirtwalker","followers_url":"https://api.github.com/users/lukedirtwalker/followers","following_url":"https://api.github.com/users/lukedirtwalker/following{/other_user}","gists_url":"https://api.github.com/users/lukedirtwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/lukedirtwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukedirtwalker/subscriptions","organizations_url":"https://api.github.com/users/lukedirtwalker/orgs","repos_url":"https://api.github.com/users/lukedirtwalker/repos","events_url":"https://api.github.com/users/lukedirtwalker/events{/privacy}","received_events_url":"https://api.github.com/users/lukedirtwalker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukedirtwalker/Envision","description":"A next generation IDE with a visual programming interface","fork":true,"url":"https://api.github.com/repos/lukedirtwalker/Envision","forks_url":"https://api.github.com/repos/lukedirtwalker/Envision/forks","keys_url":"https://api.github.com/repos/lukedirtwalker/Envision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukedirtwalker/Envision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukedirtwalker/Envision/teams","hooks_url":"https://api.github.com/repos/lukedirtwalker/Envision/hooks","issue_events_url":"https://api.github.com/repos/lukedirtwalker/Envision/issues/events{/number}","events_url":"https://api.github.com/repos/lukedirtwalker/Envision/events","assignees_url":"https://api.github.com/repos/lukedirtwalker/Envision/assignees{/user}","branches_url":"https://api.github.com/repos/lukedirtwalker/Envision/branches{/branch}","tags_url":"https://api.github.com/repos/lukedirtwalker/Envision/tags","blobs_url":"https://api.github.com/repos/lukedirtwalker/Envision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukedirtwalker/Envision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukedirtwalker/Envision/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukedirtwalker/Envision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukedirtwalker/Envision/statuses/{sha}","languages_url":"https://api.github.com/repos/lukedirtwalker/Envision/languages","stargazers_url":"https://api.github.com/repos/lukedirtwalker/Envision/stargazers","contributors_url":"https://api.github.com/repos/lukedirtwalker/Envision/contributors","subscribers_url":"https://api.github.com/repos/lukedirtwalker/Envision/subscribers","subscription_url":"https://api.github.com/repos/lukedirtwalker/Envision/subscription","commits_url":"https://api.github.com/repos/lukedirtwalker/Envision/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukedirtwalker/Envision/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukedirtwalker/Envision/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukedirtwalker/Envision/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukedirtwalker/Envision/contents/{+path}","compare_url":"https://api.github.com/repos/lukedirtwalker/Envision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukedirtwalker/Envision/merges","archive_url":"https://api.github.com/repos/lukedirtwalker/Envision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukedirtwalker/Envision/downloads","issues_url":"https://api.github.com/repos/lukedirtwalker/Envision/issues{/number}","pulls_url":"https://api.github.com/repos/lukedirtwalker/Envision/pulls{/number}","milestones_url":"https://api.github.com/repos/lukedirtwalker/Envision/milestones{/number}","notifications_url":"https://api.github.com/repos/lukedirtwalker/Envision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukedirtwalker/Envision/labels{/name}","releases_url":"https://api.github.com/repos/lukedirtwalker/Envision/releases{/id}","deployments_url":"https://api.github.com/repos/lukedirtwalker/Envision/deployments","created_at":"2013-02-16T13:02:50Z","updated_at":"2015-05-08T15:42:06Z","pushed_at":"2016-04-27T20:47:05Z","git_url":"git://github.com/lukedirtwalker/Envision.git","ssh_url":"git@github.com:lukedirtwalker/Envision.git","clone_url":"https://github.com/lukedirtwalker/Envision.git","svn_url":"https://github.com/lukedirtwalker/Envision","homepage":"http://www.pm.inf.ethz.ch/research/envision","size":23684,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"dimitar-asenov:development","ref":"development","sha":"b1ded4f68e1133c1c2a2761db502d02fdc309a69","user":{"login":"dimitar-asenov","id":1152976,"avatar_url":"https://avatars.githubusercontent.com/u/1152976?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitar-asenov","html_url":"https://github.com/dimitar-asenov","followers_url":"https://api.github.com/users/dimitar-asenov/followers","following_url":"https://api.github.com/users/dimitar-asenov/following{/other_user}","gists_url":"https://api.github.com/users/dimitar-asenov/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitar-asenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitar-asenov/subscriptions","organizations_url":"https://api.github.com/users/dimitar-asenov/orgs","repos_url":"https://api.github.com/users/dimitar-asenov/repos","events_url":"https://api.github.com/users/dimitar-asenov/events{/privacy}","received_events_url":"https://api.github.com/users/dimitar-asenov/received_events","type":"User","site_admin":false},"repo":{"id":2650576,"name":"Envision","full_name":"dimitar-asenov/Envision","owner":{"login":"dimitar-asenov","id":1152976,"avatar_url":"https://avatars.githubusercontent.com/u/1152976?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitar-asenov","html_url":"https://github.com/dimitar-asenov","followers_url":"https://api.github.com/users/dimitar-asenov/followers","following_url":"https://api.github.com/users/dimitar-asenov/following{/other_user}","gists_url":"https://api.github.com/users/dimitar-asenov/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitar-asenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitar-asenov/subscriptions","organizations_url":"https://api.github.com/users/dimitar-asenov/orgs","repos_url":"https://api.github.com/users/dimitar-asenov/repos","events_url":"https://api.github.com/users/dimitar-asenov/events{/privacy}","received_events_url":"https://api.github.com/users/dimitar-asenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dimitar-asenov/Envision","description":"A next generation IDE with a visual programming interface","fork":false,"url":"https://api.github.com/repos/dimitar-asenov/Envision","forks_url":"https://api.github.com/repos/dimitar-asenov/Envision/forks","keys_url":"https://api.github.com/repos/dimitar-asenov/Envision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimitar-asenov/Envision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimitar-asenov/Envision/teams","hooks_url":"https://api.github.com/repos/dimitar-asenov/Envision/hooks","issue_events_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/events{/number}","events_url":"https://api.github.com/repos/dimitar-asenov/Envision/events","assignees_url":"https://api.github.com/repos/dimitar-asenov/Envision/assignees{/user}","branches_url":"https://api.github.com/repos/dimitar-asenov/Envision/branches{/branch}","tags_url":"https://api.github.com/repos/dimitar-asenov/Envision/tags","blobs_url":"https://api.github.com/repos/dimitar-asenov/Envision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimitar-asenov/Envision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimitar-asenov/Envision/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimitar-asenov/Envision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimitar-asenov/Envision/statuses/{sha}","languages_url":"https://api.github.com/repos/dimitar-asenov/Envision/languages","stargazers_url":"https://api.github.com/repos/dimitar-asenov/Envision/stargazers","contributors_url":"https://api.github.com/repos/dimitar-asenov/Envision/contributors","subscribers_url":"https://api.github.com/repos/dimitar-asenov/Envision/subscribers","subscription_url":"https://api.github.com/repos/dimitar-asenov/Envision/subscription","commits_url":"https://api.github.com/repos/dimitar-asenov/Envision/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimitar-asenov/Envision/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimitar-asenov/Envision/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimitar-asenov/Envision/contents/{+path}","compare_url":"https://api.github.com/repos/dimitar-asenov/Envision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimitar-asenov/Envision/merges","archive_url":"https://api.github.com/repos/dimitar-asenov/Envision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimitar-asenov/Envision/downloads","issues_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues{/number}","pulls_url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls{/number}","milestones_url":"https://api.github.com/repos/dimitar-asenov/Envision/milestones{/number}","notifications_url":"https://api.github.com/repos/dimitar-asenov/Envision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimitar-asenov/Envision/labels{/name}","releases_url":"https://api.github.com/repos/dimitar-asenov/Envision/releases{/id}","deployments_url":"https://api.github.com/repos/dimitar-asenov/Envision/deployments","created_at":"2011-10-26T12:03:58Z","updated_at":"2016-04-02T07:40:14Z","pushed_at":"2016-04-27T20:47:06Z","git_url":"git://github.com/dimitar-asenov/Envision.git","ssh_url":"git@github.com:dimitar-asenov/Envision.git","clone_url":"https://github.com/dimitar-asenov/Envision.git","svn_url":"https://github.com/dimitar-asenov/Envision","homepage":"http://dimitar-asenov.github.com/Envision/","size":64782,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":32,"forks":16,"open_issues":32,"watchers":26,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/351"},"html":{"href":"https://github.com/dimitar-asenov/Envision/pull/351"},"issue":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/issues/351"},"comments":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/dimitar-asenov/Envision/statuses/a4aceadeb4f040e7b70908b0bc9c171f9c6a89ac"}}}}