{"action":"opened","issue":{"url":"https://api.github.com/repos/atom/settings-view/issues/868","repository_url":"https://api.github.com/repos/atom/settings-view","labels_url":"https://api.github.com/repos/atom/settings-view/issues/868/labels{/name}","comments_url":"https://api.github.com/repos/atom/settings-view/issues/868/comments","events_url":"https://api.github.com/repos/atom/settings-view/issues/868/events","html_url":"https://github.com/atom/settings-view/issues/868","id":182645018,"number":868,"title":"Opening Settings View with all windows minimized does nothing","user":{"login":"jsejcksn","id":868251,"avatar_url":"https://avatars.githubusercontent.com/u/868251?v=3","gravatar_id":"","url":"https://api.github.com/users/jsejcksn","html_url":"https://github.com/jsejcksn","followers_url":"https://api.github.com/users/jsejcksn/followers","following_url":"https://api.github.com/users/jsejcksn/following{/other_user}","gists_url":"https://api.github.com/users/jsejcksn/gists{/gist_id}","starred_url":"https://api.github.com/users/jsejcksn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsejcksn/subscriptions","organizations_url":"https://api.github.com/users/jsejcksn/orgs","repos_url":"https://api.github.com/users/jsejcksn/repos","events_url":"https://api.github.com/users/jsejcksn/events{/privacy}","received_events_url":"https://api.github.com/users/jsejcksn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-12T21:59:56Z","updated_at":"2016-10-12T21:59:56Z","closed_at":null,"body":"_(This is related to atom/tree-view#690)_\r\n\r\nWhen I try to open Settings using <kbd>⌘</kbd>+<kbd>,</kbd> (macOS standard keyboard shortcut), nothing happens if all of my Atom windows are minimized.\r\n\r\n**Reproduction Steps:**\r\n\r\n1. Open one or more Atom windows\r\n2. Minimize all windows\r\n3. Press <kbd>⌘</kbd>+<kbd>,</kbd>\r\n\r\n**Expected behavior:** Settings opens in a new window in a new tab\r\n**Observed behavior:** Nothing happens\r\n\r\n**Atom version:** 1.10.2\r\n**OS and version:** macOS 10.12\r\n\r\n**Installed packages:**\r\n\r\n* [atom-beautify](https://atom.io/packages/atom-beautify)\r\n* [atom-mac-terminal](https://atom.io/packages/atom-mac-terminal)\r\n* [color-picker](https://atom.io/packages/color-picker)\r\n* [compare-files](https://atom.io/packages/compare-files)\r\n* [flatwhite-syntax](https://atom.io/packages/flatwhite-syntax)\r\n* [gist-it](https://atom.io/packages/gist-it)\r\n* [json-converter](https://atom.io/packages/json-converter)\r\n* [lines](https://atom.io/packages/lines)\r\n* [linter](https://atom.io/packages/linter)\r\n* [linter-csslint](https://atom.io/packages/linter-csslint)\r\n* [linter-htmlhint](https://atom.io/packages/linter-htmlhint)\r\n* [linter-js-standard](https://atom.io/packages/linter-js-standard)\r\n* [linter-jshint](https://atom.io/packages/linter-jshint)\r\n* [linter-jsonlint](https://atom.io/packages/linter-jsonlint)\r\n* [linter-less](https://atom.io/packages/linter-less)\r\n* [linter-xmllint](https://atom.io/packages/linter-xmllint)\r\n* [minimap](https://atom.io/packages/minimap)\r\n* [pigments](https://atom.io/packages/pigments)\r\n* [standard-formatter](https://atom.io/packages/standard-formatter)\r\n\r\n**Additional information:**\r\n\r\n* **Problem can be reproduced in safe mode:**  \r\nI don't know what safe mode is in macOS\r\n* **Problem started happening recently, didn't happen in an older version of Atom:**  \r\nNo\r\n* **Problem can be reliably reproduced, doesn't happen randomly:**  \r\nYes\r\n* **Problem happens with all files and projects, not only some files or projects:**  \r\nYes\r\n\r\n**Screenshots and more details**\r\n\r\nI think the issue here is that the <kbd>⌘</kbd>+<kbd>,</kbd> keybinding has two entries by default in a vanilla install on macOS, and I'll go into further behavioral description below:\r\n\r\n![keybindings](https://cloud.githubusercontent.com/assets/868251/19327814/792cacda-9096-11e6-8919-d9557d4655cb.png)\r\n\r\nKeybindings shows that <kbd>⌘</kbd>+<kbd>,</kbd> is assigned to both `application:show-settings` and `settings-view:open`. I have no idea why it was designed this way, but here is where it starts to cause problems.\r\n\r\n<img width=\"571\" alt=\"menu-bar\" src=\"https://cloud.githubusercontent.com/assets/868251/19328009/6961717c-9097-11e6-8954-6a8a85b338d2.png\">\r\n\r\nThis is what the menu bar typically looks like in Atom when a window is open (I'll get to why this is relevant in a moment). When I press <kbd>⌘</kbd>+<kbd>,</kbd>, a new tab opens in the current window and it shows Settings. However, when I minimize all of my windows and press <kbd>⌘</kbd>+<kbd>,</kbd>, the `Packages` menu item flashes and nothing happens:\r\n\r\n<img width=\"571\" alt=\"menu-packages\" src=\"https://cloud.githubusercontent.com/assets/868251/19328100/cdb23aa8-9097-11e6-8707-3d26af07c21c.png\">\r\n\r\nI can use my cursor to go and select `Packages > Settings View > Open` (displayed below) and nothing happens then either:\r\n\r\n<img width=\"819\" alt=\"menu-packages-settings_vew-open\" src=\"https://cloud.githubusercontent.com/assets/868251/19328165/09d6cd28-9098-11e6-90ac-e45caa3782ca.png\">\r\n\r\nHowever, if I use my cursor and navigate to `Atom > Preferences` (displayed below), a new window appears and Settings opens in a new tab.\r\n\r\n<img width=\"565\" alt=\"menu-atom-preferences\" src=\"https://cloud.githubusercontent.com/assets/868251/19328219/43fe72ee-9098-11e6-9c95-3cef76e4af19.png\">\r\n\r\nThis leads me to believe that the keybinding entry `settings-view:open` seems to have priority over `application:show-settings`, so when there's a conflict, it receieves the shortcut keypress.\r\n\r\nHang in there with me, it gets weirder. Now that I have used my mouse to successfully create a new window with Settings in a tab, I close that window so I only have minimized windows again, and I notice this:\r\n\r\n<img width=\"488\" alt=\"menu-bar-no-packages\" src=\"https://cloud.githubusercontent.com/assets/868251/19328494/7b167e74-9099-11e6-9544-8b345a3be415.png\">\r\n\r\nThe `Packages` menu bar item is now missing. I press <kbd>⌘</kbd>+<kbd>,</kbd> and this time, the `Atom` menu item flashes, and I get a new window again with Settings in a new tab!\r\n\r\n<img width=\"488\" alt=\"menu-atom\" src=\"https://cloud.githubusercontent.com/assets/868251/19328709/9e9339ae-909a-11e6-949d-5be72ecb77ee.png\">\r\n\r\n![settings](https://cloud.githubusercontent.com/assets/868251/19328615/15db700e-909a-11e6-868a-e80e8a534449.png)\r\n\r\nAlso, the `Packages` menu item is back now:\r\n\r\n<img width=\"571\" alt=\"menu-bar\" src=\"https://cloud.githubusercontent.com/assets/868251/19328009/6961717c-9097-11e6-8954-6a8a85b338d2.png\">\r\n\r\n## Summary of issues observed\r\n\r\n1. There is a keybinding conflict for <kbd>⌘</kbd>+<kbd>,</kbd>. `settings-view:open` should not have a keyboard shortcut assigned because the macOS system-wide standard is for that shortcut to go to App > Preferences (`application:show-settings` in this case).\r\n\r\n  If this is fixed/implemented, there will be a problem with no. 3 in my original report at atom/tree-view#690.\r\n\r\n2. The `Packages` menu item should be consistently present or absent when all windows are minimized. As of now, it appears that the logic is set to check for active windows only on close, and not on minimize."}}
{"actor":{"display_login":"jsejcksn"}}