{"action":"created","issue":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/811","repository_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin","labels_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/811/labels{/name}","comments_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/811/comments","events_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/811/events","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/811","id":168417579,"number":811,"title":"Almost to the top of the Thali stack","user":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/3%20-%20Working","name":"3 - Working","color":"CCCCCC"},{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/cla-not-required","name":"cla-not-required","color":"009800"},{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"andrew-aladev","id":941925,"avatar_url":"https://avatars.githubusercontent.com/u/941925?v=3","gravatar_id":"","url":"https://api.github.com/users/andrew-aladev","html_url":"https://github.com/andrew-aladev","followers_url":"https://api.github.com/users/andrew-aladev/followers","following_url":"https://api.github.com/users/andrew-aladev/following{/other_user}","gists_url":"https://api.github.com/users/andrew-aladev/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-aladev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-aladev/subscriptions","organizations_url":"https://api.github.com/users/andrew-aladev/orgs","repos_url":"https://api.github.com/users/andrew-aladev/repos","events_url":"https://api.github.com/users/andrew-aladev/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-aladev/received_events","type":"User","site_admin":false},"assignees":[{"login":"andrew-aladev","id":941925,"avatar_url":"https://avatars.githubusercontent.com/u/941925?v=3","gravatar_id":"","url":"https://api.github.com/users/andrew-aladev","html_url":"https://github.com/andrew-aladev","followers_url":"https://api.github.com/users/andrew-aladev/followers","following_url":"https://api.github.com/users/andrew-aladev/following{/other_user}","gists_url":"https://api.github.com/users/andrew-aladev/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-aladev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-aladev/subscriptions","organizations_url":"https://api.github.com/users/andrew-aladev/orgs","repos_url":"https://api.github.com/users/andrew-aladev/repos","events_url":"https://api.github.com/users/andrew-aladev/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-aladev/received_events","type":"User","site_admin":false},{"login":"evabishchevich","id":17500412,"avatar_url":"https://avatars.githubusercontent.com/u/17500412?v=3","gravatar_id":"","url":"https://api.github.com/users/evabishchevich","html_url":"https://github.com/evabishchevich","followers_url":"https://api.github.com/users/evabishchevich/followers","following_url":"https://api.github.com/users/evabishchevich/following{/other_user}","gists_url":"https://api.github.com/users/evabishchevich/gists{/gist_id}","starred_url":"https://api.github.com/users/evabishchevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evabishchevich/subscriptions","organizations_url":"https://api.github.com/users/evabishchevich/orgs","repos_url":"https://api.github.com/users/evabishchevich/repos","events_url":"https://api.github.com/users/evabishchevich/events{/privacy}","received_events_url":"https://api.github.com/users/evabishchevich/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/milestones/7","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/milestones/New%20Infra","labels_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/milestones/7/labels","id":1498038,"number":7,"title":"New Infra","description":"This will be the first release of the new infrastructure working end to end.","creator":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":201,"state":"open","created_at":"2016-01-11T19:12:00Z","updated_at":"2016-07-29T21:23:51Z","due_on":"2016-03-31T07:00:00Z","closed_at":null},"comments":3,"created_at":"2016-07-29T21:23:51Z","updated_at":"2016-07-29T21:39:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/pulls/811","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/811","diff_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/811.diff","patch_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/811.patch"},"body":"@andrew-aladev - Your job on this PR is to review the actual code since it's all node code. Please DO NOT review any of the files that are in test/www/jxcore/bv_tests/disabled.\r\n\r\n@evabishchevich - Your job on this PR is to build and run it on your local Android devices and see how it behaves itself. This code all passes desktop tests so if there is a problem on Android it will be because either Node's expectations of Android or wrong or vice versa. Please leverage @andrew-aladev for node issues. Also make sure you read the test/Readme.md on sinopia. Without that you won't be able to build and deploy. Take a look in particular at UnitTest_App.js line 18. I expect I screwed that if condition up. Normally I would handle this myself but it's a good test run for you and I really need to get Alex unblocked on iOS.\r\n\r\nA note to both of you - no, PRs aren't supposed to be this ridiculously huge. But I was working on this code by myself for months part-time and there was no one around to do PRs. In the future PRs will be much smaller.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/thaliproject/thali_cordovaplugin/811)\n<!-- Reviewable:end -->\n\r\n\r\n<!---\r\n@huboard:{\"order\":2.9789939177407095e-08,\"milestone_order\":811,\"custom_state\":\"\"}\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/comments/236300608","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/811#issuecomment-236300608","issue_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/811","id":236300608,"user":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T21:39:50Z","updated_at":"2016-07-29T21:39:50Z","body":"@evabishchevich Note that this PR won't be able to run in CI until [this issue](https://github.com/thaliproject/CI/issues/49) is resolved. So please just run it on your local machine."}}
{"actor":{"display_login":"yaronyg"}}