{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments/68121760","id":68121760,"diff_hunk":"@@ -1562,7 +1442,7 @@ static const char* authentication_method(const SSL* ssl) {\n                 // No cipher available so return UNKNOWN.\n                 return UNKNOWN_AUTH_METHOD;\n             }\n-            return cipher_authentication_method(sk_value((_STACK*) ciphers, 0));\n+            return SSL_cipher_authentication_method(sk_value((_STACK*) ciphers, 0));","path":"openssl-dynamic/src/main/c/sslcontext.c","position":248,"original_position":248,"commit_id":"688398c83dac1327786e013ad59401b7320e25df","original_commit_id":"688398c83dac1327786e013ad59401b7320e25df","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"@Scottmitch its consistent with other methods defined n ssl_private.h ","created_at":"2016-06-22T19:46:13Z","updated_at":"2016-06-22T19:46:13Z","html_url":"https://github.com/netty/netty-tcnative/pull/164#discussion_r68121760","pull_request_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/164","_links":{"self":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments/68121760"},"html":{"href":"https://github.com/netty/netty-tcnative/pull/164#discussion_r68121760"},"pull_request":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/164"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty-tcnative/pulls/164","id":74827985,"html_url":"https://github.com/netty/netty-tcnative/pull/164","diff_url":"https://github.com/netty/netty-tcnative/pull/164.diff","patch_url":"https://github.com/netty/netty-tcnative/pull/164.patch","issue_url":"https://api.github.com/repos/netty/netty-tcnative/issues/164","number":164,"state":"open","locked":false,"title":"Add support for setting callback via SSL_CTX_set_client_cert_cb","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nTo be able to hook in X509KeyManager we need to allow setting a callback via SSL_CTX_set_client_cert_cb.\r\n\r\nModification:\r\n\r\nAdd CertificateRequestedCallback and needed SSL methods to set the cert / privatekey so we can hook in X509KeyManager from within netty.\r\n\r\nResult:\r\n\r\nBe able to hook in X509KeyManager","created_at":"2016-06-22T17:52:17Z","updated_at":"2016-06-22T19:46:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c10493f64926ded11a7708cde1a08f7d7f58f555","assignee":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty-tcnative/milestones/21","html_url":"https://github.com/netty/netty-tcnative/milestones/1.1.33.Fork18","labels_url":"https://api.github.com/repos/netty/netty-tcnative/milestones/21/labels","id":1819819,"number":21,"title":"1.1.33.Fork18","description":"","creator":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":10,"state":"open","created_at":"2016-06-10T11:40:18Z","updated_at":"2016-06-22T17:52:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/164/commits","review_comments_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/164/comments","review_comment_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty-tcnative/issues/164/comments","statuses_url":"https://api.github.com/repos/netty/netty-tcnative/statuses/688398c83dac1327786e013ad59401b7320e25df","head":{"label":"netty:keyfactory","ref":"keyfactory","sha":"688398c83dac1327786e013ad59401b7320e25df","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":19016985,"name":"netty-tcnative","full_name":"netty/netty-tcnative","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty-tcnative","description":"A fork of Apache Tomcat Native, based on finagle-native","fork":false,"url":"https://api.github.com/repos/netty/netty-tcnative","forks_url":"https://api.github.com/repos/netty/netty-tcnative/forks","keys_url":"https://api.github.com/repos/netty/netty-tcnative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty-tcnative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty-tcnative/teams","hooks_url":"https://api.github.com/repos/netty/netty-tcnative/hooks","issue_events_url":"https://api.github.com/repos/netty/netty-tcnative/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty-tcnative/events","assignees_url":"https://api.github.com/repos/netty/netty-tcnative/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty-tcnative/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty-tcnative/tags","blobs_url":"https://api.github.com/repos/netty/netty-tcnative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty-tcnative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty-tcnative/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty-tcnative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty-tcnative/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty-tcnative/languages","stargazers_url":"https://api.github.com/repos/netty/netty-tcnative/stargazers","contributors_url":"https://api.github.com/repos/netty/netty-tcnative/contributors","subscribers_url":"https://api.github.com/repos/netty/netty-tcnative/subscribers","subscription_url":"https://api.github.com/repos/netty/netty-tcnative/subscription","commits_url":"https://api.github.com/repos/netty/netty-tcnative/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty-tcnative/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty-tcnative/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty-tcnative/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty-tcnative/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty-tcnative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty-tcnative/merges","archive_url":"https://api.github.com/repos/netty/netty-tcnative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty-tcnative/downloads","issues_url":"https://api.github.com/repos/netty/netty-tcnative/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty-tcnative/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty-tcnative/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty-tcnative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty-tcnative/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty-tcnative/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty-tcnative/deployments","created_at":"2014-04-22T04:24:17Z","updated_at":"2016-06-22T07:56:09Z","pushed_at":"2016-06-22T17:52:17Z","git_url":"git://github.com/netty/netty-tcnative.git","ssh_url":"git@github.com:netty/netty-tcnative.git","clone_url":"https://github.com/netty/netty-tcnative.git","svn_url":"https://github.com/netty/netty-tcnative","homepage":null,"size":1038,"stargazers_count":39,"watchers_count":39,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":23,"forks":33,"open_issues":23,"watchers":39,"default_branch":"1.1.33"}},"base":{"label":"netty:1.1.33","ref":"1.1.33","sha":"03d0e888c9c774cc56ee17253724ef0cd3d60696","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":19016985,"name":"netty-tcnative","full_name":"netty/netty-tcnative","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty-tcnative","description":"A fork of Apache Tomcat Native, based on finagle-native","fork":false,"url":"https://api.github.com/repos/netty/netty-tcnative","forks_url":"https://api.github.com/repos/netty/netty-tcnative/forks","keys_url":"https://api.github.com/repos/netty/netty-tcnative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty-tcnative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty-tcnative/teams","hooks_url":"https://api.github.com/repos/netty/netty-tcnative/hooks","issue_events_url":"https://api.github.com/repos/netty/netty-tcnative/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty-tcnative/events","assignees_url":"https://api.github.com/repos/netty/netty-tcnative/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty-tcnative/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty-tcnative/tags","blobs_url":"https://api.github.com/repos/netty/netty-tcnative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty-tcnative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty-tcnative/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty-tcnative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty-tcnative/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty-tcnative/languages","stargazers_url":"https://api.github.com/repos/netty/netty-tcnative/stargazers","contributors_url":"https://api.github.com/repos/netty/netty-tcnative/contributors","subscribers_url":"https://api.github.com/repos/netty/netty-tcnative/subscribers","subscription_url":"https://api.github.com/repos/netty/netty-tcnative/subscription","commits_url":"https://api.github.com/repos/netty/netty-tcnative/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty-tcnative/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty-tcnative/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty-tcnative/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty-tcnative/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty-tcnative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty-tcnative/merges","archive_url":"https://api.github.com/repos/netty/netty-tcnative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty-tcnative/downloads","issues_url":"https://api.github.com/repos/netty/netty-tcnative/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty-tcnative/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty-tcnative/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty-tcnative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty-tcnative/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty-tcnative/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty-tcnative/deployments","created_at":"2014-04-22T04:24:17Z","updated_at":"2016-06-22T07:56:09Z","pushed_at":"2016-06-22T17:52:17Z","git_url":"git://github.com/netty/netty-tcnative.git","ssh_url":"git@github.com:netty/netty-tcnative.git","clone_url":"https://github.com/netty/netty-tcnative.git","svn_url":"https://github.com/netty/netty-tcnative","homepage":null,"size":1038,"stargazers_count":39,"watchers_count":39,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":23,"forks":33,"open_issues":23,"watchers":39,"default_branch":"1.1.33"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/164"},"html":{"href":"https://github.com/netty/netty-tcnative/pull/164"},"issue":{"href":"https://api.github.com/repos/netty/netty-tcnative/issues/164"},"comments":{"href":"https://api.github.com/repos/netty/netty-tcnative/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty-tcnative/statuses/688398c83dac1327786e013ad59401b7320e25df"}}}}
{"actor":{"display_login":"normanmaurer"}}