{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/92145288","pull_request_review_id":12653370,"id":92145288,"diff_hunk":"@@ -1631,8 +1631,7 @@ class OSD : public Dispatcher,\n   map<int, int> debug_heartbeat_drops_remaining;\n   Cond heartbeat_cond;\n   bool heartbeat_stop;\n-  Mutex heartbeat_update_lock; // orders under heartbeat_lock\n-  bool heartbeat_need_update;   ///< true if we need to refresh our heartbeat peers\n+  std::atomic_bool heartbeat_need_update;   ","path":"src/osd/OSD.h","position":6,"original_position":6,"commit_id":"ff718c8b094651d6326e9521ff60eb2e0f81685a","original_commit_id":"ff718c8b094651d6326e9521ff60eb2e0f81685a","user":{"login":"liupan1111","id":17977187,"avatar_url":"https://avatars.githubusercontent.com/u/17977187?v=3","gravatar_id":"","url":"https://api.github.com/users/liupan1111","html_url":"https://github.com/liupan1111","followers_url":"https://api.github.com/users/liupan1111/followers","following_url":"https://api.github.com/users/liupan1111/following{/other_user}","gists_url":"https://api.github.com/users/liupan1111/gists{/gist_id}","starred_url":"https://api.github.com/users/liupan1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liupan1111/subscriptions","organizations_url":"https://api.github.com/users/liupan1111/orgs","repos_url":"https://api.github.com/users/liupan1111/repos","events_url":"https://api.github.com/users/liupan1111/events{/privacy}","received_events_url":"https://api.github.com/users/liupan1111/received_events","type":"User","site_admin":false},"body":"cool....let me change it.","created_at":"2016-12-13T11:03:03Z","updated_at":"2016-12-13T11:03:03Z","html_url":"https://github.com/ceph/ceph/pull/12461#discussion_r92145288","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/12461","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/92145288"},"html":{"href":"https://github.com/ceph/ceph/pull/12461#discussion_r92145288"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12461"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/12461","id":97705787,"html_url":"https://github.com/ceph/ceph/pull/12461","diff_url":"https://github.com/ceph/ceph/pull/12461.diff","patch_url":"https://github.com/ceph/ceph/pull/12461.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/12461","number":12461,"state":"open","locked":false,"title":"osd: remove the lock heartbeat_update_lock, and change heatbeat_need_…","user":{"login":"liupan1111","id":17977187,"avatar_url":"https://avatars.githubusercontent.com/u/17977187?v=3","gravatar_id":"","url":"https://api.github.com/users/liupan1111","html_url":"https://github.com/liupan1111","followers_url":"https://api.github.com/users/liupan1111/followers","following_url":"https://api.github.com/users/liupan1111/following{/other_user}","gists_url":"https://api.github.com/users/liupan1111/gists{/gist_id}","starred_url":"https://api.github.com/users/liupan1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liupan1111/subscriptions","organizations_url":"https://api.github.com/users/liupan1111/orgs","repos_url":"https://api.github.com/users/liupan1111/repos","events_url":"https://api.github.com/users/liupan1111/events{/privacy}","received_events_url":"https://api.github.com/users/liupan1111/received_events","type":"User","site_admin":false},"body":"…update to atomic_bool\r\n\r\nSigned-off-by: Pan Liu <pan.liu@istuary.com>","created_at":"2016-12-13T08:31:36Z","updated_at":"2016-12-13T11:03:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c8a3e1bbdc2808f7acdc8308e9685a843d97a97","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/12461/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/12461/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/12461/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/ff718c8b094651d6326e9521ff60eb2e0f81685a","head":{"label":"liupan1111:wip-replace-atomic","ref":"wip-replace-atomic","sha":"ff718c8b094651d6326e9521ff60eb2e0f81685a","user":{"login":"liupan1111","id":17977187,"avatar_url":"https://avatars.githubusercontent.com/u/17977187?v=3","gravatar_id":"","url":"https://api.github.com/users/liupan1111","html_url":"https://github.com/liupan1111","followers_url":"https://api.github.com/users/liupan1111/followers","following_url":"https://api.github.com/users/liupan1111/following{/other_user}","gists_url":"https://api.github.com/users/liupan1111/gists{/gist_id}","starred_url":"https://api.github.com/users/liupan1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liupan1111/subscriptions","organizations_url":"https://api.github.com/users/liupan1111/orgs","repos_url":"https://api.github.com/users/liupan1111/repos","events_url":"https://api.github.com/users/liupan1111/events{/privacy}","received_events_url":"https://api.github.com/users/liupan1111/received_events","type":"User","site_admin":false},"repo":{"id":73261462,"name":"ceph","full_name":"liupan1111/ceph","owner":{"login":"liupan1111","id":17977187,"avatar_url":"https://avatars.githubusercontent.com/u/17977187?v=3","gravatar_id":"","url":"https://api.github.com/users/liupan1111","html_url":"https://github.com/liupan1111","followers_url":"https://api.github.com/users/liupan1111/followers","following_url":"https://api.github.com/users/liupan1111/following{/other_user}","gists_url":"https://api.github.com/users/liupan1111/gists{/gist_id}","starred_url":"https://api.github.com/users/liupan1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liupan1111/subscriptions","organizations_url":"https://api.github.com/users/liupan1111/orgs","repos_url":"https://api.github.com/users/liupan1111/repos","events_url":"https://api.github.com/users/liupan1111/events{/privacy}","received_events_url":"https://api.github.com/users/liupan1111/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liupan1111/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/liupan1111/ceph","forks_url":"https://api.github.com/repos/liupan1111/ceph/forks","keys_url":"https://api.github.com/repos/liupan1111/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liupan1111/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liupan1111/ceph/teams","hooks_url":"https://api.github.com/repos/liupan1111/ceph/hooks","issue_events_url":"https://api.github.com/repos/liupan1111/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/liupan1111/ceph/events","assignees_url":"https://api.github.com/repos/liupan1111/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/liupan1111/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/liupan1111/ceph/tags","blobs_url":"https://api.github.com/repos/liupan1111/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liupan1111/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liupan1111/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/liupan1111/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liupan1111/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/liupan1111/ceph/languages","stargazers_url":"https://api.github.com/repos/liupan1111/ceph/stargazers","contributors_url":"https://api.github.com/repos/liupan1111/ceph/contributors","subscribers_url":"https://api.github.com/repos/liupan1111/ceph/subscribers","subscription_url":"https://api.github.com/repos/liupan1111/ceph/subscription","commits_url":"https://api.github.com/repos/liupan1111/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/liupan1111/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/liupan1111/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/liupan1111/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/liupan1111/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/liupan1111/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liupan1111/ceph/merges","archive_url":"https://api.github.com/repos/liupan1111/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liupan1111/ceph/downloads","issues_url":"https://api.github.com/repos/liupan1111/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/liupan1111/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/liupan1111/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/liupan1111/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liupan1111/ceph/labels{/name}","releases_url":"https://api.github.com/repos/liupan1111/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/liupan1111/ceph/deployments","created_at":"2016-11-09T07:34:45Z","updated_at":"2016-11-09T07:35:07Z","pushed_at":"2016-12-13T08:30:37Z","git_url":"git://github.com/liupan1111/ceph.git","ssh_url":"git@github.com:liupan1111/ceph.git","clone_url":"https://github.com/liupan1111/ceph.git","svn_url":"https://github.com/liupan1111/ceph","homepage":"http://ceph.com","size":190880,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"a3bf341876294390ca1dbc44f09ef150ba2f7d91","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-12-13T10:20:32Z","pushed_at":"2016-12-13T11:02:56Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":255631,"stargazers_count":2705,"watchers_count":2705,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1584,"mirror_url":null,"open_issues_count":383,"forks":1584,"open_issues":383,"watchers":2705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12461"},"html":{"href":"https://github.com/ceph/ceph/pull/12461"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/12461"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/12461/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12461/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12461/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/ff718c8b094651d6326e9521ff60eb2e0f81685a"}}}}
{"actor":{"display_login":"liupan1111"}}