{"action":"created","comment":{"url":"https://api.github.com/repos/dask/distributed/pulls/comments/79318245","id":79318245,"diff_hunk":"@@ -132,12 +132,12 @@ class Server(TCPServer):\n     default_port = 0\n \n     def __init__(self, handlers, max_buffer_size=MAX_BUFFER_SIZE,\n-            connection_limit=512, **kwargs):\n+            connection_limit=512, ssl_context_creator= create_ssl_context, **kwargs):\n         self.handlers = assoc(handlers, 'identity', self.identity)\n         self.id = str(uuid.uuid1())\n         self._port = None\n         self.rpc = ConnectionPool(limit=connection_limit)\n-        super(Server, self).__init__(max_buffer_size=max_buffer_size, **kwargs)\n+        super(Server, self).__init__(max_buffer_size=max_buffer_size, ssl_options=ssl_context_creator(), **kwargs)","path":"distributed/core.py","position":24,"original_position":24,"commit_id":"bd7dcc4c4ed5a130aa8b064f7696a9da35e3f1cb","original_commit_id":"bd7dcc4c4ed5a130aa8b064f7696a9da35e3f1cb","user":{"login":"mrocklin","id":306380,"avatar_url":"https://avatars.githubusercontent.com/u/306380?v=3","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"body":"Yeah, so I think at the moment I'm mostly confused because I don't understand the pain you're currently trying to solve.  If I were to solve this problem (that I admittedly know little about) I would probably check for ssl certificates whereever I called Scheduler/Worker and then send them in at that point.  My guess is that this would be at the CLI level.  ","created_at":"2016-09-18T23:48:18Z","updated_at":"2016-09-18T23:48:18Z","html_url":"https://github.com/dask/distributed/pull/537#discussion_r79318245","pull_request_url":"https://api.github.com/repos/dask/distributed/pulls/537","_links":{"self":{"href":"https://api.github.com/repos/dask/distributed/pulls/comments/79318245"},"html":{"href":"https://github.com/dask/distributed/pull/537#discussion_r79318245"},"pull_request":{"href":"https://api.github.com/repos/dask/distributed/pulls/537"}}},"pull_request":{"url":"https://api.github.com/repos/dask/distributed/pulls/537","id":85723225,"html_url":"https://github.com/dask/distributed/pull/537","diff_url":"https://github.com/dask/distributed/pull/537.diff","patch_url":"https://github.com/dask/distributed/pull/537.patch","issue_url":"https://api.github.com/repos/dask/distributed/issues/537","number":537,"state":"open","locked":false,"title":"Add ssl configurations for Server and rpc connections","user":{"login":"hussainsultan","id":3936122,"avatar_url":"https://avatars.githubusercontent.com/u/3936122?v=3","gravatar_id":"","url":"https://api.github.com/users/hussainsultan","html_url":"https://github.com/hussainsultan","followers_url":"https://api.github.com/users/hussainsultan/followers","following_url":"https://api.github.com/users/hussainsultan/following{/other_user}","gists_url":"https://api.github.com/users/hussainsultan/gists{/gist_id}","starred_url":"https://api.github.com/users/hussainsultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hussainsultan/subscriptions","organizations_url":"https://api.github.com/users/hussainsultan/orgs","repos_url":"https://api.github.com/users/hussainsultan/repos","events_url":"https://api.github.com/users/hussainsultan/events{/privacy}","received_events_url":"https://api.github.com/users/hussainsultan/received_events","type":"User","site_admin":false},"body":"Add minimal SSL configuration options for `dask.distributed` cluster.  \r\n\r\nFor production deployments, this PR allows for setting up different TLS certificate for every dask worker node in your cluster, scheduler node and client node. It assumes that all certificates are signed by a single \"root/cluster\" CA authority.  This does not include verification of certificates  when presented.\r\n\r\nThis PR does not add SSL for Bokeh Interface.  Needs docs. ","created_at":"2016-09-18T21:16:01Z","updated_at":"2016-09-18T23:48:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d582ce9613a5cc8794d5964c3583f5f0d9ff1a13","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dask/distributed/pulls/537/commits","review_comments_url":"https://api.github.com/repos/dask/distributed/pulls/537/comments","review_comment_url":"https://api.github.com/repos/dask/distributed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dask/distributed/issues/537/comments","statuses_url":"https://api.github.com/repos/dask/distributed/statuses/bd7dcc4c4ed5a130aa8b064f7696a9da35e3f1cb","head":{"label":"hussainsultan:ssl_communication","ref":"ssl_communication","sha":"bd7dcc4c4ed5a130aa8b064f7696a9da35e3f1cb","user":{"login":"hussainsultan","id":3936122,"avatar_url":"https://avatars.githubusercontent.com/u/3936122?v=3","gravatar_id":"","url":"https://api.github.com/users/hussainsultan","html_url":"https://github.com/hussainsultan","followers_url":"https://api.github.com/users/hussainsultan/followers","following_url":"https://api.github.com/users/hussainsultan/following{/other_user}","gists_url":"https://api.github.com/users/hussainsultan/gists{/gist_id}","starred_url":"https://api.github.com/users/hussainsultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hussainsultan/subscriptions","organizations_url":"https://api.github.com/users/hussainsultan/orgs","repos_url":"https://api.github.com/users/hussainsultan/repos","events_url":"https://api.github.com/users/hussainsultan/events{/privacy}","received_events_url":"https://api.github.com/users/hussainsultan/received_events","type":"User","site_admin":false},"repo":{"id":62074681,"name":"distributed","full_name":"hussainsultan/distributed","owner":{"login":"hussainsultan","id":3936122,"avatar_url":"https://avatars.githubusercontent.com/u/3936122?v=3","gravatar_id":"","url":"https://api.github.com/users/hussainsultan","html_url":"https://github.com/hussainsultan","followers_url":"https://api.github.com/users/hussainsultan/followers","following_url":"https://api.github.com/users/hussainsultan/following{/other_user}","gists_url":"https://api.github.com/users/hussainsultan/gists{/gist_id}","starred_url":"https://api.github.com/users/hussainsultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hussainsultan/subscriptions","organizations_url":"https://api.github.com/users/hussainsultan/orgs","repos_url":"https://api.github.com/users/hussainsultan/repos","events_url":"https://api.github.com/users/hussainsultan/events{/privacy}","received_events_url":"https://api.github.com/users/hussainsultan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hussainsultan/distributed","description":"Distributed computation in Python","fork":true,"url":"https://api.github.com/repos/hussainsultan/distributed","forks_url":"https://api.github.com/repos/hussainsultan/distributed/forks","keys_url":"https://api.github.com/repos/hussainsultan/distributed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hussainsultan/distributed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hussainsultan/distributed/teams","hooks_url":"https://api.github.com/repos/hussainsultan/distributed/hooks","issue_events_url":"https://api.github.com/repos/hussainsultan/distributed/issues/events{/number}","events_url":"https://api.github.com/repos/hussainsultan/distributed/events","assignees_url":"https://api.github.com/repos/hussainsultan/distributed/assignees{/user}","branches_url":"https://api.github.com/repos/hussainsultan/distributed/branches{/branch}","tags_url":"https://api.github.com/repos/hussainsultan/distributed/tags","blobs_url":"https://api.github.com/repos/hussainsultan/distributed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hussainsultan/distributed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hussainsultan/distributed/git/refs{/sha}","trees_url":"https://api.github.com/repos/hussainsultan/distributed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hussainsultan/distributed/statuses/{sha}","languages_url":"https://api.github.com/repos/hussainsultan/distributed/languages","stargazers_url":"https://api.github.com/repos/hussainsultan/distributed/stargazers","contributors_url":"https://api.github.com/repos/hussainsultan/distributed/contributors","subscribers_url":"https://api.github.com/repos/hussainsultan/distributed/subscribers","subscription_url":"https://api.github.com/repos/hussainsultan/distributed/subscription","commits_url":"https://api.github.com/repos/hussainsultan/distributed/commits{/sha}","git_commits_url":"https://api.github.com/repos/hussainsultan/distributed/git/commits{/sha}","comments_url":"https://api.github.com/repos/hussainsultan/distributed/comments{/number}","issue_comment_url":"https://api.github.com/repos/hussainsultan/distributed/issues/comments{/number}","contents_url":"https://api.github.com/repos/hussainsultan/distributed/contents/{+path}","compare_url":"https://api.github.com/repos/hussainsultan/distributed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hussainsultan/distributed/merges","archive_url":"https://api.github.com/repos/hussainsultan/distributed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hussainsultan/distributed/downloads","issues_url":"https://api.github.com/repos/hussainsultan/distributed/issues{/number}","pulls_url":"https://api.github.com/repos/hussainsultan/distributed/pulls{/number}","milestones_url":"https://api.github.com/repos/hussainsultan/distributed/milestones{/number}","notifications_url":"https://api.github.com/repos/hussainsultan/distributed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hussainsultan/distributed/labels{/name}","releases_url":"https://api.github.com/repos/hussainsultan/distributed/releases{/id}","deployments_url":"https://api.github.com/repos/hussainsultan/distributed/deployments","created_at":"2016-06-27T17:27:57Z","updated_at":"2016-06-27T17:27:58Z","pushed_at":"2016-09-18T21:39:41Z","git_url":"git://github.com/hussainsultan/distributed.git","ssh_url":"git@github.com:hussainsultan/distributed.git","clone_url":"https://github.com/hussainsultan/distributed.git","svn_url":"https://github.com/hussainsultan/distributed","homepage":"http://distributed.readthedocs.io/en/latest/","size":3371,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dask:master","ref":"master","sha":"e842616b8e555111666a0aeced1fb7b6aa8cdf8d","user":{"login":"dask","id":17131925,"avatar_url":"https://avatars.githubusercontent.com/u/17131925?v=3","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"repo":{"id":42408083,"name":"distributed","full_name":"dask/distributed","owner":{"login":"dask","id":17131925,"avatar_url":"https://avatars.githubusercontent.com/u/17131925?v=3","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dask/distributed","description":"Distributed computation in Python","fork":false,"url":"https://api.github.com/repos/dask/distributed","forks_url":"https://api.github.com/repos/dask/distributed/forks","keys_url":"https://api.github.com/repos/dask/distributed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dask/distributed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dask/distributed/teams","hooks_url":"https://api.github.com/repos/dask/distributed/hooks","issue_events_url":"https://api.github.com/repos/dask/distributed/issues/events{/number}","events_url":"https://api.github.com/repos/dask/distributed/events","assignees_url":"https://api.github.com/repos/dask/distributed/assignees{/user}","branches_url":"https://api.github.com/repos/dask/distributed/branches{/branch}","tags_url":"https://api.github.com/repos/dask/distributed/tags","blobs_url":"https://api.github.com/repos/dask/distributed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dask/distributed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dask/distributed/git/refs{/sha}","trees_url":"https://api.github.com/repos/dask/distributed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dask/distributed/statuses/{sha}","languages_url":"https://api.github.com/repos/dask/distributed/languages","stargazers_url":"https://api.github.com/repos/dask/distributed/stargazers","contributors_url":"https://api.github.com/repos/dask/distributed/contributors","subscribers_url":"https://api.github.com/repos/dask/distributed/subscribers","subscription_url":"https://api.github.com/repos/dask/distributed/subscription","commits_url":"https://api.github.com/repos/dask/distributed/commits{/sha}","git_commits_url":"https://api.github.com/repos/dask/distributed/git/commits{/sha}","comments_url":"https://api.github.com/repos/dask/distributed/comments{/number}","issue_comment_url":"https://api.github.com/repos/dask/distributed/issues/comments{/number}","contents_url":"https://api.github.com/repos/dask/distributed/contents/{+path}","compare_url":"https://api.github.com/repos/dask/distributed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dask/distributed/merges","archive_url":"https://api.github.com/repos/dask/distributed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dask/distributed/downloads","issues_url":"https://api.github.com/repos/dask/distributed/issues{/number}","pulls_url":"https://api.github.com/repos/dask/distributed/pulls{/number}","milestones_url":"https://api.github.com/repos/dask/distributed/milestones{/number}","notifications_url":"https://api.github.com/repos/dask/distributed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dask/distributed/labels{/name}","releases_url":"https://api.github.com/repos/dask/distributed/releases{/id}","deployments_url":"https://api.github.com/repos/dask/distributed/deployments","created_at":"2015-09-13T18:42:29Z","updated_at":"2016-09-18T09:40:58Z","pushed_at":"2016-09-18T21:39:44Z","git_url":"git://github.com/dask/distributed.git","ssh_url":"git@github.com:dask/distributed.git","clone_url":"https://github.com/dask/distributed.git","svn_url":"https://github.com/dask/distributed","homepage":"http://distributed.readthedocs.io/en/latest/","size":3750,"stargazers_count":152,"watchers_count":152,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":30,"forks":58,"open_issues":30,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dask/distributed/pulls/537"},"html":{"href":"https://github.com/dask/distributed/pull/537"},"issue":{"href":"https://api.github.com/repos/dask/distributed/issues/537"},"comments":{"href":"https://api.github.com/repos/dask/distributed/issues/537/comments"},"review_comments":{"href":"https://api.github.com/repos/dask/distributed/pulls/537/comments"},"review_comment":{"href":"https://api.github.com/repos/dask/distributed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dask/distributed/pulls/537/commits"},"statuses":{"href":"https://api.github.com/repos/dask/distributed/statuses/bd7dcc4c4ed5a130aa8b064f7696a9da35e3f1cb"}}}}
{"actor":{"display_login":"mrocklin"}}