{"action":"created","comment":{"url":"https://api.github.com/repos/realm/SwiftLint/pulls/comments/92065783","pull_request_review_id":12575435,"id":92065783,"diff_hunk":"@@ -0,0 +1,23 @@\n+//\n+//  SwiftExpressionCallKind.swift\n+//  SwiftLint\n+//\n+//  Created by Marcelo Fabri on 11/12/16.\n+//  Copyright © 2016 Realm. All rights reserved.\n+//\n+\n+import Foundation\n+\n+public enum SwiftExpressionCallKind: String {","path":"Source/SwiftLintFramework/Extensions/SwiftExpressionCallKind.swift","position":11,"original_position":11,"commit_id":"3187bef199f4b2be7a571277c67e48a57409ee44","original_commit_id":"3187bef199f4b2be7a571277c67e48a57409ee44","user":{"login":"marcelofabri","id":833072,"avatar_url":"https://avatars.githubusercontent.com/u/833072?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelofabri","html_url":"https://github.com/marcelofabri","followers_url":"https://api.github.com/users/marcelofabri/followers","following_url":"https://api.github.com/users/marcelofabri/following{/other_user}","gists_url":"https://api.github.com/users/marcelofabri/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelofabri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelofabri/subscriptions","organizations_url":"https://api.github.com/users/marcelofabri/orgs","repos_url":"https://api.github.com/users/marcelofabri/repos","events_url":"https://api.github.com/users/marcelofabri/events{/privacy}","received_events_url":"https://api.github.com/users/marcelofabri/received_events","type":"User","site_admin":false},"body":"I think we'd need to rethink our implementations if we did that. They only work because of the `other` case, as these kinds can be nested in other kinds (`struct` for example). If we added the other cases and removed the `other` one, some rules could start failing.\r\n\r\nFor example, `trailing_comma` in this example: \r\n```swift\r\nstruct Bar {\r\n  let foo = [1: 2, 2: 3, ]\r\n},\r\n```\r\n\r\nThis enum also can't be `internal` because it's used as `associatedtype` on `ASTRule`s, in functions that are `public`.","created_at":"2016-12-12T23:29:05Z","updated_at":"2016-12-12T23:29:05Z","html_url":"https://github.com/realm/SwiftLint/pull/960#discussion_r92065783","pull_request_url":"https://api.github.com/repos/realm/SwiftLint/pulls/960","_links":{"self":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/comments/92065783"},"html":{"href":"https://github.com/realm/SwiftLint/pull/960#discussion_r92065783"},"pull_request":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/960"}}},"pull_request":{"url":"https://api.github.com/repos/realm/SwiftLint/pulls/960","id":97468703,"html_url":"https://github.com/realm/SwiftLint/pull/960","diff_url":"https://github.com/realm/SwiftLint/pull/960.diff","patch_url":"https://github.com/realm/SwiftLint/pull/960.patch","issue_url":"https://api.github.com/repos/realm/SwiftLint/issues/960","number":960,"state":"open","locked":false,"title":"Add closure_parameter_position rule","user":{"login":"marcelofabri","id":833072,"avatar_url":"https://avatars.githubusercontent.com/u/833072?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelofabri","html_url":"https://github.com/marcelofabri","followers_url":"https://api.github.com/users/marcelofabri/followers","following_url":"https://api.github.com/users/marcelofabri/following{/other_user}","gists_url":"https://api.github.com/users/marcelofabri/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelofabri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelofabri/subscriptions","organizations_url":"https://api.github.com/users/marcelofabri/orgs","repos_url":"https://api.github.com/users/marcelofabri/repos","events_url":"https://api.github.com/users/marcelofabri/events{/privacy}","received_events_url":"https://api.github.com/users/marcelofabri/received_events","type":"User","site_admin":false},"body":"Fixes #931","created_at":"2016-12-11T19:05:37Z","updated_at":"2016-12-12T23:29:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7fb4d5b6076ede3a87cddbeceb1e1d6d6fc016c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/realm/SwiftLint/pulls/960/commits","review_comments_url":"https://api.github.com/repos/realm/SwiftLint/pulls/960/comments","review_comment_url":"https://api.github.com/repos/realm/SwiftLint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/SwiftLint/issues/960/comments","statuses_url":"https://api.github.com/repos/realm/SwiftLint/statuses/3187bef199f4b2be7a571277c67e48a57409ee44","head":{"label":"marcelofabri:closure_parameter_position","ref":"closure_parameter_position","sha":"3187bef199f4b2be7a571277c67e48a57409ee44","user":{"login":"marcelofabri","id":833072,"avatar_url":"https://avatars.githubusercontent.com/u/833072?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelofabri","html_url":"https://github.com/marcelofabri","followers_url":"https://api.github.com/users/marcelofabri/followers","following_url":"https://api.github.com/users/marcelofabri/following{/other_user}","gists_url":"https://api.github.com/users/marcelofabri/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelofabri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelofabri/subscriptions","organizations_url":"https://api.github.com/users/marcelofabri/orgs","repos_url":"https://api.github.com/users/marcelofabri/repos","events_url":"https://api.github.com/users/marcelofabri/events{/privacy}","received_events_url":"https://api.github.com/users/marcelofabri/received_events","type":"User","site_admin":false},"repo":{"id":66171616,"name":"SwiftLint","full_name":"marcelofabri/SwiftLint","owner":{"login":"marcelofabri","id":833072,"avatar_url":"https://avatars.githubusercontent.com/u/833072?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelofabri","html_url":"https://github.com/marcelofabri","followers_url":"https://api.github.com/users/marcelofabri/followers","following_url":"https://api.github.com/users/marcelofabri/following{/other_user}","gists_url":"https://api.github.com/users/marcelofabri/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelofabri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelofabri/subscriptions","organizations_url":"https://api.github.com/users/marcelofabri/orgs","repos_url":"https://api.github.com/users/marcelofabri/repos","events_url":"https://api.github.com/users/marcelofabri/events{/privacy}","received_events_url":"https://api.github.com/users/marcelofabri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcelofabri/SwiftLint","description":"A tool to enforce Swift style and conventions.","fork":true,"url":"https://api.github.com/repos/marcelofabri/SwiftLint","forks_url":"https://api.github.com/repos/marcelofabri/SwiftLint/forks","keys_url":"https://api.github.com/repos/marcelofabri/SwiftLint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcelofabri/SwiftLint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcelofabri/SwiftLint/teams","hooks_url":"https://api.github.com/repos/marcelofabri/SwiftLint/hooks","issue_events_url":"https://api.github.com/repos/marcelofabri/SwiftLint/issues/events{/number}","events_url":"https://api.github.com/repos/marcelofabri/SwiftLint/events","assignees_url":"https://api.github.com/repos/marcelofabri/SwiftLint/assignees{/user}","branches_url":"https://api.github.com/repos/marcelofabri/SwiftLint/branches{/branch}","tags_url":"https://api.github.com/repos/marcelofabri/SwiftLint/tags","blobs_url":"https://api.github.com/repos/marcelofabri/SwiftLint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcelofabri/SwiftLint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcelofabri/SwiftLint/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcelofabri/SwiftLint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcelofabri/SwiftLint/statuses/{sha}","languages_url":"https://api.github.com/repos/marcelofabri/SwiftLint/languages","stargazers_url":"https://api.github.com/repos/marcelofabri/SwiftLint/stargazers","contributors_url":"https://api.github.com/repos/marcelofabri/SwiftLint/contributors","subscribers_url":"https://api.github.com/repos/marcelofabri/SwiftLint/subscribers","subscription_url":"https://api.github.com/repos/marcelofabri/SwiftLint/subscription","commits_url":"https://api.github.com/repos/marcelofabri/SwiftLint/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcelofabri/SwiftLint/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcelofabri/SwiftLint/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcelofabri/SwiftLint/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcelofabri/SwiftLint/contents/{+path}","compare_url":"https://api.github.com/repos/marcelofabri/SwiftLint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcelofabri/SwiftLint/merges","archive_url":"https://api.github.com/repos/marcelofabri/SwiftLint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcelofabri/SwiftLint/downloads","issues_url":"https://api.github.com/repos/marcelofabri/SwiftLint/issues{/number}","pulls_url":"https://api.github.com/repos/marcelofabri/SwiftLint/pulls{/number}","milestones_url":"https://api.github.com/repos/marcelofabri/SwiftLint/milestones{/number}","notifications_url":"https://api.github.com/repos/marcelofabri/SwiftLint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcelofabri/SwiftLint/labels{/name}","releases_url":"https://api.github.com/repos/marcelofabri/SwiftLint/releases{/id}","deployments_url":"https://api.github.com/repos/marcelofabri/SwiftLint/deployments","created_at":"2016-08-20T22:57:09Z","updated_at":"2016-08-20T22:57:10Z","pushed_at":"2016-12-12T23:10:29Z","git_url":"git://github.com/marcelofabri/SwiftLint.git","ssh_url":"git@github.com:marcelofabri/SwiftLint.git","clone_url":"https://github.com/marcelofabri/SwiftLint.git","svn_url":"https://github.com/marcelofabri/SwiftLint","homepage":"https://realm.io","size":2785,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"realm:master","ref":"master","sha":"288a3ec4585e531508a449a3808587e8017cb271","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":35732214,"name":"SwiftLint","full_name":"realm/SwiftLint","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/SwiftLint","description":"A tool to enforce Swift style and conventions.","fork":false,"url":"https://api.github.com/repos/realm/SwiftLint","forks_url":"https://api.github.com/repos/realm/SwiftLint/forks","keys_url":"https://api.github.com/repos/realm/SwiftLint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/SwiftLint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/SwiftLint/teams","hooks_url":"https://api.github.com/repos/realm/SwiftLint/hooks","issue_events_url":"https://api.github.com/repos/realm/SwiftLint/issues/events{/number}","events_url":"https://api.github.com/repos/realm/SwiftLint/events","assignees_url":"https://api.github.com/repos/realm/SwiftLint/assignees{/user}","branches_url":"https://api.github.com/repos/realm/SwiftLint/branches{/branch}","tags_url":"https://api.github.com/repos/realm/SwiftLint/tags","blobs_url":"https://api.github.com/repos/realm/SwiftLint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/SwiftLint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/SwiftLint/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/SwiftLint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/SwiftLint/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/SwiftLint/languages","stargazers_url":"https://api.github.com/repos/realm/SwiftLint/stargazers","contributors_url":"https://api.github.com/repos/realm/SwiftLint/contributors","subscribers_url":"https://api.github.com/repos/realm/SwiftLint/subscribers","subscription_url":"https://api.github.com/repos/realm/SwiftLint/subscription","commits_url":"https://api.github.com/repos/realm/SwiftLint/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/SwiftLint/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/SwiftLint/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/SwiftLint/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/SwiftLint/contents/{+path}","compare_url":"https://api.github.com/repos/realm/SwiftLint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/SwiftLint/merges","archive_url":"https://api.github.com/repos/realm/SwiftLint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/SwiftLint/downloads","issues_url":"https://api.github.com/repos/realm/SwiftLint/issues{/number}","pulls_url":"https://api.github.com/repos/realm/SwiftLint/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/SwiftLint/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/SwiftLint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/SwiftLint/labels{/name}","releases_url":"https://api.github.com/repos/realm/SwiftLint/releases{/id}","deployments_url":"https://api.github.com/repos/realm/SwiftLint/deployments","created_at":"2015-05-16T16:59:31Z","updated_at":"2016-12-12T23:19:16Z","pushed_at":"2016-12-12T23:10:29Z","git_url":"git://github.com/realm/SwiftLint.git","ssh_url":"git@github.com:realm/SwiftLint.git","clone_url":"https://github.com/realm/SwiftLint.git","svn_url":"https://github.com/realm/SwiftLint","homepage":"https://realm.io","size":3257,"stargazers_count":5300,"watchers_count":5300,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":390,"mirror_url":null,"open_issues_count":146,"forks":390,"open_issues":146,"watchers":5300,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/960"},"html":{"href":"https://github.com/realm/SwiftLint/pull/960"},"issue":{"href":"https://api.github.com/repos/realm/SwiftLint/issues/960"},"comments":{"href":"https://api.github.com/repos/realm/SwiftLint/issues/960/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/960/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/960/commits"},"statuses":{"href":"https://api.github.com/repos/realm/SwiftLint/statuses/3187bef199f4b2be7a571277c67e48a57409ee44"}}}}
{"actor":{"display_login":"marcelofabri"}}