{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7716","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7716/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7716/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7716/events","html_url":"https://github.com/ManageIQ/manageiq/pull/7716","id":146008079,"number":7716,"title":"Convert dc_tree to TreeBuilder","user":{"login":"ZitaNemeckova","id":9210860,"avatar_url":"https://avatars.githubusercontent.com/u/9210860?v=3","gravatar_id":"","url":"https://api.github.com/users/ZitaNemeckova","html_url":"https://github.com/ZitaNemeckova","followers_url":"https://api.github.com/users/ZitaNemeckova/followers","following_url":"https://api.github.com/users/ZitaNemeckova/following{/other_user}","gists_url":"https://api.github.com/users/ZitaNemeckova/gists{/gist_id}","starred_url":"https://api.github.com/users/ZitaNemeckova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZitaNemeckova/subscriptions","organizations_url":"https://api.github.com/users/ZitaNemeckova/orgs","repos_url":"https://api.github.com/users/ZitaNemeckova/repos","events_url":"https://api.github.com/users/ZitaNemeckova/events{/privacy}","received_events_url":"https://api.github.com/users/ZitaNemeckova/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-05T14:33:41Z","updated_at":"2016-04-11T07:52:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7716","html_url":"https://github.com/ManageIQ/manageiq/pull/7716","diff_url":"https://github.com/ManageIQ/manageiq/pull/7716.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7716.patch"},"body":"in ems_common_controller, resource_pool_controller, ems_cluster_controller\r\n\r\nBiggest of thanks to @himdel for introduction in TreeBuilder.\r\n\r\n@miq-bot add_label wip"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/208211275","html_url":"https://github.com/ManageIQ/manageiq/pull/7716#issuecomment-208211275","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7716","id":208211275,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-04-11T07:52:32Z","updated_at":"2016-04-11T07:52:32Z","body":"<rubocop />Checked commits https://github.com/ZitaNemeckova/manageiq/compare/3c70f3ba354da7db15f1df39c4cd7cd6d7db5fc3~...65291c2b01ac42fd836968dd91d2df35340b4663 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1\n11 files checked, 18 offenses detected\n\n**app/controllers/ems_common.rb**\n- [ ] :large_orange_diamond: - [Line 35](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/controllers/ems_common.rb#L35), Col 82 - [Style/DoubleNegation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/DoubleNegation) - Avoid the use of double negation (`!!`).\n\n**app/presenters/tree_builder_datacenter.rb**\n- [ ] :large_orange_diamond: - [Line 36](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_datacenter.rb#L36), Col 24 - [Style/OptionalArguments](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/OptionalArguments) - Optional arguments should appear at the end of the argument list.\n- [ ] :large_orange_diamond: - [Line 49](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_datacenter.rb#L49), Col 42 - [Style/OptionalArguments](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/OptionalArguments) - Optional arguments should appear at the end of the argument list.\n- [ ] :small_blue_diamond: - [Line 36](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_datacenter.rb#L36), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for x_get_tree_roots is too high. [15.94/15]\n- [ ] :small_blue_diamond: - [Line 55](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_datacenter.rb#L55), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for x_get_tree_folder_kids is too high. [44.06/15]\n- [ ] :small_blue_diamond: - [Line 55](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_datacenter.rb#L55), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for x_get_tree_folder_kids is too high. [9/6]\n- [ ] :small_blue_diamond: - [Line 55](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_datacenter.rb#L55), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for x_get_tree_folder_kids is too high. [10/7]\n\n**app/presenters/tree_builder_vat.rb**\n- [ ] :large_orange_diamond: - [Line 21](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_vat.rb#L21), Col 24 - [Style/OptionalArguments](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/OptionalArguments) - Optional arguments should appear at the end of the argument list.\n- [ ] :large_orange_diamond: - [Line 27](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_vat.rb#L27), Col 42 - [Style/OptionalArguments](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/OptionalArguments) - Optional arguments should appear at the end of the argument list.\n- [ ] :small_blue_diamond: - [Line 2](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_vat.rb#L2), Col 17 - [Metrics/ParameterLists](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/ParameterLists) - Avoid parameter lists longer than 5 parameters.\n- [ ] :small_blue_diamond: - [Line 33](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_vat.rb#L33), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for x_get_tree_folder_kids is too high. [50.05/15]\n- [ ] :small_blue_diamond: - [Line 33](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_vat.rb#L33), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for x_get_tree_folder_kids is too high. [11/6]\n- [ ] :small_blue_diamond: - [Line 33](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_vat.rb#L33), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [28/25]\n- [ ] :small_blue_diamond: - [Line 33](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_builder_vat.rb#L33), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for x_get_tree_folder_kids is too high. [12/7]\n\n**app/presenters/tree_node_builder_datacenter.rb**\n- [ ] :small_blue_diamond: - [Line 15](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_node_builder_datacenter.rb#L15), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for tooltip is too high. [18.03/15]\n- [ ] :small_blue_diamond: - [Line 15](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_node_builder_datacenter.rb#L15), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for tooltip is too high. [7/6]\n- [ ] :small_blue_diamond: - [Line 15](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/presenters/tree_node_builder_datacenter.rb#L15), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for tooltip is too high. [8/7]\n\n**app/views/layouts/_dc_tree.html.haml**\n- [ ] :red_circle: **Warn** - [Line 3](https://github.com/ZitaNemeckova/manageiq/blob/65291c2b01ac42fd836968dd91d2df35340b4663/app/views/layouts/_dc_tree.html.haml#L3), Col  -  - Operator `=>` should be surrounded by a single space.\n"}}