{"action":"created","comment":{"url":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/comments/91839119","pull_request_review_id":12351641,"id":91839119,"diff_hunk":"@@ -125,6 +125,41 @@ def side_effect(*args, **kwargs):\n         self.assertEqual(process_mock.communicate.call_count, 1)\n \n     @mock.patch('subprocess.Popen')\n+    def test_bundle_skip_source_maps_suprocess(self, mock_subproc_popen):\n+        \"\"\"\n+        Test that bundling calls the correct subprocess command\n+        \"\"\"\n+\n+        app_name = 'app/dummy'\n+\n+        def side_effect(*args, **kwargs):\n+            _bundle(app_name)\n+            return ('output', 'error')\n+\n+        # mock Popen/communicate\n+        process_mock = mock_Popen(mock_subproc_popen, side_effect=side_effect)\n+\n+        # Bundle app/dummy\n+        system = System(skip_source_maps=True)\n+        system.bundle('app/dummy')\n+        self.assertEqual(mock_subproc_popen.call_count, 1)\n+        command = mock_subproc_popen.call_args[0][0]\n+        outfile = os.path.join(settings.STATIC_ROOT, 'SYSTEMJS/app/dummy.js')\n+        self.assertEqual(command,\n+                         'jspm bundle app/dummy {0} --skip-source-maps'.format(outfile))\n+\n+        mapfile = os.path.join(settings.STATIC_ROOT,\n+                               'SYSTEMJS/{0}.js.map'.format(app_name))\n+        self.assertFalse(os.path.isfile(mapfile))","path":"tests/tests/test_bundle.py","position":29,"original_position":29,"commit_id":"8235d5977385324644c87b78920385f60ccedbe1","original_commit_id":"8235d5977385324644c87b78920385f60ccedbe1","user":{"login":"sergei-maertens","id":5518550,"avatar_url":"https://avatars.githubusercontent.com/u/5518550?v=3","gravatar_id":"","url":"https://api.github.com/users/sergei-maertens","html_url":"https://github.com/sergei-maertens","followers_url":"https://api.github.com/users/sergei-maertens/followers","following_url":"https://api.github.com/users/sergei-maertens/following{/other_user}","gists_url":"https://api.github.com/users/sergei-maertens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergei-maertens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergei-maertens/subscriptions","organizations_url":"https://api.github.com/users/sergei-maertens/orgs","repos_url":"https://api.github.com/users/sergei-maertens/repos","events_url":"https://api.github.com/users/sergei-maertens/events{/privacy}","received_events_url":"https://api.github.com/users/sergei-maertens/received_events","type":"User","site_admin":false},"body":"the idea is of course nice, but this assertion has little value since the actual bundling is mocked away. Asserting that the option is indeed passed on the suprocess command is enough - it's `jspm`/`SystemJS`' duty to ensure that the source map is indeed skipped.\r\n\r\nI would remove this assertion to avoid confusion, and maybe add my above comment as a comment in the test.","created_at":"2016-12-10T17:44:37Z","updated_at":"2016-12-10T17:46:23Z","html_url":"https://github.com/sergei-maertens/django-systemjs/pull/30#discussion_r91839119","pull_request_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/comments/91839119"},"html":{"href":"https://github.com/sergei-maertens/django-systemjs/pull/30#discussion_r91839119"},"pull_request":{"href":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/30","id":94432929,"html_url":"https://github.com/sergei-maertens/django-systemjs/pull/30","diff_url":"https://github.com/sergei-maertens/django-systemjs/pull/30.diff","patch_url":"https://github.com/sergei-maertens/django-systemjs/pull/30.patch","issue_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/issues/30","number":30,"state":"open","locked":false,"title":"Added --skip-source-maps option to systemjs_bundle command.","user":{"login":"funn","id":2428212,"avatar_url":"https://avatars.githubusercontent.com/u/2428212?v=3","gravatar_id":"","url":"https://api.github.com/users/funn","html_url":"https://github.com/funn","followers_url":"https://api.github.com/users/funn/followers","following_url":"https://api.github.com/users/funn/following{/other_user}","gists_url":"https://api.github.com/users/funn/gists{/gist_id}","starred_url":"https://api.github.com/users/funn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funn/subscriptions","organizations_url":"https://api.github.com/users/funn/orgs","repos_url":"https://api.github.com/users/funn/repos","events_url":"https://api.github.com/users/funn/events{/privacy}","received_events_url":"https://api.github.com/users/funn/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-18T20:40:10Z","updated_at":"2016-12-10T17:46:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c8e8a613b36f488562c751f95e2b189d8a6d3a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/30/commits","review_comments_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/30/comments","review_comment_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/issues/30/comments","statuses_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/statuses/8235d5977385324644c87b78920385f60ccedbe1","head":{"label":"funn:develop","ref":"develop","sha":"8235d5977385324644c87b78920385f60ccedbe1","user":{"login":"funn","id":2428212,"avatar_url":"https://avatars.githubusercontent.com/u/2428212?v=3","gravatar_id":"","url":"https://api.github.com/users/funn","html_url":"https://github.com/funn","followers_url":"https://api.github.com/users/funn/followers","following_url":"https://api.github.com/users/funn/following{/other_user}","gists_url":"https://api.github.com/users/funn/gists{/gist_id}","starred_url":"https://api.github.com/users/funn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funn/subscriptions","organizations_url":"https://api.github.com/users/funn/orgs","repos_url":"https://api.github.com/users/funn/repos","events_url":"https://api.github.com/users/funn/events{/privacy}","received_events_url":"https://api.github.com/users/funn/received_events","type":"User","site_admin":false},"repo":{"id":74069174,"name":"django-systemjs","full_name":"funn/django-systemjs","owner":{"login":"funn","id":2428212,"avatar_url":"https://avatars.githubusercontent.com/u/2428212?v=3","gravatar_id":"","url":"https://api.github.com/users/funn","html_url":"https://github.com/funn","followers_url":"https://api.github.com/users/funn/followers","following_url":"https://api.github.com/users/funn/following{/other_user}","gists_url":"https://api.github.com/users/funn/gists{/gist_id}","starred_url":"https://api.github.com/users/funn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funn/subscriptions","organizations_url":"https://api.github.com/users/funn/orgs","repos_url":"https://api.github.com/users/funn/repos","events_url":"https://api.github.com/users/funn/events{/privacy}","received_events_url":"https://api.github.com/users/funn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/funn/django-systemjs","description":null,"fork":true,"url":"https://api.github.com/repos/funn/django-systemjs","forks_url":"https://api.github.com/repos/funn/django-systemjs/forks","keys_url":"https://api.github.com/repos/funn/django-systemjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/funn/django-systemjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/funn/django-systemjs/teams","hooks_url":"https://api.github.com/repos/funn/django-systemjs/hooks","issue_events_url":"https://api.github.com/repos/funn/django-systemjs/issues/events{/number}","events_url":"https://api.github.com/repos/funn/django-systemjs/events","assignees_url":"https://api.github.com/repos/funn/django-systemjs/assignees{/user}","branches_url":"https://api.github.com/repos/funn/django-systemjs/branches{/branch}","tags_url":"https://api.github.com/repos/funn/django-systemjs/tags","blobs_url":"https://api.github.com/repos/funn/django-systemjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/funn/django-systemjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/funn/django-systemjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/funn/django-systemjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/funn/django-systemjs/statuses/{sha}","languages_url":"https://api.github.com/repos/funn/django-systemjs/languages","stargazers_url":"https://api.github.com/repos/funn/django-systemjs/stargazers","contributors_url":"https://api.github.com/repos/funn/django-systemjs/contributors","subscribers_url":"https://api.github.com/repos/funn/django-systemjs/subscribers","subscription_url":"https://api.github.com/repos/funn/django-systemjs/subscription","commits_url":"https://api.github.com/repos/funn/django-systemjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/funn/django-systemjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/funn/django-systemjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/funn/django-systemjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/funn/django-systemjs/contents/{+path}","compare_url":"https://api.github.com/repos/funn/django-systemjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/funn/django-systemjs/merges","archive_url":"https://api.github.com/repos/funn/django-systemjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/funn/django-systemjs/downloads","issues_url":"https://api.github.com/repos/funn/django-systemjs/issues{/number}","pulls_url":"https://api.github.com/repos/funn/django-systemjs/pulls{/number}","milestones_url":"https://api.github.com/repos/funn/django-systemjs/milestones{/number}","notifications_url":"https://api.github.com/repos/funn/django-systemjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/funn/django-systemjs/labels{/name}","releases_url":"https://api.github.com/repos/funn/django-systemjs/releases{/id}","deployments_url":"https://api.github.com/repos/funn/django-systemjs/deployments","created_at":"2016-11-17T21:29:20Z","updated_at":"2016-11-17T21:29:22Z","pushed_at":"2016-11-19T20:22:02Z","git_url":"git://github.com/funn/django-systemjs.git","ssh_url":"git@github.com:funn/django-systemjs.git","clone_url":"https://github.com/funn/django-systemjs.git","svn_url":"https://github.com/funn/django-systemjs","homepage":null,"size":201,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sergei-maertens:develop","ref":"develop","sha":"da9b8a04f8794811c2330b59ffba21b452dd1701","user":{"login":"sergei-maertens","id":5518550,"avatar_url":"https://avatars.githubusercontent.com/u/5518550?v=3","gravatar_id":"","url":"https://api.github.com/users/sergei-maertens","html_url":"https://github.com/sergei-maertens","followers_url":"https://api.github.com/users/sergei-maertens/followers","following_url":"https://api.github.com/users/sergei-maertens/following{/other_user}","gists_url":"https://api.github.com/users/sergei-maertens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergei-maertens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergei-maertens/subscriptions","organizations_url":"https://api.github.com/users/sergei-maertens/orgs","repos_url":"https://api.github.com/users/sergei-maertens/repos","events_url":"https://api.github.com/users/sergei-maertens/events{/privacy}","received_events_url":"https://api.github.com/users/sergei-maertens/received_events","type":"User","site_admin":false},"repo":{"id":38629282,"name":"django-systemjs","full_name":"sergei-maertens/django-systemjs","owner":{"login":"sergei-maertens","id":5518550,"avatar_url":"https://avatars.githubusercontent.com/u/5518550?v=3","gravatar_id":"","url":"https://api.github.com/users/sergei-maertens","html_url":"https://github.com/sergei-maertens","followers_url":"https://api.github.com/users/sergei-maertens/followers","following_url":"https://api.github.com/users/sergei-maertens/following{/other_user}","gists_url":"https://api.github.com/users/sergei-maertens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergei-maertens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergei-maertens/subscriptions","organizations_url":"https://api.github.com/users/sergei-maertens/orgs","repos_url":"https://api.github.com/users/sergei-maertens/repos","events_url":"https://api.github.com/users/sergei-maertens/events{/privacy}","received_events_url":"https://api.github.com/users/sergei-maertens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergei-maertens/django-systemjs","description":null,"fork":false,"url":"https://api.github.com/repos/sergei-maertens/django-systemjs","forks_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/forks","keys_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/teams","hooks_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/hooks","issue_events_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/issues/events{/number}","events_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/events","assignees_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/assignees{/user}","branches_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/branches{/branch}","tags_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/tags","blobs_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/statuses/{sha}","languages_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/languages","stargazers_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/stargazers","contributors_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/contributors","subscribers_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/subscribers","subscription_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/subscription","commits_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/contents/{+path}","compare_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/merges","archive_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/downloads","issues_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/issues{/number}","pulls_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls{/number}","milestones_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/milestones{/number}","notifications_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/labels{/name}","releases_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/releases{/id}","deployments_url":"https://api.github.com/repos/sergei-maertens/django-systemjs/deployments","created_at":"2015-07-06T15:53:26Z","updated_at":"2016-11-22T03:11:16Z","pushed_at":"2016-11-24T18:14:40Z","git_url":"git://github.com/sergei-maertens/django-systemjs.git","ssh_url":"git@github.com:sergei-maertens/django-systemjs.git","clone_url":"https://github.com/sergei-maertens/django-systemjs.git","svn_url":"https://github.com/sergei-maertens/django-systemjs","homepage":null,"size":209,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":40,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/30"},"html":{"href":"https://github.com/sergei-maertens/django-systemjs/pull/30"},"issue":{"href":"https://api.github.com/repos/sergei-maertens/django-systemjs/issues/30"},"comments":{"href":"https://api.github.com/repos/sergei-maertens/django-systemjs/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sergei-maertens/django-systemjs/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/sergei-maertens/django-systemjs/statuses/8235d5977385324644c87b78920385f60ccedbe1"}}}}
{"actor":{"display_login":"sergei-maertens"}}