{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/74542273","id":74542273,"diff_hunk":"@@ -7,22 +7,23 @@\n  */\n \n import {Injectable, NgZone} from '@angular/core';\n-\n-import {ListWrapper, StringMapWrapper} from '../../facade/collection';\n-import {StringWrapper, isPresent} from '../../facade/lang';\n+import {ListWrapper} from '../../facade/collection';\n import {getDOM} from '../dom_adapter';\n-\n import {EventManagerPlugin} from './event_manager';\n \n \n-var modifierKeys = ['alt', 'control', 'meta', 'shift'];\n-var modifierKeyGetters: {[key: string]: (event: KeyboardEvent) => boolean} = {\n+const MODIFIER_KEYS = ['alt', 'control', 'meta', 'shift'];\n+const MODIFIER_KEY_GETTERS: {[key: string]: (event: KeyboardEvent) => boolean} = {\n   'alt': (event: KeyboardEvent) => event.altKey,\n   'control': (event: KeyboardEvent) => event.ctrlKey,\n   'meta': (event: KeyboardEvent) => event.metaKey,\n   'shift': (event: KeyboardEvent) => event.shiftKey\n };\n \n+export interface ParsedEvent {","path":"modules/@angular/platform-browser/src/dom/events/key_events.ts","position":23,"original_position":23,"commit_id":"b9754e622299d27e61ff4072892e21f0e3c42d69","original_commit_id":"b9754e622299d27e61ff4072892e21f0e3c42d69","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"do this need to be exported ? ","created_at":"2016-08-12T05:13:46Z","updated_at":"2016-08-12T05:13:46Z","html_url":"https://github.com/angular/angular/pull/10596#discussion_r74542273","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/10596","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/74542273"},"html":{"href":"https://github.com/angular/angular/pull/10596#discussion_r74542273"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/10596"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/10596","id":80654495,"html_url":"https://github.com/angular/angular/pull/10596","diff_url":"https://github.com/angular/angular/pull/10596.diff","patch_url":"https://github.com/angular/angular/pull/10596.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/10596","number":10596,"state":"open","locked":false,"title":"feat(events): provide the ability to specify key for global events","user":{"login":"DzmitryShylovich","id":9335533,"avatar_url":"https://avatars.githubusercontent.com/u/9335533?v=3","gravatar_id":"","url":"https://api.github.com/users/DzmitryShylovich","html_url":"https://github.com/DzmitryShylovich","followers_url":"https://api.github.com/users/DzmitryShylovich/followers","following_url":"https://api.github.com/users/DzmitryShylovich/following{/other_user}","gists_url":"https://api.github.com/users/DzmitryShylovich/gists{/gist_id}","starred_url":"https://api.github.com/users/DzmitryShylovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DzmitryShylovich/subscriptions","organizations_url":"https://api.github.com/users/DzmitryShylovich/orgs","repos_url":"https://api.github.com/users/DzmitryShylovich/repos","events_url":"https://api.github.com/users/DzmitryShylovich/events{/privacy}","received_events_url":"https://api.github.com/users/DzmitryShylovich/received_events","type":"User","site_admin":false},"body":"**What kind of change does this PR introduce?** (check one with \"x\")\r\n```\r\n[ ] Bugfix\r\n[x] Feature\r\n[x] Code style update (formatting, local variables)\r\n[x] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\nThis PR adds support for:\r\n*  Event keys on global events:\r\n\r\n**Before**\r\n```\r\n @HostListener('document:keyup') onKeyUp() { ... }\r\n```\r\n**After**\r\n```\r\n @HostListener('document:keyup.esc') onEscKey() { ... }\r\n```\r\n\r\n* Global hammerjs events:\r\n\r\n**Before**\r\n```\r\n@HostListener('swiperight', ['$event']) handleSwipeRight(event) { ... }\r\n```\r\n**After**\r\n```\r\n@HostListener('document:swiperight', ['$event']) handleSwipeRight(event) { ... }\r\n```\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n\r\n","created_at":"2016-08-09T16:43:58Z","updated_at":"2016-08-12T05:13:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08b6d0316ab933768d70d092e4609beed9690889","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/10596/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/10596/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/10596/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/b9754e622299d27e61ff4072892e21f0e3c42d69","head":{"label":"DzmitryShylovich:global-key-events","ref":"global-key-events","sha":"b9754e622299d27e61ff4072892e21f0e3c42d69","user":{"login":"DzmitryShylovich","id":9335533,"avatar_url":"https://avatars.githubusercontent.com/u/9335533?v=3","gravatar_id":"","url":"https://api.github.com/users/DzmitryShylovich","html_url":"https://github.com/DzmitryShylovich","followers_url":"https://api.github.com/users/DzmitryShylovich/followers","following_url":"https://api.github.com/users/DzmitryShylovich/following{/other_user}","gists_url":"https://api.github.com/users/DzmitryShylovich/gists{/gist_id}","starred_url":"https://api.github.com/users/DzmitryShylovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DzmitryShylovich/subscriptions","organizations_url":"https://api.github.com/users/DzmitryShylovich/orgs","repos_url":"https://api.github.com/users/DzmitryShylovich/repos","events_url":"https://api.github.com/users/DzmitryShylovich/events{/privacy}","received_events_url":"https://api.github.com/users/DzmitryShylovich/received_events","type":"User","site_admin":false},"repo":{"id":56142926,"name":"angular","full_name":"DzmitryShylovich/angular","owner":{"login":"DzmitryShylovich","id":9335533,"avatar_url":"https://avatars.githubusercontent.com/u/9335533?v=3","gravatar_id":"","url":"https://api.github.com/users/DzmitryShylovich","html_url":"https://github.com/DzmitryShylovich","followers_url":"https://api.github.com/users/DzmitryShylovich/followers","following_url":"https://api.github.com/users/DzmitryShylovich/following{/other_user}","gists_url":"https://api.github.com/users/DzmitryShylovich/gists{/gist_id}","starred_url":"https://api.github.com/users/DzmitryShylovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DzmitryShylovich/subscriptions","organizations_url":"https://api.github.com/users/DzmitryShylovich/orgs","repos_url":"https://api.github.com/users/DzmitryShylovich/repos","events_url":"https://api.github.com/users/DzmitryShylovich/events{/privacy}","received_events_url":"https://api.github.com/users/DzmitryShylovich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DzmitryShylovich/angular","description":"","fork":true,"url":"https://api.github.com/repos/DzmitryShylovich/angular","forks_url":"https://api.github.com/repos/DzmitryShylovich/angular/forks","keys_url":"https://api.github.com/repos/DzmitryShylovich/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DzmitryShylovich/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DzmitryShylovich/angular/teams","hooks_url":"https://api.github.com/repos/DzmitryShylovich/angular/hooks","issue_events_url":"https://api.github.com/repos/DzmitryShylovich/angular/issues/events{/number}","events_url":"https://api.github.com/repos/DzmitryShylovich/angular/events","assignees_url":"https://api.github.com/repos/DzmitryShylovich/angular/assignees{/user}","branches_url":"https://api.github.com/repos/DzmitryShylovich/angular/branches{/branch}","tags_url":"https://api.github.com/repos/DzmitryShylovich/angular/tags","blobs_url":"https://api.github.com/repos/DzmitryShylovich/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DzmitryShylovich/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DzmitryShylovich/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/DzmitryShylovich/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DzmitryShylovich/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/DzmitryShylovich/angular/languages","stargazers_url":"https://api.github.com/repos/DzmitryShylovich/angular/stargazers","contributors_url":"https://api.github.com/repos/DzmitryShylovich/angular/contributors","subscribers_url":"https://api.github.com/repos/DzmitryShylovich/angular/subscribers","subscription_url":"https://api.github.com/repos/DzmitryShylovich/angular/subscription","commits_url":"https://api.github.com/repos/DzmitryShylovich/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/DzmitryShylovich/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/DzmitryShylovich/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/DzmitryShylovich/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/DzmitryShylovich/angular/contents/{+path}","compare_url":"https://api.github.com/repos/DzmitryShylovich/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DzmitryShylovich/angular/merges","archive_url":"https://api.github.com/repos/DzmitryShylovich/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DzmitryShylovich/angular/downloads","issues_url":"https://api.github.com/repos/DzmitryShylovich/angular/issues{/number}","pulls_url":"https://api.github.com/repos/DzmitryShylovich/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/DzmitryShylovich/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/DzmitryShylovich/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DzmitryShylovich/angular/labels{/name}","releases_url":"https://api.github.com/repos/DzmitryShylovich/angular/releases{/id}","deployments_url":"https://api.github.com/repos/DzmitryShylovich/angular/deployments","created_at":"2016-04-13T10:34:06Z","updated_at":"2016-04-13T10:34:26Z","pushed_at":"2016-08-09T21:19:02Z","git_url":"git://github.com/DzmitryShylovich/angular.git","ssh_url":"git@github.com:DzmitryShylovich/angular.git","clone_url":"https://github.com/DzmitryShylovich/angular.git","svn_url":"https://github.com/DzmitryShylovich/angular","homepage":"https://angular.io","size":125150,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"c8da7e995ff75e29960ee527b1926f7a9d04ce5a","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-08-12T05:11:41Z","pushed_at":"2016-08-12T04:49:11Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":643326,"stargazers_count":14767,"watchers_count":14767,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3788,"mirror_url":null,"open_issues_count":1156,"forks":3788,"open_issues":1156,"watchers":14767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/10596"},"html":{"href":"https://github.com/angular/angular/pull/10596"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/10596"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/10596/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/10596/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/10596/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/b9754e622299d27e61ff4072892e21f0e3c42d69"}}}}
{"actor":{"display_login":"vicb"}}