{"action":"created","issue":{"url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/67","repository_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows","labels_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/67/comments","events_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/67/events","html_url":"https://github.com/mit-teaching-systems-lab/threeflows/pull/67","id":164155322,"number":67,"title":"Finishing up the refactoring of InstructionsCard","user":{"login":"david-rosales","id":1490352,"avatar_url":"https://avatars.githubusercontent.com/u/1490352?v=3","gravatar_id":"","url":"https://api.github.com/users/david-rosales","html_url":"https://github.com/david-rosales","followers_url":"https://api.github.com/users/david-rosales/followers","following_url":"https://api.github.com/users/david-rosales/following{/other_user}","gists_url":"https://api.github.com/users/david-rosales/gists{/gist_id}","starred_url":"https://api.github.com/users/david-rosales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-rosales/subscriptions","organizations_url":"https://api.github.com/users/david-rosales/orgs","repos_url":"https://api.github.com/users/david-rosales/repos","events_url":"https://api.github.com/users/david-rosales/events{/privacy}","received_events_url":"https://api.github.com/users/david-rosales/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-07-06T19:30:59Z","updated_at":"2016-07-15T21:35:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/pulls/67","html_url":"https://github.com/mit-teaching-systems-lab/threeflows/pull/67","diff_url":"https://github.com/mit-teaching-systems-lab/threeflows/pull/67.diff","patch_url":"https://github.com/mit-teaching-systems-lab/threeflows/pull/67.patch"},"body":"I moved most of the functions from inside `instructions_card.jsx` into `scaffolding_card.jsx`. I decided to leave a lot of the configuration as a state inside of the instructions card because I couldn't come up with a good idea of when to pass the state from within `scaffolding_card.jsx` to `instructions_card.jsx` as done with `instructions_card.jsx` to `experience_page.jsx`. Because the parameters from `scaffolding_card.jsx` are changed and instantly updated, whereas the configuration from `instructions_card.jsx` is only saved when the start button is pressed, `instructions_card.jsx`'s state gets changed with the new parameters from within `scaffolding_card.jsx` every time something gets updated or changed inside `scaffolding_card.jsx`."},"comment":{"url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/comments/233075670","html_url":"https://github.com/mit-teaching-systems-lab/threeflows/pull/67#issuecomment-233075670","issue_url":"https://api.github.com/repos/mit-teaching-systems-lab/threeflows/issues/67","id":233075670,"user":{"login":"kevinrobinson","id":1056957,"avatar_url":"https://avatars.githubusercontent.com/u/1056957?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinrobinson","html_url":"https://github.com/kevinrobinson","followers_url":"https://api.github.com/users/kevinrobinson/followers","following_url":"https://api.github.com/users/kevinrobinson/following{/other_user}","gists_url":"https://api.github.com/users/kevinrobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinrobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinrobinson/subscriptions","organizations_url":"https://api.github.com/users/kevinrobinson/orgs","repos_url":"https://api.github.com/users/kevinrobinson/repos","events_url":"https://api.github.com/users/kevinrobinson/events{/privacy}","received_events_url":"https://api.github.com/users/kevinrobinson/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T21:35:35Z","updated_at":"2016-07-15T21:35:35Z","body":"@david-rosales This is awesome work and great progress!  There's a lot of pieces in this refactoring and you've made the flow of state between components a lot more direct. :thumbsup:\r\n\r\nI left comments inline with more explanation, but here's the few steps I think we have left to finish this off!\r\n\r\n##### Remove state that isn't needed\r\n- [ ] `email` from experience_page state\r\n- [ ] `hasStarted` from experience_page state\r\n- [ ] `questions` from scaffolding_card state (it can be computed from other state)\r\n\r\n##### Clarify how a gameSession gets created\r\n- [ ] update `onSaveScaffoldingAndSession` so it creates a new `gameSession` from the pieces it's passed\r\n- [ ] update `onSave` so it only passes scaffodling, email and questions\r\n\r\n##### Cleanup\r\n- [ ] Remove methods from `scaffolding_card` that were extracted out\r\n\r\n"}}
{"actor":{"display_login":"kevinrobinson"}}