{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/64988432","id":64988432,"diff_hunk":"@@ -175,11 +198,28 @@ public FluidStack drain(int maxDrain, boolean doDrain)\n                 fluid = null;\n             }\n \n+            onContentsChanged();\n+\n             if (tile != null)\n             {\n                 FluidEvent.fireEvent(new FluidEvent.FluidDrainingEvent(fluid, tile.getWorld(), tile.getPos(), this, drained));\n             }\n         }\n         return stack;\n     }\n+\n+    public boolean canFill(Fluid fluid)","path":"src/main/java/net/minecraftforge/fluids/FluidTank.java","position":143,"original_position":143,"commit_id":"fb0a9a6941b2b95e93ce9b9ca56aee55edc23b09","original_commit_id":"fb0a9a6941b2b95e93ce9b9ca56aee55edc23b09","user":{"login":"asiekierka","id":113514,"avatar_url":"https://avatars.githubusercontent.com/u/113514?v=3","gravatar_id":"","url":"https://api.github.com/users/asiekierka","html_url":"https://github.com/asiekierka","followers_url":"https://api.github.com/users/asiekierka/followers","following_url":"https://api.github.com/users/asiekierka/following{/other_user}","gists_url":"https://api.github.com/users/asiekierka/gists{/gist_id}","starred_url":"https://api.github.com/users/asiekierka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asiekierka/subscriptions","organizations_url":"https://api.github.com/users/asiekierka/orgs","repos_url":"https://api.github.com/users/asiekierka/repos","events_url":"https://api.github.com/users/asiekierka/events{/privacy}","received_events_url":"https://api.github.com/users/asiekierka/received_events","type":"User","site_admin":false},"body":"Do we need canFill, when fill has a simulation parameter?","created_at":"2016-05-28T12:35:35Z","updated_at":"2016-05-28T12:35:35Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2923#discussion_r64988432","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2923","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/64988432"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/2923#discussion_r64988432"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2923"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2923","id":71798174,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2923","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2923.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2923.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2923","number":2923,"state":"open","locked":false,"title":"Add Fluid Capability","user":{"login":"mezz","id":916092,"avatar_url":"https://avatars.githubusercontent.com/u/916092?v=3","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"body":"Builds on the previous PR #2459 and fixes some bugs.\r\nAdds wrappers to turn every kind of legacy fluid handling into the new `IFluidHandler`.\r\nAdds methods in `FluidUtils` to handle common cases,\r\n\r\nI made a branch of Forestry to test out the legacy handling and new features.\r\nhttps://github.com/ForestryMC/ForestryMC/tree/fluid-capability\r\nThis helped me define better methods in Forge's `FluidUtils` to handle some more complicated cases cleanly.\r\nIf you test with Forestry, note that most machines will consume Forestry's filled capsules, cans, etc. This is intentional. They do not consume any other types of fluid container.\r\n\r\nI have not used `IFluidHandler.getTankInfo()` at all. It seems sort of useful, but in practice I'm not sure if it's needed or not. Maybe pipes have a need for it, they're the only thing I haven't really tried out.","created_at":"2016-05-28T09:59:45Z","updated_at":"2016-05-28T12:35:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31c98158c6d89e0ee4e4e5ed749a0278876f7480","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2923/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2923/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2923/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/fb0a9a6941b2b95e93ce9b9ca56aee55edc23b09","head":{"label":"mezz:fluid-capability","ref":"fluid-capability","sha":"fb0a9a6941b2b95e93ce9b9ca56aee55edc23b09","user":{"login":"mezz","id":916092,"avatar_url":"https://avatars.githubusercontent.com/u/916092?v=3","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"repo":{"id":22802638,"name":"MinecraftForge","full_name":"mezz/MinecraftForge","owner":{"login":"mezz","id":916092,"avatar_url":"https://avatars.githubusercontent.com/u/916092?v=3","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mezz/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/mezz/MinecraftForge","forks_url":"https://api.github.com/repos/mezz/MinecraftForge/forks","keys_url":"https://api.github.com/repos/mezz/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mezz/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mezz/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/mezz/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/mezz/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/mezz/MinecraftForge/events","assignees_url":"https://api.github.com/repos/mezz/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/mezz/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/mezz/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/mezz/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mezz/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mezz/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/mezz/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mezz/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/mezz/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/mezz/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/mezz/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/mezz/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/mezz/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/mezz/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/mezz/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/mezz/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/mezz/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/mezz/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/mezz/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mezz/MinecraftForge/merges","archive_url":"https://api.github.com/repos/mezz/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mezz/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/mezz/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/mezz/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/mezz/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/mezz/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mezz/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/mezz/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/mezz/MinecraftForge/deployments","created_at":"2014-08-10T05:48:41Z","updated_at":"2016-05-06T23:35:24Z","pushed_at":"2016-05-28T10:13:00Z","git_url":"git://github.com/mezz/MinecraftForge.git","ssh_url":"git@github.com:mezz/MinecraftForge.git","clone_url":"https://github.com/mezz/MinecraftForge.git","svn_url":"https://github.com/mezz/MinecraftForge","homepage":"","size":86587,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"MinecraftForge:1.9.4","ref":"1.9.4","sha":"e00a11be995b749be32fefc21b6fcbf72e46a241","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2016-05-27T16:43:56Z","pushed_at":"2016-05-28T11:12:23Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":149427,"stargazers_count":1396,"watchers_count":1396,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":775,"mirror_url":null,"open_issues_count":283,"forks":775,"open_issues":283,"watchers":1396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2923"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/2923"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2923"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2923/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2923/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2923/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/fb0a9a6941b2b95e93ce9b9ca56aee55edc23b09"}}}}
{"actor":{"display_login":"asiekierka"}}