{"action":"created","comment":{"url":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/comments/81286623","pull_request_review_id":2276372,"id":81286623,"diff_hunk":"@@ -70,3 +94,31 @@ def output_difference(self, example, got, optionflags):\n \n RENormalizing = OutputChecker\n \n+\n+def maybe_a_traceback(string):\n+    if not string:\n+        return None\n+\n+    lines = string.splitlines()\n+    last = lines[-1]\n+    words = last.split(' ')\n+    first = words[0]\n+    if not first.endswith(':'):\n+        return None\n+\n+    return lines, last, words, first\n+\n+\n+def strip_dottedname_from_traceback(string):\n+    # We might want to confirm more strictly were dealing with a traceback.","path":"src/zope/testing/renormalizing.py","position":73,"original_position":73,"commit_id":"f6cca5d2209f595f8d52ddf21435b73aaa23eb33","original_commit_id":"f6cca5d2209f595f8d52ddf21435b73aaa23eb33","user":{"login":"mgedmin","id":159967,"avatar_url":"https://avatars.githubusercontent.com/u/159967?v=3","gravatar_id":"","url":"https://api.github.com/users/mgedmin","html_url":"https://github.com/mgedmin","followers_url":"https://api.github.com/users/mgedmin/followers","following_url":"https://api.github.com/users/mgedmin/following{/other_user}","gists_url":"https://api.github.com/users/mgedmin/gists{/gist_id}","starred_url":"https://api.github.com/users/mgedmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgedmin/subscriptions","organizations_url":"https://api.github.com/users/mgedmin/orgs","repos_url":"https://api.github.com/users/mgedmin/repos","events_url":"https://api.github.com/users/mgedmin/events{/privacy}","received_events_url":"https://api.github.com/users/mgedmin/received_events","type":"User","site_admin":false},"body":"I'd prefer that.  See [doctest.py](https://github.com/python/cpython/blob/36ebdb1812fd7676f3a25f872158cc4a9503881a/Lib/doctest.py#L604-L615) for the *sigh* private regexp.  I think a simpler version that checks just the first line would suffice.","created_at":"2016-09-30T06:56:04Z","updated_at":"2016-09-30T07:00:15Z","html_url":"https://github.com/zopefoundation/zope.testing/pull/15#discussion_r81286623","pull_request_url":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/comments/81286623"},"html":{"href":"https://github.com/zopefoundation/zope.testing/pull/15#discussion_r81286623"},"pull_request":{"href":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/15","id":87347862,"html_url":"https://github.com/zopefoundation/zope.testing/pull/15","diff_url":"https://github.com/zopefoundation/zope.testing/pull/15.diff","patch_url":"https://github.com/zopefoundation/zope.testing/pull/15.patch","issue_url":"https://api.github.com/repos/zopefoundation/zope.testing/issues/15","number":15,"state":"open","locked":false,"title":"Doctest 2 to 3","user":{"login":"janwijbrand","id":530800,"avatar_url":"https://avatars.githubusercontent.com/u/530800?v=3","gravatar_id":"","url":"https://api.github.com/users/janwijbrand","html_url":"https://github.com/janwijbrand","followers_url":"https://api.github.com/users/janwijbrand/followers","following_url":"https://api.github.com/users/janwijbrand/following{/other_user}","gists_url":"https://api.github.com/users/janwijbrand/gists{/gist_id}","starred_url":"https://api.github.com/users/janwijbrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janwijbrand/subscriptions","organizations_url":"https://api.github.com/users/janwijbrand/orgs","repos_url":"https://api.github.com/users/janwijbrand/repos","events_url":"https://api.github.com/users/janwijbrand/events{/privacy}","received_events_url":"https://api.github.com/users/janwijbrand/received_events","type":"User","site_admin":false},"body":"Introduce optionflag ``EXCEPTION_2TO3`` to normalize exception class names in traceback output. In Python 3 they are displayed as the full dotted name. In Python 2 they are displayed as \"just\" the class name.  When running doctests in Python 3, the optionflag will not have any effect, however when running the same test in Python 2, the segments in the full dotted name leading up to the class name are stripped away from the \"expected\" string.","created_at":"2016-09-29T16:27:27Z","updated_at":"2016-09-30T07:00:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78e7b156577b69c3ad85b65101dd117609f19741","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/15/commits","review_comments_url":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/15/comments","review_comment_url":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zopefoundation/zope.testing/issues/15/comments","statuses_url":"https://api.github.com/repos/zopefoundation/zope.testing/statuses/f6cca5d2209f595f8d52ddf21435b73aaa23eb33","head":{"label":"zopefoundation:doctest-2-to-3","ref":"doctest-2-to-3","sha":"f6cca5d2209f595f8d52ddf21435b73aaa23eb33","user":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":7491615,"name":"zope.testing","full_name":"zopefoundation/zope.testing","owner":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zopefoundation/zope.testing","description":"","fork":false,"url":"https://api.github.com/repos/zopefoundation/zope.testing","forks_url":"https://api.github.com/repos/zopefoundation/zope.testing/forks","keys_url":"https://api.github.com/repos/zopefoundation/zope.testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zopefoundation/zope.testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zopefoundation/zope.testing/teams","hooks_url":"https://api.github.com/repos/zopefoundation/zope.testing/hooks","issue_events_url":"https://api.github.com/repos/zopefoundation/zope.testing/issues/events{/number}","events_url":"https://api.github.com/repos/zopefoundation/zope.testing/events","assignees_url":"https://api.github.com/repos/zopefoundation/zope.testing/assignees{/user}","branches_url":"https://api.github.com/repos/zopefoundation/zope.testing/branches{/branch}","tags_url":"https://api.github.com/repos/zopefoundation/zope.testing/tags","blobs_url":"https://api.github.com/repos/zopefoundation/zope.testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zopefoundation/zope.testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zopefoundation/zope.testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/zopefoundation/zope.testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zopefoundation/zope.testing/statuses/{sha}","languages_url":"https://api.github.com/repos/zopefoundation/zope.testing/languages","stargazers_url":"https://api.github.com/repos/zopefoundation/zope.testing/stargazers","contributors_url":"https://api.github.com/repos/zopefoundation/zope.testing/contributors","subscribers_url":"https://api.github.com/repos/zopefoundation/zope.testing/subscribers","subscription_url":"https://api.github.com/repos/zopefoundation/zope.testing/subscription","commits_url":"https://api.github.com/repos/zopefoundation/zope.testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/zopefoundation/zope.testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/zopefoundation/zope.testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/zopefoundation/zope.testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/zopefoundation/zope.testing/contents/{+path}","compare_url":"https://api.github.com/repos/zopefoundation/zope.testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zopefoundation/zope.testing/merges","archive_url":"https://api.github.com/repos/zopefoundation/zope.testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zopefoundation/zope.testing/downloads","issues_url":"https://api.github.com/repos/zopefoundation/zope.testing/issues{/number}","pulls_url":"https://api.github.com/repos/zopefoundation/zope.testing/pulls{/number}","milestones_url":"https://api.github.com/repos/zopefoundation/zope.testing/milestones{/number}","notifications_url":"https://api.github.com/repos/zopefoundation/zope.testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zopefoundation/zope.testing/labels{/name}","releases_url":"https://api.github.com/repos/zopefoundation/zope.testing/releases{/id}","deployments_url":"https://api.github.com/repos/zopefoundation/zope.testing/deployments","created_at":"2013-01-07T23:05:37Z","updated_at":"2016-03-24T01:51:17Z","pushed_at":"2016-09-29T16:27:27Z","git_url":"git://github.com/zopefoundation/zope.testing.git","ssh_url":"git@github.com:zopefoundation/zope.testing.git","clone_url":"https://github.com/zopefoundation/zope.testing.git","svn_url":"https://github.com/zopefoundation/zope.testing","homepage":null,"size":721,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"zopefoundation:master","ref":"master","sha":"fcb30778408f00b18fe580ef4aaee9d3df4749b9","user":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":7491615,"name":"zope.testing","full_name":"zopefoundation/zope.testing","owner":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zopefoundation/zope.testing","description":"","fork":false,"url":"https://api.github.com/repos/zopefoundation/zope.testing","forks_url":"https://api.github.com/repos/zopefoundation/zope.testing/forks","keys_url":"https://api.github.com/repos/zopefoundation/zope.testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zopefoundation/zope.testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zopefoundation/zope.testing/teams","hooks_url":"https://api.github.com/repos/zopefoundation/zope.testing/hooks","issue_events_url":"https://api.github.com/repos/zopefoundation/zope.testing/issues/events{/number}","events_url":"https://api.github.com/repos/zopefoundation/zope.testing/events","assignees_url":"https://api.github.com/repos/zopefoundation/zope.testing/assignees{/user}","branches_url":"https://api.github.com/repos/zopefoundation/zope.testing/branches{/branch}","tags_url":"https://api.github.com/repos/zopefoundation/zope.testing/tags","blobs_url":"https://api.github.com/repos/zopefoundation/zope.testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zopefoundation/zope.testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zopefoundation/zope.testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/zopefoundation/zope.testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zopefoundation/zope.testing/statuses/{sha}","languages_url":"https://api.github.com/repos/zopefoundation/zope.testing/languages","stargazers_url":"https://api.github.com/repos/zopefoundation/zope.testing/stargazers","contributors_url":"https://api.github.com/repos/zopefoundation/zope.testing/contributors","subscribers_url":"https://api.github.com/repos/zopefoundation/zope.testing/subscribers","subscription_url":"https://api.github.com/repos/zopefoundation/zope.testing/subscription","commits_url":"https://api.github.com/repos/zopefoundation/zope.testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/zopefoundation/zope.testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/zopefoundation/zope.testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/zopefoundation/zope.testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/zopefoundation/zope.testing/contents/{+path}","compare_url":"https://api.github.com/repos/zopefoundation/zope.testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zopefoundation/zope.testing/merges","archive_url":"https://api.github.com/repos/zopefoundation/zope.testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zopefoundation/zope.testing/downloads","issues_url":"https://api.github.com/repos/zopefoundation/zope.testing/issues{/number}","pulls_url":"https://api.github.com/repos/zopefoundation/zope.testing/pulls{/number}","milestones_url":"https://api.github.com/repos/zopefoundation/zope.testing/milestones{/number}","notifications_url":"https://api.github.com/repos/zopefoundation/zope.testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zopefoundation/zope.testing/labels{/name}","releases_url":"https://api.github.com/repos/zopefoundation/zope.testing/releases{/id}","deployments_url":"https://api.github.com/repos/zopefoundation/zope.testing/deployments","created_at":"2013-01-07T23:05:37Z","updated_at":"2016-03-24T01:51:17Z","pushed_at":"2016-09-29T16:27:27Z","git_url":"git://github.com/zopefoundation/zope.testing.git","ssh_url":"git@github.com:zopefoundation/zope.testing.git","clone_url":"https://github.com/zopefoundation/zope.testing.git","svn_url":"https://github.com/zopefoundation/zope.testing","homepage":null,"size":721,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/15"},"html":{"href":"https://github.com/zopefoundation/zope.testing/pull/15"},"issue":{"href":"https://api.github.com/repos/zopefoundation/zope.testing/issues/15"},"comments":{"href":"https://api.github.com/repos/zopefoundation/zope.testing/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zopefoundation/zope.testing/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/zopefoundation/zope.testing/statuses/f6cca5d2209f595f8d52ddf21435b73aaa23eb33"}}}}
{"actor":{"display_login":"mgedmin"}}