{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/unit-rates/issues/130","repository_url":"https://api.github.com/repos/phetsims/unit-rates","labels_url":"https://api.github.com/repos/phetsims/unit-rates/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/unit-rates/issues/130/comments","events_url":"https://api.github.com/repos/phetsims/unit-rates/issues/130/events","html_url":"https://github.com/phetsims/unit-rates/issues/130","id":183125794,"number":130,"title":"Semi-duplication of NumberEntryControl in KeypadPanelNode","user":{"login":"jonathanolson","id":480878,"avatar_url":"https://avatars.githubusercontent.com/u/480878?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanolson","html_url":"https://github.com/jonathanolson","followers_url":"https://api.github.com/users/jonathanolson/followers","following_url":"https://api.github.com/users/jonathanolson/following{/other_user}","gists_url":"https://api.github.com/users/jonathanolson/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanolson/subscriptions","organizations_url":"https://api.github.com/users/jonathanolson/orgs","repos_url":"https://api.github.com/users/jonathanolson/repos","events_url":"https://api.github.com/users/jonathanolson/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanolson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jbphet","id":3082831,"avatar_url":"https://avatars.githubusercontent.com/u/3082831?v=3","gravatar_id":"","url":"https://api.github.com/users/jbphet","html_url":"https://github.com/jbphet","followers_url":"https://api.github.com/users/jbphet/followers","following_url":"https://api.github.com/users/jbphet/following{/other_user}","gists_url":"https://api.github.com/users/jbphet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbphet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbphet/subscriptions","organizations_url":"https://api.github.com/users/jbphet/orgs","repos_url":"https://api.github.com/users/jbphet/repos","events_url":"https://api.github.com/users/jbphet/events{/privacy}","received_events_url":"https://api.github.com/users/jbphet/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbphet","id":3082831,"avatar_url":"https://avatars.githubusercontent.com/u/3082831?v=3","gravatar_id":"","url":"https://api.github.com/users/jbphet","html_url":"https://github.com/jbphet","followers_url":"https://api.github.com/users/jbphet/followers","following_url":"https://api.github.com/users/jbphet/following{/other_user}","gists_url":"https://api.github.com/users/jbphet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbphet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbphet/subscriptions","organizations_url":"https://api.github.com/users/jbphet/orgs","repos_url":"https://api.github.com/users/jbphet/repos","events_url":"https://api.github.com/users/jbphet/events{/privacy}","received_events_url":"https://api.github.com/users/jbphet/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-10-14T18:57:34Z","updated_at":"2016-10-19T20:41:03Z","closed_at":null,"body":"@jbphet noted a lot of similarity in https://github.com/phetsims/making-tens/issues/76, but there were enough differences that I didn't factor out any of KeypadPanelNode's behavior into scenery-phet's NumberEntryControl.\r\n\r\nShould certain code be shared here?"},"comment":{"url":"https://api.github.com/repos/phetsims/unit-rates/issues/comments/254934332","html_url":"https://github.com/phetsims/unit-rates/issues/130#issuecomment-254934332","issue_url":"https://api.github.com/repos/phetsims/unit-rates/issues/130","id":254934332,"user":{"login":"jbphet","id":3082831,"avatar_url":"https://avatars.githubusercontent.com/u/3082831?v=3","gravatar_id":"","url":"https://api.github.com/users/jbphet","html_url":"https://github.com/jbphet","followers_url":"https://api.github.com/users/jbphet/followers","following_url":"https://api.github.com/users/jbphet/following{/other_user}","gists_url":"https://api.github.com/users/jbphet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbphet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbphet/subscriptions","organizations_url":"https://api.github.com/users/jbphet/orgs","repos_url":"https://api.github.com/users/jbphet/repos","events_url":"https://api.github.com/users/jbphet/events{/privacy}","received_events_url":"https://api.github.com/users/jbphet/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T20:41:03Z","updated_at":"2016-10-19T20:41:03Z","body":"In response to https://github.com/phetsims/unit-rates/issues/130#issuecomment-254684114, I think we should keep NumberKeypad 'pure' and not add a display or an entry button.  Even though we have no usages now without some sort of 'Enter' button, I could easily envision a situation in the future where we want this.  I would therefore favor the idea of a subtype with the enter button and display, but I think that is essentially what NumberEntryControl and KeypadPanelNode essentially are (not subtypes, strictly speaking, but controls that put the keypad, display, and enter button together through composition).\r\n\r\nI just looked at unit-rates.KeypadPanelNode, and I think @jonathanolson may have been discouraged from combining this with the others due to some differences in the API for setting and clearing listeners.  Looking at it (but not too deeply), I still feel like these could all be consolidated.  In other words, it seems like we could have one control with a readout, keypad, and enter button that could work for area-builder, making-tens, and unit rates and possible (as @pixelzoom noted above) arithmetic and projectile-motion too."}}
{"actor":{"display_login":"jbphet"}}