{"action":"created","comment":{"url":"https://api.github.com/repos/croscon/sw2/pulls/comments/87620666","pull_request_review_id":8229174,"id":87620666,"diff_hunk":"@@ -87,6 +87,14 @@ cleanup_docker_images:\n     - job_args:\n       - \"/usr/bin/docker rmi -f $(/usr/bin/docker images -q -f dangling=true)\"\n     - hours: 1\n+\n+# Cleanup docker volumes once an hour\n+cleanup_docker_volumes:\n+  schedule.present:\n+    - function: cmd.run\n+    - job_args:\n+      - \"/usr/bin/docker volume rm $(/usr/bin/docker volume ls -qf dangling=true)\"\n+    - hours: 1","path":"srv-salt/sw2/services/docker/latest.sls","position":11,"original_position":11,"commit_id":"1eb4aa2817b1e0d8be97eb1ebc07da1669e5e6c6","original_commit_id":"1eb4aa2817b1e0d8be97eb1ebc07da1669e5e6c6","user":{"login":"hjc1710","id":1062500,"avatar_url":"https://avatars.githubusercontent.com/u/1062500?v=3","gravatar_id":"","url":"https://api.github.com/users/hjc1710","html_url":"https://github.com/hjc1710","followers_url":"https://api.github.com/users/hjc1710/followers","following_url":"https://api.github.com/users/hjc1710/following{/other_user}","gists_url":"https://api.github.com/users/hjc1710/gists{/gist_id}","starred_url":"https://api.github.com/users/hjc1710/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjc1710/subscriptions","organizations_url":"https://api.github.com/users/hjc1710/orgs","repos_url":"https://api.github.com/users/hjc1710/repos","events_url":"https://api.github.com/users/hjc1710/events{/privacy}","received_events_url":"https://api.github.com/users/hjc1710/received_events","type":"User","site_admin":false},"body":"@garethgreenaway - deleting volumes makes me nervous, even if they're dangling. I'm mostly worried about a MySQL volume getting deleted and data getting lost. What's the confidence level around a removed dangling volume impacting a data container?\r\n\r\nI just tested this workflow on Weber Prod (NO idea why I picked prod, but it's not used...) and it lost my data volume. But I'm thinking that might be because of the salt state for my data container, because I'm noticing it was replaced around the time I was running those tasks.\r\n\r\nJust looking for your thoughts.","created_at":"2016-11-11T16:56:20Z","updated_at":"2016-11-11T16:56:20Z","html_url":"https://github.com/croscon/sw2/pull/187#discussion_r87620666","pull_request_url":"https://api.github.com/repos/croscon/sw2/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/croscon/sw2/pulls/comments/87620666"},"html":{"href":"https://github.com/croscon/sw2/pull/187#discussion_r87620666"},"pull_request":{"href":"https://api.github.com/repos/croscon/sw2/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/croscon/sw2/pulls/187","id":93341437,"html_url":"https://github.com/croscon/sw2/pull/187","diff_url":"https://github.com/croscon/sw2/pull/187.diff","patch_url":"https://github.com/croscon/sw2/pull/187.patch","issue_url":"https://api.github.com/repos/croscon/sw2/issues/187","number":187,"state":"open","locked":false,"title":"Docker Volume Cleanup","user":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars.githubusercontent.com/u/718525?v=3","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"body":"We already have the ability for Salt to routinely clear out old and unused Docker images, this addition will clear out old & unused Docker volumes as well.\r\n\r\n@hjc1710 Please review this PR and make sure I'm not missing anything obvious.  I tested it manually and it works, just want a second pair of eyes before rolling it out.","created_at":"2016-11-11T14:37:29Z","updated_at":"2016-11-11T16:56:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78afe87d5b678b7f79fd6ea7749df98ed3d1cea9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/croscon/sw2/pulls/187/commits","review_comments_url":"https://api.github.com/repos/croscon/sw2/pulls/187/comments","review_comment_url":"https://api.github.com/repos/croscon/sw2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/croscon/sw2/issues/187/comments","statuses_url":"https://api.github.com/repos/croscon/sw2/statuses/1eb4aa2817b1e0d8be97eb1ebc07da1669e5e6c6","head":{"label":"croscon:docker_volume_cleanup","ref":"docker_volume_cleanup","sha":"1eb4aa2817b1e0d8be97eb1ebc07da1669e5e6c6","user":{"login":"croscon","id":640218,"avatar_url":"https://avatars.githubusercontent.com/u/640218?v=3","gravatar_id":"","url":"https://api.github.com/users/croscon","html_url":"https://github.com/croscon","followers_url":"https://api.github.com/users/croscon/followers","following_url":"https://api.github.com/users/croscon/following{/other_user}","gists_url":"https://api.github.com/users/croscon/gists{/gist_id}","starred_url":"https://api.github.com/users/croscon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croscon/subscriptions","organizations_url":"https://api.github.com/users/croscon/orgs","repos_url":"https://api.github.com/users/croscon/repos","events_url":"https://api.github.com/users/croscon/events{/privacy}","received_events_url":"https://api.github.com/users/croscon/received_events","type":"Organization","site_admin":false},"repo":{"id":41426062,"name":"sw2","full_name":"croscon/sw2","owner":{"login":"croscon","id":640218,"avatar_url":"https://avatars.githubusercontent.com/u/640218?v=3","gravatar_id":"","url":"https://api.github.com/users/croscon","html_url":"https://github.com/croscon","followers_url":"https://api.github.com/users/croscon/followers","following_url":"https://api.github.com/users/croscon/following{/other_user}","gists_url":"https://api.github.com/users/croscon/gists{/gist_id}","starred_url":"https://api.github.com/users/croscon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croscon/subscriptions","organizations_url":"https://api.github.com/users/croscon/orgs","repos_url":"https://api.github.com/users/croscon/repos","events_url":"https://api.github.com/users/croscon/events{/privacy}","received_events_url":"https://api.github.com/users/croscon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/croscon/sw2","description":"SaltWerks 2.0","fork":false,"url":"https://api.github.com/repos/croscon/sw2","forks_url":"https://api.github.com/repos/croscon/sw2/forks","keys_url":"https://api.github.com/repos/croscon/sw2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/croscon/sw2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/croscon/sw2/teams","hooks_url":"https://api.github.com/repos/croscon/sw2/hooks","issue_events_url":"https://api.github.com/repos/croscon/sw2/issues/events{/number}","events_url":"https://api.github.com/repos/croscon/sw2/events","assignees_url":"https://api.github.com/repos/croscon/sw2/assignees{/user}","branches_url":"https://api.github.com/repos/croscon/sw2/branches{/branch}","tags_url":"https://api.github.com/repos/croscon/sw2/tags","blobs_url":"https://api.github.com/repos/croscon/sw2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/croscon/sw2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/croscon/sw2/git/refs{/sha}","trees_url":"https://api.github.com/repos/croscon/sw2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/croscon/sw2/statuses/{sha}","languages_url":"https://api.github.com/repos/croscon/sw2/languages","stargazers_url":"https://api.github.com/repos/croscon/sw2/stargazers","contributors_url":"https://api.github.com/repos/croscon/sw2/contributors","subscribers_url":"https://api.github.com/repos/croscon/sw2/subscribers","subscription_url":"https://api.github.com/repos/croscon/sw2/subscription","commits_url":"https://api.github.com/repos/croscon/sw2/commits{/sha}","git_commits_url":"https://api.github.com/repos/croscon/sw2/git/commits{/sha}","comments_url":"https://api.github.com/repos/croscon/sw2/comments{/number}","issue_comment_url":"https://api.github.com/repos/croscon/sw2/issues/comments{/number}","contents_url":"https://api.github.com/repos/croscon/sw2/contents/{+path}","compare_url":"https://api.github.com/repos/croscon/sw2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/croscon/sw2/merges","archive_url":"https://api.github.com/repos/croscon/sw2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/croscon/sw2/downloads","issues_url":"https://api.github.com/repos/croscon/sw2/issues{/number}","pulls_url":"https://api.github.com/repos/croscon/sw2/pulls{/number}","milestones_url":"https://api.github.com/repos/croscon/sw2/milestones{/number}","notifications_url":"https://api.github.com/repos/croscon/sw2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/croscon/sw2/labels{/name}","releases_url":"https://api.github.com/repos/croscon/sw2/releases{/id}","deployments_url":"https://api.github.com/repos/croscon/sw2/deployments","created_at":"2015-08-26T13:05:57Z","updated_at":"2016-10-25T02:11:07Z","pushed_at":"2016-11-11T14:37:29Z","git_url":"git://github.com/croscon/sw2.git","ssh_url":"git@github.com:croscon/sw2.git","clone_url":"https://github.com/croscon/sw2.git","svn_url":"https://github.com/croscon/sw2","homepage":null,"size":392,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"croscon:develop","ref":"develop","sha":"3bdf386c7e09b14e110b73584a1f987ebfcf6472","user":{"login":"croscon","id":640218,"avatar_url":"https://avatars.githubusercontent.com/u/640218?v=3","gravatar_id":"","url":"https://api.github.com/users/croscon","html_url":"https://github.com/croscon","followers_url":"https://api.github.com/users/croscon/followers","following_url":"https://api.github.com/users/croscon/following{/other_user}","gists_url":"https://api.github.com/users/croscon/gists{/gist_id}","starred_url":"https://api.github.com/users/croscon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croscon/subscriptions","organizations_url":"https://api.github.com/users/croscon/orgs","repos_url":"https://api.github.com/users/croscon/repos","events_url":"https://api.github.com/users/croscon/events{/privacy}","received_events_url":"https://api.github.com/users/croscon/received_events","type":"Organization","site_admin":false},"repo":{"id":41426062,"name":"sw2","full_name":"croscon/sw2","owner":{"login":"croscon","id":640218,"avatar_url":"https://avatars.githubusercontent.com/u/640218?v=3","gravatar_id":"","url":"https://api.github.com/users/croscon","html_url":"https://github.com/croscon","followers_url":"https://api.github.com/users/croscon/followers","following_url":"https://api.github.com/users/croscon/following{/other_user}","gists_url":"https://api.github.com/users/croscon/gists{/gist_id}","starred_url":"https://api.github.com/users/croscon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croscon/subscriptions","organizations_url":"https://api.github.com/users/croscon/orgs","repos_url":"https://api.github.com/users/croscon/repos","events_url":"https://api.github.com/users/croscon/events{/privacy}","received_events_url":"https://api.github.com/users/croscon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/croscon/sw2","description":"SaltWerks 2.0","fork":false,"url":"https://api.github.com/repos/croscon/sw2","forks_url":"https://api.github.com/repos/croscon/sw2/forks","keys_url":"https://api.github.com/repos/croscon/sw2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/croscon/sw2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/croscon/sw2/teams","hooks_url":"https://api.github.com/repos/croscon/sw2/hooks","issue_events_url":"https://api.github.com/repos/croscon/sw2/issues/events{/number}","events_url":"https://api.github.com/repos/croscon/sw2/events","assignees_url":"https://api.github.com/repos/croscon/sw2/assignees{/user}","branches_url":"https://api.github.com/repos/croscon/sw2/branches{/branch}","tags_url":"https://api.github.com/repos/croscon/sw2/tags","blobs_url":"https://api.github.com/repos/croscon/sw2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/croscon/sw2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/croscon/sw2/git/refs{/sha}","trees_url":"https://api.github.com/repos/croscon/sw2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/croscon/sw2/statuses/{sha}","languages_url":"https://api.github.com/repos/croscon/sw2/languages","stargazers_url":"https://api.github.com/repos/croscon/sw2/stargazers","contributors_url":"https://api.github.com/repos/croscon/sw2/contributors","subscribers_url":"https://api.github.com/repos/croscon/sw2/subscribers","subscription_url":"https://api.github.com/repos/croscon/sw2/subscription","commits_url":"https://api.github.com/repos/croscon/sw2/commits{/sha}","git_commits_url":"https://api.github.com/repos/croscon/sw2/git/commits{/sha}","comments_url":"https://api.github.com/repos/croscon/sw2/comments{/number}","issue_comment_url":"https://api.github.com/repos/croscon/sw2/issues/comments{/number}","contents_url":"https://api.github.com/repos/croscon/sw2/contents/{+path}","compare_url":"https://api.github.com/repos/croscon/sw2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/croscon/sw2/merges","archive_url":"https://api.github.com/repos/croscon/sw2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/croscon/sw2/downloads","issues_url":"https://api.github.com/repos/croscon/sw2/issues{/number}","pulls_url":"https://api.github.com/repos/croscon/sw2/pulls{/number}","milestones_url":"https://api.github.com/repos/croscon/sw2/milestones{/number}","notifications_url":"https://api.github.com/repos/croscon/sw2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/croscon/sw2/labels{/name}","releases_url":"https://api.github.com/repos/croscon/sw2/releases{/id}","deployments_url":"https://api.github.com/repos/croscon/sw2/deployments","created_at":"2015-08-26T13:05:57Z","updated_at":"2016-10-25T02:11:07Z","pushed_at":"2016-11-11T14:37:29Z","git_url":"git://github.com/croscon/sw2.git","ssh_url":"git@github.com:croscon/sw2.git","clone_url":"https://github.com/croscon/sw2.git","svn_url":"https://github.com/croscon/sw2","homepage":null,"size":392,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/croscon/sw2/pulls/187"},"html":{"href":"https://github.com/croscon/sw2/pull/187"},"issue":{"href":"https://api.github.com/repos/croscon/sw2/issues/187"},"comments":{"href":"https://api.github.com/repos/croscon/sw2/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/croscon/sw2/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/croscon/sw2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/croscon/sw2/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/croscon/sw2/statuses/1eb4aa2817b1e0d8be97eb1ebc07da1669e5e6c6"}}}}
{"actor":{"display_login":"hjc1710"}}