{"action":"created","comment":{"url":"https://api.github.com/repos/apache/zookeeper/pulls/comments/80002635","id":80002635,"diff_hunk":"@@ -99,11 +100,15 @@ public void close() {\n                         + Long.toHexString(sessionId));\n             }\n \n-            synchronized (factory.ipMap) {\n-                Set<NettyServerCnxn> s =\n-                    factory.ipMap.get(((InetSocketAddress)channel\n-                            .getRemoteAddress()).getAddress());\n-                s.remove(this);\n+            InetAddress address = ((InetSocketAddress) channel.getRemoteAddress()).getAddress();\n+            Set<NettyServerCnxn> s = factory.ipMap.get(address);","path":"src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java","position":18,"original_position":18,"commit_id":"186bfb141d701362015f02f7d35515cf5b542e83","original_commit_id":"186bfb141d701362015f02f7d35515cf5b542e83","user":{"login":"fpj","id":572920,"avatar_url":"https://avatars.githubusercontent.com/u/572920?v=3","gravatar_id":"","url":"https://api.github.com/users/fpj","html_url":"https://github.com/fpj","followers_url":"https://api.github.com/users/fpj/followers","following_url":"https://api.github.com/users/fpj/following{/other_user}","gists_url":"https://api.github.com/users/fpj/gists{/gist_id}","starred_url":"https://api.github.com/users/fpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpj/subscriptions","organizations_url":"https://api.github.com/users/fpj/orgs","repos_url":"https://api.github.com/users/fpj/repos","events_url":"https://api.github.com/users/fpj/events{/privacy}","received_events_url":"https://api.github.com/users/fpj/received_events","type":"User","site_admin":false},"body":"This management of the `ipMap` looks like something that should be done by the factory, not the connection. should we move this logic to the factory?","created_at":"2016-09-22T09:20:29Z","updated_at":"2016-09-22T09:20:29Z","html_url":"https://github.com/apache/zookeeper/pull/77#discussion_r80002635","pull_request_url":"https://api.github.com/repos/apache/zookeeper/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/comments/80002635"},"html":{"href":"https://github.com/apache/zookeeper/pull/77#discussion_r80002635"},"pull_request":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/apache/zookeeper/pulls/77","id":80895717,"html_url":"https://github.com/apache/zookeeper/pull/77","diff_url":"https://github.com/apache/zookeeper/pull/77.diff","patch_url":"https://github.com/apache/zookeeper/pull/77.patch","issue_url":"https://api.github.com/repos/apache/zookeeper/issues/77","number":77,"state":"open","locked":false,"title":"ZOOKEEPER-2280: NettyServerCnxnFactory doesn't honor maxClientCnxns p…","user":{"login":"eribeiro","id":116156,"avatar_url":"https://avatars.githubusercontent.com/u/116156?v=3","gravatar_id":"","url":"https://api.github.com/users/eribeiro","html_url":"https://github.com/eribeiro","followers_url":"https://api.github.com/users/eribeiro/followers","following_url":"https://api.github.com/users/eribeiro/following{/other_user}","gists_url":"https://api.github.com/users/eribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/eribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eribeiro/subscriptions","organizations_url":"https://api.github.com/users/eribeiro/orgs","repos_url":"https://api.github.com/users/eribeiro/repos","events_url":"https://api.github.com/users/eribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/eribeiro/received_events","type":"User","site_admin":false},"body":"…aram","created_at":"2016-08-11T02:05:02Z","updated_at":"2016-09-22T09:32:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e1c5ff7a03fc9d0afb3638e5aa95dbc7e782201","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/zookeeper/pulls/77/commits","review_comments_url":"https://api.github.com/repos/apache/zookeeper/pulls/77/comments","review_comment_url":"https://api.github.com/repos/apache/zookeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/zookeeper/issues/77/comments","statuses_url":"https://api.github.com/repos/apache/zookeeper/statuses/186bfb141d701362015f02f7d35515cf5b542e83","head":{"label":"eribeiro:ZOOKEEPER-2280","ref":"ZOOKEEPER-2280","sha":"186bfb141d701362015f02f7d35515cf5b542e83","user":{"login":"eribeiro","id":116156,"avatar_url":"https://avatars.githubusercontent.com/u/116156?v=3","gravatar_id":"","url":"https://api.github.com/users/eribeiro","html_url":"https://github.com/eribeiro","followers_url":"https://api.github.com/users/eribeiro/followers","following_url":"https://api.github.com/users/eribeiro/following{/other_user}","gists_url":"https://api.github.com/users/eribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/eribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eribeiro/subscriptions","organizations_url":"https://api.github.com/users/eribeiro/orgs","repos_url":"https://api.github.com/users/eribeiro/repos","events_url":"https://api.github.com/users/eribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/eribeiro/received_events","type":"User","site_admin":false},"repo":{"id":43274176,"name":"zookeeper","full_name":"eribeiro/zookeeper","owner":{"login":"eribeiro","id":116156,"avatar_url":"https://avatars.githubusercontent.com/u/116156?v=3","gravatar_id":"","url":"https://api.github.com/users/eribeiro","html_url":"https://github.com/eribeiro","followers_url":"https://api.github.com/users/eribeiro/followers","following_url":"https://api.github.com/users/eribeiro/following{/other_user}","gists_url":"https://api.github.com/users/eribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/eribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eribeiro/subscriptions","organizations_url":"https://api.github.com/users/eribeiro/orgs","repos_url":"https://api.github.com/users/eribeiro/repos","events_url":"https://api.github.com/users/eribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/eribeiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eribeiro/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":true,"url":"https://api.github.com/repos/eribeiro/zookeeper","forks_url":"https://api.github.com/repos/eribeiro/zookeeper/forks","keys_url":"https://api.github.com/repos/eribeiro/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eribeiro/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eribeiro/zookeeper/teams","hooks_url":"https://api.github.com/repos/eribeiro/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/eribeiro/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/eribeiro/zookeeper/events","assignees_url":"https://api.github.com/repos/eribeiro/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/eribeiro/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/eribeiro/zookeeper/tags","blobs_url":"https://api.github.com/repos/eribeiro/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eribeiro/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eribeiro/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/eribeiro/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eribeiro/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/eribeiro/zookeeper/languages","stargazers_url":"https://api.github.com/repos/eribeiro/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/eribeiro/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/eribeiro/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/eribeiro/zookeeper/subscription","commits_url":"https://api.github.com/repos/eribeiro/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/eribeiro/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/eribeiro/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/eribeiro/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/eribeiro/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/eribeiro/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eribeiro/zookeeper/merges","archive_url":"https://api.github.com/repos/eribeiro/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eribeiro/zookeeper/downloads","issues_url":"https://api.github.com/repos/eribeiro/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/eribeiro/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/eribeiro/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/eribeiro/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eribeiro/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/eribeiro/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/eribeiro/zookeeper/deployments","created_at":"2015-09-28T01:48:50Z","updated_at":"2016-07-03T13:47:01Z","pushed_at":"2016-09-09T23:14:03Z","git_url":"git://github.com/eribeiro/zookeeper.git","ssh_url":"git@github.com:eribeiro/zookeeper.git","clone_url":"https://github.com/eribeiro/zookeeper.git","svn_url":"https://github.com/eribeiro/zookeeper","homepage":null,"size":25818,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"c1b496442130b8b5c3795c7efcb9020de58dd698","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":160999,"name":"zookeeper","full_name":"apache/zookeeper","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":false,"url":"https://api.github.com/repos/apache/zookeeper","forks_url":"https://api.github.com/repos/apache/zookeeper/forks","keys_url":"https://api.github.com/repos/apache/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/zookeeper/teams","hooks_url":"https://api.github.com/repos/apache/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/zookeeper/events","assignees_url":"https://api.github.com/repos/apache/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/zookeeper/tags","blobs_url":"https://api.github.com/repos/apache/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/zookeeper/languages","stargazers_url":"https://api.github.com/repos/apache/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/zookeeper/subscription","commits_url":"https://api.github.com/repos/apache/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/zookeeper/merges","archive_url":"https://api.github.com/repos/apache/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/zookeeper/downloads","issues_url":"https://api.github.com/repos/apache/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/zookeeper/deployments","created_at":"2009-03-27T15:41:56Z","updated_at":"2016-09-22T07:28:04Z","pushed_at":"2016-09-21T15:22:54Z","git_url":"git://github.com/apache/zookeeper.git","ssh_url":"git@github.com:apache/zookeeper.git","clone_url":"https://github.com/apache/zookeeper.git","svn_url":"https://github.com/apache/zookeeper","homepage":null,"size":45914,"stargazers_count":2068,"watchers_count":2068,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1539,"mirror_url":"git://git.apache.org/zookeeper.git","open_issues_count":58,"forks":1539,"open_issues":58,"watchers":2068,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/77"},"html":{"href":"https://github.com/apache/zookeeper/pull/77"},"issue":{"href":"https://api.github.com/repos/apache/zookeeper/issues/77"},"comments":{"href":"https://api.github.com/repos/apache/zookeeper/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/apache/zookeeper/statuses/186bfb141d701362015f02f7d35515cf5b542e83"}}}}
{"actor":{"display_login":"fpj"}}