{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/john-travoltage/issues/112","repository_url":"https://api.github.com/repos/phetsims/john-travoltage","labels_url":"https://api.github.com/repos/phetsims/john-travoltage/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/john-travoltage/issues/112/comments","events_url":"https://api.github.com/repos/phetsims/john-travoltage/issues/112/events","html_url":"https://github.com/phetsims/john-travoltage/issues/112","id":167217635,"number":112,"title":"HTML in danger of being overwritten","user":{"login":"samreid","id":679486,"avatar_url":"https://avatars.githubusercontent.com/u/679486?v=3","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phetsims/john-travoltage/labels/dev:a11y","name":"dev:a11y","color":"008080"}],"state":"open","locked":false,"assignee":{"login":"jessegreenberg","id":6396244,"avatar_url":"https://avatars.githubusercontent.com/u/6396244?v=3","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false},"assignees":[{"login":"jessegreenberg","id":6396244,"avatar_url":"https://avatars.githubusercontent.com/u/6396244?v=3","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-07-24T05:15:42Z","updated_at":"2016-07-25T20:24:23Z","closed_at":null,"body":"I noticed that john-travoltage_en.html has the following added html:\r\n\r\n```html\r\n<p id=\"john-travoltage-alert\" role=\"alert\"></p>\r\n<p id=\"john-travoltage-status\" role=\"status\" aria-live=\"polite\" aria-atomic=\"true\"></p>\r\n```\r\n\r\nThis would be eliminated if someone ran the `grunt generate-development-html` task.  Perhaps it would be safer to (a) generate those dom elements programmatically from JS or (b) change the development-html template to include that for every sim if it is ready for production."},"comment":{"url":"https://api.github.com/repos/phetsims/john-travoltage/issues/comments/235073206","html_url":"https://github.com/phetsims/john-travoltage/issues/112#issuecomment-235073206","issue_url":"https://api.github.com/repos/phetsims/john-travoltage/issues/112","id":235073206,"user":{"login":"samreid","id":679486,"avatar_url":"https://avatars.githubusercontent.com/u/679486?v=3","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T20:24:22Z","updated_at":"2016-07-25T20:24:22Z","body":"> Unfortunately, screen readers don't observe 'aria-live' elements that are added dynamcially, they are only able to listen for changes to elements that exist on the page on load.\r\n\r\nThat is interesting, I wouldn't have guessed that.\r\n\r\nIn that case, could these divs be given more general names?  They are currently:\r\n\r\n```html\r\n<p id=\"john-travoltage-alert\" role=\"alert\"></p>\r\n<p id=\"john-travoltage-status\" role=\"status\" aria-live=\"polite\" aria-atomic=\"true\"></p>\r\n```\r\n\r\nWhat if it was something that could be used for every simulation:\r\n\r\n```html\r\n<p id=\"phet-accessibility-alert\" role=\"alert\"></p>\r\n<p id=\"phet-accessibility-status\" role=\"status\" aria-live=\"polite\" aria-atomic=\"true\"></p>\r\n```\r\n\r\nDo these elements have appropriate CSS so it won't disrupt any of the other dom elements?  If so, we could work on moving this into the general template."}}
{"actor":{"display_login":"samreid"}}