{"action":"created","comment":{"url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/comments/72683912","id":72683912,"diff_hunk":"@@ -1,15 +1,12 @@\n # Ember FastBoot\n \n-An Ember CLI addon that allows you to render and serve Ember.js apps on\n-the server. Using FastBoot, you can serve rendered HTML to browsers and\n-other clients without requiring them to download JavaScript assets.\n+An Ember CLI Addon that allows you to render and serve Ember.js apps on the server. Using FastBoot, you can serve rendered HTML to browsers and other clients without requiring them to download JavaScript assets.\n \n-Currently, the set of Ember applications supported is extremely limited.\n-As we fix more issues, we expect that set to grow rapidly. See [Known\n-Limitations](#known-limitations) below for a full-list.\n+## How It Works\n \n-The bottom line is that you should not (yet) expect to install this add-on in\n-your production app and have FastBoot work.\n+FastBoot works by creating a Node virtual [sandbox](https://github.com/ember-fastboot/fastboot/blob/master/lib/ember-app.js#L50-L75) and [executing](https://github.com/ember-fastboot/fastboot/blob/master/lib/ember-app.js#L165-L232) your Ember Application within it.\n+\n+Most Ember applications should work out of the box. However, there are some idiomatic patterns of design that you have to be sure to follow. See [Known Limitations](#known-limitations) below for a full-list.","path":"README.md","position":17,"original_position":17,"commit_id":"cba00f211b018ee0834cd61673a706700c9b4638","original_commit_id":"cba00f211b018ee0834cd61673a706700c9b4638","user":{"login":"arjansingh","id":1598641,"avatar_url":"https://avatars.githubusercontent.com/u/1598641?v=3","gravatar_id":"","url":"https://api.github.com/users/arjansingh","html_url":"https://github.com/arjansingh","followers_url":"https://api.github.com/users/arjansingh/followers","following_url":"https://api.github.com/users/arjansingh/following{/other_user}","gists_url":"https://api.github.com/users/arjansingh/gists{/gist_id}","starred_url":"https://api.github.com/users/arjansingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjansingh/subscriptions","organizations_url":"https://api.github.com/users/arjansingh/orgs","repos_url":"https://api.github.com/users/arjansingh/repos","events_url":"https://api.github.com/users/arjansingh/events{/privacy}","received_events_url":"https://api.github.com/users/arjansingh/received_events","type":"User","site_admin":false},"body":"My suggested text:\r\n\r\n> Most Ember applications should work out of the box. However, there are some patterns that you be sure should follow to to guarantee that your application is fully FastBoot compatible. See [Known Limitations](#known-limitations) below for a full-list.","created_at":"2016-07-28T19:12:19Z","updated_at":"2016-07-28T19:12:19Z","html_url":"https://github.com/ember-fastboot/ember-cli-fastboot/pull/240#discussion_r72683912","pull_request_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/240","_links":{"self":{"href":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/comments/72683912"},"html":{"href":"https://github.com/ember-fastboot/ember-cli-fastboot/pull/240#discussion_r72683912"},"pull_request":{"href":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/240"}}},"pull_request":{"url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/240","id":79141705,"html_url":"https://github.com/ember-fastboot/ember-cli-fastboot/pull/240","diff_url":"https://github.com/ember-fastboot/ember-cli-fastboot/pull/240.diff","patch_url":"https://github.com/ember-fastboot/ember-cli-fastboot/pull/240.patch","issue_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/issues/240","number":240,"state":"open","locked":false,"title":"README Cleanup - Draft","user":{"login":"arjansingh","id":1598641,"avatar_url":"https://avatars.githubusercontent.com/u/1598641?v=3","gravatar_id":"","url":"https://api.github.com/users/arjansingh","html_url":"https://github.com/arjansingh","followers_url":"https://api.github.com/users/arjansingh/followers","following_url":"https://api.github.com/users/arjansingh/following{/other_user}","gists_url":"https://api.github.com/users/arjansingh/gists{/gist_id}","starred_url":"https://api.github.com/users/arjansingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjansingh/subscriptions","organizations_url":"https://api.github.com/users/arjansingh/orgs","repos_url":"https://api.github.com/users/arjansingh/repos","events_url":"https://api.github.com/users/arjansingh/events{/privacy}","received_events_url":"https://api.github.com/users/arjansingh/received_events","type":"User","site_admin":false},"body":"Still chugging along with this, but I figure early feedback is better than late feedback.\r\n\r\nI have gone over every section up to \"Disabling incompatible dependencies\".\r\n\r\nI still need to add FastBoot Request documentation also. Feedback is welcome. I will pick up again tomorrow.","created_at":"2016-07-28T06:14:21Z","updated_at":"2016-07-28T19:12:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52630bb4e838cb855a18c476b27cfa97dfcc856b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/240/commits","review_comments_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/240/comments","review_comment_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/issues/240/comments","statuses_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/statuses/cba00f211b018ee0834cd61673a706700c9b4638","head":{"label":"arjansingh:readme","ref":"readme","sha":"cba00f211b018ee0834cd61673a706700c9b4638","user":{"login":"arjansingh","id":1598641,"avatar_url":"https://avatars.githubusercontent.com/u/1598641?v=3","gravatar_id":"","url":"https://api.github.com/users/arjansingh","html_url":"https://github.com/arjansingh","followers_url":"https://api.github.com/users/arjansingh/followers","following_url":"https://api.github.com/users/arjansingh/following{/other_user}","gists_url":"https://api.github.com/users/arjansingh/gists{/gist_id}","starred_url":"https://api.github.com/users/arjansingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjansingh/subscriptions","organizations_url":"https://api.github.com/users/arjansingh/orgs","repos_url":"https://api.github.com/users/arjansingh/repos","events_url":"https://api.github.com/users/arjansingh/events{/privacy}","received_events_url":"https://api.github.com/users/arjansingh/received_events","type":"User","site_admin":false},"repo":{"id":56889561,"name":"ember-cli-fastboot","full_name":"arjansingh/ember-cli-fastboot","owner":{"login":"arjansingh","id":1598641,"avatar_url":"https://avatars.githubusercontent.com/u/1598641?v=3","gravatar_id":"","url":"https://api.github.com/users/arjansingh","html_url":"https://github.com/arjansingh","followers_url":"https://api.github.com/users/arjansingh/followers","following_url":"https://api.github.com/users/arjansingh/following{/other_user}","gists_url":"https://api.github.com/users/arjansingh/gists{/gist_id}","starred_url":"https://api.github.com/users/arjansingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjansingh/subscriptions","organizations_url":"https://api.github.com/users/arjansingh/orgs","repos_url":"https://api.github.com/users/arjansingh/repos","events_url":"https://api.github.com/users/arjansingh/events{/privacy}","received_events_url":"https://api.github.com/users/arjansingh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arjansingh/ember-cli-fastboot","description":"Server-side rendering for Ember.js apps","fork":true,"url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot","forks_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/forks","keys_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/teams","hooks_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/hooks","issue_events_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/issues/events{/number}","events_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/events","assignees_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/assignees{/user}","branches_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/branches{/branch}","tags_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/tags","blobs_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/git/refs{/sha}","trees_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/statuses/{sha}","languages_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/languages","stargazers_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/stargazers","contributors_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/contributors","subscribers_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/subscribers","subscription_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/subscription","commits_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/commits{/sha}","git_commits_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/git/commits{/sha}","comments_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/comments{/number}","issue_comment_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/issues/comments{/number}","contents_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/contents/{+path}","compare_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/merges","archive_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/downloads","issues_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/issues{/number}","pulls_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/pulls{/number}","milestones_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/milestones{/number}","notifications_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/labels{/name}","releases_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/releases{/id}","deployments_url":"https://api.github.com/repos/arjansingh/ember-cli-fastboot/deployments","created_at":"2016-04-22T22:52:30Z","updated_at":"2016-04-22T22:52:30Z","pushed_at":"2016-07-28T06:12:26Z","git_url":"git://github.com/arjansingh/ember-cli-fastboot.git","ssh_url":"git@github.com:arjansingh/ember-cli-fastboot.git","clone_url":"https://github.com/arjansingh/ember-cli-fastboot.git","svn_url":"https://github.com/arjansingh/ember-cli-fastboot","homepage":"","size":301,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-fastboot:master","ref":"master","sha":"97d5056f874f81f39d209e0eb04a0a46cb69bc18","user":{"login":"ember-fastboot","id":14139940,"avatar_url":"https://avatars.githubusercontent.com/u/14139940?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-fastboot","html_url":"https://github.com/ember-fastboot","followers_url":"https://api.github.com/users/ember-fastboot/followers","following_url":"https://api.github.com/users/ember-fastboot/following{/other_user}","gists_url":"https://api.github.com/users/ember-fastboot/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-fastboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-fastboot/subscriptions","organizations_url":"https://api.github.com/users/ember-fastboot/orgs","repos_url":"https://api.github.com/users/ember-fastboot/repos","events_url":"https://api.github.com/users/ember-fastboot/events{/privacy}","received_events_url":"https://api.github.com/users/ember-fastboot/received_events","type":"Organization","site_admin":false},"repo":{"id":29309660,"name":"ember-cli-fastboot","full_name":"ember-fastboot/ember-cli-fastboot","owner":{"login":"ember-fastboot","id":14139940,"avatar_url":"https://avatars.githubusercontent.com/u/14139940?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-fastboot","html_url":"https://github.com/ember-fastboot","followers_url":"https://api.github.com/users/ember-fastboot/followers","following_url":"https://api.github.com/users/ember-fastboot/following{/other_user}","gists_url":"https://api.github.com/users/ember-fastboot/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-fastboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-fastboot/subscriptions","organizations_url":"https://api.github.com/users/ember-fastboot/orgs","repos_url":"https://api.github.com/users/ember-fastboot/repos","events_url":"https://api.github.com/users/ember-fastboot/events{/privacy}","received_events_url":"https://api.github.com/users/ember-fastboot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-fastboot/ember-cli-fastboot","description":"Server-side rendering for Ember.js apps","fork":false,"url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot","forks_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/forks","keys_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/teams","hooks_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/hooks","issue_events_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/issues/events{/number}","events_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/events","assignees_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/assignees{/user}","branches_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/branches{/branch}","tags_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/tags","blobs_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/languages","stargazers_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/stargazers","contributors_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/contributors","subscribers_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/subscribers","subscription_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/subscription","commits_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/contents/{+path}","compare_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/merges","archive_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/downloads","issues_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/issues{/number}","pulls_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/labels{/name}","releases_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/releases{/id}","deployments_url":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/deployments","created_at":"2015-01-15T17:44:10Z","updated_at":"2016-07-28T01:45:20Z","pushed_at":"2016-07-28T16:37:21Z","git_url":"git://github.com/ember-fastboot/ember-cli-fastboot.git","ssh_url":"git@github.com:ember-fastboot/ember-cli-fastboot.git","clone_url":"https://github.com/ember-fastboot/ember-cli-fastboot.git","svn_url":"https://github.com/ember-fastboot/ember-cli-fastboot","homepage":"http://ember-fastboot.com/","size":371,"stargazers_count":665,"watchers_count":665,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":22,"forks":63,"open_issues":22,"watchers":665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/240"},"html":{"href":"https://github.com/ember-fastboot/ember-cli-fastboot/pull/240"},"issue":{"href":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/issues/240"},"comments":{"href":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/ember-fastboot/ember-cli-fastboot/statuses/cba00f211b018ee0834cd61673a706700c9b4638"}}}}
{"actor":{"display_login":"arjansingh"}}