{"action":"opened","number":2387,"pull_request":{"url":"https://api.github.com/repos/drush-ops/drush/pulls/2387","id":89023916,"html_url":"https://github.com/drush-ops/drush/pull/2387","diff_url":"https://github.com/drush-ops/drush/pull/2387.diff","patch_url":"https://github.com/drush-ops/drush/pull/2387.patch","issue_url":"https://api.github.com/repos/drush-ops/drush/issues/2387","number":2387,"state":"open","locked":false,"title":"#2183 Fixed .my.cnf messing up mysql connection + minor credential-leak fix","user":{"login":"reinier-vegter","id":4497866,"avatar_url":"https://avatars.githubusercontent.com/u/4497866?v=3","gravatar_id":"","url":"https://api.github.com/users/reinier-vegter","html_url":"https://github.com/reinier-vegter","followers_url":"https://api.github.com/users/reinier-vegter/followers","following_url":"https://api.github.com/users/reinier-vegter/following{/other_user}","gists_url":"https://api.github.com/users/reinier-vegter/gists{/gist_id}","starred_url":"https://api.github.com/users/reinier-vegter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinier-vegter/subscriptions","organizations_url":"https://api.github.com/users/reinier-vegter/orgs","repos_url":"https://api.github.com/users/reinier-vegter/repos","events_url":"https://api.github.com/users/reinier-vegter/events{/privacy}","received_events_url":"https://api.github.com/users/reinier-vegter/received_events","type":"User","site_admin":false},"body":"Please merge this PR, it fixes the problem where .my.cnf is used to connect to mysql.\r\nFurthermore, the filemode-option in drush_save_data_to_temp_file() provides a way to prevent credential leakage, since that seemed to be the whole point of using the --defaults-extra-file param.\r\nPrior to this commit the sql credentials were exposed in the open-to-anyone /tmp folder.\r\n\r\nCreated this on the 8.x branch, but maybe it's just possible to merge this 1:1 to the master branch (didn't check).","created_at":"2016-10-12T14:15:07Z","updated_at":"2016-10-12T14:15:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/drush-ops/drush/pulls/2387/commits","review_comments_url":"https://api.github.com/repos/drush-ops/drush/pulls/2387/comments","review_comment_url":"https://api.github.com/repos/drush-ops/drush/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drush-ops/drush/issues/2387/comments","statuses_url":"https://api.github.com/repos/drush-ops/drush/statuses/201c05ac3155ee8f9c07119c95a4946e428878e0","head":{"label":"reinier-vegter:8.x","ref":"8.x","sha":"201c05ac3155ee8f9c07119c95a4946e428878e0","user":{"login":"reinier-vegter","id":4497866,"avatar_url":"https://avatars.githubusercontent.com/u/4497866?v=3","gravatar_id":"","url":"https://api.github.com/users/reinier-vegter","html_url":"https://github.com/reinier-vegter","followers_url":"https://api.github.com/users/reinier-vegter/followers","following_url":"https://api.github.com/users/reinier-vegter/following{/other_user}","gists_url":"https://api.github.com/users/reinier-vegter/gists{/gist_id}","starred_url":"https://api.github.com/users/reinier-vegter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinier-vegter/subscriptions","organizations_url":"https://api.github.com/users/reinier-vegter/orgs","repos_url":"https://api.github.com/users/reinier-vegter/repos","events_url":"https://api.github.com/users/reinier-vegter/events{/privacy}","received_events_url":"https://api.github.com/users/reinier-vegter/received_events","type":"User","site_admin":false},"repo":{"id":70584639,"name":"drush","full_name":"reinier-vegter/drush","owner":{"login":"reinier-vegter","id":4497866,"avatar_url":"https://avatars.githubusercontent.com/u/4497866?v=3","gravatar_id":"","url":"https://api.github.com/users/reinier-vegter","html_url":"https://github.com/reinier-vegter","followers_url":"https://api.github.com/users/reinier-vegter/followers","following_url":"https://api.github.com/users/reinier-vegter/following{/other_user}","gists_url":"https://api.github.com/users/reinier-vegter/gists{/gist_id}","starred_url":"https://api.github.com/users/reinier-vegter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinier-vegter/subscriptions","organizations_url":"https://api.github.com/users/reinier-vegter/orgs","repos_url":"https://api.github.com/users/reinier-vegter/repos","events_url":"https://api.github.com/users/reinier-vegter/events{/privacy}","received_events_url":"https://api.github.com/users/reinier-vegter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reinier-vegter/drush","description":"Drush is a command-line shell and scripting interface for Drupal, a veritable Swiss Army knife designed to make life easier for those who spend their working hours hacking away at the command prompt.","fork":true,"url":"https://api.github.com/repos/reinier-vegter/drush","forks_url":"https://api.github.com/repos/reinier-vegter/drush/forks","keys_url":"https://api.github.com/repos/reinier-vegter/drush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reinier-vegter/drush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reinier-vegter/drush/teams","hooks_url":"https://api.github.com/repos/reinier-vegter/drush/hooks","issue_events_url":"https://api.github.com/repos/reinier-vegter/drush/issues/events{/number}","events_url":"https://api.github.com/repos/reinier-vegter/drush/events","assignees_url":"https://api.github.com/repos/reinier-vegter/drush/assignees{/user}","branches_url":"https://api.github.com/repos/reinier-vegter/drush/branches{/branch}","tags_url":"https://api.github.com/repos/reinier-vegter/drush/tags","blobs_url":"https://api.github.com/repos/reinier-vegter/drush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reinier-vegter/drush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reinier-vegter/drush/git/refs{/sha}","trees_url":"https://api.github.com/repos/reinier-vegter/drush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reinier-vegter/drush/statuses/{sha}","languages_url":"https://api.github.com/repos/reinier-vegter/drush/languages","stargazers_url":"https://api.github.com/repos/reinier-vegter/drush/stargazers","contributors_url":"https://api.github.com/repos/reinier-vegter/drush/contributors","subscribers_url":"https://api.github.com/repos/reinier-vegter/drush/subscribers","subscription_url":"https://api.github.com/repos/reinier-vegter/drush/subscription","commits_url":"https://api.github.com/repos/reinier-vegter/drush/commits{/sha}","git_commits_url":"https://api.github.com/repos/reinier-vegter/drush/git/commits{/sha}","comments_url":"https://api.github.com/repos/reinier-vegter/drush/comments{/number}","issue_comment_url":"https://api.github.com/repos/reinier-vegter/drush/issues/comments{/number}","contents_url":"https://api.github.com/repos/reinier-vegter/drush/contents/{+path}","compare_url":"https://api.github.com/repos/reinier-vegter/drush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reinier-vegter/drush/merges","archive_url":"https://api.github.com/repos/reinier-vegter/drush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reinier-vegter/drush/downloads","issues_url":"https://api.github.com/repos/reinier-vegter/drush/issues{/number}","pulls_url":"https://api.github.com/repos/reinier-vegter/drush/pulls{/number}","milestones_url":"https://api.github.com/repos/reinier-vegter/drush/milestones{/number}","notifications_url":"https://api.github.com/repos/reinier-vegter/drush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reinier-vegter/drush/labels{/name}","releases_url":"https://api.github.com/repos/reinier-vegter/drush/releases{/id}","deployments_url":"https://api.github.com/repos/reinier-vegter/drush/deployments","created_at":"2016-10-11T11:01:40Z","updated_at":"2016-10-11T11:01:43Z","pushed_at":"2016-10-12T14:10:42Z","git_url":"git://github.com/reinier-vegter/drush.git","ssh_url":"git@github.com:reinier-vegter/drush.git","clone_url":"https://github.com/reinier-vegter/drush.git","svn_url":"https://github.com/reinier-vegter/drush","homepage":"","size":23383,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drush-ops:8.x","ref":"8.x","sha":"72494ace4b31bda89348a39b2ee0ac31b55027b2","user":{"login":"drush-ops","id":931201,"avatar_url":"https://avatars.githubusercontent.com/u/931201?v=3","gravatar_id":"","url":"https://api.github.com/users/drush-ops","html_url":"https://github.com/drush-ops","followers_url":"https://api.github.com/users/drush-ops/followers","following_url":"https://api.github.com/users/drush-ops/following{/other_user}","gists_url":"https://api.github.com/users/drush-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/drush-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drush-ops/subscriptions","organizations_url":"https://api.github.com/users/drush-ops/orgs","repos_url":"https://api.github.com/users/drush-ops/repos","events_url":"https://api.github.com/users/drush-ops/events{/privacy}","received_events_url":"https://api.github.com/users/drush-ops/received_events","type":"Organization","site_admin":false},"repo":{"id":3193843,"name":"drush","full_name":"drush-ops/drush","owner":{"login":"drush-ops","id":931201,"avatar_url":"https://avatars.githubusercontent.com/u/931201?v=3","gravatar_id":"","url":"https://api.github.com/users/drush-ops","html_url":"https://github.com/drush-ops","followers_url":"https://api.github.com/users/drush-ops/followers","following_url":"https://api.github.com/users/drush-ops/following{/other_user}","gists_url":"https://api.github.com/users/drush-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/drush-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drush-ops/subscriptions","organizations_url":"https://api.github.com/users/drush-ops/orgs","repos_url":"https://api.github.com/users/drush-ops/repos","events_url":"https://api.github.com/users/drush-ops/events{/privacy}","received_events_url":"https://api.github.com/users/drush-ops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drush-ops/drush","description":"Drush is a command-line shell and scripting interface for Drupal, a veritable Swiss Army knife designed to make life easier for those who spend their working hours hacking away at the command prompt.","fork":false,"url":"https://api.github.com/repos/drush-ops/drush","forks_url":"https://api.github.com/repos/drush-ops/drush/forks","keys_url":"https://api.github.com/repos/drush-ops/drush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drush-ops/drush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drush-ops/drush/teams","hooks_url":"https://api.github.com/repos/drush-ops/drush/hooks","issue_events_url":"https://api.github.com/repos/drush-ops/drush/issues/events{/number}","events_url":"https://api.github.com/repos/drush-ops/drush/events","assignees_url":"https://api.github.com/repos/drush-ops/drush/assignees{/user}","branches_url":"https://api.github.com/repos/drush-ops/drush/branches{/branch}","tags_url":"https://api.github.com/repos/drush-ops/drush/tags","blobs_url":"https://api.github.com/repos/drush-ops/drush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drush-ops/drush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drush-ops/drush/git/refs{/sha}","trees_url":"https://api.github.com/repos/drush-ops/drush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drush-ops/drush/statuses/{sha}","languages_url":"https://api.github.com/repos/drush-ops/drush/languages","stargazers_url":"https://api.github.com/repos/drush-ops/drush/stargazers","contributors_url":"https://api.github.com/repos/drush-ops/drush/contributors","subscribers_url":"https://api.github.com/repos/drush-ops/drush/subscribers","subscription_url":"https://api.github.com/repos/drush-ops/drush/subscription","commits_url":"https://api.github.com/repos/drush-ops/drush/commits{/sha}","git_commits_url":"https://api.github.com/repos/drush-ops/drush/git/commits{/sha}","comments_url":"https://api.github.com/repos/drush-ops/drush/comments{/number}","issue_comment_url":"https://api.github.com/repos/drush-ops/drush/issues/comments{/number}","contents_url":"https://api.github.com/repos/drush-ops/drush/contents/{+path}","compare_url":"https://api.github.com/repos/drush-ops/drush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drush-ops/drush/merges","archive_url":"https://api.github.com/repos/drush-ops/drush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drush-ops/drush/downloads","issues_url":"https://api.github.com/repos/drush-ops/drush/issues{/number}","pulls_url":"https://api.github.com/repos/drush-ops/drush/pulls{/number}","milestones_url":"https://api.github.com/repos/drush-ops/drush/milestones{/number}","notifications_url":"https://api.github.com/repos/drush-ops/drush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drush-ops/drush/labels{/name}","releases_url":"https://api.github.com/repos/drush-ops/drush/releases{/id}","deployments_url":"https://api.github.com/repos/drush-ops/drush/deployments","created_at":"2012-01-16T20:26:51Z","updated_at":"2016-10-12T09:42:41Z","pushed_at":"2016-10-12T00:13:07Z","git_url":"git://github.com/drush-ops/drush.git","ssh_url":"git@github.com:drush-ops/drush.git","clone_url":"https://github.com/drush-ops/drush.git","svn_url":"https://github.com/drush-ops/drush","homepage":"","size":23396,"stargazers_count":1479,"watchers_count":1479,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":744,"mirror_url":null,"open_issues_count":445,"forks":744,"open_issues":445,"watchers":1479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drush-ops/drush/pulls/2387"},"html":{"href":"https://github.com/drush-ops/drush/pull/2387"},"issue":{"href":"https://api.github.com/repos/drush-ops/drush/issues/2387"},"comments":{"href":"https://api.github.com/repos/drush-ops/drush/issues/2387/comments"},"review_comments":{"href":"https://api.github.com/repos/drush-ops/drush/pulls/2387/comments"},"review_comment":{"href":"https://api.github.com/repos/drush-ops/drush/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drush-ops/drush/pulls/2387/commits"},"statuses":{"href":"https://api.github.com/repos/drush-ops/drush/statuses/201c05ac3155ee8f9c07119c95a4946e428878e0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"reinier-vegter"}}