{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-geode/pulls/comments/71577488","id":71577488,"diff_hunk":"@@ -7769,17 +7879,55 @@ void cleanUpOnIncompleteOp(EntryEventImpl event, RegionEntry re) {\n     this.entries.removeEntry(event.getKey(), re, false) ;      \n   }\n \n-  static void validateRegionName(String name)\n+  static void validateRegionName(String name, InternalRegionArguments internalRegionArgs)\n   {\n     if (name == null) {\n       throw new IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_NULL.toLocalizedString());\n     }\n-    if (name.length() == 0) {\n+    if (name.isEmpty()) {\n       throw new IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_EMPTY.toLocalizedString());\n     }\n-    if (name.indexOf(SEPARATOR) >= 0) {\n+    if (name.contains(SEPARATOR)) {\n       throw new IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_CONTAIN_THE_SEPARATOR_0.toLocalizedString(SEPARATOR));\n     }\n+\n+    // Validate the name of the region only if it isn't an internal region\n+    if (internalRegionArgs.isInternalRegion()){\n+      return;\n+    }\n+    if (internalRegionArgs.isUsedForMetaRegion()) {\n+      return;\n+    }\n+    if (internalRegionArgs.isUsedForPartitionedRegionAdmin()) {\n+      return;\n+    }\n+    if (internalRegionArgs.isUsedForPartitionedRegionBucket()) {\n+      return;\n+    }\n+\n+//    LocalRegion metaRegion = internalRegionArgs.getInternalMetaRegion();\n+//    if (metaRegion != null) {\n+//      if (metaRegion instanceof HARegion) {\n+//        if (metaRegion.getName().equals(name)) {\n+//          return;\n+//        }\n+//      }\n+//      if (metaRegion instanceof SerialGatewaySenderQueueMetaRegion) {\n+//        return;\n+//      }\n+//    }\n+\n+    if (name.startsWith(\"__\")","path":"geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java","position":251,"original_position":251,"commit_id":"b4f5c457bf3dd600ba8b2ea0a1ebc8572f7cf1cb","original_commit_id":"b4f5c457bf3dd600ba8b2ea0a1ebc8572f7cf1cb","user":{"login":"dschneider-pivotal","id":11197400,"avatar_url":"https://avatars.githubusercontent.com/u/11197400?v=3","gravatar_id":"","url":"https://api.github.com/users/dschneider-pivotal","html_url":"https://github.com/dschneider-pivotal","followers_url":"https://api.github.com/users/dschneider-pivotal/followers","following_url":"https://api.github.com/users/dschneider-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/dschneider-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/dschneider-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschneider-pivotal/subscriptions","organizations_url":"https://api.github.com/users/dschneider-pivotal/orgs","repos_url":"https://api.github.com/users/dschneider-pivotal/repos","events_url":"https://api.github.com/users/dschneider-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/dschneider-pivotal/received_events","type":"User","site_admin":false},"body":"Why was the special case needed? Shouldn't this region have set isInternalRegion?","created_at":"2016-07-20T18:12:34Z","updated_at":"2016-07-20T18:12:34Z","html_url":"https://github.com/apache/incubator-geode/pull/201#discussion_r71577488","pull_request_url":"https://api.github.com/repos/apache/incubator-geode/pulls/201","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-geode/pulls/comments/71577488"},"html":{"href":"https://github.com/apache/incubator-geode/pull/201#discussion_r71577488"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-geode/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-geode/pulls/201","id":77352079,"html_url":"https://github.com/apache/incubator-geode/pull/201","diff_url":"https://github.com/apache/incubator-geode/pull/201.diff","patch_url":"https://github.com/apache/incubator-geode/pull/201.patch","issue_url":"https://api.github.com/repos/apache/incubator-geode/issues/201","number":201,"state":"open","locked":false,"title":"GEODE-1617: Regions can be created with a variety of characters that are unsupported","user":{"login":"kjduling","id":5323097,"avatar_url":"https://avatars.githubusercontent.com/u/5323097?v=3","gravatar_id":"","url":"https://api.github.com/users/kjduling","html_url":"https://github.com/kjduling","followers_url":"https://api.github.com/users/kjduling/followers","following_url":"https://api.github.com/users/kjduling/following{/other_user}","gists_url":"https://api.github.com/users/kjduling/gists{/gist_id}","starred_url":"https://api.github.com/users/kjduling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjduling/subscriptions","organizations_url":"https://api.github.com/users/kjduling/orgs","repos_url":"https://api.github.com/users/kjduling/repos","events_url":"https://api.github.com/users/kjduling/events{/privacy}","received_events_url":"https://api.github.com/users/kjduling/received_events","type":"User","site_admin":false},"body":"Updated the pull request for this ticket after several unit tests failed.","created_at":"2016-07-13T20:02:34Z","updated_at":"2016-07-20T18:12:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3d01fb3ea1fc3fcf01200d6ab1fecf75707aa31","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-geode/pulls/201/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-geode/pulls/201/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-geode/issues/201/comments","statuses_url":"https://api.github.com/repos/apache/incubator-geode/statuses/b4f5c457bf3dd600ba8b2ea0a1ebc8572f7cf1cb","head":{"label":"kjduling:feature/GEODE-1617","ref":"feature/GEODE-1617","sha":"b4f5c457bf3dd600ba8b2ea0a1ebc8572f7cf1cb","user":{"login":"kjduling","id":5323097,"avatar_url":"https://avatars.githubusercontent.com/u/5323097?v=3","gravatar_id":"","url":"https://api.github.com/users/kjduling","html_url":"https://github.com/kjduling","followers_url":"https://api.github.com/users/kjduling/followers","following_url":"https://api.github.com/users/kjduling/following{/other_user}","gists_url":"https://api.github.com/users/kjduling/gists{/gist_id}","starred_url":"https://api.github.com/users/kjduling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjduling/subscriptions","organizations_url":"https://api.github.com/users/kjduling/orgs","repos_url":"https://api.github.com/users/kjduling/repos","events_url":"https://api.github.com/users/kjduling/events{/privacy}","received_events_url":"https://api.github.com/users/kjduling/received_events","type":"User","site_admin":false},"repo":{"id":58583459,"name":"incubator-geode","full_name":"kjduling/incubator-geode","owner":{"login":"kjduling","id":5323097,"avatar_url":"https://avatars.githubusercontent.com/u/5323097?v=3","gravatar_id":"","url":"https://api.github.com/users/kjduling","html_url":"https://github.com/kjduling","followers_url":"https://api.github.com/users/kjduling/followers","following_url":"https://api.github.com/users/kjduling/following{/other_user}","gists_url":"https://api.github.com/users/kjduling/gists{/gist_id}","starred_url":"https://api.github.com/users/kjduling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjduling/subscriptions","organizations_url":"https://api.github.com/users/kjduling/orgs","repos_url":"https://api.github.com/users/kjduling/repos","events_url":"https://api.github.com/users/kjduling/events{/privacy}","received_events_url":"https://api.github.com/users/kjduling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kjduling/incubator-geode","description":"Mirror of Apache Geode (Incubating)","fork":true,"url":"https://api.github.com/repos/kjduling/incubator-geode","forks_url":"https://api.github.com/repos/kjduling/incubator-geode/forks","keys_url":"https://api.github.com/repos/kjduling/incubator-geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kjduling/incubator-geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kjduling/incubator-geode/teams","hooks_url":"https://api.github.com/repos/kjduling/incubator-geode/hooks","issue_events_url":"https://api.github.com/repos/kjduling/incubator-geode/issues/events{/number}","events_url":"https://api.github.com/repos/kjduling/incubator-geode/events","assignees_url":"https://api.github.com/repos/kjduling/incubator-geode/assignees{/user}","branches_url":"https://api.github.com/repos/kjduling/incubator-geode/branches{/branch}","tags_url":"https://api.github.com/repos/kjduling/incubator-geode/tags","blobs_url":"https://api.github.com/repos/kjduling/incubator-geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kjduling/incubator-geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kjduling/incubator-geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/kjduling/incubator-geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kjduling/incubator-geode/statuses/{sha}","languages_url":"https://api.github.com/repos/kjduling/incubator-geode/languages","stargazers_url":"https://api.github.com/repos/kjduling/incubator-geode/stargazers","contributors_url":"https://api.github.com/repos/kjduling/incubator-geode/contributors","subscribers_url":"https://api.github.com/repos/kjduling/incubator-geode/subscribers","subscription_url":"https://api.github.com/repos/kjduling/incubator-geode/subscription","commits_url":"https://api.github.com/repos/kjduling/incubator-geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/kjduling/incubator-geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/kjduling/incubator-geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/kjduling/incubator-geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/kjduling/incubator-geode/contents/{+path}","compare_url":"https://api.github.com/repos/kjduling/incubator-geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kjduling/incubator-geode/merges","archive_url":"https://api.github.com/repos/kjduling/incubator-geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kjduling/incubator-geode/downloads","issues_url":"https://api.github.com/repos/kjduling/incubator-geode/issues{/number}","pulls_url":"https://api.github.com/repos/kjduling/incubator-geode/pulls{/number}","milestones_url":"https://api.github.com/repos/kjduling/incubator-geode/milestones{/number}","notifications_url":"https://api.github.com/repos/kjduling/incubator-geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kjduling/incubator-geode/labels{/name}","releases_url":"https://api.github.com/repos/kjduling/incubator-geode/releases{/id}","deployments_url":"https://api.github.com/repos/kjduling/incubator-geode/deployments","created_at":"2016-05-11T21:33:26Z","updated_at":"2016-05-11T21:33:37Z","pushed_at":"2016-07-20T16:28:08Z","git_url":"git://github.com/kjduling/incubator-geode.git","ssh_url":"git@github.com:kjduling/incubator-geode.git","clone_url":"https://github.com/kjduling/incubator-geode.git","svn_url":"https://github.com/kjduling/incubator-geode","homepage":null,"size":84399,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"701909fd46626774d7b4ce0266a3a1c0340814b3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"name":"incubator-geode","full_name":"apache/incubator-geode","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-geode","description":"Mirror of Apache Geode (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-geode","forks_url":"https://api.github.com/repos/apache/incubator-geode/forks","keys_url":"https://api.github.com/repos/apache/incubator-geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-geode/teams","hooks_url":"https://api.github.com/repos/apache/incubator-geode/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-geode/events","assignees_url":"https://api.github.com/repos/apache/incubator-geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-geode/tags","blobs_url":"https://api.github.com/repos/apache/incubator-geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-geode/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-geode/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-geode/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-geode/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-geode/subscription","commits_url":"https://api.github.com/repos/apache/incubator-geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-geode/merges","archive_url":"https://api.github.com/repos/apache/incubator-geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-geode/downloads","issues_url":"https://api.github.com/repos/apache/incubator-geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2016-07-20T14:58:56Z","pushed_at":"2016-07-20T17:54:09Z","git_url":"git://github.com/apache/incubator-geode.git","ssh_url":"git@github.com:apache/incubator-geode.git","clone_url":"https://github.com/apache/incubator-geode.git","svn_url":"https://github.com/apache/incubator-geode","homepage":null,"size":97724,"stargazers_count":569,"watchers_count":569,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":231,"mirror_url":"git://git.apache.org/incubator-geode.git","open_issues_count":8,"forks":231,"open_issues":8,"watchers":569,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-geode/pulls/201"},"html":{"href":"https://github.com/apache/incubator-geode/pull/201"},"issue":{"href":"https://api.github.com/repos/apache/incubator-geode/issues/201"},"comments":{"href":"https://api.github.com/repos/apache/incubator-geode/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-geode/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-geode/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-geode/statuses/b4f5c457bf3dd600ba8b2ea0a1ebc8572f7cf1cb"}}}}
{"actor":{"display_login":"dschneider-pivotal"}}