{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/PragTob/benchee/pulls/40","id":88130939,"html_url":"https://github.com/PragTob/benchee/pull/40","diff_url":"https://github.com/PragTob/benchee/pull/40.diff","patch_url":"https://github.com/PragTob/benchee/pull/40.patch","issue_url":"https://api.github.com/repos/PragTob/benchee/issues/40","number":40,"state":"closed","locked":false,"title":"Use Unit struct, and hang Unit functionality there","user":{"login":"wasnotrice","id":908,"avatar_url":"https://avatars.githubusercontent.com/u/908?v=3","gravatar_id":"","url":"https://api.github.com/users/wasnotrice","html_url":"https://github.com/wasnotrice","followers_url":"https://api.github.com/users/wasnotrice/followers","following_url":"https://api.github.com/users/wasnotrice/following{/other_user}","gists_url":"https://api.github.com/users/wasnotrice/gists{/gist_id}","starred_url":"https://api.github.com/users/wasnotrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasnotrice/subscriptions","organizations_url":"https://api.github.com/users/wasnotrice/orgs","repos_url":"https://api.github.com/users/wasnotrice/repos","events_url":"https://api.github.com/users/wasnotrice/events{/privacy}","received_events_url":"https://api.github.com/users/wasnotrice/received_events","type":"User","site_admin":false},"body":"This was just an experiment, but I really like how it turned out, so I'm opening this PR for review. Note that it is based on #39, because it is an extension of that basic refactoring.\r\n\r\n- converts units from plain maps to `Unit` structs\r\n- remove `label/1`, `magnitude/1`, `separator/0` functions from `Count` and `Duration`\r\n- add label and magnitude functionality to the Unit struct, as it better fits there anyway\r\n- retain the option for a module like `Count` to define a `separator/0` function, but if not, just use a space","created_at":"2016-10-05T18:26:05Z","updated_at":"2016-10-10T16:15:20Z","closed_at":"2016-10-10T16:15:20Z","merged_at":"2016-10-10T16:15:20Z","merge_commit_sha":"bef3d681535e5b01f1a061f16f00683ff932c2e8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PragTob/benchee/pulls/40/commits","review_comments_url":"https://api.github.com/repos/PragTob/benchee/pulls/40/comments","review_comment_url":"https://api.github.com/repos/PragTob/benchee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PragTob/benchee/issues/40/comments","statuses_url":"https://api.github.com/repos/PragTob/benchee/statuses/cf0536b28b08cbd1e144f1480232ed68ad681526","head":{"label":"PragTob:unit-struct","ref":"unit-struct","sha":"cf0536b28b08cbd1e144f1480232ed68ad681526","user":{"login":"PragTob","id":606517,"avatar_url":"https://avatars.githubusercontent.com/u/606517?v=3","gravatar_id":"","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"repo":{"id":59428665,"name":"benchee","full_name":"PragTob/benchee","owner":{"login":"PragTob","id":606517,"avatar_url":"https://avatars.githubusercontent.com/u/606517?v=3","gravatar_id":"","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PragTob/benchee","description":"Easy and extensible benchmarking in Elixir providing you with lots of statistics!","fork":false,"url":"https://api.github.com/repos/PragTob/benchee","forks_url":"https://api.github.com/repos/PragTob/benchee/forks","keys_url":"https://api.github.com/repos/PragTob/benchee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PragTob/benchee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PragTob/benchee/teams","hooks_url":"https://api.github.com/repos/PragTob/benchee/hooks","issue_events_url":"https://api.github.com/repos/PragTob/benchee/issues/events{/number}","events_url":"https://api.github.com/repos/PragTob/benchee/events","assignees_url":"https://api.github.com/repos/PragTob/benchee/assignees{/user}","branches_url":"https://api.github.com/repos/PragTob/benchee/branches{/branch}","tags_url":"https://api.github.com/repos/PragTob/benchee/tags","blobs_url":"https://api.github.com/repos/PragTob/benchee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PragTob/benchee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PragTob/benchee/git/refs{/sha}","trees_url":"https://api.github.com/repos/PragTob/benchee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PragTob/benchee/statuses/{sha}","languages_url":"https://api.github.com/repos/PragTob/benchee/languages","stargazers_url":"https://api.github.com/repos/PragTob/benchee/stargazers","contributors_url":"https://api.github.com/repos/PragTob/benchee/contributors","subscribers_url":"https://api.github.com/repos/PragTob/benchee/subscribers","subscription_url":"https://api.github.com/repos/PragTob/benchee/subscription","commits_url":"https://api.github.com/repos/PragTob/benchee/commits{/sha}","git_commits_url":"https://api.github.com/repos/PragTob/benchee/git/commits{/sha}","comments_url":"https://api.github.com/repos/PragTob/benchee/comments{/number}","issue_comment_url":"https://api.github.com/repos/PragTob/benchee/issues/comments{/number}","contents_url":"https://api.github.com/repos/PragTob/benchee/contents/{+path}","compare_url":"https://api.github.com/repos/PragTob/benchee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PragTob/benchee/merges","archive_url":"https://api.github.com/repos/PragTob/benchee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PragTob/benchee/downloads","issues_url":"https://api.github.com/repos/PragTob/benchee/issues{/number}","pulls_url":"https://api.github.com/repos/PragTob/benchee/pulls{/number}","milestones_url":"https://api.github.com/repos/PragTob/benchee/milestones{/number}","notifications_url":"https://api.github.com/repos/PragTob/benchee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PragTob/benchee/labels{/name}","releases_url":"https://api.github.com/repos/PragTob/benchee/releases{/id}","deployments_url":"https://api.github.com/repos/PragTob/benchee/deployments","created_at":"2016-05-22T18:48:43Z","updated_at":"2016-09-25T10:38:33Z","pushed_at":"2016-10-10T16:15:20Z","git_url":"git://github.com/PragTob/benchee.git","ssh_url":"git@github.com:PragTob/benchee.git","clone_url":"https://github.com/PragTob/benchee.git","svn_url":"https://github.com/PragTob/benchee","homepage":"","size":277,"stargazers_count":83,"watchers_count":83,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":14,"forks":6,"open_issues":14,"watchers":83,"default_branch":"master"}},"base":{"label":"PragTob:refactor-unit-to-conversion","ref":"refactor-unit-to-conversion","sha":"f221a93c8266a2f275ddf9c7917e21a42fa1eb95","user":{"login":"PragTob","id":606517,"avatar_url":"https://avatars.githubusercontent.com/u/606517?v=3","gravatar_id":"","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"repo":{"id":59428665,"name":"benchee","full_name":"PragTob/benchee","owner":{"login":"PragTob","id":606517,"avatar_url":"https://avatars.githubusercontent.com/u/606517?v=3","gravatar_id":"","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PragTob/benchee","description":"Easy and extensible benchmarking in Elixir providing you with lots of statistics!","fork":false,"url":"https://api.github.com/repos/PragTob/benchee","forks_url":"https://api.github.com/repos/PragTob/benchee/forks","keys_url":"https://api.github.com/repos/PragTob/benchee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PragTob/benchee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PragTob/benchee/teams","hooks_url":"https://api.github.com/repos/PragTob/benchee/hooks","issue_events_url":"https://api.github.com/repos/PragTob/benchee/issues/events{/number}","events_url":"https://api.github.com/repos/PragTob/benchee/events","assignees_url":"https://api.github.com/repos/PragTob/benchee/assignees{/user}","branches_url":"https://api.github.com/repos/PragTob/benchee/branches{/branch}","tags_url":"https://api.github.com/repos/PragTob/benchee/tags","blobs_url":"https://api.github.com/repos/PragTob/benchee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PragTob/benchee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PragTob/benchee/git/refs{/sha}","trees_url":"https://api.github.com/repos/PragTob/benchee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PragTob/benchee/statuses/{sha}","languages_url":"https://api.github.com/repos/PragTob/benchee/languages","stargazers_url":"https://api.github.com/repos/PragTob/benchee/stargazers","contributors_url":"https://api.github.com/repos/PragTob/benchee/contributors","subscribers_url":"https://api.github.com/repos/PragTob/benchee/subscribers","subscription_url":"https://api.github.com/repos/PragTob/benchee/subscription","commits_url":"https://api.github.com/repos/PragTob/benchee/commits{/sha}","git_commits_url":"https://api.github.com/repos/PragTob/benchee/git/commits{/sha}","comments_url":"https://api.github.com/repos/PragTob/benchee/comments{/number}","issue_comment_url":"https://api.github.com/repos/PragTob/benchee/issues/comments{/number}","contents_url":"https://api.github.com/repos/PragTob/benchee/contents/{+path}","compare_url":"https://api.github.com/repos/PragTob/benchee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PragTob/benchee/merges","archive_url":"https://api.github.com/repos/PragTob/benchee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PragTob/benchee/downloads","issues_url":"https://api.github.com/repos/PragTob/benchee/issues{/number}","pulls_url":"https://api.github.com/repos/PragTob/benchee/pulls{/number}","milestones_url":"https://api.github.com/repos/PragTob/benchee/milestones{/number}","notifications_url":"https://api.github.com/repos/PragTob/benchee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PragTob/benchee/labels{/name}","releases_url":"https://api.github.com/repos/PragTob/benchee/releases{/id}","deployments_url":"https://api.github.com/repos/PragTob/benchee/deployments","created_at":"2016-05-22T18:48:43Z","updated_at":"2016-09-25T10:38:33Z","pushed_at":"2016-10-10T16:15:20Z","git_url":"git://github.com/PragTob/benchee.git","ssh_url":"git@github.com:PragTob/benchee.git","clone_url":"https://github.com/PragTob/benchee.git","svn_url":"https://github.com/PragTob/benchee","homepage":"","size":277,"stargazers_count":83,"watchers_count":83,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":14,"forks":6,"open_issues":14,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PragTob/benchee/pulls/40"},"html":{"href":"https://github.com/PragTob/benchee/pull/40"},"issue":{"href":"https://api.github.com/repos/PragTob/benchee/issues/40"},"comments":{"href":"https://api.github.com/repos/PragTob/benchee/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/PragTob/benchee/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/PragTob/benchee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PragTob/benchee/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/PragTob/benchee/statuses/cf0536b28b08cbd1e144f1480232ed68ad681526"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"PragTob","id":606517,"avatar_url":"https://avatars.githubusercontent.com/u/606517?v=3","gravatar_id":"","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"comments":4,"review_comments":6,"commits":22,"additions":264,"deletions":237,"changed_files":7}}
{"actor":{"display_login":"PragTob"}}