{"action":"closed","issue":{"url":"https://api.github.com/repos/SynBioDex/SBOL-specification/issues/70","repository_url":"https://api.github.com/repos/SynBioDex/SBOL-specification","labels_url":"https://api.github.com/repos/SynBioDex/SBOL-specification/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/SynBioDex/SBOL-specification/issues/70/comments","events_url":"https://api.github.com/repos/SynBioDex/SBOL-specification/issues/70/events","html_url":"https://github.com/SynBioDex/SBOL-specification/issues/70","id":182556613,"number":70,"title":"Sequence annotation cannot have both a role and a component","user":{"login":"jakebeal","id":10675899,"avatar_url":"https://avatars.githubusercontent.com/u/10675899?v=3","gravatar_id":"","url":"https://api.github.com/users/jakebeal","html_url":"https://github.com/jakebeal","followers_url":"https://api.github.com/users/jakebeal/followers","following_url":"https://api.github.com/users/jakebeal/following{/other_user}","gists_url":"https://api.github.com/users/jakebeal/gists{/gist_id}","starred_url":"https://api.github.com/users/jakebeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakebeal/subscriptions","organizations_url":"https://api.github.com/users/jakebeal/orgs","repos_url":"https://api.github.com/users/jakebeal/repos","events_url":"https://api.github.com/users/jakebeal/events{/privacy}","received_events_url":"https://api.github.com/users/jakebeal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SynBioDex/SBOL-specification/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/SynBioDex/SBOL-specification/labels/Needs%20SEP","name":"Needs SEP","color":"eb6420"},{"url":"https://api.github.com/repos/SynBioDex/SBOL-specification/labels/Non-SEP%20change","name":"Non-SEP change","color":"009800"}],"state":"closed","locked":false,"assignee":{"login":"cjmyers","id":3507191,"avatar_url":"https://avatars.githubusercontent.com/u/3507191?v=3","gravatar_id":"","url":"https://api.github.com/users/cjmyers","html_url":"https://github.com/cjmyers","followers_url":"https://api.github.com/users/cjmyers/followers","following_url":"https://api.github.com/users/cjmyers/following{/other_user}","gists_url":"https://api.github.com/users/cjmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/cjmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjmyers/subscriptions","organizations_url":"https://api.github.com/users/cjmyers/orgs","repos_url":"https://api.github.com/users/cjmyers/repos","events_url":"https://api.github.com/users/cjmyers/events{/privacy}","received_events_url":"https://api.github.com/users/cjmyers/received_events","type":"User","site_admin":false},"assignees":[{"login":"cjmyers","id":3507191,"avatar_url":"https://avatars.githubusercontent.com/u/3507191?v=3","gravatar_id":"","url":"https://api.github.com/users/cjmyers","html_url":"https://github.com/cjmyers","followers_url":"https://api.github.com/users/cjmyers/followers","following_url":"https://api.github.com/users/cjmyers/following{/other_user}","gists_url":"https://api.github.com/users/cjmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/cjmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjmyers/subscriptions","organizations_url":"https://api.github.com/users/cjmyers/orgs","repos_url":"https://api.github.com/users/cjmyers/repos","events_url":"https://api.github.com/users/cjmyers/events{/privacy}","received_events_url":"https://api.github.com/users/cjmyers/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/SynBioDex/SBOL-specification/milestones/3","html_url":"https://github.com/SynBioDex/SBOL-specification/milestones/Version%202.1","labels_url":"https://api.github.com/repos/SynBioDex/SBOL-specification/milestones/3/labels","id":1174245,"number":3,"title":"Version 2.1","description":"Next anticipated update with modifications to the data model.\r\n\r\nA new minor version is when you add functionality in a backwards-compatible manner (per semver.org)","creator":{"login":"jakebeal","id":10675899,"avatar_url":"https://avatars.githubusercontent.com/u/10675899?v=3","gravatar_id":"","url":"https://api.github.com/users/jakebeal","html_url":"https://github.com/jakebeal","followers_url":"https://api.github.com/users/jakebeal/followers","following_url":"https://api.github.com/users/jakebeal/following{/other_user}","gists_url":"https://api.github.com/users/jakebeal/gists{/gist_id}","starred_url":"https://api.github.com/users/jakebeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakebeal/subscriptions","organizations_url":"https://api.github.com/users/jakebeal/orgs","repos_url":"https://api.github.com/users/jakebeal/repos","events_url":"https://api.github.com/users/jakebeal/events{/privacy}","received_events_url":"https://api.github.com/users/jakebeal/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":1,"state":"open","created_at":"2015-06-21T22:33:30Z","updated_at":"2016-10-20T15:15:29Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-10-12T15:27:54Z","updated_at":"2016-10-20T15:15:29Z","closed_at":"2016-10-20T15:15:29Z","body":"We would like to avoid backward compatibility issues when SEP010 (or something of its sort) is adopted, but also want to get SBOL 2.1 out including the new roles from SEP004.  Thus, we plan to do the following:\r\n\r\nRather than keeping roleIntegration on SequenceAnnotation, we can add a constraint that says a SequenceAnnotation cannot have both a role and a component.  This will prevent the need for roleIntegration in SequenceAnnotation, and can readily be enforced because both SequenceAnnotation and Component are child objects of ComponentDefinition, meaning they generally travel together.\r\n\r\nI have marked this as both \"Needs SEP\" and \"Non-SEP\" for the following reasons:\r\n1. The formal vote on data model effects will come as part of accepting SEP010, in whatever form it ultimately assumes.\r\n2. The was a general consensus on SEP010 (or something like it) in the discussions at COMBINE\r\n3. All of the key stakeholders are agreeing with the general path forward\r\n4. Even if SEP010 completely fails and the consensus changes back toward roleIntegration in SequenceAnnotation, dropping the constraint and adding roleIntegration is a backward compatible change that could be implemented in SBOL 2.2.\r\n"}}
{"actor":{"display_login":"jakebeal"}}