{"action":"created","issue":{"url":"https://api.github.com/repos/pypa/pip/issues/4093","repository_url":"https://api.github.com/repos/pypa/pip","labels_url":"https://api.github.com/repos/pypa/pip/issues/4093/labels{/name}","comments_url":"https://api.github.com/repos/pypa/pip/issues/4093/comments","events_url":"https://api.github.com/repos/pypa/pip/issues/4093/events","html_url":"https://github.com/pypa/pip/pull/4093","id":187558900,"number":4093,"title":"Automatic vendoring","user":{"login":"xavfernandez","id":1089744,"avatar_url":"https://avatars.githubusercontent.com/u/1089744?v=3","gravatar_id":"","url":"https://api.github.com/users/xavfernandez","html_url":"https://github.com/xavfernandez","followers_url":"https://api.github.com/users/xavfernandez/followers","following_url":"https://api.github.com/users/xavfernandez/following{/other_user}","gists_url":"https://api.github.com/users/xavfernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/xavfernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavfernandez/subscriptions","organizations_url":"https://api.github.com/users/xavfernandez/orgs","repos_url":"https://api.github.com/users/xavfernandez/repos","events_url":"https://api.github.com/users/xavfernandez/events{/privacy}","received_events_url":"https://api.github.com/users/xavfernandez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-06T12:34:00Z","updated_at":"2016-11-06T15:47:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pypa/pip/pulls/4093","html_url":"https://github.com/pypa/pip/pull/4093","diff_url":"https://github.com/pypa/pip/pull/4093.diff","patch_url":"https://github.com/pypa/pip/pull/4093.patch"},"body":"cc @dstufft "},"comment":{"url":"https://api.github.com/repos/pypa/pip/issues/comments/258689410","html_url":"https://github.com/pypa/pip/pull/4093#issuecomment-258689410","issue_url":"https://api.github.com/repos/pypa/pip/issues/4093","id":258689410,"user":{"login":"pfmoore","id":1110419,"avatar_url":"https://avatars.githubusercontent.com/u/1110419?v=3","gravatar_id":"","url":"https://api.github.com/users/pfmoore","html_url":"https://github.com/pfmoore","followers_url":"https://api.github.com/users/pfmoore/followers","following_url":"https://api.github.com/users/pfmoore/following{/other_user}","gists_url":"https://api.github.com/users/pfmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/pfmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfmoore/subscriptions","organizations_url":"https://api.github.com/users/pfmoore/orgs","repos_url":"https://api.github.com/users/pfmoore/repos","events_url":"https://api.github.com/users/pfmoore/events{/privacy}","received_events_url":"https://api.github.com/users/pfmoore/received_events","type":"User","site_admin":false},"created_at":"2016-11-06T15:47:00Z","updated_at":"2016-11-06T15:47:00Z","body":"Only a couple of comments, as I don't have time for a full review at the moment, sorry.\r\n\r\n1. Are the edits to vendored files meant to be in there? Seems odd for a patch that fully automates vendoring to me also adding manual changes to the vendored files.\r\n2. As long as the new vendoring task works on Windows, I'm OK with it. I originally wrote the vendoring script to replace some Unix-only shell scripts, so that I could re-vendor myself if needed. As ```invoke``` now works on Windows, I'm happy to move the functionality to the invoke tasks.\r\n3. Although actually, you don't reference invoke in the new script, or make it a task. Are you aware that the contents of the ```tasks``` directory are run via ```invoke```? (It wouldn't be surprising if you weren't, it's not documented anywhere. AFAIK, it's just the tool @dstufft prefers to use for some of the release jobs.)"}}
{"actor":{"display_login":"pfmoore"}}