{"action":"created","issue":{"url":"https://api.github.com/repos/KnpLabs/KnpJsonSchemaBundle/issues/26","repository_url":"https://api.github.com/repos/KnpLabs/KnpJsonSchemaBundle","labels_url":"https://api.github.com/repos/KnpLabs/KnpJsonSchemaBundle/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/KnpLabs/KnpJsonSchemaBundle/issues/26/comments","events_url":"https://api.github.com/repos/KnpLabs/KnpJsonSchemaBundle/issues/26/events","html_url":"https://github.com/KnpLabs/KnpJsonSchemaBundle/pull/26","id":141153913,"number":26,"title":"shared = false attribute to services configuration to fix symfony >= 2.8 issue","user":{"login":"pedropapa","id":2160382,"avatar_url":"https://avatars.githubusercontent.com/u/2160382?v=3","gravatar_id":"","url":"https://api.github.com/users/pedropapa","html_url":"https://github.com/pedropapa","followers_url":"https://api.github.com/users/pedropapa/followers","following_url":"https://api.github.com/users/pedropapa/following{/other_user}","gists_url":"https://api.github.com/users/pedropapa/gists{/gist_id}","starred_url":"https://api.github.com/users/pedropapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedropapa/subscriptions","organizations_url":"https://api.github.com/users/pedropapa/orgs","repos_url":"https://api.github.com/users/pedropapa/repos","events_url":"https://api.github.com/users/pedropapa/events{/privacy}","received_events_url":"https://api.github.com/users/pedropapa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-16T02:29:10Z","updated_at":"2016-03-16T19:19:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/KnpLabs/KnpJsonSchemaBundle/pulls/26","html_url":"https://github.com/KnpLabs/KnpJsonSchemaBundle/pull/26","diff_url":"https://github.com/KnpLabs/KnpJsonSchemaBundle/pull/26.diff","patch_url":"https://github.com/KnpLabs/KnpJsonSchemaBundle/pull/26.patch"},"body":"Shared: false attribute on services configuration is necessary because it prevents symfony from sharing the service scope among other classes (forcing a new class instance), it solves an issue on Reflection Factory when two or more bundles are added to the RegisterJsonSchemasPass compiler on bundle's build method. The scope sharing feature is default in symfony >= 2.8 and need to be disabled manually.\r\n\r\nNote: it fixes https://github.com/KnpLabs/KnpJsonSchemaBundle/issues/16"},"comment":{"url":"https://api.github.com/repos/KnpLabs/KnpJsonSchemaBundle/issues/comments/197498403","html_url":"https://github.com/KnpLabs/KnpJsonSchemaBundle/pull/26#issuecomment-197498403","issue_url":"https://api.github.com/repos/KnpLabs/KnpJsonSchemaBundle/issues/26","id":197498403,"user":{"login":"gquemener","id":668604,"avatar_url":"https://avatars.githubusercontent.com/u/668604?v=3","gravatar_id":"","url":"https://api.github.com/users/gquemener","html_url":"https://github.com/gquemener","followers_url":"https://api.github.com/users/gquemener/followers","following_url":"https://api.github.com/users/gquemener/following{/other_user}","gists_url":"https://api.github.com/users/gquemener/gists{/gist_id}","starred_url":"https://api.github.com/users/gquemener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gquemener/subscriptions","organizations_url":"https://api.github.com/users/gquemener/orgs","repos_url":"https://api.github.com/users/gquemener/repos","events_url":"https://api.github.com/users/gquemener/events{/privacy}","received_events_url":"https://api.github.com/users/gquemener/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T19:19:33Z","updated_at":"2016-03-16T19:19:33Z","body":"First of all, thank you!\r\n\r\nI'm not sure this is compatible with symfony < 2.8 as the build matrix is not testing against different versions of symfony (but only the last one).\r\n\r\nBTW, I'm no longer part of the Knp organization, and thus can't help you with the merging.\r\n\r\nLet me ping a few of the folks for you @PedroTroller @docteurklein @AntoineLelaisant @Einenlum \r\n\r\nCheers!"}}