{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/62056036","id":62056036,"diff_hunk":"@@ -688,6 +689,12 @@ public void TestGetDotNetFrameworkSdkRootRegistryKey()\n             Assert.Equal(ToolLocationHelper.GetDotNetFrameworkSdkRootRegistryKey(TargetDotNetFrameworkVersion.Version451, VisualStudioVersion.Version120), fullDotNetFrameworkSdkRegistryPathForV4ToolsOnManagedToolsSDK81A);\n             Assert.Equal(ToolLocationHelper.GetDotNetFrameworkSdkRootRegistryKey(TargetDotNetFrameworkVersion.Version451, VisualStudioVersion.Version140), fullDotNetFrameworkSdkRegistryPathForV4ToolsOnManagedToolsSDK46);\n \n+            // v4.5.2\n+            ObjectModelHelpers.AssertThrows(typeof(ArgumentException), delegate { ToolLocationHelper.GetDotNetFrameworkSdkRootRegistryKey(TargetDotNetFrameworkVersion.Version451, VisualStudioVersion.Version100); });\n+            ObjectModelHelpers.AssertThrows(typeof(ArgumentException), delegate { ToolLocationHelper.GetDotNetFrameworkSdkRootRegistryKey(TargetDotNetFrameworkVersion.Version451, VisualStudioVersion.Version110); });\n+            Assert.Equal(ToolLocationHelper.GetDotNetFrameworkSdkRootRegistryKey(TargetDotNetFrameworkVersion.Version452, VisualStudioVersion.Version120), fullDotNetFrameworkSdkRegistryPathForV4ToolsOnManagedToolsSDK81A);\n+            Assert.Equal(ToolLocationHelper.GetDotNetFrameworkSdkRootRegistryKey(TargetDotNetFrameworkVersion.Version452, VisualStudioVersion.Version140), fullDotNetFrameworkSdkRegistryPathForV4ToolsOnManagedToolsSDK46);","path":"src/Utilities/UnitTests/ToolLocationHelper_Tests.cs","position":16,"original_position":16,"commit_id":"31f3d1c62b12c42931dc2bb5a0654cafc34150c3","original_commit_id":"31f3d1c62b12c42931dc2bb5a0654cafc34150c3","user":{"login":"rainersigwald","id":3347530,"avatar_url":"https://avatars.githubusercontent.com/u/3347530?v=3","gravatar_id":"","url":"https://api.github.com/users/rainersigwald","html_url":"https://github.com/rainersigwald","followers_url":"https://api.github.com/users/rainersigwald/followers","following_url":"https://api.github.com/users/rainersigwald/following{/other_user}","gists_url":"https://api.github.com/users/rainersigwald/gists{/gist_id}","starred_url":"https://api.github.com/users/rainersigwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainersigwald/subscriptions","organizations_url":"https://api.github.com/users/rainersigwald/orgs","repos_url":"https://api.github.com/users/rainersigwald/repos","events_url":"https://api.github.com/users/rainersigwald/events{/privacy}","received_events_url":"https://api.github.com/users/rainersigwald/received_events","type":"User","site_admin":false},"body":"Really? It points to 4.6? (This matches the other tests above, so it's probably right, but it seems very odd.)","created_at":"2016-05-04T15:06:27Z","updated_at":"2016-05-04T15:06:27Z","html_url":"https://github.com/Microsoft/msbuild/pull/602#discussion_r62056036","pull_request_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/602","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/62056036"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/602#discussion_r62056036"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/602"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/602","id":68770159,"html_url":"https://github.com/Microsoft/msbuild/pull/602","diff_url":"https://github.com/Microsoft/msbuild/pull/602.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/602.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/602","number":602,"state":"open","locked":false,"title":"Adding support for 4.5.2 target framework","user":{"login":"AndyGerlicher","id":9847849,"avatar_url":"https://avatars.githubusercontent.com/u/9847849?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyGerlicher","html_url":"https://github.com/AndyGerlicher","followers_url":"https://api.github.com/users/AndyGerlicher/followers","following_url":"https://api.github.com/users/AndyGerlicher/following{/other_user}","gists_url":"https://api.github.com/users/AndyGerlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyGerlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyGerlicher/subscriptions","organizations_url":"https://api.github.com/users/AndyGerlicher/orgs","repos_url":"https://api.github.com/users/AndyGerlicher/repos","events_url":"https://api.github.com/users/AndyGerlicher/events{/privacy}","received_events_url":"https://api.github.com/users/AndyGerlicher/received_events","type":"User","site_admin":false},"body":"Closes #601","created_at":"2016-05-03T20:33:46Z","updated_at":"2016-05-04T15:06:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78a7267d0289a864f19ea480f439de077592bbaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/602/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/602/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/602/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/31f3d1c62b12c42931dc2bb5a0654cafc34150c3","head":{"label":"AndyGerlicher:AddFramework452","ref":"AddFramework452","sha":"31f3d1c62b12c42931dc2bb5a0654cafc34150c3","user":{"login":"AndyGerlicher","id":9847849,"avatar_url":"https://avatars.githubusercontent.com/u/9847849?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyGerlicher","html_url":"https://github.com/AndyGerlicher","followers_url":"https://api.github.com/users/AndyGerlicher/followers","following_url":"https://api.github.com/users/AndyGerlicher/following{/other_user}","gists_url":"https://api.github.com/users/AndyGerlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyGerlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyGerlicher/subscriptions","organizations_url":"https://api.github.com/users/AndyGerlicher/orgs","repos_url":"https://api.github.com/users/AndyGerlicher/repos","events_url":"https://api.github.com/users/AndyGerlicher/events{/privacy}","received_events_url":"https://api.github.com/users/AndyGerlicher/received_events","type":"User","site_admin":false},"repo":{"id":32488219,"name":"msbuild","full_name":"AndyGerlicher/msbuild","owner":{"login":"AndyGerlicher","id":9847849,"avatar_url":"https://avatars.githubusercontent.com/u/9847849?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyGerlicher","html_url":"https://github.com/AndyGerlicher","followers_url":"https://api.github.com/users/AndyGerlicher/followers","following_url":"https://api.github.com/users/AndyGerlicher/following{/other_user}","gists_url":"https://api.github.com/users/AndyGerlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyGerlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyGerlicher/subscriptions","organizations_url":"https://api.github.com/users/AndyGerlicher/orgs","repos_url":"https://api.github.com/users/AndyGerlicher/repos","events_url":"https://api.github.com/users/AndyGerlicher/events{/privacy}","received_events_url":"https://api.github.com/users/AndyGerlicher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndyGerlicher/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/AndyGerlicher/msbuild","forks_url":"https://api.github.com/repos/AndyGerlicher/msbuild/forks","keys_url":"https://api.github.com/repos/AndyGerlicher/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndyGerlicher/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndyGerlicher/msbuild/teams","hooks_url":"https://api.github.com/repos/AndyGerlicher/msbuild/hooks","issue_events_url":"https://api.github.com/repos/AndyGerlicher/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/AndyGerlicher/msbuild/events","assignees_url":"https://api.github.com/repos/AndyGerlicher/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/AndyGerlicher/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/AndyGerlicher/msbuild/tags","blobs_url":"https://api.github.com/repos/AndyGerlicher/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndyGerlicher/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndyGerlicher/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndyGerlicher/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndyGerlicher/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/AndyGerlicher/msbuild/languages","stargazers_url":"https://api.github.com/repos/AndyGerlicher/msbuild/stargazers","contributors_url":"https://api.github.com/repos/AndyGerlicher/msbuild/contributors","subscribers_url":"https://api.github.com/repos/AndyGerlicher/msbuild/subscribers","subscription_url":"https://api.github.com/repos/AndyGerlicher/msbuild/subscription","commits_url":"https://api.github.com/repos/AndyGerlicher/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndyGerlicher/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndyGerlicher/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndyGerlicher/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndyGerlicher/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/AndyGerlicher/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndyGerlicher/msbuild/merges","archive_url":"https://api.github.com/repos/AndyGerlicher/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndyGerlicher/msbuild/downloads","issues_url":"https://api.github.com/repos/AndyGerlicher/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/AndyGerlicher/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/AndyGerlicher/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/AndyGerlicher/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndyGerlicher/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/AndyGerlicher/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/AndyGerlicher/msbuild/deployments","created_at":"2015-03-18T22:42:33Z","updated_at":"2016-01-14T23:55:33Z","pushed_at":"2016-05-03T20:32:41Z","git_url":"git://github.com/AndyGerlicher/msbuild.git","ssh_url":"git@github.com:AndyGerlicher/msbuild.git","clone_url":"https://github.com/AndyGerlicher/msbuild.git","svn_url":"https://github.com/AndyGerlicher/msbuild","homepage":null,"size":8503,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:dev14-update3","ref":"dev14-update3","sha":"e4a55eecb0d41d63647356a55da7396654f830f5","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"name":"msbuild","full_name":"Microsoft/msbuild","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2016-05-03T14:15:06Z","pushed_at":"2016-05-03T20:33:47Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":10933,"stargazers_count":2549,"watchers_count":2549,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":494,"mirror_url":null,"open_issues_count":167,"forks":494,"open_issues":167,"watchers":2549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/602"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/602"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/602"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/602/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/602/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/602/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/31f3d1c62b12c42931dc2bb5a0654cafc34150c3"}}}}