{"action":"created","comment":{"url":"https://api.github.com/repos/01org/libyami/pulls/comments/73559327","id":73559327,"diff_hunk":"@@ -82,14 +114,14 @@ static int32_t searchStartPos(const uint8_t* src, uint32_t size)\n }\n \n //7.3.2.1.1.1 Scaling list syntax\n-static void scalingList(NalReader& nr, uint8_t* sl, uint32_t size, uint32_t index)\n+static bool scalingList(NalReader& br, uint8_t* sl, uint32_t size, uint32_t index)\n {\n     uint8_t lastScale = 8;\n     uint8_t nextScale = 8;\n     int32_t delta_scale;\n     for (uint32_t j = 0; j < size; j++) {\n         if (nextScale) {\n-            delta_scale = nr.readSe();\n+            READ_SE(delta_scale);","path":"codecparsers/h264Parser.cpp","position":52,"original_position":52,"commit_id":"3cdecdb4545b3cf713eb3e49b7a198e699699e11","original_commit_id":"3cdecdb4545b3cf713eb3e49b7a198e699699e11","user":{"login":"chivakker","id":69215,"avatar_url":"https://avatars.githubusercontent.com/u/69215?v=3","gravatar_id":"","url":"https://api.github.com/users/chivakker","html_url":"https://github.com/chivakker","followers_url":"https://api.github.com/users/chivakker/followers","following_url":"https://api.github.com/users/chivakker/following{/other_user}","gists_url":"https://api.github.com/users/chivakker/gists{/gist_id}","starred_url":"https://api.github.com/users/chivakker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chivakker/subscriptions","organizations_url":"https://api.github.com/users/chivakker/orgs","repos_url":"https://api.github.com/users/chivakker/repos","events_url":"https://api.github.com/users/chivakker/events{/privacy}","received_events_url":"https://api.github.com/users/chivakker/received_events","type":"User","site_admin":false},"body":"Return gets hidden in the macro; making it a inline function will have a return value and hence better readable on this function.","created_at":"2016-08-04T16:48:10Z","updated_at":"2016-08-04T16:48:10Z","html_url":"https://github.com/01org/libyami/pull/524#discussion_r73559327","pull_request_url":"https://api.github.com/repos/01org/libyami/pulls/524","_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments/73559327"},"html":{"href":"https://github.com/01org/libyami/pull/524#discussion_r73559327"},"pull_request":{"href":"https://api.github.com/repos/01org/libyami/pulls/524"}}},"pull_request":{"url":"https://api.github.com/repos/01org/libyami/pulls/524","id":79533198,"html_url":"https://github.com/01org/libyami/pull/524","diff_url":"https://github.com/01org/libyami/pull/524.diff","patch_url":"https://github.com/01org/libyami/pull/524.patch","issue_url":"https://api.github.com/repos/01org/libyami/issues/524","number":524,"state":"open","locked":false,"title":"h264dec: check read beyond boundary for every bit","user":{"login":"xuguangxin","id":6667546,"avatar_url":"https://avatars.githubusercontent.com/u/6667546?v=3","gravatar_id":"","url":"https://api.github.com/users/xuguangxin","html_url":"https://github.com/xuguangxin","followers_url":"https://api.github.com/users/xuguangxin/followers","following_url":"https://api.github.com/users/xuguangxin/following{/other_user}","gists_url":"https://api.github.com/users/xuguangxin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuguangxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuguangxin/subscriptions","organizations_url":"https://api.github.com/users/xuguangxin/orgs","repos_url":"https://api.github.com/users/xuguangxin/repos","events_url":"https://api.github.com/users/xuguangxin/events{/privacy}","received_events_url":"https://api.github.com/users/xuguangxin/received_events","type":"User","site_admin":false},"body":"We need check read beyond boundary. To make sure we can detect error bitstream as early as possible.\r\nIf we do not check this, maybe we will encounter a serious error.\r\n#495 is good example","created_at":"2016-08-01T08:44:18Z","updated_at":"2016-08-04T16:48:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c962b29943afc01fde53130a0ea916cd75b0005","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/libyami/pulls/524/commits","review_comments_url":"https://api.github.com/repos/01org/libyami/pulls/524/comments","review_comment_url":"https://api.github.com/repos/01org/libyami/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/libyami/issues/524/comments","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/3cdecdb4545b3cf713eb3e49b7a198e699699e11","head":{"label":"xuguangxin:h264_checkread","ref":"h264_checkread","sha":"3cdecdb4545b3cf713eb3e49b7a198e699699e11","user":{"login":"xuguangxin","id":6667546,"avatar_url":"https://avatars.githubusercontent.com/u/6667546?v=3","gravatar_id":"","url":"https://api.github.com/users/xuguangxin","html_url":"https://github.com/xuguangxin","followers_url":"https://api.github.com/users/xuguangxin/followers","following_url":"https://api.github.com/users/xuguangxin/following{/other_user}","gists_url":"https://api.github.com/users/xuguangxin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuguangxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuguangxin/subscriptions","organizations_url":"https://api.github.com/users/xuguangxin/orgs","repos_url":"https://api.github.com/users/xuguangxin/repos","events_url":"https://api.github.com/users/xuguangxin/events{/privacy}","received_events_url":"https://api.github.com/users/xuguangxin/received_events","type":"User","site_admin":false},"repo":{"id":19519730,"name":"libyami","full_name":"xuguangxin/libyami","owner":{"login":"xuguangxin","id":6667546,"avatar_url":"https://avatars.githubusercontent.com/u/6667546?v=3","gravatar_id":"","url":"https://api.github.com/users/xuguangxin","html_url":"https://github.com/xuguangxin","followers_url":"https://api.github.com/users/xuguangxin/followers","following_url":"https://api.github.com/users/xuguangxin/following{/other_user}","gists_url":"https://api.github.com/users/xuguangxin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuguangxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuguangxin/subscriptions","organizations_url":"https://api.github.com/users/xuguangxin/orgs","repos_url":"https://api.github.com/users/xuguangxin/repos","events_url":"https://api.github.com/users/xuguangxin/events{/privacy}","received_events_url":"https://api.github.com/users/xuguangxin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xuguangxin/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":true,"url":"https://api.github.com/repos/xuguangxin/libyami","forks_url":"https://api.github.com/repos/xuguangxin/libyami/forks","keys_url":"https://api.github.com/repos/xuguangxin/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xuguangxin/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xuguangxin/libyami/teams","hooks_url":"https://api.github.com/repos/xuguangxin/libyami/hooks","issue_events_url":"https://api.github.com/repos/xuguangxin/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/xuguangxin/libyami/events","assignees_url":"https://api.github.com/repos/xuguangxin/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/xuguangxin/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/xuguangxin/libyami/tags","blobs_url":"https://api.github.com/repos/xuguangxin/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xuguangxin/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xuguangxin/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/xuguangxin/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xuguangxin/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/xuguangxin/libyami/languages","stargazers_url":"https://api.github.com/repos/xuguangxin/libyami/stargazers","contributors_url":"https://api.github.com/repos/xuguangxin/libyami/contributors","subscribers_url":"https://api.github.com/repos/xuguangxin/libyami/subscribers","subscription_url":"https://api.github.com/repos/xuguangxin/libyami/subscription","commits_url":"https://api.github.com/repos/xuguangxin/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/xuguangxin/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/xuguangxin/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/xuguangxin/libyami/issues/comments{/number}","contents_url":"https://api.github.com/repos/xuguangxin/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/xuguangxin/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xuguangxin/libyami/merges","archive_url":"https://api.github.com/repos/xuguangxin/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xuguangxin/libyami/downloads","issues_url":"https://api.github.com/repos/xuguangxin/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/xuguangxin/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/xuguangxin/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/xuguangxin/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xuguangxin/libyami/labels{/name}","releases_url":"https://api.github.com/repos/xuguangxin/libyami/releases{/id}","deployments_url":"https://api.github.com/repos/xuguangxin/libyami/deployments","created_at":"2014-05-07T03:21:18Z","updated_at":"2015-08-06T05:27:58Z","pushed_at":"2016-08-01T08:41:36Z","git_url":"git://github.com/xuguangxin/libyami.git","ssh_url":"git@github.com:xuguangxin/libyami.git","clone_url":"https://github.com/xuguangxin/libyami.git","svn_url":"https://github.com/xuguangxin/libyami","homepage":null,"size":3809,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:apache","ref":"apache","sha":"509d0cda8071073e302a11b9f17cdfbc71144721","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":18320220,"name":"libyami","full_name":"01org/libyami","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":false,"url":"https://api.github.com/repos/01org/libyami","forks_url":"https://api.github.com/repos/01org/libyami/forks","keys_url":"https://api.github.com/repos/01org/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/libyami/teams","hooks_url":"https://api.github.com/repos/01org/libyami/hooks","issue_events_url":"https://api.github.com/repos/01org/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/01org/libyami/events","assignees_url":"https://api.github.com/repos/01org/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/01org/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/01org/libyami/tags","blobs_url":"https://api.github.com/repos/01org/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/libyami/languages","stargazers_url":"https://api.github.com/repos/01org/libyami/stargazers","contributors_url":"https://api.github.com/repos/01org/libyami/contributors","subscribers_url":"https://api.github.com/repos/01org/libyami/subscribers","subscription_url":"https://api.github.com/repos/01org/libyami/subscription","commits_url":"https://api.github.com/repos/01org/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/libyami/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/01org/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/libyami/merges","archive_url":"https://api.github.com/repos/01org/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/libyami/downloads","issues_url":"https://api.github.com/repos/01org/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/01org/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/libyami/labels{/name}","releases_url":"https://api.github.com/repos/01org/libyami/releases{/id}","deployments_url":"https://api.github.com/repos/01org/libyami/deployments","created_at":"2014-04-01T06:44:19Z","updated_at":"2016-07-10T11:22:09Z","pushed_at":"2016-08-04T07:49:04Z","git_url":"git://github.com/01org/libyami.git","ssh_url":"git@github.com:01org/libyami.git","clone_url":"https://github.com/01org/libyami.git","svn_url":"https://github.com/01org/libyami","homepage":null,"size":4840,"stargazers_count":36,"watchers_count":36,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":31,"forks":53,"open_issues":31,"watchers":36,"default_branch":"apache"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/524"},"html":{"href":"https://github.com/01org/libyami/pull/524"},"issue":{"href":"https://api.github.com/repos/01org/libyami/issues/524"},"comments":{"href":"https://api.github.com/repos/01org/libyami/issues/524/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/libyami/pulls/524/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/libyami/pulls/524/commits"},"statuses":{"href":"https://api.github.com/repos/01org/libyami/statuses/3cdecdb4545b3cf713eb3e49b7a198e699699e11"}}}}
{"actor":{"display_login":"chivakker"}}