{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/84853646","pull_request_review_id":5603528,"id":84853646,"diff_hunk":"@@ -9,6 +10,11 @@\n   let(:included_in_price) { false }\n   subject(:calculator) { Spree::Calculator::DefaultTax.new(calculable: rate ) }\n \n+  describe \".description\" do","path":"core/spec/models/spree/calculator/default_tax_spec.rb","position":10,"original_position":10,"commit_id":"61f6c19d85409a7dab7dfba5dbd7c78f868f30ad","original_commit_id":"185f78d41d20525797deb188e8c2a21e415fbab8","user":{"login":"mamhoff","id":703401,"avatar_url":"https://avatars.githubusercontent.com/u/703401?v=3","gravatar_id":"","url":"https://api.github.com/users/mamhoff","html_url":"https://github.com/mamhoff","followers_url":"https://api.github.com/users/mamhoff/followers","following_url":"https://api.github.com/users/mamhoff/following{/other_user}","gists_url":"https://api.github.com/users/mamhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mamhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamhoff/subscriptions","organizations_url":"https://api.github.com/users/mamhoff/orgs","repos_url":"https://api.github.com/users/mamhoff/repos","events_url":"https://api.github.com/users/mamhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mamhoff/received_events","type":"User","site_admin":false},"body":"@gevann I second this thought. In the individual calculator specs, we only want to see something like `it_behaves_like \"a calculator with a description\"`. The `describe` block can go into the shared example. ","created_at":"2016-10-25T08:34:11Z","updated_at":"2016-10-25T08:34:11Z","html_url":"https://github.com/solidusio/solidus/pull/1546#discussion_r84853646","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/1546","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/84853646"},"html":{"href":"https://github.com/solidusio/solidus/pull/1546#discussion_r84853646"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1546"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1546","id":90280126,"html_url":"https://github.com/solidusio/solidus/pull/1546","diff_url":"https://github.com/solidusio/solidus/pull/1546.diff","patch_url":"https://github.com/solidusio/solidus/pull/1546.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1546","number":1546,"state":"open","locked":false,"title":"Use actionmodel naming for calculators","user":{"login":"gevann","id":6427337,"avatar_url":"https://avatars.githubusercontent.com/u/6427337?v=3","gravatar_id":"","url":"https://api.github.com/users/gevann","html_url":"https://github.com/gevann","followers_url":"https://api.github.com/users/gevann/followers","following_url":"https://api.github.com/users/gevann/following{/other_user}","gists_url":"https://api.github.com/users/gevann/gists{/gist_id}","starred_url":"https://api.github.com/users/gevann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gevann/subscriptions","organizations_url":"https://api.github.com/users/gevann/orgs","repos_url":"https://api.github.com/users/gevann/repos","events_url":"https://api.github.com/users/gevann/events{/privacy}","received_events_url":"https://api.github.com/users/gevann/received_events","type":"User","site_admin":false},"body":"This PR is based on #1538 and closes #1544","created_at":"2016-10-20T21:00:03Z","updated_at":"2016-10-25T08:34:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"151731e0c62b3971dba63a8ed3e7852814e83ada","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/1546/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/1546/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1546/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/61f6c19d85409a7dab7dfba5dbd7c78f868f30ad","head":{"label":"gevann:use-actionmodel-naming-for-calculators","ref":"use-actionmodel-naming-for-calculators","sha":"61f6c19d85409a7dab7dfba5dbd7c78f868f30ad","user":{"login":"gevann","id":6427337,"avatar_url":"https://avatars.githubusercontent.com/u/6427337?v=3","gravatar_id":"","url":"https://api.github.com/users/gevann","html_url":"https://github.com/gevann","followers_url":"https://api.github.com/users/gevann/followers","following_url":"https://api.github.com/users/gevann/following{/other_user}","gists_url":"https://api.github.com/users/gevann/gists{/gist_id}","starred_url":"https://api.github.com/users/gevann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gevann/subscriptions","organizations_url":"https://api.github.com/users/gevann/orgs","repos_url":"https://api.github.com/users/gevann/repos","events_url":"https://api.github.com/users/gevann/events{/privacy}","received_events_url":"https://api.github.com/users/gevann/received_events","type":"User","site_admin":false},"repo":{"id":66890108,"name":"solidus-1","full_name":"gevann/solidus-1","owner":{"login":"gevann","id":6427337,"avatar_url":"https://avatars.githubusercontent.com/u/6427337?v=3","gravatar_id":"","url":"https://api.github.com/users/gevann","html_url":"https://github.com/gevann","followers_url":"https://api.github.com/users/gevann/followers","following_url":"https://api.github.com/users/gevann/following{/other_user}","gists_url":"https://api.github.com/users/gevann/gists{/gist_id}","starred_url":"https://api.github.com/users/gevann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gevann/subscriptions","organizations_url":"https://api.github.com/users/gevann/orgs","repos_url":"https://api.github.com/users/gevann/repos","events_url":"https://api.github.com/users/gevann/events{/privacy}","received_events_url":"https://api.github.com/users/gevann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gevann/solidus-1","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/gevann/solidus-1","forks_url":"https://api.github.com/repos/gevann/solidus-1/forks","keys_url":"https://api.github.com/repos/gevann/solidus-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gevann/solidus-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gevann/solidus-1/teams","hooks_url":"https://api.github.com/repos/gevann/solidus-1/hooks","issue_events_url":"https://api.github.com/repos/gevann/solidus-1/issues/events{/number}","events_url":"https://api.github.com/repos/gevann/solidus-1/events","assignees_url":"https://api.github.com/repos/gevann/solidus-1/assignees{/user}","branches_url":"https://api.github.com/repos/gevann/solidus-1/branches{/branch}","tags_url":"https://api.github.com/repos/gevann/solidus-1/tags","blobs_url":"https://api.github.com/repos/gevann/solidus-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gevann/solidus-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gevann/solidus-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/gevann/solidus-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gevann/solidus-1/statuses/{sha}","languages_url":"https://api.github.com/repos/gevann/solidus-1/languages","stargazers_url":"https://api.github.com/repos/gevann/solidus-1/stargazers","contributors_url":"https://api.github.com/repos/gevann/solidus-1/contributors","subscribers_url":"https://api.github.com/repos/gevann/solidus-1/subscribers","subscription_url":"https://api.github.com/repos/gevann/solidus-1/subscription","commits_url":"https://api.github.com/repos/gevann/solidus-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/gevann/solidus-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/gevann/solidus-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/gevann/solidus-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/gevann/solidus-1/contents/{+path}","compare_url":"https://api.github.com/repos/gevann/solidus-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gevann/solidus-1/merges","archive_url":"https://api.github.com/repos/gevann/solidus-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gevann/solidus-1/downloads","issues_url":"https://api.github.com/repos/gevann/solidus-1/issues{/number}","pulls_url":"https://api.github.com/repos/gevann/solidus-1/pulls{/number}","milestones_url":"https://api.github.com/repos/gevann/solidus-1/milestones{/number}","notifications_url":"https://api.github.com/repos/gevann/solidus-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gevann/solidus-1/labels{/name}","releases_url":"https://api.github.com/repos/gevann/solidus-1/releases{/id}","deployments_url":"https://api.github.com/repos/gevann/solidus-1/deployments","created_at":"2016-08-30T00:05:38Z","updated_at":"2016-08-30T00:05:42Z","pushed_at":"2016-10-24T17:22:15Z","git_url":"git://github.com/gevann/solidus-1.git","ssh_url":"git@github.com:gevann/solidus-1.git","clone_url":"https://github.com/gevann/solidus-1.git","svn_url":"https://github.com/gevann/solidus-1","homepage":"http://solidus.io/","size":64899,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"748ceb97201273d92d71d926a3a93eecf3712526","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2016-10-23T13:34:43Z","pushed_at":"2016-10-24T23:06:31Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"https://solidus.io/","size":71431,"stargazers_count":1143,"watchers_count":1143,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":358,"mirror_url":null,"open_issues_count":191,"forks":358,"open_issues":191,"watchers":1143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1546"},"html":{"href":"https://github.com/solidusio/solidus/pull/1546"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1546"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1546/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1546/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1546/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/61f6c19d85409a7dab7dfba5dbd7c78f868f30ad"}}}}
{"actor":{"display_login":"mamhoff"}}