{"push_id":992979561,"size":5,"distinct_size":1,"ref":"refs/heads/master","head":"c0dee4a2393e23b226e123a427898de94b342141","before":"5163d89155eec6b6b39994d0cd18e6ceeff8b180","commits":[{"sha":"a534036c8d036275aa802f86470d67e4ee46db96","author":{"email":"143a18b53deb6612d517b2e11f8086b561f1df57@lelutin.ca","name":"Gabriel Filion"},"message":"parametrize nagios::nrpe\n\nthe current code for configuring NRPE is still relying on global\nvariables. This is not working at all with puppet 3.x and forward, so in\norder to make this code functional, we need to parametrize values that\nare used.","distinct":false,"url":"https://api.github.com/repos/lelutin/puppet-nagios/commits/a534036c8d036275aa802f86470d67e4ee46db96"},{"sha":"c6faaaf04cbf33db4430893b6b0eeacfc5f74776","author":{"email":"143a18b53deb6612d517b2e11f8086b561f1df57@lelutin.ca","name":"Gabriel Filion"},"message":"nrpe: parametrize dont_blame_nrpe\n\nThis value is used in order to enable or disable arguments to nrpe\ncommands. Since some ppl might need to enable it, we should parametrize\nit.","distinct":false,"url":"https://api.github.com/repos/lelutin/puppet-nagios/commits/c6faaaf04cbf33db4430893b6b0eeacfc5f74776"},{"sha":"f052a673dcbe532860c80c3e7ebf6d393c452473","author":{"email":"143a18b53deb6612d517b2e11f8086b561f1df57@lelutin.ca","name":"Gabriel Filion"},"message":"disable NRPE command arguments by default\n\nsetting dont_blame_nrpe is useful for some, but it's generally dangerous\nand should be disabled if it's not used.\n\nIn this sense, it's a better idea to disable this by default.","distinct":false,"url":"https://api.github.com/repos/lelutin/puppet-nagios/commits/f052a673dcbe532860c80c3e7ebf6d393c452473"},{"sha":"2892e1795a823c2bee2893bc339854dd4f5e5b94","author":{"email":"143a18b53deb6612d517b2e11f8086b561f1df57@lelutin.ca","name":"Gabriel Filion"},"message":"Document how to use the nagios::nrpe class","distinct":false,"url":"https://api.github.com/repos/lelutin/puppet-nagios/commits/2892e1795a823c2bee2893bc339854dd4f5e5b94"},{"sha":"c0dee4a2393e23b226e123a427898de94b342141","author":{"email":"143a18b53deb6612d517b2e11f8086b561f1df57@lelutin.ca","name":"LeLutin"},"message":"Merge branch 'nrpe_params' into 'master'\r\n\r\nNrpe params\r\n\r\nThe nagios::nrpe class is currently completely unusable with puppet 3.x+\r\n\r\nThis is because it's still relying on global variables. When one tries to setup an nrpe client with nagios::nrpe with puppet 3.x, the following error occurs:\r\n\r\n~~~\r\n==> jessiepuppet: Error: Failed to parse template nagios/nrpe/nrpe.cfg:\r\n==> jessiepuppet:   Filepath: /usr/lib/ruby/vendor_ruby/puppet/parser/templatewrapper.rb\r\n==> jessiepuppet:   Line: 81\r\n==> jessiepuppet:   Detail: Could not find value for 'nagios_nrpe_pid_file' at /etc/puppet/modules/nagios/templates/nrpe/nrpe.cfg:19\r\n==> jessiepuppet:  at /etc/puppet/modules/nagios/manifests/nrpe/base.pp:22 on node jessie.vagrantup.com\r\n==> jessiepuppet: Error: Failed to parse template nagios/nrpe/nrpe.cfg:\r\n==> jessiepuppet:   Filepath: /usr/lib/ruby/vendor_ruby/puppet/parser/templatewrapper.rb\r\n==> jessiepuppet:   Line: 81\r\n==> jessiepuppet:   Detail: Could not find value for 'nagios_nrpe_pid_file' at /etc/puppet/modules/nagios/templates/nrpe/nrpe.cfg:19\r\n==> jessiepuppet:  at /etc/puppet/modules/nagios/manifests/nrpe/base.pp:22 on node jessie.vagrantup.com\r\n~~~\r\n\r\nThis is because the values of variables defined within nagios::nrpe are not propagated into other classes anymore.\r\n\r\nThis series also changes a default behaviour for creating saner configurations by default: the dont_blame_nrpe option is changed to disable command arguments by default.\r\n\r\nIt also adds some documentation for the nagios::nrpe class since it had no explanation whatsoever of how it should be used in the README.\r\n\r\nSee merge request !18","distinct":true,"url":"https://api.github.com/repos/lelutin/puppet-nagios/commits/c0dee4a2393e23b226e123a427898de94b342141"}]}