{"action":"closed","issue":{"url":"https://api.github.com/repos/18F/api.data.gov/issues/334","repository_url":"https://api.github.com/repos/18F/api.data.gov","labels_url":"https://api.github.com/repos/18F/api.data.gov/issues/334/labels{/name}","comments_url":"https://api.github.com/repos/18F/api.data.gov/issues/334/comments","events_url":"https://api.github.com/repos/18F/api.data.gov/issues/334/events","html_url":"https://github.com/18F/api.data.gov/issues/334","id":151702207,"number":334,"title":"Search issues in admin","user":{"login":"GUI","id":12112,"avatar_url":"https://avatars.githubusercontent.com/u/12112?v=3","gravatar_id":"","url":"https://api.github.com/users/GUI","html_url":"https://github.com/GUI","followers_url":"https://api.github.com/users/GUI/followers","following_url":"https://api.github.com/users/GUI/following{/other_user}","gists_url":"https://api.github.com/users/GUI/gists{/gist_id}","starred_url":"https://api.github.com/users/GUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GUI/subscriptions","organizations_url":"https://api.github.com/users/GUI/orgs","repos_url":"https://api.github.com/users/GUI/repos","events_url":"https://api.github.com/users/GUI/events{/privacy}","received_events_url":"https://api.github.com/users/GUI/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-28T17:43:26Z","updated_at":"2016-04-28T17:46:36Z","closed_at":"2016-04-28T17:46:35Z","body":"The search field that's present on most of the listing pages in the admin screens (for example, API Backends, API Users, etc) could fail to return results as expected if you searched for special characters. For example, if you searched for `(foo`, you'd get alert errors. Searching for other special characters may have resulted in no search results at all.\r\n\r\nThe reason for the issues was that we were treating these searches as regular expressions, rather than a simple \"contains\" type of search. This regex handling wasn't intended and caused for this type of unintuitive behavior when your searches happened to contain any regex special characters.\r\n\r\nThe other issue with the regex handling was that the regexes could potentially be abused by a nefarious admin to eat CPU cycles on our servers (see [regular expression denial of service](https://en.wikipedia.org/wiki/ReDoS)). This was limited to admins, since they were the only ones that could hit these endpoints, and we never saw any activity like this, but regardless, it's good to mitigate this type of issue."}}