{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/55476262","id":55476262,"diff_hunk":"@@ -1,7 +1,9 @@\n <div>\n-  Name that uniquely identifies a agent within this Jenkins installation.\n-\n+  Name that uniquely identifies an agent within this Jenkins installation.\n   <p>\n-  This value could be any string, and doesn't have to be the same as the agent host name,\n-  but it's often convenient to make them the same.\n+  This does not have to be the same as the agent hostname (where applicable),\n+  but it is often convenient to make them the same.\n+  <p>\n+  The name may not contain any characters from this list:\n+  <tt>?*/\\\\%!@#$^&|<>[]:;</tt>","path":"core/src/main/resources/hudson/model/Node/help-name.html","position":12,"original_position":12,"commit_id":"e0804f628e529a061734a3252bc63c053a264cc6","original_commit_id":"e0804f628e529a061734a3252bc63c053a264cc6","user":{"login":"batmat","id":223853,"avatar_url":"https://avatars.githubusercontent.com/u/223853?v=3","gravatar_id":"","url":"https://api.github.com/users/batmat","html_url":"https://github.com/batmat","followers_url":"https://api.github.com/users/batmat/followers","following_url":"https://api.github.com/users/batmat/following{/other_user}","gists_url":"https://api.github.com/users/batmat/gists{/gist_id}","starred_url":"https://api.github.com/users/batmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batmat/subscriptions","organizations_url":"https://api.github.com/users/batmat/orgs","repos_url":"https://api.github.com/users/batmat/repos","events_url":"https://api.github.com/users/batmat/events{/privacy}","received_events_url":"https://api.github.com/users/batmat/received_events","type":"User","site_admin":false},"body":"right. /me think this would still preferable in general as IMO it's a browser matter and we're not sure it's gonna render fine everywhere (or less sure I guess).","created_at":"2016-03-09T06:17:42Z","updated_at":"2016-03-09T06:17:42Z","html_url":"https://github.com/jenkinsci/jenkins/pull/2101#discussion_r55476262","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2101","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/55476262"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2101#discussion_r55476262"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2101"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2101","id":62170089,"html_url":"https://github.com/jenkinsci/jenkins/pull/2101","diff_url":"https://github.com/jenkinsci/jenkins/pull/2101.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2101.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2101","number":2101,"state":"open","locked":false,"title":"[WIP][JENKINS-33364] Ensure everything in core has inline documentation","user":{"login":"orrc","id":138615,"avatar_url":"https://avatars.githubusercontent.com/u/138615?v=3","gravatar_id":"","url":"https://api.github.com/users/orrc","html_url":"https://github.com/orrc","followers_url":"https://api.github.com/users/orrc/followers","following_url":"https://api.github.com/users/orrc/following{/other_user}","gists_url":"https://api.github.com/users/orrc/gists{/gist_id}","starred_url":"https://api.github.com/users/orrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orrc/subscriptions","organizations_url":"https://api.github.com/users/orrc/orgs","repos_url":"https://api.github.com/users/orrc/repos","events_url":"https://api.github.com/users/orrc/events{/privacy}","received_events_url":"https://api.github.com/users/orrc/received_events","type":"User","site_admin":false},"body":"Ticket: https://issues.jenkins-ci.org/browse/JENKINS-33364\r\n\r\nI'm going through Jenkins core on the 2.0 branch (without any plugins), and fixing up documentation to be more consistent, removing unnecessary detail, fixing broken English, replacing stray instances of \"slave\" with \"agent\", and adding documentation where it's missing entirely.\r\n\r\nMy mini \"styleguide\" of terms so far (open to discussion):\r\n\r\nCanonical term | Term(s) to be replaced | Comments\r\n--- | --- | ---\r\nan agent | a agent, slave | There are stray usages of the old term, and search-replace errors where \"a\" instead of \"an\" is used\r\nfor example | for instance | There *is* a difference, but it's unlikely that we will need \"for instance\"\r\nhostname | host name, host-name | [Most common usage](https://en.wikipedia.org/wiki/Hostname)\r\nlog in | login (verb) | Login is **not** a verb; it's ok when used as a noun\r\nmaster | Master | Keep it lowercase\r\nonline | on-line | \r\nuse | utilize | Keep it simple\r\ndoes not | doesn't | \r\nit is | it's\r\n---\r\nThis is still very much a work-in-progress; so far I have half of the \"Add Agent\" screen done.","created_at":"2016-03-09T02:14:07Z","updated_at":"2016-03-09T06:17:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec9e1a3cad2d3145e29a3a4f2d8273b52ab14dfc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2101/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2101/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2101/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/e0804f628e529a061734a3252bc63c053a264cc6","head":{"label":"orrc:JENKINS-33364","ref":"JENKINS-33364","sha":"e0804f628e529a061734a3252bc63c053a264cc6","user":{"login":"orrc","id":138615,"avatar_url":"https://avatars.githubusercontent.com/u/138615?v=3","gravatar_id":"","url":"https://api.github.com/users/orrc","html_url":"https://github.com/orrc","followers_url":"https://api.github.com/users/orrc/followers","following_url":"https://api.github.com/users/orrc/following{/other_user}","gists_url":"https://api.github.com/users/orrc/gists{/gist_id}","starred_url":"https://api.github.com/users/orrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orrc/subscriptions","organizations_url":"https://api.github.com/users/orrc/orgs","repos_url":"https://api.github.com/users/orrc/repos","events_url":"https://api.github.com/users/orrc/events{/privacy}","received_events_url":"https://api.github.com/users/orrc/received_events","type":"User","site_admin":false},"repo":{"id":53459628,"name":"jenkins","full_name":"orrc/jenkins","owner":{"login":"orrc","id":138615,"avatar_url":"https://avatars.githubusercontent.com/u/138615?v=3","gravatar_id":"","url":"https://api.github.com/users/orrc","html_url":"https://github.com/orrc","followers_url":"https://api.github.com/users/orrc/followers","following_url":"https://api.github.com/users/orrc/following{/other_user}","gists_url":"https://api.github.com/users/orrc/gists{/gist_id}","starred_url":"https://api.github.com/users/orrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orrc/subscriptions","organizations_url":"https://api.github.com/users/orrc/orgs","repos_url":"https://api.github.com/users/orrc/repos","events_url":"https://api.github.com/users/orrc/events{/privacy}","received_events_url":"https://api.github.com/users/orrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/orrc/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/orrc/jenkins","forks_url":"https://api.github.com/repos/orrc/jenkins/forks","keys_url":"https://api.github.com/repos/orrc/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orrc/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orrc/jenkins/teams","hooks_url":"https://api.github.com/repos/orrc/jenkins/hooks","issue_events_url":"https://api.github.com/repos/orrc/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/orrc/jenkins/events","assignees_url":"https://api.github.com/repos/orrc/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/orrc/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/orrc/jenkins/tags","blobs_url":"https://api.github.com/repos/orrc/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orrc/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orrc/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/orrc/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orrc/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/orrc/jenkins/languages","stargazers_url":"https://api.github.com/repos/orrc/jenkins/stargazers","contributors_url":"https://api.github.com/repos/orrc/jenkins/contributors","subscribers_url":"https://api.github.com/repos/orrc/jenkins/subscribers","subscription_url":"https://api.github.com/repos/orrc/jenkins/subscription","commits_url":"https://api.github.com/repos/orrc/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/orrc/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/orrc/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/orrc/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/orrc/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/orrc/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orrc/jenkins/merges","archive_url":"https://api.github.com/repos/orrc/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orrc/jenkins/downloads","issues_url":"https://api.github.com/repos/orrc/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/orrc/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/orrc/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/orrc/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orrc/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/orrc/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/orrc/jenkins/deployments","created_at":"2016-03-09T01:54:43Z","updated_at":"2016-03-09T01:55:06Z","pushed_at":"2016-03-09T01:59:05Z","git_url":"git://github.com/orrc/jenkins.git","ssh_url":"git@github.com:orrc/jenkins.git","clone_url":"https://github.com/orrc/jenkins.git","svn_url":"https://github.com/orrc/jenkins","homepage":"http://jenkins-ci.org/","size":91086,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:2.0","ref":"2.0","sha":"ede925cae3f08a40d57b3d6ff70b71c3d2e97e87","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2016-03-09T06:03:00Z","pushed_at":"2016-03-09T04:34:07Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":96550,"stargazers_count":5264,"watchers_count":5264,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2337,"mirror_url":null,"open_issues_count":148,"forks":2337,"open_issues":148,"watchers":5264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2101"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2101"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2101"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2101/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2101/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2101/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/e0804f628e529a061734a3252bc63c053a264cc6"}}}}