{"action":"opened","number":76,"pull_request":{"url":"https://api.github.com/repos/gandalfcode/gandalf/pulls/76","id":85561011,"html_url":"https://github.com/gandalfcode/gandalf/pull/76","diff_url":"https://github.com/gandalfcode/gandalf/pull/76.diff","patch_url":"https://github.com/gandalfcode/gandalf/pull/76.patch","issue_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/76","number":76,"state":"open","locked":false,"title":"Slope limiter testing","user":{"login":"rbooth200","id":15370420,"avatar_url":"https://avatars.githubusercontent.com/u/15370420?v=3","gravatar_id":"","url":"https://api.github.com/users/rbooth200","html_url":"https://github.com/rbooth200","followers_url":"https://api.github.com/users/rbooth200/followers","following_url":"https://api.github.com/users/rbooth200/following{/other_user}","gists_url":"https://api.github.com/users/rbooth200/gists{/gist_id}","starred_url":"https://api.github.com/users/rbooth200/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbooth200/subscriptions","organizations_url":"https://api.github.com/users/rbooth200/orgs","repos_url":"https://api.github.com/users/rbooth200/repos","events_url":"https://api.github.com/users/rbooth200/events{/privacy}","received_events_url":"https://api.github.com/users/rbooth200/received_events","type":"User","site_admin":false},"body":"I've modified the slope limiters and written some scripts to produce some comparisons between the various slope limiters. Since this branch is built upon the slope_limiter branch we had before I will delete that pull request and we should use this one instead.  This pull request includes the following:\r\n\r\n- updating the thermal properties after changes to the conserved quantities\r\n- recomputing the density for particles that become active, only if the density is out of date\r\n- I moved the various particle flags (active, potmin) to be part of the flags class.\r\n- Changes / generalizations to the slope limiter classes\r\n- Tests for the slope limiters.\r\n\r\nI've also attached  a couple of results from the slope limiter tests for the discussion. These can be used to rank the limiters by how diffusive they are.\r\n\r\n\r\n![adsod_rarefaction](https://cloud.githubusercontent.com/assets/15370420/18585139/fda8d414-7c0c-11e6-88df-48859d61c97c.png)\r\n![adsod_shock](https://cloud.githubusercontent.com/assets/15370420/18585140/fda93832-7c0c-11e6-8314-3397475078e0.png)\r\n![gresho](https://cloud.githubusercontent.com/assets/15370420/18585167/32396176-7c0d-11e6-87cf-d3e650c1c10e.png)\r\n","created_at":"2016-09-16T11:58:15Z","updated_at":"2016-09-16T11:58:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gandalfcode/gandalf/pulls/76/commits","review_comments_url":"https://api.github.com/repos/gandalfcode/gandalf/pulls/76/comments","review_comment_url":"https://api.github.com/repos/gandalfcode/gandalf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/76/comments","statuses_url":"https://api.github.com/repos/gandalfcode/gandalf/statuses/f2dc7880bd824c6441b9b9c8eebe749eb7553907","head":{"label":"gandalfcode:slope_limiter_testing","ref":"slope_limiter_testing","sha":"f2dc7880bd824c6441b9b9c8eebe749eb7553907","user":{"login":"gandalfcode","id":5112953,"avatar_url":"https://avatars.githubusercontent.com/u/5112953?v=3","gravatar_id":"","url":"https://api.github.com/users/gandalfcode","html_url":"https://github.com/gandalfcode","followers_url":"https://api.github.com/users/gandalfcode/followers","following_url":"https://api.github.com/users/gandalfcode/following{/other_user}","gists_url":"https://api.github.com/users/gandalfcode/gists{/gist_id}","starred_url":"https://api.github.com/users/gandalfcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandalfcode/subscriptions","organizations_url":"https://api.github.com/users/gandalfcode/orgs","repos_url":"https://api.github.com/users/gandalfcode/repos","events_url":"https://api.github.com/users/gandalfcode/events{/privacy}","received_events_url":"https://api.github.com/users/gandalfcode/received_events","type":"Organization","site_admin":false},"repo":{"id":11739204,"name":"gandalf","full_name":"gandalfcode/gandalf","owner":{"login":"gandalfcode","id":5112953,"avatar_url":"https://avatars.githubusercontent.com/u/5112953?v=3","gravatar_id":"","url":"https://api.github.com/users/gandalfcode","html_url":"https://github.com/gandalfcode","followers_url":"https://api.github.com/users/gandalfcode/followers","following_url":"https://api.github.com/users/gandalfcode/following{/other_user}","gists_url":"https://api.github.com/users/gandalfcode/gists{/gist_id}","starred_url":"https://api.github.com/users/gandalfcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandalfcode/subscriptions","organizations_url":"https://api.github.com/users/gandalfcode/orgs","repos_url":"https://api.github.com/users/gandalfcode/repos","events_url":"https://api.github.com/users/gandalfcode/events{/privacy}","received_events_url":"https://api.github.com/users/gandalfcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gandalfcode/gandalf","description":"GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)","fork":false,"url":"https://api.github.com/repos/gandalfcode/gandalf","forks_url":"https://api.github.com/repos/gandalfcode/gandalf/forks","keys_url":"https://api.github.com/repos/gandalfcode/gandalf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gandalfcode/gandalf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gandalfcode/gandalf/teams","hooks_url":"https://api.github.com/repos/gandalfcode/gandalf/hooks","issue_events_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/events{/number}","events_url":"https://api.github.com/repos/gandalfcode/gandalf/events","assignees_url":"https://api.github.com/repos/gandalfcode/gandalf/assignees{/user}","branches_url":"https://api.github.com/repos/gandalfcode/gandalf/branches{/branch}","tags_url":"https://api.github.com/repos/gandalfcode/gandalf/tags","blobs_url":"https://api.github.com/repos/gandalfcode/gandalf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gandalfcode/gandalf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gandalfcode/gandalf/git/refs{/sha}","trees_url":"https://api.github.com/repos/gandalfcode/gandalf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gandalfcode/gandalf/statuses/{sha}","languages_url":"https://api.github.com/repos/gandalfcode/gandalf/languages","stargazers_url":"https://api.github.com/repos/gandalfcode/gandalf/stargazers","contributors_url":"https://api.github.com/repos/gandalfcode/gandalf/contributors","subscribers_url":"https://api.github.com/repos/gandalfcode/gandalf/subscribers","subscription_url":"https://api.github.com/repos/gandalfcode/gandalf/subscription","commits_url":"https://api.github.com/repos/gandalfcode/gandalf/commits{/sha}","git_commits_url":"https://api.github.com/repos/gandalfcode/gandalf/git/commits{/sha}","comments_url":"https://api.github.com/repos/gandalfcode/gandalf/comments{/number}","issue_comment_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/comments{/number}","contents_url":"https://api.github.com/repos/gandalfcode/gandalf/contents/{+path}","compare_url":"https://api.github.com/repos/gandalfcode/gandalf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gandalfcode/gandalf/merges","archive_url":"https://api.github.com/repos/gandalfcode/gandalf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gandalfcode/gandalf/downloads","issues_url":"https://api.github.com/repos/gandalfcode/gandalf/issues{/number}","pulls_url":"https://api.github.com/repos/gandalfcode/gandalf/pulls{/number}","milestones_url":"https://api.github.com/repos/gandalfcode/gandalf/milestones{/number}","notifications_url":"https://api.github.com/repos/gandalfcode/gandalf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gandalfcode/gandalf/labels{/name}","releases_url":"https://api.github.com/repos/gandalfcode/gandalf/releases{/id}","deployments_url":"https://api.github.com/repos/gandalfcode/gandalf/deployments","created_at":"2013-07-29T12:36:37Z","updated_at":"2016-09-03T23:29:10Z","pushed_at":"2016-09-16T11:48:27Z","git_url":"git://github.com/gandalfcode/gandalf.git","ssh_url":"git@github.com:gandalfcode/gandalf.git","clone_url":"https://github.com/gandalfcode/gandalf.git","svn_url":"https://github.com/gandalfcode/gandalf","homepage":null,"size":6102,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":30,"forks":2,"open_issues":30,"watchers":10,"default_branch":"master"}},"base":{"label":"gandalfcode:master","ref":"master","sha":"8d10236f15eca563147d99b9d8fd2501e12b1556","user":{"login":"gandalfcode","id":5112953,"avatar_url":"https://avatars.githubusercontent.com/u/5112953?v=3","gravatar_id":"","url":"https://api.github.com/users/gandalfcode","html_url":"https://github.com/gandalfcode","followers_url":"https://api.github.com/users/gandalfcode/followers","following_url":"https://api.github.com/users/gandalfcode/following{/other_user}","gists_url":"https://api.github.com/users/gandalfcode/gists{/gist_id}","starred_url":"https://api.github.com/users/gandalfcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandalfcode/subscriptions","organizations_url":"https://api.github.com/users/gandalfcode/orgs","repos_url":"https://api.github.com/users/gandalfcode/repos","events_url":"https://api.github.com/users/gandalfcode/events{/privacy}","received_events_url":"https://api.github.com/users/gandalfcode/received_events","type":"Organization","site_admin":false},"repo":{"id":11739204,"name":"gandalf","full_name":"gandalfcode/gandalf","owner":{"login":"gandalfcode","id":5112953,"avatar_url":"https://avatars.githubusercontent.com/u/5112953?v=3","gravatar_id":"","url":"https://api.github.com/users/gandalfcode","html_url":"https://github.com/gandalfcode","followers_url":"https://api.github.com/users/gandalfcode/followers","following_url":"https://api.github.com/users/gandalfcode/following{/other_user}","gists_url":"https://api.github.com/users/gandalfcode/gists{/gist_id}","starred_url":"https://api.github.com/users/gandalfcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandalfcode/subscriptions","organizations_url":"https://api.github.com/users/gandalfcode/orgs","repos_url":"https://api.github.com/users/gandalfcode/repos","events_url":"https://api.github.com/users/gandalfcode/events{/privacy}","received_events_url":"https://api.github.com/users/gandalfcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gandalfcode/gandalf","description":"GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)","fork":false,"url":"https://api.github.com/repos/gandalfcode/gandalf","forks_url":"https://api.github.com/repos/gandalfcode/gandalf/forks","keys_url":"https://api.github.com/repos/gandalfcode/gandalf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gandalfcode/gandalf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gandalfcode/gandalf/teams","hooks_url":"https://api.github.com/repos/gandalfcode/gandalf/hooks","issue_events_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/events{/number}","events_url":"https://api.github.com/repos/gandalfcode/gandalf/events","assignees_url":"https://api.github.com/repos/gandalfcode/gandalf/assignees{/user}","branches_url":"https://api.github.com/repos/gandalfcode/gandalf/branches{/branch}","tags_url":"https://api.github.com/repos/gandalfcode/gandalf/tags","blobs_url":"https://api.github.com/repos/gandalfcode/gandalf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gandalfcode/gandalf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gandalfcode/gandalf/git/refs{/sha}","trees_url":"https://api.github.com/repos/gandalfcode/gandalf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gandalfcode/gandalf/statuses/{sha}","languages_url":"https://api.github.com/repos/gandalfcode/gandalf/languages","stargazers_url":"https://api.github.com/repos/gandalfcode/gandalf/stargazers","contributors_url":"https://api.github.com/repos/gandalfcode/gandalf/contributors","subscribers_url":"https://api.github.com/repos/gandalfcode/gandalf/subscribers","subscription_url":"https://api.github.com/repos/gandalfcode/gandalf/subscription","commits_url":"https://api.github.com/repos/gandalfcode/gandalf/commits{/sha}","git_commits_url":"https://api.github.com/repos/gandalfcode/gandalf/git/commits{/sha}","comments_url":"https://api.github.com/repos/gandalfcode/gandalf/comments{/number}","issue_comment_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/comments{/number}","contents_url":"https://api.github.com/repos/gandalfcode/gandalf/contents/{+path}","compare_url":"https://api.github.com/repos/gandalfcode/gandalf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gandalfcode/gandalf/merges","archive_url":"https://api.github.com/repos/gandalfcode/gandalf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gandalfcode/gandalf/downloads","issues_url":"https://api.github.com/repos/gandalfcode/gandalf/issues{/number}","pulls_url":"https://api.github.com/repos/gandalfcode/gandalf/pulls{/number}","milestones_url":"https://api.github.com/repos/gandalfcode/gandalf/milestones{/number}","notifications_url":"https://api.github.com/repos/gandalfcode/gandalf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gandalfcode/gandalf/labels{/name}","releases_url":"https://api.github.com/repos/gandalfcode/gandalf/releases{/id}","deployments_url":"https://api.github.com/repos/gandalfcode/gandalf/deployments","created_at":"2013-07-29T12:36:37Z","updated_at":"2016-09-03T23:29:10Z","pushed_at":"2016-09-16T11:48:27Z","git_url":"git://github.com/gandalfcode/gandalf.git","ssh_url":"git@github.com:gandalfcode/gandalf.git","clone_url":"https://github.com/gandalfcode/gandalf.git","svn_url":"https://github.com/gandalfcode/gandalf","homepage":null,"size":6102,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":30,"forks":2,"open_issues":30,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gandalfcode/gandalf/pulls/76"},"html":{"href":"https://github.com/gandalfcode/gandalf/pull/76"},"issue":{"href":"https://api.github.com/repos/gandalfcode/gandalf/issues/76"},"comments":{"href":"https://api.github.com/repos/gandalfcode/gandalf/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/gandalfcode/gandalf/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/gandalfcode/gandalf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gandalfcode/gandalf/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/gandalfcode/gandalf/statuses/f2dc7880bd824c6441b9b9c8eebe749eb7553907"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":1421,"deletions":556,"changed_files":35}}
{"actor":{"display_login":"rbooth200"}}