{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/59119245","id":59119245,"diff_hunk":"@@ -0,0 +1,156 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.sql.hive.execution\n+\n+import org.apache.hadoop.fs.Path\n+\n+import org.apache.spark.sql.{AnalysisException, QueryTest, SaveMode}\n+import org.apache.spark.sql.catalyst.catalog.CatalogTableType\n+import org.apache.spark.sql.catalyst.TableIdentifier\n+import org.apache.spark.sql.hive.test.TestHiveSingleton\n+import org.apache.spark.sql.internal.SQLConf\n+import org.apache.spark.sql.test.SQLTestUtils\n+\n+class HiveDDLSuite extends QueryTest with SQLTestUtils with TestHiveSingleton {\n+  import hiveContext.implicits._\n+\n+  // check if the directory for recording the data of the table exists.\n+  private def tableDirectoryExists(tableIdentifier: TableIdentifier): Boolean = {\n+    val expectedTablePath =\n+      hiveContext.sessionState.catalog.hiveDefaultTableFilePath(tableIdentifier)\n+    val filesystemPath = new Path(expectedTablePath)\n+    val fs = filesystemPath.getFileSystem(sparkContext.hadoopConfiguration)\n+    fs.exists(filesystemPath)\n+  }\n+\n+  test(\"drop tables\") {\n+    withTable(\"tab1\") {\n+      val tabName = \"tab1\"\n+\n+      assert(!tableDirectoryExists(TableIdentifier(tabName)))\n+      sql(s\"CREATE TABLE $tabName(c1 int)\")\n+\n+      assert(tableDirectoryExists(TableIdentifier(tabName)))\n+      sql(s\"DROP TABLE $tabName\")\n+\n+      assert(!tableDirectoryExists(TableIdentifier(tabName)))\n+      sql(s\"DROP TABLE IF EXISTS $tabName\")\n+      sql(s\"DROP VIEW IF EXISTS $tabName\")\n+    }\n+  }\n+\n+  test(\"drop managed tables\") {\n+    withTempDir { tmpDir =>\n+      val tabName = \"tab1\"\n+      withTable(tabName) {\n+        assert(tmpDir.listFiles.isEmpty)\n+        sql(\n+          s\"\"\"\n+             |create external table $tabName(c1 int COMMENT 'abc', c2 string)\n+             |stored as parquet\n+             |location '$tmpDir'\n+             |as select 1, '3'\n+          \"\"\".stripMargin)","path":"sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala","position":68,"original_position":68,"commit_id":"2f45c0df7717fd3eb52f6d8dc2f8d4dbcb584c9c","original_commit_id":"2f45c0df7717fd3eb52f6d8dc2f8d4dbcb584c9c","user":{"login":"yhuai","id":2072857,"avatar_url":"https://avatars.githubusercontent.com/u/2072857?v=3","gravatar_id":"","url":"https://api.github.com/users/yhuai","html_url":"https://github.com/yhuai","followers_url":"https://api.github.com/users/yhuai/followers","following_url":"https://api.github.com/users/yhuai/following{/other_user}","gists_url":"https://api.github.com/users/yhuai/gists{/gist_id}","starred_url":"https://api.github.com/users/yhuai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhuai/subscriptions","organizations_url":"https://api.github.com/users/yhuai/orgs","repos_url":"https://api.github.com/users/yhuai/repos","events_url":"https://api.github.com/users/yhuai/events{/privacy}","received_events_url":"https://api.github.com/users/yhuai/received_events","type":"User","site_admin":false},"body":"For an external table, table type needs to be EXTERNAL_TABLE and its table properties should have an entry EXTERNAL set to TRUE.","created_at":"2016-04-09T18:31:16Z","updated_at":"2016-04-09T18:31:16Z","html_url":"https://github.com/apache/spark/pull/12146#discussion_r59119245","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/12146","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/59119245"},"html":{"href":"https://github.com/apache/spark/pull/12146#discussion_r59119245"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/12146"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12146","id":65099100,"html_url":"https://github.com/apache/spark/pull/12146","diff_url":"https://github.com/apache/spark/pull/12146.diff","patch_url":"https://github.com/apache/spark/pull/12146.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/12146","number":12146,"state":"open","locked":false,"title":"[SPARK-14362] [SPARK-14406] [SQL] DDL Native Support: Drop View and Drop Table","user":{"login":"gatorsmile","id":11567269,"avatar_url":"https://avatars.githubusercontent.com/u/11567269?v=3","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"body":"#### What changes were proposed in this pull request?\r\n\r\nThis PR is to provide a native support for DDL `DROP VIEW` and `DROP TABLE`. The PR includes native parsing and native analysis.\r\n\r\nBased on the HIVE DDL document for [DROP_VIEW_WEB_LINK](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-\r\nDropView\r\n), `DROP VIEW` is defined as, \r\n**Syntax:**\r\n```SQL\r\nDROP VIEW [IF EXISTS] [db_name.]view_name;\r\n```\r\n - to remove metadata for the specified view. \r\n - illegal to use DROP TABLE on a view.\r\n - illegal to use DROP VIEW on a table.\r\n - this command only works in `HiveContext`. In `SQLContext`, we will get an exception. \r\n\r\nThis PR also handles `DROP TABLE`. \r\n**Syntax:**\r\n```SQL\r\nDROP TABLE [IF EXISTS] table_name [PURGE];\r\n```\r\n- Previously, the `DROP TABLE` command only can drop Hive tables in `HiveContext`. Now, after this PR, this command also can drop temporary table, external table, external data source table in `SQLContext`. \r\n- In `HiveContext`, we will not issue an exception if the to-be-dropped table does not exist and users did not specify `IF EXISTS`. Instead, we just log an error message. If `IF EXISTS` is specified, we will not issue any error message/exception.  \r\n- In `SQLContext`, we will issue an exception if the to-be-dropped table does not exist, unless `IF EXISTS` is specified.\r\n\r\n#### How was this patch tested?\r\nFor verifying command parsing, added test cases in `spark/sql/hive/HiveDDLCommandSuite.scala`\r\nFor verifying command analysis, added test cases in `spark/sql/hive/execution/HiveDDLSuite.scala`","created_at":"2016-04-04T05:58:30Z","updated_at":"2016-04-09T18:31:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d307f212756bf3f738bcc0f54930905aff03bc35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/12146/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/12146/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/12146/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/2f45c0df7717fd3eb52f6d8dc2f8d4dbcb584c9c","head":{"label":"gatorsmile:dropView","ref":"dropView","sha":"2f45c0df7717fd3eb52f6d8dc2f8d4dbcb584c9c","user":{"login":"gatorsmile","id":11567269,"avatar_url":"https://avatars.githubusercontent.com/u/11567269?v=3","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"repo":{"id":44710950,"name":"spark","full_name":"gatorsmile/spark","owner":{"login":"gatorsmile","id":11567269,"avatar_url":"https://avatars.githubusercontent.com/u/11567269?v=3","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gatorsmile/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/gatorsmile/spark","forks_url":"https://api.github.com/repos/gatorsmile/spark/forks","keys_url":"https://api.github.com/repos/gatorsmile/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gatorsmile/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gatorsmile/spark/teams","hooks_url":"https://api.github.com/repos/gatorsmile/spark/hooks","issue_events_url":"https://api.github.com/repos/gatorsmile/spark/issues/events{/number}","events_url":"https://api.github.com/repos/gatorsmile/spark/events","assignees_url":"https://api.github.com/repos/gatorsmile/spark/assignees{/user}","branches_url":"https://api.github.com/repos/gatorsmile/spark/branches{/branch}","tags_url":"https://api.github.com/repos/gatorsmile/spark/tags","blobs_url":"https://api.github.com/repos/gatorsmile/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gatorsmile/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gatorsmile/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/gatorsmile/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gatorsmile/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/gatorsmile/spark/languages","stargazers_url":"https://api.github.com/repos/gatorsmile/spark/stargazers","contributors_url":"https://api.github.com/repos/gatorsmile/spark/contributors","subscribers_url":"https://api.github.com/repos/gatorsmile/spark/subscribers","subscription_url":"https://api.github.com/repos/gatorsmile/spark/subscription","commits_url":"https://api.github.com/repos/gatorsmile/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/gatorsmile/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/gatorsmile/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/gatorsmile/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/gatorsmile/spark/contents/{+path}","compare_url":"https://api.github.com/repos/gatorsmile/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gatorsmile/spark/merges","archive_url":"https://api.github.com/repos/gatorsmile/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gatorsmile/spark/downloads","issues_url":"https://api.github.com/repos/gatorsmile/spark/issues{/number}","pulls_url":"https://api.github.com/repos/gatorsmile/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/gatorsmile/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/gatorsmile/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gatorsmile/spark/labels{/name}","releases_url":"https://api.github.com/repos/gatorsmile/spark/releases{/id}","deployments_url":"https://api.github.com/repos/gatorsmile/spark/deployments","created_at":"2015-10-21T23:48:23Z","updated_at":"2015-10-21T23:48:54Z","pushed_at":"2016-04-09T17:25:12Z","git_url":"git://github.com/gatorsmile/spark.git","ssh_url":"git@github.com:gatorsmile/spark.git","clone_url":"https://github.com/gatorsmile/spark.git","svn_url":"https://github.com/gatorsmile/spark","homepage":null,"size":156758,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"binaryOutput"}},"base":{"label":"apache:master","ref":"master","sha":"e0ad75f2b55772efc82a6f8ebb1b2d80fe27d9b5","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-04-09T16:50:49Z","pushed_at":"2016-04-09T18:26:01Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":454800,"stargazers_count":8065,"watchers_count":8065,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7467,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":424,"forks":7467,"open_issues":424,"watchers":8065,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/12146"},"html":{"href":"https://github.com/apache/spark/pull/12146"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/12146"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/12146/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/12146/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/12146/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/2f45c0df7717fd3eb52f6d8dc2f8d4dbcb584c9c"}}}}