{"action":"closed","number":27,"pull_request":{"url":"https://api.github.com/repos/IIIF/image-validator/pulls/27","id":45447635,"html_url":"https://github.com/IIIF/image-validator/pull/27","diff_url":"https://github.com/IIIF/image-validator/pull/27.diff","patch_url":"https://github.com/IIIF/image-validator/pull/27.patch","issue_url":"https://api.github.com/repos/IIIF/image-validator/issues/27","number":27,"state":"closed","locked":false,"title":"Validator: expanded JSON-LD type checks","user":{"login":"acdha","id":46565,"avatar_url":"https://avatars.githubusercontent.com/u/46565?v=3","gravatar_id":"","url":"https://api.github.com/users/acdha","html_url":"https://github.com/acdha","followers_url":"https://api.github.com/users/acdha/followers","following_url":"https://api.github.com/users/acdha/following{/other_user}","gists_url":"https://api.github.com/users/acdha/gists{/gist_id}","starred_url":"https://api.github.com/users/acdha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdha/subscriptions","organizations_url":"https://api.github.com/users/acdha/orgs","repos_url":"https://api.github.com/users/acdha/repos","events_url":"https://api.github.com/users/acdha/events{/privacy}","received_events_url":"https://api.github.com/users/acdha/received_events","type":"User","site_admin":false},"body":"The validator is currently stricter than http://iiif.io/api/image/2.1/index.html#information-request and requires all responses to be `application/ld+json`.\n\nThis branch splits the existing `jsonld` check into separate checks for both specified behaviours:\n- When the request does not have `Accept: application/ld+json` the response MUST be `application/json`\n- When JSON-LD is requested, the response must be either `application/ld+json` or have both the `application/json` Content-Type and a Link header specifying the standard context\n\nThe second check is still slightly unsatisfactory because we don't appear to have a way to specify warnings as opposed to outright errors. The specification recommends that JSON responses have the Link header but it's not a hard requirement and it might be useful to acknowledge that this is tolerable but should be fixed if possible.\n","created_at":"2015-09-18T20:12:44Z","updated_at":"2016-12-13T06:18:17Z","closed_at":"2016-12-13T06:18:17Z","merged_at":null,"merge_commit_sha":"5a69cd549610d9e5c834ac63d44452124d4b6577","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/IIIF/image-validator/pulls/27/commits","review_comments_url":"https://api.github.com/repos/IIIF/image-validator/pulls/27/comments","review_comment_url":"https://api.github.com/repos/IIIF/image-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IIIF/image-validator/issues/27/comments","statuses_url":"https://api.github.com/repos/IIIF/image-validator/statuses/8e67430f0a00e8c92a15680f49f5893d2ad1cfd8","head":{"label":"acdha:validator-expanded-json-ld-type-check","ref":"validator-expanded-json-ld-type-check","sha":"8e67430f0a00e8c92a15680f49f5893d2ad1cfd8","user":{"login":"acdha","id":46565,"avatar_url":"https://avatars.githubusercontent.com/u/46565?v=3","gravatar_id":"","url":"https://api.github.com/users/acdha","html_url":"https://github.com/acdha","followers_url":"https://api.github.com/users/acdha/followers","following_url":"https://api.github.com/users/acdha/following{/other_user}","gists_url":"https://api.github.com/users/acdha/gists{/gist_id}","starred_url":"https://api.github.com/users/acdha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdha/subscriptions","organizations_url":"https://api.github.com/users/acdha/orgs","repos_url":"https://api.github.com/users/acdha/repos","events_url":"https://api.github.com/users/acdha/events{/privacy}","received_events_url":"https://api.github.com/users/acdha/received_events","type":"User","site_admin":false},"repo":{"id":42743261,"name":"image-api","full_name":"acdha/image-api","owner":{"login":"acdha","id":46565,"avatar_url":"https://avatars.githubusercontent.com/u/46565?v=3","gravatar_id":"","url":"https://api.github.com/users/acdha","html_url":"https://github.com/acdha","followers_url":"https://api.github.com/users/acdha/followers","following_url":"https://api.github.com/users/acdha/following{/other_user}","gists_url":"https://api.github.com/users/acdha/gists{/gist_id}","starred_url":"https://api.github.com/users/acdha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdha/subscriptions","organizations_url":"https://api.github.com/users/acdha/orgs","repos_url":"https://api.github.com/users/acdha/repos","events_url":"https://api.github.com/users/acdha/events{/privacy}","received_events_url":"https://api.github.com/users/acdha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acdha/image-api","description":"Implementations of the IIIF Image API","fork":true,"url":"https://api.github.com/repos/acdha/image-api","forks_url":"https://api.github.com/repos/acdha/image-api/forks","keys_url":"https://api.github.com/repos/acdha/image-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acdha/image-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acdha/image-api/teams","hooks_url":"https://api.github.com/repos/acdha/image-api/hooks","issue_events_url":"https://api.github.com/repos/acdha/image-api/issues/events{/number}","events_url":"https://api.github.com/repos/acdha/image-api/events","assignees_url":"https://api.github.com/repos/acdha/image-api/assignees{/user}","branches_url":"https://api.github.com/repos/acdha/image-api/branches{/branch}","tags_url":"https://api.github.com/repos/acdha/image-api/tags","blobs_url":"https://api.github.com/repos/acdha/image-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acdha/image-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acdha/image-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/acdha/image-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acdha/image-api/statuses/{sha}","languages_url":"https://api.github.com/repos/acdha/image-api/languages","stargazers_url":"https://api.github.com/repos/acdha/image-api/stargazers","contributors_url":"https://api.github.com/repos/acdha/image-api/contributors","subscribers_url":"https://api.github.com/repos/acdha/image-api/subscribers","subscription_url":"https://api.github.com/repos/acdha/image-api/subscription","commits_url":"https://api.github.com/repos/acdha/image-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/acdha/image-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/acdha/image-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/acdha/image-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/acdha/image-api/contents/{+path}","compare_url":"https://api.github.com/repos/acdha/image-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acdha/image-api/merges","archive_url":"https://api.github.com/repos/acdha/image-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acdha/image-api/downloads","issues_url":"https://api.github.com/repos/acdha/image-api/issues{/number}","pulls_url":"https://api.github.com/repos/acdha/image-api/pulls{/number}","milestones_url":"https://api.github.com/repos/acdha/image-api/milestones{/number}","notifications_url":"https://api.github.com/repos/acdha/image-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acdha/image-api/labels{/name}","releases_url":"https://api.github.com/repos/acdha/image-api/releases{/id}","deployments_url":"https://api.github.com/repos/acdha/image-api/deployments","created_at":"2015-09-18T19:33:01Z","updated_at":"2015-09-18T19:33:02Z","pushed_at":"2015-09-21T20:09:56Z","git_url":"git://github.com/acdha/image-api.git","ssh_url":"git@github.com:acdha/image-api.git","clone_url":"https://github.com/acdha/image-api.git","svn_url":"https://github.com/acdha/image-api","homepage":"","size":270,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IIIF:master","ref":"master","sha":"c0d3e6df82e43aaae2e20f49b3546f7ec8e88447","user":{"login":"IIIF","id":5812589,"avatar_url":"https://avatars.githubusercontent.com/u/5812589?v=3","gravatar_id":"","url":"https://api.github.com/users/IIIF","html_url":"https://github.com/IIIF","followers_url":"https://api.github.com/users/IIIF/followers","following_url":"https://api.github.com/users/IIIF/following{/other_user}","gists_url":"https://api.github.com/users/IIIF/gists{/gist_id}","starred_url":"https://api.github.com/users/IIIF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IIIF/subscriptions","organizations_url":"https://api.github.com/users/IIIF/orgs","repos_url":"https://api.github.com/users/IIIF/repos","events_url":"https://api.github.com/users/IIIF/events{/privacy}","received_events_url":"https://api.github.com/users/IIIF/received_events","type":"Organization","site_admin":false},"repo":{"id":14026029,"name":"image-validator","full_name":"IIIF/image-validator","owner":{"login":"IIIF","id":5812589,"avatar_url":"https://avatars.githubusercontent.com/u/5812589?v=3","gravatar_id":"","url":"https://api.github.com/users/IIIF","html_url":"https://github.com/IIIF","followers_url":"https://api.github.com/users/IIIF/followers","following_url":"https://api.github.com/users/IIIF/following{/other_user}","gists_url":"https://api.github.com/users/IIIF/gists{/gist_id}","starred_url":"https://api.github.com/users/IIIF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IIIF/subscriptions","organizations_url":"https://api.github.com/users/IIIF/orgs","repos_url":"https://api.github.com/users/IIIF/repos","events_url":"https://api.github.com/users/IIIF/events{/privacy}","received_events_url":"https://api.github.com/users/IIIF/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IIIF/image-validator","description":"Validator for the Image API","fork":false,"url":"https://api.github.com/repos/IIIF/image-validator","forks_url":"https://api.github.com/repos/IIIF/image-validator/forks","keys_url":"https://api.github.com/repos/IIIF/image-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IIIF/image-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IIIF/image-validator/teams","hooks_url":"https://api.github.com/repos/IIIF/image-validator/hooks","issue_events_url":"https://api.github.com/repos/IIIF/image-validator/issues/events{/number}","events_url":"https://api.github.com/repos/IIIF/image-validator/events","assignees_url":"https://api.github.com/repos/IIIF/image-validator/assignees{/user}","branches_url":"https://api.github.com/repos/IIIF/image-validator/branches{/branch}","tags_url":"https://api.github.com/repos/IIIF/image-validator/tags","blobs_url":"https://api.github.com/repos/IIIF/image-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IIIF/image-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IIIF/image-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/IIIF/image-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IIIF/image-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/IIIF/image-validator/languages","stargazers_url":"https://api.github.com/repos/IIIF/image-validator/stargazers","contributors_url":"https://api.github.com/repos/IIIF/image-validator/contributors","subscribers_url":"https://api.github.com/repos/IIIF/image-validator/subscribers","subscription_url":"https://api.github.com/repos/IIIF/image-validator/subscription","commits_url":"https://api.github.com/repos/IIIF/image-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/IIIF/image-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/IIIF/image-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/IIIF/image-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/IIIF/image-validator/contents/{+path}","compare_url":"https://api.github.com/repos/IIIF/image-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IIIF/image-validator/merges","archive_url":"https://api.github.com/repos/IIIF/image-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IIIF/image-validator/downloads","issues_url":"https://api.github.com/repos/IIIF/image-validator/issues{/number}","pulls_url":"https://api.github.com/repos/IIIF/image-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/IIIF/image-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/IIIF/image-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IIIF/image-validator/labels{/name}","releases_url":"https://api.github.com/repos/IIIF/image-validator/releases{/id}","deployments_url":"https://api.github.com/repos/IIIF/image-validator/deployments","created_at":"2013-10-31T19:11:35Z","updated_at":"2016-10-27T23:44:19Z","pushed_at":"2016-12-13T06:18:00Z","git_url":"git://github.com/IIIF/image-validator.git","ssh_url":"git@github.com:IIIF/image-validator.git","clone_url":"https://github.com/IIIF/image-validator.git","svn_url":"https://github.com/IIIF/image-validator","homepage":"http://iiif.io/api/image/validator/","size":611,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":18,"forks":9,"open_issues":18,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IIIF/image-validator/pulls/27"},"html":{"href":"https://github.com/IIIF/image-validator/pull/27"},"issue":{"href":"https://api.github.com/repos/IIIF/image-validator/issues/27"},"comments":{"href":"https://api.github.com/repos/IIIF/image-validator/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/IIIF/image-validator/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/IIIF/image-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IIIF/image-validator/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/IIIF/image-validator/statuses/8e67430f0a00e8c92a15680f49f5893d2ad1cfd8"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":5,"review_comments":0,"commits":2,"additions":57,"deletions":11,"changed_files":3}}
{"actor":{"display_login":"azaroth42"}}