{"push_id":948455900,"size":76,"distinct_size":2,"ref":"refs/heads/cartopy_switch","head":"d75c7a3b8c38eb14a0f0802d7c0468aa86f04d53","before":"33a1793704916b0a29613f43dc9e4a6ff47fcd7f","commits":[{"sha":"19faab8ae261e1c3e42bd8b27bbe5ee5bac64981","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Adding extensive new subsetting tests for vertical coordinates. I also need to add some tests for empty subsets.","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/19faab8ae261e1c3e42bd8b27bbe5ee5bac64981"},{"sha":"a4ad7fdf6891864051916200df8df0f45b742004","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Bringing upto date with master","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/a4ad7fdf6891864051916200df8df0f45b742004"},{"sha":"3728417ecf8398117cc804ea1fb6f005776f0799","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Removing strict numpy requirement","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/3728417ecf8398117cc804ea1fb6f005776f0799"},{"sha":"47621f89da842ac937b382d5193e8379161642ef","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Changed _set_constraint_limits method to loop over the limits rather than over the coordinates, this makes it a bit clearer what's going on, and also makes it easier to determine if a limit doesn't correspond to any available coordinates. An error is now raised if this is the case - previously it would output data without actually applying any constraint. It's probably also every so slightly quicker. Updated docs.\n\nThis may mean that while in the past the routine would have guessed coordinates like gridded_longitude as 'x' it won't now. But the user is still able to specify gridded_longitude as the coordinate to subset, and this way seems safer for the user as it's more explicit.","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/47621f89da842ac937b382d5193e8379161642ef"},{"sha":"3fa119fe1dcfd93c1b27cc688d85fb34521d34ac","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Added a number of new subsetting tests to check the subsetting of vertical coordinates. I had to move the exception handling out of the subset command routine into the main routine in cis_main, this shouldn't make any difference as it would have been caught there anyway.","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/3fa119fe1dcfd93c1b27cc688d85fb34521d34ac"},{"sha":"15ed714918a956d7df5d8c2f323c331923a62b96","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Reverting the _set_constraint_limits method to loop over the coordinates rather than the limits, this is a tricky call in terms of code cleanliness, but I think that on the whole this is the right approach. It's also more consistent with the aggregation method, I've also made this even more consistent with the aggregation method by including a few more coord checks and also popping off the limits once they've been found - this lets me check if any are left and raise an error if so.","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/15ed714918a956d7df5d8c2f323c331923a62b96"},{"sha":"678e439143a8dfdfe2024855dbab2b397aa61d3d","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"The get_grid method now also checks for matching var_names, this just gives a nicer consistency between gridded and ungridded datasets. It also matches the subsetting now. Minor update to the error reporting to format it a bit more nicely.","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/678e439143a8dfdfe2024855dbab2b397aa61d3d"},{"sha":"3f7afaf192da310790e50afaf5edc95722ce1b0d","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Updated the docs to strengthen the advice to use variable name or standard names rather than axes shorthands. The time variable naming wasn't working, they required some tweaks to the parsing routines so that they treat time elements correctly even if the variable isn't 't'. Added some tests around this.","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/3f7afaf192da310790e50afaf5edc95722ce1b0d"},{"sha":"d867fe1901e689e15a712e0411ce4e0588477d19","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Add an info log message when changing the variable name - this was only done when changing the standard name, but this is arguably even more unexpected.","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/d867fe1901e689e15a712e0411ce4e0588477d19"},{"sha":"eb72e69194f29b61a5e52cf8e325c4aeaef9e5e5","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Minor update to docs","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/eb72e69194f29b61a5e52cf8e325c4aeaef9e5e5"},{"sha":"5fad2bad36fd1645f6c0d042f48df94d21875ad6","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Minor doc fixes","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/5fad2bad36fd1645f6c0d042f48df94d21875ad6"},{"sha":"abbb9365dbf5e015d41e64fa8320129f9b484ce2","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Removed the redundant subsetter class, it was just increasing complexity and adding no value. This made it a bit harder to setup some of the unit tests (as we're not injecting the dependency any more) but this is fairly easily fixed using mock patches as needed. Note that the set_limit mocks are setup for each test using the start/stop methods in setup and teardown respectively, but that the constrain methods are patched out on a per-test basis, this is just because some tests rely on the constrain call having different side effects.\n\nI'm not opposed to dependency injection where it adds value to the (core) code, but this added > 30 LOC for the sake of making a few unit tests easier. I'm not convinced there aren't better ways of doing this in Python anyway.","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/abbb9365dbf5e015d41e64fa8320129f9b484ce2"},{"sha":"ae4a998b931608eb2925c2437e05fd8b4da4b484","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Removed some unused imports","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/ae4a998b931608eb2925c2437e05fd8b4da4b484"},{"sha":"974c81a4098c46b81d1e6657bf39c879bd1d06a7","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Minor doc updates","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/974c81a4098c46b81d1e6657bf39c879bd1d06a7"},{"sha":"44d734d4ad60597d881b77c4be6d0478bd44174c","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Merge branch 'improve_subsetting_variable_naming'","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/44d734d4ad60597d881b77c4be6d0478bd44174c"},{"sha":"9d0e661c13bf7709a2c0a74d9681e548112363e0","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Minor doc formatting changes","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/9d0e661c13bf7709a2c0a74d9681e548112363e0"},{"sha":"626a017fdeade4747523bc895e5ab623cd7c9adf","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Reworked the convert_sec_since_to_std_time routine so that it operates on whole arrays at a time, this has sped up some integration tests by more than a factor of 10... It won't now deal with Julian calenders, but for ungridded data (which this is used for) that isn't an issue.","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/626a017fdeade4747523bc895e5ab623cd7c9adf"},{"sha":"97742d4d9ac812932de376cc707786d62c80459c","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Reworked the convert_julian_date_to_std_time routine so that it operates on whole arrays at a time, this has sped up Cloud CCI data reading by upto 100 times...!","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/97742d4d9ac812932de376cc707786d62c80459c"},{"sha":"e914560bb4737896e5fa3eed5d9133d49cca532e","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Adding a simple test around the aeronet date parsing","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/e914560bb4737896e5fa3eed5d9133d49cca532e"},{"sha":"91a88ad0572b518dc6bcf18e11c493400cd23fc7","author":{"email":"512e291f4640f74b1e27cb424a96d1141b5fc181@physics.ox.ac.uk","name":"Duncan Watson-Parris"},"message":"Simplified the Aeronet datetime reading routines to read directly into CIS standard time, rather then converting between DateTime objects. This is a bit quicker, but not as much as I had expected.","distinct":false,"url":"https://api.github.com/repos/cedadev/cis/commits/91a88ad0572b518dc6bcf18e11c493400cd23fc7"}]}