{"action":"created","issue":{"url":"https://api.github.com/repos/happner/happner/issues/95","repository_url":"https://api.github.com/repos/happner/happner","labels_url":"https://api.github.com/repos/happner/happner/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/happner/happner/issues/95/comments","events_url":"https://api.github.com/repos/happner/happner/issues/95/events","html_url":"https://github.com/happner/happner/pull/95","id":156952328,"number":95,"title":"Release/1.8.0","user":{"login":"southbite","id":1958406,"avatar_url":"https://avatars.githubusercontent.com/u/1958406?v=3","gravatar_id":"","url":"https://api.github.com/users/southbite","html_url":"https://github.com/southbite","followers_url":"https://api.github.com/users/southbite/followers","following_url":"https://api.github.com/users/southbite/following{/other_user}","gists_url":"https://api.github.com/users/southbite/gists{/gist_id}","starred_url":"https://api.github.com/users/southbite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/southbite/subscriptions","organizations_url":"https://api.github.com/users/southbite/orgs","repos_url":"https://api.github.com/users/southbite/repos","events_url":"https://api.github.com/users/southbite/events{/privacy}","received_events_url":"https://api.github.com/users/southbite/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-26T10:25:19Z","updated_at":"2016-05-30T14:38:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/happner/happner/pulls/95","html_url":"https://github.com/happner/happner/pull/95","diff_url":"https://github.com/happner/happner/pull/95.diff","patch_url":"https://github.com/happner/happner/pull/95.patch"},"body":"hi guys,\r\n\r\nthe happner-loader is finally complete, the only piece of functionality lacking is the ability to set a different splash page, but this is proving to be such a difficult thing to test accurately, I would advise we first see how this works with the fst products, and then make changes if necessary in a consecutive release.\r\n\r\nWhat is nice is the responsiveness of this version, on the Brain we have about a 1-2 seconds lag before the splash page is served, and then the progress bar kicks in finally with the redirect. you can run it on the brain from the /git/happner folder (Jen's Brain) like so: node bin/happner-loader --conf ../test/lib/d6_conf_redirect.json\r\n\r\n(make sure it isn't already running using ps -ef | grep node)\r\n\r\nthen navigate to http://jeggers.dyndns.org:55004/ping - you should get the splash page, and it will then redirect to the /ping again when happner is ready\r\n\r\nthe documents for the loader can be found here: https://github.com/happner/happner/blob/release/1.8.0/docs/loader.md\r\n\r\nthe tests for the loader can be found here:\r\nhttps://github.com/happner/happner/blob/release/1.8.0/test/test-optimize/1-startup-proxy.js\r\n\r\nI couldn't include the test in the normal folder because silence.js breaks them, tried all sorts of things to break the silence, but it remained - so just moved the test.\r\n\r\nYou can run the test like from the happner root folder: npm run-script test-optimize"},"comment":{"url":"https://api.github.com/repos/happner/happner/issues/comments/222506057","html_url":"https://github.com/happner/happner/pull/95#issuecomment-222506057","issue_url":"https://api.github.com/repos/happner/happner/issues/95","id":222506057,"user":{"login":"JensEggers","id":2249070,"avatar_url":"https://avatars.githubusercontent.com/u/2249070?v=3","gravatar_id":"","url":"https://api.github.com/users/JensEggers","html_url":"https://github.com/JensEggers","followers_url":"https://api.github.com/users/JensEggers/followers","following_url":"https://api.github.com/users/JensEggers/following{/other_user}","gists_url":"https://api.github.com/users/JensEggers/gists{/gist_id}","starred_url":"https://api.github.com/users/JensEggers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JensEggers/subscriptions","organizations_url":"https://api.github.com/users/JensEggers/orgs","repos_url":"https://api.github.com/users/JensEggers/repos","events_url":"https://api.github.com/users/JensEggers/events{/privacy}","received_events_url":"https://api.github.com/users/JensEggers/received_events","type":"User","site_admin":false},"created_at":"2016-05-30T14:38:32Z","updated_at":"2016-05-30T14:38:32Z","body":"On the whole I only had cosmetic comments, but I'd like to understand the link between logging and IPC. It seems strange to use the logging framework as the IPC framework, as evidenced by the testing difficulty introduced when silencing logs. In general one wouldn't expect changes to logging to affect program behaviour. Would it not be cleaner to separate logging and IPC, or at least for the control signals to be independent of logging options?"}}
{"actor":{"display_login":"JensEggers"}}