{"action":"closed","number":53,"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/53","id":55238880,"html_url":"https://github.com/zendframework/zend-expressive-skeleton/pull/53","diff_url":"https://github.com/zendframework/zend-expressive-skeleton/pull/53.diff","patch_url":"https://github.com/zendframework/zend-expressive-skeleton/pull/53.patch","issue_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/53","number":53,"state":"closed","locked":false,"title":"factory sharing for pimple container","user":{"login":"pine3ree","id":3229979,"avatar_url":"https://avatars.githubusercontent.com/u/3229979?v=3","gravatar_id":"","url":"https://api.github.com/users/pine3ree","html_url":"https://github.com/pine3ree","followers_url":"https://api.github.com/users/pine3ree/followers","following_url":"https://api.github.com/users/pine3ree/following{/other_user}","gists_url":"https://api.github.com/users/pine3ree/gists{/gist_id}","starred_url":"https://api.github.com/users/pine3ree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pine3ree/subscriptions","organizations_url":"https://api.github.com/users/pine3ree/orgs","repos_url":"https://api.github.com/users/pine3ree/repos","events_url":"https://api.github.com/users/pine3ree/events{/privacy}","received_events_url":"https://api.github.com/users/pine3ree/received_events","type":"User","site_admin":false},"body":"just an idea based on zend-servicemanager v3:\r\n- stores the factory in the container\r\n- allows reuse of the same factory (and same instance) for more than one service\r\n- pass an extra parameter to the factory in order to make it possible to identify the requested service\r\n\r\nNaming:\r\nshould we change $object to $factoryClass and $invokableClass to make it more explicit?","created_at":"2016-01-06T17:21:19Z","updated_at":"2016-03-17T19:37:45Z","closed_at":"2016-03-17T19:37:44Z","merged_at":"2016-03-17T19:37:44Z","merge_commit_sha":"4d1ba02ccb442105b622d1a234651941c31334c0","assignee":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/milestones/13","html_url":"https://github.com/zendframework/zend-expressive-skeleton/milestones/1.0.1","labels_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/milestones/13/labels","id":1541851,"number":13,"title":"1.0.1","description":null,"creator":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":1,"state":"open","created_at":"2016-01-25T15:45:00Z","updated_at":"2016-03-17T19:37:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/53/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/53/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/53/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/statuses/aa115bd6cc3ba0fa412ff1046f94189d07b8c0fa","head":{"label":"pine3ree:patch-1","ref":"patch-1","sha":"aa115bd6cc3ba0fa412ff1046f94189d07b8c0fa","user":{"login":"pine3ree","id":3229979,"avatar_url":"https://avatars.githubusercontent.com/u/3229979?v=3","gravatar_id":"","url":"https://api.github.com/users/pine3ree","html_url":"https://github.com/pine3ree","followers_url":"https://api.github.com/users/pine3ree/followers","following_url":"https://api.github.com/users/pine3ree/following{/other_user}","gists_url":"https://api.github.com/users/pine3ree/gists{/gist_id}","starred_url":"https://api.github.com/users/pine3ree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pine3ree/subscriptions","organizations_url":"https://api.github.com/users/pine3ree/orgs","repos_url":"https://api.github.com/users/pine3ree/repos","events_url":"https://api.github.com/users/pine3ree/events{/privacy}","received_events_url":"https://api.github.com/users/pine3ree/received_events","type":"User","site_admin":false},"repo":{"id":47271797,"name":"zend-expressive-skeleton","full_name":"pine3ree/zend-expressive-skeleton","owner":{"login":"pine3ree","id":3229979,"avatar_url":"https://avatars.githubusercontent.com/u/3229979?v=3","gravatar_id":"","url":"https://api.github.com/users/pine3ree","html_url":"https://github.com/pine3ree","followers_url":"https://api.github.com/users/pine3ree/followers","following_url":"https://api.github.com/users/pine3ree/following{/other_user}","gists_url":"https://api.github.com/users/pine3ree/gists{/gist_id}","starred_url":"https://api.github.com/users/pine3ree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pine3ree/subscriptions","organizations_url":"https://api.github.com/users/pine3ree/orgs","repos_url":"https://api.github.com/users/pine3ree/repos","events_url":"https://api.github.com/users/pine3ree/events{/privacy}","received_events_url":"https://api.github.com/users/pine3ree/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pine3ree/zend-expressive-skeleton","description":"Begin developing PSR-7 middleware applications in seconds!","fork":true,"url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton","forks_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/forks","keys_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/teams","hooks_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/hooks","issue_events_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/issues/events{/number}","events_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/events","assignees_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/assignees{/user}","branches_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/branches{/branch}","tags_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/tags","blobs_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/git/refs{/sha}","trees_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/statuses/{sha}","languages_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/languages","stargazers_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/stargazers","contributors_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/contributors","subscribers_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/subscribers","subscription_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/subscription","commits_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/commits{/sha}","git_commits_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/git/commits{/sha}","comments_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/comments{/number}","issue_comment_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/issues/comments{/number}","contents_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/contents/{+path}","compare_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/merges","archive_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/downloads","issues_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/issues{/number}","pulls_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/pulls{/number}","milestones_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/milestones{/number}","notifications_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/labels{/name}","releases_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/releases{/id}","deployments_url":"https://api.github.com/repos/pine3ree/zend-expressive-skeleton/deployments","created_at":"2015-12-02T15:57:15Z","updated_at":"2015-12-02T15:57:16Z","pushed_at":"2016-01-06T17:10:36Z","git_url":"git://github.com/pine3ree/zend-expressive-skeleton.git","ssh_url":"git@github.com:pine3ree/zend-expressive-skeleton.git","clone_url":"https://github.com/pine3ree/zend-expressive-skeleton.git","svn_url":"https://github.com/pine3ree/zend-expressive-skeleton","homepage":"","size":246,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"35f96a931609abca6c979b2df227f0129b556762","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":43980294,"name":"zend-expressive-skeleton","full_name":"zendframework/zend-expressive-skeleton","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zend-expressive-skeleton","description":"Begin developing PSR-7 middleware applications in seconds!","fork":true,"url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton","forks_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/forks","keys_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/events","assignees_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/merges","archive_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/releases{/id}","deployments_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/deployments","created_at":"2015-10-09T21:10:08Z","updated_at":"2016-03-13T00:01:34Z","pushed_at":"2016-03-17T19:37:44Z","git_url":"git://github.com/zendframework/zend-expressive-skeleton.git","ssh_url":"git@github.com:zendframework/zend-expressive-skeleton.git","clone_url":"https://github.com/zendframework/zend-expressive-skeleton.git","svn_url":"https://github.com/zendframework/zend-expressive-skeleton","homepage":"","size":315,"stargazers_count":41,"watchers_count":41,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":10,"forks":32,"open_issues":10,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/53"},"html":{"href":"https://github.com/zendframework/zend-expressive-skeleton/pull/53"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/53"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/statuses/aa115bd6cc3ba0fa412ff1046f94189d07b8c0fa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":9,"deletions":3,"changed_files":1}}