{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2940","repository_url":"https://api.github.com/repos/ethereum/go-ethereum","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2940/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2940/comments","events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2940/events","html_url":"https://github.com/ethereum/go-ethereum/pull/2940","id":172906791,"number":2940,"title":"internal/ethapi: add personal_sign method","user":{"login":"bas-vk","id":4280775,"avatar_url":"https://avatars.githubusercontent.com/u/4280775?v=3","gravatar_id":"","url":"https://api.github.com/users/bas-vk","html_url":"https://github.com/bas-vk","followers_url":"https://api.github.com/users/bas-vk/followers","following_url":"https://api.github.com/users/bas-vk/following{/other_user}","gists_url":"https://api.github.com/users/bas-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/bas-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas-vk/subscriptions","organizations_url":"https://api.github.com/users/bas-vk/orgs","repos_url":"https://api.github.com/users/bas-vk/repos","events_url":"https://api.github.com/users/bas-vk/events{/privacy}","received_events_url":"https://api.github.com/users/bas-vk/received_events","type":"User","site_admin":false},"labels":[{"id":248602208,"url":"https://api.github.com/repos/ethereum/go-ethereum/labels/crypto","name":"crypto","color":"bfd4f2","default":false},{"id":163665008,"url":"https://api.github.com/repos/ethereum/go-ethereum/labels/review","name":"review","color":"fad8c7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/26","html_url":"https://github.com/ethereum/go-ethereum/milestones/1.5.0","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/26/labels","id":1593424,"number":26,"title":"1.5.0","description":"","creator":{"login":"karalabe","id":129561,"avatar_url":"https://avatars.githubusercontent.com/u/129561?v=3","gravatar_id":"","url":"https://api.github.com/users/karalabe","html_url":"https://github.com/karalabe","followers_url":"https://api.github.com/users/karalabe/followers","following_url":"https://api.github.com/users/karalabe/following{/other_user}","gists_url":"https://api.github.com/users/karalabe/gists{/gist_id}","starred_url":"https://api.github.com/users/karalabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karalabe/subscriptions","organizations_url":"https://api.github.com/users/karalabe/orgs","repos_url":"https://api.github.com/users/karalabe/repos","events_url":"https://api.github.com/users/karalabe/events{/privacy}","received_events_url":"https://api.github.com/users/karalabe/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":63,"state":"closed","created_at":"2016-02-19T15:55:33Z","updated_at":"2016-11-15T21:55:24Z","due_on":null,"closed_at":"2016-11-15T21:55:24Z"},"comments":46,"created_at":"2016-08-24T09:34:33Z","updated_at":"2016-11-16T23:28:19Z","closed_at":"2016-10-28T19:25:49Z","pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2940","html_url":"https://github.com/ethereum/go-ethereum/pull/2940","diff_url":"https://github.com/ethereum/go-ethereum/pull/2940.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/2940.patch"},"body":"This PR includes several things:\r\n\r\n1. the behavior of `eth_sign` is changed. It now accepts an arbitrary message, prepends a known message, hashes the result using keccak256 it calculates the signature of the hash (breaks backwards compatability!).\r\n2. add `personal_sign`, same semantics as `eth_sign` but also accepts a password. The private key used to sign the hash is temporary unlocked in the scope of the request.\r\n3. add `personal_recover`, returns the address for the account that created the signature.\r\n\r\n`personal_recover(message, signature)`\r\n`personal_sign(hash, address [, password])`\r\n\r\nThe known message added to the input before hashing is\r\n\r\n`\"\\x19Ethereum Signed Message:\\n\" + len(message)`.\r\n\r\n@alexvandesande \r\n"},"comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments/261106406","html_url":"https://github.com/ethereum/go-ethereum/pull/2940#issuecomment-261106406","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2940","id":261106406,"user":{"login":"kumavis","id":1474978,"avatar_url":"https://avatars.githubusercontent.com/u/1474978?v=3","gravatar_id":"","url":"https://api.github.com/users/kumavis","html_url":"https://github.com/kumavis","followers_url":"https://api.github.com/users/kumavis/followers","following_url":"https://api.github.com/users/kumavis/following{/other_user}","gists_url":"https://api.github.com/users/kumavis/gists{/gist_id}","starred_url":"https://api.github.com/users/kumavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumavis/subscriptions","organizations_url":"https://api.github.com/users/kumavis/orgs","repos_url":"https://api.github.com/users/kumavis/repos","events_url":"https://api.github.com/users/kumavis/events{/privacy}","received_events_url":"https://api.github.com/users/kumavis/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T23:28:19Z","updated_at":"2016-11-16T23:28:19Z","body":"@pipermerriam prolly easiest to create a new contract that shadows the state of the current one"}}
{"actor":{"display_login":"kumavis"}}