{"action":"created","comment":{"url":"https://api.github.com/repos/KDAB/GammaRay/pulls/comments/89136878","pull_request_review_id":9685548,"id":89136878,"diff_hunk":"@@ -114,7 +114,7 @@ void Client::socketConnected()\n void Client::resetClientDevice()\n {\n     if (m_clientDevice) {\n-        m_clientDevice->deleteLater();\n+        QMetaObject::invokeMethod(m_clientDevice, \"deleteLater\", Qt::QueuedConnection);","path":"client/client.cpp","position":5,"original_position":5,"commit_id":"565f817fd9b6fc16c918cd63ac038d44151953ff","original_commit_id":"565f817fd9b6fc16c918cd63ac038d44151953ff","user":{"login":"vkrause","id":629750,"avatar_url":"https://avatars.githubusercontent.com/u/629750?v=3","gravatar_id":"","url":"https://api.github.com/users/vkrause","html_url":"https://github.com/vkrause","followers_url":"https://api.github.com/users/vkrause/followers","following_url":"https://api.github.com/users/vkrause/following{/other_user}","gists_url":"https://api.github.com/users/vkrause/gists{/gist_id}","starred_url":"https://api.github.com/users/vkrause/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkrause/subscriptions","organizations_url":"https://api.github.com/users/vkrause/orgs","repos_url":"https://api.github.com/users/vkrause/repos","events_url":"https://api.github.com/users/vkrause/events{/privacy}","received_events_url":"https://api.github.com/users/vkrause/received_events","type":"User","site_admin":false},"body":"deleteLater() is already queued through the event loop, are you sure this change is ncessary?","created_at":"2016-11-22T15:18:01Z","updated_at":"2016-11-22T15:18:06Z","html_url":"https://github.com/KDAB/GammaRay/pull/273#discussion_r89136878","pull_request_url":"https://api.github.com/repos/KDAB/GammaRay/pulls/273","_links":{"self":{"href":"https://api.github.com/repos/KDAB/GammaRay/pulls/comments/89136878"},"html":{"href":"https://github.com/KDAB/GammaRay/pull/273#discussion_r89136878"},"pull_request":{"href":"https://api.github.com/repos/KDAB/GammaRay/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/KDAB/GammaRay/pulls/273","id":94831990,"html_url":"https://github.com/KDAB/GammaRay/pull/273","diff_url":"https://github.com/KDAB/GammaRay/pull/273.diff","patch_url":"https://github.com/KDAB/GammaRay/pull/273.patch","issue_url":"https://api.github.com/repos/KDAB/GammaRay/issues/273","number":273,"state":"open","locked":false,"title":"Fix reentrancy issue","user":{"login":"pasnox","id":858201,"avatar_url":"https://avatars.githubusercontent.com/u/858201?v=3","gravatar_id":"","url":"https://api.github.com/users/pasnox","html_url":"https://github.com/pasnox","followers_url":"https://api.github.com/users/pasnox/followers","following_url":"https://api.github.com/users/pasnox/following{/other_user}","gists_url":"https://api.github.com/users/pasnox/gists{/gist_id}","starred_url":"https://api.github.com/users/pasnox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasnox/subscriptions","organizations_url":"https://api.github.com/users/pasnox/orgs","repos_url":"https://api.github.com/users/pasnox/repos","events_url":"https://api.github.com/users/pasnox/events{/privacy}","received_events_url":"https://api.github.com/users/pasnox/received_events","type":"User","site_admin":false},"body":"There was a recurrent crash when disconnectFromHost was called too much\r\nin a short time.\r\nAlso the invalidated socket was still connected and produced responses\r\nfor readyRead / disconnected.","created_at":"2016-11-22T15:08:45Z","updated_at":"2016-11-22T15:18:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba2494a414442069915a9713cbf36dadd2579a32","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KDAB/GammaRay/pulls/273/commits","review_comments_url":"https://api.github.com/repos/KDAB/GammaRay/pulls/273/comments","review_comment_url":"https://api.github.com/repos/KDAB/GammaRay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KDAB/GammaRay/issues/273/comments","statuses_url":"https://api.github.com/repos/KDAB/GammaRay/statuses/565f817fd9b6fc16c918cd63ac038d44151953ff","head":{"label":"KDAB:master-reentrancy","ref":"master-reentrancy","sha":"565f817fd9b6fc16c918cd63ac038d44151953ff","user":{"login":"KDAB","id":402842,"avatar_url":"https://avatars.githubusercontent.com/u/402842?v=3","gravatar_id":"","url":"https://api.github.com/users/KDAB","html_url":"https://github.com/KDAB","followers_url":"https://api.github.com/users/KDAB/followers","following_url":"https://api.github.com/users/KDAB/following{/other_user}","gists_url":"https://api.github.com/users/KDAB/gists{/gist_id}","starred_url":"https://api.github.com/users/KDAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KDAB/subscriptions","organizations_url":"https://api.github.com/users/KDAB/orgs","repos_url":"https://api.github.com/users/KDAB/repos","events_url":"https://api.github.com/users/KDAB/events{/privacy}","received_events_url":"https://api.github.com/users/KDAB/received_events","type":"Organization","site_admin":false},"repo":{"id":2615451,"name":"GammaRay","full_name":"KDAB/GammaRay","owner":{"login":"KDAB","id":402842,"avatar_url":"https://avatars.githubusercontent.com/u/402842?v=3","gravatar_id":"","url":"https://api.github.com/users/KDAB","html_url":"https://github.com/KDAB","followers_url":"https://api.github.com/users/KDAB/followers","following_url":"https://api.github.com/users/KDAB/following{/other_user}","gists_url":"https://api.github.com/users/KDAB/gists{/gist_id}","starred_url":"https://api.github.com/users/KDAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KDAB/subscriptions","organizations_url":"https://api.github.com/users/KDAB/orgs","repos_url":"https://api.github.com/users/KDAB/repos","events_url":"https://api.github.com/users/KDAB/events{/privacy}","received_events_url":"https://api.github.com/users/KDAB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KDAB/GammaRay","description":"GammaRay is a tool to poke around in a Qt-application and also to manipulate the application to some extent.","fork":false,"url":"https://api.github.com/repos/KDAB/GammaRay","forks_url":"https://api.github.com/repos/KDAB/GammaRay/forks","keys_url":"https://api.github.com/repos/KDAB/GammaRay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KDAB/GammaRay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KDAB/GammaRay/teams","hooks_url":"https://api.github.com/repos/KDAB/GammaRay/hooks","issue_events_url":"https://api.github.com/repos/KDAB/GammaRay/issues/events{/number}","events_url":"https://api.github.com/repos/KDAB/GammaRay/events","assignees_url":"https://api.github.com/repos/KDAB/GammaRay/assignees{/user}","branches_url":"https://api.github.com/repos/KDAB/GammaRay/branches{/branch}","tags_url":"https://api.github.com/repos/KDAB/GammaRay/tags","blobs_url":"https://api.github.com/repos/KDAB/GammaRay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KDAB/GammaRay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KDAB/GammaRay/git/refs{/sha}","trees_url":"https://api.github.com/repos/KDAB/GammaRay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KDAB/GammaRay/statuses/{sha}","languages_url":"https://api.github.com/repos/KDAB/GammaRay/languages","stargazers_url":"https://api.github.com/repos/KDAB/GammaRay/stargazers","contributors_url":"https://api.github.com/repos/KDAB/GammaRay/contributors","subscribers_url":"https://api.github.com/repos/KDAB/GammaRay/subscribers","subscription_url":"https://api.github.com/repos/KDAB/GammaRay/subscription","commits_url":"https://api.github.com/repos/KDAB/GammaRay/commits{/sha}","git_commits_url":"https://api.github.com/repos/KDAB/GammaRay/git/commits{/sha}","comments_url":"https://api.github.com/repos/KDAB/GammaRay/comments{/number}","issue_comment_url":"https://api.github.com/repos/KDAB/GammaRay/issues/comments{/number}","contents_url":"https://api.github.com/repos/KDAB/GammaRay/contents/{+path}","compare_url":"https://api.github.com/repos/KDAB/GammaRay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KDAB/GammaRay/merges","archive_url":"https://api.github.com/repos/KDAB/GammaRay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KDAB/GammaRay/downloads","issues_url":"https://api.github.com/repos/KDAB/GammaRay/issues{/number}","pulls_url":"https://api.github.com/repos/KDAB/GammaRay/pulls{/number}","milestones_url":"https://api.github.com/repos/KDAB/GammaRay/milestones{/number}","notifications_url":"https://api.github.com/repos/KDAB/GammaRay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KDAB/GammaRay/labels{/name}","releases_url":"https://api.github.com/repos/KDAB/GammaRay/releases{/id}","deployments_url":"https://api.github.com/repos/KDAB/GammaRay/deployments","created_at":"2011-10-20T19:00:06Z","updated_at":"2016-11-22T13:22:58Z","pushed_at":"2016-11-22T15:08:46Z","git_url":"git://github.com/KDAB/GammaRay.git","ssh_url":"git@github.com:KDAB/GammaRay.git","clone_url":"https://github.com/KDAB/GammaRay.git","svn_url":"https://github.com/KDAB/GammaRay","homepage":"https://www.kdab.com/gammaray","size":23366,"stargazers_count":352,"watchers_count":352,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":27,"forks":77,"open_issues":27,"watchers":352,"default_branch":"master"}},"base":{"label":"KDAB:master","ref":"master","sha":"77c1d57c1f874fdc6fb78c552656b935bf53e94d","user":{"login":"KDAB","id":402842,"avatar_url":"https://avatars.githubusercontent.com/u/402842?v=3","gravatar_id":"","url":"https://api.github.com/users/KDAB","html_url":"https://github.com/KDAB","followers_url":"https://api.github.com/users/KDAB/followers","following_url":"https://api.github.com/users/KDAB/following{/other_user}","gists_url":"https://api.github.com/users/KDAB/gists{/gist_id}","starred_url":"https://api.github.com/users/KDAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KDAB/subscriptions","organizations_url":"https://api.github.com/users/KDAB/orgs","repos_url":"https://api.github.com/users/KDAB/repos","events_url":"https://api.github.com/users/KDAB/events{/privacy}","received_events_url":"https://api.github.com/users/KDAB/received_events","type":"Organization","site_admin":false},"repo":{"id":2615451,"name":"GammaRay","full_name":"KDAB/GammaRay","owner":{"login":"KDAB","id":402842,"avatar_url":"https://avatars.githubusercontent.com/u/402842?v=3","gravatar_id":"","url":"https://api.github.com/users/KDAB","html_url":"https://github.com/KDAB","followers_url":"https://api.github.com/users/KDAB/followers","following_url":"https://api.github.com/users/KDAB/following{/other_user}","gists_url":"https://api.github.com/users/KDAB/gists{/gist_id}","starred_url":"https://api.github.com/users/KDAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KDAB/subscriptions","organizations_url":"https://api.github.com/users/KDAB/orgs","repos_url":"https://api.github.com/users/KDAB/repos","events_url":"https://api.github.com/users/KDAB/events{/privacy}","received_events_url":"https://api.github.com/users/KDAB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KDAB/GammaRay","description":"GammaRay is a tool to poke around in a Qt-application and also to manipulate the application to some extent.","fork":false,"url":"https://api.github.com/repos/KDAB/GammaRay","forks_url":"https://api.github.com/repos/KDAB/GammaRay/forks","keys_url":"https://api.github.com/repos/KDAB/GammaRay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KDAB/GammaRay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KDAB/GammaRay/teams","hooks_url":"https://api.github.com/repos/KDAB/GammaRay/hooks","issue_events_url":"https://api.github.com/repos/KDAB/GammaRay/issues/events{/number}","events_url":"https://api.github.com/repos/KDAB/GammaRay/events","assignees_url":"https://api.github.com/repos/KDAB/GammaRay/assignees{/user}","branches_url":"https://api.github.com/repos/KDAB/GammaRay/branches{/branch}","tags_url":"https://api.github.com/repos/KDAB/GammaRay/tags","blobs_url":"https://api.github.com/repos/KDAB/GammaRay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KDAB/GammaRay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KDAB/GammaRay/git/refs{/sha}","trees_url":"https://api.github.com/repos/KDAB/GammaRay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KDAB/GammaRay/statuses/{sha}","languages_url":"https://api.github.com/repos/KDAB/GammaRay/languages","stargazers_url":"https://api.github.com/repos/KDAB/GammaRay/stargazers","contributors_url":"https://api.github.com/repos/KDAB/GammaRay/contributors","subscribers_url":"https://api.github.com/repos/KDAB/GammaRay/subscribers","subscription_url":"https://api.github.com/repos/KDAB/GammaRay/subscription","commits_url":"https://api.github.com/repos/KDAB/GammaRay/commits{/sha}","git_commits_url":"https://api.github.com/repos/KDAB/GammaRay/git/commits{/sha}","comments_url":"https://api.github.com/repos/KDAB/GammaRay/comments{/number}","issue_comment_url":"https://api.github.com/repos/KDAB/GammaRay/issues/comments{/number}","contents_url":"https://api.github.com/repos/KDAB/GammaRay/contents/{+path}","compare_url":"https://api.github.com/repos/KDAB/GammaRay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KDAB/GammaRay/merges","archive_url":"https://api.github.com/repos/KDAB/GammaRay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KDAB/GammaRay/downloads","issues_url":"https://api.github.com/repos/KDAB/GammaRay/issues{/number}","pulls_url":"https://api.github.com/repos/KDAB/GammaRay/pulls{/number}","milestones_url":"https://api.github.com/repos/KDAB/GammaRay/milestones{/number}","notifications_url":"https://api.github.com/repos/KDAB/GammaRay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KDAB/GammaRay/labels{/name}","releases_url":"https://api.github.com/repos/KDAB/GammaRay/releases{/id}","deployments_url":"https://api.github.com/repos/KDAB/GammaRay/deployments","created_at":"2011-10-20T19:00:06Z","updated_at":"2016-11-22T13:22:58Z","pushed_at":"2016-11-22T15:08:46Z","git_url":"git://github.com/KDAB/GammaRay.git","ssh_url":"git@github.com:KDAB/GammaRay.git","clone_url":"https://github.com/KDAB/GammaRay.git","svn_url":"https://github.com/KDAB/GammaRay","homepage":"https://www.kdab.com/gammaray","size":23366,"stargazers_count":352,"watchers_count":352,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":27,"forks":77,"open_issues":27,"watchers":352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KDAB/GammaRay/pulls/273"},"html":{"href":"https://github.com/KDAB/GammaRay/pull/273"},"issue":{"href":"https://api.github.com/repos/KDAB/GammaRay/issues/273"},"comments":{"href":"https://api.github.com/repos/KDAB/GammaRay/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/KDAB/GammaRay/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/KDAB/GammaRay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KDAB/GammaRay/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/KDAB/GammaRay/statuses/565f817fd9b6fc16c918cd63ac038d44151953ff"}}}}
{"actor":{"display_login":"vkrause"}}