{"action":"created","comment":{"url":"https://api.github.com/repos/benjycui/bisheng/pulls/comments/70736679","id":70736679,"diff_hunk":"@@ -46,14 +46,15 @@ module.exports = function templateWrapper(template, dataPath = '') {\n       pageData,\n       utils,\n     }), (err, nextProps) => {\n-      callback(err, (props) => {\n-        NProgress.done();\n-        return React.createElement(\n-          !hasParams(dataPath) || pageData ?\n-            Template.default || Template : NotFound,\n-          Object.assign({}, props, nextProps)\n-        );\n+      NProgress.done();\n+      const Comp = !hasParams(dataPath) || pageData ?\n+      Template.default || Template : NotFound;","path":"lib/utils/template-wrapper.nunjucks.js","position":21,"original_position":21,"commit_id":"62b5c3651e06a26ee31acc1f7c1e7989e7fd324b","original_commit_id":"62b5c3651e06a26ee31acc1f7c1e7989e7fd324b","user":{"login":"benjycui","id":3580607,"avatar_url":"https://avatars.githubusercontent.com/u/3580607?v=3","gravatar_id":"","url":"https://api.github.com/users/benjycui","html_url":"https://github.com/benjycui","followers_url":"https://api.github.com/users/benjycui/followers","following_url":"https://api.github.com/users/benjycui/following{/other_user}","gists_url":"https://api.github.com/users/benjycui/gists{/gist_id}","starred_url":"https://api.github.com/users/benjycui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjycui/subscriptions","organizations_url":"https://api.github.com/users/benjycui/orgs","repos_url":"https://api.github.com/users/benjycui/repos","events_url":"https://api.github.com/users/benjycui/events{/privacy}","received_events_url":"https://api.github.com/users/benjycui/received_events","type":"User","site_admin":false},"body":"这缩进。。。提交前应该跑下 `npm run lint`。","created_at":"2016-07-14T01:31:41Z","updated_at":"2016-07-14T01:31:41Z","html_url":"https://github.com/benjycui/bisheng/pull/27#discussion_r70736679","pull_request_url":"https://api.github.com/repos/benjycui/bisheng/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/benjycui/bisheng/pulls/comments/70736679"},"html":{"href":"https://github.com/benjycui/bisheng/pull/27#discussion_r70736679"},"pull_request":{"href":"https://api.github.com/repos/benjycui/bisheng/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/benjycui/bisheng/pulls/27","id":76088344,"html_url":"https://github.com/benjycui/bisheng/pull/27","diff_url":"https://github.com/benjycui/bisheng/pull/27.diff","patch_url":"https://github.com/benjycui/bisheng/pull/27.patch","issue_url":"https://api.github.com/repos/benjycui/bisheng/issues/27","number":27,"state":"open","locked":false,"title":"add router path children, createElement to set defaultProps","user":{"login":"jljsj33","id":6802825,"avatar_url":"https://avatars.githubusercontent.com/u/6802825?v=3","gravatar_id":"","url":"https://api.github.com/users/jljsj33","html_url":"https://github.com/jljsj33","followers_url":"https://api.github.com/users/jljsj33/followers","following_url":"https://api.github.com/users/jljsj33/following{/other_user}","gists_url":"https://api.github.com/users/jljsj33/gists{/gist_id}","starred_url":"https://api.github.com/users/jljsj33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jljsj33/subscriptions","organizations_url":"https://api.github.com/users/jljsj33/orgs","repos_url":"https://api.github.com/users/jljsj33/repos","events_url":"https://api.github.com/users/jljsj33/events{/privacy}","received_events_url":"https://api.github.com/users/jljsj33/received_events","type":"User","site_admin":false},"body":"增加子级路由\r\n```js\r\nroutes: [\r\n    {\r\n      template: './template/Layout/index',\r\n      props: { ignoreScrollBehavior: true },\r\n      children : [\r\n        { dataPath: '/', template: './template/Home/index' },\r\n        { dataPath: '/components/:contentName', template: ComponentDoc },\r\n      ]\r\n    }\r\n  ]\r\n```\r\n\r\n原来的写法没动。。。只把 createElement 改成了去设置组件的 defaultProps, ","created_at":"2016-07-03T12:50:23Z","updated_at":"2016-07-14T01:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad79a3cc7394bf96d04fc13cbced429e8a419806","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/benjycui/bisheng/pulls/27/commits","review_comments_url":"https://api.github.com/repos/benjycui/bisheng/pulls/27/comments","review_comment_url":"https://api.github.com/repos/benjycui/bisheng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benjycui/bisheng/issues/27/comments","statuses_url":"https://api.github.com/repos/benjycui/bisheng/statuses/62b5c3651e06a26ee31acc1f7c1e7989e7fd324b","head":{"label":"jljsj33:master","ref":"master","sha":"62b5c3651e06a26ee31acc1f7c1e7989e7fd324b","user":{"login":"jljsj33","id":6802825,"avatar_url":"https://avatars.githubusercontent.com/u/6802825?v=3","gravatar_id":"","url":"https://api.github.com/users/jljsj33","html_url":"https://github.com/jljsj33","followers_url":"https://api.github.com/users/jljsj33/followers","following_url":"https://api.github.com/users/jljsj33/following{/other_user}","gists_url":"https://api.github.com/users/jljsj33/gists{/gist_id}","starred_url":"https://api.github.com/users/jljsj33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jljsj33/subscriptions","organizations_url":"https://api.github.com/users/jljsj33/orgs","repos_url":"https://api.github.com/users/jljsj33/repos","events_url":"https://api.github.com/users/jljsj33/events{/privacy}","received_events_url":"https://api.github.com/users/jljsj33/received_events","type":"User","site_admin":false},"repo":{"id":61287556,"name":"bisheng","full_name":"jljsj33/bisheng","owner":{"login":"jljsj33","id":6802825,"avatar_url":"https://avatars.githubusercontent.com/u/6802825?v=3","gravatar_id":"","url":"https://api.github.com/users/jljsj33","html_url":"https://github.com/jljsj33","followers_url":"https://api.github.com/users/jljsj33/followers","following_url":"https://api.github.com/users/jljsj33/following{/other_user}","gists_url":"https://api.github.com/users/jljsj33/gists{/gist_id}","starred_url":"https://api.github.com/users/jljsj33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jljsj33/subscriptions","organizations_url":"https://api.github.com/users/jljsj33/orgs","repos_url":"https://api.github.com/users/jljsj33/repos","events_url":"https://api.github.com/users/jljsj33/events{/privacy}","received_events_url":"https://api.github.com/users/jljsj33/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jljsj33/bisheng","description":"Transform Markdown files into a SPA website using React.","fork":true,"url":"https://api.github.com/repos/jljsj33/bisheng","forks_url":"https://api.github.com/repos/jljsj33/bisheng/forks","keys_url":"https://api.github.com/repos/jljsj33/bisheng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jljsj33/bisheng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jljsj33/bisheng/teams","hooks_url":"https://api.github.com/repos/jljsj33/bisheng/hooks","issue_events_url":"https://api.github.com/repos/jljsj33/bisheng/issues/events{/number}","events_url":"https://api.github.com/repos/jljsj33/bisheng/events","assignees_url":"https://api.github.com/repos/jljsj33/bisheng/assignees{/user}","branches_url":"https://api.github.com/repos/jljsj33/bisheng/branches{/branch}","tags_url":"https://api.github.com/repos/jljsj33/bisheng/tags","blobs_url":"https://api.github.com/repos/jljsj33/bisheng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jljsj33/bisheng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jljsj33/bisheng/git/refs{/sha}","trees_url":"https://api.github.com/repos/jljsj33/bisheng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jljsj33/bisheng/statuses/{sha}","languages_url":"https://api.github.com/repos/jljsj33/bisheng/languages","stargazers_url":"https://api.github.com/repos/jljsj33/bisheng/stargazers","contributors_url":"https://api.github.com/repos/jljsj33/bisheng/contributors","subscribers_url":"https://api.github.com/repos/jljsj33/bisheng/subscribers","subscription_url":"https://api.github.com/repos/jljsj33/bisheng/subscription","commits_url":"https://api.github.com/repos/jljsj33/bisheng/commits{/sha}","git_commits_url":"https://api.github.com/repos/jljsj33/bisheng/git/commits{/sha}","comments_url":"https://api.github.com/repos/jljsj33/bisheng/comments{/number}","issue_comment_url":"https://api.github.com/repos/jljsj33/bisheng/issues/comments{/number}","contents_url":"https://api.github.com/repos/jljsj33/bisheng/contents/{+path}","compare_url":"https://api.github.com/repos/jljsj33/bisheng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jljsj33/bisheng/merges","archive_url":"https://api.github.com/repos/jljsj33/bisheng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jljsj33/bisheng/downloads","issues_url":"https://api.github.com/repos/jljsj33/bisheng/issues{/number}","pulls_url":"https://api.github.com/repos/jljsj33/bisheng/pulls{/number}","milestones_url":"https://api.github.com/repos/jljsj33/bisheng/milestones{/number}","notifications_url":"https://api.github.com/repos/jljsj33/bisheng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jljsj33/bisheng/labels{/name}","releases_url":"https://api.github.com/repos/jljsj33/bisheng/releases{/id}","deployments_url":"https://api.github.com/repos/jljsj33/bisheng/deployments","created_at":"2016-06-16T11:30:59Z","updated_at":"2016-06-16T11:31:00Z","pushed_at":"2016-07-07T12:38:45Z","git_url":"git://github.com/jljsj33/bisheng.git","ssh_url":"git@github.com:jljsj33/bisheng.git","clone_url":"https://github.com/jljsj33/bisheng.git","svn_url":"https://github.com/jljsj33/bisheng","homepage":null,"size":87,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"benjycui:master","ref":"master","sha":"ac9af2f4600d33b2c7a2a748927a314ee098b59c","user":{"login":"benjycui","id":3580607,"avatar_url":"https://avatars.githubusercontent.com/u/3580607?v=3","gravatar_id":"","url":"https://api.github.com/users/benjycui","html_url":"https://github.com/benjycui","followers_url":"https://api.github.com/users/benjycui/followers","following_url":"https://api.github.com/users/benjycui/following{/other_user}","gists_url":"https://api.github.com/users/benjycui/gists{/gist_id}","starred_url":"https://api.github.com/users/benjycui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjycui/subscriptions","organizations_url":"https://api.github.com/users/benjycui/orgs","repos_url":"https://api.github.com/users/benjycui/repos","events_url":"https://api.github.com/users/benjycui/events{/privacy}","received_events_url":"https://api.github.com/users/benjycui/received_events","type":"User","site_admin":false},"repo":{"id":56841559,"name":"bisheng","full_name":"benjycui/bisheng","owner":{"login":"benjycui","id":3580607,"avatar_url":"https://avatars.githubusercontent.com/u/3580607?v=3","gravatar_id":"","url":"https://api.github.com/users/benjycui","html_url":"https://github.com/benjycui","followers_url":"https://api.github.com/users/benjycui/followers","following_url":"https://api.github.com/users/benjycui/following{/other_user}","gists_url":"https://api.github.com/users/benjycui/gists{/gist_id}","starred_url":"https://api.github.com/users/benjycui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjycui/subscriptions","organizations_url":"https://api.github.com/users/benjycui/orgs","repos_url":"https://api.github.com/users/benjycui/repos","events_url":"https://api.github.com/users/benjycui/events{/privacy}","received_events_url":"https://api.github.com/users/benjycui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjycui/bisheng","description":"Transform Markdown files into a SPA website using React.","fork":false,"url":"https://api.github.com/repos/benjycui/bisheng","forks_url":"https://api.github.com/repos/benjycui/bisheng/forks","keys_url":"https://api.github.com/repos/benjycui/bisheng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjycui/bisheng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjycui/bisheng/teams","hooks_url":"https://api.github.com/repos/benjycui/bisheng/hooks","issue_events_url":"https://api.github.com/repos/benjycui/bisheng/issues/events{/number}","events_url":"https://api.github.com/repos/benjycui/bisheng/events","assignees_url":"https://api.github.com/repos/benjycui/bisheng/assignees{/user}","branches_url":"https://api.github.com/repos/benjycui/bisheng/branches{/branch}","tags_url":"https://api.github.com/repos/benjycui/bisheng/tags","blobs_url":"https://api.github.com/repos/benjycui/bisheng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjycui/bisheng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjycui/bisheng/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjycui/bisheng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjycui/bisheng/statuses/{sha}","languages_url":"https://api.github.com/repos/benjycui/bisheng/languages","stargazers_url":"https://api.github.com/repos/benjycui/bisheng/stargazers","contributors_url":"https://api.github.com/repos/benjycui/bisheng/contributors","subscribers_url":"https://api.github.com/repos/benjycui/bisheng/subscribers","subscription_url":"https://api.github.com/repos/benjycui/bisheng/subscription","commits_url":"https://api.github.com/repos/benjycui/bisheng/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjycui/bisheng/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjycui/bisheng/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjycui/bisheng/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjycui/bisheng/contents/{+path}","compare_url":"https://api.github.com/repos/benjycui/bisheng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjycui/bisheng/merges","archive_url":"https://api.github.com/repos/benjycui/bisheng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjycui/bisheng/downloads","issues_url":"https://api.github.com/repos/benjycui/bisheng/issues{/number}","pulls_url":"https://api.github.com/repos/benjycui/bisheng/pulls{/number}","milestones_url":"https://api.github.com/repos/benjycui/bisheng/milestones{/number}","notifications_url":"https://api.github.com/repos/benjycui/bisheng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjycui/bisheng/labels{/name}","releases_url":"https://api.github.com/repos/benjycui/bisheng/releases{/id}","deployments_url":"https://api.github.com/repos/benjycui/bisheng/deployments","created_at":"2016-04-22T08:55:28Z","updated_at":"2016-07-13T06:52:51Z","pushed_at":"2016-07-14T01:27:45Z","git_url":"git://github.com/benjycui/bisheng.git","ssh_url":"git@github.com:benjycui/bisheng.git","clone_url":"https://github.com/benjycui/bisheng.git","svn_url":"https://github.com/benjycui/bisheng","homepage":null,"size":85,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benjycui/bisheng/pulls/27"},"html":{"href":"https://github.com/benjycui/bisheng/pull/27"},"issue":{"href":"https://api.github.com/repos/benjycui/bisheng/issues/27"},"comments":{"href":"https://api.github.com/repos/benjycui/bisheng/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/benjycui/bisheng/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/benjycui/bisheng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benjycui/bisheng/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/benjycui/bisheng/statuses/62b5c3651e06a26ee31acc1f7c1e7989e7fd324b"}}}}
{"actor":{"display_login":"benjycui"}}