{"action":"created","comment":{"url":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/comments/61681427","id":61681427,"diff_hunk":"@@ -0,0 +1,66 @@\n+/* -*- mode:js; indent-tabs-mode:true; tab-width: 4 -*- */\n+const GObject = imports.gi.GObject;\n+const Gtk = imports.gi.Gtk;\n+const Lang = imports.lang;\n+\n+const Gettext = imports.gettext.domain('pixel-saver');\n+const _ = Gettext.gettext;\n+\n+const Me = imports.misc.extensionUtils.getCurrentExtension();\n+const Convenience = Me.imports.convenience;\n+const Settings = Me.imports.settings;\n+\n+function init() {\n+\tConvenience.initTranslations('pixel-saver');\n+}\n+\n+function column(label, widget) {\n+\tlet box = new Gtk.Box({\n+\t\torientation: Gtk.Orientation.HORIZONTAL,\n+\t\tspacing: 18\n+\t});\n+\tbox.add(label);\n+\tbox.pack_end(widget, true, true, 0);\n+\n+\treturn box;\n+}\n+\n+const PixelSaverPrefsWidget = new GObject.Class({\n+\tName: 'PixelSaver.Prefs.Widget',\n+\tGTypeName: 'PixelSaverPrefsWidget',\n+\tExtends: Gtk.Box,\n+\n+\t_init: function(params) {\n+\t\tthis.parent(params);\n+\n+\t\tthis.orientation = Gtk.Orientation.VERTICAL;\n+\t\tthis.border_width = 18;\n+\t\tthis.spacing = 6;\n+\n+\t\tlet options = new Settings.Options();\n+\n+\t\tlet buttonPositionLabel = new Gtk.Label({\n+\t\t\tlabel: _(\"Show window buttons in top panel\"),\n+\t\t});\n+\n+\t\tlet buttonPositionCombo = new Gtk.ComboBoxText({ halign:Gtk.Align.END });\n+\t\tbuttonPositionCombo.set_size_request(120, -1);\n+\t\tbuttonPositionCombo.append('left', _(\"Left\"));\n+\t\tbuttonPositionCombo.append('right', _(\"Right\"));\n+\t\tbuttonPositionCombo.append('hidden', _(\"Don't show\"));\n+\t\tbuttonPositionCombo.set_active_id(options.BUTTON_POSITION.get());\n+\t\tbuttonPositionCombo.connect('changed', Lang.bind(this, function(widget) {\n+\t\t\toptions.BUTTON_POSITION.set(widget.get_active_id());\n+\t\t}));\n+\n+\t\tthis.add(column(buttonPositionLabel, buttonPositionCombo));\n+\t}\n+});","path":"pixel-saver@deadalnix.me/prefs.js","position":58,"original_position":58,"commit_id":"44a9b3ff4a379376fbecd80c42cc2a63cc7e3ce1","original_commit_id":"44a9b3ff4a379376fbecd80c42cc2a63cc7e3ce1","user":{"login":"deadalnix","id":854121,"avatar_url":"https://avatars.githubusercontent.com/u/854121?v=3","gravatar_id":"","url":"https://api.github.com/users/deadalnix","html_url":"https://github.com/deadalnix","followers_url":"https://api.github.com/users/deadalnix/followers","following_url":"https://api.github.com/users/deadalnix/following{/other_user}","gists_url":"https://api.github.com/users/deadalnix/gists{/gist_id}","starred_url":"https://api.github.com/users/deadalnix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deadalnix/subscriptions","organizations_url":"https://api.github.com/users/deadalnix/orgs","repos_url":"https://api.github.com/users/deadalnix/repos","events_url":"https://api.github.com/users/deadalnix/events{/privacy}","received_events_url":"https://api.github.com/users/deadalnix/received_events","type":"User","site_admin":false},"body":"is creating a class necessary here ? It seems like this is breaking with the style of everything else but I'm not sure there is a good reason.","created_at":"2016-05-01T06:26:43Z","updated_at":"2016-05-01T06:26:43Z","html_url":"https://github.com/deadalnix/pixel-saver/pull/56#discussion_r61681427","pull_request_url":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/comments/61681427"},"html":{"href":"https://github.com/deadalnix/pixel-saver/pull/56#discussion_r61681427"},"pull_request":{"href":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/56","id":65848127,"html_url":"https://github.com/deadalnix/pixel-saver/pull/56","diff_url":"https://github.com/deadalnix/pixel-saver/pull/56.diff","patch_url":"https://github.com/deadalnix/pixel-saver/pull/56.patch","issue_url":"https://api.github.com/repos/deadalnix/pixel-saver/issues/56","number":56,"state":"open","locked":false,"title":"Make display of window buttons in top bar user configurable, fixes #35","user":{"login":"marcohu","id":487062,"avatar_url":"https://avatars.githubusercontent.com/u/487062?v=3","gravatar_id":"","url":"https://api.github.com/users/marcohu","html_url":"https://github.com/marcohu","followers_url":"https://api.github.com/users/marcohu/followers","following_url":"https://api.github.com/users/marcohu/following{/other_user}","gists_url":"https://api.github.com/users/marcohu/gists{/gist_id}","starred_url":"https://api.github.com/users/marcohu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcohu/subscriptions","organizations_url":"https://api.github.com/users/marcohu/orgs","repos_url":"https://api.github.com/users/marcohu/repos","events_url":"https://api.github.com/users/marcohu/events{/privacy}","received_events_url":"https://api.github.com/users/marcohu/received_events","type":"User","site_admin":false},"body":"Here is the promised pull request against master that fixes #35. This time things are straightforward and I hope you can agree that some configuration won't hurt. If you go forward with this, the readme should probably be adjusted as well to reflect the changes. I could send another pull request for that.\r\n\r\nIf you have any questions, please don't hesitate to contact me. Thanks.\r\n\r\nCheers ","created_at":"2016-04-08T21:12:35Z","updated_at":"2016-05-01T06:26:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0a5add00d69041418801e9d680ed251a2a48cbc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/56/commits","review_comments_url":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/56/comments","review_comment_url":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deadalnix/pixel-saver/issues/56/comments","statuses_url":"https://api.github.com/repos/deadalnix/pixel-saver/statuses/44a9b3ff4a379376fbecd80c42cc2a63cc7e3ce1","head":{"label":"marcohu:master","ref":"master","sha":"44a9b3ff4a379376fbecd80c42cc2a63cc7e3ce1","user":{"login":"marcohu","id":487062,"avatar_url":"https://avatars.githubusercontent.com/u/487062?v=3","gravatar_id":"","url":"https://api.github.com/users/marcohu","html_url":"https://github.com/marcohu","followers_url":"https://api.github.com/users/marcohu/followers","following_url":"https://api.github.com/users/marcohu/following{/other_user}","gists_url":"https://api.github.com/users/marcohu/gists{/gist_id}","starred_url":"https://api.github.com/users/marcohu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcohu/subscriptions","organizations_url":"https://api.github.com/users/marcohu/orgs","repos_url":"https://api.github.com/users/marcohu/repos","events_url":"https://api.github.com/users/marcohu/events{/privacy}","received_events_url":"https://api.github.com/users/marcohu/received_events","type":"User","site_admin":false},"repo":{"id":55428607,"name":"pixel-saver","full_name":"marcohu/pixel-saver","owner":{"login":"marcohu","id":487062,"avatar_url":"https://avatars.githubusercontent.com/u/487062?v=3","gravatar_id":"","url":"https://api.github.com/users/marcohu","html_url":"https://github.com/marcohu","followers_url":"https://api.github.com/users/marcohu/followers","following_url":"https://api.github.com/users/marcohu/following{/other_user}","gists_url":"https://api.github.com/users/marcohu/gists{/gist_id}","starred_url":"https://api.github.com/users/marcohu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcohu/subscriptions","organizations_url":"https://api.github.com/users/marcohu/orgs","repos_url":"https://api.github.com/users/marcohu/repos","events_url":"https://api.github.com/users/marcohu/events{/privacy}","received_events_url":"https://api.github.com/users/marcohu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcohu/pixel-saver","description":"Pixel Saver is a GNOME Shell extension that merges traditional-style title bars of maximized windows with the top panel to save screen real estate.","fork":true,"url":"https://api.github.com/repos/marcohu/pixel-saver","forks_url":"https://api.github.com/repos/marcohu/pixel-saver/forks","keys_url":"https://api.github.com/repos/marcohu/pixel-saver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcohu/pixel-saver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcohu/pixel-saver/teams","hooks_url":"https://api.github.com/repos/marcohu/pixel-saver/hooks","issue_events_url":"https://api.github.com/repos/marcohu/pixel-saver/issues/events{/number}","events_url":"https://api.github.com/repos/marcohu/pixel-saver/events","assignees_url":"https://api.github.com/repos/marcohu/pixel-saver/assignees{/user}","branches_url":"https://api.github.com/repos/marcohu/pixel-saver/branches{/branch}","tags_url":"https://api.github.com/repos/marcohu/pixel-saver/tags","blobs_url":"https://api.github.com/repos/marcohu/pixel-saver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcohu/pixel-saver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcohu/pixel-saver/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcohu/pixel-saver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcohu/pixel-saver/statuses/{sha}","languages_url":"https://api.github.com/repos/marcohu/pixel-saver/languages","stargazers_url":"https://api.github.com/repos/marcohu/pixel-saver/stargazers","contributors_url":"https://api.github.com/repos/marcohu/pixel-saver/contributors","subscribers_url":"https://api.github.com/repos/marcohu/pixel-saver/subscribers","subscription_url":"https://api.github.com/repos/marcohu/pixel-saver/subscription","commits_url":"https://api.github.com/repos/marcohu/pixel-saver/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcohu/pixel-saver/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcohu/pixel-saver/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcohu/pixel-saver/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcohu/pixel-saver/contents/{+path}","compare_url":"https://api.github.com/repos/marcohu/pixel-saver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcohu/pixel-saver/merges","archive_url":"https://api.github.com/repos/marcohu/pixel-saver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcohu/pixel-saver/downloads","issues_url":"https://api.github.com/repos/marcohu/pixel-saver/issues{/number}","pulls_url":"https://api.github.com/repos/marcohu/pixel-saver/pulls{/number}","milestones_url":"https://api.github.com/repos/marcohu/pixel-saver/milestones{/number}","notifications_url":"https://api.github.com/repos/marcohu/pixel-saver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcohu/pixel-saver/labels{/name}","releases_url":"https://api.github.com/repos/marcohu/pixel-saver/releases{/id}","deployments_url":"https://api.github.com/repos/marcohu/pixel-saver/deployments","created_at":"2016-04-04T16:52:36Z","updated_at":"2016-04-29T19:53:16Z","pushed_at":"2016-04-30T13:31:16Z","git_url":"git://github.com/marcohu/pixel-saver.git","ssh_url":"git@github.com:marcohu/pixel-saver.git","clone_url":"https://github.com/marcohu/pixel-saver.git","svn_url":"https://github.com/marcohu/pixel-saver","homepage":"","size":846,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deadalnix:master","ref":"master","sha":"363396881dc45fa3c90457ebff366481690ecafb","user":{"login":"deadalnix","id":854121,"avatar_url":"https://avatars.githubusercontent.com/u/854121?v=3","gravatar_id":"","url":"https://api.github.com/users/deadalnix","html_url":"https://github.com/deadalnix","followers_url":"https://api.github.com/users/deadalnix/followers","following_url":"https://api.github.com/users/deadalnix/following{/other_user}","gists_url":"https://api.github.com/users/deadalnix/gists{/gist_id}","starred_url":"https://api.github.com/users/deadalnix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deadalnix/subscriptions","organizations_url":"https://api.github.com/users/deadalnix/orgs","repos_url":"https://api.github.com/users/deadalnix/repos","events_url":"https://api.github.com/users/deadalnix/events{/privacy}","received_events_url":"https://api.github.com/users/deadalnix/received_events","type":"User","site_admin":false},"repo":{"id":12684122,"name":"pixel-saver","full_name":"deadalnix/pixel-saver","owner":{"login":"deadalnix","id":854121,"avatar_url":"https://avatars.githubusercontent.com/u/854121?v=3","gravatar_id":"","url":"https://api.github.com/users/deadalnix","html_url":"https://github.com/deadalnix","followers_url":"https://api.github.com/users/deadalnix/followers","following_url":"https://api.github.com/users/deadalnix/following{/other_user}","gists_url":"https://api.github.com/users/deadalnix/gists{/gist_id}","starred_url":"https://api.github.com/users/deadalnix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deadalnix/subscriptions","organizations_url":"https://api.github.com/users/deadalnix/orgs","repos_url":"https://api.github.com/users/deadalnix/repos","events_url":"https://api.github.com/users/deadalnix/events{/privacy}","received_events_url":"https://api.github.com/users/deadalnix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deadalnix/pixel-saver","description":"Pixel Saver","fork":false,"url":"https://api.github.com/repos/deadalnix/pixel-saver","forks_url":"https://api.github.com/repos/deadalnix/pixel-saver/forks","keys_url":"https://api.github.com/repos/deadalnix/pixel-saver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deadalnix/pixel-saver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deadalnix/pixel-saver/teams","hooks_url":"https://api.github.com/repos/deadalnix/pixel-saver/hooks","issue_events_url":"https://api.github.com/repos/deadalnix/pixel-saver/issues/events{/number}","events_url":"https://api.github.com/repos/deadalnix/pixel-saver/events","assignees_url":"https://api.github.com/repos/deadalnix/pixel-saver/assignees{/user}","branches_url":"https://api.github.com/repos/deadalnix/pixel-saver/branches{/branch}","tags_url":"https://api.github.com/repos/deadalnix/pixel-saver/tags","blobs_url":"https://api.github.com/repos/deadalnix/pixel-saver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deadalnix/pixel-saver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deadalnix/pixel-saver/git/refs{/sha}","trees_url":"https://api.github.com/repos/deadalnix/pixel-saver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deadalnix/pixel-saver/statuses/{sha}","languages_url":"https://api.github.com/repos/deadalnix/pixel-saver/languages","stargazers_url":"https://api.github.com/repos/deadalnix/pixel-saver/stargazers","contributors_url":"https://api.github.com/repos/deadalnix/pixel-saver/contributors","subscribers_url":"https://api.github.com/repos/deadalnix/pixel-saver/subscribers","subscription_url":"https://api.github.com/repos/deadalnix/pixel-saver/subscription","commits_url":"https://api.github.com/repos/deadalnix/pixel-saver/commits{/sha}","git_commits_url":"https://api.github.com/repos/deadalnix/pixel-saver/git/commits{/sha}","comments_url":"https://api.github.com/repos/deadalnix/pixel-saver/comments{/number}","issue_comment_url":"https://api.github.com/repos/deadalnix/pixel-saver/issues/comments{/number}","contents_url":"https://api.github.com/repos/deadalnix/pixel-saver/contents/{+path}","compare_url":"https://api.github.com/repos/deadalnix/pixel-saver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deadalnix/pixel-saver/merges","archive_url":"https://api.github.com/repos/deadalnix/pixel-saver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deadalnix/pixel-saver/downloads","issues_url":"https://api.github.com/repos/deadalnix/pixel-saver/issues{/number}","pulls_url":"https://api.github.com/repos/deadalnix/pixel-saver/pulls{/number}","milestones_url":"https://api.github.com/repos/deadalnix/pixel-saver/milestones{/number}","notifications_url":"https://api.github.com/repos/deadalnix/pixel-saver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deadalnix/pixel-saver/labels{/name}","releases_url":"https://api.github.com/repos/deadalnix/pixel-saver/releases{/id}","deployments_url":"https://api.github.com/repos/deadalnix/pixel-saver/deployments","created_at":"2013-09-08T16:59:05Z","updated_at":"2016-05-01T05:00:43Z","pushed_at":"2016-05-01T06:19:06Z","git_url":"git://github.com/deadalnix/pixel-saver.git","ssh_url":"git@github.com:deadalnix/pixel-saver.git","clone_url":"https://github.com/deadalnix/pixel-saver.git","svn_url":"https://github.com/deadalnix/pixel-saver","homepage":null,"size":196,"stargazers_count":96,"watchers_count":96,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":29,"forks":23,"open_issues":29,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/56"},"html":{"href":"https://github.com/deadalnix/pixel-saver/pull/56"},"issue":{"href":"https://api.github.com/repos/deadalnix/pixel-saver/issues/56"},"comments":{"href":"https://api.github.com/repos/deadalnix/pixel-saver/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deadalnix/pixel-saver/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/deadalnix/pixel-saver/statuses/44a9b3ff4a379376fbecd80c42cc2a63cc7e3ce1"}}}}