{"action":"created","comment":{"url":"https://api.github.com/repos/eslint/eslint/pulls/comments/54573482","id":54573482,"diff_hunk":"@@ -1,20 +1,12 @@\n # Disallow Empty Block Statements (no-empty)\n \n-Empty block statements usually occur due to refactoring that wasn't completed, such as:\n-\n-```js\n-if (foo) {\n-}\n-```\n-\n-Empty block statements such as this are usually an indicator of an error, or at the very least, an indicator that some refactoring is likely needed.\n+Empty block statements, while not technically errors, usually occur due to refactoring that wasn't completed. They can cause confusion when reading code.\n \n ## Rule Details\n \n-This rule is aimed at eliminating empty block statements. While not technically an error, empty block statements can be a source of confusion when reading code.\n-A block will not be considered a warning if it contains a comment line.\n+This rule is aimed at eliminating empty block statements. If an empty block contains a comment, it is **correct** code for this rule.","path":"docs/rules/no-empty.md","position":17,"original_position":17,"commit_id":"b008da903e976b3f660a7871ef8c2c8d3e699a3b","original_commit_id":"b008da903e976b3f660a7871ef8c2c8d3e699a3b","user":{"login":"michaelficarra","id":218840,"avatar_url":"https://avatars.githubusercontent.com/u/218840?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelficarra","html_url":"https://github.com/michaelficarra","followers_url":"https://api.github.com/users/michaelficarra/followers","following_url":"https://api.github.com/users/michaelficarra/following{/other_user}","gists_url":"https://api.github.com/users/michaelficarra/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelficarra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelficarra/subscriptions","organizations_url":"https://api.github.com/users/michaelficarra/orgs","repos_url":"https://api.github.com/users/michaelficarra/repos","events_url":"https://api.github.com/users/michaelficarra/events{/privacy}","received_events_url":"https://api.github.com/users/michaelficarra/received_events","type":"User","site_admin":false},"body":"That is one of the reasons that I always try to use the verb \"report\".","created_at":"2016-03-01T14:30:48Z","updated_at":"2016-03-01T14:30:48Z","html_url":"https://github.com/eslint/eslint/pull/5436#discussion_r54573482","pull_request_url":"https://api.github.com/repos/eslint/eslint/pulls/5436","_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments/54573482"},"html":{"href":"https://github.com/eslint/eslint/pull/5436#discussion_r54573482"},"pull_request":{"href":"https://api.github.com/repos/eslint/eslint/pulls/5436"}}},"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/5436","id":61124885,"html_url":"https://github.com/eslint/eslint/pull/5436","diff_url":"https://github.com/eslint/eslint/pull/5436.diff","patch_url":"https://github.com/eslint/eslint/pull/5436.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/5436","number":5436,"state":"open","locked":false,"title":"Docs: Distinguish examples in rules under Possible Errors part 1","user":{"login":"pedrottimark","id":11862657,"avatar_url":"https://avatars.githubusercontent.com/u/11862657?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrottimark","html_url":"https://github.com/pedrottimark","followers_url":"https://api.github.com/users/pedrottimark/followers","following_url":"https://api.github.com/users/pedrottimark/following{/other_user}","gists_url":"https://api.github.com/users/pedrottimark/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrottimark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrottimark/subscriptions","organizations_url":"https://api.github.com/users/pedrottimark/orgs","repos_url":"https://api.github.com/users/pedrottimark/repos","events_url":"https://api.github.com/users/pedrottimark/events{/privacy}","received_events_url":"https://api.github.com/users/pedrottimark/received_events","type":"User","site_admin":false},"body":"First of two pull requests for rules under **Possible Errors**.\r\n\r\nHere are the changes beyond example sentences:\r\n\r\n* comma-dangle: add **Options**; move default option first in list; replace status 1 with 2\r\n* no-cond-assign: simplify paragraphs about options; **Related Rules** no-extra-parens\r\n* no-constant-condition rewrite rule details\r\n* no-dupe-args: rewrite rule details; add example of correct code\r\n* no-duplicate-case: rewrite introduction and rule details; move intro example to incorrect code and make correct code parallel; *sorry this rule wins hash-of-changes prize for this batch*\r\n* no-empty: rewrite sentence about comment; include both line and block comments in correct code\r\n* no-extra-parens: replace h4 Fine-grained control with h3 conditionalAssign; **Related Rules** no-cond-assign\r\n","created_at":"2016-02-29T18:50:39Z","updated_at":"2016-03-01T14:30:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdf81b83f9c37634cd0ec5c2a6e3fcd09d96dcaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/5436/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/5436/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/5436/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/b008da903e976b3f660a7871ef8c2c8d3e699a3b","head":{"label":"pedrottimark:distinguish-examples-possible-errors-1","ref":"distinguish-examples-possible-errors-1","sha":"b008da903e976b3f660a7871ef8c2c8d3e699a3b","user":{"login":"pedrottimark","id":11862657,"avatar_url":"https://avatars.githubusercontent.com/u/11862657?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrottimark","html_url":"https://github.com/pedrottimark","followers_url":"https://api.github.com/users/pedrottimark/followers","following_url":"https://api.github.com/users/pedrottimark/following{/other_user}","gists_url":"https://api.github.com/users/pedrottimark/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrottimark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrottimark/subscriptions","organizations_url":"https://api.github.com/users/pedrottimark/orgs","repos_url":"https://api.github.com/users/pedrottimark/repos","events_url":"https://api.github.com/users/pedrottimark/events{/privacy}","received_events_url":"https://api.github.com/users/pedrottimark/received_events","type":"User","site_admin":false},"repo":{"id":50926047,"name":"eslint","full_name":"pedrottimark/eslint","owner":{"login":"pedrottimark","id":11862657,"avatar_url":"https://avatars.githubusercontent.com/u/11862657?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrottimark","html_url":"https://github.com/pedrottimark","followers_url":"https://api.github.com/users/pedrottimark/followers","following_url":"https://api.github.com/users/pedrottimark/following{/other_user}","gists_url":"https://api.github.com/users/pedrottimark/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrottimark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrottimark/subscriptions","organizations_url":"https://api.github.com/users/pedrottimark/orgs","repos_url":"https://api.github.com/users/pedrottimark/repos","events_url":"https://api.github.com/users/pedrottimark/events{/privacy}","received_events_url":"https://api.github.com/users/pedrottimark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pedrottimark/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":true,"url":"https://api.github.com/repos/pedrottimark/eslint","forks_url":"https://api.github.com/repos/pedrottimark/eslint/forks","keys_url":"https://api.github.com/repos/pedrottimark/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedrottimark/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedrottimark/eslint/teams","hooks_url":"https://api.github.com/repos/pedrottimark/eslint/hooks","issue_events_url":"https://api.github.com/repos/pedrottimark/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/pedrottimark/eslint/events","assignees_url":"https://api.github.com/repos/pedrottimark/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/pedrottimark/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/pedrottimark/eslint/tags","blobs_url":"https://api.github.com/repos/pedrottimark/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedrottimark/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedrottimark/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedrottimark/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedrottimark/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/pedrottimark/eslint/languages","stargazers_url":"https://api.github.com/repos/pedrottimark/eslint/stargazers","contributors_url":"https://api.github.com/repos/pedrottimark/eslint/contributors","subscribers_url":"https://api.github.com/repos/pedrottimark/eslint/subscribers","subscription_url":"https://api.github.com/repos/pedrottimark/eslint/subscription","commits_url":"https://api.github.com/repos/pedrottimark/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedrottimark/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedrottimark/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedrottimark/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/pedrottimark/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/pedrottimark/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedrottimark/eslint/merges","archive_url":"https://api.github.com/repos/pedrottimark/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedrottimark/eslint/downloads","issues_url":"https://api.github.com/repos/pedrottimark/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/pedrottimark/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/pedrottimark/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/pedrottimark/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedrottimark/eslint/labels{/name}","releases_url":"https://api.github.com/repos/pedrottimark/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/pedrottimark/eslint/deployments","created_at":"2016-02-02T14:28:38Z","updated_at":"2016-02-02T14:28:41Z","pushed_at":"2016-02-29T18:43:59Z","git_url":"git://github.com/pedrottimark/eslint.git","ssh_url":"git@github.com:pedrottimark/eslint.git","clone_url":"https://github.com/pedrottimark/eslint.git","svn_url":"https://github.com/pedrottimark/eslint","homepage":"http://eslint.org","size":9336,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"4a7f9919e7e30121a217dbcd7383dfc4c5775858","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/eslint/eslint/deployments","created_at":"2013-06-29T23:59:48Z","updated_at":"2016-03-01T13:37:25Z","pushed_at":"2016-03-01T05:05:49Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"http://eslint.org","size":13394,"stargazers_count":4234,"watchers_count":4234,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":838,"mirror_url":null,"open_issues_count":180,"forks":838,"open_issues":180,"watchers":4234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/5436"},"html":{"href":"https://github.com/eslint/eslint/pull/5436"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/5436"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/5436/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/5436/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/5436/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/b008da903e976b3f660a7871ef8c2c8d3e699a3b"}}}}