{"action":"created","issue":{"url":"https://api.github.com/repos/buggy-programmer/utility/issues/1","labels_url":"https://api.github.com/repos/buggy-programmer/utility/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/buggy-programmer/utility/issues/1/comments","events_url":"https://api.github.com/repos/buggy-programmer/utility/issues/1/events","html_url":"https://github.com/buggy-programmer/utility/pull/1","id":124918886,"number":1,"title":"Update jsutilities","user":{"login":"rt-jar","id":4495639,"avatar_url":"https://avatars.githubusercontent.com/u/4495639?v=3","gravatar_id":"","url":"https://api.github.com/users/rt-jar","html_url":"https://github.com/rt-jar","followers_url":"https://api.github.com/users/rt-jar/followers","following_url":"https://api.github.com/users/rt-jar/following{/other_user}","gists_url":"https://api.github.com/users/rt-jar/gists{/gist_id}","starred_url":"https://api.github.com/users/rt-jar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rt-jar/subscriptions","organizations_url":"https://api.github.com/users/rt-jar/orgs","repos_url":"https://api.github.com/users/rt-jar/repos","events_url":"https://api.github.com/users/rt-jar/events{/privacy}","received_events_url":"https://api.github.com/users/rt-jar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-05T08:31:44Z","updated_at":"2016-01-06T06:04:59Z","closed_at":"2016-01-05T09:11:37Z","pull_request":{"url":"https://api.github.com/repos/buggy-programmer/utility/pulls/1","html_url":"https://github.com/buggy-programmer/utility/pull/1","diff_url":"https://github.com/buggy-programmer/utility/pull/1.diff","patch_url":"https://github.com/buggy-programmer/utility/pull/1.patch"},"body":"I had done some changes in getDateDifference."},"comment":{"url":"https://api.github.com/repos/buggy-programmer/utility/issues/comments/169240549","html_url":"https://github.com/buggy-programmer/utility/pull/1#issuecomment-169240549","issue_url":"https://api.github.com/repos/buggy-programmer/utility/issues/1","id":169240549,"user":{"login":"buggy-programmer","id":9882520,"avatar_url":"https://avatars.githubusercontent.com/u/9882520?v=3","gravatar_id":"","url":"https://api.github.com/users/buggy-programmer","html_url":"https://github.com/buggy-programmer","followers_url":"https://api.github.com/users/buggy-programmer/followers","following_url":"https://api.github.com/users/buggy-programmer/following{/other_user}","gists_url":"https://api.github.com/users/buggy-programmer/gists{/gist_id}","starred_url":"https://api.github.com/users/buggy-programmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buggy-programmer/subscriptions","organizations_url":"https://api.github.com/users/buggy-programmer/orgs","repos_url":"https://api.github.com/users/buggy-programmer/repos","events_url":"https://api.github.com/users/buggy-programmer/events{/privacy}","received_events_url":"https://api.github.com/users/buggy-programmer/received_events","type":"User","site_admin":false},"created_at":"2016-01-06T06:04:59Z","updated_at":"2016-01-06T06:04:59Z","body":"Thanks for your input but on the contrary i think differently and that check is not appropriate for the following reasons\r\n\r\n1 I/O are in string format, actual data is always in string format so it is easier to use it in a pure form and need not make an object just to compare data.\r\n2 Why one should limit a function to use only an object when one can use it in string format as well in addition to object this gives more flexibility in using the function.\r\n3 Second return of the function already converts both d1, d2 variable into Date object before and then perform the operations on it, so this check is totally invalid \r\n4 I know pure function def but it doesn't says that you should not be using it at all even the cases where it can be used and which can provide more feasibility to the function/solution.\r\n\r\nThanks for your valuable inputs and its always welcome its always a good learning in this type of discussion "}}