{"action":"opened","number":119,"pull_request":{"url":"https://api.github.com/repos/ArcticaProject/nx-libs/pulls/119","id":67703494,"html_url":"https://github.com/ArcticaProject/nx-libs/pull/119","diff_url":"https://github.com/ArcticaProject/nx-libs/pull/119.diff","patch_url":"https://github.com/ArcticaProject/nx-libs/pull/119.patch","issue_url":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/119","number":119,"state":"open","locked":false,"title":"Clean up compiler warnings in nxcomp","user":{"login":"fcarvajaldev","id":17450557,"avatar_url":"https://avatars.githubusercontent.com/u/17450557?v=3","gravatar_id":"","url":"https://api.github.com/users/fcarvajaldev","html_url":"https://github.com/fcarvajaldev","followers_url":"https://api.github.com/users/fcarvajaldev/followers","following_url":"https://api.github.com/users/fcarvajaldev/following{/other_user}","gists_url":"https://api.github.com/users/fcarvajaldev/gists{/gist_id}","starred_url":"https://api.github.com/users/fcarvajaldev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcarvajaldev/subscriptions","organizations_url":"https://api.github.com/users/fcarvajaldev/orgs","repos_url":"https://api.github.com/users/fcarvajaldev/repos","events_url":"https://api.github.com/users/fcarvajaldev/events{/privacy}","received_events_url":"https://api.github.com/users/fcarvajaldev/received_events","type":"User","site_admin":false},"body":"Besides the warnings included in ArcticaProject's issue #103 there has\r\nbeen removed another one related to setgid and setuid returning values\r\nnot being checked:\r\n\r\nPipe.cpp: In function ‘FILE* Popen(char* const*, const char*)’:\r\nPipe.cpp:240:23: warning: ignoring return value of ‘int setgid(__gid_t)’,\r\ndeclared with attribute warn_unused_result [-Wunused-result]\r\n       setgid(getgid());\r\n                       ^\r\nPipe.cpp:241:23: warning: ignoring return value of ‘int setuid(__uid_t)’,\r\ndeclared with attribute warn_unused_result [-Wunused-result]\r\n       setuid(getuid());\r\n                       ^\r\n\r\nThere was also a hidden problem in the way Proxy::handleSaveAllStores was\r\nchecking for an error in the returning value from the call to the virtual\r\nmethod handleSaveAllStores of the specific proxy class really being used\r\n(ClientProxy or ServerProxy).\r\n\r\nFormer code was considering the value 0 as the returning value in case of\r\nan error whereas both subclasses return the value -1 when there is an error\r\nin their handleSaveAllStores method.\r\n\r\nThis bug has been fixed in this commit taking advantage of the modification\r\nthat was already being made to this method in order to replace tempnam\r\nfunction with the more secure one mkstemp.\r\n\r\nRefs: ArcticaProject/nx-libs#103","created_at":"2016-04-25T11:24:34Z","updated_at":"2016-04-25T11:24:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ArcticaProject/nx-libs/pulls/119/commits","review_comments_url":"https://api.github.com/repos/ArcticaProject/nx-libs/pulls/119/comments","review_comment_url":"https://api.github.com/repos/ArcticaProject/nx-libs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/119/comments","statuses_url":"https://api.github.com/repos/ArcticaProject/nx-libs/statuses/baaf58150155db69a5ec95406db7cc45e8f17d42","head":{"label":"fcarvajaldev:3.6.x-nxcomp-amend-compiler-warnings","ref":"3.6.x-nxcomp-amend-compiler-warnings","sha":"baaf58150155db69a5ec95406db7cc45e8f17d42","user":{"login":"fcarvajaldev","id":17450557,"avatar_url":"https://avatars.githubusercontent.com/u/17450557?v=3","gravatar_id":"","url":"https://api.github.com/users/fcarvajaldev","html_url":"https://github.com/fcarvajaldev","followers_url":"https://api.github.com/users/fcarvajaldev/followers","following_url":"https://api.github.com/users/fcarvajaldev/following{/other_user}","gists_url":"https://api.github.com/users/fcarvajaldev/gists{/gist_id}","starred_url":"https://api.github.com/users/fcarvajaldev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcarvajaldev/subscriptions","organizations_url":"https://api.github.com/users/fcarvajaldev/orgs","repos_url":"https://api.github.com/users/fcarvajaldev/repos","events_url":"https://api.github.com/users/fcarvajaldev/events{/privacy}","received_events_url":"https://api.github.com/users/fcarvajaldev/received_events","type":"User","site_admin":false},"repo":{"id":52436085,"name":"nx-libs","full_name":"fcarvajaldev/nx-libs","owner":{"login":"fcarvajaldev","id":17450557,"avatar_url":"https://avatars.githubusercontent.com/u/17450557?v=3","gravatar_id":"","url":"https://api.github.com/users/fcarvajaldev","html_url":"https://github.com/fcarvajaldev","followers_url":"https://api.github.com/users/fcarvajaldev/followers","following_url":"https://api.github.com/users/fcarvajaldev/following{/other_user}","gists_url":"https://api.github.com/users/fcarvajaldev/gists{/gist_id}","starred_url":"https://api.github.com/users/fcarvajaldev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcarvajaldev/subscriptions","organizations_url":"https://api.github.com/users/fcarvajaldev/orgs","repos_url":"https://api.github.com/users/fcarvajaldev/repos","events_url":"https://api.github.com/users/fcarvajaldev/events{/privacy}","received_events_url":"https://api.github.com/users/fcarvajaldev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fcarvajaldev/nx-libs","description":"nx-libs","fork":true,"url":"https://api.github.com/repos/fcarvajaldev/nx-libs","forks_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/forks","keys_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/teams","hooks_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/hooks","issue_events_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/issues/events{/number}","events_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/events","assignees_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/assignees{/user}","branches_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/branches{/branch}","tags_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/tags","blobs_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/statuses/{sha}","languages_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/languages","stargazers_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/stargazers","contributors_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/contributors","subscribers_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/subscribers","subscription_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/subscription","commits_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/contents/{+path}","compare_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/merges","archive_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/downloads","issues_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/issues{/number}","pulls_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/pulls{/number}","milestones_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/milestones{/number}","notifications_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/labels{/name}","releases_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/releases{/id}","deployments_url":"https://api.github.com/repos/fcarvajaldev/nx-libs/deployments","created_at":"2016-02-24T11:05:55Z","updated_at":"2016-02-24T11:06:09Z","pushed_at":"2016-04-25T11:13:07Z","git_url":"git://github.com/fcarvajaldev/nx-libs.git","ssh_url":"git@github.com:fcarvajaldev/nx-libs.git","clone_url":"https://github.com/fcarvajaldev/nx-libs.git","svn_url":"https://github.com/fcarvajaldev/nx-libs","homepage":"","size":26702,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.6.x"}},"base":{"label":"ArcticaProject:3.6.x","ref":"3.6.x","sha":"5729783dbbbaaea835cad2f6621c822c69fe02ea","user":{"login":"ArcticaProject","id":10671181,"avatar_url":"https://avatars.githubusercontent.com/u/10671181?v=3","gravatar_id":"","url":"https://api.github.com/users/ArcticaProject","html_url":"https://github.com/ArcticaProject","followers_url":"https://api.github.com/users/ArcticaProject/followers","following_url":"https://api.github.com/users/ArcticaProject/following{/other_user}","gists_url":"https://api.github.com/users/ArcticaProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ArcticaProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArcticaProject/subscriptions","organizations_url":"https://api.github.com/users/ArcticaProject/orgs","repos_url":"https://api.github.com/users/ArcticaProject/repos","events_url":"https://api.github.com/users/ArcticaProject/events{/privacy}","received_events_url":"https://api.github.com/users/ArcticaProject/received_events","type":"Organization","site_admin":false},"repo":{"id":30066549,"name":"nx-libs","full_name":"ArcticaProject/nx-libs","owner":{"login":"ArcticaProject","id":10671181,"avatar_url":"https://avatars.githubusercontent.com/u/10671181?v=3","gravatar_id":"","url":"https://api.github.com/users/ArcticaProject","html_url":"https://github.com/ArcticaProject","followers_url":"https://api.github.com/users/ArcticaProject/followers","following_url":"https://api.github.com/users/ArcticaProject/following{/other_user}","gists_url":"https://api.github.com/users/ArcticaProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ArcticaProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArcticaProject/subscriptions","organizations_url":"https://api.github.com/users/ArcticaProject/orgs","repos_url":"https://api.github.com/users/ArcticaProject/repos","events_url":"https://api.github.com/users/ArcticaProject/events{/privacy}","received_events_url":"https://api.github.com/users/ArcticaProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArcticaProject/nx-libs","description":"nx-libs","fork":false,"url":"https://api.github.com/repos/ArcticaProject/nx-libs","forks_url":"https://api.github.com/repos/ArcticaProject/nx-libs/forks","keys_url":"https://api.github.com/repos/ArcticaProject/nx-libs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArcticaProject/nx-libs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArcticaProject/nx-libs/teams","hooks_url":"https://api.github.com/repos/ArcticaProject/nx-libs/hooks","issue_events_url":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/events{/number}","events_url":"https://api.github.com/repos/ArcticaProject/nx-libs/events","assignees_url":"https://api.github.com/repos/ArcticaProject/nx-libs/assignees{/user}","branches_url":"https://api.github.com/repos/ArcticaProject/nx-libs/branches{/branch}","tags_url":"https://api.github.com/repos/ArcticaProject/nx-libs/tags","blobs_url":"https://api.github.com/repos/ArcticaProject/nx-libs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArcticaProject/nx-libs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArcticaProject/nx-libs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArcticaProject/nx-libs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArcticaProject/nx-libs/statuses/{sha}","languages_url":"https://api.github.com/repos/ArcticaProject/nx-libs/languages","stargazers_url":"https://api.github.com/repos/ArcticaProject/nx-libs/stargazers","contributors_url":"https://api.github.com/repos/ArcticaProject/nx-libs/contributors","subscribers_url":"https://api.github.com/repos/ArcticaProject/nx-libs/subscribers","subscription_url":"https://api.github.com/repos/ArcticaProject/nx-libs/subscription","commits_url":"https://api.github.com/repos/ArcticaProject/nx-libs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArcticaProject/nx-libs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArcticaProject/nx-libs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArcticaProject/nx-libs/contents/{+path}","compare_url":"https://api.github.com/repos/ArcticaProject/nx-libs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArcticaProject/nx-libs/merges","archive_url":"https://api.github.com/repos/ArcticaProject/nx-libs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArcticaProject/nx-libs/downloads","issues_url":"https://api.github.com/repos/ArcticaProject/nx-libs/issues{/number}","pulls_url":"https://api.github.com/repos/ArcticaProject/nx-libs/pulls{/number}","milestones_url":"https://api.github.com/repos/ArcticaProject/nx-libs/milestones{/number}","notifications_url":"https://api.github.com/repos/ArcticaProject/nx-libs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArcticaProject/nx-libs/labels{/name}","releases_url":"https://api.github.com/repos/ArcticaProject/nx-libs/releases{/id}","deployments_url":"https://api.github.com/repos/ArcticaProject/nx-libs/deployments","created_at":"2015-01-30T10:03:57Z","updated_at":"2016-04-14T13:06:55Z","pushed_at":"2016-04-22T20:09:11Z","git_url":"git://github.com/ArcticaProject/nx-libs.git","ssh_url":"git@github.com:ArcticaProject/nx-libs.git","clone_url":"https://github.com/ArcticaProject/nx-libs.git","svn_url":"https://github.com/ArcticaProject/nx-libs","homepage":"","size":27032,"stargazers_count":18,"watchers_count":18,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":54,"forks":11,"open_issues":54,"watchers":18,"default_branch":"3.6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/ArcticaProject/nx-libs/pulls/119"},"html":{"href":"https://github.com/ArcticaProject/nx-libs/pull/119"},"issue":{"href":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/119"},"comments":{"href":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/ArcticaProject/nx-libs/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/ArcticaProject/nx-libs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArcticaProject/nx-libs/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/ArcticaProject/nx-libs/statuses/baaf58150155db69a5ec95406db7cc45e8f17d42"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":129,"deletions":61,"changed_files":5}}