{"action":"created","comment":{"url":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/comments/61147204","id":61147204,"diff_hunk":"@@ -0,0 +1,70 @@\n+package main\n+","path":"kafka.go","position":2,"original_position":2,"commit_id":"0dd29f895c65ae11c43067dfe4e25f6ff8f1c1d6","original_commit_id":"0dd29f895c65ae11c43067dfe4e25f6ff8f1c1d6","user":{"login":"matlockx","id":936786,"avatar_url":"https://avatars.githubusercontent.com/u/936786?v=3","gravatar_id":"","url":"https://api.github.com/users/matlockx","html_url":"https://github.com/matlockx","followers_url":"https://api.github.com/users/matlockx/followers","following_url":"https://api.github.com/users/matlockx/following{/other_user}","gists_url":"https://api.github.com/users/matlockx/gists{/gist_id}","starred_url":"https://api.github.com/users/matlockx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matlockx/subscriptions","organizations_url":"https://api.github.com/users/matlockx/orgs","repos_url":"https://api.github.com/users/matlockx/repos","events_url":"https://api.github.com/users/matlockx/events{/privacy}","received_events_url":"https://api.github.com/users/matlockx/received_events","type":"User","site_admin":false},"body":"this doe not look so nice to me here. \r\nwe should encapsulate this. i also do not like giving the close chanel to the 'outside'. we should have a struct or an interface","created_at":"2016-04-26T19:17:27Z","updated_at":"2016-04-26T19:17:27Z","html_url":"https://github.com/flachnetz/flatnet-agent/pull/1#discussion_r61147204","pull_request_url":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/comments/61147204"},"html":{"href":"https://github.com/flachnetz/flatnet-agent/pull/1#discussion_r61147204"},"pull_request":{"href":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/1","id":67776576,"html_url":"https://github.com/flachnetz/flatnet-agent/pull/1","diff_url":"https://github.com/flachnetz/flatnet-agent/pull/1.diff","patch_url":"https://github.com/flachnetz/flatnet-agent/pull/1.patch","issue_url":"https://api.github.com/repos/flachnetz/flatnet-agent/issues/1","number":1,"state":"open","locked":false,"title":"Small clenups, remove global variables, split into multiple files, ad…","user":{"login":"oliverbestmann","id":6551584,"avatar_url":"https://avatars.githubusercontent.com/u/6551584?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverbestmann","html_url":"https://github.com/oliverbestmann","followers_url":"https://api.github.com/users/oliverbestmann/followers","following_url":"https://api.github.com/users/oliverbestmann/following{/other_user}","gists_url":"https://api.github.com/users/oliverbestmann/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverbestmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverbestmann/subscriptions","organizations_url":"https://api.github.com/users/oliverbestmann/orgs","repos_url":"https://api.github.com/users/oliverbestmann/repos","events_url":"https://api.github.com/users/oliverbestmann/events{/privacy}","received_events_url":"https://api.github.com/users/oliverbestmann/received_events","type":"User","site_admin":false},"body":"…d NameProvider, add graceful shutdown.","created_at":"2016-04-25T19:44:27Z","updated_at":"2016-04-26T19:17:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a760c8ab7b0240cb560cf7227273526cf5c37fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/1/commits","review_comments_url":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/1/comments","review_comment_url":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flachnetz/flatnet-agent/issues/1/comments","statuses_url":"https://api.github.com/repos/flachnetz/flatnet-agent/statuses/0dd29f895c65ae11c43067dfe4e25f6ff8f1c1d6","head":{"label":"oliverbestmann:master","ref":"master","sha":"0dd29f895c65ae11c43067dfe4e25f6ff8f1c1d6","user":{"login":"oliverbestmann","id":6551584,"avatar_url":"https://avatars.githubusercontent.com/u/6551584?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverbestmann","html_url":"https://github.com/oliverbestmann","followers_url":"https://api.github.com/users/oliverbestmann/followers","following_url":"https://api.github.com/users/oliverbestmann/following{/other_user}","gists_url":"https://api.github.com/users/oliverbestmann/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverbestmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverbestmann/subscriptions","organizations_url":"https://api.github.com/users/oliverbestmann/orgs","repos_url":"https://api.github.com/users/oliverbestmann/repos","events_url":"https://api.github.com/users/oliverbestmann/events{/privacy}","received_events_url":"https://api.github.com/users/oliverbestmann/received_events","type":"User","site_admin":false},"repo":{"id":57070559,"name":"flatnet-agent","full_name":"oliverbestmann/flatnet-agent","owner":{"login":"oliverbestmann","id":6551584,"avatar_url":"https://avatars.githubusercontent.com/u/6551584?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverbestmann","html_url":"https://github.com/oliverbestmann","followers_url":"https://api.github.com/users/oliverbestmann/followers","following_url":"https://api.github.com/users/oliverbestmann/following{/other_user}","gists_url":"https://api.github.com/users/oliverbestmann/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverbestmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverbestmann/subscriptions","organizations_url":"https://api.github.com/users/oliverbestmann/orgs","repos_url":"https://api.github.com/users/oliverbestmann/repos","events_url":"https://api.github.com/users/oliverbestmann/events{/privacy}","received_events_url":"https://api.github.com/users/oliverbestmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oliverbestmann/flatnet-agent","description":"The agent collects network data on every node.","fork":true,"url":"https://api.github.com/repos/oliverbestmann/flatnet-agent","forks_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/forks","keys_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/teams","hooks_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/hooks","issue_events_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/issues/events{/number}","events_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/events","assignees_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/assignees{/user}","branches_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/branches{/branch}","tags_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/tags","blobs_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/languages","stargazers_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/stargazers","contributors_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/contributors","subscribers_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/subscribers","subscription_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/subscription","commits_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/contents/{+path}","compare_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/merges","archive_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/downloads","issues_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/issues{/number}","pulls_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/labels{/name}","releases_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/releases{/id}","deployments_url":"https://api.github.com/repos/oliverbestmann/flatnet-agent/deployments","created_at":"2016-04-25T19:37:55Z","updated_at":"2016-04-25T19:37:56Z","pushed_at":"2016-04-25T19:44:53Z","git_url":"git://github.com/oliverbestmann/flatnet-agent.git","ssh_url":"git@github.com:oliverbestmann/flatnet-agent.git","clone_url":"https://github.com/oliverbestmann/flatnet-agent.git","svn_url":"https://github.com/oliverbestmann/flatnet-agent","homepage":null,"size":4508,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flachnetz:master","ref":"master","sha":"024a4d0414f599081fb092dea5e3cec9bfcef240","user":{"login":"flachnetz","id":18664275,"avatar_url":"https://avatars.githubusercontent.com/u/18664275?v=3","gravatar_id":"","url":"https://api.github.com/users/flachnetz","html_url":"https://github.com/flachnetz","followers_url":"https://api.github.com/users/flachnetz/followers","following_url":"https://api.github.com/users/flachnetz/following{/other_user}","gists_url":"https://api.github.com/users/flachnetz/gists{/gist_id}","starred_url":"https://api.github.com/users/flachnetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flachnetz/subscriptions","organizations_url":"https://api.github.com/users/flachnetz/orgs","repos_url":"https://api.github.com/users/flachnetz/repos","events_url":"https://api.github.com/users/flachnetz/events{/privacy}","received_events_url":"https://api.github.com/users/flachnetz/received_events","type":"Organization","site_admin":false},"repo":{"id":57058469,"name":"flatnet-agent","full_name":"flachnetz/flatnet-agent","owner":{"login":"flachnetz","id":18664275,"avatar_url":"https://avatars.githubusercontent.com/u/18664275?v=3","gravatar_id":"","url":"https://api.github.com/users/flachnetz","html_url":"https://github.com/flachnetz","followers_url":"https://api.github.com/users/flachnetz/followers","following_url":"https://api.github.com/users/flachnetz/following{/other_user}","gists_url":"https://api.github.com/users/flachnetz/gists{/gist_id}","starred_url":"https://api.github.com/users/flachnetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flachnetz/subscriptions","organizations_url":"https://api.github.com/users/flachnetz/orgs","repos_url":"https://api.github.com/users/flachnetz/repos","events_url":"https://api.github.com/users/flachnetz/events{/privacy}","received_events_url":"https://api.github.com/users/flachnetz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flachnetz/flatnet-agent","description":"The agent collects network data on every node.","fork":false,"url":"https://api.github.com/repos/flachnetz/flatnet-agent","forks_url":"https://api.github.com/repos/flachnetz/flatnet-agent/forks","keys_url":"https://api.github.com/repos/flachnetz/flatnet-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flachnetz/flatnet-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flachnetz/flatnet-agent/teams","hooks_url":"https://api.github.com/repos/flachnetz/flatnet-agent/hooks","issue_events_url":"https://api.github.com/repos/flachnetz/flatnet-agent/issues/events{/number}","events_url":"https://api.github.com/repos/flachnetz/flatnet-agent/events","assignees_url":"https://api.github.com/repos/flachnetz/flatnet-agent/assignees{/user}","branches_url":"https://api.github.com/repos/flachnetz/flatnet-agent/branches{/branch}","tags_url":"https://api.github.com/repos/flachnetz/flatnet-agent/tags","blobs_url":"https://api.github.com/repos/flachnetz/flatnet-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flachnetz/flatnet-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flachnetz/flatnet-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/flachnetz/flatnet-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flachnetz/flatnet-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/flachnetz/flatnet-agent/languages","stargazers_url":"https://api.github.com/repos/flachnetz/flatnet-agent/stargazers","contributors_url":"https://api.github.com/repos/flachnetz/flatnet-agent/contributors","subscribers_url":"https://api.github.com/repos/flachnetz/flatnet-agent/subscribers","subscription_url":"https://api.github.com/repos/flachnetz/flatnet-agent/subscription","commits_url":"https://api.github.com/repos/flachnetz/flatnet-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/flachnetz/flatnet-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/flachnetz/flatnet-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/flachnetz/flatnet-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/flachnetz/flatnet-agent/contents/{+path}","compare_url":"https://api.github.com/repos/flachnetz/flatnet-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flachnetz/flatnet-agent/merges","archive_url":"https://api.github.com/repos/flachnetz/flatnet-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flachnetz/flatnet-agent/downloads","issues_url":"https://api.github.com/repos/flachnetz/flatnet-agent/issues{/number}","pulls_url":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/flachnetz/flatnet-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/flachnetz/flatnet-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flachnetz/flatnet-agent/labels{/name}","releases_url":"https://api.github.com/repos/flachnetz/flatnet-agent/releases{/id}","deployments_url":"https://api.github.com/repos/flachnetz/flatnet-agent/deployments","created_at":"2016-04-25T16:36:52Z","updated_at":"2016-04-25T16:49:59Z","pushed_at":"2016-04-25T19:44:54Z","git_url":"git://github.com/flachnetz/flatnet-agent.git","ssh_url":"git@github.com:flachnetz/flatnet-agent.git","clone_url":"https://github.com/flachnetz/flatnet-agent.git","svn_url":"https://github.com/flachnetz/flatnet-agent","homepage":null,"size":4502,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/1"},"html":{"href":"https://github.com/flachnetz/flatnet-agent/pull/1"},"issue":{"href":"https://api.github.com/repos/flachnetz/flatnet-agent/issues/1"},"comments":{"href":"https://api.github.com/repos/flachnetz/flatnet-agent/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flachnetz/flatnet-agent/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/flachnetz/flatnet-agent/statuses/0dd29f895c65ae11c43067dfe4e25f6ff8f1c1d6"}}}}