{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37254","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37254/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37254/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37254/events","html_url":"https://github.com/kubernetes/kubernetes/issues/37254","id":190878867,"number":37254,"title":"version or vendor golint for verification checks?","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"labels":[{"id":105152717,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/test","name":"area/test","color":"fad8c7","default":false},{"id":483069764,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":178071252,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/test-infra","name":"team/test-infra","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-11-22T00:52:57Z","updated_at":"2016-11-30T18:52:21Z","closed_at":null,"body":"In our test-infra we [`go get github.com/golang/lint/golint`](https://github.com/kubernetes/test-infra/blob/master/jenkins/test-image/Dockerfile-1.4#L53-L54) in the kubekins-test image to use in the various \\*-verify-\\* jobs.\r\n\r\nRecently, we updated the `kubekins-test` image, which ended up pulling in a newer version of `golint` with [a new check](https://github.com/golang/lint/commit/3390df4df2787994aea98de825b964ac7944b817). And now the verify-1.4 jobs [are failing](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-verify-release-1.4/467/) due to this new check:\r\n```\r\nI1121 16:07:11.555] Verifying hack/make-rules/../../hack/verify-golint.sh\r\nW1121 16:07:32.929] Errors from golint:\r\nW1121 16:07:32.929] pkg/storage/etcd3/store_test.go:548:1: context.Context should be the first parameter of a function\r\nW1121 16:07:32.929] \r\nW1121 16:07:32.929] Please fix the above errors. You can test via \"golint\" and commit the result.\r\nW1121 16:07:32.930] \r\nI1121 16:07:32.933] FAILED   hack/make-rules/../../hack/verify-golint.sh\t21s\r\n```\r\n\r\nWhile 1.4 is still fairly recent, we could imagine older release branches breaking similarly, and I'm not sure we want to fix lint failures in old releases.\r\n\r\nShould we figure out some way to version/vendor golint for these checks?\r\n\r\ncc @kubernetes/test-infra-maintainers @kubernetes/sig-testing "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/263960271","html_url":"https://github.com/kubernetes/kubernetes/issues/37254#issuecomment-263960271","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37254","id":263960271,"user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T18:52:21Z","updated_at":"2016-11-30T18:52:21Z","body":"So this means that if I have a newer version of golint locally that adds new rules, my code my fail the golint check locally but pass in CI. I think we need to pin the golint version in hack/verify-golint.sh."}}
{"actor":{"display_login":"ncdc"}}