{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/52892684","id":52892684,"diff_hunk":"@@ -404,12 +410,16 @@ def populate_updated_fields(config, columns, row, datemode):\n \n         if update_value is not None:\n             if field_map[key]['type_field'] == 'date':\n-                update_value = parse_excel_date(update_value, datemode)\n-            elif field_map[key]['type_field'] == 'integer':\n                 try:\n-                    update_value = str(int(update_value))\n-                except ValueError:\n-                    update_value = ''\n+                    update_value = parse_excel_date(update_value, datemode)\n+                except InvalidDateException:","path":"corehq/apps/importer/util.py","position":85,"original_position":85,"commit_id":"fb57790dbefaad9eb68df1477f59a581e2ca9625","original_commit_id":"fb57790dbefaad9eb68df1477f59a581e2ca9625","user":{"login":"proteusvacuum","id":146896,"avatar_url":"https://avatars.githubusercontent.com/u/146896?v=3","gravatar_id":"","url":"https://api.github.com/users/proteusvacuum","html_url":"https://github.com/proteusvacuum","followers_url":"https://api.github.com/users/proteusvacuum/followers","following_url":"https://api.github.com/users/proteusvacuum/following{/other_user}","gists_url":"https://api.github.com/users/proteusvacuum/gists{/gist_id}","starred_url":"https://api.github.com/users/proteusvacuum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proteusvacuum/subscriptions","organizations_url":"https://api.github.com/users/proteusvacuum/orgs","repos_url":"https://api.github.com/users/proteusvacuum/repos","events_url":"https://api.github.com/users/proteusvacuum/events{/privacy}","received_events_url":"https://api.github.com/users/proteusvacuum/received_events","type":"User","site_admin":false},"body":"Is this sketchy? I think the other way is to not catch the error in `parse_excel_date` and just catch it here.","created_at":"2016-02-15T12:23:47Z","updated_at":"2016-02-15T12:23:47Z","html_url":"https://github.com/dimagi/commcare-hq/pull/10300#discussion_r52892684","pull_request_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/10300","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/52892684"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/10300#discussion_r52892684"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/10300"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/10300","id":59356942,"html_url":"https://github.com/dimagi/commcare-hq/pull/10300","diff_url":"https://github.com/dimagi/commcare-hq/pull/10300.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/10300.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/10300","number":10300,"state":"open","locked":false,"title":"Case import errors","user":{"login":"proteusvacuum","id":146896,"avatar_url":"https://avatars.githubusercontent.com/u/146896?v=3","gravatar_id":"","url":"https://api.github.com/users/proteusvacuum","html_url":"https://github.com/proteusvacuum","followers_url":"https://api.github.com/users/proteusvacuum/followers","following_url":"https://api.github.com/users/proteusvacuum/following{/other_user}","gists_url":"https://api.github.com/users/proteusvacuum/gists{/gist_id}","starred_url":"https://api.github.com/users/proteusvacuum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proteusvacuum/subscriptions","organizations_url":"https://api.github.com/users/proteusvacuum/orgs","repos_url":"https://api.github.com/users/proteusvacuum/repos","events_url":"https://api.github.com/users/proteusvacuum/events{/privacy}","received_events_url":"https://api.github.com/users/proteusvacuum/received_events","type":"User","site_admin":false},"body":"@orangejenny \r\nThis is my hackathon contribution...\r\n\r\nCase import errors are very cryptic, as they just tell you which row a specific error comes from, not which column. If you have, for e.g. many date columns, you have to scan each column to figure out which one is the bad egg. \r\n\r\nThis changes the error message for `Date` and `Integer` to show which column is the bad one.\r\n\r\nOther types should be potentially trivial to add...","created_at":"2016-02-15T12:22:48Z","updated_at":"2016-02-15T12:23:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0e9167db97ce1951d6ef4e1bcc1c36a581a1424","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/10300/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/10300/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/10300/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/fb57790dbefaad9eb68df1477f59a581e2ca9625","head":{"label":"dimagi:case-import-errors","ref":"case-import-errors","sha":"fb57790dbefaad9eb68df1477f59a581e2ca9625","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"name":"commcare-hq","full_name":"dimagi/commcare-hq","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2016-01-25T13:36:18Z","pushed_at":"2016-02-15T12:22:48Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"http://www.commcarehq.org","size":251761,"stargazers_count":61,"watchers_count":61,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":66,"mirror_url":null,"open_issues_count":54,"forks":66,"open_issues":54,"watchers":61,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"452b8de22efec41a9cc75e9082982e492d0691a3","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"name":"commcare-hq","full_name":"dimagi/commcare-hq","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2016-01-25T13:36:18Z","pushed_at":"2016-02-15T12:22:48Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"http://www.commcarehq.org","size":251761,"stargazers_count":61,"watchers_count":61,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":66,"mirror_url":null,"open_issues_count":54,"forks":66,"open_issues":54,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/10300"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/10300"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/10300"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/10300/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/10300/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/10300/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-hq/statuses/fb57790dbefaad9eb68df1477f59a581e2ca9625"}}}}