{"action":"created","issue":{"url":"https://api.github.com/repos/openfisca/openfisca-web-api/issues/67","repository_url":"https://api.github.com/repos/openfisca/openfisca-web-api","labels_url":"https://api.github.com/repos/openfisca/openfisca-web-api/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/openfisca/openfisca-web-api/issues/67/comments","events_url":"https://api.github.com/repos/openfisca/openfisca-web-api/issues/67/events","html_url":"https://github.com/openfisca/openfisca-web-api/pull/67","id":173157602,"number":67,"title":"Fix venv wrong path","user":{"login":"cbenz","id":12686,"avatar_url":"https://avatars.githubusercontent.com/u/12686?v=3","gravatar_id":"","url":"https://api.github.com/users/cbenz","html_url":"https://github.com/cbenz","followers_url":"https://api.github.com/users/cbenz/followers","following_url":"https://api.github.com/users/cbenz/following{/other_user}","gists_url":"https://api.github.com/users/cbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/cbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbenz/subscriptions","organizations_url":"https://api.github.com/users/cbenz/orgs","repos_url":"https://api.github.com/users/cbenz/repos","events_url":"https://api.github.com/users/cbenz/events{/privacy}","received_events_url":"https://api.github.com/users/cbenz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"cbenz","id":12686,"avatar_url":"https://avatars.githubusercontent.com/u/12686?v=3","gravatar_id":"","url":"https://api.github.com/users/cbenz","html_url":"https://github.com/cbenz","followers_url":"https://api.github.com/users/cbenz/followers","following_url":"https://api.github.com/users/cbenz/following{/other_user}","gists_url":"https://api.github.com/users/cbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/cbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbenz/subscriptions","organizations_url":"https://api.github.com/users/cbenz/orgs","repos_url":"https://api.github.com/users/cbenz/repos","events_url":"https://api.github.com/users/cbenz/events{/privacy}","received_events_url":"https://api.github.com/users/cbenz/received_events","type":"User","site_admin":false},"assignees":[{"login":"cbenz","id":12686,"avatar_url":"https://avatars.githubusercontent.com/u/12686?v=3","gravatar_id":"","url":"https://api.github.com/users/cbenz","html_url":"https://github.com/cbenz","followers_url":"https://api.github.com/users/cbenz/followers","following_url":"https://api.github.com/users/cbenz/following{/other_user}","gists_url":"https://api.github.com/users/cbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/cbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbenz/subscriptions","organizations_url":"https://api.github.com/users/cbenz/orgs","repos_url":"https://api.github.com/users/cbenz/repos","events_url":"https://api.github.com/users/cbenz/events{/privacy}","received_events_url":"https://api.github.com/users/cbenz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-08-25T09:39:34Z","updated_at":"2016-08-25T15:59:48Z","closed_at":"2016-08-25T15:23:23Z","pull_request":{"url":"https://api.github.com/repos/openfisca/openfisca-web-api/pulls/67","html_url":"https://github.com/openfisca/openfisca-web-api/pull/67","diff_url":"https://github.com/openfisca/openfisca-web-api/pull/67.diff","patch_url":"https://github.com/openfisca/openfisca-web-api/pull/67.patch"},"body":"In some cases in `/variables` endpoint, `source_file_path` of each variable was wrong if application was deployed in a virtualenv. This fix uses `importlib` to get the path of the country package instead of `pkg_resources`.\r\n"},"comment":{"url":"https://api.github.com/repos/openfisca/openfisca-web-api/issues/comments/242441559","html_url":"https://github.com/openfisca/openfisca-web-api/pull/67#issuecomment-242441559","issue_url":"https://api.github.com/repos/openfisca/openfisca-web-api/issues/67","id":242441559,"user":{"login":"MattiSG","id":222463,"avatar_url":"https://avatars.githubusercontent.com/u/222463?v=3","gravatar_id":"","url":"https://api.github.com/users/MattiSG","html_url":"https://github.com/MattiSG","followers_url":"https://api.github.com/users/MattiSG/followers","following_url":"https://api.github.com/users/MattiSG/following{/other_user}","gists_url":"https://api.github.com/users/MattiSG/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiSG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiSG/subscriptions","organizations_url":"https://api.github.com/users/MattiSG/orgs","repos_url":"https://api.github.com/users/MattiSG/repos","events_url":"https://api.github.com/users/MattiSG/events{/privacy}","received_events_url":"https://api.github.com/users/MattiSG/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T15:59:48Z","updated_at":"2016-08-25T15:59:48Z","body":"> a call-to-review sent to the team, but […] reviewer to add it when actually starting the review.\r\n\r\n🤔\r\nI find this slightly ambiguous: as a possible reviewer, when seeing this label, am I supposed to review or is someone already doing it?\r\n\r\nWe do it with assignments: when an implementor has finished work, s·he unassigns herself.\r\nIf a PR is open with no assignee, then it is waiting for review.\r\nOnce a reviewer starts work, s·he assigns herself.\r\nOnce review is done, reviewer unassigns herself and reassigns the original implementor.\r\nThe original implementor can then work, and this cycles until a GTM is obtained, at which point the original implementor is expected to merge her work.\r\n\r\nNo need for a label to request reviews since everything is expected to be reviewed, no need for a label that says a review is in progress because for efficiency reviews should not be parallel."}}
{"actor":{"display_login":"MattiSG"}}