{"action":"created","comment":{"url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/comments/59570338","id":59570338,"diff_hunk":"@@ -30,4 +30,9 @@ dependencies {\n     compile project(':library')\n     compile 'com.android.support:appcompat-v7:23.1.0'\n     compile 'com.android.support:design:23.1.0'\n+\n+    testCompile 'junit:junit:4.12'\n+    testCompile 'org.mockito:mockito-core:1.10.19'\n+    testCompile 'org.easytesting:fest-assert-core:2.0M10'\n+    testCompile 'org.robolectric:robolectric:2.4'","path":"demo-extended/build.gradle","position":8,"original_position":8,"commit_id":"eae6245a2b0f8c44a03b807594cc948e3d5ff55e","original_commit_id":"eae6245a2b0f8c44a03b807594cc948e3d5ff55e","user":{"login":"alexstyl","id":1665273,"avatar_url":"https://avatars.githubusercontent.com/u/1665273?v=3","gravatar_id":"","url":"https://api.github.com/users/alexstyl","html_url":"https://github.com/alexstyl","followers_url":"https://api.github.com/users/alexstyl/followers","following_url":"https://api.github.com/users/alexstyl/following{/other_user}","gists_url":"https://api.github.com/users/alexstyl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexstyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexstyl/subscriptions","organizations_url":"https://api.github.com/users/alexstyl/orgs","repos_url":"https://api.github.com/users/alexstyl/repos","events_url":"https://api.github.com/users/alexstyl/events{/privacy}","received_events_url":"https://api.github.com/users/alexstyl/received_events","type":"User","site_admin":false},"body":"We used Robolectric in `UrlFinderTest` and `UrlSpanFactoryTest` otherwise the test would fail since their had no idea about the Android components such as `UrlSpan`s or `Patterns`.","created_at":"2016-04-13T15:32:42Z","updated_at":"2016-04-13T15:32:42Z","html_url":"https://github.com/novoda/simple-chrome-custom-tabs/pull/21#discussion_r59570338","pull_request_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/comments/59570338"},"html":{"href":"https://github.com/novoda/simple-chrome-custom-tabs/pull/21#discussion_r59570338"},"pull_request":{"href":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/21","id":66302788,"html_url":"https://github.com/novoda/simple-chrome-custom-tabs/pull/21","diff_url":"https://github.com/novoda/simple-chrome-custom-tabs/pull/21.diff","patch_url":"https://github.com/novoda/simple-chrome-custom-tabs/pull/21.patch","issue_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/issues/21","number":21,"state":"open","locked":false,"title":"Example of how to use Linkify with SimpleChromeCustomTabs","user":{"login":"alexstyl","id":1665273,"avatar_url":"https://avatars.githubusercontent.com/u/1665273?v=3","gravatar_id":"","url":"https://api.github.com/users/alexstyl","html_url":"https://github.com/alexstyl","followers_url":"https://api.github.com/users/alexstyl/followers","following_url":"https://api.github.com/users/alexstyl/following{/other_user}","gists_url":"https://api.github.com/users/alexstyl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexstyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexstyl/subscriptions","organizations_url":"https://api.github.com/users/alexstyl/orgs","repos_url":"https://api.github.com/users/alexstyl/repos","events_url":"https://api.github.com/users/alexstyl/events{/privacy}","received_events_url":"https://api.github.com/users/alexstyl/received_events","type":"User","site_admin":false},"body":"### Task Requested ###\r\nThere was a request to include an example of how to use `Linkify` with the use of the library (See https://github.com/novoda/simple-chrome-custom-tabs/issues/15). This PR includes such an example.\r\n\r\n### Solution implemented ###\r\nAndroid's Linkify does not allows the user to set their own behavior when a link has been pressed. For that reason, we created our own version of the class, `WebLinkify` which linkifies all Web links from a passed `TextView` and triggering a custom click listener when a link has been pressed. \r\n\r\n**no Test added**\r\nWe considered working on this TDD-style, but at first sight we thought that it was really tied up to Android components. \r\n\r\nScreenshots\r\n![linkify_center](https://cloud.githubusercontent.com/assets/1665273/14491102/ccf5c11a-016e-11e6-9c80-e1107854c9b3.gif)\r\n\r\n\r\nPaired with the one and only @joetimmins ","created_at":"2016-04-13T11:05:20Z","updated_at":"2016-04-13T15:32:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdc0b551d37ad0c5bd6150829af5699a6c0585ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/21/commits","review_comments_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/21/comments","review_comment_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/issues/21/comments","statuses_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/statuses/eae6245a2b0f8c44a03b807594cc948e3d5ff55e","head":{"label":"novoda:linkify","ref":"linkify","sha":"eae6245a2b0f8c44a03b807594cc948e3d5ff55e","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":46065249,"name":"simple-chrome-custom-tabs","full_name":"novoda/simple-chrome-custom-tabs","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/simple-chrome-custom-tabs","description":"","fork":false,"url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs","forks_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/forks","keys_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/teams","hooks_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/hooks","issue_events_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/events","assignees_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/tags","blobs_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/languages","stargazers_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/stargazers","contributors_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/contributors","subscribers_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/subscribers","subscription_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/subscription","commits_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/merges","archive_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/downloads","issues_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/labels{/name}","releases_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/deployments","created_at":"2015-11-12T16:23:45Z","updated_at":"2016-04-11T14:31:27Z","pushed_at":"2016-04-13T15:12:40Z","git_url":"git://github.com/novoda/simple-chrome-custom-tabs.git","ssh_url":"git@github.com:novoda/simple-chrome-custom-tabs.git","clone_url":"https://github.com/novoda/simple-chrome-custom-tabs.git","svn_url":"https://github.com/novoda/simple-chrome-custom-tabs","homepage":null,"size":9290,"stargazers_count":52,"watchers_count":52,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":52,"default_branch":"master"}},"base":{"label":"novoda:master","ref":"master","sha":"afdb0c1c350b821a37f6f49677d987741533773e","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":46065249,"name":"simple-chrome-custom-tabs","full_name":"novoda/simple-chrome-custom-tabs","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/simple-chrome-custom-tabs","description":"","fork":false,"url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs","forks_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/forks","keys_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/teams","hooks_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/hooks","issue_events_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/events","assignees_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/tags","blobs_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/languages","stargazers_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/stargazers","contributors_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/contributors","subscribers_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/subscribers","subscription_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/subscription","commits_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/merges","archive_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/downloads","issues_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/labels{/name}","releases_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/deployments","created_at":"2015-11-12T16:23:45Z","updated_at":"2016-04-11T14:31:27Z","pushed_at":"2016-04-13T15:12:40Z","git_url":"git://github.com/novoda/simple-chrome-custom-tabs.git","ssh_url":"git@github.com:novoda/simple-chrome-custom-tabs.git","clone_url":"https://github.com/novoda/simple-chrome-custom-tabs.git","svn_url":"https://github.com/novoda/simple-chrome-custom-tabs","homepage":null,"size":9290,"stargazers_count":52,"watchers_count":52,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/21"},"html":{"href":"https://github.com/novoda/simple-chrome-custom-tabs/pull/21"},"issue":{"href":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/issues/21"},"comments":{"href":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/simple-chrome-custom-tabs/statuses/eae6245a2b0f8c44a03b807594cc948e3d5ff55e"}}}}