{"action":"created","comment":{"url":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments/59713810","id":59713810,"diff_hunk":"@@ -15,14 +57,12 @@ def collect(self):\n         test_dir = os.path.dirname(str(self.fspath))\n         for platform, archs in spec[\"Output Files\"].items():\n             for arch, filename in archs.items():\n-                filepath = os.path.join(test_dir, filename)\n-                if os.path.exists(filepath):\n-                    yield FLOSSTest(self, platform, arch, filename, spec)\n-\n-\n-def extract_strings(sample_path):\n-    # TODO: implement me\n-    return []\n+                # TODO only test Windows PE files for now\n+                _, fileext = os.path.splitext(filename)\n+                if fileext == \".exe\":","path":"tests/conftest.py","position":63,"original_position":63,"commit_id":"456d0ff413623cb1bffc44d1d5caaad4cc9f0c46","original_commit_id":"456d0ff413623cb1bffc44d1d5caaad4cc9f0c46","user":{"login":"williballenthin","id":156560,"avatar_url":"https://avatars.githubusercontent.com/u/156560?v=3","gravatar_id":"","url":"https://api.github.com/users/williballenthin","html_url":"https://github.com/williballenthin","followers_url":"https://api.github.com/users/williballenthin/followers","following_url":"https://api.github.com/users/williballenthin/following{/other_user}","gists_url":"https://api.github.com/users/williballenthin/gists{/gist_id}","starred_url":"https://api.github.com/users/williballenthin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williballenthin/subscriptions","organizations_url":"https://api.github.com/users/williballenthin/orgs","repos_url":"https://api.github.com/users/williballenthin/repos","events_url":"https://api.github.com/users/williballenthin/events{/privacy}","received_events_url":"https://api.github.com/users/williballenthin/received_events","type":"User","site_admin":false},"body":"also, i think these are items that should be marked `xfail` see #76, rather than ignored. this indicates we'd like to support the functionality, but that it not expected to work yet.","created_at":"2016-04-14T13:13:43Z","updated_at":"2016-04-14T13:13:43Z","html_url":"https://github.com/fireeye/flare-floss/pull/86#discussion_r59713810","pull_request_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments/59713810"},"html":{"href":"https://github.com/fireeye/flare-floss/pull/86#discussion_r59713810"},"pull_request":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/fireeye/flare-floss/pulls/86","id":66428253,"html_url":"https://github.com/fireeye/flare-floss/pull/86","diff_url":"https://github.com/fireeye/flare-floss/pull/86.diff","patch_url":"https://github.com/fireeye/flare-floss/pull/86.patch","issue_url":"https://api.github.com/repos/fireeye/flare-floss/issues/86","number":86,"state":"open","locked":false,"title":"Testing architecture gap filling","user":{"login":"mr-tz","id":17606537,"avatar_url":"https://avatars.githubusercontent.com/u/17606537?v=3","gravatar_id":"","url":"https://api.github.com/users/mr-tz","html_url":"https://github.com/mr-tz","followers_url":"https://api.github.com/users/mr-tz/followers","following_url":"https://api.github.com/users/mr-tz/following{/other_user}","gists_url":"https://api.github.com/users/mr-tz/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-tz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-tz/subscriptions","organizations_url":"https://api.github.com/users/mr-tz/orgs","repos_url":"https://api.github.com/users/mr-tz/repos","events_url":"https://api.github.com/users/mr-tz/events{/privacy}","received_events_url":"https://api.github.com/users/mr-tz/received_events","type":"User","site_admin":false},"body":"Addresses the outstanding work from #69.\r\n1. fix for decoded strings in decode-split-stackstrings test.yml\r\n2. added script that appends the test data (decoded strings) from a test.yml file to a binary\r\n3. run FLOSS and assert that deobfuscated strings have been found via conftest.py\r\n\r\nCurrent limitations:\r\n- Need to invoke tests from FLOSS main directory\r\n- Only analyze Windows PE files (as FLOSS can't analyze ELF files currently, anyway)\r\n- Might want to add decoding function offsets in test.yml file, although this might be infeasible due to chaning offsets, currently don't extract it from appended test data either\r\n- Currently, gets expected strings from test.yml files instead of appended data\r\n\r\nExample run output:\r\n```\r\ntests/src/decode-base64/test.yml::test-decode-base64::Windows::32bit PASSED\r\ntests/src/decode-base64/test.yml::test-decode-base64::Windows::64bit FAILED\r\ntests/src/decode-from-global/test.yml::test-decode-from-global::Windows::32bit PASSED\r\ntests/src/decode-from-global/test.yml::test-decode-from-global::Windows::64bit PASSED\r\ntests/src/decode-from-heap/test.yml::test-decode-from-heap::Windows::32bit FAILED\r\ntests/src/decode-from-heap/test.yml::test-decode-from-heap::Windows::64bit FAILED\r\ntests/src/decode-from-stack/test.yml::test-decode-from-stack::Windows::32bit PASSED\r\ntests/src/decode-from-stack/test.yml::test-decode-from-stack::Windows::64bit PASSED\r\ntests/src/decode-global-stackstrings/test.yml::test-decode-global-stackstrings::Windows::32bit FAILED\r\ntests/src/decode-global-stackstrings/test.yml::test-decode-global-stackstrings::Windows::64bit FAILED\r\ntests/src/decode-in-place/test.yml::test-decode-in-place::Windows::32bit PASSED\r\ntests/src/decode-in-place/test.yml::test-decode-in-place::Windows::64bit PASSED\r\ntests/src/decode-local-stackstrings/test.yml::test-decode-local-stackstrings::Windows::32bit PASSED\r\ntests/src/decode-local-stackstrings/test.yml::test-decode-local-stackstrings::Windows::64bit PASSED\r\ntests/src/decode-rc4/test.yml::test-decode-rc4::Windows::32bit FAILED\r\ntests/src/decode-rc4/test.yml::test-decode-rc4::Windows::64bit FAILED\r\ntests/src/decode-single-byte-xor/test.yml::test-decode-single-byte-xor::Windows::32bit PASSED\r\ntests/src/decode-single-byte-xor/test.yml::test-decode-single-byte-xor::Windows::64bit PASSED\r\ntests/src/decode-split-stackstrings/test.yml::test-decode-split-stackstrings::Windows::32bit PASSED\r\ntests/src/decode-split-stackstrings/test.yml::test-decode-split-stackstrings::Windows::64bit PASSED\r\ntests/src/decode-string-with-header/test.yml::test-decode-string-with-header::Windows::32bit FAILED\r\ntests/src/decode-string-with-header/test.yml::test-decode-string-with-header::Windows::64bit FAILED\r\ntests/src/decode-to-global/test.yml::test-decode-to-global::Windows::32bit PASSED\r\ntests/src/decode-to-global/test.yml::test-decode-to-global::Windows::64bit PASSED\r\ntests/src/decode-to-heap/test.yml::test-decode-to-heap::Windows::32bit PASSED\r\ntests/src/decode-to-heap/test.yml::test-decode-to-heap::Windows::64bit PASSED\r\ntests/src/decode-to-output-buf/test.yml::test-decode-to-output-buf::Windows::32bit PASSED\r\ntests/src/decode-to-output-buf/test.yml::test-decode-to-output-buf::Windows::64bit PASSED\r\ntests/src/decode-to-stack/test.yml::test-decode-to-stack::Windows::32bit PASSED\r\ntests/src/decode-to-stack/test.yml::test-decode-to-stack::Windows::64bit PASSED\r\n```","created_at":"2016-04-14T04:40:06Z","updated_at":"2016-04-14T13:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7708b5462cc46a7201f97fe2a129a51f65f2f1d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/86/commits","review_comments_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/86/comments","review_comment_url":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fireeye/flare-floss/issues/86/comments","statuses_url":"https://api.github.com/repos/fireeye/flare-floss/statuses/456d0ff413623cb1bffc44d1d5caaad4cc9f0c46","head":{"label":"fireeye:tests/testing-arch-cont","ref":"tests/testing-arch-cont","sha":"456d0ff413623cb1bffc44d1d5caaad4cc9f0c46","user":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"repo":{"id":52993349,"name":"flare-floss","full_name":"fireeye/flare-floss","owner":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fireeye/flare-floss","description":"","fork":false,"url":"https://api.github.com/repos/fireeye/flare-floss","forks_url":"https://api.github.com/repos/fireeye/flare-floss/forks","keys_url":"https://api.github.com/repos/fireeye/flare-floss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fireeye/flare-floss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fireeye/flare-floss/teams","hooks_url":"https://api.github.com/repos/fireeye/flare-floss/hooks","issue_events_url":"https://api.github.com/repos/fireeye/flare-floss/issues/events{/number}","events_url":"https://api.github.com/repos/fireeye/flare-floss/events","assignees_url":"https://api.github.com/repos/fireeye/flare-floss/assignees{/user}","branches_url":"https://api.github.com/repos/fireeye/flare-floss/branches{/branch}","tags_url":"https://api.github.com/repos/fireeye/flare-floss/tags","blobs_url":"https://api.github.com/repos/fireeye/flare-floss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fireeye/flare-floss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fireeye/flare-floss/git/refs{/sha}","trees_url":"https://api.github.com/repos/fireeye/flare-floss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fireeye/flare-floss/statuses/{sha}","languages_url":"https://api.github.com/repos/fireeye/flare-floss/languages","stargazers_url":"https://api.github.com/repos/fireeye/flare-floss/stargazers","contributors_url":"https://api.github.com/repos/fireeye/flare-floss/contributors","subscribers_url":"https://api.github.com/repos/fireeye/flare-floss/subscribers","subscription_url":"https://api.github.com/repos/fireeye/flare-floss/subscription","commits_url":"https://api.github.com/repos/fireeye/flare-floss/commits{/sha}","git_commits_url":"https://api.github.com/repos/fireeye/flare-floss/git/commits{/sha}","comments_url":"https://api.github.com/repos/fireeye/flare-floss/comments{/number}","issue_comment_url":"https://api.github.com/repos/fireeye/flare-floss/issues/comments{/number}","contents_url":"https://api.github.com/repos/fireeye/flare-floss/contents/{+path}","compare_url":"https://api.github.com/repos/fireeye/flare-floss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fireeye/flare-floss/merges","archive_url":"https://api.github.com/repos/fireeye/flare-floss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fireeye/flare-floss/downloads","issues_url":"https://api.github.com/repos/fireeye/flare-floss/issues{/number}","pulls_url":"https://api.github.com/repos/fireeye/flare-floss/pulls{/number}","milestones_url":"https://api.github.com/repos/fireeye/flare-floss/milestones{/number}","notifications_url":"https://api.github.com/repos/fireeye/flare-floss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fireeye/flare-floss/labels{/name}","releases_url":"https://api.github.com/repos/fireeye/flare-floss/releases{/id}","deployments_url":"https://api.github.com/repos/fireeye/flare-floss/deployments","created_at":"2016-03-02T20:16:10Z","updated_at":"2016-04-12T11:13:16Z","pushed_at":"2016-04-14T12:59:23Z","git_url":"git://github.com/fireeye/flare-floss.git","ssh_url":"git@github.com:fireeye/flare-floss.git","clone_url":"https://github.com/fireeye/flare-floss.git","svn_url":"https://github.com/fireeye/flare-floss","homepage":null,"size":203,"stargazers_count":61,"watchers_count":61,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":13,"forks":13,"open_issues":13,"watchers":61,"default_branch":"master"}},"base":{"label":"fireeye:master","ref":"master","sha":"b4fed4e067919a1646e91a170238ed4a6baf2c8e","user":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"repo":{"id":52993349,"name":"flare-floss","full_name":"fireeye/flare-floss","owner":{"login":"fireeye","id":4984788,"avatar_url":"https://avatars.githubusercontent.com/u/4984788?v=3","gravatar_id":"","url":"https://api.github.com/users/fireeye","html_url":"https://github.com/fireeye","followers_url":"https://api.github.com/users/fireeye/followers","following_url":"https://api.github.com/users/fireeye/following{/other_user}","gists_url":"https://api.github.com/users/fireeye/gists{/gist_id}","starred_url":"https://api.github.com/users/fireeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireeye/subscriptions","organizations_url":"https://api.github.com/users/fireeye/orgs","repos_url":"https://api.github.com/users/fireeye/repos","events_url":"https://api.github.com/users/fireeye/events{/privacy}","received_events_url":"https://api.github.com/users/fireeye/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fireeye/flare-floss","description":"","fork":false,"url":"https://api.github.com/repos/fireeye/flare-floss","forks_url":"https://api.github.com/repos/fireeye/flare-floss/forks","keys_url":"https://api.github.com/repos/fireeye/flare-floss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fireeye/flare-floss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fireeye/flare-floss/teams","hooks_url":"https://api.github.com/repos/fireeye/flare-floss/hooks","issue_events_url":"https://api.github.com/repos/fireeye/flare-floss/issues/events{/number}","events_url":"https://api.github.com/repos/fireeye/flare-floss/events","assignees_url":"https://api.github.com/repos/fireeye/flare-floss/assignees{/user}","branches_url":"https://api.github.com/repos/fireeye/flare-floss/branches{/branch}","tags_url":"https://api.github.com/repos/fireeye/flare-floss/tags","blobs_url":"https://api.github.com/repos/fireeye/flare-floss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fireeye/flare-floss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fireeye/flare-floss/git/refs{/sha}","trees_url":"https://api.github.com/repos/fireeye/flare-floss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fireeye/flare-floss/statuses/{sha}","languages_url":"https://api.github.com/repos/fireeye/flare-floss/languages","stargazers_url":"https://api.github.com/repos/fireeye/flare-floss/stargazers","contributors_url":"https://api.github.com/repos/fireeye/flare-floss/contributors","subscribers_url":"https://api.github.com/repos/fireeye/flare-floss/subscribers","subscription_url":"https://api.github.com/repos/fireeye/flare-floss/subscription","commits_url":"https://api.github.com/repos/fireeye/flare-floss/commits{/sha}","git_commits_url":"https://api.github.com/repos/fireeye/flare-floss/git/commits{/sha}","comments_url":"https://api.github.com/repos/fireeye/flare-floss/comments{/number}","issue_comment_url":"https://api.github.com/repos/fireeye/flare-floss/issues/comments{/number}","contents_url":"https://api.github.com/repos/fireeye/flare-floss/contents/{+path}","compare_url":"https://api.github.com/repos/fireeye/flare-floss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fireeye/flare-floss/merges","archive_url":"https://api.github.com/repos/fireeye/flare-floss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fireeye/flare-floss/downloads","issues_url":"https://api.github.com/repos/fireeye/flare-floss/issues{/number}","pulls_url":"https://api.github.com/repos/fireeye/flare-floss/pulls{/number}","milestones_url":"https://api.github.com/repos/fireeye/flare-floss/milestones{/number}","notifications_url":"https://api.github.com/repos/fireeye/flare-floss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fireeye/flare-floss/labels{/name}","releases_url":"https://api.github.com/repos/fireeye/flare-floss/releases{/id}","deployments_url":"https://api.github.com/repos/fireeye/flare-floss/deployments","created_at":"2016-03-02T20:16:10Z","updated_at":"2016-04-12T11:13:16Z","pushed_at":"2016-04-14T12:59:23Z","git_url":"git://github.com/fireeye/flare-floss.git","ssh_url":"git@github.com:fireeye/flare-floss.git","clone_url":"https://github.com/fireeye/flare-floss.git","svn_url":"https://github.com/fireeye/flare-floss","homepage":null,"size":203,"stargazers_count":61,"watchers_count":61,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":13,"forks":13,"open_issues":13,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/86"},"html":{"href":"https://github.com/fireeye/flare-floss/pull/86"},"issue":{"href":"https://api.github.com/repos/fireeye/flare-floss/issues/86"},"comments":{"href":"https://api.github.com/repos/fireeye/flare-floss/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fireeye/flare-floss/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/fireeye/flare-floss/statuses/456d0ff413623cb1bffc44d1d5caaad4cc9f0c46"}}}}