{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/eclipse-plugin/issues/231","repository_url":"https://api.github.com/repos/vaadin/eclipse-plugin","labels_url":"https://api.github.com/repos/vaadin/eclipse-plugin/issues/231/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/eclipse-plugin/issues/231/comments","events_url":"https://api.github.com/repos/vaadin/eclipse-plugin/issues/231/events","html_url":"https://github.com/vaadin/eclipse-plugin/issues/231","id":134248038,"number":231,"title":"Widgetset name refactoring fails when renaming packages","user":{"login":"makoivis","id":7498049,"avatar_url":"https://avatars.githubusercontent.com/u/7498049?v=3","gravatar_id":"","url":"https://api.github.com/users/makoivis","html_url":"https://github.com/makoivis","followers_url":"https://api.github.com/users/makoivis/followers","following_url":"https://api.github.com/users/makoivis/following{/other_user}","gists_url":"https://api.github.com/users/makoivis/gists{/gist_id}","starred_url":"https://api.github.com/users/makoivis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makoivis/subscriptions","organizations_url":"https://api.github.com/users/makoivis/orgs","repos_url":"https://api.github.com/users/makoivis/repos","events_url":"https://api.github.com/users/makoivis/events{/privacy}","received_events_url":"https://api.github.com/users/makoivis/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-17T10:52:41Z","updated_at":"2016-02-17T10:53:06Z","closed_at":"2016-02-17T10:52:55Z","body":"**Reported by Henri Muurimaa on 22 Jan 2010 12:29 UTC**\nThe plugin has a off-by-one index problem when doing a string replace for the widgetset name in web.xml. Before rename I have\r\n```\r\n  \t<init-param>\r\n  \t\t<description>\r\n  \t\tApplication widgetset</description>\r\n  \t\t<param-name>widgetset</param-name>\r\n  \t\t<param-value>com.vaadin.contrib.mandelbrotwidget.widgetset.MandelbrotwidgetWidgetset</param-value>\r\n  \t</init-param>\r\n```\r\n\r\nI refactor the package to ```org.vaadin.hezamu.mandelbrotwidget```. Application package is replaced correctly, but the widgetset name is replaced to\r\n```\r\n  \t<init-param>\r\n  \t\t<description>\r\n  \t\tApplication widgetset</description>\r\n  \t\t<param-name>widgetset</param-name>\r\n  \t\t<param-value>corg.vaadin.hezamu.mandelbrotwidget.widgetsetMandelbrotwidgetWidgetset</param-value>\r\n  \t</init-param>\r\n```\r\n\r\nApparently the plugin replaces the correct number of characters, but starts from character in index 1 instead of 0.\r\n\n\nMigrated-From: http://my.domain/trac/env/ticket/4045"},"comment":{"url":"https://api.github.com/repos/vaadin/eclipse-plugin/issues/comments/185151867","html_url":"https://github.com/vaadin/eclipse-plugin/issues/231#issuecomment-185151867","issue_url":"https://api.github.com/repos/vaadin/eclipse-plugin/issues/231","id":185151867,"user":{"login":"makoivis","id":7498049,"avatar_url":"https://avatars.githubusercontent.com/u/7498049?v=3","gravatar_id":"","url":"https://api.github.com/users/makoivis","html_url":"https://github.com/makoivis","followers_url":"https://api.github.com/users/makoivis/followers","following_url":"https://api.github.com/users/makoivis/following{/other_user}","gists_url":"https://api.github.com/users/makoivis/gists{/gist_id}","starred_url":"https://api.github.com/users/makoivis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makoivis/subscriptions","organizations_url":"https://api.github.com/users/makoivis/orgs","repos_url":"https://api.github.com/users/makoivis/repos","events_url":"https://api.github.com/users/makoivis/events{/privacy}","received_events_url":"https://api.github.com/users/makoivis/received_events","type":"User","site_admin":false},"created_at":"2016-02-17T10:53:06Z","updated_at":"2016-02-17T10:53:06Z","body":"**Comment by Artur Signell on 28 Aug 2014 08:46 UTC**\nMilestone Plug-in for Eclipse backlog deleted"}}