{"action":"opened","issue":{"url":"https://api.github.com/repos/thias/puppet-sysctl/issues/40","repository_url":"https://api.github.com/repos/thias/puppet-sysctl","labels_url":"https://api.github.com/repos/thias/puppet-sysctl/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/thias/puppet-sysctl/issues/40/comments","events_url":"https://api.github.com/repos/thias/puppet-sysctl/issues/40/events","html_url":"https://github.com/thias/puppet-sysctl/issues/40","id":134060688,"number":40,"title":"Recent changes make module non-idempotent.","user":{"login":"gapotts","id":4754985,"avatar_url":"https://avatars.githubusercontent.com/u/4754985?v=3","gravatar_id":"","url":"https://api.github.com/users/gapotts","html_url":"https://github.com/gapotts","followers_url":"https://api.github.com/users/gapotts/followers","following_url":"https://api.github.com/users/gapotts/following{/other_user}","gists_url":"https://api.github.com/users/gapotts/gists{/gist_id}","starred_url":"https://api.github.com/users/gapotts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gapotts/subscriptions","organizations_url":"https://api.github.com/users/gapotts/orgs","repos_url":"https://api.github.com/users/gapotts/repos","events_url":"https://api.github.com/users/gapotts/events{/privacy}","received_events_url":"https://api.github.com/users/gapotts/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-16T18:34:35Z","updated_at":"2016-02-16T18:34:35Z","closed_at":null,"body":"A recent change to this module makes it non-idempotent for some values.\r\n\r\nExample:\r\nNotice: /Stage[main]/Sysctl::Base/Sysctl[kernel.sem]/Exec[enforce-sysctl-value-kernel.sem]/returns: executed successfully\r\nNotice: /Stage[main]/Sysctl::Base/Sysctl[net.ipv4.ip_local_port_range]/Exec[enforce-sysctl-value-net.ipv4.ip_local_port_range]/returns: executed successfully\r\n\r\nThis notice happens on every puppet run.\r\n\r\nMy hiera data looks like:\r\n---\r\nsysctl::base::values:\r\n  kernel.shmmax:\r\n    value: 68719476736\r\n  kernel.shmall:\r\n    value: 4294967296\r\n  fs.aio-max-nr:\r\n    value: 1048576\r\n  fs.file-max:\r\n    value: 6815744\r\n  kernel.shmmni:\r\n    value: 4096\r\n  kernel.sem:\r\n    value: 250 32000 100 128\r\n  net.ipv4.ip_local_port_range:\r\n    value: 9000 65500\r\n  net.core.rmem_default:\r\n    value: 262144\r\n  net.core.rmem_max:\r\n    value: 4194304\r\n  net.core.wmem_default:\r\n    value: 262144\r\n  net.core.wmem_max:\r\n    value: 1048576\r\n\r\nI am running R10k and am currently working around the issue by pinning my version number to 1.0.2.  I'm not sure at what version this actually started to happen since I haven't had time go test this on the versions in between, but I'm sure others are likely to hit this at some point.\r\n\r\nRegards -Greg"}}