{"action":"created","comment":{"url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/comments/50904553","id":50904553,"diff_hunk":"@@ -160,63 +142,75 @@\n \n #elif defined(TIME_OVERRIDES)\n     /* user would like to override time() and gmtime() functionality */\n-\n     #ifndef HAVE_TIME_T_TYPE\n-        typedef long time_t;\n+        #define USE_WOLF_TIME_T\n     #endif\n-    extern time_t XTIME(time_t * timer);\n-\n     #ifndef HAVE_TM_TYPE\n-        struct tm {\n-            int  tm_sec;     /* seconds after the minute [0-60] */\n-            int  tm_min;     /* minutes after the hour [0-59] */\n-            int  tm_hour;    /* hours since midnight [0-23] */\n-            int  tm_mday;    /* day of the month [1-31] */\n-            int  tm_mon;     /* months since January [0-11] */\n-            int  tm_year;    /* years since 1900 */\n-            int  tm_wday;    /* days since Sunday [0-6] */\n-            int  tm_yday;    /* days since January 1 [0-365] */\n-            int  tm_isdst;   /* Daylight Savings Time flag */\n-            long tm_gmtoff;  /* offset from CUT in seconds */\n-            char *tm_zone;   /* timezone abbreviation */\n-        };\n+        #define USE_WOLF_TM\n     #endif\n-    extern struct tm* XGMTIME(const time_t* timer, struct tm* tmp);\n \n-    #ifndef HAVE_VALIDATE_DATE\n-        #define XVALIDATE_DATE(d, f, t) ValidateDate((d), (f), (t))\n-    #endif\n+    /* forward declarations */\n+    extern time_t XTIME(time_t * timer);","path":"wolfcrypt/src/asn.c","position":111,"original_position":111,"commit_id":"c7f24331d283628764d02798e9d8ca9a8eb15142","original_commit_id":"c7f24331d283628764d02798e9d8ca9a8eb15142","user":{"login":"dgarske","id":2692870,"avatar_url":"https://avatars.githubusercontent.com/u/2692870?v=3","gravatar_id":"","url":"https://api.github.com/users/dgarske","html_url":"https://github.com/dgarske","followers_url":"https://api.github.com/users/dgarske/followers","following_url":"https://api.github.com/users/dgarske/following{/other_user}","gists_url":"https://api.github.com/users/dgarske/gists{/gist_id}","starred_url":"https://api.github.com/users/dgarske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgarske/subscriptions","organizations_url":"https://api.github.com/users/dgarske/orgs","repos_url":"https://api.github.com/users/dgarske/repos","events_url":"https://api.github.com/users/dgarske/events{/privacy}","received_events_url":"https://api.github.com/users/dgarske/received_events","type":"User","site_admin":false},"body":"Same as above. The typedef time_t is known because I added \"USE_WOLF_TIME_T\" at new line 131, which does the \"typedef long time_t\" below at new line 208.","created_at":"2016-01-26T21:39:42Z","updated_at":"2016-01-26T21:39:42Z","html_url":"https://github.com/wolfSSL/wolfssl/pull/261#discussion_r50904553","pull_request_url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/261","_links":{"self":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/comments/50904553"},"html":{"href":"https://github.com/wolfSSL/wolfssl/pull/261#discussion_r50904553"},"pull_request":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/261"}}},"pull_request":{"url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/261","id":56234665,"html_url":"https://github.com/wolfSSL/wolfssl/pull/261","diff_url":"https://github.com/wolfSSL/wolfssl/pull/261.diff","patch_url":"https://github.com/wolfSSL/wolfssl/pull/261.patch","issue_url":"https://api.github.com/repos/wolfSSL/wolfssl/issues/261","number":261,"state":"open","locked":false,"title":"ASN time cleanup and ksdk_time fix with returned pointer","user":{"login":"dgarske","id":2692870,"avatar_url":"https://avatars.githubusercontent.com/u/2692870?v=3","gravatar_id":"","url":"https://api.github.com/users/dgarske","html_url":"https://github.com/dgarske","followers_url":"https://api.github.com/users/dgarske/followers","following_url":"https://api.github.com/users/dgarske/following{/other_user}","gists_url":"https://api.github.com/users/dgarske/gists{/gist_id}","starred_url":"https://api.github.com/users/dgarske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgarske/subscriptions","organizations_url":"https://api.github.com/users/dgarske/orgs","repos_url":"https://api.github.com/users/dgarske/repos","events_url":"https://api.github.com/users/dgarske/events{/privacy}","received_events_url":"https://api.github.com/users/dgarske/received_events","type":"User","site_admin":false},"body":"Cleanup of the time macros in asn.c to allow expanded use of wolf \"struct tm\", \"time_t\" and \"gmtime\". Fixed issue in \"ksdk_time\" where it could return a stack pointer by making the variable static. Cleanup of the io.c socket includes for clarity. Cleanup trailing spaces in io.c and asn.c.","created_at":"2016-01-15T23:26:32Z","updated_at":"2016-01-26T21:39:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a76c972b48dd6ba2b04f3921b4f52c780db5a02","assignee":{"login":"cconlon","id":302241,"avatar_url":"https://avatars.githubusercontent.com/u/302241?v=3","gravatar_id":"","url":"https://api.github.com/users/cconlon","html_url":"https://github.com/cconlon","followers_url":"https://api.github.com/users/cconlon/followers","following_url":"https://api.github.com/users/cconlon/following{/other_user}","gists_url":"https://api.github.com/users/cconlon/gists{/gist_id}","starred_url":"https://api.github.com/users/cconlon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cconlon/subscriptions","organizations_url":"https://api.github.com/users/cconlon/orgs","repos_url":"https://api.github.com/users/cconlon/repos","events_url":"https://api.github.com/users/cconlon/events{/privacy}","received_events_url":"https://api.github.com/users/cconlon/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/261/commits","review_comments_url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/261/comments","review_comment_url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wolfSSL/wolfssl/issues/261/comments","statuses_url":"https://api.github.com/repos/wolfSSL/wolfssl/statuses/c7f24331d283628764d02798e9d8ca9a8eb15142","head":{"label":"dgarske:AsnIoCleanup","ref":"AsnIoCleanup","sha":"c7f24331d283628764d02798e9d8ca9a8eb15142","user":{"login":"dgarske","id":2692870,"avatar_url":"https://avatars.githubusercontent.com/u/2692870?v=3","gravatar_id":"","url":"https://api.github.com/users/dgarske","html_url":"https://github.com/dgarske","followers_url":"https://api.github.com/users/dgarske/followers","following_url":"https://api.github.com/users/dgarske/following{/other_user}","gists_url":"https://api.github.com/users/dgarske/gists{/gist_id}","starred_url":"https://api.github.com/users/dgarske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgarske/subscriptions","organizations_url":"https://api.github.com/users/dgarske/orgs","repos_url":"https://api.github.com/users/dgarske/repos","events_url":"https://api.github.com/users/dgarske/events{/privacy}","received_events_url":"https://api.github.com/users/dgarske/received_events","type":"User","site_admin":false},"repo":{"id":44402104,"name":"wolfssl","full_name":"dgarske/wolfssl","owner":{"login":"dgarske","id":2692870,"avatar_url":"https://avatars.githubusercontent.com/u/2692870?v=3","gravatar_id":"","url":"https://api.github.com/users/dgarske","html_url":"https://github.com/dgarske","followers_url":"https://api.github.com/users/dgarske/followers","following_url":"https://api.github.com/users/dgarske/following{/other_user}","gists_url":"https://api.github.com/users/dgarske/gists{/gist_id}","starred_url":"https://api.github.com/users/dgarske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgarske/subscriptions","organizations_url":"https://api.github.com/users/dgarske/orgs","repos_url":"https://api.github.com/users/dgarske/repos","events_url":"https://api.github.com/users/dgarske/events{/privacy}","received_events_url":"https://api.github.com/users/dgarske/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgarske/wolfssl","description":"wolfSSL (formerly CyaSSL) is a small, fast, portable implementation of TLS/SSL for embedded devices to the cloud. http://www.wolfssl.com","fork":true,"url":"https://api.github.com/repos/dgarske/wolfssl","forks_url":"https://api.github.com/repos/dgarske/wolfssl/forks","keys_url":"https://api.github.com/repos/dgarske/wolfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgarske/wolfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgarske/wolfssl/teams","hooks_url":"https://api.github.com/repos/dgarske/wolfssl/hooks","issue_events_url":"https://api.github.com/repos/dgarske/wolfssl/issues/events{/number}","events_url":"https://api.github.com/repos/dgarske/wolfssl/events","assignees_url":"https://api.github.com/repos/dgarske/wolfssl/assignees{/user}","branches_url":"https://api.github.com/repos/dgarske/wolfssl/branches{/branch}","tags_url":"https://api.github.com/repos/dgarske/wolfssl/tags","blobs_url":"https://api.github.com/repos/dgarske/wolfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgarske/wolfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgarske/wolfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgarske/wolfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgarske/wolfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/dgarske/wolfssl/languages","stargazers_url":"https://api.github.com/repos/dgarske/wolfssl/stargazers","contributors_url":"https://api.github.com/repos/dgarske/wolfssl/contributors","subscribers_url":"https://api.github.com/repos/dgarske/wolfssl/subscribers","subscription_url":"https://api.github.com/repos/dgarske/wolfssl/subscription","commits_url":"https://api.github.com/repos/dgarske/wolfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgarske/wolfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgarske/wolfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgarske/wolfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgarske/wolfssl/contents/{+path}","compare_url":"https://api.github.com/repos/dgarske/wolfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgarske/wolfssl/merges","archive_url":"https://api.github.com/repos/dgarske/wolfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgarske/wolfssl/downloads","issues_url":"https://api.github.com/repos/dgarske/wolfssl/issues{/number}","pulls_url":"https://api.github.com/repos/dgarske/wolfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/dgarske/wolfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/dgarske/wolfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgarske/wolfssl/labels{/name}","releases_url":"https://api.github.com/repos/dgarske/wolfssl/releases{/id}","deployments_url":"https://api.github.com/repos/dgarske/wolfssl/deployments","created_at":"2015-10-16T18:00:02Z","updated_at":"2016-01-15T05:03:58Z","pushed_at":"2016-01-26T19:29:50Z","git_url":"git://github.com/dgarske/wolfssl.git","ssh_url":"git@github.com:dgarske/wolfssl.git","clone_url":"https://github.com/dgarske/wolfssl.git","svn_url":"https://github.com/dgarske/wolfssl","homepage":null,"size":17145,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wolfSSL:master","ref":"master","sha":"18c25b5d043a65341443ec4b91c5560f8724d0d1","user":{"login":"wolfSSL","id":5891092,"avatar_url":"https://avatars.githubusercontent.com/u/5891092?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfSSL","html_url":"https://github.com/wolfSSL","followers_url":"https://api.github.com/users/wolfSSL/followers","following_url":"https://api.github.com/users/wolfSSL/following{/other_user}","gists_url":"https://api.github.com/users/wolfSSL/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfSSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfSSL/subscriptions","organizations_url":"https://api.github.com/users/wolfSSL/orgs","repos_url":"https://api.github.com/users/wolfSSL/repos","events_url":"https://api.github.com/users/wolfSSL/events{/privacy}","received_events_url":"https://api.github.com/users/wolfSSL/received_events","type":"Organization","site_admin":false},"repo":{"id":28928522,"name":"wolfssl","full_name":"wolfSSL/wolfssl","owner":{"login":"wolfSSL","id":5891092,"avatar_url":"https://avatars.githubusercontent.com/u/5891092?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfSSL","html_url":"https://github.com/wolfSSL","followers_url":"https://api.github.com/users/wolfSSL/followers","following_url":"https://api.github.com/users/wolfSSL/following{/other_user}","gists_url":"https://api.github.com/users/wolfSSL/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfSSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfSSL/subscriptions","organizations_url":"https://api.github.com/users/wolfSSL/orgs","repos_url":"https://api.github.com/users/wolfSSL/repos","events_url":"https://api.github.com/users/wolfSSL/events{/privacy}","received_events_url":"https://api.github.com/users/wolfSSL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wolfSSL/wolfssl","description":"wolfSSL (formerly CyaSSL) is a small, fast, portable implementation of TLS/SSL for embedded devices to the cloud. http://www.wolfssl.com","fork":false,"url":"https://api.github.com/repos/wolfSSL/wolfssl","forks_url":"https://api.github.com/repos/wolfSSL/wolfssl/forks","keys_url":"https://api.github.com/repos/wolfSSL/wolfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolfSSL/wolfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolfSSL/wolfssl/teams","hooks_url":"https://api.github.com/repos/wolfSSL/wolfssl/hooks","issue_events_url":"https://api.github.com/repos/wolfSSL/wolfssl/issues/events{/number}","events_url":"https://api.github.com/repos/wolfSSL/wolfssl/events","assignees_url":"https://api.github.com/repos/wolfSSL/wolfssl/assignees{/user}","branches_url":"https://api.github.com/repos/wolfSSL/wolfssl/branches{/branch}","tags_url":"https://api.github.com/repos/wolfSSL/wolfssl/tags","blobs_url":"https://api.github.com/repos/wolfSSL/wolfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolfSSL/wolfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolfSSL/wolfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolfSSL/wolfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolfSSL/wolfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/wolfSSL/wolfssl/languages","stargazers_url":"https://api.github.com/repos/wolfSSL/wolfssl/stargazers","contributors_url":"https://api.github.com/repos/wolfSSL/wolfssl/contributors","subscribers_url":"https://api.github.com/repos/wolfSSL/wolfssl/subscribers","subscription_url":"https://api.github.com/repos/wolfSSL/wolfssl/subscription","commits_url":"https://api.github.com/repos/wolfSSL/wolfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolfSSL/wolfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolfSSL/wolfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolfSSL/wolfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolfSSL/wolfssl/contents/{+path}","compare_url":"https://api.github.com/repos/wolfSSL/wolfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolfSSL/wolfssl/merges","archive_url":"https://api.github.com/repos/wolfSSL/wolfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolfSSL/wolfssl/downloads","issues_url":"https://api.github.com/repos/wolfSSL/wolfssl/issues{/number}","pulls_url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/wolfSSL/wolfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/wolfSSL/wolfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolfSSL/wolfssl/labels{/name}","releases_url":"https://api.github.com/repos/wolfSSL/wolfssl/releases{/id}","deployments_url":"https://api.github.com/repos/wolfSSL/wolfssl/deployments","created_at":"2015-01-07T18:50:58Z","updated_at":"2016-01-11T19:29:28Z","pushed_at":"2016-01-26T21:18:11Z","git_url":"git://github.com/wolfSSL/wolfssl.git","ssh_url":"git@github.com:wolfSSL/wolfssl.git","clone_url":"https://github.com/wolfSSL/wolfssl.git","svn_url":"https://github.com/wolfSSL/wolfssl","homepage":null,"size":19142,"stargazers_count":65,"watchers_count":65,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":4,"forks":43,"open_issues":4,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/261"},"html":{"href":"https://github.com/wolfSSL/wolfssl/pull/261"},"issue":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/issues/261"},"comments":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/statuses/c7f24331d283628764d02798e9d8ca9a8eb15142"}}}}