{"action":"created","issue":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1415","repository_url":"https://api.github.com/repos/SUSE-Cloud/automation","labels_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1415/labels{/name}","comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1415/comments","events_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1415/events","html_url":"https://github.com/SUSE-Cloud/automation/pull/1415","id":186852659,"number":1415,"title":"unsource qa_crowbarsetup","user":{"login":"jdsn","id":27084,"avatar_url":"https://avatars.githubusercontent.com/u/27084?v=3","gravatar_id":"","url":"https://api.github.com/users/jdsn","html_url":"https://github.com/jdsn","followers_url":"https://api.github.com/users/jdsn/followers","following_url":"https://api.github.com/users/jdsn/following{/other_user}","gists_url":"https://api.github.com/users/jdsn/gists{/gist_id}","starred_url":"https://api.github.com/users/jdsn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdsn/subscriptions","organizations_url":"https://api.github.com/users/jdsn/orgs","repos_url":"https://api.github.com/users/jdsn/repos","events_url":"https://api.github.com/users/jdsn/events{/privacy}","received_events_url":"https://api.github.com/users/jdsn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"assignees":[{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},{"login":"s-t-e-v-e-n-k","id":15225059,"avatar_url":"https://avatars.githubusercontent.com/u/15225059?v=3","gravatar_id":"","url":"https://api.github.com/users/s-t-e-v-e-n-k","html_url":"https://github.com/s-t-e-v-e-n-k","followers_url":"https://api.github.com/users/s-t-e-v-e-n-k/followers","following_url":"https://api.github.com/users/s-t-e-v-e-n-k/following{/other_user}","gists_url":"https://api.github.com/users/s-t-e-v-e-n-k/gists{/gist_id}","starred_url":"https://api.github.com/users/s-t-e-v-e-n-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-t-e-v-e-n-k/subscriptions","organizations_url":"https://api.github.com/users/s-t-e-v-e-n-k/orgs","repos_url":"https://api.github.com/users/s-t-e-v-e-n-k/repos","events_url":"https://api.github.com/users/s-t-e-v-e-n-k/events{/privacy}","received_events_url":"https://api.github.com/users/s-t-e-v-e-n-k/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-11-02T16:33:59Z","updated_at":"2016-11-03T10:23:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1415","html_url":"https://github.com/SUSE-Cloud/automation/pull/1415","diff_url":"https://github.com/SUSE-Cloud/automation/pull/1415.diff","patch_url":"https://github.com/SUSE-Cloud/automation/pull/1415.patch"},"body":"Move qa_crowbarsetup help to common file.\r\nRenaming `onadmin_help` to `qacrowbarsetup_help` which is a correct name (because the `onadmin_` prefix means that a function runs **on** the admin node).\r\n    \r\nThe goal is to untie mkcloud and qa_crowbarsetup.\r\nSo we removed the sourcing of qa_crowbarsetup a few weeks ago (this is a feature).\r\n\r\nThe idea behind this is, that mkcloud can change more radical than qa_crowbarsetup. The latter will most likely remain a collection of shell functions. But mkcloud will need to change sooner or later into a OOP style (this will not be bash). Changes like this contradict this plan. Breakages should not be fixed by sourcing qa_crowbarsetup.sh again.\r\n\r\nThis PR contains the revert of commit dae0ddd21698e274175fee60c31d8ae8a24d5600"},"comment":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/comments/258106700","html_url":"https://github.com/SUSE-Cloud/automation/pull/1415#issuecomment-258106700","issue_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1415","id":258106700,"user":{"login":"jdsn","id":27084,"avatar_url":"https://avatars.githubusercontent.com/u/27084?v=3","gravatar_id":"","url":"https://api.github.com/users/jdsn","html_url":"https://github.com/jdsn","followers_url":"https://api.github.com/users/jdsn/followers","following_url":"https://api.github.com/users/jdsn/following{/other_user}","gists_url":"https://api.github.com/users/jdsn/gists{/gist_id}","starred_url":"https://api.github.com/users/jdsn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdsn/subscriptions","organizations_url":"https://api.github.com/users/jdsn/orgs","repos_url":"https://api.github.com/users/jdsn/repos","events_url":"https://api.github.com/users/jdsn/events{/privacy}","received_events_url":"https://api.github.com/users/jdsn/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T10:23:27Z","updated_at":"2016-11-03T10:23:27Z","body":"> My only issue with this change is that developers have to remember to update two files if new flags get added.\r\n\r\n@s-t-e-v-e-n-k \r\nWhy? If new variables are added that are needed on the admin node then they have to be passed there in both cases. For all variables with the `want_` prefix this is done automatically. Others need a good reason to be named differently.\r\n\r\nRemember, the goal is to reduce the number of variables that we need to configure an mkcloud run. We want to take as many configuration parameters from batch/scenario files as possible.\r\n\r\n> I'd prefer the commits to be squashed.\r\n\r\n@nicolasbock \r\nI agree that the revert alone reintroduces the failure, but the following commit from this PR contains the fix. For a normal change commit I would agree to squash, but in this case my preference is to have the revert as standalone commit - to show what was reverted, without mixing it. As the PR gets merged together anyway this should not be an issue.\r\nBut I don't care that much about it being one or two commits. So if this is preferred by all other parties, I can squash the commits (please speak up), otherwise I keep them separate.\r\n\r\n\r\n> As QA and perhaps others still rely on sourcing qa_crowbarsetup.sh, what are the consequences for those using the file as standalone collection of functions?\r\n\r\n@vmoravec This change only complains if qa_crowbarsetup was sourced within the mkcloud script. All other sourcing is unaffected. Even in our deployments qa_crowbarsetup is sourced in the admin node shell and the functions are called directly. So no changes here, and no changes for standalone usage.\r\nIn essence, this is exactly what the change enforces: that qa_crowbarsetup remains a standalone tool by not mixing it into mkcloud."}}
{"actor":{"display_login":"jdsn"}}