{"action":"created","comment":{"url":"https://api.github.com/repos/LLK/scratch-www/pulls/comments/87847803","pull_request_review_id":8442398,"id":87847803,"diff_hunk":"@@ -7,10 +7,11 @@\n var tap=require('tap');\n var seleniumWebdriver = require('selenium-webdriver');\n \n-//chrome driver\n-var driver = new seleniumWebdriver.Builder().withCapabilities(seleniumWebdriver.Capabilities.chrome()).build();\n+//Passing in the driver as a variable?\n+var driver = process.env.DRIVER || seleniumWebdriver.Builder().withCapabilities(seleniumWebdriver.Capabilities.chrome()).build();","path":"test/integration/check_navbar_links.js","position":null,"original_position":7,"commit_id":"5900537f0e2028013243e78e58557cd1a2a68027","original_commit_id":"5900537f0e2028013243e78e58557cd1a2a68027","user":{"login":"jwzimmer","id":1320456,"avatar_url":"https://avatars.githubusercontent.com/u/1320456?v=3","gravatar_id":"","url":"https://api.github.com/users/jwzimmer","html_url":"https://github.com/jwzimmer","followers_url":"https://api.github.com/users/jwzimmer/followers","following_url":"https://api.github.com/users/jwzimmer/following{/other_user}","gists_url":"https://api.github.com/users/jwzimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwzimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwzimmer/subscriptions","organizations_url":"https://api.github.com/users/jwzimmer/orgs","repos_url":"https://api.github.com/users/jwzimmer/repos","events_url":"https://api.github.com/users/jwzimmer/events{/privacy}","received_events_url":"https://api.github.com/users/jwzimmer/received_events","type":"User","site_admin":false},"body":"I don't think this would work... the proces.env docs said that by default passed-in variables are strings, so I need to look into how to do this properly, but I just wanted to illustrate what I was trying to ask about when I mentioned passing in the drivers as variables...","created_at":"2016-11-14T17:18:20Z","updated_at":"2016-11-14T17:18:20Z","html_url":"https://github.com/LLK/scratch-www/pull/1017#discussion_r87847803","pull_request_url":"https://api.github.com/repos/LLK/scratch-www/pulls/1017","_links":{"self":{"href":"https://api.github.com/repos/LLK/scratch-www/pulls/comments/87847803"},"html":{"href":"https://github.com/LLK/scratch-www/pull/1017#discussion_r87847803"},"pull_request":{"href":"https://api.github.com/repos/LLK/scratch-www/pulls/1017"}}},"pull_request":{"url":"https://api.github.com/repos/LLK/scratch-www/pulls/1017","id":93606582,"html_url":"https://github.com/LLK/scratch-www/pull/1017","diff_url":"https://github.com/LLK/scratch-www/pull/1017.diff","patch_url":"https://github.com/LLK/scratch-www/pull/1017.patch","issue_url":"https://api.github.com/repos/LLK/scratch-www/issues/1017","number":1017,"state":"open","locked":false,"title":"Fix gh-925: setup initial automated test","user":{"login":"jwzimmer","id":1320456,"avatar_url":"https://avatars.githubusercontent.com/u/1320456?v=3","gravatar_id":"","url":"https://api.github.com/users/jwzimmer","html_url":"https://github.com/jwzimmer","followers_url":"https://api.github.com/users/jwzimmer/followers","following_url":"https://api.github.com/users/jwzimmer/following{/other_user}","gists_url":"https://api.github.com/users/jwzimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwzimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwzimmer/subscriptions","organizations_url":"https://api.github.com/users/jwzimmer/orgs","repos_url":"https://api.github.com/users/jwzimmer/repos","events_url":"https://api.github.com/users/jwzimmer/events{/privacy}","received_events_url":"https://api.github.com/users/jwzimmer/received_events","type":"User","site_admin":false},"body":"Fixes #925.\r\n\r\n@mewtaylor Would you mind going over this with me when you have time?\r\n\r\nIn #925, we said:\r\n- Change driver URL to a variable so it isn't hardcoded --> I added process.env TEST_DOMAIN variable\r\n- Set up running with travis/ sauce --> I am not sure how to do this, but from the conversation in the meeting last Thursday, it sounded like we were going to remove testing dependencies from dev dependencies and set-up running various kinds of tests. I removed selenium as a dependency... not sure how to do the set up for running the tests.\r\n- Maybe set up running with multiple browser drivers --> Haven't addressed yet, seems like we could use sauce to do this and maybe makes sense to do at the same time as the other parts of the set-up? (Ideally, maybe we could pass in drivers as a variable and iterate through them?)\r\n\r\n\r\n","created_at":"2016-11-14T17:07:31Z","updated_at":"2016-11-14T17:18:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05c2857965655e6617e1ce1c4c72b172f8c7885d","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/LLK/scratch-www/milestones/25","html_url":"https://github.com/LLK/scratch-www/milestones/November%2014","labels_url":"https://api.github.com/repos/LLK/scratch-www/milestones/25/labels","id":1932369,"number":25,"title":"November 14","description":"","creator":{"login":"kaschm","id":782228,"avatar_url":"https://avatars.githubusercontent.com/u/782228?v=3","gravatar_id":"","url":"https://api.github.com/users/kaschm","html_url":"https://github.com/kaschm","followers_url":"https://api.github.com/users/kaschm/followers","following_url":"https://api.github.com/users/kaschm/following{/other_user}","gists_url":"https://api.github.com/users/kaschm/gists{/gist_id}","starred_url":"https://api.github.com/users/kaschm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaschm/subscriptions","organizations_url":"https://api.github.com/users/kaschm/orgs","repos_url":"https://api.github.com/users/kaschm/repos","events_url":"https://api.github.com/users/kaschm/events{/privacy}","received_events_url":"https://api.github.com/users/kaschm/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":12,"state":"open","created_at":"2016-08-09T13:37:40Z","updated_at":"2016-11-14T17:08:47Z","due_on":"2016-11-14T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/LLK/scratch-www/pulls/1017/commits","review_comments_url":"https://api.github.com/repos/LLK/scratch-www/pulls/1017/comments","review_comment_url":"https://api.github.com/repos/LLK/scratch-www/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLK/scratch-www/issues/1017/comments","statuses_url":"https://api.github.com/repos/LLK/scratch-www/statuses/5900537f0e2028013243e78e58557cd1a2a68027","head":{"label":"jwzimmer:issue/gh-925-setup-initial-automated-test","ref":"issue/gh-925-setup-initial-automated-test","sha":"5900537f0e2028013243e78e58557cd1a2a68027","user":{"login":"jwzimmer","id":1320456,"avatar_url":"https://avatars.githubusercontent.com/u/1320456?v=3","gravatar_id":"","url":"https://api.github.com/users/jwzimmer","html_url":"https://github.com/jwzimmer","followers_url":"https://api.github.com/users/jwzimmer/followers","following_url":"https://api.github.com/users/jwzimmer/following{/other_user}","gists_url":"https://api.github.com/users/jwzimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwzimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwzimmer/subscriptions","organizations_url":"https://api.github.com/users/jwzimmer/orgs","repos_url":"https://api.github.com/users/jwzimmer/repos","events_url":"https://api.github.com/users/jwzimmer/events{/privacy}","received_events_url":"https://api.github.com/users/jwzimmer/received_events","type":"User","site_admin":false},"repo":{"id":68229922,"name":"scratch-www","full_name":"jwzimmer/scratch-www","owner":{"login":"jwzimmer","id":1320456,"avatar_url":"https://avatars.githubusercontent.com/u/1320456?v=3","gravatar_id":"","url":"https://api.github.com/users/jwzimmer","html_url":"https://github.com/jwzimmer","followers_url":"https://api.github.com/users/jwzimmer/followers","following_url":"https://api.github.com/users/jwzimmer/following{/other_user}","gists_url":"https://api.github.com/users/jwzimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwzimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwzimmer/subscriptions","organizations_url":"https://api.github.com/users/jwzimmer/orgs","repos_url":"https://api.github.com/users/jwzimmer/repos","events_url":"https://api.github.com/users/jwzimmer/events{/privacy}","received_events_url":"https://api.github.com/users/jwzimmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwzimmer/scratch-www","description":"Standalone web client for Scratch","fork":true,"url":"https://api.github.com/repos/jwzimmer/scratch-www","forks_url":"https://api.github.com/repos/jwzimmer/scratch-www/forks","keys_url":"https://api.github.com/repos/jwzimmer/scratch-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwzimmer/scratch-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwzimmer/scratch-www/teams","hooks_url":"https://api.github.com/repos/jwzimmer/scratch-www/hooks","issue_events_url":"https://api.github.com/repos/jwzimmer/scratch-www/issues/events{/number}","events_url":"https://api.github.com/repos/jwzimmer/scratch-www/events","assignees_url":"https://api.github.com/repos/jwzimmer/scratch-www/assignees{/user}","branches_url":"https://api.github.com/repos/jwzimmer/scratch-www/branches{/branch}","tags_url":"https://api.github.com/repos/jwzimmer/scratch-www/tags","blobs_url":"https://api.github.com/repos/jwzimmer/scratch-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwzimmer/scratch-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwzimmer/scratch-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwzimmer/scratch-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwzimmer/scratch-www/statuses/{sha}","languages_url":"https://api.github.com/repos/jwzimmer/scratch-www/languages","stargazers_url":"https://api.github.com/repos/jwzimmer/scratch-www/stargazers","contributors_url":"https://api.github.com/repos/jwzimmer/scratch-www/contributors","subscribers_url":"https://api.github.com/repos/jwzimmer/scratch-www/subscribers","subscription_url":"https://api.github.com/repos/jwzimmer/scratch-www/subscription","commits_url":"https://api.github.com/repos/jwzimmer/scratch-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwzimmer/scratch-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwzimmer/scratch-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwzimmer/scratch-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwzimmer/scratch-www/contents/{+path}","compare_url":"https://api.github.com/repos/jwzimmer/scratch-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwzimmer/scratch-www/merges","archive_url":"https://api.github.com/repos/jwzimmer/scratch-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwzimmer/scratch-www/downloads","issues_url":"https://api.github.com/repos/jwzimmer/scratch-www/issues{/number}","pulls_url":"https://api.github.com/repos/jwzimmer/scratch-www/pulls{/number}","milestones_url":"https://api.github.com/repos/jwzimmer/scratch-www/milestones{/number}","notifications_url":"https://api.github.com/repos/jwzimmer/scratch-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwzimmer/scratch-www/labels{/name}","releases_url":"https://api.github.com/repos/jwzimmer/scratch-www/releases{/id}","deployments_url":"https://api.github.com/repos/jwzimmer/scratch-www/deployments","created_at":"2016-09-14T17:55:31Z","updated_at":"2016-09-14T17:55:32Z","pushed_at":"2016-11-14T17:16:10Z","git_url":"git://github.com/jwzimmer/scratch-www.git","ssh_url":"git@github.com:jwzimmer/scratch-www.git","clone_url":"https://github.com/jwzimmer/scratch-www.git","svn_url":"https://github.com/jwzimmer/scratch-www","homepage":"https://scratch.mit.edu","size":76066,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLK:develop","ref":"develop","sha":"25f61fdb778e8b6e5140c465d37acce793ffe868","user":{"login":"LLK","id":3420800,"avatar_url":"https://avatars.githubusercontent.com/u/3420800?v=3","gravatar_id":"","url":"https://api.github.com/users/LLK","html_url":"https://github.com/LLK","followers_url":"https://api.github.com/users/LLK/followers","following_url":"https://api.github.com/users/LLK/following{/other_user}","gists_url":"https://api.github.com/users/LLK/gists{/gist_id}","starred_url":"https://api.github.com/users/LLK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLK/subscriptions","organizations_url":"https://api.github.com/users/LLK/orgs","repos_url":"https://api.github.com/users/LLK/repos","events_url":"https://api.github.com/users/LLK/events{/privacy}","received_events_url":"https://api.github.com/users/LLK/received_events","type":"Organization","site_admin":false},"repo":{"id":41567275,"name":"scratch-www","full_name":"LLK/scratch-www","owner":{"login":"LLK","id":3420800,"avatar_url":"https://avatars.githubusercontent.com/u/3420800?v=3","gravatar_id":"","url":"https://api.github.com/users/LLK","html_url":"https://github.com/LLK","followers_url":"https://api.github.com/users/LLK/followers","following_url":"https://api.github.com/users/LLK/following{/other_user}","gists_url":"https://api.github.com/users/LLK/gists{/gist_id}","starred_url":"https://api.github.com/users/LLK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLK/subscriptions","organizations_url":"https://api.github.com/users/LLK/orgs","repos_url":"https://api.github.com/users/LLK/repos","events_url":"https://api.github.com/users/LLK/events{/privacy}","received_events_url":"https://api.github.com/users/LLK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLK/scratch-www","description":"Standalone web client for Scratch","fork":false,"url":"https://api.github.com/repos/LLK/scratch-www","forks_url":"https://api.github.com/repos/LLK/scratch-www/forks","keys_url":"https://api.github.com/repos/LLK/scratch-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLK/scratch-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLK/scratch-www/teams","hooks_url":"https://api.github.com/repos/LLK/scratch-www/hooks","issue_events_url":"https://api.github.com/repos/LLK/scratch-www/issues/events{/number}","events_url":"https://api.github.com/repos/LLK/scratch-www/events","assignees_url":"https://api.github.com/repos/LLK/scratch-www/assignees{/user}","branches_url":"https://api.github.com/repos/LLK/scratch-www/branches{/branch}","tags_url":"https://api.github.com/repos/LLK/scratch-www/tags","blobs_url":"https://api.github.com/repos/LLK/scratch-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLK/scratch-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLK/scratch-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLK/scratch-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLK/scratch-www/statuses/{sha}","languages_url":"https://api.github.com/repos/LLK/scratch-www/languages","stargazers_url":"https://api.github.com/repos/LLK/scratch-www/stargazers","contributors_url":"https://api.github.com/repos/LLK/scratch-www/contributors","subscribers_url":"https://api.github.com/repos/LLK/scratch-www/subscribers","subscription_url":"https://api.github.com/repos/LLK/scratch-www/subscription","commits_url":"https://api.github.com/repos/LLK/scratch-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLK/scratch-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLK/scratch-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLK/scratch-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLK/scratch-www/contents/{+path}","compare_url":"https://api.github.com/repos/LLK/scratch-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLK/scratch-www/merges","archive_url":"https://api.github.com/repos/LLK/scratch-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLK/scratch-www/downloads","issues_url":"https://api.github.com/repos/LLK/scratch-www/issues{/number}","pulls_url":"https://api.github.com/repos/LLK/scratch-www/pulls{/number}","milestones_url":"https://api.github.com/repos/LLK/scratch-www/milestones{/number}","notifications_url":"https://api.github.com/repos/LLK/scratch-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLK/scratch-www/labels{/name}","releases_url":"https://api.github.com/repos/LLK/scratch-www/releases{/id}","deployments_url":"https://api.github.com/repos/LLK/scratch-www/deployments","created_at":"2015-08-28T20:14:36Z","updated_at":"2016-11-12T05:20:24Z","pushed_at":"2016-11-14T17:16:10Z","git_url":"git://github.com/LLK/scratch-www.git","ssh_url":"git@github.com:LLK/scratch-www.git","clone_url":"https://github.com/LLK/scratch-www.git","svn_url":"https://github.com/LLK/scratch-www","homepage":"https://scratch.mit.edu","size":78259,"stargazers_count":137,"watchers_count":137,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":99,"forks":54,"open_issues":99,"watchers":137,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLK/scratch-www/pulls/1017"},"html":{"href":"https://github.com/LLK/scratch-www/pull/1017"},"issue":{"href":"https://api.github.com/repos/LLK/scratch-www/issues/1017"},"comments":{"href":"https://api.github.com/repos/LLK/scratch-www/issues/1017/comments"},"review_comments":{"href":"https://api.github.com/repos/LLK/scratch-www/pulls/1017/comments"},"review_comment":{"href":"https://api.github.com/repos/LLK/scratch-www/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLK/scratch-www/pulls/1017/commits"},"statuses":{"href":"https://api.github.com/repos/LLK/scratch-www/statuses/5900537f0e2028013243e78e58557cd1a2a68027"}}}}
{"actor":{"display_login":"jwzimmer"}}