{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/980","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/980/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/980/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/980/events","html_url":"https://github.com/greenplum-db/gpdb/pull/980","id":166928372,"number":980,"title":"Properly deparsing PartitionSelector's printablePredicate","user":{"login":"foyzur","id":1253020,"avatar_url":"https://avatars.githubusercontent.com/u/1253020?v=3","gravatar_id":"","url":"https://api.github.com/users/foyzur","html_url":"https://github.com/foyzur","followers_url":"https://api.github.com/users/foyzur/followers","following_url":"https://api.github.com/users/foyzur/following{/other_user}","gists_url":"https://api.github.com/users/foyzur/gists{/gist_id}","starred_url":"https://api.github.com/users/foyzur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foyzur/subscriptions","organizations_url":"https://api.github.com/users/foyzur/orgs","repos_url":"https://api.github.com/users/foyzur/repos","events_url":"https://api.github.com/users/foyzur/events{/privacy}","received_events_url":"https://api.github.com/users/foyzur/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-07-21T22:02:58Z","updated_at":"2016-07-22T05:57:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/980","html_url":"https://github.com/greenplum-db/gpdb/pull/980","diff_url":"https://github.com/greenplum-db/gpdb/pull/980.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/980.patch"},"body":"In this PR we revert the earlier fix in https://github.com/greenplum-db/gpdb/pull/840, but keep some part of it. This PR is similar in spirit to the earlier as it depends on parent of PartitionSelector (which is expected to be Sequence) to deparse printablePredicate. However, this PR resolves the parent from child, instead of resolving child from parent and localizes the changes to just explain.c. We also keep the old behavior of clearly isolating Sequence node from PartitionSelector node.\r\n\r\nBesides this, we also pass the parent to resolve both outer and inner varno of a PartitionSelector's printablePredicate, which is also necessary to make bfv_partition green."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/234461016","html_url":"https://github.com/greenplum-db/gpdb/pull/980#issuecomment-234461016","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/980","id":234461016,"user":{"login":"vraghavan78","id":12649877,"avatar_url":"https://avatars.githubusercontent.com/u/12649877?v=3","gravatar_id":"","url":"https://api.github.com/users/vraghavan78","html_url":"https://github.com/vraghavan78","followers_url":"https://api.github.com/users/vraghavan78/followers","following_url":"https://api.github.com/users/vraghavan78/following{/other_user}","gists_url":"https://api.github.com/users/vraghavan78/gists{/gist_id}","starred_url":"https://api.github.com/users/vraghavan78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vraghavan78/subscriptions","organizations_url":"https://api.github.com/users/vraghavan78/orgs","repos_url":"https://api.github.com/users/vraghavan78/repos","events_url":"https://api.github.com/users/vraghavan78/events{/privacy}","received_events_url":"https://api.github.com/users/vraghavan78/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T05:57:54Z","updated_at":"2016-07-22T05:57:54Z","body":"By design, dynamic table/bitmap scan is always coupled with a partition selector. All of our documentation, and training material says so. Customers want to see that the predicate was used for partition elimination. Even after your initial PR, these explain were causing failures in ICG. So we decided to revisit. Can we focus on how we can incorporate both approaches? "}}
{"actor":{"display_login":"vraghavan78"}}