{"action":"created","comment":{"url":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/comments/75267453","id":75267453,"diff_hunk":"@@ -19,48 +21,64 @@\n  *\n  */\n \n-namespace OCA\\FilesAccessControl\\Controller;\n+namespace OCA\\FilesAccessControl\\Settings;\n \n-use OCP\\AppFramework\\Controller;\n+use OCA\\FilesAccessControl\\AppInfo\\Application;\n use OCP\\AppFramework\\Http\\TemplateResponse;\n use OCP\\IL10N;\n-use OCP\\IRequest;\n-use Symfony\\Component\\EventDispatcher\\EventDispatcher;\n+use OCP\\Settings\\ISettings;\n+use OCP\\Util;\n use Symfony\\Component\\EventDispatcher\\EventDispatcherInterface;\n \n-class AdminController extends Controller {\n+class Admin implements ISettings {\n \n-\t/** @var EventDispatcher */\n-\tprotected $eventDispatcher;\n \t/** @var IL10N */\n-\tprotected $l10n;\n+\tprivate $l10n;\n \n-\t/**\n-\t * @param string $appName\n-\t * @param IRequest $request\n-\t * @param EventDispatcherInterface $eventDispatcher\n-\t * @param IL10N $l10n\n-\t */\n-\tpublic function __construct($appName,\n-\t\t\t\t\t\t\t\tIRequest $request,\n-\t\t\t\t\t\t\t\tEventDispatcherInterface $eventDispatcher,\n-\t\t\t\t\t\t\t\tIL10N $l10n) {\n-\t\tparent::__construct($appName, $request);\n+\t/** @var Application */\n+\tprivate $app;\n \n-\t\t$this->eventDispatcher = $eventDispatcher;\n+\t/** @var EventDispatcherInterface */\n+\tprivate $eventDispatcher;\n+\n+\tpublic function __construct(IL10N $l10n, Application $app, EventDispatcherInterface $eventDispatcher) {\n \t\t$this->l10n = $l10n;\n+\t\t$this->app = $app;\n+\t\t$this->eventDispatcher = $eventDispatcher;\n \t}\n \n \t/**\n \t * @return TemplateResponse\n \t */\n-\tpublic function index() {\n+\tpublic function getForm() {\n+\t\t$appName = $this->app->getContainer()->getAppName();\n \t\t$this->eventDispatcher->dispatch('OCP\\WorkflowEngine::loadAdditionalSettingScripts');\n-\t\t\\OCP\\Util::addScript($this->appName, 'admin');\n-\t\treturn new TemplateResponse('workflowengine', 'admin', [\n-\t\t\t'appid' => $this->appName,\n+\t\tUtil::addScript($appName, 'admin');\n+\t\t$parameters = [\n+\t\t\t'appid' => $appName,\n \t\t\t'heading' => $this->l10n->t('File access control'),\n \t\t\t'description' => $this->l10n->t('Each rule group consists of one or more rules. A request matches a group if all rules evaluate to true. If a request matches at least one of the defined groups, the request is blocked and the file content can not be read or written.'),\n-\t\t], 'blank');\n+\t\t];\n+\n+\t\treturn new TemplateResponse('workflowengine', 'admin', $parameters, 'blank');\n+\t}\n+\n+\t/**\n+\t * @return string the section ID, e.g. 'sharing'\n+\t */\n+\tpublic function getSection() {\n+\t\treturn 'additional';","path":"lib/Settings/Admin.php","position":85,"original_position":85,"commit_id":"56dcc2cb5a6b24f81c672250f59596139d90b615","original_commit_id":"56dcc2cb5a6b24f81c672250f59596139d90b615","user":{"login":"blizzz","id":2184312,"avatar_url":"https://avatars.githubusercontent.com/u/2184312?v=3","gravatar_id":"","url":"https://api.github.com/users/blizzz","html_url":"https://github.com/blizzz","followers_url":"https://api.github.com/users/blizzz/followers","following_url":"https://api.github.com/users/blizzz/following{/other_user}","gists_url":"https://api.github.com/users/blizzz/gists{/gist_id}","starred_url":"https://api.github.com/users/blizzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blizzz/subscriptions","organizations_url":"https://api.github.com/users/blizzz/orgs","repos_url":"https://api.github.com/users/blizzz/repos","events_url":"https://api.github.com/users/blizzz/events{/privacy}","received_events_url":"https://api.github.com/users/blizzz/received_events","type":"User","site_admin":false},"body":"Ok, I only checked info.xml, not default enabled there. ","created_at":"2016-08-18T08:30:48Z","updated_at":"2016-08-18T08:30:48Z","html_url":"https://github.com/nextcloud/files_accesscontrol/pull/16#discussion_r75267453","pull_request_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/comments/75267453"},"html":{"href":"https://github.com/nextcloud/files_accesscontrol/pull/16#discussion_r75267453"},"pull_request":{"href":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/16","id":81683114,"html_url":"https://github.com/nextcloud/files_accesscontrol/pull/16","diff_url":"https://github.com/nextcloud/files_accesscontrol/pull/16.diff","patch_url":"https://github.com/nextcloud/files_accesscontrol/pull/16.patch","issue_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/issues/16","number":16,"state":"open","locked":false,"title":"move to new admin mechanism","user":{"login":"blizzz","id":2184312,"avatar_url":"https://avatars.githubusercontent.com/u/2184312?v=3","gravatar_id":"","url":"https://api.github.com/users/blizzz","html_url":"https://github.com/blizzz","followers_url":"https://api.github.com/users/blizzz/followers","following_url":"https://api.github.com/users/blizzz/following{/other_user}","gists_url":"https://api.github.com/users/blizzz/gists{/gist_id}","starred_url":"https://api.github.com/users/blizzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blizzz/subscriptions","organizations_url":"https://api.github.com/users/blizzz/orgs","repos_url":"https://api.github.com/users/blizzz/repos","events_url":"https://api.github.com/users/blizzz/events{/privacy}","received_events_url":"https://api.github.com/users/blizzz/received_events","type":"User","site_admin":false},"body":"@nickvergessen @MorrisJobke ","created_at":"2016-08-17T17:26:58Z","updated_at":"2016-08-18T08:30:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcc5d427889cd3c0401d7a95db1863da4b2ff2fc","assignee":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=3","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"assignees":[{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=3","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/nextcloud/files_accesscontrol/milestones/3","html_url":"https://github.com/nextcloud/files_accesscontrol/milestones/Nextcloud%2011.0","labels_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/milestones/3/labels","id":1906573,"number":3,"title":"Nextcloud 11.0","description":null,"creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":11,"state":"open","created_at":"2016-07-27T07:31:09Z","updated_at":"2016-08-18T07:55:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/16/commits","review_comments_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/16/comments","review_comment_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/issues/16/comments","statuses_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/statuses/56dcc2cb5a6b24f81c672250f59596139d90b615","head":{"label":"nextcloud:admin-settings","ref":"admin-settings","sha":"56dcc2cb5a6b24f81c672250f59596139d90b615","user":{"login":"nextcloud","id":19211038,"avatar_url":"https://avatars.githubusercontent.com/u/19211038?v=3","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":64218239,"name":"files_accesscontrol","full_name":"nextcloud/files_accesscontrol","owner":{"login":"nextcloud","id":19211038,"avatar_url":"https://avatars.githubusercontent.com/u/19211038?v=3","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nextcloud/files_accesscontrol","description":"🚫 App to manage access control for files","fork":false,"url":"https://api.github.com/repos/nextcloud/files_accesscontrol","forks_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/forks","keys_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/teams","hooks_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/events","assignees_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/tags","blobs_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/languages","stargazers_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/subscription","commits_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/merges","archive_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/downloads","issues_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/deployments","created_at":"2016-07-26T12:07:49Z","updated_at":"2016-07-27T09:58:13Z","pushed_at":"2016-08-18T06:44:57Z","git_url":"git://github.com/nextcloud/files_accesscontrol.git","ssh_url":"git@github.com:nextcloud/files_accesscontrol.git","clone_url":"https://github.com/nextcloud/files_accesscontrol.git","svn_url":"https://github.com/nextcloud/files_accesscontrol","homepage":"","size":69,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"nextcloud:master","ref":"master","sha":"95e8b8aecb053cc76fa2a0a03aa614ea41fc1fa8","user":{"login":"nextcloud","id":19211038,"avatar_url":"https://avatars.githubusercontent.com/u/19211038?v=3","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":64218239,"name":"files_accesscontrol","full_name":"nextcloud/files_accesscontrol","owner":{"login":"nextcloud","id":19211038,"avatar_url":"https://avatars.githubusercontent.com/u/19211038?v=3","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nextcloud/files_accesscontrol","description":"🚫 App to manage access control for files","fork":false,"url":"https://api.github.com/repos/nextcloud/files_accesscontrol","forks_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/forks","keys_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/teams","hooks_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/events","assignees_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/tags","blobs_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/languages","stargazers_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/subscription","commits_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/merges","archive_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/downloads","issues_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/files_accesscontrol/deployments","created_at":"2016-07-26T12:07:49Z","updated_at":"2016-07-27T09:58:13Z","pushed_at":"2016-08-18T06:44:57Z","git_url":"git://github.com/nextcloud/files_accesscontrol.git","ssh_url":"git@github.com:nextcloud/files_accesscontrol.git","clone_url":"https://github.com/nextcloud/files_accesscontrol.git","svn_url":"https://github.com/nextcloud/files_accesscontrol","homepage":"","size":69,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/16"},"html":{"href":"https://github.com/nextcloud/files_accesscontrol/pull/16"},"issue":{"href":"https://api.github.com/repos/nextcloud/files_accesscontrol/issues/16"},"comments":{"href":"https://api.github.com/repos/nextcloud/files_accesscontrol/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextcloud/files_accesscontrol/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/nextcloud/files_accesscontrol/statuses/56dcc2cb5a6b24f81c672250f59596139d90b615"}}}}
{"actor":{"display_login":"blizzz"}}