{"action":"created","comment":{"url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/comments/63272637","id":63272637,"diff_hunk":"@@ -110,28 +110,33 @@ function convertGroupsToRanks(groups) {\n }\n \n function makeNewlinesBetweenReport (context, imported, newlinesBetweenImports) {\n-  const getLineDifference = (currentImport, previousImport) => {\n-    return currentImport.node.loc.start.line - previousImport.node.loc.start.line\n+  const getNumberOfEmptyLinesBeetwen = (currentImport, previousImport) => {","path":"src/rules/order.js","position":null,"original_position":6,"commit_id":"577ba6c50da2b3d1bf6484bddcd03b702eb0c004","original_commit_id":"2f5d2d0e92e8c9eb046131c265b8fb66d7e4ecfa","user":{"login":"singles","id":218345,"avatar_url":"https://avatars.githubusercontent.com/u/218345?v=3","gravatar_id":"","url":"https://api.github.com/users/singles","html_url":"https://github.com/singles","followers_url":"https://api.github.com/users/singles/followers","following_url":"https://api.github.com/users/singles/following{/other_user}","gists_url":"https://api.github.com/users/singles/gists{/gist_id}","starred_url":"https://api.github.com/users/singles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singles/subscriptions","organizations_url":"https://api.github.com/users/singles/orgs","repos_url":"https://api.github.com/users/singles/repos","events_url":"https://api.github.com/users/singles/events{/privacy}","received_events_url":"https://api.github.com/users/singles/received_events","type":"User","site_admin":false},"body":"Thx, fixed.","created_at":"2016-05-14T07:33:35Z","updated_at":"2016-05-14T07:33:35Z","html_url":"https://github.com/benmosher/eslint-plugin-import/pull/339#discussion_r63272637","pull_request_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/339","_links":{"self":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/comments/63272637"},"html":{"href":"https://github.com/benmosher/eslint-plugin-import/pull/339#discussion_r63272637"},"pull_request":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/339"}}},"pull_request":{"url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/339","id":70032000,"html_url":"https://github.com/benmosher/eslint-plugin-import/pull/339","diff_url":"https://github.com/benmosher/eslint-plugin-import/pull/339.diff","patch_url":"https://github.com/benmosher/eslint-plugin-import/pull/339.patch","issue_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/339","number":339,"state":"open","locked":false,"title":"Fix order's `newlines-between` edge cases","user":{"login":"singles","id":218345,"avatar_url":"https://avatars.githubusercontent.com/u/218345?v=3","gravatar_id":"","url":"https://api.github.com/users/singles","html_url":"https://github.com/singles","followers_url":"https://api.github.com/users/singles/followers","following_url":"https://api.github.com/users/singles/following{/other_user}","gists_url":"https://api.github.com/users/singles/gists{/gist_id}","starred_url":"https://api.github.com/users/singles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singles/subscriptions","organizations_url":"https://api.github.com/users/singles/orgs","repos_url":"https://api.github.com/users/singles/repos","events_url":"https://api.github.com/users/singles/events{/privacy}","received_events_url":"https://api.github.com/users/singles/received_events","type":"User","site_admin":false},"body":"Fixes all issues mentioned in #313:\r\n\r\n1. Empty lines between multiline import statements are detected correctly.\r\n2. Not assigned imports are ignored (see comments).\r\n3. `require` used inside objects are ignored.\r\n\r\nIt also changes requirement - there's no specific limit about 1 empty line between groups. Now it has to be **at least** 1. If one would like to have only one, then `no-multiple-empty-lines` core rule can be used (thx @lo1tuma for hint!).\r\n\r\nI'm not 100% sure about implementation for last one - it works for provided test cases, yet I could use another pair of eyes. ","created_at":"2016-05-13T17:37:35Z","updated_at":"2016-05-14T07:33:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04140f57bca3fe50d8555ba9851226f4c6822c26","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/339/commits","review_comments_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/339/comments","review_comment_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/339/comments","statuses_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/statuses/577ba6c50da2b3d1bf6484bddcd03b702eb0c004","head":{"label":"singles:fix-order-newline-edge-cases","ref":"fix-order-newline-edge-cases","sha":"577ba6c50da2b3d1bf6484bddcd03b702eb0c004","user":{"login":"singles","id":218345,"avatar_url":"https://avatars.githubusercontent.com/u/218345?v=3","gravatar_id":"","url":"https://api.github.com/users/singles","html_url":"https://github.com/singles","followers_url":"https://api.github.com/users/singles/followers","following_url":"https://api.github.com/users/singles/following{/other_user}","gists_url":"https://api.github.com/users/singles/gists{/gist_id}","starred_url":"https://api.github.com/users/singles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singles/subscriptions","organizations_url":"https://api.github.com/users/singles/orgs","repos_url":"https://api.github.com/users/singles/repos","events_url":"https://api.github.com/users/singles/events{/privacy}","received_events_url":"https://api.github.com/users/singles/received_events","type":"User","site_admin":false},"repo":{"id":55622315,"name":"eslint-plugin-import","full_name":"singles/eslint-plugin-import","owner":{"login":"singles","id":218345,"avatar_url":"https://avatars.githubusercontent.com/u/218345?v=3","gravatar_id":"","url":"https://api.github.com/users/singles","html_url":"https://github.com/singles","followers_url":"https://api.github.com/users/singles/followers","following_url":"https://api.github.com/users/singles/following{/other_user}","gists_url":"https://api.github.com/users/singles/gists{/gist_id}","starred_url":"https://api.github.com/users/singles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singles/subscriptions","organizations_url":"https://api.github.com/users/singles/orgs","repos_url":"https://api.github.com/users/singles/repos","events_url":"https://api.github.com/users/singles/events{/privacy}","received_events_url":"https://api.github.com/users/singles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/singles/eslint-plugin-import","description":"ESLint plugin with rules that help validate proper imports.","fork":true,"url":"https://api.github.com/repos/singles/eslint-plugin-import","forks_url":"https://api.github.com/repos/singles/eslint-plugin-import/forks","keys_url":"https://api.github.com/repos/singles/eslint-plugin-import/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singles/eslint-plugin-import/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singles/eslint-plugin-import/teams","hooks_url":"https://api.github.com/repos/singles/eslint-plugin-import/hooks","issue_events_url":"https://api.github.com/repos/singles/eslint-plugin-import/issues/events{/number}","events_url":"https://api.github.com/repos/singles/eslint-plugin-import/events","assignees_url":"https://api.github.com/repos/singles/eslint-plugin-import/assignees{/user}","branches_url":"https://api.github.com/repos/singles/eslint-plugin-import/branches{/branch}","tags_url":"https://api.github.com/repos/singles/eslint-plugin-import/tags","blobs_url":"https://api.github.com/repos/singles/eslint-plugin-import/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singles/eslint-plugin-import/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singles/eslint-plugin-import/git/refs{/sha}","trees_url":"https://api.github.com/repos/singles/eslint-plugin-import/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singles/eslint-plugin-import/statuses/{sha}","languages_url":"https://api.github.com/repos/singles/eslint-plugin-import/languages","stargazers_url":"https://api.github.com/repos/singles/eslint-plugin-import/stargazers","contributors_url":"https://api.github.com/repos/singles/eslint-plugin-import/contributors","subscribers_url":"https://api.github.com/repos/singles/eslint-plugin-import/subscribers","subscription_url":"https://api.github.com/repos/singles/eslint-plugin-import/subscription","commits_url":"https://api.github.com/repos/singles/eslint-plugin-import/commits{/sha}","git_commits_url":"https://api.github.com/repos/singles/eslint-plugin-import/git/commits{/sha}","comments_url":"https://api.github.com/repos/singles/eslint-plugin-import/comments{/number}","issue_comment_url":"https://api.github.com/repos/singles/eslint-plugin-import/issues/comments{/number}","contents_url":"https://api.github.com/repos/singles/eslint-plugin-import/contents/{+path}","compare_url":"https://api.github.com/repos/singles/eslint-plugin-import/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singles/eslint-plugin-import/merges","archive_url":"https://api.github.com/repos/singles/eslint-plugin-import/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singles/eslint-plugin-import/downloads","issues_url":"https://api.github.com/repos/singles/eslint-plugin-import/issues{/number}","pulls_url":"https://api.github.com/repos/singles/eslint-plugin-import/pulls{/number}","milestones_url":"https://api.github.com/repos/singles/eslint-plugin-import/milestones{/number}","notifications_url":"https://api.github.com/repos/singles/eslint-plugin-import/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singles/eslint-plugin-import/labels{/name}","releases_url":"https://api.github.com/repos/singles/eslint-plugin-import/releases{/id}","deployments_url":"https://api.github.com/repos/singles/eslint-plugin-import/deployments","created_at":"2016-04-06T16:28:53Z","updated_at":"2016-04-06T16:28:54Z","pushed_at":"2016-05-14T07:32:25Z","git_url":"git://github.com/singles/eslint-plugin-import.git","ssh_url":"git@github.com:singles/eslint-plugin-import.git","clone_url":"https://github.com/singles/eslint-plugin-import.git","svn_url":"https://github.com/singles/eslint-plugin-import","homepage":null,"size":655,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"benmosher:master","ref":"master","sha":"5bdd443c7bb35a0d829779802d862bd60d4411f9","user":{"login":"benmosher","id":3709196,"avatar_url":"https://avatars.githubusercontent.com/u/3709196?v=3","gravatar_id":"","url":"https://api.github.com/users/benmosher","html_url":"https://github.com/benmosher","followers_url":"https://api.github.com/users/benmosher/followers","following_url":"https://api.github.com/users/benmosher/following{/other_user}","gists_url":"https://api.github.com/users/benmosher/gists{/gist_id}","starred_url":"https://api.github.com/users/benmosher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmosher/subscriptions","organizations_url":"https://api.github.com/users/benmosher/orgs","repos_url":"https://api.github.com/users/benmosher/repos","events_url":"https://api.github.com/users/benmosher/events{/privacy}","received_events_url":"https://api.github.com/users/benmosher/received_events","type":"User","site_admin":false},"repo":{"id":32238354,"name":"eslint-plugin-import","full_name":"benmosher/eslint-plugin-import","owner":{"login":"benmosher","id":3709196,"avatar_url":"https://avatars.githubusercontent.com/u/3709196?v=3","gravatar_id":"","url":"https://api.github.com/users/benmosher","html_url":"https://github.com/benmosher","followers_url":"https://api.github.com/users/benmosher/followers","following_url":"https://api.github.com/users/benmosher/following{/other_user}","gists_url":"https://api.github.com/users/benmosher/gists{/gist_id}","starred_url":"https://api.github.com/users/benmosher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmosher/subscriptions","organizations_url":"https://api.github.com/users/benmosher/orgs","repos_url":"https://api.github.com/users/benmosher/repos","events_url":"https://api.github.com/users/benmosher/events{/privacy}","received_events_url":"https://api.github.com/users/benmosher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benmosher/eslint-plugin-import","description":"ESLint plugin with rules that help validate proper imports.","fork":false,"url":"https://api.github.com/repos/benmosher/eslint-plugin-import","forks_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/forks","keys_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/teams","hooks_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/hooks","issue_events_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/events{/number}","events_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/events","assignees_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/assignees{/user}","branches_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/branches{/branch}","tags_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/tags","blobs_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/refs{/sha}","trees_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/statuses/{sha}","languages_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/languages","stargazers_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/stargazers","contributors_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/contributors","subscribers_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/subscribers","subscription_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/subscription","commits_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/commits{/sha}","git_commits_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/commits{/sha}","comments_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/comments{/number}","issue_comment_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/comments{/number}","contents_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/contents/{+path}","compare_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/merges","archive_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/downloads","issues_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues{/number}","pulls_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls{/number}","milestones_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/milestones{/number}","notifications_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/labels{/name}","releases_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/releases{/id}","deployments_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/deployments","created_at":"2015-03-15T00:21:57Z","updated_at":"2016-05-14T03:23:49Z","pushed_at":"2016-05-14T07:32:26Z","git_url":"git://github.com/benmosher/eslint-plugin-import.git","ssh_url":"git@github.com:benmosher/eslint-plugin-import.git","clone_url":"https://github.com/benmosher/eslint-plugin-import.git","svn_url":"https://github.com/benmosher/eslint-plugin-import","homepage":null,"size":761,"stargazers_count":237,"watchers_count":237,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":49,"forks":37,"open_issues":49,"watchers":237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/339"},"html":{"href":"https://github.com/benmosher/eslint-plugin-import/pull/339"},"issue":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/339"},"comments":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/statuses/577ba6c50da2b3d1bf6484bddcd03b702eb0c004"}}}}