{"action":"created","comment":{"url":"https://api.github.com/repos/adjust/istore/pulls/comments/71582692","id":71582692,"diff_hunk":"@@ -210,17 +220,21 @@ CREATE AGGREGATE SUM (\n     sfunc = istore_sum_transfn,\n     basetype = istore,\n     stype = internal,\n-    finalfunc = istore_sum_finalfn\n+    finalfunc = istore_agg_finalfn\n );\n \n-CREATE AGGREGATE MIN(istore) (\n-    sfunc = istore_val_smaller,\n-    stype = istore\n+CREATE AGGREGATE MIN (\n+    sfunc = istore_min_transfn,\n+    basetype = istore,\n+    stype = internal,\n+    finalfunc = istore_agg_finalfn","path":"istore--0.1.2.sql","position":46,"original_position":46,"commit_id":"1482e2f7a6bb18f778da5ede71b8812511c8bd2e","original_commit_id":"1482e2f7a6bb18f778da5ede71b8812511c8bd2e","user":{"login":"rapimo","id":165142,"avatar_url":"https://avatars.githubusercontent.com/u/165142?v=3","gravatar_id":"","url":"https://api.github.com/users/rapimo","html_url":"https://github.com/rapimo","followers_url":"https://api.github.com/users/rapimo/followers","following_url":"https://api.github.com/users/rapimo/following{/other_user}","gists_url":"https://api.github.com/users/rapimo/gists{/gist_id}","starred_url":"https://api.github.com/users/rapimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapimo/subscriptions","organizations_url":"https://api.github.com/users/rapimo/orgs","repos_url":"https://api.github.com/users/rapimo/repos","events_url":"https://api.github.com/users/rapimo/events{/privacy}","received_events_url":"https://api.github.com/users/rapimo/received_events","type":"User","site_admin":false},"body":"so MIN/MAX(istore) returns bigistore ? Is that what we want?","created_at":"2016-07-20T18:41:03Z","updated_at":"2016-07-20T18:41:03Z","html_url":"https://github.com/adjust/istore/pull/55#discussion_r71582692","pull_request_url":"https://api.github.com/repos/adjust/istore/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/adjust/istore/pulls/comments/71582692"},"html":{"href":"https://github.com/adjust/istore/pull/55#discussion_r71582692"},"pull_request":{"href":"https://api.github.com/repos/adjust/istore/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/adjust/istore/pulls/55","id":78192950,"html_url":"https://github.com/adjust/istore/pull/55","diff_url":"https://github.com/adjust/istore/pull/55.diff","patch_url":"https://github.com/adjust/istore/pull/55.patch","issue_url":"https://api.github.com/repos/adjust/istore/issues/55","number":55,"state":"open","locked":false,"title":"Refactor MIN/MAX aggregate functions for istore and bigistore","user":{"login":"chochkov","id":397854,"avatar_url":"https://avatars.githubusercontent.com/u/397854?v=3","gravatar_id":"","url":"https://api.github.com/users/chochkov","html_url":"https://github.com/chochkov","followers_url":"https://api.github.com/users/chochkov/followers","following_url":"https://api.github.com/users/chochkov/following{/other_user}","gists_url":"https://api.github.com/users/chochkov/gists{/gist_id}","starred_url":"https://api.github.com/users/chochkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chochkov/subscriptions","organizations_url":"https://api.github.com/users/chochkov/orgs","repos_url":"https://api.github.com/users/chochkov/repos","events_url":"https://api.github.com/users/chochkov/events{/privacy}","received_events_url":"https://api.github.com/users/chochkov/received_events","type":"User","site_admin":false},"body":"Introduces custom transition state to MAX/MIN the same as on the SUM aggregate.\r\n\r\n@rapimo as discussed this implements the base branch approach to MAX/MIN. I managed to reproduce the performance increase with an average `180ms` for version `0.1.1` over ~ 260K istores v.s. average of `102ms` for version `0.1.2` over the same set.\r\n\r\n","created_at":"2016-07-20T18:09:17Z","updated_at":"2016-07-20T18:41:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39324851dae5f110906b5808892bde4d92bdd8e7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/adjust/istore/pulls/55/commits","review_comments_url":"https://api.github.com/repos/adjust/istore/pulls/55/comments","review_comment_url":"https://api.github.com/repos/adjust/istore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adjust/istore/issues/55/comments","statuses_url":"https://api.github.com/repos/adjust/istore/statuses/1482e2f7a6bb18f778da5ede71b8812511c8bd2e","head":{"label":"adjust:agg_performance_min_max","ref":"agg_performance_min_max","sha":"1482e2f7a6bb18f778da5ede71b8812511c8bd2e","user":{"login":"adjust","id":1327203,"avatar_url":"https://avatars.githubusercontent.com/u/1327203?v=3","gravatar_id":"","url":"https://api.github.com/users/adjust","html_url":"https://github.com/adjust","followers_url":"https://api.github.com/users/adjust/followers","following_url":"https://api.github.com/users/adjust/following{/other_user}","gists_url":"https://api.github.com/users/adjust/gists{/gist_id}","starred_url":"https://api.github.com/users/adjust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjust/subscriptions","organizations_url":"https://api.github.com/users/adjust/orgs","repos_url":"https://api.github.com/users/adjust/repos","events_url":"https://api.github.com/users/adjust/events{/privacy}","received_events_url":"https://api.github.com/users/adjust/received_events","type":"Organization","site_admin":false},"repo":{"id":20890217,"name":"istore","full_name":"adjust/istore","owner":{"login":"adjust","id":1327203,"avatar_url":"https://avatars.githubusercontent.com/u/1327203?v=3","gravatar_id":"","url":"https://api.github.com/users/adjust","html_url":"https://github.com/adjust","followers_url":"https://api.github.com/users/adjust/followers","following_url":"https://api.github.com/users/adjust/following{/other_user}","gists_url":"https://api.github.com/users/adjust/gists{/gist_id}","starred_url":"https://api.github.com/users/adjust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjust/subscriptions","organizations_url":"https://api.github.com/users/adjust/orgs","repos_url":"https://api.github.com/users/adjust/repos","events_url":"https://api.github.com/users/adjust/events{/privacy}","received_events_url":"https://api.github.com/users/adjust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adjust/istore","description":"development repo for integer hstore replacement in postgres","fork":false,"url":"https://api.github.com/repos/adjust/istore","forks_url":"https://api.github.com/repos/adjust/istore/forks","keys_url":"https://api.github.com/repos/adjust/istore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adjust/istore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adjust/istore/teams","hooks_url":"https://api.github.com/repos/adjust/istore/hooks","issue_events_url":"https://api.github.com/repos/adjust/istore/issues/events{/number}","events_url":"https://api.github.com/repos/adjust/istore/events","assignees_url":"https://api.github.com/repos/adjust/istore/assignees{/user}","branches_url":"https://api.github.com/repos/adjust/istore/branches{/branch}","tags_url":"https://api.github.com/repos/adjust/istore/tags","blobs_url":"https://api.github.com/repos/adjust/istore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adjust/istore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adjust/istore/git/refs{/sha}","trees_url":"https://api.github.com/repos/adjust/istore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adjust/istore/statuses/{sha}","languages_url":"https://api.github.com/repos/adjust/istore/languages","stargazers_url":"https://api.github.com/repos/adjust/istore/stargazers","contributors_url":"https://api.github.com/repos/adjust/istore/contributors","subscribers_url":"https://api.github.com/repos/adjust/istore/subscribers","subscription_url":"https://api.github.com/repos/adjust/istore/subscription","commits_url":"https://api.github.com/repos/adjust/istore/commits{/sha}","git_commits_url":"https://api.github.com/repos/adjust/istore/git/commits{/sha}","comments_url":"https://api.github.com/repos/adjust/istore/comments{/number}","issue_comment_url":"https://api.github.com/repos/adjust/istore/issues/comments{/number}","contents_url":"https://api.github.com/repos/adjust/istore/contents/{+path}","compare_url":"https://api.github.com/repos/adjust/istore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adjust/istore/merges","archive_url":"https://api.github.com/repos/adjust/istore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adjust/istore/downloads","issues_url":"https://api.github.com/repos/adjust/istore/issues{/number}","pulls_url":"https://api.github.com/repos/adjust/istore/pulls{/number}","milestones_url":"https://api.github.com/repos/adjust/istore/milestones{/number}","notifications_url":"https://api.github.com/repos/adjust/istore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adjust/istore/labels{/name}","releases_url":"https://api.github.com/repos/adjust/istore/releases{/id}","deployments_url":"https://api.github.com/repos/adjust/istore/deployments","created_at":"2014-06-16T15:34:17Z","updated_at":"2016-06-14T15:49:15Z","pushed_at":"2016-07-20T18:09:17Z","git_url":"git://github.com/adjust/istore.git","ssh_url":"git@github.com:adjust/istore.git","clone_url":"https://github.com/adjust/istore.git","svn_url":"https://github.com/adjust/istore","homepage":null,"size":607,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"adjust:agg_performance","ref":"agg_performance","sha":"ce3ac7839ea779019b45b99ccdde9795fe476164","user":{"login":"adjust","id":1327203,"avatar_url":"https://avatars.githubusercontent.com/u/1327203?v=3","gravatar_id":"","url":"https://api.github.com/users/adjust","html_url":"https://github.com/adjust","followers_url":"https://api.github.com/users/adjust/followers","following_url":"https://api.github.com/users/adjust/following{/other_user}","gists_url":"https://api.github.com/users/adjust/gists{/gist_id}","starred_url":"https://api.github.com/users/adjust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjust/subscriptions","organizations_url":"https://api.github.com/users/adjust/orgs","repos_url":"https://api.github.com/users/adjust/repos","events_url":"https://api.github.com/users/adjust/events{/privacy}","received_events_url":"https://api.github.com/users/adjust/received_events","type":"Organization","site_admin":false},"repo":{"id":20890217,"name":"istore","full_name":"adjust/istore","owner":{"login":"adjust","id":1327203,"avatar_url":"https://avatars.githubusercontent.com/u/1327203?v=3","gravatar_id":"","url":"https://api.github.com/users/adjust","html_url":"https://github.com/adjust","followers_url":"https://api.github.com/users/adjust/followers","following_url":"https://api.github.com/users/adjust/following{/other_user}","gists_url":"https://api.github.com/users/adjust/gists{/gist_id}","starred_url":"https://api.github.com/users/adjust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjust/subscriptions","organizations_url":"https://api.github.com/users/adjust/orgs","repos_url":"https://api.github.com/users/adjust/repos","events_url":"https://api.github.com/users/adjust/events{/privacy}","received_events_url":"https://api.github.com/users/adjust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adjust/istore","description":"development repo for integer hstore replacement in postgres","fork":false,"url":"https://api.github.com/repos/adjust/istore","forks_url":"https://api.github.com/repos/adjust/istore/forks","keys_url":"https://api.github.com/repos/adjust/istore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adjust/istore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adjust/istore/teams","hooks_url":"https://api.github.com/repos/adjust/istore/hooks","issue_events_url":"https://api.github.com/repos/adjust/istore/issues/events{/number}","events_url":"https://api.github.com/repos/adjust/istore/events","assignees_url":"https://api.github.com/repos/adjust/istore/assignees{/user}","branches_url":"https://api.github.com/repos/adjust/istore/branches{/branch}","tags_url":"https://api.github.com/repos/adjust/istore/tags","blobs_url":"https://api.github.com/repos/adjust/istore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adjust/istore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adjust/istore/git/refs{/sha}","trees_url":"https://api.github.com/repos/adjust/istore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adjust/istore/statuses/{sha}","languages_url":"https://api.github.com/repos/adjust/istore/languages","stargazers_url":"https://api.github.com/repos/adjust/istore/stargazers","contributors_url":"https://api.github.com/repos/adjust/istore/contributors","subscribers_url":"https://api.github.com/repos/adjust/istore/subscribers","subscription_url":"https://api.github.com/repos/adjust/istore/subscription","commits_url":"https://api.github.com/repos/adjust/istore/commits{/sha}","git_commits_url":"https://api.github.com/repos/adjust/istore/git/commits{/sha}","comments_url":"https://api.github.com/repos/adjust/istore/comments{/number}","issue_comment_url":"https://api.github.com/repos/adjust/istore/issues/comments{/number}","contents_url":"https://api.github.com/repos/adjust/istore/contents/{+path}","compare_url":"https://api.github.com/repos/adjust/istore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adjust/istore/merges","archive_url":"https://api.github.com/repos/adjust/istore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adjust/istore/downloads","issues_url":"https://api.github.com/repos/adjust/istore/issues{/number}","pulls_url":"https://api.github.com/repos/adjust/istore/pulls{/number}","milestones_url":"https://api.github.com/repos/adjust/istore/milestones{/number}","notifications_url":"https://api.github.com/repos/adjust/istore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adjust/istore/labels{/name}","releases_url":"https://api.github.com/repos/adjust/istore/releases{/id}","deployments_url":"https://api.github.com/repos/adjust/istore/deployments","created_at":"2014-06-16T15:34:17Z","updated_at":"2016-06-14T15:49:15Z","pushed_at":"2016-07-20T18:09:17Z","git_url":"git://github.com/adjust/istore.git","ssh_url":"git@github.com:adjust/istore.git","clone_url":"https://github.com/adjust/istore.git","svn_url":"https://github.com/adjust/istore","homepage":null,"size":607,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adjust/istore/pulls/55"},"html":{"href":"https://github.com/adjust/istore/pull/55"},"issue":{"href":"https://api.github.com/repos/adjust/istore/issues/55"},"comments":{"href":"https://api.github.com/repos/adjust/istore/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/adjust/istore/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/adjust/istore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adjust/istore/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/adjust/istore/statuses/1482e2f7a6bb18f778da5ede71b8812511c8bd2e"}}}}
{"actor":{"display_login":"rapimo"}}