{"action":"created","comment":{"url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/comments/58313773","id":58313773,"diff_hunk":"@@ -0,0 +1,74 @@\n+package org.testcontainers.junit;\n+\n+import com.github.dockerjava.api.command.BuildImageCmd;\n+import org.junit.Test;\n+import org.testcontainers.containers.GenericContainer;\n+import org.testcontainers.images.builder.ImageFromDockerfile;\n+\n+import java.util.Arrays;\n+import java.util.List;\n+\n+import static org.rnorth.visibleassertions.VisibleAssertions.pass;\n+\n+public class DockerfileTest {","path":"core/src/test/java/org/testcontainers/junit/DockerfileTest.java","position":13,"original_position":13,"commit_id":"5fe50bd788abc60387d8883af4d8fde05a511a30","original_commit_id":"5fe50bd788abc60387d8883af4d8fde05a511a30","user":{"login":"bsideup","id":1050762,"avatar_url":"https://avatars.githubusercontent.com/u/1050762?v=3","gravatar_id":"","url":"https://api.github.com/users/bsideup","html_url":"https://github.com/bsideup","followers_url":"https://api.github.com/users/bsideup/followers","following_url":"https://api.github.com/users/bsideup/following{/other_user}","gists_url":"https://api.github.com/users/bsideup/gists{/gist_id}","starred_url":"https://api.github.com/users/bsideup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsideup/subscriptions","organizations_url":"https://api.github.com/users/bsideup/orgs","repos_url":"https://api.github.com/users/bsideup/repos","events_url":"https://api.github.com/users/bsideup/events{/privacy}","received_events_url":"https://api.github.com/users/bsideup/received_events","type":"User","site_admin":false},"body":"tests for Dockerfile itself will be provided separately as Unit tests with string-based comparation","created_at":"2016-04-03T17:19:41Z","updated_at":"2016-04-03T17:19:41Z","html_url":"https://github.com/testcontainers/testcontainers-java/pull/119#discussion_r58313773","pull_request_url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/comments/58313773"},"html":{"href":"https://github.com/testcontainers/testcontainers-java/pull/119#discussion_r58313773"},"pull_request":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/119"}}},"pull_request":{"url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/119","id":65073990,"html_url":"https://github.com/testcontainers/testcontainers-java/pull/119","diff_url":"https://github.com/testcontainers/testcontainers-java/pull/119.diff","patch_url":"https://github.com/testcontainers/testcontainers-java/pull/119.patch","issue_url":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/119","number":119,"state":"open","locked":false,"title":"Basic Dockerfile support (WIP)","user":{"login":"bsideup","id":1050762,"avatar_url":"https://avatars.githubusercontent.com/u/1050762?v=3","gravatar_id":"","url":"https://api.github.com/users/bsideup","html_url":"https://github.com/bsideup","followers_url":"https://api.github.com/users/bsideup/followers","following_url":"https://api.github.com/users/bsideup/following{/other_user}","gists_url":"https://api.github.com/users/bsideup/gists{/gist_id}","starred_url":"https://api.github.com/users/bsideup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsideup/subscriptions","organizations_url":"https://api.github.com/users/bsideup/orgs","repos_url":"https://api.github.com/users/bsideup/repos","events_url":"https://api.github.com/users/bsideup/events{/privacy}","received_events_url":"https://api.github.com/users/bsideup/received_events","type":"User","site_admin":false},"body":"this PR provides basic functionality to build Docker images during the test run. \r\n\r\nSome refactorings were performed:\r\n\r\n1. GenericContainer - docker image name as `Future<String>`\r\n1. DockerLoggerFactory was extracted to make it possible to reuse cool :whale:-based logger\r\n1. Brand-new way of implementing Builder pattern - please, leave your feedback about it , I would like to hear :) It implements self-referencing and allows to implement different building methods in different files\r\n\r\nCurrently supported Dockerfile statements:\r\n- ADD\r\n- CMD\r\n- COPY\r\n- ENV\r\n- EXPOSE\r\n- FROM\r\n- LABEL\r\n- RUN\r\n- WORKDIR\r\n\r\nOthers will be implemented as well (soon)\r\n\r\nPlease see `DockerfileTest` for example usage.","created_at":"2016-04-03T17:07:09Z","updated_at":"2016-04-03T17:19:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3406a7ffc31a81c70f3dbc66ffeb7f52ce5e30b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/119/commits","review_comments_url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/119/comments","review_comment_url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/119/comments","statuses_url":"https://api.github.com/repos/testcontainers/testcontainers-java/statuses/5fe50bd788abc60387d8883af4d8fde05a511a30","head":{"label":"zeroturnaround:feature/dockerfile","ref":"feature/dockerfile","sha":"5fe50bd788abc60387d8883af4d8fde05a511a30","user":{"login":"zeroturnaround","id":1213260,"avatar_url":"https://avatars.githubusercontent.com/u/1213260?v=3","gravatar_id":"","url":"https://api.github.com/users/zeroturnaround","html_url":"https://github.com/zeroturnaround","followers_url":"https://api.github.com/users/zeroturnaround/followers","following_url":"https://api.github.com/users/zeroturnaround/following{/other_user}","gists_url":"https://api.github.com/users/zeroturnaround/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroturnaround/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroturnaround/subscriptions","organizations_url":"https://api.github.com/users/zeroturnaround/orgs","repos_url":"https://api.github.com/users/zeroturnaround/repos","events_url":"https://api.github.com/users/zeroturnaround/events{/privacy}","received_events_url":"https://api.github.com/users/zeroturnaround/received_events","type":"Organization","site_admin":false},"repo":{"id":54567968,"name":"testcontainers-java","full_name":"zeroturnaround/testcontainers-java","owner":{"login":"zeroturnaround","id":1213260,"avatar_url":"https://avatars.githubusercontent.com/u/1213260?v=3","gravatar_id":"","url":"https://api.github.com/users/zeroturnaround","html_url":"https://github.com/zeroturnaround","followers_url":"https://api.github.com/users/zeroturnaround/followers","following_url":"https://api.github.com/users/zeroturnaround/following{/other_user}","gists_url":"https://api.github.com/users/zeroturnaround/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroturnaround/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroturnaround/subscriptions","organizations_url":"https://api.github.com/users/zeroturnaround/orgs","repos_url":"https://api.github.com/users/zeroturnaround/repos","events_url":"https://api.github.com/users/zeroturnaround/events{/privacy}","received_events_url":"https://api.github.com/users/zeroturnaround/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeroturnaround/testcontainers-java","description":"TestContainers is a Java 8 library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.","fork":true,"url":"https://api.github.com/repos/zeroturnaround/testcontainers-java","forks_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/forks","keys_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/teams","hooks_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/hooks","issue_events_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/issues/events{/number}","events_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/events","assignees_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/assignees{/user}","branches_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/branches{/branch}","tags_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/tags","blobs_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/statuses/{sha}","languages_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/languages","stargazers_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/stargazers","contributors_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/contributors","subscribers_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/subscribers","subscription_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/subscription","commits_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/contents/{+path}","compare_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/merges","archive_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/downloads","issues_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/issues{/number}","pulls_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/pulls{/number}","milestones_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/milestones{/number}","notifications_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/labels{/name}","releases_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/releases{/id}","deployments_url":"https://api.github.com/repos/zeroturnaround/testcontainers-java/deployments","created_at":"2016-03-23T14:48:08Z","updated_at":"2016-03-23T14:48:09Z","pushed_at":"2016-04-03T17:03:24Z","git_url":"git://github.com/zeroturnaround/testcontainers-java.git","ssh_url":"git@github.com:zeroturnaround/testcontainers-java.git","clone_url":"https://github.com/zeroturnaround/testcontainers-java.git","svn_url":"https://github.com/zeroturnaround/testcontainers-java","homepage":"","size":569,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"testcontainers:master","ref":"master","sha":"1e9d586a178fdb96a738832b72bd65f73d108212","user":{"login":"testcontainers","id":13393021,"avatar_url":"https://avatars.githubusercontent.com/u/13393021?v=3","gravatar_id":"","url":"https://api.github.com/users/testcontainers","html_url":"https://github.com/testcontainers","followers_url":"https://api.github.com/users/testcontainers/followers","following_url":"https://api.github.com/users/testcontainers/following{/other_user}","gists_url":"https://api.github.com/users/testcontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/testcontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/testcontainers/subscriptions","organizations_url":"https://api.github.com/users/testcontainers/orgs","repos_url":"https://api.github.com/users/testcontainers/repos","events_url":"https://api.github.com/users/testcontainers/events{/privacy}","received_events_url":"https://api.github.com/users/testcontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":33816473,"name":"testcontainers-java","full_name":"testcontainers/testcontainers-java","owner":{"login":"testcontainers","id":13393021,"avatar_url":"https://avatars.githubusercontent.com/u/13393021?v=3","gravatar_id":"","url":"https://api.github.com/users/testcontainers","html_url":"https://github.com/testcontainers","followers_url":"https://api.github.com/users/testcontainers/followers","following_url":"https://api.github.com/users/testcontainers/following{/other_user}","gists_url":"https://api.github.com/users/testcontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/testcontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/testcontainers/subscriptions","organizations_url":"https://api.github.com/users/testcontainers/orgs","repos_url":"https://api.github.com/users/testcontainers/repos","events_url":"https://api.github.com/users/testcontainers/events{/privacy}","received_events_url":"https://api.github.com/users/testcontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/testcontainers/testcontainers-java","description":"TestContainers is a Java 8 library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.","fork":false,"url":"https://api.github.com/repos/testcontainers/testcontainers-java","forks_url":"https://api.github.com/repos/testcontainers/testcontainers-java/forks","keys_url":"https://api.github.com/repos/testcontainers/testcontainers-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/testcontainers/testcontainers-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/testcontainers/testcontainers-java/teams","hooks_url":"https://api.github.com/repos/testcontainers/testcontainers-java/hooks","issue_events_url":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/events{/number}","events_url":"https://api.github.com/repos/testcontainers/testcontainers-java/events","assignees_url":"https://api.github.com/repos/testcontainers/testcontainers-java/assignees{/user}","branches_url":"https://api.github.com/repos/testcontainers/testcontainers-java/branches{/branch}","tags_url":"https://api.github.com/repos/testcontainers/testcontainers-java/tags","blobs_url":"https://api.github.com/repos/testcontainers/testcontainers-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/testcontainers/testcontainers-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/testcontainers/testcontainers-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/testcontainers/testcontainers-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/testcontainers/testcontainers-java/statuses/{sha}","languages_url":"https://api.github.com/repos/testcontainers/testcontainers-java/languages","stargazers_url":"https://api.github.com/repos/testcontainers/testcontainers-java/stargazers","contributors_url":"https://api.github.com/repos/testcontainers/testcontainers-java/contributors","subscribers_url":"https://api.github.com/repos/testcontainers/testcontainers-java/subscribers","subscription_url":"https://api.github.com/repos/testcontainers/testcontainers-java/subscription","commits_url":"https://api.github.com/repos/testcontainers/testcontainers-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/testcontainers/testcontainers-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/testcontainers/testcontainers-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/testcontainers/testcontainers-java/contents/{+path}","compare_url":"https://api.github.com/repos/testcontainers/testcontainers-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/testcontainers/testcontainers-java/merges","archive_url":"https://api.github.com/repos/testcontainers/testcontainers-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/testcontainers/testcontainers-java/downloads","issues_url":"https://api.github.com/repos/testcontainers/testcontainers-java/issues{/number}","pulls_url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls{/number}","milestones_url":"https://api.github.com/repos/testcontainers/testcontainers-java/milestones{/number}","notifications_url":"https://api.github.com/repos/testcontainers/testcontainers-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/testcontainers/testcontainers-java/labels{/name}","releases_url":"https://api.github.com/repos/testcontainers/testcontainers-java/releases{/id}","deployments_url":"https://api.github.com/repos/testcontainers/testcontainers-java/deployments","created_at":"2015-04-12T12:44:59Z","updated_at":"2016-04-03T02:42:33Z","pushed_at":"2016-04-03T17:07:09Z","git_url":"git://github.com/testcontainers/testcontainers-java.git","ssh_url":"git@github.com:testcontainers/testcontainers-java.git","clone_url":"https://github.com/testcontainers/testcontainers-java.git","svn_url":"https://github.com/testcontainers/testcontainers-java","homepage":"","size":3217,"stargazers_count":69,"watchers_count":69,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":19,"forks":20,"open_issues":19,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/119"},"html":{"href":"https://github.com/testcontainers/testcontainers-java/pull/119"},"issue":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/119"},"comments":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/statuses/5fe50bd788abc60387d8883af4d8fde05a511a30"}}}}