{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19879","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19879/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19879/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19879/events","html_url":"https://github.com/kubernetes/kubernetes/pull/19879","id":127763662,"number":19879,"title":"Improve the concurrency management in the service controller.","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"}],"state":"open","locked":false,"assignee":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-01-20T19:22:10Z","updated_at":"2016-01-20T20:07:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19879","html_url":"https://github.com/kubernetes/kubernetes/pull/19879","diff_url":"https://github.com/kubernetes/kubernetes/pull/19879.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/19879.patch"},"body":"This is a refactor that should fix an existing broken edge case where\r\na retried delta could get added back to the queue after an unrelated\r\nlegitimate update to the service.\r\n\r\nI was originally planning to use the keymutex class for this, but we\r\ndon't want to block our worker threads on waiting for other worker\r\nthreads, so I've used a 1-item channel as a semaphore that we can try\r\nto grab without blocking on.\r\n\r\nI've had this code sitting around for a few days while trying to get e2e tests to work at all for me, but am just giving up for the moment by opening #19878 and letting the PR builder test this for now until I can get them to run locally.\r\n\r\n@cjcullen @saad-ali"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/173345060","html_url":"https://github.com/kubernetes/kubernetes/pull/19879#issuecomment-173345060","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19879","id":173345060,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-01-20T20:07:24Z","updated_at":"2016-01-20T20:07:24Z","body":"GCE e2e build/test **failed** for commit e6d89238af968bd97f344335ccac6c51327f764f.\n* [Build Log](https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/e6d89238af968bd97f344335ccac6c51327f764f/kubernetes-pull-build-test-e2e-gce/24359/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/e6d89238af968bd97f344335ccac6c51327f764f/kubernetes-pull-build-test-e2e-gce/24359/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//24359)\n"}}