{"action":"created","comment":{"url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/comments/89544731","pull_request_review_id":10090825,"id":89544731,"diff_hunk":"@@ -22,502 +22,525 @@\n import com.yahoo.ycsb.DBException;\n import com.yahoo.ycsb.Status;\n import com.yahoo.ycsb.measurements.Measurements;\n-\n-import org.apache.hadoop.security.UserGroupInformation;\n import org.apache.hadoop.conf.Configuration;\n import org.apache.hadoop.hbase.HBaseConfiguration;\n-import org.apache.hadoop.hbase.HTableDescriptor;\n import org.apache.hadoop.hbase.KeyValue;\n-import org.apache.hadoop.hbase.client.HConnectionManager;\n-import org.apache.hadoop.hbase.client.HConnection;\n-import org.apache.hadoop.hbase.client.HTableInterface;\n-import org.apache.hadoop.hbase.client.Delete;\n-import org.apache.hadoop.hbase.client.Get;\n-import org.apache.hadoop.hbase.client.HTable;\n-import org.apache.hadoop.hbase.client.Put;\n-import org.apache.hadoop.hbase.client.Result;\n-import org.apache.hadoop.hbase.client.ResultScanner;\n-import org.apache.hadoop.hbase.client.Scan;\n-import org.apache.hadoop.hbase.filter.PageFilter;\n+import org.apache.hadoop.hbase.client.*;\n+import org.apache.hadoop.hbase.filter.*;\n import org.apache.hadoop.hbase.util.Bytes;\n+import org.apache.hadoop.security.UserGroupInformation;\n \n import java.io.IOException;\n-import java.util.ConcurrentModificationException;\n-import java.util.HashMap;\n-import java.util.HashSet;\n-import java.util.Map;\n-import java.util.Properties;\n-import java.util.Random;\n-import java.util.Set;\n-import java.util.Vector;\n+import java.util.*;\n import java.util.concurrent.atomic.AtomicInteger;\n \n /**\n  * HBase client for YCSB framework\n  */\n public class HBaseClient extends com.yahoo.ycsb.DB\n {\n-    // BFC: Change to fix broken build (with HBase 0.20.6)\n-    //private static final Configuration config = HBaseConfiguration.create();\n-    private static final Configuration config = HBaseConfiguration.create(); //new HBaseConfiguration();\n-    private static final AtomicInteger THREAD_COUNT = new AtomicInteger(0);\n-\n-    public boolean _debug=false;\n-\n-    public String _table=\"\";\n-    private static HConnection _hConn=null;\n-    public HTableInterface _hTable=null;\n-    public String _columnFamily=\"\";\n-    public byte _columnFamilyBytes[];\n-    public boolean _clientSideBuffering = false;\n-    public long _writeBufferSize = 1024 * 1024 * 12;\n-    /** Whether or not a page filter should be used to limit scan length. */\n-    public boolean _usePageFilter = true;\n-\n-    public static final int HttpError=-2;\n-","path":"hbase098/src/main/java/com/yahoo/ycsb/db/HBaseClient.java","position":68,"original_position":61,"commit_id":"35431b83bde55f10947c67f010cf8b3503c68527","original_commit_id":"3627aa03c8f6bac85e4c33131d7b9da94b6506f7","user":{"login":"ricardomacedo13","id":9079182,"avatar_url":"https://avatars.githubusercontent.com/u/9079182?v=3","gravatar_id":"","url":"https://api.github.com/users/ricardomacedo13","html_url":"https://github.com/ricardomacedo13","followers_url":"https://api.github.com/users/ricardomacedo13/followers","following_url":"https://api.github.com/users/ricardomacedo13/following{/other_user}","gists_url":"https://api.github.com/users/ricardomacedo13/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardomacedo13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardomacedo13/subscriptions","organizations_url":"https://api.github.com/users/ricardomacedo13/orgs","repos_url":"https://api.github.com/users/ricardomacedo13/repos","events_url":"https://api.github.com/users/ricardomacedo13/events{/privacy}","received_events_url":"https://api.github.com/users/ricardomacedo13/received_events","type":"User","site_admin":false},"body":"This piece of code was already in the previous versions.","created_at":"2016-11-24T20:40:11Z","updated_at":"2016-11-24T20:40:11Z","html_url":"https://github.com/brianfrankcooper/YCSB/pull/869#discussion_r89544731","pull_request_url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/869","_links":{"self":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/comments/89544731"},"html":{"href":"https://github.com/brianfrankcooper/YCSB/pull/869#discussion_r89544731"},"pull_request":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/869"}}},"pull_request":{"url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/869","id":92379420,"html_url":"https://github.com/brianfrankcooper/YCSB/pull/869","diff_url":"https://github.com/brianfrankcooper/YCSB/pull/869.diff","patch_url":"https://github.com/brianfrankcooper/YCSB/pull/869.patch","issue_url":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/869","number":869,"state":"open","locked":false,"title":"[hbase098] Add support for RowFilter's and perform Deterministic Workload","user":{"login":"ricardomacedo13","id":9079182,"avatar_url":"https://avatars.githubusercontent.com/u/9079182?v=3","gravatar_id":"","url":"https://api.github.com/users/ricardomacedo13","html_url":"https://github.com/ricardomacedo13","followers_url":"https://api.github.com/users/ricardomacedo13/followers","following_url":"https://api.github.com/users/ricardomacedo13/following{/other_user}","gists_url":"https://api.github.com/users/ricardomacedo13/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardomacedo13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardomacedo13/subscriptions","organizations_url":"https://api.github.com/users/ricardomacedo13/orgs","repos_url":"https://api.github.com/users/ricardomacedo13/repos","events_url":"https://api.github.com/users/ricardomacedo13/events{/privacy}","received_events_url":"https://api.github.com/users/ricardomacedo13/received_events","type":"User","site_admin":false},"body":"I was using this benchmark with the hbase098 client to run some tests on the project of my master thesis. I tested the four hbase operations but notice that I wasn't able to do Filters, more specifically RowFilters.\r\nThis way, I added a new operation on hbase client, being able to perform filters by row (RowFilter). It is possible to use the EQUAL, GREATER, GREATER_OR_EQUAL, LESS and LESS_OR_EQUAL operands.\r\nI also added new properties to achieve this solution:\r\n- define proportions for all comparison operands;\r\n- comparevalue, value to perform the comparisons and return the filtered results;\r\n- seed, a long to get deterministic workloads.\r\n\r\nAs referred in the title, I also added the seed property and changed the Utils.random() function, in order to achieve deterministic results, being possible to perform multiple executions and get the same results for the same seed. This way we can get more consistent measurements for and verify the behavior for the same results.","created_at":"2016-11-04T17:08:13Z","updated_at":"2016-11-24T20:40:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"771e78961231bd178034a4e97a93354553e50476","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/869/commits","review_comments_url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/869/comments","review_comment_url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/869/comments","statuses_url":"https://api.github.com/repos/brianfrankcooper/YCSB/statuses/35431b83bde55f10947c67f010cf8b3503c68527","head":{"label":"ricardomacedo13:master","ref":"master","sha":"35431b83bde55f10947c67f010cf8b3503c68527","user":{"login":"ricardomacedo13","id":9079182,"avatar_url":"https://avatars.githubusercontent.com/u/9079182?v=3","gravatar_id":"","url":"https://api.github.com/users/ricardomacedo13","html_url":"https://github.com/ricardomacedo13","followers_url":"https://api.github.com/users/ricardomacedo13/followers","following_url":"https://api.github.com/users/ricardomacedo13/following{/other_user}","gists_url":"https://api.github.com/users/ricardomacedo13/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardomacedo13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardomacedo13/subscriptions","organizations_url":"https://api.github.com/users/ricardomacedo13/orgs","repos_url":"https://api.github.com/users/ricardomacedo13/repos","events_url":"https://api.github.com/users/ricardomacedo13/events{/privacy}","received_events_url":"https://api.github.com/users/ricardomacedo13/received_events","type":"User","site_admin":false},"repo":{"id":72186814,"name":"YCSB","full_name":"ricardomacedo13/YCSB","owner":{"login":"ricardomacedo13","id":9079182,"avatar_url":"https://avatars.githubusercontent.com/u/9079182?v=3","gravatar_id":"","url":"https://api.github.com/users/ricardomacedo13","html_url":"https://github.com/ricardomacedo13","followers_url":"https://api.github.com/users/ricardomacedo13/followers","following_url":"https://api.github.com/users/ricardomacedo13/following{/other_user}","gists_url":"https://api.github.com/users/ricardomacedo13/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardomacedo13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardomacedo13/subscriptions","organizations_url":"https://api.github.com/users/ricardomacedo13/orgs","repos_url":"https://api.github.com/users/ricardomacedo13/repos","events_url":"https://api.github.com/users/ricardomacedo13/events{/privacy}","received_events_url":"https://api.github.com/users/ricardomacedo13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ricardomacedo13/YCSB","description":"Yahoo! Cloud Serving Benchmark","fork":true,"url":"https://api.github.com/repos/ricardomacedo13/YCSB","forks_url":"https://api.github.com/repos/ricardomacedo13/YCSB/forks","keys_url":"https://api.github.com/repos/ricardomacedo13/YCSB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ricardomacedo13/YCSB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ricardomacedo13/YCSB/teams","hooks_url":"https://api.github.com/repos/ricardomacedo13/YCSB/hooks","issue_events_url":"https://api.github.com/repos/ricardomacedo13/YCSB/issues/events{/number}","events_url":"https://api.github.com/repos/ricardomacedo13/YCSB/events","assignees_url":"https://api.github.com/repos/ricardomacedo13/YCSB/assignees{/user}","branches_url":"https://api.github.com/repos/ricardomacedo13/YCSB/branches{/branch}","tags_url":"https://api.github.com/repos/ricardomacedo13/YCSB/tags","blobs_url":"https://api.github.com/repos/ricardomacedo13/YCSB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ricardomacedo13/YCSB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ricardomacedo13/YCSB/git/refs{/sha}","trees_url":"https://api.github.com/repos/ricardomacedo13/YCSB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ricardomacedo13/YCSB/statuses/{sha}","languages_url":"https://api.github.com/repos/ricardomacedo13/YCSB/languages","stargazers_url":"https://api.github.com/repos/ricardomacedo13/YCSB/stargazers","contributors_url":"https://api.github.com/repos/ricardomacedo13/YCSB/contributors","subscribers_url":"https://api.github.com/repos/ricardomacedo13/YCSB/subscribers","subscription_url":"https://api.github.com/repos/ricardomacedo13/YCSB/subscription","commits_url":"https://api.github.com/repos/ricardomacedo13/YCSB/commits{/sha}","git_commits_url":"https://api.github.com/repos/ricardomacedo13/YCSB/git/commits{/sha}","comments_url":"https://api.github.com/repos/ricardomacedo13/YCSB/comments{/number}","issue_comment_url":"https://api.github.com/repos/ricardomacedo13/YCSB/issues/comments{/number}","contents_url":"https://api.github.com/repos/ricardomacedo13/YCSB/contents/{+path}","compare_url":"https://api.github.com/repos/ricardomacedo13/YCSB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ricardomacedo13/YCSB/merges","archive_url":"https://api.github.com/repos/ricardomacedo13/YCSB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ricardomacedo13/YCSB/downloads","issues_url":"https://api.github.com/repos/ricardomacedo13/YCSB/issues{/number}","pulls_url":"https://api.github.com/repos/ricardomacedo13/YCSB/pulls{/number}","milestones_url":"https://api.github.com/repos/ricardomacedo13/YCSB/milestones{/number}","notifications_url":"https://api.github.com/repos/ricardomacedo13/YCSB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ricardomacedo13/YCSB/labels{/name}","releases_url":"https://api.github.com/repos/ricardomacedo13/YCSB/releases{/id}","deployments_url":"https://api.github.com/repos/ricardomacedo13/YCSB/deployments","created_at":"2016-10-28T08:00:53Z","updated_at":"2016-10-28T08:00:55Z","pushed_at":"2016-11-24T12:51:18Z","git_url":"git://github.com/ricardomacedo13/YCSB.git","ssh_url":"git@github.com:ricardomacedo13/YCSB.git","clone_url":"https://github.com/ricardomacedo13/YCSB.git","svn_url":"https://github.com/ricardomacedo13/YCSB","homepage":"http://labs.yahoo.com/news/yahoo-cloud-serving-benchmark/","size":1075092,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brianfrankcooper:master","ref":"master","sha":"70f4362bdf63c6de6f408029bdcb6951f02867c6","user":{"login":"brianfrankcooper","id":247619,"avatar_url":"https://avatars.githubusercontent.com/u/247619?v=3","gravatar_id":"","url":"https://api.github.com/users/brianfrankcooper","html_url":"https://github.com/brianfrankcooper","followers_url":"https://api.github.com/users/brianfrankcooper/followers","following_url":"https://api.github.com/users/brianfrankcooper/following{/other_user}","gists_url":"https://api.github.com/users/brianfrankcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/brianfrankcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianfrankcooper/subscriptions","organizations_url":"https://api.github.com/users/brianfrankcooper/orgs","repos_url":"https://api.github.com/users/brianfrankcooper/repos","events_url":"https://api.github.com/users/brianfrankcooper/events{/privacy}","received_events_url":"https://api.github.com/users/brianfrankcooper/received_events","type":"User","site_admin":false},"repo":{"id":618492,"name":"YCSB","full_name":"brianfrankcooper/YCSB","owner":{"login":"brianfrankcooper","id":247619,"avatar_url":"https://avatars.githubusercontent.com/u/247619?v=3","gravatar_id":"","url":"https://api.github.com/users/brianfrankcooper","html_url":"https://github.com/brianfrankcooper","followers_url":"https://api.github.com/users/brianfrankcooper/followers","following_url":"https://api.github.com/users/brianfrankcooper/following{/other_user}","gists_url":"https://api.github.com/users/brianfrankcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/brianfrankcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianfrankcooper/subscriptions","organizations_url":"https://api.github.com/users/brianfrankcooper/orgs","repos_url":"https://api.github.com/users/brianfrankcooper/repos","events_url":"https://api.github.com/users/brianfrankcooper/events{/privacy}","received_events_url":"https://api.github.com/users/brianfrankcooper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianfrankcooper/YCSB","description":"Yahoo! Cloud Serving Benchmark","fork":false,"url":"https://api.github.com/repos/brianfrankcooper/YCSB","forks_url":"https://api.github.com/repos/brianfrankcooper/YCSB/forks","keys_url":"https://api.github.com/repos/brianfrankcooper/YCSB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianfrankcooper/YCSB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianfrankcooper/YCSB/teams","hooks_url":"https://api.github.com/repos/brianfrankcooper/YCSB/hooks","issue_events_url":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/events{/number}","events_url":"https://api.github.com/repos/brianfrankcooper/YCSB/events","assignees_url":"https://api.github.com/repos/brianfrankcooper/YCSB/assignees{/user}","branches_url":"https://api.github.com/repos/brianfrankcooper/YCSB/branches{/branch}","tags_url":"https://api.github.com/repos/brianfrankcooper/YCSB/tags","blobs_url":"https://api.github.com/repos/brianfrankcooper/YCSB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianfrankcooper/YCSB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianfrankcooper/YCSB/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianfrankcooper/YCSB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianfrankcooper/YCSB/statuses/{sha}","languages_url":"https://api.github.com/repos/brianfrankcooper/YCSB/languages","stargazers_url":"https://api.github.com/repos/brianfrankcooper/YCSB/stargazers","contributors_url":"https://api.github.com/repos/brianfrankcooper/YCSB/contributors","subscribers_url":"https://api.github.com/repos/brianfrankcooper/YCSB/subscribers","subscription_url":"https://api.github.com/repos/brianfrankcooper/YCSB/subscription","commits_url":"https://api.github.com/repos/brianfrankcooper/YCSB/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianfrankcooper/YCSB/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianfrankcooper/YCSB/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianfrankcooper/YCSB/contents/{+path}","compare_url":"https://api.github.com/repos/brianfrankcooper/YCSB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianfrankcooper/YCSB/merges","archive_url":"https://api.github.com/repos/brianfrankcooper/YCSB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianfrankcooper/YCSB/downloads","issues_url":"https://api.github.com/repos/brianfrankcooper/YCSB/issues{/number}","pulls_url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls{/number}","milestones_url":"https://api.github.com/repos/brianfrankcooper/YCSB/milestones{/number}","notifications_url":"https://api.github.com/repos/brianfrankcooper/YCSB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianfrankcooper/YCSB/labels{/name}","releases_url":"https://api.github.com/repos/brianfrankcooper/YCSB/releases{/id}","deployments_url":"https://api.github.com/repos/brianfrankcooper/YCSB/deployments","created_at":"2010-04-19T20:52:11Z","updated_at":"2016-11-24T16:26:22Z","pushed_at":"2016-11-24T12:51:20Z","git_url":"git://github.com/brianfrankcooper/YCSB.git","ssh_url":"git@github.com:brianfrankcooper/YCSB.git","clone_url":"https://github.com/brianfrankcooper/YCSB.git","svn_url":"https://github.com/brianfrankcooper/YCSB","homepage":"http://labs.yahoo.com/news/yahoo-cloud-serving-benchmark/","size":1218527,"stargazers_count":1401,"watchers_count":1401,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":931,"mirror_url":null,"open_issues_count":128,"forks":931,"open_issues":128,"watchers":1401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/869"},"html":{"href":"https://github.com/brianfrankcooper/YCSB/pull/869"},"issue":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/869"},"comments":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/869/comments"},"review_comments":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/869/comments"},"review_comment":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/869/commits"},"statuses":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/statuses/35431b83bde55f10947c67f010cf8b3503c68527"}}}}
{"actor":{"display_login":"ricardomacedo13"}}