{"action":"created","comment":{"url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/comments/83179721","pull_request_review_id":4037454,"id":83179721,"diff_hunk":"@@ -191,7 +191,9 @@ public VideoConversionStatus getProgressStatus(String repositoryName, String doc\n         WorkManager workManager = Framework.getLocalService(WorkManager.class);\n         Work work = new VideoConversionWork(repositoryName, docId, conversionName);\n         State state = workManager.getWorkState(work.getId());\n-        if (state == State.SCHEDULED) {\n+        if (state == null) { // DONE\n+            return null;","path":"nuxeo-platform-video-core/src/main/java/org/nuxeo/ecm/platform/video/service/VideoServiceImpl.java","position":6,"original_position":6,"commit_id":"c8237630be2c7a29112c4e579d713a20e9df1684","original_commit_id":"c8237630be2c7a29112c4e579d713a20e9df1684","user":{"login":"efge","id":592810,"avatar_url":"https://avatars.githubusercontent.com/u/592810?v=3","gravatar_id":"","url":"https://api.github.com/users/efge","html_url":"https://github.com/efge","followers_url":"https://api.github.com/users/efge/followers","following_url":"https://api.github.com/users/efge/following{/other_user}","gists_url":"https://api.github.com/users/efge/gists{/gist_id}","starred_url":"https://api.github.com/users/efge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efge/subscriptions","organizations_url":"https://api.github.com/users/efge/orgs","repos_url":"https://api.github.com/users/efge/repos","events_url":"https://api.github.com/users/efge/events{/privacy}","received_events_url":"https://api.github.com/users/efge/received_events","type":"User","site_admin":false},"body":"Why do you return `null` and not a `VideoConversionStatus` like for other code paths? Is the caller prepared to get a `null`? The Javadoc should explain what it means in that case.","created_at":"2016-10-13T09:47:23Z","updated_at":"2016-10-13T09:47:28Z","html_url":"https://github.com/nuxeo/nuxeo-platform-video/pull/6#discussion_r83179721","pull_request_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/comments/83179721"},"html":{"href":"https://github.com/nuxeo/nuxeo-platform-video/pull/6#discussion_r83179721"},"pull_request":{"href":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/6","id":89048164,"html_url":"https://github.com/nuxeo/nuxeo-platform-video/pull/6","diff_url":"https://github.com/nuxeo/nuxeo-platform-video/pull/6.diff","patch_url":"https://github.com/nuxeo/nuxeo-platform-video/pull/6.patch","issue_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/issues/6","number":6,"state":"open","locked":false,"title":"fix-NXP-20232-video-conversion-widget","user":{"login":"nuxeojenkins","id":925456,"avatar_url":"https://avatars.githubusercontent.com/u/925456?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeojenkins","html_url":"https://github.com/nuxeojenkins","followers_url":"https://api.github.com/users/nuxeojenkins/followers","following_url":"https://api.github.com/users/nuxeojenkins/following{/other_user}","gists_url":"https://api.github.com/users/nuxeojenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeojenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeojenkins/subscriptions","organizations_url":"https://api.github.com/users/nuxeojenkins/orgs","repos_url":"https://api.github.com/users/nuxeojenkins/repos","events_url":"https://api.github.com/users/nuxeojenkins/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeojenkins/received_events","type":"User","site_admin":false},"body":"PR created from https://qa.nuxeo.org/jenkins/job/TestAndPush/job/ondemand-testandpush-troger/10/","created_at":"2016-10-12T16:23:15Z","updated_at":"2016-10-13T09:47:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"811d533c820cc4119b448540bbbfc23824e99132","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/6/commits","review_comments_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/6/comments","review_comment_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/issues/6/comments","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/statuses/c8237630be2c7a29112c4e579d713a20e9df1684","head":{"label":"nuxeo:fix-NXP-20232-video-conversion-widget","ref":"fix-NXP-20232-video-conversion-widget","sha":"c8237630be2c7a29112c4e579d713a20e9df1684","user":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2989002,"name":"nuxeo-platform-video","full_name":"nuxeo/nuxeo-platform-video","owner":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nuxeo/nuxeo-platform-video","description":"Nuxeo Platform Video addon","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video","forks_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/deployments","created_at":"2011-12-15T16:39:02Z","updated_at":"2016-10-04T21:02:46Z","pushed_at":"2016-10-12T16:23:15Z","git_url":"git://github.com/nuxeo/nuxeo-platform-video.git","ssh_url":"git@github.com:nuxeo/nuxeo-platform-video.git","clone_url":"https://github.com/nuxeo/nuxeo-platform-video.git","svn_url":"https://github.com/nuxeo/nuxeo-platform-video","homepage":"","size":24088,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"nuxeo:master","ref":"master","sha":"1e7966c6a2db29634ed3faa64b30e5d61c2a50cd","user":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2989002,"name":"nuxeo-platform-video","full_name":"nuxeo/nuxeo-platform-video","owner":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nuxeo/nuxeo-platform-video","description":"Nuxeo Platform Video addon","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video","forks_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/deployments","created_at":"2011-12-15T16:39:02Z","updated_at":"2016-10-04T21:02:46Z","pushed_at":"2016-10-12T16:23:15Z","git_url":"git://github.com/nuxeo/nuxeo-platform-video.git","ssh_url":"git@github.com:nuxeo/nuxeo-platform-video.git","clone_url":"https://github.com/nuxeo/nuxeo-platform-video.git","svn_url":"https://github.com/nuxeo/nuxeo-platform-video","homepage":"","size":24088,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/6"},"html":{"href":"https://github.com/nuxeo/nuxeo-platform-video/pull/6"},"issue":{"href":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/issues/6"},"comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/nuxeo/nuxeo-platform-video/statuses/c8237630be2c7a29112c4e579d713a20e9df1684"}}}}
{"actor":{"display_login":"efge"}}