{"action":"created","issue":{"url":"https://api.github.com/repos/certbot/certbot/issues/3767","repository_url":"https://api.github.com/repos/certbot/certbot","labels_url":"https://api.github.com/repos/certbot/certbot/issues/3767/labels{/name}","comments_url":"https://api.github.com/repos/certbot/certbot/issues/3767/comments","events_url":"https://api.github.com/repos/certbot/certbot/issues/3767/events","html_url":"https://github.com/certbot/certbot/issues/3767","id":187879645,"number":3767,"title":"Further merge --script-* with --*-hook","user":{"login":"pde","id":479213,"avatar_url":"https://avatars.githubusercontent.com/u/479213?v=3","gravatar_id":"","url":"https://api.github.com/users/pde","html_url":"https://github.com/pde","followers_url":"https://api.github.com/users/pde/followers","following_url":"https://api.github.com/users/pde/following{/other_user}","gists_url":"https://api.github.com/users/pde/gists{/gist_id}","starred_url":"https://api.github.com/users/pde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pde/subscriptions","organizations_url":"https://api.github.com/users/pde/orgs","repos_url":"https://api.github.com/users/pde/repos","events_url":"https://api.github.com/users/pde/events{/privacy}","received_events_url":"https://api.github.com/users/pde/received_events","type":"User","site_admin":false},"labels":[{"id":281465844,"url":"https://api.github.com/repos/certbot/certbot/labels/refactoring","name":"refactoring","color":"b4a5d9","default":false},{"id":448572621,"url":"https://api.github.com/repos/certbot/certbot/labels/script%20plugin","name":"script plugin","color":"8e6a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-08T01:42:07Z","updated_at":"2016-11-08T06:00:51Z","closed_at":null,"body":"Today @jsha made an argument that we should work a bit harder to make the script plugin feel and operate consistently with the existing hooks.  We reached some conclusions about this:\r\n\r\n* `--script-auth` and `--script-cleanup` could become `--auth-hook` and `--cleanup-hook`; that would require moving them out of a plugin but that's doable.\r\n* Support from them could be moved from their own plugin to the manual plugin, with the advantage that existing manual users could told about them interactively and onboarded into the brave new scripting future\r\n* We disagreed on whether `--auth-hook` should always be run or whether it should be specific to `--manual`, but concluded that this would be the prerogative of whoever implements this refactor."},"comment":{"url":"https://api.github.com/repos/certbot/certbot/issues/comments/259053137","html_url":"https://github.com/certbot/certbot/issues/3767#issuecomment-259053137","issue_url":"https://api.github.com/repos/certbot/certbot/issues/3767","id":259053137,"user":{"login":"joohoi","id":5235109,"avatar_url":"https://avatars.githubusercontent.com/u/5235109?v=3","gravatar_id":"","url":"https://api.github.com/users/joohoi","html_url":"https://github.com/joohoi","followers_url":"https://api.github.com/users/joohoi/followers","following_url":"https://api.github.com/users/joohoi/following{/other_user}","gists_url":"https://api.github.com/users/joohoi/gists{/gist_id}","starred_url":"https://api.github.com/users/joohoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joohoi/subscriptions","organizations_url":"https://api.github.com/users/joohoi/orgs","repos_url":"https://api.github.com/users/joohoi/repos","events_url":"https://api.github.com/users/joohoi/events{/privacy}","received_events_url":"https://api.github.com/users/joohoi/received_events","type":"User","site_admin":false},"created_at":"2016-11-08T06:00:51Z","updated_at":"2016-11-08T06:00:51Z","body":"It's a hard question. There certainly are benefits to the both approaches, however I would suggest leaving it as is - to script plugin. This is not up to me, but here are my thoughts about the subject to help you to pick the way to proceed.\r\n\r\nThings that would promote merging the functionality with hooks:\r\n - Code simplicity\r\n - Being able to possibly use auth and cleanup hooks from inside other plugins also if needed\r\n\r\nHowever things that I see beneficial for having the functionality inside a plugin, be it merged with manual plugin, or left to script plugin:\r\n - Keeping the authenticator / installer functionality inside plugin, and staying consistent with current design. I think this is also intuitive from the user perspective, as the current hooks are pretty much \"one shot\" scripts, that are run outside of the actual auth loop, ie: outside of the \"magic\".\r\n - In contrary to hooks, plugins are for the actual \"heavy lifting\" process, while hooks are more like helpers in my view. This is effectively what the authenticator part is doing.\r\n\r\nThings promoting keeping it in script plugin instead of merging with manual:\r\n - The current manual plugin users have either scripted around it or have some kind of process around it. I don't think there are actual conversion factors.\r\n - Omitting the current manual plugin pause-to-wait-for-challenge-deployment functionality would break scripts for users that have scripted around the manual plugin altogether.\r\n "}}
{"actor":{"display_login":"joohoi"}}