{"action":"created","comment":{"url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/comments/80335101","id":80335101,"diff_hunk":"@@ -47,25 +47,25 @@ def extract2d(input_model, which_subarray=None):\n         log.info('Subarray x-extents are: %s %s', xlo, xhi)\n         log.info('Subarray y-extents are: %s %s', ylo, yhi)\n \n-        ext_data = input_model.data[ylo: yhi + 1, xlo: xhi + 1].copy()\n-        ext_err = input_model.err[ylo: yhi + 1, xlo: xhi + 1].copy()\n-        ext_dq = input_model.dq[ylo: yhi + 1, xlo: xhi + 1].copy()\n+        ext_data = input_model.data[ylo: yhi, xlo: xhi].copy()\n+        ext_err = input_model.err[ylo: yhi, xlo: xhi].copy()\n+        ext_dq = input_model.dq[ylo: yhi, xlo: xhi].copy()\n         new_model = datamodels.ImageModel(data=ext_data, err=ext_err, dq=ext_dq)\n         shape = ext_data.shape\n-        domain = [{'lower': -0.5, 'upper': shape[1] + 0.5, 'includes_lower': True, 'includes_upper': False},\n-                  {'lower': -0.5, 'upper': shape[0] + 0.5, 'includes_lower': True, 'includes_upper': False}]\n+        domain = [{'lower': 0, 'upper': shape[1], 'includes_lower': True, 'includes_upper': False},\n+                  {'lower':0, 'upper': shape[0], 'includes_lower': True, 'includes_upper': False}]\n         slit_wcs.domain = domain\n         new_model.meta.wcs = slit_wcs\n         output_model.slits.append(new_model)\n-        # set x/ystart values relative to full detector space\n+        # set x/ystart values relative to the image (screen) frame.\n+        # The overall subarray offset is recorded in model.meta.subarray.\n         nslit = len(output_model.slits) - 1\n         output_model.slits[nslit].name = slit_name\n-        output_model.slits[nslit].xstart = xlo\n+        output_model.slits[nslit].xstart = xlo + 1\n         output_model.slits[nslit].xsize = xhi - xlo + 1\n-        output_model.slits[nslit].ystart = ylo\n+        output_model.slits[nslit].ystart = ylo +1\n         output_model.slits[nslit].ysize = yhi - ylo + 1","path":"jwst/extract_2d/extract_2d.py","position":29,"original_position":29,"commit_id":"f654242b7ef30142d217ea4c1b488c3e480fa10c","original_commit_id":"f654242b7ef30142d217ea4c1b488c3e480fa10c","user":{"login":"jdavies-st","id":17088869,"avatar_url":"https://avatars.githubusercontent.com/u/17088869?v=3","gravatar_id":"","url":"https://api.github.com/users/jdavies-st","html_url":"https://github.com/jdavies-st","followers_url":"https://api.github.com/users/jdavies-st/followers","following_url":"https://api.github.com/users/jdavies-st/following{/other_user}","gists_url":"https://api.github.com/users/jdavies-st/gists{/gist_id}","starred_url":"https://api.github.com/users/jdavies-st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdavies-st/subscriptions","organizations_url":"https://api.github.com/users/jdavies-st/orgs","repos_url":"https://api.github.com/users/jdavies-st/repos","events_url":"https://api.github.com/users/jdavies-st/events{/privacy}","received_events_url":"https://api.github.com/users/jdavies-st/received_events","type":"User","site_admin":false},"body":"Again, leave off the +1 for ysize.","created_at":"2016-09-23T22:04:21Z","updated_at":"2016-09-23T22:04:47Z","html_url":"https://github.com/STScI-JWST/jwst/pull/283#discussion_r80335101","pull_request_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/283","_links":{"self":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/comments/80335101"},"html":{"href":"https://github.com/STScI-JWST/jwst/pull/283#discussion_r80335101"},"pull_request":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/283"}}},"pull_request":{"url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/283","id":86552882,"html_url":"https://github.com/STScI-JWST/jwst/pull/283","diff_url":"https://github.com/STScI-JWST/jwst/pull/283.diff","patch_url":"https://github.com/STScI-JWST/jwst/pull/283.patch","issue_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/283","number":283,"state":"closed","locked":false,"title":"Nirspec full frame","user":{"login":"nden","id":1110361,"avatar_url":"https://avatars.githubusercontent.com/u/1110361?v=3","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"body":"I went through the entire NIRSpec WCS pipeline in assign_wcs, slit extraction in extract_2d and wavelength assignment in compute_world_coordinates and checked that +/- 1 pixels exist at the correct places (0- vs 1- based coordinates). Also made sure that `domain` and `subarray.x(y)start` are used consistently within these modules. My testing shows that full frame coordinates are shifted by 1 pixel in x and y directions compared to IDT results. \r\n`SLITSTR` keywords are 0-base din IDT data (as far as I can tell) but I am not sure this is the difference.","created_at":"2016-09-23T17:44:16Z","updated_at":"2016-09-23T22:04:47Z","closed_at":"2016-09-23T18:31:42Z","merged_at":"2016-09-23T18:31:41Z","merge_commit_sha":"e2d8fae89d49d61eb5d86dc258706f3c8b60ca78","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/STScI-JWST/jwst/milestones/1","html_url":"https://github.com/STScI-JWST/jwst/milestones/Build%207","labels_url":"https://api.github.com/repos/STScI-JWST/jwst/milestones/1/labels","id":1818128,"number":1,"title":"Build 7","description":"JWST Pipeline Build 7","creator":{"login":"larrybradley","id":4992897,"avatar_url":"https://avatars.githubusercontent.com/u/4992897?v=3","gravatar_id":"","url":"https://api.github.com/users/larrybradley","html_url":"https://github.com/larrybradley","followers_url":"https://api.github.com/users/larrybradley/followers","following_url":"https://api.github.com/users/larrybradley/following{/other_user}","gists_url":"https://api.github.com/users/larrybradley/gists{/gist_id}","starred_url":"https://api.github.com/users/larrybradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larrybradley/subscriptions","organizations_url":"https://api.github.com/users/larrybradley/orgs","repos_url":"https://api.github.com/users/larrybradley/repos","events_url":"https://api.github.com/users/larrybradley/events{/privacy}","received_events_url":"https://api.github.com/users/larrybradley/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":152,"state":"open","created_at":"2016-06-09T16:38:24Z","updated_at":"2016-09-23T20:23:03Z","due_on":"2016-10-31T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/283/commits","review_comments_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/283/comments","review_comment_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/comments{/number}","comments_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/283/comments","statuses_url":"https://api.github.com/repos/STScI-JWST/jwst/statuses/f654242b7ef30142d217ea4c1b488c3e480fa10c","head":{"label":"nden:nirspec-full-frame","ref":"nirspec-full-frame","sha":"f654242b7ef30142d217ea4c1b488c3e480fa10c","user":{"login":"nden","id":1110361,"avatar_url":"https://avatars.githubusercontent.com/u/1110361?v=3","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"repo":{"id":60785193,"name":"jwst","full_name":"nden/jwst","owner":{"login":"nden","id":1110361,"avatar_url":"https://avatars.githubusercontent.com/u/1110361?v=3","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nden/jwst","description":"","fork":true,"url":"https://api.github.com/repos/nden/jwst","forks_url":"https://api.github.com/repos/nden/jwst/forks","keys_url":"https://api.github.com/repos/nden/jwst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nden/jwst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nden/jwst/teams","hooks_url":"https://api.github.com/repos/nden/jwst/hooks","issue_events_url":"https://api.github.com/repos/nden/jwst/issues/events{/number}","events_url":"https://api.github.com/repos/nden/jwst/events","assignees_url":"https://api.github.com/repos/nden/jwst/assignees{/user}","branches_url":"https://api.github.com/repos/nden/jwst/branches{/branch}","tags_url":"https://api.github.com/repos/nden/jwst/tags","blobs_url":"https://api.github.com/repos/nden/jwst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nden/jwst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nden/jwst/git/refs{/sha}","trees_url":"https://api.github.com/repos/nden/jwst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nden/jwst/statuses/{sha}","languages_url":"https://api.github.com/repos/nden/jwst/languages","stargazers_url":"https://api.github.com/repos/nden/jwst/stargazers","contributors_url":"https://api.github.com/repos/nden/jwst/contributors","subscribers_url":"https://api.github.com/repos/nden/jwst/subscribers","subscription_url":"https://api.github.com/repos/nden/jwst/subscription","commits_url":"https://api.github.com/repos/nden/jwst/commits{/sha}","git_commits_url":"https://api.github.com/repos/nden/jwst/git/commits{/sha}","comments_url":"https://api.github.com/repos/nden/jwst/comments{/number}","issue_comment_url":"https://api.github.com/repos/nden/jwst/issues/comments{/number}","contents_url":"https://api.github.com/repos/nden/jwst/contents/{+path}","compare_url":"https://api.github.com/repos/nden/jwst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nden/jwst/merges","archive_url":"https://api.github.com/repos/nden/jwst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nden/jwst/downloads","issues_url":"https://api.github.com/repos/nden/jwst/issues{/number}","pulls_url":"https://api.github.com/repos/nden/jwst/pulls{/number}","milestones_url":"https://api.github.com/repos/nden/jwst/milestones{/number}","notifications_url":"https://api.github.com/repos/nden/jwst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nden/jwst/labels{/name}","releases_url":"https://api.github.com/repos/nden/jwst/releases{/id}","deployments_url":"https://api.github.com/repos/nden/jwst/deployments","created_at":"2016-06-09T15:24:24Z","updated_at":"2016-06-09T15:24:26Z","pushed_at":"2016-09-23T17:39:19Z","git_url":"git://github.com/nden/jwst.git","ssh_url":"git@github.com:nden/jwst.git","clone_url":"https://github.com/nden/jwst.git","svn_url":"https://github.com/nden/jwst","homepage":null,"size":13164,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"STScI-JWST:master","ref":"master","sha":"9e174e917169826a5f3decfb1d4dcc8c13b1cb8d","user":{"login":"STScI-JWST","id":17731768,"avatar_url":"https://avatars.githubusercontent.com/u/17731768?v=3","gravatar_id":"","url":"https://api.github.com/users/STScI-JWST","html_url":"https://github.com/STScI-JWST","followers_url":"https://api.github.com/users/STScI-JWST/followers","following_url":"https://api.github.com/users/STScI-JWST/following{/other_user}","gists_url":"https://api.github.com/users/STScI-JWST/gists{/gist_id}","starred_url":"https://api.github.com/users/STScI-JWST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STScI-JWST/subscriptions","organizations_url":"https://api.github.com/users/STScI-JWST/orgs","repos_url":"https://api.github.com/users/STScI-JWST/repos","events_url":"https://api.github.com/users/STScI-JWST/events{/privacy}","received_events_url":"https://api.github.com/users/STScI-JWST/received_events","type":"Organization","site_admin":false},"repo":{"id":60551519,"name":"jwst","full_name":"STScI-JWST/jwst","owner":{"login":"STScI-JWST","id":17731768,"avatar_url":"https://avatars.githubusercontent.com/u/17731768?v=3","gravatar_id":"","url":"https://api.github.com/users/STScI-JWST","html_url":"https://github.com/STScI-JWST","followers_url":"https://api.github.com/users/STScI-JWST/followers","following_url":"https://api.github.com/users/STScI-JWST/following{/other_user}","gists_url":"https://api.github.com/users/STScI-JWST/gists{/gist_id}","starred_url":"https://api.github.com/users/STScI-JWST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STScI-JWST/subscriptions","organizations_url":"https://api.github.com/users/STScI-JWST/orgs","repos_url":"https://api.github.com/users/STScI-JWST/repos","events_url":"https://api.github.com/users/STScI-JWST/events{/privacy}","received_events_url":"https://api.github.com/users/STScI-JWST/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STScI-JWST/jwst","description":"","fork":false,"url":"https://api.github.com/repos/STScI-JWST/jwst","forks_url":"https://api.github.com/repos/STScI-JWST/jwst/forks","keys_url":"https://api.github.com/repos/STScI-JWST/jwst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STScI-JWST/jwst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STScI-JWST/jwst/teams","hooks_url":"https://api.github.com/repos/STScI-JWST/jwst/hooks","issue_events_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/events{/number}","events_url":"https://api.github.com/repos/STScI-JWST/jwst/events","assignees_url":"https://api.github.com/repos/STScI-JWST/jwst/assignees{/user}","branches_url":"https://api.github.com/repos/STScI-JWST/jwst/branches{/branch}","tags_url":"https://api.github.com/repos/STScI-JWST/jwst/tags","blobs_url":"https://api.github.com/repos/STScI-JWST/jwst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STScI-JWST/jwst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STScI-JWST/jwst/git/refs{/sha}","trees_url":"https://api.github.com/repos/STScI-JWST/jwst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STScI-JWST/jwst/statuses/{sha}","languages_url":"https://api.github.com/repos/STScI-JWST/jwst/languages","stargazers_url":"https://api.github.com/repos/STScI-JWST/jwst/stargazers","contributors_url":"https://api.github.com/repos/STScI-JWST/jwst/contributors","subscribers_url":"https://api.github.com/repos/STScI-JWST/jwst/subscribers","subscription_url":"https://api.github.com/repos/STScI-JWST/jwst/subscription","commits_url":"https://api.github.com/repos/STScI-JWST/jwst/commits{/sha}","git_commits_url":"https://api.github.com/repos/STScI-JWST/jwst/git/commits{/sha}","comments_url":"https://api.github.com/repos/STScI-JWST/jwst/comments{/number}","issue_comment_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/comments{/number}","contents_url":"https://api.github.com/repos/STScI-JWST/jwst/contents/{+path}","compare_url":"https://api.github.com/repos/STScI-JWST/jwst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STScI-JWST/jwst/merges","archive_url":"https://api.github.com/repos/STScI-JWST/jwst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STScI-JWST/jwst/downloads","issues_url":"https://api.github.com/repos/STScI-JWST/jwst/issues{/number}","pulls_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls{/number}","milestones_url":"https://api.github.com/repos/STScI-JWST/jwst/milestones{/number}","notifications_url":"https://api.github.com/repos/STScI-JWST/jwst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STScI-JWST/jwst/labels{/name}","releases_url":"https://api.github.com/repos/STScI-JWST/jwst/releases{/id}","deployments_url":"https://api.github.com/repos/STScI-JWST/jwst/deployments","created_at":"2016-06-06T18:34:23Z","updated_at":"2016-09-19T20:24:49Z","pushed_at":"2016-09-23T18:31:42Z","git_url":"git://github.com/STScI-JWST/jwst.git","ssh_url":"git@github.com:STScI-JWST/jwst.git","clone_url":"https://github.com/STScI-JWST/jwst.git","svn_url":"https://github.com/STScI-JWST/jwst","homepage":null,"size":16012,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":56,"forks":19,"open_issues":56,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/283"},"html":{"href":"https://github.com/STScI-JWST/jwst/pull/283"},"issue":{"href":"https://api.github.com/repos/STScI-JWST/jwst/issues/283"},"comments":{"href":"https://api.github.com/repos/STScI-JWST/jwst/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/STScI-JWST/jwst/statuses/f654242b7ef30142d217ea4c1b488c3e480fa10c"}}}}
{"actor":{"display_login":"jdavies-st"}}