{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4703","repository_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4703/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4703/comments","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4703/events","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4703","id":159522545,"number":4703,"title":"histograms","user":{"login":"will-moore","id":900055,"avatar_url":"https://avatars.githubusercontent.com/u/900055?v=3","gravatar_id":"","url":"https://api.github.com/users/will-moore","html_url":"https://github.com/will-moore","followers_url":"https://api.github.com/users/will-moore/followers","following_url":"https://api.github.com/users/will-moore/following{/other_user}","gists_url":"https://api.github.com/users/will-moore/gists{/gist_id}","starred_url":"https://api.github.com/users/will-moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will-moore/subscriptions","organizations_url":"https://api.github.com/users/will-moore/orgs","repos_url":"https://api.github.com/users/will-moore/repos","events_url":"https://api.github.com/users/will-moore/events{/privacy}","received_events_url":"https://api.github.com/users/will-moore/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/labels/develop","name":"develop","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-06-09T22:26:45Z","updated_at":"2016-06-17T10:50:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/4703","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4703","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4703.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4703.patch"},"body":"This adds histograms to Preview panel of web (will also add to image viewer - not ready yet).\r\nBased on designs at https://github.com/openmicroscopy/design/issues/37\r\nAlso https://trello.com/c/6gKn8FT2/40-histogram\r\n\r\nTo test (NB: start with refresh of browser to avoid cached js files)\r\n - Open image in Preview Tab\r\n - Click \"Show Histogram\"\r\n - Need full test of editing rendering settings (few code changes in this)\r\n - Histogram should show channel being edited (slider/colour-picker/toggle)\r\n - Lines on histogram showing start/end of channel sliders should be shown on histogram and updated when adjusting sliders.\r\n - Also test histogram updates to 'current channel' and start/end lines in sync with slider values during Save, Save To All, Undo / Redo, Copy / Paste, 'Imported' settings, greyscale etc.\r\n - Test similar in full image viewer.\r\n\r\n<img width=\"368\" alt=\"screen shot 2016-06-09 at 23 22 52\" src=\"https://cloud.githubusercontent.com/assets/900055/15948674/fa763950-2e99-11e6-871d-6777350cd48d.png\">\r\n\r\nNB: I have removed the 'rangewidget' which gives channel start/end inputs their up/down buttons. I think this wasn't useful functionality and looks better with it gone. See before (above) and after (below)\r\n\r\n<img width=\"360\" alt=\"screen shot 2016-06-12 at 23 59 21\" src=\"https://cloud.githubusercontent.com/assets/900055/15994345/d6679452-30f9-11e6-8dc1-569810f1caed.png\">\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments/226739735","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4703#issuecomment-226739735","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4703","id":226739735,"user":{"login":"pwalczysko","id":2478303,"avatar_url":"https://avatars.githubusercontent.com/u/2478303?v=3","gravatar_id":"","url":"https://api.github.com/users/pwalczysko","html_url":"https://github.com/pwalczysko","followers_url":"https://api.github.com/users/pwalczysko/followers","following_url":"https://api.github.com/users/pwalczysko/following{/other_user}","gists_url":"https://api.github.com/users/pwalczysko/gists{/gist_id}","starred_url":"https://api.github.com/users/pwalczysko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwalczysko/subscriptions","organizations_url":"https://api.github.com/users/pwalczysko/orgs","repos_url":"https://api.github.com/users/pwalczysko/repos","events_url":"https://api.github.com/users/pwalczysko/events{/privacy}","received_events_url":"https://api.github.com/users/pwalczysko/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T10:50:31Z","updated_at":"2016-06-17T10:50:31Z","body":"> Like @pwalczysko - finding the behaviour between full range/min/max confusing. Histogram only shows between min and max and lines only appear on histogram when min/max is reached.\r\nIt is logical but the behaviour is not transparent.\r\nNot sure if possible/worth trying to make it easier to grasp.\r\n\r\nMaybe adding a x-axis scale under the Histogram ? Now you have no comparison where actually the \"hill\" of the histogram is if the bars are missing from the graph."}}
{"actor":{"display_login":"pwalczysko"}}