{"action":"created","comment":{"url":"https://api.github.com/repos/scalecube/scalecube/pulls/comments/80010639","id":80010639,"diff_hunk":"@@ -238,13 +236,13 @@ public void stop() {\n    * ============== Action Methods ================== *\n    * ================================================ */\n \n-  private ListenableFuture<Void> doInitialSync() {\n+  private CompletableFuture<Void> doInitialSync() {\n     LOGGER.debug(\"Making initial Sync to all seed members: {}\", seedMembers);\n     if (seedMembers.isEmpty()) {\n-      return Futures.immediateFuture(null);\n+      return CompletableFuture.completedFuture(null);","path":"cluster/src/main/java/io/scalecube/cluster/membership/MembershipProtocol.java","position":36,"original_position":36,"commit_id":"9b2e996bcc68ffc7dc440ee5b49f9ff5a210c4df","original_commit_id":"9b2e996bcc68ffc7dc440ee5b49f9ff5a210c4df","user":{"login":"antonkharenko","id":589734,"avatar_url":"https://avatars.githubusercontent.com/u/589734?v=3","gravatar_id":"","url":"https://api.github.com/users/antonkharenko","html_url":"https://github.com/antonkharenko","followers_url":"https://api.github.com/users/antonkharenko/followers","following_url":"https://api.github.com/users/antonkharenko/following{/other_user}","gists_url":"https://api.github.com/users/antonkharenko/gists{/gist_id}","starred_url":"https://api.github.com/users/antonkharenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonkharenko/subscriptions","organizations_url":"https://api.github.com/users/antonkharenko/orgs","repos_url":"https://api.github.com/users/antonkharenko/repos","events_url":"https://api.github.com/users/antonkharenko/events{/privacy}","received_events_url":"https://api.github.com/users/antonkharenko/received_events","type":"User","site_admin":false},"body":"hm, actually i see a bug here (not related to futures). We need to call `schedulePeriodicSync();` before returning future.","created_at":"2016-09-22T10:09:02Z","updated_at":"2016-09-22T10:09:03Z","html_url":"https://github.com/scalecube/scalecube/pull/96#discussion_r80010639","pull_request_url":"https://api.github.com/repos/scalecube/scalecube/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/comments/80010639"},"html":{"href":"https://github.com/scalecube/scalecube/pull/96#discussion_r80010639"},"pull_request":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/scalecube/scalecube/pulls/96","id":86295315,"html_url":"https://github.com/scalecube/scalecube/pull/96","diff_url":"https://github.com/scalecube/scalecube/pull/96.diff","patch_url":"https://github.com/scalecube/scalecube/pull/96.patch","issue_url":"https://api.github.com/repos/scalecube/scalecube/issues/96","number":96,"state":"open","locked":false,"title":"Remove guava futures usage","user":{"login":"myroslavlisniak","id":3830020,"avatar_url":"https://avatars.githubusercontent.com/u/3830020?v=3","gravatar_id":"","url":"https://api.github.com/users/myroslavlisniak","html_url":"https://github.com/myroslavlisniak","followers_url":"https://api.github.com/users/myroslavlisniak/followers","following_url":"https://api.github.com/users/myroslavlisniak/following{/other_user}","gists_url":"https://api.github.com/users/myroslavlisniak/gists{/gist_id}","starred_url":"https://api.github.com/users/myroslavlisniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myroslavlisniak/subscriptions","organizations_url":"https://api.github.com/users/myroslavlisniak/orgs","repos_url":"https://api.github.com/users/myroslavlisniak/repos","events_url":"https://api.github.com/users/myroslavlisniak/events{/privacy}","received_events_url":"https://api.github.com/users/myroslavlisniak/received_events","type":"User","site_admin":false},"body":"https://github.com/scalecube/scalecube/issues/90\r\n\r\nUse CompletableFuture instead of guava's future,\r\nDecrease null usage","created_at":"2016-09-22T08:19:58Z","updated_at":"2016-09-22T10:09:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82df7eb70ebeb5ae3fe8a0930a29b3fd9765becf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalecube/scalecube/pulls/96/commits","review_comments_url":"https://api.github.com/repos/scalecube/scalecube/pulls/96/comments","review_comment_url":"https://api.github.com/repos/scalecube/scalecube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalecube/scalecube/issues/96/comments","statuses_url":"https://api.github.com/repos/scalecube/scalecube/statuses/9b2e996bcc68ffc7dc440ee5b49f9ff5a210c4df","head":{"label":"scalecube:get_rid_of_settable_future","ref":"get_rid_of_settable_future","sha":"9b2e996bcc68ffc7dc440ee5b49f9ff5a210c4df","user":{"login":"scalecube","id":12896170,"avatar_url":"https://avatars.githubusercontent.com/u/12896170?v=3","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"repo":{"id":40714460,"name":"scalecube","full_name":"scalecube/scalecube","owner":{"login":"scalecube","id":12896170,"avatar_url":"https://avatars.githubusercontent.com/u/12896170?v=3","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalecube/scalecube","description":"ScaleCube is a lightweight decentralized cluster membership, failure detection, messaging and gossip protocol library for the Java VM","fork":false,"url":"https://api.github.com/repos/scalecube/scalecube","forks_url":"https://api.github.com/repos/scalecube/scalecube/forks","keys_url":"https://api.github.com/repos/scalecube/scalecube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalecube/scalecube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalecube/scalecube/teams","hooks_url":"https://api.github.com/repos/scalecube/scalecube/hooks","issue_events_url":"https://api.github.com/repos/scalecube/scalecube/issues/events{/number}","events_url":"https://api.github.com/repos/scalecube/scalecube/events","assignees_url":"https://api.github.com/repos/scalecube/scalecube/assignees{/user}","branches_url":"https://api.github.com/repos/scalecube/scalecube/branches{/branch}","tags_url":"https://api.github.com/repos/scalecube/scalecube/tags","blobs_url":"https://api.github.com/repos/scalecube/scalecube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalecube/scalecube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalecube/scalecube/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalecube/scalecube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalecube/scalecube/statuses/{sha}","languages_url":"https://api.github.com/repos/scalecube/scalecube/languages","stargazers_url":"https://api.github.com/repos/scalecube/scalecube/stargazers","contributors_url":"https://api.github.com/repos/scalecube/scalecube/contributors","subscribers_url":"https://api.github.com/repos/scalecube/scalecube/subscribers","subscription_url":"https://api.github.com/repos/scalecube/scalecube/subscription","commits_url":"https://api.github.com/repos/scalecube/scalecube/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalecube/scalecube/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalecube/scalecube/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalecube/scalecube/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalecube/scalecube/contents/{+path}","compare_url":"https://api.github.com/repos/scalecube/scalecube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalecube/scalecube/merges","archive_url":"https://api.github.com/repos/scalecube/scalecube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalecube/scalecube/downloads","issues_url":"https://api.github.com/repos/scalecube/scalecube/issues{/number}","pulls_url":"https://api.github.com/repos/scalecube/scalecube/pulls{/number}","milestones_url":"https://api.github.com/repos/scalecube/scalecube/milestones{/number}","notifications_url":"https://api.github.com/repos/scalecube/scalecube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalecube/scalecube/labels{/name}","releases_url":"https://api.github.com/repos/scalecube/scalecube/releases{/id}","deployments_url":"https://api.github.com/repos/scalecube/scalecube/deployments","created_at":"2015-08-14T12:44:39Z","updated_at":"2016-09-18T19:11:25Z","pushed_at":"2016-09-22T09:22:47Z","git_url":"git://github.com/scalecube/scalecube.git","ssh_url":"git@github.com:scalecube/scalecube.git","clone_url":"https://github.com/scalecube/scalecube.git","svn_url":"https://github.com/scalecube/scalecube","homepage":"http://scalecube.io/","size":1050,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":20,"forks":8,"open_issues":20,"watchers":19,"default_branch":"master"}},"base":{"label":"scalecube:master","ref":"master","sha":"d1b1cd4c65fa9532caf81a2b39214110eaf45162","user":{"login":"scalecube","id":12896170,"avatar_url":"https://avatars.githubusercontent.com/u/12896170?v=3","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"repo":{"id":40714460,"name":"scalecube","full_name":"scalecube/scalecube","owner":{"login":"scalecube","id":12896170,"avatar_url":"https://avatars.githubusercontent.com/u/12896170?v=3","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalecube/scalecube","description":"ScaleCube is a lightweight decentralized cluster membership, failure detection, messaging and gossip protocol library for the Java VM","fork":false,"url":"https://api.github.com/repos/scalecube/scalecube","forks_url":"https://api.github.com/repos/scalecube/scalecube/forks","keys_url":"https://api.github.com/repos/scalecube/scalecube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalecube/scalecube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalecube/scalecube/teams","hooks_url":"https://api.github.com/repos/scalecube/scalecube/hooks","issue_events_url":"https://api.github.com/repos/scalecube/scalecube/issues/events{/number}","events_url":"https://api.github.com/repos/scalecube/scalecube/events","assignees_url":"https://api.github.com/repos/scalecube/scalecube/assignees{/user}","branches_url":"https://api.github.com/repos/scalecube/scalecube/branches{/branch}","tags_url":"https://api.github.com/repos/scalecube/scalecube/tags","blobs_url":"https://api.github.com/repos/scalecube/scalecube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalecube/scalecube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalecube/scalecube/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalecube/scalecube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalecube/scalecube/statuses/{sha}","languages_url":"https://api.github.com/repos/scalecube/scalecube/languages","stargazers_url":"https://api.github.com/repos/scalecube/scalecube/stargazers","contributors_url":"https://api.github.com/repos/scalecube/scalecube/contributors","subscribers_url":"https://api.github.com/repos/scalecube/scalecube/subscribers","subscription_url":"https://api.github.com/repos/scalecube/scalecube/subscription","commits_url":"https://api.github.com/repos/scalecube/scalecube/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalecube/scalecube/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalecube/scalecube/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalecube/scalecube/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalecube/scalecube/contents/{+path}","compare_url":"https://api.github.com/repos/scalecube/scalecube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalecube/scalecube/merges","archive_url":"https://api.github.com/repos/scalecube/scalecube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalecube/scalecube/downloads","issues_url":"https://api.github.com/repos/scalecube/scalecube/issues{/number}","pulls_url":"https://api.github.com/repos/scalecube/scalecube/pulls{/number}","milestones_url":"https://api.github.com/repos/scalecube/scalecube/milestones{/number}","notifications_url":"https://api.github.com/repos/scalecube/scalecube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalecube/scalecube/labels{/name}","releases_url":"https://api.github.com/repos/scalecube/scalecube/releases{/id}","deployments_url":"https://api.github.com/repos/scalecube/scalecube/deployments","created_at":"2015-08-14T12:44:39Z","updated_at":"2016-09-18T19:11:25Z","pushed_at":"2016-09-22T09:22:47Z","git_url":"git://github.com/scalecube/scalecube.git","ssh_url":"git@github.com:scalecube/scalecube.git","clone_url":"https://github.com/scalecube/scalecube.git","svn_url":"https://github.com/scalecube/scalecube","homepage":"http://scalecube.io/","size":1050,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":20,"forks":8,"open_issues":20,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/96"},"html":{"href":"https://github.com/scalecube/scalecube/pull/96"},"issue":{"href":"https://api.github.com/repos/scalecube/scalecube/issues/96"},"comments":{"href":"https://api.github.com/repos/scalecube/scalecube/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/scalecube/scalecube/statuses/9b2e996bcc68ffc7dc440ee5b49f9ff5a210c4df"}}}}
{"actor":{"display_login":"antonkharenko"}}