{"action":"created","issue":{"url":"https://api.github.com/repos/tardis-sn/tardis/issues/455","labels_url":"https://api.github.com/repos/tardis-sn/tardis/issues/455/labels{/name}","comments_url":"https://api.github.com/repos/tardis-sn/tardis/issues/455/comments","events_url":"https://api.github.com/repos/tardis-sn/tardis/issues/455/events","html_url":"https://github.com/tardis-sn/tardis/issues/455","id":122249830,"number":455,"title":"Inconsistencies between Tardis versions","user":{"login":"unoebauer","id":6351165,"avatar_url":"https://avatars.githubusercontent.com/u/6351165?v=3","gravatar_id":"","url":"https://api.github.com/users/unoebauer","html_url":"https://github.com/unoebauer","followers_url":"https://api.github.com/users/unoebauer/followers","following_url":"https://api.github.com/users/unoebauer/following{/other_user}","gists_url":"https://api.github.com/users/unoebauer/gists{/gist_id}","starred_url":"https://api.github.com/users/unoebauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unoebauer/subscriptions","organizations_url":"https://api.github.com/users/unoebauer/orgs","repos_url":"https://api.github.com/users/unoebauer/repos","events_url":"https://api.github.com/users/unoebauer/events{/privacy}","received_events_url":"https://api.github.com/users/unoebauer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tardis-sn/tardis/labels/priority%20-%20high","name":"priority - high","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":65,"created_at":"2015-12-15T11:17:35Z","updated_at":"2016-01-15T14:26:40Z","closed_at":null,"body":"**Main description:**\r\n\r\nTARDIS produces different output between 45eca24d77eacc91d0a0b875e5521bc2d3dc151a and master with this YML file. Why? and what commit introduced this change. \r\n\r\nThe following YML files provide a minimum \"working\" example\": [issue_455.zip](https://github.com/tardis-sn/tardis/files/81324/issue_455.zip)\r\n\r\n-------\r\nThe diagnosis of the problem at hand is still work in progress, but it seems the most recent Tardis version, c9e1b1761a6745d44bae973d962e1be180295827, is inconsistent with a previous state of Tardis.\r\n\r\nAll this has been triggered by re-examining some detailed runs performed during the Abundance Tomography Project of Talytha. For that, we mainly used a Tardis version similar to aa7da173d0e7339bc962bafb62d34d60596fd951 (a working Open-MP implementation has just been incorporated, PR #338). Comparing the virtual spectra obtained with the recent Tardis version for the same setup, reveals huge discrepancies:\r\n\r\n![tardis_cmp](https://cloud.githubusercontent.com/assets/6351165/11809315/4e0b5596-a326-11e5-8d46-6ce036514e7e.png)\r\n\r\n\r\nThe new Tardis version finds a much higher inner temperature. This goes hand in hand with a much higher radiation temperature in the ejecta and a higher ionisation state (and in turn electron density).\r\n\r\n![ionisation_cmp](https://cloud.githubusercontent.com/assets/6351165/11809474/7af337d0-a327-11e5-90e5-d6f8c414032f.png)\r\n\r\n### Setup:\r\n\r\n* ``tardis_00173_2.yml``\r\n```\r\natom_data: kurucz_cd23_chianti_H_He.h5\r\nmodel:\r\n  abundances:\r\n    filename: abundances_00173_2.dat\r\n    filetype: simple_ascii\r\n    type: file\r\n  structure:\r\n    filename: densities_00173_2.dat\r\n    filetype: simple_ascii\r\n    type: file\r\n    v_inner_boundary: 12000.000 km/s\r\n    v_outer_boundary: 35000.000 km/s\r\nmontecarlo:\r\n  black_body_sampling:\r\n    num: 1000000\r\n    start: 1 angstrom\r\n    stop: 1000000 angstrom\r\n  convergence_criteria:\r\n    damping_constant: 1.0\r\n    fraction: 0.8\r\n    hold: 3\r\n    t_inner:\r\n      damping_constant: 1.0\r\n    threshold: 0.05\r\n    type: specific\r\n  iterations: 20\r\n  last_no_of_packets: 500000\r\n  no_of_packets: 50000\r\n  no_of_virtual_packets: 3\r\n  nthreads: 16\r\n  seed: 23111963\r\nplasma:\r\n  disable_electron_scattering: false\r\n  excitation: dilute-lte\r\n  ionization: nebular\r\n  line_interaction_type: downbranch\r\n  radiative_rates_type: dilute-blackbody\r\nspectrum:\r\n  num: 10000\r\n  start: 500 angstrom\r\n  stop: 20000 angstrom\r\nsupernova:\r\n  luminosity_requested: 8.675 log_lsun\r\n  luminosity_wavelength_end: 6500.000 angstrom\r\n  luminosity_wavelength_start: 3500.000 angstrom\r\n  time_explosion: 6.800 day\r\ntardis_config_version: v1.0\r\n```\r\n* ``densities_00173_2.dat``\r\n```\r\n6.800000 day\r\n#Index     Velocities [km/s] Densities [g/cm^3]\r\n  0          1.2000e+04          9.652102e-13\r\n  1          1.2408e+04          3.659182e-13\r\n  2          1.2844e+04          3.932164e-13\r\n  3          1.3312e+04          3.900119e-13\r\n  4          1.3816e+04          3.090009e-13\r\n  5          1.4359e+04          3.108902e-13\r\n  6          1.4947e+04          2.463674e-13\r\n  7          1.5584e+04          5.468102e-14\r\n  8          1.6279e+04          3.228778e-14\r\n  9          1.7039e+04          2.211246e-14\r\n 10          1.7872e+04          1.542880e-14\r\n 11          1.8792e+04          1.264987e-14\r\n 12          1.9811e+04          8.297541e-15\r\n 13          2.0948e+04          4.517051e-15\r\n 14          2.2222e+04          5.480575e-16\r\n 15          2.3662e+04          8.695515e-18\r\n 16          2.5301e+04          4.354394e-18\r\n 17          2.7184e+04          2.150320e-18\r\n 18          2.9371e+04          1.040788e-18\r\n 19          3.1939e+04          4.580299e-19\r\n 20          3.5000e+04          1.893468e-19\r\n```\r\n* ``abundances_00173_2.dat``\r\n```\r\n#Index Z=1 - Z=32\r\n 0 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 6.9280e-06 6.2377e-01 5.0460e-09 1.2570e-05 2.9230e-07 6.0000e-02 5.5630e-07 1.8000e-01 5.8250e-08 3.0000e-02 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-06 3.1720e-09 1.6600e-04 1.0820e-07 5.0000e-03 5.2010e-02 4.6180e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n 1 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 6.9280e-06 6.2377e-01 5.0460e-09 1.2570e-05 2.9230e-07 6.0000e-02 5.5630e-07 1.8000e-01 5.8250e-08 3.0000e-02 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-06 3.1720e-09 1.6600e-04 1.0820e-07 5.0000e-03 5.2010e-02 4.6180e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n 2 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 6.9280e-06 6.2377e-01 5.0460e-09 1.2570e-05 2.9230e-07 6.0000e-02 5.5630e-07 1.8000e-01 5.8250e-08 3.0000e-02 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-06 3.1720e-09 1.6600e-04 1.0820e-07 5.0000e-03 5.2010e-02 4.6180e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n 3 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 6.9280e-06 6.2377e-01 5.0460e-09 1.2570e-05 2.9230e-07 6.0000e-02 5.5630e-07 1.8000e-01 5.8250e-08 3.0000e-02 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-06 3.1720e-09 1.6600e-04 1.0820e-07 5.0000e-03 5.2010e-02 4.6180e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n 4 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 6.9280e-06 6.2377e-01 5.0460e-09 1.2570e-05 2.9230e-07 6.0000e-02 5.5630e-07 1.8000e-01 5.8250e-08 3.0000e-02 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-06 3.1720e-09 1.6600e-04 1.0820e-07 5.0000e-03 5.2010e-02 4.6180e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n 5 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 6.9280e-06 6.2377e-01 5.0460e-09 1.2570e-05 2.9230e-07 6.0000e-02 5.5630e-07 1.8000e-01 5.8250e-08 3.0000e-02 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-06 3.1720e-09 1.6600e-04 1.0820e-07 5.0000e-03 5.2010e-02 4.6180e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n 6 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 6.9280e-06 6.2377e-01 5.0460e-09 1.2570e-05 2.9230e-07 6.0000e-02 5.5630e-07 1.8000e-01 5.8250e-08 3.0000e-02 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-06 3.1720e-09 1.6600e-04 1.0820e-07 5.0000e-03 5.2010e-02 4.6180e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n 7 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 2.7585e-02 6.9280e-06 8.8141e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.3220e-02 5.5630e-07 2.3687e-02 5.8250e-08 5.1738e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 2.7997e-07 3.1720e-09 1.3517e-05 1.0820e-07 5.2687e-04 1.2043e-02 2.3331e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n 8 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n 9 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n10 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n11 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n12 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n13 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n14 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n15 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n16 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n17 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n18 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n19 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n20 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 0.0000e+00 3.0000e-02 6.9280e-06 9.0397e-01 5.0460e-09 1.2570e-05 2.9230e-07 2.0000e-02 5.5630e-07 1.0000e-02 5.8250e-08 3.0000e-03 8.2020e-08 7.3410e-07 3.0650e-08 3.0000e-03 4.6460e-10 3.1210e-08 3.1720e-09 1.6600e-07 1.0820e-07 1.3520e-04 8.5440e-03 2.1330e-02 7.2000e-09 1.7370e-08 0.0000e+00 0.0000e+00\r\n```"},"comment":{"url":"https://api.github.com/repos/tardis-sn/tardis/issues/comments/171974293","html_url":"https://github.com/tardis-sn/tardis/issues/455#issuecomment-171974293","issue_url":"https://api.github.com/repos/tardis-sn/tardis/issues/455","id":171974293,"user":{"login":"aoifeboyle","id":5586399,"avatar_url":"https://avatars.githubusercontent.com/u/5586399?v=3","gravatar_id":"","url":"https://api.github.com/users/aoifeboyle","html_url":"https://github.com/aoifeboyle","followers_url":"https://api.github.com/users/aoifeboyle/followers","following_url":"https://api.github.com/users/aoifeboyle/following{/other_user}","gists_url":"https://api.github.com/users/aoifeboyle/gists{/gist_id}","starred_url":"https://api.github.com/users/aoifeboyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aoifeboyle/subscriptions","organizations_url":"https://api.github.com/users/aoifeboyle/orgs","repos_url":"https://api.github.com/users/aoifeboyle/repos","events_url":"https://api.github.com/users/aoifeboyle/events{/privacy}","received_events_url":"https://api.github.com/users/aoifeboyle/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T14:26:39Z","updated_at":"2016-01-15T14:26:39Z","body":"@unoebauer I tried checking it out directly from the PR rather than using my own branch and it still works for me. Is this the test you're talking about?\r\n\r\natom_data: kurucz_cd23_chianti_H_He.h5\r\nmodel:\r\n  abundances:\r\n    filename: abundances_test.dat\r\n    filetype: simple_ascii\r\n    type: file\r\n  structure:\r\n    filename: densities_test.dat\r\n    filetype: simple_ascii\r\n    type: file\r\n    v_inner_boundary: 12000.000 km/s\r\n    v_outer_boundary: 35000.000 km/s\r\nmontecarlo:\r\n  black_body_sampling:\r\n    num: 1000000\r\n    start: 1 angstrom\r\n    stop: 1000000 angstrom\r\n  iterations: 1\r\n  last_no_of_packets: 1000\r\n  no_of_packets: 1000\r\n  no_of_virtual_packets: 3\r\n  nthreads: 16\r\n  seed: 23111963\r\nplasma:\r\n  initial_t_rad: 10000 K\r\n  initial_t_inner: 10000 K\r\n  disable_electron_scattering: false\r\n  excitation: dilute-lte\r\n  ionization: nebular\r\n  line_interaction_type: downbranch\r\n  radiative_rates_type: dilute-blackbody\r\nspectrum:\r\n  num: 10000\r\n  start: 500 angstrom\r\n  stop: 20000 angstrom\r\nsupernova:\r\n  luminosity_requested: 8.675 log_lsun\r\n  luminosity_wavelength_end: 6500.000 angstrom\r\n  luminosity_wavelength_start: 3500.000 angstrom\r\n  time_explosion: 6.800 day\r\ntardis_config_version: v1.0"}}