{"action":"created","comment":{"url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/comments/82525049","pull_request_review_id":3427839,"id":82525049,"diff_hunk":"@@ -355,13 +365,13 @@ The `id` attribute is REQUIRED.\n \n #### minOccurs\n \n-An integer expressing the minimum number of occurrences of this `EBML Element` within its `Parent Element`. The `minOccurs` value MUST be equal to the `MinOccurence` value of the `path`.\n+An integer expressing the minimum number of occurrences of this `EBML Element` within its `Parent Element`. The `minOccurs` value MUST be equal to the `EBMLMinOccurence` value of the `path`.\n \n The `minOccurs` attribute is OPTIONAL. If the `minOccurs` attribute is not present then that `EBML Element` is considered to have a `minOccurs` value of 0.\n \n #### maxOccurs\n \n-An integer expressing the maximum number of occurrences of this `EBML Element` within its `Parent Element`. The `maxOccurs` value MUST be equal to the `MaxOccurence` value of the `path`.\n+An integer expressing the maximum number of occurrences of this `EBML Element` within its `Parent Element`. The `maxOccurs` value MUST be equal to the `EBMLMaxOccurence` value of the `path`.","path":"specification.markdown","position":null,"original_position":79,"commit_id":"11a2cadd08ee4d97ad22915ca1701a151e1f6fa6","original_commit_id":"9ac3ca15a70688225c73fdb5befeb407f7e11d91","user":{"login":"dericed","id":762604,"avatar_url":"https://avatars.githubusercontent.com/u/762604?v=3","gravatar_id":"","url":"https://api.github.com/users/dericed","html_url":"https://github.com/dericed","followers_url":"https://api.github.com/users/dericed/followers","following_url":"https://api.github.com/users/dericed/following{/other_user}","gists_url":"https://api.github.com/users/dericed/gists{/gist_id}","starred_url":"https://api.github.com/users/dericed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dericed/subscriptions","organizations_url":"https://api.github.com/users/dericed/orgs","repos_url":"https://api.github.com/users/dericed/repos","events_url":"https://api.github.com/users/dericed/events{/privacy}","received_events_url":"https://api.github.com/users/dericed/received_events","type":"User","site_admin":false},"body":"If `maxOccurs` MUST equal `EBMLMaxOccurence` does that infer that `maxOccurs` is mandatory?","created_at":"2016-10-09T15:51:32Z","updated_at":"2016-10-09T15:51:32Z","html_url":"https://github.com/Matroska-Org/ebml-specification/pull/106#discussion_r82525049","pull_request_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/comments/82525049"},"html":{"href":"https://github.com/Matroska-Org/ebml-specification/pull/106#discussion_r82525049"},"pull_request":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/106","id":86653528,"html_url":"https://github.com/Matroska-Org/ebml-specification/pull/106","diff_url":"https://github.com/Matroska-Org/ebml-specification/pull/106.diff","patch_url":"https://github.com/Matroska-Org/ebml-specification/pull/106.patch","issue_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/106","number":106,"state":"open","locked":false,"title":"[RFC] replace the level/minOccurs/maxOccurs attributes with a EBNF based path attribute","user":{"login":"robUx4","id":657717,"avatar_url":"https://avatars.githubusercontent.com/u/657717?v=3","gravatar_id":"","url":"https://api.github.com/users/robUx4","html_url":"https://github.com/robUx4","followers_url":"https://api.github.com/users/robUx4/followers","following_url":"https://api.github.com/users/robUx4/following{/other_user}","gists_url":"https://api.github.com/users/robUx4/gists{/gist_id}","starred_url":"https://api.github.com/users/robUx4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robUx4/subscriptions","organizations_url":"https://api.github.com/users/robUx4/orgs","repos_url":"https://api.github.com/users/robUx4/repos","events_url":"https://api.github.com/users/robUx4/events{/privacy}","received_events_url":"https://api.github.com/users/robUx4/received_events","type":"User","site_admin":false},"body":"This deprecates PR #83.\r\n\r\nThe `EBML Schema` has less attributes but the path needs to be parsed to figure out the hierarchy and occurences. We may need to split the flat/textual element definitions and the `EBML Schema` which can present the data in the way they were before this patch. Each part could be mapped to one section of the EBNF path defined in the textual definition.\r\n\r\nI don't know if the XML Schema is harder to parse with the path of with different attributes.","created_at":"2016-09-25T15:44:07Z","updated_at":"2016-10-09T15:51:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8808fb12bb163a6df745e32ccb3f296636828b15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/106/commits","review_comments_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/106/comments","review_comment_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/106/comments","statuses_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/statuses/11a2cadd08ee4d97ad22915ca1701a151e1f6fa6","head":{"label":"Matroska-Org:ebml-path","ref":"ebml-path","sha":"11a2cadd08ee4d97ad22915ca1701a151e1f6fa6","user":{"login":"Matroska-Org","id":3148284,"avatar_url":"https://avatars.githubusercontent.com/u/3148284?v=3","gravatar_id":"","url":"https://api.github.com/users/Matroska-Org","html_url":"https://github.com/Matroska-Org","followers_url":"https://api.github.com/users/Matroska-Org/followers","following_url":"https://api.github.com/users/Matroska-Org/following{/other_user}","gists_url":"https://api.github.com/users/Matroska-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/Matroska-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matroska-Org/subscriptions","organizations_url":"https://api.github.com/users/Matroska-Org/orgs","repos_url":"https://api.github.com/users/Matroska-Org/repos","events_url":"https://api.github.com/users/Matroska-Org/events{/privacy}","received_events_url":"https://api.github.com/users/Matroska-Org/received_events","type":"Organization","site_admin":false},"repo":{"id":34994967,"name":"ebml-specification","full_name":"Matroska-Org/ebml-specification","owner":{"login":"Matroska-Org","id":3148284,"avatar_url":"https://avatars.githubusercontent.com/u/3148284?v=3","gravatar_id":"","url":"https://api.github.com/users/Matroska-Org","html_url":"https://github.com/Matroska-Org","followers_url":"https://api.github.com/users/Matroska-Org/followers","following_url":"https://api.github.com/users/Matroska-Org/following{/other_user}","gists_url":"https://api.github.com/users/Matroska-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/Matroska-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matroska-Org/subscriptions","organizations_url":"https://api.github.com/users/Matroska-Org/orgs","repos_url":"https://api.github.com/users/Matroska-Org/repos","events_url":"https://api.github.com/users/Matroska-Org/events{/privacy}","received_events_url":"https://api.github.com/users/Matroska-Org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Matroska-Org/ebml-specification","description":"the specification for the EBML format","fork":false,"url":"https://api.github.com/repos/Matroska-Org/ebml-specification","forks_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/forks","keys_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/teams","hooks_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/hooks","issue_events_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/events{/number}","events_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/events","assignees_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/assignees{/user}","branches_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/branches{/branch}","tags_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/tags","blobs_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/refs{/sha}","trees_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/statuses/{sha}","languages_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/languages","stargazers_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/stargazers","contributors_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/contributors","subscribers_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/subscribers","subscription_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/subscription","commits_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/commits{/sha}","git_commits_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/commits{/sha}","comments_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/comments{/number}","issue_comment_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/comments{/number}","contents_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/contents/{+path}","compare_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/merges","archive_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/downloads","issues_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues{/number}","pulls_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls{/number}","milestones_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/milestones{/number}","notifications_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/labels{/name}","releases_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/releases{/id}","deployments_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/deployments","created_at":"2015-05-03T17:48:36Z","updated_at":"2016-09-20T17:12:58Z","pushed_at":"2016-10-09T15:44:22Z","git_url":"git://github.com/Matroska-Org/ebml-specification.git","ssh_url":"git@github.com:Matroska-Org/ebml-specification.git","clone_url":"https://github.com/Matroska-Org/ebml-specification.git","svn_url":"https://github.com/Matroska-Org/ebml-specification","homepage":null,"size":362,"stargazers_count":14,"watchers_count":14,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":17,"forks":7,"open_issues":17,"watchers":14,"default_branch":"master"}},"base":{"label":"Matroska-Org:master","ref":"master","sha":"db31ace4a93c51b16000429aaa38bb8f96dd033f","user":{"login":"Matroska-Org","id":3148284,"avatar_url":"https://avatars.githubusercontent.com/u/3148284?v=3","gravatar_id":"","url":"https://api.github.com/users/Matroska-Org","html_url":"https://github.com/Matroska-Org","followers_url":"https://api.github.com/users/Matroska-Org/followers","following_url":"https://api.github.com/users/Matroska-Org/following{/other_user}","gists_url":"https://api.github.com/users/Matroska-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/Matroska-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matroska-Org/subscriptions","organizations_url":"https://api.github.com/users/Matroska-Org/orgs","repos_url":"https://api.github.com/users/Matroska-Org/repos","events_url":"https://api.github.com/users/Matroska-Org/events{/privacy}","received_events_url":"https://api.github.com/users/Matroska-Org/received_events","type":"Organization","site_admin":false},"repo":{"id":34994967,"name":"ebml-specification","full_name":"Matroska-Org/ebml-specification","owner":{"login":"Matroska-Org","id":3148284,"avatar_url":"https://avatars.githubusercontent.com/u/3148284?v=3","gravatar_id":"","url":"https://api.github.com/users/Matroska-Org","html_url":"https://github.com/Matroska-Org","followers_url":"https://api.github.com/users/Matroska-Org/followers","following_url":"https://api.github.com/users/Matroska-Org/following{/other_user}","gists_url":"https://api.github.com/users/Matroska-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/Matroska-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matroska-Org/subscriptions","organizations_url":"https://api.github.com/users/Matroska-Org/orgs","repos_url":"https://api.github.com/users/Matroska-Org/repos","events_url":"https://api.github.com/users/Matroska-Org/events{/privacy}","received_events_url":"https://api.github.com/users/Matroska-Org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Matroska-Org/ebml-specification","description":"the specification for the EBML format","fork":false,"url":"https://api.github.com/repos/Matroska-Org/ebml-specification","forks_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/forks","keys_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/teams","hooks_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/hooks","issue_events_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/events{/number}","events_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/events","assignees_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/assignees{/user}","branches_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/branches{/branch}","tags_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/tags","blobs_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/refs{/sha}","trees_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/statuses/{sha}","languages_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/languages","stargazers_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/stargazers","contributors_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/contributors","subscribers_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/subscribers","subscription_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/subscription","commits_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/commits{/sha}","git_commits_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/commits{/sha}","comments_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/comments{/number}","issue_comment_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/comments{/number}","contents_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/contents/{+path}","compare_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/merges","archive_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/downloads","issues_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues{/number}","pulls_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls{/number}","milestones_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/milestones{/number}","notifications_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/labels{/name}","releases_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/releases{/id}","deployments_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/deployments","created_at":"2015-05-03T17:48:36Z","updated_at":"2016-09-20T17:12:58Z","pushed_at":"2016-10-09T15:44:22Z","git_url":"git://github.com/Matroska-Org/ebml-specification.git","ssh_url":"git@github.com:Matroska-Org/ebml-specification.git","clone_url":"https://github.com/Matroska-Org/ebml-specification.git","svn_url":"https://github.com/Matroska-Org/ebml-specification","homepage":null,"size":362,"stargazers_count":14,"watchers_count":14,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":17,"forks":7,"open_issues":17,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/106"},"html":{"href":"https://github.com/Matroska-Org/ebml-specification/pull/106"},"issue":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/106"},"comments":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/statuses/11a2cadd08ee4d97ad22915ca1701a151e1f6fa6"}}}}
{"actor":{"display_login":"dericed"}}