{"action":"created","issue":{"url":"https://api.github.com/repos/jwiegley/logging/issues/15","repository_url":"https://api.github.com/repos/jwiegley/logging","labels_url":"https://api.github.com/repos/jwiegley/logging/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/jwiegley/logging/issues/15/comments","events_url":"https://api.github.com/repos/jwiegley/logging/issues/15/events","html_url":"https://github.com/jwiegley/logging/pull/15","id":154862356,"number":15,"title":"Replaced `pcre-light` with `regex-compat` for better Windows experience","user":{"login":"sgraf812","id":1151264,"avatar_url":"https://avatars.githubusercontent.com/u/1151264?v=3","gravatar_id":"","url":"https://api.github.com/users/sgraf812","html_url":"https://github.com/sgraf812","followers_url":"https://api.github.com/users/sgraf812/followers","following_url":"https://api.github.com/users/sgraf812/following{/other_user}","gists_url":"https://api.github.com/users/sgraf812/gists{/gist_id}","starred_url":"https://api.github.com/users/sgraf812/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgraf812/subscriptions","organizations_url":"https://api.github.com/users/sgraf812/orgs","repos_url":"https://api.github.com/users/sgraf812/repos","events_url":"https://api.github.com/users/sgraf812/events{/privacy}","received_events_url":"https://api.github.com/users/sgraf812/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-05-14T16:21:39Z","updated_at":"2016-05-15T12:07:44Z","closed_at":"2016-05-14T23:25:44Z","pull_request":{"url":"https://api.github.com/repos/jwiegley/logging/pulls/15","html_url":"https://github.com/jwiegley/logging/pull/15","diff_url":"https://github.com/jwiegley/logging/pull/15.diff","patch_url":"https://github.com/jwiegley/logging/pull/15.patch"},"body":"Getting `pcre-light` to work on Windows is a pain (didn't get it to work within 5 minutes), whereas `regex-compat` works out of the box.\r\n\r\nThe changes aren't a net win, though.\r\n\r\n1. `regex-compat` uses `String` and is probably inferior performance-wise\r\n2. This might introduce breaking changes in the way regexes are processed\r\n\r\nRegarding the former, I could change the code to using `text-icu` instead if you wish so, although I don't think that performance matters when filtering debug log messages."},"comment":{"url":"https://api.github.com/repos/jwiegley/logging/issues/comments/219282134","html_url":"https://github.com/jwiegley/logging/pull/15#issuecomment-219282134","issue_url":"https://api.github.com/repos/jwiegley/logging/issues/15","id":219282134,"user":{"login":"sgraf812","id":1151264,"avatar_url":"https://avatars.githubusercontent.com/u/1151264?v=3","gravatar_id":"","url":"https://api.github.com/users/sgraf812","html_url":"https://github.com/sgraf812","followers_url":"https://api.github.com/users/sgraf812/followers","following_url":"https://api.github.com/users/sgraf812/following{/other_user}","gists_url":"https://api.github.com/users/sgraf812/gists{/gist_id}","starred_url":"https://api.github.com/users/sgraf812/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgraf812/subscriptions","organizations_url":"https://api.github.com/users/sgraf812/orgs","repos_url":"https://api.github.com/users/sgraf812/repos","events_url":"https://api.github.com/users/sgraf812/events{/privacy}","received_events_url":"https://api.github.com/users/sgraf812/received_events","type":"User","site_admin":false},"created_at":"2016-05-15T12:07:44Z","updated_at":"2016-05-15T12:07:44Z","body":"Anyway, my current master branch holds the changes. If you ever find `regex-compat` to be performing poor, you can switch to that."}}