{"push_id":1287788940,"size":12,"distinct_size":12,"ref":"refs/heads/master","head":"42519abdbf6c9778a9f9421e704181b22d4df684","before":"ee723b2aee3dad18207cbc4083bb290da1f2a3e8","commits":[{"sha":"c1b4b99a3c758f320c369a8daadb219eeb50ee83","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"logging: don't round subsecond part in logging timestamp\n\ntv.tv_usec is guaranteed to have less then 6 digits, however rounding it up\nwe might reach 1000000 and thus the value becomes mis-aligned. To round\ncorrectly, we would have to carry over a potential overflow to the seconds.\nBut that seems too much effort for little gain. Just truncate the value.","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/c1b4b99a3c758f320c369a8daadb219eeb50ee83"},{"sha":"b2016fd2a52b82d45324526c965e7545d026cebe","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"shared: add NM_MIN()/NM_MAX() macros to replace glib's MIN()/MAX()","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/b2016fd2a52b82d45324526c965e7545d026cebe"},{"sha":"2cae9ba348ed6ea4d41ebd714d8c55f4d49feae9","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"shared: add _NM_GET_PRIVATE() macro","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/2cae9ba348ed6ea4d41ebd714d8c55f4d49feae9"},{"sha":"cdf6ad40572f23be6f8b6971bd57b1002ffb9aaf","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"core: use _NM_GET_PRIVATE() macros","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/cdf6ad40572f23be6f8b6971bd57b1002ffb9aaf"},{"sha":"822f01a8fdb63831c887d5db9fb06eb840f53c88","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp-listener: refactor type definition and embed private data in @self","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/822f01a8fdb63831c887d5db9fb06eb840f53c88"},{"sha":"d37cd04fe059e9d99c7103f4e22a9a945f8d4d98","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp-listener: add logging macros to nm-dhcp-listener.c","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/d37cd04fe059e9d99c7103f4e22a9a945f8d4d98"},{"sha":"2dd3a5245f91a7c25ae1a36a86638195500f00a8","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp-listener/trivial: rename field to track connections in NMDhcpListener\n\nIt's not \"signal-handles\", as it currently tracks the registration ID of\ntype int. Rename it, it is effectively the list of connections that we\ntrack.","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/2dd3a5245f91a7c25ae1a36a86638195500f00a8"},{"sha":"bb489163db36889a6fb80789e4e5b9dd8a15dbdd","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp-helper: refactor error handling\n\nDon't exit(1) from fatal_error() because that skips destroying\nlocal variables in main(). Just return regularly.","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/bb489163db36889a6fb80789e4e5b9dd8a15dbdd"},{"sha":"cc89996c9e826c9c8d12d5fb7bc8a2a578209eb0","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp-helper: refactor logging to use logging macros","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/cc89996c9e826c9c8d12d5fb7bc8a2a578209eb0"},{"sha":"7684b68c49812ed7b2ec493889fae04db066b665","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp: add new header \"nm-dhcp-helper-api.h\"","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/7684b68c49812ed7b2ec493889fae04db066b665"},{"sha":"2856a658b38df88494187c811415a198a424e1f2","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp: call synchronous Notify D-Bus method from nm-dhcp-helper\n\nA D-Bus signal is asynchronous and it can happen that nm-dhcp-helper\nemits the \"Event\" signal before the server is able to register a handler:\n\n   NM_DHCP_HELPER=/usr/libexec/nm-dhcp-helper\n   nmcli general logging level TRACE\n   for i in `seq 1 500`; do $NM_DHCP_HELPER & done\n   journalctl -u NetworkManager --since '1 min ago' | grep \"didn't have associated interface\" | wc -l\n    499\n\nAvoid that, by calling the synchronous D-Bus method \"Notify\".\n\nInterestingly, this race seem to exist since 2007.\n\nActually, we called g_dbus_connection_signal_subscribe() from inside\nGDBusServer:new-connection signal. So it is not clear how such a race\ncould exist. I was not able to reproduce it by putting a sleep\nbefore g_dbus_connection_signal_subscribe(). On the other hand, there\nis bug rh#1372854 and above reproducer which strongly indicates that\nevents can be lost under certain circumstances.\nNow we instead g_dbus_connection_register_object() from the\nnew-connection signal. According to my tests there was no more race\nas also backed by glib's documentation. Still, keep a simple retry-loop\nin nm-dhcp-helper just to be sure.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1372854\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1373276","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/2856a658b38df88494187c811415a198a424e1f2"},{"sha":"42519abdbf6c9778a9f9421e704181b22d4df684","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"dhcp: merge branch 'th/dhcp-helper-sync-notify-rh1372854'\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1372854","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/42519abdbf6c9778a9f9421e704181b22d4df684"}]}
{"actor":{"display_login":"lkundrak"}}