{"action":"closed","issue":{"url":"https://api.github.com/repos/qcubed/framework/issues/695","repository_url":"https://api.github.com/repos/qcubed/framework","labels_url":"https://api.github.com/repos/qcubed/framework/issues/695/labels{/name}","comments_url":"https://api.github.com/repos/qcubed/framework/issues/695/comments","events_url":"https://api.github.com/repos/qcubed/framework/issues/695/events","html_url":"https://github.com/qcubed/framework/issues/695","id":81944811,"number":695,"title":"Dialogs and Alerts","user":{"login":"spekary","id":755757,"avatar_url":"https://avatars.githubusercontent.com/u/755757?v=3","gravatar_id":"","url":"https://api.github.com/users/spekary","html_url":"https://github.com/spekary","followers_url":"https://api.github.com/users/spekary/followers","following_url":"https://api.github.com/users/spekary/following{/other_user}","gists_url":"https://api.github.com/users/spekary/gists{/gist_id}","starred_url":"https://api.github.com/users/spekary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spekary/subscriptions","organizations_url":"https://api.github.com/users/spekary/orgs","repos_url":"https://api.github.com/users/spekary/repos","events_url":"https://api.github.com/users/spekary/events{/privacy}","received_events_url":"https://api.github.com/users/spekary/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/qcubed/framework/milestones/5","html_url":"https://github.com/qcubed/framework/milestones/3.0%20Release","labels_url":"https://api.github.com/repos/qcubed/framework/milestones/5/labels","id":247832,"number":5,"title":"3.0 Release","description":"Major infrastructure changes:\r\n1. PHP 5.4+ (for composer)\r\n2. Directory restructuring (to simplify the contribution to the QCubed framework)\r\n3. Composer for all dependencies, plugins and for QCubed itself","creator":{"login":"olegabr","id":2850808,"avatar_url":"https://avatars.githubusercontent.com/u/2850808?v=3","gravatar_id":"","url":"https://api.github.com/users/olegabr","html_url":"https://github.com/olegabr","followers_url":"https://api.github.com/users/olegabr/followers","following_url":"https://api.github.com/users/olegabr/following{/other_user}","gists_url":"https://api.github.com/users/olegabr/gists{/gist_id}","starred_url":"https://api.github.com/users/olegabr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegabr/subscriptions","organizations_url":"https://api.github.com/users/olegabr/orgs","repos_url":"https://api.github.com/users/olegabr/repos","events_url":"https://api.github.com/users/olegabr/events{/privacy}","received_events_url":"https://api.github.com/users/olegabr/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":67,"state":"open","created_at":"2013-01-20T08:31:38Z","updated_at":"2016-06-28T17:24:09Z","due_on":"2016-07-23T18:30:00Z","closed_at":null},"comments":4,"created_at":"2015-05-28T14:11:06Z","updated_at":"2016-06-28T17:24:09Z","closed_at":"2016-06-28T17:24:09Z","body":"Its been on my todo list for a while to do some mods to the dialog code, and to enable some alerts in the code. The priority in this work would be to try to keep as much of the current functionality as possible, while improving efficiency, adding alerts, and looking for opportunities to be able to bring up alerts and dialogs by making a simple call, rather than needing to assemble a QDialog subclass and making it a member of the form.\r\n\r\nDialogs currently are hidden html that are always on the page. You show them by calling Open(), which basically just makes them visible. With a lot of dialogs, this can clutter the DOM. Also, doing it this way doesn't save all that much traffic across the wire, as most of the dialog would get redrawn when showing anyways in order to populate the data.\r\n\r\nAn alternate way to do this would be to have an entire dialog be sent through ajax when needed. This is partly done by the deprecated ShowDialog code that is there now. \r\n\r\nIn order to support creating and removing dialogs on the fly, and not needing to make them objects you set up in Form_Create, we will need to make some changes to how controls get inserted. I may be mistaken, but I don't think the current architecture supports dynamically adding controls to a form at the top level of the form. Currently they must be child controls of a control that is already up. That could be fixed with some changes to qcubed.js.\r\n\r\nTo do simple dialogs, like alerts and confirmations, I think a modification to qcubed.js could be done to put up a dialog with a string and some buttons, and then fire an event that shows what button were clicked, and that would automatically removed the dialog from the screen at the same time.\r\n\r\nThe thing I want to think through is how to do this in a way that could be over-ridden to support something like Bootstrap dialogs through the bootstrap plugin."}}
{"actor":{"display_login":"spekary"}}