{"action":"created","comment":{"url":"https://api.github.com/repos/xapian/xapian/pulls/comments/92901063","pull_request_review_id":13426835,"id":92901063,"diff_hunk":"@@ -136,7 +142,8 @@ TfIdfWeight::get_maxpart() const\n {\n     Xapian::termcount wdf_max = get_wdf_upper_bound();\n     Xapian::termcount len_min = get_doclength_lower_bound();\n-    double wdfn = get_wdfn(wdf_max, len_min, normalizations[0]);\n+    Xapian::termcount len_max = get_doclength_upper_bound();\n+    double wdfn = get_wdfn(wdf_max, len_min, len_max, normalizations[0]);\n     return get_wtn(wdfn * idfn, normalizations[2]) * wqf_factor;","path":"xapian-core/weight/tfidfweight.cc","position":64,"original_position":62,"commit_id":"29cb3ca590c609a8d480fe89699207e04289f0c7","original_commit_id":"6e8196613b1bed8a67d51eadcd0adeddd1cb1518","user":{"login":"ivmarkp","id":17006136,"avatar_url":"https://avatars.githubusercontent.com/u/17006136?v=3","gravatar_id":"","url":"https://api.github.com/users/ivmarkp","html_url":"https://github.com/ivmarkp","followers_url":"https://api.github.com/users/ivmarkp/followers","following_url":"https://api.github.com/users/ivmarkp/following{/other_user}","gists_url":"https://api.github.com/users/ivmarkp/gists{/gist_id}","starred_url":"https://api.github.com/users/ivmarkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivmarkp/subscriptions","organizations_url":"https://api.github.com/users/ivmarkp/orgs","repos_url":"https://api.github.com/users/ivmarkp/repos","events_url":"https://api.github.com/users/ivmarkp/events{/privacy}","received_events_url":"https://api.github.com/users/ivmarkp/received_events","type":"User","site_admin":false},"body":"Sorry, I don't quite get it. I'm unclear on what values should be passed instead of the current `len_min` and `len_max` parameter values?","created_at":"2016-12-16T23:04:08Z","updated_at":"2016-12-16T23:04:08Z","html_url":"https://github.com/xapian/xapian/pull/128#discussion_r92901063","pull_request_url":"https://api.github.com/repos/xapian/xapian/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/xapian/xapian/pulls/comments/92901063"},"html":{"href":"https://github.com/xapian/xapian/pull/128#discussion_r92901063"},"pull_request":{"href":"https://api.github.com/repos/xapian/xapian/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/xapian/xapian/pulls/128","id":98140758,"html_url":"https://github.com/xapian/xapian/pull/128","diff_url":"https://github.com/xapian/xapian/pull/128.diff","patch_url":"https://github.com/xapian/xapian/pull/128.patch","issue_url":"https://api.github.com/repos/xapian/xapian/issues/128","number":128,"state":"open","locked":false,"title":"L wdf normalisation support in TfIdfWeight","user":{"login":"ivmarkp","id":17006136,"avatar_url":"https://avatars.githubusercontent.com/u/17006136?v=3","gravatar_id":"","url":"https://api.github.com/users/ivmarkp","html_url":"https://github.com/ivmarkp","followers_url":"https://api.github.com/users/ivmarkp/followers","following_url":"https://api.github.com/users/ivmarkp/following{/other_user}","gists_url":"https://api.github.com/users/ivmarkp/gists{/gist_id}","starred_url":"https://api.github.com/users/ivmarkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivmarkp/subscriptions","organizations_url":"https://api.github.com/users/ivmarkp/orgs","repos_url":"https://api.github.com/users/ivmarkp/repos","events_url":"https://api.github.com/users/ivmarkp/events{/privacy}","received_events_url":"https://api.github.com/users/ivmarkp/received_events","type":"User","site_admin":false},"body":"This PR adds support for the L wdf normalisation in TfIdfWeight. \r\n* Code builds successfully.\r\n* All tests pass.","created_at":"2016-12-15T12:22:37Z","updated_at":"2016-12-16T23:04:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f33827b440c5f5495ee93e7cf60aa1a46d3868e0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapian/xapian/pulls/128/commits","review_comments_url":"https://api.github.com/repos/xapian/xapian/pulls/128/comments","review_comment_url":"https://api.github.com/repos/xapian/xapian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapian/xapian/issues/128/comments","statuses_url":"https://api.github.com/repos/xapian/xapian/statuses/29cb3ca590c609a8d480fe89699207e04289f0c7","head":{"label":"ivmarkp:tfidf-logave-norm","ref":"tfidf-logave-norm","sha":"29cb3ca590c609a8d480fe89699207e04289f0c7","user":{"login":"ivmarkp","id":17006136,"avatar_url":"https://avatars.githubusercontent.com/u/17006136?v=3","gravatar_id":"","url":"https://api.github.com/users/ivmarkp","html_url":"https://github.com/ivmarkp","followers_url":"https://api.github.com/users/ivmarkp/followers","following_url":"https://api.github.com/users/ivmarkp/following{/other_user}","gists_url":"https://api.github.com/users/ivmarkp/gists{/gist_id}","starred_url":"https://api.github.com/users/ivmarkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivmarkp/subscriptions","organizations_url":"https://api.github.com/users/ivmarkp/orgs","repos_url":"https://api.github.com/users/ivmarkp/repos","events_url":"https://api.github.com/users/ivmarkp/events{/privacy}","received_events_url":"https://api.github.com/users/ivmarkp/received_events","type":"User","site_admin":false},"repo":{"id":53715784,"name":"xapian","full_name":"ivmarkp/xapian","owner":{"login":"ivmarkp","id":17006136,"avatar_url":"https://avatars.githubusercontent.com/u/17006136?v=3","gravatar_id":"","url":"https://api.github.com/users/ivmarkp","html_url":"https://github.com/ivmarkp","followers_url":"https://api.github.com/users/ivmarkp/followers","following_url":"https://api.github.com/users/ivmarkp/following{/other_user}","gists_url":"https://api.github.com/users/ivmarkp/gists{/gist_id}","starred_url":"https://api.github.com/users/ivmarkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivmarkp/subscriptions","organizations_url":"https://api.github.com/users/ivmarkp/orgs","repos_url":"https://api.github.com/users/ivmarkp/repos","events_url":"https://api.github.com/users/ivmarkp/events{/privacy}","received_events_url":"https://api.github.com/users/ivmarkp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivmarkp/xapian","description":"Mirror of the Xapian repository.  You're welcome to open pull requests on github (they'll just get merged indirectly).","fork":true,"url":"https://api.github.com/repos/ivmarkp/xapian","forks_url":"https://api.github.com/repos/ivmarkp/xapian/forks","keys_url":"https://api.github.com/repos/ivmarkp/xapian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivmarkp/xapian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivmarkp/xapian/teams","hooks_url":"https://api.github.com/repos/ivmarkp/xapian/hooks","issue_events_url":"https://api.github.com/repos/ivmarkp/xapian/issues/events{/number}","events_url":"https://api.github.com/repos/ivmarkp/xapian/events","assignees_url":"https://api.github.com/repos/ivmarkp/xapian/assignees{/user}","branches_url":"https://api.github.com/repos/ivmarkp/xapian/branches{/branch}","tags_url":"https://api.github.com/repos/ivmarkp/xapian/tags","blobs_url":"https://api.github.com/repos/ivmarkp/xapian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivmarkp/xapian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivmarkp/xapian/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivmarkp/xapian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivmarkp/xapian/statuses/{sha}","languages_url":"https://api.github.com/repos/ivmarkp/xapian/languages","stargazers_url":"https://api.github.com/repos/ivmarkp/xapian/stargazers","contributors_url":"https://api.github.com/repos/ivmarkp/xapian/contributors","subscribers_url":"https://api.github.com/repos/ivmarkp/xapian/subscribers","subscription_url":"https://api.github.com/repos/ivmarkp/xapian/subscription","commits_url":"https://api.github.com/repos/ivmarkp/xapian/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivmarkp/xapian/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivmarkp/xapian/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivmarkp/xapian/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivmarkp/xapian/contents/{+path}","compare_url":"https://api.github.com/repos/ivmarkp/xapian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivmarkp/xapian/merges","archive_url":"https://api.github.com/repos/ivmarkp/xapian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivmarkp/xapian/downloads","issues_url":"https://api.github.com/repos/ivmarkp/xapian/issues{/number}","pulls_url":"https://api.github.com/repos/ivmarkp/xapian/pulls{/number}","milestones_url":"https://api.github.com/repos/ivmarkp/xapian/milestones{/number}","notifications_url":"https://api.github.com/repos/ivmarkp/xapian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivmarkp/xapian/labels{/name}","releases_url":"https://api.github.com/repos/ivmarkp/xapian/releases{/id}","deployments_url":"https://api.github.com/repos/ivmarkp/xapian/deployments","created_at":"2016-03-12T05:46:48Z","updated_at":"2016-03-12T05:46:55Z","pushed_at":"2016-12-16T09:34:24Z","git_url":"git://github.com/ivmarkp/xapian.git","ssh_url":"git@github.com:ivmarkp/xapian.git","clone_url":"https://github.com/ivmarkp/xapian.git","svn_url":"https://github.com/ivmarkp/xapian","homepage":"https://xapian.org/","size":76132,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapian:master","ref":"master","sha":"ce33b20d98f02d0f6aa1e5c94c30b9cda10ef09a","user":{"login":"xapian","id":312861,"avatar_url":"https://avatars.githubusercontent.com/u/312861?v=3","gravatar_id":"","url":"https://api.github.com/users/xapian","html_url":"https://github.com/xapian","followers_url":"https://api.github.com/users/xapian/followers","following_url":"https://api.github.com/users/xapian/following{/other_user}","gists_url":"https://api.github.com/users/xapian/gists{/gist_id}","starred_url":"https://api.github.com/users/xapian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapian/subscriptions","organizations_url":"https://api.github.com/users/xapian/orgs","repos_url":"https://api.github.com/users/xapian/repos","events_url":"https://api.github.com/users/xapian/events{/privacy}","received_events_url":"https://api.github.com/users/xapian/received_events","type":"Organization","site_admin":false},"repo":{"id":735981,"name":"xapian","full_name":"xapian/xapian","owner":{"login":"xapian","id":312861,"avatar_url":"https://avatars.githubusercontent.com/u/312861?v=3","gravatar_id":"","url":"https://api.github.com/users/xapian","html_url":"https://github.com/xapian","followers_url":"https://api.github.com/users/xapian/followers","following_url":"https://api.github.com/users/xapian/following{/other_user}","gists_url":"https://api.github.com/users/xapian/gists{/gist_id}","starred_url":"https://api.github.com/users/xapian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapian/subscriptions","organizations_url":"https://api.github.com/users/xapian/orgs","repos_url":"https://api.github.com/users/xapian/repos","events_url":"https://api.github.com/users/xapian/events{/privacy}","received_events_url":"https://api.github.com/users/xapian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapian/xapian","description":"Mirror of the Xapian repository.  You're welcome to open pull requests on github (they'll just get merged indirectly).","fork":false,"url":"https://api.github.com/repos/xapian/xapian","forks_url":"https://api.github.com/repos/xapian/xapian/forks","keys_url":"https://api.github.com/repos/xapian/xapian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapian/xapian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapian/xapian/teams","hooks_url":"https://api.github.com/repos/xapian/xapian/hooks","issue_events_url":"https://api.github.com/repos/xapian/xapian/issues/events{/number}","events_url":"https://api.github.com/repos/xapian/xapian/events","assignees_url":"https://api.github.com/repos/xapian/xapian/assignees{/user}","branches_url":"https://api.github.com/repos/xapian/xapian/branches{/branch}","tags_url":"https://api.github.com/repos/xapian/xapian/tags","blobs_url":"https://api.github.com/repos/xapian/xapian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapian/xapian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapian/xapian/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapian/xapian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapian/xapian/statuses/{sha}","languages_url":"https://api.github.com/repos/xapian/xapian/languages","stargazers_url":"https://api.github.com/repos/xapian/xapian/stargazers","contributors_url":"https://api.github.com/repos/xapian/xapian/contributors","subscribers_url":"https://api.github.com/repos/xapian/xapian/subscribers","subscription_url":"https://api.github.com/repos/xapian/xapian/subscription","commits_url":"https://api.github.com/repos/xapian/xapian/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapian/xapian/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapian/xapian/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapian/xapian/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapian/xapian/contents/{+path}","compare_url":"https://api.github.com/repos/xapian/xapian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapian/xapian/merges","archive_url":"https://api.github.com/repos/xapian/xapian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapian/xapian/downloads","issues_url":"https://api.github.com/repos/xapian/xapian/issues{/number}","pulls_url":"https://api.github.com/repos/xapian/xapian/pulls{/number}","milestones_url":"https://api.github.com/repos/xapian/xapian/milestones{/number}","notifications_url":"https://api.github.com/repos/xapian/xapian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapian/xapian/labels{/name}","releases_url":"https://api.github.com/repos/xapian/xapian/releases{/id}","deployments_url":"https://api.github.com/repos/xapian/xapian/deployments","created_at":"2010-06-23T15:51:03Z","updated_at":"2016-12-09T15:24:12Z","pushed_at":"2016-12-16T09:34:26Z","git_url":"git://github.com/xapian/xapian.git","ssh_url":"git@github.com:xapian/xapian.git","clone_url":"https://github.com/xapian/xapian.git","svn_url":"https://github.com/xapian/xapian","homepage":"https://xapian.org/","size":76579,"stargazers_count":294,"watchers_count":294,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":15,"forks":154,"open_issues":15,"watchers":294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapian/xapian/pulls/128"},"html":{"href":"https://github.com/xapian/xapian/pull/128"},"issue":{"href":"https://api.github.com/repos/xapian/xapian/issues/128"},"comments":{"href":"https://api.github.com/repos/xapian/xapian/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/xapian/xapian/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/xapian/xapian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapian/xapian/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/xapian/xapian/statuses/29cb3ca590c609a8d480fe89699207e04289f0c7"}}}}
{"actor":{"display_login":"ivmarkp"}}