{"action":"created","issue":{"url":"https://api.github.com/repos/edvin/tornadofx/issues/67","repository_url":"https://api.github.com/repos/edvin/tornadofx","labels_url":"https://api.github.com/repos/edvin/tornadofx/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/edvin/tornadofx/issues/67/comments","events_url":"https://api.github.com/repos/edvin/tornadofx/issues/67/events","html_url":"https://github.com/edvin/tornadofx/issues/67","id":145503350,"number":67,"title":"Streamlining CellFactories","user":{"login":"thomasnield","id":7420801,"avatar_url":"https://avatars.githubusercontent.com/u/7420801?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasnield","html_url":"https://github.com/thomasnield","followers_url":"https://api.github.com/users/thomasnield/followers","following_url":"https://api.github.com/users/thomasnield/following{/other_user}","gists_url":"https://api.github.com/users/thomasnield/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasnield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasnield/subscriptions","organizations_url":"https://api.github.com/users/thomasnield/orgs","repos_url":"https://api.github.com/users/thomasnield/repos","events_url":"https://api.github.com/users/thomasnield/events{/privacy}","received_events_url":"https://api.github.com/users/thomasnield/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-03T13:59:57Z","updated_at":"2016-04-03T17:37:28Z","closed_at":null,"body":"I wonder if there is opportunity to improve the cell factories for `TableView` and other data controls. \r\n\r\nFor instance, setting a mutable column in `TableView` to use a `ComboBoxTableCell` feels like it could be streamlined. \r\n\r\n```kotlin\r\ncolumn(\"CATEGORY\", ParsedTransaction::categoryProperty).apply {\r\n\tcellFactory = ComboBoxTableCell.forTableColumn(Category.all)\r\n\tsetOnEditCommit {\r\n\t\tit.tableView.items[it.tablePosition.row].category = it.newValue\r\n\t}\r\n}\r\n```\r\n\r\nIt really should be just as easy as giving a `List<R>` or an `ObservableList<R>` for a given `TableColumn<T,R>` and the `ComboBox` just plugs in automagically.\r\n\r\n```kotlin\r\ncolumn(\"CATEGORY\", ParsedTransaction::categoryProperty).apply {\r\n        applyComboBox(Category.all)\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/edvin/tornadofx/issues/comments/205019098","html_url":"https://github.com/edvin/tornadofx/issues/67#issuecomment-205019098","issue_url":"https://api.github.com/repos/edvin/tornadofx/issues/67","id":205019098,"user":{"login":"edvin","id":977035,"avatar_url":"https://avatars.githubusercontent.com/u/977035?v=3","gravatar_id":"","url":"https://api.github.com/users/edvin","html_url":"https://github.com/edvin","followers_url":"https://api.github.com/users/edvin/followers","following_url":"https://api.github.com/users/edvin/following{/other_user}","gists_url":"https://api.github.com/users/edvin/gists{/gist_id}","starred_url":"https://api.github.com/users/edvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edvin/subscriptions","organizations_url":"https://api.github.com/users/edvin/orgs","repos_url":"https://api.github.com/users/edvin/repos","events_url":"https://api.github.com/users/edvin/events{/privacy}","received_events_url":"https://api.github.com/users/edvin/received_events","type":"User","site_admin":false},"created_at":"2016-04-03T17:37:28Z","updated_at":"2016-04-03T17:37:28Z","body":"I think the default behavior is to cancel the commit when you just leave focus from the cell, which is counter not what users expect. Is this what you're experiencing?"}}