{"push_id":1437028587,"size":1,"distinct_size":1,"ref":"refs/heads/develop","head":"f59f1cb42ac97611e16184b2e8438087482306b0","before":"90f23b8a9a41693cf34a97030516b4567b5410dd","commits":[{"sha":"f59f1cb42ac97611e16184b2e8438087482306b0","author":{"name":"Ashley Engelund","email":"9a6bdc7681b84fb8633f8efac01fa948ed039ace@users.noreply.github.com"},"message":"Approving member creates their company (#54)\n\n* first scenario for approving a member\r\n* correcting the email  in userid; correcting the name of the field\r\n* wip - accepting the application...\r\n* hash key is a string, not a symbol\r\n* added comment - next to be done\r\n* finished writing the simple scenario\r\n* if status changed to Accepted, save/create related info, then redirect to edit page\r\n* assertion step: on the edit page for <a particular person>\r\n* Can't check for the company by name, since we have no name yet; wording of fields, etc\r\n* cannot require presence of name; we don't have it until after the member logs in a fills out their company page\r\n* we have to have an email, so take the individual's email for now.\r\n* only allow the admin to edit the membership_number.  user/owner can view it\r\n* admin must be able to edit membership_number if the application has been accepted\r\n* name *can* be blank, now.  (when application is accepted, we only have a number, but have to make a companyy\r\n* moved scenario 'change status to accepted' to 'approve membership' feature\r\n* status name changed from 'approved' to 'Accepted'\r\n* moved 'submit' into the edit page\r\n* had to move the 'submit' back into the fields (so new.html.haml would work again)\r\n* status changed from 'approved' to Accepted (background data fixed)\r\n* added scenarios: member is added to existing company.  Member is approved, then changed to rejected.\r\n* helper and a bit of spec; ensure CollectionAssociation is really loaded when we check if it's empty\r\nSee the documentation for the class ActiveRecord::Associations::CollectionAssociation\r\nThis can be an issue especially for HABTM associations.  Tests were failing when I was checking to see if the collections was empty.  Needed to ensure the information was really loaded.\r\n* rename to 'all_business_categories' to avoid confusion.  use helper to ensure all data is really loaded when we check empty\r\n* rename to 'all_business_categories' to avoid confusion. Use helper method to ensure all data is loaded when we check for empty\r\n* comment out lines that won't work correctly in the testing. (FactoryGirl + association caching problems?).  that is already tested in other feature scenarios.\r\n* Removes comments and second validation of company_number in company.rb","distinct":true,"url":"https://api.github.com/repos/AgileVentures/shf-project/commits/f59f1cb42ac97611e16184b2e8438087482306b0"}]}
{"actor":{"display_login":"thesuss"}}