{"action":"created","comment":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments/82231550","pull_request_review_id":3153507,"id":82231550,"diff_hunk":"@@ -15,25 +15,114 @@\n # specific language governing permissions and limitations\n # under the License.\n \n-\n+import errno\n import pytest\n+import shutil\n+import tempfile\n+import types\n \n+from selenium.webdriver.firefox.firefox_binary import FirefoxBinary\n+from selenium.webdriver.firefox.firefox_profile import FirefoxProfile\n+from selenium.webdriver.firefox.options import Log, Options\n from selenium.webdriver import Firefox\n-from selenium.webdriver.firefox.options import Options\n \n \n @pytest.fixture\n-def driver(capabilities):\n-    options = Options()\n-    driver = Firefox(\n-        capabilities=capabilities,\n-        firefox_options=options)\n+def driver(options = None):","path":"py/test/selenium/webdriver/marionette/mn_options_tests.py","position":null,"original_position":24,"commit_id":"161dd767150ef28190ebb2618607391ad0fff15b","original_commit_id":"6e30487c047ebf6c61b8413581bce0d9434e0c2e","user":{"login":"andreastt","id":399120,"avatar_url":"https://avatars.githubusercontent.com/u/399120?v=3","gravatar_id":"","url":"https://api.github.com/users/andreastt","html_url":"https://github.com/andreastt","followers_url":"https://api.github.com/users/andreastt/followers","following_url":"https://api.github.com/users/andreastt/following{/other_user}","gists_url":"https://api.github.com/users/andreastt/gists{/gist_id}","starred_url":"https://api.github.com/users/andreastt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreastt/subscriptions","organizations_url":"https://api.github.com/users/andreastt/orgs","repos_url":"https://api.github.com/users/andreastt/repos","events_url":"https://api.github.com/users/andreastt/events{/privacy}","received_events_url":"https://api.github.com/users/andreastt/received_events","type":"User","site_admin":false},"body":"Reverted.","created_at":"2016-10-06T16:42:34Z","updated_at":"2016-10-06T16:42:34Z","html_url":"https://github.com/SeleniumHQ/selenium/pull/2882#discussion_r82231550","pull_request_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2882","_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments/82231550"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/2882#discussion_r82231550"},"pull_request":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2882"}}},"pull_request":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2882","id":88284806,"html_url":"https://github.com/SeleniumHQ/selenium/pull/2882","diff_url":"https://github.com/SeleniumHQ/selenium/pull/2882.diff","patch_url":"https://github.com/SeleniumHQ/selenium/pull/2882.patch","issue_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/2882","number":2882,"state":"open","locked":false,"title":"New FirefoxDriver ctor precedence logic and moz:firefoxOptions su…","user":{"login":"andreastt","id":399120,"avatar_url":"https://avatars.githubusercontent.com/u/399120?v=3","gravatar_id":"","url":"https://api.github.com/users/andreastt","html_url":"https://github.com/andreastt","followers_url":"https://api.github.com/users/andreastt/followers","following_url":"https://api.github.com/users/andreastt/following{/other_user}","gists_url":"https://api.github.com/users/andreastt/gists{/gist_id}","starred_url":"https://api.github.com/users/andreastt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreastt/subscriptions","organizations_url":"https://api.github.com/users/andreastt/orgs","repos_url":"https://api.github.com/users/andreastt/repos","events_url":"https://api.github.com/users/andreastt/events{/privacy}","received_events_url":"https://api.github.com/users/andreastt/received_events","type":"User","site_admin":false},"body":"This change tries to make sense of the keyword arguments accepted by\r\nFirefoxDriver's constructor in the transition phase between the Firefox\r\nadd-on driver and the Mozilla supported geckodriver HTTP service.\r\n\r\nPrior to this patch, which arguments were consumed and respected varied\r\ngreatly on whether the `capabilities[\"marionette\"]` key was set to true.\r\nFollowing this change, the options passed on to geckodriver will\r\nconsistently come out of firefox.Options.\r\n\r\nThe patch implements precedence logic for `capabilities`,\r\n`firefox_options`, and `firefox_binary`/`firefox_profile`.  They will\r\npopulate the underlying data model in that order, which means a binary-\r\nor profile location set in `firefox_options` will override one set in the\r\n`capabilities` dictionary, and that `firefox_binary` and `firefox_profile`\r\nwill override both of these.\r\n\r\nThe goal is to make it predictable what key is chosen, and to make the\r\nunderlying data model somewhat easier to understand.  The latter is\r\nparticularly important because the extension connection used for the old\r\nFirefox add-on does not accept a binary, profile, or arguments through\r\ncapabilities since it is the Python bindings themselves that manage the\r\nlifetime of the browser.\r\n\r\nIn the case of geckodriver, which is an external HTTP service, it\r\nmanages the lifetime and accepts a `moz:firefoxOptions` dictionary that\r\nis not unlike `chromeOptions` as of version 0.11.0.  Versions prior to\r\ngeckodriver 0.11.0 accepted `firefox_binary`, `firefox_profile`, and\r\n`firefox_args` as top-level entries on the capabilities JSON Object.\r\nThis is no longer supported behaviour by either the Python bindings\r\nor geckodriver.\r\n\r\nFixes https://github.com/mozilla/geckodriver/issues/228.","created_at":"2016-10-06T15:26:17Z","updated_at":"2016-10-06T16:42:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"451e5bec72b09363b369a5ffa749657781858eca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2882/commits","review_comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2882/comments","review_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/2882/comments","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/161dd767150ef28190ebb2618607391ad0fff15b","head":{"label":"andreastt:py-firefoxoptions","ref":"py-firefoxoptions","sha":"161dd767150ef28190ebb2618607391ad0fff15b","user":{"login":"andreastt","id":399120,"avatar_url":"https://avatars.githubusercontent.com/u/399120?v=3","gravatar_id":"","url":"https://api.github.com/users/andreastt","html_url":"https://github.com/andreastt","followers_url":"https://api.github.com/users/andreastt/followers","following_url":"https://api.github.com/users/andreastt/following{/other_user}","gists_url":"https://api.github.com/users/andreastt/gists{/gist_id}","starred_url":"https://api.github.com/users/andreastt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreastt/subscriptions","organizations_url":"https://api.github.com/users/andreastt/orgs","repos_url":"https://api.github.com/users/andreastt/repos","events_url":"https://api.github.com/users/andreastt/events{/privacy}","received_events_url":"https://api.github.com/users/andreastt/received_events","type":"User","site_admin":false},"repo":{"id":32645944,"name":"selenium","full_name":"andreastt/selenium","owner":{"login":"andreastt","id":399120,"avatar_url":"https://avatars.githubusercontent.com/u/399120?v=3","gravatar_id":"","url":"https://api.github.com/users/andreastt","html_url":"https://github.com/andreastt","followers_url":"https://api.github.com/users/andreastt/followers","following_url":"https://api.github.com/users/andreastt/following{/other_user}","gists_url":"https://api.github.com/users/andreastt/gists{/gist_id}","starred_url":"https://api.github.com/users/andreastt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreastt/subscriptions","organizations_url":"https://api.github.com/users/andreastt/orgs","repos_url":"https://api.github.com/users/andreastt/repos","events_url":"https://api.github.com/users/andreastt/events{/privacy}","received_events_url":"https://api.github.com/users/andreastt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreastt/selenium","description":"A browser automation framework and ecosystem.","fork":true,"url":"https://api.github.com/repos/andreastt/selenium","forks_url":"https://api.github.com/repos/andreastt/selenium/forks","keys_url":"https://api.github.com/repos/andreastt/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreastt/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreastt/selenium/teams","hooks_url":"https://api.github.com/repos/andreastt/selenium/hooks","issue_events_url":"https://api.github.com/repos/andreastt/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/andreastt/selenium/events","assignees_url":"https://api.github.com/repos/andreastt/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/andreastt/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/andreastt/selenium/tags","blobs_url":"https://api.github.com/repos/andreastt/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreastt/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreastt/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreastt/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreastt/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/andreastt/selenium/languages","stargazers_url":"https://api.github.com/repos/andreastt/selenium/stargazers","contributors_url":"https://api.github.com/repos/andreastt/selenium/contributors","subscribers_url":"https://api.github.com/repos/andreastt/selenium/subscribers","subscription_url":"https://api.github.com/repos/andreastt/selenium/subscription","commits_url":"https://api.github.com/repos/andreastt/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreastt/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreastt/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreastt/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreastt/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/andreastt/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreastt/selenium/merges","archive_url":"https://api.github.com/repos/andreastt/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreastt/selenium/downloads","issues_url":"https://api.github.com/repos/andreastt/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/andreastt/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/andreastt/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/andreastt/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreastt/selenium/labels{/name}","releases_url":"https://api.github.com/repos/andreastt/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/andreastt/selenium/deployments","created_at":"2015-03-21T19:07:07Z","updated_at":"2016-06-29T13:05:56Z","pushed_at":"2016-10-06T16:42:15Z","git_url":"git://github.com/andreastt/selenium.git","ssh_url":"git@github.com:andreastt/selenium.git","clone_url":"https://github.com/andreastt/selenium.git","svn_url":"https://github.com/andreastt/selenium","homepage":"http://seleniumhq.org/","size":1368728,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SeleniumHQ:master","ref":"master","sha":"3464282e0b2b3e57bf83df43b817bf2a353d175e","user":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":7613257,"name":"selenium","full_name":"SeleniumHQ/selenium","owner":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SeleniumHQ/selenium","description":"A browser automation framework and ecosystem.","fork":false,"url":"https://api.github.com/repos/SeleniumHQ/selenium","forks_url":"https://api.github.com/repos/SeleniumHQ/selenium/forks","keys_url":"https://api.github.com/repos/SeleniumHQ/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeleniumHQ/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeleniumHQ/selenium/teams","hooks_url":"https://api.github.com/repos/SeleniumHQ/selenium/hooks","issue_events_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/SeleniumHQ/selenium/events","assignees_url":"https://api.github.com/repos/SeleniumHQ/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/SeleniumHQ/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/tags","blobs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/SeleniumHQ/selenium/languages","stargazers_url":"https://api.github.com/repos/SeleniumHQ/selenium/stargazers","contributors_url":"https://api.github.com/repos/SeleniumHQ/selenium/contributors","subscribers_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscribers","subscription_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscription","commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeleniumHQ/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/SeleniumHQ/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeleniumHQ/selenium/merges","archive_url":"https://api.github.com/repos/SeleniumHQ/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeleniumHQ/selenium/downloads","issues_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/SeleniumHQ/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/SeleniumHQ/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeleniumHQ/selenium/labels{/name}","releases_url":"https://api.github.com/repos/SeleniumHQ/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/SeleniumHQ/selenium/deployments","created_at":"2013-01-14T21:40:56Z","updated_at":"2016-10-06T14:56:09Z","pushed_at":"2016-10-06T16:42:18Z","git_url":"git://github.com/SeleniumHQ/selenium.git","ssh_url":"git@github.com:SeleniumHQ/selenium.git","clone_url":"https://github.com/SeleniumHQ/selenium.git","svn_url":"https://github.com/SeleniumHQ/selenium","homepage":"http://seleniumhq.org/","size":1419013,"stargazers_count":4526,"watchers_count":4526,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2201,"mirror_url":null,"open_issues_count":446,"forks":2201,"open_issues":446,"watchers":4526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2882"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/2882"},"issue":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/2882"},"comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/2882/comments"},"review_comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2882/comments"},"review_comment":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2882/commits"},"statuses":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/161dd767150ef28190ebb2618607391ad0fff15b"}}}}
{"actor":{"display_login":"andreastt"}}