{"action":"created","issue":{"url":"https://api.github.com/repos/fotinakis/jsonapi-serializers/issues/79","repository_url":"https://api.github.com/repos/fotinakis/jsonapi-serializers","labels_url":"https://api.github.com/repos/fotinakis/jsonapi-serializers/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/fotinakis/jsonapi-serializers/issues/79/comments","events_url":"https://api.github.com/repos/fotinakis/jsonapi-serializers/issues/79/events","html_url":"https://github.com/fotinakis/jsonapi-serializers/pull/79","id":164083647,"number":79,"title":"simple namespace implementation added","user":{"login":"tompesman","id":116475,"avatar_url":"https://avatars.githubusercontent.com/u/116475?v=3","gravatar_id":"","url":"https://api.github.com/users/tompesman","html_url":"https://github.com/tompesman","followers_url":"https://api.github.com/users/tompesman/followers","following_url":"https://api.github.com/users/tompesman/following{/other_user}","gists_url":"https://api.github.com/users/tompesman/gists{/gist_id}","starred_url":"https://api.github.com/users/tompesman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tompesman/subscriptions","organizations_url":"https://api.github.com/users/tompesman/orgs","repos_url":"https://api.github.com/users/tompesman/repos","events_url":"https://api.github.com/users/tompesman/events{/privacy}","received_events_url":"https://api.github.com/users/tompesman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-07-06T14:05:56Z","updated_at":"2016-07-23T23:37:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fotinakis/jsonapi-serializers/pulls/79","html_url":"https://github.com/fotinakis/jsonapi-serializers/pull/79","diff_url":"https://github.com/fotinakis/jsonapi-serializers/pull/79.diff","patch_url":"https://github.com/fotinakis/jsonapi-serializers/pull/79.patch"},"body":"Only thing i've added is the `options` parameter to `find_serializer_class_name` method so that it can use the `options[:namespace]` parameter to prefix the class lookup: `\"#{options[:namespace]}::#{object.class.name}Serializer\"`. The sub serializers are namespaced as well.\r\n\r\nUsage:\r\n`JSONAPI::Serializer.serialize(object, namespace: ::MyApi)`\r\nor\r\n`JSONAPI::Serializer.serialize(object, namespace: '::MyApi')`\r\n\r\nNo test or documentation at the moment, but if this PR is acceptable I can make them."},"comment":{"url":"https://api.github.com/repos/fotinakis/jsonapi-serializers/issues/comments/234747215","html_url":"https://github.com/fotinakis/jsonapi-serializers/pull/79#issuecomment-234747215","issue_url":"https://api.github.com/repos/fotinakis/jsonapi-serializers/issues/79","id":234747215,"user":{"login":"fotinakis","id":75300,"avatar_url":"https://avatars.githubusercontent.com/u/75300?v=3","gravatar_id":"","url":"https://api.github.com/users/fotinakis","html_url":"https://github.com/fotinakis","followers_url":"https://api.github.com/users/fotinakis/followers","following_url":"https://api.github.com/users/fotinakis/following{/other_user}","gists_url":"https://api.github.com/users/fotinakis/gists{/gist_id}","starred_url":"https://api.github.com/users/fotinakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fotinakis/subscriptions","organizations_url":"https://api.github.com/users/fotinakis/orgs","repos_url":"https://api.github.com/users/fotinakis/repos","events_url":"https://api.github.com/users/fotinakis/events{/privacy}","received_events_url":"https://api.github.com/users/fotinakis/received_events","type":"User","site_admin":false},"created_at":"2016-07-23T23:37:21Z","updated_at":"2016-07-23T23:37:21Z","body":"Slowly getting back to this, this looks good to me! One comment above about some cleanup and then good to go."}}
{"actor":{"display_login":"fotinakis"}}