{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/4645","repository_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/4645/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/4645/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/4645/events","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/4645","id":182660234,"number":4645,"title":"Magic link is the new login experience","user":{"login":"kwonye","id":1158819,"avatar_url":"https://avatars.githubusercontent.com/u/1158819?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonye","html_url":"https://github.com/kwonye","followers_url":"https://api.github.com/users/kwonye/followers","following_url":"https://api.github.com/users/kwonye/following{/other_user}","gists_url":"https://api.github.com/users/kwonye/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonye/subscriptions","organizations_url":"https://api.github.com/users/kwonye/orgs","repos_url":"https://api.github.com/users/kwonye/repos","events_url":"https://api.github.com/users/kwonye/events{/privacy}","received_events_url":"https://api.github.com/users/kwonye/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/General","name":"General","color":"006b75"},{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/NUX","name":"NUX","color":"006b75"}],"state":"open","locked":false,"assignee":{"login":"maxme","id":40213,"avatar_url":"https://avatars.githubusercontent.com/u/40213?v=3","gravatar_id":"","url":"https://api.github.com/users/maxme","html_url":"https://github.com/maxme","followers_url":"https://api.github.com/users/maxme/followers","following_url":"https://api.github.com/users/maxme/following{/other_user}","gists_url":"https://api.github.com/users/maxme/gists{/gist_id}","starred_url":"https://api.github.com/users/maxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxme/subscriptions","organizations_url":"https://api.github.com/users/maxme/orgs","repos_url":"https://api.github.com/users/maxme/repos","events_url":"https://api.github.com/users/maxme/events{/privacy}","received_events_url":"https://api.github.com/users/maxme/received_events","type":"User","site_admin":false},"assignees":[{"login":"maxme","id":40213,"avatar_url":"https://avatars.githubusercontent.com/u/40213?v=3","gravatar_id":"","url":"https://api.github.com/users/maxme","html_url":"https://github.com/maxme","followers_url":"https://api.github.com/users/maxme/followers","following_url":"https://api.github.com/users/maxme/following{/other_user}","gists_url":"https://api.github.com/users/maxme/gists{/gist_id}","starred_url":"https://api.github.com/users/maxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxme/subscriptions","organizations_url":"https://api.github.com/users/maxme/orgs","repos_url":"https://api.github.com/users/maxme/repos","events_url":"https://api.github.com/users/maxme/events{/privacy}","received_events_url":"https://api.github.com/users/maxme/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/74","html_url":"https://github.com/wordpress-mobile/WordPress-Android/milestones/6.2","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/74/labels","id":1997595,"number":74,"title":"6.2","description":"","creator":{"login":"maxme","id":40213,"avatar_url":"https://avatars.githubusercontent.com/u/40213?v=3","gravatar_id":"","url":"https://api.github.com/users/maxme","html_url":"https://github.com/maxme","followers_url":"https://api.github.com/users/maxme/followers","following_url":"https://api.github.com/users/maxme/following{/other_user}","gists_url":"https://api.github.com/users/maxme/gists{/gist_id}","starred_url":"https://api.github.com/users/maxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxme/subscriptions","organizations_url":"https://api.github.com/users/maxme/orgs","repos_url":"https://api.github.com/users/maxme/repos","events_url":"https://api.github.com/users/maxme/events{/privacy}","received_events_url":"https://api.github.com/users/maxme/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2016-09-12T08:21:20Z","updated_at":"2016-10-15T18:00:58Z","due_on":"2016-12-05T00:00:00Z","closed_at":null},"comments":7,"created_at":"2016-10-12T23:36:21Z","updated_at":"2016-10-25T18:01:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/4645","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/4645","diff_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/4645.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/4645.patch"},"body":"Fixes #4461 \r\n\r\nWe are going with magic links as the primary way to log in (at least for WordPress.com)\r\n\r\nBecause `MagicLinkSignInActivity/Fragment` was simply subclassing/overriding `SignInActivity/Fragment` it's fairly straight forward. All overridden/new methods have been added.\r\n\r\nTo test:\r\nGo through all log-in situations\r\n\r\n1. Log in with a username/password\r\n2. Log in with an email address/magic link\r\n3. Log in with an email address/password\r\n4. Verify smart lock auto-fills account details if the user already has a password saved\r\n5. Log into a self-hosted site\r\n6. Create a new account on WordPress.com\r\n\r\nNeeds review: @maxme "},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments/256112168","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/4645#issuecomment-256112168","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/4645","id":256112168,"user":{"login":"aforcier","id":9613966,"avatar_url":"https://avatars.githubusercontent.com/u/9613966?v=3","gravatar_id":"","url":"https://api.github.com/users/aforcier","html_url":"https://github.com/aforcier","followers_url":"https://api.github.com/users/aforcier/followers","following_url":"https://api.github.com/users/aforcier/following{/other_user}","gists_url":"https://api.github.com/users/aforcier/gists{/gist_id}","starred_url":"https://api.github.com/users/aforcier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aforcier/subscriptions","organizations_url":"https://api.github.com/users/aforcier/orgs","repos_url":"https://api.github.com/users/aforcier/repos","events_url":"https://api.github.com/users/aforcier/events{/privacy}","received_events_url":"https://api.github.com/users/aforcier/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T18:01:27Z","updated_at":"2016-10-25T18:01:27Z","body":"> What happens if the user mistypes their username and is on WP.com?\r\n\r\nI concede it's not ideal, but the user can:\r\n\r\n1. Press \"Sign in to WordPress.com\" to go back to the username/email screen and correct their username, or\r\n2. Correct their username and password, ignore the URL field and login successfully, or\r\n3. Correct their username and password, enter any `wordpress.com` URL and login successfully (pending https://github.com/wordpress-mobile/WordPress-Android/pull/4686)\r\n\r\n> There's backend work required for this, possibly delaying the feature\r\n\r\nHmm, I'm not sure what backend work would be needed - the `is-available/username?` endpoint seems to be working. What did you have in mind?\r\n\r\n> We don't even know if we'll keep this feature, making additional work on it a sunk-cost if we discard it.\r\n>\r\n> Because the self-hosted user has to click the \"add a self-hosted WordPress site\" currently, I say we ship this as-is and iterate on it after we see the results.\r\n\r\nThis is fair enough, though I might argue that removing one step for some self-hosted users (those using usernames or emails not on WP.com) might help contribute to a net decrease in log-in error rate and prompt us to keep the feature.\r\n\r\nIn any case, I'll leave it up to you and @maxme to decide. 😄"}}
{"actor":{"display_login":"aforcier"}}