{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/sti-wildfly/pulls/comments/56758847","id":56758847,"diff_hunk":"@@ -1,2 +1,12 @@\n #!/bin/bash\n-exec /wildfly/bin/standalone.sh -b 0.0.0.0 -bmanagement 0.0.0.0\n+\n+run_wildfly() {\n+  if [ \"$DEV_MODE\" == true ]; then\n+    exec /wildfly/bin/standalone.sh -b 0.0.0.0 -bmanagement 0.0.0.0 -Dhot.deploy.enabled=true -DENABLE_JPDA=true\n+  else\n+    exec /wildfly/bin/standalone.sh -b 0.0.0.0 -bmanagement 0.0.0.0\n+  fi\n+}\n+\n+run_wildfly","path":"10.0/s2i/bin/run","position":12,"original_position":12,"commit_id":"7d5d7d61103f49aac6fc78d13684e476399661f3","original_commit_id":"797ce887ff800d24efb570955725033db9bf01e1","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"flexible in what sense?  our best practices basically just say \"configuration options should be exposed as env variables so users can control them at build/runtime\"\r\n","created_at":"2016-03-20T03:34:24Z","updated_at":"2016-03-20T03:34:24Z","html_url":"https://github.com/openshift/sti-wildfly/pull/77#discussion_r56758847","pull_request_url":"https://api.github.com/repos/openshift/sti-wildfly/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/openshift/sti-wildfly/pulls/comments/56758847"},"html":{"href":"https://github.com/openshift/sti-wildfly/pull/77#discussion_r56758847"},"pull_request":{"href":"https://api.github.com/repos/openshift/sti-wildfly/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/sti-wildfly/pulls/77","id":63452725,"html_url":"https://github.com/openshift/sti-wildfly/pull/77","diff_url":"https://github.com/openshift/sti-wildfly/pull/77.diff","patch_url":"https://github.com/openshift/sti-wildfly/pull/77.patch","issue_url":"https://api.github.com/repos/openshift/sti-wildfly/issues/77","number":77,"state":"open","locked":false,"title":"Trying to enable DEV_MODE for wildfly","user":{"login":"thesteve0","id":1404099,"avatar_url":"https://avatars.githubusercontent.com/u/1404099?v=3","gravatar_id":"","url":"https://api.github.com/users/thesteve0","html_url":"https://github.com/thesteve0","followers_url":"https://api.github.com/users/thesteve0/followers","following_url":"https://api.github.com/users/thesteve0/following{/other_user}","gists_url":"https://api.github.com/users/thesteve0/gists{/gist_id}","starred_url":"https://api.github.com/users/thesteve0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesteve0/subscriptions","organizations_url":"https://api.github.com/users/thesteve0/orgs","repos_url":"https://api.github.com/users/thesteve0/repos","events_url":"https://api.github.com/users/thesteve0/events{/privacy}","received_events_url":"https://api.github.com/users/thesteve0/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-19T00:30:55Z","updated_at":"2016-03-20T03:34:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0703733338939beb6d3a32cf7a0475693c99b94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/sti-wildfly/pulls/77/commits","review_comments_url":"https://api.github.com/repos/openshift/sti-wildfly/pulls/77/comments","review_comment_url":"https://api.github.com/repos/openshift/sti-wildfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/sti-wildfly/issues/77/comments","statuses_url":"https://api.github.com/repos/openshift/sti-wildfly/statuses/7d5d7d61103f49aac6fc78d13684e476399661f3","head":{"label":"thesteve0:master","ref":"master","sha":"7d5d7d61103f49aac6fc78d13684e476399661f3","user":{"login":"thesteve0","id":1404099,"avatar_url":"https://avatars.githubusercontent.com/u/1404099?v=3","gravatar_id":"","url":"https://api.github.com/users/thesteve0","html_url":"https://github.com/thesteve0","followers_url":"https://api.github.com/users/thesteve0/followers","following_url":"https://api.github.com/users/thesteve0/following{/other_user}","gists_url":"https://api.github.com/users/thesteve0/gists{/gist_id}","starred_url":"https://api.github.com/users/thesteve0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesteve0/subscriptions","organizations_url":"https://api.github.com/users/thesteve0/orgs","repos_url":"https://api.github.com/users/thesteve0/repos","events_url":"https://api.github.com/users/thesteve0/events{/privacy}","received_events_url":"https://api.github.com/users/thesteve0/received_events","type":"User","site_admin":false},"repo":{"id":54238108,"name":"sti-wildfly","full_name":"thesteve0/sti-wildfly","owner":{"login":"thesteve0","id":1404099,"avatar_url":"https://avatars.githubusercontent.com/u/1404099?v=3","gravatar_id":"","url":"https://api.github.com/users/thesteve0","html_url":"https://github.com/thesteve0","followers_url":"https://api.github.com/users/thesteve0/followers","following_url":"https://api.github.com/users/thesteve0/following{/other_user}","gists_url":"https://api.github.com/users/thesteve0/gists{/gist_id}","starred_url":"https://api.github.com/users/thesteve0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesteve0/subscriptions","organizations_url":"https://api.github.com/users/thesteve0/orgs","repos_url":"https://api.github.com/users/thesteve0/repos","events_url":"https://api.github.com/users/thesteve0/events{/privacy}","received_events_url":"https://api.github.com/users/thesteve0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thesteve0/sti-wildfly","description":"","fork":true,"url":"https://api.github.com/repos/thesteve0/sti-wildfly","forks_url":"https://api.github.com/repos/thesteve0/sti-wildfly/forks","keys_url":"https://api.github.com/repos/thesteve0/sti-wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesteve0/sti-wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesteve0/sti-wildfly/teams","hooks_url":"https://api.github.com/repos/thesteve0/sti-wildfly/hooks","issue_events_url":"https://api.github.com/repos/thesteve0/sti-wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/thesteve0/sti-wildfly/events","assignees_url":"https://api.github.com/repos/thesteve0/sti-wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/thesteve0/sti-wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/thesteve0/sti-wildfly/tags","blobs_url":"https://api.github.com/repos/thesteve0/sti-wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesteve0/sti-wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesteve0/sti-wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesteve0/sti-wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesteve0/sti-wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/thesteve0/sti-wildfly/languages","stargazers_url":"https://api.github.com/repos/thesteve0/sti-wildfly/stargazers","contributors_url":"https://api.github.com/repos/thesteve0/sti-wildfly/contributors","subscribers_url":"https://api.github.com/repos/thesteve0/sti-wildfly/subscribers","subscription_url":"https://api.github.com/repos/thesteve0/sti-wildfly/subscription","commits_url":"https://api.github.com/repos/thesteve0/sti-wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesteve0/sti-wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesteve0/sti-wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesteve0/sti-wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesteve0/sti-wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/thesteve0/sti-wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesteve0/sti-wildfly/merges","archive_url":"https://api.github.com/repos/thesteve0/sti-wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesteve0/sti-wildfly/downloads","issues_url":"https://api.github.com/repos/thesteve0/sti-wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/thesteve0/sti-wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/thesteve0/sti-wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/thesteve0/sti-wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesteve0/sti-wildfly/labels{/name}","releases_url":"https://api.github.com/repos/thesteve0/sti-wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/thesteve0/sti-wildfly/deployments","created_at":"2016-03-18T23:53:21Z","updated_at":"2016-03-18T23:53:22Z","pushed_at":"2016-03-20T01:32:10Z","git_url":"git://github.com/thesteve0/sti-wildfly.git","ssh_url":"git@github.com:thesteve0/sti-wildfly.git","clone_url":"https://github.com/thesteve0/sti-wildfly.git","svn_url":"https://github.com/thesteve0/sti-wildfly","homepage":null,"size":1238,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"86428ad34b1db3130fb691e1c6a849e5dcd31cd6","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":19788374,"name":"sti-wildfly","full_name":"openshift/sti-wildfly","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/sti-wildfly","description":"","fork":false,"url":"https://api.github.com/repos/openshift/sti-wildfly","forks_url":"https://api.github.com/repos/openshift/sti-wildfly/forks","keys_url":"https://api.github.com/repos/openshift/sti-wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/sti-wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/sti-wildfly/teams","hooks_url":"https://api.github.com/repos/openshift/sti-wildfly/hooks","issue_events_url":"https://api.github.com/repos/openshift/sti-wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/sti-wildfly/events","assignees_url":"https://api.github.com/repos/openshift/sti-wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/sti-wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/sti-wildfly/tags","blobs_url":"https://api.github.com/repos/openshift/sti-wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/sti-wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/sti-wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/sti-wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/sti-wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/sti-wildfly/languages","stargazers_url":"https://api.github.com/repos/openshift/sti-wildfly/stargazers","contributors_url":"https://api.github.com/repos/openshift/sti-wildfly/contributors","subscribers_url":"https://api.github.com/repos/openshift/sti-wildfly/subscribers","subscription_url":"https://api.github.com/repos/openshift/sti-wildfly/subscription","commits_url":"https://api.github.com/repos/openshift/sti-wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/sti-wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/sti-wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/sti-wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/sti-wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/sti-wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/sti-wildfly/merges","archive_url":"https://api.github.com/repos/openshift/sti-wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/sti-wildfly/downloads","issues_url":"https://api.github.com/repos/openshift/sti-wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/sti-wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/sti-wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/sti-wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/sti-wildfly/labels{/name}","releases_url":"https://api.github.com/repos/openshift/sti-wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/sti-wildfly/deployments","created_at":"2014-05-14T17:05:11Z","updated_at":"2016-03-05T22:12:04Z","pushed_at":"2016-03-20T01:32:11Z","git_url":"git://github.com/openshift/sti-wildfly.git","ssh_url":"git@github.com:openshift/sti-wildfly.git","clone_url":"https://github.com/openshift/sti-wildfly.git","svn_url":"https://github.com/openshift/sti-wildfly","homepage":null,"size":1235,"stargazers_count":12,"watchers_count":12,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":4,"forks":43,"open_issues":4,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/sti-wildfly/pulls/77"},"html":{"href":"https://github.com/openshift/sti-wildfly/pull/77"},"issue":{"href":"https://api.github.com/repos/openshift/sti-wildfly/issues/77"},"comments":{"href":"https://api.github.com/repos/openshift/sti-wildfly/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/sti-wildfly/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/sti-wildfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/sti-wildfly/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/sti-wildfly/statuses/7d5d7d61103f49aac6fc78d13684e476399661f3"}}}}