{"action":"created","issue":{"url":"https://api.github.com/repos/picocms/Pico/issues/358","repository_url":"https://api.github.com/repos/picocms/Pico","labels_url":"https://api.github.com/repos/picocms/Pico/issues/358/labels{/name}","comments_url":"https://api.github.com/repos/picocms/Pico/issues/358/comments","events_url":"https://api.github.com/repos/picocms/Pico/issues/358/events","html_url":"https://github.com/picocms/Pico/pull/358","id":159828376,"number":358,"title":"Customization Redesign & Portfolio","user":{"login":"smcdougall","id":12779160,"avatar_url":"https://avatars.githubusercontent.com/u/12779160?v=3","gravatar_id":"","url":"https://api.github.com/users/smcdougall","html_url":"https://github.com/smcdougall","followers_url":"https://api.github.com/users/smcdougall/followers","following_url":"https://api.github.com/users/smcdougall/following{/other_user}","gists_url":"https://api.github.com/users/smcdougall/gists{/gist_id}","starred_url":"https://api.github.com/users/smcdougall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcdougall/subscriptions","organizations_url":"https://api.github.com/users/smcdougall/orgs","repos_url":"https://api.github.com/users/smcdougall/repos","events_url":"https://api.github.com/users/smcdougall/events{/privacy}","received_events_url":"https://api.github.com/users/smcdougall/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/picocms/Pico/labels/info:%20Feedback%20Needed","name":"info: Feedback Needed","color":"006b75"},{"url":"https://api.github.com/repos/picocms/Pico/labels/info:%20Website","name":"info: Website","color":"f0f0f0"},{"url":"https://api.github.com/repos/picocms/Pico/labels/type:%20Enhancement","name":"type: Enhancement","color":"0e8a16"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":70,"created_at":"2016-06-12T13:46:03Z","updated_at":"2016-10-25T21:57:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/picocms/Pico/pulls/358","html_url":"https://github.com/picocms/Pico/pull/358","diff_url":"https://github.com/picocms/Pico/pull/358.diff","patch_url":"https://github.com/picocms/Pico/pull/358.patch"},"body":"Redesigned Customization page using Webpaint's Portfolio style.\r\n\r\nViewable here: [Themes](http://testing3.mcdougallhome.net/themes/) and [Plugins](http://testing3.mcdougallhome.net/plugins/)\r\n\r\nThis PR is both for the page itself and for the portfolio framework that generates it.\r\n\r\nAlso note that it contains currently unmerged changes from #352 that are unrelated to this PR.  Actual changes begin at `Implemented Portfolio and Revamped Customization.` https://github.com/picocms/Pico/pull/358/commits/8819d4379aea0814e1bae513660cc65abdba0bb3\r\n\r\nPreviously discussed in #352.\r\n\r\nAreas to improve on:\r\n* [x] Customizable \"Launch Site\" Button Text.\r\n  * [x] What should the text be on `customization`?  Download? Launch Site? View on GitHub? (since I think all but NotePaper go to GitHub).\r\n* [x] Better utilization of `Meta` text in existing tiles...\r\n* [x] Separate Plugins and Themes\r\n* [x] Improve Javascript on `portfolio-detail-view`.\r\n* [x] Multiple categories for themes/plugins - Started, but always room for improvements / more\r\n  * For Themes: Single-page, Static Website, Blog-Style, etc.\r\n  * For Plugins: Blogging, Social, Developer, etc\r\n* [x] Better representation of Plugins (especially when too abstract for a screenshot)\r\n    * [x] Possible Style: \"muted\", gray puzzle piece background with persistent overlay text, but only turns green on hover.\r\n    * [x] Initial Styles and Effect\r\n    * [x] Better Puzzle Piece graphic.\r\n      * [ ] Upload Source Files\r\n* [x] Use Jekyll \"Collections\" to separate each theme and plugin into its own file.\r\n  * [x] Migrate Heading and Description to `content`\r\n    * [x] ~~Migrate Heading~~\r\n      * Markdownified Heading instead, since it's not contiguous with the Description.\r\n      * Also, it's used for the Overlay, so it needs to be in an isolated variable for that.\r\n    * [x] Migrate Description\r\n   * [x] Provide backwards compatibility with YAML method for non-collection based portfolio pages.\r\n  * [x] Provide a blank YAML template that contributors can fill out to easily add their content.\r\n    * [x] Include submission guidelines / readme with things like screenshot resolution and location.\r\n     * [ ] Fork and PR instructions?  ~~This is probably out-of-scope.~~ As Links.\r\n  * [x] Move images into collection\r\n    * [x] Remove \"Theme\" from the names of theme screenshots, as it's redundant now.\r\n    * [ ] Remove \"Default Theme\" images.  Maybe re-purpose them elsewhere.\r\n    * [ ] Use *these* images for the About Page, instead of its own?  This is more likely to be a \"permanent home\" for these theme images, and it's redundant to have two copies.  (Putting this task *here* instead of on #352 because it'll rely on the new customization page collections being committed first.)\r\n      * Probably for Fullsize only, at this point.\r\n* [x] `a` tags in the info section should be white, not green.\r\n* ~~Captions for carousel items?~~ Probably not worth the effort, since we already have a content area.\r\n* [x] Escape *all* variables that are vulnerable to apostrophes.\r\n* ~~Provide \"Documentation\" on how to use `gallery` and `portfolio`.~~ \"Unnecessary\" \r\n  * ~~Don't forget about things like `info._blank`, `page.portfolio.categories`, `include categories=variable` and other examples that may not be represented on the current page.~~\r\n* [x] Fix whitespace on either side of `:` in the Item-Details `<span>`.\r\n* [x] Customize or slow carousel.\r\n  * [x] Slowed\r\n* [x] Second, text-focused, pop-up content area for Plugins page.\r\n* [x] Fix odd cut-off on right edge.\r\n* [x] Update About page URLs ~~(and image locations)~~\r\n* [x] Add styles for `portfolio-detail-view code`\r\n* [x] Better implementation of ~~plugin~~ defaultThumbnail styles trigger\r\n* [ ] Merge new styles with regular styles.\r\n* [x] Correct image paths (and any others) with `{{ site.github.url }}`.  Remove leading `/` from paths.\r\n* [x] Change `myCarousel` ID to `entry-{{ forloop.index0 }}-carousel` or something similar.\r\n* [x] Check commented JS from https://github.com/picocms/Pico/pull/358/commits/e3cd95b4fe3a30d8a3aa82c8db9c38d9d53843fa\r\n* [x] Use the \"active item\" class to make active item stay lit.\r\n* [x] Don't break the styles for \"standalone\" overlay images\r\n* [ ] Make sure that the bg color transitions are located in the right CSS file (pico.css) for consistency with other styles.\r\n* [ ] IE8 Compatible Styles (https://github.com/picocms/Pico/pull/358#issuecomment-247850979)\r\n* [x] Change `meta` to `description`\r\n* [x] New blank `info` lines implementation.\r\n* [ ] Find a replacement for the `None` category? (created when I removed `multi-page`)\r\n* [x] Create Theme/Code image for \"Plus\" tile.\r\n* [ ] Bigger plugin content (excerpts or whole readme's)\r\n* [x] Standardize Description (meta) punctuation.\r\n* [x] Set \"Contribute\" tile layout.\r\n* [x] Change name of `layout` variable.\r\n\r\n---\r\n\r\n* [ ] Investigate odd YAML behavior that is treating my categories as an array instead of a string.  For now, I'm treating this variable as an array (and maybe converting the syntax) since it probably *should* be an array.  It was just confusing because I was expecting a string of HTML ID's separated by spaces.  For comparison, `description` is correctly treated as a string (otherwise it'd be a spaceless jumble of letters).\r\n\r\n```yaml\r\ndescription: Google Analytics for Pico with basic options.<br><br>This plugin will automatically add the Google Analytics tracking script to the < head > section of each page generated by Pico.\r\ncategories: plugin developer. Why is this an array and not a string?\r\n```\r\n\r\nIs creating:\r\n\r\n```json\r\ndescription: \"Google Analytics for Pico with basic options.<br><br>This plugin will automatically add the Google Analytics tracking script to the < head > section of each page generated by Pico.\"\r\ncategories: [\"plugin\",\"developer.\",\"Why\",\"is\",\"this\",\"an\",\"array\",\"and\",\"not\",\"a\",\"string?\"]\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/picocms/Pico/issues/comments/256188893","html_url":"https://github.com/picocms/Pico/pull/358#issuecomment-256188893","issue_url":"https://api.github.com/repos/picocms/Pico/issues/358","id":256188893,"user":{"login":"PhrozenByte","id":920356,"avatar_url":"https://avatars.githubusercontent.com/u/920356?v=3","gravatar_id":"","url":"https://api.github.com/users/PhrozenByte","html_url":"https://github.com/PhrozenByte","followers_url":"https://api.github.com/users/PhrozenByte/followers","following_url":"https://api.github.com/users/PhrozenByte/following{/other_user}","gists_url":"https://api.github.com/users/PhrozenByte/gists{/gist_id}","starred_url":"https://api.github.com/users/PhrozenByte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhrozenByte/subscriptions","organizations_url":"https://api.github.com/users/PhrozenByte/orgs","repos_url":"https://api.github.com/users/PhrozenByte/repos","events_url":"https://api.github.com/users/PhrozenByte/events{/privacy}","received_events_url":"https://api.github.com/users/PhrozenByte/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T21:57:07Z","updated_at":"2016-10-25T21:57:07Z","body":"So true, so true...\r\n\r\nHowever, please don't forget that we don't need full support for old IE versions, support is graduated. No support for IE7. IE8 users get a very basic experience, it doesn't have to look \"perfect\", no eye candy (gradients, animations, transitions...), the only goal is that the page is usable. IE9 users should get a fully functional website that looks good, however, eye candy is optional. Only IE10+ users get full support (some of the eye candy might even require IE11+).\r\n\r\nAfaik the portfolio style already satisfies these requirements! Just IE8 isn't usable at the moment, because title and description are always visible without a background color, what makes them hard to read depending on the thumbnail (see e.g. SimpleTwo). Simply add a background color (maybe with `opacity`/`-ms-filter`) and you're done."}}
{"actor":{"display_login":"PhrozenByte"}}