{"action":"opened","number":2883,"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/2883","id":66427702,"html_url":"https://github.com/mono/mono/pull/2883","diff_url":"https://github.com/mono/mono/pull/2883.diff","patch_url":"https://github.com/mono/mono/pull/2883.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/2883","number":2883,"state":"open","locked":false,"title":"[DO NOT MERGE] [jit] Simplified implementation of generic sharing.","user":{"login":"vargaz","id":186301,"avatar_url":"https://avatars.githubusercontent.com/u/186301?v=3","gravatar_id":"","url":"https://api.github.com/users/vargaz","html_url":"https://github.com/vargaz","followers_url":"https://api.github.com/users/vargaz/followers","following_url":"https://api.github.com/users/vargaz/following{/other_user}","gists_url":"https://api.github.com/users/vargaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vargaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vargaz/subscriptions","organizations_url":"https://api.github.com/users/vargaz/orgs","repos_url":"https://api.github.com/users/vargaz/repos","events_url":"https://api.github.com/users/vargaz/events{/privacy}","received_events_url":"https://api.github.com/users/vargaz/received_events","type":"User","site_admin":false},"body":"These changes aim to simplify the generic sharing code in the JIT. The design is the following:\r\n* Every shared method receives a MonoMethodRgctxArg pointer in the rgctx register.\r\n* The 'mrgctx' field of this structure points to the runtime generic context for that method.\r\n* The method lazily initializes the mrgctx on the first call.\r\n* Each piece of data is stored in the mrgctx, at an offset\r\n  known at compile time. No data is stored in the vtable.\r\n\r\nAdvantages:\r\n* Greatly simplifies the generic sharing code.\r\n* The rgctx trampolines are no longer needed.\r\n* Every piece of data can be loaded from the mrgctx\r\n  using two loads without a call which clobbers registers.\r\n\r\nDisadvantages:\r\n* Every shared method requires an rgctx argument/rgctx trampoline.\r\n* Need to lazily initialize the mrgctx in the method prolog, which\r\n  in the best case is a load and a non taken branch.","created_at":"2016-04-14T04:30:02Z","updated_at":"2016-04-14T04:30:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/2883/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/2883/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/2883/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/919ce2dc45b27d38c7c3cc4e1157725a93c56881","head":{"label":"vargaz:new-gshared","ref":"new-gshared","sha":"919ce2dc45b27d38c7c3cc4e1157725a93c56881","user":{"login":"vargaz","id":186301,"avatar_url":"https://avatars.githubusercontent.com/u/186301?v=3","gravatar_id":"","url":"https://api.github.com/users/vargaz","html_url":"https://github.com/vargaz","followers_url":"https://api.github.com/users/vargaz/followers","following_url":"https://api.github.com/users/vargaz/following{/other_user}","gists_url":"https://api.github.com/users/vargaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vargaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vargaz/subscriptions","organizations_url":"https://api.github.com/users/vargaz/orgs","repos_url":"https://api.github.com/users/vargaz/repos","events_url":"https://api.github.com/users/vargaz/events{/privacy}","received_events_url":"https://api.github.com/users/vargaz/received_events","type":"User","site_admin":false},"repo":{"id":826761,"name":"mono","full_name":"vargaz/mono","owner":{"login":"vargaz","id":186301,"avatar_url":"https://avatars.githubusercontent.com/u/186301?v=3","gravatar_id":"","url":"https://api.github.com/users/vargaz","html_url":"https://github.com/vargaz","followers_url":"https://api.github.com/users/vargaz/followers","following_url":"https://api.github.com/users/vargaz/following{/other_user}","gists_url":"https://api.github.com/users/vargaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vargaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vargaz/subscriptions","organizations_url":"https://api.github.com/users/vargaz/orgs","repos_url":"https://api.github.com/users/vargaz/repos","events_url":"https://api.github.com/users/vargaz/events{/privacy}","received_events_url":"https://api.github.com/users/vargaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vargaz/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/vargaz/mono","forks_url":"https://api.github.com/repos/vargaz/mono/forks","keys_url":"https://api.github.com/repos/vargaz/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vargaz/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vargaz/mono/teams","hooks_url":"https://api.github.com/repos/vargaz/mono/hooks","issue_events_url":"https://api.github.com/repos/vargaz/mono/issues/events{/number}","events_url":"https://api.github.com/repos/vargaz/mono/events","assignees_url":"https://api.github.com/repos/vargaz/mono/assignees{/user}","branches_url":"https://api.github.com/repos/vargaz/mono/branches{/branch}","tags_url":"https://api.github.com/repos/vargaz/mono/tags","blobs_url":"https://api.github.com/repos/vargaz/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vargaz/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vargaz/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/vargaz/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vargaz/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/vargaz/mono/languages","stargazers_url":"https://api.github.com/repos/vargaz/mono/stargazers","contributors_url":"https://api.github.com/repos/vargaz/mono/contributors","subscribers_url":"https://api.github.com/repos/vargaz/mono/subscribers","subscription_url":"https://api.github.com/repos/vargaz/mono/subscription","commits_url":"https://api.github.com/repos/vargaz/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/vargaz/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/vargaz/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/vargaz/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/vargaz/mono/contents/{+path}","compare_url":"https://api.github.com/repos/vargaz/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vargaz/mono/merges","archive_url":"https://api.github.com/repos/vargaz/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vargaz/mono/downloads","issues_url":"https://api.github.com/repos/vargaz/mono/issues{/number}","pulls_url":"https://api.github.com/repos/vargaz/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/vargaz/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/vargaz/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vargaz/mono/labels{/name}","releases_url":"https://api.github.com/repos/vargaz/mono/releases{/id}","deployments_url":"https://api.github.com/repos/vargaz/mono/deployments","created_at":"2010-08-09T15:56:23Z","updated_at":"2015-07-28T17:13:34Z","pushed_at":"2016-04-14T04:29:23Z","git_url":"git://github.com/vargaz/mono.git","ssh_url":"git@github.com:vargaz/mono.git","clone_url":"https://github.com/vargaz/mono.git","svn_url":"https://github.com/vargaz/mono","homepage":"http://www.mono-project.com/","size":369693,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"a06225626c4bb69b1fa80ee03945d4476a6af863","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-04-14T03:34:54Z","pushed_at":"2016-04-14T04:30:02Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":469248,"stargazers_count":4509,"watchers_count":4509,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2158,"mirror_url":null,"open_issues_count":107,"forks":2158,"open_issues":107,"watchers":4509,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/2883"},"html":{"href":"https://github.com/mono/mono/pull/2883"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/2883"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/2883/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/2883/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/2883/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/919ce2dc45b27d38c7c3cc4e1157725a93c56881"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":324,"deletions":12,"changed_files":13}}