{"action":"created","comment":{"url":"https://api.github.com/repos/scootdev/scoot/pulls/comments/76097953","id":76097953,"diff_hunk":"@@ -20,20 +22,27 @@ type SwarmTest struct {\n \tNumWorkers int\n \tCompile    func() error\n \tRun        func() error\n+\tNumJobs    int\n+\tTimeout    time.Duration\n+\tmutex      *sync.Mutex","path":"tests/swarmtest/swarmtest.go","position":22,"original_position":22,"commit_id":"41adbe0795db4510fbf92675593efa3964ec9c59","original_commit_id":"41adbe0795db4510fbf92675593efa3964ec9c59","user":{"login":"CaitieM20","id":3310141,"avatar_url":"https://avatars.githubusercontent.com/u/3310141?v=3","gravatar_id":"","url":"https://api.github.com/users/CaitieM20","html_url":"https://github.com/CaitieM20","followers_url":"https://api.github.com/users/CaitieM20/followers","following_url":"https://api.github.com/users/CaitieM20/following{/other_user}","gists_url":"https://api.github.com/users/CaitieM20/gists{/gist_id}","starred_url":"https://api.github.com/users/CaitieM20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaitieM20/subscriptions","organizations_url":"https://api.github.com/users/CaitieM20/orgs","repos_url":"https://api.github.com/users/CaitieM20/repos","events_url":"https://api.github.com/users/CaitieM20/events{/privacy}","received_events_url":"https://api.github.com/users/CaitieM20/received_events","type":"User","site_admin":false},"body":"Running go test -race ./... returns an error because there is access from multiple go routines to the cmd objects.  \r\n\r\nI assume this is safe because its processes, but to make our test suite happy I added the mutex","created_at":"2016-08-24T17:08:15Z","updated_at":"2016-08-24T17:08:15Z","html_url":"https://github.com/scootdev/scoot/pull/82#discussion_r76097953","pull_request_url":"https://api.github.com/repos/scootdev/scoot/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/comments/76097953"},"html":{"href":"https://github.com/scootdev/scoot/pull/82#discussion_r76097953"},"pull_request":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/scootdev/scoot/pulls/82","id":82469400,"html_url":"https://github.com/scootdev/scoot/pull/82","diff_url":"https://github.com/scootdev/scoot/pull/82.diff","patch_url":"https://github.com/scootdev/scoot/pull/82.patch","issue_url":"https://api.github.com/repos/scootdev/scoot/issues/82","number":82,"state":"open","locked":false,"title":"Swarmtest refactor","user":{"login":"CaitieM20","id":3310141,"avatar_url":"https://avatars.githubusercontent.com/u/3310141?v=3","gravatar_id":"","url":"https://api.github.com/users/CaitieM20","html_url":"https://github.com/CaitieM20","followers_url":"https://api.github.com/users/CaitieM20/followers","following_url":"https://api.github.com/users/CaitieM20/following{/other_user}","gists_url":"https://api.github.com/users/CaitieM20/gists{/gist_id}","starred_url":"https://api.github.com/users/CaitieM20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaitieM20/subscriptions","organizations_url":"https://api.github.com/users/CaitieM20/orgs","repos_url":"https://api.github.com/users/CaitieM20/repos","events_url":"https://api.github.com/users/CaitieM20/events{/privacy}","received_events_url":"https://api.github.com/users/CaitieM20/received_events","type":"User","site_admin":false},"body":"* refactoring swarmtest so it can run as a test as part of our normal test suite\r\n* added a mutex to swarmtest to avoid race conditions, also had to remove cmd.Wait()  due to complicated race conditions.  Not sure how to have a cmd.Wait() in one go routine followed by a cmd.Kill() in another one and not trigger the race detector without doing a big refactor...\r\n* added swarmtest binary to binaries folders so it can be ran locally as well\r\n* moved job & task generators to tests folder\r\n* added numJobs and timeout to run_smoketest_cmd\r\n","created_at":"2016-08-24T01:47:38Z","updated_at":"2016-08-24T17:08:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b10e0f363b9349daa6af5702431c144d3cc5016","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scootdev/scoot/pulls/82/commits","review_comments_url":"https://api.github.com/repos/scootdev/scoot/pulls/82/comments","review_comment_url":"https://api.github.com/repos/scootdev/scoot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scootdev/scoot/issues/82/comments","statuses_url":"https://api.github.com/repos/scootdev/scoot/statuses/41adbe0795db4510fbf92675593efa3964ec9c59","head":{"label":"scootdev:caitie/swarmtest2","ref":"caitie/swarmtest2","sha":"41adbe0795db4510fbf92675593efa3964ec9c59","user":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"repo":{"id":48396966,"name":"scoot","full_name":"scootdev/scoot","owner":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scootdev/scoot","description":"","fork":false,"url":"https://api.github.com/repos/scootdev/scoot","forks_url":"https://api.github.com/repos/scootdev/scoot/forks","keys_url":"https://api.github.com/repos/scootdev/scoot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scootdev/scoot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scootdev/scoot/teams","hooks_url":"https://api.github.com/repos/scootdev/scoot/hooks","issue_events_url":"https://api.github.com/repos/scootdev/scoot/issues/events{/number}","events_url":"https://api.github.com/repos/scootdev/scoot/events","assignees_url":"https://api.github.com/repos/scootdev/scoot/assignees{/user}","branches_url":"https://api.github.com/repos/scootdev/scoot/branches{/branch}","tags_url":"https://api.github.com/repos/scootdev/scoot/tags","blobs_url":"https://api.github.com/repos/scootdev/scoot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scootdev/scoot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scootdev/scoot/git/refs{/sha}","trees_url":"https://api.github.com/repos/scootdev/scoot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scootdev/scoot/statuses/{sha}","languages_url":"https://api.github.com/repos/scootdev/scoot/languages","stargazers_url":"https://api.github.com/repos/scootdev/scoot/stargazers","contributors_url":"https://api.github.com/repos/scootdev/scoot/contributors","subscribers_url":"https://api.github.com/repos/scootdev/scoot/subscribers","subscription_url":"https://api.github.com/repos/scootdev/scoot/subscription","commits_url":"https://api.github.com/repos/scootdev/scoot/commits{/sha}","git_commits_url":"https://api.github.com/repos/scootdev/scoot/git/commits{/sha}","comments_url":"https://api.github.com/repos/scootdev/scoot/comments{/number}","issue_comment_url":"https://api.github.com/repos/scootdev/scoot/issues/comments{/number}","contents_url":"https://api.github.com/repos/scootdev/scoot/contents/{+path}","compare_url":"https://api.github.com/repos/scootdev/scoot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scootdev/scoot/merges","archive_url":"https://api.github.com/repos/scootdev/scoot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scootdev/scoot/downloads","issues_url":"https://api.github.com/repos/scootdev/scoot/issues{/number}","pulls_url":"https://api.github.com/repos/scootdev/scoot/pulls{/number}","milestones_url":"https://api.github.com/repos/scootdev/scoot/milestones{/number}","notifications_url":"https://api.github.com/repos/scootdev/scoot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scootdev/scoot/labels{/name}","releases_url":"https://api.github.com/repos/scootdev/scoot/releases{/id}","deployments_url":"https://api.github.com/repos/scootdev/scoot/deployments","created_at":"2015-12-21T22:14:54Z","updated_at":"2016-08-09T23:32:59Z","pushed_at":"2016-08-24T16:10:33Z","git_url":"git://github.com/scootdev/scoot.git","ssh_url":"git@github.com:scootdev/scoot.git","clone_url":"https://github.com/scootdev/scoot.git","svn_url":"https://github.com/scootdev/scoot","homepage":null,"size":7287,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":8,"default_branch":"master"}},"base":{"label":"scootdev:master","ref":"master","sha":"8caa03e27cab6720337ffb57b8174d29b06b4cc7","user":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"repo":{"id":48396966,"name":"scoot","full_name":"scootdev/scoot","owner":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scootdev/scoot","description":"","fork":false,"url":"https://api.github.com/repos/scootdev/scoot","forks_url":"https://api.github.com/repos/scootdev/scoot/forks","keys_url":"https://api.github.com/repos/scootdev/scoot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scootdev/scoot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scootdev/scoot/teams","hooks_url":"https://api.github.com/repos/scootdev/scoot/hooks","issue_events_url":"https://api.github.com/repos/scootdev/scoot/issues/events{/number}","events_url":"https://api.github.com/repos/scootdev/scoot/events","assignees_url":"https://api.github.com/repos/scootdev/scoot/assignees{/user}","branches_url":"https://api.github.com/repos/scootdev/scoot/branches{/branch}","tags_url":"https://api.github.com/repos/scootdev/scoot/tags","blobs_url":"https://api.github.com/repos/scootdev/scoot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scootdev/scoot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scootdev/scoot/git/refs{/sha}","trees_url":"https://api.github.com/repos/scootdev/scoot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scootdev/scoot/statuses/{sha}","languages_url":"https://api.github.com/repos/scootdev/scoot/languages","stargazers_url":"https://api.github.com/repos/scootdev/scoot/stargazers","contributors_url":"https://api.github.com/repos/scootdev/scoot/contributors","subscribers_url":"https://api.github.com/repos/scootdev/scoot/subscribers","subscription_url":"https://api.github.com/repos/scootdev/scoot/subscription","commits_url":"https://api.github.com/repos/scootdev/scoot/commits{/sha}","git_commits_url":"https://api.github.com/repos/scootdev/scoot/git/commits{/sha}","comments_url":"https://api.github.com/repos/scootdev/scoot/comments{/number}","issue_comment_url":"https://api.github.com/repos/scootdev/scoot/issues/comments{/number}","contents_url":"https://api.github.com/repos/scootdev/scoot/contents/{+path}","compare_url":"https://api.github.com/repos/scootdev/scoot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scootdev/scoot/merges","archive_url":"https://api.github.com/repos/scootdev/scoot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scootdev/scoot/downloads","issues_url":"https://api.github.com/repos/scootdev/scoot/issues{/number}","pulls_url":"https://api.github.com/repos/scootdev/scoot/pulls{/number}","milestones_url":"https://api.github.com/repos/scootdev/scoot/milestones{/number}","notifications_url":"https://api.github.com/repos/scootdev/scoot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scootdev/scoot/labels{/name}","releases_url":"https://api.github.com/repos/scootdev/scoot/releases{/id}","deployments_url":"https://api.github.com/repos/scootdev/scoot/deployments","created_at":"2015-12-21T22:14:54Z","updated_at":"2016-08-09T23:32:59Z","pushed_at":"2016-08-24T16:10:33Z","git_url":"git://github.com/scootdev/scoot.git","ssh_url":"git@github.com:scootdev/scoot.git","clone_url":"https://github.com/scootdev/scoot.git","svn_url":"https://github.com/scootdev/scoot","homepage":null,"size":7287,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/82"},"html":{"href":"https://github.com/scootdev/scoot/pull/82"},"issue":{"href":"https://api.github.com/repos/scootdev/scoot/issues/82"},"comments":{"href":"https://api.github.com/repos/scootdev/scoot/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/scootdev/scoot/statuses/41adbe0795db4510fbf92675593efa3964ec9c59"}}}}
{"actor":{"display_login":"CaitieM20"}}