{"action":"created","comment":{"url":"https://api.github.com/repos/deis/workflow-manager/pulls/comments/67970309","id":67970309,"diff_hunk":"@@ -97,11 +99,21 @@ func TestComponentsHandler(t *testing.T) {\n }\n \n func TestDoctorHandler(t *testing.T) {\n+\tts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {\n+\t\tw.Header().Set(\"Content-Type\", \"application/json; charset=UTF-8\")\n+\t\tif err := json.NewEncoder(w).Encode([]byte(\"\")); err != nil {\n+\t\t\thttp.Error(w, \"error encoding JSON\", http.StatusInternalServerError)\n+\t\t\treturn\n+\t\t}\n+\t}))\n+\tdefer ts.Close()\n+\tapiClient, err := config.GetSwaggerClient(ts.URL)\n \tdoctorHandler := DoctorHandler(\n \t\tmockInstalledComponents{},\n \t\t&mockClusterID{},\n \t\tmockAvailableVersion{},\n \t\tdata.NewFakeKubeSecretGetterCreator(nil, nil),\n+\t\tapiClient,\n \t)\n \tresp, err := getTestHandlerResponse(doctorHandler)","path":"handlers/handlers_test.go","position":36,"original_position":36,"commit_id":"963cf15a17f538157729bae35d5fc8962bad71f6","original_commit_id":"963cf15a17f538157729bae35d5fc8962bad71f6","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"body":"doesn't this start up another server for the versions.deis.com mock?","created_at":"2016-06-21T23:20:39Z","updated_at":"2016-06-21T23:20:39Z","html_url":"https://github.com/deis/workflow-manager/pull/73#discussion_r67970309","pull_request_url":"https://api.github.com/repos/deis/workflow-manager/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/deis/workflow-manager/pulls/comments/67970309"},"html":{"href":"https://github.com/deis/workflow-manager/pull/73#discussion_r67970309"},"pull_request":{"href":"https://api.github.com/repos/deis/workflow-manager/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/deis/workflow-manager/pulls/73","id":74680624,"html_url":"https://github.com/deis/workflow-manager/pull/73","diff_url":"https://github.com/deis/workflow-manager/pull/73.diff","patch_url":"https://github.com/deis/workflow-manager/pull/73.patch","issue_url":"https://api.github.com/repos/deis/workflow-manager/issues/73","number":73,"state":"open","locked":false,"title":"test(doctor): doctor endpoint tests","user":{"login":"jackfrancis","id":1494193,"avatar_url":"https://avatars.githubusercontent.com/u/1494193?v=3","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"body":"Refactored `handlers.DoctorHandler` to accept a `*apiclient.WorkflowManager`, so that we can pass in mock api clients for testing.\r\n\r\nThis PR should make functional test coverage current with recent introductory deis doctor code.","created_at":"2016-06-21T20:34:30Z","updated_at":"2016-06-21T23:20:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8de17b5fc2f4baa93d3127e048e349baed303118","assignee":{"login":"jackfrancis","id":1494193,"avatar_url":"https://avatars.githubusercontent.com/u/1494193?v=3","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/workflow-manager/milestones/8","html_url":"https://github.com/deis/workflow-manager/milestones/v2.1","labels_url":"https://api.github.com/repos/deis/workflow-manager/milestones/8/labels","id":1786140,"number":8,"title":"v2.1","description":null,"creator":{"login":"deis-admin","id":12703824,"avatar_url":"https://avatars.githubusercontent.com/u/12703824?v=3","gravatar_id":"","url":"https://api.github.com/users/deis-admin","html_url":"https://github.com/deis-admin","followers_url":"https://api.github.com/users/deis-admin/followers","following_url":"https://api.github.com/users/deis-admin/following{/other_user}","gists_url":"https://api.github.com/users/deis-admin/gists{/gist_id}","starred_url":"https://api.github.com/users/deis-admin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis-admin/subscriptions","organizations_url":"https://api.github.com/users/deis-admin/orgs","repos_url":"https://api.github.com/users/deis-admin/repos","events_url":"https://api.github.com/users/deis-admin/events{/privacy}","received_events_url":"https://api.github.com/users/deis-admin/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2016-05-24T21:48:43Z","updated_at":"2016-06-21T20:34:30Z","due_on":"2016-07-06T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/deis/workflow-manager/pulls/73/commits","review_comments_url":"https://api.github.com/repos/deis/workflow-manager/pulls/73/comments","review_comment_url":"https://api.github.com/repos/deis/workflow-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/workflow-manager/issues/73/comments","statuses_url":"https://api.github.com/repos/deis/workflow-manager/statuses/963cf15a17f538157729bae35d5fc8962bad71f6","head":{"label":"jackfrancis:doctor-api-tests","ref":"doctor-api-tests","sha":"963cf15a17f538157729bae35d5fc8962bad71f6","user":{"login":"jackfrancis","id":1494193,"avatar_url":"https://avatars.githubusercontent.com/u/1494193?v=3","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"repo":{"id":60556329,"name":"workflow-manager","full_name":"jackfrancis/workflow-manager","owner":{"login":"jackfrancis","id":1494193,"avatar_url":"https://avatars.githubusercontent.com/u/1494193?v=3","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackfrancis/workflow-manager","description":"Deis Workflow Manager: Cluster First Aid","fork":true,"url":"https://api.github.com/repos/jackfrancis/workflow-manager","forks_url":"https://api.github.com/repos/jackfrancis/workflow-manager/forks","keys_url":"https://api.github.com/repos/jackfrancis/workflow-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackfrancis/workflow-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackfrancis/workflow-manager/teams","hooks_url":"https://api.github.com/repos/jackfrancis/workflow-manager/hooks","issue_events_url":"https://api.github.com/repos/jackfrancis/workflow-manager/issues/events{/number}","events_url":"https://api.github.com/repos/jackfrancis/workflow-manager/events","assignees_url":"https://api.github.com/repos/jackfrancis/workflow-manager/assignees{/user}","branches_url":"https://api.github.com/repos/jackfrancis/workflow-manager/branches{/branch}","tags_url":"https://api.github.com/repos/jackfrancis/workflow-manager/tags","blobs_url":"https://api.github.com/repos/jackfrancis/workflow-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackfrancis/workflow-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackfrancis/workflow-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackfrancis/workflow-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackfrancis/workflow-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/jackfrancis/workflow-manager/languages","stargazers_url":"https://api.github.com/repos/jackfrancis/workflow-manager/stargazers","contributors_url":"https://api.github.com/repos/jackfrancis/workflow-manager/contributors","subscribers_url":"https://api.github.com/repos/jackfrancis/workflow-manager/subscribers","subscription_url":"https://api.github.com/repos/jackfrancis/workflow-manager/subscription","commits_url":"https://api.github.com/repos/jackfrancis/workflow-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackfrancis/workflow-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackfrancis/workflow-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackfrancis/workflow-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackfrancis/workflow-manager/contents/{+path}","compare_url":"https://api.github.com/repos/jackfrancis/workflow-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackfrancis/workflow-manager/merges","archive_url":"https://api.github.com/repos/jackfrancis/workflow-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackfrancis/workflow-manager/downloads","issues_url":"https://api.github.com/repos/jackfrancis/workflow-manager/issues{/number}","pulls_url":"https://api.github.com/repos/jackfrancis/workflow-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/jackfrancis/workflow-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/jackfrancis/workflow-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackfrancis/workflow-manager/labels{/name}","releases_url":"https://api.github.com/repos/jackfrancis/workflow-manager/releases{/id}","deployments_url":"https://api.github.com/repos/jackfrancis/workflow-manager/deployments","created_at":"2016-06-06T19:51:58Z","updated_at":"2016-06-06T19:51:58Z","pushed_at":"2016-06-21T22:36:09Z","git_url":"git://github.com/jackfrancis/workflow-manager.git","ssh_url":"git@github.com:jackfrancis/workflow-manager.git","clone_url":"https://github.com/jackfrancis/workflow-manager.git","svn_url":"https://github.com/jackfrancis/workflow-manager","homepage":"","size":118,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"abefd4c001a7f8b7071d8dc7c316925d9dc48a5e","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":51403061,"name":"workflow-manager","full_name":"deis/workflow-manager","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/workflow-manager","description":"Deis Workflow Manager: Cluster First Aid","fork":false,"url":"https://api.github.com/repos/deis/workflow-manager","forks_url":"https://api.github.com/repos/deis/workflow-manager/forks","keys_url":"https://api.github.com/repos/deis/workflow-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/workflow-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/workflow-manager/teams","hooks_url":"https://api.github.com/repos/deis/workflow-manager/hooks","issue_events_url":"https://api.github.com/repos/deis/workflow-manager/issues/events{/number}","events_url":"https://api.github.com/repos/deis/workflow-manager/events","assignees_url":"https://api.github.com/repos/deis/workflow-manager/assignees{/user}","branches_url":"https://api.github.com/repos/deis/workflow-manager/branches{/branch}","tags_url":"https://api.github.com/repos/deis/workflow-manager/tags","blobs_url":"https://api.github.com/repos/deis/workflow-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/workflow-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/workflow-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/workflow-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/workflow-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/workflow-manager/languages","stargazers_url":"https://api.github.com/repos/deis/workflow-manager/stargazers","contributors_url":"https://api.github.com/repos/deis/workflow-manager/contributors","subscribers_url":"https://api.github.com/repos/deis/workflow-manager/subscribers","subscription_url":"https://api.github.com/repos/deis/workflow-manager/subscription","commits_url":"https://api.github.com/repos/deis/workflow-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/workflow-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/workflow-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/workflow-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/workflow-manager/contents/{+path}","compare_url":"https://api.github.com/repos/deis/workflow-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/workflow-manager/merges","archive_url":"https://api.github.com/repos/deis/workflow-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/workflow-manager/downloads","issues_url":"https://api.github.com/repos/deis/workflow-manager/issues{/number}","pulls_url":"https://api.github.com/repos/deis/workflow-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/workflow-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/workflow-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/workflow-manager/labels{/name}","releases_url":"https://api.github.com/repos/deis/workflow-manager/releases{/id}","deployments_url":"https://api.github.com/repos/deis/workflow-manager/deployments","created_at":"2016-02-09T21:56:20Z","updated_at":"2016-05-25T17:42:17Z","pushed_at":"2016-06-21T22:36:09Z","git_url":"git://github.com/deis/workflow-manager.git","ssh_url":"git@github.com:deis/workflow-manager.git","clone_url":"https://github.com/deis/workflow-manager.git","svn_url":"https://github.com/deis/workflow-manager","homepage":"","size":183,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":8,"forks":13,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/workflow-manager/pulls/73"},"html":{"href":"https://github.com/deis/workflow-manager/pull/73"},"issue":{"href":"https://api.github.com/repos/deis/workflow-manager/issues/73"},"comments":{"href":"https://api.github.com/repos/deis/workflow-manager/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/workflow-manager/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/workflow-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/workflow-manager/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/deis/workflow-manager/statuses/963cf15a17f538157729bae35d5fc8962bad71f6"}}}}
{"actor":{"display_login":"arschles"}}