{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/65093886","id":65093886,"diff_hunk":"@@ -19,13 +19,13 @@\n var t = async_test(\"Parsing of non-negative integers in setAttribute\");\n _addTest(function(canvas, ctx) {\n \n-canvas.setAttribute('width', '\\r\\n\\t\\x0c100');","path":"html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.whitespace.html","position":4,"original_position":4,"commit_id":"fea3307c4d6513c67bb097fe2c731ced97a0e7b9","original_commit_id":"fea3307c4d6513c67bb097fe2c731ced97a0e7b9","user":{"login":"gsnedders","id":176218,"avatar_url":"https://avatars.githubusercontent.com/u/176218?v=3","gravatar_id":"","url":"https://api.github.com/users/gsnedders","html_url":"https://github.com/gsnedders","followers_url":"https://api.github.com/users/gsnedders/followers","following_url":"https://api.github.com/users/gsnedders/following{/other_user}","gists_url":"https://api.github.com/users/gsnedders/gists{/gist_id}","starred_url":"https://api.github.com/users/gsnedders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsnedders/subscriptions","organizations_url":"https://api.github.com/users/gsnedders/orgs","repos_url":"https://api.github.com/users/gsnedders/repos","events_url":"https://api.github.com/users/gsnedders/events{/privacy}","received_events_url":"https://api.github.com/users/gsnedders/received_events","type":"User","site_admin":false},"body":"https://github.com/w3c/web-platform-tests/commit/092f472231935e7478c59f8bdf149b991858b722","created_at":"2016-05-30T17:14:49Z","updated_at":"2016-05-30T17:14:49Z","html_url":"https://github.com/w3c/web-platform-tests/pull/3083#discussion_r65093886","pull_request_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3083","_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/65093886"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/3083#discussion_r65093886"},"pull_request":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3083"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3083","id":71794227,"html_url":"https://github.com/w3c/web-platform-tests/pull/3083","diff_url":"https://github.com/w3c/web-platform-tests/pull/3083.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/3083.patch","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/3083","number":3083,"state":"open","locked":false,"title":"Update generated tests; add Makefile to avoid people working out how","user":{"login":"gsnedders","id":176218,"avatar_url":"https://avatars.githubusercontent.com/u/176218?v=3","gravatar_id":"","url":"https://api.github.com/users/gsnedders","html_url":"https://github.com/gsnedders","followers_url":"https://api.github.com/users/gsnedders/followers","following_url":"https://api.github.com/users/gsnedders/following{/other_user}","gists_url":"https://api.github.com/users/gsnedders/gists{/gist_id}","starred_url":"https://api.github.com/users/gsnedders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsnedders/subscriptions","organizations_url":"https://api.github.com/users/gsnedders/orgs","repos_url":"https://api.github.com/users/gsnedders/repos","events_url":"https://api.github.com/users/gsnedders/events{/privacy}","received_events_url":"https://api.github.com/users/gsnedders/received_events","type":"User","site_admin":false},"body":"At the moment, most of our generated tests are badly documented as to how to generate them. One solution is to just provide a Makefile that does all the heavy lifting (and ultimately, hopefully, have a Makefile at the root which just regenerates all tests with a generation step, and ideally we can then run that on Travis CI to ensure they all stay up to date). This does that, and regenerates all the tests. And fixes the breakage caused by people not updating the source files properly.","created_at":"2016-05-28T06:09:20Z","updated_at":"2016-05-30T17:14:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a0fec7f8397cc6e7e6b4c043192a6ad43695659","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3083/commits","review_comments_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3083/comments","review_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/3083/comments","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/fea3307c4d6513c67bb097fe2c731ced97a0e7b9","head":{"label":"gsnedders:generated_tests_make","ref":"generated_tests_make","sha":"fea3307c4d6513c67bb097fe2c731ced97a0e7b9","user":{"login":"gsnedders","id":176218,"avatar_url":"https://avatars.githubusercontent.com/u/176218?v=3","gravatar_id":"","url":"https://api.github.com/users/gsnedders","html_url":"https://github.com/gsnedders","followers_url":"https://api.github.com/users/gsnedders/followers","following_url":"https://api.github.com/users/gsnedders/following{/other_user}","gists_url":"https://api.github.com/users/gsnedders/gists{/gist_id}","starred_url":"https://api.github.com/users/gsnedders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsnedders/subscriptions","organizations_url":"https://api.github.com/users/gsnedders/orgs","repos_url":"https://api.github.com/users/gsnedders/repos","events_url":"https://api.github.com/users/gsnedders/events{/privacy}","received_events_url":"https://api.github.com/users/gsnedders/received_events","type":"User","site_admin":false},"repo":{"id":10076726,"name":"web-platform-tests","full_name":"gsnedders/web-platform-tests","owner":{"login":"gsnedders","id":176218,"avatar_url":"https://avatars.githubusercontent.com/u/176218?v=3","gravatar_id":"","url":"https://api.github.com/users/gsnedders","html_url":"https://github.com/gsnedders","followers_url":"https://api.github.com/users/gsnedders/followers","following_url":"https://api.github.com/users/gsnedders/following{/other_user}","gists_url":"https://api.github.com/users/gsnedders/gists{/gist_id}","starred_url":"https://api.github.com/users/gsnedders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsnedders/subscriptions","organizations_url":"https://api.github.com/users/gsnedders/orgs","repos_url":"https://api.github.com/users/gsnedders/repos","events_url":"https://api.github.com/users/gsnedders/events{/privacy}","received_events_url":"https://api.github.com/users/gsnedders/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gsnedders/web-platform-tests","description":"Test Suites for Web Platform specifications","fork":true,"url":"https://api.github.com/repos/gsnedders/web-platform-tests","forks_url":"https://api.github.com/repos/gsnedders/web-platform-tests/forks","keys_url":"https://api.github.com/repos/gsnedders/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsnedders/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsnedders/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/gsnedders/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/gsnedders/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/gsnedders/web-platform-tests/events","assignees_url":"https://api.github.com/repos/gsnedders/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/gsnedders/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/gsnedders/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/gsnedders/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsnedders/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsnedders/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsnedders/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsnedders/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/gsnedders/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/gsnedders/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/gsnedders/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/gsnedders/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/gsnedders/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/gsnedders/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsnedders/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsnedders/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsnedders/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsnedders/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/gsnedders/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsnedders/web-platform-tests/merges","archive_url":"https://api.github.com/repos/gsnedders/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsnedders/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/gsnedders/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/gsnedders/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/gsnedders/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/gsnedders/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsnedders/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/gsnedders/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/gsnedders/web-platform-tests/deployments","created_at":"2013-05-15T11:06:17Z","updated_at":"2015-08-31T04:05:41Z","pushed_at":"2016-05-28T06:00:03Z","git_url":"git://github.com/gsnedders/web-platform-tests.git","ssh_url":"git@github.com:gsnedders/web-platform-tests.git","clone_url":"https://github.com/gsnedders/web-platform-tests.git","svn_url":"https://github.com/gsnedders/web-platform-tests","homepage":"","size":150186,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"6ad04910855d3b77a4557cee425a616efb0100aa","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"name":"web-platform-tests","full_name":"w3c/web-platform-tests","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-platform-tests","description":"Test Suites for Web Platform specifications—including WHATWG, W3C and others","fork":false,"url":"https://api.github.com/repos/w3c/web-platform-tests","forks_url":"https://api.github.com/repos/w3c/web-platform-tests/forks","keys_url":"https://api.github.com/repos/w3c/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/w3c/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-platform-tests/events","assignees_url":"https://api.github.com/repos/w3c/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/w3c/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/w3c/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-platform-tests/merges","archive_url":"https://api.github.com/repos/w3c/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/w3c/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-platform-tests/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2016-05-27T21:39:25Z","pushed_at":"2016-05-30T16:26:36Z","git_url":"git://github.com/w3c/web-platform-tests.git","ssh_url":"git@github.com:w3c/web-platform-tests.git","clone_url":"https://github.com/w3c/web-platform-tests.git","svn_url":"https://github.com/w3c/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":316799,"stargazers_count":764,"watchers_count":764,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":868,"mirror_url":null,"open_issues_count":309,"forks":868,"open_issues":309,"watchers":764,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3083"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/3083"},"issue":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/3083"},"comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/3083/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3083/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3083/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/web-platform-tests/statuses/fea3307c4d6513c67bb097fe2c731ced97a0e7b9"}}}}
{"actor":{"display_login":"gsnedders"}}