{"action":"closed","number":220,"pull_request":{"url":"https://api.github.com/repos/Islandora/islandora_scholar/pulls/220","id":58356317,"html_url":"https://github.com/Islandora/islandora_scholar/pull/220","diff_url":"https://github.com/Islandora/islandora_scholar/pull/220.diff","patch_url":"https://github.com/Islandora/islandora_scholar/pull/220.patch","issue_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/220","number":220,"state":"closed","locked":false,"title":"Enables roles with \"can embargo any object\" to manage embargoed items","user":{"login":"bryjbrown","id":3837461,"avatar_url":"https://avatars.githubusercontent.com/u/3837461?v=3","gravatar_id":"","url":"https://api.github.com/users/bryjbrown","html_url":"https://github.com/bryjbrown","followers_url":"https://api.github.com/users/bryjbrown/followers","following_url":"https://api.github.com/users/bryjbrown/following{/other_user}","gists_url":"https://api.github.com/users/bryjbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/bryjbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryjbrown/subscriptions","organizations_url":"https://api.github.com/users/bryjbrown/orgs","repos_url":"https://api.github.com/users/bryjbrown/repos","events_url":"https://api.github.com/users/bryjbrown/events{/privacy}","received_events_url":"https://api.github.com/users/bryjbrown/received_events","type":"User","site_admin":false},"body":"Currently embargoes are implemented by applying XACML policies to objects restricting access to all but administrators and the object's owner. The permission \"can embargo any object\" provided by the module has the description \"User can add or remove embargo on any object in repository\", but this is not the case since any role granted this permission is unable to access the object due to the user-centric XACML policy. This pull request adds a check for all roles with the \"can embargo any object\" permission and adds them to the XACML policy when setting embargoes.\r\n\r\nUse case: FSU has several staff at the graduate school who need to be able to manage embargoes independently on ETDs. We created a low-power \"embargo_admin\" role with just these permissions, and this pull request was required in order for that role to be able to see embargoed objects.","created_at":"2016-02-04T22:02:14Z","updated_at":"2016-09-14T20:22:39Z","closed_at":"2016-09-14T20:22:39Z","merged_at":null,"merge_commit_sha":"068ece3da5496098ccd6445401127c7121bfd4c6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Islandora/islandora_scholar/pulls/220/commits","review_comments_url":"https://api.github.com/repos/Islandora/islandora_scholar/pulls/220/comments","review_comment_url":"https://api.github.com/repos/Islandora/islandora_scholar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/220/comments","statuses_url":"https://api.github.com/repos/Islandora/islandora_scholar/statuses/e834b37b87bababa807b6460fd987f615a5dd86a","head":{"label":"bryjbrown:7.x","ref":"7.x","sha":"e834b37b87bababa807b6460fd987f615a5dd86a","user":{"login":"bryjbrown","id":3837461,"avatar_url":"https://avatars.githubusercontent.com/u/3837461?v=3","gravatar_id":"","url":"https://api.github.com/users/bryjbrown","html_url":"https://github.com/bryjbrown","followers_url":"https://api.github.com/users/bryjbrown/followers","following_url":"https://api.github.com/users/bryjbrown/following{/other_user}","gists_url":"https://api.github.com/users/bryjbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/bryjbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryjbrown/subscriptions","organizations_url":"https://api.github.com/users/bryjbrown/orgs","repos_url":"https://api.github.com/users/bryjbrown/repos","events_url":"https://api.github.com/users/bryjbrown/events{/privacy}","received_events_url":"https://api.github.com/users/bryjbrown/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"Islandora:7.x","ref":"7.x","sha":"32ba0e756d57ba2e3055cb3dbc0490d8f00b1d43","user":{"login":"Islandora","id":494054,"avatar_url":"https://avatars.githubusercontent.com/u/494054?v=3","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"repo":{"id":4797831,"name":"islandora_scholar","full_name":"Islandora/islandora_scholar","owner":{"login":"Islandora","id":494054,"avatar_url":"https://avatars.githubusercontent.com/u/494054?v=3","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Islandora/islandora_scholar","description":"Scholarly PDF Solution Pack for handling scholarly data and theses. A foundational module for implementing Islandora as an institutional repository.","fork":false,"url":"https://api.github.com/repos/Islandora/islandora_scholar","forks_url":"https://api.github.com/repos/Islandora/islandora_scholar/forks","keys_url":"https://api.github.com/repos/Islandora/islandora_scholar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Islandora/islandora_scholar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Islandora/islandora_scholar/teams","hooks_url":"https://api.github.com/repos/Islandora/islandora_scholar/hooks","issue_events_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/events{/number}","events_url":"https://api.github.com/repos/Islandora/islandora_scholar/events","assignees_url":"https://api.github.com/repos/Islandora/islandora_scholar/assignees{/user}","branches_url":"https://api.github.com/repos/Islandora/islandora_scholar/branches{/branch}","tags_url":"https://api.github.com/repos/Islandora/islandora_scholar/tags","blobs_url":"https://api.github.com/repos/Islandora/islandora_scholar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Islandora/islandora_scholar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Islandora/islandora_scholar/git/refs{/sha}","trees_url":"https://api.github.com/repos/Islandora/islandora_scholar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Islandora/islandora_scholar/statuses/{sha}","languages_url":"https://api.github.com/repos/Islandora/islandora_scholar/languages","stargazers_url":"https://api.github.com/repos/Islandora/islandora_scholar/stargazers","contributors_url":"https://api.github.com/repos/Islandora/islandora_scholar/contributors","subscribers_url":"https://api.github.com/repos/Islandora/islandora_scholar/subscribers","subscription_url":"https://api.github.com/repos/Islandora/islandora_scholar/subscription","commits_url":"https://api.github.com/repos/Islandora/islandora_scholar/commits{/sha}","git_commits_url":"https://api.github.com/repos/Islandora/islandora_scholar/git/commits{/sha}","comments_url":"https://api.github.com/repos/Islandora/islandora_scholar/comments{/number}","issue_comment_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues/comments{/number}","contents_url":"https://api.github.com/repos/Islandora/islandora_scholar/contents/{+path}","compare_url":"https://api.github.com/repos/Islandora/islandora_scholar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Islandora/islandora_scholar/merges","archive_url":"https://api.github.com/repos/Islandora/islandora_scholar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Islandora/islandora_scholar/downloads","issues_url":"https://api.github.com/repos/Islandora/islandora_scholar/issues{/number}","pulls_url":"https://api.github.com/repos/Islandora/islandora_scholar/pulls{/number}","milestones_url":"https://api.github.com/repos/Islandora/islandora_scholar/milestones{/number}","notifications_url":"https://api.github.com/repos/Islandora/islandora_scholar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Islandora/islandora_scholar/labels{/name}","releases_url":"https://api.github.com/repos/Islandora/islandora_scholar/releases{/id}","deployments_url":"https://api.github.com/repos/Islandora/islandora_scholar/deployments","created_at":"2012-06-26T16:49:57Z","updated_at":"2016-07-13T14:14:00Z","pushed_at":"2016-09-08T17:54:14Z","git_url":"git://github.com/Islandora/islandora_scholar.git","ssh_url":"git@github.com:Islandora/islandora_scholar.git","clone_url":"https://github.com/Islandora/islandora_scholar.git","svn_url":"https://github.com/Islandora/islandora_scholar","homepage":"http://islandora.ca/","size":17221,"stargazers_count":9,"watchers_count":9,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":5,"forks":41,"open_issues":5,"watchers":9,"default_branch":"7.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Islandora/islandora_scholar/pulls/220"},"html":{"href":"https://github.com/Islandora/islandora_scholar/pull/220"},"issue":{"href":"https://api.github.com/repos/Islandora/islandora_scholar/issues/220"},"comments":{"href":"https://api.github.com/repos/Islandora/islandora_scholar/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/Islandora/islandora_scholar/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/Islandora/islandora_scholar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Islandora/islandora_scholar/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/Islandora/islandora_scholar/statuses/e834b37b87bababa807b6460fd987f615a5dd86a"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":12,"review_comments":0,"commits":3,"additions":9,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"bryjbrown"}}