{"action":"created","comment":{"url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/comments/89863081","pull_request_review_id":10374289,"id":89863081,"diff_hunk":"@@ -1,15 +1,11 @@\n \"use strict\";\n \n import HlsjsP2PWrapperPrivate from './hlsjs-p2p-wrapper-private';\n-import StreamrootPeerAgentModule from 'streamroot-p2p';\n \n class HlsjsP2PWrapper {\n \n-    constructor(hlsjsConstructor) {\n-        let wrapper = new HlsjsP2PWrapperPrivate(hlsjsConstructor, StreamrootPeerAgentModule);\n-        this.createPlayer = wrapper.createPlayer.bind(wrapper);\n-        this.createSRModule = wrapper.createSRModule.bind(wrapper);\n-        this.P2PLoader = wrapper.P2PLoader;\n+    constructor(p2pConfig, hlsjs) {\n+        let wrapper = new HlsjsP2PWrapperPrivate(p2pConfig, hlsjs);\n \n         Object.defineProperty(this, \"stats\", {\n             get() {","path":"lib/hlsjs-p2p-wrapper.js","position":17,"original_position":17,"commit_id":"5ae33c5a1ea72d854ff68d69b7b44df522cdc7e2","original_commit_id":"5ae33c5a1ea72d854ff68d69b7b44df522cdc7e2","user":{"login":"AxelDelmas","id":5991128,"avatar_url":"https://avatars.githubusercontent.com/u/5991128?v=3","gravatar_id":"","url":"https://api.github.com/users/AxelDelmas","html_url":"https://github.com/AxelDelmas","followers_url":"https://api.github.com/users/AxelDelmas/followers","following_url":"https://api.github.com/users/AxelDelmas/following{/other_user}","gists_url":"https://api.github.com/users/AxelDelmas/gists{/gist_id}","starred_url":"https://api.github.com/users/AxelDelmas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AxelDelmas/subscriptions","organizations_url":"https://api.github.com/users/AxelDelmas/orgs","repos_url":"https://api.github.com/users/AxelDelmas/repos","events_url":"https://api.github.com/users/AxelDelmas/events{/privacy}","received_events_url":"https://api.github.com/users/AxelDelmas/received_events","type":"User","site_admin":false},"body":"We'll soon make a change to access all the functionality of the peer-agent public API through `wrapper.peerAgent` (for example `stats`).\r\nWe need to make sure that we introduce all the breaking change in wrapper v4, so this will need to do this before merging dev in master if we don't do it in this PR (we don't need to make all the changes on the internals, just make sure that we get the wrapper interface right from the start)","created_at":"2016-11-28T19:32:57Z","updated_at":"2016-11-28T19:32:57Z","html_url":"https://github.com/streamroot/hlsjs-p2p-wrapper/pull/94#discussion_r89863081","pull_request_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/comments/89863081"},"html":{"href":"https://github.com/streamroot/hlsjs-p2p-wrapper/pull/94#discussion_r89863081"},"pull_request":{"href":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/94","id":95206967,"html_url":"https://github.com/streamroot/hlsjs-p2p-wrapper/pull/94","diff_url":"https://github.com/streamroot/hlsjs-p2p-wrapper/pull/94.diff","patch_url":"https://github.com/streamroot/hlsjs-p2p-wrapper/pull/94.patch","issue_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/issues/94","number":94,"state":"open","locked":false,"title":"Wrapper public api cleanup","user":{"login":"ruslandinov","id":78303,"avatar_url":"https://avatars.githubusercontent.com/u/78303?v=3","gravatar_id":"","url":"https://api.github.com/users/ruslandinov","html_url":"https://github.com/ruslandinov","followers_url":"https://api.github.com/users/ruslandinov/followers","following_url":"https://api.github.com/users/ruslandinov/following{/other_user}","gists_url":"https://api.github.com/users/ruslandinov/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslandinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslandinov/subscriptions","organizations_url":"https://api.github.com/users/ruslandinov/orgs","repos_url":"https://api.github.com/users/ruslandinov/repos","events_url":"https://api.github.com/users/ruslandinov/events{/privacy}","received_events_url":"https://api.github.com/users/ruslandinov/received_events","type":"User","site_admin":false},"body":"Addressed this task https://www.pivotaltracker.com/n/projects/1597593/stories/133273783.\r\nThe idea is to simplify wrapper instantiation by passing already created `hls.js` instance to it, and removing unnecessary public methods from it.","created_at":"2016-11-24T16:37:10Z","updated_at":"2016-11-28T19:50:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c720147000abea82f0d3b4aec2321d307b2a2be0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/94/commits","review_comments_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/94/comments","review_comment_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/issues/94/comments","statuses_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/statuses/5ae33c5a1ea72d854ff68d69b7b44df522cdc7e2","head":{"label":"streamroot:wrapper_public_api_cleanup","ref":"wrapper_public_api_cleanup","sha":"5ae33c5a1ea72d854ff68d69b7b44df522cdc7e2","user":{"login":"streamroot","id":5428240,"avatar_url":"https://avatars.githubusercontent.com/u/5428240?v=3","gravatar_id":"","url":"https://api.github.com/users/streamroot","html_url":"https://github.com/streamroot","followers_url":"https://api.github.com/users/streamroot/followers","following_url":"https://api.github.com/users/streamroot/following{/other_user}","gists_url":"https://api.github.com/users/streamroot/gists{/gist_id}","starred_url":"https://api.github.com/users/streamroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamroot/subscriptions","organizations_url":"https://api.github.com/users/streamroot/orgs","repos_url":"https://api.github.com/users/streamroot/repos","events_url":"https://api.github.com/users/streamroot/events{/privacy}","received_events_url":"https://api.github.com/users/streamroot/received_events","type":"Organization","site_admin":false},"repo":{"id":51022043,"name":"hlsjs-p2p-wrapper","full_name":"streamroot/hlsjs-p2p-wrapper","owner":{"login":"streamroot","id":5428240,"avatar_url":"https://avatars.githubusercontent.com/u/5428240?v=3","gravatar_id":"","url":"https://api.github.com/users/streamroot","html_url":"https://github.com/streamroot","followers_url":"https://api.github.com/users/streamroot/followers","following_url":"https://api.github.com/users/streamroot/following{/other_user}","gists_url":"https://api.github.com/users/streamroot/gists{/gist_id}","starred_url":"https://api.github.com/users/streamroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamroot/subscriptions","organizations_url":"https://api.github.com/users/streamroot/orgs","repos_url":"https://api.github.com/users/streamroot/repos","events_url":"https://api.github.com/users/streamroot/events{/privacy}","received_events_url":"https://api.github.com/users/streamroot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/streamroot/hlsjs-p2p-wrapper","description":"Streamroot peer-acceleration module for hls.js","fork":false,"url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper","forks_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/forks","keys_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/teams","hooks_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/hooks","issue_events_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/issues/events{/number}","events_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/events","assignees_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/assignees{/user}","branches_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/branches{/branch}","tags_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/tags","blobs_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/languages","stargazers_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/stargazers","contributors_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/contributors","subscribers_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/subscribers","subscription_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/subscription","commits_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/contents/{+path}","compare_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/merges","archive_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/downloads","issues_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/issues{/number}","pulls_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/labels{/name}","releases_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/releases{/id}","deployments_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/deployments","created_at":"2016-02-03T18:46:58Z","updated_at":"2016-11-10T19:51:23Z","pushed_at":"2016-11-28T09:37:03Z","git_url":"git://github.com/streamroot/hlsjs-p2p-wrapper.git","ssh_url":"git@github.com:streamroot/hlsjs-p2p-wrapper.git","clone_url":"https://github.com/streamroot/hlsjs-p2p-wrapper.git","svn_url":"https://github.com/streamroot/hlsjs-p2p-wrapper","homepage":"https://www.streamroot.io","size":865,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"streamroot:dev","ref":"dev","sha":"935e2699efd396c170176b7e59cfceb6c07513bb","user":{"login":"streamroot","id":5428240,"avatar_url":"https://avatars.githubusercontent.com/u/5428240?v=3","gravatar_id":"","url":"https://api.github.com/users/streamroot","html_url":"https://github.com/streamroot","followers_url":"https://api.github.com/users/streamroot/followers","following_url":"https://api.github.com/users/streamroot/following{/other_user}","gists_url":"https://api.github.com/users/streamroot/gists{/gist_id}","starred_url":"https://api.github.com/users/streamroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamroot/subscriptions","organizations_url":"https://api.github.com/users/streamroot/orgs","repos_url":"https://api.github.com/users/streamroot/repos","events_url":"https://api.github.com/users/streamroot/events{/privacy}","received_events_url":"https://api.github.com/users/streamroot/received_events","type":"Organization","site_admin":false},"repo":{"id":51022043,"name":"hlsjs-p2p-wrapper","full_name":"streamroot/hlsjs-p2p-wrapper","owner":{"login":"streamroot","id":5428240,"avatar_url":"https://avatars.githubusercontent.com/u/5428240?v=3","gravatar_id":"","url":"https://api.github.com/users/streamroot","html_url":"https://github.com/streamroot","followers_url":"https://api.github.com/users/streamroot/followers","following_url":"https://api.github.com/users/streamroot/following{/other_user}","gists_url":"https://api.github.com/users/streamroot/gists{/gist_id}","starred_url":"https://api.github.com/users/streamroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamroot/subscriptions","organizations_url":"https://api.github.com/users/streamroot/orgs","repos_url":"https://api.github.com/users/streamroot/repos","events_url":"https://api.github.com/users/streamroot/events{/privacy}","received_events_url":"https://api.github.com/users/streamroot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/streamroot/hlsjs-p2p-wrapper","description":"Streamroot peer-acceleration module for hls.js","fork":false,"url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper","forks_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/forks","keys_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/teams","hooks_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/hooks","issue_events_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/issues/events{/number}","events_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/events","assignees_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/assignees{/user}","branches_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/branches{/branch}","tags_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/tags","blobs_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/languages","stargazers_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/stargazers","contributors_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/contributors","subscribers_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/subscribers","subscription_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/subscription","commits_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/contents/{+path}","compare_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/merges","archive_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/downloads","issues_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/issues{/number}","pulls_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/labels{/name}","releases_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/releases{/id}","deployments_url":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/deployments","created_at":"2016-02-03T18:46:58Z","updated_at":"2016-11-10T19:51:23Z","pushed_at":"2016-11-28T09:37:03Z","git_url":"git://github.com/streamroot/hlsjs-p2p-wrapper.git","ssh_url":"git@github.com:streamroot/hlsjs-p2p-wrapper.git","clone_url":"https://github.com/streamroot/hlsjs-p2p-wrapper.git","svn_url":"https://github.com/streamroot/hlsjs-p2p-wrapper","homepage":"https://www.streamroot.io","size":865,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/94"},"html":{"href":"https://github.com/streamroot/hlsjs-p2p-wrapper/pull/94"},"issue":{"href":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/issues/94"},"comments":{"href":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/streamroot/hlsjs-p2p-wrapper/statuses/5ae33c5a1ea72d854ff68d69b7b44df522cdc7e2"}}}}
{"actor":{"display_login":"AxelDelmas"}}