{"action":"created","issue":{"url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/45","repository_url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats","labels_url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/45/comments","events_url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/45/events","html_url":"https://github.com/open-gamma-ray-astro/gamma-astro-data-formats/issues/45","id":152484883,"number":45,"title":"SED and Binned Likelihood Formats","user":{"login":"woodmd","id":5733106,"avatar_url":"https://avatars.githubusercontent.com/u/5733106?v=3","gravatar_id":"","url":"https://api.github.com/users/woodmd","html_url":"https://github.com/woodmd","followers_url":"https://api.github.com/users/woodmd/followers","following_url":"https://api.github.com/users/woodmd/following{/other_user}","gists_url":"https://api.github.com/users/woodmd/gists{/gist_id}","starred_url":"https://api.github.com/users/woodmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woodmd/subscriptions","organizations_url":"https://api.github.com/users/woodmd/orgs","repos_url":"https://api.github.com/users/woodmd/repos","events_url":"https://api.github.com/users/woodmd/events{/privacy}","received_events_url":"https://api.github.com/users/woodmd/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/labels/type:%20question","name":"type: question","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/milestones/4","html_url":"https://github.com/open-gamma-ray-astro/gamma-astro-data-formats/milestones/whishlist","labels_url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/milestones/4/labels","id":1504140,"number":4,"title":"whishlist","description":"","creator":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":0,"state":"open","created_at":"2016-01-13T10:24:11Z","updated_at":"2016-05-22T21:19:51Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-05-02T05:46:02Z","updated_at":"2016-05-22T21:55:26Z","closed_at":null,"body":"This is an open thread to collect comments and feedback on the proposed formats for [Binned Likelihood Profiles](http://gamma-astro-data-formats.readthedocs.io/en/latest/results/binned_likelihoods/index.html).  Since these formats are effectively just SEDs with extra information in each bin it would probably be a good idea to try to share conventions with the [Flux points format](http://gamma-astro-data-formats.readthedocs.io/en/latest/results/flux_points/index.html).  @zblz Did you have any thoughts on this?\r\n\r\nHere are a few open questions:\r\n\r\n- Do we want a fixed 95% CL for the UL columns?  I saw that the naima format specifies the confidence level with a header keyword so maybe we should do something similar.\r\n\r\n- Do we need a column to specify the bin center?  The current format only specifies the lower and upper edges (`E_MIN` and `E_MAX`).  Differential quantities are assumed to be evaluated at the geometric center of the bin but we could add a bin center column (`E_CTR`) that would allow the evaluation point to be explicitly defined. \r\n\r\n- Which columns do we want to make optional?  The current specification calls for five different unit conversion factors (`DFDE`,`E2DFDE`,`FLUX`,`EFLUX`,`NPRED`).  I mainly did this for convenience so that one doesn't need to know anything about the underlying spectral model to convert between units.  Of these `E2DFDE` could clearly be optional (or maybe dropped entirely) since it can be trivially computed from `DFDE`.  `NPRED` provides additional information that can't be rederived from the other four unit columns but since it may not always be available it should probably also be optional.\r\n\r\n- Do we want a column for exposure?  This can be inferred from `FLUX` and `NPRED` but having it as an independent column could be useful in some circumstances.\r\n\r\n- Do we need a column that describes the model for the spectral distribution within each bin?  For instance when making LAT SEDs we typically substitute the source with an index=2.0 power-law.  For many applications this doesn't really matter (e.g. when using narrow bins) but when using wide bins or when the effect of energy dispersion is significant the assumed shape within the bin can have a big influence on the measured flux.  One option would be a column for the logarithmic slope of the bin model evaluated at the bin center. "},"comment":{"url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/comments/220858901","html_url":"https://github.com/open-gamma-ray-astro/gamma-astro-data-formats/issues/45#issuecomment-220858901","issue_url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/45","id":220858901,"user":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"created_at":"2016-05-22T21:55:26Z","updated_at":"2016-05-22T21:55:26Z","body":"Here's some comments from me on the flux point spec:\r\n\r\n* Currently there's a heading `Flux points` and right after `SED`. We should pick one heading and then explain in the main text that the other term is used equivalently instead of having two headings. I don't care which term is used, @woodmd, maybe you can make the choice?\r\n* I think that too many of the columns are required at the moment, more should be optional. The proposal [here](http://naima.readthedocs.io/en/latest/dataformat.html) of having energy, flux and flux error as the required columns is better IMO, I would have even put flux error as optional.\r\n* This format is pretty complex for the average user. I think what would help would be to put the FITS example files at the end into a separate section and extend that with some more info / example numbers like @zblz did [here](http://naima.readthedocs.io/en/latest/dataformat.html). Specifically from the flux spec alone it's a bit cryptic what the \"reference model\" is. \"REF\" is first used for the reference energy, which has nothing to do with the \"reference model\". And then \"REF\" is added everywhere to refer to the \"reference model\". Is that really needed? Can't we state once at the top that usually a \"reference model\" or \"spectral shape\" within each bin is assumed and then have simpler column names? (like 'Energy', 'Flux', ...)"}}
{"actor":{"display_login":"cdeil"}}