{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/78983426","id":78983426,"diff_hunk":"@@ -0,0 +1,91 @@\n+<?php\n+\n+/*\n+ * This file is part of the Sylius package.\n+ *\n+ * (c) Paweł Jędrzejewski\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace spec\\Sylius\\Component\\Core\\Inventory\\Updater;\n+\n+use PhpSpec\\ObjectBehavior;\n+use Sylius\\Component\\Core\\Inventory\\Updater\\OnHoldQuantityUpdater;\n+use Sylius\\Component\\Core\\Inventory\\Updater\\OrderQuantityUpdaterInterface;\n+use Sylius\\Component\\Core\\Model\\OrderInterface;\n+use Sylius\\Component\\Core\\Model\\OrderItemInterface;\n+use Sylius\\Component\\Core\\Model\\ProductVariantInterface;\n+\n+/**\n+ * @mixin OnHoldQuantityUpdater\n+ *\n+ * @author Arkadiusz Krakowiak <arkadiusz.krakowiak@lakion.com>\n+ */\n+final class OnHoldQuantityUpdaterSpec extends ObjectBehavior\n+{\n+    function it_is_initializable()\n+    {\n+        $this->shouldHaveType(OnHoldQuantityUpdater::class);\n+    }\n+\n+    function it_implements_order_quantity_updater_interface()\n+    {\n+        $this->shouldImplement(OrderQuantityUpdaterInterface::class);\n+    }\n+\n+    function it_increase_on_hold_quantity(\n+        OrderInterface $order,\n+        OrderItemInterface $orderItem,\n+        ProductVariantInterface $productVariant\n+    ) {\n+        $productVariant->getOnHold()->willReturn(3);\n+        $productVariant->isTracked()->willReturn(true);\n+\n+        $orderItem->getVariant()->willReturn($productVariant);\n+        $orderItem->getQuantity()->willReturn(10);\n+\n+        $order->getItems()->willReturn([$orderItem]);\n+\n+        $productVariant->setOnHold(13)->shouldBeCalled();\n+\n+        $this->increase($order);\n+    }\n+\n+    function it_decrease_on_hold_quantity(\n+        OrderInterface $order,\n+        OrderItemInterface $orderItem,\n+        ProductVariantInterface $productVariant\n+    ) {\n+        $productVariant->getOnHold()->willReturn(10);\n+        $productVariant->isTracked()->willReturn(true);\n+        $productVariant->getName()->willReturn('t-shirt');","path":"src/Sylius/Component/Core/spec/Inventory/Updater/OnHoldQuantityUpdaterSpec.php","position":63,"original_position":63,"commit_id":"049455b2b28c19eb11a1f8b7fe6b9b39264c6f90","original_commit_id":"049455b2b28c19eb11a1f8b7fe6b9b39264c6f90","user":{"login":"michalmarcinkowski","id":7572437,"avatar_url":"https://avatars.githubusercontent.com/u/7572437?v=3","gravatar_id":"","url":"https://api.github.com/users/michalmarcinkowski","html_url":"https://github.com/michalmarcinkowski","followers_url":"https://api.github.com/users/michalmarcinkowski/followers","following_url":"https://api.github.com/users/michalmarcinkowski/following{/other_user}","gists_url":"https://api.github.com/users/michalmarcinkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/michalmarcinkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalmarcinkowski/subscriptions","organizations_url":"https://api.github.com/users/michalmarcinkowski/orgs","repos_url":"https://api.github.com/users/michalmarcinkowski/repos","events_url":"https://api.github.com/users/michalmarcinkowski/events{/privacy}","received_events_url":"https://api.github.com/users/michalmarcinkowski/received_events","type":"User","site_admin":false},"body":"Do we need it?","created_at":"2016-09-15T14:55:20Z","updated_at":"2016-09-15T14:56:50Z","html_url":"https://github.com/Sylius/Sylius/pull/6033#discussion_r78983426","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/6033","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/78983426"},"html":{"href":"https://github.com/Sylius/Sylius/pull/6033#discussion_r78983426"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/6033"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/6033","id":84475746,"html_url":"https://github.com/Sylius/Sylius/pull/6033","diff_url":"https://github.com/Sylius/Sylius/pull/6033.diff","patch_url":"https://github.com/Sylius/Sylius/pull/6033.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/6033","number":6033,"state":"open","locked":false,"title":"[Inventory] Holding inventory units during checkout","user":{"login":"Arminek","id":6368946,"avatar_url":"https://avatars.githubusercontent.com/u/6368946?v=3","gravatar_id":"","url":"https://api.github.com/users/Arminek","html_url":"https://github.com/Arminek","followers_url":"https://api.github.com/users/Arminek/followers","following_url":"https://api.github.com/users/Arminek/following{/other_user}","gists_url":"https://api.github.com/users/Arminek/gists{/gist_id}","starred_url":"https://api.github.com/users/Arminek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arminek/subscriptions","organizations_url":"https://api.github.com/users/Arminek/orgs","repos_url":"https://api.github.com/users/Arminek/repos","events_url":"https://api.github.com/users/Arminek/events{/privacy}","received_events_url":"https://api.github.com/users/Arminek/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | no\r\n| New feature?    | yes\r\n| BC breaks?      | no\r\n| Related tickets | \r\n| License         | MIT","created_at":"2016-09-08T13:18:46Z","updated_at":"2016-09-15T14:56:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"693c1b1786f4ea5b87d2557764da5c59115b2e81","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/6033/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/6033/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/6033/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/049455b2b28c19eb11a1f8b7fe6b9b39264c6f90","head":{"label":"Arminek:inventory-hold","ref":"inventory-hold","sha":"049455b2b28c19eb11a1f8b7fe6b9b39264c6f90","user":{"login":"Arminek","id":6368946,"avatar_url":"https://avatars.githubusercontent.com/u/6368946?v=3","gravatar_id":"","url":"https://api.github.com/users/Arminek","html_url":"https://github.com/Arminek","followers_url":"https://api.github.com/users/Arminek/followers","following_url":"https://api.github.com/users/Arminek/following{/other_user}","gists_url":"https://api.github.com/users/Arminek/gists{/gist_id}","starred_url":"https://api.github.com/users/Arminek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arminek/subscriptions","organizations_url":"https://api.github.com/users/Arminek/orgs","repos_url":"https://api.github.com/users/Arminek/repos","events_url":"https://api.github.com/users/Arminek/events{/privacy}","received_events_url":"https://api.github.com/users/Arminek/received_events","type":"User","site_admin":false},"repo":{"id":38776658,"name":"Sylius","full_name":"Arminek/Sylius","owner":{"login":"Arminek","id":6368946,"avatar_url":"https://avatars.githubusercontent.com/u/6368946?v=3","gravatar_id":"","url":"https://api.github.com/users/Arminek","html_url":"https://github.com/Arminek","followers_url":"https://api.github.com/users/Arminek/followers","following_url":"https://api.github.com/users/Arminek/following{/other_user}","gists_url":"https://api.github.com/users/Arminek/gists{/gist_id}","starred_url":"https://api.github.com/users/Arminek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arminek/subscriptions","organizations_url":"https://api.github.com/users/Arminek/orgs","repos_url":"https://api.github.com/users/Arminek/repos","events_url":"https://api.github.com/users/Arminek/events{/privacy}","received_events_url":"https://api.github.com/users/Arminek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Arminek/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/Arminek/Sylius","forks_url":"https://api.github.com/repos/Arminek/Sylius/forks","keys_url":"https://api.github.com/repos/Arminek/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Arminek/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Arminek/Sylius/teams","hooks_url":"https://api.github.com/repos/Arminek/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Arminek/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Arminek/Sylius/events","assignees_url":"https://api.github.com/repos/Arminek/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Arminek/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Arminek/Sylius/tags","blobs_url":"https://api.github.com/repos/Arminek/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Arminek/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Arminek/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Arminek/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Arminek/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Arminek/Sylius/languages","stargazers_url":"https://api.github.com/repos/Arminek/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Arminek/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Arminek/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Arminek/Sylius/subscription","commits_url":"https://api.github.com/repos/Arminek/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Arminek/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Arminek/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Arminek/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Arminek/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Arminek/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Arminek/Sylius/merges","archive_url":"https://api.github.com/repos/Arminek/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Arminek/Sylius/downloads","issues_url":"https://api.github.com/repos/Arminek/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Arminek/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Arminek/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Arminek/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Arminek/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Arminek/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Arminek/Sylius/deployments","created_at":"2015-07-08T19:59:32Z","updated_at":"2016-01-31T16:53:25Z","pushed_at":"2016-09-15T13:40:43Z","git_url":"git://github.com/Arminek/Sylius.git","ssh_url":"git@github.com:Arminek/Sylius.git","clone_url":"https://github.com/Arminek/Sylius.git","svn_url":"https://github.com/Arminek/Sylius","homepage":"Sylius.org","size":42364,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"60668683e5ff3baed81c2041e3954dae0b52798f","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2016-09-14T22:31:33Z","pushed_at":"2016-09-15T14:41:23Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":78339,"stargazers_count":2449,"watchers_count":2449,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":914,"mirror_url":null,"open_issues_count":776,"forks":914,"open_issues":776,"watchers":2449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/6033"},"html":{"href":"https://github.com/Sylius/Sylius/pull/6033"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/6033"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/6033/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/6033/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/6033/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/049455b2b28c19eb11a1f8b7fe6b9b39264c6f90"}}}}
{"actor":{"display_login":"michalmarcinkowski"}}