{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/50172369","id":50172369,"diff_hunk":"@@ -41,6 +42,8 @@ class BaseTrackPlayer : public BasePlayer {\n     void loadTrackFailed(TrackPointer pTrack);\n     void newTrackLoaded(TrackPointer pLoadedTrack);\n     void unloadingTrack(TrackPointer pAboutToBeUnloaded);\n+    void noPassthroughInputConfigured();\n+    void noVinylControlInputConfigured();\n };\n \n class BaseTrackPlayerImpl : public BaseTrackPlayer {","path":"src/mixer/basetrackplayer.h","position":16,"original_position":16,"commit_id":"6cdcf6e75d310976c497705756b36508e5b4c4be","original_commit_id":"7c6987648c649b632c05fae6385c8a6d377875f5","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"body":"At the time I wrote the test suite I didn't want to change every instance of BaseTrackPlayer in the codebase to BaseTrackPlayerAbstract/Interface. I don't see a strong need to do any name changing here.","created_at":"2016-01-19T20:43:51Z","updated_at":"2016-01-19T20:43:51Z","html_url":"https://github.com/mixxxdj/mixxx/pull/858#discussion_r50172369","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/50172369"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/858#discussion_r50172369"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858","id":56231395,"html_url":"https://github.com/mixxxdj/mixxx/pull/858","diff_url":"https://github.com/mixxxdj/mixxx/pull/858.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/858.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/858","number":858,"state":"open","locked":false,"title":"Move menu logic and VC/Passthrough/Mic checking out of MixxxMainWindow.","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"body":"Drops 1000+ lines from mixxx.h/mixxx.cpp -- now they're \"only\" 1400 lines!\r\n\r\nI'm out for the weekend but figured I'd get this PR started. Some notes:\r\n\r\n* I removed the re-creation of the menu bar when toggling full screen. Bug #885890 and #1076789. I'd like to see if we still need this workaround on Trusty onwards. Maybe various bugs are fixed? In either case, @Pegasus-RPG reported that menubars are still broken on KDE so maybe this isn't the right fix after all.\r\n\r\n* I removed the partial menubar creation during bootup -- for me, QWidget::setMenuBar takes 95% of the time in initMenuBar() so not creating the full menubar doesn't seem like much of a savings to me at the code complexity cost it introduced.\r\n\r\n* I still have some TODO(rryan)'s in WMainMenuBar that I intend to fix before merging.","created_at":"2016-01-15T22:45:46Z","updated_at":"2016-01-19T20:43:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08baaf8d3466d461468c5a302ca2a85348bc050c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/858/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/6cdcf6e75d310976c497705756b36508e5b4c4be","head":{"label":"rryan:menubar","ref":"menubar","sha":"6cdcf6e75d310976c497705756b36508e5b4c4be","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"repo":{"id":10690290,"name":"mixxx","full_name":"rryan/mixxx","owner":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rryan/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/rryan/mixxx","forks_url":"https://api.github.com/repos/rryan/mixxx/forks","keys_url":"https://api.github.com/repos/rryan/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rryan/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rryan/mixxx/teams","hooks_url":"https://api.github.com/repos/rryan/mixxx/hooks","issue_events_url":"https://api.github.com/repos/rryan/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/rryan/mixxx/events","assignees_url":"https://api.github.com/repos/rryan/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/rryan/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/rryan/mixxx/tags","blobs_url":"https://api.github.com/repos/rryan/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rryan/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rryan/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/rryan/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rryan/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/rryan/mixxx/languages","stargazers_url":"https://api.github.com/repos/rryan/mixxx/stargazers","contributors_url":"https://api.github.com/repos/rryan/mixxx/contributors","subscribers_url":"https://api.github.com/repos/rryan/mixxx/subscribers","subscription_url":"https://api.github.com/repos/rryan/mixxx/subscription","commits_url":"https://api.github.com/repos/rryan/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/rryan/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/rryan/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/rryan/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/rryan/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/rryan/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rryan/mixxx/merges","archive_url":"https://api.github.com/repos/rryan/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rryan/mixxx/downloads","issues_url":"https://api.github.com/repos/rryan/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/rryan/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/rryan/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/rryan/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rryan/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/rryan/mixxx/releases{/id}","created_at":"2013-06-14T14:11:10Z","updated_at":"2014-09-27T19:25:20Z","pushed_at":"2016-01-19T20:01:38Z","git_url":"git://github.com/rryan/mixxx.git","ssh_url":"git@github.com:rryan/mixxx.git","clone_url":"https://github.com/rryan/mixxx.git","svn_url":"https://github.com/rryan/mixxx","homepage":"http://mixxx.org","size":255994,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"0bb570394a0cec51861600145ab5f3077865e2cd","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","created_at":"2013-05-17T15:14:38Z","updated_at":"2016-01-19T18:27:50Z","pushed_at":"2016-01-19T20:01:39Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":266018,"stargazers_count":447,"watchers_count":447,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":283,"mirror_url":null,"open_issues_count":56,"forks":283,"open_issues":56,"watchers":447,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/858"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/858"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/858/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/6cdcf6e75d310976c497705756b36508e5b4c4be"}}}}