{"action":"opened","issue":{"url":"https://api.github.com/repos/swri-robotics/mapviz/issues/410","repository_url":"https://api.github.com/repos/swri-robotics/mapviz","labels_url":"https://api.github.com/repos/swri-robotics/mapviz/issues/410/labels{/name}","comments_url":"https://api.github.com/repos/swri-robotics/mapviz/issues/410/comments","events_url":"https://api.github.com/repos/swri-robotics/mapviz/issues/410/events","html_url":"https://github.com/swri-robotics/mapviz/issues/410","id":169169685,"number":410,"title":"Compiler Warnings in mapviz Package","user":{"login":"evenator","id":567836,"avatar_url":"https://avatars.githubusercontent.com/u/567836?v=3","gravatar_id":"","url":"https://api.github.com/users/evenator","html_url":"https://github.com/evenator","followers_url":"https://api.github.com/users/evenator/followers","following_url":"https://api.github.com/users/evenator/following{/other_user}","gists_url":"https://api.github.com/users/evenator/gists{/gist_id}","starred_url":"https://api.github.com/users/evenator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evenator/subscriptions","organizations_url":"https://api.github.com/users/evenator/orgs","repos_url":"https://api.github.com/users/evenator/repos","events_url":"https://api.github.com/users/evenator/events{/privacy}","received_events_url":"https://api.github.com/users/evenator/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-03T16:04:08Z","updated_at":"2016-08-03T16:04:08Z","closed_at":null,"body":"When compiling mapviz with gcc -Wall -Wno-unused, I get the following warnings:\r\n\r\n```\r\nWarnings   << mapviz:make /home/evenator/code/dsat_catkin/logs/mapviz/build.make.008.log                                                                                                                                                     \r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/mapviz_application.h:50: Note: No relevant classes found. No output generated.\r\nIn file included from /home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp:31:0:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h: In constructor ‘mapviz::ServiceUpdaterThread::ServiceUpdaterThread(ros::NodeHandle&, const string&, QObject*)’:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:80:24: warning: ‘mapviz::ServiceUpdaterThread::allowed_datatype_’ will be initialized after [-Wreorder]\r\n     const std::string& allowed_datatype_;\r\n                        ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:69:21: warning:   base ‘QThread’ [-Wreorder]\r\n       QThread(parent)\r\n                     ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:66:5: warning:   when initialized here [-Wreorder]\r\n     ServiceUpdaterThread(ros::NodeHandle& nh, const std::string& allowed_datatype, QObject* parent) :\r\n     ^\r\nIn file included from /home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp:31:0:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h: In constructor ‘mapviz::SelectServiceDialog::SelectServiceDialog(const string&, QWidget*)’:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:165:16: warning: ‘mapviz::SelectServiceDialog::name_filter_’ will be initialized after [-Wreorder]\r\n     QLineEdit *name_filter_;\r\n                ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp:117:21: warning:   base ‘QDialog’ [-Wreorder]\r\n       QDialog(parent)\r\n                     ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp:110:3: warning:   when initialized here [-Wreorder]\r\n   SelectServiceDialog::SelectServiceDialog(const std::string& datatype, QWidget* parent)\r\n   ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp: In member function ‘std::string mapviz::SelectServiceDialog::selectedService() const’:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp:289:42: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n       if (row < displayed_services_.size()) {\r\n                                          ^\r\nIn file included from /home/evenator/code/dsat_catkin/build/mapviz/include/mapviz/moc_select_service_dialog.cxx:9:0:\r\n/home/evenator/code/dsat_catkin/build/mapviz/include/mapviz/../../../../src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h: In constructor ‘mapviz::ServiceUpdaterThread::ServiceUpdaterThread(ros::NodeHandle&, const string&, QObject*)’:\r\n/home/evenator/code/dsat_catkin/build/mapviz/include/mapviz/../../../../src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:80:24: warning: ‘mapviz::ServiceUpdaterThread::allowed_datatype_’ will be initialized after [-Wreorder]\r\n     const std::string& allowed_datatype_;\r\n                        ^\r\n/home/evenator/code/dsat_catkin/build/mapviz/include/mapviz/../../../../src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:69:21: warning:   base ‘QThread’ [-Wreorder]\r\n       QThread(parent)\r\n                     ^\r\n/home/evenator/code/dsat_catkin/build/mapviz/include/mapviz/../../../../src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:66:5: warning:   when initialized here [-Wreorder]\r\n     ServiceUpdaterThread(ros::NodeHandle& nh, const std::string& allowed_datatype, QObject* parent) :\r\n     ^\r\nIn file included from /home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp:31:0:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h: In constructor ‘mapviz::ServiceUpdaterThread::ServiceUpdaterThread(ros::NodeHandle&, const string&, QObject*)’:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:80:24: warning: ‘mapviz::ServiceUpdaterThread::allowed_datatype_’ will be initialized after [-Wreorder]\r\n     const std::string& allowed_datatype_;\r\n                        ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:69:21: warning:   base ‘QThread’ [-Wreorder]\r\n       QThread(parent)\r\n                     ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:66:5: warning:   when initialized here [-Wreorder]\r\n     ServiceUpdaterThread(ros::NodeHandle& nh, const std::string& allowed_datatype, QObject* parent) :\r\n     ^\r\nIn file included from /home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp:31:0:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h: In constructor ‘mapviz::SelectServiceDialog::SelectServiceDialog(const string&, QWidget*)’:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:165:16: warning: ‘mapviz::SelectServiceDialog::name_filter_’ will be initialized after [-Wreorder]\r\n     QLineEdit *name_filter_;\r\n                ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp:117:21: warning:   base ‘QDialog’ [-Wreorder]\r\n       QDialog(parent)\r\n                     ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp:110:3: warning:   when initialized here [-Wreorder]\r\n   SelectServiceDialog::SelectServiceDialog(const std::string& datatype, QWidget* parent)\r\n   ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp: In member function ‘std::string mapviz::SelectServiceDialog::selectedService() const’:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_service_dialog.cpp:289:42: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n       if (row < displayed_services_.size()) {\r\n                                          ^\r\nIn file included from /home/evenator/code/dsat_catkin/build/mapviz/include/mapviz/moc_select_service_dialog.cxx:9:0:\r\n/home/evenator/code/dsat_catkin/build/mapviz/include/mapviz/../../../../src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h: In constructor ‘mapviz::ServiceUpdaterThread::ServiceUpdaterThread(ros::NodeHandle&, const string&, QObject*)’:\r\n/home/evenator/code/dsat_catkin/build/mapviz/include/mapviz/../../../../src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:80:24: warning: ‘mapviz::ServiceUpdaterThread::allowed_datatype_’ will be initialized after [-Wreorder]\r\n     const std::string& allowed_datatype_;\r\n                        ^\r\n/home/evenator/code/dsat_catkin/build/mapviz/include/mapviz/../../../../src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:69:21: warning:   base ‘QThread’ [-Wreorder]\r\n       QThread(parent)\r\n                     ^\r\n/home/evenator/code/dsat_catkin/build/mapviz/include/mapviz/../../../../src/MARTI/mapviz/mapviz/include/mapviz/select_service_dialog.h:66:5: warning:   when initialized here [-Wreorder]\r\n     ServiceUpdaterThread(ros::NodeHandle& nh, const std::string& allowed_datatype, QObject* parent) :\r\n     ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_topic_dialog.cpp: In member function ‘std::vector<ros::master::TopicInfo> mapviz::SelectTopicDialog::selectedTopics() const’:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_topic_dialog.cpp:199:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n   for (size_t i = 0; i < qt_selection.size(); i++) {\r\n                                            ^\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_topic_dialog.cpp: In member function ‘std::vector<ros::master::TopicInfo> mapviz::SelectTopicDialog::selectedTopics() const’:\r\n/home/evenator/code/dsat_catkin/src/MARTI/mapviz/mapviz/src/select_topic_dialog.cpp:199:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n   for (size_t i = 0; i < qt_selection.size(); i++) {\r\n                                            ^\r\ncd /home/evenator/code/dsat_catkin/build/mapviz; catkin build --get-env mapviz | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -\r\n```"}}
{"actor":{"display_login":"evenator"}}