{"action":"created","issue":{"url":"https://api.github.com/repos/PCGen/pcgen/issues/1217","repository_url":"https://api.github.com/repos/PCGen/pcgen","labels_url":"https://api.github.com/repos/PCGen/pcgen/issues/1217/labels{/name}","comments_url":"https://api.github.com/repos/PCGen/pcgen/issues/1217/comments","events_url":"https://api.github.com/repos/PCGen/pcgen/issues/1217/events","html_url":"https://github.com/PCGen/pcgen/pull/1217","id":154153034,"number":1217,"title":"Simplify quite a bit of code in NameGenPanel","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-11T03:32:38Z","updated_at":"2016-05-11T03:33:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/1217","html_url":"https://github.com/PCGen/pcgen/pull/1217","diff_url":"https://github.com/PCGen/pcgen/pull/1217.diff","patch_url":"https://github.com/PCGen/pcgen/pull/1217.patch"},"body":"Summary:\nThis simplifies the class NameGenPanel quite a bit and makes it easier\nto process.\nIt also introduces a temporary class called Predicates which is intended\nto be used until the switch to Java 1.8. Once that occurs this code can\nbe simplified even more by converting a couple of one-function-classes\nto lambdas.\n\nThis also weakens many types to their higher level form (and then uses\n<> to avoid redundant information)\n\nThis change also avoids the use Vector and replaces it with\nList/ArrayList where possible.\n\n(I know there should be a bug ID here for code cleanup but not sure what\nthe current one is)\n\nTest Plan:\nOpened GMGen NameGen and tried some functions\nBuilt pcgen"},"comment":{"url":"https://api.github.com/repos/PCGen/pcgen/issues/comments/218353141","html_url":"https://github.com/PCGen/pcgen/pull/1217#issuecomment-218353141","issue_url":"https://api.github.com/repos/PCGen/pcgen/issues/1217","id":218353141,"user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"created_at":"2016-05-11T03:33:09Z","updated_at":"2016-05-11T03:33:09Z","body":"I'll try to be more responsive with this change than my last one."}}