{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments/88499385","pull_request_review_id":9071876,"id":88499385,"diff_hunk":"@@ -247,6 +247,84 @@ void InsertDestination::bulkInsertTuplesWithRemappedAttributes(\n   });\n }\n \n+void InsertDestination::bulkInsertTuplesFromValueAccessors(\n+    const std::vector<std::pair<ValueAccessor *, std::vector<attribute_id>>> &accessor_attribute_map,\n+    bool always_mark_full) {\n+  // Handle pathological corner case where there are no accessors\n+  if (accessor_attribute_map.size() == 0)\n+    return;\n+\n+  // A common case that we can optimize away is when the attribute_map\n+  // for an accessor only contains gaps. e.g. This happens for a join when\n+  // there are no attributes selected from one side.\n+  std::vector<std::pair<ValueAccessor *, const std::vector<attribute_id>>> reduced_accessor_attribute_map;","path":"storage/InsertDestination.cpp","position":14,"original_position":14,"commit_id":"2c25dea812968e7fec87c9426f9b16ed803e96d9","original_commit_id":"2c25dea812968e7fec87c9426f9b16ed803e96d9","user":{"login":"cramja","id":5708822,"avatar_url":"https://avatars.githubusercontent.com/u/5708822?v=3","gravatar_id":"","url":"https://api.github.com/users/cramja","html_url":"https://github.com/cramja","followers_url":"https://api.github.com/users/cramja/followers","following_url":"https://api.github.com/users/cramja/following{/other_user}","gists_url":"https://api.github.com/users/cramja/gists{/gist_id}","starred_url":"https://api.github.com/users/cramja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramja/subscriptions","organizations_url":"https://api.github.com/users/cramja/orgs","repos_url":"https://api.github.com/users/cramja/repos","events_url":"https://api.github.com/users/cramja/events{/privacy}","received_events_url":"https://api.github.com/users/cramja/received_events","type":"User","site_admin":false},"body":"Should this routine be factored into a method?","created_at":"2016-11-17T17:10:22Z","updated_at":"2016-11-17T17:10:22Z","html_url":"https://github.com/apache/incubator-quickstep/pull/129#discussion_r88499385","pull_request_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments/88499385"},"html":{"href":"https://github.com/apache/incubator-quickstep/pull/129#discussion_r88499385"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/129","id":92674673,"html_url":"https://github.com/apache/incubator-quickstep/pull/129","diff_url":"https://github.com/apache/incubator-quickstep/pull/129.diff","patch_url":"https://github.com/apache/incubator-quickstep/pull/129.patch","issue_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/129","number":129,"state":"open","locked":false,"title":"Partial inserts","user":{"login":"cramja","id":5708822,"avatar_url":"https://avatars.githubusercontent.com/u/5708822?v=3","gravatar_id":"","url":"https://api.github.com/users/cramja","html_url":"https://github.com/cramja","followers_url":"https://api.github.com/users/cramja/followers","following_url":"https://api.github.com/users/cramja/following{/other_user}","gists_url":"https://api.github.com/users/cramja/gists{/gist_id}","starred_url":"https://api.github.com/users/cramja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramja/subscriptions","organizations_url":"https://api.github.com/users/cramja/orgs","repos_url":"https://api.github.com/users/cramja/repos","events_url":"https://api.github.com/users/cramja/events{/privacy}","received_events_url":"https://api.github.com/users/cramja/received_events","type":"User","site_admin":false},"body":"This change enables use of the PartialBulkInserts feature, an efficient implementation of which was introduced in the SplitRowStore in #100 . Most of these changes were imported from @navsan 's branch which exploited partial inserts but only implemented the storage optimization required to take advantage of them for the PackedRowStore.\r\n\r\n*Performance*\r\n\r\nWe ran SSB100 on the cloudlab machines and found that SplitRow's performance was almost exactly the same as PackedRow. `packed+split opt` includes both packed and splitrow with the copy optimization and uses both splitrow and packed row intermediate blocks. `splitrow opt ` uses only optimized splitrowstore blocks for intermediates.\r\n```\r\ntime (s)\r\n12.579     12.175          12.114\r\nno opt     splitrow opt    packed+split opt\r\n```\r\n\r\n*TPCH*\r\nThe total runtime of TPCH on a cloudlab box: `146,064` versus `165,640` for the latest.\r\nHere's the breakdown:\r\n```\r\n16,539.16\r\n619.40\r\n4,903.79\r\n2,408.61\r\n4,325.95\r\n399.81\r\n17,965.45\r\n1,705.55\r\n6,409.02\r\n6,873.65\r\n1,045.46\r\n1,661.75\r\n22,779.69\r\n812.33\r\n905.95\r\n10,479.83\r\n1,500.36\r\n27,464.26\r\n1,369.74\r\n1,203.16\r\n8,549.15\r\n6,141.90\r\n```\r\n\r\n*TODO*\r\n\r\nIn a later PR, we will remove packed rowstore as it represents unnecessary complexity.\r\n","created_at":"2016-11-07T22:09:15Z","updated_at":"2016-11-17T17:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2d81af6ca29b2a9f719614067f70d33316764bd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/129/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/129/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/129/comments","statuses_url":"https://api.github.com/repos/apache/incubator-quickstep/statuses/2c25dea812968e7fec87c9426f9b16ed803e96d9","head":{"label":"cramja:partial-inserts","ref":"partial-inserts","sha":"2c25dea812968e7fec87c9426f9b16ed803e96d9","user":{"login":"cramja","id":5708822,"avatar_url":"https://avatars.githubusercontent.com/u/5708822?v=3","gravatar_id":"","url":"https://api.github.com/users/cramja","html_url":"https://github.com/cramja","followers_url":"https://api.github.com/users/cramja/followers","following_url":"https://api.github.com/users/cramja/following{/other_user}","gists_url":"https://api.github.com/users/cramja/gists{/gist_id}","starred_url":"https://api.github.com/users/cramja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramja/subscriptions","organizations_url":"https://api.github.com/users/cramja/orgs","repos_url":"https://api.github.com/users/cramja/repos","events_url":"https://api.github.com/users/cramja/events{/privacy}","received_events_url":"https://api.github.com/users/cramja/received_events","type":"User","site_admin":false},"repo":{"id":66734831,"name":"incubator-quickstep","full_name":"cramja/incubator-quickstep","owner":{"login":"cramja","id":5708822,"avatar_url":"https://avatars.githubusercontent.com/u/5708822?v=3","gravatar_id":"","url":"https://api.github.com/users/cramja","html_url":"https://github.com/cramja","followers_url":"https://api.github.com/users/cramja/followers","following_url":"https://api.github.com/users/cramja/following{/other_user}","gists_url":"https://api.github.com/users/cramja/gists{/gist_id}","starred_url":"https://api.github.com/users/cramja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramja/subscriptions","organizations_url":"https://api.github.com/users/cramja/orgs","repos_url":"https://api.github.com/users/cramja/repos","events_url":"https://api.github.com/users/cramja/events{/privacy}","received_events_url":"https://api.github.com/users/cramja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cramja/incubator-quickstep","description":"Mirror of Apache Quickstep Incubator","fork":true,"url":"https://api.github.com/repos/cramja/incubator-quickstep","forks_url":"https://api.github.com/repos/cramja/incubator-quickstep/forks","keys_url":"https://api.github.com/repos/cramja/incubator-quickstep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cramja/incubator-quickstep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cramja/incubator-quickstep/teams","hooks_url":"https://api.github.com/repos/cramja/incubator-quickstep/hooks","issue_events_url":"https://api.github.com/repos/cramja/incubator-quickstep/issues/events{/number}","events_url":"https://api.github.com/repos/cramja/incubator-quickstep/events","assignees_url":"https://api.github.com/repos/cramja/incubator-quickstep/assignees{/user}","branches_url":"https://api.github.com/repos/cramja/incubator-quickstep/branches{/branch}","tags_url":"https://api.github.com/repos/cramja/incubator-quickstep/tags","blobs_url":"https://api.github.com/repos/cramja/incubator-quickstep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cramja/incubator-quickstep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cramja/incubator-quickstep/git/refs{/sha}","trees_url":"https://api.github.com/repos/cramja/incubator-quickstep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cramja/incubator-quickstep/statuses/{sha}","languages_url":"https://api.github.com/repos/cramja/incubator-quickstep/languages","stargazers_url":"https://api.github.com/repos/cramja/incubator-quickstep/stargazers","contributors_url":"https://api.github.com/repos/cramja/incubator-quickstep/contributors","subscribers_url":"https://api.github.com/repos/cramja/incubator-quickstep/subscribers","subscription_url":"https://api.github.com/repos/cramja/incubator-quickstep/subscription","commits_url":"https://api.github.com/repos/cramja/incubator-quickstep/commits{/sha}","git_commits_url":"https://api.github.com/repos/cramja/incubator-quickstep/git/commits{/sha}","comments_url":"https://api.github.com/repos/cramja/incubator-quickstep/comments{/number}","issue_comment_url":"https://api.github.com/repos/cramja/incubator-quickstep/issues/comments{/number}","contents_url":"https://api.github.com/repos/cramja/incubator-quickstep/contents/{+path}","compare_url":"https://api.github.com/repos/cramja/incubator-quickstep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cramja/incubator-quickstep/merges","archive_url":"https://api.github.com/repos/cramja/incubator-quickstep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cramja/incubator-quickstep/downloads","issues_url":"https://api.github.com/repos/cramja/incubator-quickstep/issues{/number}","pulls_url":"https://api.github.com/repos/cramja/incubator-quickstep/pulls{/number}","milestones_url":"https://api.github.com/repos/cramja/incubator-quickstep/milestones{/number}","notifications_url":"https://api.github.com/repos/cramja/incubator-quickstep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cramja/incubator-quickstep/labels{/name}","releases_url":"https://api.github.com/repos/cramja/incubator-quickstep/releases{/id}","deployments_url":"https://api.github.com/repos/cramja/incubator-quickstep/deployments","created_at":"2016-08-27T20:46:25Z","updated_at":"2016-08-27T20:46:30Z","pushed_at":"2016-11-09T17:26:36Z","git_url":"git://github.com/cramja/incubator-quickstep.git","ssh_url":"git@github.com:cramja/incubator-quickstep.git","clone_url":"https://github.com/cramja/incubator-quickstep.git","svn_url":"https://github.com/cramja/incubator-quickstep","homepage":null,"size":9376,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c45d68e19c53ffb5a6e017aa62c7577860204d0b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":56214719,"name":"incubator-quickstep","full_name":"apache/incubator-quickstep","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-quickstep","description":"Mirror of Apache Quickstep Incubator","fork":false,"url":"https://api.github.com/repos/apache/incubator-quickstep","forks_url":"https://api.github.com/repos/apache/incubator-quickstep/forks","keys_url":"https://api.github.com/repos/apache/incubator-quickstep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-quickstep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-quickstep/teams","hooks_url":"https://api.github.com/repos/apache/incubator-quickstep/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-quickstep/events","assignees_url":"https://api.github.com/repos/apache/incubator-quickstep/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-quickstep/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-quickstep/tags","blobs_url":"https://api.github.com/repos/apache/incubator-quickstep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-quickstep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-quickstep/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-quickstep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-quickstep/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-quickstep/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-quickstep/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-quickstep/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-quickstep/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-quickstep/subscription","commits_url":"https://api.github.com/repos/apache/incubator-quickstep/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-quickstep/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-quickstep/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-quickstep/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-quickstep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-quickstep/merges","archive_url":"https://api.github.com/repos/apache/incubator-quickstep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-quickstep/downloads","issues_url":"https://api.github.com/repos/apache/incubator-quickstep/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-quickstep/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-quickstep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-quickstep/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-quickstep/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-quickstep/deployments","created_at":"2016-04-14T07:00:07Z","updated_at":"2016-11-16T04:13:48Z","pushed_at":"2016-11-17T04:16:31Z","git_url":"git://github.com/apache/incubator-quickstep.git","ssh_url":"git@github.com:apache/incubator-quickstep.git","clone_url":"https://github.com/apache/incubator-quickstep.git","svn_url":"https://github.com/apache/incubator-quickstep","homepage":null,"size":9577,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":"git://git.apache.org/incubator-quickstep.git","open_issues_count":7,"forks":26,"open_issues":7,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/129"},"html":{"href":"https://github.com/apache/incubator-quickstep/pull/129"},"issue":{"href":"https://api.github.com/repos/apache/incubator-quickstep/issues/129"},"comments":{"href":"https://api.github.com/repos/apache/incubator-quickstep/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-quickstep/statuses/2c25dea812968e7fec87c9426f9b16ed803e96d9"}}}}
{"actor":{"display_login":"cramja"}}