{"action":"closed","number":1768,"pull_request":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/1768","id":88580595,"html_url":"https://github.com/forkcms/forkcms/pull/1768","diff_url":"https://github.com/forkcms/forkcms/pull/1768.diff","patch_url":"https://github.com/forkcms/forkcms/pull/1768.patch","issue_url":"https://api.github.com/repos/forkcms/forkcms/issues/1768","number":1768,"state":"closed","locked":false,"title":"Implement the symfony translator interface on the language classes","user":{"login":"carakas","id":3634654,"avatar_url":"https://avatars.githubusercontent.com/u/3634654?v=3","gravatar_id":"","url":"https://api.github.com/users/carakas","html_url":"https://github.com/carakas","followers_url":"https://api.github.com/users/carakas/followers","following_url":"https://api.github.com/users/carakas/following{/other_user}","gists_url":"https://api.github.com/users/carakas/gists{/gist_id}","starred_url":"https://api.github.com/users/carakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carakas/subscriptions","organizations_url":"https://api.github.com/users/carakas/orgs","repos_url":"https://api.github.com/users/carakas/repos","events_url":"https://api.github.com/users/carakas/events{/privacy}","received_events_url":"https://api.github.com/users/carakas/received_events","type":"User","site_admin":false},"body":"## Type\r\n\r\n- Feature\r\n\r\n## Pull request description\r\n\r\nYou can now use the trans function of the translator service to translate strings with our system\r\n\r\nInstead of `Language::lbl('MyLabel')` you can now do `$this->get'translator')->trans('lbl.MyLabel')`\r\n\r\nIf we can't translate it it will fallback to the default translation of symfony\r\n\r\nIf symfony also can't translate it we will return our normal fallback?-.\r\n\r\nThis was needed to be able to translate the error messages from symfony forms automatically but also makes it easier to move away from using static classes in our code to use the translations.\r\n\r\nit also fixes the bug that the error messages when there was missing data for content blocks wasn't translated, see 935ffa1\r\n","created_at":"2016-10-09T13:23:49Z","updated_at":"2016-10-20T09:13:10Z","closed_at":"2016-10-20T09:13:10Z","merged_at":"2016-10-20T09:13:10Z","merge_commit_sha":"4740b4be74f9887810988a693757696740fde59a","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/forkcms/forkcms/milestones/22","html_url":"https://github.com/forkcms/forkcms/milestones/4.3.0","labels_url":"https://api.github.com/repos/forkcms/forkcms/milestones/22/labels","id":1959880,"number":22,"title":"4.3.0","description":null,"creator":{"login":"carakas","id":3634654,"avatar_url":"https://avatars.githubusercontent.com/u/3634654?v=3","gravatar_id":"","url":"https://api.github.com/users/carakas","html_url":"https://github.com/carakas","followers_url":"https://api.github.com/users/carakas/followers","following_url":"https://api.github.com/users/carakas/following{/other_user}","gists_url":"https://api.github.com/users/carakas/gists{/gist_id}","starred_url":"https://api.github.com/users/carakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carakas/subscriptions","organizations_url":"https://api.github.com/users/carakas/orgs","repos_url":"https://api.github.com/users/carakas/repos","events_url":"https://api.github.com/users/carakas/events{/privacy}","received_events_url":"https://api.github.com/users/carakas/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":12,"state":"open","created_at":"2016-08-24T07:40:11Z","updated_at":"2016-10-20T09:13:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/forkcms/forkcms/pulls/1768/commits","review_comments_url":"https://api.github.com/repos/forkcms/forkcms/pulls/1768/comments","review_comment_url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forkcms/forkcms/issues/1768/comments","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/935ffa11c167e291a80f4648580289e84d95fa4b","head":{"label":"justcarakas:implement-the-Symfony-TranslatorInterface-on-the-language-classes","ref":"implement-the-Symfony-TranslatorInterface-on-the-language-classes","sha":"935ffa11c167e291a80f4648580289e84d95fa4b","user":{"login":"justcarakas","id":11027428,"avatar_url":"https://avatars.githubusercontent.com/u/11027428?v=3","gravatar_id":"","url":"https://api.github.com/users/justcarakas","html_url":"https://github.com/justcarakas","followers_url":"https://api.github.com/users/justcarakas/followers","following_url":"https://api.github.com/users/justcarakas/following{/other_user}","gists_url":"https://api.github.com/users/justcarakas/gists{/gist_id}","starred_url":"https://api.github.com/users/justcarakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justcarakas/subscriptions","organizations_url":"https://api.github.com/users/justcarakas/orgs","repos_url":"https://api.github.com/users/justcarakas/repos","events_url":"https://api.github.com/users/justcarakas/events{/privacy}","received_events_url":"https://api.github.com/users/justcarakas/received_events","type":"Organization","site_admin":false},"repo":{"id":30862709,"name":"forkcms","full_name":"justcarakas/forkcms","owner":{"login":"justcarakas","id":11027428,"avatar_url":"https://avatars.githubusercontent.com/u/11027428?v=3","gravatar_id":"","url":"https://api.github.com/users/justcarakas","html_url":"https://github.com/justcarakas","followers_url":"https://api.github.com/users/justcarakas/followers","following_url":"https://api.github.com/users/justcarakas/following{/other_user}","gists_url":"https://api.github.com/users/justcarakas/gists{/gist_id}","starred_url":"https://api.github.com/users/justcarakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justcarakas/subscriptions","organizations_url":"https://api.github.com/users/justcarakas/orgs","repos_url":"https://api.github.com/users/justcarakas/repos","events_url":"https://api.github.com/users/justcarakas/events{/privacy}","received_events_url":"https://api.github.com/users/justcarakas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/justcarakas/forkcms","description":"Fork is an open source CMS.","fork":true,"url":"https://api.github.com/repos/justcarakas/forkcms","forks_url":"https://api.github.com/repos/justcarakas/forkcms/forks","keys_url":"https://api.github.com/repos/justcarakas/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justcarakas/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justcarakas/forkcms/teams","hooks_url":"https://api.github.com/repos/justcarakas/forkcms/hooks","issue_events_url":"https://api.github.com/repos/justcarakas/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/justcarakas/forkcms/events","assignees_url":"https://api.github.com/repos/justcarakas/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/justcarakas/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/justcarakas/forkcms/tags","blobs_url":"https://api.github.com/repos/justcarakas/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justcarakas/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justcarakas/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/justcarakas/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justcarakas/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/justcarakas/forkcms/languages","stargazers_url":"https://api.github.com/repos/justcarakas/forkcms/stargazers","contributors_url":"https://api.github.com/repos/justcarakas/forkcms/contributors","subscribers_url":"https://api.github.com/repos/justcarakas/forkcms/subscribers","subscription_url":"https://api.github.com/repos/justcarakas/forkcms/subscription","commits_url":"https://api.github.com/repos/justcarakas/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/justcarakas/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/justcarakas/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/justcarakas/forkcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/justcarakas/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/justcarakas/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justcarakas/forkcms/merges","archive_url":"https://api.github.com/repos/justcarakas/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justcarakas/forkcms/downloads","issues_url":"https://api.github.com/repos/justcarakas/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/justcarakas/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/justcarakas/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/justcarakas/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justcarakas/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/justcarakas/forkcms/releases{/id}","deployments_url":"https://api.github.com/repos/justcarakas/forkcms/deployments","created_at":"2015-02-16T10:05:25Z","updated_at":"2016-03-14T08:12:31Z","pushed_at":"2016-10-20T08:58:33Z","git_url":"git://github.com/justcarakas/forkcms.git","ssh_url":"git@github.com:justcarakas/forkcms.git","clone_url":"https://github.com/justcarakas/forkcms.git","svn_url":"https://github.com/justcarakas/forkcms","homepage":"http://www.fork-cms.com","size":43436,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forkcms:master","ref":"master","sha":"91f1ebf51161d8a705bba4e96113c959e60a7483","user":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"repo":{"id":1138583,"name":"forkcms","full_name":"forkcms/forkcms","owner":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forkcms/forkcms","description":"Fork is an easy to use open source CMS using Symfony Components.","fork":false,"url":"https://api.github.com/repos/forkcms/forkcms","forks_url":"https://api.github.com/repos/forkcms/forkcms/forks","keys_url":"https://api.github.com/repos/forkcms/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forkcms/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forkcms/forkcms/teams","hooks_url":"https://api.github.com/repos/forkcms/forkcms/hooks","issue_events_url":"https://api.github.com/repos/forkcms/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/forkcms/forkcms/events","assignees_url":"https://api.github.com/repos/forkcms/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/forkcms/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/forkcms/forkcms/tags","blobs_url":"https://api.github.com/repos/forkcms/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forkcms/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forkcms/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/forkcms/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/forkcms/forkcms/languages","stargazers_url":"https://api.github.com/repos/forkcms/forkcms/stargazers","contributors_url":"https://api.github.com/repos/forkcms/forkcms/contributors","subscribers_url":"https://api.github.com/repos/forkcms/forkcms/subscribers","subscription_url":"https://api.github.com/repos/forkcms/forkcms/subscription","commits_url":"https://api.github.com/repos/forkcms/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/forkcms/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/forkcms/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/forkcms/forkcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/forkcms/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/forkcms/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forkcms/forkcms/merges","archive_url":"https://api.github.com/repos/forkcms/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forkcms/forkcms/downloads","issues_url":"https://api.github.com/repos/forkcms/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/forkcms/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/forkcms/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/forkcms/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forkcms/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/forkcms/forkcms/releases{/id}","deployments_url":"https://api.github.com/repos/forkcms/forkcms/deployments","created_at":"2010-12-04T18:06:15Z","updated_at":"2016-10-19T23:59:47Z","pushed_at":"2016-10-20T09:13:10Z","git_url":"git://github.com/forkcms/forkcms.git","ssh_url":"git@github.com:forkcms/forkcms.git","clone_url":"https://github.com/forkcms/forkcms.git","svn_url":"https://github.com/forkcms/forkcms","homepage":"http://www.fork-cms.com","size":63751,"stargazers_count":935,"watchers_count":935,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":240,"mirror_url":null,"open_issues_count":47,"forks":240,"open_issues":47,"watchers":935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1768"},"html":{"href":"https://github.com/forkcms/forkcms/pull/1768"},"issue":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/1768"},"comments":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/1768/comments"},"review_comments":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1768/comments"},"review_comment":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1768/commits"},"statuses":{"href":"https://api.github.com/repos/forkcms/forkcms/statuses/935ffa11c167e291a80f4648580289e84d95fa4b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"StijnVrolijk","id":442529,"avatar_url":"https://avatars.githubusercontent.com/u/442529?v=3","gravatar_id":"","url":"https://api.github.com/users/StijnVrolijk","html_url":"https://github.com/StijnVrolijk","followers_url":"https://api.github.com/users/StijnVrolijk/followers","following_url":"https://api.github.com/users/StijnVrolijk/following{/other_user}","gists_url":"https://api.github.com/users/StijnVrolijk/gists{/gist_id}","starred_url":"https://api.github.com/users/StijnVrolijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StijnVrolijk/subscriptions","organizations_url":"https://api.github.com/users/StijnVrolijk/orgs","repos_url":"https://api.github.com/users/StijnVrolijk/repos","events_url":"https://api.github.com/users/StijnVrolijk/events{/privacy}","received_events_url":"https://api.github.com/users/StijnVrolijk/received_events","type":"User","site_admin":false},"comments":0,"review_comments":5,"commits":11,"additions":66,"deletions":52,"changed_files":8}}
{"actor":{"display_login":"StijnVrolijk"}}