{"action":"created","issue":{"url":"https://api.github.com/repos/criteo/biggraphite/issues/53","repository_url":"https://api.github.com/repos/criteo/biggraphite","labels_url":"https://api.github.com/repos/criteo/biggraphite/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/criteo/biggraphite/issues/53/comments","events_url":"https://api.github.com/repos/criteo/biggraphite/issues/53/events","html_url":"https://github.com/criteo/biggraphite/pull/53","id":167058424,"number":53,"title":"Merge Metricbuffer and StageAggregate into MetricAggregate","user":{"login":"natbraun","id":12711504,"avatar_url":"https://avatars.githubusercontent.com/u/12711504?v=3","gravatar_id":"","url":"https://api.github.com/users/natbraun","html_url":"https://github.com/natbraun","followers_url":"https://api.github.com/users/natbraun/followers","following_url":"https://api.github.com/users/natbraun/following{/other_user}","gists_url":"https://api.github.com/users/natbraun/gists{/gist_id}","starred_url":"https://api.github.com/users/natbraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natbraun/subscriptions","organizations_url":"https://api.github.com/users/natbraun/orgs","repos_url":"https://api.github.com/users/natbraun/repos","events_url":"https://api.github.com/users/natbraun/events{/privacy}","received_events_url":"https://api.github.com/users/natbraun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"unbrice","id":530291,"avatar_url":"https://avatars.githubusercontent.com/u/530291?v=3","gravatar_id":"","url":"https://api.github.com/users/unbrice","html_url":"https://github.com/unbrice","followers_url":"https://api.github.com/users/unbrice/followers","following_url":"https://api.github.com/users/unbrice/following{/other_user}","gists_url":"https://api.github.com/users/unbrice/gists{/gist_id}","starred_url":"https://api.github.com/users/unbrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unbrice/subscriptions","organizations_url":"https://api.github.com/users/unbrice/orgs","repos_url":"https://api.github.com/users/unbrice/repos","events_url":"https://api.github.com/users/unbrice/events{/privacy}","received_events_url":"https://api.github.com/users/unbrice/received_events","type":"User","site_admin":false},"assignees":[{"login":"unbrice","id":530291,"avatar_url":"https://avatars.githubusercontent.com/u/530291?v=3","gravatar_id":"","url":"https://api.github.com/users/unbrice","html_url":"https://github.com/unbrice","followers_url":"https://api.github.com/users/unbrice/followers","following_url":"https://api.github.com/users/unbrice/following{/other_user}","gists_url":"https://api.github.com/users/unbrice/gists{/gist_id}","starred_url":"https://api.github.com/users/unbrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unbrice/subscriptions","organizations_url":"https://api.github.com/users/unbrice/orgs","repos_url":"https://api.github.com/users/unbrice/repos","events_url":"https://api.github.com/users/unbrice/events{/privacy}","received_events_url":"https://api.github.com/users/unbrice/received_events","type":"User","site_admin":false},{"login":"iksaif","id":1032963,"avatar_url":"https://avatars.githubusercontent.com/u/1032963?v=3","gravatar_id":"","url":"https://api.github.com/users/iksaif","html_url":"https://github.com/iksaif","followers_url":"https://api.github.com/users/iksaif/followers","following_url":"https://api.github.com/users/iksaif/following{/other_user}","gists_url":"https://api.github.com/users/iksaif/gists{/gist_id}","starred_url":"https://api.github.com/users/iksaif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iksaif/subscriptions","organizations_url":"https://api.github.com/users/iksaif/orgs","repos_url":"https://api.github.com/users/iksaif/repos","events_url":"https://api.github.com/users/iksaif/events{/privacy}","received_events_url":"https://api.github.com/users/iksaif/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2016-07-22T14:32:26Z","updated_at":"2016-07-25T13:55:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/criteo/biggraphite/pulls/53","html_url":"https://github.com/criteo/biggraphite/pull/53","diff_url":"https://github.com/criteo/biggraphite/pull/53.diff","patch_url":"https://github.com/criteo/biggraphite/pull/53.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/criteo/biggraphite/53)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/criteo/biggraphite/issues/comments/234959762","html_url":"https://github.com/criteo/biggraphite/pull/53#issuecomment-234959762","issue_url":"https://api.github.com/repos/criteo/biggraphite/issues/53","id":234959762,"user":{"login":"natbraun","id":12711504,"avatar_url":"https://avatars.githubusercontent.com/u/12711504?v=3","gravatar_id":"","url":"https://api.github.com/users/natbraun","html_url":"https://github.com/natbraun","followers_url":"https://api.github.com/users/natbraun/followers","following_url":"https://api.github.com/users/natbraun/following{/other_user}","gists_url":"https://api.github.com/users/natbraun/gists{/gist_id}","starred_url":"https://api.github.com/users/natbraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natbraun/subscriptions","organizations_url":"https://api.github.com/users/natbraun/orgs","repos_url":"https://api.github.com/users/natbraun/repos","events_url":"https://api.github.com/users/natbraun/events{/privacy}","received_events_url":"https://api.github.com/users/natbraun/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T13:55:27Z","updated_at":"2016-07-25T13:55:27Z","body":"\n\n\n\nReview status: 1 of 2 files reviewed at latest revision, 5 unresolved discussions.\n\n---\n\n*[biggraphite/drivers/downsampling.py, line 128 \\[r1\\]](https://reviewable.io:443/reviews/criteo/biggraphite/53#-KNIAWhwzqx7ySruk1lE:-KNXJEPS11FyNcUbekOl:-499146009) ([raw file](https://github.com/criteo/biggraphite/blob/89727f4435e12916f15c2536ebf31e5a35275a38/biggraphite/drivers/downsampling.py#L128)):*\n<details><summary><i>Previously, unbrice (Brice Arnould) wrote…</i></summary>\n> Nope :sweat_smile: \n</details>\nDone.\n\n---\n\n*[biggraphite/drivers/downsampling.py, line 136 \\[r1\\]](https://reviewable.io:443/reviews/criteo/biggraphite/53#-KNIB8LlkxsYMG-UajCL:-KNXJJDpfnCjSoNP8WQX:-499146009) ([raw file](https://github.com/criteo/biggraphite/blob/89727f4435e12916f15c2536ebf31e5a35275a38/biggraphite/drivers/downsampling.py#L136)):*\n<details><summary><i>Previously, unbrice (Brice Arnould) wrote…</i></summary>\n> Please add TODO\n</details>\nDone.\n\n---\n\n*[biggraphite/drivers/downsampling.py, line 141 \\[r1\\]](https://reviewable.io:443/reviews/criteo/biggraphite/53#-KNIAwV68ZX0cN-DA5lF:-KNXKeEf67VqUEwm0TMl:1013543619) ([raw file](https://github.com/criteo/biggraphite/blob/89727f4435e12916f15c2536ebf31e5a35275a38/biggraphite/drivers/downsampling.py#L141)):*\n<details><summary><i>Previously, unbrice (Brice Arnould) wrote…</i></summary>\n> Why wouldn't the code I proposed work?\n</details>\nWhere do I get the accessor from?\n\n---\n\n*[biggraphite/drivers/downsampling.py, line 33 \\[r4\\]](https://reviewable.io:443/reviews/criteo/biggraphite/53#-KNX7BsFZsjdud2WnRKK:-KNXJYZnKMwcWUeTqfZn:-499146009) ([raw file](https://github.com/criteo/biggraphite/blob/1226422cc7e49daf928abb2e3acb6941876b38b0/biggraphite/drivers/downsampling.py#L33)):*\n<details><summary><i>Previously, unbrice (Brice Arnould) wrote…</i></summary>\n> I suggest calling dicts \"${KEY}_to_${VALUE}\" like \"_names_to_aggregates\"\n</details>\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/criteo/biggraphite/53)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"natbraun"}}