{"action":"created","comment":{"url":"https://api.github.com/repos/minio/mc/pulls/comments/74978417","id":74978417,"diff_hunk":"@@ -119,14 +115,24 @@ func (w *Watcher) Wait() {\n \tw.wg.Wait()\n }\n \n-// Join the watcher with client\n-func (w *Watcher) Join(client Client, recursive bool) *probe.Error {","path":"mc/watch.go","position":47,"original_position":47,"commit_id":"c1eaacd41298464cb56995095cf9e54ccc41aa09","original_commit_id":"c1eaacd41298464cb56995095cf9e54ccc41aa09","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars.githubusercontent.com/u/622699?v=3","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"body":"We will not have such clients. We shouldnt bring in new interfaces in such a manner.","created_at":"2016-08-16T17:13:46Z","updated_at":"2016-08-16T17:13:46Z","html_url":"https://github.com/minio/mc/pull/1799#discussion_r74978417","pull_request_url":"https://api.github.com/repos/minio/mc/pulls/1799","_links":{"self":{"href":"https://api.github.com/repos/minio/mc/pulls/comments/74978417"},"html":{"href":"https://github.com/minio/mc/pull/1799#discussion_r74978417"},"pull_request":{"href":"https://api.github.com/repos/minio/mc/pulls/1799"}}},"pull_request":{"url":"https://api.github.com/repos/minio/mc/pulls/1799","id":81436746,"html_url":"https://github.com/minio/mc/pull/1799","diff_url":"https://github.com/minio/mc/pull/1799.diff","patch_url":"https://github.com/minio/mc/pull/1799.patch","issue_url":"https://api.github.com/repos/minio/mc/issues/1799","number":1799,"state":"open","locked":false,"title":"mirror: Watch() for events based on session time.","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars.githubusercontent.com/u/622699?v=3","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"body":"Enable notification if not already set, avoid overriding\r\nor append to existing notification set - all of this\r\nneeds to be done to make this transparent.","created_at":"2016-08-16T09:01:43Z","updated_at":"2016-08-16T17:13:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82d2216ad49b2176e97e96158a23fee6fc7fd48f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/mc/pulls/1799/commits","review_comments_url":"https://api.github.com/repos/minio/mc/pulls/1799/comments","review_comment_url":"https://api.github.com/repos/minio/mc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/mc/issues/1799/comments","statuses_url":"https://api.github.com/repos/minio/mc/statuses/c1eaacd41298464cb56995095cf9e54ccc41aa09","head":{"label":"harshavardhana:listen-events","ref":"listen-events","sha":"c1eaacd41298464cb56995095cf9e54ccc41aa09","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars.githubusercontent.com/u/622699?v=3","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"repo":{"id":33426538,"name":"mc","full_name":"harshavardhana/mc","owner":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars.githubusercontent.com/u/622699?v=3","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harshavardhana/mc","description":"Unified command line interface for Minio Object Storage","fork":true,"url":"https://api.github.com/repos/harshavardhana/mc","forks_url":"https://api.github.com/repos/harshavardhana/mc/forks","keys_url":"https://api.github.com/repos/harshavardhana/mc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harshavardhana/mc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harshavardhana/mc/teams","hooks_url":"https://api.github.com/repos/harshavardhana/mc/hooks","issue_events_url":"https://api.github.com/repos/harshavardhana/mc/issues/events{/number}","events_url":"https://api.github.com/repos/harshavardhana/mc/events","assignees_url":"https://api.github.com/repos/harshavardhana/mc/assignees{/user}","branches_url":"https://api.github.com/repos/harshavardhana/mc/branches{/branch}","tags_url":"https://api.github.com/repos/harshavardhana/mc/tags","blobs_url":"https://api.github.com/repos/harshavardhana/mc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harshavardhana/mc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harshavardhana/mc/git/refs{/sha}","trees_url":"https://api.github.com/repos/harshavardhana/mc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harshavardhana/mc/statuses/{sha}","languages_url":"https://api.github.com/repos/harshavardhana/mc/languages","stargazers_url":"https://api.github.com/repos/harshavardhana/mc/stargazers","contributors_url":"https://api.github.com/repos/harshavardhana/mc/contributors","subscribers_url":"https://api.github.com/repos/harshavardhana/mc/subscribers","subscription_url":"https://api.github.com/repos/harshavardhana/mc/subscription","commits_url":"https://api.github.com/repos/harshavardhana/mc/commits{/sha}","git_commits_url":"https://api.github.com/repos/harshavardhana/mc/git/commits{/sha}","comments_url":"https://api.github.com/repos/harshavardhana/mc/comments{/number}","issue_comment_url":"https://api.github.com/repos/harshavardhana/mc/issues/comments{/number}","contents_url":"https://api.github.com/repos/harshavardhana/mc/contents/{+path}","compare_url":"https://api.github.com/repos/harshavardhana/mc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harshavardhana/mc/merges","archive_url":"https://api.github.com/repos/harshavardhana/mc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harshavardhana/mc/downloads","issues_url":"https://api.github.com/repos/harshavardhana/mc/issues{/number}","pulls_url":"https://api.github.com/repos/harshavardhana/mc/pulls{/number}","milestones_url":"https://api.github.com/repos/harshavardhana/mc/milestones{/number}","notifications_url":"https://api.github.com/repos/harshavardhana/mc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harshavardhana/mc/labels{/name}","releases_url":"https://api.github.com/repos/harshavardhana/mc/releases{/id}","deployments_url":"https://api.github.com/repos/harshavardhana/mc/deployments","created_at":"2015-04-05T01:31:55Z","updated_at":"2016-06-22T19:27:35Z","pushed_at":"2016-08-16T09:23:03Z","git_url":"git://github.com/harshavardhana/mc.git","ssh_url":"git@github.com:harshavardhana/mc.git","clone_url":"https://github.com/harshavardhana/mc.git","svn_url":"https://github.com/harshavardhana/mc","homepage":"","size":7469,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"082ea3c29518e46be872544777a1961240c44ecb","user":{"login":"minio","id":695951,"avatar_url":"https://avatars.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29329884,"name":"mc","full_name":"minio/mc","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/mc","description":"Minio Client is a replacement for ls, cp, mkdir, diff and rsync commands for filesystems and object storage.","fork":false,"url":"https://api.github.com/repos/minio/mc","forks_url":"https://api.github.com/repos/minio/mc/forks","keys_url":"https://api.github.com/repos/minio/mc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/mc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/mc/teams","hooks_url":"https://api.github.com/repos/minio/mc/hooks","issue_events_url":"https://api.github.com/repos/minio/mc/issues/events{/number}","events_url":"https://api.github.com/repos/minio/mc/events","assignees_url":"https://api.github.com/repos/minio/mc/assignees{/user}","branches_url":"https://api.github.com/repos/minio/mc/branches{/branch}","tags_url":"https://api.github.com/repos/minio/mc/tags","blobs_url":"https://api.github.com/repos/minio/mc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/mc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/mc/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/mc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/mc/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/mc/languages","stargazers_url":"https://api.github.com/repos/minio/mc/stargazers","contributors_url":"https://api.github.com/repos/minio/mc/contributors","subscribers_url":"https://api.github.com/repos/minio/mc/subscribers","subscription_url":"https://api.github.com/repos/minio/mc/subscription","commits_url":"https://api.github.com/repos/minio/mc/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/mc/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/mc/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/mc/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/mc/contents/{+path}","compare_url":"https://api.github.com/repos/minio/mc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/mc/merges","archive_url":"https://api.github.com/repos/minio/mc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/mc/downloads","issues_url":"https://api.github.com/repos/minio/mc/issues{/number}","pulls_url":"https://api.github.com/repos/minio/mc/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/mc/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/mc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/mc/labels{/name}","releases_url":"https://api.github.com/repos/minio/mc/releases{/id}","deployments_url":"https://api.github.com/repos/minio/mc/deployments","created_at":"2015-01-16T02:56:51Z","updated_at":"2016-08-16T05:25:17Z","pushed_at":"2016-08-16T09:23:03Z","git_url":"git://github.com/minio/mc.git","ssh_url":"git@github.com:minio/mc.git","clone_url":"https://github.com/minio/mc.git","svn_url":"https://github.com/minio/mc","homepage":"https://minio.io/downloads/#minio-client","size":7875,"stargazers_count":299,"watchers_count":299,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":5,"forks":39,"open_issues":5,"watchers":299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/mc/pulls/1799"},"html":{"href":"https://github.com/minio/mc/pull/1799"},"issue":{"href":"https://api.github.com/repos/minio/mc/issues/1799"},"comments":{"href":"https://api.github.com/repos/minio/mc/issues/1799/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/mc/pulls/1799/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/mc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/mc/pulls/1799/commits"},"statuses":{"href":"https://api.github.com/repos/minio/mc/statuses/c1eaacd41298464cb56995095cf9e54ccc41aa09"}}}}
{"actor":{"display_login":"harshavardhana"}}