{"action":"created","comment":{"url":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/comments/67469082","id":67469082,"diff_hunk":"@@ -251,7 +216,7 @@ def _token_matching(self, funcs, start=0, end=None, reverse=False):\n                 if func(token):\n                     return token\n \n-    def token_first(self, ignore_whitespace=True, ignore_comments=False):\n+    def token_first(self, skip_ws=True, skip_cm=False):","path":"sqlparse/sql.py","position":240,"original_position":240,"commit_id":"5747015634a39191511de8db576f2cd0aa5eafc9","original_commit_id":"5747015634a39191511de8db576f2cd0aa5eafc9","user":{"login":"andialbrecht","id":25632,"avatar_url":"https://avatars.githubusercontent.com/u/25632?v=3","gravatar_id":"","url":"https://api.github.com/users/andialbrecht","html_url":"https://github.com/andialbrecht","followers_url":"https://api.github.com/users/andialbrecht/followers","following_url":"https://api.github.com/users/andialbrecht/following{/other_user}","gists_url":"https://api.github.com/users/andialbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/andialbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andialbrecht/subscriptions","organizations_url":"https://api.github.com/users/andialbrecht/orgs","repos_url":"https://api.github.com/users/andialbrecht/repos","events_url":"https://api.github.com/users/andialbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/andialbrecht/received_events","type":"User","site_admin":false},"body":"Why did you change the name of the keywords? I don't see any benefit (except that they are shorter). \r\n\r\nIf there are any benefits in changing those keywords we also need to change the docstring and mention this change in the release notes in case third-party apps are using it.","created_at":"2016-06-17T07:20:30Z","updated_at":"2016-06-17T07:20:30Z","html_url":"https://github.com/andialbrecht/sqlparse/pull/251#discussion_r67469082","pull_request_url":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/251","_links":{"self":{"href":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/comments/67469082"},"html":{"href":"https://github.com/andialbrecht/sqlparse/pull/251#discussion_r67469082"},"pull_request":{"href":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/251"}}},"pull_request":{"url":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/251","id":72614832,"html_url":"https://github.com/andialbrecht/sqlparse/pull/251","diff_url":"https://github.com/andialbrecht/sqlparse/pull/251.diff","patch_url":"https://github.com/andialbrecht/sqlparse/pull/251.patch","issue_url":"https://api.github.com/repos/andialbrecht/sqlparse/issues/251","number":251,"state":"closed","locked":false,"title":"Update Filters sql","user":{"login":"vmuriart","id":13303020,"avatar_url":"https://avatars.githubusercontent.com/u/13303020?v=3","gravatar_id":"","url":"https://api.github.com/users/vmuriart","html_url":"https://github.com/vmuriart","followers_url":"https://api.github.com/users/vmuriart/followers","following_url":"https://api.github.com/users/vmuriart/following{/other_user}","gists_url":"https://api.github.com/users/vmuriart/gists{/gist_id}","starred_url":"https://api.github.com/users/vmuriart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmuriart/subscriptions","organizations_url":"https://api.github.com/users/vmuriart/orgs","repos_url":"https://api.github.com/users/vmuriart/repos","events_url":"https://api.github.com/users/vmuriart/events{/privacy}","received_events_url":"https://api.github.com/users/vmuriart/received_events","type":"User","site_admin":false},"body":"Changes:\r\n\r\n* Refactor sql.py\r\n* Remove undocumented functions\r\n* Document StatementFilter\r\n* Simplify FilterStack\r\n* Refactor Filters\r\n* Re-adds support for Python 2.6\r\n","created_at":"2016-06-04T22:28:25Z","updated_at":"2016-06-17T07:20:30Z","closed_at":"2016-06-06T13:29:26Z","merged_at":"2016-06-06T13:29:26Z","merge_commit_sha":"b9d81ac4fe49114f57dc33c0d635f99ff56e62f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/251/commits","review_comments_url":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/251/comments","review_comment_url":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andialbrecht/sqlparse/issues/251/comments","statuses_url":"https://api.github.com/repos/andialbrecht/sqlparse/statuses/5747015634a39191511de8db576f2cd0aa5eafc9","head":{"label":"andialbrecht:filters_sql","ref":"filters_sql","sha":"5747015634a39191511de8db576f2cd0aa5eafc9","user":{"login":"andialbrecht","id":25632,"avatar_url":"https://avatars.githubusercontent.com/u/25632?v=3","gravatar_id":"","url":"https://api.github.com/users/andialbrecht","html_url":"https://github.com/andialbrecht","followers_url":"https://api.github.com/users/andialbrecht/followers","following_url":"https://api.github.com/users/andialbrecht/following{/other_user}","gists_url":"https://api.github.com/users/andialbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/andialbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andialbrecht/subscriptions","organizations_url":"https://api.github.com/users/andialbrecht/orgs","repos_url":"https://api.github.com/users/andialbrecht/repos","events_url":"https://api.github.com/users/andialbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/andialbrecht/received_events","type":"User","site_admin":false},"repo":{"id":4067434,"name":"sqlparse","full_name":"andialbrecht/sqlparse","owner":{"login":"andialbrecht","id":25632,"avatar_url":"https://avatars.githubusercontent.com/u/25632?v=3","gravatar_id":"","url":"https://api.github.com/users/andialbrecht","html_url":"https://github.com/andialbrecht","followers_url":"https://api.github.com/users/andialbrecht/followers","following_url":"https://api.github.com/users/andialbrecht/following{/other_user}","gists_url":"https://api.github.com/users/andialbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/andialbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andialbrecht/subscriptions","organizations_url":"https://api.github.com/users/andialbrecht/orgs","repos_url":"https://api.github.com/users/andialbrecht/repos","events_url":"https://api.github.com/users/andialbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/andialbrecht/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andialbrecht/sqlparse","description":"A non-validating SQL parser module for Python","fork":false,"url":"https://api.github.com/repos/andialbrecht/sqlparse","forks_url":"https://api.github.com/repos/andialbrecht/sqlparse/forks","keys_url":"https://api.github.com/repos/andialbrecht/sqlparse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andialbrecht/sqlparse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andialbrecht/sqlparse/teams","hooks_url":"https://api.github.com/repos/andialbrecht/sqlparse/hooks","issue_events_url":"https://api.github.com/repos/andialbrecht/sqlparse/issues/events{/number}","events_url":"https://api.github.com/repos/andialbrecht/sqlparse/events","assignees_url":"https://api.github.com/repos/andialbrecht/sqlparse/assignees{/user}","branches_url":"https://api.github.com/repos/andialbrecht/sqlparse/branches{/branch}","tags_url":"https://api.github.com/repos/andialbrecht/sqlparse/tags","blobs_url":"https://api.github.com/repos/andialbrecht/sqlparse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andialbrecht/sqlparse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andialbrecht/sqlparse/git/refs{/sha}","trees_url":"https://api.github.com/repos/andialbrecht/sqlparse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andialbrecht/sqlparse/statuses/{sha}","languages_url":"https://api.github.com/repos/andialbrecht/sqlparse/languages","stargazers_url":"https://api.github.com/repos/andialbrecht/sqlparse/stargazers","contributors_url":"https://api.github.com/repos/andialbrecht/sqlparse/contributors","subscribers_url":"https://api.github.com/repos/andialbrecht/sqlparse/subscribers","subscription_url":"https://api.github.com/repos/andialbrecht/sqlparse/subscription","commits_url":"https://api.github.com/repos/andialbrecht/sqlparse/commits{/sha}","git_commits_url":"https://api.github.com/repos/andialbrecht/sqlparse/git/commits{/sha}","comments_url":"https://api.github.com/repos/andialbrecht/sqlparse/comments{/number}","issue_comment_url":"https://api.github.com/repos/andialbrecht/sqlparse/issues/comments{/number}","contents_url":"https://api.github.com/repos/andialbrecht/sqlparse/contents/{+path}","compare_url":"https://api.github.com/repos/andialbrecht/sqlparse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andialbrecht/sqlparse/merges","archive_url":"https://api.github.com/repos/andialbrecht/sqlparse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andialbrecht/sqlparse/downloads","issues_url":"https://api.github.com/repos/andialbrecht/sqlparse/issues{/number}","pulls_url":"https://api.github.com/repos/andialbrecht/sqlparse/pulls{/number}","milestones_url":"https://api.github.com/repos/andialbrecht/sqlparse/milestones{/number}","notifications_url":"https://api.github.com/repos/andialbrecht/sqlparse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andialbrecht/sqlparse/labels{/name}","releases_url":"https://api.github.com/repos/andialbrecht/sqlparse/releases{/id}","deployments_url":"https://api.github.com/repos/andialbrecht/sqlparse/deployments","created_at":"2012-04-18T19:33:21Z","updated_at":"2016-06-17T06:55:05Z","pushed_at":"2016-06-16T09:33:28Z","git_url":"git://github.com/andialbrecht/sqlparse.git","ssh_url":"git@github.com:andialbrecht/sqlparse.git","clone_url":"https://github.com/andialbrecht/sqlparse.git","svn_url":"https://github.com/andialbrecht/sqlparse","homepage":"","size":1665,"stargazers_count":652,"watchers_count":652,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":37,"forks":161,"open_issues":37,"watchers":652,"default_branch":"master"}},"base":{"label":"andialbrecht:master","ref":"master","sha":"c6a5e7ac2a5ecc993f4e5292ab16e6df6b84f26c","user":{"login":"andialbrecht","id":25632,"avatar_url":"https://avatars.githubusercontent.com/u/25632?v=3","gravatar_id":"","url":"https://api.github.com/users/andialbrecht","html_url":"https://github.com/andialbrecht","followers_url":"https://api.github.com/users/andialbrecht/followers","following_url":"https://api.github.com/users/andialbrecht/following{/other_user}","gists_url":"https://api.github.com/users/andialbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/andialbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andialbrecht/subscriptions","organizations_url":"https://api.github.com/users/andialbrecht/orgs","repos_url":"https://api.github.com/users/andialbrecht/repos","events_url":"https://api.github.com/users/andialbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/andialbrecht/received_events","type":"User","site_admin":false},"repo":{"id":4067434,"name":"sqlparse","full_name":"andialbrecht/sqlparse","owner":{"login":"andialbrecht","id":25632,"avatar_url":"https://avatars.githubusercontent.com/u/25632?v=3","gravatar_id":"","url":"https://api.github.com/users/andialbrecht","html_url":"https://github.com/andialbrecht","followers_url":"https://api.github.com/users/andialbrecht/followers","following_url":"https://api.github.com/users/andialbrecht/following{/other_user}","gists_url":"https://api.github.com/users/andialbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/andialbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andialbrecht/subscriptions","organizations_url":"https://api.github.com/users/andialbrecht/orgs","repos_url":"https://api.github.com/users/andialbrecht/repos","events_url":"https://api.github.com/users/andialbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/andialbrecht/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andialbrecht/sqlparse","description":"A non-validating SQL parser module for Python","fork":false,"url":"https://api.github.com/repos/andialbrecht/sqlparse","forks_url":"https://api.github.com/repos/andialbrecht/sqlparse/forks","keys_url":"https://api.github.com/repos/andialbrecht/sqlparse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andialbrecht/sqlparse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andialbrecht/sqlparse/teams","hooks_url":"https://api.github.com/repos/andialbrecht/sqlparse/hooks","issue_events_url":"https://api.github.com/repos/andialbrecht/sqlparse/issues/events{/number}","events_url":"https://api.github.com/repos/andialbrecht/sqlparse/events","assignees_url":"https://api.github.com/repos/andialbrecht/sqlparse/assignees{/user}","branches_url":"https://api.github.com/repos/andialbrecht/sqlparse/branches{/branch}","tags_url":"https://api.github.com/repos/andialbrecht/sqlparse/tags","blobs_url":"https://api.github.com/repos/andialbrecht/sqlparse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andialbrecht/sqlparse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andialbrecht/sqlparse/git/refs{/sha}","trees_url":"https://api.github.com/repos/andialbrecht/sqlparse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andialbrecht/sqlparse/statuses/{sha}","languages_url":"https://api.github.com/repos/andialbrecht/sqlparse/languages","stargazers_url":"https://api.github.com/repos/andialbrecht/sqlparse/stargazers","contributors_url":"https://api.github.com/repos/andialbrecht/sqlparse/contributors","subscribers_url":"https://api.github.com/repos/andialbrecht/sqlparse/subscribers","subscription_url":"https://api.github.com/repos/andialbrecht/sqlparse/subscription","commits_url":"https://api.github.com/repos/andialbrecht/sqlparse/commits{/sha}","git_commits_url":"https://api.github.com/repos/andialbrecht/sqlparse/git/commits{/sha}","comments_url":"https://api.github.com/repos/andialbrecht/sqlparse/comments{/number}","issue_comment_url":"https://api.github.com/repos/andialbrecht/sqlparse/issues/comments{/number}","contents_url":"https://api.github.com/repos/andialbrecht/sqlparse/contents/{+path}","compare_url":"https://api.github.com/repos/andialbrecht/sqlparse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andialbrecht/sqlparse/merges","archive_url":"https://api.github.com/repos/andialbrecht/sqlparse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andialbrecht/sqlparse/downloads","issues_url":"https://api.github.com/repos/andialbrecht/sqlparse/issues{/number}","pulls_url":"https://api.github.com/repos/andialbrecht/sqlparse/pulls{/number}","milestones_url":"https://api.github.com/repos/andialbrecht/sqlparse/milestones{/number}","notifications_url":"https://api.github.com/repos/andialbrecht/sqlparse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andialbrecht/sqlparse/labels{/name}","releases_url":"https://api.github.com/repos/andialbrecht/sqlparse/releases{/id}","deployments_url":"https://api.github.com/repos/andialbrecht/sqlparse/deployments","created_at":"2012-04-18T19:33:21Z","updated_at":"2016-06-17T06:55:05Z","pushed_at":"2016-06-16T09:33:28Z","git_url":"git://github.com/andialbrecht/sqlparse.git","ssh_url":"git@github.com:andialbrecht/sqlparse.git","clone_url":"https://github.com/andialbrecht/sqlparse.git","svn_url":"https://github.com/andialbrecht/sqlparse","homepage":"","size":1665,"stargazers_count":652,"watchers_count":652,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":37,"forks":161,"open_issues":37,"watchers":652,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/251"},"html":{"href":"https://github.com/andialbrecht/sqlparse/pull/251"},"issue":{"href":"https://api.github.com/repos/andialbrecht/sqlparse/issues/251"},"comments":{"href":"https://api.github.com/repos/andialbrecht/sqlparse/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andialbrecht/sqlparse/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/andialbrecht/sqlparse/statuses/5747015634a39191511de8db576f2cd0aa5eafc9"}}}}
{"actor":{"display_login":"andialbrecht"}}