{"action":"created","issue":{"url":"https://api.github.com/repos/dpla/platform/issues/42","repository_url":"https://api.github.com/repos/dpla/platform","labels_url":"https://api.github.com/repos/dpla/platform/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/dpla/platform/issues/42/comments","events_url":"https://api.github.com/repos/dpla/platform/issues/42/events","html_url":"https://github.com/dpla/platform/pull/42","id":180047721,"number":42,"title":"Create Elasticsearch River with last sequence param","user":{"login":"markbreedlove","id":5550828,"avatar_url":"https://avatars.githubusercontent.com/u/5550828?v=3","gravatar_id":"","url":"https://api.github.com/users/markbreedlove","html_url":"https://github.com/markbreedlove","followers_url":"https://api.github.com/users/markbreedlove/followers","following_url":"https://api.github.com/users/markbreedlove/following{/other_user}","gists_url":"https://api.github.com/users/markbreedlove/gists{/gist_id}","starred_url":"https://api.github.com/users/markbreedlove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markbreedlove/subscriptions","organizations_url":"https://api.github.com/users/markbreedlove/orgs","repos_url":"https://api.github.com/users/markbreedlove/repos","events_url":"https://api.github.com/users/markbreedlove/events{/privacy}","received_events_url":"https://api.github.com/users/markbreedlove/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-29T13:22:39Z","updated_at":"2016-09-29T20:51:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dpla/platform/pulls/42","html_url":"https://github.com/dpla/platform/pull/42","diff_url":"https://github.com/dpla/platform/pull/42.diff","patch_url":"https://github.com/dpla/platform/pull/42.patch"},"body":"- Change River creation to require a last sequence number parameter, and to set it on the newly-created River.\r\n- Leave `V1::SearchEngine` shims for methods in `V1::SearchEngine::River` in-place but modified them where necessary, related to the River creation change.\r\n- Update River re-creation to get the last sequence number of the old River and set it for the new one.\r\n- Alter the behavior of `V1::SearchEngine::River.last_sequence` for it to raise an exception if there is an HTTP error, such as will happen if the river does not exists, or exists, but it pointed at an empty CouchDB database without having a `last_seq` number set. This should be an edge case now that we're having create_river require a `last_seq` parameter.\r\n- Add a number of missing unit tests for `V1::SearchEngine::River`.\r\n- Add status messages to stdout.\r\n- Add doc comments.\r\n\r\nRake task changes:\r\n- `create_river`: Task description no longer suggests defaulting to the currently-deployed index (implies that you should specify it). I'm not sure anyway that you could have left it empty in the rake task arguments.\r\n- `delete_river`: Now requires that you enter the name of the river to delete.\r\n\r\nAddresses https://issues.dp.la/issues/8576 "},"comment":{"url":"https://api.github.com/repos/dpla/platform/issues/comments/250587609","html_url":"https://github.com/dpla/platform/pull/42#issuecomment-250587609","issue_url":"https://api.github.com/repos/dpla/platform/issues/42","id":250587609,"user":{"login":"moltude","id":1419766,"avatar_url":"https://avatars.githubusercontent.com/u/1419766?v=3","gravatar_id":"","url":"https://api.github.com/users/moltude","html_url":"https://github.com/moltude","followers_url":"https://api.github.com/users/moltude/followers","following_url":"https://api.github.com/users/moltude/following{/other_user}","gists_url":"https://api.github.com/users/moltude/gists{/gist_id}","starred_url":"https://api.github.com/users/moltude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moltude/subscriptions","organizations_url":"https://api.github.com/users/moltude/orgs","repos_url":"https://api.github.com/users/moltude/repos","events_url":"https://api.github.com/users/moltude/events{/privacy}","received_events_url":"https://api.github.com/users/moltude/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T20:51:38Z","updated_at":"2016-09-29T20:51:38Z","body":"I think this is 👍  too "}}
{"actor":{"display_login":"moltude"}}