{"action":"created","comment":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/comments/51570698","id":51570698,"diff_hunk":"@@ -213,31 +278,22 @@ class TestWindowsOfflineBootstrap(TestWindowsBase, TestOfflineCliPackage):\n     def test_offline_windows_cli_package(self):\n         self._test_cli_package()\n \n-    def _update_hosts_file(self, resolution):\n+    def update_hosts_file(self, resolution):\n         cmd = 'ac -Encoding UTF8  ' \\\n               'C:\\Windows\\system32\\drivers\\etc\\hosts \"{0}\"'.format(resolution)\n         self._execute_command(cmd)\n \n-    def _prepare_cli(self):\n-        with self.dns():\n-            wget_cmd = \"\"\"\n-$client = New-Object System.Net.WebClient\n-$url = \"{0}\"\n-$file = \"{1}\"\n-$client.DownloadFile($url, $file)\"\"\".format(self.cli_package_url,\n-                                            CLI_PACKAGE_EXE)\n-            self.logger.info(\n-                'Downloading Windows CLI package from: {0}'.format(\n-                    self.cli_package_url))\n-        self._execute_command(wget_cmd)\n+    def prepare_cli(self):\n+        self.logger.info('Downloading Windows CLI package from: {0}'\n+                         .format(self.cli_package_url))\n+        self._get_resource(self.cli_package_url, CLI_PACKAGE_EXE)\n \n         return CLI_PACKAGE_EXE\n \n-    def _install_cli(self, package_name):\n+    def install_cli(self, package_name):","path":"system_tests/test_windows_bootstrap.py","position":394,"original_position":394,"commit_id":"de19d6db658acd88e4db722aebc910db7a187182","original_commit_id":"de19d6db658acd88e4db722aebc910db7a187182","user":{"login":"nirbir","id":2264173,"avatar_url":"https://avatars.githubusercontent.com/u/2264173?v=3","gravatar_id":"","url":"https://api.github.com/users/nirbir","html_url":"https://github.com/nirbir","followers_url":"https://api.github.com/users/nirbir/followers","following_url":"https://api.github.com/users/nirbir/following{/other_user}","gists_url":"https://api.github.com/users/nirbir/gists{/gist_id}","starred_url":"https://api.github.com/users/nirbir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirbir/subscriptions","organizations_url":"https://api.github.com/users/nirbir/orgs","repos_url":"https://api.github.com/users/nirbir/repos","events_url":"https://api.github.com/users/nirbir/events{/privacy}","received_events_url":"https://api.github.com/users/nirbir/received_events","type":"User","site_admin":false},"body":"Actually, the online windows test has an install_cli method, and so does the offline. windowsbase doesn't have it, so it seems fine ","created_at":"2016-02-02T13:58:46Z","updated_at":"2016-02-02T13:58:46Z","html_url":"https://github.com/cloudify-cosmo/cloudify-packager/pull/188#discussion_r51570698","pull_request_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/188","_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/comments/51570698"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-packager/pull/188#discussion_r51570698"},"pull_request":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/188","id":57537481,"html_url":"https://github.com/cloudify-cosmo/cloudify-packager/pull/188","diff_url":"https://github.com/cloudify-cosmo/cloudify-packager/pull/188.diff","patch_url":"https://github.com/cloudify-cosmo/cloudify-packager/pull/188.patch","issue_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/issues/188","number":188,"state":"open","locked":false,"title":"CFY-4639-AWS-based-offline-package-tests-missing-functionality","user":{"login":"max-orlov","id":9050974,"avatar_url":"https://avatars.githubusercontent.com/u/9050974?v=3","gravatar_id":"","url":"https://api.github.com/users/max-orlov","html_url":"https://github.com/max-orlov","followers_url":"https://api.github.com/users/max-orlov/followers","following_url":"https://api.github.com/users/max-orlov/following{/other_user}","gists_url":"https://api.github.com/users/max-orlov/gists{/gist_id}","starred_url":"https://api.github.com/users/max-orlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max-orlov/subscriptions","organizations_url":"https://api.github.com/users/max-orlov/orgs","repos_url":"https://api.github.com/users/max-orlov/repos","events_url":"https://api.github.com/users/max-orlov/events{/privacy}","received_events_url":"https://api.github.com/users/max-orlov/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-28T17:39:36Z","updated_at":"2016-02-02T13:58:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cfa1455b1e88a86ece1e5d2d23a4499c28ab173","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/188/commits","review_comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/188/comments","review_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/issues/188/comments","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/statuses/de19d6db658acd88e4db722aebc910db7a187182","head":{"label":"cloudify-cosmo:CFY-4639-AWS-based-offline-package-tests-missing-functionality-master","ref":"CFY-4639-AWS-based-offline-package-tests-missing-functionality-master","sha":"de19d6db658acd88e4db722aebc910db7a187182","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":18327496,"name":"cloudify-packager","full_name":"cloudify-cosmo/cloudify-packager","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/cloudify-packager","description":"Cloudify Resource Creation Configuration","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/releases{/id}","deployments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/deployments","created_at":"2014-04-01T11:43:44Z","updated_at":"2016-01-17T12:07:24Z","pushed_at":"2016-02-02T12:29:47Z","git_url":"git://github.com/cloudify-cosmo/cloudify-packager.git","ssh_url":"git@github.com:cloudify-cosmo/cloudify-packager.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-packager.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-packager","homepage":"","size":69687,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":9,"default_branch":"master"}},"base":{"label":"cloudify-cosmo:master","ref":"master","sha":"5e9f44c70b6d4f709927001f5eecf6ec08bbf151","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":18327496,"name":"cloudify-packager","full_name":"cloudify-cosmo/cloudify-packager","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/cloudify-packager","description":"Cloudify Resource Creation Configuration","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/releases{/id}","deployments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/deployments","created_at":"2014-04-01T11:43:44Z","updated_at":"2016-01-17T12:07:24Z","pushed_at":"2016-02-02T12:29:47Z","git_url":"git://github.com/cloudify-cosmo/cloudify-packager.git","ssh_url":"git@github.com:cloudify-cosmo/cloudify-packager.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-packager.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-packager","homepage":"","size":69687,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/188"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-packager/pull/188"},"issue":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/issues/188"},"comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-packager/statuses/de19d6db658acd88e4db722aebc910db7a187182"}}}}