{"action":"closed","number":99,"pull_request":{"url":"https://api.github.com/repos/ocf/puppet/pulls/99","id":95356170,"html_url":"https://github.com/ocf/puppet/pull/99","diff_url":"https://github.com/ocf/puppet/pull/99.diff","patch_url":"https://github.com/ocf/puppet/pull/99.patch","issue_url":"https://api.github.com/repos/ocf/puppet/issues/99","number":99,"state":"closed","locked":false,"title":"Refactor ocf_ssl to allow providing additional bundles","user":{"login":"chriskuehl","id":665269,"avatar_url":"https://avatars.githubusercontent.com/u/665269?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskuehl","html_url":"https://github.com/chriskuehl","followers_url":"https://api.github.com/users/chriskuehl/followers","following_url":"https://api.github.com/users/chriskuehl/following{/other_user}","gists_url":"https://api.github.com/users/chriskuehl/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskuehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskuehl/subscriptions","organizations_url":"https://api.github.com/users/chriskuehl/orgs","repos_url":"https://api.github.com/users/chriskuehl/repos","events_url":"https://api.github.com/users/chriskuehl/events{/privacy}","received_events_url":"https://api.github.com/users/chriskuehl/received_events","type":"User","site_admin":false},"body":"Sometimes we have the need to provide provide additional SSL certs/keys besides the main one based on the vhost. (In the past we did this for virtual hosts; another reason now is so that we can use a wildcard cert, since InCommon doesn't seem to have an option to use both a wildcard and other SANs on the same cert.)\r\n\r\nThis lets us easily define additional bundles, e.g.:\r\n\r\n```puppet\r\nocf_ssl::bundle { 'wildcard.agent.mesos.ocf.berkeley.edu':; }\r\n```\r\n\r\nThe default bundle is also provided this way now.","created_at":"2016-11-26T00:40:33Z","updated_at":"2016-11-26T00:58:15Z","closed_at":"2016-11-26T00:58:14Z","merged_at":"2016-11-26T00:58:14Z","merge_commit_sha":"60b00bae03f79b146f3f8cbcc13e64ff18decdb9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocf/puppet/pulls/99/commits","review_comments_url":"https://api.github.com/repos/ocf/puppet/pulls/99/comments","review_comment_url":"https://api.github.com/repos/ocf/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocf/puppet/issues/99/comments","statuses_url":"https://api.github.com/repos/ocf/puppet/statuses/027848cc84a1d0db48e3f798a7a2bde9f7635100","head":{"label":"ocf:refactor-ocf-ssl","ref":"refactor-ocf-ssl","sha":"027848cc84a1d0db48e3f798a7a2bde9f7635100","user":{"login":"ocf","id":1504667,"avatar_url":"https://avatars.githubusercontent.com/u/1504667?v=3","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"repo":{"id":7022222,"name":"puppet","full_name":"ocf/puppet","owner":{"login":"ocf","id":1504667,"avatar_url":"https://avatars.githubusercontent.com/u/1504667?v=3","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocf/puppet","description":"Puppet config for OCF servers and lab machines","fork":false,"url":"https://api.github.com/repos/ocf/puppet","forks_url":"https://api.github.com/repos/ocf/puppet/forks","keys_url":"https://api.github.com/repos/ocf/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocf/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocf/puppet/teams","hooks_url":"https://api.github.com/repos/ocf/puppet/hooks","issue_events_url":"https://api.github.com/repos/ocf/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/ocf/puppet/events","assignees_url":"https://api.github.com/repos/ocf/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/ocf/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/ocf/puppet/tags","blobs_url":"https://api.github.com/repos/ocf/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocf/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocf/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocf/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocf/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/ocf/puppet/languages","stargazers_url":"https://api.github.com/repos/ocf/puppet/stargazers","contributors_url":"https://api.github.com/repos/ocf/puppet/contributors","subscribers_url":"https://api.github.com/repos/ocf/puppet/subscribers","subscription_url":"https://api.github.com/repos/ocf/puppet/subscription","commits_url":"https://api.github.com/repos/ocf/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocf/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocf/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocf/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocf/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/ocf/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocf/puppet/merges","archive_url":"https://api.github.com/repos/ocf/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocf/puppet/downloads","issues_url":"https://api.github.com/repos/ocf/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/ocf/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/ocf/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/ocf/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocf/puppet/labels{/name}","releases_url":"https://api.github.com/repos/ocf/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/ocf/puppet/deployments","created_at":"2012-12-05T18:16:15Z","updated_at":"2016-10-22T02:37:42Z","pushed_at":"2016-11-26T00:58:14Z","git_url":"git://github.com/ocf/puppet.git","ssh_url":"git@github.com:ocf/puppet.git","clone_url":"https://github.com/ocf/puppet.git","svn_url":"https://github.com/ocf/puppet","homepage":"https://www.ocf.berkeley.edu/","size":3113,"stargazers_count":8,"watchers_count":8,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":8,"default_branch":"master"}},"base":{"label":"ocf:master","ref":"master","sha":"c5e5a5b5c128df9328098031398b42468259eb70","user":{"login":"ocf","id":1504667,"avatar_url":"https://avatars.githubusercontent.com/u/1504667?v=3","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"repo":{"id":7022222,"name":"puppet","full_name":"ocf/puppet","owner":{"login":"ocf","id":1504667,"avatar_url":"https://avatars.githubusercontent.com/u/1504667?v=3","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocf/puppet","description":"Puppet config for OCF servers and lab machines","fork":false,"url":"https://api.github.com/repos/ocf/puppet","forks_url":"https://api.github.com/repos/ocf/puppet/forks","keys_url":"https://api.github.com/repos/ocf/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocf/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocf/puppet/teams","hooks_url":"https://api.github.com/repos/ocf/puppet/hooks","issue_events_url":"https://api.github.com/repos/ocf/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/ocf/puppet/events","assignees_url":"https://api.github.com/repos/ocf/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/ocf/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/ocf/puppet/tags","blobs_url":"https://api.github.com/repos/ocf/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocf/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocf/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocf/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocf/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/ocf/puppet/languages","stargazers_url":"https://api.github.com/repos/ocf/puppet/stargazers","contributors_url":"https://api.github.com/repos/ocf/puppet/contributors","subscribers_url":"https://api.github.com/repos/ocf/puppet/subscribers","subscription_url":"https://api.github.com/repos/ocf/puppet/subscription","commits_url":"https://api.github.com/repos/ocf/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocf/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocf/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocf/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocf/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/ocf/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocf/puppet/merges","archive_url":"https://api.github.com/repos/ocf/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocf/puppet/downloads","issues_url":"https://api.github.com/repos/ocf/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/ocf/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/ocf/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/ocf/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocf/puppet/labels{/name}","releases_url":"https://api.github.com/repos/ocf/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/ocf/puppet/deployments","created_at":"2012-12-05T18:16:15Z","updated_at":"2016-10-22T02:37:42Z","pushed_at":"2016-11-26T00:58:14Z","git_url":"git://github.com/ocf/puppet.git","ssh_url":"git@github.com:ocf/puppet.git","clone_url":"https://github.com/ocf/puppet.git","svn_url":"https://github.com/ocf/puppet","homepage":"https://www.ocf.berkeley.edu/","size":3113,"stargazers_count":8,"watchers_count":8,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocf/puppet/pulls/99"},"html":{"href":"https://github.com/ocf/puppet/pull/99"},"issue":{"href":"https://api.github.com/repos/ocf/puppet/issues/99"},"comments":{"href":"https://api.github.com/repos/ocf/puppet/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/ocf/puppet/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/ocf/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocf/puppet/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/ocf/puppet/statuses/027848cc84a1d0db48e3f798a7a2bde9f7635100"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chriskuehl","id":665269,"avatar_url":"https://avatars.githubusercontent.com/u/665269?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskuehl","html_url":"https://github.com/chriskuehl","followers_url":"https://api.github.com/users/chriskuehl/followers","following_url":"https://api.github.com/users/chriskuehl/following{/other_user}","gists_url":"https://api.github.com/users/chriskuehl/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskuehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskuehl/subscriptions","organizations_url":"https://api.github.com/users/chriskuehl/orgs","repos_url":"https://api.github.com/users/chriskuehl/repos","events_url":"https://api.github.com/users/chriskuehl/events{/privacy}","received_events_url":"https://api.github.com/users/chriskuehl/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"commits":2,"additions":78,"deletions":61,"changed_files":23}}
{"actor":{"display_login":"chriskuehl"}}