{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/60237402","id":60237402,"diff_hunk":"@@ -45,23 +48,34 @@ def supports_authentication?(authtype)\n     supported_auth_types.include?(authtype.to_s)\n   end\n \n-  def self.raw_connect(server, port, username, password, service = \"Service\")\n-    require 'ovirt'\n+  def raw_connect(server, port, username, password, service = \"Service\")\n+    # If there is API path stored in the endpoints table and use it:\n+    path = default_endpoint.path\n+    unless path.blank?\n+      _log.info(\"Using stored API path '#{path}'.\")\n+    end\n+\n     Ovirt.logger = $rhevm_log\n \n     params = {\n       :server     => server,\n       :port       => port.presence && port.to_i,\n+      :path       => path,\n       :username   => username,\n       :password   => password,\n       :verify_ssl => false\n     }\n \n-    read_timeout, open_timeout = ems_timeouts(:ems_redhat, service)\n+    read_timeout, open_timeout = self.class.ems_timeouts(:ems_redhat, service)\n     params[:timeout]      = read_timeout if read_timeout\n     params[:open_timeout] = open_timeout if open_timeout\n \n-    Ovirt.const_get(service).new(params)\n+    result = Ovirt.const_get(service).new(params)\n+\n+    # Copy the API path to the endpoints table:\n+    default_endpoint.path = result.api_path","path":"app/models/manageiq/providers/redhat/infra_manager.rb","position":40,"original_position":40,"commit_id":"d4e045d2597236ca62200e715999a872613cc287","original_commit_id":"d4e045d2597236ca62200e715999a872613cc287","user":{"login":"jhernand","id":1423971,"avatar_url":"https://avatars.githubusercontent.com/u/1423971?v=3","gravatar_id":"","url":"https://api.github.com/users/jhernand","html_url":"https://github.com/jhernand","followers_url":"https://api.github.com/users/jhernand/followers","following_url":"https://api.github.com/users/jhernand/following{/other_user}","gists_url":"https://api.github.com/users/jhernand/gists{/gist_id}","starred_url":"https://api.github.com/users/jhernand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhernand/subscriptions","organizations_url":"https://api.github.com/users/jhernand/orgs","repos_url":"https://api.github.com/users/jhernand/repos","events_url":"https://api.github.com/users/jhernand/events{/privacy}","received_events_url":"https://api.github.com/users/jhernand/received_events","type":"User","site_admin":false},"body":"The change is persisted the first time that the connection is used to fetch the inventory, as it calls `ems.save`. Not sure if it should be done here, as this is called also when clicking the button to test the connection, and in that case I guess that we don't want to save anything.\r\n\r\nAnyhow, what is the exact syntax for `update_attributes!`?","created_at":"2016-04-19T14:09:15Z","updated_at":"2016-04-19T14:09:15Z","html_url":"https://github.com/ManageIQ/manageiq/pull/8055#discussion_r60237402","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8055","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/60237402"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/8055#discussion_r60237402"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8055"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8055","id":66912300,"html_url":"https://github.com/ManageIQ/manageiq/pull/8055","diff_url":"https://github.com/ManageIQ/manageiq/pull/8055.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/8055.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8055","number":8055,"state":"open","locked":false,"title":"Probe and save oVirt API path","user":{"login":"jhernand","id":1423971,"avatar_url":"https://avatars.githubusercontent.com/u/1423971?v=3","gravatar_id":"","url":"https://api.github.com/users/jhernand","html_url":"https://github.com/jhernand","followers_url":"https://api.github.com/users/jhernand/followers","following_url":"https://api.github.com/users/jhernand/following{/other_user}","gists_url":"https://api.github.com/users/jhernand/gists{/gist_id}","starred_url":"https://api.github.com/users/jhernand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhernand/subscriptions","organizations_url":"https://api.github.com/users/jhernand/orgs","repos_url":"https://api.github.com/users/jhernand/repos","events_url":"https://api.github.com/users/jhernand/events{/privacy}","received_events_url":"https://api.github.com/users/jhernand/received_events","type":"User","site_admin":false},"body":"This patch changes the oVirt provider so that it will determine the path\r\nof the oVirt API probing the candidates. Once determined it will be\r\nsaved to the \"path\" column of the \"endpoints\" table, and the next time\r\nit is required it will be retrieved from the table without probing.\r\n\r\nSigned-off-by: Juan Hernandez <juan.hernandez@redhat.com>","created_at":"2016-04-18T19:59:59Z","updated_at":"2016-04-19T14:09:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d3b34d249801c846b3f52d0f657a92a98434b20","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8055/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8055/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/8055/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/d4e045d2597236ca62200e715999a872613cc287","head":{"label":"jhernand:probe_and_save_ovirt_api_path","ref":"probe_and_save_ovirt_api_path","sha":"d4e045d2597236ca62200e715999a872613cc287","user":{"login":"jhernand","id":1423971,"avatar_url":"https://avatars.githubusercontent.com/u/1423971?v=3","gravatar_id":"","url":"https://api.github.com/users/jhernand","html_url":"https://github.com/jhernand","followers_url":"https://api.github.com/users/jhernand/followers","following_url":"https://api.github.com/users/jhernand/following{/other_user}","gists_url":"https://api.github.com/users/jhernand/gists{/gist_id}","starred_url":"https://api.github.com/users/jhernand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhernand/subscriptions","organizations_url":"https://api.github.com/users/jhernand/orgs","repos_url":"https://api.github.com/users/jhernand/repos","events_url":"https://api.github.com/users/jhernand/events{/privacy}","received_events_url":"https://api.github.com/users/jhernand/received_events","type":"User","site_admin":false},"repo":{"id":52809272,"name":"manageiq","full_name":"jhernand/manageiq","owner":{"login":"jhernand","id":1423971,"avatar_url":"https://avatars.githubusercontent.com/u/1423971?v=3","gravatar_id":"","url":"https://api.github.com/users/jhernand","html_url":"https://github.com/jhernand","followers_url":"https://api.github.com/users/jhernand/followers","following_url":"https://api.github.com/users/jhernand/following{/other_user}","gists_url":"https://api.github.com/users/jhernand/gists{/gist_id}","starred_url":"https://api.github.com/users/jhernand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhernand/subscriptions","organizations_url":"https://api.github.com/users/jhernand/orgs","repos_url":"https://api.github.com/users/jhernand/repos","events_url":"https://api.github.com/users/jhernand/events{/privacy}","received_events_url":"https://api.github.com/users/jhernand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhernand/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/jhernand/manageiq","forks_url":"https://api.github.com/repos/jhernand/manageiq/forks","keys_url":"https://api.github.com/repos/jhernand/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhernand/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhernand/manageiq/teams","hooks_url":"https://api.github.com/repos/jhernand/manageiq/hooks","issue_events_url":"https://api.github.com/repos/jhernand/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/jhernand/manageiq/events","assignees_url":"https://api.github.com/repos/jhernand/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/jhernand/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/jhernand/manageiq/tags","blobs_url":"https://api.github.com/repos/jhernand/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhernand/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhernand/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhernand/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhernand/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/jhernand/manageiq/languages","stargazers_url":"https://api.github.com/repos/jhernand/manageiq/stargazers","contributors_url":"https://api.github.com/repos/jhernand/manageiq/contributors","subscribers_url":"https://api.github.com/repos/jhernand/manageiq/subscribers","subscription_url":"https://api.github.com/repos/jhernand/manageiq/subscription","commits_url":"https://api.github.com/repos/jhernand/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhernand/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhernand/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhernand/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhernand/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/jhernand/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhernand/manageiq/merges","archive_url":"https://api.github.com/repos/jhernand/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhernand/manageiq/downloads","issues_url":"https://api.github.com/repos/jhernand/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/jhernand/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/jhernand/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/jhernand/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhernand/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/jhernand/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/jhernand/manageiq/deployments","created_at":"2016-02-29T17:21:33Z","updated_at":"2016-02-29T17:21:50Z","pushed_at":"2016-04-19T13:07:11Z","git_url":"git://github.com/jhernand/manageiq.git","ssh_url":"git@github.com:jhernand/manageiq.git","clone_url":"https://github.com/jhernand/manageiq.git","svn_url":"https://github.com/jhernand/manageiq","homepage":"manageiq.org","size":119291,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"4cde1637f3c56c1e718760feffbb4239d1bcb754","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-04-18T11:38:51Z","pushed_at":"2016-04-19T14:00:01Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":156753,"stargazers_count":254,"watchers_count":254,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":271,"mirror_url":null,"open_issues_count":627,"forks":271,"open_issues":627,"watchers":254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8055"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/8055"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/8055"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/8055/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8055/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/8055/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/d4e045d2597236ca62200e715999a872613cc287"}}}}