{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/connector-interfaces/pulls/comments/54929599","id":54929599,"diff_hunk":"@@ -61,8 +61,8 @@ def _create_csv_attachment(session, fields, data, options, file_name):\n     # write csv\n     f = StringIO()\n     writer = csv.writer(f,\n-                        delimiter=options.get(OPT_SEPARATOR),\n-                        quotechar=options.get(OPT_QUOTING))\n+                        delimiter=str(options.get(OPT_SEPARATOR)),\n+                        quotechar=str(options.get(OPT_QUOTING)))","path":"base_import_async/models/base_import_async.py","position":7,"original_position":7,"commit_id":"54218da29d242963396ff84506d836578c4da5f9","original_commit_id":"54218da29d242963396ff84506d836578c4da5f9","user":{"login":"guewen","id":417223,"avatar_url":"https://avatars.githubusercontent.com/u/417223?v=3","gravatar_id":"","url":"https://api.github.com/users/guewen","html_url":"https://github.com/guewen","followers_url":"https://api.github.com/users/guewen/followers","following_url":"https://api.github.com/users/guewen/following{/other_user}","gists_url":"https://api.github.com/users/guewen/gists{/gist_id}","starred_url":"https://api.github.com/users/guewen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guewen/subscriptions","organizations_url":"https://api.github.com/users/guewen/orgs","repos_url":"https://api.github.com/users/guewen/repos","events_url":"https://api.github.com/users/guewen/events{/privacy}","received_events_url":"https://api.github.com/users/guewen/received_events","type":"User","site_admin":false},"body":"Couldn'it end up with `'None'` as delimiter and quotechar if no option is set?","created_at":"2016-03-03T19:04:28Z","updated_at":"2016-03-03T19:04:28Z","html_url":"https://github.com/OCA/connector-interfaces/pull/28#discussion_r54929599","pull_request_url":"https://api.github.com/repos/OCA/connector-interfaces/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/OCA/connector-interfaces/pulls/comments/54929599"},"html":{"href":"https://github.com/OCA/connector-interfaces/pull/28#discussion_r54929599"},"pull_request":{"href":"https://api.github.com/repos/OCA/connector-interfaces/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/connector-interfaces/pulls/28","id":61580984,"html_url":"https://github.com/OCA/connector-interfaces/pull/28","diff_url":"https://github.com/OCA/connector-interfaces/pull/28.diff","patch_url":"https://github.com/OCA/connector-interfaces/pull/28.patch","issue_url":"https://api.github.com/repos/OCA/connector-interfaces/issues/28","number":28,"state":"open","locked":false,"title":"Migrate base_import_async to 9.0","user":{"login":"sbidoul","id":692075,"avatar_url":"https://avatars.githubusercontent.com/u/692075?v=3","gravatar_id":"","url":"https://api.github.com/users/sbidoul","html_url":"https://github.com/sbidoul","followers_url":"https://api.github.com/users/sbidoul/followers","following_url":"https://api.github.com/users/sbidoul/following{/other_user}","gists_url":"https://api.github.com/users/sbidoul/gists{/gist_id}","starred_url":"https://api.github.com/users/sbidoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbidoul/subscriptions","organizations_url":"https://api.github.com/users/sbidoul/orgs","repos_url":"https://api.github.com/users/sbidoul/repos","events_url":"https://api.github.com/users/sbidoul/events{/privacy}","received_events_url":"https://api.github.com/users/sbidoul/received_events","type":"User","site_admin":false},"body":"including latests commit from the 8.0 branch\r\n\r\nTODO:\r\n\r\n- [x] fix problem with qweb and/or js that prevents the view to load","created_at":"2016-03-03T16:01:55Z","updated_at":"2016-03-03T19:04:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee200e7079097ea08653a91574acc7a652ecd7d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OCA/connector-interfaces/pulls/28/commits","review_comments_url":"https://api.github.com/repos/OCA/connector-interfaces/pulls/28/comments","review_comment_url":"https://api.github.com/repos/OCA/connector-interfaces/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/connector-interfaces/issues/28/comments","statuses_url":"https://api.github.com/repos/OCA/connector-interfaces/statuses/54218da29d242963396ff84506d836578c4da5f9","head":{"label":"acsone:9.0-mig-sbi","ref":"9.0-mig-sbi","sha":"54218da29d242963396ff84506d836578c4da5f9","user":{"login":"acsone","id":7601056,"avatar_url":"https://avatars.githubusercontent.com/u/7601056?v=3","gravatar_id":"","url":"https://api.github.com/users/acsone","html_url":"https://github.com/acsone","followers_url":"https://api.github.com/users/acsone/followers","following_url":"https://api.github.com/users/acsone/following{/other_user}","gists_url":"https://api.github.com/users/acsone/gists{/gist_id}","starred_url":"https://api.github.com/users/acsone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acsone/subscriptions","organizations_url":"https://api.github.com/users/acsone/orgs","repos_url":"https://api.github.com/users/acsone/repos","events_url":"https://api.github.com/users/acsone/events{/privacy}","received_events_url":"https://api.github.com/users/acsone/received_events","type":"Organization","site_admin":false},"repo":{"id":26533214,"name":"connector-interfaces","full_name":"acsone/connector-interfaces","owner":{"login":"acsone","id":7601056,"avatar_url":"https://avatars.githubusercontent.com/u/7601056?v=3","gravatar_id":"","url":"https://api.github.com/users/acsone","html_url":"https://github.com/acsone","followers_url":"https://api.github.com/users/acsone/followers","following_url":"https://api.github.com/users/acsone/following{/other_user}","gists_url":"https://api.github.com/users/acsone/gists{/gist_id}","starred_url":"https://api.github.com/users/acsone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acsone/subscriptions","organizations_url":"https://api.github.com/users/acsone/orgs","repos_url":"https://api.github.com/users/acsone/repos","events_url":"https://api.github.com/users/acsone/events{/privacy}","received_events_url":"https://api.github.com/users/acsone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acsone/connector-interfaces","description":"","fork":true,"url":"https://api.github.com/repos/acsone/connector-interfaces","forks_url":"https://api.github.com/repos/acsone/connector-interfaces/forks","keys_url":"https://api.github.com/repos/acsone/connector-interfaces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acsone/connector-interfaces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acsone/connector-interfaces/teams","hooks_url":"https://api.github.com/repos/acsone/connector-interfaces/hooks","issue_events_url":"https://api.github.com/repos/acsone/connector-interfaces/issues/events{/number}","events_url":"https://api.github.com/repos/acsone/connector-interfaces/events","assignees_url":"https://api.github.com/repos/acsone/connector-interfaces/assignees{/user}","branches_url":"https://api.github.com/repos/acsone/connector-interfaces/branches{/branch}","tags_url":"https://api.github.com/repos/acsone/connector-interfaces/tags","blobs_url":"https://api.github.com/repos/acsone/connector-interfaces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acsone/connector-interfaces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acsone/connector-interfaces/git/refs{/sha}","trees_url":"https://api.github.com/repos/acsone/connector-interfaces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acsone/connector-interfaces/statuses/{sha}","languages_url":"https://api.github.com/repos/acsone/connector-interfaces/languages","stargazers_url":"https://api.github.com/repos/acsone/connector-interfaces/stargazers","contributors_url":"https://api.github.com/repos/acsone/connector-interfaces/contributors","subscribers_url":"https://api.github.com/repos/acsone/connector-interfaces/subscribers","subscription_url":"https://api.github.com/repos/acsone/connector-interfaces/subscription","commits_url":"https://api.github.com/repos/acsone/connector-interfaces/commits{/sha}","git_commits_url":"https://api.github.com/repos/acsone/connector-interfaces/git/commits{/sha}","comments_url":"https://api.github.com/repos/acsone/connector-interfaces/comments{/number}","issue_comment_url":"https://api.github.com/repos/acsone/connector-interfaces/issues/comments{/number}","contents_url":"https://api.github.com/repos/acsone/connector-interfaces/contents/{+path}","compare_url":"https://api.github.com/repos/acsone/connector-interfaces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acsone/connector-interfaces/merges","archive_url":"https://api.github.com/repos/acsone/connector-interfaces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acsone/connector-interfaces/downloads","issues_url":"https://api.github.com/repos/acsone/connector-interfaces/issues{/number}","pulls_url":"https://api.github.com/repos/acsone/connector-interfaces/pulls{/number}","milestones_url":"https://api.github.com/repos/acsone/connector-interfaces/milestones{/number}","notifications_url":"https://api.github.com/repos/acsone/connector-interfaces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acsone/connector-interfaces/labels{/name}","releases_url":"https://api.github.com/repos/acsone/connector-interfaces/releases{/id}","deployments_url":"https://api.github.com/repos/acsone/connector-interfaces/deployments","created_at":"2014-11-12T11:38:35Z","updated_at":"2015-04-21T10:22:36Z","pushed_at":"2016-03-03T17:07:39Z","git_url":"git://github.com/acsone/connector-interfaces.git","ssh_url":"git@github.com:acsone/connector-interfaces.git","clone_url":"https://github.com/acsone/connector-interfaces.git","svn_url":"https://github.com/acsone/connector-interfaces","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"8.0"}},"base":{"label":"OCA:9.0","ref":"9.0","sha":"681bb2ba01a229098542323dcd0834ebbf940e1b","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":24750581,"name":"connector-interfaces","full_name":"OCA/connector-interfaces","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/connector-interfaces","description":"Odoo Generic Connector for ODBC, .CSV,...","fork":false,"url":"https://api.github.com/repos/OCA/connector-interfaces","forks_url":"https://api.github.com/repos/OCA/connector-interfaces/forks","keys_url":"https://api.github.com/repos/OCA/connector-interfaces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/connector-interfaces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/connector-interfaces/teams","hooks_url":"https://api.github.com/repos/OCA/connector-interfaces/hooks","issue_events_url":"https://api.github.com/repos/OCA/connector-interfaces/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/connector-interfaces/events","assignees_url":"https://api.github.com/repos/OCA/connector-interfaces/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/connector-interfaces/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/connector-interfaces/tags","blobs_url":"https://api.github.com/repos/OCA/connector-interfaces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/connector-interfaces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/connector-interfaces/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/connector-interfaces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/connector-interfaces/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/connector-interfaces/languages","stargazers_url":"https://api.github.com/repos/OCA/connector-interfaces/stargazers","contributors_url":"https://api.github.com/repos/OCA/connector-interfaces/contributors","subscribers_url":"https://api.github.com/repos/OCA/connector-interfaces/subscribers","subscription_url":"https://api.github.com/repos/OCA/connector-interfaces/subscription","commits_url":"https://api.github.com/repos/OCA/connector-interfaces/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/connector-interfaces/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/connector-interfaces/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/connector-interfaces/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/connector-interfaces/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/connector-interfaces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/connector-interfaces/merges","archive_url":"https://api.github.com/repos/OCA/connector-interfaces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/connector-interfaces/downloads","issues_url":"https://api.github.com/repos/OCA/connector-interfaces/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/connector-interfaces/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/connector-interfaces/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/connector-interfaces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/connector-interfaces/labels{/name}","releases_url":"https://api.github.com/repos/OCA/connector-interfaces/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/connector-interfaces/deployments","created_at":"2014-10-03T07:46:15Z","updated_at":"2016-03-03T17:16:01Z","pushed_at":"2016-03-03T17:07:40Z","git_url":"git://github.com/OCA/connector-interfaces.git","ssh_url":"git@github.com:OCA/connector-interfaces.git","clone_url":"https://github.com/OCA/connector-interfaces.git","svn_url":"https://github.com/OCA/connector-interfaces","homepage":"","size":1129,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":9,"forks":42,"open_issues":9,"watchers":18,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/connector-interfaces/pulls/28"},"html":{"href":"https://github.com/OCA/connector-interfaces/pull/28"},"issue":{"href":"https://api.github.com/repos/OCA/connector-interfaces/issues/28"},"comments":{"href":"https://api.github.com/repos/OCA/connector-interfaces/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/connector-interfaces/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/connector-interfaces/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/connector-interfaces/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/connector-interfaces/statuses/54218da29d242963396ff84506d836578c4da5f9"}}}}