{"action":"closed","number":113,"pull_request":{"url":"https://api.github.com/repos/KimiNewt/pyshark/pulls/113","id":55724666,"html_url":"https://github.com/KimiNewt/pyshark/pull/113","diff_url":"https://github.com/KimiNewt/pyshark/pull/113.diff","patch_url":"https://github.com/KimiNewt/pyshark/pull/113.patch","issue_url":"https://api.github.com/repos/KimiNewt/pyshark/issues/113","number":113,"state":"closed","locked":false,"title":"Updating get_tshark_version() to support a wider variety of TShark version line strings","user":{"login":"monkut","id":1135529,"avatar_url":"https://avatars.githubusercontent.com/u/1135529?v=3","gravatar_id":"","url":"https://api.github.com/users/monkut","html_url":"https://github.com/monkut","followers_url":"https://api.github.com/users/monkut/followers","following_url":"https://api.github.com/users/monkut/following{/other_user}","gists_url":"https://api.github.com/users/monkut/gists{/gist_id}","starred_url":"https://api.github.com/users/monkut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monkut/subscriptions","organizations_url":"https://api.github.com/users/monkut/orgs","repos_url":"https://api.github.com/users/monkut/repos","events_url":"https://api.github.com/users/monkut/events{/privacy}","received_events_url":"https://api.github.com/users/monkut/received_events","type":"User","site_admin":false},"body":"Version strings for TSHARK are displayed differently for different versions of TShark.\r\nThe following were found as a difference between Windows and Linux:\r\n\r\nwin_version_line = 'TShark 1.12.8 (v1.12.8-0-g5b6e543 from master-1.12)'\r\nlnx_version_line = 'TShark (Wireshark) 2.0.0 (SVN Rev Unknown from unknown)'\r\n\r\nThe current implementation returned \"(Wireshark)\" for the Linux case above, and caused an error in version comparision performed in 'get_tshark_display_filter_flag()'.","created_at":"2016-01-12T07:55:15Z","updated_at":"2016-01-13T21:13:10Z","closed_at":"2016-01-13T21:13:10Z","merged_at":null,"merge_commit_sha":"343b2c05a5a2c8748fe097f76584460a076bd037","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KimiNewt/pyshark/pulls/113/commits","review_comments_url":"https://api.github.com/repos/KimiNewt/pyshark/pulls/113/comments","review_comment_url":"https://api.github.com/repos/KimiNewt/pyshark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KimiNewt/pyshark/issues/113/comments","statuses_url":"https://api.github.com/repos/KimiNewt/pyshark/statuses/bdc0efcca82de89e4211f67bf3772d76ac8f65a7","head":{"label":"monkut:master","ref":"master","sha":"bdc0efcca82de89e4211f67bf3772d76ac8f65a7","user":{"login":"monkut","id":1135529,"avatar_url":"https://avatars.githubusercontent.com/u/1135529?v=3","gravatar_id":"","url":"https://api.github.com/users/monkut","html_url":"https://github.com/monkut","followers_url":"https://api.github.com/users/monkut/followers","following_url":"https://api.github.com/users/monkut/following{/other_user}","gists_url":"https://api.github.com/users/monkut/gists{/gist_id}","starred_url":"https://api.github.com/users/monkut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monkut/subscriptions","organizations_url":"https://api.github.com/users/monkut/orgs","repos_url":"https://api.github.com/users/monkut/repos","events_url":"https://api.github.com/users/monkut/events{/privacy}","received_events_url":"https://api.github.com/users/monkut/received_events","type":"User","site_admin":false},"repo":{"id":49258451,"name":"pyshark","full_name":"monkut/pyshark","owner":{"login":"monkut","id":1135529,"avatar_url":"https://avatars.githubusercontent.com/u/1135529?v=3","gravatar_id":"","url":"https://api.github.com/users/monkut","html_url":"https://github.com/monkut","followers_url":"https://api.github.com/users/monkut/followers","following_url":"https://api.github.com/users/monkut/following{/other_user}","gists_url":"https://api.github.com/users/monkut/gists{/gist_id}","starred_url":"https://api.github.com/users/monkut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monkut/subscriptions","organizations_url":"https://api.github.com/users/monkut/orgs","repos_url":"https://api.github.com/users/monkut/repos","events_url":"https://api.github.com/users/monkut/events{/privacy}","received_events_url":"https://api.github.com/users/monkut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monkut/pyshark","description":"Python wrapper for tshark, allowing python packet parsing using wireshark dissectors","fork":true,"url":"https://api.github.com/repos/monkut/pyshark","forks_url":"https://api.github.com/repos/monkut/pyshark/forks","keys_url":"https://api.github.com/repos/monkut/pyshark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monkut/pyshark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monkut/pyshark/teams","hooks_url":"https://api.github.com/repos/monkut/pyshark/hooks","issue_events_url":"https://api.github.com/repos/monkut/pyshark/issues/events{/number}","events_url":"https://api.github.com/repos/monkut/pyshark/events","assignees_url":"https://api.github.com/repos/monkut/pyshark/assignees{/user}","branches_url":"https://api.github.com/repos/monkut/pyshark/branches{/branch}","tags_url":"https://api.github.com/repos/monkut/pyshark/tags","blobs_url":"https://api.github.com/repos/monkut/pyshark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monkut/pyshark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monkut/pyshark/git/refs{/sha}","trees_url":"https://api.github.com/repos/monkut/pyshark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monkut/pyshark/statuses/{sha}","languages_url":"https://api.github.com/repos/monkut/pyshark/languages","stargazers_url":"https://api.github.com/repos/monkut/pyshark/stargazers","contributors_url":"https://api.github.com/repos/monkut/pyshark/contributors","subscribers_url":"https://api.github.com/repos/monkut/pyshark/subscribers","subscription_url":"https://api.github.com/repos/monkut/pyshark/subscription","commits_url":"https://api.github.com/repos/monkut/pyshark/commits{/sha}","git_commits_url":"https://api.github.com/repos/monkut/pyshark/git/commits{/sha}","comments_url":"https://api.github.com/repos/monkut/pyshark/comments{/number}","issue_comment_url":"https://api.github.com/repos/monkut/pyshark/issues/comments{/number}","contents_url":"https://api.github.com/repos/monkut/pyshark/contents/{+path}","compare_url":"https://api.github.com/repos/monkut/pyshark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monkut/pyshark/merges","archive_url":"https://api.github.com/repos/monkut/pyshark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monkut/pyshark/downloads","issues_url":"https://api.github.com/repos/monkut/pyshark/issues{/number}","pulls_url":"https://api.github.com/repos/monkut/pyshark/pulls{/number}","milestones_url":"https://api.github.com/repos/monkut/pyshark/milestones{/number}","notifications_url":"https://api.github.com/repos/monkut/pyshark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monkut/pyshark/labels{/name}","releases_url":"https://api.github.com/repos/monkut/pyshark/releases{/id}","created_at":"2016-01-08T07:59:57Z","updated_at":"2016-01-12T07:50:08Z","pushed_at":"2016-01-12T07:50:17Z","git_url":"git://github.com/monkut/pyshark.git","ssh_url":"git@github.com:monkut/pyshark.git","clone_url":"https://github.com/monkut/pyshark.git","svn_url":"https://github.com/monkut/pyshark","homepage":null,"size":194,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KimiNewt:master","ref":"master","sha":"8fe71088bb638c221660391c3e78e1dd8e0c0d40","user":{"login":"KimiNewt","id":2090554,"avatar_url":"https://avatars.githubusercontent.com/u/2090554?v=3","gravatar_id":"","url":"https://api.github.com/users/KimiNewt","html_url":"https://github.com/KimiNewt","followers_url":"https://api.github.com/users/KimiNewt/followers","following_url":"https://api.github.com/users/KimiNewt/following{/other_user}","gists_url":"https://api.github.com/users/KimiNewt/gists{/gist_id}","starred_url":"https://api.github.com/users/KimiNewt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KimiNewt/subscriptions","organizations_url":"https://api.github.com/users/KimiNewt/orgs","repos_url":"https://api.github.com/users/KimiNewt/repos","events_url":"https://api.github.com/users/KimiNewt/events{/privacy}","received_events_url":"https://api.github.com/users/KimiNewt/received_events","type":"User","site_admin":false},"repo":{"id":15493723,"name":"pyshark","full_name":"KimiNewt/pyshark","owner":{"login":"KimiNewt","id":2090554,"avatar_url":"https://avatars.githubusercontent.com/u/2090554?v=3","gravatar_id":"","url":"https://api.github.com/users/KimiNewt","html_url":"https://github.com/KimiNewt","followers_url":"https://api.github.com/users/KimiNewt/followers","following_url":"https://api.github.com/users/KimiNewt/following{/other_user}","gists_url":"https://api.github.com/users/KimiNewt/gists{/gist_id}","starred_url":"https://api.github.com/users/KimiNewt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KimiNewt/subscriptions","organizations_url":"https://api.github.com/users/KimiNewt/orgs","repos_url":"https://api.github.com/users/KimiNewt/repos","events_url":"https://api.github.com/users/KimiNewt/events{/privacy}","received_events_url":"https://api.github.com/users/KimiNewt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KimiNewt/pyshark","description":"Python wrapper for tshark, allowing python packet parsing using wireshark dissectors","fork":false,"url":"https://api.github.com/repos/KimiNewt/pyshark","forks_url":"https://api.github.com/repos/KimiNewt/pyshark/forks","keys_url":"https://api.github.com/repos/KimiNewt/pyshark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KimiNewt/pyshark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KimiNewt/pyshark/teams","hooks_url":"https://api.github.com/repos/KimiNewt/pyshark/hooks","issue_events_url":"https://api.github.com/repos/KimiNewt/pyshark/issues/events{/number}","events_url":"https://api.github.com/repos/KimiNewt/pyshark/events","assignees_url":"https://api.github.com/repos/KimiNewt/pyshark/assignees{/user}","branches_url":"https://api.github.com/repos/KimiNewt/pyshark/branches{/branch}","tags_url":"https://api.github.com/repos/KimiNewt/pyshark/tags","blobs_url":"https://api.github.com/repos/KimiNewt/pyshark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KimiNewt/pyshark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KimiNewt/pyshark/git/refs{/sha}","trees_url":"https://api.github.com/repos/KimiNewt/pyshark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KimiNewt/pyshark/statuses/{sha}","languages_url":"https://api.github.com/repos/KimiNewt/pyshark/languages","stargazers_url":"https://api.github.com/repos/KimiNewt/pyshark/stargazers","contributors_url":"https://api.github.com/repos/KimiNewt/pyshark/contributors","subscribers_url":"https://api.github.com/repos/KimiNewt/pyshark/subscribers","subscription_url":"https://api.github.com/repos/KimiNewt/pyshark/subscription","commits_url":"https://api.github.com/repos/KimiNewt/pyshark/commits{/sha}","git_commits_url":"https://api.github.com/repos/KimiNewt/pyshark/git/commits{/sha}","comments_url":"https://api.github.com/repos/KimiNewt/pyshark/comments{/number}","issue_comment_url":"https://api.github.com/repos/KimiNewt/pyshark/issues/comments{/number}","contents_url":"https://api.github.com/repos/KimiNewt/pyshark/contents/{+path}","compare_url":"https://api.github.com/repos/KimiNewt/pyshark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KimiNewt/pyshark/merges","archive_url":"https://api.github.com/repos/KimiNewt/pyshark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KimiNewt/pyshark/downloads","issues_url":"https://api.github.com/repos/KimiNewt/pyshark/issues{/number}","pulls_url":"https://api.github.com/repos/KimiNewt/pyshark/pulls{/number}","milestones_url":"https://api.github.com/repos/KimiNewt/pyshark/milestones{/number}","notifications_url":"https://api.github.com/repos/KimiNewt/pyshark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KimiNewt/pyshark/labels{/name}","releases_url":"https://api.github.com/repos/KimiNewt/pyshark/releases{/id}","created_at":"2013-12-28T14:38:22Z","updated_at":"2016-01-12T21:27:55Z","pushed_at":"2016-01-12T07:55:16Z","git_url":"git://github.com/KimiNewt/pyshark.git","ssh_url":"git@github.com:KimiNewt/pyshark.git","clone_url":"https://github.com/KimiNewt/pyshark.git","svn_url":"https://github.com/KimiNewt/pyshark","homepage":null,"size":200,"stargazers_count":171,"watchers_count":171,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":61,"mirror_url":null,"open_issues_count":28,"forks":61,"open_issues":28,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KimiNewt/pyshark/pulls/113"},"html":{"href":"https://github.com/KimiNewt/pyshark/pull/113"},"issue":{"href":"https://api.github.com/repos/KimiNewt/pyshark/issues/113"},"comments":{"href":"https://api.github.com/repos/KimiNewt/pyshark/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/KimiNewt/pyshark/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/KimiNewt/pyshark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KimiNewt/pyshark/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/KimiNewt/pyshark/statuses/bdc0efcca82de89e4211f67bf3772d76ac8f65a7"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":9,"deletions":1,"changed_files":1}}