{"action":"created","comment":{"url":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/comments/75962665","id":75962665,"diff_hunk":"@@ -1215,6 +1215,8 @@ def __init__(self, application, ssh, config):\n \t\tself.application = application\n \t\tself.ssh = ssh\n \t\tself.config = config\n+\t\tself._path_mod_local = os.path\n+\t\tself._path_mod_remote = posixpath","path":"client/sftp_client.py","position":null,"original_position":163,"commit_id":"563009abe75dd4af452ec25b1f3e09951d5321c3","original_commit_id":"563009abe75dd4af452ec25b1f3e09951d5321c3","user":{"login":"zeroSteiner","id":2058303,"avatar_url":"https://avatars.githubusercontent.com/u/2058303?v=3","gravatar_id":"","url":"https://api.github.com/users/zeroSteiner","html_url":"https://github.com/zeroSteiner","followers_url":"https://api.github.com/users/zeroSteiner/followers","following_url":"https://api.github.com/users/zeroSteiner/following{/other_user}","gists_url":"https://api.github.com/users/zeroSteiner/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroSteiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroSteiner/subscriptions","organizations_url":"https://api.github.com/users/zeroSteiner/orgs","repos_url":"https://api.github.com/users/zeroSteiner/repos","events_url":"https://api.github.com/users/zeroSteiner/events{/privacy}","received_events_url":"https://api.github.com/users/zeroSteiner/received_events","type":"User","site_admin":false},"body":"No. This is not a good idea because the path module could be completely different than what the local and remote objects are actually using. Since the `_path_mod` needs to be used by other things, it should be exposed by simply making it public. There can't be two separate places where the appropriate path module is tracked for each of the local and remote directories.","created_at":"2016-08-23T22:21:41Z","updated_at":"2016-08-23T22:21:41Z","html_url":"https://github.com/securestate/king-phisher-plugins/pull/5#discussion_r75962665","pull_request_url":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/comments/75962665"},"html":{"href":"https://github.com/securestate/king-phisher-plugins/pull/5#discussion_r75962665"},"pull_request":{"href":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/5","id":80982292,"html_url":"https://github.com/securestate/king-phisher-plugins/pull/5","diff_url":"https://github.com/securestate/king-phisher-plugins/pull/5.diff","patch_url":"https://github.com/securestate/king-phisher-plugins/pull/5.patch","issue_url":"https://api.github.com/repos/securestate/king-phisher-plugins/issues/5","number":5,"state":"open","locked":false,"title":"Version 1.0 of the SFTP Plugin","user":{"login":"zeroSteiner","id":2058303,"avatar_url":"https://avatars.githubusercontent.com/u/2058303?v=3","gravatar_id":"","url":"https://api.github.com/users/zeroSteiner","html_url":"https://github.com/zeroSteiner","followers_url":"https://api.github.com/users/zeroSteiner/followers","following_url":"https://api.github.com/users/zeroSteiner/following{/other_user}","gists_url":"https://api.github.com/users/zeroSteiner/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroSteiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroSteiner/subscriptions","organizations_url":"https://api.github.com/users/zeroSteiner/orgs","repos_url":"https://api.github.com/users/zeroSteiner/repos","events_url":"https://api.github.com/users/zeroSteiner/events{/privacy}","received_events_url":"https://api.github.com/users/zeroSteiner/received_events","type":"User","site_admin":false},"body":"This is version 1.0 of the SFTP plugin which is all of @jacobj10's awesome work from his summer internship.\r\n\r\nTasks:\r\n- [ ] The UI is clean and intuitive (feedback on changes would be appreciated)\r\n- [ ] The plugin's description makes sense\r\n- [ ] Working directories are persisted across runs of the application / plugin\r\n- [ ] Test the plugin on a Linux client\r\n - [ ] Uploading files and folders work\r\n - [ ] Downloading files and folders work\r\n - [ ] Task status changes work as expected (ie Pending -> Transferring -> Paused -> Finished etc.)\r\n - [ ] Setting the working directory\r\n - [ ] Renaming and deleting a file / directory works\r\n- [ ] Test the plugin on a Windows client (cc @wolfthefallen)\r\n - [x] Uploading files and folders work\r\n - [x] Downloading files and folders work\r\n - [ ] Task status changes work as expected (ie Pending -> Transferring -> Paused -> Finished etc.)\r\n - [x] Setting the working directory works\r\n - [x] Creating a folder works\r\n - [x] Renaming and deleting a file / directory works\r\n - [ ] The plugin works when King Phisher is frozen (built)","created_at":"2016-08-11T15:50:30Z","updated_at":"2016-08-23T22:21:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ba81125cb6c8284e7fbce04f2b741b18b7687f7","assignee":{"login":"zeroSteiner","id":2058303,"avatar_url":"https://avatars.githubusercontent.com/u/2058303?v=3","gravatar_id":"","url":"https://api.github.com/users/zeroSteiner","html_url":"https://github.com/zeroSteiner","followers_url":"https://api.github.com/users/zeroSteiner/followers","following_url":"https://api.github.com/users/zeroSteiner/following{/other_user}","gists_url":"https://api.github.com/users/zeroSteiner/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroSteiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroSteiner/subscriptions","organizations_url":"https://api.github.com/users/zeroSteiner/orgs","repos_url":"https://api.github.com/users/zeroSteiner/repos","events_url":"https://api.github.com/users/zeroSteiner/events{/privacy}","received_events_url":"https://api.github.com/users/zeroSteiner/received_events","type":"User","site_admin":false},"assignees":[{"login":"zeroSteiner","id":2058303,"avatar_url":"https://avatars.githubusercontent.com/u/2058303?v=3","gravatar_id":"","url":"https://api.github.com/users/zeroSteiner","html_url":"https://github.com/zeroSteiner","followers_url":"https://api.github.com/users/zeroSteiner/followers","following_url":"https://api.github.com/users/zeroSteiner/following{/other_user}","gists_url":"https://api.github.com/users/zeroSteiner/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroSteiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroSteiner/subscriptions","organizations_url":"https://api.github.com/users/zeroSteiner/orgs","repos_url":"https://api.github.com/users/zeroSteiner/repos","events_url":"https://api.github.com/users/zeroSteiner/events{/privacy}","received_events_url":"https://api.github.com/users/zeroSteiner/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/5/commits","review_comments_url":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/5/comments","review_comment_url":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/securestate/king-phisher-plugins/issues/5/comments","statuses_url":"https://api.github.com/repos/securestate/king-phisher-plugins/statuses/563009abe75dd4af452ec25b1f3e09951d5321c3","head":{"label":"securestate:sftp","ref":"sftp","sha":"563009abe75dd4af452ec25b1f3e09951d5321c3","user":{"login":"securestate","id":3228981,"avatar_url":"https://avatars.githubusercontent.com/u/3228981?v=3","gravatar_id":"","url":"https://api.github.com/users/securestate","html_url":"https://github.com/securestate","followers_url":"https://api.github.com/users/securestate/followers","following_url":"https://api.github.com/users/securestate/following{/other_user}","gists_url":"https://api.github.com/users/securestate/gists{/gist_id}","starred_url":"https://api.github.com/users/securestate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/securestate/subscriptions","organizations_url":"https://api.github.com/users/securestate/orgs","repos_url":"https://api.github.com/users/securestate/repos","events_url":"https://api.github.com/users/securestate/events{/privacy}","received_events_url":"https://api.github.com/users/securestate/received_events","type":"Organization","site_admin":false},"repo":{"id":57471284,"name":"king-phisher-plugins","full_name":"securestate/king-phisher-plugins","owner":{"login":"securestate","id":3228981,"avatar_url":"https://avatars.githubusercontent.com/u/3228981?v=3","gravatar_id":"","url":"https://api.github.com/users/securestate","html_url":"https://github.com/securestate","followers_url":"https://api.github.com/users/securestate/followers","following_url":"https://api.github.com/users/securestate/following{/other_user}","gists_url":"https://api.github.com/users/securestate/gists{/gist_id}","starred_url":"https://api.github.com/users/securestate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/securestate/subscriptions","organizations_url":"https://api.github.com/users/securestate/orgs","repos_url":"https://api.github.com/users/securestate/repos","events_url":"https://api.github.com/users/securestate/events{/privacy}","received_events_url":"https://api.github.com/users/securestate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/securestate/king-phisher-plugins","description":"Plugins for the King Phisher open source phishing campaign toolkit.","fork":false,"url":"https://api.github.com/repos/securestate/king-phisher-plugins","forks_url":"https://api.github.com/repos/securestate/king-phisher-plugins/forks","keys_url":"https://api.github.com/repos/securestate/king-phisher-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/securestate/king-phisher-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/securestate/king-phisher-plugins/teams","hooks_url":"https://api.github.com/repos/securestate/king-phisher-plugins/hooks","issue_events_url":"https://api.github.com/repos/securestate/king-phisher-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/securestate/king-phisher-plugins/events","assignees_url":"https://api.github.com/repos/securestate/king-phisher-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/securestate/king-phisher-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/securestate/king-phisher-plugins/tags","blobs_url":"https://api.github.com/repos/securestate/king-phisher-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/securestate/king-phisher-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/securestate/king-phisher-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/securestate/king-phisher-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/securestate/king-phisher-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/securestate/king-phisher-plugins/languages","stargazers_url":"https://api.github.com/repos/securestate/king-phisher-plugins/stargazers","contributors_url":"https://api.github.com/repos/securestate/king-phisher-plugins/contributors","subscribers_url":"https://api.github.com/repos/securestate/king-phisher-plugins/subscribers","subscription_url":"https://api.github.com/repos/securestate/king-phisher-plugins/subscription","commits_url":"https://api.github.com/repos/securestate/king-phisher-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/securestate/king-phisher-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/securestate/king-phisher-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/securestate/king-phisher-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/securestate/king-phisher-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/securestate/king-phisher-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/securestate/king-phisher-plugins/merges","archive_url":"https://api.github.com/repos/securestate/king-phisher-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/securestate/king-phisher-plugins/downloads","issues_url":"https://api.github.com/repos/securestate/king-phisher-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/securestate/king-phisher-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/securestate/king-phisher-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/securestate/king-phisher-plugins/labels{/name}","releases_url":"https://api.github.com/repos/securestate/king-phisher-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/securestate/king-phisher-plugins/deployments","created_at":"2016-05-01T02:59:12Z","updated_at":"2016-08-19T02:07:05Z","pushed_at":"2016-08-17T21:02:41Z","git_url":"git://github.com/securestate/king-phisher-plugins.git","ssh_url":"git@github.com:securestate/king-phisher-plugins.git","clone_url":"https://github.com/securestate/king-phisher-plugins.git","svn_url":"https://github.com/securestate/king-phisher-plugins","homepage":null,"size":105,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"securestate:master","ref":"master","sha":"7305fc2032575d02f15265dda58157650b6d554f","user":{"login":"securestate","id":3228981,"avatar_url":"https://avatars.githubusercontent.com/u/3228981?v=3","gravatar_id":"","url":"https://api.github.com/users/securestate","html_url":"https://github.com/securestate","followers_url":"https://api.github.com/users/securestate/followers","following_url":"https://api.github.com/users/securestate/following{/other_user}","gists_url":"https://api.github.com/users/securestate/gists{/gist_id}","starred_url":"https://api.github.com/users/securestate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/securestate/subscriptions","organizations_url":"https://api.github.com/users/securestate/orgs","repos_url":"https://api.github.com/users/securestate/repos","events_url":"https://api.github.com/users/securestate/events{/privacy}","received_events_url":"https://api.github.com/users/securestate/received_events","type":"Organization","site_admin":false},"repo":{"id":57471284,"name":"king-phisher-plugins","full_name":"securestate/king-phisher-plugins","owner":{"login":"securestate","id":3228981,"avatar_url":"https://avatars.githubusercontent.com/u/3228981?v=3","gravatar_id":"","url":"https://api.github.com/users/securestate","html_url":"https://github.com/securestate","followers_url":"https://api.github.com/users/securestate/followers","following_url":"https://api.github.com/users/securestate/following{/other_user}","gists_url":"https://api.github.com/users/securestate/gists{/gist_id}","starred_url":"https://api.github.com/users/securestate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/securestate/subscriptions","organizations_url":"https://api.github.com/users/securestate/orgs","repos_url":"https://api.github.com/users/securestate/repos","events_url":"https://api.github.com/users/securestate/events{/privacy}","received_events_url":"https://api.github.com/users/securestate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/securestate/king-phisher-plugins","description":"Plugins for the King Phisher open source phishing campaign toolkit.","fork":false,"url":"https://api.github.com/repos/securestate/king-phisher-plugins","forks_url":"https://api.github.com/repos/securestate/king-phisher-plugins/forks","keys_url":"https://api.github.com/repos/securestate/king-phisher-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/securestate/king-phisher-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/securestate/king-phisher-plugins/teams","hooks_url":"https://api.github.com/repos/securestate/king-phisher-plugins/hooks","issue_events_url":"https://api.github.com/repos/securestate/king-phisher-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/securestate/king-phisher-plugins/events","assignees_url":"https://api.github.com/repos/securestate/king-phisher-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/securestate/king-phisher-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/securestate/king-phisher-plugins/tags","blobs_url":"https://api.github.com/repos/securestate/king-phisher-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/securestate/king-phisher-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/securestate/king-phisher-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/securestate/king-phisher-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/securestate/king-phisher-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/securestate/king-phisher-plugins/languages","stargazers_url":"https://api.github.com/repos/securestate/king-phisher-plugins/stargazers","contributors_url":"https://api.github.com/repos/securestate/king-phisher-plugins/contributors","subscribers_url":"https://api.github.com/repos/securestate/king-phisher-plugins/subscribers","subscription_url":"https://api.github.com/repos/securestate/king-phisher-plugins/subscription","commits_url":"https://api.github.com/repos/securestate/king-phisher-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/securestate/king-phisher-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/securestate/king-phisher-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/securestate/king-phisher-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/securestate/king-phisher-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/securestate/king-phisher-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/securestate/king-phisher-plugins/merges","archive_url":"https://api.github.com/repos/securestate/king-phisher-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/securestate/king-phisher-plugins/downloads","issues_url":"https://api.github.com/repos/securestate/king-phisher-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/securestate/king-phisher-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/securestate/king-phisher-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/securestate/king-phisher-plugins/labels{/name}","releases_url":"https://api.github.com/repos/securestate/king-phisher-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/securestate/king-phisher-plugins/deployments","created_at":"2016-05-01T02:59:12Z","updated_at":"2016-08-19T02:07:05Z","pushed_at":"2016-08-17T21:02:41Z","git_url":"git://github.com/securestate/king-phisher-plugins.git","ssh_url":"git@github.com:securestate/king-phisher-plugins.git","clone_url":"https://github.com/securestate/king-phisher-plugins.git","svn_url":"https://github.com/securestate/king-phisher-plugins","homepage":null,"size":105,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/5"},"html":{"href":"https://github.com/securestate/king-phisher-plugins/pull/5"},"issue":{"href":"https://api.github.com/repos/securestate/king-phisher-plugins/issues/5"},"comments":{"href":"https://api.github.com/repos/securestate/king-phisher-plugins/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/securestate/king-phisher-plugins/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/securestate/king-phisher-plugins/statuses/563009abe75dd4af452ec25b1f3e09951d5321c3"}}}}
{"actor":{"display_login":"zeroSteiner"}}