{"action":"created","issue":{"url":"https://api.github.com/repos/desihub/desisim/issues/191","repository_url":"https://api.github.com/repos/desihub/desisim","labels_url":"https://api.github.com/repos/desihub/desisim/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/desihub/desisim/issues/191/comments","events_url":"https://api.github.com/repos/desihub/desisim/issues/191/events","html_url":"https://github.com/desihub/desisim/pull/191","id":191039874,"number":191,"title":"Model quickcat for ELGs","user":{"login":"cballand","id":15869020,"avatar_url":"https://avatars.githubusercontent.com/u/15869020?v=3","gravatar_id":"","url":"https://api.github.com/users/cballand","html_url":"https://github.com/cballand","followers_url":"https://api.github.com/users/cballand/followers","following_url":"https://api.github.com/users/cballand/following{/other_user}","gists_url":"https://api.github.com/users/cballand/gists{/gist_id}","starred_url":"https://api.github.com/users/cballand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cballand/subscriptions","organizations_url":"https://api.github.com/users/cballand/orgs","repos_url":"https://api.github.com/users/cballand/repos","events_url":"https://api.github.com/users/cballand/events{/privacy}","received_events_url":"https://api.github.com/users/cballand/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-22T15:35:13Z","updated_at":"2016-12-01T09:31:05Z","closed_at":"2016-12-01T03:50:26Z","pull_request":{"url":"https://api.github.com/repos/desihub/desisim/pulls/191","html_url":"https://github.com/desihub/desisim/pull/191","diff_url":"https://github.com/desihub/desisim/pull/191.diff","patch_url":"https://github.com/desihub/desisim/pull/191.patch"},"body":"This is a first implementation of the efficiency and error models for ELGs in quickcat.\r\nI have tested get_redshift_efficiency() and get_observed_redshifts() using the 5000 ELG training sample of zdc1 as an input, from which I created a flux dict containing OII fluxes. I turned obsconditions off in get_redshift_efficiency to test the efficiency from fluxes only. I have not tested the full quickcat yet.\r\n\r\n "},"comment":{"url":"https://api.github.com/repos/desihub/desisim/issues/comments/264123810","html_url":"https://github.com/desihub/desisim/pull/191#issuecomment-264123810","issue_url":"https://api.github.com/repos/desihub/desisim/issues/191","id":264123810,"user":{"login":"cballand","id":15869020,"avatar_url":"https://avatars.githubusercontent.com/u/15869020?v=3","gravatar_id":"","url":"https://api.github.com/users/cballand","html_url":"https://github.com/cballand","followers_url":"https://api.github.com/users/cballand/followers","following_url":"https://api.github.com/users/cballand/following{/other_user}","gists_url":"https://api.github.com/users/cballand/gists{/gist_id}","starred_url":"https://api.github.com/users/cballand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cballand/subscriptions","organizations_url":"https://api.github.com/users/cballand/orgs","repos_url":"https://api.github.com/users/cballand/repos","events_url":"https://api.github.com/users/cballand/events{/privacy}","received_events_url":"https://api.github.com/users/cballand/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T09:31:05Z","updated_at":"2016-12-01T09:31:05Z","body":"Thanks for putting this together. This is fine, although it sounds more physical to directly alter the OII flux threshold rather than the efficiency _a posteriori_ as the OII flux threshold is equivalent to a signal-to-noise ratio that should be directly impacted by obs conditions. Moreover, multiplying the overall efficiency by a correction factor that may exceed one can potentially leads to efficiencies greater than one. Let's talk on how to improve the model at OSU next week. "}}
{"actor":{"display_login":"cballand"}}