{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/24214","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/24214/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/24214/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/24214/events","html_url":"https://github.com/owncloud/core/pull/24214","id":150456314,"number":24214,"title":"on clone Connection, do not take over the existing LDAP resource","user":{"login":"blizzz","id":2184312,"avatar_url":"https://avatars.githubusercontent.com/u/2184312?v=3","gravatar_id":"","url":"https://api.github.com/users/blizzz","html_url":"https://github.com/blizzz","followers_url":"https://api.github.com/users/blizzz/followers","following_url":"https://api.github.com/users/blizzz/following{/other_user}","gists_url":"https://api.github.com/users/blizzz/gists{/gist_id}","starred_url":"https://api.github.com/users/blizzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blizzz/subscriptions","organizations_url":"https://api.github.com/users/blizzz/orgs","repos_url":"https://api.github.com/users/blizzz/repos","events_url":"https://api.github.com/users/blizzz/events{/privacy}","received_events_url":"https://api.github.com/users/blizzz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/app:user_ldap","name":"app:user_ldap","color":"02d7e1"},{"url":"https://api.github.com/repos/owncloud/core/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/62","html_url":"https://github.com/owncloud/core/milestones/9.1-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/62/labels","id":1322460,"number":62,"title":"9.1-current","description":"","creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":732,"closed_issues":557,"state":"open","created_at":"2015-09-24T16:30:14Z","updated_at":"2016-04-22T19:49:52Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-04-22T19:49:52Z","updated_at":"2016-04-23T14:03:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/24214","html_url":"https://github.com/owncloud/core/pull/24214","diff_url":"https://github.com/owncloud/core/pull/24214.diff","patch_url":"https://github.com/owncloud/core/pull/24214.patch"},"body":"For one, it solves potential conflicts when using the resource. For the\r\nother, one on the login check (the only place where a clone happens\r\ncurrently) we do not need to rebind after confirming the user's login\r\nwas successful.\r\n\r\nFixes https://github.com/owncloud/android/issues/1527\r\n\r\nAlso might fix other issues with strange behaviour, when LDAP actions are performed after authentication took place. \r\n\r\nThe issue was introduced with https://github.com/owncloud/core/pull/22102\r\n\r\n@MarcoO74 can you confirm this solves your issue as well?\r\n\r\n@owncloud/ldap @MorrisJobke please review \r\n\r\n@GitHubUser4234 also interesting for you: once this is approved and merged, you could also clone the Connection here https://github.com/owncloud/core/pull/23992/files#diff-a13c5e86ca62f41df254847023a9de3eR53 and don't need to have the deepCopy().\r\n\r\n@karlitschek would require a backport down to 8.2, ok?"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/213744787","html_url":"https://github.com/owncloud/core/pull/24214#issuecomment-213744787","issue_url":"https://api.github.com/repos/owncloud/core/issues/24214","id":213744787,"user":{"login":"karlitschek","id":867445,"avatar_url":"https://avatars.githubusercontent.com/u/867445?v=3","gravatar_id":"","url":"https://api.github.com/users/karlitschek","html_url":"https://github.com/karlitschek","followers_url":"https://api.github.com/users/karlitschek/followers","following_url":"https://api.github.com/users/karlitschek/following{/other_user}","gists_url":"https://api.github.com/users/karlitschek/gists{/gist_id}","starred_url":"https://api.github.com/users/karlitschek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlitschek/subscriptions","organizations_url":"https://api.github.com/users/karlitschek/orgs","repos_url":"https://api.github.com/users/karlitschek/repos","events_url":"https://api.github.com/users/karlitschek/events{/privacy}","received_events_url":"https://api.github.com/users/karlitschek/received_events","type":"User","site_admin":false},"created_at":"2016-04-23T14:03:43Z","updated_at":"2016-04-23T14:03:43Z","body":" nice fix. please backport 👍 "}}