{"action":"created","issue":{"url":"https://api.github.com/repos/xesscorp/KiCost/issues/28","labels_url":"https://api.github.com/repos/xesscorp/KiCost/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/xesscorp/KiCost/issues/28/comments","events_url":"https://api.github.com/repos/xesscorp/KiCost/issues/28/events","html_url":"https://github.com/xesscorp/KiCost/pull/28","id":127131133,"number":28,"title":"Add new command line argument --private","user":{"login":"timoalho","id":6169856,"avatar_url":"https://avatars.githubusercontent.com/u/6169856?v=3","gravatar_id":"","url":"https://api.github.com/users/timoalho","html_url":"https://github.com/timoalho","followers_url":"https://api.github.com/users/timoalho/followers","following_url":"https://api.github.com/users/timoalho/following{/other_user}","gists_url":"https://api.github.com/users/timoalho/gists{/gist_id}","starred_url":"https://api.github.com/users/timoalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timoalho/subscriptions","organizations_url":"https://api.github.com/users/timoalho/orgs","repos_url":"https://api.github.com/users/timoalho/repos","events_url":"https://api.github.com/users/timoalho/events{/privacy}","received_events_url":"https://api.github.com/users/timoalho/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-17T23:06:16Z","updated_at":"2016-01-28T10:20:25Z","closed_at":"2016-01-27T05:27:51Z","pull_request":{"url":"https://api.github.com/repos/xesscorp/KiCost/pulls/28","html_url":"https://github.com/xesscorp/KiCost/pull/28","diff_url":"https://github.com/xesscorp/KiCost/pull/28.diff","patch_url":"https://github.com/xesscorp/KiCost/pull/28.patch"},"body":"Sometimes there are fields related to components which do not ruin one component being equivalent to another. A comment field detailing layout suggestions etc for a specific instance would be one example, or fields leftover from previous attempts at BOM management, which still contain useful data (my personal need) another. However, having such fields makes kicost's component grouping next to useless.\r\n\r\nSolution: add new command line argument. The argument -p or --private allows defining fields as private in the sense that they do not affect the grouping of components, even if they differ between component instances.\r\n\r\nThe argument name may not be optimal, but the abbreviation -i for --ignore would have clashed with --input\r\n\r\nN.B. I'm breaking the suggested guidelines for pull requests with regards to unit tests, since I don't see any tests implemented in the current main branch anyway. Sorry for validating the broken windows theory :) I've tested the addition in Python 3.4 on OS X, and also that it doesn't break existing functionality.\r\n\r\nI'll be happy to add explanation on the feature to the documentation, if the request gets approved."},"comment":{"url":"https://api.github.com/repos/xesscorp/KiCost/issues/comments/176107823","html_url":"https://github.com/xesscorp/KiCost/pull/28#issuecomment-176107823","issue_url":"https://api.github.com/repos/xesscorp/KiCost/issues/28","id":176107823,"user":{"login":"timoalho","id":6169856,"avatar_url":"https://avatars.githubusercontent.com/u/6169856?v=3","gravatar_id":"","url":"https://api.github.com/users/timoalho","html_url":"https://github.com/timoalho","followers_url":"https://api.github.com/users/timoalho/followers","following_url":"https://api.github.com/users/timoalho/following{/other_user}","gists_url":"https://api.github.com/users/timoalho/gists{/gist_id}","starred_url":"https://api.github.com/users/timoalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timoalho/subscriptions","organizations_url":"https://api.github.com/users/timoalho/orgs","repos_url":"https://api.github.com/users/timoalho/repos","events_url":"https://api.github.com/users/timoalho/events{/privacy}","received_events_url":"https://api.github.com/users/timoalho/received_events","type":"User","site_admin":false},"created_at":"2016-01-28T10:20:25Z","updated_at":"2016-01-28T10:20:25Z","body":"Cool, happy to help! Thanks for making this great tool!"}}