{"action":"created","issue":{"url":"https://api.github.com/repos/xeodou/react-range-slider/issues/16","repository_url":"https://api.github.com/repos/xeodou/react-range-slider","labels_url":"https://api.github.com/repos/xeodou/react-range-slider/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/xeodou/react-range-slider/issues/16/comments","events_url":"https://api.github.com/repos/xeodou/react-range-slider/issues/16/events","html_url":"https://github.com/xeodou/react-range-slider/pull/16","id":138751960,"number":16,"title":"Fix touch issues on non-touchscreen in chrome (fixes #15)","user":{"login":"philippotto","id":2486553,"avatar_url":"https://avatars.githubusercontent.com/u/2486553?v=3","gravatar_id":"","url":"https://api.github.com/users/philippotto","html_url":"https://github.com/philippotto","followers_url":"https://api.github.com/users/philippotto/followers","following_url":"https://api.github.com/users/philippotto/following{/other_user}","gists_url":"https://api.github.com/users/philippotto/gists{/gist_id}","starred_url":"https://api.github.com/users/philippotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippotto/subscriptions","organizations_url":"https://api.github.com/users/philippotto/orgs","repos_url":"https://api.github.com/users/philippotto/repos","events_url":"https://api.github.com/users/philippotto/events{/privacy}","received_events_url":"https://api.github.com/users/philippotto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-06T03:53:12Z","updated_at":"2016-03-07T03:08:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xeodou/react-range-slider/pulls/16","html_url":"https://github.com/xeodou/react-range-slider/pull/16","diff_url":"https://github.com/xeodou/react-range-slider/pull/16.diff","patch_url":"https://github.com/xeodou/react-range-slider/pull/16.patch"},"body":"This PR changes the way mouse/touch handlers are used. Basically, it takes care of handling all possible events without determining whether it runs on a touch screen at initialization time.\r\nThis fixes #15 (which is caused by `\"ontouchstart\" in window` being unreliable in Chrome) and has the added benefit that the slider will always work, when the user switches from touch to non-touch (and vice versa) while using the current website (e.g. for convertible or hybrid computers).\r\n\r\nThis is also considered as best practice (see http://www.html5rocks.com/en/mobile/touchandmouse/).\r\n\r\nI tested the code on Chrome 49, Firefox 40 and IE 11.\r\n\r\nThe code in this PR might be not the tidiest, but I'm open to suggestions :)"},"comment":{"url":"https://api.github.com/repos/xeodou/react-range-slider/issues/comments/193071459","html_url":"https://github.com/xeodou/react-range-slider/pull/16#issuecomment-193071459","issue_url":"https://api.github.com/repos/xeodou/react-range-slider/issues/16","id":193071459,"user":{"login":"xeodou","id":914595,"avatar_url":"https://avatars.githubusercontent.com/u/914595?v=3","gravatar_id":"","url":"https://api.github.com/users/xeodou","html_url":"https://github.com/xeodou","followers_url":"https://api.github.com/users/xeodou/followers","following_url":"https://api.github.com/users/xeodou/following{/other_user}","gists_url":"https://api.github.com/users/xeodou/gists{/gist_id}","starred_url":"https://api.github.com/users/xeodou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeodou/subscriptions","organizations_url":"https://api.github.com/users/xeodou/orgs","repos_url":"https://api.github.com/users/xeodou/repos","events_url":"https://api.github.com/users/xeodou/events{/privacy}","received_events_url":"https://api.github.com/users/xeodou/received_events","type":"User","site_admin":false},"created_at":"2016-03-07T03:08:56Z","updated_at":"2016-03-07T03:08:56Z","body":"@philippotto Thanks."}}