{"action":"created","comment":{"url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/comments/82085042","pull_request_review_id":3011634,"id":82085042,"diff_hunk":"@@ -346,7 +414,14 @@ private String sanitizeTableName(String tableName) {\n    *         name if sanitization is enabled.\n    */\n   public String getTableFromTopic(String topic) {\n-    return getBoolean(SANITIZE_TOPICS_CONFIG) ? sanitizeTableName(topic) : topic;\n+    String tableName = null;\n+    Map<String, String> map = getTopicsToTables();","path":"kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/config/BigQuerySinkConfig.java","position":115,"original_position":115,"commit_id":"58c389f778531baee7387616330ebd10debec76e","original_commit_id":"58c389f778531baee7387616330ebd10debec76e","user":{"login":"criccomini","id":167569,"avatar_url":"https://avatars.githubusercontent.com/u/167569?v=3","gravatar_id":"","url":"https://api.github.com/users/criccomini","html_url":"https://github.com/criccomini","followers_url":"https://api.github.com/users/criccomini/followers","following_url":"https://api.github.com/users/criccomini/following{/other_user}","gists_url":"https://api.github.com/users/criccomini/gists{/gist_id}","starred_url":"https://api.github.com/users/criccomini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criccomini/subscriptions","organizations_url":"https://api.github.com/users/criccomini/orgs","repos_url":"https://api.github.com/users/criccomini/repos","events_url":"https://api.github.com/users/criccomini/events{/privacy}","received_events_url":"https://api.github.com/users/criccomini/received_events","type":"User","site_admin":false},"body":"Nit: `map` isn't a great variable name. how about `topicsToTablesMap` or some equivalent?","created_at":"2016-10-05T22:29:55Z","updated_at":"2016-10-05T22:47:00Z","html_url":"https://github.com/wepay/kafka-connect-bigquery/pull/44#discussion_r82085042","pull_request_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/comments/82085042"},"html":{"href":"https://github.com/wepay/kafka-connect-bigquery/pull/44#discussion_r82085042"},"pull_request":{"href":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/44","id":87786215,"html_url":"https://github.com/wepay/kafka-connect-bigquery/pull/44","diff_url":"https://github.com/wepay/kafka-connect-bigquery/pull/44.diff","patch_url":"https://github.com/wepay/kafka-connect-bigquery/pull/44.patch","issue_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/44","number":44,"state":"open","locked":false,"title":"Add config mapping for topic to table names","user":{"login":"willyhoang","id":2477167,"avatar_url":"https://avatars.githubusercontent.com/u/2477167?v=3","gravatar_id":"","url":"https://api.github.com/users/willyhoang","html_url":"https://github.com/willyhoang","followers_url":"https://api.github.com/users/willyhoang/followers","following_url":"https://api.github.com/users/willyhoang/following{/other_user}","gists_url":"https://api.github.com/users/willyhoang/gists{/gist_id}","starred_url":"https://api.github.com/users/willyhoang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willyhoang/subscriptions","organizations_url":"https://api.github.com/users/willyhoang/orgs","repos_url":"https://api.github.com/users/willyhoang/repos","events_url":"https://api.github.com/users/willyhoang/events{/privacy}","received_events_url":"https://api.github.com/users/willyhoang/received_events","type":"User","site_admin":false},"body":"In cases where we do not want our table names to directly match our\r\ntopic names, a configuration should be available to rename the topics.","created_at":"2016-10-03T20:33:03Z","updated_at":"2016-10-05T22:47:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e8718cb385573c7b4f1b96cdfaf13fbb9a436e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/44/commits","review_comments_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/44/comments","review_comment_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/44/comments","statuses_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/statuses/58c389f778531baee7387616330ebd10debec76e","head":{"label":"blueapron:topics-to-tables-config","ref":"topics-to-tables-config","sha":"58c389f778531baee7387616330ebd10debec76e","user":{"login":"blueapron","id":1420060,"avatar_url":"https://avatars.githubusercontent.com/u/1420060?v=3","gravatar_id":"","url":"https://api.github.com/users/blueapron","html_url":"https://github.com/blueapron","followers_url":"https://api.github.com/users/blueapron/followers","following_url":"https://api.github.com/users/blueapron/following{/other_user}","gists_url":"https://api.github.com/users/blueapron/gists{/gist_id}","starred_url":"https://api.github.com/users/blueapron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueapron/subscriptions","organizations_url":"https://api.github.com/users/blueapron/orgs","repos_url":"https://api.github.com/users/blueapron/repos","events_url":"https://api.github.com/users/blueapron/events{/privacy}","received_events_url":"https://api.github.com/users/blueapron/received_events","type":"Organization","site_admin":false},"repo":{"id":69899995,"name":"kafka-connect-bigquery-1","full_name":"blueapron/kafka-connect-bigquery-1","owner":{"login":"blueapron","id":1420060,"avatar_url":"https://avatars.githubusercontent.com/u/1420060?v=3","gravatar_id":"","url":"https://api.github.com/users/blueapron","html_url":"https://github.com/blueapron","followers_url":"https://api.github.com/users/blueapron/followers","following_url":"https://api.github.com/users/blueapron/following{/other_user}","gists_url":"https://api.github.com/users/blueapron/gists{/gist_id}","starred_url":"https://api.github.com/users/blueapron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueapron/subscriptions","organizations_url":"https://api.github.com/users/blueapron/orgs","repos_url":"https://api.github.com/users/blueapron/repos","events_url":"https://api.github.com/users/blueapron/events{/privacy}","received_events_url":"https://api.github.com/users/blueapron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blueapron/kafka-connect-bigquery-1","description":"A Kafka Connect BigQuery sink connector","fork":true,"url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1","forks_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/forks","keys_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/teams","hooks_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/hooks","issue_events_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/issues/events{/number}","events_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/events","assignees_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/assignees{/user}","branches_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/branches{/branch}","tags_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/tags","blobs_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/statuses/{sha}","languages_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/languages","stargazers_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/stargazers","contributors_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/contributors","subscribers_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/subscribers","subscription_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/subscription","commits_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/contents/{+path}","compare_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/merges","archive_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/downloads","issues_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/issues{/number}","pulls_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/pulls{/number}","milestones_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/milestones{/number}","notifications_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/labels{/name}","releases_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/releases{/id}","deployments_url":"https://api.github.com/repos/blueapron/kafka-connect-bigquery-1/deployments","created_at":"2016-10-03T18:45:11Z","updated_at":"2016-10-03T18:45:12Z","pushed_at":"2016-10-05T21:24:10Z","git_url":"git://github.com/blueapron/kafka-connect-bigquery-1.git","ssh_url":"git@github.com:blueapron/kafka-connect-bigquery-1.git","clone_url":"https://github.com/blueapron/kafka-connect-bigquery-1.git","svn_url":"https://github.com/blueapron/kafka-connect-bigquery-1","homepage":null,"size":203,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"blueapron"}},"base":{"label":"wepay:master","ref":"master","sha":"e5219d4d215bdd6f094b49bbb4534f96e7fe725b","user":{"login":"wepay","id":769024,"avatar_url":"https://avatars.githubusercontent.com/u/769024?v=3","gravatar_id":"","url":"https://api.github.com/users/wepay","html_url":"https://github.com/wepay","followers_url":"https://api.github.com/users/wepay/followers","following_url":"https://api.github.com/users/wepay/following{/other_user}","gists_url":"https://api.github.com/users/wepay/gists{/gist_id}","starred_url":"https://api.github.com/users/wepay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wepay/subscriptions","organizations_url":"https://api.github.com/users/wepay/orgs","repos_url":"https://api.github.com/users/wepay/repos","events_url":"https://api.github.com/users/wepay/events{/privacy}","received_events_url":"https://api.github.com/users/wepay/received_events","type":"Organization","site_admin":false},"repo":{"id":65751573,"name":"kafka-connect-bigquery","full_name":"wepay/kafka-connect-bigquery","owner":{"login":"wepay","id":769024,"avatar_url":"https://avatars.githubusercontent.com/u/769024?v=3","gravatar_id":"","url":"https://api.github.com/users/wepay","html_url":"https://github.com/wepay","followers_url":"https://api.github.com/users/wepay/followers","following_url":"https://api.github.com/users/wepay/following{/other_user}","gists_url":"https://api.github.com/users/wepay/gists{/gist_id}","starred_url":"https://api.github.com/users/wepay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wepay/subscriptions","organizations_url":"https://api.github.com/users/wepay/orgs","repos_url":"https://api.github.com/users/wepay/repos","events_url":"https://api.github.com/users/wepay/events{/privacy}","received_events_url":"https://api.github.com/users/wepay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wepay/kafka-connect-bigquery","description":"A Kafka Connect BigQuery sink connector","fork":false,"url":"https://api.github.com/repos/wepay/kafka-connect-bigquery","forks_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/forks","keys_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/teams","hooks_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/hooks","issue_events_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/events{/number}","events_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/events","assignees_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/assignees{/user}","branches_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/branches{/branch}","tags_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/tags","blobs_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/statuses/{sha}","languages_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/languages","stargazers_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/stargazers","contributors_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/contributors","subscribers_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/subscribers","subscription_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/subscription","commits_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/contents/{+path}","compare_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/merges","archive_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/downloads","issues_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues{/number}","pulls_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls{/number}","milestones_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/milestones{/number}","notifications_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/labels{/name}","releases_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/releases{/id}","deployments_url":"https://api.github.com/repos/wepay/kafka-connect-bigquery/deployments","created_at":"2016-08-15T17:34:48Z","updated_at":"2016-10-02T10:10:34Z","pushed_at":"2016-10-05T22:44:58Z","git_url":"git://github.com/wepay/kafka-connect-bigquery.git","ssh_url":"git@github.com:wepay/kafka-connect-bigquery.git","clone_url":"https://github.com/wepay/kafka-connect-bigquery.git","svn_url":"https://github.com/wepay/kafka-connect-bigquery","homepage":null,"size":323,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":10,"forks":4,"open_issues":10,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/44"},"html":{"href":"https://github.com/wepay/kafka-connect-bigquery/pull/44"},"issue":{"href":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/44"},"comments":{"href":"https://api.github.com/repos/wepay/kafka-connect-bigquery/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wepay/kafka-connect-bigquery/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/wepay/kafka-connect-bigquery/statuses/58c389f778531baee7387616330ebd10debec76e"}}}}
{"actor":{"display_login":"criccomini"}}