{"action":"created","issue":{"url":"https://api.github.com/repos/atom/spell-check/issues/120","repository_url":"https://api.github.com/repos/atom/spell-check","labels_url":"https://api.github.com/repos/atom/spell-check/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/atom/spell-check/issues/120/comments","events_url":"https://api.github.com/repos/atom/spell-check/issues/120/events","html_url":"https://github.com/atom/spell-check/pull/120","id":140407101,"number":120,"title":"Changed spell-checking to be plugin-based.","user":{"login":"dmoonfire","id":206815,"avatar_url":"https://avatars.githubusercontent.com/u/206815?v=3","gravatar_id":"","url":"https://api.github.com/users/dmoonfire","html_url":"https://github.com/dmoonfire","followers_url":"https://api.github.com/users/dmoonfire/followers","following_url":"https://api.github.com/users/dmoonfire/following{/other_user}","gists_url":"https://api.github.com/users/dmoonfire/gists{/gist_id}","starred_url":"https://api.github.com/users/dmoonfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmoonfire/subscriptions","organizations_url":"https://api.github.com/users/dmoonfire/orgs","repos_url":"https://api.github.com/users/dmoonfire/repos","events_url":"https://api.github.com/users/dmoonfire/events{/privacy}","received_events_url":"https://api.github.com/users/dmoonfire/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/atom/spell-check/labels/atom","name":"atom","color":"c7def8"},{"url":"https://api.github.com/repos/atom/spell-check/labels/requires-changes","name":"requires-changes","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2016-03-12T18:56:03Z","updated_at":"2016-08-12T13:41:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/atom/spell-check/pulls/120","html_url":"https://github.com/atom/spell-check/pull/120","diff_url":"https://github.com/atom/spell-check/pull/120.diff","patch_url":"https://github.com/atom/spell-check/pull/120.patch"},"body":"* Changed the package to allow for external packages to provide additional checking. (Closes #74)\r\n      - Disabled the task-based handling because of passing plugins.\r\n      - Two default plugins are included: system-based dictionaries and \"known words\".\r\n      - Suggestions and \"add to dictionary\" are also provided via interfaces. (Closes #10)\r\n      - Modified various calls so they are aware of the where the buffer is located.\r\n    * Modified system to allow for multiple plugins/checkers to identify correctness.\r\n      - Incorrect words must be incorrect for all checkers.\r\n      - Any checker that treats a word as valid is considered valid for the buffer.\r\n    * Extracted system-based dictionary support into separate checker.\r\n      - System dictionaries can now check across multiple system locales.\r\n      - Locale selection can be changed via package settings. (Closes #21)\r\n      - Multiple locales can be selected. (Closes #11)\r\n      - External search paths can be used for Linux and OS X.\r\n      - Default language is based on the process environment, with a fallback to the browser, before finally using `en-US` as a fallback.\r\n    * Extracted hard-coded approved list into a separate checker.\r\n      - User can add additional \"known words\" via settings.\r\n      - Added an option to add more known words via the suggestion dialog.\r\n    * Updated ignore files and added EditorConfig settings for development.\r\n    * Various coffee-centric formatting."},"comment":{"url":"https://api.github.com/repos/atom/spell-check/issues/comments/239449034","html_url":"https://github.com/atom/spell-check/pull/120#issuecomment-239449034","issue_url":"https://api.github.com/repos/atom/spell-check/issues/120","id":239449034,"user":{"login":"as-cii","id":482957,"avatar_url":"https://avatars.githubusercontent.com/u/482957?v=3","gravatar_id":"","url":"https://api.github.com/users/as-cii","html_url":"https://github.com/as-cii","followers_url":"https://api.github.com/users/as-cii/followers","following_url":"https://api.github.com/users/as-cii/following{/other_user}","gists_url":"https://api.github.com/users/as-cii/gists{/gist_id}","starred_url":"https://api.github.com/users/as-cii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-cii/subscriptions","organizations_url":"https://api.github.com/users/as-cii/orgs","repos_url":"https://api.github.com/users/as-cii/repos","events_url":"https://api.github.com/users/as-cii/events{/privacy}","received_events_url":"https://api.github.com/users/as-cii/received_events","type":"User","site_admin":true},"created_at":"2016-08-12T13:41:15Z","updated_at":"2016-08-12T13:41:15Z","body":"Hey @dmoonfire, so after looking at the code a second time I think we might merge this. It's a pretty big pull-request and, as with all redesigns, I am somewhat concerned we might introduce some regression. The work you've done is pretty solid, though, so we might let this bake for a while on master and see if we're introducing any issue. \r\n\r\nWith the bundled spell-checker it works great on my machine. ✨ Is there any package that provides spell-check that I might use to test this out locally? \r\n\r\nIn the meantime could you also update this pull-request's description to match what we're currently doing in code? (i.e. the description says we're not using a `Task`, but I think we are).\r\n\r\nApologies for making you wait so long and thanks for the great work on this, looking forward to 🚢ping it!\r\n\r\n"}}
{"actor":{"display_login":"as-cii"}}