{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75610634","id":75610634,"diff_hunk":"@@ -98,24 +105,24 @@ func NewStaticKubeletClient(config *KubeletClientConfig) (KubeletClient, error)\n }\n \n // In default HTTPKubeletClient ctx is unused.\n-func (c *HTTPKubeletClient) GetConnectionInfo(ctx api.Context, nodeName string) (string, uint, http.RoundTripper, error) {\n+func (c *HTTPKubeletClient) GetConnectionInfo(ctx api.Context, nodeName string) (*ConnectionInfo, error) {\n \tif errs := validation.ValidateNodeName(nodeName, false); len(errs) != 0 {\n-\t\treturn \"\", 0, nil, fmt.Errorf(\"invalid node name: %s\", strings.Join(errs, \";\"))\n+\t\treturn nil, fmt.Errorf(\"invalid node name: %s\", strings.Join(errs, \";\"))\n \t}\n \tscheme := \"http\"\n \tif c.Config.EnableHttps {\n \t\tscheme = \"https\"\n \t}\n-\treturn scheme, c.Config.Port, c.Client.Transport, nil\n+\treturn &ConnectionInfo{scheme, nodeName, c.Config.Port, c.Client.Transport}, nil","path":"pkg/kubelet/client/kubelet_client.go","position":32,"original_position":32,"commit_id":"ffafc0fcca5ec96c6d0d36d8f1442020facd5d78","original_commit_id":"ffafc0fcca5ec96c6d0d36d8f1442020facd5d78","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"use field names in initialization (e.g. `&ConnectionInfo{Scheme:scheme, Hostname: nodeName, ...}`","created_at":"2016-08-22T02:10:10Z","updated_at":"2016-08-22T02:10:10Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25532#discussion_r75610634","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25532","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75610634"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25532#discussion_r75610634"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25532"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25532","id":69831605,"html_url":"https://github.com/kubernetes/kubernetes/pull/25532","diff_url":"https://github.com/kubernetes/kubernetes/pull/25532.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25532.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25532","number":25532,"state":"open","locked":false,"title":"Populate Node.Status.Addresses with Hostname, use it for apiserver to kubelet comm.","user":{"login":"mkulke","id":273280,"avatar_url":"https://avatars.githubusercontent.com/u/273280?v=3","gravatar_id":"","url":"https://api.github.com/users/mkulke","html_url":"https://github.com/mkulke","followers_url":"https://api.github.com/users/mkulke/followers","following_url":"https://api.github.com/users/mkulke/following{/other_user}","gists_url":"https://api.github.com/users/mkulke/gists{/gist_id}","starred_url":"https://api.github.com/users/mkulke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkulke/subscriptions","organizations_url":"https://api.github.com/users/mkulke/orgs","repos_url":"https://api.github.com/users/mkulke/repos","events_url":"https://api.github.com/users/mkulke/events{/privacy}","received_events_url":"https://api.github.com/users/mkulke/received_events","type":"User","site_admin":false},"body":"This PR is supposed to address #22063 \r\n\r\nCurrently `NodeName` has to be a resolvable dns address on the master to allow apiserver -> kubelet communication (exec, log, port-forward operations on a pod). In some situations this is unfortunate (see the discussions on the issue).\r\n\r\nThe PR aims to do the following:\r\n\r\n- Populate the `Type: Hostname` in the `Node.Status.Addresses` array, the type is already defined, but was not used so far.\r\n- Add logic to resolve a Node's Hostname when the apiserver initiates communication with the Kubelet, instead of using the Nodename string as Hostname.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/25532)\n<!-- Reviewable:end -->\n","created_at":"2016-05-12T12:58:19Z","updated_at":"2016-08-22T02:10:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62444c0e27964321e9379a2d205163448ac33394","assignee":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.4","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22/labels","id":1777384,"number":22,"title":"v1.4","description":"https://github.com/kubernetes/features/blob/master/release-1.4/Release-1.4.md","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":199,"closed_issues":314,"state":"open","created_at":"2016-05-19T18:50:19Z","updated_at":"2016-08-22T02:01:33Z","due_on":"2016-09-15T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25532/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25532/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25532/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ffafc0fcca5ec96c6d0d36d8f1442020facd5d78","head":{"label":"mkulke:resolve-nodename-in-kubelet-comm","ref":"resolve-nodename-in-kubelet-comm","sha":"ffafc0fcca5ec96c6d0d36d8f1442020facd5d78","user":{"login":"mkulke","id":273280,"avatar_url":"https://avatars.githubusercontent.com/u/273280?v=3","gravatar_id":"","url":"https://api.github.com/users/mkulke","html_url":"https://github.com/mkulke","followers_url":"https://api.github.com/users/mkulke/followers","following_url":"https://api.github.com/users/mkulke/following{/other_user}","gists_url":"https://api.github.com/users/mkulke/gists{/gist_id}","starred_url":"https://api.github.com/users/mkulke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkulke/subscriptions","organizations_url":"https://api.github.com/users/mkulke/orgs","repos_url":"https://api.github.com/users/mkulke/repos","events_url":"https://api.github.com/users/mkulke/events{/privacy}","received_events_url":"https://api.github.com/users/mkulke/received_events","type":"User","site_admin":false},"repo":{"id":33568881,"name":"kubernetes","full_name":"mkulke/kubernetes","owner":{"login":"mkulke","id":273280,"avatar_url":"https://avatars.githubusercontent.com/u/273280?v=3","gravatar_id":"","url":"https://api.github.com/users/mkulke","html_url":"https://github.com/mkulke","followers_url":"https://api.github.com/users/mkulke/followers","following_url":"https://api.github.com/users/mkulke/following{/other_user}","gists_url":"https://api.github.com/users/mkulke/gists{/gist_id}","starred_url":"https://api.github.com/users/mkulke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkulke/subscriptions","organizations_url":"https://api.github.com/users/mkulke/orgs","repos_url":"https://api.github.com/users/mkulke/repos","events_url":"https://api.github.com/users/mkulke/events{/privacy}","received_events_url":"https://api.github.com/users/mkulke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkulke/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/mkulke/kubernetes","forks_url":"https://api.github.com/repos/mkulke/kubernetes/forks","keys_url":"https://api.github.com/repos/mkulke/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkulke/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkulke/kubernetes/teams","hooks_url":"https://api.github.com/repos/mkulke/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mkulke/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mkulke/kubernetes/events","assignees_url":"https://api.github.com/repos/mkulke/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mkulke/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mkulke/kubernetes/tags","blobs_url":"https://api.github.com/repos/mkulke/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkulke/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkulke/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkulke/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkulke/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mkulke/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mkulke/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mkulke/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mkulke/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mkulke/kubernetes/subscription","commits_url":"https://api.github.com/repos/mkulke/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkulke/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkulke/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkulke/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkulke/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mkulke/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkulke/kubernetes/merges","archive_url":"https://api.github.com/repos/mkulke/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkulke/kubernetes/downloads","issues_url":"https://api.github.com/repos/mkulke/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mkulke/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mkulke/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mkulke/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkulke/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mkulke/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mkulke/kubernetes/deployments","created_at":"2015-04-07T21:19:20Z","updated_at":"2016-02-09T10:43:05Z","pushed_at":"2016-08-18T09:21:43Z","git_url":"git://github.com/mkulke/kubernetes.git","ssh_url":"git@github.com:mkulke/kubernetes.git","clone_url":"https://github.com/mkulke/kubernetes.git","svn_url":"https://github.com/mkulke/kubernetes","homepage":"http://kubernetes.io","size":304929,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"e2f39fca86e0ce002b9fb0c697ad092e515e1103","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-22T01:11:30Z","pushed_at":"2016-08-22T01:45:14Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":533355,"stargazers_count":16241,"watchers_count":16241,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5212,"mirror_url":null,"open_issues_count":4203,"forks":5212,"open_issues":4203,"watchers":16241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25532"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25532"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25532"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25532/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25532/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25532/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ffafc0fcca5ec96c6d0d36d8f1442020facd5d78"}}}}
{"actor":{"display_login":"liggitt"}}