{"action":"created","issue":{"url":"https://api.github.com/repos/halide/Halide/issues/1308","repository_url":"https://api.github.com/repos/halide/Halide","labels_url":"https://api.github.com/repos/halide/Halide/issues/1308/labels{/name}","comments_url":"https://api.github.com/repos/halide/Halide/issues/1308/comments","events_url":"https://api.github.com/repos/halide/Halide/issues/1308/events","html_url":"https://github.com/halide/Halide/pull/1308","id":160690631,"number":1308,"title":"Reduce trace output for Save/Restore OpenGL state.","user":{"login":"ronen","id":125620,"avatar_url":"https://avatars.githubusercontent.com/u/125620?v=3","gravatar_id":"","url":"https://api.github.com/users/ronen","html_url":"https://github.com/ronen","followers_url":"https://api.github.com/users/ronen/followers","following_url":"https://api.github.com/users/ronen/following{/other_user}","gists_url":"https://api.github.com/users/ronen/gists{/gist_id}","starred_url":"https://api.github.com/users/ronen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronen/subscriptions","organizations_url":"https://api.github.com/users/ronen/orgs","repos_url":"https://api.github.com/users/ronen/repos","events_url":"https://api.github.com/users/ronen/events{/privacy}","received_events_url":"https://api.github.com/users/ronen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-16T15:28:52Z","updated_at":"2016-06-16T16:10:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/halide/Halide/pulls/1308","html_url":"https://github.com/halide/Halide/pull/1308","diff_url":"https://github.com/halide/Halide/pull/1308.diff","patch_url":"https://github.com/halide/Halide/pull/1308.patch"},"body":"Previously the trace listed all the values that were being saved and restored, cluttering up (IMHO) the output with info not likely to be useful for understanding/debugging halide pipelines.  E.g.:\r\n\r\n```\r\nSaved OpenGL state:\r\n \tactive texture: 33984\r\n\tprogram: 0\r\n\tviewport: (0, 0, 1340, 1060)\r\n\tcull face: 0\r\n\tdepth test: 0\r\n[…]\r\nRestoring OpenGL state:\r\n \tactive texture: 33984\r\n\tprogram: 0\r\n\tviewport: (0, 0, 1340, 1060)\r\n\tcull face: 0\r\n\tdepth test: 0\r\n```\r\n\r\nThis PR reduces the trace to just\r\n\r\n```\r\nSaved OpenGL state\r\n[…]\r\nRestoring OpenGL state\r\n```"},"comment":{"url":"https://api.github.com/repos/halide/Halide/issues/comments/226534212","html_url":"https://github.com/halide/Halide/pull/1308#issuecomment-226534212","issue_url":"https://api.github.com/repos/halide/Halide/issues/1308","id":226534212,"user":{"login":"abadams","id":515398,"avatar_url":"https://avatars.githubusercontent.com/u/515398?v=3","gravatar_id":"","url":"https://api.github.com/users/abadams","html_url":"https://github.com/abadams","followers_url":"https://api.github.com/users/abadams/followers","following_url":"https://api.github.com/users/abadams/following{/other_user}","gists_url":"https://api.github.com/users/abadams/gists{/gist_id}","starred_url":"https://api.github.com/users/abadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadams/subscriptions","organizations_url":"https://api.github.com/users/abadams/orgs","repos_url":"https://api.github.com/users/abadams/repos","events_url":"https://api.github.com/users/abadams/events{/privacy}","received_events_url":"https://api.github.com/users/abadams/received_events","type":"User","site_admin":false},"created_at":"2016-06-16T16:10:52Z","updated_at":"2016-06-16T16:10:52Z","body":"I will defer to @shoaibkamil on how useful the saved state is"}}
{"actor":{"display_login":"abadams"}}