{"action":"created","comment":{"url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/comments/66118960","id":66118960,"diff_hunk":"@@ -0,0 +1,144 @@\n+package io.appium.java_client.YouiEngine;\n+\n+import io.appium.java_client.AppiumDriver;\n+import io.appium.java_client.YouiEngine.internal.JsonToYouiEngineElementConverter;\n+import org.openqa.selenium.Capabilities;\n+import org.openqa.selenium.WebElement;\n+import org.openqa.selenium.remote.Response;\n+\n+import java.net.URL;\n+\n+\n+public class YouiEngineDriver<T extends WebElement> extends AppiumDriver<T> {\n+\n+/*\n+    The issue here seems to be that the capabilities of Android's native automation framework differs from iOS's\n+    native automation framework. They both expose things differently or some things only on one framework. Previous\n+    implementation would have Network Settings outside of the individual drivers, but this was recently pulled into\n+    the platform specific drivers. Hopefully implementation is transparent... but I'm not holding my breath.\n+ */\n+\n+    public String AppPlatform;\n+\n+    // Platform constants\n+    final public String IOS = \"ios\";\n+    final public String ANDROID = \"android\";\n+\n+    // internal constants\n+    final public String APP_PLATFORM_CAPABILITIES = \"youiAppPlatform\";\n+\n+    // error messaging constants\n+    private String UNSUPPORTED_METHOD_FOR_PLATFORM;\n+    private String UNKNOWN_PLATFORM_SPECIFIED;","path":"src/main/java/io/appium/java_client/YouiEngine/YouiEngineDriver.java","position":32,"original_position":32,"commit_id":"d8dfa824e721a52c733bacb38dcbb3f6aed301b2","original_commit_id":"d8dfa824e721a52c733bacb38dcbb3f6aed301b2","user":{"login":"jplandry","id":5650778,"avatar_url":"https://avatars.githubusercontent.com/u/5650778?v=3","gravatar_id":"","url":"https://api.github.com/users/jplandry","html_url":"https://github.com/jplandry","followers_url":"https://api.github.com/users/jplandry/followers","following_url":"https://api.github.com/users/jplandry/following{/other_user}","gists_url":"https://api.github.com/users/jplandry/gists{/gist_id}","starred_url":"https://api.github.com/users/jplandry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jplandry/subscriptions","organizations_url":"https://api.github.com/users/jplandry/orgs","repos_url":"https://api.github.com/users/jplandry/repos","events_url":"https://api.github.com/users/jplandry/events{/privacy}","received_events_url":"https://api.github.com/users/jplandry/received_events","type":"User","site_admin":false},"body":"In the Google coding standards we can't use all caps for these variables since they aren't static and final.","created_at":"2016-06-07T17:48:08Z","updated_at":"2016-06-07T17:48:08Z","html_url":"https://github.com/YOU-i-Labs/appium-java-client/pull/1#discussion_r66118960","pull_request_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/comments/66118960"},"html":{"href":"https://github.com/YOU-i-Labs/appium-java-client/pull/1#discussion_r66118960"},"pull_request":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/1","id":72549851,"html_url":"https://github.com/YOU-i-Labs/appium-java-client/pull/1","diff_url":"https://github.com/YOU-i-Labs/appium-java-client/pull/1.diff","patch_url":"https://github.com/YOU-i-Labs/appium-java-client/pull/1.patch","issue_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/1","number":1,"state":"open","locked":false,"title":"US-3382 Added three required classes and a rough test class","user":{"login":"pfoster-youitv","id":16088405,"avatar_url":"https://avatars.githubusercontent.com/u/16088405?v=3","gravatar_id":"","url":"https://api.github.com/users/pfoster-youitv","html_url":"https://github.com/pfoster-youitv","followers_url":"https://api.github.com/users/pfoster-youitv/followers","following_url":"https://api.github.com/users/pfoster-youitv/following{/other_user}","gists_url":"https://api.github.com/users/pfoster-youitv/gists{/gist_id}","starred_url":"https://api.github.com/users/pfoster-youitv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfoster-youitv/subscriptions","organizations_url":"https://api.github.com/users/pfoster-youitv/orgs","repos_url":"https://api.github.com/users/pfoster-youitv/repos","events_url":"https://api.github.com/users/pfoster-youitv/events{/privacy}","received_events_url":"https://api.github.com/users/pfoster-youitv/received_events","type":"User","site_admin":false},"body":"## Change list\r\n\r\nmodified:   src/main/java/io/appium/java_client/AppiumDriver.java\r\nnew file:   src/main/java/io/appium/java_client/YouiEngine/YouiEngineDriver.java\r\nnew file:   src/main/java/io/appium/java_client/YouiEngine/YouiEngineElement.java\r\nnew file:   src/main/java/io/appium/java_client/YouiEngine/internal/JsonToYouiEngineElementConverter.java\r\nmodified:   src/main/java/io/appium/java_client/service/local/AppiumServiceBuilder.java\r\nnew file:   src/test/java/io/appium/java_client/YouiEngine_Test/sanityTest.java\r\nnew file:   src/test/java/io/appium/java_client/YouiEngine_Test/util/AppiumTest.java\r\nmodified:   src/test/java/io/appium/java_client/android/AndroidDriverTest.java\r\n \r\n## Types of changes\r\n\r\nAdded support for YouiEngine apps.\r\nFixed import statements.\r\nAdded test class example (not final)\r\n\r\n## Details\r\n\r\nAdded YouiEngineDriver.java - subclass of AppiumDriver with sample of proxy driver commands\r\nAdded YouiEngineElement.java - subclass of MobileElement - required for ...\r\nAdded JsonToYouiEngineElementConverter.java - subclass of JsonToMobileElementConverter which converts the JSON response to a (MobileElement) YouiEngineElement instance.\r\nAdded a very rough test class and helper class to work in to ensure the calls work. \r\n-- Reliant on the presence of the VideoPlayer app or apk\r\n\r\nAlso cleaned up some of the import commands that weren't finding the right class implementation.\r\n","created_at":"2016-06-03T18:30:30Z","updated_at":"2016-06-07T17:48:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8814019310d94efeeb2aa9b8bc88269ce63997a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/1/commits","review_comments_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/1/comments","review_comment_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/1/comments","statuses_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/statuses/d8dfa824e721a52c733bacb38dcbb3f6aed301b2","head":{"label":"pfoster-youitv:YouiEngineStuff","ref":"YouiEngineStuff","sha":"d8dfa824e721a52c733bacb38dcbb3f6aed301b2","user":{"login":"pfoster-youitv","id":16088405,"avatar_url":"https://avatars.githubusercontent.com/u/16088405?v=3","gravatar_id":"","url":"https://api.github.com/users/pfoster-youitv","html_url":"https://github.com/pfoster-youitv","followers_url":"https://api.github.com/users/pfoster-youitv/followers","following_url":"https://api.github.com/users/pfoster-youitv/following{/other_user}","gists_url":"https://api.github.com/users/pfoster-youitv/gists{/gist_id}","starred_url":"https://api.github.com/users/pfoster-youitv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfoster-youitv/subscriptions","organizations_url":"https://api.github.com/users/pfoster-youitv/orgs","repos_url":"https://api.github.com/users/pfoster-youitv/repos","events_url":"https://api.github.com/users/pfoster-youitv/events{/privacy}","received_events_url":"https://api.github.com/users/pfoster-youitv/received_events","type":"User","site_admin":false},"repo":{"id":60347146,"name":"appium-java-client","full_name":"pfoster-youitv/appium-java-client","owner":{"login":"pfoster-youitv","id":16088405,"avatar_url":"https://avatars.githubusercontent.com/u/16088405?v=3","gravatar_id":"","url":"https://api.github.com/users/pfoster-youitv","html_url":"https://github.com/pfoster-youitv","followers_url":"https://api.github.com/users/pfoster-youitv/followers","following_url":"https://api.github.com/users/pfoster-youitv/following{/other_user}","gists_url":"https://api.github.com/users/pfoster-youitv/gists{/gist_id}","starred_url":"https://api.github.com/users/pfoster-youitv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfoster-youitv/subscriptions","organizations_url":"https://api.github.com/users/pfoster-youitv/orgs","repos_url":"https://api.github.com/users/pfoster-youitv/repos","events_url":"https://api.github.com/users/pfoster-youitv/events{/privacy}","received_events_url":"https://api.github.com/users/pfoster-youitv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfoster-youitv/appium-java-client","description":"Java language binding for writing Appium Tests, conforms to Mobile JSON Wire Protocol","fork":true,"url":"https://api.github.com/repos/pfoster-youitv/appium-java-client","forks_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/forks","keys_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/teams","hooks_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/hooks","issue_events_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/events","assignees_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/tags","blobs_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/languages","stargazers_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/stargazers","contributors_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/contributors","subscribers_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/subscribers","subscription_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/subscription","commits_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/merges","archive_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/downloads","issues_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/labels{/name}","releases_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/releases{/id}","deployments_url":"https://api.github.com/repos/pfoster-youitv/appium-java-client/deployments","created_at":"2016-06-03T12:48:32Z","updated_at":"2016-06-03T12:48:34Z","pushed_at":"2016-06-07T16:33:57Z","git_url":"git://github.com/pfoster-youitv/appium-java-client.git","ssh_url":"git@github.com:pfoster-youitv/appium-java-client.git","clone_url":"https://github.com/pfoster-youitv/appium-java-client.git","svn_url":"https://github.com/pfoster-youitv/appium-java-client","homepage":null,"size":37569,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"YOU-i-Labs:develop","ref":"develop","sha":"97bfc051737d0a80d8e4a3fec4782bacdf06c3e2","user":{"login":"YOU-i-Labs","id":2078519,"avatar_url":"https://avatars.githubusercontent.com/u/2078519?v=3","gravatar_id":"","url":"https://api.github.com/users/YOU-i-Labs","html_url":"https://github.com/YOU-i-Labs","followers_url":"https://api.github.com/users/YOU-i-Labs/followers","following_url":"https://api.github.com/users/YOU-i-Labs/following{/other_user}","gists_url":"https://api.github.com/users/YOU-i-Labs/gists{/gist_id}","starred_url":"https://api.github.com/users/YOU-i-Labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YOU-i-Labs/subscriptions","organizations_url":"https://api.github.com/users/YOU-i-Labs/orgs","repos_url":"https://api.github.com/users/YOU-i-Labs/repos","events_url":"https://api.github.com/users/YOU-i-Labs/events{/privacy}","received_events_url":"https://api.github.com/users/YOU-i-Labs/received_events","type":"Organization","site_admin":false},"repo":{"id":60346845,"name":"appium-java-client","full_name":"YOU-i-Labs/appium-java-client","owner":{"login":"YOU-i-Labs","id":2078519,"avatar_url":"https://avatars.githubusercontent.com/u/2078519?v=3","gravatar_id":"","url":"https://api.github.com/users/YOU-i-Labs","html_url":"https://github.com/YOU-i-Labs","followers_url":"https://api.github.com/users/YOU-i-Labs/followers","following_url":"https://api.github.com/users/YOU-i-Labs/following{/other_user}","gists_url":"https://api.github.com/users/YOU-i-Labs/gists{/gist_id}","starred_url":"https://api.github.com/users/YOU-i-Labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YOU-i-Labs/subscriptions","organizations_url":"https://api.github.com/users/YOU-i-Labs/orgs","repos_url":"https://api.github.com/users/YOU-i-Labs/repos","events_url":"https://api.github.com/users/YOU-i-Labs/events{/privacy}","received_events_url":"https://api.github.com/users/YOU-i-Labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YOU-i-Labs/appium-java-client","description":"Java language binding for writing Appium Tests, conforms to Mobile JSON Wire Protocol","fork":true,"url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client","forks_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/forks","keys_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/teams","hooks_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/hooks","issue_events_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/events","assignees_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/tags","blobs_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/languages","stargazers_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/stargazers","contributors_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/contributors","subscribers_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/subscribers","subscription_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/subscription","commits_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/merges","archive_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/downloads","issues_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/labels{/name}","releases_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/releases{/id}","deployments_url":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/deployments","created_at":"2016-06-03T12:43:09Z","updated_at":"2016-06-03T12:43:40Z","pushed_at":"2016-06-07T16:33:58Z","git_url":"git://github.com/YOU-i-Labs/appium-java-client.git","ssh_url":"git@github.com:YOU-i-Labs/appium-java-client.git","clone_url":"https://github.com/YOU-i-Labs/appium-java-client.git","svn_url":"https://github.com/YOU-i-Labs/appium-java-client","homepage":null,"size":37486,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/1"},"html":{"href":"https://github.com/YOU-i-Labs/appium-java-client/pull/1"},"issue":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/1"},"comments":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/YOU-i-Labs/appium-java-client/statuses/d8dfa824e721a52c733bacb38dcbb3f6aed301b2"}}}}
{"actor":{"display_login":"jplandry"}}