{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/76936644","id":76936644,"diff_hunk":"@@ -1792,3 +1793,17 @@ def test_issue_2840_8155():\n \n def test_issue_9567():\n     assert solve(1 + 1/(x - 1)) == [0]\n+\n+def test_issue_11538():\n+    assert solve(x + E) == [-E]\n+    assert solve(x**2 + E) == [-I*sqrt(E),I*sqrt(E)]","path":"sympy/solvers/tests/test_solvers.py","position":17,"original_position":17,"commit_id":"3e08071b25db78d48eef951f440f1a603c641ddd","original_commit_id":"3e08071b25db78d48eef951f440f1a603c641ddd","user":{"login":"jksuom","id":6929119,"avatar_url":"https://avatars.githubusercontent.com/u/6929119?v=3","gravatar_id":"","url":"https://api.github.com/users/jksuom","html_url":"https://github.com/jksuom","followers_url":"https://api.github.com/users/jksuom/followers","following_url":"https://api.github.com/users/jksuom/following{/other_user}","gists_url":"https://api.github.com/users/jksuom/gists{/gist_id}","starred_url":"https://api.github.com/users/jksuom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jksuom/subscriptions","organizations_url":"https://api.github.com/users/jksuom/orgs","repos_url":"https://api.github.com/users/jksuom/repos","events_url":"https://api.github.com/users/jksuom/events{/privacy}","received_events_url":"https://api.github.com/users/jksuom/received_events","type":"User","site_admin":false},"body":"Space after comma.","created_at":"2016-08-31T07:26:30Z","updated_at":"2016-08-31T07:26:30Z","html_url":"https://github.com/sympy/sympy/pull/11558#discussion_r76936644","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/11558","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/76936644"},"html":{"href":"https://github.com/sympy/sympy/pull/11558#discussion_r76936644"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11558"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/11558","id":83195225,"html_url":"https://github.com/sympy/sympy/pull/11558","diff_url":"https://github.com/sympy/sympy/pull/11558.diff","patch_url":"https://github.com/sympy/sympy/pull/11558.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/11558","number":11558,"state":"open","locked":false,"title":"11538 poly solve issue","user":{"login":"ctefer","id":16949219,"avatar_url":"https://avatars.githubusercontent.com/u/16949219?v=3","gravatar_id":"","url":"https://api.github.com/users/ctefer","html_url":"https://github.com/ctefer","followers_url":"https://api.github.com/users/ctefer/followers","following_url":"https://api.github.com/users/ctefer/following{/other_user}","gists_url":"https://api.github.com/users/ctefer/gists{/gist_id}","starred_url":"https://api.github.com/users/ctefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctefer/subscriptions","organizations_url":"https://api.github.com/users/ctefer/orgs","repos_url":"https://api.github.com/users/ctefer/repos","events_url":"https://api.github.com/users/ctefer/events{/privacy}","received_events_url":"https://api.github.com/users/ctefer/received_events","type":"User","site_admin":false},"body":"> Closes 11538\r\n\r\nUpdated constructor to treat NumberSymbols as symbols. polys containing non-algebraic number symbols are now treated as ZZ. This allows solvers to solve polynomials containing these specialized constants.\r\n\r\nTests created were checked against WA. A test that ensures an empty set is not produced when given the original issue parameters was also produced. The non-empty set is hard to check against WA and contains tuples that need to be solved.\r\n\r\nA test was updated for test_solveset because the solver method now simplifies the output even further than was originally asserted.","created_at":"2016-08-30T01:34:29Z","updated_at":"2016-08-31T07:26:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ad26a0ff073bbcb2f8430d81489ecb88f176eb1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/11558/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/11558/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/11558/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/3e08071b25db78d48eef951f440f1a603c641ddd","head":{"label":"ctefer:11538_ploy_solve_issue","ref":"11538_ploy_solve_issue","sha":"3e08071b25db78d48eef951f440f1a603c641ddd","user":{"login":"ctefer","id":16949219,"avatar_url":"https://avatars.githubusercontent.com/u/16949219?v=3","gravatar_id":"","url":"https://api.github.com/users/ctefer","html_url":"https://github.com/ctefer","followers_url":"https://api.github.com/users/ctefer/followers","following_url":"https://api.github.com/users/ctefer/following{/other_user}","gists_url":"https://api.github.com/users/ctefer/gists{/gist_id}","starred_url":"https://api.github.com/users/ctefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctefer/subscriptions","organizations_url":"https://api.github.com/users/ctefer/orgs","repos_url":"https://api.github.com/users/ctefer/repos","events_url":"https://api.github.com/users/ctefer/events{/privacy}","received_events_url":"https://api.github.com/users/ctefer/received_events","type":"User","site_admin":false},"repo":{"id":66805262,"name":"sympy","full_name":"ctefer/sympy","owner":{"login":"ctefer","id":16949219,"avatar_url":"https://avatars.githubusercontent.com/u/16949219?v=3","gravatar_id":"","url":"https://api.github.com/users/ctefer","html_url":"https://github.com/ctefer","followers_url":"https://api.github.com/users/ctefer/followers","following_url":"https://api.github.com/users/ctefer/following{/other_user}","gists_url":"https://api.github.com/users/ctefer/gists{/gist_id}","starred_url":"https://api.github.com/users/ctefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctefer/subscriptions","organizations_url":"https://api.github.com/users/ctefer/orgs","repos_url":"https://api.github.com/users/ctefer/repos","events_url":"https://api.github.com/users/ctefer/events{/privacy}","received_events_url":"https://api.github.com/users/ctefer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctefer/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/ctefer/sympy","forks_url":"https://api.github.com/repos/ctefer/sympy/forks","keys_url":"https://api.github.com/repos/ctefer/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctefer/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctefer/sympy/teams","hooks_url":"https://api.github.com/repos/ctefer/sympy/hooks","issue_events_url":"https://api.github.com/repos/ctefer/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/ctefer/sympy/events","assignees_url":"https://api.github.com/repos/ctefer/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/ctefer/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/ctefer/sympy/tags","blobs_url":"https://api.github.com/repos/ctefer/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctefer/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctefer/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctefer/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctefer/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/ctefer/sympy/languages","stargazers_url":"https://api.github.com/repos/ctefer/sympy/stargazers","contributors_url":"https://api.github.com/repos/ctefer/sympy/contributors","subscribers_url":"https://api.github.com/repos/ctefer/sympy/subscribers","subscription_url":"https://api.github.com/repos/ctefer/sympy/subscription","commits_url":"https://api.github.com/repos/ctefer/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctefer/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctefer/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctefer/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctefer/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/ctefer/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctefer/sympy/merges","archive_url":"https://api.github.com/repos/ctefer/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctefer/sympy/downloads","issues_url":"https://api.github.com/repos/ctefer/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/ctefer/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/ctefer/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/ctefer/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctefer/sympy/labels{/name}","releases_url":"https://api.github.com/repos/ctefer/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/ctefer/sympy/deployments","created_at":"2016-08-29T02:41:37Z","updated_at":"2016-08-29T02:41:43Z","pushed_at":"2016-08-31T02:15:24Z","git_url":"git://github.com/ctefer/sympy.git","ssh_url":"git@github.com:ctefer/sympy.git","clone_url":"https://github.com/ctefer/sympy.git","svn_url":"https://github.com/ctefer/sympy","homepage":"http://sympy.org/","size":74838,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"deeb5ac6789f97abd4846e03e9f2b2fced384262","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2016-08-31T02:35:59Z","pushed_at":"2016-08-31T02:46:00Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":116394,"stargazers_count":3093,"watchers_count":3093,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1565,"mirror_url":null,"open_issues_count":2496,"forks":1565,"open_issues":2496,"watchers":3093,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11558"},"html":{"href":"https://github.com/sympy/sympy/pull/11558"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/11558"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/11558/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11558/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11558/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/3e08071b25db78d48eef951f440f1a603c641ddd"}}}}
{"actor":{"display_login":"jksuom"}}