{"action":"created","comment":{"url":"https://api.github.com/repos/atom/language-javascript/pulls/comments/85643431","pull_request_review_id":6350164,"id":85643431,"diff_hunk":"@@ -1249,6 +1249,14 @@ describe \"Javascript grammar\", ->\n       {tokens} = grammar.tokenizeLine('\"func\" : a => a')\n       expect(tokens[8]).toEqual value: '=>', scopes: ['source.js', 'meta.function.arrow.json.js', 'storage.type.function.arrow.js']\n \n+      {tokens} = grammar.tokenizeLine('import (x) { return \"Yeah\"; }')\n+      expect(tokens[0]).toEqual value: 'import', scopes: ['source.js', 'meta.function.method.definition.js', 'entity.name.function.js']\n+      expect(tokens[11]).toEqual value: 'Yeah', scopes: ['source.js', 'string.quoted.double.js']\n+\n+      {tokens} = grammar.tokenizeLine('export (x) { return \"Nah\"; }')\n+      expect(tokens[0]).toEqual value: 'export', scopes: ['source.js', 'meta.function.method.definition.js', 'entity.name.function.js']\n+      expect(tokens[11]).toEqual value: 'Nah', scopes: ['source.js', 'string.quoted.double.js']\n+","path":"spec/javascript-spec.coffee","position":11,"original_position":11,"commit_id":"a66d00b7d7917f36d87db257b0931ad643d1882b","original_commit_id":"17ba6640367d4291c6ae4ddcd1c1e139de286dbe","user":{"login":"Alhadis","id":2346707,"avatar_url":"https://avatars.githubusercontent.com/u/2346707?v=3","gravatar_id":"","url":"https://api.github.com/users/Alhadis","html_url":"https://github.com/Alhadis","followers_url":"https://api.github.com/users/Alhadis/followers","following_url":"https://api.github.com/users/Alhadis/following{/other_user}","gists_url":"https://api.github.com/users/Alhadis/gists{/gist_id}","starred_url":"https://api.github.com/users/Alhadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alhadis/subscriptions","organizations_url":"https://api.github.com/users/Alhadis/orgs","repos_url":"https://api.github.com/users/Alhadis/repos","events_url":"https://api.github.com/users/Alhadis/events{/privacy}","received_events_url":"https://api.github.com/users/Alhadis/received_events","type":"User","site_admin":false},"body":"<img src=\"https://cloud.githubusercontent.com/assets/2346707/18314225/71c30e64-7555-11e6-94aa-37d9ee51814f.jpg\" width=\"200\" alt=\"👌\" />\r\n","created_at":"2016-10-29T16:24:31Z","updated_at":"2016-10-29T16:24:31Z","html_url":"https://github.com/atom/language-javascript/pull/453#discussion_r85643431","pull_request_url":"https://api.github.com/repos/atom/language-javascript/pulls/453","_links":{"self":{"href":"https://api.github.com/repos/atom/language-javascript/pulls/comments/85643431"},"html":{"href":"https://github.com/atom/language-javascript/pull/453#discussion_r85643431"},"pull_request":{"href":"https://api.github.com/repos/atom/language-javascript/pulls/453"}}},"pull_request":{"url":"https://api.github.com/repos/atom/language-javascript/pulls/453","id":91493347,"html_url":"https://github.com/atom/language-javascript/pull/453","diff_url":"https://github.com/atom/language-javascript/pull/453.diff","patch_url":"https://github.com/atom/language-javascript/pull/453.patch","issue_url":"https://api.github.com/repos/atom/language-javascript/issues/453","number":453,"state":"open","locked":false,"title":"Fix #452: Wrong scopes for methods named \"import\"","user":{"login":"Alhadis","id":2346707,"avatar_url":"https://avatars.githubusercontent.com/u/2346707?v=3","gravatar_id":"","url":"https://api.github.com/users/Alhadis","html_url":"https://github.com/Alhadis","followers_url":"https://api.github.com/users/Alhadis/followers","following_url":"https://api.github.com/users/Alhadis/following{/other_user}","gists_url":"https://api.github.com/users/Alhadis/gists{/gist_id}","starred_url":"https://api.github.com/users/Alhadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alhadis/subscriptions","organizations_url":"https://api.github.com/users/Alhadis/orgs","repos_url":"https://api.github.com/users/Alhadis/repos","events_url":"https://api.github.com/users/Alhadis/events{/privacy}","received_events_url":"https://api.github.com/users/Alhadis/received_events","type":"User","site_admin":false},"body":"Fixes #452:\r\n\r\n```js\r\nimport(x) { \"ABCDEFGHIJKLMNOPQRSTUVWXYZ\"; }\r\nImport(x) { \"ABCDEFGHIJKLMNOPQRSTUVWXYZ\"; }\r\n```","created_at":"2016-10-29T16:04:30Z","updated_at":"2016-10-29T16:24:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c7b3bcd74aaa485e2e6a934ab5ed1d97e244a4e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/atom/language-javascript/pulls/453/commits","review_comments_url":"https://api.github.com/repos/atom/language-javascript/pulls/453/comments","review_comment_url":"https://api.github.com/repos/atom/language-javascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/language-javascript/issues/453/comments","statuses_url":"https://api.github.com/repos/atom/language-javascript/statuses/a66d00b7d7917f36d87db257b0931ad643d1882b","head":{"label":"Alhadis:fix-452","ref":"fix-452","sha":"a66d00b7d7917f36d87db257b0931ad643d1882b","user":{"login":"Alhadis","id":2346707,"avatar_url":"https://avatars.githubusercontent.com/u/2346707?v=3","gravatar_id":"","url":"https://api.github.com/users/Alhadis","html_url":"https://github.com/Alhadis","followers_url":"https://api.github.com/users/Alhadis/followers","following_url":"https://api.github.com/users/Alhadis/following{/other_user}","gists_url":"https://api.github.com/users/Alhadis/gists{/gist_id}","starred_url":"https://api.github.com/users/Alhadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alhadis/subscriptions","organizations_url":"https://api.github.com/users/Alhadis/orgs","repos_url":"https://api.github.com/users/Alhadis/repos","events_url":"https://api.github.com/users/Alhadis/events{/privacy}","received_events_url":"https://api.github.com/users/Alhadis/received_events","type":"User","site_admin":false},"repo":{"id":68465555,"name":"language-javascript","full_name":"Alhadis/language-javascript","owner":{"login":"Alhadis","id":2346707,"avatar_url":"https://avatars.githubusercontent.com/u/2346707?v=3","gravatar_id":"","url":"https://api.github.com/users/Alhadis","html_url":"https://github.com/Alhadis","followers_url":"https://api.github.com/users/Alhadis/followers","following_url":"https://api.github.com/users/Alhadis/following{/other_user}","gists_url":"https://api.github.com/users/Alhadis/gists{/gist_id}","starred_url":"https://api.github.com/users/Alhadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alhadis/subscriptions","organizations_url":"https://api.github.com/users/Alhadis/orgs","repos_url":"https://api.github.com/users/Alhadis/repos","events_url":"https://api.github.com/users/Alhadis/events{/privacy}","received_events_url":"https://api.github.com/users/Alhadis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Alhadis/language-javascript","description":"Hub of various pull requests submitted to Atom's JS package.","fork":true,"url":"https://api.github.com/repos/Alhadis/language-javascript","forks_url":"https://api.github.com/repos/Alhadis/language-javascript/forks","keys_url":"https://api.github.com/repos/Alhadis/language-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alhadis/language-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alhadis/language-javascript/teams","hooks_url":"https://api.github.com/repos/Alhadis/language-javascript/hooks","issue_events_url":"https://api.github.com/repos/Alhadis/language-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/Alhadis/language-javascript/events","assignees_url":"https://api.github.com/repos/Alhadis/language-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/Alhadis/language-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/Alhadis/language-javascript/tags","blobs_url":"https://api.github.com/repos/Alhadis/language-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alhadis/language-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alhadis/language-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alhadis/language-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alhadis/language-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/Alhadis/language-javascript/languages","stargazers_url":"https://api.github.com/repos/Alhadis/language-javascript/stargazers","contributors_url":"https://api.github.com/repos/Alhadis/language-javascript/contributors","subscribers_url":"https://api.github.com/repos/Alhadis/language-javascript/subscribers","subscription_url":"https://api.github.com/repos/Alhadis/language-javascript/subscription","commits_url":"https://api.github.com/repos/Alhadis/language-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alhadis/language-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alhadis/language-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alhadis/language-javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alhadis/language-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/Alhadis/language-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alhadis/language-javascript/merges","archive_url":"https://api.github.com/repos/Alhadis/language-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alhadis/language-javascript/downloads","issues_url":"https://api.github.com/repos/Alhadis/language-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/Alhadis/language-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/Alhadis/language-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/Alhadis/language-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alhadis/language-javascript/labels{/name}","releases_url":"https://api.github.com/repos/Alhadis/language-javascript/releases{/id}","deployments_url":"https://api.github.com/repos/Alhadis/language-javascript/deployments","created_at":"2016-09-17T16:58:03Z","updated_at":"2016-09-17T16:59:03Z","pushed_at":"2016-10-29T16:23:58Z","git_url":"git://github.com/Alhadis/language-javascript.git","ssh_url":"git@github.com:Alhadis/language-javascript.git","clone_url":"https://github.com/Alhadis/language-javascript.git","svn_url":"https://github.com/Alhadis/language-javascript","homepage":"https://github.com/atom/language-javascript","size":891,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"08645006afea85fc012da155d883a8423530bbd0","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":13712111,"name":"language-javascript","full_name":"atom/language-javascript","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/language-javascript","description":"JavaScript language package for Atom","fork":false,"url":"https://api.github.com/repos/atom/language-javascript","forks_url":"https://api.github.com/repos/atom/language-javascript/forks","keys_url":"https://api.github.com/repos/atom/language-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/language-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/language-javascript/teams","hooks_url":"https://api.github.com/repos/atom/language-javascript/hooks","issue_events_url":"https://api.github.com/repos/atom/language-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/atom/language-javascript/events","assignees_url":"https://api.github.com/repos/atom/language-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/atom/language-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/atom/language-javascript/tags","blobs_url":"https://api.github.com/repos/atom/language-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/language-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/language-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/language-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/language-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/language-javascript/languages","stargazers_url":"https://api.github.com/repos/atom/language-javascript/stargazers","contributors_url":"https://api.github.com/repos/atom/language-javascript/contributors","subscribers_url":"https://api.github.com/repos/atom/language-javascript/subscribers","subscription_url":"https://api.github.com/repos/atom/language-javascript/subscription","commits_url":"https://api.github.com/repos/atom/language-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/language-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/language-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/language-javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/language-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/atom/language-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/language-javascript/merges","archive_url":"https://api.github.com/repos/atom/language-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/language-javascript/downloads","issues_url":"https://api.github.com/repos/atom/language-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/atom/language-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/language-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/language-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/language-javascript/labels{/name}","releases_url":"https://api.github.com/repos/atom/language-javascript/releases{/id}","deployments_url":"https://api.github.com/repos/atom/language-javascript/deployments","created_at":"2013-10-20T02:03:20Z","updated_at":"2016-10-24T03:27:43Z","pushed_at":"2016-10-29T16:23:59Z","git_url":"git://github.com/atom/language-javascript.git","ssh_url":"git@github.com:atom/language-javascript.git","clone_url":"https://github.com/atom/language-javascript.git","svn_url":"https://github.com/atom/language-javascript","homepage":"","size":1338,"stargazers_count":108,"watchers_count":108,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":48,"forks":159,"open_issues":48,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/language-javascript/pulls/453"},"html":{"href":"https://github.com/atom/language-javascript/pull/453"},"issue":{"href":"https://api.github.com/repos/atom/language-javascript/issues/453"},"comments":{"href":"https://api.github.com/repos/atom/language-javascript/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/language-javascript/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/language-javascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/language-javascript/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/atom/language-javascript/statuses/a66d00b7d7917f36d87db257b0931ad643d1882b"}}}}
{"actor":{"display_login":"Alhadis"}}