{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/comments/73504914","id":73504914,"diff_hunk":"@@ -31,7 +31,7 @@ export class TaskCommand {\n             for (var key in this.properties) {\n                 if (this.properties.hasOwnProperty(key)) {\n                     var val = this.properties[key];\n-                    if (val) {\n+                    if (val != null) {","path":"node/taskcommand.ts","position":5,"original_position":5,"commit_id":"283e0c70dc4b98b4dbfe70c834941a306c54f180","original_commit_id":"283e0c70dc4b98b4dbfe70c834941a306c54f180","user":{"login":"bryanmacfarlane","id":919564,"avatar_url":"https://avatars.githubusercontent.com/u/919564?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanmacfarlane","html_url":"https://github.com/bryanmacfarlane","followers_url":"https://api.github.com/users/bryanmacfarlane/followers","following_url":"https://api.github.com/users/bryanmacfarlane/following{/other_user}","gists_url":"https://api.github.com/users/bryanmacfarlane/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanmacfarlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanmacfarlane/subscriptions","organizations_url":"https://api.github.com/users/bryanmacfarlane/orgs","repos_url":"https://api.github.com/users/bryanmacfarlane/repos","events_url":"https://api.github.com/users/bryanmacfarlane/events{/privacy}","received_events_url":"https://api.github.com/users/bryanmacfarlane/received_events","type":"User","site_admin":false},"body":"They did something wrong, it should be skipped.  Writing code to enable passing the wrong data type encourages doing the wrong thing.  The compiler will encourage the right thing.  If they bypass that and do the wrong thing, then it not getting set will further encourage the right thing.  They will see it's not getting set, look at the docs/types and fix it.","created_at":"2016-08-04T11:24:56Z","updated_at":"2016-08-04T11:24:56Z","html_url":"https://github.com/Microsoft/vsts-task-lib/pull/103#discussion_r73504914","pull_request_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/comments/73504914"},"html":{"href":"https://github.com/Microsoft/vsts-task-lib/pull/103#discussion_r73504914"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/103","id":77943095,"html_url":"https://github.com/Microsoft/vsts-task-lib/pull/103","diff_url":"https://github.com/Microsoft/vsts-task-lib/pull/103.diff","patch_url":"https://github.com/Microsoft/vsts-task-lib/pull/103.patch","issue_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/issues/103","number":103,"state":"open","locked":false,"title":"Fix issue in generating Command for boolean values","user":{"login":"nigurr","id":15208679,"avatar_url":"https://avatars.githubusercontent.com/u/15208679?v=3","gravatar_id":"","url":"https://api.github.com/users/nigurr","html_url":"https://github.com/nigurr","followers_url":"https://api.github.com/users/nigurr/followers","following_url":"https://api.github.com/users/nigurr/following{/other_user}","gists_url":"https://api.github.com/users/nigurr/gists{/gist_id}","starred_url":"https://api.github.com/users/nigurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigurr/subscriptions","organizations_url":"https://api.github.com/users/nigurr/orgs","repos_url":"https://api.github.com/users/nigurr/repos","events_url":"https://api.github.com/users/nigurr/events{/privacy}","received_events_url":"https://api.github.com/users/nigurr/received_events","type":"User","site_admin":false},"body":"if(val) falsify the boolean parameters. \r\nWe should not send command only for undefined/null types","created_at":"2016-07-19T09:20:41Z","updated_at":"2016-08-04T11:24:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d59533095693bea34343f2320bb84de9cf9fe25","assignee":{"login":"bryanmacfarlane","id":919564,"avatar_url":"https://avatars.githubusercontent.com/u/919564?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanmacfarlane","html_url":"https://github.com/bryanmacfarlane","followers_url":"https://api.github.com/users/bryanmacfarlane/followers","following_url":"https://api.github.com/users/bryanmacfarlane/following{/other_user}","gists_url":"https://api.github.com/users/bryanmacfarlane/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanmacfarlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanmacfarlane/subscriptions","organizations_url":"https://api.github.com/users/bryanmacfarlane/orgs","repos_url":"https://api.github.com/users/bryanmacfarlane/repos","events_url":"https://api.github.com/users/bryanmacfarlane/events{/privacy}","received_events_url":"https://api.github.com/users/bryanmacfarlane/received_events","type":"User","site_admin":false},"assignees":[{"login":"bryanmacfarlane","id":919564,"avatar_url":"https://avatars.githubusercontent.com/u/919564?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanmacfarlane","html_url":"https://github.com/bryanmacfarlane","followers_url":"https://api.github.com/users/bryanmacfarlane/followers","following_url":"https://api.github.com/users/bryanmacfarlane/following{/other_user}","gists_url":"https://api.github.com/users/bryanmacfarlane/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanmacfarlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanmacfarlane/subscriptions","organizations_url":"https://api.github.com/users/bryanmacfarlane/orgs","repos_url":"https://api.github.com/users/bryanmacfarlane/repos","events_url":"https://api.github.com/users/bryanmacfarlane/events{/privacy}","received_events_url":"https://api.github.com/users/bryanmacfarlane/received_events","type":"User","site_admin":false},{"login":"ericsciple","id":12102068,"avatar_url":"https://avatars.githubusercontent.com/u/12102068?v=3","gravatar_id":"","url":"https://api.github.com/users/ericsciple","html_url":"https://github.com/ericsciple","followers_url":"https://api.github.com/users/ericsciple/followers","following_url":"https://api.github.com/users/ericsciple/following{/other_user}","gists_url":"https://api.github.com/users/ericsciple/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsciple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsciple/subscriptions","organizations_url":"https://api.github.com/users/ericsciple/orgs","repos_url":"https://api.github.com/users/ericsciple/repos","events_url":"https://api.github.com/users/ericsciple/events{/privacy}","received_events_url":"https://api.github.com/users/ericsciple/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/103/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/103/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/issues/103/comments","statuses_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/statuses/283e0c70dc4b98b4dbfe70c834941a306c54f180","head":{"label":"Microsoft:users/nigurr/FixCommandString","ref":"users/nigurr/FixCommandString","sha":"283e0c70dc4b98b4dbfe70c834941a306c54f180","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38649294,"name":"vsts-task-lib","full_name":"Microsoft/vsts-task-lib","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-task-lib","description":"Libraries for writing VSO and TFS build tasks","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-task-lib","forks_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/deployments","created_at":"2015-07-06T22:13:57Z","updated_at":"2016-08-01T17:27:18Z","pushed_at":"2016-08-04T10:57:31Z","git_url":"git://github.com/Microsoft/vsts-task-lib.git","ssh_url":"git@github.com:Microsoft/vsts-task-lib.git","clone_url":"https://github.com/Microsoft/vsts-task-lib.git","svn_url":"https://github.com/Microsoft/vsts-task-lib","homepage":null,"size":576,"stargazers_count":41,"watchers_count":41,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":14,"forks":24,"open_issues":14,"watchers":41,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"3b35cde4837ad93ce7ea5cac2660a7cd5706a444","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38649294,"name":"vsts-task-lib","full_name":"Microsoft/vsts-task-lib","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-task-lib","description":"Libraries for writing VSO and TFS build tasks","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-task-lib","forks_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-task-lib/deployments","created_at":"2015-07-06T22:13:57Z","updated_at":"2016-08-01T17:27:18Z","pushed_at":"2016-08-04T10:57:31Z","git_url":"git://github.com/Microsoft/vsts-task-lib.git","ssh_url":"git@github.com:Microsoft/vsts-task-lib.git","clone_url":"https://github.com/Microsoft/vsts-task-lib.git","svn_url":"https://github.com/Microsoft/vsts-task-lib","homepage":null,"size":576,"stargazers_count":41,"watchers_count":41,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":14,"forks":24,"open_issues":14,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/103"},"html":{"href":"https://github.com/Microsoft/vsts-task-lib/pull/103"},"issue":{"href":"https://api.github.com/repos/Microsoft/vsts-task-lib/issues/103"},"comments":{"href":"https://api.github.com/repos/Microsoft/vsts-task-lib/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vsts-task-lib/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vsts-task-lib/statuses/283e0c70dc4b98b4dbfe70c834941a306c54f180"}}}}
{"actor":{"display_login":"bryanmacfarlane"}}