{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-R/repgen/pulls/comments/77900335","id":77900335,"diff_hunk":"@@ -278,10 +281,51 @@ subsetByMonth <- function(pts, onlyMonth) {\n   }\n   return(pts)\n }\n-getYvals_approvals <- function(object, num_vals){\n-  ylim <- ylim(object)$side.2[1]\n-  yvals <- rep(ylim, num_vals)\n-  return(yvals)\n+\n+ApprovalInfoY <- function(object, times, c) {\n+  # Compute top and bottom vertical position of approval bars.\n+  # \n+  # Args:\n+  #   object: A gsplot object.\n+  #   times: \"times\" argument of R rep() function.\n+  #   c: A scaling ratio to adjust top or bottom of approval bar rectangle.\n+  #\n+  # Returns:\n+  #   Approval bar, top or bottom y-axis point, in world coordinates.\n+  reverse <- object$side.2$reverse\n+  \n+  # no idea whether semantics of object$global$par$ylog are correct in this\n+  # context or not; it just looked promising in the debugger\n+  if (is.null(object$global$par$ylog)) {","path":"R/utils-json.R","position":43,"original_position":43,"commit_id":"bae5d1f0237ca09b520931638c87d0f82a58b139","original_commit_id":"bae5d1f0237ca09b520931638c87d0f82a58b139","user":{"login":"lindsaycarr","id":13220910,"avatar_url":"https://avatars.githubusercontent.com/u/13220910?v=3","gravatar_id":"","url":"https://api.github.com/users/lindsaycarr","html_url":"https://github.com/lindsaycarr","followers_url":"https://api.github.com/users/lindsaycarr/followers","following_url":"https://api.github.com/users/lindsaycarr/following{/other_user}","gists_url":"https://api.github.com/users/lindsaycarr/gists{/gist_id}","starred_url":"https://api.github.com/users/lindsaycarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindsaycarr/subscriptions","organizations_url":"https://api.github.com/users/lindsaycarr/orgs","repos_url":"https://api.github.com/users/lindsaycarr/repos","events_url":"https://api.github.com/users/lindsaycarr/events{/privacy}","received_events_url":"https://api.github.com/users/lindsaycarr/received_events","type":"User","site_admin":false},"body":"yes, `object$global$par$ylog` is good - but I don't think it will ever be NULL based on what the `isLogged` function returns. I wonder if we should not have logic correcting for when this is NULL so that we can catch that scenario as a bug if it ever happens","created_at":"2016-09-07T20:46:02Z","updated_at":"2016-09-07T20:46:02Z","html_url":"https://github.com/USGS-R/repgen/pull/396#discussion_r77900335","pull_request_url":"https://api.github.com/repos/USGS-R/repgen/pulls/396","_links":{"self":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/comments/77900335"},"html":{"href":"https://github.com/USGS-R/repgen/pull/396#discussion_r77900335"},"pull_request":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/396"}}},"pull_request":{"url":"https://api.github.com/repos/USGS-R/repgen/pulls/396","id":83530521,"html_url":"https://github.com/USGS-R/repgen/pull/396","diff_url":"https://github.com/USGS-R/repgen/pull/396.diff","patch_url":"https://github.com/USGS-R/repgen/pull/396.patch","issue_url":"https://api.github.com/repos/USGS-R/repgen/issues/396","number":396,"state":"open","locked":false,"title":"Correct positioning of approval bars.","user":{"login":"ashalper-usgs","id":6117231,"avatar_url":"https://avatars.githubusercontent.com/u/6117231?v=3","gravatar_id":"","url":"https://api.github.com/users/ashalper-usgs","html_url":"https://github.com/ashalper-usgs","followers_url":"https://api.github.com/users/ashalper-usgs/followers","following_url":"https://api.github.com/users/ashalper-usgs/following{/other_user}","gists_url":"https://api.github.com/users/ashalper-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ashalper-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashalper-usgs/subscriptions","organizations_url":"https://api.github.com/users/ashalper-usgs/orgs","repos_url":"https://api.github.com/users/ashalper-usgs/repos","events_url":"https://api.github.com/users/ashalper-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/ashalper-usgs/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-31T21:12:28Z","updated_at":"2016-09-07T20:46:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81087320bb2f52ee1d5a186ab186ea0cbf5beac6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/USGS-R/repgen/pulls/396/commits","review_comments_url":"https://api.github.com/repos/USGS-R/repgen/pulls/396/comments","review_comment_url":"https://api.github.com/repos/USGS-R/repgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-R/repgen/issues/396/comments","statuses_url":"https://api.github.com/repos/USGS-R/repgen/statuses/bae5d1f0237ca09b520931638c87d0f82a58b139","head":{"label":"ashalper-usgs:master","ref":"master","sha":"bae5d1f0237ca09b520931638c87d0f82a58b139","user":{"login":"ashalper-usgs","id":6117231,"avatar_url":"https://avatars.githubusercontent.com/u/6117231?v=3","gravatar_id":"","url":"https://api.github.com/users/ashalper-usgs","html_url":"https://github.com/ashalper-usgs","followers_url":"https://api.github.com/users/ashalper-usgs/followers","following_url":"https://api.github.com/users/ashalper-usgs/following{/other_user}","gists_url":"https://api.github.com/users/ashalper-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ashalper-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashalper-usgs/subscriptions","organizations_url":"https://api.github.com/users/ashalper-usgs/orgs","repos_url":"https://api.github.com/users/ashalper-usgs/repos","events_url":"https://api.github.com/users/ashalper-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/ashalper-usgs/received_events","type":"User","site_admin":false},"repo":{"id":63436410,"name":"repgen","full_name":"ashalper-usgs/repgen","owner":{"login":"ashalper-usgs","id":6117231,"avatar_url":"https://avatars.githubusercontent.com/u/6117231?v=3","gravatar_id":"","url":"https://api.github.com/users/ashalper-usgs","html_url":"https://github.com/ashalper-usgs","followers_url":"https://api.github.com/users/ashalper-usgs/followers","following_url":"https://api.github.com/users/ashalper-usgs/following{/other_user}","gists_url":"https://api.github.com/users/ashalper-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ashalper-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashalper-usgs/subscriptions","organizations_url":"https://api.github.com/users/ashalper-usgs/orgs","repos_url":"https://api.github.com/users/ashalper-usgs/repos","events_url":"https://api.github.com/users/ashalper-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/ashalper-usgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashalper-usgs/repgen","description":"report generation in R","fork":true,"url":"https://api.github.com/repos/ashalper-usgs/repgen","forks_url":"https://api.github.com/repos/ashalper-usgs/repgen/forks","keys_url":"https://api.github.com/repos/ashalper-usgs/repgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashalper-usgs/repgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashalper-usgs/repgen/teams","hooks_url":"https://api.github.com/repos/ashalper-usgs/repgen/hooks","issue_events_url":"https://api.github.com/repos/ashalper-usgs/repgen/issues/events{/number}","events_url":"https://api.github.com/repos/ashalper-usgs/repgen/events","assignees_url":"https://api.github.com/repos/ashalper-usgs/repgen/assignees{/user}","branches_url":"https://api.github.com/repos/ashalper-usgs/repgen/branches{/branch}","tags_url":"https://api.github.com/repos/ashalper-usgs/repgen/tags","blobs_url":"https://api.github.com/repos/ashalper-usgs/repgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashalper-usgs/repgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashalper-usgs/repgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashalper-usgs/repgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashalper-usgs/repgen/statuses/{sha}","languages_url":"https://api.github.com/repos/ashalper-usgs/repgen/languages","stargazers_url":"https://api.github.com/repos/ashalper-usgs/repgen/stargazers","contributors_url":"https://api.github.com/repos/ashalper-usgs/repgen/contributors","subscribers_url":"https://api.github.com/repos/ashalper-usgs/repgen/subscribers","subscription_url":"https://api.github.com/repos/ashalper-usgs/repgen/subscription","commits_url":"https://api.github.com/repos/ashalper-usgs/repgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashalper-usgs/repgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashalper-usgs/repgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashalper-usgs/repgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashalper-usgs/repgen/contents/{+path}","compare_url":"https://api.github.com/repos/ashalper-usgs/repgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashalper-usgs/repgen/merges","archive_url":"https://api.github.com/repos/ashalper-usgs/repgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashalper-usgs/repgen/downloads","issues_url":"https://api.github.com/repos/ashalper-usgs/repgen/issues{/number}","pulls_url":"https://api.github.com/repos/ashalper-usgs/repgen/pulls{/number}","milestones_url":"https://api.github.com/repos/ashalper-usgs/repgen/milestones{/number}","notifications_url":"https://api.github.com/repos/ashalper-usgs/repgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashalper-usgs/repgen/labels{/name}","releases_url":"https://api.github.com/repos/ashalper-usgs/repgen/releases{/id}","deployments_url":"https://api.github.com/repos/ashalper-usgs/repgen/deployments","created_at":"2016-07-15T16:36:46Z","updated_at":"2016-07-15T16:36:47Z","pushed_at":"2016-09-07T17:50:14Z","git_url":"git://github.com/ashalper-usgs/repgen.git","ssh_url":"git@github.com:ashalper-usgs/repgen.git","clone_url":"https://github.com/ashalper-usgs/repgen.git","svn_url":"https://github.com/ashalper-usgs/repgen","homepage":null,"size":11054,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-R:master","ref":"master","sha":"8c68974081860645c923be596bab9ae93f96c3b0","user":{"login":"USGS-R","id":3188813,"avatar_url":"https://avatars.githubusercontent.com/u/3188813?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"repo":{"id":31678130,"name":"repgen","full_name":"USGS-R/repgen","owner":{"login":"USGS-R","id":3188813,"avatar_url":"https://avatars.githubusercontent.com/u/3188813?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-R/repgen","description":"report generation in R","fork":false,"url":"https://api.github.com/repos/USGS-R/repgen","forks_url":"https://api.github.com/repos/USGS-R/repgen/forks","keys_url":"https://api.github.com/repos/USGS-R/repgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-R/repgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-R/repgen/teams","hooks_url":"https://api.github.com/repos/USGS-R/repgen/hooks","issue_events_url":"https://api.github.com/repos/USGS-R/repgen/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-R/repgen/events","assignees_url":"https://api.github.com/repos/USGS-R/repgen/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-R/repgen/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-R/repgen/tags","blobs_url":"https://api.github.com/repos/USGS-R/repgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-R/repgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-R/repgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-R/repgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-R/repgen/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-R/repgen/languages","stargazers_url":"https://api.github.com/repos/USGS-R/repgen/stargazers","contributors_url":"https://api.github.com/repos/USGS-R/repgen/contributors","subscribers_url":"https://api.github.com/repos/USGS-R/repgen/subscribers","subscription_url":"https://api.github.com/repos/USGS-R/repgen/subscription","commits_url":"https://api.github.com/repos/USGS-R/repgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-R/repgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-R/repgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-R/repgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-R/repgen/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-R/repgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-R/repgen/merges","archive_url":"https://api.github.com/repos/USGS-R/repgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-R/repgen/downloads","issues_url":"https://api.github.com/repos/USGS-R/repgen/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-R/repgen/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-R/repgen/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-R/repgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-R/repgen/labels{/name}","releases_url":"https://api.github.com/repos/USGS-R/repgen/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-R/repgen/deployments","created_at":"2015-03-04T20:24:02Z","updated_at":"2016-08-31T01:50:11Z","pushed_at":"2016-09-07T19:59:27Z","git_url":"git://github.com/USGS-R/repgen.git","ssh_url":"git@github.com:USGS-R/repgen.git","clone_url":"https://github.com/USGS-R/repgen.git","svn_url":"https://github.com/USGS-R/repgen","homepage":null,"size":11104,"stargazers_count":7,"watchers_count":7,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/396"},"html":{"href":"https://github.com/USGS-R/repgen/pull/396"},"issue":{"href":"https://api.github.com/repos/USGS-R/repgen/issues/396"},"comments":{"href":"https://api.github.com/repos/USGS-R/repgen/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-R/repgen/statuses/bae5d1f0237ca09b520931638c87d0f82a58b139"}}}}
{"actor":{"display_login":"lindsaycarr"}}