{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/66","repository_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint","labels_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/66/comments","events_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/66/events","html_url":"https://github.com/ember-cli/ember-cli-eslint/issues/66","id":158797085,"number":66,"title":"QUnit tests fail on warnings","user":{"login":"jwlawrence","id":488888,"avatar_url":"https://avatars.githubusercontent.com/u/488888?v=3","gravatar_id":"","url":"https://api.github.com/users/jwlawrence","html_url":"https://github.com/jwlawrence","followers_url":"https://api.github.com/users/jwlawrence/followers","following_url":"https://api.github.com/users/jwlawrence/following{/other_user}","gists_url":"https://api.github.com/users/jwlawrence/gists{/gist_id}","starred_url":"https://api.github.com/users/jwlawrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwlawrence/subscriptions","organizations_url":"https://api.github.com/users/jwlawrence/orgs","repos_url":"https://api.github.com/users/jwlawrence/repos","events_url":"https://api.github.com/users/jwlawrence/events{/privacy}","received_events_url":"https://api.github.com/users/jwlawrence/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-06T23:19:35Z","updated_at":"2016-06-07T06:17:52Z","closed_at":null,"body":"When setting rules to warn (\"1\") any offending lines count as failed tests when running \"ember test\".  I tend to think that warnings should count as passing results when running tests in ember.\r\n\r\nFor me warnings are useful when running linters in text editors, providing suggestions to devs that aren't necessarily enforced, but considered good practice. Their usefulness while running tests in ember is debatable, but it would be nice to at least have the option to count them as passing rather than failing results.\r\n\r\nCurrently, I have to either relax all warning rules to ignore rules to pass tests and deploy my product or fix a couple hundred lines of code that have warnings. Thoughts?"},"comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/comments/224189951","html_url":"https://github.com/ember-cli/ember-cli-eslint/issues/66#issuecomment-224189951","issue_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/66","id":224189951,"user":{"login":"BrianSipple","id":5483853,"avatar_url":"https://avatars.githubusercontent.com/u/5483853?v=3","gravatar_id":"","url":"https://api.github.com/users/BrianSipple","html_url":"https://github.com/BrianSipple","followers_url":"https://api.github.com/users/BrianSipple/followers","following_url":"https://api.github.com/users/BrianSipple/following{/other_user}","gists_url":"https://api.github.com/users/BrianSipple/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianSipple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianSipple/subscriptions","organizations_url":"https://api.github.com/users/BrianSipple/orgs","repos_url":"https://api.github.com/users/BrianSipple/repos","events_url":"https://api.github.com/users/BrianSipple/events{/privacy}","received_events_url":"https://api.github.com/users/BrianSipple/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T06:17:52Z","updated_at":"2016-06-07T06:17:52Z","body":"Full agreement here as well! \r\n\r\nThere's been an [ongoing discussion about this in `broccoli-lint-eslint`](https://github.com/ember-cli/broccoli-lint-eslint/issues/10), and it's possible that we could make refinements across both projects (in the case of `broccoli-lint-eslint`, determining the structure of the `errors` that get sent to the test generator callback). I could definitely look into this in the near future. "}}
{"actor":{"display_login":"BrianSipple"}}