{"action":"created","comment":{"url":"https://api.github.com/repos/foxish/spark/pulls/comments/90075950","pull_request_review_id":10600988,"id":90075950,"diff_hunk":"@@ -0,0 +1,50 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.spark.network.shuffle.kubernetes;\n+\n+import org.apache.spark.network.client.TransportClient;\n+import org.apache.spark.network.sasl.SecretKeyHolder;\n+import org.apache.spark.network.shuffle.ExternalShuffleClient;\n+import org.apache.spark.network.shuffle.protocol.kubernetes.ApplicationComplete;\n+import org.apache.spark.network.util.TransportConf;\n+\n+import java.io.IOException;\n+import java.nio.ByteBuffer;\n+\n+public class KubernetesExternalShuffleClient extends ExternalShuffleClient {","path":"common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/kubernetes/KubernetesExternalShuffleClient.java","position":28,"original_position":28,"commit_id":"f82c70936cd9d0c00f6bf62992dcb77083e4dde5","original_commit_id":"f82c70936cd9d0c00f6bf62992dcb77083e4dde5","user":{"login":"tnachen","id":67244,"avatar_url":"https://avatars.githubusercontent.com/u/67244?v=3","gravatar_id":"","url":"https://api.github.com/users/tnachen","html_url":"https://github.com/tnachen","followers_url":"https://api.github.com/users/tnachen/followers","following_url":"https://api.github.com/users/tnachen/following{/other_user}","gists_url":"https://api.github.com/users/tnachen/gists{/gist_id}","starred_url":"https://api.github.com/users/tnachen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnachen/subscriptions","organizations_url":"https://api.github.com/users/tnachen/orgs","repos_url":"https://api.github.com/users/tnachen/repos","events_url":"https://api.github.com/users/tnachen/events{/privacy}","received_events_url":"https://api.github.com/users/tnachen/received_events","type":"User","site_admin":false},"body":"I understand, however I don't see it being used in this PR. Another PR will use this?","created_at":"2016-11-29T18:38:59Z","updated_at":"2016-11-29T18:38:59Z","html_url":"https://github.com/foxish/spark/pull/7#discussion_r90075950","pull_request_url":"https://api.github.com/repos/foxish/spark/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/foxish/spark/pulls/comments/90075950"},"html":{"href":"https://github.com/foxish/spark/pull/7#discussion_r90075950"},"pull_request":{"href":"https://api.github.com/repos/foxish/spark/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/foxish/spark/pulls/7","id":94736096,"html_url":"https://github.com/foxish/spark/pull/7","diff_url":"https://github.com/foxish/spark/pull/7.diff","patch_url":"https://github.com/foxish/spark/pull/7.patch","issue_url":"https://api.github.com/repos/foxish/spark/issues/7","number":7,"state":"open","locked":false,"title":"Initial Kubernetes cluster manager implementation.","user":{"login":"mccheah","id":8975385,"avatar_url":"https://avatars.githubusercontent.com/u/8975385?v=3","gravatar_id":"","url":"https://api.github.com/users/mccheah","html_url":"https://github.com/mccheah","followers_url":"https://api.github.com/users/mccheah/followers","following_url":"https://api.github.com/users/mccheah/following{/other_user}","gists_url":"https://api.github.com/users/mccheah/gists{/gist_id}","starred_url":"https://api.github.com/users/mccheah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccheah/subscriptions","organizations_url":"https://api.github.com/users/mccheah/orgs","repos_url":"https://api.github.com/users/mccheah/repos","events_url":"https://api.github.com/users/mccheah/events{/privacy}","received_events_url":"https://api.github.com/users/mccheah/received_events","type":"User","site_admin":false},"body":"Includes the following initial feature set:\r\n- Cluster mode with only Scala/Java jobs\r\n- Spark-submit support\r\n- Dynamic allocation\r\n\r\nDoes not include, most notably:\r\n- Client mode support\r\n- Proper testing on both the unit and integration level; integration\r\ntests are flaky","created_at":"2016-11-22T02:17:51Z","updated_at":"2016-11-29T18:38:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5fb160d39308ca0dcaededbfb0fc792e7c8f0bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/foxish/spark/pulls/7/commits","review_comments_url":"https://api.github.com/repos/foxish/spark/pulls/7/comments","review_comment_url":"https://api.github.com/repos/foxish/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/foxish/spark/issues/7/comments","statuses_url":"https://api.github.com/repos/foxish/spark/statuses/f82c70936cd9d0c00f6bf62992dcb77083e4dde5","head":{"label":"foxish:k8s-support-alternate","ref":"k8s-support-alternate","sha":"f82c70936cd9d0c00f6bf62992dcb77083e4dde5","user":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"repo":{"id":67230308,"name":"spark","full_name":"foxish/spark","owner":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/foxish/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/foxish/spark","forks_url":"https://api.github.com/repos/foxish/spark/forks","keys_url":"https://api.github.com/repos/foxish/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foxish/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foxish/spark/teams","hooks_url":"https://api.github.com/repos/foxish/spark/hooks","issue_events_url":"https://api.github.com/repos/foxish/spark/issues/events{/number}","events_url":"https://api.github.com/repos/foxish/spark/events","assignees_url":"https://api.github.com/repos/foxish/spark/assignees{/user}","branches_url":"https://api.github.com/repos/foxish/spark/branches{/branch}","tags_url":"https://api.github.com/repos/foxish/spark/tags","blobs_url":"https://api.github.com/repos/foxish/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foxish/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foxish/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/foxish/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foxish/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/foxish/spark/languages","stargazers_url":"https://api.github.com/repos/foxish/spark/stargazers","contributors_url":"https://api.github.com/repos/foxish/spark/contributors","subscribers_url":"https://api.github.com/repos/foxish/spark/subscribers","subscription_url":"https://api.github.com/repos/foxish/spark/subscription","commits_url":"https://api.github.com/repos/foxish/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/foxish/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/foxish/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/foxish/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/foxish/spark/contents/{+path}","compare_url":"https://api.github.com/repos/foxish/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foxish/spark/merges","archive_url":"https://api.github.com/repos/foxish/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foxish/spark/downloads","issues_url":"https://api.github.com/repos/foxish/spark/issues{/number}","pulls_url":"https://api.github.com/repos/foxish/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/foxish/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/foxish/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foxish/spark/labels{/name}","releases_url":"https://api.github.com/repos/foxish/spark/releases{/id}","deployments_url":"https://api.github.com/repos/foxish/spark/deployments","created_at":"2016-09-02T14:40:35Z","updated_at":"2016-11-04T18:59:34Z","pushed_at":"2016-11-29T02:07:13Z","git_url":"git://github.com/foxish/spark.git","ssh_url":"git@github.com:foxish/spark.git","clone_url":"https://github.com/foxish/spark.git","svn_url":"https://github.com/foxish/spark","homepage":null,"size":250951,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"foxish:master","ref":"master","sha":"97a8239a625df455d2c439f3628a529d6d9413ca","user":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"repo":{"id":67230308,"name":"spark","full_name":"foxish/spark","owner":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/foxish/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/foxish/spark","forks_url":"https://api.github.com/repos/foxish/spark/forks","keys_url":"https://api.github.com/repos/foxish/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foxish/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foxish/spark/teams","hooks_url":"https://api.github.com/repos/foxish/spark/hooks","issue_events_url":"https://api.github.com/repos/foxish/spark/issues/events{/number}","events_url":"https://api.github.com/repos/foxish/spark/events","assignees_url":"https://api.github.com/repos/foxish/spark/assignees{/user}","branches_url":"https://api.github.com/repos/foxish/spark/branches{/branch}","tags_url":"https://api.github.com/repos/foxish/spark/tags","blobs_url":"https://api.github.com/repos/foxish/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foxish/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foxish/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/foxish/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foxish/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/foxish/spark/languages","stargazers_url":"https://api.github.com/repos/foxish/spark/stargazers","contributors_url":"https://api.github.com/repos/foxish/spark/contributors","subscribers_url":"https://api.github.com/repos/foxish/spark/subscribers","subscription_url":"https://api.github.com/repos/foxish/spark/subscription","commits_url":"https://api.github.com/repos/foxish/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/foxish/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/foxish/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/foxish/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/foxish/spark/contents/{+path}","compare_url":"https://api.github.com/repos/foxish/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foxish/spark/merges","archive_url":"https://api.github.com/repos/foxish/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foxish/spark/downloads","issues_url":"https://api.github.com/repos/foxish/spark/issues{/number}","pulls_url":"https://api.github.com/repos/foxish/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/foxish/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/foxish/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foxish/spark/labels{/name}","releases_url":"https://api.github.com/repos/foxish/spark/releases{/id}","deployments_url":"https://api.github.com/repos/foxish/spark/deployments","created_at":"2016-09-02T14:40:35Z","updated_at":"2016-11-04T18:59:34Z","pushed_at":"2016-11-29T02:07:13Z","git_url":"git://github.com/foxish/spark.git","ssh_url":"git@github.com:foxish/spark.git","clone_url":"https://github.com/foxish/spark.git","svn_url":"https://github.com/foxish/spark","homepage":null,"size":250951,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/foxish/spark/pulls/7"},"html":{"href":"https://github.com/foxish/spark/pull/7"},"issue":{"href":"https://api.github.com/repos/foxish/spark/issues/7"},"comments":{"href":"https://api.github.com/repos/foxish/spark/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/foxish/spark/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/foxish/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/foxish/spark/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/foxish/spark/statuses/f82c70936cd9d0c00f6bf62992dcb77083e4dde5"}}}}
{"actor":{"display_login":"tnachen"}}