{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/20491","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/20491/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20491/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/20491/events","html_url":"https://github.com/symfony/symfony/pull/20491","id":188805777,"number":20491,"title":"[POC] [Workflow] Made StateMachine supports only single state marking","user":{"login":"HeahDude","id":10107633,"avatar_url":"https://avatars.githubusercontent.com/u/10107633?v=3","gravatar_id":"","url":"https://api.github.com/users/HeahDude","html_url":"https://github.com/HeahDude","followers_url":"https://api.github.com/users/HeahDude/followers","following_url":"https://api.github.com/users/HeahDude/following{/other_user}","gists_url":"https://api.github.com/users/HeahDude/gists{/gist_id}","starred_url":"https://api.github.com/users/HeahDude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeahDude/subscriptions","organizations_url":"https://api.github.com/users/HeahDude/orgs","repos_url":"https://api.github.com/users/HeahDude/repos","events_url":"https://api.github.com/users/HeahDude/events{/privacy}","received_events_url":"https://api.github.com/users/HeahDude/received_events","type":"User","site_admin":false},"labels":[{"id":238909857,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Work","name":"Status: Needs Work","color":"fad8c7","default":false},{"id":397995968,"url":"https://api.github.com/repos/symfony/symfony/labels/Workflow","name":"Workflow","color":"dddddd","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/10","html_url":"https://github.com/symfony/symfony/milestone/10","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/10/labels","id":2117464,"number":10,"title":"3.x","description":"New features and deprecations go here. Since Symfony versions are time based, this milestone has no due date.","creator":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":148,"closed_issues":25,"state":"open","created_at":"2016-11-06T20:24:23Z","updated_at":"2016-12-13T15:55:47Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2016-11-11T17:06:42Z","updated_at":"2016-12-13T15:55:47Z","closed_at":"2016-12-13T15:55:47Z","pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20491","html_url":"https://github.com/symfony/symfony/pull/20491","diff_url":"https://github.com/symfony/symfony/pull/20491.diff","patch_url":"https://github.com/symfony/symfony/pull/20491.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | yes\r\n| New feature?  | yes\r\n| BC breaks?    | yes\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | https://github.com/symfony/symfony/pull/19629\r\n| License       | MIT\r\n| Doc PR        | TODO\r\n\r\nSince StateMachine cannot be in one place at the time it does not make sense to allow multiple marking. Actually we default to the right SingleStateMarkingStore, but we can't prevent it with any interface.\r\n\r\nThis PR makes `Marking` and `MarkingStore` abstract so any implementation can use the component mechanisms by defining a marking strategy using `Marking` constants in the `MarkingStore` constructor.\r\n\r\nHence we need two marking classes `SingleStateMarking` and `MultipleStateMarking` so every internal piece of the workflow knows how to behave regarding marking.\r\n\r\nAlso we only need one `PropertyAccessMarkingStore` which use the same decency for its logic but can handle both strategies.\r\n\r\nMost of the abstract class are public and can easily be overridden.\r\n\r\nWdyt?"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/266776589","html_url":"https://github.com/symfony/symfony/pull/20491#issuecomment-266776589","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20491","id":266776589,"user":{"login":"lyrixx","id":408368,"avatar_url":"https://avatars.githubusercontent.com/u/408368?v=3","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T15:55:47Z","updated_at":"2016-12-13T15:55:47Z","body":"I'm sorry, but I have to close this PR as the current implementation is too complex\r\n(I have talked with @HeahDude IRL about this PR)"}}
{"actor":{"display_login":"lyrixx"}}