{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/223","repository_url":"https://api.github.com/repos/apache/cordova-plugin-camera","labels_url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/223/labels{/name}","comments_url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/223/comments","events_url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/223/events","html_url":"https://github.com/apache/cordova-plugin-camera/pull/223","id":167606579,"number":223,"title":"CB-11447 Fix Appium camera tests failures","user":{"login":"vladimir-kotikov","id":3857604,"avatar_url":"https://avatars.githubusercontent.com/u/3857604?v=3","gravatar_id":"","url":"https://api.github.com/users/vladimir-kotikov","html_url":"https://github.com/vladimir-kotikov","followers_url":"https://api.github.com/users/vladimir-kotikov/followers","following_url":"https://api.github.com/users/vladimir-kotikov/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-kotikov/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-kotikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-kotikov/subscriptions","organizations_url":"https://api.github.com/users/vladimir-kotikov/orgs","repos_url":"https://api.github.com/users/vladimir-kotikov/repos","events_url":"https://api.github.com/users/vladimir-kotikov/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-kotikov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-26T13:26:41Z","updated_at":"2016-07-26T14:35:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/cordova-plugin-camera/pulls/223","html_url":"https://github.com/apache/cordova-plugin-camera/pull/223","diff_url":"https://github.com/apache/cordova-plugin-camera/pull/223.diff","patch_url":"https://github.com/apache/cordova-plugin-camera/pull/223.patch"},"body":"<!--\r\nPlease make sure the checklist boxes are all checked before submitting the PR. The checklist\r\nis intended as a quick reference, for complete details please see our Contributor Guidelines:\r\n\r\nhttp://cordova.apache.org/contribute/contribute_guidelines.html\r\n\r\nThanks!\r\n-->\r\n\r\n### Platforms affected\r\nAndroid, iOS\r\n\r\n### What does this PR do?\r\nThis PR resolves issues w/ the plugin (and tests), discovered by Appium tests:\r\n\r\n1. on iOS plugin does not modify resultant file (no compression, format change or resizing is performed) when source is PHOTOGALLERY and output is NATIVE_URI. This is not well-documented in README and hadn't been taken into account when tests were being written.\r\n2. On Android when output type is `PNG` and image has been picked from gallery, this results in skipping `jpeg` -> `png` conversion. The output file is saved in `jpeg` format even if file extension might be `.png`.\r\n\r\nAn example of failed tests can be found here: \r\n- For Android: [PLATFORM=android,PLUGIN=cordova-plugin-camera](http://cordova-ci.cloudapp.net:8080/view/Periodic%20builds/job/cordova-periodic-build/PLATFORM=android,PLUGIN=cordova-plugin-camera)\r\n- For iOS: [PLATFORM=ios,PLUGIN=cordova-plugin-camera](http://cordova-ci.cloudapp.net:8080/view/Periodic%20builds/job/cordova-periodic-build/PLATFORM=ios,PLUGIN=cordova-plugin-camera)\r\n\r\n### What testing has been done on this change?\r\nManual tests and automated testing via `cordova-paramedic`\r\n\r\n### Checklist\r\n- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.\r\n- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database\r\n- [x] Commit message follows the format: \"CB-3232: (android) Fix bug with resolving file paths\", where CB-xxxx is the JIRA ID & \"android\" is the platform affected.\r\n- [ ] Added automated test coverage as appropriate for this change.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/comments/235287229","html_url":"https://github.com/apache/cordova-plugin-camera/pull/223#issuecomment-235287229","issue_url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/223","id":235287229,"user":{"login":"cordova-qa","id":19274979,"avatar_url":"https://avatars.githubusercontent.com/u/19274979?v=3","gravatar_id":"","url":"https://api.github.com/users/cordova-qa","html_url":"https://github.com/cordova-qa","followers_url":"https://api.github.com/users/cordova-qa/followers","following_url":"https://api.github.com/users/cordova-qa/following{/other_user}","gists_url":"https://api.github.com/users/cordova-qa/gists{/gist_id}","starred_url":"https://api.github.com/users/cordova-qa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cordova-qa/subscriptions","organizations_url":"https://api.github.com/users/cordova-qa/orgs","repos_url":"https://api.github.com/users/cordova-qa/repos","events_url":"https://api.github.com/users/cordova-qa/events{/privacy}","received_events_url":"https://api.github.com/users/cordova-qa/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T14:35:28Z","updated_at":"2016-07-26T14:35:28Z","body":"Cordova CI Build has one or more failures. \n\n**Commit**     - [Link](https://github.com/apache/cordova-plugin-camera/pull/223/commits/fed798e6c7f56e23bff994ab2c11d316c8257a78)\n**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45/)\n\n| Builder Name  | Console Output | Test Report | Device Logs  |\n|     :---:     |     :---:      |   :---:     |     :---:    |\n| [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-8.1-store/artifact/) |\n| [Windows 10  Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-10-store/artifact/) |\n| [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=windows-8.1-phone/artifact/) |\n| [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=ios/artifact/) |\n| [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/45//PLATFORM=android/artifact/) |\n \n"}}
{"actor":{"display_login":"cordova-qa"}}