{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments/61286203","id":61286203,"diff_hunk":"@@ -1262,30 +1265,42 @@\n             <a href=\"#widl-RTCIceCandidate-sdpMid\">sdpMid</a></code> and <code>\n             <a href=\n             \"#widl-RTCIceCandidate-sdpMLineIndex\">sdpMLineIndex</a></code>; the\n-            rest are ignored.</p>\n+            rest are ignored. When the method is invoked, the User Agent MUST\n+            run the following steps:</p>\n \n             <ol>\n               <li>\n-                <p>Let <var>connection</var> be the <code>\n-                <a>RTCPeerConnection</a></code> object on which the method was\n-                invoked.</p>\n+                <p>Let <var>candidate</var> be the methods argument.</p>\n               </li>\n \n               <li>\n-                <p>If <var>connection</var>'s [[<a>isClosed</a>]] slot is\n-                <code>true</code>, return a promise rejected with an\n-                <code>InvalidStateError</code>.</p>\n+                <p>If <var>candidate</var> is not <code>null</code> but is\n+                missing values for both <var>sdpMid</var> and\n+                <var>sdpMLineIndex</var>, return a promise rejected with a\n+                <code>TypeError</code>.</p>\n               </li>\n \n               <li>\n-                <p>Let <var>candidate</var> be the methods argument.</p>\n+                <p>Return the result of <a href=\n+                \"#enqueue-an-operation\">queuing</a> <a>addIceCandidate's queued\n+                steps</a>.</p>\n               </li>\n+            </ol>\n+\n+            <p>The following steps defines <dfn>addIceCandidate's queued\n+            steps</dfn>:</p>\n \n+            <ol>\n               <li>\n-                <p>If <var>candidate</var> is not <code>null</code> but is\n-                missing values for both <var>sdpMid</var> and\n-                <var>sdpMLineIndex</var>, return a promise rejected with a\n-                <code>TypeError</code>.</p>\n+                <p>Let <var>connection</var> be the <code>\n+                <a>RTCPeerConnection</a></code> object on which the method was\n+                invoked.</p>","path":"webrtc.html","position":135,"original_position":135,"commit_id":"03f6bb5dfa94410f7ef70b8d2eaa535ff3f4ef6b","original_commit_id":"03f6bb5dfa94410f7ef70b8d2eaa535ff3f4ef6b","user":{"login":"jan-ivar","id":3136226,"avatar_url":"https://avatars.githubusercontent.com/u/3136226?v=3","gravatar_id":"","url":"https://api.github.com/users/jan-ivar","html_url":"https://github.com/jan-ivar","followers_url":"https://api.github.com/users/jan-ivar/followers","following_url":"https://api.github.com/users/jan-ivar/following{/other_user}","gists_url":"https://api.github.com/users/jan-ivar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-ivar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-ivar/subscriptions","organizations_url":"https://api.github.com/users/jan-ivar/orgs","repos_url":"https://api.github.com/users/jan-ivar/repos","events_url":"https://api.github.com/users/jan-ivar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-ivar/received_events","type":"User","site_admin":false},"body":"I think it would make sense to move this step out of the enqueued steps, to the steps above, to be next to `candidate` and the others. Otherwise the context for this text seems wrong.","created_at":"2016-04-27T16:02:49Z","updated_at":"2016-04-27T16:02:49Z","html_url":"https://github.com/w3c/webrtc-pc/pull/601#discussion_r61286203","pull_request_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/601","_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments/61286203"},"html":{"href":"https://github.com/w3c/webrtc-pc/pull/601#discussion_r61286203"},"pull_request":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/601"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/601","id":68071029,"html_url":"https://github.com/w3c/webrtc-pc/pull/601","diff_url":"https://github.com/w3c/webrtc-pc/pull/601.diff","patch_url":"https://github.com/w3c/webrtc-pc/pull/601.patch","issue_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/601","number":601,"state":"open","locked":false,"title":"Specify the synchronous and queued steps for addIceCandidate (issue #600)","user":{"login":"adam-be","id":1233205,"avatar_url":"https://avatars.githubusercontent.com/u/1233205?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-be","html_url":"https://github.com/adam-be","followers_url":"https://api.github.com/users/adam-be/followers","following_url":"https://api.github.com/users/adam-be/following{/other_user}","gists_url":"https://api.github.com/users/adam-be/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-be/subscriptions","organizations_url":"https://api.github.com/users/adam-be/orgs","repos_url":"https://api.github.com/users/adam-be/repos","events_url":"https://api.github.com/users/adam-be/events{/privacy}","received_events_url":"https://api.github.com/users/adam-be/received_events","type":"User","site_admin":false},"body":"This PR is only for reviewing since it doesn't update all queued operations; only addIceCandidate.\r\n\r\nIssue #600","created_at":"2016-04-27T15:13:42Z","updated_at":"2016-04-27T16:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5862585f40e5c8fe3b8da76da9862a89045985b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/601/commits","review_comments_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/601/comments","review_comment_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/601/comments","statuses_url":"https://api.github.com/repos/w3c/webrtc-pc/statuses/03f6bb5dfa94410f7ef70b8d2eaa535ff3f4ef6b","head":{"label":"adam-be:queued-operations-sync","ref":"queued-operations-sync","sha":"03f6bb5dfa94410f7ef70b8d2eaa535ff3f4ef6b","user":{"login":"adam-be","id":1233205,"avatar_url":"https://avatars.githubusercontent.com/u/1233205?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-be","html_url":"https://github.com/adam-be","followers_url":"https://api.github.com/users/adam-be/followers","following_url":"https://api.github.com/users/adam-be/following{/other_user}","gists_url":"https://api.github.com/users/adam-be/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-be/subscriptions","organizations_url":"https://api.github.com/users/adam-be/orgs","repos_url":"https://api.github.com/users/adam-be/repos","events_url":"https://api.github.com/users/adam-be/events{/privacy}","received_events_url":"https://api.github.com/users/adam-be/received_events","type":"User","site_admin":false},"repo":{"id":25730074,"name":"webrtc-pc","full_name":"adam-be/webrtc-pc","owner":{"login":"adam-be","id":1233205,"avatar_url":"https://avatars.githubusercontent.com/u/1233205?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-be","html_url":"https://github.com/adam-be","followers_url":"https://api.github.com/users/adam-be/followers","following_url":"https://api.github.com/users/adam-be/following{/other_user}","gists_url":"https://api.github.com/users/adam-be/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-be/subscriptions","organizations_url":"https://api.github.com/users/adam-be/orgs","repos_url":"https://api.github.com/users/adam-be/repos","events_url":"https://api.github.com/users/adam-be/events{/privacy}","received_events_url":"https://api.github.com/users/adam-be/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adam-be/webrtc-pc","description":"WebRTC 1.0 API","fork":true,"url":"https://api.github.com/repos/adam-be/webrtc-pc","forks_url":"https://api.github.com/repos/adam-be/webrtc-pc/forks","keys_url":"https://api.github.com/repos/adam-be/webrtc-pc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adam-be/webrtc-pc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adam-be/webrtc-pc/teams","hooks_url":"https://api.github.com/repos/adam-be/webrtc-pc/hooks","issue_events_url":"https://api.github.com/repos/adam-be/webrtc-pc/issues/events{/number}","events_url":"https://api.github.com/repos/adam-be/webrtc-pc/events","assignees_url":"https://api.github.com/repos/adam-be/webrtc-pc/assignees{/user}","branches_url":"https://api.github.com/repos/adam-be/webrtc-pc/branches{/branch}","tags_url":"https://api.github.com/repos/adam-be/webrtc-pc/tags","blobs_url":"https://api.github.com/repos/adam-be/webrtc-pc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adam-be/webrtc-pc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adam-be/webrtc-pc/git/refs{/sha}","trees_url":"https://api.github.com/repos/adam-be/webrtc-pc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adam-be/webrtc-pc/statuses/{sha}","languages_url":"https://api.github.com/repos/adam-be/webrtc-pc/languages","stargazers_url":"https://api.github.com/repos/adam-be/webrtc-pc/stargazers","contributors_url":"https://api.github.com/repos/adam-be/webrtc-pc/contributors","subscribers_url":"https://api.github.com/repos/adam-be/webrtc-pc/subscribers","subscription_url":"https://api.github.com/repos/adam-be/webrtc-pc/subscription","commits_url":"https://api.github.com/repos/adam-be/webrtc-pc/commits{/sha}","git_commits_url":"https://api.github.com/repos/adam-be/webrtc-pc/git/commits{/sha}","comments_url":"https://api.github.com/repos/adam-be/webrtc-pc/comments{/number}","issue_comment_url":"https://api.github.com/repos/adam-be/webrtc-pc/issues/comments{/number}","contents_url":"https://api.github.com/repos/adam-be/webrtc-pc/contents/{+path}","compare_url":"https://api.github.com/repos/adam-be/webrtc-pc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adam-be/webrtc-pc/merges","archive_url":"https://api.github.com/repos/adam-be/webrtc-pc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adam-be/webrtc-pc/downloads","issues_url":"https://api.github.com/repos/adam-be/webrtc-pc/issues{/number}","pulls_url":"https://api.github.com/repos/adam-be/webrtc-pc/pulls{/number}","milestones_url":"https://api.github.com/repos/adam-be/webrtc-pc/milestones{/number}","notifications_url":"https://api.github.com/repos/adam-be/webrtc-pc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adam-be/webrtc-pc/labels{/name}","releases_url":"https://api.github.com/repos/adam-be/webrtc-pc/releases{/id}","deployments_url":"https://api.github.com/repos/adam-be/webrtc-pc/deployments","created_at":"2014-10-25T12:03:40Z","updated_at":"2014-10-07T10:20:34Z","pushed_at":"2016-04-27T15:10:17Z","git_url":"git://github.com/adam-be/webrtc-pc.git","ssh_url":"git@github.com:adam-be/webrtc-pc.git","clone_url":"https://github.com/adam-be/webrtc-pc.git","svn_url":"https://github.com/adam-be/webrtc-pc","homepage":null,"size":15411,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"9b9a6f7d6043c8992abd84d1fbbe3757de07a564","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":23384500,"name":"webrtc-pc","full_name":"w3c/webrtc-pc","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/webrtc-pc","description":"WebRTC 1.0 API","fork":false,"url":"https://api.github.com/repos/w3c/webrtc-pc","forks_url":"https://api.github.com/repos/w3c/webrtc-pc/forks","keys_url":"https://api.github.com/repos/w3c/webrtc-pc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webrtc-pc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webrtc-pc/teams","hooks_url":"https://api.github.com/repos/w3c/webrtc-pc/hooks","issue_events_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webrtc-pc/events","assignees_url":"https://api.github.com/repos/w3c/webrtc-pc/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webrtc-pc/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webrtc-pc/tags","blobs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webrtc-pc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webrtc-pc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webrtc-pc/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webrtc-pc/languages","stargazers_url":"https://api.github.com/repos/w3c/webrtc-pc/stargazers","contributors_url":"https://api.github.com/repos/w3c/webrtc-pc/contributors","subscribers_url":"https://api.github.com/repos/w3c/webrtc-pc/subscribers","subscription_url":"https://api.github.com/repos/w3c/webrtc-pc/subscription","commits_url":"https://api.github.com/repos/w3c/webrtc-pc/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webrtc-pc/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webrtc-pc/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webrtc-pc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webrtc-pc/merges","archive_url":"https://api.github.com/repos/w3c/webrtc-pc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webrtc-pc/downloads","issues_url":"https://api.github.com/repos/w3c/webrtc-pc/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webrtc-pc/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webrtc-pc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webrtc-pc/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webrtc-pc/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/webrtc-pc/deployments","created_at":"2014-08-27T09:39:00Z","updated_at":"2016-04-26T04:50:39Z","pushed_at":"2016-04-27T15:13:42Z","git_url":"git://github.com/w3c/webrtc-pc.git","ssh_url":"git@github.com:w3c/webrtc-pc.git","clone_url":"https://github.com/w3c/webrtc-pc.git","svn_url":"https://github.com/w3c/webrtc-pc","homepage":null,"size":16888,"stargazers_count":81,"watchers_count":81,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":45,"forks":39,"open_issues":45,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/601"},"html":{"href":"https://github.com/w3c/webrtc-pc/pull/601"},"issue":{"href":"https://api.github.com/repos/w3c/webrtc-pc/issues/601"},"comments":{"href":"https://api.github.com/repos/w3c/webrtc-pc/issues/601/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/601/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/601/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/webrtc-pc/statuses/03f6bb5dfa94410f7ef70b8d2eaa535ff3f4ef6b"}}}}