{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7048","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7048/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7048/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7048/events","html_url":"https://github.com/nodejs/node/pull/7048","id":157382715,"number":7048,"title":"Backporting Async Wrap changes","user":{"login":"AndreasMadsen","id":505333,"avatar_url":"https://avatars.githubusercontent.com/u/505333?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreasMadsen","html_url":"https://github.com/AndreasMadsen","followers_url":"https://api.github.com/users/AndreasMadsen/followers","following_url":"https://api.github.com/users/AndreasMadsen/following{/other_user}","gists_url":"https://api.github.com/users/AndreasMadsen/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasMadsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasMadsen/subscriptions","organizations_url":"https://api.github.com/users/AndreasMadsen/orgs","repos_url":"https://api.github.com/users/AndreasMadsen/repos","events_url":"https://api.github.com/users/AndreasMadsen/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasMadsen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/async_wrap","name":"async_wrap","color":"fbca04"},{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v4.x","name":"lts-watch-v4.x","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/v4.x","name":"v4.x","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2016-05-29T11:54:20Z","updated_at":"2016-06-07T19:18:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7048","html_url":"https://github.com/nodejs/node/pull/7048","diff_url":"https://github.com/nodejs/node/pull/7048.diff","patch_url":"https://github.com/nodejs/node/pull/7048.patch"},"body":"##### Checklist\r\n\r\n- [x] tests and code linting passes\r\n- [x] a test and/or benchmark is included\r\n- [x] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nsrc, http, http_parser, test, async_wrap\r\n\r\n##### Description of change\r\n\r\nAsync Wrap in 4.x is very far behind and it creates a lot of issues, see the issue references in https://github.com/nodejs/LTS/issues/86. I recall in some discussion (I can't find it) that this shouldn't be straight forward, however it was actually really easy and all the tests passes. Am I missing something?\r\n\r\nThis backports the following changes:\r\n\r\n1. https://github.com/nodejs/node/pull/4507 - src: fix MakeCallback error handling\r\n2. https://github.com/nodejs/node/commit/b72dbdbe430ef83c73cf535bc0dabdba2a64b352 from  nodejs/node#5233 - src: remove unnecessary check\r\n3. https://github.com/nodejs/node/pull/4600 - async_wrap: add uid argument to all asyncWrap hooks\r\n4. https://github.com/nodejs/node/pull/5419 - http_parser: use `MakeCallback`\r\n5. https://github.com/nodejs/node/pull/5591 - src,http: fix uncaughtException miss in http\r\n6. https://github.com/nodejs/node/pull/5756 - Asyncwrap more\r\n\r\n/cc @TheAlphaNerd @trevnorris "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/224385401","html_url":"https://github.com/nodejs/node/pull/7048#issuecomment-224385401","issue_url":"https://api.github.com/repos/nodejs/node/issues/7048","id":224385401,"user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T19:18:01Z","updated_at":"2016-06-07T19:18:01Z","body":"CI is all green. Land it!"}}
{"actor":{"display_login":"trevnorris"}}