{"action":"created","comment":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments/65645899","id":65645899,"diff_hunk":"@@ -182,6 +182,17 @@ def app_options\n       # currently, all levels are Blockly or DSLDefined except for Unplugged\n       @app_options = view_options.camelize_keys\n     end\n+\n+    @app_options[:dialog] = {\n+      skipSound: !!(@level.properties['options'].try(:[], 'skip_sound')),\n+      preTitle: @level.properties['pre_title'],\n+      fallbackResponse: @fallback_response.to_json,\n+      callback: @callback,\n+      app: @level.type.underscore,","path":"dashboard/app/helpers/levels_helper.rb","position":10,"original_position":10,"commit_id":"a71d787d9a25838e542820f02260d8fb0716e76a","original_commit_id":"a71d787d9a25838e542820f02260d8fb0716e76a","user":{"login":"balderdash","id":1070243,"avatar_url":"https://avatars.githubusercontent.com/u/1070243?v=3","gravatar_id":"","url":"https://api.github.com/users/balderdash","html_url":"https://github.com/balderdash","followers_url":"https://api.github.com/users/balderdash/followers","following_url":"https://api.github.com/users/balderdash/following{/other_user}","gists_url":"https://api.github.com/users/balderdash/gists{/gist_id}","starred_url":"https://api.github.com/users/balderdash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balderdash/subscriptions","organizations_url":"https://api.github.com/users/balderdash/orgs","repos_url":"https://api.github.com/users/balderdash/repos","events_url":"https://api.github.com/users/balderdash/events{/privacy}","received_events_url":"https://api.github.com/users/balderdash/received_events","type":"User","site_admin":false},"body":"Ok. so there's another set of app names defined in the various <app>.js files under apps/src/... when they fire their own milestone posts, that's where turtle, Jigsaw, and most of the rest of the names actually come from.\r\n\r\nThe app name I'm setting above is only actually used for milestone posts coming from external, multi, match, free response, and levelgroup levels.","created_at":"2016-06-03T01:31:01Z","updated_at":"2016-06-03T01:31:01Z","html_url":"https://github.com/code-dot-org/code-dot-org/pull/8727#discussion_r65645899","pull_request_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/8727","_links":{"self":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments/65645899"},"html":{"href":"https://github.com/code-dot-org/code-dot-org/pull/8727#discussion_r65645899"},"pull_request":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/8727"}}},"pull_request":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/8727","id":72407712,"html_url":"https://github.com/code-dot-org/code-dot-org/pull/8727","diff_url":"https://github.com/code-dot-org/code-dot-org/pull/8727.diff","patch_url":"https://github.com/code-dot-org/code-dot-org/pull/8727.patch","issue_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/8727","number":8727,"state":"open","locked":false,"title":"Set appOptions.dialog in helper instead of view","user":{"login":"balderdash","id":1070243,"avatar_url":"https://avatars.githubusercontent.com/u/1070243?v=3","gravatar_id":"","url":"https://api.github.com/users/balderdash","html_url":"https://github.com/balderdash","followers_url":"https://api.github.com/users/balderdash/followers","following_url":"https://api.github.com/users/balderdash/following{/other_user}","gists_url":"https://api.github.com/users/balderdash/gists{/gist_id}","starred_url":"https://api.github.com/users/balderdash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balderdash/subscriptions","organizations_url":"https://api.github.com/users/balderdash/orgs","repos_url":"https://api.github.com/users/balderdash/repos","events_url":"https://api.github.com/users/balderdash/events{/privacy}","received_events_url":"https://api.github.com/users/balderdash/received_events","type":"User","site_admin":false},"body":"appOptions.dialog.autoResizeScrollableElement is never set to anything else, so I just hardcoded '.scrollable-element' in dialogHelper.js and moved the rest to levels_helper.rb.\r\n\r\nMoving everything into one place makes it easier to generate multiple versions of appOptions to support CYOA.","created_at":"2016-06-02T19:58:35Z","updated_at":"2016-06-03T01:31:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e237c50972b66c5233e5942b2ebafd99fb7c334","assignee":{"login":"Hamms","id":244100,"avatar_url":"https://avatars.githubusercontent.com/u/244100?v=3","gravatar_id":"","url":"https://api.github.com/users/Hamms","html_url":"https://github.com/Hamms","followers_url":"https://api.github.com/users/Hamms/followers","following_url":"https://api.github.com/users/Hamms/following{/other_user}","gists_url":"https://api.github.com/users/Hamms/gists{/gist_id}","starred_url":"https://api.github.com/users/Hamms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hamms/subscriptions","organizations_url":"https://api.github.com/users/Hamms/orgs","repos_url":"https://api.github.com/users/Hamms/repos","events_url":"https://api.github.com/users/Hamms/events{/privacy}","received_events_url":"https://api.github.com/users/Hamms/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/8727/commits","review_comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/8727/comments","review_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/8727/comments","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/a71d787d9a25838e542820f02260d8fb0716e76a","head":{"label":"code-dot-org:move-dialog-options","ref":"move-dialog-options","sha":"a71d787d9a25838e542820f02260d8fb0716e76a","user":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24250009,"name":"code-dot-org","full_name":"code-dot-org/code-dot-org","owner":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-dot-org/code-dot-org","description":"The code powering code.org and studio.code.org","fork":false,"url":"https://api.github.com/repos/code-dot-org/code-dot-org","forks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/forks","keys_url":"https://api.github.com/repos/code-dot-org/code-dot-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-dot-org/code-dot-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-dot-org/code-dot-org/teams","hooks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/hooks","issue_events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/events{/number}","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/events","assignees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/assignees{/user}","branches_url":"https://api.github.com/repos/code-dot-org/code-dot-org/branches{/branch}","tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/tags","blobs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/{sha}","languages_url":"https://api.github.com/repos/code-dot-org/code-dot-org/languages","stargazers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/stargazers","contributors_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contributors","subscribers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscribers","subscription_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscription","commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contents/{+path}","compare_url":"https://api.github.com/repos/code-dot-org/code-dot-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-dot-org/code-dot-org/merges","archive_url":"https://api.github.com/repos/code-dot-org/code-dot-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-dot-org/code-dot-org/downloads","issues_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues{/number}","pulls_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls{/number}","milestones_url":"https://api.github.com/repos/code-dot-org/code-dot-org/milestones{/number}","notifications_url":"https://api.github.com/repos/code-dot-org/code-dot-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels{/name}","releases_url":"https://api.github.com/repos/code-dot-org/code-dot-org/releases{/id}","deployments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/deployments","created_at":"2014-09-20T00:46:11Z","updated_at":"2016-05-30T09:44:27Z","pushed_at":"2016-06-03T01:29:21Z","git_url":"git://github.com/code-dot-org/code-dot-org.git","ssh_url":"git@github.com:code-dot-org/code-dot-org.git","clone_url":"https://github.com/code-dot-org/code-dot-org.git","svn_url":"https://github.com/code-dot-org/code-dot-org","homepage":"http://code.org","size":4723811,"stargazers_count":119,"watchers_count":119,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":43,"forks":70,"open_issues":43,"watchers":119,"default_branch":"staging"}},"base":{"label":"code-dot-org:staging","ref":"staging","sha":"abc4c96b3a49d791183be8bba7ca4687879b0922","user":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24250009,"name":"code-dot-org","full_name":"code-dot-org/code-dot-org","owner":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-dot-org/code-dot-org","description":"The code powering code.org and studio.code.org","fork":false,"url":"https://api.github.com/repos/code-dot-org/code-dot-org","forks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/forks","keys_url":"https://api.github.com/repos/code-dot-org/code-dot-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-dot-org/code-dot-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-dot-org/code-dot-org/teams","hooks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/hooks","issue_events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/events{/number}","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/events","assignees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/assignees{/user}","branches_url":"https://api.github.com/repos/code-dot-org/code-dot-org/branches{/branch}","tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/tags","blobs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/{sha}","languages_url":"https://api.github.com/repos/code-dot-org/code-dot-org/languages","stargazers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/stargazers","contributors_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contributors","subscribers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscribers","subscription_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscription","commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contents/{+path}","compare_url":"https://api.github.com/repos/code-dot-org/code-dot-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-dot-org/code-dot-org/merges","archive_url":"https://api.github.com/repos/code-dot-org/code-dot-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-dot-org/code-dot-org/downloads","issues_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues{/number}","pulls_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls{/number}","milestones_url":"https://api.github.com/repos/code-dot-org/code-dot-org/milestones{/number}","notifications_url":"https://api.github.com/repos/code-dot-org/code-dot-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels{/name}","releases_url":"https://api.github.com/repos/code-dot-org/code-dot-org/releases{/id}","deployments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/deployments","created_at":"2014-09-20T00:46:11Z","updated_at":"2016-05-30T09:44:27Z","pushed_at":"2016-06-03T01:29:21Z","git_url":"git://github.com/code-dot-org/code-dot-org.git","ssh_url":"git@github.com:code-dot-org/code-dot-org.git","clone_url":"https://github.com/code-dot-org/code-dot-org.git","svn_url":"https://github.com/code-dot-org/code-dot-org","homepage":"http://code.org","size":4723811,"stargazers_count":119,"watchers_count":119,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":43,"forks":70,"open_issues":43,"watchers":119,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/8727"},"html":{"href":"https://github.com/code-dot-org/code-dot-org/pull/8727"},"issue":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/8727"},"comments":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/8727/comments"},"review_comments":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/8727/comments"},"review_comment":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/8727/commits"},"statuses":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/a71d787d9a25838e542820f02260d8fb0716e76a"}}}}
{"actor":{"display_login":"balderdash"}}