{"action":"closed","number":1208,"pull_request":{"url":"https://api.github.com/repos/osmandapp/Osmand/pulls/1208","id":35170000,"html_url":"https://github.com/osmandapp/Osmand/pull/1208","diff_url":"https://github.com/osmandapp/Osmand/pull/1208.diff","patch_url":"https://github.com/osmandapp/Osmand/pull/1208.patch","issue_url":"https://api.github.com/repos/osmandapp/Osmand/issues/1208","number":1208,"state":"closed","locked":false,"title":"tighten parseLength() again","user":{"login":"aceman444","id":6699462,"avatar_url":"https://avatars.githubusercontent.com/u/6699462?v=3","gravatar_id":"","url":"https://api.github.com/users/aceman444","html_url":"https://github.com/aceman444","followers_url":"https://api.github.com/users/aceman444/followers","following_url":"https://api.github.com/users/aceman444/following{/other_user}","gists_url":"https://api.github.com/users/aceman444/gists{/gist_id}","starred_url":"https://api.github.com/users/aceman444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceman444/subscriptions","organizations_url":"https://api.github.com/users/aceman444/orgs","repos_url":"https://api.github.com/users/aceman444/repos","events_url":"https://api.github.com/users/aceman444/events{/privacy}","received_events_url":"https://api.github.com/users/aceman444/received_events","type":"User","site_admin":false},"body":"I wonder what the test for \"-\" does. There can't be any negative values in maxlength or maxheight.\r\nIt seems your version also accepts values like \"1 km 1 km\" (meaning 2km) which is invalid per the wiki, but probably shouldn't harm. I'm fine with that. But I think it also accepted \"1 mile\" and thinking it was 1meter. You can't just test unit.contains(\"m\") as that would also match \"mile\", \"cm\", etc. That is not good so I tightened it a bit.\r\n\r\nSo I haven't compiled this again, please tell me if all the tests pass.","created_at":"2015-05-11T21:11:35Z","updated_at":"2016-06-13T22:40:36Z","closed_at":"2016-06-13T22:40:36Z","merged_at":null,"merge_commit_sha":"ccc366cc0bad9d5b8a09180f1838e5f7fd8bdbfc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/osmandapp/Osmand/pulls/1208/commits","review_comments_url":"https://api.github.com/repos/osmandapp/Osmand/pulls/1208/comments","review_comment_url":"https://api.github.com/repos/osmandapp/Osmand/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osmandapp/Osmand/issues/1208/comments","statuses_url":"https://api.github.com/repos/osmandapp/Osmand/statuses/27d080e98fcda4783351933ae403fa0939e30fd7","head":{"label":"aceman444:patch-1","ref":"patch-1","sha":"27d080e98fcda4783351933ae403fa0939e30fd7","user":{"login":"aceman444","id":6699462,"avatar_url":"https://avatars.githubusercontent.com/u/6699462?v=3","gravatar_id":"","url":"https://api.github.com/users/aceman444","html_url":"https://github.com/aceman444","followers_url":"https://api.github.com/users/aceman444/followers","following_url":"https://api.github.com/users/aceman444/following{/other_user}","gists_url":"https://api.github.com/users/aceman444/gists{/gist_id}","starred_url":"https://api.github.com/users/aceman444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceman444/subscriptions","organizations_url":"https://api.github.com/users/aceman444/orgs","repos_url":"https://api.github.com/users/aceman444/repos","events_url":"https://api.github.com/users/aceman444/events{/privacy}","received_events_url":"https://api.github.com/users/aceman444/received_events","type":"User","site_admin":false},"repo":{"id":20495906,"name":"Osmand","full_name":"aceman444/Osmand","owner":{"login":"aceman444","id":6699462,"avatar_url":"https://avatars.githubusercontent.com/u/6699462?v=3","gravatar_id":"","url":"https://api.github.com/users/aceman444","html_url":"https://github.com/aceman444","followers_url":"https://api.github.com/users/aceman444/followers","following_url":"https://api.github.com/users/aceman444/following{/other_user}","gists_url":"https://api.github.com/users/aceman444/gists{/gist_id}","starred_url":"https://api.github.com/users/aceman444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceman444/subscriptions","organizations_url":"https://api.github.com/users/aceman444/orgs","repos_url":"https://api.github.com/users/aceman444/repos","events_url":"https://api.github.com/users/aceman444/events{/privacy}","received_events_url":"https://api.github.com/users/aceman444/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aceman444/Osmand","description":"osmand","fork":true,"url":"https://api.github.com/repos/aceman444/Osmand","forks_url":"https://api.github.com/repos/aceman444/Osmand/forks","keys_url":"https://api.github.com/repos/aceman444/Osmand/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aceman444/Osmand/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aceman444/Osmand/teams","hooks_url":"https://api.github.com/repos/aceman444/Osmand/hooks","issue_events_url":"https://api.github.com/repos/aceman444/Osmand/issues/events{/number}","events_url":"https://api.github.com/repos/aceman444/Osmand/events","assignees_url":"https://api.github.com/repos/aceman444/Osmand/assignees{/user}","branches_url":"https://api.github.com/repos/aceman444/Osmand/branches{/branch}","tags_url":"https://api.github.com/repos/aceman444/Osmand/tags","blobs_url":"https://api.github.com/repos/aceman444/Osmand/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aceman444/Osmand/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aceman444/Osmand/git/refs{/sha}","trees_url":"https://api.github.com/repos/aceman444/Osmand/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aceman444/Osmand/statuses/{sha}","languages_url":"https://api.github.com/repos/aceman444/Osmand/languages","stargazers_url":"https://api.github.com/repos/aceman444/Osmand/stargazers","contributors_url":"https://api.github.com/repos/aceman444/Osmand/contributors","subscribers_url":"https://api.github.com/repos/aceman444/Osmand/subscribers","subscription_url":"https://api.github.com/repos/aceman444/Osmand/subscription","commits_url":"https://api.github.com/repos/aceman444/Osmand/commits{/sha}","git_commits_url":"https://api.github.com/repos/aceman444/Osmand/git/commits{/sha}","comments_url":"https://api.github.com/repos/aceman444/Osmand/comments{/number}","issue_comment_url":"https://api.github.com/repos/aceman444/Osmand/issues/comments{/number}","contents_url":"https://api.github.com/repos/aceman444/Osmand/contents/{+path}","compare_url":"https://api.github.com/repos/aceman444/Osmand/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aceman444/Osmand/merges","archive_url":"https://api.github.com/repos/aceman444/Osmand/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aceman444/Osmand/downloads","issues_url":"https://api.github.com/repos/aceman444/Osmand/issues{/number}","pulls_url":"https://api.github.com/repos/aceman444/Osmand/pulls{/number}","milestones_url":"https://api.github.com/repos/aceman444/Osmand/milestones{/number}","notifications_url":"https://api.github.com/repos/aceman444/Osmand/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aceman444/Osmand/labels{/name}","releases_url":"https://api.github.com/repos/aceman444/Osmand/releases{/id}","deployments_url":"https://api.github.com/repos/aceman444/Osmand/deployments","created_at":"2014-06-04T18:59:08Z","updated_at":"2014-08-20T20:02:37Z","pushed_at":"2016-02-22T10:54:49Z","git_url":"git://github.com/aceman444/Osmand.git","ssh_url":"git@github.com:aceman444/Osmand.git","clone_url":"https://github.com/aceman444/Osmand.git","svn_url":"https://github.com/aceman444/Osmand","homepage":"osmand.net","size":239628,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"osmandapp:master","ref":"master","sha":"7f72ed8375235a9f7f379e0c6d2849446fb784c2","user":{"login":"osmandapp","id":566635,"avatar_url":"https://avatars.githubusercontent.com/u/566635?v=3","gravatar_id":"","url":"https://api.github.com/users/osmandapp","html_url":"https://github.com/osmandapp","followers_url":"https://api.github.com/users/osmandapp/followers","following_url":"https://api.github.com/users/osmandapp/following{/other_user}","gists_url":"https://api.github.com/users/osmandapp/gists{/gist_id}","starred_url":"https://api.github.com/users/osmandapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmandapp/subscriptions","organizations_url":"https://api.github.com/users/osmandapp/orgs","repos_url":"https://api.github.com/users/osmandapp/repos","events_url":"https://api.github.com/users/osmandapp/events{/privacy}","received_events_url":"https://api.github.com/users/osmandapp/received_events","type":"Organization","site_admin":false},"repo":{"id":1258570,"name":"Osmand","full_name":"osmandapp/Osmand","owner":{"login":"osmandapp","id":566635,"avatar_url":"https://avatars.githubusercontent.com/u/566635?v=3","gravatar_id":"","url":"https://api.github.com/users/osmandapp","html_url":"https://github.com/osmandapp","followers_url":"https://api.github.com/users/osmandapp/followers","following_url":"https://api.github.com/users/osmandapp/following{/other_user}","gists_url":"https://api.github.com/users/osmandapp/gists{/gist_id}","starred_url":"https://api.github.com/users/osmandapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmandapp/subscriptions","organizations_url":"https://api.github.com/users/osmandapp/orgs","repos_url":"https://api.github.com/users/osmandapp/repos","events_url":"https://api.github.com/users/osmandapp/events{/privacy}","received_events_url":"https://api.github.com/users/osmandapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osmandapp/Osmand","description":"osmand","fork":false,"url":"https://api.github.com/repos/osmandapp/Osmand","forks_url":"https://api.github.com/repos/osmandapp/Osmand/forks","keys_url":"https://api.github.com/repos/osmandapp/Osmand/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osmandapp/Osmand/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osmandapp/Osmand/teams","hooks_url":"https://api.github.com/repos/osmandapp/Osmand/hooks","issue_events_url":"https://api.github.com/repos/osmandapp/Osmand/issues/events{/number}","events_url":"https://api.github.com/repos/osmandapp/Osmand/events","assignees_url":"https://api.github.com/repos/osmandapp/Osmand/assignees{/user}","branches_url":"https://api.github.com/repos/osmandapp/Osmand/branches{/branch}","tags_url":"https://api.github.com/repos/osmandapp/Osmand/tags","blobs_url":"https://api.github.com/repos/osmandapp/Osmand/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osmandapp/Osmand/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osmandapp/Osmand/git/refs{/sha}","trees_url":"https://api.github.com/repos/osmandapp/Osmand/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osmandapp/Osmand/statuses/{sha}","languages_url":"https://api.github.com/repos/osmandapp/Osmand/languages","stargazers_url":"https://api.github.com/repos/osmandapp/Osmand/stargazers","contributors_url":"https://api.github.com/repos/osmandapp/Osmand/contributors","subscribers_url":"https://api.github.com/repos/osmandapp/Osmand/subscribers","subscription_url":"https://api.github.com/repos/osmandapp/Osmand/subscription","commits_url":"https://api.github.com/repos/osmandapp/Osmand/commits{/sha}","git_commits_url":"https://api.github.com/repos/osmandapp/Osmand/git/commits{/sha}","comments_url":"https://api.github.com/repos/osmandapp/Osmand/comments{/number}","issue_comment_url":"https://api.github.com/repos/osmandapp/Osmand/issues/comments{/number}","contents_url":"https://api.github.com/repos/osmandapp/Osmand/contents/{+path}","compare_url":"https://api.github.com/repos/osmandapp/Osmand/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osmandapp/Osmand/merges","archive_url":"https://api.github.com/repos/osmandapp/Osmand/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osmandapp/Osmand/downloads","issues_url":"https://api.github.com/repos/osmandapp/Osmand/issues{/number}","pulls_url":"https://api.github.com/repos/osmandapp/Osmand/pulls{/number}","milestones_url":"https://api.github.com/repos/osmandapp/Osmand/milestones{/number}","notifications_url":"https://api.github.com/repos/osmandapp/Osmand/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osmandapp/Osmand/labels{/name}","releases_url":"https://api.github.com/repos/osmandapp/Osmand/releases{/id}","deployments_url":"https://api.github.com/repos/osmandapp/Osmand/deployments","created_at":"2011-01-15T19:59:44Z","updated_at":"2016-06-12T13:14:42Z","pushed_at":"2016-06-13T22:32:43Z","git_url":"git://github.com/osmandapp/Osmand.git","ssh_url":"git@github.com:osmandapp/Osmand.git","clone_url":"https://github.com/osmandapp/Osmand.git","svn_url":"https://github.com/osmandapp/Osmand","homepage":"osmand.net","size":360010,"stargazers_count":795,"watchers_count":795,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":470,"mirror_url":null,"open_issues_count":362,"forks":470,"open_issues":362,"watchers":795,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osmandapp/Osmand/pulls/1208"},"html":{"href":"https://github.com/osmandapp/Osmand/pull/1208"},"issue":{"href":"https://api.github.com/repos/osmandapp/Osmand/issues/1208"},"comments":{"href":"https://api.github.com/repos/osmandapp/Osmand/issues/1208/comments"},"review_comments":{"href":"https://api.github.com/repos/osmandapp/Osmand/pulls/1208/comments"},"review_comment":{"href":"https://api.github.com/repos/osmandapp/Osmand/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osmandapp/Osmand/pulls/1208/commits"},"statuses":{"href":"https://api.github.com/repos/osmandapp/Osmand/statuses/27d080e98fcda4783351933ae403fa0939e30fd7"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":39,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"vshcherb"}}