{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments/93339653","pull_request_review_id":13865308,"id":93339653,"diff_hunk":"@@ -0,0 +1,89 @@\n+use core::Workspace;\n+use ops::{self, CompileOptions, MessageFormat};\n+use util::important_paths::{find_root_manifest_for_wd};\n+use util::{CliResult, Config};\n+\n+#[derive(RustcDecodable)]\n+pub struct Options {","path":"src/cargo/ops/cargo_check.rs","position":7,"original_position":7,"commit_id":"6440007cb8b3c0663d93f0f33e63630a168e13f9","original_commit_id":"6440007cb8b3c0663d93f0f33e63630a168e13f9","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"Ah yeah the intention was that all the CLI options have their own suite of flags and such but everything \"compiles down\" to [`CompileOptions`](https://www.openssl.org/docs/manmaster/man3/SSL_write_ex.html) where that's the common functionality amongst everything.","created_at":"2016-12-20T22:30:59Z","updated_at":"2016-12-20T22:30:59Z","html_url":"https://github.com/rust-lang/cargo/pull/3427#discussion_r93339653","pull_request_url":"https://api.github.com/repos/rust-lang/cargo/pulls/3427","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments/93339653"},"html":{"href":"https://github.com/rust-lang/cargo/pull/3427#discussion_r93339653"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/3427"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/3427","id":98493300,"html_url":"https://github.com/rust-lang/cargo/pull/3427","diff_url":"https://github.com/rust-lang/cargo/pull/3427.diff","patch_url":"https://github.com/rust-lang/cargo/pull/3427.patch","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/3427","number":3427,"state":"open","locked":false,"title":"Make some aspects of check/build available as an API.","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"body":"There are two key parts to this commit:\r\n* let API clients run `cargo check` with minimal fuss (ops/cargo_check.rs),\r\n* let API clients intercept and customise Cargo's calls to rustc (all the Executor stuff).\r\n\r\nr? @alexcrichton ","created_at":"2016-12-19T00:13:31Z","updated_at":"2016-12-20T22:30:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8a5b42337e14697b1d34e6d23e7205856f809a3","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/cargo/pulls/3427/commits","review_comments_url":"https://api.github.com/repos/rust-lang/cargo/pulls/3427/comments","review_comment_url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/3427/comments","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/6440007cb8b3c0663d93f0f33e63630a168e13f9","head":{"label":"nrc:api-check-2","ref":"api-check-2","sha":"6440007cb8b3c0663d93f0f33e63630a168e13f9","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"repo":{"id":38234234,"name":"cargo","full_name":"nrc/cargo","owner":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nrc/cargo","description":"The Rust package manager","fork":true,"url":"https://api.github.com/repos/nrc/cargo","forks_url":"https://api.github.com/repos/nrc/cargo/forks","keys_url":"https://api.github.com/repos/nrc/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrc/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrc/cargo/teams","hooks_url":"https://api.github.com/repos/nrc/cargo/hooks","issue_events_url":"https://api.github.com/repos/nrc/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/nrc/cargo/events","assignees_url":"https://api.github.com/repos/nrc/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/nrc/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/nrc/cargo/tags","blobs_url":"https://api.github.com/repos/nrc/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrc/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrc/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrc/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrc/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/nrc/cargo/languages","stargazers_url":"https://api.github.com/repos/nrc/cargo/stargazers","contributors_url":"https://api.github.com/repos/nrc/cargo/contributors","subscribers_url":"https://api.github.com/repos/nrc/cargo/subscribers","subscription_url":"https://api.github.com/repos/nrc/cargo/subscription","commits_url":"https://api.github.com/repos/nrc/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrc/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrc/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrc/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrc/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/nrc/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrc/cargo/merges","archive_url":"https://api.github.com/repos/nrc/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrc/cargo/downloads","issues_url":"https://api.github.com/repos/nrc/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/nrc/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/nrc/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/nrc/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrc/cargo/labels{/name}","releases_url":"https://api.github.com/repos/nrc/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/nrc/cargo/deployments","created_at":"2015-06-29T07:40:55Z","updated_at":"2015-06-29T07:40:56Z","pushed_at":"2016-12-19T00:12:16Z","git_url":"git://github.com/nrc/cargo.git","ssh_url":"git@github.com:nrc/cargo.git","clone_url":"https://github.com/nrc/cargo.git","svn_url":"https://github.com/nrc/cargo","homepage":"http://crates.io/","size":11365,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"ddb5c328d67f046c929928f161d50eef1cbc3e81","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":17420913,"name":"cargo","full_name":"rust-lang/cargo","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/cargo","description":"The Rust package manager","fork":false,"url":"https://api.github.com/repos/rust-lang/cargo","forks_url":"https://api.github.com/repos/rust-lang/cargo/forks","keys_url":"https://api.github.com/repos/rust-lang/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/cargo/teams","hooks_url":"https://api.github.com/repos/rust-lang/cargo/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/cargo/events","assignees_url":"https://api.github.com/repos/rust-lang/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/cargo/tags","blobs_url":"https://api.github.com/repos/rust-lang/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/cargo/languages","stargazers_url":"https://api.github.com/repos/rust-lang/cargo/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/cargo/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/cargo/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/cargo/subscription","commits_url":"https://api.github.com/repos/rust-lang/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/cargo/merges","archive_url":"https://api.github.com/repos/rust-lang/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/cargo/downloads","issues_url":"https://api.github.com/repos/rust-lang/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/cargo/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/cargo/deployments","created_at":"2014-03-04T23:20:42Z","updated_at":"2016-12-20T17:41:20Z","pushed_at":"2016-12-20T22:11:16Z","git_url":"git://github.com/rust-lang/cargo.git","ssh_url":"git@github.com:rust-lang/cargo.git","clone_url":"https://github.com/rust-lang/cargo.git","svn_url":"https://github.com/rust-lang/cargo","homepage":"https://crates.io/","size":11412,"stargazers_count":1948,"watchers_count":1948,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":472,"mirror_url":null,"open_issues_count":423,"forks":472,"open_issues":423,"watchers":1948,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/3427"},"html":{"href":"https://github.com/rust-lang/cargo/pull/3427"},"issue":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/3427"},"comments":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/3427/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/3427/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/3427/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/cargo/statuses/6440007cb8b3c0663d93f0f33e63630a168e13f9"}}}}
{"actor":{"display_login":"alexcrichton"}}