{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments/88778772","pull_request_review_id":9344853,"id":88778772,"diff_hunk":"@@ -75,7 +83,8 @@ def squash_dates(obj):\n def date_default(obj):\n     \"\"\"default function for packing datetime objects in JSON.\"\"\"\n     if isinstance(obj, datetime):\n-        return obj.isoformat()\n+        obj = _ensure_tzinfo(obj)","path":"jupyter_client/jsonutil.py","position":67,"original_position":61,"commit_id":"dc9e6444c79d1da9797f1c77b3207a7e2d395926","original_commit_id":"bd43a11f609e29c2bee64c3c59404fb7fa192df0","user":{"login":"takluyver","id":327925,"avatar_url":"https://avatars.githubusercontent.com/u/327925?v=3","gravatar_id":"","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"body":"Fair enough. Then in some future version, we could potentially drop support for passing naive datetime objects to the serialisation machinery.","created_at":"2016-11-19T12:41:48Z","updated_at":"2016-11-19T12:41:49Z","html_url":"https://github.com/jupyter/jupyter_client/pull/217#discussion_r88778772","pull_request_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments/88778772"},"html":{"href":"https://github.com/jupyter/jupyter_client/pull/217#discussion_r88778772"},"pull_request":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/217","id":90579023,"html_url":"https://github.com/jupyter/jupyter_client/pull/217","diff_url":"https://github.com/jupyter/jupyter_client/pull/217.diff","patch_url":"https://github.com/jupyter/jupyter_client/pull/217.patch","issue_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/217","number":217,"state":"open","locked":false,"title":"ensure timestamps are timezone-aware","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"- use UTC timestamps everywhere\n- use common Z format instead of +00:00 for UTC\n- naïve timestamps are given local timezone on serialize/deserialize\n- use python-dateutil for parsing, local timezone\n\nThis should trigger a major version bump because it affects the Python API (existing code that compares timestamps with naïve timestamps will break). It does not affect the message _protocol_ version, because the protocol's definition of timestamp behavior is unchanged, other than resolving the ambiguity that timezone-free timestamps are interpreted as local time.\n","created_at":"2016-10-24T09:43:07Z","updated_at":"2016-11-19T12:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36c936724da5829b65ed23e20477d69456e053cc","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jupyter/jupyter_client/milestones/5","html_url":"https://github.com/jupyter/jupyter_client/milestones/5.0","labels_url":"https://api.github.com/repos/jupyter/jupyter_client/milestones/5/labels","id":1204362,"number":5,"title":"5.0","description":null,"creator":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2015-07-13T02:27:02Z","updated_at":"2016-11-16T12:47:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/217/commits","review_comments_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/217/comments","review_comment_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/217/comments","statuses_url":"https://api.github.com/repos/jupyter/jupyter_client/statuses/dc9e6444c79d1da9797f1c77b3207a7e2d395926","head":{"label":"minrk:utc-timestamps","ref":"utc-timestamps","sha":"dc9e6444c79d1da9797f1c77b3207a7e2d395926","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"repo":{"id":34010117,"name":"jupyter_client","full_name":"minrk/jupyter_client","owner":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/minrk/jupyter_client","description":"Jupyter protocol client APIs","fork":true,"url":"https://api.github.com/repos/minrk/jupyter_client","forks_url":"https://api.github.com/repos/minrk/jupyter_client/forks","keys_url":"https://api.github.com/repos/minrk/jupyter_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minrk/jupyter_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minrk/jupyter_client/teams","hooks_url":"https://api.github.com/repos/minrk/jupyter_client/hooks","issue_events_url":"https://api.github.com/repos/minrk/jupyter_client/issues/events{/number}","events_url":"https://api.github.com/repos/minrk/jupyter_client/events","assignees_url":"https://api.github.com/repos/minrk/jupyter_client/assignees{/user}","branches_url":"https://api.github.com/repos/minrk/jupyter_client/branches{/branch}","tags_url":"https://api.github.com/repos/minrk/jupyter_client/tags","blobs_url":"https://api.github.com/repos/minrk/jupyter_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minrk/jupyter_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minrk/jupyter_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/minrk/jupyter_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minrk/jupyter_client/statuses/{sha}","languages_url":"https://api.github.com/repos/minrk/jupyter_client/languages","stargazers_url":"https://api.github.com/repos/minrk/jupyter_client/stargazers","contributors_url":"https://api.github.com/repos/minrk/jupyter_client/contributors","subscribers_url":"https://api.github.com/repos/minrk/jupyter_client/subscribers","subscription_url":"https://api.github.com/repos/minrk/jupyter_client/subscription","commits_url":"https://api.github.com/repos/minrk/jupyter_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/minrk/jupyter_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/minrk/jupyter_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/minrk/jupyter_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/minrk/jupyter_client/contents/{+path}","compare_url":"https://api.github.com/repos/minrk/jupyter_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minrk/jupyter_client/merges","archive_url":"https://api.github.com/repos/minrk/jupyter_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minrk/jupyter_client/downloads","issues_url":"https://api.github.com/repos/minrk/jupyter_client/issues{/number}","pulls_url":"https://api.github.com/repos/minrk/jupyter_client/pulls{/number}","milestones_url":"https://api.github.com/repos/minrk/jupyter_client/milestones{/number}","notifications_url":"https://api.github.com/repos/minrk/jupyter_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minrk/jupyter_client/labels{/name}","releases_url":"https://api.github.com/repos/minrk/jupyter_client/releases{/id}","deployments_url":"https://api.github.com/repos/minrk/jupyter_client/deployments","created_at":"2015-04-15T18:04:05Z","updated_at":"2016-03-04T14:55:58Z","pushed_at":"2016-11-18T14:54:03Z","git_url":"git://github.com/minrk/jupyter_client.git","ssh_url":"git@github.com:minrk/jupyter_client.git","clone_url":"https://github.com/minrk/jupyter_client.git","svn_url":"https://github.com/minrk/jupyter_client","homepage":null,"size":2205,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"7c5c013b6dbd9fb584ad7ded5cdebbfbd9d26f94","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":33653575,"name":"jupyter_client","full_name":"jupyter/jupyter_client","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/jupyter_client","description":"Jupyter protocol client APIs","fork":false,"url":"https://api.github.com/repos/jupyter/jupyter_client","forks_url":"https://api.github.com/repos/jupyter/jupyter_client/forks","keys_url":"https://api.github.com/repos/jupyter/jupyter_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/jupyter_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/jupyter_client/teams","hooks_url":"https://api.github.com/repos/jupyter/jupyter_client/hooks","issue_events_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/jupyter_client/events","assignees_url":"https://api.github.com/repos/jupyter/jupyter_client/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/jupyter_client/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/jupyter_client/tags","blobs_url":"https://api.github.com/repos/jupyter/jupyter_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/jupyter_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/jupyter_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/jupyter_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/jupyter_client/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/jupyter_client/languages","stargazers_url":"https://api.github.com/repos/jupyter/jupyter_client/stargazers","contributors_url":"https://api.github.com/repos/jupyter/jupyter_client/contributors","subscribers_url":"https://api.github.com/repos/jupyter/jupyter_client/subscribers","subscription_url":"https://api.github.com/repos/jupyter/jupyter_client/subscription","commits_url":"https://api.github.com/repos/jupyter/jupyter_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/jupyter_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/jupyter_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/jupyter_client/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/jupyter_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/jupyter_client/merges","archive_url":"https://api.github.com/repos/jupyter/jupyter_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/jupyter_client/downloads","issues_url":"https://api.github.com/repos/jupyter/jupyter_client/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/jupyter_client/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/jupyter_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/jupyter_client/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/jupyter_client/releases{/id}","deployments_url":"https://api.github.com/repos/jupyter/jupyter_client/deployments","created_at":"2015-04-09T06:57:29Z","updated_at":"2016-10-25T10:55:52Z","pushed_at":"2016-11-18T14:54:03Z","git_url":"git://github.com/jupyter/jupyter_client.git","ssh_url":"git@github.com:jupyter/jupyter_client.git","clone_url":"https://github.com/jupyter/jupyter_client.git","svn_url":"https://github.com/jupyter/jupyter_client","homepage":"https://jupyter-client.readthedocs.io","size":2297,"stargazers_count":43,"watchers_count":43,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":44,"forks":71,"open_issues":44,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/217"},"html":{"href":"https://github.com/jupyter/jupyter_client/pull/217"},"issue":{"href":"https://api.github.com/repos/jupyter/jupyter_client/issues/217"},"comments":{"href":"https://api.github.com/repos/jupyter/jupyter_client/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/jupyter_client/statuses/dc9e6444c79d1da9797f1c77b3207a7e2d395926"}}}}
{"actor":{"display_login":"takluyver"}}