{"action":"created","issue":{"url":"https://api.github.com/repos/ibm-js/deliteful/issues/645","repository_url":"https://api.github.com/repos/ibm-js/deliteful","labels_url":"https://api.github.com/repos/ibm-js/deliteful/issues/645/labels{/name}","comments_url":"https://api.github.com/repos/ibm-js/deliteful/issues/645/comments","events_url":"https://api.github.com/repos/ibm-js/deliteful/issues/645/events","html_url":"https://github.com/ibm-js/deliteful/issues/645","id":171488644,"number":645,"title":"Some things about Accordion","user":{"login":"gbaumgart","id":1205100,"avatar_url":"https://avatars.githubusercontent.com/u/1205100?v=3","gravatar_id":"","url":"https://api.github.com/users/gbaumgart","html_url":"https://github.com/gbaumgart","followers_url":"https://api.github.com/users/gbaumgart/followers","following_url":"https://api.github.com/users/gbaumgart/following{/other_user}","gists_url":"https://api.github.com/users/gbaumgart/gists{/gist_id}","starred_url":"https://api.github.com/users/gbaumgart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbaumgart/subscriptions","organizations_url":"https://api.github.com/users/gbaumgart/orgs","repos_url":"https://api.github.com/users/gbaumgart/repos","events_url":"https://api.github.com/users/gbaumgart/events{/privacy}","received_events_url":"https://api.github.com/users/gbaumgart/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-16T18:45:09Z","updated_at":"2016-08-16T22:57:32Z","closed_at":null,"body":"I think there is a bug in Accordion#removeChild(panel). It removes the panel but not the AccordionHeader.\r\n\r\n\r\nThe other thing is : Accordion#onAddChild  is never called (programmatically created) and so new added panels won't get properly initiated with a AccordionHeader. I can't recall exactly how my Maqetta clone did de-serialize the widget's children but after debugging I figured that the most is done in the Accordion#createdCallback and at the time this is called, the accordion is still empty and the panels are added later for some reason by Maqetta. I couldn't find a widget API method to refresh rendering in this case (init unparsed children). \r\n\r\nIs it possible i have to this manually just ? I noticed already that Deliteful works well if used the declarative way but when using it programmatically I have lots weird things going on (just saying)\r\n\r\nwell, close this just if its out of scope for you but it would great to get some little feedback on this, possibly I am doing things wrong (have similar problems with ViewStack)\r\n\r\n\r\n\r\n \r\n\r\n "},"comment":{"url":"https://api.github.com/repos/ibm-js/deliteful/issues/comments/240265083","html_url":"https://github.com/ibm-js/deliteful/issues/645#issuecomment-240265083","issue_url":"https://api.github.com/repos/ibm-js/deliteful/issues/645","id":240265083,"user":{"login":"wkeese","id":69599,"avatar_url":"https://avatars.githubusercontent.com/u/69599?v=3","gravatar_id":"","url":"https://api.github.com/users/wkeese","html_url":"https://github.com/wkeese","followers_url":"https://api.github.com/users/wkeese/followers","following_url":"https://api.github.com/users/wkeese/following{/other_user}","gists_url":"https://api.github.com/users/wkeese/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeese/subscriptions","organizations_url":"https://api.github.com/users/wkeese/orgs","repos_url":"https://api.github.com/users/wkeese/repos","events_url":"https://api.github.com/users/wkeese/events{/privacy}","received_events_url":"https://api.github.com/users/wkeese/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T22:57:32Z","updated_at":"2016-08-16T22:57:32Z","body":"Yup, sorry, those things should work but looks like I didn't implement them, at least not after I rewrote Accordion.   Not sure if they used to work or not.\r\n\r\nThe Accordion programmatic test (tests/unit/Accordion) is also bad because it's obviously missing tests for this case.  It doesn't check for incrementally adding/removing panes after Accordion creation."}}
{"actor":{"display_login":"wkeese"}}