{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/10405","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/10405/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10405/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/10405/events","html_url":"https://github.com/nodejs/node/pull/10405","id":197087622,"number":10405,"title":"src: make `global` non-enumerable","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"labels":[{"id":281232761,"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false},{"id":169485514,"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2016-12-22T03:36:12Z","updated_at":"2016-12-24T06:42:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10405","html_url":"https://github.com/nodejs/node/pull/10405","diff_url":"https://github.com/nodejs/node/pull/10405.diff","patch_url":"https://github.com/nodejs/node/pull/10405.patch"},"body":"Per https://github.com/tc39/proposal-global\r\n\r\nThis is my first PR to node core, so I'm putting it up now without a completed checklist. Early feedback is welcome, and I'll be moving through the items as quickly I can.\r\n\r\n<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), ~~or `vcbuild test` (Windows)~~ passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nthe JS environment\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\nPer [the stage 3 proposal](https://github.com/tc39/proposal-global), `global` should be non-enumerable (but writable and configurable). This PR alters the property descriptor to be so.\r\n\r\n(If there's a better place this should be done, a pointer to it is most welcome)"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/269071997","html_url":"https://github.com/nodejs/node/pull/10405#issuecomment-269071997","issue_url":"https://api.github.com/repos/nodejs/node/issues/10405","id":269071997,"user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"created_at":"2016-12-24T06:42:04Z","updated_at":"2016-12-24T06:42:04Z","body":"@Fishrock123 wrote:\r\n\r\n> Ummm. I'm not ok with that?? I've used this for debugging certain things and finding things before... and I can see myself needing it again in the future...\r\n\r\nRe-reading what I wrote, I see that I phrased it badly. I may have made it sound like `Object.keys(global)` will no longer return an array. It will still return an array of keys. The only change will be that the string `global` will no longer be one of those keys. In other words, the `global.global` circular reference will no longer be listed among the keys returned by `Object.keys(global)`. "}}
{"actor":{"display_login":"Trott"}}