{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/49369280","id":49369280,"diff_hunk":"@@ -106,6 +120,10 @@ if (__DEV__) {\n     } else if (badStyleValueWithSemicolonPattern.test(value)) {\n       warnStyleValueWithSemicolon(name, value);\n     }\n+\n+    if (numberIsNaN(value)) {","path":"src/renderers/dom/shared/CSSPropertyOperations.js","position":33,"original_position":33,"commit_id":"27d9b429171196740e2fbbe25553e5f86bab72d0","original_commit_id":"27d9b429171196740e2fbbe25553e5f86bab72d0","user":{"login":"jimfb","id":9595985,"avatar_url":"https://avatars.githubusercontent.com/u/9595985?v=3","gravatar_id":"","url":"https://api.github.com/users/jimfb","html_url":"https://github.com/jimfb","followers_url":"https://api.github.com/users/jimfb/followers","following_url":"https://api.github.com/users/jimfb/following{/other_user}","gists_url":"https://api.github.com/users/jimfb/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfb/subscriptions","organizations_url":"https://api.github.com/users/jimfb/orgs","repos_url":"https://api.github.com/users/jimfb/repos","events_url":"https://api.github.com/users/jimfb/events{/privacy}","received_events_url":"https://api.github.com/users/jimfb/received_events","type":"User","site_admin":false},"body":"The advantage to not inlining is readability, since otherwise `if(value !== value)` has an incredibly obscure behavior.  I don't feel strongly, so if you want it inlined, that's fine with me.","created_at":"2016-01-11T19:53:08Z","updated_at":"2016-01-11T19:53:08Z","html_url":"https://github.com/facebook/react/pull/5811#discussion_r49369280","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/5811","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/49369280"},"html":{"href":"https://github.com/facebook/react/pull/5811#discussion_r49369280"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/5811"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/5811","id":55525274,"html_url":"https://github.com/facebook/react/pull/5811","diff_url":"https://github.com/facebook/react/pull/5811.diff","patch_url":"https://github.com/facebook/react/pull/5811.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/5811","number":5811,"state":"open","locked":false,"title":"Warn when a style object has NaN for a value","user":{"login":"jontewks","id":3970573,"avatar_url":"https://avatars.githubusercontent.com/u/3970573?v=3","gravatar_id":"","url":"https://api.github.com/users/jontewks","html_url":"https://github.com/jontewks","followers_url":"https://api.github.com/users/jontewks/followers","following_url":"https://api.github.com/users/jontewks/following{/other_user}","gists_url":"https://api.github.com/users/jontewks/gists{/gist_id}","starred_url":"https://api.github.com/users/jontewks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jontewks/subscriptions","organizations_url":"https://api.github.com/users/jontewks/orgs","repos_url":"https://api.github.com/users/jontewks/repos","events_url":"https://api.github.com/users/jontewks/events{/privacy}","received_events_url":"https://api.github.com/users/jontewks/received_events","type":"User","site_admin":false},"body":"Warn when a style object has NaN for a value instead of showing mutated style warning.\r\n\r\nFix for issue #5773 ","created_at":"2016-01-08T23:45:36Z","updated_at":"2016-01-11T19:53:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eec6a34158e027f537f77a64bf4040d0ea8f049a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/5811/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/5811/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/5811/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/27d9b429171196740e2fbbe25553e5f86bab72d0","head":{"label":"jontewks:warn-nan-style","ref":"warn-nan-style","sha":"27d9b429171196740e2fbbe25553e5f86bab72d0","user":{"login":"jontewks","id":3970573,"avatar_url":"https://avatars.githubusercontent.com/u/3970573?v=3","gravatar_id":"","url":"https://api.github.com/users/jontewks","html_url":"https://github.com/jontewks","followers_url":"https://api.github.com/users/jontewks/followers","following_url":"https://api.github.com/users/jontewks/following{/other_user}","gists_url":"https://api.github.com/users/jontewks/gists{/gist_id}","starred_url":"https://api.github.com/users/jontewks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jontewks/subscriptions","organizations_url":"https://api.github.com/users/jontewks/orgs","repos_url":"https://api.github.com/users/jontewks/repos","events_url":"https://api.github.com/users/jontewks/events{/privacy}","received_events_url":"https://api.github.com/users/jontewks/received_events","type":"User","site_admin":false},"repo":{"id":39164710,"name":"react","full_name":"jontewks/react","owner":{"login":"jontewks","id":3970573,"avatar_url":"https://avatars.githubusercontent.com/u/3970573?v=3","gravatar_id":"","url":"https://api.github.com/users/jontewks","html_url":"https://github.com/jontewks","followers_url":"https://api.github.com/users/jontewks/followers","following_url":"https://api.github.com/users/jontewks/following{/other_user}","gists_url":"https://api.github.com/users/jontewks/gists{/gist_id}","starred_url":"https://api.github.com/users/jontewks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jontewks/subscriptions","organizations_url":"https://api.github.com/users/jontewks/orgs","repos_url":"https://api.github.com/users/jontewks/repos","events_url":"https://api.github.com/users/jontewks/events{/privacy}","received_events_url":"https://api.github.com/users/jontewks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jontewks/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/jontewks/react","forks_url":"https://api.github.com/repos/jontewks/react/forks","keys_url":"https://api.github.com/repos/jontewks/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jontewks/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jontewks/react/teams","hooks_url":"https://api.github.com/repos/jontewks/react/hooks","issue_events_url":"https://api.github.com/repos/jontewks/react/issues/events{/number}","events_url":"https://api.github.com/repos/jontewks/react/events","assignees_url":"https://api.github.com/repos/jontewks/react/assignees{/user}","branches_url":"https://api.github.com/repos/jontewks/react/branches{/branch}","tags_url":"https://api.github.com/repos/jontewks/react/tags","blobs_url":"https://api.github.com/repos/jontewks/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jontewks/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jontewks/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/jontewks/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jontewks/react/statuses/{sha}","languages_url":"https://api.github.com/repos/jontewks/react/languages","stargazers_url":"https://api.github.com/repos/jontewks/react/stargazers","contributors_url":"https://api.github.com/repos/jontewks/react/contributors","subscribers_url":"https://api.github.com/repos/jontewks/react/subscribers","subscription_url":"https://api.github.com/repos/jontewks/react/subscription","commits_url":"https://api.github.com/repos/jontewks/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/jontewks/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/jontewks/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/jontewks/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/jontewks/react/contents/{+path}","compare_url":"https://api.github.com/repos/jontewks/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jontewks/react/merges","archive_url":"https://api.github.com/repos/jontewks/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jontewks/react/downloads","issues_url":"https://api.github.com/repos/jontewks/react/issues{/number}","pulls_url":"https://api.github.com/repos/jontewks/react/pulls{/number}","milestones_url":"https://api.github.com/repos/jontewks/react/milestones{/number}","notifications_url":"https://api.github.com/repos/jontewks/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jontewks/react/labels{/name}","releases_url":"https://api.github.com/repos/jontewks/react/releases{/id}","created_at":"2015-07-15T22:43:43Z","updated_at":"2015-07-15T22:43:47Z","pushed_at":"2016-01-10T00:41:48Z","git_url":"git://github.com/jontewks/react.git","ssh_url":"git@github.com:jontewks/react.git","clone_url":"https://github.com/jontewks/react.git","svn_url":"https://github.com/jontewks/react","homepage":"https://facebook.github.io/react/","size":70781,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"23167f287eda5ee23725a099e67d6086baa8e300","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-01-11T19:45:42Z","pushed_at":"2016-01-11T18:37:34Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":94229,"stargazers_count":34558,"watchers_count":34558,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5584,"mirror_url":null,"open_issues_count":577,"forks":5584,"open_issues":577,"watchers":34558,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/5811"},"html":{"href":"https://github.com/facebook/react/pull/5811"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/5811"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/5811/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/5811/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/5811/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/27d9b429171196740e2fbbe25553e5f86bab72d0"}}}}