{"action":"closed","number":353,"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/353","id":90893858,"html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/353","diff_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/353.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/353.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/353","number":353,"state":"closed","locked":false,"title":"EVSS: Require document-type for uploads","user":{"login":"carlmjohnson","id":222245,"avatar_url":"https://avatars.githubusercontent.com/u/222245?v=3","gravatar_id":"","url":"https://api.github.com/users/carlmjohnson","html_url":"https://github.com/carlmjohnson","followers_url":"https://api.github.com/users/carlmjohnson/followers","following_url":"https://api.github.com/users/carlmjohnson/following{/other_user}","gists_url":"https://api.github.com/users/carlmjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/carlmjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlmjohnson/subscriptions","organizations_url":"https://api.github.com/users/carlmjohnson/orgs","repos_url":"https://api.github.com/users/carlmjohnson/repos","events_url":"https://api.github.com/users/carlmjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/carlmjohnson/received_events","type":"User","site_admin":false},"body":"Using a struct made more sense before I added validation. Now I'm leaning towards changing to a class for DocumentData, but whatever suggestions you have would be appreciated.\r\n\r\nFixes https://github.com/department-of-veterans-affairs/sunsets-team/issues/143","created_at":"2016-10-25T21:18:52Z","updated_at":"2016-10-26T21:31:50Z","closed_at":"2016-10-26T21:31:50Z","merged_at":"2016-10-26T21:31:50Z","merge_commit_sha":"2adce5e0a169a643e3a75cdbf8aaf52b554cce88","assignee":{"login":"austin-martinez","id":16657563,"avatar_url":"https://avatars.githubusercontent.com/u/16657563?v=3","gravatar_id":"","url":"https://api.github.com/users/austin-martinez","html_url":"https://github.com/austin-martinez","followers_url":"https://api.github.com/users/austin-martinez/followers","following_url":"https://api.github.com/users/austin-martinez/following{/other_user}","gists_url":"https://api.github.com/users/austin-martinez/gists{/gist_id}","starred_url":"https://api.github.com/users/austin-martinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austin-martinez/subscriptions","organizations_url":"https://api.github.com/users/austin-martinez/orgs","repos_url":"https://api.github.com/users/austin-martinez/repos","events_url":"https://api.github.com/users/austin-martinez/events{/privacy}","received_events_url":"https://api.github.com/users/austin-martinez/received_events","type":"User","site_admin":false},"assignees":[{"login":"austin-martinez","id":16657563,"avatar_url":"https://avatars.githubusercontent.com/u/16657563?v=3","gravatar_id":"","url":"https://api.github.com/users/austin-martinez","html_url":"https://github.com/austin-martinez","followers_url":"https://api.github.com/users/austin-martinez/followers","following_url":"https://api.github.com/users/austin-martinez/following{/other_user}","gists_url":"https://api.github.com/users/austin-martinez/gists{/gist_id}","starred_url":"https://api.github.com/users/austin-martinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austin-martinez/subscriptions","organizations_url":"https://api.github.com/users/austin-martinez/orgs","repos_url":"https://api.github.com/users/austin-martinez/repos","events_url":"https://api.github.com/users/austin-martinez/events{/privacy}","received_events_url":"https://api.github.com/users/austin-martinez/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/353/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/353/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/353/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/27781c70d4f2462c9ddc12b6ca1cdf14c9ed15a5","head":{"label":"department-of-veterans-affairs:cjohnson/document-params","ref":"cjohnson/document-params","sha":"27781c70d4f2462c9ddc12b6ca1cdf14c9ed15a5","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":62409417,"name":"vets-api","full_name":"department-of-veterans-affairs/vets-api","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/vets-api","description":"API for vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/deployments","created_at":"2016-07-01T17:33:19Z","updated_at":"2016-10-23T11:11:55Z","pushed_at":"2016-10-26T21:31:50Z","git_url":"git://github.com/department-of-veterans-affairs/vets-api.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-api.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-api.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-api","homepage":null,"size":5372,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":41,"forks":1,"open_issues":41,"watchers":4,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"41ea2363af03eada1e465f0e7ef0d72ce8c0fa68","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":62409417,"name":"vets-api","full_name":"department-of-veterans-affairs/vets-api","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/vets-api","description":"API for vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/deployments","created_at":"2016-07-01T17:33:19Z","updated_at":"2016-10-23T11:11:55Z","pushed_at":"2016-10-26T21:31:50Z","git_url":"git://github.com/department-of-veterans-affairs/vets-api.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-api.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-api.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-api","homepage":null,"size":5372,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":41,"forks":1,"open_issues":41,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/353"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-api/pull/353"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/353"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/353/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/353/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/353/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/27781c70d4f2462c9ddc12b6ca1cdf14c9ed15a5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"carlmjohnson","id":222245,"avatar_url":"https://avatars.githubusercontent.com/u/222245?v=3","gravatar_id":"","url":"https://api.github.com/users/carlmjohnson","html_url":"https://github.com/carlmjohnson","followers_url":"https://api.github.com/users/carlmjohnson/followers","following_url":"https://api.github.com/users/carlmjohnson/following{/other_user}","gists_url":"https://api.github.com/users/carlmjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/carlmjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlmjohnson/subscriptions","organizations_url":"https://api.github.com/users/carlmjohnson/orgs","repos_url":"https://api.github.com/users/carlmjohnson/repos","events_url":"https://api.github.com/users/carlmjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/carlmjohnson/received_events","type":"User","site_admin":false},"comments":0,"review_comments":6,"commits":11,"additions":115,"deletions":25,"changed_files":8}}
{"actor":{"display_login":"carlmjohnson"}}