{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/12180","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/12180/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/12180/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/12180/events","html_url":"https://github.com/cockroachdb/cockroach/pull/12180","id":194386200,"number":12180,"title":"storage: fix quiescent replica metric","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-08T16:47:32Z","updated_at":"2016-12-08T17:05:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/12180","html_url":"https://github.com/cockroachdb/cockroach/pull/12180","diff_url":"https://github.com/cockroachdb/cockroach/pull/12180.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/12180.patch"},"body":"Broken by #12026\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/12180)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/265795106","html_url":"https://github.com/cockroachdb/cockroach/pull/12180#issuecomment-265795106","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/12180","id":265795106,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T17:05:48Z","updated_at":"2016-12-08T17:05:48Z","body":"Manually setting this field in the test cases above.\n\nOn Thu, Dec 8, 2016 at 12:04 PM, Peter Mattis <notifications@github.com>\nwrote:\n\n> *@petermattis* commented on this pull request.\n> ------------------------------\n>\n> In pkg/storage/replica_test.go\n> <https://github.com/cockroachdb/cockroach/pull/12180>:\n>\n> >  \t\tt.Run(\"\", func(t *testing.T) {\n>  \t\t\tzoneConfig := config.ZoneConfig{NumReplicas: c.replicas}\n>  \t\t\tdefer config.TestingSetDefaultZoneConfig(zoneConfig)()\n>\n> +\t\t\tc.expected.quiescent = i%2 == 0\n>\n> What would you prefer?\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/cockroachdb/cockroach/pull/12180>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABdsPODQTOkzkkZiWnri7YSgsWOYQIPJks5rGDi2gaJpZM4LICOf>\n> .\n>\n"}}
{"actor":{"display_login":"tamird"}}