{"action":"created","issue":{"url":"https://api.github.com/repos/HTBox/allReady/issues/518","repository_url":"https://api.github.com/repos/HTBox/allReady","labels_url":"https://api.github.com/repos/HTBox/allReady/issues/518/labels{/name}","comments_url":"https://api.github.com/repos/HTBox/allReady/issues/518/comments","events_url":"https://api.github.com/repos/HTBox/allReady/issues/518/events","html_url":"https://github.com/HTBox/allReady/pull/518","id":133409395,"number":518,"title":"Add support for \"Type A: Activity Manged\" activities","user":{"login":"mmoore99","id":45022,"avatar_url":"https://avatars.githubusercontent.com/u/45022?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoore99","html_url":"https://github.com/mmoore99","followers_url":"https://api.github.com/users/mmoore99/followers","following_url":"https://api.github.com/users/mmoore99/following{/other_user}","gists_url":"https://api.github.com/users/mmoore99/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoore99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoore99/subscriptions","organizations_url":"https://api.github.com/users/mmoore99/orgs","repos_url":"https://api.github.com/users/mmoore99/repos","events_url":"https://api.github.com/users/mmoore99/events{/privacy}","received_events_url":"https://api.github.com/users/mmoore99/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-13T07:24:23Z","updated_at":"2016-02-13T16:37:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/HTBox/allReady/pulls/518","html_url":"https://github.com/HTBox/allReady/pull/518","diff_url":"https://github.com/HTBox/allReady/pull/518.diff","patch_url":"https://github.com/HTBox/allReady/pull/518.patch"},"body":"Fixes #506\r\n\r\n**This PR should be able to be merged into \"Master\" as it does not  introduce any breaking changes.  Unless an Activity is specifically assigned an \"ActivityType\" of \"ActivityManaged\" the original workflow for avtivities and tasks remains intact.**\r\n\r\n**Note: this PR depends on PR #514**\r\n\r\nThis PR depends on PR \r\n\r\nThis PR implements the following changes to the functionality of the Activity Detail Page:\r\n\r\n-  No task information is displayed for an \"Activity Managed\" activity\r\n- The \"Volunteer\" link was changed to a button and made more prominent (**see Screenshot 1**)\r\n- Client side validation has been implemented for the activity signup dialog using Knockout (**see Screenshot 2**)\r\n- A confirmation message is now displayed after a successfull signup (**see Screenshot 3**)\r\n- A confirmation message is now displayed after unenrolling from an activity (**see Screenshot 4**)\r\n- The posting of the signup activity dialog is now done through an Ajax call to the ActivityApi conntroller, thereby eliminating the need for a page refresh after signing up.  While, this may not be a specific requirement for this issue, it is needed to support functionality for issue #507 where the user will be picking from a list of tasks on the page.\r\n\r\nThis PR also fixes a bug in the existing code when a user unenrolls from an Activity where task(s) have been assigned to the user. The code was attempting to delete \"Tasks\" instead of \"TaskSignups\" and also was causing system exception to be thrown.\r\n\r\n**Screenshot 1**\r\n![screenclip 1](https://cloud.githubusercontent.com/assets/45022/12985571/339b0c38-d0a8-11e5-8b53-7655495bba75.png)\r\n\r\n**Screenshot 2**\r\n![screenclip 2](https://cloud.githubusercontent.com/assets/45022/12985620/75d715f6-d0a8-11e5-8cba-70ef7ed1ba14.png)\r\n\r\n**Screenshot 3**\r\n![screenclip 3](https://cloud.githubusercontent.com/assets/45022/12985627/7d256ed4-d0a8-11e5-90df-fa7aa238d4e8.png)\r\n\r\n**Screenshot 4**\r\n![screenclip 4](https://cloud.githubusercontent.com/assets/45022/12985635/83963cbc-d0a8-11e5-9d82-097e9bdfb30c.png)"},"comment":{"url":"https://api.github.com/repos/HTBox/allReady/issues/comments/183700055","html_url":"https://github.com/HTBox/allReady/pull/518#issuecomment-183700055","issue_url":"https://api.github.com/repos/HTBox/allReady/issues/518","id":183700055,"user":{"login":"mmoore99","id":45022,"avatar_url":"https://avatars.githubusercontent.com/u/45022?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoore99","html_url":"https://github.com/mmoore99","followers_url":"https://api.github.com/users/mmoore99/followers","following_url":"https://api.github.com/users/mmoore99/following{/other_user}","gists_url":"https://api.github.com/users/mmoore99/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoore99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoore99/subscriptions","organizations_url":"https://api.github.com/users/mmoore99/orgs","repos_url":"https://api.github.com/users/mmoore99/repos","events_url":"https://api.github.com/users/mmoore99/events{/privacy}","received_events_url":"https://api.github.com/users/mmoore99/received_events","type":"User","site_admin":false},"created_at":"2016-02-13T16:37:10Z","updated_at":"2016-02-13T16:37:10Z","body":"@MisterJames I have investigated this  a little further.  It appears that the test is failing while trying to confirm the ability for the admin to **create an activity** (\"Test: The Org Admin can create activies\").  Nothing in this PR involves that process.  \r\n\r\nHowever, this PR depends on PR #514, which has not yet been merged.  #514 does make some changes to the Activity create process as it has added the \"ActivityType\" field.  So, possibly, this error will go away once #514 is merged?  Just sort of guessing here since I am not really familiar with the scenario test process."}}