{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5863","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5863/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5863/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5863/events","html_url":"https://github.com/nodejs/node/pull/5863","id":142927684,"number":5863,"title":"Fix zlib pseudo multi member failure","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"fad8c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/zlib","name":"zlib","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-23T10:55:21Z","updated_at":"2016-03-23T15:34:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5863","html_url":"https://github.com/nodejs/node/pull/5863","diff_url":"https://github.com/nodejs/node/pull/5863.diff","patch_url":"https://github.com/nodejs/node/pull/5863.patch"},"body":"### Pull Request check-list\r\n\r\n- [x] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [x] Is the commit message formatted according to [CONTRIBUTING.md][0]?\r\n- [x] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n\r\n### Affected core subsystem(s)\r\n\r\nzlib\r\n\r\n[0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit\r\n\r\n### Description of change\r\n\r\nFixes #5852, which was introduced in f380db237b (#5120).\r\n\r\nOnly treat the gzip magic bytes, when encountered within the file after reading a single block, as the start of a new member when the previous member has ended.\r\n\r\nI’m really not sure on whether “pseudo-multimember-gzip” & co. are the right names for the test files, but I don’t think there’s a specific term for this very situation. :smile:\r\n\r\nI’m also not sure whether the `ctx->strm_.avail_in >= GZIP_MIN_HEADER_SIZE` check in `node_zlib.cc` doesn’t open the possibility of another edge case, namely that there *is* a new gzip member starting, but not enough bytes have been read into the internal buffer. But that is very likely not related to #5852, since I assume it would result in truncated output rather than an error."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/200397428","html_url":"https://github.com/nodejs/node/pull/5863#issuecomment-200397428","issue_url":"https://api.github.com/repos/nodejs/node/issues/5863","id":200397428,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T15:34:55Z","updated_at":"2016-03-23T15:34:55Z","body":"LGTM"}}