{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments/80019828","id":80019828,"diff_hunk":"@@ -0,0 +1,100 @@\n+require 'concurrent'\n+\n+class Proxy::PuppetApi::V3EnvironmentClassesApiClassesRetriever","path":"modules/puppet_proxy_puppet_api/v3_environmentclassesapi_classes_retriever.rb","position":3,"original_position":3,"commit_id":"6686bf907099706dd6920db065ad1c8abb28652c","original_commit_id":"6686bf907099706dd6920db065ad1c8abb28652c","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"The filename is missing some underscores to match the capitalisation of the class, it'd be easier to read with them.","created_at":"2016-09-22T11:18:20Z","updated_at":"2016-09-22T11:23:01Z","html_url":"https://github.com/theforeman/smart-proxy/pull/460#discussion_r80019828","pull_request_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/460","_links":{"self":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments/80019828"},"html":{"href":"https://github.com/theforeman/smart-proxy/pull/460#discussion_r80019828"},"pull_request":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/460"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/460","id":86133105,"html_url":"https://github.com/theforeman/smart-proxy/pull/460","diff_url":"https://github.com/theforeman/smart-proxy/pull/460.diff","patch_url":"https://github.com/theforeman/smart-proxy/pull/460.patch","issue_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/460","number":460,"state":"open","locked":false,"title":"Fixes #15095 - introduced support for puppet environment classes api","user":{"login":"witlessbird","id":8957,"avatar_url":"https://avatars.githubusercontent.com/u/8957?v=3","gravatar_id":"","url":"https://api.github.com/users/witlessbird","html_url":"https://github.com/witlessbird","followers_url":"https://api.github.com/users/witlessbird/followers","following_url":"https://api.github.com/users/witlessbird/following{/other_user}","gists_url":"https://api.github.com/users/witlessbird/gists{/gist_id}","starred_url":"https://api.github.com/users/witlessbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witlessbird/subscriptions","organizations_url":"https://api.github.com/users/witlessbird/orgs","repos_url":"https://api.github.com/users/witlessbird/repos","events_url":"https://api.github.com/users/witlessbird/events{/privacy}","received_events_url":"https://api.github.com/users/witlessbird/received_events","type":"User","site_admin":false},"body":" - Ruby 1.8.7 is NOT supported.\r\n- This will attempt to cache puppet classes and rely on etag for cache validation. Enable puppet's environment class cache for this feature to have effect.\r\n- It will return a timeout error to the client if puppet doesn't respond within 15 seconds. The module will wait for 5 minutes to update the classes cache before timing out however.","created_at":"2016-09-21T10:07:01Z","updated_at":"2016-09-22T11:23:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2fbc79224cb873f13c3addf3b55c5c56b147758","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/460/commits","review_comments_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/460/comments","review_comment_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/460/comments","statuses_url":"https://api.github.com/repos/theforeman/smart-proxy/statuses/6686bf907099706dd6920db065ad1c8abb28652c","head":{"label":"witlessbird:15095-puppet-environmentclassesapi","ref":"15095-puppet-environmentclassesapi","sha":"6686bf907099706dd6920db065ad1c8abb28652c","user":{"login":"witlessbird","id":8957,"avatar_url":"https://avatars.githubusercontent.com/u/8957?v=3","gravatar_id":"","url":"https://api.github.com/users/witlessbird","html_url":"https://github.com/witlessbird","followers_url":"https://api.github.com/users/witlessbird/followers","following_url":"https://api.github.com/users/witlessbird/following{/other_user}","gists_url":"https://api.github.com/users/witlessbird/gists{/gist_id}","starred_url":"https://api.github.com/users/witlessbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witlessbird/subscriptions","organizations_url":"https://api.github.com/users/witlessbird/orgs","repos_url":"https://api.github.com/users/witlessbird/repos","events_url":"https://api.github.com/users/witlessbird/events{/privacy}","received_events_url":"https://api.github.com/users/witlessbird/received_events","type":"User","site_admin":false},"repo":{"id":9788543,"name":"smart-proxy","full_name":"witlessbird/smart-proxy","owner":{"login":"witlessbird","id":8957,"avatar_url":"https://avatars.githubusercontent.com/u/8957?v=3","gravatar_id":"","url":"https://api.github.com/users/witlessbird","html_url":"https://github.com/witlessbird","followers_url":"https://api.github.com/users/witlessbird/followers","following_url":"https://api.github.com/users/witlessbird/following{/other_user}","gists_url":"https://api.github.com/users/witlessbird/gists{/gist_id}","starred_url":"https://api.github.com/users/witlessbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witlessbird/subscriptions","organizations_url":"https://api.github.com/users/witlessbird/orgs","repos_url":"https://api.github.com/users/witlessbird/repos","events_url":"https://api.github.com/users/witlessbird/events{/privacy}","received_events_url":"https://api.github.com/users/witlessbird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/witlessbird/smart-proxy","description":"RESTful proxies for DNS, DHCP, TFTP and Puppet","fork":true,"url":"https://api.github.com/repos/witlessbird/smart-proxy","forks_url":"https://api.github.com/repos/witlessbird/smart-proxy/forks","keys_url":"https://api.github.com/repos/witlessbird/smart-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/witlessbird/smart-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/witlessbird/smart-proxy/teams","hooks_url":"https://api.github.com/repos/witlessbird/smart-proxy/hooks","issue_events_url":"https://api.github.com/repos/witlessbird/smart-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/witlessbird/smart-proxy/events","assignees_url":"https://api.github.com/repos/witlessbird/smart-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/witlessbird/smart-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/witlessbird/smart-proxy/tags","blobs_url":"https://api.github.com/repos/witlessbird/smart-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/witlessbird/smart-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/witlessbird/smart-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/witlessbird/smart-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/witlessbird/smart-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/witlessbird/smart-proxy/languages","stargazers_url":"https://api.github.com/repos/witlessbird/smart-proxy/stargazers","contributors_url":"https://api.github.com/repos/witlessbird/smart-proxy/contributors","subscribers_url":"https://api.github.com/repos/witlessbird/smart-proxy/subscribers","subscription_url":"https://api.github.com/repos/witlessbird/smart-proxy/subscription","commits_url":"https://api.github.com/repos/witlessbird/smart-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/witlessbird/smart-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/witlessbird/smart-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/witlessbird/smart-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/witlessbird/smart-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/witlessbird/smart-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/witlessbird/smart-proxy/merges","archive_url":"https://api.github.com/repos/witlessbird/smart-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/witlessbird/smart-proxy/downloads","issues_url":"https://api.github.com/repos/witlessbird/smart-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/witlessbird/smart-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/witlessbird/smart-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/witlessbird/smart-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/witlessbird/smart-proxy/labels{/name}","releases_url":"https://api.github.com/repos/witlessbird/smart-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/witlessbird/smart-proxy/deployments","created_at":"2013-05-01T09:05:41Z","updated_at":"2015-05-05T11:14:30Z","pushed_at":"2016-09-22T10:48:05Z","git_url":"git://github.com/witlessbird/smart-proxy.git","ssh_url":"git@github.com:witlessbird/smart-proxy.git","clone_url":"https://github.com/witlessbird/smart-proxy.git","svn_url":"https://github.com/witlessbird/smart-proxy","homepage":"http://theforeman.org/projects/smart-proxy","size":1436,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"933f2b096a8474538915a1edefadfb8f5e757a0d","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":986551,"name":"smart-proxy","full_name":"theforeman/smart-proxy","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/smart-proxy","description":"RESTful proxies for DNS, DHCP, TFTP, BMC and Puppet","fork":false,"url":"https://api.github.com/repos/theforeman/smart-proxy","forks_url":"https://api.github.com/repos/theforeman/smart-proxy/forks","keys_url":"https://api.github.com/repos/theforeman/smart-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/smart-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/smart-proxy/teams","hooks_url":"https://api.github.com/repos/theforeman/smart-proxy/hooks","issue_events_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/smart-proxy/events","assignees_url":"https://api.github.com/repos/theforeman/smart-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/smart-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/smart-proxy/tags","blobs_url":"https://api.github.com/repos/theforeman/smart-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/smart-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/smart-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/smart-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/smart-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/smart-proxy/languages","stargazers_url":"https://api.github.com/repos/theforeman/smart-proxy/stargazers","contributors_url":"https://api.github.com/repos/theforeman/smart-proxy/contributors","subscribers_url":"https://api.github.com/repos/theforeman/smart-proxy/subscribers","subscription_url":"https://api.github.com/repos/theforeman/smart-proxy/subscription","commits_url":"https://api.github.com/repos/theforeman/smart-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/smart-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/smart-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/smart-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/smart-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/smart-proxy/merges","archive_url":"https://api.github.com/repos/theforeman/smart-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/smart-proxy/downloads","issues_url":"https://api.github.com/repos/theforeman/smart-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/smart-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/smart-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/smart-proxy/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/smart-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/smart-proxy/deployments","created_at":"2010-10-14T10:00:51Z","updated_at":"2016-09-12T18:05:17Z","pushed_at":"2016-09-22T10:48:06Z","git_url":"git://github.com/theforeman/smart-proxy.git","ssh_url":"git@github.com:theforeman/smart-proxy.git","clone_url":"https://github.com/theforeman/smart-proxy.git","svn_url":"https://github.com/theforeman/smart-proxy","homepage":"http://theforeman.org/projects/smart-proxy","size":2111,"stargazers_count":133,"watchers_count":133,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":15,"forks":162,"open_issues":15,"watchers":133,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/460"},"html":{"href":"https://github.com/theforeman/smart-proxy/pull/460"},"issue":{"href":"https://api.github.com/repos/theforeman/smart-proxy/issues/460"},"comments":{"href":"https://api.github.com/repos/theforeman/smart-proxy/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/smart-proxy/statuses/6686bf907099706dd6920db065ad1c8abb28652c"}}}}
{"actor":{"display_login":"domcleal"}}