{"action":"created","issue":{"url":"https://api.github.com/repos/jsok/hiera-vault/issues/10","repository_url":"https://api.github.com/repos/jsok/hiera-vault","labels_url":"https://api.github.com/repos/jsok/hiera-vault/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/jsok/hiera-vault/issues/10/comments","events_url":"https://api.github.com/repos/jsok/hiera-vault/issues/10/events","html_url":"https://github.com/jsok/hiera-vault/pull/10","id":125468425,"number":10,"title":"Flagged","user":{"login":"abooitt","id":1453876,"avatar_url":"https://avatars.githubusercontent.com/u/1453876?v=3","gravatar_id":"","url":"https://api.github.com/users/abooitt","html_url":"https://github.com/abooitt","followers_url":"https://api.github.com/users/abooitt/followers","following_url":"https://api.github.com/users/abooitt/following{/other_user}","gists_url":"https://api.github.com/users/abooitt/gists{/gist_id}","starred_url":"https://api.github.com/users/abooitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abooitt/subscriptions","organizations_url":"https://api.github.com/users/abooitt/orgs","repos_url":"https://api.github.com/users/abooitt/repos","events_url":"https://api.github.com/users/abooitt/events{/privacy}","received_events_url":"https://api.github.com/users/abooitt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-01-07T19:31:42Z","updated_at":"2016-06-20T19:52:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jsok/hiera-vault/pulls/10","html_url":"https://github.com/jsok/hiera-vault/pull/10","diff_url":"https://github.com/jsok/hiera-vault/pull/10.diff","patch_url":"https://github.com/jsok/hiera-vault/pull/10.patch"},"body":"This changeset (use_hierarchy branch #9 merged into it) adds the feature to read from vault, only when using custom `hiera_vault`, `hiera_vault_array`, and `hiera_vault_hash` functions in the puppet code.\r\nNormal `hiera*` function calls will cause the `vault` backend to skip reading from vault.\r\n\r\nWhy? Because always reading from vault is pretty heavy and easily can exhaust the number of source ports on the puppet master. Found this when doing test runs in a relatively small environment.\r\n\r\nAdditional features:\r\n- Flag `hiera_vault*` calls to tell it to look in vault only. This can even be the default behavior.\r\n- Generate and write secrets in case they are not found in vault, by using a special value for the second argument (the fallback default) of the `hiera_vault*` functions.\r\n- Better handling/renewing connections to vault in case vault has been temporarily unavailable.\r\n- Handle empty fallback default values as invalid when using `hiera_vault*` functions. Actually a side effect of making it possible to specify a third parameter without a valid fallback default.\r\n\r\nMore info in the README and the code."},"comment":{"url":"https://api.github.com/repos/jsok/hiera-vault/issues/comments/227250133","html_url":"https://github.com/jsok/hiera-vault/pull/10#issuecomment-227250133","issue_url":"https://api.github.com/repos/jsok/hiera-vault/issues/10","id":227250133,"user":{"login":"jovandeginste","id":3170771,"avatar_url":"https://avatars.githubusercontent.com/u/3170771?v=3","gravatar_id":"","url":"https://api.github.com/users/jovandeginste","html_url":"https://github.com/jovandeginste","followers_url":"https://api.github.com/users/jovandeginste/followers","following_url":"https://api.github.com/users/jovandeginste/following{/other_user}","gists_url":"https://api.github.com/users/jovandeginste/gists{/gist_id}","starred_url":"https://api.github.com/users/jovandeginste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jovandeginste/subscriptions","organizations_url":"https://api.github.com/users/jovandeginste/orgs","repos_url":"https://api.github.com/users/jovandeginste/repos","events_url":"https://api.github.com/users/jovandeginste/events{/privacy}","received_events_url":"https://api.github.com/users/jovandeginste/received_events","type":"User","site_admin":false},"created_at":"2016-06-20T19:52:17Z","updated_at":"2016-06-20T19:52:17Z","body":"I'm aware of the existing functions, I have no clue about implementing a custom one... "}}
{"actor":{"display_login":"jovandeginste"}}