{"push_id":1407188761,"size":4,"distinct_size":2,"ref":"refs/heads/explicit-compiled-queries","head":"3a10927c849002777fc656fba063ffde3f8d3938","before":"86ddd7e629fb20076b82487c0d78e5924053716d","commits":[{"sha":"3608b72f59ff110d75672569ea84e82288de6ab8","author":{"name":"Micah Zoltu","email":"6ad8dd4fa00314523adae46702e13969a18ef860@zoltu.net"},"message":"Adds overloads that use TimeSpan instead of Int32.\n\nI tried to follow the conventions elsewhere in the file, but feel free to let me know if I have not followed code style correctly.\n\nThe `ArgumentOutOfRangeException` seemed like the best way to handle the fact that `TimeSpan`s aren't really bounded, though with the new the API surface area the upper bound constraint seems arbitrary.  However, in most real world use cases it will probably not be hit and it is documented.  I decided to throw on negative number as well because that doesn't make sense.  The overload doesn't accept null because if you want to pass null explicitly you can simply call the other overload (transparent to the user) and if you have a `TimeSpan?` you are doing it wrong.  ;)\n\nI added two tests, but I'll admit that they are pretty weak.  I didn't see any tests for the original overloads and I'm not sure how to author a test that will correctly spin up a `DatabaseFacade` where the `SetCommandTimeout` will actually succeed.  Feedback is welcome on how I can make a positive test for timeout setting.\n\nThe overload that returns a `TimeSpan` is likely a bit contentious, as is always the case when you have an \"overload\" that differs only by return type.  I can pull it out if desired, I added it mainly for consistency but I admit that it feels quite awkward.","distinct":false,"url":"https://api.github.com/repos/aspnet/EntityFramework/commits/3608b72f59ff110d75672569ea84e82288de6ab8"},{"sha":"ec5f78de6ba9934f74d032e41682c3681bb93df8","author":{"name":"Smit Patel","email":"8fa6f7087ac978f59e4a88552941cd4c903eb4cb@users.noreply.github.com"},"message":"Maintain connection state in BatchExecutor","distinct":false,"url":"https://api.github.com/repos/aspnet/EntityFramework/commits/ec5f78de6ba9934f74d032e41682c3681bb93df8"},{"sha":"ee39132e563e7c092ce2df3f4093fdd055a5e0ba","author":{"name":"Andrew Peters","email":"a4bcd3bda441d1daaa4531d4ca0035bf13ad06c2@microsoft.com"},"message":"Query: Perf: Adds explicit compiled queries.\n\n- Adds EF.CompileQuery and EF.CompileAsyncQuery which allow for the creation of user managed\ncompiled query delegates. Such queries are more efficient to execute because they bypass the\nCompiledQueryCache (avoiding query hashing and parameterization). Typical gains are around 3-5%","distinct":true,"url":"https://api.github.com/repos/aspnet/EntityFramework/commits/ee39132e563e7c092ce2df3f4093fdd055a5e0ba"},{"sha":"3a10927c849002777fc656fba063ffde3f8d3938","author":{"name":"Andrew Peters","email":"a4bcd3bda441d1daaa4531d4ca0035bf13ad06c2@microsoft.com"},"message":"Adds custom result type and execution operators for async enumerable compiled queries.","distinct":true,"url":"https://api.github.com/repos/aspnet/EntityFramework/commits/3a10927c849002777fc656fba063ffde3f8d3938"}]}
{"actor":{"display_login":"anpete"}}