{"action":"created","comment":{"url":"https://api.github.com/repos/cocos-creator/engine/pulls/comments/64390618","id":64390618,"diff_hunk":"@@ -46,14 +46,18 @@ EventListeners.prototype.invoke = function (event) {\n     if (list) {\n         if (list.length === 1) {\n             callingFunc = list[0];\n-            callingFunc.call && callingFunc.call(event.currentTarget, event);\n+            if (callingFunc.call) {\n+                callingFunc.call(event.currentTarget, event);\n+            }\n         }\n         else {\n             endIndex = list.length - 1;\n             if (key === cc.Director.EVENT_COMPONENT_UPDATE) {\n                 for (i = 1; i <= endIndex; i += 2) {\n                     target = list[i];\n-                    target.update(event.detail);\n+                    if (target.update) {","path":"cocos2d/core/event/event-listeners.js","position":15,"original_position":15,"commit_id":"edbea7e688c751953cd391fd61f6384d8ea22f97","original_commit_id":"edbea7e688c751953cd391fd61f6384d8ea22f97","user":{"login":"jareguo","id":1503156,"avatar_url":"https://avatars.githubusercontent.com/u/1503156?v=3","gravatar_id":"","url":"https://api.github.com/users/jareguo","html_url":"https://github.com/jareguo","followers_url":"https://api.github.com/users/jareguo/followers","following_url":"https://api.github.com/users/jareguo/following{/other_user}","gists_url":"https://api.github.com/users/jareguo/gists{/gist_id}","starred_url":"https://api.github.com/users/jareguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jareguo/subscriptions","organizations_url":"https://api.github.com/users/jareguo/orgs","repos_url":"https://api.github.com/users/jareguo/repos","events_url":"https://api.github.com/users/jareguo/events{/privacy}","received_events_url":"https://api.github.com/users/jareguo/received_events","type":"User","site_admin":false},"body":"那样的话，不是应该判断 if (target !== REMOVE_PLACEHOLDER) 吗？否则如果 REMOVE_PLACEHOLDER 将来变成 undefine，这里又出错了","created_at":"2016-05-24T13:33:51Z","updated_at":"2016-05-24T13:33:51Z","html_url":"https://github.com/cocos-creator/engine/pull/722#discussion_r64390618","pull_request_url":"https://api.github.com/repos/cocos-creator/engine/pulls/722","_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/comments/64390618"},"html":{"href":"https://github.com/cocos-creator/engine/pull/722#discussion_r64390618"},"pull_request":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/722"}}},"pull_request":{"url":"https://api.github.com/repos/cocos-creator/engine/pulls/722","id":71190722,"html_url":"https://github.com/cocos-creator/engine/pull/722","diff_url":"https://github.com/cocos-creator/engine/pull/722.diff","patch_url":"https://github.com/cocos-creator/engine/pull/722.patch","issue_url":"https://api.github.com/repos/cocos-creator/engine/issues/722","number":722,"state":"open","locked":false,"title":"Fix target not verified issue in event-listeners","user":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars.githubusercontent.com/u/632460?v=3","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"body":"Changes proposed in this pull request:\r\n * Fix target not verified issue in event-listeners https://github.com/cocos-creator/engine/pull/714\r\n\r\n> Makes sure these boxes are checked before submitting your PR - thank you!\r\n>\r\n- [x] Check that your javascript is following our [style guide](https://github.com/cocos-creator/fireball/blob/dev/.github/CONTRIBUTING.md) and end files with a newline\r\n- [x] Document new code with comments in source code based on [API Docs](https://github.com/cocos-creator/fireball#api-docs)\r\n- [x] If your pull request has gone \"stale\", you should **rebase** your work on top of the latest version of the upstream branch.\r\n- [x] If your commit history is full of small, unimportant commits (such as \"fix pep8\" or \"update tests\"), **squash** your commits down to a few, or one, discreet changesets before submitting a pull request.\r\n\r\n@cocos-creator/engine-admins\r\n\r\n","created_at":"2016-05-24T09:55:58Z","updated_at":"2016-05-24T13:33:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ced6ddbdea5cbefbf3af7cbaee1e6d949dfe2cc9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cocos-creator/engine/pulls/722/commits","review_comments_url":"https://api.github.com/repos/cocos-creator/engine/pulls/722/comments","review_comment_url":"https://api.github.com/repos/cocos-creator/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos-creator/engine/issues/722/comments","statuses_url":"https://api.github.com/repos/cocos-creator/engine/statuses/edbea7e688c751953cd391fd61f6384d8ea22f97","head":{"label":"pandamicro:master","ref":"master","sha":"edbea7e688c751953cd391fd61f6384d8ea22f97","user":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars.githubusercontent.com/u/632460?v=3","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"repo":{"id":54607274,"name":"fire-engine","full_name":"pandamicro/fire-engine","owner":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars.githubusercontent.com/u/632460?v=3","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pandamicro/fire-engine","description":"New integrated engine to replace cocos2d-html5","fork":true,"url":"https://api.github.com/repos/pandamicro/fire-engine","forks_url":"https://api.github.com/repos/pandamicro/fire-engine/forks","keys_url":"https://api.github.com/repos/pandamicro/fire-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandamicro/fire-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandamicro/fire-engine/teams","hooks_url":"https://api.github.com/repos/pandamicro/fire-engine/hooks","issue_events_url":"https://api.github.com/repos/pandamicro/fire-engine/issues/events{/number}","events_url":"https://api.github.com/repos/pandamicro/fire-engine/events","assignees_url":"https://api.github.com/repos/pandamicro/fire-engine/assignees{/user}","branches_url":"https://api.github.com/repos/pandamicro/fire-engine/branches{/branch}","tags_url":"https://api.github.com/repos/pandamicro/fire-engine/tags","blobs_url":"https://api.github.com/repos/pandamicro/fire-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandamicro/fire-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandamicro/fire-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandamicro/fire-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandamicro/fire-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/pandamicro/fire-engine/languages","stargazers_url":"https://api.github.com/repos/pandamicro/fire-engine/stargazers","contributors_url":"https://api.github.com/repos/pandamicro/fire-engine/contributors","subscribers_url":"https://api.github.com/repos/pandamicro/fire-engine/subscribers","subscription_url":"https://api.github.com/repos/pandamicro/fire-engine/subscription","commits_url":"https://api.github.com/repos/pandamicro/fire-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandamicro/fire-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandamicro/fire-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandamicro/fire-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandamicro/fire-engine/contents/{+path}","compare_url":"https://api.github.com/repos/pandamicro/fire-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandamicro/fire-engine/merges","archive_url":"https://api.github.com/repos/pandamicro/fire-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandamicro/fire-engine/downloads","issues_url":"https://api.github.com/repos/pandamicro/fire-engine/issues{/number}","pulls_url":"https://api.github.com/repos/pandamicro/fire-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/pandamicro/fire-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/pandamicro/fire-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandamicro/fire-engine/labels{/name}","releases_url":"https://api.github.com/repos/pandamicro/fire-engine/releases{/id}","deployments_url":"https://api.github.com/repos/pandamicro/fire-engine/deployments","created_at":"2016-03-24T02:06:28Z","updated_at":"2016-03-29T00:45:18Z","pushed_at":"2016-05-24T10:11:41Z","git_url":"git://github.com/pandamicro/fire-engine.git","ssh_url":"git@github.com:pandamicro/fire-engine.git","clone_url":"https://github.com/pandamicro/fire-engine.git","svn_url":"https://github.com/pandamicro/fire-engine","homepage":null,"size":23858,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cocos-creator:master","ref":"master","sha":"9748275004404b11f3b0efe6a6845a96bb054505","user":{"login":"cocos-creator","id":6937061,"avatar_url":"https://avatars.githubusercontent.com/u/6937061?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"repo":{"id":47440536,"name":"engine","full_name":"cocos-creator/engine","owner":{"login":"cocos-creator","id":6937061,"avatar_url":"https://avatars.githubusercontent.com/u/6937061?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos-creator/engine","description":"The engine for Cocos Creator","fork":false,"url":"https://api.github.com/repos/cocos-creator/engine","forks_url":"https://api.github.com/repos/cocos-creator/engine/forks","keys_url":"https://api.github.com/repos/cocos-creator/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos-creator/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos-creator/engine/teams","hooks_url":"https://api.github.com/repos/cocos-creator/engine/hooks","issue_events_url":"https://api.github.com/repos/cocos-creator/engine/issues/events{/number}","events_url":"https://api.github.com/repos/cocos-creator/engine/events","assignees_url":"https://api.github.com/repos/cocos-creator/engine/assignees{/user}","branches_url":"https://api.github.com/repos/cocos-creator/engine/branches{/branch}","tags_url":"https://api.github.com/repos/cocos-creator/engine/tags","blobs_url":"https://api.github.com/repos/cocos-creator/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos-creator/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos-creator/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos-creator/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos-creator/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos-creator/engine/languages","stargazers_url":"https://api.github.com/repos/cocos-creator/engine/stargazers","contributors_url":"https://api.github.com/repos/cocos-creator/engine/contributors","subscribers_url":"https://api.github.com/repos/cocos-creator/engine/subscribers","subscription_url":"https://api.github.com/repos/cocos-creator/engine/subscription","commits_url":"https://api.github.com/repos/cocos-creator/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos-creator/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos-creator/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos-creator/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos-creator/engine/contents/{+path}","compare_url":"https://api.github.com/repos/cocos-creator/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos-creator/engine/merges","archive_url":"https://api.github.com/repos/cocos-creator/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos-creator/engine/downloads","issues_url":"https://api.github.com/repos/cocos-creator/engine/issues{/number}","pulls_url":"https://api.github.com/repos/cocos-creator/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos-creator/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos-creator/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos-creator/engine/labels{/name}","releases_url":"https://api.github.com/repos/cocos-creator/engine/releases{/id}","deployments_url":"https://api.github.com/repos/cocos-creator/engine/deployments","created_at":"2015-12-05T03:28:59Z","updated_at":"2016-05-23T02:58:55Z","pushed_at":"2016-05-24T10:23:24Z","git_url":"git://github.com/cocos-creator/engine.git","ssh_url":"git@github.com:cocos-creator/engine.git","clone_url":"https://github.com/cocos-creator/engine.git","svn_url":"https://github.com/cocos-creator/engine","homepage":"http://www.cocos2d-x.org/creator","size":24564,"stargazers_count":58,"watchers_count":58,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":5,"forks":27,"open_issues":5,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/722"},"html":{"href":"https://github.com/cocos-creator/engine/pull/722"},"issue":{"href":"https://api.github.com/repos/cocos-creator/engine/issues/722"},"comments":{"href":"https://api.github.com/repos/cocos-creator/engine/issues/722/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/722/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/722/commits"},"statuses":{"href":"https://api.github.com/repos/cocos-creator/engine/statuses/edbea7e688c751953cd391fd61f6384d8ea22f97"}}}}
{"actor":{"display_login":"jareguo"}}