{"action":"created","issue":{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/178","repository_url":"https://api.github.com/repos/01org/TPM2.0-TSS","labels_url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/178/labels{/name}","comments_url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/178/comments","events_url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/178/events","html_url":"https://github.com/01org/TPM2.0-TSS/issues/178","id":145070255,"number":178,"title":"Undefined symbol in TCTIs: commandCodeStrings","user":{"login":"flihp","id":1550813,"avatar_url":"https://avatars.githubusercontent.com/u/1550813?v=3","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"flihp","id":1550813,"avatar_url":"https://avatars.githubusercontent.com/u/1550813?v=3","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/milestones/4","html_url":"https://github.com/01org/TPM2.0-TSS/milestones/packaging","labels_url":"https://api.github.com/repos/01org/TPM2.0-TSS/milestones/4/labels","id":1313603,"number":4,"title":"packaging","description":"A collection of tasks that need to be accomplished to aid package maintainers for various distros. This means getting things like headers and libraries installed in the right place when someone invokes 'make install'.","creator":{"login":"flihp","id":1550813,"avatar_url":"https://avatars.githubusercontent.com/u/1550813?v=3","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":24,"state":"open","created_at":"2015-09-18T15:36:50Z","updated_at":"2016-04-05T16:44:11Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-04-01T02:39:39Z","updated_at":"2016-04-05T16:44:11Z","closed_at":"2016-04-05T16:44:11Z","body":"This array is used to map TPM command codes to human readable strings. Given where it lives (https://github.com/01org/TPM2.0-TSS/blob/master/sysapi/sysapi_util/debug.c) it's probably for debug purposes. Exposing this data from libtss2 implicitly while having the TCTIs declare it as extern makes it a hidden part of our API. Worse yet it requires that libraries using libtss2 and wanting this function have unresolved symbols. This should be avoided if at all possible.\r\n\r\nTry wrapping this in a function, exposing it through the tss2 headers (a specific 'debug' or 'util' header?).\r\n"},"comment":{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/comments/205888808","html_url":"https://github.com/01org/TPM2.0-TSS/issues/178#issuecomment-205888808","issue_url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/178","id":205888808,"user":{"login":"flihp","id":1550813,"avatar_url":"https://avatars.githubusercontent.com/u/1550813?v=3","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"created_at":"2016-04-05T16:44:11Z","updated_at":"2016-04-05T16:44:11Z","body":"fixed by cbf4975ac05781244dcdf707b357cad3dc6b8cd2"}}