{"action":"created","comment":{"url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/comments/71847501","id":71847501,"diff_hunk":"@@ -10,6 +10,12 @@ define command {\n        command_line   /opt/rhmap/nagios/plugins/fh-check-component-health.sh $ARG1$ 8080\n }\n \n+# Check for valid response from Memcached\n+define command {\n+       command_name   check_memcached\n+       command_line   $USER1$/check_tcp -H memcached -p $ARG1$ -E -s 'version\\n' -e 'VERSION' -w2 -c5 -t5","path":"fhservices.cfg.j2","position":7,"original_position":7,"commit_id":"b034fdb9024aad8dabf8a6b58d2f1db0c5797b4d","original_commit_id":"b034fdb9024aad8dabf8a6b58d2f1db0c5797b4d","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"body":"What are those version arguments?\r\n\r\nWhat do the thresholds mean? 2 and 5.","created_at":"2016-07-22T08:57:03Z","updated_at":"2016-07-22T08:57:03Z","html_url":"https://github.com/feedhenry/nagios-container/pull/15#discussion_r71847501","pull_request_url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/comments/71847501"},"html":{"href":"https://github.com/feedhenry/nagios-container/pull/15#discussion_r71847501"},"pull_request":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/15","id":78443670,"html_url":"https://github.com/feedhenry/nagios-container/pull/15","diff_url":"https://github.com/feedhenry/nagios-container/pull/15.diff","patch_url":"https://github.com/feedhenry/nagios-container/pull/15.patch","issue_url":"https://api.github.com/repos/feedhenry/nagios-container/issues/15","number":15,"state":"open","locked":false,"title":"Adding tcp check for memcached","user":{"login":"pmccarthy","id":1999769,"avatar_url":"https://avatars.githubusercontent.com/u/1999769?v=3","gravatar_id":"","url":"https://api.github.com/users/pmccarthy","html_url":"https://github.com/pmccarthy","followers_url":"https://api.github.com/users/pmccarthy/followers","following_url":"https://api.github.com/users/pmccarthy/following{/other_user}","gists_url":"https://api.github.com/users/pmccarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/pmccarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmccarthy/subscriptions","organizations_url":"https://api.github.com/users/pmccarthy/orgs","repos_url":"https://api.github.com/users/pmccarthy/repos","events_url":"https://api.github.com/users/pmccarthy/events{/privacy}","received_events_url":"https://api.github.com/users/pmccarthy/received_events","type":"User","site_admin":false},"body":"As check uses the existing nagios check_tcp plugin, there was no need for additional python plugins. Only change required was a new command and service in the fhservices.cfg.j2 file\r\n\r\n@jessesarn @mikenairn @rhcarvalho mind taking a look?","created_at":"2016-07-22T08:47:28Z","updated_at":"2016-07-22T08:57:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59bceffc6579b4cd5ab76a3003a8a4f8aae05e88","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/15/commits","review_comments_url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/15/comments","review_comment_url":"https://api.github.com/repos/feedhenry/nagios-container/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feedhenry/nagios-container/issues/15/comments","statuses_url":"https://api.github.com/repos/feedhenry/nagios-container/statuses/b034fdb9024aad8dabf8a6b58d2f1db0c5797b4d","head":{"label":"pmccarthy:RHMAP-8090_add_memcache_tcp_check","ref":"RHMAP-8090_add_memcache_tcp_check","sha":"b034fdb9024aad8dabf8a6b58d2f1db0c5797b4d","user":{"login":"pmccarthy","id":1999769,"avatar_url":"https://avatars.githubusercontent.com/u/1999769?v=3","gravatar_id":"","url":"https://api.github.com/users/pmccarthy","html_url":"https://github.com/pmccarthy","followers_url":"https://api.github.com/users/pmccarthy/followers","following_url":"https://api.github.com/users/pmccarthy/following{/other_user}","gists_url":"https://api.github.com/users/pmccarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/pmccarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmccarthy/subscriptions","organizations_url":"https://api.github.com/users/pmccarthy/orgs","repos_url":"https://api.github.com/users/pmccarthy/repos","events_url":"https://api.github.com/users/pmccarthy/events{/privacy}","received_events_url":"https://api.github.com/users/pmccarthy/received_events","type":"User","site_admin":false},"repo":{"id":63788845,"name":"nagios-container","full_name":"pmccarthy/nagios-container","owner":{"login":"pmccarthy","id":1999769,"avatar_url":"https://avatars.githubusercontent.com/u/1999769?v=3","gravatar_id":"","url":"https://api.github.com/users/pmccarthy","html_url":"https://github.com/pmccarthy","followers_url":"https://api.github.com/users/pmccarthy/followers","following_url":"https://api.github.com/users/pmccarthy/following{/other_user}","gists_url":"https://api.github.com/users/pmccarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/pmccarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmccarthy/subscriptions","organizations_url":"https://api.github.com/users/pmccarthy/orgs","repos_url":"https://api.github.com/users/pmccarthy/repos","events_url":"https://api.github.com/users/pmccarthy/events{/privacy}","received_events_url":"https://api.github.com/users/pmccarthy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmccarthy/nagios-container","description":"RHMAP Core Monitoring ","fork":true,"url":"https://api.github.com/repos/pmccarthy/nagios-container","forks_url":"https://api.github.com/repos/pmccarthy/nagios-container/forks","keys_url":"https://api.github.com/repos/pmccarthy/nagios-container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmccarthy/nagios-container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmccarthy/nagios-container/teams","hooks_url":"https://api.github.com/repos/pmccarthy/nagios-container/hooks","issue_events_url":"https://api.github.com/repos/pmccarthy/nagios-container/issues/events{/number}","events_url":"https://api.github.com/repos/pmccarthy/nagios-container/events","assignees_url":"https://api.github.com/repos/pmccarthy/nagios-container/assignees{/user}","branches_url":"https://api.github.com/repos/pmccarthy/nagios-container/branches{/branch}","tags_url":"https://api.github.com/repos/pmccarthy/nagios-container/tags","blobs_url":"https://api.github.com/repos/pmccarthy/nagios-container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmccarthy/nagios-container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmccarthy/nagios-container/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmccarthy/nagios-container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmccarthy/nagios-container/statuses/{sha}","languages_url":"https://api.github.com/repos/pmccarthy/nagios-container/languages","stargazers_url":"https://api.github.com/repos/pmccarthy/nagios-container/stargazers","contributors_url":"https://api.github.com/repos/pmccarthy/nagios-container/contributors","subscribers_url":"https://api.github.com/repos/pmccarthy/nagios-container/subscribers","subscription_url":"https://api.github.com/repos/pmccarthy/nagios-container/subscription","commits_url":"https://api.github.com/repos/pmccarthy/nagios-container/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmccarthy/nagios-container/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmccarthy/nagios-container/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmccarthy/nagios-container/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmccarthy/nagios-container/contents/{+path}","compare_url":"https://api.github.com/repos/pmccarthy/nagios-container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmccarthy/nagios-container/merges","archive_url":"https://api.github.com/repos/pmccarthy/nagios-container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmccarthy/nagios-container/downloads","issues_url":"https://api.github.com/repos/pmccarthy/nagios-container/issues{/number}","pulls_url":"https://api.github.com/repos/pmccarthy/nagios-container/pulls{/number}","milestones_url":"https://api.github.com/repos/pmccarthy/nagios-container/milestones{/number}","notifications_url":"https://api.github.com/repos/pmccarthy/nagios-container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmccarthy/nagios-container/labels{/name}","releases_url":"https://api.github.com/repos/pmccarthy/nagios-container/releases{/id}","deployments_url":"https://api.github.com/repos/pmccarthy/nagios-container/deployments","created_at":"2016-07-20T14:37:13Z","updated_at":"2016-07-20T14:37:14Z","pushed_at":"2016-07-22T08:46:46Z","git_url":"git://github.com/pmccarthy/nagios-container.git","ssh_url":"git@github.com:pmccarthy/nagios-container.git","clone_url":"https://github.com/pmccarthy/nagios-container.git","svn_url":"https://github.com/pmccarthy/nagios-container","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feedhenry:master","ref":"master","sha":"acdfb9c91b8cc035384be101c2914caba5a3fbd4","user":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"repo":{"id":63078110,"name":"nagios-container","full_name":"feedhenry/nagios-container","owner":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry/nagios-container","description":"RHMAP Core Monitoring ","fork":false,"url":"https://api.github.com/repos/feedhenry/nagios-container","forks_url":"https://api.github.com/repos/feedhenry/nagios-container/forks","keys_url":"https://api.github.com/repos/feedhenry/nagios-container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry/nagios-container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry/nagios-container/teams","hooks_url":"https://api.github.com/repos/feedhenry/nagios-container/hooks","issue_events_url":"https://api.github.com/repos/feedhenry/nagios-container/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry/nagios-container/events","assignees_url":"https://api.github.com/repos/feedhenry/nagios-container/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry/nagios-container/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry/nagios-container/tags","blobs_url":"https://api.github.com/repos/feedhenry/nagios-container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry/nagios-container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry/nagios-container/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry/nagios-container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry/nagios-container/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry/nagios-container/languages","stargazers_url":"https://api.github.com/repos/feedhenry/nagios-container/stargazers","contributors_url":"https://api.github.com/repos/feedhenry/nagios-container/contributors","subscribers_url":"https://api.github.com/repos/feedhenry/nagios-container/subscribers","subscription_url":"https://api.github.com/repos/feedhenry/nagios-container/subscription","commits_url":"https://api.github.com/repos/feedhenry/nagios-container/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry/nagios-container/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry/nagios-container/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry/nagios-container/issues/comments{/number}","contents_url":"https://api.github.com/repos/feedhenry/nagios-container/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry/nagios-container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry/nagios-container/merges","archive_url":"https://api.github.com/repos/feedhenry/nagios-container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry/nagios-container/downloads","issues_url":"https://api.github.com/repos/feedhenry/nagios-container/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry/nagios-container/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry/nagios-container/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry/nagios-container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry/nagios-container/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry/nagios-container/releases{/id}","deployments_url":"https://api.github.com/repos/feedhenry/nagios-container/deployments","created_at":"2016-07-11T15:09:01Z","updated_at":"2016-07-14T13:21:01Z","pushed_at":"2016-07-22T08:47:28Z","git_url":"git://github.com/feedhenry/nagios-container.git","ssh_url":"git@github.com:feedhenry/nagios-container.git","clone_url":"https://github.com/feedhenry/nagios-container.git","svn_url":"https://github.com/feedhenry/nagios-container","homepage":null,"size":51,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/15"},"html":{"href":"https://github.com/feedhenry/nagios-container/pull/15"},"issue":{"href":"https://api.github.com/repos/feedhenry/nagios-container/issues/15"},"comments":{"href":"https://api.github.com/repos/feedhenry/nagios-container/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feedhenry/nagios-container/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/feedhenry/nagios-container/statuses/b034fdb9024aad8dabf8a6b58d2f1db0c5797b4d"}}}}
{"actor":{"display_login":"rhcarvalho"}}