{"action":"created","issue":{"url":"https://api.github.com/repos/thredded/thredded/issues/442","repository_url":"https://api.github.com/repos/thredded/thredded","labels_url":"https://api.github.com/repos/thredded/thredded/issues/442/labels{/name}","comments_url":"https://api.github.com/repos/thredded/thredded/issues/442/comments","events_url":"https://api.github.com/repos/thredded/thredded/issues/442/events","html_url":"https://github.com/thredded/thredded/pull/442","id":186233149,"number":442,"title":"Configurable notifiers","user":{"login":"timdiggins","id":18395,"avatar_url":"https://avatars.githubusercontent.com/u/18395?v=3","gravatar_id":"","url":"https://api.github.com/users/timdiggins","html_url":"https://github.com/timdiggins","followers_url":"https://api.github.com/users/timdiggins/followers","following_url":"https://api.github.com/users/timdiggins/following{/other_user}","gists_url":"https://api.github.com/users/timdiggins/gists{/gist_id}","starred_url":"https://api.github.com/users/timdiggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timdiggins/subscriptions","organizations_url":"https://api.github.com/users/timdiggins/orgs","repos_url":"https://api.github.com/users/timdiggins/repos","events_url":"https://api.github.com/users/timdiggins/events{/privacy}","received_events_url":"https://api.github.com/users/timdiggins/received_events","type":"User","site_admin":false},"labels":[{"id":170759971,"url":"https://api.github.com/repos/thredded/thredded/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/thredded/thredded/milestones/16","html_url":"https://github.com/thredded/thredded/milestones/v0.9.0","labels_url":"https://api.github.com/repos/thredded/thredded/milestones/16/labels","id":2131471,"number":16,"title":"v0.9.0","description":"","creator":{"login":"glebm","id":216339,"avatar_url":"https://avatars.githubusercontent.com/u/216339?v=3","gravatar_id":"","url":"https://api.github.com/users/glebm","html_url":"https://github.com/glebm","followers_url":"https://api.github.com/users/glebm/followers","following_url":"https://api.github.com/users/glebm/following{/other_user}","gists_url":"https://api.github.com/users/glebm/gists{/gist_id}","starred_url":"https://api.github.com/users/glebm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glebm/subscriptions","organizations_url":"https://api.github.com/users/glebm/orgs","repos_url":"https://api.github.com/users/glebm/repos","events_url":"https://api.github.com/users/glebm/events{/privacy}","received_events_url":"https://api.github.com/users/glebm/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-11-13T04:14:26Z","updated_at":"2016-11-13T17:37:54Z","due_on":"2016-12-05T00:00:00Z","closed_at":null},"comments":11,"created_at":"2016-10-31T08:55:38Z","updated_at":"2016-11-19T20:13:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thredded/thredded/pulls/442","html_url":"https://github.com/thredded/thredded/pull/442","diff_url":"https://github.com/thredded/thredded/pull/442.diff","patch_url":"https://github.com/thredded/thredded/pull/442.patch"},"body":"See https://github.com/thredded/thredded/issues/441.\r\nAllows notifiers which could be external plugins. A few small todos, but would be grateful of comments.\r\n\r\n* [x] code duplication from codeclimate\r\n* [x] add instructions in README for adding notifiers\r\n* [x] allow notifiers to be set to empty array (and hide notification preferences) - with feature spec\r\n* [x] serialize everything (not just non default), but still marshall back with defaults\r\n*  ~~(possibly) allow configuration to change default for each field from true to false!~~\r\n* [x] left over code (see comments below) and i18n clean up, double check portuguese changes.\r\n* [x]  (possibly) shared examples (and base class?) to aid notifier writers: :responds to known methods, key has no whitespace, human_name returns string, config\r\n* [x] nicer access to i18n_key (human_key and mechanism to access in views)\r\n* [x] perf issues in commands (exclusion)\r\n* [x] fail early when notifier isn't going to be adequate\r\n\r\n<img width=\"743\" alt=\"notification_settings___thredded_demo\" src=\"https://cloud.githubusercontent.com/assets/18395/19848784/9e9d474e-9f47-11e6-9d5a-e2401ce7c600.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/thredded/thredded/issues/comments/261736664","html_url":"https://github.com/thredded/thredded/pull/442#issuecomment-261736664","issue_url":"https://api.github.com/repos/thredded/thredded/issues/442","id":261736664,"user":{"login":"glebm","id":216339,"avatar_url":"https://avatars.githubusercontent.com/u/216339?v=3","gravatar_id":"","url":"https://api.github.com/users/glebm","html_url":"https://github.com/glebm","followers_url":"https://api.github.com/users/glebm/followers","following_url":"https://api.github.com/users/glebm/following{/other_user}","gists_url":"https://api.github.com/users/glebm/gists{/gist_id}","starred_url":"https://api.github.com/users/glebm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glebm/subscriptions","organizations_url":"https://api.github.com/users/glebm/orgs","repos_url":"https://api.github.com/users/glebm/repos","events_url":"https://api.github.com/users/glebm/events{/privacy}","received_events_url":"https://api.github.com/users/glebm/received_events","type":"User","site_admin":false},"created_at":"2016-11-19T20:13:56Z","updated_at":"2016-11-19T20:13:56Z","body":"Merged! :tada: \r\n\r\nDid it manually (https://github.com/thredded/thredded/pull/481) because I had added a new conflict when fixing #480!"}}
{"actor":{"display_login":"glebm"}}