{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/78928472","id":78928472,"diff_hunk":"@@ -4,8 +4,170 @@\n \n module Carto\n   describe Form do\n-    it 'handles inexistent geometry types' do\n-      expect { Carto::Form.new('patata') }.to raise_error('Carto::Forms: No form for geometry type: \\'patata\\'')\n+    let(:point_form) do\n+      {\n+        \"fill\" => {\n+          \"size\" => {\n+            \"fixed\" => 7\n+          },\n+          \"color\" => {\n+            \"fixed\" => \"#FFB927\",\n+            \"opacity\" => 0.9\n+          }\n+        },\n+        \"stroke\" => {\n+          \"size\" => {\n+            \"fixed\" => 1\n+          },\n+          \"color\" => {\n+            \"fixed\" => \"#FFF\",\n+            \"opacity\" => 1\n+          }\n+        },\n+        \"blending\" => \"none\",\n+        \"aggregation\" => {},\n+        \"labels\" => {\n+          \"enabled\" => false,\n+          \"attribute\" => nil,\n+          \"font\" => \"DejaVu Sans Book\",\n+          \"fill\" => {\n+            \"size\" => {\n+              \"fixed\" => 10\n+            },\n+            \"color\" => {\n+              \"fixed\" => \"#FFFFFF\",\n+              \"opacity\" => 1\n+            }\n+          },\n+          \"halo\" => {\n+            \"size\" => {\n+              \"fixed\" => 1\n+            },\n+            \"color\" => {\n+              \"fixed\" => \"#6F808D\",\n+              \"opacity\" => 1\n+            }\n+          },\n+          \"offset\" => -10,\n+          \"overlap\" => true,\n+          \"placement\" => \"point\"\n+        }\n+      }\n+    end\n+\n+    let(:polygon_form) do\n+      {\n+        \"fill\" => {\n+          \"color\" => {\n+            \"fixed\" => \"#374C70\",\n+            \"opacity\" => 0.9\n+          }\n+        },\n+        \"stroke\" => {\n+          \"size\" => {\n+            \"fixed\" => 1\n+          },\n+          \"color\" => {\n+            \"fixed\" => \"#FFF\",\n+            \"opacity\" => 0.5\n+          }\n+        },\n+        \"blending\" => \"none\",\n+        \"aggregation\" => {},\n+        \"labels\" => {\n+          \"enabled\" => false,\n+          \"attribute\" => nil,\n+          \"font\" => \"DejaVu Sans Book\",\n+          \"fill\" => {\n+            \"size\" => {\n+              \"fixed\" => 10\n+            },\n+            \"color\" => {\n+              \"fixed\" => \"#FFFFFF\",\n+              \"opacity\" => 1\n+            }\n+          },\n+          \"halo\" => {\n+            \"size\" => {\n+              \"fixed\" => 1\n+            },\n+            \"color\" => {\n+              \"fixed\" => \"#6F808D\",\n+              \"opacity\" => 1\n+            }\n+          },\n+          \"offset\" => -10,\n+          \"overlap\" => true,\n+          \"placement\" => \"point\"\n+        }\n+      }\n+    end\n+\n+    let(:line_form) do\n+      {\n+        \"fill\" => {},\n+        \"stroke\" => {\n+          \"size\" => {\n+            \"fixed\" => 1.5\n+          },\n+          \"color\" => {\n+            \"fixed\" => \"#3EBCAE\",\n+            \"opacity\" => 1\n+          }\n+        },\n+        \"blending\" => \"none\",\n+        \"aggregation\" => {},\n+        \"labels\" => {\n+          \"enabled\" => false,\n+          \"attribute\" => nil,\n+          \"font\" => \"DejaVu Sans Book\",\n+          \"fill\" => {\n+            \"size\" => {\n+              \"fixed\" => 10\n+            },\n+            \"color\" => {\n+              \"fixed\" => \"#FFFFFF\",\n+              \"opacity\" => 1\n+            }\n+          },\n+          \"halo\" => {\n+            \"size\" => {\n+              \"fixed\" => 1\n+            },\n+            \"color\" => {\n+              \"fixed\" => \"#6F808D\",\n+              \"opacity\" => 1\n+            }\n+          },\n+          \"offset\" => -10,\n+          \"overlap\" => true,\n+          \"placement\" => \"point\"\n+        }\n+      }\n+    end\n+\n+    it 'return point form if inexisting type is specified' do\n+      form = Carto::Form.new('geometry')\n+\n+      form.to_hash.should eq Carto::Form.new('point').to_hash","path":"spec/lib/carto/form_spec.rb","position":151,"original_position":151,"commit_id":"f4dc0702bb98e7bb9bfe393ccb1df11b1d09de4f","original_commit_id":"f4dc0702bb98e7bb9bfe393ccb1df11b1d09de4f","user":{"login":"javitonino","id":7569673,"avatar_url":"https://avatars.githubusercontent.com/u/7569673?v=3","gravatar_id":"","url":"https://api.github.com/users/javitonino","html_url":"https://github.com/javitonino","followers_url":"https://api.github.com/users/javitonino/followers","following_url":"https://api.github.com/users/javitonino/following{/other_user}","gists_url":"https://api.github.com/users/javitonino/gists{/gist_id}","starred_url":"https://api.github.com/users/javitonino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javitonino/subscriptions","organizations_url":"https://api.github.com/users/javitonino/orgs","repos_url":"https://api.github.com/users/javitonino/repos","events_url":"https://api.github.com/users/javitonino/events{/privacy}","received_events_url":"https://api.github.com/users/javitonino/received_events","type":"User","site_admin":false},"body":"Why not `point_form`?","created_at":"2016-09-15T10:02:49Z","updated_at":"2016-09-15T10:05:57Z","html_url":"https://github.com/CartoDB/cartodb/pull/9770#discussion_r78928472","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/9770","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/78928472"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/9770#discussion_r78928472"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/9770"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/9770","id":85373045,"html_url":"https://github.com/CartoDB/cartodb/pull/9770","diff_url":"https://github.com/CartoDB/cartodb/pull/9770.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/9770.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/9770","number":9770,"state":"open","locked":false,"title":"default form should be point","user":{"login":"gfiorav","id":4222826,"avatar_url":"https://avatars.githubusercontent.com/u/4222826?v=3","gravatar_id":"","url":"https://api.github.com/users/gfiorav","html_url":"https://github.com/gfiorav","followers_url":"https://api.github.com/users/gfiorav/followers","following_url":"https://api.github.com/users/gfiorav/following{/other_user}","gists_url":"https://api.github.com/users/gfiorav/gists{/gist_id}","starred_url":"https://api.github.com/users/gfiorav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfiorav/subscriptions","organizations_url":"https://api.github.com/users/gfiorav/orgs","repos_url":"https://api.github.com/users/gfiorav/repos","events_url":"https://api.github.com/users/gfiorav/events{/privacy}","received_events_url":"https://api.github.com/users/gfiorav/received_events","type":"User","site_admin":false},"body":"Please CR @javitonino ","created_at":"2016-09-15T09:43:08Z","updated_at":"2016-09-15T10:05:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a09ce3874fa4a6db3b954afa67fe0e715237b15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/9770/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/9770/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/9770/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/f4dc0702bb98e7bb9bfe393ccb1df11b1d09de4f","head":{"label":"CartoDB:default-form-is-point","ref":"default-form-is-point","sha":"f4dc0702bb98e7bb9bfe393ccb1df11b1d09de4f","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2016-09-13T19:18:04Z","pushed_at":"2016-09-15T09:58:28Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":400429,"stargazers_count":1259,"watchers_count":1259,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":1079,"forks":323,"open_issues":1079,"watchers":1259,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"5972e611d323d196ef226a27e3fb3fd3bcaf4816","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2016-09-13T19:18:04Z","pushed_at":"2016-09-15T09:58:28Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":400429,"stargazers_count":1259,"watchers_count":1259,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":1079,"forks":323,"open_issues":1079,"watchers":1259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/9770"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/9770"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/9770"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/9770/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/9770/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/9770/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/f4dc0702bb98e7bb9bfe393ccb1df11b1d09de4f"}}}}
{"actor":{"display_login":"javitonino"}}