{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/3770","repository_url":"https://api.github.com/repos/minetest/minetest","labels_url":"https://api.github.com/repos/minetest/minetest/issues/3770/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3770/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/3770/events","html_url":"https://github.com/minetest/minetest/pull/3770","id":135627805,"number":3770,"title":"Fix superflous shader setting updates","user":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Client%20/%20Audiovisuals","name":"@ Client / Audiovisuals","color":"009800"},{"url":"https://api.github.com/repos/minetest/minetest/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/minetest/minetest/labels/Performance","name":"Performance","color":"ffff00"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/minetest/minetest/milestones/7","html_url":"https://github.com/minetest/minetest/milestones/0.4.14","labels_url":"https://api.github.com/repos/minetest/minetest/milestones/7/labels","id":1601315,"number":7,"title":"0.4.14","description":"This milestone for issues which should get resolved before the 0.4.14 release.","creator":{"login":"kahrl","id":630411,"avatar_url":"https://avatars.githubusercontent.com/u/630411?v=3","gravatar_id":"","url":"https://api.github.com/users/kahrl","html_url":"https://github.com/kahrl","followers_url":"https://api.github.com/users/kahrl/followers","following_url":"https://api.github.com/users/kahrl/following{/other_user}","gists_url":"https://api.github.com/users/kahrl/gists{/gist_id}","starred_url":"https://api.github.com/users/kahrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kahrl/subscriptions","organizations_url":"https://api.github.com/users/kahrl/orgs","repos_url":"https://api.github.com/users/kahrl/repos","events_url":"https://api.github.com/users/kahrl/events{/privacy}","received_events_url":"https://api.github.com/users/kahrl/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":0,"state":"open","created_at":"2016-02-23T23:07:27Z","updated_at":"2016-02-24T12:08:10Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2016-02-23T04:23:39Z","updated_at":"2016-02-24T22:33:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3770","html_url":"https://github.com/minetest/minetest/pull/3770","diff_url":"https://github.com/minetest/minetest/pull/3770.diff","patch_url":"https://github.com/minetest/minetest/pull/3770.patch"},"body":"This improves rendering performance by ~40% acording to @gregorycu.\r\n\r\nRebased version of #2375 with some changes like replacing `SkyBackgroundColorProvider` with a pointer to a pointer and simplifying the `Cached*ShaderSetting` code.  The factory stuff seems to acutally be necessary to ensure that each shader has it's own `CachedShaderSetting` though.\r\n\r\nThis makes paralax mapping glitchy on leveled snow nodes (randomly switches intensity and sometimes gets a wavy effect), I'm not sure how to fix this though.  @RealBadAngel: care to take a look?\r\n"},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/188488790","html_url":"https://github.com/minetest/minetest/pull/3770#issuecomment-188488790","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3770","id":188488790,"user":{"login":"Fixer-007","id":16494741,"avatar_url":"https://avatars.githubusercontent.com/u/16494741?v=3","gravatar_id":"","url":"https://api.github.com/users/Fixer-007","html_url":"https://github.com/Fixer-007","followers_url":"https://api.github.com/users/Fixer-007/followers","following_url":"https://api.github.com/users/Fixer-007/following{/other_user}","gists_url":"https://api.github.com/users/Fixer-007/gists{/gist_id}","starred_url":"https://api.github.com/users/Fixer-007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fixer-007/subscriptions","organizations_url":"https://api.github.com/users/Fixer-007/orgs","repos_url":"https://api.github.com/users/Fixer-007/repos","events_url":"https://api.github.com/users/Fixer-007/events{/privacy}","received_events_url":"https://api.github.com/users/Fixer-007/received_events","type":"User","site_admin":false},"created_at":"2016-02-24T22:33:34Z","updated_at":"2016-02-24T22:33:34Z","body":"Lightning problem is still there: https://i.imgur.com/vxq8bGg.jpg (at least with VBO), will try to test without VBO"}}