{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/comments/59260224","id":59260224,"diff_hunk":"@@ -56,10 +58,6 @@ var (\n \t\t\"collect.info_schema.innodb_metrics\", false,\n \t\t\"Collect metrics from information_schema.innodb_metrics\",\n \t)\n-\tcollectGlobalStatus = flag.Bool(","path":"mysqld_exporter.go","position":null,"original_position":13,"commit_id":"04b244758e9f2746bde3c53c47cdb041f7c5798a","original_commit_id":"6764c357f7e46a8141726966bfd7fea57f19e0ea","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"It really boils down to whether there's someone using this code as a library that may want a different operational mode.\r\n\r\nIf it's just a random tuning variable, inside the file itself is fine. The node exporter ones fall under this, as plumbing them all into main wouldn't make sense, and noone is using it as a library.\r\n\r\nPrometheus has gone too far in the other direction and plumbed through everything to main, which just makes it harder to add flags. This has also lead to us having more hardcoded constants than we should have.","created_at":"2016-04-11T18:53:33Z","updated_at":"2016-04-11T18:53:33Z","html_url":"https://github.com/prometheus/mysqld_exporter/pull/110#discussion_r59260224","pull_request_url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/comments/59260224"},"html":{"href":"https://github.com/prometheus/mysqld_exporter/pull/110#discussion_r59260224"},"pull_request":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/110","id":65909481,"html_url":"https://github.com/prometheus/mysqld_exporter/pull/110","diff_url":"https://github.com/prometheus/mysqld_exporter/pull/110.diff","patch_url":"https://github.com/prometheus/mysqld_exporter/pull/110.patch","issue_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/110","number":110,"state":"open","locked":false,"title":"Refactor collectors","user":{"login":"SuperQ","id":1320667,"avatar_url":"https://avatars.githubusercontent.com/u/1320667?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperQ","html_url":"https://github.com/SuperQ","followers_url":"https://api.github.com/users/SuperQ/followers","following_url":"https://api.github.com/users/SuperQ/following{/other_user}","gists_url":"https://api.github.com/users/SuperQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperQ/subscriptions","organizations_url":"https://api.github.com/users/SuperQ/orgs","repos_url":"https://api.github.com/users/SuperQ/repos","events_url":"https://api.github.com/users/SuperQ/events{/privacy}","received_events_url":"https://api.github.com/users/SuperQ/received_events","type":"User","site_admin":false},"body":"Move `GLOBAL STATUS` scraper to a separate file.","created_at":"2016-04-10T12:47:22Z","updated_at":"2016-04-11T18:53:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c48330c226691df1f05f04df24abbb9d1991e80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/110/commits","review_comments_url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/110/comments","review_comment_url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/110/comments","statuses_url":"https://api.github.com/repos/prometheus/mysqld_exporter/statuses/04b244758e9f2746bde3c53c47cdb041f7c5798a","head":{"label":"prometheus:bjk/scrape_refactor","ref":"bjk/scrape_refactor","sha":"04b244758e9f2746bde3c53c47cdb041f7c5798a","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":32075541,"name":"mysqld_exporter","full_name":"prometheus/mysqld_exporter","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/mysqld_exporter","description":"Exporter for MySQL server metrics","fork":false,"url":"https://api.github.com/repos/prometheus/mysqld_exporter","forks_url":"https://api.github.com/repos/prometheus/mysqld_exporter/forks","keys_url":"https://api.github.com/repos/prometheus/mysqld_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/mysqld_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/mysqld_exporter/teams","hooks_url":"https://api.github.com/repos/prometheus/mysqld_exporter/hooks","issue_events_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/mysqld_exporter/events","assignees_url":"https://api.github.com/repos/prometheus/mysqld_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/mysqld_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/mysqld_exporter/tags","blobs_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/mysqld_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/mysqld_exporter/languages","stargazers_url":"https://api.github.com/repos/prometheus/mysqld_exporter/stargazers","contributors_url":"https://api.github.com/repos/prometheus/mysqld_exporter/contributors","subscribers_url":"https://api.github.com/repos/prometheus/mysqld_exporter/subscribers","subscription_url":"https://api.github.com/repos/prometheus/mysqld_exporter/subscription","commits_url":"https://api.github.com/repos/prometheus/mysqld_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/mysqld_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/mysqld_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/mysqld_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/mysqld_exporter/merges","archive_url":"https://api.github.com/repos/prometheus/mysqld_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/mysqld_exporter/downloads","issues_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/mysqld_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/mysqld_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/mysqld_exporter/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/mysqld_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/mysqld_exporter/deployments","created_at":"2015-03-12T12:23:48Z","updated_at":"2016-04-03T14:39:31Z","pushed_at":"2016-04-11T18:45:31Z","git_url":"git://github.com/prometheus/mysqld_exporter.git","ssh_url":"git@github.com:prometheus/mysqld_exporter.git","clone_url":"https://github.com/prometheus/mysqld_exporter.git","svn_url":"https://github.com/prometheus/mysqld_exporter","homepage":"http://prometheus.io/","size":928,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":10,"forks":18,"open_issues":10,"watchers":36,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"f0103834a540973e5fe7976e4b6a9611274e826a","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":32075541,"name":"mysqld_exporter","full_name":"prometheus/mysqld_exporter","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/mysqld_exporter","description":"Exporter for MySQL server metrics","fork":false,"url":"https://api.github.com/repos/prometheus/mysqld_exporter","forks_url":"https://api.github.com/repos/prometheus/mysqld_exporter/forks","keys_url":"https://api.github.com/repos/prometheus/mysqld_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/mysqld_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/mysqld_exporter/teams","hooks_url":"https://api.github.com/repos/prometheus/mysqld_exporter/hooks","issue_events_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/mysqld_exporter/events","assignees_url":"https://api.github.com/repos/prometheus/mysqld_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/mysqld_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/mysqld_exporter/tags","blobs_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/mysqld_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/mysqld_exporter/languages","stargazers_url":"https://api.github.com/repos/prometheus/mysqld_exporter/stargazers","contributors_url":"https://api.github.com/repos/prometheus/mysqld_exporter/contributors","subscribers_url":"https://api.github.com/repos/prometheus/mysqld_exporter/subscribers","subscription_url":"https://api.github.com/repos/prometheus/mysqld_exporter/subscription","commits_url":"https://api.github.com/repos/prometheus/mysqld_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/mysqld_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/mysqld_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/mysqld_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/mysqld_exporter/merges","archive_url":"https://api.github.com/repos/prometheus/mysqld_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/mysqld_exporter/downloads","issues_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/mysqld_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/mysqld_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/mysqld_exporter/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/mysqld_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/mysqld_exporter/deployments","created_at":"2015-03-12T12:23:48Z","updated_at":"2016-04-03T14:39:31Z","pushed_at":"2016-04-11T18:45:31Z","git_url":"git://github.com/prometheus/mysqld_exporter.git","ssh_url":"git@github.com:prometheus/mysqld_exporter.git","clone_url":"https://github.com/prometheus/mysqld_exporter.git","svn_url":"https://github.com/prometheus/mysqld_exporter","homepage":"http://prometheus.io/","size":928,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":10,"forks":18,"open_issues":10,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/110"},"html":{"href":"https://github.com/prometheus/mysqld_exporter/pull/110"},"issue":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/110"},"comments":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/statuses/04b244758e9f2746bde3c53c47cdb041f7c5798a"}}}}