{"action":"created","issue":{"url":"https://api.github.com/repos/robotframework/Selenium2Library/issues/696","repository_url":"https://api.github.com/repos/robotframework/Selenium2Library","labels_url":"https://api.github.com/repos/robotframework/Selenium2Library/issues/696/labels{/name}","comments_url":"https://api.github.com/repos/robotframework/Selenium2Library/issues/696/comments","events_url":"https://api.github.com/repos/robotframework/Selenium2Library/issues/696/events","html_url":"https://github.com/robotframework/Selenium2Library/pull/696","id":193161293,"number":696,"title":"Adds 'Get window urls' keyword","user":{"login":"thaffenden","id":14163530,"avatar_url":"https://avatars.githubusercontent.com/u/14163530?v=3","gravatar_id":"","url":"https://api.github.com/users/thaffenden","html_url":"https://github.com/thaffenden","followers_url":"https://api.github.com/users/thaffenden/followers","following_url":"https://api.github.com/users/thaffenden/following{/other_user}","gists_url":"https://api.github.com/users/thaffenden/gists{/gist_id}","starred_url":"https://api.github.com/users/thaffenden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaffenden/subscriptions","organizations_url":"https://api.github.com/users/thaffenden/orgs","repos_url":"https://api.github.com/users/thaffenden/repos","events_url":"https://api.github.com/users/thaffenden/events{/privacy}","received_events_url":"https://api.github.com/users/thaffenden/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-02T16:39:40Z","updated_at":"2016-12-02T18:53:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/696","html_url":"https://github.com/robotframework/Selenium2Library/pull/696","diff_url":"https://github.com/robotframework/Selenium2Library/pull/696.diff","patch_url":"https://github.com/robotframework/Selenium2Library/pull/696.patch"},"body":"As a keyword to return a list for all of the currently opened urls (in the same way titles works).\r\n\r\nThe urls are exposed by `WebDriverMonkeyPatches.get_current_window_info` so I'm not sure if there was a reason this functionality has been left out previously (I had a look through the issues on here and in the google group but couldn't see anything) or if it just wasn't needed.\r\n\r\nI'm using it for testing on a site where the url is the most reliable/consistent information so its really useful for switch window command to make sure you're in the right place. \r\n\r\nI've added an acceptance test and a unit test in line with the other `get_window...` keywords.\r\n\r\nLet me know if there's any issues with any of this."},"comment":{"url":"https://api.github.com/repos/robotframework/Selenium2Library/issues/comments/264532465","html_url":"https://github.com/robotframework/Selenium2Library/pull/696#issuecomment-264532465","issue_url":"https://api.github.com/repos/robotframework/Selenium2Library/issues/696","id":264532465,"user":{"login":"thaffenden","id":14163530,"avatar_url":"https://avatars.githubusercontent.com/u/14163530?v=3","gravatar_id":"","url":"https://api.github.com/users/thaffenden","html_url":"https://github.com/thaffenden","followers_url":"https://api.github.com/users/thaffenden/followers","following_url":"https://api.github.com/users/thaffenden/following{/other_user}","gists_url":"https://api.github.com/users/thaffenden/gists{/gist_id}","starred_url":"https://api.github.com/users/thaffenden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaffenden/subscriptions","organizations_url":"https://api.github.com/users/thaffenden/orgs","repos_url":"https://api.github.com/users/thaffenden/repos","events_url":"https://api.github.com/users/thaffenden/events{/privacy}","received_events_url":"https://api.github.com/users/thaffenden/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T18:53:34Z","updated_at":"2016-12-02T18:53:34Z","body":"@aaltat ahh yep, staying consistent with the `get location` keyword probably would have been a good idea.\r\nI can update this PR to do that though.\r\nI can add an argument to `get location` to return all locations (and update tests, doc strings etc).\r\nDo you have any preference on the argument name? I was just thinking `all_locations`.\r\n```python\r\n    def get_location(self, all_locations=False):\r\n        \"\"\"Returns the current location.\"\"\"\r\n        if all_locations:\r\n            <code here>\r\n        else:\r\n            return self._current_browser().get_current_url()\r\n```\r\n\r\nI can't see any tests using `get location` so I'll add ones for returning the single location and all. "}}
{"actor":{"display_login":"thaffenden"}}