{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16965","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16965/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16965/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16965/events","html_url":"https://github.com/cms-sw/cmssw/pull/16965","id":194802439,"number":16965,"title":"Add 2023 geometry unit test, remove T1","user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"labels":[{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52881721,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-pending","name":"geometry-pending","color":"fbca04","default":false},{"id":52881747,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":149441697,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pdmv-pending","name":"pdmv-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/64","html_url":"https://github.com/cms-sw/cmssw/milestone/64","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/64/labels","id":2138657,"number":64,"title":"Next CMSSW_9_0_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":187,"state":"open","created_at":"2016-11-16T08:55:18Z","updated_at":"2016-12-11T23:07:45Z","due_on":null,"closed_at":null},"comments":19,"created_at":"2016-12-10T23:58:54Z","updated_at":"2016-12-11T23:46:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16965","html_url":"https://github.com/cms-sw/cmssw/pull/16965","diff_url":"https://github.com/cms-sw/cmssw/pull/16965.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16965.patch"},"body":"Changes in this PR:\r\n1. Add unit test to compare outputs of 2023 geometry generation script to current versions of the corresponding files. This should prevent inconsistencies of the type that have occurred recently.\r\n2. Add a few features to the script:\r\n  * `-D` is now used to specify an existing detector version (requested a while ago by @lgray) in lieu of specifying each subdet version. `-V` is now used for the previous functionality, to specify a new version number for an unknown setup to facilitate testing.\r\n  * A list of deprecated detector and subdetector version numbers is kept, to prevent any of them from being reused accidentally.\r\n3. Removed T1 and replaced with T3 in relevant detector versions. This was implemented as D1->D7, D5->D8, D6->D9. D3 was removed, as it would be redundant with D4 with this change. Importantly, all workflow numbers were kept the same, by designating what were previously the D3 numbers as \"conflicts\" to be skipped. This was requested by the tracking group because reco efforts are increasingly based on T3 and may not provide sensible performance for T1. The specific implementation of the change in this PR was agreed with upgrade management.\r\n\r\nIn the future, I also plan to remove C1 and reduce the number of detector versions. However, due to the intended use of 90X for TDR production, these further changes are tentatively delayed until 91X, in order to avoid confusion.\r\n\r\nFailing test result:\r\n```\r\nPackage Configuration/Geometry: Running test test2023Geometry\r\n \r\n===== Test \"test2023Geometry\" ====\r\nargument 0: test2023Geometry\r\nargument 1: /bin/bash\r\nargument 2: Configuration/Geometry/test\r\nargument 3: runtests.sh\r\nshell is: /bin/bash\r\nCurrent directory is: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100\r\ntopdir is: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100\r\ntestdir is: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100/src/Configuration/Geometry/test\r\ntmpdir is: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100/tmp/slc6_amd64_gcc530\r\ntestbin is: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100/test/slc6_amd64_gcc530\r\nRunning script: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100/src/Configuration/Geometry/test/runtests.sh\r\nGeometryExtended2023D6_cff.py differs\r\nGeometryExtended2023D5Reco_cff.py differs\r\nstatus = 256\r\n\r\n---> test test2023Geometry had ERRORS\r\n\r\n^^^^ End Test test2023Geometry ^^^^\r\n```\r\nPassing test result:\r\n```\r\nPackage Configuration/Geometry: Running test test2023Geometry\r\n \r\n===== Test \"test2023Geometry\" ====\r\nargument 0: test2023Geometry\r\nargument 1: /bin/bash\r\nargument 2: Configuration/Geometry/test\r\nargument 3: runtests.sh\r\nshell is: /bin/bash\r\nCurrent directory is: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100\r\ntopdir is: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100\r\ntestdir is: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100/src/Configuration/Geometry/test\r\ntmpdir is: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100/tmp/slc6_amd64_gcc530\r\ntestbin is: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100/test/slc6_amd64_gcc530\r\nRunning script: /uscms_data/d3/pedrok/phase2/wf/CMSSW_9_0_X_2016-12-07-1100/src/Configuration/Geometry/test/runtests.sh\r\nstatus = 0\r\n\r\n---> test test2023Geometry succeeded\r\n\r\n^^^^ End Test test2023Geometry ^^^^\r\n```\r\n\r\nThis PR supersedes #16908.\r\n\r\n@slava77, this might cause some \"missing matrix map\" warnings..."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/266317709","html_url":"https://github.com/cms-sw/cmssw/pull/16965#issuecomment-266317709","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16965","id":266317709,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2016-12-11T23:46:08Z","updated_at":"2016-12-11T23:46:08Z","body":"Comparison is ready\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16965/16960/summary.html"}}
{"actor":{"display_login":"cmsbuild"}}