{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/94165935","pull_request_review_id":14696925,"id":94165935,"diff_hunk":"@@ -340,4 +340,13 @@ describe('ReactIncrementalScheduling', () => {\n     // animation priority.\n     expect(ReactNoop.getChildren()).toEqual([span(1)]);\n   });\n+\n+  it('can force synchronous updates with syncUpdates, even inside batchedUpdates', () => {\n+    ReactNoop.batchedUpdates(() => {\n+      ReactNoop.syncUpdates(() => {\n+        ReactNoop.render(<span />);\n+        expect(ReactNoop.getChildren()).toEqual([span()]);","path":"src/renderers/shared/fiber/__tests__/ReactIncrementalScheduling-test.js","position":9,"original_position":9,"commit_id":"3a252520f5e37e8b4e57f4daf3585973db78cc45","original_commit_id":"2f85a21892ee6cdd8e793a1977f11f4c8c0847fd","user":{"login":"bvaughn","id":29597,"avatar_url":"https://avatars.githubusercontent.com/u/29597?v=3","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"body":"You could guard against this with:\r\n```jsx\r\nit('can force synchronous updates with syncUpdates, even inside batchedUpdates', (done) => {\r\n  ReactNoop.batchedUpdates(() => {\r\n    ReactNoop.syncUpdates(() => {\r\n      ReactNoop.render(<span />);\r\n      expect(ReactNoop.getChildren()).toEqual([span()]);\r\n      done();\r\n    });\r\n  });\r\n});\r\n```\r\n\r\nBut yeah I agree, probably not necessary. 😄","created_at":"2016-12-29T18:33:33Z","updated_at":"2016-12-29T18:33:33Z","html_url":"https://github.com/facebook/react/pull/8634#discussion_r94165935","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/8634","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/94165935"},"html":{"href":"https://github.com/facebook/react/pull/8634#discussion_r94165935"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/8634"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/8634","id":99279230,"html_url":"https://github.com/facebook/react/pull/8634","diff_url":"https://github.com/facebook/react/pull/8634.diff","patch_url":"https://github.com/facebook/react/pull/8634.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/8634","number":8634,"state":"open","locked":false,"title":"[Fiber] Sync mount and unmount","user":{"login":"acdlite","id":3624098,"avatar_url":"https://avatars.githubusercontent.com/u/3624098?v=3","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"body":"Ensures that `syncUpdates` resets the batching context so that sync updates are not downgraded to Task. This provides an escape hatch for code that relies on synchronous flushing of updates.\r\n\r\nTop-level mount and unmount are now wrapped in `syncUpdates`. Should we do this for ART and native as well?","created_at":"2016-12-23T20:30:31Z","updated_at":"2016-12-29T18:33:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f858458b03cbc4550561b759d2eef9f70ee8f3f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/8634/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/8634/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/8634/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/3a252520f5e37e8b4e57f4daf3585973db78cc45","head":{"label":"acdlite:fibersyncmount","ref":"fibersyncmount","sha":"3a252520f5e37e8b4e57f4daf3585973db78cc45","user":{"login":"acdlite","id":3624098,"avatar_url":"https://avatars.githubusercontent.com/u/3624098?v=3","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"repo":{"id":45281256,"name":"react","full_name":"acdlite/react","owner":{"login":"acdlite","id":3624098,"avatar_url":"https://avatars.githubusercontent.com/u/3624098?v=3","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acdlite/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/acdlite/react","forks_url":"https://api.github.com/repos/acdlite/react/forks","keys_url":"https://api.github.com/repos/acdlite/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acdlite/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acdlite/react/teams","hooks_url":"https://api.github.com/repos/acdlite/react/hooks","issue_events_url":"https://api.github.com/repos/acdlite/react/issues/events{/number}","events_url":"https://api.github.com/repos/acdlite/react/events","assignees_url":"https://api.github.com/repos/acdlite/react/assignees{/user}","branches_url":"https://api.github.com/repos/acdlite/react/branches{/branch}","tags_url":"https://api.github.com/repos/acdlite/react/tags","blobs_url":"https://api.github.com/repos/acdlite/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acdlite/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acdlite/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/acdlite/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acdlite/react/statuses/{sha}","languages_url":"https://api.github.com/repos/acdlite/react/languages","stargazers_url":"https://api.github.com/repos/acdlite/react/stargazers","contributors_url":"https://api.github.com/repos/acdlite/react/contributors","subscribers_url":"https://api.github.com/repos/acdlite/react/subscribers","subscription_url":"https://api.github.com/repos/acdlite/react/subscription","commits_url":"https://api.github.com/repos/acdlite/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/acdlite/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/acdlite/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/acdlite/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/acdlite/react/contents/{+path}","compare_url":"https://api.github.com/repos/acdlite/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acdlite/react/merges","archive_url":"https://api.github.com/repos/acdlite/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acdlite/react/downloads","issues_url":"https://api.github.com/repos/acdlite/react/issues{/number}","pulls_url":"https://api.github.com/repos/acdlite/react/pulls{/number}","milestones_url":"https://api.github.com/repos/acdlite/react/milestones{/number}","notifications_url":"https://api.github.com/repos/acdlite/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acdlite/react/labels{/name}","releases_url":"https://api.github.com/repos/acdlite/react/releases{/id}","deployments_url":"https://api.github.com/repos/acdlite/react/deployments","created_at":"2015-10-30T23:18:48Z","updated_at":"2016-10-09T08:15:38Z","pushed_at":"2016-12-29T18:24:44Z","git_url":"git://github.com/acdlite/react.git","ssh_url":"git@github.com:acdlite/react.git","clone_url":"https://github.com/acdlite/react.git","svn_url":"https://github.com/acdlite/react","homepage":"https://facebook.github.io/react/","size":90622,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"df6ca0e2c11e995f8053348e672b7ede62e8bed9","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-12-29T18:09:28Z","pushed_at":"2016-12-29T18:24:57Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":111459,"stargazers_count":56645,"watchers_count":56645,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10207,"mirror_url":null,"open_issues_count":667,"forks":10207,"open_issues":667,"watchers":56645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/8634"},"html":{"href":"https://github.com/facebook/react/pull/8634"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/8634"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/8634/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/8634/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/8634/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/3a252520f5e37e8b4e57f4daf3585973db78cc45"}}}}
{"actor":{"display_login":"bvaughn"}}