{"action":"created","issue":{"url":"https://api.github.com/repos/canoo/dolphin-platform/issues/264","repository_url":"https://api.github.com/repos/canoo/dolphin-platform","labels_url":"https://api.github.com/repos/canoo/dolphin-platform/issues/264/labels{/name}","comments_url":"https://api.github.com/repos/canoo/dolphin-platform/issues/264/comments","events_url":"https://api.github.com/repos/canoo/dolphin-platform/issues/264/events","html_url":"https://github.com/canoo/dolphin-platform/pull/264","id":185308286,"number":264,"title":"Client connector migrated to java","user":{"login":"hendrikebbers","id":9443847,"avatar_url":"https://avatars.githubusercontent.com/u/9443847?v=3","gravatar_id":"","url":"https://api.github.com/users/hendrikebbers","html_url":"https://github.com/hendrikebbers","followers_url":"https://api.github.com/users/hendrikebbers/followers","following_url":"https://api.github.com/users/hendrikebbers/following{/other_user}","gists_url":"https://api.github.com/users/hendrikebbers/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrikebbers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrikebbers/subscriptions","organizations_url":"https://api.github.com/users/hendrikebbers/orgs","repos_url":"https://api.github.com/users/hendrikebbers/repos","events_url":"https://api.github.com/users/hendrikebbers/events{/privacy}","received_events_url":"https://api.github.com/users/hendrikebbers/received_events","type":"User","site_admin":false},"labels":[{"id":387081492,"url":"https://api.github.com/repos/canoo/dolphin-platform/labels/BLOCKER","name":"BLOCKER","color":"b60205","default":false},{"id":317030247,"url":"https://api.github.com/repos/canoo/dolphin-platform/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":274854867,"url":"https://api.github.com/repos/canoo/dolphin-platform/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/canoo/dolphin-platform/milestones/11","html_url":"https://github.com/canoo/dolphin-platform/milestones/0.8.8","labels_url":"https://api.github.com/repos/canoo/dolphin-platform/milestones/11/labels","id":1882823,"number":11,"title":"0.8.8","description":"","creator":{"login":"hendrikebbers","id":9443847,"avatar_url":"https://avatars.githubusercontent.com/u/9443847?v=3","gravatar_id":"","url":"https://api.github.com/users/hendrikebbers","html_url":"https://github.com/hendrikebbers","followers_url":"https://api.github.com/users/hendrikebbers/followers","following_url":"https://api.github.com/users/hendrikebbers/following{/other_user}","gists_url":"https://api.github.com/users/hendrikebbers/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrikebbers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrikebbers/subscriptions","organizations_url":"https://api.github.com/users/hendrikebbers/orgs","repos_url":"https://api.github.com/users/hendrikebbers/repos","events_url":"https://api.github.com/users/hendrikebbers/events{/privacy}","received_events_url":"https://api.github.com/users/hendrikebbers/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":13,"state":"open","created_at":"2016-07-14T09:19:04Z","updated_at":"2016-11-01T10:28:04Z","due_on":"2016-09-08T00:00:00Z","closed_at":null},"comments":3,"created_at":"2016-10-26T06:33:30Z","updated_at":"2016-11-07T08:51:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/canoo/dolphin-platform/pulls/264","html_url":"https://github.com/canoo/dolphin-platform/pull/264","diff_url":"https://github.com/canoo/dolphin-platform/pull/264.diff","patch_url":"https://github.com/canoo/dolphin-platform/pull/264.patch"},"body":"For several issues we need to refactor the client connector. This PR migrates it to Java for a better refactoring.\n\n<!-- Reviewable:start -->\n---\n\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/canoo/dolphin-platform/264)\n\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/canoo/dolphin-platform/issues/comments/258778021","html_url":"https://github.com/canoo/dolphin-platform/pull/264#issuecomment-258778021","issue_url":"https://api.github.com/repos/canoo/dolphin-platform/issues/264","id":258778021,"user":{"login":"blackdrag","id":470278,"avatar_url":"https://avatars.githubusercontent.com/u/470278?v=3","gravatar_id":"","url":"https://api.github.com/users/blackdrag","html_url":"https://github.com/blackdrag","followers_url":"https://api.github.com/users/blackdrag/followers","following_url":"https://api.github.com/users/blackdrag/following{/other_user}","gists_url":"https://api.github.com/users/blackdrag/gists{/gist_id}","starred_url":"https://api.github.com/users/blackdrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackdrag/subscriptions","organizations_url":"https://api.github.com/users/blackdrag/orgs","repos_url":"https://api.github.com/users/blackdrag/repos","events_url":"https://api.github.com/users/blackdrag/events{/privacy}","received_events_url":"https://api.github.com/users/blackdrag/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T08:51:05Z","updated_at":"2016-11-07T08:51:05Z","body":"\n\n\n\nReviewed 12 of 14 files at r1.\nReview status: 10 of 12 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[remoting/dolphin-remoting-client/src/main/groovy/org/opendolphin/core/client/comm/AbstractClientConnector.java, line 80 at r1](https://reviewable.io:443/reviews/canoo/dolphin-platform/264#-KVxwfrAwxVajVuCmNLe:-KVxwfrAwxVajVuCmNLf:b-u2hwyb) ([raw file](https://github.com/canoo/dolphin-platform/blob/d31b54c83c84613afa059d5fac887c426eb64198/remoting/dolphin-remoting-client/src/main/groovy/org/opendolphin/core/client/comm/AbstractClientConnector.java#L80)):*\n> ```Java\n>     public AbstractClientConnector(ClientDolphin clientDolphin, ICommandBatcher commandBatcher) {\n>         this.clientDolphin = clientDolphin;\n>         this.commandBatcher = DefaultGroovyMethods.asBoolean(commandBatcher) ? commandBatcher : new CommandBatcher();\n> ```\n\nI think you can replace this with a null check\n\n---\n\n*[remoting/dolphin-remoting-client/src/main/groovy/org/opendolphin/core/client/comm/CommandAndHandler.java, line 41 at r1](https://reviewable.io:443/reviews/canoo/dolphin-platform/264#-KVxx8F__l04PAZBGkan:-KVxx8F__l04PAZBGkao:bo1gf37) ([raw file](https://github.com/canoo/dolphin-platform/blob/d31b54c83c84613afa059d5fac887c426eb64198/remoting/dolphin-remoting-client/src/main/groovy/org/opendolphin/core/client/comm/CommandAndHandler.java#L41)):*\n> ```Java\n>      */\n>     public boolean isBatchable() {\n>         if (DefaultGroovyMethods.asBoolean(handler)) return false;\n> ```\n\nI think this can be a null check\n\n---\n\n*[remoting/dolphin-remoting-client/src/test/groovy/org/opendolphin/core/client/comm/ClientConnectorTests.groovy, line 113 at r1](https://reviewable.io:443/reviews/canoo/dolphin-platform/264#-KVxyrz7zVU52gfDlbR3:-KVxyrz7zVU52gfDlbR4:b-f93y5k) ([raw file](https://github.com/canoo/dolphin-platform/blob/d31b54c83c84613afa059d5fac887c426eb64198/remoting/dolphin-remoting-client/src/test/groovy/org/opendolphin/core/client/comm/ClientConnectorTests.groovy#L113)):*\n> ```Groovy\n> \t//\t}\n> \t//\tassert msg == exceptionMessage\n> \t//}\n> ```\n\nwhy is this test commented out?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/canoo/dolphin-platform/264)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"blackdrag"}}