{"action":"created","comment":{"url":"https://api.github.com/repos/chef-cookbooks/audit/pulls/comments/88563338","pull_request_review_id":9134865,"id":88563338,"diff_hunk":"@@ -0,0 +1,28 @@\n+# encoding: utf-8\n+#\n+# Cookbook Name:: audit\n+# Recipe:: inspec_package\n+#\n+# Copyright 2016 Chef Software, Inc.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+chef_ingredient 'inspec' do\n+  version node['audit']['inspec_version'] if node['audit']['inspec_version'] != 'latest'\n+  accept_license true\n+  action :upgrade\n+end\n+\n+load_inspec_libs","path":"recipes/inspec_package.rb","position":26,"original_position":26,"commit_id":"bbde422c16edd7cab99999de340e5e277af32e79","original_commit_id":"bbde422c16edd7cab99999de340e5e277af32e79","user":{"login":"vjeffrey","id":10341541,"avatar_url":"https://avatars.githubusercontent.com/u/10341541?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeffrey","html_url":"https://github.com/vjeffrey","followers_url":"https://api.github.com/users/vjeffrey/followers","following_url":"https://api.github.com/users/vjeffrey/following{/other_user}","gists_url":"https://api.github.com/users/vjeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeffrey/subscriptions","organizations_url":"https://api.github.com/users/vjeffrey/orgs","repos_url":"https://api.github.com/users/vjeffrey/repos","events_url":"https://api.github.com/users/vjeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/vjeffrey/received_events","type":"User","site_admin":false},"body":"oh shoot i think i had some leftover gem cruft in there when i tested.  right, ok, so we would need to set the load path like you did there. sounds like there are some other issues too (looking in compliance-support) in that chef-ingredient uses mixlib install gem.  so we could go the remote file and execute route. and then there's the problem of having gem and package installed....we could do a check to get around that i suppose","created_at":"2016-11-17T22:38:56Z","updated_at":"2016-11-17T22:38:56Z","html_url":"https://github.com/chef-cookbooks/audit/pull/165#discussion_r88563338","pull_request_url":"https://api.github.com/repos/chef-cookbooks/audit/pulls/165","_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/audit/pulls/comments/88563338"},"html":{"href":"https://github.com/chef-cookbooks/audit/pull/165#discussion_r88563338"},"pull_request":{"href":"https://api.github.com/repos/chef-cookbooks/audit/pulls/165"}}},"pull_request":{"url":"https://api.github.com/repos/chef-cookbooks/audit/pulls/165","id":94235608,"html_url":"https://github.com/chef-cookbooks/audit/pull/165","diff_url":"https://github.com/chef-cookbooks/audit/pull/165.diff","patch_url":"https://github.com/chef-cookbooks/audit/pull/165.patch","issue_url":"https://api.github.com/repos/chef-cookbooks/audit/issues/165","number":165,"state":"open","locked":false,"title":"add the ability to install gem as package when specified","user":{"login":"vjeffrey","id":10341541,"avatar_url":"https://avatars.githubusercontent.com/u/10341541?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeffrey","html_url":"https://github.com/vjeffrey","followers_url":"https://api.github.com/users/vjeffrey/followers","following_url":"https://api.github.com/users/vjeffrey/following{/other_user}","gists_url":"https://api.github.com/users/vjeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeffrey/subscriptions","organizations_url":"https://api.github.com/users/vjeffrey/orgs","repos_url":"https://api.github.com/users/vjeffrey/repos","events_url":"https://api.github.com/users/vjeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/vjeffrey/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\n@stephenlauck came up with a nice recipe to do this (https://github.com/stephenlauck/audit/blob/lauck/inspec_package/recipes/inspec_package.rb), just filling in the details to get it working with attributes, etc\r\n\r\nAdds the ability to install gem as package when specified.  @stephenlauck does this fit what you were thinking??\r\n\r\n### Issues Resolved\r\n\r\nfixes: https://github.com/chef-cookbooks/audit/issues/164\r\n\r\n### Check List\r\n\r\n- [x] All tests pass. See <https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD>\r\n- [x] New functionality includes testing.\r\n- [ ] New functionality has been documented in the README if applicable\r\n- [x] All commits have been signed for the Developer Certificate of Origin. See <https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD>\r\n\r\n","created_at":"2016-11-17T19:39:45Z","updated_at":"2016-11-17T22:38:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be7a595899c2c747f082c20c70b6c0948f9ada51","assignee":{"login":"vjeffrey","id":10341541,"avatar_url":"https://avatars.githubusercontent.com/u/10341541?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeffrey","html_url":"https://github.com/vjeffrey","followers_url":"https://api.github.com/users/vjeffrey/followers","following_url":"https://api.github.com/users/vjeffrey/following{/other_user}","gists_url":"https://api.github.com/users/vjeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeffrey/subscriptions","organizations_url":"https://api.github.com/users/vjeffrey/orgs","repos_url":"https://api.github.com/users/vjeffrey/repos","events_url":"https://api.github.com/users/vjeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/vjeffrey/received_events","type":"User","site_admin":false},"assignees":[{"login":"vjeffrey","id":10341541,"avatar_url":"https://avatars.githubusercontent.com/u/10341541?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeffrey","html_url":"https://github.com/vjeffrey","followers_url":"https://api.github.com/users/vjeffrey/followers","following_url":"https://api.github.com/users/vjeffrey/following{/other_user}","gists_url":"https://api.github.com/users/vjeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeffrey/subscriptions","organizations_url":"https://api.github.com/users/vjeffrey/orgs","repos_url":"https://api.github.com/users/vjeffrey/repos","events_url":"https://api.github.com/users/vjeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/vjeffrey/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/chef-cookbooks/audit/pulls/165/commits","review_comments_url":"https://api.github.com/repos/chef-cookbooks/audit/pulls/165/comments","review_comment_url":"https://api.github.com/repos/chef-cookbooks/audit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef-cookbooks/audit/issues/165/comments","statuses_url":"https://api.github.com/repos/chef-cookbooks/audit/statuses/bbde422c16edd7cab99999de340e5e277af32e79","head":{"label":"chef-cookbooks:lauck-vj/inspec-package","ref":"lauck-vj/inspec-package","sha":"bbde422c16edd7cab99999de340e5e277af32e79","user":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":51575047,"name":"audit","full_name":"chef-cookbooks/audit","owner":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-cookbooks/audit","description":"Audit Cookbook for Chef Compliance","fork":false,"url":"https://api.github.com/repos/chef-cookbooks/audit","forks_url":"https://api.github.com/repos/chef-cookbooks/audit/forks","keys_url":"https://api.github.com/repos/chef-cookbooks/audit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-cookbooks/audit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-cookbooks/audit/teams","hooks_url":"https://api.github.com/repos/chef-cookbooks/audit/hooks","issue_events_url":"https://api.github.com/repos/chef-cookbooks/audit/issues/events{/number}","events_url":"https://api.github.com/repos/chef-cookbooks/audit/events","assignees_url":"https://api.github.com/repos/chef-cookbooks/audit/assignees{/user}","branches_url":"https://api.github.com/repos/chef-cookbooks/audit/branches{/branch}","tags_url":"https://api.github.com/repos/chef-cookbooks/audit/tags","blobs_url":"https://api.github.com/repos/chef-cookbooks/audit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-cookbooks/audit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-cookbooks/audit/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-cookbooks/audit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-cookbooks/audit/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-cookbooks/audit/languages","stargazers_url":"https://api.github.com/repos/chef-cookbooks/audit/stargazers","contributors_url":"https://api.github.com/repos/chef-cookbooks/audit/contributors","subscribers_url":"https://api.github.com/repos/chef-cookbooks/audit/subscribers","subscription_url":"https://api.github.com/repos/chef-cookbooks/audit/subscription","commits_url":"https://api.github.com/repos/chef-cookbooks/audit/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-cookbooks/audit/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-cookbooks/audit/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-cookbooks/audit/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-cookbooks/audit/contents/{+path}","compare_url":"https://api.github.com/repos/chef-cookbooks/audit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-cookbooks/audit/merges","archive_url":"https://api.github.com/repos/chef-cookbooks/audit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-cookbooks/audit/downloads","issues_url":"https://api.github.com/repos/chef-cookbooks/audit/issues{/number}","pulls_url":"https://api.github.com/repos/chef-cookbooks/audit/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-cookbooks/audit/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-cookbooks/audit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-cookbooks/audit/labels{/name}","releases_url":"https://api.github.com/repos/chef-cookbooks/audit/releases{/id}","deployments_url":"https://api.github.com/repos/chef-cookbooks/audit/deployments","created_at":"2016-02-12T08:20:02Z","updated_at":"2016-10-26T19:06:32Z","pushed_at":"2016-11-17T19:49:24Z","git_url":"git://github.com/chef-cookbooks/audit.git","ssh_url":"git@github.com:chef-cookbooks/audit.git","clone_url":"https://github.com/chef-cookbooks/audit.git","svn_url":"https://github.com/chef-cookbooks/audit","homepage":"https://supermarket.chef.io/cookbooks/audit","size":469,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":19,"forks":16,"open_issues":19,"watchers":17,"default_branch":"master"}},"base":{"label":"chef-cookbooks:master","ref":"master","sha":"f1b86921f58a767930356e92c8a076f61b92b0b9","user":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":51575047,"name":"audit","full_name":"chef-cookbooks/audit","owner":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-cookbooks/audit","description":"Audit Cookbook for Chef Compliance","fork":false,"url":"https://api.github.com/repos/chef-cookbooks/audit","forks_url":"https://api.github.com/repos/chef-cookbooks/audit/forks","keys_url":"https://api.github.com/repos/chef-cookbooks/audit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-cookbooks/audit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-cookbooks/audit/teams","hooks_url":"https://api.github.com/repos/chef-cookbooks/audit/hooks","issue_events_url":"https://api.github.com/repos/chef-cookbooks/audit/issues/events{/number}","events_url":"https://api.github.com/repos/chef-cookbooks/audit/events","assignees_url":"https://api.github.com/repos/chef-cookbooks/audit/assignees{/user}","branches_url":"https://api.github.com/repos/chef-cookbooks/audit/branches{/branch}","tags_url":"https://api.github.com/repos/chef-cookbooks/audit/tags","blobs_url":"https://api.github.com/repos/chef-cookbooks/audit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-cookbooks/audit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-cookbooks/audit/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-cookbooks/audit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-cookbooks/audit/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-cookbooks/audit/languages","stargazers_url":"https://api.github.com/repos/chef-cookbooks/audit/stargazers","contributors_url":"https://api.github.com/repos/chef-cookbooks/audit/contributors","subscribers_url":"https://api.github.com/repos/chef-cookbooks/audit/subscribers","subscription_url":"https://api.github.com/repos/chef-cookbooks/audit/subscription","commits_url":"https://api.github.com/repos/chef-cookbooks/audit/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-cookbooks/audit/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-cookbooks/audit/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-cookbooks/audit/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-cookbooks/audit/contents/{+path}","compare_url":"https://api.github.com/repos/chef-cookbooks/audit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-cookbooks/audit/merges","archive_url":"https://api.github.com/repos/chef-cookbooks/audit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-cookbooks/audit/downloads","issues_url":"https://api.github.com/repos/chef-cookbooks/audit/issues{/number}","pulls_url":"https://api.github.com/repos/chef-cookbooks/audit/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-cookbooks/audit/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-cookbooks/audit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-cookbooks/audit/labels{/name}","releases_url":"https://api.github.com/repos/chef-cookbooks/audit/releases{/id}","deployments_url":"https://api.github.com/repos/chef-cookbooks/audit/deployments","created_at":"2016-02-12T08:20:02Z","updated_at":"2016-10-26T19:06:32Z","pushed_at":"2016-11-17T19:49:24Z","git_url":"git://github.com/chef-cookbooks/audit.git","ssh_url":"git@github.com:chef-cookbooks/audit.git","clone_url":"https://github.com/chef-cookbooks/audit.git","svn_url":"https://github.com/chef-cookbooks/audit","homepage":"https://supermarket.chef.io/cookbooks/audit","size":469,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":19,"forks":16,"open_issues":19,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/audit/pulls/165"},"html":{"href":"https://github.com/chef-cookbooks/audit/pull/165"},"issue":{"href":"https://api.github.com/repos/chef-cookbooks/audit/issues/165"},"comments":{"href":"https://api.github.com/repos/chef-cookbooks/audit/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/chef-cookbooks/audit/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/chef-cookbooks/audit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef-cookbooks/audit/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/chef-cookbooks/audit/statuses/bbde422c16edd7cab99999de340e5e277af32e79"}}}}
{"actor":{"display_login":"vjeffrey"}}