{"push_id":1068835865,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"17cab0417c831a24589e401d7648e012d79ff3a7","before":"63162a9033e35365fc4eb50830176467da3bbb61","commits":[{"sha":"17cab0417c831a24589e401d7648e012d79ff3a7","author":{"email":"72977556adb407c83e4c510020c5fe46488477ad@google.com","name":"Etienne Bergeron"},"message":"[clang-tidy] Add more detection rules for redundant c_str calls.\n\nSummary:\nThe string class contains methods which support receiving either a string literal or a string object.\n\nFor example, calls to append can receive either a char* or a string.\n```\n  string& append (const string& str);\n  string& append (const char* s);\n```\n\nWhich make these cases equivalent, and the .c_str() useless:\n```\n  std::string s = \"123\";\n  str.append(s);\n  str.append(s.c_str());\n```\n\nIn these cases, removing .c_str()  doesn't provide any size or speed improvement.\nIt's only a readability issue.\n\nIf the string contains embedded NUL characters,  the string literal and the string\nobject won't produce the same semantic.\n\nReviewers: alexfh, sbenza\n\nSubscribers: LegalizeAdulthood, aaron.ballman, chapuni, Eugene.Zelenko, cfe-commits\n\nDifferential Revision: http://reviews.llvm.org/D18475","distinct":true,"url":"https://api.github.com/repos/llvm-project/llvm-project-submodule/commits/17cab0417c831a24589e401d7648e012d79ff3a7"}]}