{"action":"created","comment":{"url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/comments/92396328","pull_request_review_id":12910115,"id":92396328,"diff_hunk":"@@ -74,6 +76,7 @@ def _tps_ensemble(self, stateA, stateB):\n             paths.AllInXEnsemble(stateB) & paths.LengthEnsemble(1)\n         ])\n \n+    # TODO: Can this kwargs be removed? It is not used","path":"openpathsampling/high_level/transition.py","position":29,"original_position":29,"commit_id":"bb4d81bc5f1d7db62b940cb57d1f9b5cdc7d329e","original_commit_id":"bb4d81bc5f1d7db62b940cb57d1f9b5cdc7d329e","user":{"login":"jhprinz","id":5091934,"avatar_url":"https://avatars.githubusercontent.com/u/5091934?v=3","gravatar_id":"","url":"https://api.github.com/users/jhprinz","html_url":"https://github.com/jhprinz","followers_url":"https://api.github.com/users/jhprinz/followers","following_url":"https://api.github.com/users/jhprinz/following{/other_user}","gists_url":"https://api.github.com/users/jhprinz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhprinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhprinz/subscriptions","organizations_url":"https://api.github.com/users/jhprinz/orgs","repos_url":"https://api.github.com/users/jhprinz/repos","events_url":"https://api.github.com/users/jhprinz/events{/privacy}","received_events_url":"https://api.github.com/users/jhprinz/received_events","type":"User","site_admin":false},"body":"Okay, thanks. That answers it.","created_at":"2016-12-14T13:54:26Z","updated_at":"2016-12-14T13:54:26Z","html_url":"https://github.com/openpathsampling/openpathsampling/pull/636#discussion_r92396328","pull_request_url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/636","_links":{"self":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/comments/92396328"},"html":{"href":"https://github.com/openpathsampling/openpathsampling/pull/636#discussion_r92396328"},"pull_request":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/636"}}},"pull_request":{"url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/636","id":93484861,"html_url":"https://github.com/openpathsampling/openpathsampling/pull/636","diff_url":"https://github.com/openpathsampling/openpathsampling/pull/636.diff","patch_url":"https://github.com/openpathsampling/openpathsampling/pull/636.patch","issue_url":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/636","number":636,"state":"open","locked":false,"title":"Storage -> Only with UUID","user":{"login":"jhprinz","id":5091934,"avatar_url":"https://avatars.githubusercontent.com/u/5091934?v=3","gravatar_id":"","url":"https://api.github.com/users/jhprinz","html_url":"https://github.com/jhprinz","followers_url":"https://api.github.com/users/jhprinz/followers","following_url":"https://api.github.com/users/jhprinz/following{/other_user}","gists_url":"https://api.github.com/users/jhprinz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhprinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhprinz/subscriptions","organizations_url":"https://api.github.com/users/jhprinz/orgs","repos_url":"https://api.github.com/users/jhprinz/repos","events_url":"https://api.github.com/users/jhprinz/events{/privacy}","received_events_url":"https://api.github.com/users/jhprinz/received_events","type":"User","site_admin":false},"body":"This fixes `Storage` to use only with uuid. This means that some tpy example might run a little slower, but it simplified the code A LOT! And makes it much better maintainable. It has also some major speed improvements (not sure how these turn out in a real system).\r\n\r\nSo far it is completely backward compatible, but I would like to change the file format a little to make it faster for dealing with UUIDs.\r\n\r\nMain idea for that is to just use long instead of creating string representations and `UUID` objects. It now is really just a long integer and thus much faster to compare and change and store. Since this part is a significant part in loading objects it should load much faster.\r\n\r\nIt makes the following changes:\r\n\r\n- [x] removal of `use_uuid` or `referenced_by_uuid`\r\n- [x] fixes tests, notebooks are run `use_uuid=True`\r\n- [x] store the UUID internally as 16byte - long and not as a UUID object anymore\r\n- [x] storage is left as is (it stores UUID as a string representation, which is an moderately expensive transformation \r\n- [x] remove decorator for auto creation of delayed loading. This were only 4 variables and using the decorator will destroy the signature for the help of `Sample`, `MCStep` and `SampleSet` which is bad for a user (we can write a better decorator later and this is fixed in Py 3.4+ anyway)\r\n- [x] some cleanup in the loading functions\r\n- [x] use `VariableStore` in the correct order to speedup object creation with `args` and not `kwargs`\r\n- [x] rearrange some code in multiple files for better maintenance. There is now a `stores` folder that has the code related to a `store`\r\n- [x] update the `cache_all` functions for faster analysis loading\r\n- [x] increase chunk sizes","created_at":"2016-11-13T20:09:38Z","updated_at":"2016-12-14T13:54:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4de37b45b26cec0a31942fbc17d69b98362b5b5c","assignee":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"assignees":[{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openpathsampling/openpathsampling/milestones/6","html_url":"https://github.com/openpathsampling/openpathsampling/milestone/6","labels_url":"https://api.github.com/repos/openpathsampling/openpathsampling/milestones/6/labels","id":1845511,"number":6,"title":"1.x","description":null,"creator":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":4,"state":"open","created_at":"2016-06-23T14:33:14Z","updated_at":"2016-11-13T20:10:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/636/commits","review_comments_url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/636/comments","review_comment_url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/636/comments","statuses_url":"https://api.github.com/repos/openpathsampling/openpathsampling/statuses/bb4d81bc5f1d7db62b940cb57d1f9b5cdc7d329e","head":{"label":"jhprinz:onlyuuid","ref":"onlyuuid","sha":"bb4d81bc5f1d7db62b940cb57d1f9b5cdc7d329e","user":{"login":"jhprinz","id":5091934,"avatar_url":"https://avatars.githubusercontent.com/u/5091934?v=3","gravatar_id":"","url":"https://api.github.com/users/jhprinz","html_url":"https://github.com/jhprinz","followers_url":"https://api.github.com/users/jhprinz/followers","following_url":"https://api.github.com/users/jhprinz/following{/other_user}","gists_url":"https://api.github.com/users/jhprinz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhprinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhprinz/subscriptions","organizations_url":"https://api.github.com/users/jhprinz/orgs","repos_url":"https://api.github.com/users/jhprinz/repos","events_url":"https://api.github.com/users/jhprinz/events{/privacy}","received_events_url":"https://api.github.com/users/jhprinz/received_events","type":"User","site_admin":false},"repo":{"id":23916614,"name":"openpathsampling","full_name":"jhprinz/openpathsampling","owner":{"login":"jhprinz","id":5091934,"avatar_url":"https://avatars.githubusercontent.com/u/5091934?v=3","gravatar_id":"","url":"https://api.github.com/users/jhprinz","html_url":"https://github.com/jhprinz","followers_url":"https://api.github.com/users/jhprinz/followers","following_url":"https://api.github.com/users/jhprinz/following{/other_user}","gists_url":"https://api.github.com/users/jhprinz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhprinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhprinz/subscriptions","organizations_url":"https://api.github.com/users/jhprinz/orgs","repos_url":"https://api.github.com/users/jhprinz/repos","events_url":"https://api.github.com/users/jhprinz/events{/privacy}","received_events_url":"https://api.github.com/users/jhprinz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhprinz/openpathsampling","description":"Explorations of ways to combine MSMs with TIS","fork":true,"url":"https://api.github.com/repos/jhprinz/openpathsampling","forks_url":"https://api.github.com/repos/jhprinz/openpathsampling/forks","keys_url":"https://api.github.com/repos/jhprinz/openpathsampling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhprinz/openpathsampling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhprinz/openpathsampling/teams","hooks_url":"https://api.github.com/repos/jhprinz/openpathsampling/hooks","issue_events_url":"https://api.github.com/repos/jhprinz/openpathsampling/issues/events{/number}","events_url":"https://api.github.com/repos/jhprinz/openpathsampling/events","assignees_url":"https://api.github.com/repos/jhprinz/openpathsampling/assignees{/user}","branches_url":"https://api.github.com/repos/jhprinz/openpathsampling/branches{/branch}","tags_url":"https://api.github.com/repos/jhprinz/openpathsampling/tags","blobs_url":"https://api.github.com/repos/jhprinz/openpathsampling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhprinz/openpathsampling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhprinz/openpathsampling/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhprinz/openpathsampling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhprinz/openpathsampling/statuses/{sha}","languages_url":"https://api.github.com/repos/jhprinz/openpathsampling/languages","stargazers_url":"https://api.github.com/repos/jhprinz/openpathsampling/stargazers","contributors_url":"https://api.github.com/repos/jhprinz/openpathsampling/contributors","subscribers_url":"https://api.github.com/repos/jhprinz/openpathsampling/subscribers","subscription_url":"https://api.github.com/repos/jhprinz/openpathsampling/subscription","commits_url":"https://api.github.com/repos/jhprinz/openpathsampling/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhprinz/openpathsampling/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhprinz/openpathsampling/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhprinz/openpathsampling/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhprinz/openpathsampling/contents/{+path}","compare_url":"https://api.github.com/repos/jhprinz/openpathsampling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhprinz/openpathsampling/merges","archive_url":"https://api.github.com/repos/jhprinz/openpathsampling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhprinz/openpathsampling/downloads","issues_url":"https://api.github.com/repos/jhprinz/openpathsampling/issues{/number}","pulls_url":"https://api.github.com/repos/jhprinz/openpathsampling/pulls{/number}","milestones_url":"https://api.github.com/repos/jhprinz/openpathsampling/milestones{/number}","notifications_url":"https://api.github.com/repos/jhprinz/openpathsampling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhprinz/openpathsampling/labels{/name}","releases_url":"https://api.github.com/repos/jhprinz/openpathsampling/releases{/id}","deployments_url":"https://api.github.com/repos/jhprinz/openpathsampling/deployments","created_at":"2014-09-11T12:06:28Z","updated_at":"2016-11-01T15:55:33Z","pushed_at":"2016-12-13T23:05:28Z","git_url":"git://github.com/jhprinz/openpathsampling.git","ssh_url":"git@github.com:jhprinz/openpathsampling.git","clone_url":"https://github.com/jhprinz/openpathsampling.git","svn_url":"https://github.com/jhprinz/openpathsampling","homepage":null,"size":259624,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openpathsampling:master","ref":"master","sha":"fecb244710ecb53b6d46ec47e4ab7e7f922b90cf","user":{"login":"openpathsampling","id":19826308,"avatar_url":"https://avatars.githubusercontent.com/u/19826308?v=3","gravatar_id":"","url":"https://api.github.com/users/openpathsampling","html_url":"https://github.com/openpathsampling","followers_url":"https://api.github.com/users/openpathsampling/followers","following_url":"https://api.github.com/users/openpathsampling/following{/other_user}","gists_url":"https://api.github.com/users/openpathsampling/gists{/gist_id}","starred_url":"https://api.github.com/users/openpathsampling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openpathsampling/subscriptions","organizations_url":"https://api.github.com/users/openpathsampling/orgs","repos_url":"https://api.github.com/users/openpathsampling/repos","events_url":"https://api.github.com/users/openpathsampling/events{/privacy}","received_events_url":"https://api.github.com/users/openpathsampling/received_events","type":"Organization","site_admin":false},"repo":{"id":12592267,"name":"openpathsampling","full_name":"openpathsampling/openpathsampling","owner":{"login":"openpathsampling","id":19826308,"avatar_url":"https://avatars.githubusercontent.com/u/19826308?v=3","gravatar_id":"","url":"https://api.github.com/users/openpathsampling","html_url":"https://github.com/openpathsampling","followers_url":"https://api.github.com/users/openpathsampling/followers","following_url":"https://api.github.com/users/openpathsampling/following{/other_user}","gists_url":"https://api.github.com/users/openpathsampling/gists{/gist_id}","starred_url":"https://api.github.com/users/openpathsampling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openpathsampling/subscriptions","organizations_url":"https://api.github.com/users/openpathsampling/orgs","repos_url":"https://api.github.com/users/openpathsampling/repos","events_url":"https://api.github.com/users/openpathsampling/events{/privacy}","received_events_url":"https://api.github.com/users/openpathsampling/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openpathsampling/openpathsampling","description":"An open source Python framework for transition interface and path sampling calculations.","fork":false,"url":"https://api.github.com/repos/openpathsampling/openpathsampling","forks_url":"https://api.github.com/repos/openpathsampling/openpathsampling/forks","keys_url":"https://api.github.com/repos/openpathsampling/openpathsampling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openpathsampling/openpathsampling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openpathsampling/openpathsampling/teams","hooks_url":"https://api.github.com/repos/openpathsampling/openpathsampling/hooks","issue_events_url":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/events{/number}","events_url":"https://api.github.com/repos/openpathsampling/openpathsampling/events","assignees_url":"https://api.github.com/repos/openpathsampling/openpathsampling/assignees{/user}","branches_url":"https://api.github.com/repos/openpathsampling/openpathsampling/branches{/branch}","tags_url":"https://api.github.com/repos/openpathsampling/openpathsampling/tags","blobs_url":"https://api.github.com/repos/openpathsampling/openpathsampling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openpathsampling/openpathsampling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openpathsampling/openpathsampling/git/refs{/sha}","trees_url":"https://api.github.com/repos/openpathsampling/openpathsampling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openpathsampling/openpathsampling/statuses/{sha}","languages_url":"https://api.github.com/repos/openpathsampling/openpathsampling/languages","stargazers_url":"https://api.github.com/repos/openpathsampling/openpathsampling/stargazers","contributors_url":"https://api.github.com/repos/openpathsampling/openpathsampling/contributors","subscribers_url":"https://api.github.com/repos/openpathsampling/openpathsampling/subscribers","subscription_url":"https://api.github.com/repos/openpathsampling/openpathsampling/subscription","commits_url":"https://api.github.com/repos/openpathsampling/openpathsampling/commits{/sha}","git_commits_url":"https://api.github.com/repos/openpathsampling/openpathsampling/git/commits{/sha}","comments_url":"https://api.github.com/repos/openpathsampling/openpathsampling/comments{/number}","issue_comment_url":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/comments{/number}","contents_url":"https://api.github.com/repos/openpathsampling/openpathsampling/contents/{+path}","compare_url":"https://api.github.com/repos/openpathsampling/openpathsampling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openpathsampling/openpathsampling/merges","archive_url":"https://api.github.com/repos/openpathsampling/openpathsampling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openpathsampling/openpathsampling/downloads","issues_url":"https://api.github.com/repos/openpathsampling/openpathsampling/issues{/number}","pulls_url":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls{/number}","milestones_url":"https://api.github.com/repos/openpathsampling/openpathsampling/milestones{/number}","notifications_url":"https://api.github.com/repos/openpathsampling/openpathsampling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openpathsampling/openpathsampling/labels{/name}","releases_url":"https://api.github.com/repos/openpathsampling/openpathsampling/releases{/id}","deployments_url":"https://api.github.com/repos/openpathsampling/openpathsampling/deployments","created_at":"2013-09-04T14:06:28Z","updated_at":"2016-11-28T16:07:10Z","pushed_at":"2016-12-13T23:05:29Z","git_url":"git://github.com/openpathsampling/openpathsampling.git","ssh_url":"git@github.com:openpathsampling/openpathsampling.git","clone_url":"https://github.com/openpathsampling/openpathsampling.git","svn_url":"https://github.com/openpathsampling/openpathsampling","homepage":"http://openpathsampling.org","size":254899,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":64,"forks":12,"open_issues":64,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/636"},"html":{"href":"https://github.com/openpathsampling/openpathsampling/pull/636"},"issue":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/636"},"comments":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/openpathsampling/openpathsampling/statuses/bb4d81bc5f1d7db62b940cb57d1f9b5cdc7d329e"}}}}
{"actor":{"display_login":"jhprinz"}}