{"action":"created","issue":{"url":"https://api.github.com/repos/simplethings/EntityAudit/issues/170","labels_url":"https://api.github.com/repos/simplethings/EntityAudit/issues/170/labels{/name}","comments_url":"https://api.github.com/repos/simplethings/EntityAudit/issues/170/comments","events_url":"https://api.github.com/repos/simplethings/EntityAudit/issues/170/events","html_url":"https://github.com/simplethings/EntityAudit/pull/170","id":128159223,"number":170,"title":"Change LogRevisionsListener methods to protected","user":{"login":"rvanlaarhoven","id":1857585,"avatar_url":"https://avatars.githubusercontent.com/u/1857585?v=3","gravatar_id":"","url":"https://api.github.com/users/rvanlaarhoven","html_url":"https://github.com/rvanlaarhoven","followers_url":"https://api.github.com/users/rvanlaarhoven/followers","following_url":"https://api.github.com/users/rvanlaarhoven/following{/other_user}","gists_url":"https://api.github.com/users/rvanlaarhoven/gists{/gist_id}","starred_url":"https://api.github.com/users/rvanlaarhoven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvanlaarhoven/subscriptions","organizations_url":"https://api.github.com/users/rvanlaarhoven/orgs","repos_url":"https://api.github.com/users/rvanlaarhoven/repos","events_url":"https://api.github.com/users/rvanlaarhoven/events{/privacy}","received_events_url":"https://api.github.com/users/rvanlaarhoven/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-01-22T13:42:54Z","updated_at":"2016-01-26T08:16:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/simplethings/EntityAudit/pulls/170","html_url":"https://github.com/simplethings/EntityAudit/pull/170","diff_url":"https://github.com/simplethings/EntityAudit/pull/170.diff","patch_url":"https://github.com/simplethings/EntityAudit/pull/170.patch"},"body":"Changed all private methods in `LogRevisionsListener` to protected in order to be able to extend the listener without having to override everything."},"comment":{"url":"https://api.github.com/repos/simplethings/EntityAudit/issues/comments/174885628","html_url":"https://github.com/simplethings/EntityAudit/pull/170#issuecomment-174885628","issue_url":"https://api.github.com/repos/simplethings/EntityAudit/issues/170","id":174885628,"user":{"login":"rvanlaarhoven","id":1857585,"avatar_url":"https://avatars.githubusercontent.com/u/1857585?v=3","gravatar_id":"","url":"https://api.github.com/users/rvanlaarhoven","html_url":"https://github.com/rvanlaarhoven","followers_url":"https://api.github.com/users/rvanlaarhoven/followers","following_url":"https://api.github.com/users/rvanlaarhoven/following{/other_user}","gists_url":"https://api.github.com/users/rvanlaarhoven/gists{/gist_id}","starred_url":"https://api.github.com/users/rvanlaarhoven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvanlaarhoven/subscriptions","organizations_url":"https://api.github.com/users/rvanlaarhoven/orgs","repos_url":"https://api.github.com/users/rvanlaarhoven/repos","events_url":"https://api.github.com/users/rvanlaarhoven/events{/privacy}","received_events_url":"https://api.github.com/users/rvanlaarhoven/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T08:16:20Z","updated_at":"2016-01-26T08:16:20Z","body":"Actually, we decided to stick with our old solution (Gedmo Loggable) for now, until we have some more time to refactor. so this PR is not directly necessary.\r\n\r\nTo clarify what I intended to do is override `saveRevisionEntityData`, to;\r\n- Add another column to the audit table with extra log data.\r\n- We're using versioning on a nested entity structure, with publish functionality. Not every change needed a new audit row, so when a log was already created and the version wasn't published yet, I needed to execute an UPDATE instead of an INSERT.\r\n\r\n"}}