{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/68467851","id":68467851,"diff_hunk":"@@ -480,7 +497,24 @@ func (c *Context) UnbindContainer(h *exec.Handle) error {\n \t\t}\n \t}\n \n+\t// Removing long id, short id and common name from the map\n \tdelete(c.containers, h.Container.ID)\n+\n+\ttid := con.id.TruncateID()\n+\tcname := h.Container.ExecConfig.Common.Name\n+\n+\tvar key string\n+\t// network scoped\n+\tfor _, e := range con.Endpoints() {\n+\t\tsname := e.Scope().Name()\n+\n+\t\tkey = fmt.Sprintf(\"%s:%s\", sname, tid)\n+\t\tdelete(c.containers, exec.ParseID(key))\n+\n+\t\tkey = fmt.Sprintf(\"%s:%s\", sname, cname)\n+\t\tdelete(c.containers, exec.ParseID(key))","path":"lib/portlayer/network/context.go","position":44,"original_position":44,"commit_id":"af619421d8ebfa2b589596b26507f2de91ad0d13","original_commit_id":"af619421d8ebfa2b589596b26507f2de91ad0d13","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"body":"Nope, but we don't cache internal names ","created_at":"2016-06-24T21:46:50Z","updated_at":"2016-06-24T21:46:50Z","html_url":"https://github.com/vmware/vic/pull/1209#discussion_r68467851","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/1209","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/68467851"},"html":{"href":"https://github.com/vmware/vic/pull/1209#discussion_r68467851"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/1209"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/1209","id":75173868,"html_url":"https://github.com/vmware/vic/pull/1209","diff_url":"https://github.com/vmware/vic/pull/1209.diff","patch_url":"https://github.com/vmware/vic/pull/1209.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/1209","number":1209,"state":"open","locked":false,"title":"[dns] Introduce network scopes","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"body":"- we now have a seperate vic-dns binary to create standalone DNS service\r\n- context now inserts/removed truncated id and common/name into\r\nthe map of containers (using SCOPE:NAME as a key)\r\n- dns part of the PL now iterates over scopes to map requester IP adress\r\nand returns the SCOPE:NAME key as a response\r\n- tether now generates /etc/resolv.conf for containers","created_at":"2016-06-24T21:06:49Z","updated_at":"2016-06-24T21:46:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe4ce743997b53d881da9c162da1740045dbe121","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/1209/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/1209/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/1209/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/af619421d8ebfa2b589596b26507f2de91ad0d13","head":{"label":"caglar10ur:scopes","ref":"scopes","sha":"af619421d8ebfa2b589596b26507f2de91ad0d13","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"repo":{"id":55449160,"name":"vic","full_name":"caglar10ur/vic","owner":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caglar10ur/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/caglar10ur/vic","forks_url":"https://api.github.com/repos/caglar10ur/vic/forks","keys_url":"https://api.github.com/repos/caglar10ur/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caglar10ur/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caglar10ur/vic/teams","hooks_url":"https://api.github.com/repos/caglar10ur/vic/hooks","issue_events_url":"https://api.github.com/repos/caglar10ur/vic/issues/events{/number}","events_url":"https://api.github.com/repos/caglar10ur/vic/events","assignees_url":"https://api.github.com/repos/caglar10ur/vic/assignees{/user}","branches_url":"https://api.github.com/repos/caglar10ur/vic/branches{/branch}","tags_url":"https://api.github.com/repos/caglar10ur/vic/tags","blobs_url":"https://api.github.com/repos/caglar10ur/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caglar10ur/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caglar10ur/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/caglar10ur/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caglar10ur/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/caglar10ur/vic/languages","stargazers_url":"https://api.github.com/repos/caglar10ur/vic/stargazers","contributors_url":"https://api.github.com/repos/caglar10ur/vic/contributors","subscribers_url":"https://api.github.com/repos/caglar10ur/vic/subscribers","subscription_url":"https://api.github.com/repos/caglar10ur/vic/subscription","commits_url":"https://api.github.com/repos/caglar10ur/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/caglar10ur/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/caglar10ur/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/caglar10ur/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/caglar10ur/vic/contents/{+path}","compare_url":"https://api.github.com/repos/caglar10ur/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caglar10ur/vic/merges","archive_url":"https://api.github.com/repos/caglar10ur/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caglar10ur/vic/downloads","issues_url":"https://api.github.com/repos/caglar10ur/vic/issues{/number}","pulls_url":"https://api.github.com/repos/caglar10ur/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/caglar10ur/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/caglar10ur/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caglar10ur/vic/labels{/name}","releases_url":"https://api.github.com/repos/caglar10ur/vic/releases{/id}","deployments_url":"https://api.github.com/repos/caglar10ur/vic/deployments","created_at":"2016-04-04T22:13:10Z","updated_at":"2016-04-04T22:13:12Z","pushed_at":"2016-06-24T21:06:36Z","git_url":"git://github.com/caglar10ur/vic.git","ssh_url":"git@github.com:caglar10ur/vic.git","clone_url":"https://github.com/caglar10ur/vic.git","svn_url":"https://github.com/caglar10ur/vic","homepage":null,"size":18183,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"864f58ce5bf2746bd7b40c70484e7a2e86fa4597","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-06-24T06:10:27Z","pushed_at":"2016-06-24T21:45:20Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":null,"size":65683,"stargazers_count":94,"watchers_count":94,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"open_issues_count":434,"forks":37,"open_issues":434,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/1209"},"html":{"href":"https://github.com/vmware/vic/pull/1209"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/1209"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/1209/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/1209/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/1209/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/af619421d8ebfa2b589596b26507f2de91ad0d13"}}}}
{"actor":{"display_login":"caglar10ur"}}