{"action":"created","issue":{"url":"https://api.github.com/repos/twitter/bijection/issues/258","repository_url":"https://api.github.com/repos/twitter/bijection","labels_url":"https://api.github.com/repos/twitter/bijection/issues/258/labels{/name}","comments_url":"https://api.github.com/repos/twitter/bijection/issues/258/comments","events_url":"https://api.github.com/repos/twitter/bijection/issues/258/events","html_url":"https://github.com/twitter/bijection/pull/258","id":192115871,"number":258,"title":"Add support for Scala 2.12.0","user":{"login":"piyushnarang","id":9885908,"avatar_url":"https://avatars.githubusercontent.com/u/9885908?v=3","gravatar_id":"","url":"https://api.github.com/users/piyushnarang","html_url":"https://github.com/piyushnarang","followers_url":"https://api.github.com/users/piyushnarang/followers","following_url":"https://api.github.com/users/piyushnarang/following{/other_user}","gists_url":"https://api.github.com/users/piyushnarang/gists{/gist_id}","starred_url":"https://api.github.com/users/piyushnarang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piyushnarang/subscriptions","organizations_url":"https://api.github.com/users/piyushnarang/orgs","repos_url":"https://api.github.com/users/piyushnarang/repos","events_url":"https://api.github.com/users/piyushnarang/events{/privacy}","received_events_url":"https://api.github.com/users/piyushnarang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-11-28T21:00:50Z","updated_at":"2016-11-29T02:31:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twitter/bijection/pulls/258","html_url":"https://github.com/twitter/bijection/pull/258","diff_url":"https://github.com/twitter/bijection/pull/258.diff","patch_url":"https://github.com/twitter/bijection/pull/258.patch"},"body":"Building on https://github.com/twitter/bijection/pull/257. Adding 2.12.0 as a cross version to include. Had to disable building 2.12 for a few projects as they require some finagle 2.12 artifacts (which in turn requires bijection-core 2.12). Once the finagle artifacts are in, we can reenable those projects. "},"comment":{"url":"https://api.github.com/repos/twitter/bijection/issues/comments/263458955","html_url":"https://github.com/twitter/bijection/pull/258#issuecomment-263458955","issue_url":"https://api.github.com/repos/twitter/bijection/issues/258","id":263458955,"user":{"login":"piyushnarang","id":9885908,"avatar_url":"https://avatars.githubusercontent.com/u/9885908?v=3","gravatar_id":"","url":"https://api.github.com/users/piyushnarang","html_url":"https://github.com/piyushnarang","followers_url":"https://api.github.com/users/piyushnarang/followers","following_url":"https://api.github.com/users/piyushnarang/following{/other_user}","gists_url":"https://api.github.com/users/piyushnarang/gists{/gist_id}","starred_url":"https://api.github.com/users/piyushnarang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piyushnarang/subscriptions","organizations_url":"https://api.github.com/users/piyushnarang/orgs","repos_url":"https://api.github.com/users/piyushnarang/repos","events_url":"https://api.github.com/users/piyushnarang/events{/privacy}","received_events_url":"https://api.github.com/users/piyushnarang/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T02:31:17Z","updated_at":"2016-11-29T02:31:17Z","body":"@johnynek ok not 100% sure what the best way to proceed on this is. Here's what I see. When I set up coverageEnabled conditionally:\r\n````\r\nval buildLevelSettings = Seq(\r\n...\r\ncoverageEnabled := (if (scalaVersion.value startsWith \"2.11\") true else false),\r\n...\r\n)\r\n```\r\n\r\nI still end up with coverage running in 2.12.0:\r\n```\r\n[tw-mbp-pnarang bijection (scala-2.12)]$ ./sbt \"+++2.12.0 test\"\r\n[info] Loading global plugins from /Users/pnarang/.sbt/0.13/plugins\r\n[info] Loading project definition from /Users/pnarang/workspace/bijection/project\r\n[info] Resolving key references (10437 settings) ...\r\n[info] Set current project to bijection (in build file:/Users/pnarang/workspace/bijection/)\r\n[info] Setting version to 2.12.0\r\n[info] Reapplying settings...\r\n[info] Set current project to bijection (in build file:/Users/pnarang/workspace/bijection/)\r\n[info] Compiling 27 Scala sources and 2 Java sources to /Users/pnarang/workspace/bijection/bijection-core/target/scala-2.11/classes...\r\n[info] [info] Cleaning datadir [/Users/pnarang/workspace/bijection/bijection-core/target/scala-2.11/scoverage-data]\r\n[info] [info] Beginning coverage instrumentation\r\n...\r\n```\r\n Seems like our default setting of scalaVersion = 2.11.8 is ensuring that is can't be updated even if we try to pass it with `++` or `+++`. \r\n\r\nThis shows up even in the sbt console:\r\n```\r\n$ ./sbt\r\n> ++ 2.10.6\r\n[info] Setting version to 2.10.6\r\n[info] Reapplying settings...\r\n[info] Set current project to bijection (in build file:/Users/pnarang/workspace/bijection/)\r\n> show scalaVersion\r\n[info] bijection-guava/*:scalaVersion\r\n[info] \t2.11.8\r\n...\r\n```\r\n\r\nNow if I comment out the line in build.sbt setting `scalaVersion := \"2.11.8\"`, this seems to work ok - both the sbt console and the coverage builds behave as expected. We show the version passed in `++` or `+++` and coverageEnabled = true only for 2.11. \r\n\r\nSeems like this problem is present even currently. We are checking scalaVersion to set scalacOptions - https://github.com/clhodapp/bijection/blob/eadf262306a1523514ad419671a00c8ee6e37105/build.sbt#L26. When I tested this out on the sbt command line, it seems like we're always setting the options for 2.11. "}}
{"actor":{"display_login":"piyushnarang"}}