{"action":"created","comment":{"url":"https://api.github.com/repos/piwik/piwik/pulls/comments/76874303","id":76874303,"diff_hunk":"@@ -73,8 +73,26 @@ public function aggregateMultipleReports()\n \n     private function aggregateByLabel($labelSQL, $recordName)\n     {\n-        $metrics = $this->getLogAggregator()->getMetricsFromVisitByDimension($labelSQL)->asDataTable();\n-        $report = $metrics->getSerialized($this->maximumRows, null, Metrics::INDEX_NB_VISITS);\n+        $metrics = $this->getLogAggregator()->getMetricsFromVisitByDimension($labelSQL);\n+\n+        if (in_array($recordName, array(self::DEVICE_TYPE_RECORD_NAME, self::DEVICE_BRAND_RECORD_NAME, self::DEVICE_MODEL_RECORD_NAME))) {\n+\n+            $labelSQL = str_replace('log_visit.', 'log_conversion.', $labelSQL);\n+\n+            $query = $this->getLogAggregator()->queryConversionsByDimension(array($labelSQL));\n+\n+            if ($query === false) {\n+                return;\n+            }\n+\n+            while ($conversionRow = $query->fetch()) {\n+\n+                $metrics->sumMetricsGoals($conversionRow[$labelSQL], $conversionRow);\n+            }\n+            $metrics->enrichMetricsWithConversions();\n+        }\n+\n+        $report = $metrics->asDataTable()->getSerialized($this->maximumRows, null, Metrics::INDEX_NB_VISITS);\n         $this->getProcessor()->insertBlobRecord($recordName, $report);","path":"plugins/DevicesDetection/Archiver.php","position":26,"original_position":26,"commit_id":"346d802909e07440d88e412c78b0b36e48328b04","original_commit_id":"346d802909e07440d88e412c78b0b36e48328b04","user":{"login":"tsteur","id":273120,"avatar_url":"https://avatars.githubusercontent.com/u/273120?v=3","gravatar_id":"","url":"https://api.github.com/users/tsteur","html_url":"https://github.com/tsteur","followers_url":"https://api.github.com/users/tsteur/followers","following_url":"https://api.github.com/users/tsteur/following{/other_user}","gists_url":"https://api.github.com/users/tsteur/gists{/gist_id}","starred_url":"https://api.github.com/users/tsteur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsteur/subscriptions","organizations_url":"https://api.github.com/users/tsteur/orgs","repos_url":"https://api.github.com/users/tsteur/repos","events_url":"https://api.github.com/users/tsteur/events{/privacy}","received_events_url":"https://api.github.com/users/tsteur/received_events","type":"User","site_admin":false},"body":"and just to be safe afterwards `unset($table);unset($report);`. Otherwise we might leak memory","created_at":"2016-08-30T20:38:18Z","updated_at":"2016-08-30T20:38:18Z","html_url":"https://github.com/piwik/piwik/pull/10070#discussion_r76874303","pull_request_url":"https://api.github.com/repos/piwik/piwik/pulls/10070","_links":{"self":{"href":"https://api.github.com/repos/piwik/piwik/pulls/comments/76874303"},"html":{"href":"https://github.com/piwik/piwik/pull/10070#discussion_r76874303"},"pull_request":{"href":"https://api.github.com/repos/piwik/piwik/pulls/10070"}}},"pull_request":{"url":"https://api.github.com/repos/piwik/piwik/pulls/10070","id":66923950,"html_url":"https://github.com/piwik/piwik/pull/10070","diff_url":"https://github.com/piwik/piwik/pull/10070.diff","patch_url":"https://github.com/piwik/piwik/pull/10070.patch","issue_url":"https://api.github.com/repos/piwik/piwik/issues/10070","number":10070,"state":"open","locked":false,"title":"Process goal conversions for device data (type, brand, model)","user":{"login":"sgiehl","id":1579355,"avatar_url":"https://avatars.githubusercontent.com/u/1579355?v=3","gravatar_id":"","url":"https://api.github.com/users/sgiehl","html_url":"https://github.com/sgiehl","followers_url":"https://api.github.com/users/sgiehl/followers","following_url":"https://api.github.com/users/sgiehl/following{/other_user}","gists_url":"https://api.github.com/users/sgiehl/gists{/gist_id}","starred_url":"https://api.github.com/users/sgiehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgiehl/subscriptions","organizations_url":"https://api.github.com/users/sgiehl/orgs","repos_url":"https://api.github.com/users/sgiehl/repos","events_url":"https://api.github.com/users/sgiehl/events{/privacy}","received_events_url":"https://api.github.com/users/sgiehl/received_events","type":"User","site_admin":false},"body":"rebased #10026 for 3.x\r\n(refs #9777)","created_at":"2016-04-18T21:19:50Z","updated_at":"2016-08-30T20:38:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92f1b652c4afadc893590499e0525f141b1c7bc4","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/piwik/piwik/milestones/87","html_url":"https://github.com/piwik/piwik/milestones/3.0.0-b1","labels_url":"https://api.github.com/repos/piwik/piwik/milestones/87/labels","id":1233156,"number":87,"title":"3.0.0-b1","description":"First public beta for Piwik 3.0.0. Includes database schema changes, code optimisations, and some core platform API changes and improvements. Send us your feedback! ","creator":{"login":"mattab","id":466765,"avatar_url":"https://avatars.githubusercontent.com/u/466765?v=3","gravatar_id":"","url":"https://api.github.com/users/mattab","html_url":"https://github.com/mattab","followers_url":"https://api.github.com/users/mattab/followers","following_url":"https://api.github.com/users/mattab/following{/other_user}","gists_url":"https://api.github.com/users/mattab/gists{/gist_id}","starred_url":"https://api.github.com/users/mattab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattab/subscriptions","organizations_url":"https://api.github.com/users/mattab/orgs","repos_url":"https://api.github.com/users/mattab/repos","events_url":"https://api.github.com/users/mattab/events{/privacy}","received_events_url":"https://api.github.com/users/mattab/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":56,"state":"open","created_at":"2015-07-30T09:33:07Z","updated_at":"2016-08-30T20:35:27Z","due_on":"2016-08-31T12:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/piwik/piwik/pulls/10070/commits","review_comments_url":"https://api.github.com/repos/piwik/piwik/pulls/10070/comments","review_comment_url":"https://api.github.com/repos/piwik/piwik/pulls/comments{/number}","comments_url":"https://api.github.com/repos/piwik/piwik/issues/10070/comments","statuses_url":"https://api.github.com/repos/piwik/piwik/statuses/346d802909e07440d88e412c78b0b36e48328b04","head":{"label":"piwik:devicegoalreports-3","ref":"devicegoalreports-3","sha":"346d802909e07440d88e412c78b0b36e48328b04","user":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"repo":{"id":1548202,"name":"piwik","full_name":"piwik/piwik","owner":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/piwik/piwik","description":"Liberating Web Analytics. Star us on Github? +1. Piwik is the leading open alternative to Google Analytics that gives you full control over your data. Piwik lets you easily collect data from websites, apps & the IoT and visualise this data and extract insights. Privacy is built-in. We love Pull Requests! ","fork":false,"url":"https://api.github.com/repos/piwik/piwik","forks_url":"https://api.github.com/repos/piwik/piwik/forks","keys_url":"https://api.github.com/repos/piwik/piwik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piwik/piwik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piwik/piwik/teams","hooks_url":"https://api.github.com/repos/piwik/piwik/hooks","issue_events_url":"https://api.github.com/repos/piwik/piwik/issues/events{/number}","events_url":"https://api.github.com/repos/piwik/piwik/events","assignees_url":"https://api.github.com/repos/piwik/piwik/assignees{/user}","branches_url":"https://api.github.com/repos/piwik/piwik/branches{/branch}","tags_url":"https://api.github.com/repos/piwik/piwik/tags","blobs_url":"https://api.github.com/repos/piwik/piwik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piwik/piwik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piwik/piwik/git/refs{/sha}","trees_url":"https://api.github.com/repos/piwik/piwik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piwik/piwik/statuses/{sha}","languages_url":"https://api.github.com/repos/piwik/piwik/languages","stargazers_url":"https://api.github.com/repos/piwik/piwik/stargazers","contributors_url":"https://api.github.com/repos/piwik/piwik/contributors","subscribers_url":"https://api.github.com/repos/piwik/piwik/subscribers","subscription_url":"https://api.github.com/repos/piwik/piwik/subscription","commits_url":"https://api.github.com/repos/piwik/piwik/commits{/sha}","git_commits_url":"https://api.github.com/repos/piwik/piwik/git/commits{/sha}","comments_url":"https://api.github.com/repos/piwik/piwik/comments{/number}","issue_comment_url":"https://api.github.com/repos/piwik/piwik/issues/comments{/number}","contents_url":"https://api.github.com/repos/piwik/piwik/contents/{+path}","compare_url":"https://api.github.com/repos/piwik/piwik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piwik/piwik/merges","archive_url":"https://api.github.com/repos/piwik/piwik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piwik/piwik/downloads","issues_url":"https://api.github.com/repos/piwik/piwik/issues{/number}","pulls_url":"https://api.github.com/repos/piwik/piwik/pulls{/number}","milestones_url":"https://api.github.com/repos/piwik/piwik/milestones{/number}","notifications_url":"https://api.github.com/repos/piwik/piwik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piwik/piwik/labels{/name}","releases_url":"https://api.github.com/repos/piwik/piwik/releases{/id}","deployments_url":"https://api.github.com/repos/piwik/piwik/deployments","created_at":"2011-03-30T21:18:17Z","updated_at":"2016-08-30T18:59:33Z","pushed_at":"2016-08-30T20:31:26Z","git_url":"git://github.com/piwik/piwik.git","ssh_url":"git@github.com:piwik/piwik.git","clone_url":"https://github.com/piwik/piwik.git","svn_url":"https://github.com/piwik/piwik","homepage":"http://piwik.org/","size":201565,"stargazers_count":5924,"watchers_count":5924,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1050,"mirror_url":null,"open_issues_count":1379,"forks":1050,"open_issues":1379,"watchers":5924,"default_branch":"master"}},"base":{"label":"piwik:3.x-dev","ref":"3.x-dev","sha":"24d8a0ee74fd6d6f26338c3efb8eb143eaed5ec0","user":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"repo":{"id":1548202,"name":"piwik","full_name":"piwik/piwik","owner":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/piwik/piwik","description":"Liberating Web Analytics. Star us on Github? +1. Piwik is the leading open alternative to Google Analytics that gives you full control over your data. Piwik lets you easily collect data from websites, apps & the IoT and visualise this data and extract insights. Privacy is built-in. We love Pull Requests! ","fork":false,"url":"https://api.github.com/repos/piwik/piwik","forks_url":"https://api.github.com/repos/piwik/piwik/forks","keys_url":"https://api.github.com/repos/piwik/piwik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piwik/piwik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piwik/piwik/teams","hooks_url":"https://api.github.com/repos/piwik/piwik/hooks","issue_events_url":"https://api.github.com/repos/piwik/piwik/issues/events{/number}","events_url":"https://api.github.com/repos/piwik/piwik/events","assignees_url":"https://api.github.com/repos/piwik/piwik/assignees{/user}","branches_url":"https://api.github.com/repos/piwik/piwik/branches{/branch}","tags_url":"https://api.github.com/repos/piwik/piwik/tags","blobs_url":"https://api.github.com/repos/piwik/piwik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piwik/piwik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piwik/piwik/git/refs{/sha}","trees_url":"https://api.github.com/repos/piwik/piwik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piwik/piwik/statuses/{sha}","languages_url":"https://api.github.com/repos/piwik/piwik/languages","stargazers_url":"https://api.github.com/repos/piwik/piwik/stargazers","contributors_url":"https://api.github.com/repos/piwik/piwik/contributors","subscribers_url":"https://api.github.com/repos/piwik/piwik/subscribers","subscription_url":"https://api.github.com/repos/piwik/piwik/subscription","commits_url":"https://api.github.com/repos/piwik/piwik/commits{/sha}","git_commits_url":"https://api.github.com/repos/piwik/piwik/git/commits{/sha}","comments_url":"https://api.github.com/repos/piwik/piwik/comments{/number}","issue_comment_url":"https://api.github.com/repos/piwik/piwik/issues/comments{/number}","contents_url":"https://api.github.com/repos/piwik/piwik/contents/{+path}","compare_url":"https://api.github.com/repos/piwik/piwik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piwik/piwik/merges","archive_url":"https://api.github.com/repos/piwik/piwik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piwik/piwik/downloads","issues_url":"https://api.github.com/repos/piwik/piwik/issues{/number}","pulls_url":"https://api.github.com/repos/piwik/piwik/pulls{/number}","milestones_url":"https://api.github.com/repos/piwik/piwik/milestones{/number}","notifications_url":"https://api.github.com/repos/piwik/piwik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piwik/piwik/labels{/name}","releases_url":"https://api.github.com/repos/piwik/piwik/releases{/id}","deployments_url":"https://api.github.com/repos/piwik/piwik/deployments","created_at":"2011-03-30T21:18:17Z","updated_at":"2016-08-30T18:59:33Z","pushed_at":"2016-08-30T20:31:26Z","git_url":"git://github.com/piwik/piwik.git","ssh_url":"git@github.com:piwik/piwik.git","clone_url":"https://github.com/piwik/piwik.git","svn_url":"https://github.com/piwik/piwik","homepage":"http://piwik.org/","size":201565,"stargazers_count":5924,"watchers_count":5924,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1050,"mirror_url":null,"open_issues_count":1379,"forks":1050,"open_issues":1379,"watchers":5924,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/piwik/piwik/pulls/10070"},"html":{"href":"https://github.com/piwik/piwik/pull/10070"},"issue":{"href":"https://api.github.com/repos/piwik/piwik/issues/10070"},"comments":{"href":"https://api.github.com/repos/piwik/piwik/issues/10070/comments"},"review_comments":{"href":"https://api.github.com/repos/piwik/piwik/pulls/10070/comments"},"review_comment":{"href":"https://api.github.com/repos/piwik/piwik/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/piwik/piwik/pulls/10070/commits"},"statuses":{"href":"https://api.github.com/repos/piwik/piwik/statuses/346d802909e07440d88e412c78b0b36e48328b04"}}}}
{"actor":{"display_login":"tsteur"}}