{"push_id":1378393687,"size":11,"distinct_size":10,"ref":"refs/heads/wip_newtab","head":"240fd64eb9de5c7679a8199e234569c7377306ce","before":"714552cc427bf3eb4f861151c92cba665c7ac30b","commits":[{"sha":"9ef1d63352b83e1f2e102aa9913feb3b7d35b2d9","author":{"name":"yan","email":"cabce391cf888f87596dff36824ebbf861bdc136@mit.edu"},"message":"Fix urlbar dropping last characters before ENTER\n\nFix https://github.com/brave/browser-laptop/issues/5189 by requesting\nthe location currently in the urlbar instead of the location in react\ncomponent state.\n\nAuditors: @bbondy\n\nTest Plan:\ntype 'somenewurl.com' quickly into the urlbar, hit enter as fast as possible,\nand make sure no characters are lost","distinct":false,"url":"https://api.github.com/repos/brave/browser-laptop/commits/9ef1d63352b83e1f2e102aa9913feb3b7d35b2d9"},{"sha":"b1fb29c3bd098dc71fb16486629da8716117d939","author":{"name":"Cezar Augusto","email":"ad369a8c7c598f65104b79b6ae138666da0f87e7@outlook.it"},"message":"new tab page","distinct":true,"url":"https://api.github.com/repos/brave/browser-laptop/commits/b1fb29c3bd098dc71fb16486629da8716117d939"},{"sha":"205012633074ff4a1a84f8d68bcd5a286824dd50","author":{"name":"Brian Clifton","email":"1d28577c3a34c1ac08d512237ad32156e7267b61@clifton.me"},"message":"Tweaks to about:newtab\n- moving SVGs into img/newtab/ folder\n- standardized colors between about:newtab and Bravery panel (pulled into variables.less)\n- marked items we don't want having text selection w/ -webkit-user-select:none\n- marked items as cursor:default, to ensure a more app-like feel (versus browser icons)\n- SVG icons in bottom right are now drawn via mask and have a hover color (@gray)","distinct":true,"url":"https://api.github.com/repos/brave/browser-laptop/commits/205012633074ff4a1a84f8d68bcd5a286824dd50"},{"sha":"d78d5b30c2f7398485f4de149d42330622795149","author":{"name":"Cezar Augusto","email":"ad369a8c7c598f65104b79b6ae138666da0f87e7@outlook.it"},"message":"- Fix title attr to topSites bookmark action\n- check if topSites bookmark action has title ok\n- Add new removalNotification component\n- Break newTab component into separated modules","distinct":true,"url":"https://api.github.com/repos/brave/browser-laptop/commits/d78d5b30c2f7398485f4de149d42330622795149"},{"sha":"5aa0dcfa550699c00bd032981b7c3c1fec938070","author":{"name":"Brian Clifton","email":"1d28577c3a34c1ac08d512237ad32156e7267b61@clifton.me"},"message":"- Revert \"Fix title attr to topSites bookmark action\"\n- Manually add strings to newtab.properties; removing from app.properties broke the star button next to omnibox\n- Adding tests for about:newtab\n- Fixed bookmark behavior; title is correct (add or edit; recent changes not related to newtab updated this behavior)","distinct":true,"url":"https://api.github.com/repos/brave/browser-laptop/commits/5aa0dcfa550699c00bd032981b7c3c1fec938070"},{"sha":"f89328e927015d39592fa4b84a80ac87a15bfcfe","author":{"name":"Cezar Augusto","email":"ad369a8c7c598f65104b79b6ae138666da0f87e7@outlook.it"},"message":"add actions for removal notification","distinct":true,"url":"https://api.github.com/repos/brave/browser-laptop/commits/f89328e927015d39592fa4b84a80ac87a15bfcfe"},{"sha":"4c6014f604b93c4b677809118027c32a54affe99","author":{"name":"Brian Clifton","email":"1d28577c3a34c1ac08d512237ad32156e7267b61@clifton.me"},"message":"- Updated SiteRemovalNotification to use component state (triggering re-render when change happens)\n- Updated photographer name/link to come from config (temporary- it should be stored w/ the background JSON)\n- Updated styles to match expected behavior (no border on close button, pointer cursor on undo/restore all links, etc)","distinct":true,"url":"https://api.github.com/repos/brave/browser-laptop/commits/4c6014f604b93c4b677809118027c32a54affe99"},{"sha":"06fbe05002c534ead95d2940ddc7832d4eb5e3de","author":{"name":"Cezar Augusto","email":"ad369a8c7c598f65104b79b6ae138666da0f87e7@outlook.it"},"message":"Add option to unpin topSites\n\nAuditors: @bsclifton\n\nTest Plan:\n\n* Pin a topSite\n* Check that there are a pinned icon\n* Hover over topSite\n* Check that there are a minus icon\n* Hit minus icon\n* Pinned icon should be removed","distinct":true,"url":"https://api.github.com/repos/brave/browser-laptop/commits/06fbe05002c534ead95d2940ddc7832d4eb5e3de"},{"sha":"995207020f76229332b4da7571504fd9d2d10173","author":{"name":"Brian Clifton","email":"1d28577c3a34c1ac08d512237ad32156e7267b61@clifton.me"},"message":"Lots of small items:\n- All images (except one) removed from project\n- Image details are now stored in json in ./js/data/backgrounds.js\n- Images will try to load remotely:\n  - if they fail, they'll fall back to the built-in image (see config.js)\n  - if the built-in image fails, the screen still looks nice (uses gradient)\n  - screen desperately needs fade in transition to avoid FOUC (https://en.wikipedia.org/wiki/Flash_of_unstyled_content)\n- Properties that read newTabState moved into stats component\n- Code retrieving about links moved into footer component\n- Components not using state were updated to inherit from ImmutableComponent\n- Clock updated to start with a time (no longer waits 1 second before showing)\n- remove multiple calls to aboutAction where possible\n- fix broken bookmark button (handlers had wrong names)\n\nNOTE: the ONLY way I could find to detect image load failure was to put a hidden\nimage tag with an onerror handler. Having a div with a `background-image` CSS\nattribute doesn't appear to offer a way to catch the error. You can provide a\nfallback image URL, but the title of the image won't match (and down the road,\nthe author details may not match, if there are multiple authors)","distinct":true,"url":"https://api.github.com/repos/brave/browser-laptop/commits/995207020f76229332b4da7571504fd9d2d10173"},{"sha":"cccf7bc9475a2f285b32b4b18a40a7e8dee60481","author":{"name":"Scott King","email":"55c21dc1ae3533c4dd301e78334c027ecd0dc812@gmail.com"},"message":"Initial work done for https://github.com/brave/browser-laptop/issues/2106\n\n- Add settings for new tab behaviour, handle this behaviour when you click the new tab button\n- Scaffolding for deafult search engine appearing as new tab\n- Grab proper search engine information on new tab\n- New tab can load default search engine\n- Add functionality for new tab options\n- Abstraction of handling new tab settings\n- Hopefully final abstraction to complete new tab functionality","distinct":true,"url":"https://api.github.com/repos/brave/browser-laptop/commits/cccf7bc9475a2f285b32b4b18a40a7e8dee60481"},{"sha":"240fd64eb9de5c7679a8199e234569c7377306ce","author":{"name":"Brian Clifton","email":"1d28577c3a34c1ac08d512237ad32156e7267b61@clifton.me"},"message":"Finishing up settings for newtab:\n\nFixes https://github.com/brave/browser-laptop/issues/2106\n\n- pulled out setting values into an enum\n- position moved to below \"Brave starts with\" (in preferences.js)\n- resolved circular dependency issue in appUrlUtil which broke app\n- made a newtab option called BLANK and renamed value TEMP. We can change back when ready to go live\n- defaultUrl removed from main.js (since it gets defaulted in windowStore.js)\n- removed defaultUrl from window.js (since windowStore.js also handles this)\n- put about pages into config; updated contextMenus.js to use config constants\n- adding missing \"base\" element to searchProviders that had it missing (mdn, github, startpage, etc)\n- updated defaultUrl logic in appUrlUtil.js to default unknown values to about:blank\n- windowStore.js now uses new defaultUrl method (from appUrlUtil) instead of config.defaultUrl\n\nAuditors: @kingscott @cezaraugusto","distinct":true,"url":"https://api.github.com/repos/brave/browser-laptop/commits/240fd64eb9de5c7679a8199e234569c7377306ce"}]}
{"actor":{"display_login":"bsclifton"}}