{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/90136307","pull_request_review_id":10660432,"id":90136307,"diff_hunk":"@@ -84,9 +88,8 @@ export default React.createClass( {\n \t},\n \n \trender() {\n+\t\tconst { site, translate } = this.props;\n \t\tconst classes = classNames( this.props.className, 'upgrade-nudge' );\n-\n-\t\tconst site = sites.getSelectedSite();\n \t\tlet href = this.props.href;\n \n \t\tif ( ! this.shouldDisplay( site ) ) {","path":"client/my-sites/upgrade-nudge/index.jsx","position":90,"original_position":90,"commit_id":"2d54e23200ae0e42900ab2ce890467ce705836ca","original_commit_id":"2d54e23200ae0e42900ab2ce890467ce705836ca","user":{"login":"gwwar","id":1270189,"avatar_url":"https://avatars.githubusercontent.com/u/1270189?v=3","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"body":"We don't need to pass site into the function, since we removed it above.","created_at":"2016-11-29T23:08:59Z","updated_at":"2016-11-29T23:08:59Z","html_url":"https://github.com/Automattic/wp-calypso/pull/9332#discussion_r90136307","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/9332","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/90136307"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/9332#discussion_r90136307"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/9332"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/9332","id":93471599,"html_url":"https://github.com/Automattic/wp-calypso/pull/9332","diff_url":"https://github.com/Automattic/wp-calypso/pull/9332.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/9332.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/9332","number":9332,"state":"open","locked":false,"title":"Remove SiteList ref from UpgradeNudge and Localize UpgradeNudge","user":{"login":"spen","id":4335450,"avatar_url":"https://avatars.githubusercontent.com/u/4335450?v=3","gravatar_id":"","url":"https://api.github.com/users/spen","html_url":"https://github.com/spen","followers_url":"https://api.github.com/users/spen/followers","following_url":"https://api.github.com/users/spen/following{/other_user}","gists_url":"https://api.github.com/users/spen/gists{/gist_id}","starred_url":"https://api.github.com/users/spen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spen/subscriptions","organizations_url":"https://api.github.com/users/spen/orgs","repos_url":"https://api.github.com/users/spen/repos","events_url":"https://api.github.com/users/spen/events{/privacy}","received_events_url":"https://api.github.com/users/spen/received_events","type":"User","site_admin":false},"body":"### Aims\r\nAs part of #8726, this PR removes reference to 'lib/sites-list' in the UpgradeNudge component.\r\n\r\nAlso, while refactoring I added the localize HoC :)\r\n\r\n### Test Plan\r\n\r\n- Navigate to [stat insights](http://calypso.localhost:3000/stats/insights) and select a ___.wordpress.com site.\r\n- Scroll to find the 'nudge', it should appear between `Most popular day and hour` and `Comments`.\r\n- Check that this nudge has not changed in anyway\r\n    - it should be visually identical before & after this patch\r\n    - clicking it should route to `domains/add/__site-name__`\r\n","created_at":"2016-11-13T12:42:01Z","updated_at":"2016-11-29T23:08:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c084f290e418fc55c0f022f5d312423b1de805ff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/9332/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/9332/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/9332/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/2d54e23200ae0e42900ab2ce890467ce705836ca","head":{"label":"spen:update/remove-site-list-ref-from-upgrade-nudge","ref":"update/remove-site-list-ref-from-upgrade-nudge","sha":"2d54e23200ae0e42900ab2ce890467ce705836ca","user":{"login":"spen","id":4335450,"avatar_url":"https://avatars.githubusercontent.com/u/4335450?v=3","gravatar_id":"","url":"https://api.github.com/users/spen","html_url":"https://github.com/spen","followers_url":"https://api.github.com/users/spen/followers","following_url":"https://api.github.com/users/spen/following{/other_user}","gists_url":"https://api.github.com/users/spen/gists{/gist_id}","starred_url":"https://api.github.com/users/spen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spen/subscriptions","organizations_url":"https://api.github.com/users/spen/orgs","repos_url":"https://api.github.com/users/spen/repos","events_url":"https://api.github.com/users/spen/events{/privacy}","received_events_url":"https://api.github.com/users/spen/received_events","type":"User","site_admin":false},"repo":{"id":69190490,"name":"wp-calypso","full_name":"spen/wp-calypso","owner":{"login":"spen","id":4335450,"avatar_url":"https://avatars.githubusercontent.com/u/4335450?v=3","gravatar_id":"","url":"https://api.github.com/users/spen","html_url":"https://github.com/spen","followers_url":"https://api.github.com/users/spen/followers","following_url":"https://api.github.com/users/spen/following{/other_user}","gists_url":"https://api.github.com/users/spen/gists{/gist_id}","starred_url":"https://api.github.com/users/spen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spen/subscriptions","organizations_url":"https://api.github.com/users/spen/orgs","repos_url":"https://api.github.com/users/spen/repos","events_url":"https://api.github.com/users/spen/events{/privacy}","received_events_url":"https://api.github.com/users/spen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spen/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":true,"url":"https://api.github.com/repos/spen/wp-calypso","forks_url":"https://api.github.com/repos/spen/wp-calypso/forks","keys_url":"https://api.github.com/repos/spen/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spen/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spen/wp-calypso/teams","hooks_url":"https://api.github.com/repos/spen/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/spen/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/spen/wp-calypso/events","assignees_url":"https://api.github.com/repos/spen/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/spen/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/spen/wp-calypso/tags","blobs_url":"https://api.github.com/repos/spen/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spen/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spen/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/spen/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spen/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/spen/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/spen/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/spen/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/spen/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/spen/wp-calypso/subscription","commits_url":"https://api.github.com/repos/spen/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/spen/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/spen/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/spen/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/spen/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/spen/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spen/wp-calypso/merges","archive_url":"https://api.github.com/repos/spen/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spen/wp-calypso/downloads","issues_url":"https://api.github.com/repos/spen/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/spen/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/spen/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/spen/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spen/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/spen/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/spen/wp-calypso/deployments","created_at":"2016-09-25T21:04:20Z","updated_at":"2016-09-25T21:04:29Z","pushed_at":"2016-11-29T13:55:16Z","git_url":"git://github.com/spen/wp-calypso.git","ssh_url":"git@github.com:spen/wp-calypso.git","clone_url":"https://github.com/spen/wp-calypso.git","svn_url":"https://github.com/spen/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":31709,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"27f8beb0bf624160099642b76306dbea0bed5155","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-11-29T11:29:02Z","pushed_at":"2016-11-29T23:07:13Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":153408,"stargazers_count":8139,"watchers_count":8139,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1029,"mirror_url":null,"open_issues_count":1585,"forks":1029,"open_issues":1585,"watchers":8139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/9332"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/9332"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/9332"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/9332/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/9332/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/9332/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/2d54e23200ae0e42900ab2ce890467ce705836ca"}}}}
{"actor":{"display_login":"gwwar"}}