{"action":"created","comment":{"url":"https://api.github.com/repos/yarpc/yab/pulls/comments/64623552","id":64623552,"diff_hunk":"@@ -26,6 +26,10 @@ import (\n \n \t\"gopkg.in/yaml.v2\"\n \n+\t\"strings\"\n+\n+\t\"strconv\"","path":"thrift/to_wire.go","position":6,"original_position":6,"commit_id":"183b7ea7e626ffdce67d986d287a68bcd5aa4351","original_commit_id":"183b7ea7e626ffdce67d986d287a68bcd5aa4351","user":{"login":"prashantv","id":140159,"avatar_url":"https://avatars.githubusercontent.com/u/140159?v=3","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"body":"fixed, VS Code's \"Add Import\" apparently just doesn't care about import ordering or grouping","created_at":"2016-05-25T18:09:50Z","updated_at":"2016-05-25T18:09:50Z","html_url":"https://github.com/yarpc/yab/pull/37#discussion_r64623552","pull_request_url":"https://api.github.com/repos/yarpc/yab/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/yarpc/yab/pulls/comments/64623552"},"html":{"href":"https://github.com/yarpc/yab/pull/37#discussion_r64623552"},"pull_request":{"href":"https://api.github.com/repos/yarpc/yab/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/yarpc/yab/pulls/37","id":71419613,"html_url":"https://github.com/yarpc/yab/pull/37","diff_url":"https://github.com/yarpc/yab/pull/37.diff","patch_url":"https://github.com/yarpc/yab/pull/37.patch","issue_url":"https://api.github.com/repos/yarpc/yab/issues/37","number":37,"state":"open","locked":false,"title":"thrift: Improve handling of enums","user":{"login":"prashantv","id":140159,"avatar_url":"https://avatars.githubusercontent.com/u/140159?v=3","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"body":"When an enum value is received over the wire, it is formatted using the\r\nname. If a name is not found, it is formatted as EnumType(%d)\r\n\r\nEnums can be specified as:\r\n- int32\r\n- Case-insentivie name\r\n- EnumType(%d)\r\n\r\nThe last format is so that formatted unknown enums on the result path\r\ncan be used as input.","created_at":"2016-05-25T16:10:49Z","updated_at":"2016-05-25T18:09:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea74507e80144892355e5e17c95dfaee9a1d8b54","assignee":{"login":"abhinav","id":41730,"avatar_url":"https://avatars.githubusercontent.com/u/41730?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinav","html_url":"https://github.com/abhinav","followers_url":"https://api.github.com/users/abhinav/followers","following_url":"https://api.github.com/users/abhinav/following{/other_user}","gists_url":"https://api.github.com/users/abhinav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav/subscriptions","organizations_url":"https://api.github.com/users/abhinav/orgs","repos_url":"https://api.github.com/users/abhinav/repos","events_url":"https://api.github.com/users/abhinav/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/yarpc/yab/pulls/37/commits","review_comments_url":"https://api.github.com/repos/yarpc/yab/pulls/37/comments","review_comment_url":"https://api.github.com/repos/yarpc/yab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarpc/yab/issues/37/comments","statuses_url":"https://api.github.com/repos/yarpc/yab/statuses/183b7ea7e626ffdce67d986d287a68bcd5aa4351","head":{"label":"yarpc:enum_name","ref":"enum_name","sha":"183b7ea7e626ffdce67d986d287a68bcd5aa4351","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":53321582,"name":"yab","full_name":"yarpc/yab","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/yab","description":"Benchmarking utility for Thrift, works with HTTP and TChannel","fork":false,"url":"https://api.github.com/repos/yarpc/yab","forks_url":"https://api.github.com/repos/yarpc/yab/forks","keys_url":"https://api.github.com/repos/yarpc/yab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yab/teams","hooks_url":"https://api.github.com/repos/yarpc/yab/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yab/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yab/events","assignees_url":"https://api.github.com/repos/yarpc/yab/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yab/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yab/tags","blobs_url":"https://api.github.com/repos/yarpc/yab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yab/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yab/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yab/languages","stargazers_url":"https://api.github.com/repos/yarpc/yab/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yab/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yab/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yab/subscription","commits_url":"https://api.github.com/repos/yarpc/yab/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yab/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yab/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yab/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yab/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yab/merges","archive_url":"https://api.github.com/repos/yarpc/yab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yab/downloads","issues_url":"https://api.github.com/repos/yarpc/yab/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yab/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yab/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yab/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yab/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yab/deployments","created_at":"2016-03-07T11:48:58Z","updated_at":"2016-03-24T00:48:38Z","pushed_at":"2016-05-25T17:24:58Z","git_url":"git://github.com/yarpc/yab.git","ssh_url":"git@github.com:yarpc/yab.git","clone_url":"https://github.com/yarpc/yab.git","svn_url":"https://github.com/yarpc/yab","homepage":"","size":158,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"dev"}},"base":{"label":"yarpc:dev","ref":"dev","sha":"207e3049a59aa221c9e3efe62585b4290b219789","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":53321582,"name":"yab","full_name":"yarpc/yab","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/yab","description":"Benchmarking utility for Thrift, works with HTTP and TChannel","fork":false,"url":"https://api.github.com/repos/yarpc/yab","forks_url":"https://api.github.com/repos/yarpc/yab/forks","keys_url":"https://api.github.com/repos/yarpc/yab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yab/teams","hooks_url":"https://api.github.com/repos/yarpc/yab/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yab/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yab/events","assignees_url":"https://api.github.com/repos/yarpc/yab/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yab/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yab/tags","blobs_url":"https://api.github.com/repos/yarpc/yab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yab/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yab/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yab/languages","stargazers_url":"https://api.github.com/repos/yarpc/yab/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yab/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yab/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yab/subscription","commits_url":"https://api.github.com/repos/yarpc/yab/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yab/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yab/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yab/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yab/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yab/merges","archive_url":"https://api.github.com/repos/yarpc/yab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yab/downloads","issues_url":"https://api.github.com/repos/yarpc/yab/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yab/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yab/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yab/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yab/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yab/deployments","created_at":"2016-03-07T11:48:58Z","updated_at":"2016-03-24T00:48:38Z","pushed_at":"2016-05-25T17:24:58Z","git_url":"git://github.com/yarpc/yab.git","ssh_url":"git@github.com:yarpc/yab.git","clone_url":"https://github.com/yarpc/yab.git","svn_url":"https://github.com/yarpc/yab","homepage":"","size":158,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/yarpc/yab/pulls/37"},"html":{"href":"https://github.com/yarpc/yab/pull/37"},"issue":{"href":"https://api.github.com/repos/yarpc/yab/issues/37"},"comments":{"href":"https://api.github.com/repos/yarpc/yab/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/yarpc/yab/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/yarpc/yab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarpc/yab/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/yarpc/yab/statuses/183b7ea7e626ffdce67d986d287a68bcd5aa4351"}}}}
{"actor":{"display_login":"prashantv"}}