{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-protobuf/issues/160","repository_url":"https://api.github.com/repos/apple/swift-protobuf","labels_url":"https://api.github.com/repos/apple/swift-protobuf/issues/160/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-protobuf/issues/160/comments","events_url":"https://api.github.com/repos/apple/swift-protobuf/issues/160/events","html_url":"https://github.com/apple/swift-protobuf/issues/160","id":193871742,"number":160,"title":"Move conformance test runner into this project","user":{"login":"allevato","id":1062427,"avatar_url":"https://avatars.githubusercontent.com/u/1062427?v=3","gravatar_id":"","url":"https://api.github.com/users/allevato","html_url":"https://github.com/allevato","followers_url":"https://api.github.com/users/allevato/followers","following_url":"https://api.github.com/users/allevato/following{/other_user}","gists_url":"https://api.github.com/users/allevato/gists{/gist_id}","starred_url":"https://api.github.com/users/allevato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allevato/subscriptions","organizations_url":"https://api.github.com/users/allevato/orgs","repos_url":"https://api.github.com/users/allevato/repos","events_url":"https://api.github.com/users/allevato/events{/privacy}","received_events_url":"https://api.github.com/users/allevato/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"allevato","id":1062427,"avatar_url":"https://avatars.githubusercontent.com/u/1062427?v=3","gravatar_id":"","url":"https://api.github.com/users/allevato","html_url":"https://github.com/allevato","followers_url":"https://api.github.com/users/allevato/followers","following_url":"https://api.github.com/users/allevato/following{/other_user}","gists_url":"https://api.github.com/users/allevato/gists{/gist_id}","starred_url":"https://api.github.com/users/allevato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allevato/subscriptions","organizations_url":"https://api.github.com/users/allevato/orgs","repos_url":"https://api.github.com/users/allevato/repos","events_url":"https://api.github.com/users/allevato/events{/privacy}","received_events_url":"https://api.github.com/users/allevato/received_events","type":"User","site_admin":false},"assignees":[{"login":"allevato","id":1062427,"avatar_url":"https://avatars.githubusercontent.com/u/1062427?v=3","gravatar_id":"","url":"https://api.github.com/users/allevato","html_url":"https://github.com/allevato","followers_url":"https://api.github.com/users/allevato/followers","following_url":"https://api.github.com/users/allevato/following{/other_user}","gists_url":"https://api.github.com/users/allevato/gists{/gist_id}","starred_url":"https://api.github.com/users/allevato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allevato/subscriptions","organizations_url":"https://api.github.com/users/allevato/orgs","repos_url":"https://api.github.com/users/allevato/repos","events_url":"https://api.github.com/users/allevato/events{/privacy}","received_events_url":"https://api.github.com/users/allevato/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-12-06T20:10:43Z","updated_at":"2016-12-07T20:43:58Z","closed_at":"2016-12-07T20:14:33Z","body":"Forking off from #125.\r\n\r\nHaving the conformance test runner in a separate project makes it difficult to iteratively develop and ensure that both the runner stays up to date and that changes we make to the runtime/codegen don't break conformance tests. We should add it as a top-level target in `swift-protobuf`'s package description, then delete the `swift-protobuf-test-conformance` project.\r\n\r\nAlthough it will increase build times currently, keeping our code health up is (IMO) a higher priority right now.\r\n\r\nEventually, the accepted Swift Evolution proposal [SE-0146](https://github.com/apple/swift-evolution/blob/master/proposals/0146-package-manager-product-definitions.md) will be implemented that lets us define individual products, and clients can depend on just the runtime product to avoid building the entire project.\r\n\r\nI'll prepare a PR that moves over the necessary files, then updates them to compile with the latest version of the runtime."},"comment":{"url":"https://api.github.com/repos/apple/swift-protobuf/issues/comments/265567728","html_url":"https://github.com/apple/swift-protobuf/issues/160#issuecomment-265567728","issue_url":"https://api.github.com/repos/apple/swift-protobuf/issues/160","id":265567728,"user":{"login":"thomasvl","id":5279928,"avatar_url":"https://avatars.githubusercontent.com/u/5279928?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasvl","html_url":"https://github.com/thomasvl","followers_url":"https://api.github.com/users/thomasvl/followers","following_url":"https://api.github.com/users/thomasvl/following{/other_user}","gists_url":"https://api.github.com/users/thomasvl/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasvl/subscriptions","organizations_url":"https://api.github.com/users/thomasvl/orgs","repos_url":"https://api.github.com/users/thomasvl/repos","events_url":"https://api.github.com/users/thomasvl/events{/privacy}","received_events_url":"https://api.github.com/users/thomasvl/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T20:43:58Z","updated_at":"2016-12-07T20:43:58Z","body":"@tbkka now that this is moved, what's the store with `Tests/SwiftProtobufTests/Test_Conformance.swift` and `Tests/SwiftProtobufTests/Test_JSON_Conformance.swift`.  Does the conformance test cover those?  Should we drop them?\r\n"}}
{"actor":{"display_login":"thomasvl"}}