{"action":"opened","number":1081,"pull_request":{"url":"https://api.github.com/repos/numenta/nupic.core/pulls/1081","id":85326385,"html_url":"https://github.com/numenta/nupic.core/pull/1081","diff_url":"https://github.com/numenta/nupic.core/pull/1081.diff","patch_url":"https://github.com/numenta/nupic.core/pull/1081.patch","issue_url":"https://api.github.com/repos/numenta/nupic.core/issues/1081","number":1081,"state":"open","locked":false,"title":"Faster local inhibition: Stop creating lists of neighbors","user":{"login":"mrcslws","id":364113,"avatar_url":"https://avatars.githubusercontent.com/u/364113?v=3","gravatar_id":"","url":"https://api.github.com/users/mrcslws","html_url":"https://github.com/mrcslws","followers_url":"https://api.github.com/users/mrcslws/followers","following_url":"https://api.github.com/users/mrcslws/following{/other_user}","gists_url":"https://api.github.com/users/mrcslws/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcslws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcslws/subscriptions","organizations_url":"https://api.github.com/users/mrcslws/orgs","repos_url":"https://api.github.com/users/mrcslws/repos","events_url":"https://api.github.com/users/mrcslws/events{/privacy}","received_events_url":"https://api.github.com/users/mrcslws/received_events","type":"User","site_admin":false},"body":"Introduces a `Neighborhood` class which lets you iterate over all points in a neighborhood without ever creating a list of points.\r\n\r\nThis change also fixes a bug in the SP's `mapColumn_`. When I removed the `sort` call, the compatibility tests started failing, and this was the root cause.\r\n\r\nFixes #1079 \r\nFixes #1080\r\nFixes #128 (no more extraneous sorting)\r\n\r\nThis affects algorithm results for two reasons:\r\n\r\n- We walk neighbors in a different order.\r\n- `mapColumn_` is no longer broken.\r\n  - Though this bug wasn't showing up in the SP compatibility tests until I removed neighbor sorting.\r\n\r\n## Perf results\r\n\r\n**Before:**\r\n\r\n~~~\r\n> time python nupic.research/projects/sp_paper/train_sp_topology_simple.py\r\n\r\nreal\t0m51.560s\r\n~~~\r\n\r\n**After:**\r\n\r\n~~~\r\n> time python nupic.research/projects/sp_paper/train_sp_topology_simple.py\r\n\r\nreal\t0m7.755s\r\n~~~\r\n\r\nSo with this topology, it's 6.5x faster. For larger topologies where each column has more neighbors, it will be more dramatic.","created_at":"2016-09-14T23:59:20Z","updated_at":"2016-09-14T23:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/numenta/nupic.core/pulls/1081/commits","review_comments_url":"https://api.github.com/repos/numenta/nupic.core/pulls/1081/comments","review_comment_url":"https://api.github.com/repos/numenta/nupic.core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numenta/nupic.core/issues/1081/comments","statuses_url":"https://api.github.com/repos/numenta/nupic.core/statuses/e3e6fa68dae5c532cc936ff7bf452fecf8330166","head":{"label":"mrcslws:neighborhood","ref":"neighborhood","sha":"e3e6fa68dae5c532cc936ff7bf452fecf8330166","user":{"login":"mrcslws","id":364113,"avatar_url":"https://avatars.githubusercontent.com/u/364113?v=3","gravatar_id":"","url":"https://api.github.com/users/mrcslws","html_url":"https://github.com/mrcslws","followers_url":"https://api.github.com/users/mrcslws/followers","following_url":"https://api.github.com/users/mrcslws/following{/other_user}","gists_url":"https://api.github.com/users/mrcslws/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcslws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcslws/subscriptions","organizations_url":"https://api.github.com/users/mrcslws/orgs","repos_url":"https://api.github.com/users/mrcslws/repos","events_url":"https://api.github.com/users/mrcslws/events{/privacy}","received_events_url":"https://api.github.com/users/mrcslws/received_events","type":"User","site_admin":false},"repo":{"id":51950553,"name":"nupic.core","full_name":"mrcslws/nupic.core","owner":{"login":"mrcslws","id":364113,"avatar_url":"https://avatars.githubusercontent.com/u/364113?v=3","gravatar_id":"","url":"https://api.github.com/users/mrcslws","html_url":"https://github.com/mrcslws","followers_url":"https://api.github.com/users/mrcslws/followers","following_url":"https://api.github.com/users/mrcslws/following{/other_user}","gists_url":"https://api.github.com/users/mrcslws/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcslws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcslws/subscriptions","organizations_url":"https://api.github.com/users/mrcslws/orgs","repos_url":"https://api.github.com/users/mrcslws/repos","events_url":"https://api.github.com/users/mrcslws/events{/privacy}","received_events_url":"https://api.github.com/users/mrcslws/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrcslws/nupic.core","description":"Implementation of core NuPIC algorithms in C++ (under construction)","fork":true,"url":"https://api.github.com/repos/mrcslws/nupic.core","forks_url":"https://api.github.com/repos/mrcslws/nupic.core/forks","keys_url":"https://api.github.com/repos/mrcslws/nupic.core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrcslws/nupic.core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrcslws/nupic.core/teams","hooks_url":"https://api.github.com/repos/mrcslws/nupic.core/hooks","issue_events_url":"https://api.github.com/repos/mrcslws/nupic.core/issues/events{/number}","events_url":"https://api.github.com/repos/mrcslws/nupic.core/events","assignees_url":"https://api.github.com/repos/mrcslws/nupic.core/assignees{/user}","branches_url":"https://api.github.com/repos/mrcslws/nupic.core/branches{/branch}","tags_url":"https://api.github.com/repos/mrcslws/nupic.core/tags","blobs_url":"https://api.github.com/repos/mrcslws/nupic.core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrcslws/nupic.core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrcslws/nupic.core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrcslws/nupic.core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrcslws/nupic.core/statuses/{sha}","languages_url":"https://api.github.com/repos/mrcslws/nupic.core/languages","stargazers_url":"https://api.github.com/repos/mrcslws/nupic.core/stargazers","contributors_url":"https://api.github.com/repos/mrcslws/nupic.core/contributors","subscribers_url":"https://api.github.com/repos/mrcslws/nupic.core/subscribers","subscription_url":"https://api.github.com/repos/mrcslws/nupic.core/subscription","commits_url":"https://api.github.com/repos/mrcslws/nupic.core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrcslws/nupic.core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrcslws/nupic.core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrcslws/nupic.core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrcslws/nupic.core/contents/{+path}","compare_url":"https://api.github.com/repos/mrcslws/nupic.core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrcslws/nupic.core/merges","archive_url":"https://api.github.com/repos/mrcslws/nupic.core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrcslws/nupic.core/downloads","issues_url":"https://api.github.com/repos/mrcslws/nupic.core/issues{/number}","pulls_url":"https://api.github.com/repos/mrcslws/nupic.core/pulls{/number}","milestones_url":"https://api.github.com/repos/mrcslws/nupic.core/milestones{/number}","notifications_url":"https://api.github.com/repos/mrcslws/nupic.core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrcslws/nupic.core/labels{/name}","releases_url":"https://api.github.com/repos/mrcslws/nupic.core/releases{/id}","deployments_url":"https://api.github.com/repos/mrcslws/nupic.core/deployments","created_at":"2016-02-17T19:50:37Z","updated_at":"2016-02-17T19:50:39Z","pushed_at":"2016-09-14T23:37:01Z","git_url":"git://github.com/mrcslws/nupic.core.git","ssh_url":"git@github.com:mrcslws/nupic.core.git","clone_url":"https://github.com/mrcslws/nupic.core.git","svn_url":"https://github.com/mrcslws/nupic.core","homepage":"http://numenta.org","size":182046,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numenta:master","ref":"master","sha":"78f20ffea1f1f07e5d7fd529dd298c521abe0841","user":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"repo":{"id":16366081,"name":"nupic.core","full_name":"numenta/nupic.core","owner":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numenta/nupic.core","description":"Implementation of core NuPIC algorithms in C++ (under construction)","fork":false,"url":"https://api.github.com/repos/numenta/nupic.core","forks_url":"https://api.github.com/repos/numenta/nupic.core/forks","keys_url":"https://api.github.com/repos/numenta/nupic.core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numenta/nupic.core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numenta/nupic.core/teams","hooks_url":"https://api.github.com/repos/numenta/nupic.core/hooks","issue_events_url":"https://api.github.com/repos/numenta/nupic.core/issues/events{/number}","events_url":"https://api.github.com/repos/numenta/nupic.core/events","assignees_url":"https://api.github.com/repos/numenta/nupic.core/assignees{/user}","branches_url":"https://api.github.com/repos/numenta/nupic.core/branches{/branch}","tags_url":"https://api.github.com/repos/numenta/nupic.core/tags","blobs_url":"https://api.github.com/repos/numenta/nupic.core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numenta/nupic.core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numenta/nupic.core/git/refs{/sha}","trees_url":"https://api.github.com/repos/numenta/nupic.core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numenta/nupic.core/statuses/{sha}","languages_url":"https://api.github.com/repos/numenta/nupic.core/languages","stargazers_url":"https://api.github.com/repos/numenta/nupic.core/stargazers","contributors_url":"https://api.github.com/repos/numenta/nupic.core/contributors","subscribers_url":"https://api.github.com/repos/numenta/nupic.core/subscribers","subscription_url":"https://api.github.com/repos/numenta/nupic.core/subscription","commits_url":"https://api.github.com/repos/numenta/nupic.core/commits{/sha}","git_commits_url":"https://api.github.com/repos/numenta/nupic.core/git/commits{/sha}","comments_url":"https://api.github.com/repos/numenta/nupic.core/comments{/number}","issue_comment_url":"https://api.github.com/repos/numenta/nupic.core/issues/comments{/number}","contents_url":"https://api.github.com/repos/numenta/nupic.core/contents/{+path}","compare_url":"https://api.github.com/repos/numenta/nupic.core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numenta/nupic.core/merges","archive_url":"https://api.github.com/repos/numenta/nupic.core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numenta/nupic.core/downloads","issues_url":"https://api.github.com/repos/numenta/nupic.core/issues{/number}","pulls_url":"https://api.github.com/repos/numenta/nupic.core/pulls{/number}","milestones_url":"https://api.github.com/repos/numenta/nupic.core/milestones{/number}","notifications_url":"https://api.github.com/repos/numenta/nupic.core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numenta/nupic.core/labels{/name}","releases_url":"https://api.github.com/repos/numenta/nupic.core/releases{/id}","deployments_url":"https://api.github.com/repos/numenta/nupic.core/deployments","created_at":"2014-01-30T02:13:40Z","updated_at":"2016-09-04T12:56:07Z","pushed_at":"2016-09-14T23:59:20Z","git_url":"git://github.com/numenta/nupic.core.git","ssh_url":"git@github.com:numenta/nupic.core.git","clone_url":"https://github.com/numenta/nupic.core.git","svn_url":"https://github.com/numenta/nupic.core","homepage":"http://numenta.org","size":233665,"stargazers_count":165,"watchers_count":165,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":122,"forks":164,"open_issues":122,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/1081"},"html":{"href":"https://github.com/numenta/nupic.core/pull/1081"},"issue":{"href":"https://api.github.com/repos/numenta/nupic.core/issues/1081"},"comments":{"href":"https://api.github.com/repos/numenta/nupic.core/issues/1081/comments"},"review_comments":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/1081/comments"},"review_comment":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/1081/commits"},"statuses":{"href":"https://api.github.com/repos/numenta/nupic.core/statuses/e3e6fa68dae5c532cc936ff7bf452fecf8330166"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":987,"deletions":896,"changed_files":7}}
{"actor":{"display_login":"mrcslws"}}