{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/26592","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/26592/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/26592/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/26592/events","html_url":"https://github.com/owncloud/core/pull/26592","id":188372075,"number":26592,"title":"stop php from sending any Cache control headers","user":{"login":"butonic","id":956847,"avatar_url":"https://avatars.githubusercontent.com/u/956847?v=3","gravatar_id":"","url":"https://api.github.com/users/butonic","html_url":"https://github.com/butonic","followers_url":"https://api.github.com/users/butonic/followers","following_url":"https://api.github.com/users/butonic/following{/other_user}","gists_url":"https://api.github.com/users/butonic/gists{/gist_id}","starred_url":"https://api.github.com/users/butonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/butonic/subscriptions","organizations_url":"https://api.github.com/users/butonic/orgs","repos_url":"https://api.github.com/users/butonic/repos","events_url":"https://api.github.com/users/butonic/events{/privacy}","received_events_url":"https://api.github.com/users/butonic/received_events","type":"User","site_admin":false},"labels":[{"id":17709846,"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed","default":false},{"id":80995269,"url":"https://api.github.com/repos/owncloud/core/labels/performance","name":"performance","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/76","html_url":"https://github.com/owncloud/core/milestones/9.2","labels_url":"https://api.github.com/repos/owncloud/core/milestones/76/labels","id":1632230,"number":76,"title":"9.2","description":null,"creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":466,"closed_issues":428,"state":"open","created_at":"2016-03-09T07:18:43Z","updated_at":"2016-11-10T12:07:53Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-11-09T22:43:48Z","updated_at":"2016-11-10T14:19:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/26592","html_url":"https://github.com/owncloud/core/pull/26592","diff_url":"https://github.com/owncloud/core/pull/26592.diff","patch_url":"https://github.com/owncloud/core/pull/26592.patch"},"body":"<!--\r\nThanks for submitting a change to ownCloud!\r\n\r\nThis is the bug tracker for the Server component. Find other components at https://github.com/owncloud/core/blob/master/.github/CONTRIBUTING.md#guidelines\r\n\r\nFor fixing potential security issues please see https://owncloud.org/security/\r\n\r\nTo make it possible for us to get your change reviewed and merged please fill out below information carefully.\r\n\r\nPlease note that any kind of change first has to be submitted to the master branch which holds the next major version of ownCloud.\r\n\r\nWe will carefully discuss if your change can or has to be backported to stable branches.\r\n-->\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\nOn debian the default setting for session.cache_limiter is nocache causing Pragma, CacheControl and Expiry headers to be added to every response. This may lead to conflicting headers where owncloud sets a Cache-Control header that allows caching but Pragma is still nocache. Pragma is only needed to tell IE8 how to cache responses. No longer needed -> kill it.\r\n\r\nThis PR changes the default setting of session.cache_limiter to '' to prevent php from sending any caching related headers to get give oc full control and prevent conflicting headers.\r\n\r\nsee http://php.net/manual/de/function.session-cache-limiter.php#refsect1-function.session-cache-limiter-parameters\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\n* https://github.com/owncloud/core/pull/26589/files#diff-17d17c6a954f29c12717db921f235531L137\r\n* https://github.com/owncloud/core/issues/21036\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\ncleaner caching, no unnecessary headers, profit?\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nFirefox, Edge, Chromium\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/259701050","html_url":"https://github.com/owncloud/core/pull/26592#issuecomment-259701050","issue_url":"https://api.github.com/repos/owncloud/core/issues/26592","id":259701050,"user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T14:19:02Z","updated_at":"2016-11-10T14:19:02Z","body":"Can anyone familiar with .htaccess and php settings review this ? @DeepDiver1975 @PhilippSchaffrath @felixheidecke "}}
{"actor":{"display_login":"PVince81"}}