{"action":"created","issue":{"url":"https://api.github.com/repos/jupyter-incubator/dashboards_server/issues/218","repository_url":"https://api.github.com/repos/jupyter-incubator/dashboards_server","labels_url":"https://api.github.com/repos/jupyter-incubator/dashboards_server/issues/218/labels{/name}","comments_url":"https://api.github.com/repos/jupyter-incubator/dashboards_server/issues/218/comments","events_url":"https://api.github.com/repos/jupyter-incubator/dashboards_server/issues/218/events","html_url":"https://github.com/jupyter-incubator/dashboards_server/issues/218","id":154068141,"number":218,"title":"Allow hostname, port, and protocol in PUBLIC_LINK","user":{"login":"parente","id":153745,"avatar_url":"https://avatars.githubusercontent.com/u/153745?v=3","gravatar_id":"","url":"https://api.github.com/users/parente","html_url":"https://github.com/parente","followers_url":"https://api.github.com/users/parente/followers","following_url":"https://api.github.com/users/parente/following{/other_user}","gists_url":"https://api.github.com/users/parente/gists{/gist_id}","starred_url":"https://api.github.com/users/parente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parente/subscriptions","organizations_url":"https://api.github.com/users/parente/orgs","repos_url":"https://api.github.com/users/parente/repos","events_url":"https://api.github.com/users/parente/events{/privacy}","received_events_url":"https://api.github.com/users/parente/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jupyter-incubator/dashboards_server/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/jupyter-incubator/dashboards_server/milestones/6","html_url":"https://github.com/jupyter-incubator/dashboards_server/milestones/0.6.0","labels_url":"https://api.github.com/repos/jupyter-incubator/dashboards_server/milestones/6/labels","id":1664524,"number":6,"title":"0.6.0","description":"","creator":{"login":"parente","id":153745,"avatar_url":"https://avatars.githubusercontent.com/u/153745?v=3","gravatar_id":"","url":"https://api.github.com/users/parente","html_url":"https://github.com/parente","followers_url":"https://api.github.com/users/parente/followers","following_url":"https://api.github.com/users/parente/following{/other_user}","gists_url":"https://api.github.com/users/parente/gists{/gist_id}","starred_url":"https://api.github.com/users/parente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parente/subscriptions","organizations_url":"https://api.github.com/users/parente/orgs","repos_url":"https://api.github.com/users/parente/repos","events_url":"https://api.github.com/users/parente/events{/privacy}","received_events_url":"https://api.github.com/users/parente/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":5,"state":"open","created_at":"2016-03-24T18:49:38Z","updated_at":"2016-05-10T17:59:36Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-05-10T17:55:46Z","updated_at":"2016-05-10T21:17:25Z","closed_at":null,"body":"https://github.com/jupyter-incubator/dashboards_bundlers/pull/37 makes the response from the dashboard server the default place to get the link to a deployed dashboard instead of a config value in the bundler. Currently, the dashboard server uses a hardcoded URL as the base URL. The original logic in the bundler could compute certain properties such as the hostname, protocol, and port using the Host header. The same should be done here to make configurations more portable."},"comment":{"url":"https://api.github.com/repos/jupyter-incubator/dashboards_server/issues/comments/218294454","html_url":"https://github.com/jupyter-incubator/dashboards_server/issues/218#issuecomment-218294454","issue_url":"https://api.github.com/repos/jupyter-incubator/dashboards_server/issues/218","id":218294454,"user":{"login":"parente","id":153745,"avatar_url":"https://avatars.githubusercontent.com/u/153745?v=3","gravatar_id":"","url":"https://api.github.com/users/parente","html_url":"https://github.com/parente","followers_url":"https://api.github.com/users/parente/followers","following_url":"https://api.github.com/users/parente/following{/other_user}","gists_url":"https://api.github.com/users/parente/gists{/gist_id}","starred_url":"https://api.github.com/users/parente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parente/subscriptions","organizations_url":"https://api.github.com/users/parente/orgs","repos_url":"https://api.github.com/users/parente/repos","events_url":"https://api.github.com/users/parente/events{/privacy}","received_events_url":"https://api.github.com/users/parente/received_events","type":"User","site_admin":false},"created_at":"2016-05-10T21:17:25Z","updated_at":"2016-05-10T21:17:25Z","body":"It's a template in the original code. e.g., \"http://{hostname}:8888\" would interpolate the hostname from the Host header. \"http://hardcoded.com:9999\" would still run through the template replacement function, but nothing would get replaced."}}