{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/pulls/2","id":82923495,"html_url":"https://github.com/toddmotto/angular-1-5-components-app/pull/2","diff_url":"https://github.com/toddmotto/angular-1-5-components-app/pull/2.diff","patch_url":"https://github.com/toddmotto/angular-1-5-components-app/pull/2.patch","issue_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/issues/2","number":2,"state":"open","locked":false,"title":"Small styling improvements","user":{"login":"sebpelletier","id":6053232,"avatar_url":"https://avatars.githubusercontent.com/u/6053232?v=3","gravatar_id":"","url":"https://api.github.com/users/sebpelletier","html_url":"https://github.com/sebpelletier","followers_url":"https://api.github.com/users/sebpelletier/followers","following_url":"https://api.github.com/users/sebpelletier/following{/other_user}","gists_url":"https://api.github.com/users/sebpelletier/gists{/gist_id}","starred_url":"https://api.github.com/users/sebpelletier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebpelletier/subscriptions","organizations_url":"https://api.github.com/users/sebpelletier/orgs","repos_url":"https://api.github.com/users/sebpelletier/repos","events_url":"https://api.github.com/users/sebpelletier/events{/privacy}","received_events_url":"https://api.github.com/users/sebpelletier/received_events","type":"User","site_admin":false},"body":"**Small visual improvements we're implemented, here's a list of changes:**\r\n\r\n- Login error message now has the same visual presentation as others (red coloring)\r\n- Login error now has better spacing from password input\r\n- Implemented maps to group color variables together\r\n- Button (hover, focus, active) states now are visually different from the default state\r\n\r\n\r\n**Here's a couple of other things we could do:**\r\n\r\n- Organize & Structure SCSS files into separate files for each 'component' \r\n  - _It would also promote best practices for project structure_\r\n- Make the app-sidebar smaller on smaller viewports\r\n- Show more details in the 'list' view (add job title, location, etc...) \r\n  - _That way, the detail / edit view would only be for editing_\r\n- Add 'for' and 'ids' so that you can click on the form labels and it focuses on the input\r\n  - _better UX & accessibility_\r\n- Have a function that 'generates' 10 random contacts and adds them to the list. \r\n  - _We could use this opportunity to showcase the number of $watchers per page, and users would see how performant a component based architecture really is_\r\n- Would be cool to have 'pictures' for each contact","created_at":"2016-08-26T17:21:37Z","updated_at":"2016-08-26T17:21:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/pulls/2/commits","review_comments_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/pulls/2/comments","review_comment_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/issues/2/comments","statuses_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/statuses/55395baca9544b0ad9c9e350878a297ffdca3f13","head":{"label":"sebpelletier:master","ref":"master","sha":"55395baca9544b0ad9c9e350878a297ffdca3f13","user":{"login":"sebpelletier","id":6053232,"avatar_url":"https://avatars.githubusercontent.com/u/6053232?v=3","gravatar_id":"","url":"https://api.github.com/users/sebpelletier","html_url":"https://github.com/sebpelletier","followers_url":"https://api.github.com/users/sebpelletier/followers","following_url":"https://api.github.com/users/sebpelletier/following{/other_user}","gists_url":"https://api.github.com/users/sebpelletier/gists{/gist_id}","starred_url":"https://api.github.com/users/sebpelletier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebpelletier/subscriptions","organizations_url":"https://api.github.com/users/sebpelletier/orgs","repos_url":"https://api.github.com/users/sebpelletier/repos","events_url":"https://api.github.com/users/sebpelletier/events{/privacy}","received_events_url":"https://api.github.com/users/sebpelletier/received_events","type":"User","site_admin":false},"repo":{"id":66605305,"name":"angular-1-5-components-app","full_name":"sebpelletier/angular-1-5-components-app","owner":{"login":"sebpelletier","id":6053232,"avatar_url":"https://avatars.githubusercontent.com/u/6053232?v=3","gravatar_id":"","url":"https://api.github.com/users/sebpelletier","html_url":"https://github.com/sebpelletier","followers_url":"https://api.github.com/users/sebpelletier/followers","following_url":"https://api.github.com/users/sebpelletier/following{/other_user}","gists_url":"https://api.github.com/users/sebpelletier/gists{/gist_id}","starred_url":"https://api.github.com/users/sebpelletier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebpelletier/subscriptions","organizations_url":"https://api.github.com/users/sebpelletier/orgs","repos_url":"https://api.github.com/users/sebpelletier/repos","events_url":"https://api.github.com/users/sebpelletier/events{/privacy}","received_events_url":"https://api.github.com/users/sebpelletier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebpelletier/angular-1-5-components-app","description":"A Contacts Manager application built on Angular 1.5 components, ui-router 1.0.0, Firebase.","fork":true,"url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app","forks_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/forks","keys_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/teams","hooks_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/hooks","issue_events_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/issues/events{/number}","events_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/events","assignees_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/assignees{/user}","branches_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/branches{/branch}","tags_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/tags","blobs_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/statuses/{sha}","languages_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/languages","stargazers_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/stargazers","contributors_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/contributors","subscribers_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/subscribers","subscription_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/subscription","commits_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/contents/{+path}","compare_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/merges","archive_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/downloads","issues_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/issues{/number}","pulls_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/pulls{/number}","milestones_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/milestones{/number}","notifications_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/labels{/name}","releases_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/releases{/id}","deployments_url":"https://api.github.com/repos/sebpelletier/angular-1-5-components-app/deployments","created_at":"2016-08-26T01:15:33Z","updated_at":"2016-08-26T01:15:34Z","pushed_at":"2016-08-26T16:57:15Z","git_url":"git://github.com/sebpelletier/angular-1-5-components-app.git","ssh_url":"git@github.com:sebpelletier/angular-1-5-components-app.git","clone_url":"https://github.com/sebpelletier/angular-1-5-components-app.git","svn_url":"https://github.com/sebpelletier/angular-1-5-components-app","homepage":"https://courses.toddmotto.com","size":288,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"toddmotto:master","ref":"master","sha":"8bba5e93aeb7d26d409ac387ad105e1f62c1dfd0","user":{"login":"toddmotto","id":1655968,"avatar_url":"https://avatars.githubusercontent.com/u/1655968?v=3","gravatar_id":"","url":"https://api.github.com/users/toddmotto","html_url":"https://github.com/toddmotto","followers_url":"https://api.github.com/users/toddmotto/followers","following_url":"https://api.github.com/users/toddmotto/following{/other_user}","gists_url":"https://api.github.com/users/toddmotto/gists{/gist_id}","starred_url":"https://api.github.com/users/toddmotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddmotto/subscriptions","organizations_url":"https://api.github.com/users/toddmotto/orgs","repos_url":"https://api.github.com/users/toddmotto/repos","events_url":"https://api.github.com/users/toddmotto/events{/privacy}","received_events_url":"https://api.github.com/users/toddmotto/received_events","type":"User","site_admin":false},"repo":{"id":66580658,"name":"angular-1-5-components-app","full_name":"toddmotto/angular-1-5-components-app","owner":{"login":"toddmotto","id":1655968,"avatar_url":"https://avatars.githubusercontent.com/u/1655968?v=3","gravatar_id":"","url":"https://api.github.com/users/toddmotto","html_url":"https://github.com/toddmotto","followers_url":"https://api.github.com/users/toddmotto/followers","following_url":"https://api.github.com/users/toddmotto/following{/other_user}","gists_url":"https://api.github.com/users/toddmotto/gists{/gist_id}","starred_url":"https://api.github.com/users/toddmotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddmotto/subscriptions","organizations_url":"https://api.github.com/users/toddmotto/orgs","repos_url":"https://api.github.com/users/toddmotto/repos","events_url":"https://api.github.com/users/toddmotto/events{/privacy}","received_events_url":"https://api.github.com/users/toddmotto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toddmotto/angular-1-5-components-app","description":"A Contacts Manager application built on Angular 1.5 components, ui-router 1.0.0, Firebase.","fork":false,"url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app","forks_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/forks","keys_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/teams","hooks_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/hooks","issue_events_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/issues/events{/number}","events_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/events","assignees_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/assignees{/user}","branches_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/branches{/branch}","tags_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/tags","blobs_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/statuses/{sha}","languages_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/languages","stargazers_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/stargazers","contributors_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/contributors","subscribers_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/subscribers","subscription_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/subscription","commits_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/contents/{+path}","compare_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/merges","archive_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/downloads","issues_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/issues{/number}","pulls_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/pulls{/number}","milestones_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/milestones{/number}","notifications_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/labels{/name}","releases_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/releases{/id}","deployments_url":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/deployments","created_at":"2016-08-25T17:53:59Z","updated_at":"2016-08-26T17:10:08Z","pushed_at":"2016-08-26T09:49:15Z","git_url":"git://github.com/toddmotto/angular-1-5-components-app.git","ssh_url":"git@github.com:toddmotto/angular-1-5-components-app.git","clone_url":"https://github.com/toddmotto/angular-1-5-components-app.git","svn_url":"https://github.com/toddmotto/angular-1-5-components-app","homepage":"https://courses.toddmotto.com","size":287,"stargazers_count":112,"watchers_count":112,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/pulls/2"},"html":{"href":"https://github.com/toddmotto/angular-1-5-components-app/pull/2"},"issue":{"href":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/issues/2"},"comments":{"href":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/toddmotto/angular-1-5-components-app/statuses/55395baca9544b0ad9c9e350878a297ffdca3f13"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":95,"deletions":21,"changed_files":2}}
{"actor":{"display_login":"sebpelletier"}}