{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments/55796333","id":55796333,"diff_hunk":"@@ -15,7 +15,9 @@ class MutateIncomingMessageBehavior : Behavior<IIncomingLogicalMessageContext>\n             var mutatorContext = new MutateIncomingMessageContext(current, context.Headers);\n             foreach (var mutator in context.Builder.BuildAll<IMutateIncomingMessages>())\n             {\n-                await mutator.MutateIncoming(mutatorContext).ConfigureAwait(false);\n+                await mutator.MutateIncoming(mutatorContext)","path":"src/NServiceBus.Core/Pipeline/MutateInstanceMessage/MutateIncomingMessageBehavior.cs","position":5,"original_position":5,"commit_id":"4c8c3d04f26f92f14ed51376522518d0209bc528","original_commit_id":"4395d0300586e97f0c9820879001c587649d048f","user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"body":"My question was in another direction. Since we always eagerly create the message like in this example with \r\n\r\n```\r\n($\"{mutator.GetType().FullName}.MutateIncoming\"\r\n```\r\n\r\nWe do reflection and allocation of strings every time just to create a bit more helpful message. My vote is to remove the additional message. The memory and perf hit is not worth for such a small benefit.\r\n\r\nThoughts @Particular/nservicebus-maintainers ","created_at":"2016-03-11T07:11:43Z","updated_at":"2016-03-11T07:11:43Z","html_url":"https://github.com/Particular/NServiceBus/pull/3570#discussion_r55796333","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3570","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments/55796333"},"html":{"href":"https://github.com/Particular/NServiceBus/pull/3570#discussion_r55796333"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3570"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3570","id":62105985,"html_url":"https://github.com/Particular/NServiceBus/pull/3570","diff_url":"https://github.com/Particular/NServiceBus/pull/3570.diff","patch_url":"https://github.com/Particular/NServiceBus/pull/3570.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3570","number":3570,"state":"open","locked":false,"title":"Null check for common user Task methods","user":{"login":"boblangley","id":2546913,"avatar_url":"https://avatars.githubusercontent.com/u/2546913?v=3","gravatar_id":"","url":"https://api.github.com/users/boblangley","html_url":"https://github.com/boblangley","followers_url":"https://api.github.com/users/boblangley/followers","following_url":"https://api.github.com/users/boblangley/following{/other_user}","gists_url":"https://api.github.com/users/boblangley/gists{/gist_id}","starred_url":"https://api.github.com/users/boblangley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boblangley/subscriptions","organizations_url":"https://api.github.com/users/boblangley/orgs","repos_url":"https://api.github.com/users/boblangley/repos","events_url":"https://api.github.com/users/boblangley/events{/privacy}","received_events_url":"https://api.github.com/users/boblangley/received_events","type":"User","site_admin":false},"body":"Closes #3533\r\n\r\nNull checks for:\r\n\r\n- IHandleMessages.Handle\r\n- Sagas:\r\n   - IHandleTimeouts.Timeout [Not explicitly tested]\r\n   - IFindSagas.FindBy\r\n   - IHandleSagaNotFound.Handle\r\n- IWantToRunWhenBusStartsAndStops.Start\r\n- IWantToRunWhenBusStartsAndStops.Stop [Not tested - exception is logged but swallowed]\r\n\r\n@danielmarbach Can you review what I have done so far? Anything I missed for the first group?","created_at":"2016-03-08T17:31:25Z","updated_at":"2016-03-11T07:11:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0d61c0662c5ffbb5bc4a28c5389134c4f268e37","assignee":{"login":"boblangley","id":2546913,"avatar_url":"https://avatars.githubusercontent.com/u/2546913?v=3","gravatar_id":"","url":"https://api.github.com/users/boblangley","html_url":"https://github.com/boblangley","followers_url":"https://api.github.com/users/boblangley/followers","following_url":"https://api.github.com/users/boblangley/following{/other_user}","gists_url":"https://api.github.com/users/boblangley/gists{/gist_id}","starred_url":"https://api.github.com/users/boblangley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boblangley/subscriptions","organizations_url":"https://api.github.com/users/boblangley/orgs","repos_url":"https://api.github.com/users/boblangley/repos","events_url":"https://api.github.com/users/boblangley/events{/privacy}","received_events_url":"https://api.github.com/users/boblangley/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3570/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3570/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3570/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/4c8c3d04f26f92f14ed51376522518d0209bc528","head":{"label":"Particular:no-null-user-tasks","ref":"no-null-user-tasks","sha":"4c8c3d04f26f92f14ed51376522518d0209bc528","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":1056713,"name":"NServiceBus","full_name":"Particular/NServiceBus","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus","description":"The most popular service bus for .NET","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus","forks_url":"https://api.github.com/repos/Particular/NServiceBus/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus/deployments","created_at":"2010-11-06T12:54:52Z","updated_at":"2016-03-11T04:37:31Z","pushed_at":"2016-03-11T06:08:22Z","git_url":"git://github.com/Particular/NServiceBus.git","ssh_url":"git@github.com:Particular/NServiceBus.git","clone_url":"https://github.com/Particular/NServiceBus.git","svn_url":"https://github.com/Particular/NServiceBus","homepage":"http://particular.net/nservicebus","size":159806,"stargazers_count":893,"watchers_count":893,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":479,"mirror_url":null,"open_issues_count":265,"forks":479,"open_issues":265,"watchers":893,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"3ddf2b2b062b383e3e6ea02d18fcf82afc1f3df0","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":1056713,"name":"NServiceBus","full_name":"Particular/NServiceBus","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus","description":"The most popular service bus for .NET","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus","forks_url":"https://api.github.com/repos/Particular/NServiceBus/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus/deployments","created_at":"2010-11-06T12:54:52Z","updated_at":"2016-03-11T04:37:31Z","pushed_at":"2016-03-11T06:08:22Z","git_url":"git://github.com/Particular/NServiceBus.git","ssh_url":"git@github.com:Particular/NServiceBus.git","clone_url":"https://github.com/Particular/NServiceBus.git","svn_url":"https://github.com/Particular/NServiceBus","homepage":"http://particular.net/nservicebus","size":159806,"stargazers_count":893,"watchers_count":893,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":479,"mirror_url":null,"open_issues_count":265,"forks":479,"open_issues":265,"watchers":893,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3570"},"html":{"href":"https://github.com/Particular/NServiceBus/pull/3570"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus/issues/3570"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus/issues/3570/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3570/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3570/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus/statuses/4c8c3d04f26f92f14ed51376522518d0209bc528"}}}}