{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/2493","repository_url":"https://api.github.com/repos/DataDog/dd-agent","labels_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2493/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2493/comments","events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2493/events","html_url":"https://github.com/DataDog/dd-agent/pull/2493","id":154408956,"number":2493,"title":"[mysql] Fix slave_running for mysql 5.7 with slave binlog","user":{"login":"nrw505","id":8898943,"avatar_url":"https://avatars.githubusercontent.com/u/8898943?v=3","gravatar_id":"","url":"https://api.github.com/users/nrw505","html_url":"https://github.com/nrw505","followers_url":"https://api.github.com/users/nrw505/followers","following_url":"https://api.github.com/users/nrw505/following{/other_user}","gists_url":"https://api.github.com/users/nrw505/gists{/gist_id}","starred_url":"https://api.github.com/users/nrw505/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrw505/subscriptions","organizations_url":"https://api.github.com/users/nrw505/orgs","repos_url":"https://api.github.com/users/nrw505/repos","events_url":"https://api.github.com/users/nrw505/events{/privacy}","received_events_url":"https://api.github.com/users/nrw505/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DataDog/dd-agent/labels/improvement","name":"improvement","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/DataDog/dd-agent/milestones/70","html_url":"https://github.com/DataDog/dd-agent/milestones/5.8.3","labels_url":"https://api.github.com/repos/DataDog/dd-agent/milestones/70/labels","id":1785954,"number":70,"title":"5.8.3","description":"","creator":{"login":"yannmh","id":5708089,"avatar_url":"https://avatars.githubusercontent.com/u/5708089?v=3","gravatar_id":"","url":"https://api.github.com/users/yannmh","html_url":"https://github.com/yannmh","followers_url":"https://api.github.com/users/yannmh/followers","following_url":"https://api.github.com/users/yannmh/following{/other_user}","gists_url":"https://api.github.com/users/yannmh/gists{/gist_id}","starred_url":"https://api.github.com/users/yannmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannmh/subscriptions","organizations_url":"https://api.github.com/users/yannmh/orgs","repos_url":"https://api.github.com/users/yannmh/repos","events_url":"https://api.github.com/users/yannmh/events{/privacy}","received_events_url":"https://api.github.com/users/yannmh/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":3,"state":"open","created_at":"2016-05-24T20:17:45Z","updated_at":"2016-06-03T21:10:26Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-05-12T06:45:35Z","updated_at":"2016-06-04T18:07:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2493","html_url":"https://github.com/DataDog/dd-agent/pull/2493","diff_url":"https://github.com/DataDog/dd-agent/pull/2493.diff","patch_url":"https://github.com/DataDog/dd-agent/pull/2493.patch"},"body":"When a MySQL 5.7 is a slave _and_ has a running binlog with no\r\ndownstream slaves attached, this check assumed that the instance was a\r\nmaster with no running slaves.\r\n\r\nFix it so that it checks for Slave_IO_Running and Slave_SQL_Running\r\nbefore checking for Binlog_enabled and Slaves_connected."},"comment":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments/223769723","html_url":"https://github.com/DataDog/dd-agent/pull/2493#issuecomment-223769723","issue_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2493","id":223769723,"user":{"login":"jmackenziejr","id":2965129,"avatar_url":"https://avatars.githubusercontent.com/u/2965129?v=3","gravatar_id":"","url":"https://api.github.com/users/jmackenziejr","html_url":"https://github.com/jmackenziejr","followers_url":"https://api.github.com/users/jmackenziejr/followers","following_url":"https://api.github.com/users/jmackenziejr/following{/other_user}","gists_url":"https://api.github.com/users/jmackenziejr/gists{/gist_id}","starred_url":"https://api.github.com/users/jmackenziejr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmackenziejr/subscriptions","organizations_url":"https://api.github.com/users/jmackenziejr/orgs","repos_url":"https://api.github.com/users/jmackenziejr/repos","events_url":"https://api.github.com/users/jmackenziejr/events{/privacy}","received_events_url":"https://api.github.com/users/jmackenziejr/received_events","type":"User","site_admin":false},"created_at":"2016-06-04T18:07:39Z","updated_at":"2016-06-04T18:07:39Z","body":"Hello there, this fix is great, and has allowed us to properly check if a slave is running on our databases that are set up with a master-master replication configuration. However, we do have a database that is configured with multiple slaves, and it seems this metric only verifies that the first instance of Slave_SQL_Running and Slave_IO_Running in the output of the \"show slave status\\G\" command. It would be extremely helpful if this metric could track all instances of this output, so that the slaves running metric could report a value that is indicative of the amount of slaves running on that MySQL instance. This way if you have two slave processes configured that should be running, the metric will allow you to alert if any one of them shuts down. Right now, as it stands, I believe you will only be notified of a failure in the first slave that is displayed in the output of \"show slave status\\G\". Hope that is clear, please let me know if there's anything I can do to clarify, or assist in providing a fix."}}
{"actor":{"display_login":"jmackenziejr"}}