{"action":"created","comment":{"url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/comments/88805965","pull_request_review_id":9368397,"id":88805965,"diff_hunk":"@@ -1,5 +1,17 @@\n require 'rails_helper'\n \n RSpec.describe Piece, type: :model do\n-  \n+\n+  let(:white_player) { FactoryGirl.create(:player, email: 'blah@blah.com', password: 'SPACECAT') }\n+  let(:black_player) { FactoryGirl.create(:player, email: 'meow@meow.com', password: 'MONORAILCAT') }\n+  let(:game) { FactoryGirl.create(:game, white_player_id: white_player.id, black_player_id: black_player.id) }\n+  let(:piece) { FactoryGirl.create(:piece, x_position: 4, y_position: 4, game_id: game.id, player_id: white_player.id) }\n+\n+  describe 'a Pawn' do\n+    it 'should be a pawn' do\n+      pawn = FactoryGirl.create(:pawn, x_position: 2, y_position: 1, game_id: game.id, player_id: black_player.id)","path":"spec/models/piece_spec.rb","position":13,"original_position":13,"commit_id":"bbb0517a06d41ad31e840138e63441f4cfdc570e","original_commit_id":"bbb0517a06d41ad31e840138e63441f4cfdc570e","user":{"login":"lasley","id":7397578,"avatar_url":"https://avatars.githubusercontent.com/u/7397578?v=3","gravatar_id":"","url":"https://api.github.com/users/lasley","html_url":"https://github.com/lasley","followers_url":"https://api.github.com/users/lasley/followers","following_url":"https://api.github.com/users/lasley/following{/other_user}","gists_url":"https://api.github.com/users/lasley/gists{/gist_id}","starred_url":"https://api.github.com/users/lasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasley/subscriptions","organizations_url":"https://api.github.com/users/lasley/orgs","repos_url":"https://api.github.com/users/lasley/repos","events_url":"https://api.github.com/users/lasley/events{/privacy}","received_events_url":"https://api.github.com/users/lasley/received_events","type":"User","site_admin":false},"body":"Why all these attributes in the factorygirl create, but no default attributes in the factory? These should all be moved to the factory IMO","created_at":"2016-11-20T17:02:17Z","updated_at":"2016-11-20T17:02:23Z","html_url":"https://github.com/the-cheaters/up-all-knight/pull/14#discussion_r88805965","pull_request_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/comments/88805965"},"html":{"href":"https://github.com/the-cheaters/up-all-knight/pull/14#discussion_r88805965"},"pull_request":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/14","id":94488090,"html_url":"https://github.com/the-cheaters/up-all-knight/pull/14","diff_url":"https://github.com/the-cheaters/up-all-knight/pull/14.diff","patch_url":"https://github.com/the-cheaters/up-all-knight/pull/14.patch","issue_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/14","number":14,"state":"open","locked":false,"title":"Single table inheritance","user":{"login":"GonSanchezS","id":13472846,"avatar_url":"https://avatars.githubusercontent.com/u/13472846?v=3","gravatar_id":"","url":"https://api.github.com/users/GonSanchezS","html_url":"https://github.com/GonSanchezS","followers_url":"https://api.github.com/users/GonSanchezS/followers","following_url":"https://api.github.com/users/GonSanchezS/following{/other_user}","gists_url":"https://api.github.com/users/GonSanchezS/gists{/gist_id}","starred_url":"https://api.github.com/users/GonSanchezS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GonSanchezS/subscriptions","organizations_url":"https://api.github.com/users/GonSanchezS/orgs","repos_url":"https://api.github.com/users/GonSanchezS/repos","events_url":"https://api.github.com/users/GonSanchezS/events{/privacy}","received_events_url":"https://api.github.com/users/GonSanchezS/received_events","type":"User","site_admin":false},"body":"To start with single table inheritance, I created a pawn model that inherits all the `Piece` attributes. I also wrote a test to check if a pawn is, in fact, a pawn. ","created_at":"2016-11-19T17:17:21Z","updated_at":"2016-11-20T17:02:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50cce063ab6438276a5d463437850b98ecc613b9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/14/commits","review_comments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/14/comments","review_comment_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/14/comments","statuses_url":"https://api.github.com/repos/the-cheaters/up-all-knight/statuses/bbb0517a06d41ad31e840138e63441f4cfdc570e","head":{"label":"the-cheaters:sti","ref":"sti","sha":"bbb0517a06d41ad31e840138e63441f4cfdc570e","user":{"login":"the-cheaters","id":23323498,"avatar_url":"https://avatars.githubusercontent.com/u/23323498?v=3","gravatar_id":"","url":"https://api.github.com/users/the-cheaters","html_url":"https://github.com/the-cheaters","followers_url":"https://api.github.com/users/the-cheaters/followers","following_url":"https://api.github.com/users/the-cheaters/following{/other_user}","gists_url":"https://api.github.com/users/the-cheaters/gists{/gist_id}","starred_url":"https://api.github.com/users/the-cheaters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-cheaters/subscriptions","organizations_url":"https://api.github.com/users/the-cheaters/orgs","repos_url":"https://api.github.com/users/the-cheaters/repos","events_url":"https://api.github.com/users/the-cheaters/events{/privacy}","received_events_url":"https://api.github.com/users/the-cheaters/received_events","type":"Organization","site_admin":false},"repo":{"id":73124016,"name":"up-all-knight","full_name":"the-cheaters/up-all-knight","owner":{"login":"the-cheaters","id":23323498,"avatar_url":"https://avatars.githubusercontent.com/u/23323498?v=3","gravatar_id":"","url":"https://api.github.com/users/the-cheaters","html_url":"https://github.com/the-cheaters","followers_url":"https://api.github.com/users/the-cheaters/followers","following_url":"https://api.github.com/users/the-cheaters/following{/other_user}","gists_url":"https://api.github.com/users/the-cheaters/gists{/gist_id}","starred_url":"https://api.github.com/users/the-cheaters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-cheaters/subscriptions","organizations_url":"https://api.github.com/users/the-cheaters/orgs","repos_url":"https://api.github.com/users/the-cheaters/repos","events_url":"https://api.github.com/users/the-cheaters/events{/privacy}","received_events_url":"https://api.github.com/users/the-cheaters/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/the-cheaters/up-all-knight","description":null,"fork":false,"url":"https://api.github.com/repos/the-cheaters/up-all-knight","forks_url":"https://api.github.com/repos/the-cheaters/up-all-knight/forks","keys_url":"https://api.github.com/repos/the-cheaters/up-all-knight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/the-cheaters/up-all-knight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/the-cheaters/up-all-knight/teams","hooks_url":"https://api.github.com/repos/the-cheaters/up-all-knight/hooks","issue_events_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/events{/number}","events_url":"https://api.github.com/repos/the-cheaters/up-all-knight/events","assignees_url":"https://api.github.com/repos/the-cheaters/up-all-knight/assignees{/user}","branches_url":"https://api.github.com/repos/the-cheaters/up-all-knight/branches{/branch}","tags_url":"https://api.github.com/repos/the-cheaters/up-all-knight/tags","blobs_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/refs{/sha}","trees_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/the-cheaters/up-all-knight/statuses/{sha}","languages_url":"https://api.github.com/repos/the-cheaters/up-all-knight/languages","stargazers_url":"https://api.github.com/repos/the-cheaters/up-all-knight/stargazers","contributors_url":"https://api.github.com/repos/the-cheaters/up-all-knight/contributors","subscribers_url":"https://api.github.com/repos/the-cheaters/up-all-knight/subscribers","subscription_url":"https://api.github.com/repos/the-cheaters/up-all-knight/subscription","commits_url":"https://api.github.com/repos/the-cheaters/up-all-knight/commits{/sha}","git_commits_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/commits{/sha}","comments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/comments{/number}","issue_comment_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/comments{/number}","contents_url":"https://api.github.com/repos/the-cheaters/up-all-knight/contents/{+path}","compare_url":"https://api.github.com/repos/the-cheaters/up-all-knight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/the-cheaters/up-all-knight/merges","archive_url":"https://api.github.com/repos/the-cheaters/up-all-knight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/the-cheaters/up-all-knight/downloads","issues_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues{/number}","pulls_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls{/number}","milestones_url":"https://api.github.com/repos/the-cheaters/up-all-knight/milestones{/number}","notifications_url":"https://api.github.com/repos/the-cheaters/up-all-knight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/the-cheaters/up-all-knight/labels{/name}","releases_url":"https://api.github.com/repos/the-cheaters/up-all-knight/releases{/id}","deployments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/deployments","created_at":"2016-11-07T21:49:25Z","updated_at":"2016-11-15T03:50:11Z","pushed_at":"2016-11-20T01:55:59Z","git_url":"git://github.com/the-cheaters/up-all-knight.git","ssh_url":"git@github.com:the-cheaters/up-all-knight.git","clone_url":"https://github.com/the-cheaters/up-all-knight.git","svn_url":"https://github.com/the-cheaters/up-all-knight","homepage":null,"size":117,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"the-cheaters:master","ref":"master","sha":"389330037936c6e0cf8b8e8a68dba4fc2c5ab3ac","user":{"login":"the-cheaters","id":23323498,"avatar_url":"https://avatars.githubusercontent.com/u/23323498?v=3","gravatar_id":"","url":"https://api.github.com/users/the-cheaters","html_url":"https://github.com/the-cheaters","followers_url":"https://api.github.com/users/the-cheaters/followers","following_url":"https://api.github.com/users/the-cheaters/following{/other_user}","gists_url":"https://api.github.com/users/the-cheaters/gists{/gist_id}","starred_url":"https://api.github.com/users/the-cheaters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-cheaters/subscriptions","organizations_url":"https://api.github.com/users/the-cheaters/orgs","repos_url":"https://api.github.com/users/the-cheaters/repos","events_url":"https://api.github.com/users/the-cheaters/events{/privacy}","received_events_url":"https://api.github.com/users/the-cheaters/received_events","type":"Organization","site_admin":false},"repo":{"id":73124016,"name":"up-all-knight","full_name":"the-cheaters/up-all-knight","owner":{"login":"the-cheaters","id":23323498,"avatar_url":"https://avatars.githubusercontent.com/u/23323498?v=3","gravatar_id":"","url":"https://api.github.com/users/the-cheaters","html_url":"https://github.com/the-cheaters","followers_url":"https://api.github.com/users/the-cheaters/followers","following_url":"https://api.github.com/users/the-cheaters/following{/other_user}","gists_url":"https://api.github.com/users/the-cheaters/gists{/gist_id}","starred_url":"https://api.github.com/users/the-cheaters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-cheaters/subscriptions","organizations_url":"https://api.github.com/users/the-cheaters/orgs","repos_url":"https://api.github.com/users/the-cheaters/repos","events_url":"https://api.github.com/users/the-cheaters/events{/privacy}","received_events_url":"https://api.github.com/users/the-cheaters/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/the-cheaters/up-all-knight","description":null,"fork":false,"url":"https://api.github.com/repos/the-cheaters/up-all-knight","forks_url":"https://api.github.com/repos/the-cheaters/up-all-knight/forks","keys_url":"https://api.github.com/repos/the-cheaters/up-all-knight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/the-cheaters/up-all-knight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/the-cheaters/up-all-knight/teams","hooks_url":"https://api.github.com/repos/the-cheaters/up-all-knight/hooks","issue_events_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/events{/number}","events_url":"https://api.github.com/repos/the-cheaters/up-all-knight/events","assignees_url":"https://api.github.com/repos/the-cheaters/up-all-knight/assignees{/user}","branches_url":"https://api.github.com/repos/the-cheaters/up-all-knight/branches{/branch}","tags_url":"https://api.github.com/repos/the-cheaters/up-all-knight/tags","blobs_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/refs{/sha}","trees_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/the-cheaters/up-all-knight/statuses/{sha}","languages_url":"https://api.github.com/repos/the-cheaters/up-all-knight/languages","stargazers_url":"https://api.github.com/repos/the-cheaters/up-all-knight/stargazers","contributors_url":"https://api.github.com/repos/the-cheaters/up-all-knight/contributors","subscribers_url":"https://api.github.com/repos/the-cheaters/up-all-knight/subscribers","subscription_url":"https://api.github.com/repos/the-cheaters/up-all-knight/subscription","commits_url":"https://api.github.com/repos/the-cheaters/up-all-knight/commits{/sha}","git_commits_url":"https://api.github.com/repos/the-cheaters/up-all-knight/git/commits{/sha}","comments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/comments{/number}","issue_comment_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/comments{/number}","contents_url":"https://api.github.com/repos/the-cheaters/up-all-knight/contents/{+path}","compare_url":"https://api.github.com/repos/the-cheaters/up-all-knight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/the-cheaters/up-all-knight/merges","archive_url":"https://api.github.com/repos/the-cheaters/up-all-knight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/the-cheaters/up-all-knight/downloads","issues_url":"https://api.github.com/repos/the-cheaters/up-all-knight/issues{/number}","pulls_url":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls{/number}","milestones_url":"https://api.github.com/repos/the-cheaters/up-all-knight/milestones{/number}","notifications_url":"https://api.github.com/repos/the-cheaters/up-all-knight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/the-cheaters/up-all-knight/labels{/name}","releases_url":"https://api.github.com/repos/the-cheaters/up-all-knight/releases{/id}","deployments_url":"https://api.github.com/repos/the-cheaters/up-all-knight/deployments","created_at":"2016-11-07T21:49:25Z","updated_at":"2016-11-15T03:50:11Z","pushed_at":"2016-11-20T01:55:59Z","git_url":"git://github.com/the-cheaters/up-all-knight.git","ssh_url":"git@github.com:the-cheaters/up-all-knight.git","clone_url":"https://github.com/the-cheaters/up-all-knight.git","svn_url":"https://github.com/the-cheaters/up-all-knight","homepage":null,"size":117,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/14"},"html":{"href":"https://github.com/the-cheaters/up-all-knight/pull/14"},"issue":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/14"},"comments":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/the-cheaters/up-all-knight/statuses/bbb0517a06d41ad31e840138e63441f4cfdc570e"}}}}
{"actor":{"display_login":"lasley"}}