{"action":"closed","number":546,"pull_request":{"url":"https://api.github.com/repos/python-diamond/Diamond/pulls/546","id":91719307,"html_url":"https://github.com/python-diamond/Diamond/pull/546","diff_url":"https://github.com/python-diamond/Diamond/pull/546.diff","patch_url":"https://github.com/python-diamond/Diamond/pull/546.patch","issue_url":"https://api.github.com/repos/python-diamond/Diamond/issues/546","number":546,"state":"closed","locked":false,"title":"Remove invalid params as of ES 5.0","user":{"login":"MichaelDoyle","id":2858322,"avatar_url":"https://avatars.githubusercontent.com/u/2858322?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelDoyle","html_url":"https://github.com/MichaelDoyle","followers_url":"https://api.github.com/users/MichaelDoyle/followers","following_url":"https://api.github.com/users/MichaelDoyle/following{/other_user}","gists_url":"https://api.github.com/users/MichaelDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelDoyle/subscriptions","organizations_url":"https://api.github.com/users/MichaelDoyle/orgs","repos_url":"https://api.github.com/users/MichaelDoyle/repos","events_url":"https://api.github.com/users/MichaelDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelDoyle/received_events","type":"User","site_admin":false},"body":"As of Elasticsearch 1.0 the format of of the APIs have changed to a more RESTful format. Furthermore, as of Elasticsearch 5.0, erroneous URL params are rejected. This is causing the collector to fail for ES 5.0+. Previously ES would ignore bad params, and thus these changes went unnoticed.\r\n\r\nIndices stats API now returns all by default, no need to specify additional params, as of 1.3:\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/1.3/indices-stats.html\r\n\r\nSimilarly, the node stats API will also return all by default as 1.3:\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/1.3/cluster-nodes-stats.html\r\n\r\nES 5.0 behavior change:\r\nhttps://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking_50_rest_api_changes.html#_strict_rest_query_string_parameter_parsing\r\n\r\nChanges have been validated against 2.0+. Haven't been able to test earlier than that, but I assume this is good at least as far back as 1.3.","created_at":"2016-11-01T01:15:44Z","updated_at":"2016-11-01T14:13:23Z","closed_at":"2016-11-01T14:13:22Z","merged_at":"2016-11-01T14:13:22Z","merge_commit_sha":"fdbb07bf75be564f2ab93a38b6038090a6f6ab59","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/python-diamond/Diamond/pulls/546/commits","review_comments_url":"https://api.github.com/repos/python-diamond/Diamond/pulls/546/comments","review_comment_url":"https://api.github.com/repos/python-diamond/Diamond/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-diamond/Diamond/issues/546/comments","statuses_url":"https://api.github.com/repos/python-diamond/Diamond/statuses/7b16002dec21eaed9e0171629fd761e49ed5da52","head":{"label":"MichaelDoyle:elasticsearch_strict_params","ref":"elasticsearch_strict_params","sha":"7b16002dec21eaed9e0171629fd761e49ed5da52","user":{"login":"MichaelDoyle","id":2858322,"avatar_url":"https://avatars.githubusercontent.com/u/2858322?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelDoyle","html_url":"https://github.com/MichaelDoyle","followers_url":"https://api.github.com/users/MichaelDoyle/followers","following_url":"https://api.github.com/users/MichaelDoyle/following{/other_user}","gists_url":"https://api.github.com/users/MichaelDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelDoyle/subscriptions","organizations_url":"https://api.github.com/users/MichaelDoyle/orgs","repos_url":"https://api.github.com/users/MichaelDoyle/repos","events_url":"https://api.github.com/users/MichaelDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelDoyle/received_events","type":"User","site_admin":false},"repo":{"id":35119805,"name":"Diamond","full_name":"MichaelDoyle/Diamond","owner":{"login":"MichaelDoyle","id":2858322,"avatar_url":"https://avatars.githubusercontent.com/u/2858322?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelDoyle","html_url":"https://github.com/MichaelDoyle","followers_url":"https://api.github.com/users/MichaelDoyle/followers","following_url":"https://api.github.com/users/MichaelDoyle/following{/other_user}","gists_url":"https://api.github.com/users/MichaelDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelDoyle/subscriptions","organizations_url":"https://api.github.com/users/MichaelDoyle/orgs","repos_url":"https://api.github.com/users/MichaelDoyle/repos","events_url":"https://api.github.com/users/MichaelDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelDoyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MichaelDoyle/Diamond","description":"Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.","fork":true,"url":"https://api.github.com/repos/MichaelDoyle/Diamond","forks_url":"https://api.github.com/repos/MichaelDoyle/Diamond/forks","keys_url":"https://api.github.com/repos/MichaelDoyle/Diamond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MichaelDoyle/Diamond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MichaelDoyle/Diamond/teams","hooks_url":"https://api.github.com/repos/MichaelDoyle/Diamond/hooks","issue_events_url":"https://api.github.com/repos/MichaelDoyle/Diamond/issues/events{/number}","events_url":"https://api.github.com/repos/MichaelDoyle/Diamond/events","assignees_url":"https://api.github.com/repos/MichaelDoyle/Diamond/assignees{/user}","branches_url":"https://api.github.com/repos/MichaelDoyle/Diamond/branches{/branch}","tags_url":"https://api.github.com/repos/MichaelDoyle/Diamond/tags","blobs_url":"https://api.github.com/repos/MichaelDoyle/Diamond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MichaelDoyle/Diamond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MichaelDoyle/Diamond/git/refs{/sha}","trees_url":"https://api.github.com/repos/MichaelDoyle/Diamond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MichaelDoyle/Diamond/statuses/{sha}","languages_url":"https://api.github.com/repos/MichaelDoyle/Diamond/languages","stargazers_url":"https://api.github.com/repos/MichaelDoyle/Diamond/stargazers","contributors_url":"https://api.github.com/repos/MichaelDoyle/Diamond/contributors","subscribers_url":"https://api.github.com/repos/MichaelDoyle/Diamond/subscribers","subscription_url":"https://api.github.com/repos/MichaelDoyle/Diamond/subscription","commits_url":"https://api.github.com/repos/MichaelDoyle/Diamond/commits{/sha}","git_commits_url":"https://api.github.com/repos/MichaelDoyle/Diamond/git/commits{/sha}","comments_url":"https://api.github.com/repos/MichaelDoyle/Diamond/comments{/number}","issue_comment_url":"https://api.github.com/repos/MichaelDoyle/Diamond/issues/comments{/number}","contents_url":"https://api.github.com/repos/MichaelDoyle/Diamond/contents/{+path}","compare_url":"https://api.github.com/repos/MichaelDoyle/Diamond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MichaelDoyle/Diamond/merges","archive_url":"https://api.github.com/repos/MichaelDoyle/Diamond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MichaelDoyle/Diamond/downloads","issues_url":"https://api.github.com/repos/MichaelDoyle/Diamond/issues{/number}","pulls_url":"https://api.github.com/repos/MichaelDoyle/Diamond/pulls{/number}","milestones_url":"https://api.github.com/repos/MichaelDoyle/Diamond/milestones{/number}","notifications_url":"https://api.github.com/repos/MichaelDoyle/Diamond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MichaelDoyle/Diamond/labels{/name}","releases_url":"https://api.github.com/repos/MichaelDoyle/Diamond/releases{/id}","deployments_url":"https://api.github.com/repos/MichaelDoyle/Diamond/deployments","created_at":"2015-05-05T19:33:51Z","updated_at":"2015-05-05T20:54:28Z","pushed_at":"2016-11-01T02:38:55Z","git_url":"git://github.com/MichaelDoyle/Diamond.git","ssh_url":"git@github.com:MichaelDoyle/Diamond.git","clone_url":"https://github.com/MichaelDoyle/Diamond.git","svn_url":"https://github.com/MichaelDoyle/Diamond","homepage":null,"size":3270,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-diamond:master","ref":"master","sha":"175a4db4ed2ffb5d56e3c5e1ab7709817f44ea67","user":{"login":"python-diamond","id":5668086,"avatar_url":"https://avatars.githubusercontent.com/u/5668086?v=3","gravatar_id":"","url":"https://api.github.com/users/python-diamond","html_url":"https://github.com/python-diamond","followers_url":"https://api.github.com/users/python-diamond/followers","following_url":"https://api.github.com/users/python-diamond/following{/other_user}","gists_url":"https://api.github.com/users/python-diamond/gists{/gist_id}","starred_url":"https://api.github.com/users/python-diamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-diamond/subscriptions","organizations_url":"https://api.github.com/users/python-diamond/orgs","repos_url":"https://api.github.com/users/python-diamond/repos","events_url":"https://api.github.com/users/python-diamond/events{/privacy}","received_events_url":"https://api.github.com/users/python-diamond/received_events","type":"Organization","site_admin":false},"repo":{"id":13512018,"name":"Diamond","full_name":"python-diamond/Diamond","owner":{"login":"python-diamond","id":5668086,"avatar_url":"https://avatars.githubusercontent.com/u/5668086?v=3","gravatar_id":"","url":"https://api.github.com/users/python-diamond","html_url":"https://github.com/python-diamond","followers_url":"https://api.github.com/users/python-diamond/followers","following_url":"https://api.github.com/users/python-diamond/following{/other_user}","gists_url":"https://api.github.com/users/python-diamond/gists{/gist_id}","starred_url":"https://api.github.com/users/python-diamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-diamond/subscriptions","organizations_url":"https://api.github.com/users/python-diamond/orgs","repos_url":"https://api.github.com/users/python-diamond/repos","events_url":"https://api.github.com/users/python-diamond/events{/privacy}","received_events_url":"https://api.github.com/users/python-diamond/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-diamond/Diamond","description":"Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.","fork":false,"url":"https://api.github.com/repos/python-diamond/Diamond","forks_url":"https://api.github.com/repos/python-diamond/Diamond/forks","keys_url":"https://api.github.com/repos/python-diamond/Diamond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-diamond/Diamond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-diamond/Diamond/teams","hooks_url":"https://api.github.com/repos/python-diamond/Diamond/hooks","issue_events_url":"https://api.github.com/repos/python-diamond/Diamond/issues/events{/number}","events_url":"https://api.github.com/repos/python-diamond/Diamond/events","assignees_url":"https://api.github.com/repos/python-diamond/Diamond/assignees{/user}","branches_url":"https://api.github.com/repos/python-diamond/Diamond/branches{/branch}","tags_url":"https://api.github.com/repos/python-diamond/Diamond/tags","blobs_url":"https://api.github.com/repos/python-diamond/Diamond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-diamond/Diamond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-diamond/Diamond/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-diamond/Diamond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-diamond/Diamond/statuses/{sha}","languages_url":"https://api.github.com/repos/python-diamond/Diamond/languages","stargazers_url":"https://api.github.com/repos/python-diamond/Diamond/stargazers","contributors_url":"https://api.github.com/repos/python-diamond/Diamond/contributors","subscribers_url":"https://api.github.com/repos/python-diamond/Diamond/subscribers","subscription_url":"https://api.github.com/repos/python-diamond/Diamond/subscription","commits_url":"https://api.github.com/repos/python-diamond/Diamond/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-diamond/Diamond/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-diamond/Diamond/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-diamond/Diamond/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-diamond/Diamond/contents/{+path}","compare_url":"https://api.github.com/repos/python-diamond/Diamond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-diamond/Diamond/merges","archive_url":"https://api.github.com/repos/python-diamond/Diamond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-diamond/Diamond/downloads","issues_url":"https://api.github.com/repos/python-diamond/Diamond/issues{/number}","pulls_url":"https://api.github.com/repos/python-diamond/Diamond/pulls{/number}","milestones_url":"https://api.github.com/repos/python-diamond/Diamond/milestones{/number}","notifications_url":"https://api.github.com/repos/python-diamond/Diamond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-diamond/Diamond/labels{/name}","releases_url":"https://api.github.com/repos/python-diamond/Diamond/releases{/id}","deployments_url":"https://api.github.com/repos/python-diamond/Diamond/deployments","created_at":"2013-10-11T23:32:13Z","updated_at":"2016-11-01T09:15:21Z","pushed_at":"2016-11-01T14:13:22Z","git_url":"git://github.com/python-diamond/Diamond.git","ssh_url":"git@github.com:python-diamond/Diamond.git","clone_url":"https://github.com/python-diamond/Diamond.git","svn_url":"https://github.com/python-diamond/Diamond","homepage":"http://diamond.readthedocs.org/","size":5383,"stargazers_count":726,"watchers_count":726,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":365,"mirror_url":null,"open_issues_count":257,"forks":365,"open_issues":257,"watchers":726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/546"},"html":{"href":"https://github.com/python-diamond/Diamond/pull/546"},"issue":{"href":"https://api.github.com/repos/python-diamond/Diamond/issues/546"},"comments":{"href":"https://api.github.com/repos/python-diamond/Diamond/issues/546/comments"},"review_comments":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/546/comments"},"review_comment":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/546/commits"},"statuses":{"href":"https://api.github.com/repos/python-diamond/Diamond/statuses/7b16002dec21eaed9e0171629fd761e49ed5da52"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bmhatfield","id":1119967,"avatar_url":"https://avatars.githubusercontent.com/u/1119967?v=3","gravatar_id":"","url":"https://api.github.com/users/bmhatfield","html_url":"https://github.com/bmhatfield","followers_url":"https://api.github.com/users/bmhatfield/followers","following_url":"https://api.github.com/users/bmhatfield/following{/other_user}","gists_url":"https://api.github.com/users/bmhatfield/gists{/gist_id}","starred_url":"https://api.github.com/users/bmhatfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmhatfield/subscriptions","organizations_url":"https://api.github.com/users/bmhatfield/orgs","repos_url":"https://api.github.com/users/bmhatfield/repos","events_url":"https://api.github.com/users/bmhatfield/events{/privacy}","received_events_url":"https://api.github.com/users/bmhatfield/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":2,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"bmhatfield"}}