{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/68375078","id":68375078,"diff_hunk":"@@ -274,6 +283,16 @@ def subnet_for(ip)\n       ip = IPAddr.new(ip)\n       Subnet.all.detect {|s| s.family == ip.family && s.contains?(ip)}\n     end\n+\n+    # allows to create a specific subnet class based on the network_type.\n+    # network_type is more user friendly than the class names\n+    def new_network_type(args)\n+      network_type = args.delete(:network_type) || N_('IPv4')","path":"app/models/subnet.rb","position":42,"original_position":42,"commit_id":"91acd61a3f94d6ceef69ce4dacfe4e4dbf00fb24","original_commit_id":"91acd61a3f94d6ceef69ce4dacfe4e4dbf00fb24","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"no need for `N_(..)` here, it's already extracted in SUBNET_TYPES and will just return the same string","created_at":"2016-06-24T09:34:00Z","updated_at":"2016-06-24T09:34:00Z","html_url":"https://github.com/theforeman/foreman/pull/3566#discussion_r68375078","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/3566","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/68375078"},"html":{"href":"https://github.com/theforeman/foreman/pull/3566#discussion_r68375078"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3566"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3566","id":72361273,"html_url":"https://github.com/theforeman/foreman/pull/3566","diff_url":"https://github.com/theforeman/foreman/pull/3566.diff","patch_url":"https://github.com/theforeman/foreman/pull/3566.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3566","number":3566,"state":"open","locked":false,"title":"fixes #14665 - support IPv6 via API","user":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-02T14:57:29Z","updated_at":"2016-06-24T09:34:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60289a2cbcc2eee9fa0aa1a55e172ca5c4704b15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3566/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3566/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3566/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/91acd61a3f94d6ceef69ce4dacfe4e4dbf00fb24","head":{"label":"timogoebel:14665-ipv6-api","ref":"14665-ipv6-api","sha":"91acd61a3f94d6ceef69ce4dacfe4e4dbf00fb24","user":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"repo":{"id":39135770,"name":"foreman","full_name":"timogoebel/foreman","owner":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timogoebel/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/timogoebel/foreman","forks_url":"https://api.github.com/repos/timogoebel/foreman/forks","keys_url":"https://api.github.com/repos/timogoebel/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timogoebel/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timogoebel/foreman/teams","hooks_url":"https://api.github.com/repos/timogoebel/foreman/hooks","issue_events_url":"https://api.github.com/repos/timogoebel/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/timogoebel/foreman/events","assignees_url":"https://api.github.com/repos/timogoebel/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/timogoebel/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/timogoebel/foreman/tags","blobs_url":"https://api.github.com/repos/timogoebel/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timogoebel/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timogoebel/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/timogoebel/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timogoebel/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/timogoebel/foreman/languages","stargazers_url":"https://api.github.com/repos/timogoebel/foreman/stargazers","contributors_url":"https://api.github.com/repos/timogoebel/foreman/contributors","subscribers_url":"https://api.github.com/repos/timogoebel/foreman/subscribers","subscription_url":"https://api.github.com/repos/timogoebel/foreman/subscription","commits_url":"https://api.github.com/repos/timogoebel/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/timogoebel/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/timogoebel/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/timogoebel/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/timogoebel/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/timogoebel/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timogoebel/foreman/merges","archive_url":"https://api.github.com/repos/timogoebel/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timogoebel/foreman/downloads","issues_url":"https://api.github.com/repos/timogoebel/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/timogoebel/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/timogoebel/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/timogoebel/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timogoebel/foreman/labels{/name}","releases_url":"https://api.github.com/repos/timogoebel/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/timogoebel/foreman/deployments","created_at":"2015-07-15T12:33:09Z","updated_at":"2016-06-07T14:43:19Z","pushed_at":"2016-06-24T06:44:41Z","git_url":"git://github.com/timogoebel/foreman.git","ssh_url":"git@github.com:timogoebel/foreman.git","clone_url":"https://github.com/timogoebel/foreman.git","svn_url":"https://github.com/timogoebel/foreman","homepage":"http://theforeman.org","size":46112,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"6c09e04f36e1b44bc29350640ea6e9dfa395ac13","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-06-23T03:21:46Z","pushed_at":"2016-06-24T06:44:42Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":70866,"stargazers_count":1033,"watchers_count":1033,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":529,"mirror_url":null,"open_issues_count":79,"forks":529,"open_issues":79,"watchers":1033,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3566"},"html":{"href":"https://github.com/theforeman/foreman/pull/3566"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3566"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3566/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3566/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3566/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/91acd61a3f94d6ceef69ce4dacfe4e4dbf00fb24"}}}}
{"actor":{"display_login":"domcleal"}}