{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/mozilla-partners/funnelcake/pulls/16","id":68651207,"html_url":"https://github.com/mozilla-partners/funnelcake/pull/16","diff_url":"https://github.com/mozilla-partners/funnelcake/pull/16.diff","patch_url":"https://github.com/mozilla-partners/funnelcake/pull/16.patch","issue_url":"https://api.github.com/repos/mozilla-partners/funnelcake/issues/16","number":16,"state":"closed","locked":false,"title":"Bug 1267305, First and 2nd run tests, r=cmore, jpetto","user":{"login":"nthomas-mozilla","id":942272,"avatar_url":"https://avatars.githubusercontent.com/u/942272?v=3","gravatar_id":"","url":"https://api.github.com/users/nthomas-mozilla","html_url":"https://github.com/nthomas-mozilla","followers_url":"https://api.github.com/users/nthomas-mozilla/followers","following_url":"https://api.github.com/users/nthomas-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/nthomas-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/nthomas-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nthomas-mozilla/subscriptions","organizations_url":"https://api.github.com/users/nthomas-mozilla/orgs","repos_url":"https://api.github.com/users/nthomas-mozilla/repos","events_url":"https://api.github.com/users/nthomas-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/nthomas-mozilla/received_events","type":"User","site_admin":false},"body":"@chrismore for your review.\r\n\r\nAssumptions:\r\n- the &v=N query arg should match the vN listed in the bug\r\n- that &v=1 was wanted in first case\r\n- setting a string pref to \"\" actually wipes an in-app preference\r\n\r\nI've set \r\n- browser.usedOnWindows10 to true, and\r\n- startup.homepage_welcome_url.additional to \"\"\r\n\r\nto avoid additionalPage being set at [this code](https://dxr.mozilla.org/mozilla-release/source/browser/components/nsBrowserContentHandler.js#571).","created_at":"2016-05-03T02:41:50Z","updated_at":"2016-05-05T22:42:51Z","closed_at":"2016-05-05T22:42:51Z","merged_at":"2016-05-05T22:42:51Z","merge_commit_sha":"9105271264d03bf08c2d1f8ac87cd0b86f16bbc3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-partners/funnelcake/pulls/16/commits","review_comments_url":"https://api.github.com/repos/mozilla-partners/funnelcake/pulls/16/comments","review_comment_url":"https://api.github.com/repos/mozilla-partners/funnelcake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-partners/funnelcake/issues/16/comments","statuses_url":"https://api.github.com/repos/mozilla-partners/funnelcake/statuses/5018e46127e825632899840d64733f6ff3d9b5cf","head":{"label":"nthomas-mozilla:bug1267305-2nd-run","ref":"bug1267305-2nd-run","sha":"5018e46127e825632899840d64733f6ff3d9b5cf","user":{"login":"nthomas-mozilla","id":942272,"avatar_url":"https://avatars.githubusercontent.com/u/942272?v=3","gravatar_id":"","url":"https://api.github.com/users/nthomas-mozilla","html_url":"https://github.com/nthomas-mozilla","followers_url":"https://api.github.com/users/nthomas-mozilla/followers","following_url":"https://api.github.com/users/nthomas-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/nthomas-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/nthomas-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nthomas-mozilla/subscriptions","organizations_url":"https://api.github.com/users/nthomas-mozilla/orgs","repos_url":"https://api.github.com/users/nthomas-mozilla/repos","events_url":"https://api.github.com/users/nthomas-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/nthomas-mozilla/received_events","type":"User","site_admin":false},"repo":{"id":42212839,"name":"funnelcake","full_name":"nthomas-mozilla/funnelcake","owner":{"login":"nthomas-mozilla","id":942272,"avatar_url":"https://avatars.githubusercontent.com/u/942272?v=3","gravatar_id":"","url":"https://api.github.com/users/nthomas-mozilla","html_url":"https://github.com/nthomas-mozilla","followers_url":"https://api.github.com/users/nthomas-mozilla/followers","following_url":"https://api.github.com/users/nthomas-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/nthomas-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/nthomas-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nthomas-mozilla/subscriptions","organizations_url":"https://api.github.com/users/nthomas-mozilla/orgs","repos_url":"https://api.github.com/users/nthomas-mozilla/repos","events_url":"https://api.github.com/users/nthomas-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/nthomas-mozilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nthomas-mozilla/funnelcake","description":"","fork":true,"url":"https://api.github.com/repos/nthomas-mozilla/funnelcake","forks_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/forks","keys_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/teams","hooks_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/hooks","issue_events_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/issues/events{/number}","events_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/events","assignees_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/assignees{/user}","branches_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/branches{/branch}","tags_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/tags","blobs_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/git/refs{/sha}","trees_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/statuses/{sha}","languages_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/languages","stargazers_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/stargazers","contributors_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/contributors","subscribers_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/subscribers","subscription_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/subscription","commits_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/commits{/sha}","git_commits_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/git/commits{/sha}","comments_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/comments{/number}","issue_comment_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/issues/comments{/number}","contents_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/contents/{+path}","compare_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/merges","archive_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/downloads","issues_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/issues{/number}","pulls_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/pulls{/number}","milestones_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/milestones{/number}","notifications_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/labels{/name}","releases_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/releases{/id}","deployments_url":"https://api.github.com/repos/nthomas-mozilla/funnelcake/deployments","created_at":"2015-09-10T00:49:28Z","updated_at":"2016-05-03T01:55:09Z","pushed_at":"2016-05-03T02:34:23Z","git_url":"git://github.com/nthomas-mozilla/funnelcake.git","ssh_url":"git@github.com:nthomas-mozilla/funnelcake.git","clone_url":"https://github.com/nthomas-mozilla/funnelcake.git","svn_url":"https://github.com/nthomas-mozilla/funnelcake","homepage":null,"size":151,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-partners:master","ref":"master","sha":"1fb7de16faddb5f2b2bc8c6bd9f2f0d0ee806f99","user":{"login":"mozilla-partners","id":13371481,"avatar_url":"https://avatars.githubusercontent.com/u/13371481?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-partners","html_url":"https://github.com/mozilla-partners","followers_url":"https://api.github.com/users/mozilla-partners/followers","following_url":"https://api.github.com/users/mozilla-partners/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-partners/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-partners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-partners/subscriptions","organizations_url":"https://api.github.com/users/mozilla-partners/orgs","repos_url":"https://api.github.com/users/mozilla-partners/repos","events_url":"https://api.github.com/users/mozilla-partners/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-partners/received_events","type":"Organization","site_admin":false},"repo":{"id":39979557,"name":"funnelcake","full_name":"mozilla-partners/funnelcake","owner":{"login":"mozilla-partners","id":13371481,"avatar_url":"https://avatars.githubusercontent.com/u/13371481?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-partners","html_url":"https://github.com/mozilla-partners","followers_url":"https://api.github.com/users/mozilla-partners/followers","following_url":"https://api.github.com/users/mozilla-partners/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-partners/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-partners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-partners/subscriptions","organizations_url":"https://api.github.com/users/mozilla-partners/orgs","repos_url":"https://api.github.com/users/mozilla-partners/repos","events_url":"https://api.github.com/users/mozilla-partners/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-partners/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-partners/funnelcake","description":"","fork":false,"url":"https://api.github.com/repos/mozilla-partners/funnelcake","forks_url":"https://api.github.com/repos/mozilla-partners/funnelcake/forks","keys_url":"https://api.github.com/repos/mozilla-partners/funnelcake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-partners/funnelcake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-partners/funnelcake/teams","hooks_url":"https://api.github.com/repos/mozilla-partners/funnelcake/hooks","issue_events_url":"https://api.github.com/repos/mozilla-partners/funnelcake/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-partners/funnelcake/events","assignees_url":"https://api.github.com/repos/mozilla-partners/funnelcake/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-partners/funnelcake/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-partners/funnelcake/tags","blobs_url":"https://api.github.com/repos/mozilla-partners/funnelcake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-partners/funnelcake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-partners/funnelcake/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-partners/funnelcake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-partners/funnelcake/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-partners/funnelcake/languages","stargazers_url":"https://api.github.com/repos/mozilla-partners/funnelcake/stargazers","contributors_url":"https://api.github.com/repos/mozilla-partners/funnelcake/contributors","subscribers_url":"https://api.github.com/repos/mozilla-partners/funnelcake/subscribers","subscription_url":"https://api.github.com/repos/mozilla-partners/funnelcake/subscription","commits_url":"https://api.github.com/repos/mozilla-partners/funnelcake/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-partners/funnelcake/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-partners/funnelcake/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-partners/funnelcake/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-partners/funnelcake/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-partners/funnelcake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-partners/funnelcake/merges","archive_url":"https://api.github.com/repos/mozilla-partners/funnelcake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-partners/funnelcake/downloads","issues_url":"https://api.github.com/repos/mozilla-partners/funnelcake/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-partners/funnelcake/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-partners/funnelcake/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-partners/funnelcake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-partners/funnelcake/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-partners/funnelcake/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-partners/funnelcake/deployments","created_at":"2015-07-31T01:06:20Z","updated_at":"2016-03-22T22:22:35Z","pushed_at":"2016-05-05T22:42:51Z","git_url":"git://github.com/mozilla-partners/funnelcake.git","ssh_url":"git@github.com:mozilla-partners/funnelcake.git","clone_url":"https://github.com/mozilla-partners/funnelcake.git","svn_url":"https://github.com/mozilla-partners/funnelcake","homepage":null,"size":148,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-partners/funnelcake/pulls/16"},"html":{"href":"https://github.com/mozilla-partners/funnelcake/pull/16"},"issue":{"href":"https://api.github.com/repos/mozilla-partners/funnelcake/issues/16"},"comments":{"href":"https://api.github.com/repos/mozilla-partners/funnelcake/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-partners/funnelcake/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-partners/funnelcake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-partners/funnelcake/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-partners/funnelcake/statuses/5018e46127e825632899840d64733f6ff3d9b5cf"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nthomas-mozilla","id":942272,"avatar_url":"https://avatars.githubusercontent.com/u/942272?v=3","gravatar_id":"","url":"https://api.github.com/users/nthomas-mozilla","html_url":"https://github.com/nthomas-mozilla","followers_url":"https://api.github.com/users/nthomas-mozilla/followers","following_url":"https://api.github.com/users/nthomas-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/nthomas-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/nthomas-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nthomas-mozilla/subscriptions","organizations_url":"https://api.github.com/users/nthomas-mozilla/orgs","repos_url":"https://api.github.com/users/nthomas-mozilla/repos","events_url":"https://api.github.com/users/nthomas-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/nthomas-mozilla/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":2,"additions":221,"deletions":0,"changed_files":14}}