{"action":"created","comment":{"url":"https://api.github.com/repos/gem/oq-hazardlib/pulls/comments/60408991","id":60408991,"diff_hunk":"@@ -36,13 +36,13 @@ def __init__(self, corr, gsim):\n         self.corr = corr\n         self.gsim = gsim\n \n-    def __str__(self):\n-        return '''\\\n-You cannot use the correlation model %s with the GSIM %s, \\\n-that defines only the total standard deviation. If you want to use a \\\n-correlation model you have to select a GMPE that provides the inter and \\\n-intra event standard deviations.''' % (\n-            self.corr.__class__.__name__, self.gsim.__class__.__name__)\n+#    def __str__(self):\n+#        return '''\\\n+#You cannot use the correlation model %s with the GSIM %s, \\\n+#that defines only the total standard deviation. If you want to use a \\\n+#correlation model you have to select a GMPE that provides the inter and \\\n+#intra event standard deviations.''' % (\n+#            self.corr.__class__.__name__, self.gsim.__class__.__name__)","path":"openquake/hazardlib/calc/gmf.py","position":17,"original_position":17,"commit_id":"740015df7cb03995f29b0f6bfc926f837e72d9f9","original_commit_id":"740015df7cb03995f29b0f6bfc926f837e72d9f9","user":{"login":"mmpagani","id":318811,"avatar_url":"https://avatars.githubusercontent.com/u/318811?v=3","gravatar_id":"","url":"https://api.github.com/users/mmpagani","html_url":"https://github.com/mmpagani","followers_url":"https://api.github.com/users/mmpagani/followers","following_url":"https://api.github.com/users/mmpagani/following{/other_user}","gists_url":"https://api.github.com/users/mmpagani/gists{/gist_id}","starred_url":"https://api.github.com/users/mmpagani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmpagani/subscriptions","organizations_url":"https://api.github.com/users/mmpagani/orgs","repos_url":"https://api.github.com/users/mmpagani/repos","events_url":"https://api.github.com/users/mmpagani/events{/privacy}","received_events_url":"https://api.github.com/users/mmpagani/received_events","type":"User","site_admin":false},"body":"remove the commented code","created_at":"2016-04-20T13:43:36Z","updated_at":"2016-04-20T13:43:36Z","html_url":"https://github.com/gem/oq-hazardlib/pull/431#discussion_r60408991","pull_request_url":"https://api.github.com/repos/gem/oq-hazardlib/pulls/431","_links":{"self":{"href":"https://api.github.com/repos/gem/oq-hazardlib/pulls/comments/60408991"},"html":{"href":"https://github.com/gem/oq-hazardlib/pull/431#discussion_r60408991"},"pull_request":{"href":"https://api.github.com/repos/gem/oq-hazardlib/pulls/431"}}},"pull_request":{"url":"https://api.github.com/repos/gem/oq-hazardlib/pulls/431","id":62247651,"html_url":"https://github.com/gem/oq-hazardlib/pull/431","diff_url":"https://github.com/gem/oq-hazardlib/pull/431.diff","patch_url":"https://github.com/gem/oq-hazardlib/pull/431.patch","issue_url":"https://api.github.com/repos/gem/oq-hazardlib/issues/431","number":431,"state":"open","locked":false,"title":"Add ShahiBaker GMPEs (with and without near-fault effect) + 4  DistanceContext object","user":{"login":"vup1120","id":3910909,"avatar_url":"https://avatars.githubusercontent.com/u/3910909?v=3","gravatar_id":"","url":"https://api.github.com/users/vup1120","html_url":"https://github.com/vup1120","followers_url":"https://api.github.com/users/vup1120/followers","following_url":"https://api.github.com/users/vup1120/following{/other_user}","gists_url":"https://api.github.com/users/vup1120/gists{/gist_id}","starred_url":"https://api.github.com/users/vup1120/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vup1120/subscriptions","organizations_url":"https://api.github.com/users/vup1120/orgs","repos_url":"https://api.github.com/users/vup1120/repos","events_url":"https://api.github.com/users/vup1120/events{/privacy}","received_events_url":"https://api.github.com/users/vup1120/received_events","type":"User","site_admin":false},"body":"In this pull request, \r\n\r\n* Adding two GMPEs which publish in the doctoral dissertation of Shrey K. Shahi. \r\nOne is called shahi_baker_2013 GMPE, which is the one without near-fault consideration. \r\nThe other one is called shahi_baker_nearfault_2013 GMPE, which is the one with near-fault consideration(pulse). The model I implemented here is the one with unknown predicted pulse-periods, and unknown pulse-occurrence ( I think it is more practical)\r\n\r\nNote: the test tables are generated by my implementation itself in order to complete the test coverage since the code is not available from the authors. So I did not put many scenarios in the table. \r\n\r\n\r\n* Adding 4 slots to DistanceContext object, called rs, rtheta, rd, rphi (published in Somerville et al., 1997, ). They will be used in the directivity prediction inside the shahi_baker_nearfault_2013 GMPE for empirical pulse prediction.\r\n\r\n* Implemented get_rupture_fraction_strikeslip method to obatin 'rs' and 'rtheta' distances.\r\n\r\n* Implemented get_rupture_fraction_dipslip method to obatin 'rd' and 'rphi' distances.\r\n\r\nThe test is green shown below:\r\nhttps://ci.openquake.org/job/zdevel_oq-hazardlib/510/\r\n\r\n","created_at":"2016-03-09T15:42:52Z","updated_at":"2016-04-20T13:43:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46b015e9f8980c82593ca1392941994d83df3b54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gem/oq-hazardlib/pulls/431/commits","review_comments_url":"https://api.github.com/repos/gem/oq-hazardlib/pulls/431/comments","review_comment_url":"https://api.github.com/repos/gem/oq-hazardlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gem/oq-hazardlib/issues/431/comments","statuses_url":"https://api.github.com/repos/gem/oq-hazardlib/statuses/740015df7cb03995f29b0f6bfc926f837e72d9f9","head":{"label":"vup1120:SBNEW","ref":"SBNEW","sha":"740015df7cb03995f29b0f6bfc926f837e72d9f9","user":{"login":"vup1120","id":3910909,"avatar_url":"https://avatars.githubusercontent.com/u/3910909?v=3","gravatar_id":"","url":"https://api.github.com/users/vup1120","html_url":"https://github.com/vup1120","followers_url":"https://api.github.com/users/vup1120/followers","following_url":"https://api.github.com/users/vup1120/following{/other_user}","gists_url":"https://api.github.com/users/vup1120/gists{/gist_id}","starred_url":"https://api.github.com/users/vup1120/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vup1120/subscriptions","organizations_url":"https://api.github.com/users/vup1120/orgs","repos_url":"https://api.github.com/users/vup1120/repos","events_url":"https://api.github.com/users/vup1120/events{/privacy}","received_events_url":"https://api.github.com/users/vup1120/received_events","type":"User","site_admin":false},"repo":{"id":25962586,"name":"oq-hazardlib","full_name":"vup1120/oq-hazardlib","owner":{"login":"vup1120","id":3910909,"avatar_url":"https://avatars.githubusercontent.com/u/3910909?v=3","gravatar_id":"","url":"https://api.github.com/users/vup1120","html_url":"https://github.com/vup1120","followers_url":"https://api.github.com/users/vup1120/followers","following_url":"https://api.github.com/users/vup1120/following{/other_user}","gists_url":"https://api.github.com/users/vup1120/gists{/gist_id}","starred_url":"https://api.github.com/users/vup1120/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vup1120/subscriptions","organizations_url":"https://api.github.com/users/vup1120/orgs","repos_url":"https://api.github.com/users/vup1120/repos","events_url":"https://api.github.com/users/vup1120/events{/privacy}","received_events_url":"https://api.github.com/users/vup1120/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vup1120/oq-hazardlib","description":"Openquake Hazard Library","fork":true,"url":"https://api.github.com/repos/vup1120/oq-hazardlib","forks_url":"https://api.github.com/repos/vup1120/oq-hazardlib/forks","keys_url":"https://api.github.com/repos/vup1120/oq-hazardlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vup1120/oq-hazardlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vup1120/oq-hazardlib/teams","hooks_url":"https://api.github.com/repos/vup1120/oq-hazardlib/hooks","issue_events_url":"https://api.github.com/repos/vup1120/oq-hazardlib/issues/events{/number}","events_url":"https://api.github.com/repos/vup1120/oq-hazardlib/events","assignees_url":"https://api.github.com/repos/vup1120/oq-hazardlib/assignees{/user}","branches_url":"https://api.github.com/repos/vup1120/oq-hazardlib/branches{/branch}","tags_url":"https://api.github.com/repos/vup1120/oq-hazardlib/tags","blobs_url":"https://api.github.com/repos/vup1120/oq-hazardlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vup1120/oq-hazardlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vup1120/oq-hazardlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/vup1120/oq-hazardlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vup1120/oq-hazardlib/statuses/{sha}","languages_url":"https://api.github.com/repos/vup1120/oq-hazardlib/languages","stargazers_url":"https://api.github.com/repos/vup1120/oq-hazardlib/stargazers","contributors_url":"https://api.github.com/repos/vup1120/oq-hazardlib/contributors","subscribers_url":"https://api.github.com/repos/vup1120/oq-hazardlib/subscribers","subscription_url":"https://api.github.com/repos/vup1120/oq-hazardlib/subscription","commits_url":"https://api.github.com/repos/vup1120/oq-hazardlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/vup1120/oq-hazardlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/vup1120/oq-hazardlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/vup1120/oq-hazardlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/vup1120/oq-hazardlib/contents/{+path}","compare_url":"https://api.github.com/repos/vup1120/oq-hazardlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vup1120/oq-hazardlib/merges","archive_url":"https://api.github.com/repos/vup1120/oq-hazardlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vup1120/oq-hazardlib/downloads","issues_url":"https://api.github.com/repos/vup1120/oq-hazardlib/issues{/number}","pulls_url":"https://api.github.com/repos/vup1120/oq-hazardlib/pulls{/number}","milestones_url":"https://api.github.com/repos/vup1120/oq-hazardlib/milestones{/number}","notifications_url":"https://api.github.com/repos/vup1120/oq-hazardlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vup1120/oq-hazardlib/labels{/name}","releases_url":"https://api.github.com/repos/vup1120/oq-hazardlib/releases{/id}","deployments_url":"https://api.github.com/repos/vup1120/oq-hazardlib/deployments","created_at":"2014-10-30T09:00:56Z","updated_at":"2016-03-02T09:49:50Z","pushed_at":"2016-04-20T12:36:54Z","git_url":"git://github.com/vup1120/oq-hazardlib.git","ssh_url":"git@github.com:vup1120/oq-hazardlib.git","clone_url":"https://github.com/vup1120/oq-hazardlib.git","svn_url":"https://github.com/vup1120/oq-hazardlib","homepage":"http://www.globalquakemodel.org/openquake/","size":42176,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gem:master","ref":"master","sha":"4a9cb3d35220baef886b7ef058f17a1a35093116","user":{"login":"gem","id":316546,"avatar_url":"https://avatars.githubusercontent.com/u/316546?v=3","gravatar_id":"","url":"https://api.github.com/users/gem","html_url":"https://github.com/gem","followers_url":"https://api.github.com/users/gem/followers","following_url":"https://api.github.com/users/gem/following{/other_user}","gists_url":"https://api.github.com/users/gem/gists{/gist_id}","starred_url":"https://api.github.com/users/gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gem/subscriptions","organizations_url":"https://api.github.com/users/gem/orgs","repos_url":"https://api.github.com/users/gem/repos","events_url":"https://api.github.com/users/gem/events{/privacy}","received_events_url":"https://api.github.com/users/gem/received_events","type":"Organization","site_admin":false},"repo":{"id":2986762,"name":"oq-hazardlib","full_name":"gem/oq-hazardlib","owner":{"login":"gem","id":316546,"avatar_url":"https://avatars.githubusercontent.com/u/316546?v=3","gravatar_id":"","url":"https://api.github.com/users/gem","html_url":"https://github.com/gem","followers_url":"https://api.github.com/users/gem/followers","following_url":"https://api.github.com/users/gem/following{/other_user}","gists_url":"https://api.github.com/users/gem/gists{/gist_id}","starred_url":"https://api.github.com/users/gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gem/subscriptions","organizations_url":"https://api.github.com/users/gem/orgs","repos_url":"https://api.github.com/users/gem/repos","events_url":"https://api.github.com/users/gem/events{/privacy}","received_events_url":"https://api.github.com/users/gem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gem/oq-hazardlib","description":"Openquake Hazard Library","fork":false,"url":"https://api.github.com/repos/gem/oq-hazardlib","forks_url":"https://api.github.com/repos/gem/oq-hazardlib/forks","keys_url":"https://api.github.com/repos/gem/oq-hazardlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gem/oq-hazardlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gem/oq-hazardlib/teams","hooks_url":"https://api.github.com/repos/gem/oq-hazardlib/hooks","issue_events_url":"https://api.github.com/repos/gem/oq-hazardlib/issues/events{/number}","events_url":"https://api.github.com/repos/gem/oq-hazardlib/events","assignees_url":"https://api.github.com/repos/gem/oq-hazardlib/assignees{/user}","branches_url":"https://api.github.com/repos/gem/oq-hazardlib/branches{/branch}","tags_url":"https://api.github.com/repos/gem/oq-hazardlib/tags","blobs_url":"https://api.github.com/repos/gem/oq-hazardlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gem/oq-hazardlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gem/oq-hazardlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/gem/oq-hazardlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gem/oq-hazardlib/statuses/{sha}","languages_url":"https://api.github.com/repos/gem/oq-hazardlib/languages","stargazers_url":"https://api.github.com/repos/gem/oq-hazardlib/stargazers","contributors_url":"https://api.github.com/repos/gem/oq-hazardlib/contributors","subscribers_url":"https://api.github.com/repos/gem/oq-hazardlib/subscribers","subscription_url":"https://api.github.com/repos/gem/oq-hazardlib/subscription","commits_url":"https://api.github.com/repos/gem/oq-hazardlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/gem/oq-hazardlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/gem/oq-hazardlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/gem/oq-hazardlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/gem/oq-hazardlib/contents/{+path}","compare_url":"https://api.github.com/repos/gem/oq-hazardlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gem/oq-hazardlib/merges","archive_url":"https://api.github.com/repos/gem/oq-hazardlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gem/oq-hazardlib/downloads","issues_url":"https://api.github.com/repos/gem/oq-hazardlib/issues{/number}","pulls_url":"https://api.github.com/repos/gem/oq-hazardlib/pulls{/number}","milestones_url":"https://api.github.com/repos/gem/oq-hazardlib/milestones{/number}","notifications_url":"https://api.github.com/repos/gem/oq-hazardlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gem/oq-hazardlib/labels{/name}","releases_url":"https://api.github.com/repos/gem/oq-hazardlib/releases{/id}","deployments_url":"https://api.github.com/repos/gem/oq-hazardlib/deployments","created_at":"2011-12-15T10:14:46Z","updated_at":"2016-03-31T13:37:32Z","pushed_at":"2016-04-20T12:36:55Z","git_url":"git://github.com/gem/oq-hazardlib.git","ssh_url":"git@github.com:gem/oq-hazardlib.git","clone_url":"https://github.com/gem/oq-hazardlib.git","svn_url":"https://github.com/gem/oq-hazardlib","homepage":"http://www.globalquakemodel.org/openquake/","size":50867,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":2,"forks":40,"open_issues":2,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gem/oq-hazardlib/pulls/431"},"html":{"href":"https://github.com/gem/oq-hazardlib/pull/431"},"issue":{"href":"https://api.github.com/repos/gem/oq-hazardlib/issues/431"},"comments":{"href":"https://api.github.com/repos/gem/oq-hazardlib/issues/431/comments"},"review_comments":{"href":"https://api.github.com/repos/gem/oq-hazardlib/pulls/431/comments"},"review_comment":{"href":"https://api.github.com/repos/gem/oq-hazardlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gem/oq-hazardlib/pulls/431/commits"},"statuses":{"href":"https://api.github.com/repos/gem/oq-hazardlib/statuses/740015df7cb03995f29b0f6bfc926f837e72d9f9"}}}}