{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/comments/73062793","id":73062793,"diff_hunk":"@@ -189,6 +200,48 @@ var AuthenticationContext = (function () {\n         // callback from redirected page will receive fragment. It needs to call oauth2Callback\n     };\n \n+    AuthenticationContext.prototype.openPopup = function (urlNavigate, title, w, h) {\n+        //Added to center in case of dual Monitor\n+        var dualScreenLeft = window.screenLeft != undefined ? window.screenLeft : screen.left;\n+        var dualScreenTop = window.screenTop != undefined ? window.screenTop : screen.top;\n+\n+        var width = window.innerWidth ? window.innerWidth : document.documentElement.clientWidth ? document.documentElement.clientWidth : screen.width;\n+        var height = window.innerHeight ? window.innerHeight : document.documentElement.clientHeight ? document.documentElement.clientHeight : screen.height;\n+\n+        var left = ((width / 2) - (w / 2)) + dualScreenLeft;\n+        var top = ((height / 2) - (h / 2)) + dualScreenTop;\n+\n+        var popupWindow = window.open(urlNavigate, title, 'width=' + w + ', height=' + h + ', top=' + top + ', left=' + left);\n+\n+        //Puts focus on the popUpWindow\n+        if (popupWindow.focus) {\n+            popupWindow.focus();\n+        }\n+        return popupWindow;\n+    }\n+\n+    AuthenticationContext.prototype.loginPopup = function (urlNavigate) {\n+        var popupWindow = this.openPopup(urlNavigate, \"login\", 483, 600);\n+        if (this.config.redirectUri.indexOf('#') != -1)\n+            var registeredRedirectUri = this.config.redirectUri.split(\"#\")[0];\n+        else\n+            var registeredRedirectUri = this.config.redirectUri;\n+        var that = this;","path":"lib/adal.js","position":70,"original_position":70,"commit_id":"751f7723c59ba06bd0881454434c0dbd0fd8c9be","original_commit_id":"751f7723c59ba06bd0881454434c0dbd0fd8c9be","user":{"login":"tushargupta51","id":803796,"avatar_url":"https://avatars.githubusercontent.com/u/803796?v=3","gravatar_id":"","url":"https://api.github.com/users/tushargupta51","html_url":"https://github.com/tushargupta51","followers_url":"https://api.github.com/users/tushargupta51/followers","following_url":"https://api.github.com/users/tushargupta51/following{/other_user}","gists_url":"https://api.github.com/users/tushargupta51/gists{/gist_id}","starred_url":"https://api.github.com/users/tushargupta51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tushargupta51/subscriptions","organizations_url":"https://api.github.com/users/tushargupta51/orgs","repos_url":"https://api.github.com/users/tushargupta51/repos","events_url":"https://api.github.com/users/tushargupta51/events{/privacy}","received_events_url":"https://api.github.com/users/tushargupta51/received_events","type":"User","site_admin":false},"body":"This is not needed now.","created_at":"2016-08-01T22:12:08Z","updated_at":"2016-08-01T22:12:08Z","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/357#discussion_r73062793","pull_request_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/357","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/comments/73062793"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/357#discussion_r73062793"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/357"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/357","id":78951083,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/357","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/357.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/357.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/357","number":357,"state":"open","locked":false,"title":"Rohitnarula7176/popup","user":{"login":"rohitnarula7176","id":19417198,"avatar_url":"https://avatars.githubusercontent.com/u/19417198?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitnarula7176","html_url":"https://github.com/rohitnarula7176","followers_url":"https://api.github.com/users/rohitnarula7176/followers","following_url":"https://api.github.com/users/rohitnarula7176/following{/other_user}","gists_url":"https://api.github.com/users/rohitnarula7176/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitnarula7176/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitnarula7176/subscriptions","organizations_url":"https://api.github.com/users/rohitnarula7176/orgs","repos_url":"https://api.github.com/users/rohitnarula7176/repos","events_url":"https://api.github.com/users/rohitnarula7176/events{/privacy}","received_events_url":"https://api.github.com/users/rohitnarula7176/received_events","type":"User","site_admin":false},"body":"#60 ","created_at":"2016-07-27T01:12:05Z","updated_at":"2016-08-01T22:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd27097fa0f6a831ae9163900dae33a9bc677162","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/357/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/357/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/357/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/statuses/751f7723c59ba06bd0881454434c0dbd0fd8c9be","head":{"label":"AzureAD:rohitnarula7176/popup","ref":"rohitnarula7176/popup","sha":"751f7723c59ba06bd0881454434c0dbd0fd8c9be","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":19990198,"name":"azure-activedirectory-library-for-js","full_name":"AzureAD/azure-activedirectory-library-for-js","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js","description":"","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/deployments","created_at":"2014-05-20T17:21:41Z","updated_at":"2016-07-27T20:55:00Z","pushed_at":"2016-08-01T21:55:51Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-js.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-js.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js","homepage":null,"size":1579,"stargazers_count":181,"watchers_count":181,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":33,"forks":111,"open_issues":33,"watchers":181,"default_branch":"master"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"89f8612f6418929d3158accf896dd51741ef2c2a","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":19990198,"name":"azure-activedirectory-library-for-js","full_name":"AzureAD/azure-activedirectory-library-for-js","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js","description":"","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/deployments","created_at":"2014-05-20T17:21:41Z","updated_at":"2016-07-27T20:55:00Z","pushed_at":"2016-08-01T21:55:51Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-js.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-js.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js","homepage":null,"size":1579,"stargazers_count":181,"watchers_count":181,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":33,"forks":111,"open_issues":33,"watchers":181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/357"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/357"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/357"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/357/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/357/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/357/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/statuses/751f7723c59ba06bd0881454434c0dbd0fd8c9be"}}}}
{"actor":{"display_login":"tushargupta51"}}