{"action":"created","comment":{"url":"https://api.github.com/repos/oms4suse/sesceph/pulls/comments/57720642","id":57720642,"diff_hunk":"@@ -336,21 +300,26 @@ def fset(self, name):\n                 self._clear_implementation()\n             if not name in self._availableKeys:\n                 self._clear_implementation()\n-                raise Error(\"Invalid Value\")\n+                raise Error(\"Invalid Value:%s\" % (name))\n             implementation = None\n             if name == \"admin\":\n-                implementation = keyring_implementation_admin()\n+                implementation = keyring_implementation_admin(self.model)\n             if name == \"mds\":\n-                implementation = keyring_implementation_mds()\n+                implementation = keyring_implementation_mds(self.model)\n             if name == \"mon\":\n-                implementation = keyring_implementation_mon()\n+                implementation = keyring_implementation_mon(self.model)\n             if name == \"osd\":\n-                implementation = keyring_implementation_osd()\n+                implementation = keyring_implementation_osd(self.model)\n             if name == \"rgw\":\n-                implementation = keyring_implementation_rgw()\n+                implementation = keyring_implementation_rgw(self.model)\n             if implementation is None:\n                 self._clear_implementation()\n-                raise Error(\"Invalid Value\")\n+                raise Error(\"Programming error for invalid Value:%s\" % (name))","path":"_modules/sesceph/keyring.py","position":297,"original_position":297,"commit_id":"025abc0100f957c98657836fa21ec88923ffc9b0","original_commit_id":"025abc0100f957c98657836fa21ec88923ffc9b0","user":{"login":"swiftgist","id":4697887,"avatar_url":"https://avatars.githubusercontent.com/u/4697887?v=3","gravatar_id":"","url":"https://api.github.com/users/swiftgist","html_url":"https://github.com/swiftgist","followers_url":"https://api.github.com/users/swiftgist/followers","following_url":"https://api.github.com/users/swiftgist/following{/other_user}","gists_url":"https://api.github.com/users/swiftgist/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftgist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftgist/subscriptions","organizations_url":"https://api.github.com/users/swiftgist/orgs","repos_url":"https://api.github.com/users/swiftgist/repos","events_url":"https://api.github.com/users/swiftgist/events{/privacy}","received_events_url":"https://api.github.com/users/swiftgist/received_events","type":"User","site_admin":false},"body":"Should raise be ValueError here?  I'm thinking about unit testing.","created_at":"2016-03-29T13:18:19Z","updated_at":"2016-03-29T13:18:19Z","html_url":"https://github.com/oms4suse/sesceph/pull/21#discussion_r57720642","pull_request_url":"https://api.github.com/repos/oms4suse/sesceph/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/oms4suse/sesceph/pulls/comments/57720642"},"html":{"href":"https://github.com/oms4suse/sesceph/pull/21#discussion_r57720642"},"pull_request":{"href":"https://api.github.com/repos/oms4suse/sesceph/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/oms4suse/sesceph/pulls/21","id":64453194,"html_url":"https://github.com/oms4suse/sesceph/pull/21","diff_url":"https://github.com/oms4suse/sesceph/pull/21.diff","patch_url":"https://github.com/oms4suse/sesceph/pull/21.patch","issue_url":"https://api.github.com/repos/oms4suse/sesceph/issues/21","number":21,"state":"open","locked":false,"title":"Keyring refactor","user":{"login":"oms4suse","id":14092619,"avatar_url":"https://avatars.githubusercontent.com/u/14092619?v=3","gravatar_id":"","url":"https://api.github.com/users/oms4suse","html_url":"https://github.com/oms4suse","followers_url":"https://api.github.com/users/oms4suse/followers","following_url":"https://api.github.com/users/oms4suse/following{/other_user}","gists_url":"https://api.github.com/users/oms4suse/gists{/gist_id}","starred_url":"https://api.github.com/users/oms4suse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oms4suse/subscriptions","organizations_url":"https://api.github.com/users/oms4suse/orgs","repos_url":"https://api.github.com/users/oms4suse/repos","events_url":"https://api.github.com/users/oms4suse/events{/privacy}","received_events_url":"https://api.github.com/users/oms4suse/received_events","type":"User","site_admin":false},"body":"Add the following public methods.\r\n    keyring_create\r\n    keyring_save\r\n    keyring_purge\r\n    keyring_present\r\n    keyring_auth_add\r\n    keyring_auth_del\r\n\r\nThese will replace the type specific methods.\r\n\r\nThe related re factoring is for better use of the MVC design pattern.\r\n\r\nThe MVC design pattern can be composed of multiple MVC patterns if the controller\r\ncan be treated as a view. To allow this to happen the controller must not create\r\nthe model.","created_at":"2016-03-29T11:53:01Z","updated_at":"2016-03-29T13:18:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c10e257e21d7719f76e885238c38c1b8dbffbb97","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/oms4suse/sesceph/pulls/21/commits","review_comments_url":"https://api.github.com/repos/oms4suse/sesceph/pulls/21/comments","review_comment_url":"https://api.github.com/repos/oms4suse/sesceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oms4suse/sesceph/issues/21/comments","statuses_url":"https://api.github.com/repos/oms4suse/sesceph/statuses/025abc0100f957c98657836fa21ec88923ffc9b0","head":{"label":"oms4suse:wip_keyring_refactor","ref":"wip_keyring_refactor","sha":"025abc0100f957c98657836fa21ec88923ffc9b0","user":{"login":"oms4suse","id":14092619,"avatar_url":"https://avatars.githubusercontent.com/u/14092619?v=3","gravatar_id":"","url":"https://api.github.com/users/oms4suse","html_url":"https://github.com/oms4suse","followers_url":"https://api.github.com/users/oms4suse/followers","following_url":"https://api.github.com/users/oms4suse/following{/other_user}","gists_url":"https://api.github.com/users/oms4suse/gists{/gist_id}","starred_url":"https://api.github.com/users/oms4suse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oms4suse/subscriptions","organizations_url":"https://api.github.com/users/oms4suse/orgs","repos_url":"https://api.github.com/users/oms4suse/repos","events_url":"https://api.github.com/users/oms4suse/events{/privacy}","received_events_url":"https://api.github.com/users/oms4suse/received_events","type":"User","site_admin":false},"repo":{"id":51437111,"name":"sesceph","full_name":"oms4suse/sesceph","owner":{"login":"oms4suse","id":14092619,"avatar_url":"https://avatars.githubusercontent.com/u/14092619?v=3","gravatar_id":"","url":"https://api.github.com/users/oms4suse","html_url":"https://github.com/oms4suse","followers_url":"https://api.github.com/users/oms4suse/followers","following_url":"https://api.github.com/users/oms4suse/following{/other_user}","gists_url":"https://api.github.com/users/oms4suse/gists{/gist_id}","starred_url":"https://api.github.com/users/oms4suse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oms4suse/subscriptions","organizations_url":"https://api.github.com/users/oms4suse/orgs","repos_url":"https://api.github.com/users/oms4suse/repos","events_url":"https://api.github.com/users/oms4suse/events{/privacy}","received_events_url":"https://api.github.com/users/oms4suse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oms4suse/sesceph","description":"Simple API to help deploying ceph with salt or without","fork":false,"url":"https://api.github.com/repos/oms4suse/sesceph","forks_url":"https://api.github.com/repos/oms4suse/sesceph/forks","keys_url":"https://api.github.com/repos/oms4suse/sesceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oms4suse/sesceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oms4suse/sesceph/teams","hooks_url":"https://api.github.com/repos/oms4suse/sesceph/hooks","issue_events_url":"https://api.github.com/repos/oms4suse/sesceph/issues/events{/number}","events_url":"https://api.github.com/repos/oms4suse/sesceph/events","assignees_url":"https://api.github.com/repos/oms4suse/sesceph/assignees{/user}","branches_url":"https://api.github.com/repos/oms4suse/sesceph/branches{/branch}","tags_url":"https://api.github.com/repos/oms4suse/sesceph/tags","blobs_url":"https://api.github.com/repos/oms4suse/sesceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oms4suse/sesceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oms4suse/sesceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/oms4suse/sesceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oms4suse/sesceph/statuses/{sha}","languages_url":"https://api.github.com/repos/oms4suse/sesceph/languages","stargazers_url":"https://api.github.com/repos/oms4suse/sesceph/stargazers","contributors_url":"https://api.github.com/repos/oms4suse/sesceph/contributors","subscribers_url":"https://api.github.com/repos/oms4suse/sesceph/subscribers","subscription_url":"https://api.github.com/repos/oms4suse/sesceph/subscription","commits_url":"https://api.github.com/repos/oms4suse/sesceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/oms4suse/sesceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/oms4suse/sesceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/oms4suse/sesceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/oms4suse/sesceph/contents/{+path}","compare_url":"https://api.github.com/repos/oms4suse/sesceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oms4suse/sesceph/merges","archive_url":"https://api.github.com/repos/oms4suse/sesceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oms4suse/sesceph/downloads","issues_url":"https://api.github.com/repos/oms4suse/sesceph/issues{/number}","pulls_url":"https://api.github.com/repos/oms4suse/sesceph/pulls{/number}","milestones_url":"https://api.github.com/repos/oms4suse/sesceph/milestones{/number}","notifications_url":"https://api.github.com/repos/oms4suse/sesceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oms4suse/sesceph/labels{/name}","releases_url":"https://api.github.com/repos/oms4suse/sesceph/releases{/id}","deployments_url":"https://api.github.com/repos/oms4suse/sesceph/deployments","created_at":"2016-02-10T11:28:29Z","updated_at":"2016-02-24T10:07:08Z","pushed_at":"2016-03-29T13:09:58Z","git_url":"git://github.com/oms4suse/sesceph.git","ssh_url":"git@github.com:oms4suse/sesceph.git","clone_url":"https://github.com/oms4suse/sesceph.git","svn_url":"https://github.com/oms4suse/sesceph","homepage":null,"size":203,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"oms4suse:master","ref":"master","sha":"740ed332915d9a35e1915d300821c24c415c407a","user":{"login":"oms4suse","id":14092619,"avatar_url":"https://avatars.githubusercontent.com/u/14092619?v=3","gravatar_id":"","url":"https://api.github.com/users/oms4suse","html_url":"https://github.com/oms4suse","followers_url":"https://api.github.com/users/oms4suse/followers","following_url":"https://api.github.com/users/oms4suse/following{/other_user}","gists_url":"https://api.github.com/users/oms4suse/gists{/gist_id}","starred_url":"https://api.github.com/users/oms4suse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oms4suse/subscriptions","organizations_url":"https://api.github.com/users/oms4suse/orgs","repos_url":"https://api.github.com/users/oms4suse/repos","events_url":"https://api.github.com/users/oms4suse/events{/privacy}","received_events_url":"https://api.github.com/users/oms4suse/received_events","type":"User","site_admin":false},"repo":{"id":51437111,"name":"sesceph","full_name":"oms4suse/sesceph","owner":{"login":"oms4suse","id":14092619,"avatar_url":"https://avatars.githubusercontent.com/u/14092619?v=3","gravatar_id":"","url":"https://api.github.com/users/oms4suse","html_url":"https://github.com/oms4suse","followers_url":"https://api.github.com/users/oms4suse/followers","following_url":"https://api.github.com/users/oms4suse/following{/other_user}","gists_url":"https://api.github.com/users/oms4suse/gists{/gist_id}","starred_url":"https://api.github.com/users/oms4suse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oms4suse/subscriptions","organizations_url":"https://api.github.com/users/oms4suse/orgs","repos_url":"https://api.github.com/users/oms4suse/repos","events_url":"https://api.github.com/users/oms4suse/events{/privacy}","received_events_url":"https://api.github.com/users/oms4suse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oms4suse/sesceph","description":"Simple API to help deploying ceph with salt or without","fork":false,"url":"https://api.github.com/repos/oms4suse/sesceph","forks_url":"https://api.github.com/repos/oms4suse/sesceph/forks","keys_url":"https://api.github.com/repos/oms4suse/sesceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oms4suse/sesceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oms4suse/sesceph/teams","hooks_url":"https://api.github.com/repos/oms4suse/sesceph/hooks","issue_events_url":"https://api.github.com/repos/oms4suse/sesceph/issues/events{/number}","events_url":"https://api.github.com/repos/oms4suse/sesceph/events","assignees_url":"https://api.github.com/repos/oms4suse/sesceph/assignees{/user}","branches_url":"https://api.github.com/repos/oms4suse/sesceph/branches{/branch}","tags_url":"https://api.github.com/repos/oms4suse/sesceph/tags","blobs_url":"https://api.github.com/repos/oms4suse/sesceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oms4suse/sesceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oms4suse/sesceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/oms4suse/sesceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oms4suse/sesceph/statuses/{sha}","languages_url":"https://api.github.com/repos/oms4suse/sesceph/languages","stargazers_url":"https://api.github.com/repos/oms4suse/sesceph/stargazers","contributors_url":"https://api.github.com/repos/oms4suse/sesceph/contributors","subscribers_url":"https://api.github.com/repos/oms4suse/sesceph/subscribers","subscription_url":"https://api.github.com/repos/oms4suse/sesceph/subscription","commits_url":"https://api.github.com/repos/oms4suse/sesceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/oms4suse/sesceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/oms4suse/sesceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/oms4suse/sesceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/oms4suse/sesceph/contents/{+path}","compare_url":"https://api.github.com/repos/oms4suse/sesceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oms4suse/sesceph/merges","archive_url":"https://api.github.com/repos/oms4suse/sesceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oms4suse/sesceph/downloads","issues_url":"https://api.github.com/repos/oms4suse/sesceph/issues{/number}","pulls_url":"https://api.github.com/repos/oms4suse/sesceph/pulls{/number}","milestones_url":"https://api.github.com/repos/oms4suse/sesceph/milestones{/number}","notifications_url":"https://api.github.com/repos/oms4suse/sesceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oms4suse/sesceph/labels{/name}","releases_url":"https://api.github.com/repos/oms4suse/sesceph/releases{/id}","deployments_url":"https://api.github.com/repos/oms4suse/sesceph/deployments","created_at":"2016-02-10T11:28:29Z","updated_at":"2016-02-24T10:07:08Z","pushed_at":"2016-03-29T13:09:58Z","git_url":"git://github.com/oms4suse/sesceph.git","ssh_url":"git@github.com:oms4suse/sesceph.git","clone_url":"https://github.com/oms4suse/sesceph.git","svn_url":"https://github.com/oms4suse/sesceph","homepage":null,"size":203,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oms4suse/sesceph/pulls/21"},"html":{"href":"https://github.com/oms4suse/sesceph/pull/21"},"issue":{"href":"https://api.github.com/repos/oms4suse/sesceph/issues/21"},"comments":{"href":"https://api.github.com/repos/oms4suse/sesceph/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/oms4suse/sesceph/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/oms4suse/sesceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oms4suse/sesceph/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/oms4suse/sesceph/statuses/025abc0100f957c98657836fa21ec88923ffc9b0"}}}}