{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/86046838","pull_request_review_id":6725547,"id":86046838,"diff_hunk":"@@ -213,6 +249,28 @@ long RecordingManager::getFileSplitSize()\n          return SIZE_2GB;\n      else if(fileSizeStr == SPLIT_4096MB)\n          return SIZE_4GB;\n+     else if(fileSizeStr == SPLIT_60MIN)\n+         return SIZE_4GB; //Ignore size limit. use time limit\n+     else if(fileSizeStr == SPLIT_74MIN)\n+         return SIZE_4GB; //Ignore size limit. use time limit\n+     else if(fileSizeStr == SPLIT_80MIN)\n+         return SIZE_4GB; //Ignore size limit. use time limit\n+     else if(fileSizeStr == SPLIT_120MIN)\n+         return SIZE_4GB; //Ignore size limit. use time limit\n      else\n          return SIZE_650MB;\n }\n+long RecordingManager::getFileSplitTime()\n+{\n+    QString fileSizeStr = m_pConfig->getValueString(ConfigKey(RECORDING_PREF_KEY, \"FileSize\"));\n+    if(fileSizeStr == SPLIT_60MIN)\n+        return 60*60;\n+    else if(fileSizeStr == SPLIT_74MIN)\n+        return 74*60;\n+    else if(fileSizeStr == SPLIT_80MIN)\n+        return 80*60;\n+    else if(fileSizeStr == SPLIT_120MIN)\n+        return 120*60;\n+    else // Do not limit by time for the rest.\n+        return 999999999;","path":"src/recording/recordingmanager.cpp","position":176,"original_position":176,"commit_id":"53ef61b579bcc1ff53d49e0ce63a84bb20df7503","original_commit_id":"53ef61b579bcc1ff53d49e0ce63a84bb20df7503","user":{"login":"JosepMaJAZ","id":9913727,"avatar_url":"https://avatars.githubusercontent.com/u/9913727?v=3","gravatar_id":"","url":"https://api.github.com/users/JosepMaJAZ","html_url":"https://github.com/JosepMaJAZ","followers_url":"https://api.github.com/users/JosepMaJAZ/followers","following_url":"https://api.github.com/users/JosepMaJAZ/following{/other_user}","gists_url":"https://api.github.com/users/JosepMaJAZ/gists{/gist_id}","starred_url":"https://api.github.com/users/JosepMaJAZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosepMaJAZ/subscriptions","organizations_url":"https://api.github.com/users/JosepMaJAZ/orgs","repos_url":"https://api.github.com/users/JosepMaJAZ/repos","events_url":"https://api.github.com/users/JosepMaJAZ/events{/privacy}","received_events_url":"https://api.github.com/users/JosepMaJAZ/received_events","type":"User","site_admin":false},"body":"Yes and no. Maybe for the method, but not for the comparison. If I were to use -1 (or 0, which is what I initially wanted to use), then the if ( x > split_time ) would need to be if ( split_time != -1 && x > split_time).\r\nSure, this way it is not really unlimited, and the method is only called once each second, but I would prefer the simpler if.","created_at":"2016-11-01T23:26:09Z","updated_at":"2016-11-01T23:26:09Z","html_url":"https://github.com/mixxxdj/mixxx/pull/1035#discussion_r86046838","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1035","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/86046838"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1035#discussion_r86046838"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1035"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1035","id":91715769,"html_url":"https://github.com/mixxxdj/mixxx/pull/1035","diff_url":"https://github.com/mixxxdj/mixxx/pull/1035.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1035.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1035","number":1035,"state":"open","locked":false,"title":"Various fixes and additions related to recording the mix to a file","user":{"login":"JosepMaJAZ","id":9913727,"avatar_url":"https://avatars.githubusercontent.com/u/9913727?v=3","gravatar_id":"","url":"https://api.github.com/users/JosepMaJAZ","html_url":"https://github.com/JosepMaJAZ","followers_url":"https://api.github.com/users/JosepMaJAZ/followers","following_url":"https://api.github.com/users/JosepMaJAZ/following{/other_user}","gists_url":"https://api.github.com/users/JosepMaJAZ/gists{/gist_id}","starred_url":"https://api.github.com/users/JosepMaJAZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosepMaJAZ/subscriptions","organizations_url":"https://api.github.com/users/JosepMaJAZ/orgs","repos_url":"https://api.github.com/users/JosepMaJAZ/repos","events_url":"https://api.github.com/users/JosepMaJAZ/events{/privacy}","received_events_url":"https://api.github.com/users/JosepMaJAZ/received_events","type":"User","site_admin":false},"body":"launchpad bugs:\r\n\r\n#1637786 : Note: this one requires fixing the compilation of libsndfile, at least on windows (config.h, CPU_CLIPS_NEGATIVE)\r\n#1415758\r\n#1605921\r\n#1605923\r\n#1638115\r\n#1638120\r\n#1605922\r\n#1415720","created_at":"2016-11-01T00:31:14Z","updated_at":"2016-11-01T23:26:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94c039a8669c6e64ea21f622000c3d4a1c762860","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1035/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1035/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1035/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/53ef61b579bcc1ff53d49e0ce63a84bb20df7503","head":{"label":"JosepMaJAZ:fix-clip-recording","ref":"fix-clip-recording","sha":"53ef61b579bcc1ff53d49e0ce63a84bb20df7503","user":{"login":"JosepMaJAZ","id":9913727,"avatar_url":"https://avatars.githubusercontent.com/u/9913727?v=3","gravatar_id":"","url":"https://api.github.com/users/JosepMaJAZ","html_url":"https://github.com/JosepMaJAZ","followers_url":"https://api.github.com/users/JosepMaJAZ/followers","following_url":"https://api.github.com/users/JosepMaJAZ/following{/other_user}","gists_url":"https://api.github.com/users/JosepMaJAZ/gists{/gist_id}","starred_url":"https://api.github.com/users/JosepMaJAZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosepMaJAZ/subscriptions","organizations_url":"https://api.github.com/users/JosepMaJAZ/orgs","repos_url":"https://api.github.com/users/JosepMaJAZ/repos","events_url":"https://api.github.com/users/JosepMaJAZ/events{/privacy}","received_events_url":"https://api.github.com/users/JosepMaJAZ/received_events","type":"User","site_admin":false},"repo":{"id":47928817,"name":"mixxx","full_name":"JosepMaJAZ/mixxx","owner":{"login":"JosepMaJAZ","id":9913727,"avatar_url":"https://avatars.githubusercontent.com/u/9913727?v=3","gravatar_id":"","url":"https://api.github.com/users/JosepMaJAZ","html_url":"https://github.com/JosepMaJAZ","followers_url":"https://api.github.com/users/JosepMaJAZ/followers","following_url":"https://api.github.com/users/JosepMaJAZ/following{/other_user}","gists_url":"https://api.github.com/users/JosepMaJAZ/gists{/gist_id}","starred_url":"https://api.github.com/users/JosepMaJAZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosepMaJAZ/subscriptions","organizations_url":"https://api.github.com/users/JosepMaJAZ/orgs","repos_url":"https://api.github.com/users/JosepMaJAZ/repos","events_url":"https://api.github.com/users/JosepMaJAZ/events{/privacy}","received_events_url":"https://api.github.com/users/JosepMaJAZ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JosepMaJAZ/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/JosepMaJAZ/mixxx","forks_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/forks","keys_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/teams","hooks_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/hooks","issue_events_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/events","assignees_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/tags","blobs_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/languages","stargazers_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/stargazers","contributors_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/contributors","subscribers_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/subscribers","subscription_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/subscription","commits_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/merges","archive_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/downloads","issues_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/JosepMaJAZ/mixxx/deployments","created_at":"2015-12-13T17:20:51Z","updated_at":"2016-09-22T18:02:33Z","pushed_at":"2016-11-01T11:49:25Z","git_url":"git://github.com/JosepMaJAZ/mixxx.git","ssh_url":"git@github.com:JosepMaJAZ/mixxx.git","clone_url":"https://github.com/JosepMaJAZ/mixxx.git","svn_url":"https://github.com/JosepMaJAZ/mixxx","homepage":"http://mixxx.org","size":259747,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"f1cab2a5598ad86550ce4320e16c0d528c93670b","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2016-10-29T18:14:04Z","pushed_at":"2016-11-01T19:35:38Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":277607,"stargazers_count":604,"watchers_count":604,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":365,"mirror_url":null,"open_issues_count":75,"forks":365,"open_issues":75,"watchers":604,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1035"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1035"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1035"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1035/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1035/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1035/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/53ef61b579bcc1ff53d49e0ce63a84bb20df7503"}}}}
{"actor":{"display_login":"JosepMaJAZ"}}