{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/phobos/pulls/comments/92972496","pull_request_review_id":13493222,"id":92972496,"diff_hunk":"@@ -4852,37 +4905,101 @@ private struct UniqResult(alias pred, Range)\n     void popFront()\n     {\n         assert(!empty, \"Attempting to popFront an empty uniq.\");\n-        auto last = _input.front;\n-        do\n+        if (_input.empty)\n         {\n-            _input.popFront();\n+            _isInFront = false;\n+            static if (isBidirectionalRange!Range)\n+            {\n+                if (_isOverlapping)\n+                {\n+                    _isInBack = false;","path":"std/algorithm/iteration.d","position":101,"original_position":101,"commit_id":"a502b2a254a814aaf68927d07d59baa8ba87dd8f","original_commit_id":"a502b2a254a814aaf68927d07d59baa8ba87dd8f","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"uncovered","created_at":"2016-12-19T06:08:59Z","updated_at":"2016-12-19T06:20:28Z","html_url":"https://github.com/dlang/phobos/pull/4961#discussion_r92972496","pull_request_url":"https://api.github.com/repos/dlang/phobos/pulls/4961","_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments/92972496"},"html":{"href":"https://github.com/dlang/phobos/pull/4961#discussion_r92972496"},"pull_request":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4961"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/4961","id":98359766,"html_url":"https://github.com/dlang/phobos/pull/4961","diff_url":"https://github.com/dlang/phobos/pull/4961.diff","patch_url":"https://github.com/dlang/phobos/pull/4961.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/4961","number":4961,"state":"open","locked":false,"title":"Fix issue 16588 - uniqs BidirectionalRange behavior is inconsistent w…","user":{"login":"edi33416","id":3812633,"avatar_url":"https://avatars.githubusercontent.com/u/3812633?v=3","gravatar_id":"","url":"https://api.github.com/users/edi33416","html_url":"https://github.com/edi33416","followers_url":"https://api.github.com/users/edi33416/followers","following_url":"https://api.github.com/users/edi33416/following{/other_user}","gists_url":"https://api.github.com/users/edi33416/gists{/gist_id}","starred_url":"https://api.github.com/users/edi33416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edi33416/subscriptions","organizations_url":"https://api.github.com/users/edi33416/orgs","repos_url":"https://api.github.com/users/edi33416/repos","events_url":"https://api.github.com/users/edi33416/events{/privacy}","received_events_url":"https://api.github.com/users/edi33416/received_events","type":"User","site_admin":false},"body":"…ith its InputRange behavior\r\n\r\nhttps://issues.dlang.org/show_bug.cgi?id=16588","created_at":"2016-12-16T16:07:27Z","updated_at":"2016-12-19T06:20:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e37c7c4c9da187294ac7bda617b7f0ae1f21b7ef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/4961/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/4961/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/4961/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/a502b2a254a814aaf68927d07d59baa8ba87dd8f","head":{"label":"edi33416:uniq_consistency","ref":"uniq_consistency","sha":"a502b2a254a814aaf68927d07d59baa8ba87dd8f","user":{"login":"edi33416","id":3812633,"avatar_url":"https://avatars.githubusercontent.com/u/3812633?v=3","gravatar_id":"","url":"https://api.github.com/users/edi33416","html_url":"https://github.com/edi33416","followers_url":"https://api.github.com/users/edi33416/followers","following_url":"https://api.github.com/users/edi33416/following{/other_user}","gists_url":"https://api.github.com/users/edi33416/gists{/gist_id}","starred_url":"https://api.github.com/users/edi33416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edi33416/subscriptions","organizations_url":"https://api.github.com/users/edi33416/orgs","repos_url":"https://api.github.com/users/edi33416/repos","events_url":"https://api.github.com/users/edi33416/events{/privacy}","received_events_url":"https://api.github.com/users/edi33416/received_events","type":"User","site_admin":false},"repo":{"id":73472663,"name":"phobos","full_name":"edi33416/phobos","owner":{"login":"edi33416","id":3812633,"avatar_url":"https://avatars.githubusercontent.com/u/3812633?v=3","gravatar_id":"","url":"https://api.github.com/users/edi33416","html_url":"https://github.com/edi33416","followers_url":"https://api.github.com/users/edi33416/followers","following_url":"https://api.github.com/users/edi33416/following{/other_user}","gists_url":"https://api.github.com/users/edi33416/gists{/gist_id}","starred_url":"https://api.github.com/users/edi33416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edi33416/subscriptions","organizations_url":"https://api.github.com/users/edi33416/orgs","repos_url":"https://api.github.com/users/edi33416/repos","events_url":"https://api.github.com/users/edi33416/events{/privacy}","received_events_url":"https://api.github.com/users/edi33416/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edi33416/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/edi33416/phobos","forks_url":"https://api.github.com/repos/edi33416/phobos/forks","keys_url":"https://api.github.com/repos/edi33416/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edi33416/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edi33416/phobos/teams","hooks_url":"https://api.github.com/repos/edi33416/phobos/hooks","issue_events_url":"https://api.github.com/repos/edi33416/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/edi33416/phobos/events","assignees_url":"https://api.github.com/repos/edi33416/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/edi33416/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/edi33416/phobos/tags","blobs_url":"https://api.github.com/repos/edi33416/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edi33416/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edi33416/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/edi33416/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edi33416/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/edi33416/phobos/languages","stargazers_url":"https://api.github.com/repos/edi33416/phobos/stargazers","contributors_url":"https://api.github.com/repos/edi33416/phobos/contributors","subscribers_url":"https://api.github.com/repos/edi33416/phobos/subscribers","subscription_url":"https://api.github.com/repos/edi33416/phobos/subscription","commits_url":"https://api.github.com/repos/edi33416/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/edi33416/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/edi33416/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/edi33416/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/edi33416/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/edi33416/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edi33416/phobos/merges","archive_url":"https://api.github.com/repos/edi33416/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edi33416/phobos/downloads","issues_url":"https://api.github.com/repos/edi33416/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/edi33416/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/edi33416/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/edi33416/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edi33416/phobos/labels{/name}","releases_url":"https://api.github.com/repos/edi33416/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/edi33416/phobos/deployments","created_at":"2016-11-11T11:34:18Z","updated_at":"2016-11-11T11:34:22Z","pushed_at":"2016-12-16T16:05:54Z","git_url":"git://github.com/edi33416/phobos.git","ssh_url":"git@github.com:edi33416/phobos.git","clone_url":"https://github.com/edi33416/phobos.git","svn_url":"https://github.com/edi33416/phobos","homepage":"dlang.org/phobos","size":47678,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"f3a840144a156fce5efee82ca13152c2ac1ef1c3","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"dlang/phobos","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2016-12-17T02:47:12Z","pushed_at":"2016-12-19T05:37:23Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":47717,"stargazers_count":761,"watchers_count":761,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":524,"mirror_url":null,"open_issues_count":86,"forks":524,"open_issues":86,"watchers":761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4961"},"html":{"href":"https://github.com/dlang/phobos/pull/4961"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/4961"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/4961/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4961/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4961/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/a502b2a254a814aaf68927d07d59baa8ba87dd8f"}}}}
{"actor":{"display_login":"wilzbach"}}