{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/55941142","id":55941142,"diff_hunk":"@@ -0,0 +1,51 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ * <p/>\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ * <p/>\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package org.apache.storm.hbase.trident.windowing;\n+\n+import org.apache.hadoop.conf.Configuration;\n+import org.apache.hadoop.hbase.HBaseConfiguration;\n+import org.apache.storm.trident.windowing.WindowsStore;\n+import org.apache.storm.trident.windowing.WindowsStoreFactory;\n+\n+import java.util.Map;\n+\n+public class HBaseWindowsStoreFactory implements WindowsStoreFactory {\n+    private final Map<String, Object> config;\n+    private final String tableName;\n+    private final byte[] family;\n+    private final byte[] qualifier;\n+\n+    public HBaseWindowsStoreFactory(Map<String, Object> config, String tableName, byte[] family, byte[] qualifier) {","path":"external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStoreFactory.java","position":34,"original_position":34,"commit_id":"d6552513904c1c610425596b91152c6ae6d116b7","original_commit_id":"4faef1ef475bdb8c55b738525b5130fa3b35ea04","user":{"login":"harshach","id":38649,"avatar_url":"https://avatars.githubusercontent.com/u/38649?v=3","gravatar_id":"","url":"https://api.github.com/users/harshach","html_url":"https://github.com/harshach","followers_url":"https://api.github.com/users/harshach/followers","following_url":"https://api.github.com/users/harshach/following{/other_user}","gists_url":"https://api.github.com/users/harshach/gists{/gist_id}","starred_url":"https://api.github.com/users/harshach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshach/subscriptions","organizations_url":"https://api.github.com/users/harshach/orgs","repos_url":"https://api.github.com/users/harshach/repos","events_url":"https://api.github.com/users/harshach/events{/privacy}","received_events_url":"https://api.github.com/users/harshach/received_events","type":"User","site_admin":false},"body":"@satishd isn't table name, cf are specific to Hbase. In that case a config method can take a map and do its validation and this validation will specific to HbaseWindowStoreFactory","created_at":"2016-03-13T18:09:35Z","updated_at":"2016-03-13T18:09:35Z","html_url":"https://github.com/apache/storm/pull/1072#discussion_r55941142","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/1072","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/55941142"},"html":{"href":"https://github.com/apache/storm/pull/1072#discussion_r55941142"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/1072"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/1072","id":58175455,"html_url":"https://github.com/apache/storm/pull/1072","diff_url":"https://github.com/apache/storm/pull/1072.diff","patch_url":"https://github.com/apache/storm/pull/1072.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/1072","number":1072,"state":"open","locked":false,"title":"STORM-676 Trident implementation for sliding and tumbling windows.","user":{"login":"satishd","id":2577761,"avatar_url":"https://avatars.githubusercontent.com/u/2577761?v=3","gravatar_id":"","url":"https://api.github.com/users/satishd","html_url":"https://github.com/satishd","followers_url":"https://api.github.com/users/satishd/followers","following_url":"https://api.github.com/users/satishd/following{/other_user}","gists_url":"https://api.github.com/users/satishd/gists{/gist_id}","starred_url":"https://api.github.com/users/satishd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satishd/subscriptions","organizations_url":"https://api.github.com/users/satishd/orgs","repos_url":"https://api.github.com/users/satishd/repos","events_url":"https://api.github.com/users/satishd/events{/privacy}","received_events_url":"https://api.github.com/users/satishd/received_events","type":"User","site_admin":false},"body":"This PR adds windowing support in a trident stream.\r\n\r\n- Added support of sliding and tumbling windows based on count of tuples and duration through window operations on stream.\r\n- This functionality uses a WindowsStore implementation which stores tuples, and aggregated results.\r\n- HBase store provider is implemented. It can be enhanced with user configuration or extending the basic implementation. Other providers can be added by implementing the required interfaces.\r\n- More details can be found at\r\n\r\n    - https://issues.apache.org/jira/browse/STORM-676\r\n    - https://issues.apache.org/jira/secure/attachment/12780751/StormTrident_windowing_support-676.pdf","created_at":"2016-02-03T17:57:05Z","updated_at":"2016-03-13T18:09:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe3760b85e7ce6c5ea993314530e6cf154a51465","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/1072/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/1072/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/1072/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/d6552513904c1c610425596b91152c6ae6d116b7","head":{"label":"satishd:STORM-676","ref":"STORM-676","sha":"d6552513904c1c610425596b91152c6ae6d116b7","user":{"login":"satishd","id":2577761,"avatar_url":"https://avatars.githubusercontent.com/u/2577761?v=3","gravatar_id":"","url":"https://api.github.com/users/satishd","html_url":"https://github.com/satishd","followers_url":"https://api.github.com/users/satishd/followers","following_url":"https://api.github.com/users/satishd/following{/other_user}","gists_url":"https://api.github.com/users/satishd/gists{/gist_id}","starred_url":"https://api.github.com/users/satishd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satishd/subscriptions","organizations_url":"https://api.github.com/users/satishd/orgs","repos_url":"https://api.github.com/users/satishd/repos","events_url":"https://api.github.com/users/satishd/events{/privacy}","received_events_url":"https://api.github.com/users/satishd/received_events","type":"User","site_admin":false},"repo":{"id":41480044,"name":"storm","full_name":"satishd/storm","owner":{"login":"satishd","id":2577761,"avatar_url":"https://avatars.githubusercontent.com/u/2577761?v=3","gravatar_id":"","url":"https://api.github.com/users/satishd","html_url":"https://github.com/satishd","followers_url":"https://api.github.com/users/satishd/followers","following_url":"https://api.github.com/users/satishd/following{/other_user}","gists_url":"https://api.github.com/users/satishd/gists{/gist_id}","starred_url":"https://api.github.com/users/satishd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satishd/subscriptions","organizations_url":"https://api.github.com/users/satishd/orgs","repos_url":"https://api.github.com/users/satishd/repos","events_url":"https://api.github.com/users/satishd/events{/privacy}","received_events_url":"https://api.github.com/users/satishd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/satishd/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/satishd/storm","forks_url":"https://api.github.com/repos/satishd/storm/forks","keys_url":"https://api.github.com/repos/satishd/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/satishd/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/satishd/storm/teams","hooks_url":"https://api.github.com/repos/satishd/storm/hooks","issue_events_url":"https://api.github.com/repos/satishd/storm/issues/events{/number}","events_url":"https://api.github.com/repos/satishd/storm/events","assignees_url":"https://api.github.com/repos/satishd/storm/assignees{/user}","branches_url":"https://api.github.com/repos/satishd/storm/branches{/branch}","tags_url":"https://api.github.com/repos/satishd/storm/tags","blobs_url":"https://api.github.com/repos/satishd/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/satishd/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/satishd/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/satishd/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/satishd/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/satishd/storm/languages","stargazers_url":"https://api.github.com/repos/satishd/storm/stargazers","contributors_url":"https://api.github.com/repos/satishd/storm/contributors","subscribers_url":"https://api.github.com/repos/satishd/storm/subscribers","subscription_url":"https://api.github.com/repos/satishd/storm/subscription","commits_url":"https://api.github.com/repos/satishd/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/satishd/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/satishd/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/satishd/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/satishd/storm/contents/{+path}","compare_url":"https://api.github.com/repos/satishd/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/satishd/storm/merges","archive_url":"https://api.github.com/repos/satishd/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/satishd/storm/downloads","issues_url":"https://api.github.com/repos/satishd/storm/issues{/number}","pulls_url":"https://api.github.com/repos/satishd/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/satishd/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/satishd/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/satishd/storm/labels{/name}","releases_url":"https://api.github.com/repos/satishd/storm/releases{/id}","deployments_url":"https://api.github.com/repos/satishd/storm/deployments","created_at":"2015-08-27T10:17:31Z","updated_at":"2016-01-17T07:52:14Z","pushed_at":"2016-03-13T05:57:00Z","git_url":"git://github.com/satishd/storm.git","ssh_url":"git@github.com:satishd/storm.git","clone_url":"https://github.com/satishd/storm.git","svn_url":"https://github.com/satishd/storm","homepage":null,"size":101470,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c2cf3befce15ed79e41c1c02752f168194e9a1bf","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","deployments_url":"https://api.github.com/repos/apache/storm/deployments","created_at":"2013-11-05T08:00:14Z","updated_at":"2016-03-13T13:52:28Z","pushed_at":"2016-03-13T13:16:45Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":162488,"stargazers_count":2935,"watchers_count":2935,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2210,"mirror_url":"git://git.apache.org/storm.git","open_issues_count":88,"forks":2210,"open_issues":88,"watchers":2935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/1072"},"html":{"href":"https://github.com/apache/storm/pull/1072"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/1072"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/1072/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/1072/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/1072/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/d6552513904c1c610425596b91152c6ae6d116b7"}}}}