{"action":"created","issue":{"url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1367","labels_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1367/labels{/name}","comments_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1367/comments","events_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1367/events","html_url":"https://github.com/KSP-KOS/KOS/issues/1367","id":126313076,"number":1367,"title":"ORBITAT provides incorrect position/velocity/true anomaly","user":{"login":"johnwhall","id":8600352,"avatar_url":"https://avatars.githubusercontent.com/u/8600352?v=3","gravatar_id":"","url":"https://api.github.com/users/johnwhall","html_url":"https://github.com/johnwhall","followers_url":"https://api.github.com/users/johnwhall/followers","following_url":"https://api.github.com/users/johnwhall/following{/other_user}","gists_url":"https://api.github.com/users/johnwhall/gists{/gist_id}","starred_url":"https://api.github.com/users/johnwhall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnwhall/subscriptions","organizations_url":"https://api.github.com/users/johnwhall/orgs","repos_url":"https://api.github.com/users/johnwhall/repos","events_url":"https://api.github.com/users/johnwhall/events{/privacy}","received_events_url":"https://api.github.com/users/johnwhall/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/KSP-KOS/KOS/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/KSP-KOS/KOS/labels/discussion","name":"discussion","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-01-13T00:45:28Z","updated_at":"2016-01-15T02:10:49Z","closed_at":null,"body":"It returns the current position/velocity/true anomaly instead.\r\n\r\n```\r\nprint ship:orbit:position.\r\n// V(-92.5506564583629, 45.2189588607289, 115.282503618859)\r\nprint orbitat(ship, time:seconds + 60):position.\r\n// V(-92.5506564583629, 45.2189588607289, 115.282503618859)\r\n\r\nprint ship:orbit:velocity.\r\n// OrbitableVelocity(\r\n//  :orbit=V(-5448.34433373436, 2743.37341503479, 4748.02053736287),\r\n//  :surface=V(-5063.84820051011, 2743.37341503479, 4490.41164308264)\r\nprint orbitat(ship, time:seconds + 60):velocity.\r\n// OrbitableVelocity(\r\n//  :orbit=V(-5448.34433373436, 2743.37341503479, 4748.02053736287),\r\n//  :surface=V(-5063.84820051011, 2743.37341503479, 4490.41164308264)\r\n\r\nprint ship:orbit:trueanomaly.\r\n// 226.956461984762\r\nprint orbitat(ship, time:seconds + 60):trueanomaly.\r\n// 226.956461984762\r\n```\r\n\r\n(and the orbital period wasn't 60 seconds)"},"comment":{"url":"https://api.github.com/repos/KSP-KOS/KOS/issues/comments/171847931","html_url":"https://github.com/KSP-KOS/KOS/issues/1367#issuecomment-171847931","issue_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1367","id":171847931,"user":{"login":"Dunbaratu","id":5216848,"avatar_url":"https://avatars.githubusercontent.com/u/5216848?v=3","gravatar_id":"","url":"https://api.github.com/users/Dunbaratu","html_url":"https://github.com/Dunbaratu","followers_url":"https://api.github.com/users/Dunbaratu/followers","following_url":"https://api.github.com/users/Dunbaratu/following{/other_user}","gists_url":"https://api.github.com/users/Dunbaratu/gists{/gist_id}","starred_url":"https://api.github.com/users/Dunbaratu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dunbaratu/subscriptions","organizations_url":"https://api.github.com/users/Dunbaratu/orgs","repos_url":"https://api.github.com/users/Dunbaratu/repos","events_url":"https://api.github.com/users/Dunbaratu/events{/privacy}","received_events_url":"https://api.github.com/users/Dunbaratu/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T02:10:49Z","updated_at":"2016-01-15T02:10:49Z","body":"The base KSP API contains values in it for the orbit object that are time dependant: altitude, trueanomaly, etc.  If that's bogus and it's actually returning values that are bull about those things, then kOS\"s version of that is returning it at a frozen time rather than the current time, then that's where the fix needs to go.  We should calculate the correct time-dependant values and return them instead of KSP's own values if KSP's values are a lie.\r\n"}}