{"push_id":1370196182,"size":1,"distinct_size":1,"ref":"refs/heads/ProxyFilterRemoveAttributeBug","head":"3d7cb62b83390ba492463b68b2c5dab60e29627f","before":"4a7052fad8129044cf2eb0d0f0e14006b666471f","commits":[{"sha":"3d7cb62b83390ba492463b68b2c5dab60e29627f","author":{"name":"Johan Andruejol","email":"9b84a5050d4f57372f7fc706d06af5e46b92fc3a@kitware.com"},"message":"BUG: Fix issue with qMRMLNodeComboBox when removing an attribute filter\n\nSince QHash [] operator inserts a default-constructed value into the map\nif the key is not found and because the [] operator was systematically\nused, removing an attribute filter could lead the combobox to never show\nanything.\n\nThe bug was as follow in pseudo-code:\n combobox = slicer.qMRMLComboBox()\n combobox.removeAttribute('vtkMRMLVolumeNode', 'MyAttribute')\n-> Because of the [] operator, the map now has an entry for\n'vtkMRMLVolumeNode' with nothing in it. It now expects nodes to have that\nattribute declared (and it can have any value though).\n\nThe fix is to not use the [] operator when accessing values simply for\nreading but to use the value() method instead.\n\nAdded a test along to make sure everything works properly.","distinct":true,"url":"https://api.github.com/repos/Slicer/Slicer/commits/3d7cb62b83390ba492463b68b2c5dab60e29627f"}]}
{"actor":{"display_login":"vovythevov"}}