{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/Spelt/ZXing.Delphi/pulls/39","id":83257248,"html_url":"https://github.com/Spelt/ZXing.Delphi/pull/39","diff_url":"https://github.com/Spelt/ZXing.Delphi/pull/39.diff","patch_url":"https://github.com/Spelt/ZXing.Delphi/pull/39.patch","issue_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/issues/39","number":39,"state":"closed","locked":false,"title":"utf8 text in qrcodes was not handled properly","user":{"login":"csm101","id":5736859,"avatar_url":"https://avatars.githubusercontent.com/u/5736859?v=3","gravatar_id":"","url":"https://api.github.com/users/csm101","html_url":"https://github.com/csm101","followers_url":"https://api.github.com/users/csm101/followers","following_url":"https://api.github.com/users/csm101/following{/other_user}","gists_url":"https://api.github.com/users/csm101/gists{/gist_id}","starred_url":"https://api.github.com/users/csm101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csm101/subscriptions","organizations_url":"https://api.github.com/users/csm101/orgs","repos_url":"https://api.github.com/users/csm101/repos","events_url":"https://api.github.com/users/csm101/events{/privacy}","received_events_url":"https://api.github.com/users/csm101/received_events","type":"User","site_admin":false},"body":"I created a barcode containing utf8 characters taken from both the cyrillic and european charset (to be sure that they can't be all casted to ansi characters without seeing any data loss: your ansi charset can show only one of the two), and I added this barcode to the unit tests.\r\n\r\n The test was failing: the string was surely being casted to a 8 bit ansi charset, losing any character that can't be represented in the local 8 bit charset (as I suspected this would happen because there was a compiler warning about this happening). the warining was in in TReadResult.SetText.\r\n\r\n The suspiscious code was the call to UTF8ToString(AValue) before setting the FText value.\r\n\r\n I put a breakpoint there and I did see that AValue was already containing te correct unicode string with all the characters I was expecting to read from the QR-CODE, so there was no need to do any conversion.\r\n\r\n Surely the directly Assigning AValue to FText, without any transformation solved the bug under Win32 and Win64 compilers. I don't know if that call to UTF8ToString was needed for Android/Ios: I have never developed with next gen compilers and I can't test it.\r\n\r\n  Before applying this pull request could you please try to scan the barcode I added with ZXIng compiled for android/ios? you should get this string: \"ру́сский язы́к, russkij jazyk èàòù\"\r\n\r\n Note: I edited the literal strings in the test cases in order to use escape sequences with unicode values of characters instead of leaving the accented letters in the source: this could give problems to programmers who don't use a west-european windows installation. Another option could be to save the sources in UTF-8 format instead of using ANSI...\r\n ","created_at":"2016-08-30T11:56:10Z","updated_at":"2016-08-31T08:34:55Z","closed_at":"2016-08-31T08:34:55Z","merged_at":"2016-08-31T08:34:55Z","merge_commit_sha":"f0690353a405390e3fef4dab1c563cb189e91fea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/pulls/39/commits","review_comments_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/pulls/39/comments","review_comment_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/issues/39/comments","statuses_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/statuses/832d58e79688c0c0693a7ba0114fcfe899524ee2","head":{"label":"csm101:utf8_bug","ref":"utf8_bug","sha":"832d58e79688c0c0693a7ba0114fcfe899524ee2","user":{"login":"csm101","id":5736859,"avatar_url":"https://avatars.githubusercontent.com/u/5736859?v=3","gravatar_id":"","url":"https://api.github.com/users/csm101","html_url":"https://github.com/csm101","followers_url":"https://api.github.com/users/csm101/followers","following_url":"https://api.github.com/users/csm101/following{/other_user}","gists_url":"https://api.github.com/users/csm101/gists{/gist_id}","starred_url":"https://api.github.com/users/csm101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csm101/subscriptions","organizations_url":"https://api.github.com/users/csm101/orgs","repos_url":"https://api.github.com/users/csm101/repos","events_url":"https://api.github.com/users/csm101/events{/privacy}","received_events_url":"https://api.github.com/users/csm101/received_events","type":"User","site_admin":false},"repo":{"id":66462880,"name":"ZXing.Delphi","full_name":"csm101/ZXing.Delphi","owner":{"login":"csm101","id":5736859,"avatar_url":"https://avatars.githubusercontent.com/u/5736859?v=3","gravatar_id":"","url":"https://api.github.com/users/csm101","html_url":"https://github.com/csm101","followers_url":"https://api.github.com/users/csm101/followers","following_url":"https://api.github.com/users/csm101/following{/other_user}","gists_url":"https://api.github.com/users/csm101/gists{/gist_id}","starred_url":"https://api.github.com/users/csm101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csm101/subscriptions","organizations_url":"https://api.github.com/users/csm101/orgs","repos_url":"https://api.github.com/users/csm101/repos","events_url":"https://api.github.com/users/csm101/events{/privacy}","received_events_url":"https://api.github.com/users/csm101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csm101/ZXing.Delphi","description":"ZXing Barcode Scanning Library for Delphi XE7/XE8/X10/Appmethod","fork":true,"url":"https://api.github.com/repos/csm101/ZXing.Delphi","forks_url":"https://api.github.com/repos/csm101/ZXing.Delphi/forks","keys_url":"https://api.github.com/repos/csm101/ZXing.Delphi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csm101/ZXing.Delphi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csm101/ZXing.Delphi/teams","hooks_url":"https://api.github.com/repos/csm101/ZXing.Delphi/hooks","issue_events_url":"https://api.github.com/repos/csm101/ZXing.Delphi/issues/events{/number}","events_url":"https://api.github.com/repos/csm101/ZXing.Delphi/events","assignees_url":"https://api.github.com/repos/csm101/ZXing.Delphi/assignees{/user}","branches_url":"https://api.github.com/repos/csm101/ZXing.Delphi/branches{/branch}","tags_url":"https://api.github.com/repos/csm101/ZXing.Delphi/tags","blobs_url":"https://api.github.com/repos/csm101/ZXing.Delphi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csm101/ZXing.Delphi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csm101/ZXing.Delphi/git/refs{/sha}","trees_url":"https://api.github.com/repos/csm101/ZXing.Delphi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csm101/ZXing.Delphi/statuses/{sha}","languages_url":"https://api.github.com/repos/csm101/ZXing.Delphi/languages","stargazers_url":"https://api.github.com/repos/csm101/ZXing.Delphi/stargazers","contributors_url":"https://api.github.com/repos/csm101/ZXing.Delphi/contributors","subscribers_url":"https://api.github.com/repos/csm101/ZXing.Delphi/subscribers","subscription_url":"https://api.github.com/repos/csm101/ZXing.Delphi/subscription","commits_url":"https://api.github.com/repos/csm101/ZXing.Delphi/commits{/sha}","git_commits_url":"https://api.github.com/repos/csm101/ZXing.Delphi/git/commits{/sha}","comments_url":"https://api.github.com/repos/csm101/ZXing.Delphi/comments{/number}","issue_comment_url":"https://api.github.com/repos/csm101/ZXing.Delphi/issues/comments{/number}","contents_url":"https://api.github.com/repos/csm101/ZXing.Delphi/contents/{+path}","compare_url":"https://api.github.com/repos/csm101/ZXing.Delphi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csm101/ZXing.Delphi/merges","archive_url":"https://api.github.com/repos/csm101/ZXing.Delphi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csm101/ZXing.Delphi/downloads","issues_url":"https://api.github.com/repos/csm101/ZXing.Delphi/issues{/number}","pulls_url":"https://api.github.com/repos/csm101/ZXing.Delphi/pulls{/number}","milestones_url":"https://api.github.com/repos/csm101/ZXing.Delphi/milestones{/number}","notifications_url":"https://api.github.com/repos/csm101/ZXing.Delphi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csm101/ZXing.Delphi/labels{/name}","releases_url":"https://api.github.com/repos/csm101/ZXing.Delphi/releases{/id}","deployments_url":"https://api.github.com/repos/csm101/ZXing.Delphi/deployments","created_at":"2016-08-24T12:40:21Z","updated_at":"2016-08-24T12:40:23Z","pushed_at":"2016-08-30T12:01:44Z","git_url":"git://github.com/csm101/ZXing.Delphi.git","ssh_url":"git@github.com:csm101/ZXing.Delphi.git","clone_url":"https://github.com/csm101/ZXing.Delphi.git","svn_url":"https://github.com/csm101/ZXing.Delphi","homepage":"","size":9518,"stargazers_count":0,"watchers_count":0,"language":"Pascal","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v_3.0"}},"base":{"label":"Spelt:v_3.0","ref":"v_3.0","sha":"30ee333083a1e01277668ca378c8fe2a7d35b5a1","user":{"login":"Spelt","id":12660181,"avatar_url":"https://avatars.githubusercontent.com/u/12660181?v=3","gravatar_id":"","url":"https://api.github.com/users/Spelt","html_url":"https://github.com/Spelt","followers_url":"https://api.github.com/users/Spelt/followers","following_url":"https://api.github.com/users/Spelt/following{/other_user}","gists_url":"https://api.github.com/users/Spelt/gists{/gist_id}","starred_url":"https://api.github.com/users/Spelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spelt/subscriptions","organizations_url":"https://api.github.com/users/Spelt/orgs","repos_url":"https://api.github.com/users/Spelt/repos","events_url":"https://api.github.com/users/Spelt/events{/privacy}","received_events_url":"https://api.github.com/users/Spelt/received_events","type":"User","site_admin":false},"repo":{"id":36506425,"name":"ZXing.Delphi","full_name":"Spelt/ZXing.Delphi","owner":{"login":"Spelt","id":12660181,"avatar_url":"https://avatars.githubusercontent.com/u/12660181?v=3","gravatar_id":"","url":"https://api.github.com/users/Spelt","html_url":"https://github.com/Spelt","followers_url":"https://api.github.com/users/Spelt/followers","following_url":"https://api.github.com/users/Spelt/following{/other_user}","gists_url":"https://api.github.com/users/Spelt/gists{/gist_id}","starred_url":"https://api.github.com/users/Spelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spelt/subscriptions","organizations_url":"https://api.github.com/users/Spelt/orgs","repos_url":"https://api.github.com/users/Spelt/repos","events_url":"https://api.github.com/users/Spelt/events{/privacy}","received_events_url":"https://api.github.com/users/Spelt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Spelt/ZXing.Delphi","description":"ZXing Barcode Scanning Library for Delphi XE7/XE8/X10/Appmethod","fork":false,"url":"https://api.github.com/repos/Spelt/ZXing.Delphi","forks_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/forks","keys_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/teams","hooks_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/hooks","issue_events_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/issues/events{/number}","events_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/events","assignees_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/assignees{/user}","branches_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/branches{/branch}","tags_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/tags","blobs_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/statuses/{sha}","languages_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/languages","stargazers_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/stargazers","contributors_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/contributors","subscribers_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/subscribers","subscription_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/subscription","commits_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/contents/{+path}","compare_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/merges","archive_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/downloads","issues_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/issues{/number}","pulls_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/pulls{/number}","milestones_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/milestones{/number}","notifications_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/labels{/name}","releases_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/releases{/id}","deployments_url":"https://api.github.com/repos/Spelt/ZXing.Delphi/deployments","created_at":"2015-05-29T13:38:10Z","updated_at":"2016-08-21T05:22:49Z","pushed_at":"2016-08-31T08:34:56Z","git_url":"git://github.com/Spelt/ZXing.Delphi.git","ssh_url":"git@github.com:Spelt/ZXing.Delphi.git","clone_url":"https://github.com/Spelt/ZXing.Delphi.git","svn_url":"https://github.com/Spelt/ZXing.Delphi","homepage":"","size":7934,"stargazers_count":54,"watchers_count":54,"language":"Pascal","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":3,"forks":20,"open_issues":3,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Spelt/ZXing.Delphi/pulls/39"},"html":{"href":"https://github.com/Spelt/ZXing.Delphi/pull/39"},"issue":{"href":"https://api.github.com/repos/Spelt/ZXing.Delphi/issues/39"},"comments":{"href":"https://api.github.com/repos/Spelt/ZXing.Delphi/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/Spelt/ZXing.Delphi/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/Spelt/ZXing.Delphi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Spelt/ZXing.Delphi/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/Spelt/ZXing.Delphi/statuses/832d58e79688c0c0693a7ba0114fcfe899524ee2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Spelt","id":12660181,"avatar_url":"https://avatars.githubusercontent.com/u/12660181?v=3","gravatar_id":"","url":"https://api.github.com/users/Spelt","html_url":"https://github.com/Spelt","followers_url":"https://api.github.com/users/Spelt/followers","following_url":"https://api.github.com/users/Spelt/following{/other_user}","gists_url":"https://api.github.com/users/Spelt/gists{/gist_id}","starred_url":"https://api.github.com/users/Spelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spelt/subscriptions","organizations_url":"https://api.github.com/users/Spelt/orgs","repos_url":"https://api.github.com/users/Spelt/repos","events_url":"https://api.github.com/users/Spelt/events{/privacy}","received_events_url":"https://api.github.com/users/Spelt/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":16,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"Spelt"}}