{"action":"created","issue":{"url":"https://api.github.com/repos/zaps166/QMPlay2/issues/35","repository_url":"https://api.github.com/repos/zaps166/QMPlay2","labels_url":"https://api.github.com/repos/zaps166/QMPlay2/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/zaps166/QMPlay2/issues/35/comments","events_url":"https://api.github.com/repos/zaps166/QMPlay2/issues/35/events","html_url":"https://github.com/zaps166/QMPlay2/pull/35","id":163378894,"number":35,"title":"Settings UI files","user":{"login":"arthurzam","id":1664927,"avatar_url":"https://avatars.githubusercontent.com/u/1664927?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurzam","html_url":"https://github.com/arthurzam","followers_url":"https://api.github.com/users/arthurzam/followers","following_url":"https://api.github.com/users/arthurzam/following{/other_user}","gists_url":"https://api.github.com/users/arthurzam/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurzam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurzam/subscriptions","organizations_url":"https://api.github.com/users/arthurzam/orgs","repos_url":"https://api.github.com/users/arthurzam/repos","events_url":"https://api.github.com/users/arthurzam/events{/privacy}","received_events_url":"https://api.github.com/users/arthurzam/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-01T11:44:33Z","updated_at":"2016-07-03T13:59:26Z","closed_at":"2016-07-03T13:59:26Z","pull_request":{"url":"https://api.github.com/repos/zaps166/QMPlay2/pulls/35","html_url":"https://github.com/zaps166/QMPlay2/pull/35","diff_url":"https://github.com/zaps166/QMPlay2/pull/35.diff","patch_url":"https://github.com/zaps166/QMPlay2/pull/35.patch"},"body":"About the #13 issue, I made some decisions:\r\n\r\n1. I translated 'Strona' into 'Page' (checked using Google Translate :) )\r\n2. Only create ui file for page 1 & page 2. Those two pages were enormous, therefore it is logical to create ui file for them. But the other pages are little / intuitive therefore I saw no need to create for them a ui file (There is a little overhead during initialization in using the generated code than yours).\r\n3. I changed a little the concept in arranging the objects. Instead of QGridLayout I used combination of QFormLayout, QHBoxLayout and QVBoxLayout. In my opinion it is much cleaner looking now. But please says your thoughts.\r\n\r\nSome more questions:\r\n\r\n1. I think that moving every page (or at least page 1 & 2) into separate class and connect the signal/slot there. There will be only little more size addition to the binary, but it will make better organization.\r\n2. The [OSDSettingsW](https://github.com/zaps166/QMPlay2/blob/master/src/gui/OSDSettingsW.hpp) is also quite long - should I also convert it into ui file?\r\n\r\n**Reminder**: If you try to use/push to my fork, please do it into the `ui` branch. In the master branch there is future code (not ready still) for CPack, NSIS & OS X bundle."},"comment":{"url":"https://api.github.com/repos/zaps166/QMPlay2/issues/comments/230154838","html_url":"https://github.com/zaps166/QMPlay2/pull/35#issuecomment-230154838","issue_url":"https://api.github.com/repos/zaps166/QMPlay2/issues/35","id":230154838,"user":{"login":"arthurzam","id":1664927,"avatar_url":"https://avatars.githubusercontent.com/u/1664927?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurzam","html_url":"https://github.com/arthurzam","followers_url":"https://api.github.com/users/arthurzam/followers","following_url":"https://api.github.com/users/arthurzam/following{/other_user}","gists_url":"https://api.github.com/users/arthurzam/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurzam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurzam/subscriptions","organizations_url":"https://api.github.com/users/arthurzam/orgs","repos_url":"https://api.github.com/users/arthurzam/repos","events_url":"https://api.github.com/users/arthurzam/events{/privacy}","received_events_url":"https://api.github.com/users/arthurzam/received_events","type":"User","site_admin":false},"created_at":"2016-07-03T13:59:26Z","updated_at":"2016-07-03T13:59:26Z","body":"Well, thanks for the reply.\r\nBecause of the retarget, I will need to close & reopen the pull request to a new one."}}
{"actor":{"display_login":"arthurzam"}}