{"action":"created","issue":{"url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1976","repository_url":"https://api.github.com/repos/TerriaJS/terriajs","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1976/labels{/name}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1976/comments","events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1976/events","html_url":"https://github.com/TerriaJS/terriajs/issues/1976","id":172463410,"number":1976,"title":"Generalize test for ncWMS service","user":{"login":"rsignell-usgs","id":1872600,"avatar_url":"https://avatars.githubusercontent.com/u/1872600?v=3","gravatar_id":"","url":"https://api.github.com/users/rsignell-usgs","html_url":"https://github.com/rsignell-usgs","followers_url":"https://api.github.com/users/rsignell-usgs/followers","following_url":"https://api.github.com/users/rsignell-usgs/following{/other_user}","gists_url":"https://api.github.com/users/rsignell-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/rsignell-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsignell-usgs/subscriptions","organizations_url":"https://api.github.com/users/rsignell-usgs/orgs","repos_url":"https://api.github.com/users/rsignell-usgs/repos","events_url":"https://api.github.com/users/rsignell-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/rsignell-usgs/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TerriaJS/terriajs/labels/C-Catalogue","name":"C-Catalogue","color":"555577"},{"url":"https://api.github.com/repos/TerriaJS/terriajs/labels/T-Architecture/refactor","name":"T-Architecture/refactor","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/TerriaJS/terriajs/milestones/17","html_url":"https://github.com/TerriaJS/terriajs/milestones/2016-08-31%20USGS%20CDI","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/milestones/17/labels","id":1854972,"number":17,"title":"2016-08-31 USGS CDI","description":"","creator":{"login":"kring","id":924374,"avatar_url":"https://avatars.githubusercontent.com/u/924374?v=3","gravatar_id":"","url":"https://api.github.com/users/kring","html_url":"https://github.com/kring","followers_url":"https://api.github.com/users/kring/followers","following_url":"https://api.github.com/users/kring/following{/other_user}","gists_url":"https://api.github.com/users/kring/gists{/gist_id}","starred_url":"https://api.github.com/users/kring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kring/subscriptions","organizations_url":"https://api.github.com/users/kring/orgs","repos_url":"https://api.github.com/users/kring/repos","events_url":"https://api.github.com/users/kring/events{/privacy}","received_events_url":"https://api.github.com/users/kring/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":2,"state":"open","created_at":"2016-06-29T12:30:39Z","updated_at":"2016-08-23T10:30:40Z","due_on":"2016-08-30T14:00:00Z","closed_at":null},"comments":7,"created_at":"2016-08-22T14:14:33Z","updated_at":"2016-09-14T13:35:07Z","closed_at":null,"body":"Right now we test for a ncWMS service by seeing if a `boxfill/rainbow` style is available:\r\nhttps://github.com/TerriaJS/terriajs/blob/c8141034ba1025bcc115a0e2b5b4323b1ee94611/lib/Models/WebMapServiceCatalogItem.js#L367-L368\r\n\r\nThe thinking was that all ncWMS services would advertise this style, but ncWMS2 (which will be included in the THREDDS Data Server 5.0 when it is officially released) has dropped this style.\r\n\r\nHere's an example of a ncWMS2 getCapabilities from a development THREDDS Data Server 5.0:\r\n\r\nPerhaps it would be wise to distinguish between ncWMS and ncWMS2 and add a check for a style named `default-scalar/default`, something like:\r\n```\r\n            if (!defined(this.isNcWMS2) && myLayer.Style[j].Name && myLayer.Style[j].Name.match(/default\\-scalar\\/default/i)) {\r\n              this.isNcWMS2 = true;\r\n```\r\nIt seems prudent to identify ncWMS and ncWMS2 separately rather than just represent both as ncWMS, as their capabilities may be different.   \r\n\r\n@guygriffiths, do you agree?"},"comment":{"url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments/247014346","html_url":"https://github.com/TerriaJS/terriajs/issues/1976#issuecomment-247014346","issue_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1976","id":247014346,"user":{"login":"guygriffiths","id":1665346,"avatar_url":"https://avatars.githubusercontent.com/u/1665346?v=3","gravatar_id":"","url":"https://api.github.com/users/guygriffiths","html_url":"https://github.com/guygriffiths","followers_url":"https://api.github.com/users/guygriffiths/followers","following_url":"https://api.github.com/users/guygriffiths/following{/other_user}","gists_url":"https://api.github.com/users/guygriffiths/gists{/gist_id}","starred_url":"https://api.github.com/users/guygriffiths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guygriffiths/subscriptions","organizations_url":"https://api.github.com/users/guygriffiths/orgs","repos_url":"https://api.github.com/users/guygriffiths/repos","events_url":"https://api.github.com/users/guygriffiths/events{/privacy}","received_events_url":"https://api.github.com/users/guygriffiths/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T13:35:07Z","updated_at":"2016-09-14T13:35:07Z","body":"OK, this certainly looks possible, but there doesn't seem to be a standard for describing extended capabilities which would fit (INSPIRE has one, but I don't think it's suitable for describing these extensions).  I'll have a think about coming up with an XML schema which we can use and then link to, unless either of you are aware of a standard we can use?"}}
{"actor":{"display_login":"guygriffiths"}}