{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19531","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19531/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19531/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19531/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19531","id":192076780,"number":19531,"title":"[CR] Blazemod Blob Tank Generification","user":{"login":"ussdefiant60","id":22823357,"avatar_url":"https://avatars.githubusercontent.com/u/22823357?v=3","gravatar_id":"","url":"https://api.github.com/users/ussdefiant60","html_url":"https://github.com/ussdefiant60","followers_url":"https://api.github.com/users/ussdefiant60/followers","following_url":"https://api.github.com/users/ussdefiant60/following{/other_user}","gists_url":"https://api.github.com/users/ussdefiant60/gists{/gist_id}","starred_url":"https://api.github.com/users/ussdefiant60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ussdefiant60/subscriptions","organizations_url":"https://api.github.com/users/ussdefiant60/orgs","repos_url":"https://api.github.com/users/ussdefiant60/repos","events_url":"https://api.github.com/users/ussdefiant60/events{/privacy}","received_events_url":"https://api.github.com/users/ussdefiant60/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-28T18:09:32Z","updated_at":"2016-12-03T17:57:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/19531","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19531","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19531.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19531.patch"},"body":"Right, after a small bit of fumbling with Git, i've got a PR for part 2 of the things i discussed in #19217 , the tanks in particular. Capsules are set to 10 L, Pods 20, and Cocoons 25 L, and have been renamed to match the naming style of vanilla tanks. The location: under variants on the tanks have been eliminated entirely, leaving 3 entries out of 30 that were previously in the file and cluttering up the in game list (Though those 3 entries could be restored easily enough if necessary).\r\n\r\nA couple issues i see as needing discussion before this gets committed proper:\r\n\r\n1) Despite Capsules and Pods being identicle in size to vannila 10 and 20 L tanks in their vehicle part entries, ingame they were only able to hold 7.5 and 15 L, due to the component items being set to capacities of that value. I opted to increase the capacity of the components since it seemed fairly obvious that @Blaze-whatdoyoumeanitsalreadytaken intended for them to be identicle to vanilla tanks when actually installed in a vehicle. this does leave me wondering if \"size\" entries on vehicle mounted tanks actually does anything, though.\r\n\r\n2) Migration: I'm not at all certain how to make this save compatible. the migration json i currently see seems to apply to player inventory items, but i have no idea if it'll work with installed vehicle parts or not.\r\n\r\n3)There's a couple of entries for small gas/diesel tanks over in blaze_override.json. The only reason i'm not deleting those in favour of the vanilla 2L tank is that those entries are marked as FOLDABLE, while the vanilla tank is not. Not sure what to do with them."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/264654661","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19531#issuecomment-264654661","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19531","id":264654661,"user":{"login":"keyspace","id":18170434,"avatar_url":"https://avatars.githubusercontent.com/u/18170434?v=3","gravatar_id":"","url":"https://api.github.com/users/keyspace","html_url":"https://github.com/keyspace","followers_url":"https://api.github.com/users/keyspace/followers","following_url":"https://api.github.com/users/keyspace/following{/other_user}","gists_url":"https://api.github.com/users/keyspace/gists{/gist_id}","starred_url":"https://api.github.com/users/keyspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyspace/subscriptions","organizations_url":"https://api.github.com/users/keyspace/orgs","repos_url":"https://api.github.com/users/keyspace/repos","events_url":"https://api.github.com/users/keyspace/events{/privacy}","received_events_url":"https://api.github.com/users/keyspace/received_events","type":"User","site_admin":false},"created_at":"2016-12-03T17:57:16Z","updated_at":"2016-12-03T17:57:16Z","body":"Tested the PR locally.\r\n\r\nSeems to remove the `under` variants - is this intentional?.. OTOH default tanks don't have this special option.\r\n\r\nI've never used these parts, so perhaps I misunderstand where they're to be installed. :/"}}
{"actor":{"display_login":"keyspace"}}