{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/50154256","id":50154256,"diff_hunk":"@@ -111,4 +115,69 @@ private ByteBuffer getInternal(long blockId, ByteBuffer keyBuffer)\n     }\n     return null;\n   }\n+\n+  private ByteBufferKeyValuePartitionReader getReader(long sessionId, long lockId, long blockId)\n+      throws InvalidWorkerStateException, BlockDoesNotExistException, IOException {\n+    BlockReader blockReader = mBlockDataManager.readBlockRemote(sessionId, blockId, lockId);\n+    ByteBuffer fileBuffer = blockReader.read(0, blockReader.getLength());\n+    ByteBufferKeyValuePartitionReader reader = new ByteBufferKeyValuePartitionReader(fileBuffer);\n+    // TODO(binfan): clean fileBuffer which is a direct byte buffer\n+    return reader;\n+  }\n+\n+  @Override\n+  public List<ByteBuffer> getNextKeys(long blockId, ByteBuffer currentKey, int numKeys)\n+      throws TachyonTException, ThriftIOException {\n+    try {\n+      final long sessionId = Sessions.KEYVALUE_SESSION_ID;","path":"keyvalue/servers/src/main/java/tachyon/worker/keyvalue/KeyValueWorkerClientServiceHandler.java","position":86,"original_position":86,"commit_id":"2e3bed81012daa3ba4a48acc32d81a5d3deb1085","original_commit_id":"2e3bed81012daa3ba4a48acc32d81a5d3deb1085","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"we generally don't make local variables final just because they can be","created_at":"2016-01-19T18:41:46Z","updated_at":"2016-01-19T18:41:46Z","html_url":"https://github.com/amplab/tachyon/pull/2509#discussion_r50154256","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/2509","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/50154256"},"html":{"href":"https://github.com/amplab/tachyon/pull/2509#discussion_r50154256"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2509"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/2509","id":56403176,"html_url":"https://github.com/amplab/tachyon/pull/2509","diff_url":"https://github.com/amplab/tachyon/pull/2509.diff","patch_url":"https://github.com/amplab/tachyon/pull/2509.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/2509","number":2509,"state":"open","locked":false,"title":"[TACHYON-1574][TACHYON-1555] Add KeyValueInputStream for key-value store","user":{"login":"uronce-cc","id":3663941,"avatar_url":"https://avatars.githubusercontent.com/u/3663941?v=3","gravatar_id":"","url":"https://api.github.com/users/uronce-cc","html_url":"https://github.com/uronce-cc","followers_url":"https://api.github.com/users/uronce-cc/followers","following_url":"https://api.github.com/users/uronce-cc/following{/other_user}","gists_url":"https://api.github.com/users/uronce-cc/gists{/gist_id}","starred_url":"https://api.github.com/users/uronce-cc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uronce-cc/subscriptions","organizations_url":"https://api.github.com/users/uronce-cc/orgs","repos_url":"https://api.github.com/users/uronce-cc/repos","events_url":"https://api.github.com/users/uronce-cc/events{/privacy}","received_events_url":"https://api.github.com/users/uronce-cc/received_events","type":"User","site_admin":false},"body":"Apart from native key-value client, KeyValueInputFormat enables map-reduce compatible programs to directly read key-value pairs from key-value store.\r\n","created_at":"2016-01-18T23:20:53Z","updated_at":"2016-01-19T18:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a99786acb7852d2354a6145ddaed25bf35661ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/2509/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/2509/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/2509/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/2e3bed81012daa3ba4a48acc32d81a5d3deb1085","head":{"label":"uronce-cc:kv-inputformat","ref":"kv-inputformat","sha":"2e3bed81012daa3ba4a48acc32d81a5d3deb1085","user":{"login":"uronce-cc","id":3663941,"avatar_url":"https://avatars.githubusercontent.com/u/3663941?v=3","gravatar_id":"","url":"https://api.github.com/users/uronce-cc","html_url":"https://github.com/uronce-cc","followers_url":"https://api.github.com/users/uronce-cc/followers","following_url":"https://api.github.com/users/uronce-cc/following{/other_user}","gists_url":"https://api.github.com/users/uronce-cc/gists{/gist_id}","starred_url":"https://api.github.com/users/uronce-cc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uronce-cc/subscriptions","organizations_url":"https://api.github.com/users/uronce-cc/orgs","repos_url":"https://api.github.com/users/uronce-cc/repos","events_url":"https://api.github.com/users/uronce-cc/events{/privacy}","received_events_url":"https://api.github.com/users/uronce-cc/received_events","type":"User","site_admin":false},"repo":{"id":21723448,"name":"tachyon","full_name":"uronce-cc/tachyon","owner":{"login":"uronce-cc","id":3663941,"avatar_url":"https://avatars.githubusercontent.com/u/3663941?v=3","gravatar_id":"","url":"https://api.github.com/users/uronce-cc","html_url":"https://github.com/uronce-cc","followers_url":"https://api.github.com/users/uronce-cc/followers","following_url":"https://api.github.com/users/uronce-cc/following{/other_user}","gists_url":"https://api.github.com/users/uronce-cc/gists{/gist_id}","starred_url":"https://api.github.com/users/uronce-cc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uronce-cc/subscriptions","organizations_url":"https://api.github.com/users/uronce-cc/orgs","repos_url":"https://api.github.com/users/uronce-cc/repos","events_url":"https://api.github.com/users/uronce-cc/events{/privacy}","received_events_url":"https://api.github.com/users/uronce-cc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uronce-cc/tachyon","description":"Memory-centric Storage System for Big Data Analytics","fork":true,"url":"https://api.github.com/repos/uronce-cc/tachyon","forks_url":"https://api.github.com/repos/uronce-cc/tachyon/forks","keys_url":"https://api.github.com/repos/uronce-cc/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uronce-cc/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uronce-cc/tachyon/teams","hooks_url":"https://api.github.com/repos/uronce-cc/tachyon/hooks","issue_events_url":"https://api.github.com/repos/uronce-cc/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/uronce-cc/tachyon/events","assignees_url":"https://api.github.com/repos/uronce-cc/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/uronce-cc/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/uronce-cc/tachyon/tags","blobs_url":"https://api.github.com/repos/uronce-cc/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uronce-cc/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uronce-cc/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/uronce-cc/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uronce-cc/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/uronce-cc/tachyon/languages","stargazers_url":"https://api.github.com/repos/uronce-cc/tachyon/stargazers","contributors_url":"https://api.github.com/repos/uronce-cc/tachyon/contributors","subscribers_url":"https://api.github.com/repos/uronce-cc/tachyon/subscribers","subscription_url":"https://api.github.com/repos/uronce-cc/tachyon/subscription","commits_url":"https://api.github.com/repos/uronce-cc/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/uronce-cc/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/uronce-cc/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/uronce-cc/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/uronce-cc/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/uronce-cc/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uronce-cc/tachyon/merges","archive_url":"https://api.github.com/repos/uronce-cc/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uronce-cc/tachyon/downloads","issues_url":"https://api.github.com/repos/uronce-cc/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/uronce-cc/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/uronce-cc/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/uronce-cc/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uronce-cc/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/uronce-cc/tachyon/releases{/id}","created_at":"2014-07-11T05:40:12Z","updated_at":"2015-03-24T23:33:22Z","pushed_at":"2016-01-19T01:42:24Z","git_url":"git://github.com/uronce-cc/tachyon.git","ssh_url":"git@github.com:uronce-cc/tachyon.git","clone_url":"https://github.com/uronce-cc/tachyon.git","svn_url":"https://github.com/uronce-cc/tachyon","homepage":"http://tachyon-project.org","size":36745,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"56d16bc7fedaa4578d55e7c85358c27229bc4e5b","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":"Memory Centric Reliable Distributed Storage","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2016-01-19T12:39:28Z","pushed_at":"2016-01-19T18:05:38Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":45571,"stargazers_count":1903,"watchers_count":1903,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":752,"mirror_url":null,"open_issues_count":26,"forks":752,"open_issues":26,"watchers":1903,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2509"},"html":{"href":"https://github.com/amplab/tachyon/pull/2509"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2509"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2509/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2509/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2509/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/2e3bed81012daa3ba4a48acc32d81a5d3deb1085"}}}}