{"action":"created","issue":{"url":"https://api.github.com/repos/owtf/owtf/issues/660","repository_url":"https://api.github.com/repos/owtf/owtf","labels_url":"https://api.github.com/repos/owtf/owtf/issues/660/labels{/name}","comments_url":"https://api.github.com/repos/owtf/owtf/issues/660/comments","events_url":"https://api.github.com/repos/owtf/owtf/issues/660/events","html_url":"https://github.com/owtf/owtf/pull/660","id":148850782,"number":660,"title":"Fix: Pep8 fixes for /agents","user":{"login":"hTrap","id":5495474,"avatar_url":"https://avatars.githubusercontent.com/u/5495474?v=3","gravatar_id":"","url":"https://api.github.com/users/hTrap","html_url":"https://github.com/hTrap","followers_url":"https://api.github.com/users/hTrap/followers","following_url":"https://api.github.com/users/hTrap/following{/other_user}","gists_url":"https://api.github.com/users/hTrap/gists{/gist_id}","starred_url":"https://api.github.com/users/hTrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hTrap/subscriptions","organizations_url":"https://api.github.com/users/hTrap/orgs","repos_url":"https://api.github.com/users/hTrap/repos","events_url":"https://api.github.com/users/hTrap/events{/privacy}","received_events_url":"https://api.github.com/users/hTrap/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-16T13:01:44Z","updated_at":"2016-04-17T16:21:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owtf/owtf/pulls/660","html_url":"https://github.com/owtf/owtf/pull/660","diff_url":"https://github.com/owtf/owtf/pull/660.diff","patch_url":"https://github.com/owtf/owtf/pull/660.patch"},"body":"<!--- Provide a general, concise summary of your changes in the Title above -->\r\n## Description\r\nPep8 fixes for /agents submitted as a seperate PR as discussed in #623 \r\n\r\n## Reviewers\r\n<!--- @mentions of the person/people responsible for reviewing proposed changes. -->\r\n@delta24 @DePierre \r\n\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [x] Other\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style (modified PEP8) of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n\r\nSigned-off-by: Parth Oberoi <htrapdev@gmail.com>"},"comment":{"url":"https://api.github.com/repos/owtf/owtf/issues/comments/211051678","html_url":"https://github.com/owtf/owtf/pull/660#issuecomment-211051678","issue_url":"https://api.github.com/repos/owtf/owtf/issues/660","id":211051678,"user":{"login":"DePierre","id":923297,"avatar_url":"https://avatars.githubusercontent.com/u/923297?v=3","gravatar_id":"","url":"https://api.github.com/users/DePierre","html_url":"https://github.com/DePierre","followers_url":"https://api.github.com/users/DePierre/followers","following_url":"https://api.github.com/users/DePierre/following{/other_user}","gists_url":"https://api.github.com/users/DePierre/gists{/gist_id}","starred_url":"https://api.github.com/users/DePierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DePierre/subscriptions","organizations_url":"https://api.github.com/users/DePierre/orgs","repos_url":"https://api.github.com/users/DePierre/repos","events_url":"https://api.github.com/users/DePierre/events{/privacy}","received_events_url":"https://api.github.com/users/DePierre/received_events","type":"User","site_admin":false},"created_at":"2016-04-17T16:21:32Z","updated_at":"2016-04-17T16:21:32Z","body":"Hi @hTrap, it is fairly easier to review the changes, thank you for creating separate PR! :)\r\n\r\nIn your changes, there are still many pep8 violations. For instance the naming convention (CamelCase). I understand that changing the name of the functions is too tedious to be done here, but at least we could update the naming convention of the internal variables.\r\n\r\nI have pin-pointed one in the PR. I also commented a couple other stuff. They apply to the other PR (#623 for instance)."}}