{"action":"opened","number":32,"pull_request":{"url":"https://api.github.com/repos/molleindustria/p5.play/pulls/32","id":59598526,"html_url":"https://github.com/molleindustria/p5.play/pull/32","diff_url":"https://github.com/molleindustria/p5.play/pull/32.diff","patch_url":"https://github.com/molleindustria/p5.play/pull/32.patch","issue_url":"https://api.github.com/repos/molleindustria/p5.play/issues/32","number":32,"state":"open","locked":false,"title":"Follow convention for private method naming and annotation","user":{"login":"islemaster","id":1615761,"avatar_url":"https://avatars.githubusercontent.com/u/1615761?v=3","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"body":"I realized that in the last few changes, I haven't been consistent with the new private methods I've introduced.  This change is a pure refactor that brings things in line.\r\n\r\n**My understanding of the convention for private methods:**\r\n\r\n* Private methods are named with a `_leadingUnderscore`\r\n* Private methods are JSDoc annotated as [`@private`](http://usejsdoc.org/tags-private.html)\r\n\r\n**Fixes made:**\r\n\r\n* Rename `keyCodeFromAlias_` to `_keyCodeFromAlias`\r\n* Rename `warn_` to `_warn`\r\n* Correct JSDoc for `_warn`: Had wrong method name and was missing `@private` annotation\r\n* Add JSDoc for `_ensureInGlobalMode`","created_at":"2016-02-17T05:35:22Z","updated_at":"2016-02-17T05:35:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/molleindustria/p5.play/pulls/32/commits","review_comments_url":"https://api.github.com/repos/molleindustria/p5.play/pulls/32/comments","review_comment_url":"https://api.github.com/repos/molleindustria/p5.play/pulls/comments{/number}","comments_url":"https://api.github.com/repos/molleindustria/p5.play/issues/32/comments","statuses_url":"https://api.github.com/repos/molleindustria/p5.play/statuses/4a37424057a7ea54e523a635be99170a5096a52e","head":{"label":"islemaster:follow-private-method-convention","ref":"follow-private-method-convention","sha":"4a37424057a7ea54e523a635be99170a5096a52e","user":{"login":"islemaster","id":1615761,"avatar_url":"https://avatars.githubusercontent.com/u/1615761?v=3","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"repo":{"id":51337648,"name":"p5.play","full_name":"islemaster/p5.play","owner":{"login":"islemaster","id":1615761,"avatar_url":"https://avatars.githubusercontent.com/u/1615761?v=3","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/islemaster/p5.play","description":"A p5.js library for games and playthings","fork":true,"url":"https://api.github.com/repos/islemaster/p5.play","forks_url":"https://api.github.com/repos/islemaster/p5.play/forks","keys_url":"https://api.github.com/repos/islemaster/p5.play/keys{/key_id}","collaborators_url":"https://api.github.com/repos/islemaster/p5.play/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/islemaster/p5.play/teams","hooks_url":"https://api.github.com/repos/islemaster/p5.play/hooks","issue_events_url":"https://api.github.com/repos/islemaster/p5.play/issues/events{/number}","events_url":"https://api.github.com/repos/islemaster/p5.play/events","assignees_url":"https://api.github.com/repos/islemaster/p5.play/assignees{/user}","branches_url":"https://api.github.com/repos/islemaster/p5.play/branches{/branch}","tags_url":"https://api.github.com/repos/islemaster/p5.play/tags","blobs_url":"https://api.github.com/repos/islemaster/p5.play/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/islemaster/p5.play/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/islemaster/p5.play/git/refs{/sha}","trees_url":"https://api.github.com/repos/islemaster/p5.play/git/trees{/sha}","statuses_url":"https://api.github.com/repos/islemaster/p5.play/statuses/{sha}","languages_url":"https://api.github.com/repos/islemaster/p5.play/languages","stargazers_url":"https://api.github.com/repos/islemaster/p5.play/stargazers","contributors_url":"https://api.github.com/repos/islemaster/p5.play/contributors","subscribers_url":"https://api.github.com/repos/islemaster/p5.play/subscribers","subscription_url":"https://api.github.com/repos/islemaster/p5.play/subscription","commits_url":"https://api.github.com/repos/islemaster/p5.play/commits{/sha}","git_commits_url":"https://api.github.com/repos/islemaster/p5.play/git/commits{/sha}","comments_url":"https://api.github.com/repos/islemaster/p5.play/comments{/number}","issue_comment_url":"https://api.github.com/repos/islemaster/p5.play/issues/comments{/number}","contents_url":"https://api.github.com/repos/islemaster/p5.play/contents/{+path}","compare_url":"https://api.github.com/repos/islemaster/p5.play/compare/{base}...{head}","merges_url":"https://api.github.com/repos/islemaster/p5.play/merges","archive_url":"https://api.github.com/repos/islemaster/p5.play/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/islemaster/p5.play/downloads","issues_url":"https://api.github.com/repos/islemaster/p5.play/issues{/number}","pulls_url":"https://api.github.com/repos/islemaster/p5.play/pulls{/number}","milestones_url":"https://api.github.com/repos/islemaster/p5.play/milestones{/number}","notifications_url":"https://api.github.com/repos/islemaster/p5.play/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/islemaster/p5.play/labels{/name}","releases_url":"https://api.github.com/repos/islemaster/p5.play/releases{/id}","deployments_url":"https://api.github.com/repos/islemaster/p5.play/deployments","created_at":"2016-02-09T00:31:03Z","updated_at":"2016-02-09T00:31:04Z","pushed_at":"2016-02-17T05:27:59Z","git_url":"git://github.com/islemaster/p5.play.git","ssh_url":"git@github.com:islemaster/p5.play.git","clone_url":"https://github.com/islemaster/p5.play.git","svn_url":"https://github.com/islemaster/p5.play","homepage":null,"size":4023,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"molleindustria:master","ref":"master","sha":"085894cf7599f629fda52cbbd488346042afd073","user":{"login":"molleindustria","id":12369651,"avatar_url":"https://avatars.githubusercontent.com/u/12369651?v=3","gravatar_id":"","url":"https://api.github.com/users/molleindustria","html_url":"https://github.com/molleindustria","followers_url":"https://api.github.com/users/molleindustria/followers","following_url":"https://api.github.com/users/molleindustria/following{/other_user}","gists_url":"https://api.github.com/users/molleindustria/gists{/gist_id}","starred_url":"https://api.github.com/users/molleindustria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molleindustria/subscriptions","organizations_url":"https://api.github.com/users/molleindustria/orgs","repos_url":"https://api.github.com/users/molleindustria/repos","events_url":"https://api.github.com/users/molleindustria/events{/privacy}","received_events_url":"https://api.github.com/users/molleindustria/received_events","type":"User","site_admin":false},"repo":{"id":37993872,"name":"p5.play","full_name":"molleindustria/p5.play","owner":{"login":"molleindustria","id":12369651,"avatar_url":"https://avatars.githubusercontent.com/u/12369651?v=3","gravatar_id":"","url":"https://api.github.com/users/molleindustria","html_url":"https://github.com/molleindustria","followers_url":"https://api.github.com/users/molleindustria/followers","following_url":"https://api.github.com/users/molleindustria/following{/other_user}","gists_url":"https://api.github.com/users/molleindustria/gists{/gist_id}","starred_url":"https://api.github.com/users/molleindustria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molleindustria/subscriptions","organizations_url":"https://api.github.com/users/molleindustria/orgs","repos_url":"https://api.github.com/users/molleindustria/repos","events_url":"https://api.github.com/users/molleindustria/events{/privacy}","received_events_url":"https://api.github.com/users/molleindustria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/molleindustria/p5.play","description":"A p5.js library for games and playthings","fork":false,"url":"https://api.github.com/repos/molleindustria/p5.play","forks_url":"https://api.github.com/repos/molleindustria/p5.play/forks","keys_url":"https://api.github.com/repos/molleindustria/p5.play/keys{/key_id}","collaborators_url":"https://api.github.com/repos/molleindustria/p5.play/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/molleindustria/p5.play/teams","hooks_url":"https://api.github.com/repos/molleindustria/p5.play/hooks","issue_events_url":"https://api.github.com/repos/molleindustria/p5.play/issues/events{/number}","events_url":"https://api.github.com/repos/molleindustria/p5.play/events","assignees_url":"https://api.github.com/repos/molleindustria/p5.play/assignees{/user}","branches_url":"https://api.github.com/repos/molleindustria/p5.play/branches{/branch}","tags_url":"https://api.github.com/repos/molleindustria/p5.play/tags","blobs_url":"https://api.github.com/repos/molleindustria/p5.play/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/molleindustria/p5.play/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/molleindustria/p5.play/git/refs{/sha}","trees_url":"https://api.github.com/repos/molleindustria/p5.play/git/trees{/sha}","statuses_url":"https://api.github.com/repos/molleindustria/p5.play/statuses/{sha}","languages_url":"https://api.github.com/repos/molleindustria/p5.play/languages","stargazers_url":"https://api.github.com/repos/molleindustria/p5.play/stargazers","contributors_url":"https://api.github.com/repos/molleindustria/p5.play/contributors","subscribers_url":"https://api.github.com/repos/molleindustria/p5.play/subscribers","subscription_url":"https://api.github.com/repos/molleindustria/p5.play/subscription","commits_url":"https://api.github.com/repos/molleindustria/p5.play/commits{/sha}","git_commits_url":"https://api.github.com/repos/molleindustria/p5.play/git/commits{/sha}","comments_url":"https://api.github.com/repos/molleindustria/p5.play/comments{/number}","issue_comment_url":"https://api.github.com/repos/molleindustria/p5.play/issues/comments{/number}","contents_url":"https://api.github.com/repos/molleindustria/p5.play/contents/{+path}","compare_url":"https://api.github.com/repos/molleindustria/p5.play/compare/{base}...{head}","merges_url":"https://api.github.com/repos/molleindustria/p5.play/merges","archive_url":"https://api.github.com/repos/molleindustria/p5.play/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/molleindustria/p5.play/downloads","issues_url":"https://api.github.com/repos/molleindustria/p5.play/issues{/number}","pulls_url":"https://api.github.com/repos/molleindustria/p5.play/pulls{/number}","milestones_url":"https://api.github.com/repos/molleindustria/p5.play/milestones{/number}","notifications_url":"https://api.github.com/repos/molleindustria/p5.play/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/molleindustria/p5.play/labels{/name}","releases_url":"https://api.github.com/repos/molleindustria/p5.play/releases{/id}","deployments_url":"https://api.github.com/repos/molleindustria/p5.play/deployments","created_at":"2015-06-24T15:39:56Z","updated_at":"2016-02-16T07:53:58Z","pushed_at":"2016-02-17T05:13:51Z","git_url":"git://github.com/molleindustria/p5.play.git","ssh_url":"git@github.com:molleindustria/p5.play.git","clone_url":"https://github.com/molleindustria/p5.play.git","svn_url":"https://github.com/molleindustria/p5.play","homepage":null,"size":4057,"stargazers_count":70,"watchers_count":70,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":9,"forks":19,"open_issues":9,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/molleindustria/p5.play/pulls/32"},"html":{"href":"https://github.com/molleindustria/p5.play/pull/32"},"issue":{"href":"https://api.github.com/repos/molleindustria/p5.play/issues/32"},"comments":{"href":"https://api.github.com/repos/molleindustria/p5.play/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/molleindustria/p5.play/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/molleindustria/p5.play/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/molleindustria/p5.play/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/molleindustria/p5.play/statuses/4a37424057a7ea54e523a635be99170a5096a52e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":32,"deletions":27,"changed_files":2}}