{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/84829319","pull_request_review_id":5581091,"id":84829319,"diff_hunk":"@@ -0,0 +1,112 @@\n+# Open Questions\n+\n+This document contains open questions regarding the\n+[API design document](./design.md).\n+\n+## 1. Is the `ServiceInstanceBinding` resource necesssary?\n+\n+The `ServiceInstanceBinding` object is a byproduct of the successful execution\n+of a `ServiceInstanceClaim`. Instead of writing a new `ServiceInstanceBinding`\n+object, can the service catalog controller just add the binding information\n+directly into the `ServiceInstanceClaim` on success?","path":"docs/v1/open_questions.md","position":11,"original_position":11,"commit_id":"4adff8db46243a43eacca9ebea07e4cd3785599b","original_commit_id":"4adff8db46243a43eacca9ebea07e4cd3785599b","user":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"body":"In order to reflect that the ServiceInstanceClaim has been satisfied, we should write the ServiceInstance back to the claim. We could write the other references back to the claim at the same if, if there were a reason to do so. I imagine the resources would link back to the claim for garbage collection if nothing else.\r\n\r\nI'd be inclined to start without a binding resource, unless it serves a specific purpose.","created_at":"2016-10-25T04:31:10Z","updated_at":"2016-10-25T04:31:10Z","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/13#discussion_r84829319","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/84829319"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/13#discussion_r84829319"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/13","id":89088078,"html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/13","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/13.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/13.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/13","number":13,"state":"open","locked":false,"title":"Adding Service Catalog API Spec","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"body":"__Update__: this patch will be split into smaller logical pieces, to facilitate clearer, more focused discussion on individual pieces. That work is tracked in https://github.com/kubernetes-incubator/service-catalog/issues/14\r\n\r\nThis is a formal proposal that expands on @krancour's presentation given at the 10/10/2016 SIG-service-catalog meeting. Slides here: https://docs.google.com/presentation/d/1Fm3qG9zQ4R8ZbhtTObmQjO3UZYJ0ruYI4qr5w_gEKN8/edit?usp=sharing\r\n\r\nStill To Address:\r\n\r\n- [ ] Add to the use cases document: https://github.com/kubernetes-incubator/service-catalog/pull/13#discussion_r83533829\r\n- [x] Wrap all lines to 80 cols (3d7dad6776d5e05b099ea8605bc20723e638f8e5)\r\n\r\ncc/ @pmorie ","created_at":"2016-10-12T20:30:36Z","updated_at":"2016-10-25T04:31:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2d9e675b2edcc86ea062141e5ff6a9b10ae50d4","assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/13/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/13/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/13/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/4adff8db46243a43eacca9ebea07e4cd3785599b","head":{"label":"arschles:api","ref":"api","sha":"4adff8db46243a43eacca9ebea07e4cd3785599b","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"repo":{"id":70734213,"name":"kubernetes-incubator-service-catalog","full_name":"arschles/kubernetes-incubator-service-catalog","owner":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arschles/kubernetes-incubator-service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":true,"url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog","forks_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/forks","keys_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/teams","hooks_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/hooks","issue_events_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/events","assignees_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/tags","blobs_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/languages","stargazers_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/stargazers","contributors_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/contributors","subscribers_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/subscribers","subscription_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/subscription","commits_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/merges","archive_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/downloads","issues_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/deployments","created_at":"2016-10-12T19:28:49Z","updated_at":"2016-10-12T19:29:01Z","pushed_at":"2016-10-24T19:24:11Z","git_url":"git://github.com/arschles/kubernetes-incubator-service-catalog.git","ssh_url":"git@github.com:arschles/kubernetes-incubator-service-catalog.git","clone_url":"https://github.com/arschles/kubernetes-incubator-service-catalog.git","svn_url":"https://github.com/arschles/kubernetes-incubator-service-catalog","homepage":"","size":153,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"05c06422bbb19c9ac0d29a9526108a8113237745","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68024288,"name":"service-catalog","full_name":"kubernetes-incubator/service-catalog","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","forks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/deployments","created_at":"2016-09-12T15:58:39Z","updated_at":"2016-10-24T19:01:09Z","pushed_at":"2016-10-25T04:21:20Z","git_url":"git://github.com/kubernetes-incubator/service-catalog.git","ssh_url":"git@github.com:kubernetes-incubator/service-catalog.git","clone_url":"https://github.com/kubernetes-incubator/service-catalog.git","svn_url":"https://github.com/kubernetes-incubator/service-catalog","homepage":"","size":127,"stargazers_count":12,"watchers_count":12,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/13"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/13"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/13"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/4adff8db46243a43eacca9ebea07e4cd3785599b"}}}}
{"actor":{"display_login":"bgrant0607"}}