{"comment":{"url":"https://api.github.com/repos/dtaht/tc-adv/comments/19204482","html_url":"https://github.com/dtaht/tc-adv/commit/2c7ddd720a85f1814b9099945f6981e4ab8b8105#commitcomment-19204482","id":19204482,"user":{"login":"moeller0","id":6169243,"avatar_url":"https://avatars.githubusercontent.com/u/6169243?v=3","gravatar_id":"","url":"https://api.github.com/users/moeller0","html_url":"https://github.com/moeller0","followers_url":"https://api.github.com/users/moeller0/followers","following_url":"https://api.github.com/users/moeller0/following{/other_user}","gists_url":"https://api.github.com/users/moeller0/gists{/gist_id}","starred_url":"https://api.github.com/users/moeller0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moeller0/subscriptions","organizations_url":"https://api.github.com/users/moeller0/orgs","repos_url":"https://api.github.com/users/moeller0/repos","events_url":"https://api.github.com/users/moeller0/events{/privacy}","received_events_url":"https://api.github.com/users/moeller0/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"2c7ddd720a85f1814b9099945f6981e4ab8b8105","created_at":"2016-09-28T09:14:56Z","updated_at":"2016-09-28T09:14:56Z","body":"/*\r\n +\t\t * DOCSIS overhead figures courtesy of Greg White @ CableLabs.\r\n +\t\t * The \"-ip\" versions include the Ethernet frame header, in case\r\n +\t\t * you are shaping an IP interface instead of an Ethernet one.\r\n +\t\t */\r\n\r\n\r\nThis seems rather unexpected, for ATM/PTM the same is achieved by using the via-ethernet keyword, why treat DOCSIS any different? \r\nI have mentioned in the past the overhead encapsulation user interface is something only a father/mother could love, it is far from self-explantory or well-documented. And this here is not making it any better, as documenting the whole thing, should anybody ever start this quest, is much easier when an interface is predictable and systematic..."}}
{"actor":{"display_login":"moeller0"}}