{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments/84323132","pull_request_review_id":5107956,"id":84323132,"diff_hunk":"@@ -1140,11 +1140,12 @@ UI.notifyFocusLeft = function () {\n  * @param {string} [login] current login\n  */\n UI.updateAuthInfo = function (isAuthEnabled, login) {\n+    let showAuth = isAuthEnabled && UIUtil.isAuthenticationEnabled();","path":"modules/UI/UI.js","position":4,"original_position":4,"commit_id":"436f3b9d9b7d928ee88f5b7cb6c5d4081fd95d2d","original_commit_id":"436f3b9d9b7d928ee88f5b7cb6c5d4081fd95d2d","user":{"login":"yanas","id":3264676,"avatar_url":"https://avatars.githubusercontent.com/u/3264676?v=3","gravatar_id":"","url":"https://api.github.com/users/yanas","html_url":"https://github.com/yanas","followers_url":"https://api.github.com/users/yanas/followers","following_url":"https://api.github.com/users/yanas/following{/other_user}","gists_url":"https://api.github.com/users/yanas/gists{/gist_id}","starred_url":"https://api.github.com/users/yanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanas/subscriptions","organizations_url":"https://api.github.com/users/yanas/orgs","repos_url":"https://api.github.com/users/yanas/repos","events_url":"https://api.github.com/users/yanas/events{/privacy}","received_events_url":"https://api.github.com/users/yanas/received_events","type":"User","site_admin":false},"body":"Ok, now I see that you take isAuthEnabled into account actually, but also use the UI property. Why do we need the UI property then?","created_at":"2016-10-20T16:30:07Z","updated_at":"2016-10-20T16:30:07Z","html_url":"https://github.com/jitsi/jitsi-meet/pull/992#discussion_r84323132","pull_request_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/992","_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments/84323132"},"html":{"href":"https://github.com/jitsi/jitsi-meet/pull/992#discussion_r84323132"},"pull_request":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/992"}}},"pull_request":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/992","id":88558249,"html_url":"https://github.com/jitsi/jitsi-meet/pull/992","diff_url":"https://github.com/jitsi/jitsi-meet/pull/992.diff","patch_url":"https://github.com/jitsi/jitsi-meet/pull/992.patch","issue_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/992","number":992,"state":"open","locked":false,"title":"toolbar: authentication button changed","user":{"login":"kkrisstoff","id":6803242,"avatar_url":"https://avatars.githubusercontent.com/u/6803242?v=3","gravatar_id":"","url":"https://api.github.com/users/kkrisstoff","html_url":"https://github.com/kkrisstoff","followers_url":"https://api.github.com/users/kkrisstoff/followers","following_url":"https://api.github.com/users/kkrisstoff/following{/other_user}","gists_url":"https://api.github.com/users/kkrisstoff/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrisstoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrisstoff/subscriptions","organizations_url":"https://api.github.com/users/kkrisstoff/orgs","repos_url":"https://api.github.com/users/kkrisstoff/repos","events_url":"https://api.github.com/users/kkrisstoff/events{/privacy}","received_events_url":"https://api.github.com/users/kkrisstoff/received_events","type":"User","site_admin":false},"body":"Make auth button in same style like all buttons for extended toolbar\r\nbeta:\r\n![beta](https://cloud.githubusercontent.com/assets/6803242/19215762/ad3e2b8c-8daf-11e6-919b-e65e63f5fcec.gif)\r\nMy PR:\r\n![now](https://cloud.githubusercontent.com/assets/6803242/19309927/61ad147e-9090-11e6-994e-3f17e46864c3.gif)\r\n","created_at":"2016-10-08T20:34:17Z","updated_at":"2016-10-20T16:30:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba576f97c2fa9de56e7aedc474139318e50aa08e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/992/commits","review_comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/992/comments","review_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/992/comments","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/436f3b9d9b7d928ee88f5b7cb6c5d4081fd95d2d","head":{"label":"kkrisstoff:task/make-extended-toolbar-dynamically-created","ref":"task/make-extended-toolbar-dynamically-created","sha":"436f3b9d9b7d928ee88f5b7cb6c5d4081fd95d2d","user":{"login":"kkrisstoff","id":6803242,"avatar_url":"https://avatars.githubusercontent.com/u/6803242?v=3","gravatar_id":"","url":"https://api.github.com/users/kkrisstoff","html_url":"https://github.com/kkrisstoff","followers_url":"https://api.github.com/users/kkrisstoff/followers","following_url":"https://api.github.com/users/kkrisstoff/following{/other_user}","gists_url":"https://api.github.com/users/kkrisstoff/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrisstoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrisstoff/subscriptions","organizations_url":"https://api.github.com/users/kkrisstoff/orgs","repos_url":"https://api.github.com/users/kkrisstoff/repos","events_url":"https://api.github.com/users/kkrisstoff/events{/privacy}","received_events_url":"https://api.github.com/users/kkrisstoff/received_events","type":"User","site_admin":false},"repo":{"id":66845421,"name":"jitsi-meet","full_name":"kkrisstoff/jitsi-meet","owner":{"login":"kkrisstoff","id":6803242,"avatar_url":"https://avatars.githubusercontent.com/u/6803242?v=3","gravatar_id":"","url":"https://api.github.com/users/kkrisstoff","html_url":"https://github.com/kkrisstoff","followers_url":"https://api.github.com/users/kkrisstoff/followers","following_url":"https://api.github.com/users/kkrisstoff/following{/other_user}","gists_url":"https://api.github.com/users/kkrisstoff/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrisstoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrisstoff/subscriptions","organizations_url":"https://api.github.com/users/kkrisstoff/orgs","repos_url":"https://api.github.com/users/kkrisstoff/repos","events_url":"https://api.github.com/users/kkrisstoff/events{/privacy}","received_events_url":"https://api.github.com/users/kkrisstoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkrisstoff/jitsi-meet","description":"Jitsi Meet - Secure, Simple and Scalable Video Conferences","fork":true,"url":"https://api.github.com/repos/kkrisstoff/jitsi-meet","forks_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/forks","keys_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/events","assignees_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/merges","archive_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/kkrisstoff/jitsi-meet/deployments","created_at":"2016-08-29T13:20:31Z","updated_at":"2016-08-29T13:20:34Z","pushed_at":"2016-10-20T11:32:11Z","git_url":"git://github.com/kkrisstoff/jitsi-meet.git","ssh_url":"git@github.com:kkrisstoff/jitsi-meet.git","clone_url":"https://github.com/kkrisstoff/jitsi-meet.git","svn_url":"https://github.com/kkrisstoff/jitsi-meet","homepage":"https://jitsi.org/Projects/JitsiMeet","size":21012,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"8ca0943881083a509c0d56dfcd8cc1a27e6c27a5","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":15225670,"name":"jitsi-meet","full_name":"jitsi/jitsi-meet","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jitsi-meet","description":"Jitsi Meet - Secure, Simple and Scalable Video Conferences","fork":false,"url":"https://api.github.com/repos/jitsi/jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jitsi-meet/deployments","created_at":"2013-12-16T12:51:09Z","updated_at":"2016-10-20T12:34:05Z","pushed_at":"2016-10-20T16:21:00Z","git_url":"git://github.com/jitsi/jitsi-meet.git","ssh_url":"git@github.com:jitsi/jitsi-meet.git","clone_url":"https://github.com/jitsi/jitsi-meet.git","svn_url":"https://github.com/jitsi/jitsi-meet","homepage":"https://jitsi.org/Projects/JitsiMeet","size":24326,"stargazers_count":763,"watchers_count":763,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"open_issues_count":198,"forks":349,"open_issues":198,"watchers":763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/992"},"html":{"href":"https://github.com/jitsi/jitsi-meet/pull/992"},"issue":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/992"},"comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/992/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/992/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/992/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/436f3b9d9b7d928ee88f5b7cb6c5d4081fd95d2d"}}}}
{"actor":{"display_login":"yanas"}}