{"action":"created","comment":{"url":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/comments/55246343","id":55246343,"diff_hunk":"@@ -34,20 +14,33 @@ function checkParameters (iterations, keylen) {\n     throw new TypeError('Key length not a number')\n   }\n \n-  if (keylen < 0 || keylen > MAX_ALLOC) {\n+  if (keylen < 0 || isNaN(keylen) || keylen > MAX_ALLOC) {","path":"browser.js","position":36,"original_position":36,"commit_id":"b0d1399cc6080049f097147fc9eda3cc1bea32a9","original_commit_id":"b0d1399cc6080049f097147fc9eda3cc1bea32a9","user":{"login":"fanatid","id":2633065,"avatar_url":"https://avatars.githubusercontent.com/u/2633065?v=3","gravatar_id":"","url":"https://api.github.com/users/fanatid","html_url":"https://github.com/fanatid","followers_url":"https://api.github.com/users/fanatid/followers","following_url":"https://api.github.com/users/fanatid/following{/other_user}","gists_url":"https://api.github.com/users/fanatid/gists{/gist_id}","starred_url":"https://api.github.com/users/fanatid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanatid/subscriptions","organizations_url":"https://api.github.com/users/fanatid/orgs","repos_url":"https://api.github.com/users/fanatid/repos","events_url":"https://api.github.com/users/fanatid/events{/privacy}","received_events_url":"https://api.github.com/users/fanatid/received_events","type":"User","site_admin":false},"body":"in `lodash` `isNaN`: `value != +value`\r\nhttps://github.com/lodash/lodash/blob/092f90d2fca959fa75d14cae8a2377a58bcb122d/lodash.js#L10534\r\nor better will use `keylen !== keylen` ?","created_at":"2016-03-07T18:21:08Z","updated_at":"2016-03-07T18:21:08Z","html_url":"https://github.com/crypto-browserify/pbkdf2/pull/27#discussion_r55246343","pull_request_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/comments/55246343"},"html":{"href":"https://github.com/crypto-browserify/pbkdf2/pull/27#discussion_r55246343"},"pull_request":{"href":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/27","id":61851129,"html_url":"https://github.com/crypto-browserify/pbkdf2/pull/27","diff_url":"https://github.com/crypto-browserify/pbkdf2/pull/27.diff","patch_url":"https://github.com/crypto-browserify/pbkdf2/pull/27.patch","issue_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/issues/27","number":27,"state":"open","locked":false,"title":"node 0.10, more checks for keylen","user":{"login":"fanatid","id":2633065,"avatar_url":"https://avatars.githubusercontent.com/u/2633065?v=3","gravatar_id":"","url":"https://api.github.com/users/fanatid","html_url":"https://github.com/fanatid","followers_url":"https://api.github.com/users/fanatid/followers","following_url":"https://api.github.com/users/fanatid/following{/other_user}","gists_url":"https://api.github.com/users/fanatid/gists{/gist_id}","starred_url":"https://api.github.com/users/fanatid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanatid/subscriptions","organizations_url":"https://api.github.com/users/fanatid/orgs","repos_url":"https://api.github.com/users/fanatid/repos","events_url":"https://api.github.com/users/fanatid/events{/privacy}","received_events_url":"https://api.github.com/users/fanatid/received_events","type":"User","site_admin":false},"body":"Another attempt (summary of #22 #23 #25 #26)","created_at":"2016-03-06T18:56:58Z","updated_at":"2016-03-07T18:21:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f28b86162d8b2eed867d4067cc0b5b4b42d8b1c5","assignee":{"login":"calvinmetcalf","id":1128607,"avatar_url":"https://avatars.githubusercontent.com/u/1128607?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinmetcalf","html_url":"https://github.com/calvinmetcalf","followers_url":"https://api.github.com/users/calvinmetcalf/followers","following_url":"https://api.github.com/users/calvinmetcalf/following{/other_user}","gists_url":"https://api.github.com/users/calvinmetcalf/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinmetcalf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinmetcalf/subscriptions","organizations_url":"https://api.github.com/users/calvinmetcalf/orgs","repos_url":"https://api.github.com/users/calvinmetcalf/repos","events_url":"https://api.github.com/users/calvinmetcalf/events{/privacy}","received_events_url":"https://api.github.com/users/calvinmetcalf/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/27/commits","review_comments_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/27/comments","review_comment_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/issues/27/comments","statuses_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/statuses/b0d1399cc6080049f097147fc9eda3cc1bea32a9","head":{"label":"fanatid:feature/node-shim","ref":"feature/node-shim","sha":"b0d1399cc6080049f097147fc9eda3cc1bea32a9","user":{"login":"fanatid","id":2633065,"avatar_url":"https://avatars.githubusercontent.com/u/2633065?v=3","gravatar_id":"","url":"https://api.github.com/users/fanatid","html_url":"https://github.com/fanatid","followers_url":"https://api.github.com/users/fanatid/followers","following_url":"https://api.github.com/users/fanatid/following{/other_user}","gists_url":"https://api.github.com/users/fanatid/gists{/gist_id}","starred_url":"https://api.github.com/users/fanatid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanatid/subscriptions","organizations_url":"https://api.github.com/users/fanatid/orgs","repos_url":"https://api.github.com/users/fanatid/repos","events_url":"https://api.github.com/users/fanatid/events{/privacy}","received_events_url":"https://api.github.com/users/fanatid/received_events","type":"User","site_admin":false},"repo":{"id":52435769,"name":"pbkdf2","full_name":"fanatid/pbkdf2","owner":{"login":"fanatid","id":2633065,"avatar_url":"https://avatars.githubusercontent.com/u/2633065?v=3","gravatar_id":"","url":"https://api.github.com/users/fanatid","html_url":"https://github.com/fanatid","followers_url":"https://api.github.com/users/fanatid/followers","following_url":"https://api.github.com/users/fanatid/following{/other_user}","gists_url":"https://api.github.com/users/fanatid/gists{/gist_id}","starred_url":"https://api.github.com/users/fanatid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanatid/subscriptions","organizations_url":"https://api.github.com/users/fanatid/orgs","repos_url":"https://api.github.com/users/fanatid/repos","events_url":"https://api.github.com/users/fanatid/events{/privacy}","received_events_url":"https://api.github.com/users/fanatid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fanatid/pbkdf2","description":"PBKDF2 with any supported hashing algorithm in Node without waiting for 0.11","fork":true,"url":"https://api.github.com/repos/fanatid/pbkdf2","forks_url":"https://api.github.com/repos/fanatid/pbkdf2/forks","keys_url":"https://api.github.com/repos/fanatid/pbkdf2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fanatid/pbkdf2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fanatid/pbkdf2/teams","hooks_url":"https://api.github.com/repos/fanatid/pbkdf2/hooks","issue_events_url":"https://api.github.com/repos/fanatid/pbkdf2/issues/events{/number}","events_url":"https://api.github.com/repos/fanatid/pbkdf2/events","assignees_url":"https://api.github.com/repos/fanatid/pbkdf2/assignees{/user}","branches_url":"https://api.github.com/repos/fanatid/pbkdf2/branches{/branch}","tags_url":"https://api.github.com/repos/fanatid/pbkdf2/tags","blobs_url":"https://api.github.com/repos/fanatid/pbkdf2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fanatid/pbkdf2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fanatid/pbkdf2/git/refs{/sha}","trees_url":"https://api.github.com/repos/fanatid/pbkdf2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fanatid/pbkdf2/statuses/{sha}","languages_url":"https://api.github.com/repos/fanatid/pbkdf2/languages","stargazers_url":"https://api.github.com/repos/fanatid/pbkdf2/stargazers","contributors_url":"https://api.github.com/repos/fanatid/pbkdf2/contributors","subscribers_url":"https://api.github.com/repos/fanatid/pbkdf2/subscribers","subscription_url":"https://api.github.com/repos/fanatid/pbkdf2/subscription","commits_url":"https://api.github.com/repos/fanatid/pbkdf2/commits{/sha}","git_commits_url":"https://api.github.com/repos/fanatid/pbkdf2/git/commits{/sha}","comments_url":"https://api.github.com/repos/fanatid/pbkdf2/comments{/number}","issue_comment_url":"https://api.github.com/repos/fanatid/pbkdf2/issues/comments{/number}","contents_url":"https://api.github.com/repos/fanatid/pbkdf2/contents/{+path}","compare_url":"https://api.github.com/repos/fanatid/pbkdf2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fanatid/pbkdf2/merges","archive_url":"https://api.github.com/repos/fanatid/pbkdf2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fanatid/pbkdf2/downloads","issues_url":"https://api.github.com/repos/fanatid/pbkdf2/issues{/number}","pulls_url":"https://api.github.com/repos/fanatid/pbkdf2/pulls{/number}","milestones_url":"https://api.github.com/repos/fanatid/pbkdf2/milestones{/number}","notifications_url":"https://api.github.com/repos/fanatid/pbkdf2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fanatid/pbkdf2/labels{/name}","releases_url":"https://api.github.com/repos/fanatid/pbkdf2/releases{/id}","deployments_url":"https://api.github.com/repos/fanatid/pbkdf2/deployments","created_at":"2016-02-24T10:58:37Z","updated_at":"2016-02-24T10:58:38Z","pushed_at":"2016-03-07T07:51:53Z","git_url":"git://github.com/fanatid/pbkdf2.git","ssh_url":"git@github.com:fanatid/pbkdf2.git","clone_url":"https://github.com/fanatid/pbkdf2.git","svn_url":"https://github.com/fanatid/pbkdf2","homepage":"","size":49,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crypto-browserify:master","ref":"master","sha":"d67ddbd971997d29a952de98b042dfe37c9556d1","user":{"login":"crypto-browserify","id":6728527,"avatar_url":"https://avatars.githubusercontent.com/u/6728527?v=3","gravatar_id":"","url":"https://api.github.com/users/crypto-browserify","html_url":"https://github.com/crypto-browserify","followers_url":"https://api.github.com/users/crypto-browserify/followers","following_url":"https://api.github.com/users/crypto-browserify/following{/other_user}","gists_url":"https://api.github.com/users/crypto-browserify/gists{/gist_id}","starred_url":"https://api.github.com/users/crypto-browserify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crypto-browserify/subscriptions","organizations_url":"https://api.github.com/users/crypto-browserify/orgs","repos_url":"https://api.github.com/users/crypto-browserify/repos","events_url":"https://api.github.com/users/crypto-browserify/events{/privacy}","received_events_url":"https://api.github.com/users/crypto-browserify/received_events","type":"Organization","site_admin":false},"repo":{"id":23705832,"name":"pbkdf2","full_name":"crypto-browserify/pbkdf2","owner":{"login":"crypto-browserify","id":6728527,"avatar_url":"https://avatars.githubusercontent.com/u/6728527?v=3","gravatar_id":"","url":"https://api.github.com/users/crypto-browserify","html_url":"https://github.com/crypto-browserify","followers_url":"https://api.github.com/users/crypto-browserify/followers","following_url":"https://api.github.com/users/crypto-browserify/following{/other_user}","gists_url":"https://api.github.com/users/crypto-browserify/gists{/gist_id}","starred_url":"https://api.github.com/users/crypto-browserify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crypto-browserify/subscriptions","organizations_url":"https://api.github.com/users/crypto-browserify/orgs","repos_url":"https://api.github.com/users/crypto-browserify/repos","events_url":"https://api.github.com/users/crypto-browserify/events{/privacy}","received_events_url":"https://api.github.com/users/crypto-browserify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crypto-browserify/pbkdf2","description":"PBKDF2 with any supported hashing algorithm in Node without waiting for 0.11","fork":false,"url":"https://api.github.com/repos/crypto-browserify/pbkdf2","forks_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/forks","keys_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/teams","hooks_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/hooks","issue_events_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/issues/events{/number}","events_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/events","assignees_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/assignees{/user}","branches_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/branches{/branch}","tags_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/tags","blobs_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/git/refs{/sha}","trees_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/statuses/{sha}","languages_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/languages","stargazers_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/stargazers","contributors_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/contributors","subscribers_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/subscribers","subscription_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/subscription","commits_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/commits{/sha}","git_commits_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/git/commits{/sha}","comments_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/comments{/number}","issue_comment_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/issues/comments{/number}","contents_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/contents/{+path}","compare_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/merges","archive_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/downloads","issues_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/issues{/number}","pulls_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls{/number}","milestones_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/milestones{/number}","notifications_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/labels{/name}","releases_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/releases{/id}","deployments_url":"https://api.github.com/repos/crypto-browserify/pbkdf2/deployments","created_at":"2014-09-05T14:27:22Z","updated_at":"2016-01-28T13:50:07Z","pushed_at":"2016-03-07T07:51:54Z","git_url":"git://github.com/crypto-browserify/pbkdf2.git","ssh_url":"git@github.com:crypto-browserify/pbkdf2.git","clone_url":"https://github.com/crypto-browserify/pbkdf2.git","svn_url":"https://github.com/crypto-browserify/pbkdf2","homepage":"","size":51,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/27"},"html":{"href":"https://github.com/crypto-browserify/pbkdf2/pull/27"},"issue":{"href":"https://api.github.com/repos/crypto-browserify/pbkdf2/issues/27"},"comments":{"href":"https://api.github.com/repos/crypto-browserify/pbkdf2/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crypto-browserify/pbkdf2/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/crypto-browserify/pbkdf2/statuses/b0d1399cc6080049f097147fc9eda3cc1bea32a9"}}}}