{"action":"created","comment":{"url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/comments/92977420","pull_request_review_id":13498107,"id":92977420,"diff_hunk":"@@ -0,0 +1,44 @@\n+FROM microsoft/iis:windowsservercore\r\n+\r\n+SHELL [\"powershell\", \"-Command\", \"$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';\"]\r\n+\r\n+ENV PHP_VERSION 7.1.0\r\n+ENV PHP_SHA1 85c0215337b08f9d49c233c16475c15f17b66ac1\r\n+\r\n+WORKDIR /Users/ContainerAdministrator/Downloads\r\n+\r\n+# Visual C++ 2015 Redistributable\r\n+# workaround: the .exe command completes early and does not finish the install, so added 10s sleep to the end to allow time to finish\r\n+RUN Invoke-WebRequest 'https://download.microsoft.com/download/9/3/F/93FCF1E7-E6A4-478B-96E7-D4B285925B00/vc_redist.x64.exe' -OutFile 'vc_redist.x64.exe'; \\\r\n+\t.\\vc_redist.x64.exe /install /passive /norestart; \\\r\n+    Start-Sleep -s 10;\r\n+\r\n+# Install PHP\r\n+RUN Invoke-WebRequest $('http://windows.php.net/downloads/releases/php-{0}-nts-Win32-VC14-x64.zip' -f $env:PHP_VERSION) -OutFile 'php.zip'; \\\r\n+    if ((Get-FileHash php.zip -Algorithm sha1).Hash -ne $env:PHP_SHA1) {exit 1} ; \\\r\n+    Expand-Archive -Path php.zip -DestinationPath c:\\php; \\\r\n+    [Environment]::SetEnvironmentVariable('PATH', $env:Path + ';C:\\php', [EnvironmentVariableTarget]::Machine); \\\r\n+\t$env:PATH = [Environment]::GetEnvironmentVariable('PATH', [EnvironmentVariableTarget]::Machine); \\\r\n+    php --version;\r\n+\r\n+COPY stage/ /\r\n+\r\n+# Install Composer\r\n+RUN Invoke-WebRequest 'https://getcomposer.org/installer' -OutFile 'composer-setup.php'; \\\r\n+    php composer-setup.php; \\\r\n+    mv composer.phar C:\\php; \\\r\n+    composer about;\r\n+\r\n+# Configure IIS\r\n+COPY config/ ./\r\n+RUN .\\configure_iis.ps1;\r\n+\r\n+# Clean Downloads Directory\r\n+RUN Remove-Item -Recurse -Force *\r","path":"php/Dockerfile","position":37,"original_position":37,"commit_id":"7a35aa265999e11c1e0d27f65d9da5e48e1b82e1","original_commit_id":"7a35aa265999e11c1e0d27f65d9da5e48e1b82e1","user":{"login":"StefanScherer","id":207759,"avatar_url":"https://avatars.githubusercontent.com/u/207759?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanScherer","html_url":"https://github.com/StefanScherer","followers_url":"https://api.github.com/users/StefanScherer/followers","following_url":"https://api.github.com/users/StefanScherer/following{/other_user}","gists_url":"https://api.github.com/users/StefanScherer/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanScherer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanScherer/subscriptions","organizations_url":"https://api.github.com/users/StefanScherer/orgs","repos_url":"https://api.github.com/users/StefanScherer/repos","events_url":"https://api.github.com/users/StefanScherer/events{/privacy}","received_events_url":"https://api.github.com/users/StefanScherer/received_events","type":"User","site_admin":false},"body":"Removing files in a separate `RUN` command does not reduce the size of the layers to pull from a container registry as all layers have to be pulled to build the Docker image. If a first `RUN` downloads a GByte and a second `RUN` deletes it, the first layer is still a GByte.\r\n\r\nSo it would be better to remove the files at the end of the corresponding `RUN` command.\r\n","created_at":"2016-12-19T07:06:43Z","updated_at":"2016-12-19T07:08:35Z","html_url":"https://github.com/StefanScherer/dockerfiles-windows/pull/41#discussion_r92977420","pull_request_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/comments/92977420"},"html":{"href":"https://github.com/StefanScherer/dockerfiles-windows/pull/41#discussion_r92977420"},"pull_request":{"href":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/41","id":98499395,"html_url":"https://github.com/StefanScherer/dockerfiles-windows/pull/41","diff_url":"https://github.com/StefanScherer/dockerfiles-windows/pull/41.diff","patch_url":"https://github.com/StefanScherer/dockerfiles-windows/pull/41.patch","issue_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/issues/41","number":41,"state":"open","locked":false,"title":"PHP FastCGI + IIS","user":{"login":"caleblloyd","id":2414837,"avatar_url":"https://avatars.githubusercontent.com/u/2414837?v=3","gravatar_id":"","url":"https://api.github.com/users/caleblloyd","html_url":"https://github.com/caleblloyd","followers_url":"https://api.github.com/users/caleblloyd/followers","following_url":"https://api.github.com/users/caleblloyd/following{/other_user}","gists_url":"https://api.github.com/users/caleblloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/caleblloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caleblloyd/subscriptions","organizations_url":"https://api.github.com/users/caleblloyd/orgs","repos_url":"https://api.github.com/users/caleblloyd/repos","events_url":"https://api.github.com/users/caleblloyd/events{/privacy}","received_events_url":"https://api.github.com/users/caleblloyd/received_events","type":"User","site_admin":false},"body":"- Fixes #39 \r\n- Installs PHP 7.1.0\r\n- Installs `composer` (PHP package manager)\r\n- Configures IIS w/ FastCGI\r\n- Adds a site at `C:\\www`","created_at":"2016-12-19T02:36:30Z","updated_at":"2016-12-19T07:08:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a80cf9d015c76a57c8942c184146debeb367c96d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/41/commits","review_comments_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/41/comments","review_comment_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/issues/41/comments","statuses_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/statuses/7a35aa265999e11c1e0d27f65d9da5e48e1b82e1","head":{"label":"caleblloyd:f_php","ref":"f_php","sha":"7a35aa265999e11c1e0d27f65d9da5e48e1b82e1","user":{"login":"caleblloyd","id":2414837,"avatar_url":"https://avatars.githubusercontent.com/u/2414837?v=3","gravatar_id":"","url":"https://api.github.com/users/caleblloyd","html_url":"https://github.com/caleblloyd","followers_url":"https://api.github.com/users/caleblloyd/followers","following_url":"https://api.github.com/users/caleblloyd/following{/other_user}","gists_url":"https://api.github.com/users/caleblloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/caleblloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caleblloyd/subscriptions","organizations_url":"https://api.github.com/users/caleblloyd/orgs","repos_url":"https://api.github.com/users/caleblloyd/repos","events_url":"https://api.github.com/users/caleblloyd/events{/privacy}","received_events_url":"https://api.github.com/users/caleblloyd/received_events","type":"User","site_admin":false},"repo":{"id":76813727,"name":"dockerfiles-windows","full_name":"caleblloyd/dockerfiles-windows","owner":{"login":"caleblloyd","id":2414837,"avatar_url":"https://avatars.githubusercontent.com/u/2414837?v=3","gravatar_id":"","url":"https://api.github.com/users/caleblloyd","html_url":"https://github.com/caleblloyd","followers_url":"https://api.github.com/users/caleblloyd/followers","following_url":"https://api.github.com/users/caleblloyd/following{/other_user}","gists_url":"https://api.github.com/users/caleblloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/caleblloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caleblloyd/subscriptions","organizations_url":"https://api.github.com/users/caleblloyd/orgs","repos_url":"https://api.github.com/users/caleblloyd/repos","events_url":"https://api.github.com/users/caleblloyd/events{/privacy}","received_events_url":"https://api.github.com/users/caleblloyd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caleblloyd/dockerfiles-windows","description":"Various Dockerfiles for Windows","fork":true,"url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows","forks_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/forks","keys_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/teams","hooks_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/hooks","issue_events_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/issues/events{/number}","events_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/events","assignees_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/assignees{/user}","branches_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/branches{/branch}","tags_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/tags","blobs_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/languages","stargazers_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/stargazers","contributors_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/contributors","subscribers_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/subscribers","subscription_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/subscription","commits_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/contents/{+path}","compare_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/merges","archive_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/downloads","issues_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/issues{/number}","pulls_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/labels{/name}","releases_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/releases{/id}","deployments_url":"https://api.github.com/repos/caleblloyd/dockerfiles-windows/deployments","created_at":"2016-12-18T23:52:48Z","updated_at":"2016-12-18T23:52:49Z","pushed_at":"2016-12-19T02:34:29Z","git_url":"git://github.com/caleblloyd/dockerfiles-windows.git","ssh_url":"git@github.com:caleblloyd/dockerfiles-windows.git","clone_url":"https://github.com/caleblloyd/dockerfiles-windows.git","svn_url":"https://github.com/caleblloyd/dockerfiles-windows","homepage":"","size":297,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"StefanScherer:master","ref":"master","sha":"2bfff897980038eede19658047dcd4fe1afd7554","user":{"login":"StefanScherer","id":207759,"avatar_url":"https://avatars.githubusercontent.com/u/207759?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanScherer","html_url":"https://github.com/StefanScherer","followers_url":"https://api.github.com/users/StefanScherer/followers","following_url":"https://api.github.com/users/StefanScherer/following{/other_user}","gists_url":"https://api.github.com/users/StefanScherer/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanScherer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanScherer/subscriptions","organizations_url":"https://api.github.com/users/StefanScherer/orgs","repos_url":"https://api.github.com/users/StefanScherer/repos","events_url":"https://api.github.com/users/StefanScherer/events{/privacy}","received_events_url":"https://api.github.com/users/StefanScherer/received_events","type":"User","site_admin":false},"repo":{"id":41170824,"name":"dockerfiles-windows","full_name":"StefanScherer/dockerfiles-windows","owner":{"login":"StefanScherer","id":207759,"avatar_url":"https://avatars.githubusercontent.com/u/207759?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanScherer","html_url":"https://github.com/StefanScherer","followers_url":"https://api.github.com/users/StefanScherer/followers","following_url":"https://api.github.com/users/StefanScherer/following{/other_user}","gists_url":"https://api.github.com/users/StefanScherer/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanScherer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanScherer/subscriptions","organizations_url":"https://api.github.com/users/StefanScherer/orgs","repos_url":"https://api.github.com/users/StefanScherer/repos","events_url":"https://api.github.com/users/StefanScherer/events{/privacy}","received_events_url":"https://api.github.com/users/StefanScherer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StefanScherer/dockerfiles-windows","description":"Various Dockerfiles for Windows","fork":false,"url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows","forks_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/forks","keys_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/teams","hooks_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/hooks","issue_events_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/issues/events{/number}","events_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/events","assignees_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/assignees{/user}","branches_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/branches{/branch}","tags_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/tags","blobs_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/languages","stargazers_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/stargazers","contributors_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/contributors","subscribers_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/subscribers","subscription_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/subscription","commits_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/contents/{+path}","compare_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/merges","archive_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/downloads","issues_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/issues{/number}","pulls_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/labels{/name}","releases_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/releases{/id}","deployments_url":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/deployments","created_at":"2015-08-21T18:22:08Z","updated_at":"2016-12-18T08:56:30Z","pushed_at":"2016-12-19T02:36:30Z","git_url":"git://github.com/StefanScherer/dockerfiles-windows.git","ssh_url":"git@github.com:StefanScherer/dockerfiles-windows.git","clone_url":"https://github.com/StefanScherer/dockerfiles-windows.git","svn_url":"https://github.com/StefanScherer/dockerfiles-windows","homepage":"","size":272,"stargazers_count":105,"watchers_count":105,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":4,"forks":21,"open_issues":4,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/41"},"html":{"href":"https://github.com/StefanScherer/dockerfiles-windows/pull/41"},"issue":{"href":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/issues/41"},"comments":{"href":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/StefanScherer/dockerfiles-windows/statuses/7a35aa265999e11c1e0d27f65d9da5e48e1b82e1"}}}}
{"actor":{"display_login":"StefanScherer"}}