{"action":"created","issue":{"url":"https://api.github.com/repos/fsharp/FSharp.Data/issues/986","repository_url":"https://api.github.com/repos/fsharp/FSharp.Data","labels_url":"https://api.github.com/repos/fsharp/FSharp.Data/issues/986/labels{/name}","comments_url":"https://api.github.com/repos/fsharp/FSharp.Data/issues/986/comments","events_url":"https://api.github.com/repos/fsharp/FSharp.Data/issues/986/events","html_url":"https://github.com/fsharp/FSharp.Data/issues/986","id":172351387,"number":986,"title":"Failing tests in FSharp.Data.Tests\\Http.fs","user":{"login":"zpbappi","id":7844699,"avatar_url":"https://avatars.githubusercontent.com/u/7844699?v=3","gravatar_id":"","url":"https://api.github.com/users/zpbappi","html_url":"https://github.com/zpbappi","followers_url":"https://api.github.com/users/zpbappi/followers","following_url":"https://api.github.com/users/zpbappi/following{/other_user}","gists_url":"https://api.github.com/users/zpbappi/gists{/gist_id}","starred_url":"https://api.github.com/users/zpbappi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpbappi/subscriptions","organizations_url":"https://api.github.com/users/zpbappi/orgs","repos_url":"https://api.github.com/users/zpbappi/repos","events_url":"https://api.github.com/users/zpbappi/events{/privacy}","received_events_url":"https://api.github.com/users/zpbappi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-22T00:41:22Z","updated_at":"2016-08-23T20:36:01Z","closed_at":null,"body":"There are 3 tests in the ~/tests/FSharp.Data.Tests/Http.fs file that are failing. The tests are:\r\n\r\n- `Don't throw exceptions on http error`\r\n- `Throw exceptions on http error`\r\n- `Setting timeout in customizeHttpRequest overrides timeout argument`\r\n\r\nThe reason they are failing has nothing to do with the expected behavior. Rather, the url the tests are calling (http://api.themoviedb.org/3/search/movie) has a new field in the json response named `success`. As the tests are trying to compare the response, the tests are failing. As a result, almost all the pull requests pending fixing these 3 tests by adding the `success` field in the test.\r\n\r\nTo me, this approach seems like a risky way to assert a behavior. As the json response has nothing to do with the asserted behavior, we can probably re-write the tests without using the json response. I will submit a PR pretty soon with the changes in this 3 tests. However, for these tests, I would feel safer using a mock server that can simulate the behavior we want, without actually relying on the 3rd party web site. Although I am not quite sure how easy that would be in F#. But it would enable us to run tests anytime and anywhere, without even internet connection."},"comment":{"url":"https://api.github.com/repos/fsharp/FSharp.Data/issues/comments/241869895","html_url":"https://github.com/fsharp/FSharp.Data/issues/986#issuecomment-241869895","issue_url":"https://api.github.com/repos/fsharp/FSharp.Data/issues/986","id":241869895,"user":{"login":"ovatsus","id":738761,"avatar_url":"https://avatars.githubusercontent.com/u/738761?v=3","gravatar_id":"","url":"https://api.github.com/users/ovatsus","html_url":"https://github.com/ovatsus","followers_url":"https://api.github.com/users/ovatsus/followers","following_url":"https://api.github.com/users/ovatsus/following{/other_user}","gists_url":"https://api.github.com/users/ovatsus/gists{/gist_id}","starred_url":"https://api.github.com/users/ovatsus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovatsus/subscriptions","organizations_url":"https://api.github.com/users/ovatsus/orgs","repos_url":"https://api.github.com/users/ovatsus/repos","events_url":"https://api.github.com/users/ovatsus/events{/privacy}","received_events_url":"https://api.github.com/users/ovatsus/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T20:36:01Z","updated_at":"2016-08-23T20:36:01Z","body":"We already use a mock http server for some tests, see the HttpIntegrationTests.fs"}}
{"actor":{"display_login":"ovatsus"}}