{"action":"closed","number":180,"pull_request":{"url":"https://api.github.com/repos/firnsy/barnyard2/pulls/180","id":58611108,"html_url":"https://github.com/firnsy/barnyard2/pull/180","diff_url":"https://github.com/firnsy/barnyard2/pull/180.diff","patch_url":"https://github.com/firnsy/barnyard2/pull/180.patch","issue_url":"https://api.github.com/repos/firnsy/barnyard2/issues/180","number":180,"state":"closed","locked":false,"title":"This patch speeds up startup and adds the --unique-map option","user":{"login":"notnyt","id":1365428,"avatar_url":"https://avatars.githubusercontent.com/u/1365428?v=3","gravatar_id":"","url":"https://api.github.com/users/notnyt","html_url":"https://github.com/notnyt","followers_url":"https://api.github.com/users/notnyt/followers","following_url":"https://api.github.com/users/notnyt/following{/other_user}","gists_url":"https://api.github.com/users/notnyt/gists{/gist_id}","starred_url":"https://api.github.com/users/notnyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notnyt/subscriptions","organizations_url":"https://api.github.com/users/notnyt/orgs","repos_url":"https://api.github.com/users/notnyt/repos","events_url":"https://api.github.com/users/notnyt/events{/privacy}","received_events_url":"https://api.github.com/users/notnyt/received_events","type":"User","site_admin":false},"body":"Barnyard2 takes a very long time to start due to poorly\r\noptimized list code.  For every SID added to the list, the entire\r\nlist is iterated to get to the tail of the list.  Adding and\r\nmaintaining a tail pointer prevents this, since we can just add\r\nentries directly at the end.\r\n\r\nThe --unique-map option is also added, this prevents each SID from\r\nthe files being checked against what's in memory.  Most tools\r\ngenerate unique files, making this check unnecessary and wasteful.","created_at":"2016-02-08T13:49:18Z","updated_at":"2016-02-08T13:52:31Z","closed_at":"2016-02-08T13:52:31Z","merged_at":null,"merge_commit_sha":"05a9695f14c4ff6a871da9e9d6d4985e207c4093","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/firnsy/barnyard2/pulls/180/commits","review_comments_url":"https://api.github.com/repos/firnsy/barnyard2/pulls/180/comments","review_comment_url":"https://api.github.com/repos/firnsy/barnyard2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firnsy/barnyard2/issues/180/comments","statuses_url":"https://api.github.com/repos/firnsy/barnyard2/statuses/c94602ed982edba733ab26acdac9357cd360846c","head":{"label":"notnyt:feature_optimize_sid_list","ref":"feature_optimize_sid_list","sha":"c94602ed982edba733ab26acdac9357cd360846c","user":{"login":"notnyt","id":1365428,"avatar_url":"https://avatars.githubusercontent.com/u/1365428?v=3","gravatar_id":"","url":"https://api.github.com/users/notnyt","html_url":"https://github.com/notnyt","followers_url":"https://api.github.com/users/notnyt/followers","following_url":"https://api.github.com/users/notnyt/following{/other_user}","gists_url":"https://api.github.com/users/notnyt/gists{/gist_id}","starred_url":"https://api.github.com/users/notnyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notnyt/subscriptions","organizations_url":"https://api.github.com/users/notnyt/orgs","repos_url":"https://api.github.com/users/notnyt/repos","events_url":"https://api.github.com/users/notnyt/events{/privacy}","received_events_url":"https://api.github.com/users/notnyt/received_events","type":"User","site_admin":false},"repo":{"id":51248820,"name":"barnyard2","full_name":"notnyt/barnyard2","owner":{"login":"notnyt","id":1365428,"avatar_url":"https://avatars.githubusercontent.com/u/1365428?v=3","gravatar_id":"","url":"https://api.github.com/users/notnyt","html_url":"https://github.com/notnyt","followers_url":"https://api.github.com/users/notnyt/followers","following_url":"https://api.github.com/users/notnyt/following{/other_user}","gists_url":"https://api.github.com/users/notnyt/gists{/gist_id}","starred_url":"https://api.github.com/users/notnyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notnyt/subscriptions","organizations_url":"https://api.github.com/users/notnyt/orgs","repos_url":"https://api.github.com/users/notnyt/repos","events_url":"https://api.github.com/users/notnyt/events{/privacy}","received_events_url":"https://api.github.com/users/notnyt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/notnyt/barnyard2","description":"Barnyard2 is a dedicated spooler for Snort's unified2 binary output format.","fork":true,"url":"https://api.github.com/repos/notnyt/barnyard2","forks_url":"https://api.github.com/repos/notnyt/barnyard2/forks","keys_url":"https://api.github.com/repos/notnyt/barnyard2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/notnyt/barnyard2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/notnyt/barnyard2/teams","hooks_url":"https://api.github.com/repos/notnyt/barnyard2/hooks","issue_events_url":"https://api.github.com/repos/notnyt/barnyard2/issues/events{/number}","events_url":"https://api.github.com/repos/notnyt/barnyard2/events","assignees_url":"https://api.github.com/repos/notnyt/barnyard2/assignees{/user}","branches_url":"https://api.github.com/repos/notnyt/barnyard2/branches{/branch}","tags_url":"https://api.github.com/repos/notnyt/barnyard2/tags","blobs_url":"https://api.github.com/repos/notnyt/barnyard2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/notnyt/barnyard2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/notnyt/barnyard2/git/refs{/sha}","trees_url":"https://api.github.com/repos/notnyt/barnyard2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/notnyt/barnyard2/statuses/{sha}","languages_url":"https://api.github.com/repos/notnyt/barnyard2/languages","stargazers_url":"https://api.github.com/repos/notnyt/barnyard2/stargazers","contributors_url":"https://api.github.com/repos/notnyt/barnyard2/contributors","subscribers_url":"https://api.github.com/repos/notnyt/barnyard2/subscribers","subscription_url":"https://api.github.com/repos/notnyt/barnyard2/subscription","commits_url":"https://api.github.com/repos/notnyt/barnyard2/commits{/sha}","git_commits_url":"https://api.github.com/repos/notnyt/barnyard2/git/commits{/sha}","comments_url":"https://api.github.com/repos/notnyt/barnyard2/comments{/number}","issue_comment_url":"https://api.github.com/repos/notnyt/barnyard2/issues/comments{/number}","contents_url":"https://api.github.com/repos/notnyt/barnyard2/contents/{+path}","compare_url":"https://api.github.com/repos/notnyt/barnyard2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/notnyt/barnyard2/merges","archive_url":"https://api.github.com/repos/notnyt/barnyard2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/notnyt/barnyard2/downloads","issues_url":"https://api.github.com/repos/notnyt/barnyard2/issues{/number}","pulls_url":"https://api.github.com/repos/notnyt/barnyard2/pulls{/number}","milestones_url":"https://api.github.com/repos/notnyt/barnyard2/milestones{/number}","notifications_url":"https://api.github.com/repos/notnyt/barnyard2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/notnyt/barnyard2/labels{/name}","releases_url":"https://api.github.com/repos/notnyt/barnyard2/releases{/id}","deployments_url":"https://api.github.com/repos/notnyt/barnyard2/deployments","created_at":"2016-02-07T13:40:31Z","updated_at":"2016-02-07T13:40:33Z","pushed_at":"2016-02-08T13:48:06Z","git_url":"git://github.com/notnyt/barnyard2.git","ssh_url":"git@github.com:notnyt/barnyard2.git","clone_url":"https://github.com/notnyt/barnyard2.git","svn_url":"https://github.com/notnyt/barnyard2","homepage":"","size":1191,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firnsy:master","ref":"master","sha":"7254c24702392288fe6be948f88afb74040f6dc9","user":{"login":"firnsy","id":420034,"avatar_url":"https://avatars.githubusercontent.com/u/420034?v=3","gravatar_id":"","url":"https://api.github.com/users/firnsy","html_url":"https://github.com/firnsy","followers_url":"https://api.github.com/users/firnsy/followers","following_url":"https://api.github.com/users/firnsy/following{/other_user}","gists_url":"https://api.github.com/users/firnsy/gists{/gist_id}","starred_url":"https://api.github.com/users/firnsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firnsy/subscriptions","organizations_url":"https://api.github.com/users/firnsy/orgs","repos_url":"https://api.github.com/users/firnsy/repos","events_url":"https://api.github.com/users/firnsy/events{/privacy}","received_events_url":"https://api.github.com/users/firnsy/received_events","type":"User","site_admin":false},"repo":{"id":959680,"name":"barnyard2","full_name":"firnsy/barnyard2","owner":{"login":"firnsy","id":420034,"avatar_url":"https://avatars.githubusercontent.com/u/420034?v=3","gravatar_id":"","url":"https://api.github.com/users/firnsy","html_url":"https://github.com/firnsy","followers_url":"https://api.github.com/users/firnsy/followers","following_url":"https://api.github.com/users/firnsy/following{/other_user}","gists_url":"https://api.github.com/users/firnsy/gists{/gist_id}","starred_url":"https://api.github.com/users/firnsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firnsy/subscriptions","organizations_url":"https://api.github.com/users/firnsy/orgs","repos_url":"https://api.github.com/users/firnsy/repos","events_url":"https://api.github.com/users/firnsy/events{/privacy}","received_events_url":"https://api.github.com/users/firnsy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/firnsy/barnyard2","description":"Barnyard2 is a dedicated spooler for Snort's unified2 binary output format.","fork":false,"url":"https://api.github.com/repos/firnsy/barnyard2","forks_url":"https://api.github.com/repos/firnsy/barnyard2/forks","keys_url":"https://api.github.com/repos/firnsy/barnyard2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firnsy/barnyard2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firnsy/barnyard2/teams","hooks_url":"https://api.github.com/repos/firnsy/barnyard2/hooks","issue_events_url":"https://api.github.com/repos/firnsy/barnyard2/issues/events{/number}","events_url":"https://api.github.com/repos/firnsy/barnyard2/events","assignees_url":"https://api.github.com/repos/firnsy/barnyard2/assignees{/user}","branches_url":"https://api.github.com/repos/firnsy/barnyard2/branches{/branch}","tags_url":"https://api.github.com/repos/firnsy/barnyard2/tags","blobs_url":"https://api.github.com/repos/firnsy/barnyard2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firnsy/barnyard2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firnsy/barnyard2/git/refs{/sha}","trees_url":"https://api.github.com/repos/firnsy/barnyard2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firnsy/barnyard2/statuses/{sha}","languages_url":"https://api.github.com/repos/firnsy/barnyard2/languages","stargazers_url":"https://api.github.com/repos/firnsy/barnyard2/stargazers","contributors_url":"https://api.github.com/repos/firnsy/barnyard2/contributors","subscribers_url":"https://api.github.com/repos/firnsy/barnyard2/subscribers","subscription_url":"https://api.github.com/repos/firnsy/barnyard2/subscription","commits_url":"https://api.github.com/repos/firnsy/barnyard2/commits{/sha}","git_commits_url":"https://api.github.com/repos/firnsy/barnyard2/git/commits{/sha}","comments_url":"https://api.github.com/repos/firnsy/barnyard2/comments{/number}","issue_comment_url":"https://api.github.com/repos/firnsy/barnyard2/issues/comments{/number}","contents_url":"https://api.github.com/repos/firnsy/barnyard2/contents/{+path}","compare_url":"https://api.github.com/repos/firnsy/barnyard2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firnsy/barnyard2/merges","archive_url":"https://api.github.com/repos/firnsy/barnyard2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firnsy/barnyard2/downloads","issues_url":"https://api.github.com/repos/firnsy/barnyard2/issues{/number}","pulls_url":"https://api.github.com/repos/firnsy/barnyard2/pulls{/number}","milestones_url":"https://api.github.com/repos/firnsy/barnyard2/milestones{/number}","notifications_url":"https://api.github.com/repos/firnsy/barnyard2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firnsy/barnyard2/labels{/name}","releases_url":"https://api.github.com/repos/firnsy/barnyard2/releases{/id}","deployments_url":"https://api.github.com/repos/firnsy/barnyard2/deployments","created_at":"2010-10-04T04:06:16Z","updated_at":"2016-01-21T00:11:46Z","pushed_at":"2016-02-08T13:49:18Z","git_url":"git://github.com/firnsy/barnyard2.git","ssh_url":"git@github.com:firnsy/barnyard2.git","clone_url":"https://github.com/firnsy/barnyard2.git","svn_url":"https://github.com/firnsy/barnyard2","homepage":"","size":2586,"stargazers_count":155,"watchers_count":155,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":43,"forks":119,"open_issues":43,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firnsy/barnyard2/pulls/180"},"html":{"href":"https://github.com/firnsy/barnyard2/pull/180"},"issue":{"href":"https://api.github.com/repos/firnsy/barnyard2/issues/180"},"comments":{"href":"https://api.github.com/repos/firnsy/barnyard2/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/firnsy/barnyard2/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/firnsy/barnyard2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firnsy/barnyard2/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/firnsy/barnyard2/statuses/c94602ed982edba733ab26acdac9357cd360846c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":51,"deletions":19,"changed_files":8}}