{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/watchman/issues/380","repository_url":"https://api.github.com/repos/facebook/watchman","labels_url":"https://api.github.com/repos/facebook/watchman/issues/380/labels{/name}","comments_url":"https://api.github.com/repos/facebook/watchman/issues/380/comments","events_url":"https://api.github.com/repos/facebook/watchman/issues/380/events","html_url":"https://github.com/facebook/watchman/pull/380","id":186123066,"number":380,"title":"w_string_suffix return NULL if ends with '.'","user":{"login":"kaitian521","id":1303341,"avatar_url":"https://avatars.githubusercontent.com/u/1303341?v=3","gravatar_id":"","url":"https://api.github.com/users/kaitian521","html_url":"https://github.com/kaitian521","followers_url":"https://api.github.com/users/kaitian521/followers","following_url":"https://api.github.com/users/kaitian521/following{/other_user}","gists_url":"https://api.github.com/users/kaitian521/gists{/gist_id}","starred_url":"https://api.github.com/users/kaitian521/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaitian521/subscriptions","organizations_url":"https://api.github.com/users/kaitian521/orgs","repos_url":"https://api.github.com/users/kaitian521/repos","events_url":"https://api.github.com/users/kaitian521/events{/privacy}","received_events_url":"https://api.github.com/users/kaitian521/received_events","type":"User","site_admin":false},"labels":[{"id":196857356,"url":"https://api.github.com/repos/facebook/watchman/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false},{"id":274129309,"url":"https://api.github.com/repos/facebook/watchman/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-30T08:09:22Z","updated_at":"2016-10-31T18:39:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/watchman/pulls/380","html_url":"https://github.com/facebook/watchman/pull/380","diff_url":"https://github.com/facebook/watchman/pull/380.diff","patch_url":"https://github.com/facebook/watchman/pull/380.patch"},"body":"1. if a string ends with a '.', absolutely it dose not have suffix\n2. `str->len - end >= sizeof(name_buf)` is more readable and comprehensible\n"},"comment":{"url":"https://api.github.com/repos/facebook/watchman/issues/comments/257381908","html_url":"https://github.com/facebook/watchman/pull/380#issuecomment-257381908","issue_url":"https://api.github.com/repos/facebook/watchman/issues/380","id":257381908,"user":{"login":"wez","id":117777,"avatar_url":"https://avatars.githubusercontent.com/u/117777?v=3","gravatar_id":"","url":"https://api.github.com/users/wez","html_url":"https://github.com/wez","followers_url":"https://api.github.com/users/wez/followers","following_url":"https://api.github.com/users/wez/following{/other_user}","gists_url":"https://api.github.com/users/wez/gists{/gist_id}","starred_url":"https://api.github.com/users/wez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wez/subscriptions","organizations_url":"https://api.github.com/users/wez/orgs","repos_url":"https://api.github.com/users/wez/repos","events_url":"https://api.github.com/users/wez/events{/privacy}","received_events_url":"https://api.github.com/users/wez/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T18:39:52Z","updated_at":"2016-10-31T18:39:52Z","body":"Thanks for contributing!\r\n\r\nCan you also add a unit test for this function?\r\nWe don't have one today, but it should be relatively easy to add one.\r\n\r\nTake a look at `tests/argv.cpp` for an example; please add a `tests/string.cpp` file that demonstrates the expected behavior for a few different input strings, including this case where the name ends with a `.`.\r\n\r\nYou'll also need to edit `Makefile.am` and `winbuild/Makefile` to have the test build and run.\r\n"}}
{"actor":{"display_login":"wez"}}