{"action":"created","issue":{"url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/24","repository_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann","labels_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/24/comments","events_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/24/events","html_url":"https://github.com/alexandrebarachant/pyRiemann/pull/24","id":137624815,"number":24,"title":"FIX: attribute convention ala sklearn","user":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-01T16:39:24Z","updated_at":"2016-03-01T19:39:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/pulls/24","html_url":"https://github.com/alexandrebarachant/pyRiemann/pull/24","diff_url":"https://github.com/alexandrebarachant/pyRiemann/pull/24.diff","patch_url":"https://github.com/alexandrebarachant/pyRiemann/pull/24.patch"},"body":"sklearn naming convention is to have init params given by the subject without a `_` at the end and attributes created by the method with a `_`.\r\n\r\ne.g.\r\n```\r\nmyclass = MyClass(foo=1)\r\nmyclass.foo\r\nmyclass.fit()\r\nmyclass.bar_\r\n```\r\n\r\nThat's a lot of changes, some of which are backward incompatible, but I think it's generally safer to stick to their naming convention."},"comment":{"url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/comments/190868248","html_url":"https://github.com/alexandrebarachant/pyRiemann/pull/24#issuecomment-190868248","issue_url":"https://api.github.com/repos/alexandrebarachant/pyRiemann/issues/24","id":190868248,"user":{"login":"alexandrebarachant","id":2145718,"avatar_url":"https://avatars.githubusercontent.com/u/2145718?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrebarachant","html_url":"https://github.com/alexandrebarachant","followers_url":"https://api.github.com/users/alexandrebarachant/followers","following_url":"https://api.github.com/users/alexandrebarachant/following{/other_user}","gists_url":"https://api.github.com/users/alexandrebarachant/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrebarachant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrebarachant/subscriptions","organizations_url":"https://api.github.com/users/alexandrebarachant/orgs","repos_url":"https://api.github.com/users/alexandrebarachant/repos","events_url":"https://api.github.com/users/alexandrebarachant/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrebarachant/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T19:39:46Z","updated_at":"2016-03-01T19:39:46Z","body":"Thanks.\r\n\r\nFile i edited recently are supposed to be Flake8 verified and properly documented.\r\nThere are only a few files where i did not finished it: stats.py and estimation.py + some of the examples.\r\nThis is actually one of my milestone to release a new major version (see #1)\r\n"}}