{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/82514223","pull_request_review_id":3418701,"id":82514223,"diff_hunk":"@@ -100,14 +111,23 @@ int sync_cgroup(pid_t pid, CGroupUnified unified_requested) {\n \n         undo_mount = true;\n \n+        fn = strjoina(tree, cgroup);\n+        (void) rm_rf(fn, REMOVE_ROOT|REMOVE_ONLY_DIRECTORIES);","path":"src/nspawn/nspawn-cgroup.c","position":66,"original_position":66,"commit_id":"7281ab699e4ae0236c60e4c6a6a8f11b80b9ff74","original_commit_id":"7281ab699e4ae0236c60e4c6a6a8f11b80b9ff74","user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"body":"Why is this needed?","created_at":"2016-10-09T03:56:18Z","updated_at":"2016-10-09T03:56:18Z","html_url":"https://github.com/systemd/systemd/pull/4223#discussion_r82514223","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/4223","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/82514223"},"html":{"href":"https://github.com/systemd/systemd/pull/4223#discussion_r82514223"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4223"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/4223","id":86848025,"html_url":"https://github.com/systemd/systemd/pull/4223","diff_url":"https://github.com/systemd/systemd/pull/4223.diff","patch_url":"https://github.com/systemd/systemd/pull/4223.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/4223","number":4223,"state":"open","locked":false,"title":"nspawn: change the synced cgroup hierarchy permissions too","user":{"login":"evverx","id":10195800,"avatar_url":"https://avatars.githubusercontent.com/u/10195800?v=3","gravatar_id":"","url":"https://api.github.com/users/evverx","html_url":"https://github.com/evverx","followers_url":"https://api.github.com/users/evverx/followers","following_url":"https://api.github.com/users/evverx/following{/other_user}","gists_url":"https://api.github.com/users/evverx/gists{/gist_id}","starred_url":"https://api.github.com/users/evverx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evverx/subscriptions","organizations_url":"https://api.github.com/users/evverx/orgs","repos_url":"https://api.github.com/users/evverx/repos","events_url":"https://api.github.com/users/evverx/events{/privacy}","received_events_url":"https://api.github.com/users/evverx/received_events","type":"User","site_admin":false},"body":"Fixes: #4181","created_at":"2016-09-27T01:27:32Z","updated_at":"2016-10-09T03:56:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6b78a1b06ff74f45df28230c14b31ce7d911f9d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/4223/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/4223/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/4223/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/7281ab699e4ae0236c60e4c6a6a8f11b80b9ff74","head":{"label":"evverx:fix-synced-cgroup-hierarchy-perms","ref":"fix-synced-cgroup-hierarchy-perms","sha":"7281ab699e4ae0236c60e4c6a6a8f11b80b9ff74","user":{"login":"evverx","id":10195800,"avatar_url":"https://avatars.githubusercontent.com/u/10195800?v=3","gravatar_id":"","url":"https://api.github.com/users/evverx","html_url":"https://github.com/evverx","followers_url":"https://api.github.com/users/evverx/followers","following_url":"https://api.github.com/users/evverx/following{/other_user}","gists_url":"https://api.github.com/users/evverx/gists{/gist_id}","starred_url":"https://api.github.com/users/evverx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evverx/subscriptions","organizations_url":"https://api.github.com/users/evverx/orgs","repos_url":"https://api.github.com/users/evverx/repos","events_url":"https://api.github.com/users/evverx/events{/privacy}","received_events_url":"https://api.github.com/users/evverx/received_events","type":"User","site_admin":false},"repo":{"id":40683534,"name":"systemd","full_name":"evverx/systemd","owner":{"login":"evverx","id":10195800,"avatar_url":"https://avatars.githubusercontent.com/u/10195800?v=3","gravatar_id":"","url":"https://api.github.com/users/evverx","html_url":"https://github.com/evverx","followers_url":"https://api.github.com/users/evverx/followers","following_url":"https://api.github.com/users/evverx/following{/other_user}","gists_url":"https://api.github.com/users/evverx/gists{/gist_id}","starred_url":"https://api.github.com/users/evverx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evverx/subscriptions","organizations_url":"https://api.github.com/users/evverx/orgs","repos_url":"https://api.github.com/users/evverx/repos","events_url":"https://api.github.com/users/evverx/events{/privacy}","received_events_url":"https://api.github.com/users/evverx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evverx/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/evverx/systemd","forks_url":"https://api.github.com/repos/evverx/systemd/forks","keys_url":"https://api.github.com/repos/evverx/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evverx/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evverx/systemd/teams","hooks_url":"https://api.github.com/repos/evverx/systemd/hooks","issue_events_url":"https://api.github.com/repos/evverx/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/evverx/systemd/events","assignees_url":"https://api.github.com/repos/evverx/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/evverx/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/evverx/systemd/tags","blobs_url":"https://api.github.com/repos/evverx/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evverx/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evverx/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/evverx/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evverx/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/evverx/systemd/languages","stargazers_url":"https://api.github.com/repos/evverx/systemd/stargazers","contributors_url":"https://api.github.com/repos/evverx/systemd/contributors","subscribers_url":"https://api.github.com/repos/evverx/systemd/subscribers","subscription_url":"https://api.github.com/repos/evverx/systemd/subscription","commits_url":"https://api.github.com/repos/evverx/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/evverx/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/evverx/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/evverx/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/evverx/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/evverx/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evverx/systemd/merges","archive_url":"https://api.github.com/repos/evverx/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evverx/systemd/downloads","issues_url":"https://api.github.com/repos/evverx/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/evverx/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/evverx/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/evverx/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evverx/systemd/labels{/name}","releases_url":"https://api.github.com/repos/evverx/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/evverx/systemd/deployments","created_at":"2015-08-13T21:54:29Z","updated_at":"2015-08-13T21:54:34Z","pushed_at":"2016-10-01T16:15:47Z","git_url":"git://github.com/evverx/systemd.git","ssh_url":"git@github.com:evverx/systemd.git","clone_url":"https://github.com/evverx/systemd.git","svn_url":"https://github.com/evverx/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":60184,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"5fd2c135f1fd6b5147de54531940f398c6213b0c","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd upstream","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2016-10-08T16:00:55Z","pushed_at":"2016-10-08T23:43:09Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":75073,"stargazers_count":1401,"watchers_count":1401,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":592,"mirror_url":null,"open_issues_count":493,"forks":592,"open_issues":493,"watchers":1401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4223"},"html":{"href":"https://github.com/systemd/systemd/pull/4223"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/4223"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/4223/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4223/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4223/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/7281ab699e4ae0236c60e4c6a6a8f11b80b9ff74"}}}}
{"actor":{"display_login":"keszybz"}}