{"action":"closed","number":20461,"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/20461","id":84795468,"html_url":"https://github.com/tgstation/tgstation/pull/20461","diff_url":"https://github.com/tgstation/tgstation/pull/20461.diff","patch_url":"https://github.com/tgstation/tgstation/pull/20461.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/20461","number":20461,"state":"closed","locked":false,"title":"Carbon Dismemberment , second attempt.","user":{"login":"phil235","id":3476142,"avatar_url":"https://avatars.githubusercontent.com/u/3476142?v=3","gravatar_id":"","url":"https://api.github.com/users/phil235","html_url":"https://github.com/phil235","followers_url":"https://api.github.com/users/phil235/followers","following_url":"https://api.github.com/users/phil235/following{/other_user}","gists_url":"https://api.github.com/users/phil235/gists{/gist_id}","starred_url":"https://api.github.com/users/phil235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil235/subscriptions","organizations_url":"https://api.github.com/users/phil235/orgs","repos_url":"https://api.github.com/users/phil235/repos","events_url":"https://api.github.com/users/phil235/events{/privacy}","received_events_url":"https://api.github.com/users/phil235/received_events","type":"User","site_admin":false},"body":":cl: phil235\r\nadd: Monkeys can be dismembered.\r\nadd: Humans, monkeys and aliens can drop limbs when they are gibbed.\r\nadd: Roboticists can remove flashes, wires and power cells that they inserted in robot head or torso by using a crowbar on it.\r\nadd: visual wounds appear on a monkey's bodyparts when injured, exactly like humans.\r\nadd: Using a health analyzer on a monkey or alien shows the injuries to each bodypart.\r\nadd: Monkeys can become husks.\r\nfix: Human-monkey transformations now respect missing limbs. No more limb regrowth by becoming a monkey.\r\nfix: Changeling's regenerate ability also work while in monkey form.\r\nfix: Alien larva has its own gib and dust animation.\r\nfix: A bodypart that looks wounded still looks bloody when dismembered.\r\nfix: Amputation surgery now works on robotic limbs, and monkeys.\r\n/:cl:\r\n\r\n- I rearranged X_defense.dm mob files, more damage_procs.dm. Here's what's inside:\r\n * X_defense.dm: is for the procs of attacks onto the mob, all the XXX_act() proc (things happening to the mob), as well as protection check and get procs (armor, ear prot, projectile dismemberment)\r\n * damage_procs.dm: actual damage procs like adjustBruteLoss() getfireloss, any proc that handles damaging.\r\n\r\n\r\n- some bugfixes with gibspawner effects.\r\n- monkey's bodyparts can be dismembered and are used to create its icon.\r\n- <b>brains are no longer carbons.</b> :tada: \r\n- all carbon have bodyparts that can be dropped when the mob is gibbed.\r\n- adminspawned bodyparts now have a default icon.\r\n- robotic parts are now a child of bodyparts.\r\n- health analyzer on alien/monkey shows damage on each limb\r\n- added admin option to add/remove/augment bodyparts for all carbon (instead of just remove on humans)\r\n- Fixes keycheck message spam for janicart and all when trying to move.\r\n- Fixes bug with buckling to a scooter while limbless.\r\n- removed arg \"hit_zone\" in proj's on_hit() because we can already use the def_zone var (where hit_zone got its value)\r\n- Fixes mob not getting any damage when hit by a projectile on their missing limb, despite a hit message shown). carbon/apply_damage() now when we specify a def_zone and the corresponding BP is missing we default to the chest instead of stopping the proc. Consistently with how human/attacked_by() default to its attack to chest if missing limb.\r\n- Fixes mini uzi icon when empty and no mag (typo).\r\n- I renamed and changed a bit check_eye_prot and ear prot\r\n- renamed flash_eyes to flash_act()\r\n- I made a soundbang_act() similar to flash_act but for loud bangs.\r\n- added a gib and dust animation to larva.\r\n- husked monkeys\r\n- no damage overlay for husk or skeleton.\r\n- damage overlay for robotic limb now.\r\n- no damage overlay when organic bodypart husked.\r\n- one handed human with a bloody hand still get a bloody single hand overlay.\r\n- fix admin heal being unable to heal robotic bodyparts.\r\n- slightly touched robotic bodypart sprites (head one pixel too high)\r\n- Fixes #18532 \"beheaded husk has hair\".\r\n- Fixes #18584 \"Ling stasis appearance bug\"\r\n- no more eyes or lipstick on husks.\r\n- can remove flashes/wires/cells from robot chest and head with crowbar.\r\n- Fixes not being able to surgically amputate robotic arm/leg.\r\n- dropped bodyparts keep the damage overlays they had while attached.\r\n\r\n- human-monkey transformation now respects missing limbs. No more limb regrowth by becoming a monkey.\r\n- Changeling's regenerate ability also work while in monkey form.\r\n- NODISMEMBER species can still lack a limb if they were another species with a missing limb and got species-changed.\r\n- Admin heal regenerates limbs on all carbons.","created_at":"2016-09-11T19:29:35Z","updated_at":"2016-09-12T17:33:51Z","closed_at":"2016-09-12T17:33:51Z","merged_at":"2016-09-12T17:33:51Z","merge_commit_sha":"443a4501ec575c27fb8a4844ca314c070513e57e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/20461/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/20461/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/20461/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/4af45cee9d416f23f975bb566d262ed7a396967f","head":{"label":"phil235:DismembermentBoogaloo2","ref":"DismembermentBoogaloo2","sha":"4af45cee9d416f23f975bb566d262ed7a396967f","user":{"login":"phil235","id":3476142,"avatar_url":"https://avatars.githubusercontent.com/u/3476142?v=3","gravatar_id":"","url":"https://api.github.com/users/phil235","html_url":"https://github.com/phil235","followers_url":"https://api.github.com/users/phil235/followers","following_url":"https://api.github.com/users/phil235/following{/other_user}","gists_url":"https://api.github.com/users/phil235/gists{/gist_id}","starred_url":"https://api.github.com/users/phil235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil235/subscriptions","organizations_url":"https://api.github.com/users/phil235/orgs","repos_url":"https://api.github.com/users/phil235/repos","events_url":"https://api.github.com/users/phil235/events{/privacy}","received_events_url":"https://api.github.com/users/phil235/received_events","type":"User","site_admin":false},"repo":{"id":23807273,"name":"-tg-station","full_name":"phil235/-tg-station","owner":{"login":"phil235","id":3476142,"avatar_url":"https://avatars.githubusercontent.com/u/3476142?v=3","gravatar_id":"","url":"https://api.github.com/users/phil235","html_url":"https://github.com/phil235","followers_url":"https://api.github.com/users/phil235/followers","following_url":"https://api.github.com/users/phil235/following{/other_user}","gists_url":"https://api.github.com/users/phil235/gists{/gist_id}","starred_url":"https://api.github.com/users/phil235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil235/subscriptions","organizations_url":"https://api.github.com/users/phil235/orgs","repos_url":"https://api.github.com/users/phil235/repos","events_url":"https://api.github.com/users/phil235/events{/privacy}","received_events_url":"https://api.github.com/users/phil235/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phil235/-tg-station","description":"/tg/'s SS13 branch","fork":true,"url":"https://api.github.com/repos/phil235/-tg-station","forks_url":"https://api.github.com/repos/phil235/-tg-station/forks","keys_url":"https://api.github.com/repos/phil235/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phil235/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phil235/-tg-station/teams","hooks_url":"https://api.github.com/repos/phil235/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/phil235/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/phil235/-tg-station/events","assignees_url":"https://api.github.com/repos/phil235/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/phil235/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/phil235/-tg-station/tags","blobs_url":"https://api.github.com/repos/phil235/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phil235/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phil235/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/phil235/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phil235/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/phil235/-tg-station/languages","stargazers_url":"https://api.github.com/repos/phil235/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/phil235/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/phil235/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/phil235/-tg-station/subscription","commits_url":"https://api.github.com/repos/phil235/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/phil235/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/phil235/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/phil235/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/phil235/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/phil235/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phil235/-tg-station/merges","archive_url":"https://api.github.com/repos/phil235/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phil235/-tg-station/downloads","issues_url":"https://api.github.com/repos/phil235/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/phil235/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/phil235/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/phil235/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phil235/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/phil235/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/phil235/-tg-station/deployments","created_at":"2014-09-08T20:34:40Z","updated_at":"2016-02-25T12:01:02Z","pushed_at":"2016-09-12T16:18:20Z","git_url":"git://github.com/phil235/-tg-station.git","ssh_url":"git@github.com:phil235/-tg-station.git","clone_url":"https://github.com/phil235/-tg-station.git","svn_url":"https://github.com/phil235/-tg-station","homepage":"http://www.tgstation13.org/","size":651371,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"2a58dd54a95060c22dfbcef0ca32027103854d61","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2016-09-10T22:42:25Z","pushed_at":"2016-09-12T17:33:51Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"git@github.com:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"http://www.tgstation13.org/","size":1559257,"stargazers_count":314,"watchers_count":314,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1134,"mirror_url":null,"open_issues_count":898,"forks":1134,"open_issues":898,"watchers":314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/20461"},"html":{"href":"https://github.com/tgstation/tgstation/pull/20461"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/20461"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/20461/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/20461/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/20461/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/4af45cee9d416f23f975bb566d262ed7a396967f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"AnturK","id":4047233,"avatar_url":"https://avatars.githubusercontent.com/u/4047233?v=3","gravatar_id":"","url":"https://api.github.com/users/AnturK","html_url":"https://github.com/AnturK","followers_url":"https://api.github.com/users/AnturK/followers","following_url":"https://api.github.com/users/AnturK/following{/other_user}","gists_url":"https://api.github.com/users/AnturK/gists{/gist_id}","starred_url":"https://api.github.com/users/AnturK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnturK/subscriptions","organizations_url":"https://api.github.com/users/AnturK/orgs","repos_url":"https://api.github.com/users/AnturK/repos","events_url":"https://api.github.com/users/AnturK/events{/privacy}","received_events_url":"https://api.github.com/users/AnturK/received_events","type":"User","site_admin":false},"comments":2,"review_comments":7,"commits":10,"additions":4931,"deletions":4121,"changed_files":234}}
{"actor":{"display_login":"AnturK"}}