{"action":"created","comment":{"url":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/comments/89579322","pull_request_review_id":10124018,"id":89579322,"diff_hunk":"@@ -0,0 +1,43 @@\n+<?php\n+\n+namespace Sulu\\Bundle\\FormBundle\\Dynamic;\n+\n+class FormFieldTypePool\n+{\n+    /**\n+     * @var FormFieldTypeInterface[]\n+     */\n+    private $types;\n+\n+    public function __construct()","path":"Dynamic/FormFieldTypePool.php","position":12,"original_position":12,"commit_id":"12d03ff429c84155b2ad4a3e41e3e205b8a42731","original_commit_id":"12d03ff429c84155b2ad4a3e41e3e205b8a42731","user":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"body":"add argument for types they will be passed by the compiler pass. then you can remove the add function","created_at":"2016-11-25T08:35:46Z","updated_at":"2016-11-25T08:38:00Z","html_url":"https://github.com/sulu/SuluFormBundle/pull/13#discussion_r89579322","pull_request_url":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/comments/89579322"},"html":{"href":"https://github.com/sulu/SuluFormBundle/pull/13#discussion_r89579322"},"pull_request":{"href":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/13","id":95200498,"html_url":"https://github.com/sulu/SuluFormBundle/pull/13","diff_url":"https://github.com/sulu/SuluFormBundle/pull/13.diff","patch_url":"https://github.com/sulu/SuluFormBundle/pull/13.patch","issue_url":"https://api.github.com/repos/sulu/SuluFormBundle/issues/13","number":13,"state":"open","locked":false,"title":"Feature/4 custom types","user":{"login":"rs2487","id":1167787,"avatar_url":"https://avatars.githubusercontent.com/u/1167787?v=3","gravatar_id":"","url":"https://api.github.com/users/rs2487","html_url":"https://github.com/rs2487","followers_url":"https://api.github.com/users/rs2487/followers","following_url":"https://api.github.com/users/rs2487/following{/other_user}","gists_url":"https://api.github.com/users/rs2487/gists{/gist_id}","starred_url":"https://api.github.com/users/rs2487/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs2487/subscriptions","organizations_url":"https://api.github.com/users/rs2487/orgs","repos_url":"https://api.github.com/users/rs2487/repos","events_url":"https://api.github.com/users/rs2487/events{/privacy}","received_events_url":"https://api.github.com/users/rs2487/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-24T15:52:06Z","updated_at":"2016-11-25T08:38:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb3693d1b5deaed9b82ac3d0dfdce7407dc59c3d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/13/commits","review_comments_url":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/13/comments","review_comment_url":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu/SuluFormBundle/issues/13/comments","statuses_url":"https://api.github.com/repos/sulu/SuluFormBundle/statuses/12d03ff429c84155b2ad4a3e41e3e205b8a42731","head":{"label":"rs2487:feature/4-custom-types","ref":"feature/4-custom-types","sha":"12d03ff429c84155b2ad4a3e41e3e205b8a42731","user":{"login":"rs2487","id":1167787,"avatar_url":"https://avatars.githubusercontent.com/u/1167787?v=3","gravatar_id":"","url":"https://api.github.com/users/rs2487","html_url":"https://github.com/rs2487","followers_url":"https://api.github.com/users/rs2487/followers","following_url":"https://api.github.com/users/rs2487/following{/other_user}","gists_url":"https://api.github.com/users/rs2487/gists{/gist_id}","starred_url":"https://api.github.com/users/rs2487/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs2487/subscriptions","organizations_url":"https://api.github.com/users/rs2487/orgs","repos_url":"https://api.github.com/users/rs2487/repos","events_url":"https://api.github.com/users/rs2487/events{/privacy}","received_events_url":"https://api.github.com/users/rs2487/received_events","type":"User","site_admin":false},"repo":{"id":73460442,"name":"SuluFormBundle","full_name":"rs2487/SuluFormBundle","owner":{"login":"rs2487","id":1167787,"avatar_url":"https://avatars.githubusercontent.com/u/1167787?v=3","gravatar_id":"","url":"https://api.github.com/users/rs2487","html_url":"https://github.com/rs2487","followers_url":"https://api.github.com/users/rs2487/followers","following_url":"https://api.github.com/users/rs2487/following{/other_user}","gists_url":"https://api.github.com/users/rs2487/gists{/gist_id}","starred_url":"https://api.github.com/users/rs2487/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs2487/subscriptions","organizations_url":"https://api.github.com/users/rs2487/orgs","repos_url":"https://api.github.com/users/rs2487/repos","events_url":"https://api.github.com/users/rs2487/events{/privacy}","received_events_url":"https://api.github.com/users/rs2487/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rs2487/SuluFormBundle","description":"Form Bundle for handling Dynamic and Symfony Forms in http://sulu.io","fork":true,"url":"https://api.github.com/repos/rs2487/SuluFormBundle","forks_url":"https://api.github.com/repos/rs2487/SuluFormBundle/forks","keys_url":"https://api.github.com/repos/rs2487/SuluFormBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rs2487/SuluFormBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rs2487/SuluFormBundle/teams","hooks_url":"https://api.github.com/repos/rs2487/SuluFormBundle/hooks","issue_events_url":"https://api.github.com/repos/rs2487/SuluFormBundle/issues/events{/number}","events_url":"https://api.github.com/repos/rs2487/SuluFormBundle/events","assignees_url":"https://api.github.com/repos/rs2487/SuluFormBundle/assignees{/user}","branches_url":"https://api.github.com/repos/rs2487/SuluFormBundle/branches{/branch}","tags_url":"https://api.github.com/repos/rs2487/SuluFormBundle/tags","blobs_url":"https://api.github.com/repos/rs2487/SuluFormBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rs2487/SuluFormBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rs2487/SuluFormBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/rs2487/SuluFormBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rs2487/SuluFormBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/rs2487/SuluFormBundle/languages","stargazers_url":"https://api.github.com/repos/rs2487/SuluFormBundle/stargazers","contributors_url":"https://api.github.com/repos/rs2487/SuluFormBundle/contributors","subscribers_url":"https://api.github.com/repos/rs2487/SuluFormBundle/subscribers","subscription_url":"https://api.github.com/repos/rs2487/SuluFormBundle/subscription","commits_url":"https://api.github.com/repos/rs2487/SuluFormBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/rs2487/SuluFormBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/rs2487/SuluFormBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/rs2487/SuluFormBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/rs2487/SuluFormBundle/contents/{+path}","compare_url":"https://api.github.com/repos/rs2487/SuluFormBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rs2487/SuluFormBundle/merges","archive_url":"https://api.github.com/repos/rs2487/SuluFormBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rs2487/SuluFormBundle/downloads","issues_url":"https://api.github.com/repos/rs2487/SuluFormBundle/issues{/number}","pulls_url":"https://api.github.com/repos/rs2487/SuluFormBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/rs2487/SuluFormBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/rs2487/SuluFormBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rs2487/SuluFormBundle/labels{/name}","releases_url":"https://api.github.com/repos/rs2487/SuluFormBundle/releases{/id}","deployments_url":"https://api.github.com/repos/rs2487/SuluFormBundle/deployments","created_at":"2016-11-11T08:39:54Z","updated_at":"2016-11-11T08:39:55Z","pushed_at":"2016-11-25T07:53:38Z","git_url":"git://github.com/rs2487/SuluFormBundle.git","ssh_url":"git@github.com:rs2487/SuluFormBundle.git","clone_url":"https://github.com/rs2487/SuluFormBundle.git","svn_url":"https://github.com/rs2487/SuluFormBundle","homepage":"","size":346,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sulu:master","ref":"master","sha":"08f459330411fcfae9bc47652caee22993b1f412","user":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"repo":{"id":67773401,"name":"SuluFormBundle","full_name":"sulu/SuluFormBundle","owner":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu/SuluFormBundle","description":"Form Bundle for handling Dynamic and Symfony Forms in http://sulu.io","fork":false,"url":"https://api.github.com/repos/sulu/SuluFormBundle","forks_url":"https://api.github.com/repos/sulu/SuluFormBundle/forks","keys_url":"https://api.github.com/repos/sulu/SuluFormBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu/SuluFormBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu/SuluFormBundle/teams","hooks_url":"https://api.github.com/repos/sulu/SuluFormBundle/hooks","issue_events_url":"https://api.github.com/repos/sulu/SuluFormBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sulu/SuluFormBundle/events","assignees_url":"https://api.github.com/repos/sulu/SuluFormBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sulu/SuluFormBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sulu/SuluFormBundle/tags","blobs_url":"https://api.github.com/repos/sulu/SuluFormBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu/SuluFormBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu/SuluFormBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu/SuluFormBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu/SuluFormBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu/SuluFormBundle/languages","stargazers_url":"https://api.github.com/repos/sulu/SuluFormBundle/stargazers","contributors_url":"https://api.github.com/repos/sulu/SuluFormBundle/contributors","subscribers_url":"https://api.github.com/repos/sulu/SuluFormBundle/subscribers","subscription_url":"https://api.github.com/repos/sulu/SuluFormBundle/subscription","commits_url":"https://api.github.com/repos/sulu/SuluFormBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu/SuluFormBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu/SuluFormBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu/SuluFormBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu/SuluFormBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sulu/SuluFormBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu/SuluFormBundle/merges","archive_url":"https://api.github.com/repos/sulu/SuluFormBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu/SuluFormBundle/downloads","issues_url":"https://api.github.com/repos/sulu/SuluFormBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sulu/SuluFormBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu/SuluFormBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu/SuluFormBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu/SuluFormBundle/labels{/name}","releases_url":"https://api.github.com/repos/sulu/SuluFormBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sulu/SuluFormBundle/deployments","created_at":"2016-09-09T06:42:28Z","updated_at":"2016-10-24T09:44:08Z","pushed_at":"2016-11-25T07:53:38Z","git_url":"git://github.com/sulu/SuluFormBundle.git","ssh_url":"git@github.com:sulu/SuluFormBundle.git","clone_url":"https://github.com/sulu/SuluFormBundle.git","svn_url":"https://github.com/sulu/SuluFormBundle","homepage":"","size":358,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/13"},"html":{"href":"https://github.com/sulu/SuluFormBundle/pull/13"},"issue":{"href":"https://api.github.com/repos/sulu/SuluFormBundle/issues/13"},"comments":{"href":"https://api.github.com/repos/sulu/SuluFormBundle/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu/SuluFormBundle/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/sulu/SuluFormBundle/statuses/12d03ff429c84155b2ad4a3e41e3e205b8a42731"}}}}
{"actor":{"display_login":"wachterjohannes"}}