{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments/61533152","id":61533152,"diff_hunk":"@@ -13,14 +14,8 @@ namespace Microsoft.VisualStudio.R.Package.DataInspect.DataSource {\n     public class GridDataSource {\n         public static async Task<IGridData<string>> GetGridDataAsync(string expression, GridRange? gridRange, IRSession rSession = null) {\n             await TaskUtilities.SwitchToBackgroundThread();\n-\n-            if (rSession == null) {\n-                rSession = VsAppShell.Current.ExportProvider.GetExportedValue<IRSessionProvider>().GetInteractiveWindowRSession();\n-                if (rSession == null) {\n-                    throw new InvalidOperationException(Invariant($\"{nameof(IRSessionProvider)} failed to return RSession for {nameof(VariableViewModel)}\"));\n-                }\n-            }\n-\n+            rSession = rSession ?? VsAppShell.Current.ExportProvider.GetExportedValue<IRSessionProvider>().GetInteractiveWindowRSession();","path":"src/Package/Impl/DataInspect/DataSource/GridDataSource.cs","position":20,"original_position":20,"commit_id":"60811716edc24cdaedc80832f73f5443be77c37b","original_commit_id":"60811716edc24cdaedc80832f73f5443be77c37b","user":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars.githubusercontent.com/u/12820357?v=3","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"body":"It is passed as null in data import dialog. Not entirely sure why, we can probably change this and have it always non-null","created_at":"2016-04-29T04:17:17Z","updated_at":"2016-04-29T04:17:17Z","html_url":"https://github.com/Microsoft/RTVS/pull/1716#discussion_r61533152","pull_request_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/1716","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments/61533152"},"html":{"href":"https://github.com/Microsoft/RTVS/pull/1716#discussion_r61533152"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/1716"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/RTVS/pulls/1716","id":68322689,"html_url":"https://github.com/Microsoft/RTVS/pull/1716","diff_url":"https://github.com/Microsoft/RTVS/pull/1716.diff","patch_url":"https://github.com/Microsoft/RTVS/pull/1716.patch","issue_url":"https://api.github.com/repos/Microsoft/RTVS/issues/1716","number":1716,"state":"open","locked":false,"title":"Viewer tests","user":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars.githubusercontent.com/u/12820357?v=3","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"body":"- Split classes and add extra checks\r\n- Fix whatever was discovered during test writing\r\n- Add interfaces to couple of DebugEval classes so they can be mocked/substituted. We can add more as needed.","created_at":"2016-04-29T04:07:54Z","updated_at":"2016-04-29T04:17:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88aa31d9016806061bc5abc315e0154c8814eca2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/1716/commits","review_comments_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/1716/comments","review_comment_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/issues/1716/comments","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/60811716edc24cdaedc80832f73f5443be77c37b","head":{"label":"MikhailArkhipov:master","ref":"master","sha":"60811716edc24cdaedc80832f73f5443be77c37b","user":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars.githubusercontent.com/u/12820357?v=3","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"repo":{"id":53517720,"name":"RTVS","full_name":"MikhailArkhipov/RTVS","owner":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars.githubusercontent.com/u/12820357?v=3","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikhailArkhipov/RTVS","description":"R Tools for Visual Studio.","fork":true,"url":"https://api.github.com/repos/MikhailArkhipov/RTVS","forks_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/forks","keys_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/teams","hooks_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/hooks","issue_events_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/events","assignees_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/tags","blobs_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/languages","stargazers_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/stargazers","contributors_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/contributors","subscribers_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/subscribers","subscription_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/subscription","commits_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/merges","archive_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/downloads","issues_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/deployments","created_at":"2016-03-09T17:33:45Z","updated_at":"2016-03-09T17:33:51Z","pushed_at":"2016-04-29T03:52:49Z","git_url":"git://github.com/MikhailArkhipov/RTVS.git","ssh_url":"git@github.com:MikhailArkhipov/RTVS.git","clone_url":"https://github.com/MikhailArkhipov/RTVS.git","svn_url":"https://github.com/MikhailArkhipov/RTVS","homepage":null,"size":45745,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"fa25a7a37a37adca3602f59ae77b4f1e1e24bff2","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38640473,"name":"RTVS","full_name":"Microsoft/RTVS","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/RTVS","description":"R Tools for Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/RTVS","forks_url":"https://api.github.com/repos/Microsoft/RTVS/forks","keys_url":"https://api.github.com/repos/Microsoft/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/RTVS/teams","hooks_url":"https://api.github.com/repos/Microsoft/RTVS/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/RTVS/events","assignees_url":"https://api.github.com/repos/Microsoft/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/RTVS/tags","blobs_url":"https://api.github.com/repos/Microsoft/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/RTVS/languages","stargazers_url":"https://api.github.com/repos/Microsoft/RTVS/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/RTVS/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/RTVS/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/RTVS/subscription","commits_url":"https://api.github.com/repos/Microsoft/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/RTVS/merges","archive_url":"https://api.github.com/repos/Microsoft/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/RTVS/downloads","issues_url":"https://api.github.com/repos/Microsoft/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/RTVS/deployments","created_at":"2015-07-06T19:14:09Z","updated_at":"2016-04-28T22:46:11Z","pushed_at":"2016-04-29T04:07:55Z","git_url":"git://github.com/Microsoft/RTVS.git","ssh_url":"git@github.com:Microsoft/RTVS.git","clone_url":"https://github.com/Microsoft/RTVS.git","svn_url":"https://github.com/Microsoft/RTVS","homepage":null,"size":45759,"stargazers_count":134,"watchers_count":134,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":265,"forks":25,"open_issues":265,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/1716"},"html":{"href":"https://github.com/Microsoft/RTVS/pull/1716"},"issue":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/1716"},"comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/1716/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/1716/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/1716/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/RTVS/statuses/60811716edc24cdaedc80832f73f5443be77c37b"}}}}