{"action":"closed","number":640,"pull_request":{"url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/640","id":93210978,"html_url":"https://github.com/sul-dlss/sul-requests/pull/640","diff_url":"https://github.com/sul-dlss/sul-requests/pull/640.diff","patch_url":"https://github.com/sul-dlss/sul-requests/pull/640.patch","issue_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/640","number":640,"state":"closed","locked":false,"title":"requests dashboard filter by type","user":{"login":"jmartin-sul","id":7741604,"avatar_url":"https://avatars.githubusercontent.com/u/7741604?v=3","gravatar_id":"","url":"https://api.github.com/users/jmartin-sul","html_url":"https://github.com/jmartin-sul","followers_url":"https://api.github.com/users/jmartin-sul/followers","following_url":"https://api.github.com/users/jmartin-sul/following{/other_user}","gists_url":"https://api.github.com/users/jmartin-sul/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartin-sul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartin-sul/subscriptions","organizations_url":"https://api.github.com/users/jmartin-sul/orgs","repos_url":"https://api.github.com/users/jmartin-sul/repos","events_url":"https://api.github.com/users/jmartin-sul/events{/privacy}","received_events_url":"https://api.github.com/users/jmartin-sul/received_events","type":"User","site_admin":false},"body":"allows users to filter the requests dashboard by type.  each type name (under its respective count) links to a version of the page filtered by type.  if a type filter is on, an `[x]` link to its right provides a way to remove that filter and show all requests.  i was just running with @jkeck's idea for how to implement this simply, it could definitely use design vetting from @jvine.\r\n\r\nattaching screenshots from the capybara tests because i did something to mess up my local test data when instantiating test objects from the factory, and the default unfiltered version of the page now 500s on me.  would be nice to test this manually, either locally or on stage, before merging.\r\n\r\n![capybara-201611101050404614639155](https://cloud.githubusercontent.com/assets/7741604/20190205/5246cffa-a735-11e6-857c-eed27de8f98c.png)\r\n\r\n![capybara-201611101050402221951178](https://cloud.githubusercontent.com/assets/7741604/20190233/6e2fcd16-a735-11e6-856e-2045f70b1add.png)\r\n\r\n![capybara-201611101050401483245569](https://cloud.githubusercontent.com/assets/7741604/20190247/79112f18-a735-11e6-9f25-56143fe85fda.png)\r\n\r\ncloses #625 ","created_at":"2016-11-10T19:06:06Z","updated_at":"2016-11-11T01:00:51Z","closed_at":"2016-11-11T01:00:51Z","merged_at":"2016-11-11T01:00:51Z","merge_commit_sha":"35d7e5b97096f691cf5a66ac062fb13e19ea6ded","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/640/commits","review_comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/640/comments","review_comment_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/640/comments","statuses_url":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/4b632786adbed6f9c026135441f439e1ccc2c6d6","head":{"label":"sul-dlss:625-reqs-dashboard-filter-by-type","ref":"625-reqs-dashboard-filter-by-type","sha":"4b632786adbed6f9c026135441f439e1ccc2c6d6","user":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":33213527,"name":"sul-requests","full_name":"sul-dlss/sul-requests","owner":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/sul-requests","description":"Rails application for requesting materials from Stanford University Library","fork":false,"url":"https://api.github.com/repos/sul-dlss/sul-requests","forks_url":"https://api.github.com/repos/sul-dlss/sul-requests/forks","keys_url":"https://api.github.com/repos/sul-dlss/sul-requests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/sul-requests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/sul-requests/teams","hooks_url":"https://api.github.com/repos/sul-dlss/sul-requests/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/sul-requests/events","assignees_url":"https://api.github.com/repos/sul-dlss/sul-requests/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/sul-requests/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/tags","blobs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/sul-requests/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/sul-requests/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/sul-requests/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscription","commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/sul-requests/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/sul-requests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/sul-requests/merges","archive_url":"https://api.github.com/repos/sul-dlss/sul-requests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/sul-requests/downloads","issues_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/sul-requests/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/sul-requests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/sul-requests/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/sul-requests/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/sul-requests/deployments","created_at":"2015-03-31T22:27:27Z","updated_at":"2016-10-24T18:50:41Z","pushed_at":"2016-11-11T01:00:52Z","git_url":"git://github.com/sul-dlss/sul-requests.git","ssh_url":"git@github.com:sul-dlss/sul-requests.git","clone_url":"https://github.com/sul-dlss/sul-requests.git","svn_url":"https://github.com/sul-dlss/sul-requests","homepage":null,"size":2965,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":33,"forks":0,"open_issues":33,"watchers":2,"default_branch":"master"}},"base":{"label":"sul-dlss:master","ref":"master","sha":"96adbbb729544c61b80e878500eb17ca4527b061","user":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":33213527,"name":"sul-requests","full_name":"sul-dlss/sul-requests","owner":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/sul-requests","description":"Rails application for requesting materials from Stanford University Library","fork":false,"url":"https://api.github.com/repos/sul-dlss/sul-requests","forks_url":"https://api.github.com/repos/sul-dlss/sul-requests/forks","keys_url":"https://api.github.com/repos/sul-dlss/sul-requests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/sul-requests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/sul-requests/teams","hooks_url":"https://api.github.com/repos/sul-dlss/sul-requests/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/sul-requests/events","assignees_url":"https://api.github.com/repos/sul-dlss/sul-requests/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/sul-requests/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/tags","blobs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/sul-requests/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/sul-requests/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/sul-requests/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscription","commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/sul-requests/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/sul-requests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/sul-requests/merges","archive_url":"https://api.github.com/repos/sul-dlss/sul-requests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/sul-requests/downloads","issues_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/sul-requests/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/sul-requests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/sul-requests/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/sul-requests/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/sul-requests/deployments","created_at":"2015-03-31T22:27:27Z","updated_at":"2016-10-24T18:50:41Z","pushed_at":"2016-11-11T01:00:52Z","git_url":"git://github.com/sul-dlss/sul-requests.git","ssh_url":"git@github.com:sul-dlss/sul-requests.git","clone_url":"https://github.com/sul-dlss/sul-requests.git","svn_url":"https://github.com/sul-dlss/sul-requests","homepage":null,"size":2965,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":33,"forks":0,"open_issues":33,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/640"},"html":{"href":"https://github.com/sul-dlss/sul-requests/pull/640"},"issue":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/issues/640"},"comments":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/issues/640/comments"},"review_comments":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/640/comments"},"review_comment":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/640/commits"},"statuses":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/4b632786adbed6f9c026135441f439e1ccc2c6d6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jkeck","id":96776,"avatar_url":"https://avatars.githubusercontent.com/u/96776?v=3","gravatar_id":"","url":"https://api.github.com/users/jkeck","html_url":"https://github.com/jkeck","followers_url":"https://api.github.com/users/jkeck/followers","following_url":"https://api.github.com/users/jkeck/following{/other_user}","gists_url":"https://api.github.com/users/jkeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jkeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkeck/subscriptions","organizations_url":"https://api.github.com/users/jkeck/orgs","repos_url":"https://api.github.com/users/jkeck/repos","events_url":"https://api.github.com/users/jkeck/events{/privacy}","received_events_url":"https://api.github.com/users/jkeck/received_events","type":"User","site_admin":false},"comments":4,"review_comments":4,"commits":2,"additions":69,"deletions":3,"changed_files":5}}
{"actor":{"display_login":"jkeck"}}