{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/53473239","id":53473239,"diff_hunk":"@@ -232,6 +232,8 @@ public MessageProperties toMessageProperties(AMQP.BasicProperties source, Envelo\n \n \tprivate volatile int defaultTxSize = DEFAULT_TX_SIZE;\n \n+\tprotected volatile boolean defaultDurableSubscription = true;\n+","path":"spring-cloud-stream-binders/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/RabbitMessageChannelBinder.java","position":39,"original_position":39,"commit_id":"54008f0ad71e50d612f38839b6d386306dd6a6be","original_commit_id":"54008f0ad71e50d612f38839b6d386306dd6a6be","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"body":"I think https://github.com/spring-cloud/spring-cloud-stream/pull/360/files#r53472658 answers it :)","created_at":"2016-02-19T15:22:55Z","updated_at":"2016-02-19T15:22:55Z","html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/360#discussion_r53473239","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/360","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/53473239"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/360#discussion_r53473239"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/360","id":59910651,"html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/360","diff_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/360.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/360.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/360","number":360,"state":"open","locked":false,"title":"Durability configuration and default groups","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"body":"Resolves #317\r\n\r\nRemove the `durable` binder configuration property\r\nMake subscriber groups durable by default\r\nIntroduce `requiredGroups` property\r\nKafka groups (non-anonymous) now start by default at EARLIEST, which is more appropriate for new stream consumers","created_at":"2016-02-19T06:43:05Z","updated_at":"2016-02-19T15:22:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f073d6246e7968347708529d04a8f227ce5a6345","assignee":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/360/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/360/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/360/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/54008f0ad71e50d612f38839b6d386306dd6a6be","head":{"label":"mbogoevici:GH-317","ref":"GH-317","sha":"54008f0ad71e50d612f38839b6d386306dd6a6be","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"repo":{"id":38768510,"name":"spring-cloud-stream","full_name":"mbogoevici/spring-cloud-stream","owner":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbogoevici/spring-cloud-stream","description":"Messaging Microservices with Spring Integration","fork":true,"url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream","forks_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/releases{/id}","deployments_url":"https://api.github.com/repos/mbogoevici/spring-cloud-stream/deployments","created_at":"2015-07-08T17:15:48Z","updated_at":"2016-01-13T21:40:39Z","pushed_at":"2016-02-19T06:41:44Z","git_url":"git://github.com/mbogoevici/spring-cloud-stream.git","ssh_url":"git@github.com:mbogoevici/spring-cloud-stream.git","clone_url":"https://github.com/mbogoevici/spring-cloud-stream.git","svn_url":"https://github.com/mbogoevici/spring-cloud-stream","homepage":null,"size":1858,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"706711eaf8fa833afc5426ba3ea9b7cfba71db15","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":38764029,"name":"spring-cloud-stream","full_name":"spring-cloud/spring-cloud-stream","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-stream","description":"Messaging Microservices with Spring Integration","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/deployments","created_at":"2015-07-08T15:51:38Z","updated_at":"2016-02-17T21:54:51Z","pushed_at":"2016-02-19T14:09:59Z","git_url":"git://github.com/spring-cloud/spring-cloud-stream.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-stream.git","clone_url":"https://github.com/spring-cloud/spring-cloud-stream.git","svn_url":"https://github.com/spring-cloud/spring-cloud-stream","homepage":"http://cloud.spring.io/spring-cloud-stream/","size":3118,"stargazers_count":39,"watchers_count":39,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"open_issues_count":60,"forks":35,"open_issues":60,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/360"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/360"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/360"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/54008f0ad71e50d612f38839b6d386306dd6a6be"}}}}