{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7439","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7439/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7439/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7439/events","html_url":"https://github.com/ManageIQ/manageiq/pull/7439","id":142410306,"number":7439,"title":"Azure:  Event support","user":{"login":"bronaghs","id":4379675,"avatar_url":"https://avatars.githubusercontent.com/u/4379675?v=3","gravatar_id":"","url":"https://api.github.com/users/bronaghs","html_url":"https://github.com/bronaghs","followers_url":"https://api.github.com/users/bronaghs/followers","following_url":"https://api.github.com/users/bronaghs/following{/other_user}","gists_url":"https://api.github.com/users/bronaghs/gists{/gist_id}","starred_url":"https://api.github.com/users/bronaghs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bronaghs/subscriptions","organizations_url":"https://api.github.com/users/bronaghs/orgs","repos_url":"https://api.github.com/users/bronaghs/repos","events_url":"https://api.github.com/users/bronaghs/events{/privacy}","received_events_url":"https://api.github.com/users/bronaghs/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/events","name":"events","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/gem%20changes","name":"gem changes","color":"6A92BC"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/azure","name":"providers/azure","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-03-21T17:02:07Z","updated_at":"2016-04-12T15:27:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7439","html_url":"https://github.com/ManageIQ/manageiq/pull/7439","diff_url":"https://github.com/ManageIQ/manageiq/pull/7439.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7439.patch"},"body":"## Event support for Azure. \r\n\r\n### A couple of points to note:\r\n\r\n* There is no payload included in the Azure event making it difficult to gather details.\r\n\r\n* The Azure \"write\" event is fired after any configuration change has been made to a VM e.g. a change of flavor assignment, the addition of a new data disk etc, but it also is fired upon the creation of a new VM. Given the lack of payload and absence of any description, it is impossible to determine which scenario triggered the event.  \r\n\r\nCorresponding Trello card:\r\nhttps://trello.com/c/QnXCQPZj/50-3-azure-events-event-mappings"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/208961513","html_url":"https://github.com/ManageIQ/manageiq/pull/7439#issuecomment-208961513","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7439","id":208961513,"user":{"login":"durandom","id":161888,"avatar_url":"https://avatars.githubusercontent.com/u/161888?v=3","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false},"created_at":"2016-04-12T15:27:05Z","updated_at":"2016-04-12T15:27:05Z","body":"looks good to me, nice job @bronaghs 👍 \r\n\r\nonly as a side note for future specs, if you run this...\r\n```\r\n❯ be rspec --format documentation spec/models/manageiq/providers/azure/cloud_manager/event_catcher/runner_spec.rb\r\n\r\nManageIQ::Providers::Azure::CloudManager::EventCatcher::Runner\r\n  parsing properties\r\n    parse properties\r\n      event type\r\n      vm ref\r\n```\r\n...it should read like documentation. That also helps reading the specs in order to get a clue on how the code is supposed to work and to fix broken specs. It also helps structuring the specs in a nice clean way. "}}