{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments/81196295","pull_request_review_id":2194296,"id":81196295,"diff_hunk":"@@ -116,6 +117,19 @@ JitsiConference.prototype._init = function (options) {\n     // Always add listeners because on reload we are executing leave and the\n     // listeners are removed from statistics module.\n     this.eventManager.setupStatisticsListeners();\n+\n+    if (this.options.config.enableTalkWhileMuted) {\n+        this.talkMutedDetection\n+            = new TalkMutedDetection(() => {\n+                this.eventEmitter.emit(JitsiConferenceEvents.TALK_WHILE_MUTED);","path":"JitsiConference.js","position":16,"original_position":16,"commit_id":"a08ec825c82fb78092e68f15896db9b3bf646d48","original_commit_id":"a08ec825c82fb78092e68f15896db9b3bf646d48","user":{"login":"lyubomir","id":3251887,"avatar_url":"https://avatars.githubusercontent.com/u/3251887?v=3","gravatar_id":"","url":"https://api.github.com/users/lyubomir","html_url":"https://github.com/lyubomir","followers_url":"https://api.github.com/users/lyubomir/followers","following_url":"https://api.github.com/users/lyubomir/following{/other_user}","gists_url":"https://api.github.com/users/lyubomir/gists{/gist_id}","starred_url":"https://api.github.com/users/lyubomir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyubomir/subscriptions","organizations_url":"https://api.github.com/users/lyubomir/orgs","repos_url":"https://api.github.com/users/lyubomir/repos","events_url":"https://api.github.com/users/lyubomir/events{/privacy}","received_events_url":"https://api.github.com/users/lyubomir/received_events","type":"User","site_admin":false},"body":"Why is `TALK_WHILE_MUTED` an event of `JitsiConference`? Reading `TalkMutedDetection`, it looks to me like it's mostly about the local audio track so I'm wondering why `TALK_WHILE_MUTED` is not an event of the local audio track.","created_at":"2016-09-29T17:55:30Z","updated_at":"2016-09-29T17:55:30Z","html_url":"https://github.com/jitsi/lib-jitsi-meet/pull/242#discussion_r81196295","pull_request_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/242","_links":{"self":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments/81196295"},"html":{"href":"https://github.com/jitsi/lib-jitsi-meet/pull/242#discussion_r81196295"},"pull_request":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/242","id":84580105,"html_url":"https://github.com/jitsi/lib-jitsi-meet/pull/242","diff_url":"https://github.com/jitsi/lib-jitsi-meet/pull/242.diff","patch_url":"https://github.com/jitsi/lib-jitsi-meet/pull/242.patch","issue_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/242","number":242,"state":"open","locked":false,"title":"Talk while muted","user":{"login":"damencho","id":3263098,"avatar_url":"https://avatars.githubusercontent.com/u/3263098?v=3","gravatar_id":"","url":"https://api.github.com/users/damencho","html_url":"https://github.com/damencho","followers_url":"https://api.github.com/users/damencho/followers","following_url":"https://api.github.com/users/damencho/following{/other_user}","gists_url":"https://api.github.com/users/damencho/gists{/gist_id}","starred_url":"https://api.github.com/users/damencho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damencho/subscriptions","organizations_url":"https://api.github.com/users/damencho/orgs","repos_url":"https://api.github.com/users/damencho/repos","events_url":"https://api.github.com/users/damencho/events{/privacy}","received_events_url":"https://api.github.com/users/damencho/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-09T01:20:17Z","updated_at":"2016-09-29T17:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"579f7bd05d8d339389f14a5ca2587de505ee267d","assignee":{"login":"lyubomir","id":3251887,"avatar_url":"https://avatars.githubusercontent.com/u/3251887?v=3","gravatar_id":"","url":"https://api.github.com/users/lyubomir","html_url":"https://github.com/lyubomir","followers_url":"https://api.github.com/users/lyubomir/followers","following_url":"https://api.github.com/users/lyubomir/following{/other_user}","gists_url":"https://api.github.com/users/lyubomir/gists{/gist_id}","starred_url":"https://api.github.com/users/lyubomir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyubomir/subscriptions","organizations_url":"https://api.github.com/users/lyubomir/orgs","repos_url":"https://api.github.com/users/lyubomir/repos","events_url":"https://api.github.com/users/lyubomir/events{/privacy}","received_events_url":"https://api.github.com/users/lyubomir/received_events","type":"User","site_admin":false},"assignees":[{"login":"lyubomir","id":3251887,"avatar_url":"https://avatars.githubusercontent.com/u/3251887?v=3","gravatar_id":"","url":"https://api.github.com/users/lyubomir","html_url":"https://github.com/lyubomir","followers_url":"https://api.github.com/users/lyubomir/followers","following_url":"https://api.github.com/users/lyubomir/following{/other_user}","gists_url":"https://api.github.com/users/lyubomir/gists{/gist_id}","starred_url":"https://api.github.com/users/lyubomir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyubomir/subscriptions","organizations_url":"https://api.github.com/users/lyubomir/orgs","repos_url":"https://api.github.com/users/lyubomir/repos","events_url":"https://api.github.com/users/lyubomir/events{/privacy}","received_events_url":"https://api.github.com/users/lyubomir/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/242/commits","review_comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/242/comments","review_comment_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/242/comments","statuses_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/a08ec825c82fb78092e68f15896db9b3bf646d48","head":{"label":"jitsi:talk-muted","ref":"talk-muted","sha":"a08ec825c82fb78092e68f15896db9b3bf646d48","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":50543360,"name":"lib-jitsi-meet","full_name":"jitsi/lib-jitsi-meet","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/lib-jitsi-meet","description":"","fork":false,"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/deployments","created_at":"2016-01-27T22:44:09Z","updated_at":"2016-09-21T12:45:11Z","pushed_at":"2016-09-29T17:33:30Z","git_url":"git://github.com/jitsi/lib-jitsi-meet.git","ssh_url":"git@github.com:jitsi/lib-jitsi-meet.git","clone_url":"https://github.com/jitsi/lib-jitsi-meet.git","svn_url":"https://github.com/jitsi/lib-jitsi-meet","homepage":null,"size":4312,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":23,"forks":45,"open_issues":23,"watchers":21,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"5771dc29fd754eb842652294765dc9d6dd616492","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":50543360,"name":"lib-jitsi-meet","full_name":"jitsi/lib-jitsi-meet","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/lib-jitsi-meet","description":"","fork":false,"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/deployments","created_at":"2016-01-27T22:44:09Z","updated_at":"2016-09-21T12:45:11Z","pushed_at":"2016-09-29T17:33:30Z","git_url":"git://github.com/jitsi/lib-jitsi-meet.git","ssh_url":"git@github.com:jitsi/lib-jitsi-meet.git","clone_url":"https://github.com/jitsi/lib-jitsi-meet.git","svn_url":"https://github.com/jitsi/lib-jitsi-meet","homepage":null,"size":4312,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":23,"forks":45,"open_issues":23,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/242"},"html":{"href":"https://github.com/jitsi/lib-jitsi-meet/pull/242"},"issue":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/242"},"comments":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/a08ec825c82fb78092e68f15896db9b3bf646d48"}}}}
{"actor":{"display_login":"lyubomir"}}