{"action":"created","comment":{"url":"https://api.github.com/repos/opesci/devito/pulls/comments/73605598","id":73605598,"diff_hunk":"@@ -200,7 +201,7 @@ def sympy_to_cgen(self, stencils):\n                 # TODO: add support for double precision\n                 self.add_local_var(name, np.float32)\n                 # TODO: undo precision enforcing\n-                factors.append(cgen.Assign(name, str(ccode(expr.xreplace(self._var_map))).replace(\"pow\", \"powf\").replace(\"fabs\", \"fabsf\")))\n+                factors.append(cgen.Assign(name, str(ccode(self.time_substitutions(expr).xreplace(self._var_map))).replace(\"pow\", \"powf\").replace(\"fabs\", \"fabsf\")))","path":"devito/propagator.py","position":13,"original_position":13,"commit_id":"196f3a4ee8f911ac80c3f51e2adbc74498937b60","original_commit_id":"196f3a4ee8f911ac80c3f51e2adbc74498937b60","user":{"login":"navjotk","id":679809,"avatar_url":"https://avatars.githubusercontent.com/u/679809?v=3","gravatar_id":"","url":"https://api.github.com/users/navjotk","html_url":"https://github.com/navjotk","followers_url":"https://api.github.com/users/navjotk/followers","following_url":"https://api.github.com/users/navjotk/following{/other_user}","gists_url":"https://api.github.com/users/navjotk/gists{/gist_id}","starred_url":"https://api.github.com/users/navjotk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navjotk/subscriptions","organizations_url":"https://api.github.com/users/navjotk/orgs","repos_url":"https://api.github.com/users/navjotk/repos","events_url":"https://api.github.com/users/navjotk/events{/privacy}","received_events_url":"https://api.github.com/users/navjotk/received_events","type":"User","site_admin":false},"body":"Are you sure?\r\n\r\nI removed it in a test on my machine and ran the tti 2D example. The generated code compiled fine so I guess there was no `s` left in the stencil. \r\n\r\n\r\nI think this is a left over from the initial factor implementation. A modified version of that implementation (that doesn't include this call) is already in master.","created_at":"2016-08-04T21:24:30Z","updated_at":"2016-08-04T21:24:30Z","html_url":"https://github.com/opesci/devito/pull/60#discussion_r73605598","pull_request_url":"https://api.github.com/repos/opesci/devito/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/opesci/devito/pulls/comments/73605598"},"html":{"href":"https://github.com/opesci/devito/pull/60#discussion_r73605598"},"pull_request":{"href":"https://api.github.com/repos/opesci/devito/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/opesci/devito/pulls/60","id":79487942,"html_url":"https://github.com/opesci/devito/pull/60","diff_url":"https://github.com/opesci/devito/pull/60.diff","patch_url":"https://github.com/opesci/devito/pull/60.patch","issue_url":"https://api.github.com/repos/opesci/devito/issues/60","number":60,"state":"open","locked":false,"title":"Zhang tti","user":{"login":"mloubout","id":5702350,"avatar_url":"https://avatars.githubusercontent.com/u/5702350?v=3","gravatar_id":"","url":"https://api.github.com/users/mloubout","html_url":"https://github.com/mloubout","followers_url":"https://api.github.com/users/mloubout/followers","following_url":"https://api.github.com/users/mloubout/following{/other_user}","gists_url":"https://api.github.com/users/mloubout/gists{/gist_id}","starred_url":"https://api.github.com/users/mloubout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mloubout/subscriptions","organizations_url":"https://api.github.com/users/mloubout/orgs","repos_url":"https://api.github.com/users/mloubout/repos","events_url":"https://api.github.com/users/mloubout/events{/privacy}","received_events_url":"https://api.github.com/users/mloubout/received_events","type":"User","site_admin":false},"body":"Sorry guys, but I entirely rewrote the discretization of the TTI equation. This new scheme should be a lot more stable and robust (there is papers proving it) as the FD operators are now self-adjoint. \r\nThe stencil is rewritten.\r\nThe factors now depend on the grid size and time.\r\nThe actual stencil is now tiny as all the FD is in the factors.\r\nIt is a more complex and intensive stencil as it requires all the cos/sin at every gridpoint of the stencil (this scheme takes derivative of the cos/sin) so it will be a lot longer to generate the code. The 2D is working and tested I am now testing the 3D.","created_at":"2016-07-31T15:30:22Z","updated_at":"2016-08-04T21:24:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa270178242f3ee541e0bded8cc808767a560809","assignee":{"login":"navjotk","id":679809,"avatar_url":"https://avatars.githubusercontent.com/u/679809?v=3","gravatar_id":"","url":"https://api.github.com/users/navjotk","html_url":"https://github.com/navjotk","followers_url":"https://api.github.com/users/navjotk/followers","following_url":"https://api.github.com/users/navjotk/following{/other_user}","gists_url":"https://api.github.com/users/navjotk/gists{/gist_id}","starred_url":"https://api.github.com/users/navjotk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navjotk/subscriptions","organizations_url":"https://api.github.com/users/navjotk/orgs","repos_url":"https://api.github.com/users/navjotk/repos","events_url":"https://api.github.com/users/navjotk/events{/privacy}","received_events_url":"https://api.github.com/users/navjotk/received_events","type":"User","site_admin":false},"assignees":[{"login":"navjotk","id":679809,"avatar_url":"https://avatars.githubusercontent.com/u/679809?v=3","gravatar_id":"","url":"https://api.github.com/users/navjotk","html_url":"https://github.com/navjotk","followers_url":"https://api.github.com/users/navjotk/followers","following_url":"https://api.github.com/users/navjotk/following{/other_user}","gists_url":"https://api.github.com/users/navjotk/gists{/gist_id}","starred_url":"https://api.github.com/users/navjotk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navjotk/subscriptions","organizations_url":"https://api.github.com/users/navjotk/orgs","repos_url":"https://api.github.com/users/navjotk/repos","events_url":"https://api.github.com/users/navjotk/events{/privacy}","received_events_url":"https://api.github.com/users/navjotk/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/opesci/devito/pulls/60/commits","review_comments_url":"https://api.github.com/repos/opesci/devito/pulls/60/comments","review_comment_url":"https://api.github.com/repos/opesci/devito/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opesci/devito/issues/60/comments","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/196f3a4ee8f911ac80c3f51e2adbc74498937b60","head":{"label":"opesci:Zhang_tti","ref":"Zhang_tti","sha":"196f3a4ee8f911ac80c3f51e2adbc74498937b60","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":54585666,"name":"devito","full_name":"opesci/devito","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/devito","description":"Code generation for the inversion workflow","fork":false,"url":"https://api.github.com/repos/opesci/devito","forks_url":"https://api.github.com/repos/opesci/devito/forks","keys_url":"https://api.github.com/repos/opesci/devito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/devito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/devito/teams","hooks_url":"https://api.github.com/repos/opesci/devito/hooks","issue_events_url":"https://api.github.com/repos/opesci/devito/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/devito/events","assignees_url":"https://api.github.com/repos/opesci/devito/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/devito/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/devito/tags","blobs_url":"https://api.github.com/repos/opesci/devito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/devito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/devito/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/devito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/devito/languages","stargazers_url":"https://api.github.com/repos/opesci/devito/stargazers","contributors_url":"https://api.github.com/repos/opesci/devito/contributors","subscribers_url":"https://api.github.com/repos/opesci/devito/subscribers","subscription_url":"https://api.github.com/repos/opesci/devito/subscription","commits_url":"https://api.github.com/repos/opesci/devito/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/devito/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/devito/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/devito/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/devito/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/devito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/devito/merges","archive_url":"https://api.github.com/repos/opesci/devito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/devito/downloads","issues_url":"https://api.github.com/repos/opesci/devito/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/devito/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/devito/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/devito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/devito/labels{/name}","releases_url":"https://api.github.com/repos/opesci/devito/releases{/id}","deployments_url":"https://api.github.com/repos/opesci/devito/deployments","created_at":"2016-03-23T18:59:49Z","updated_at":"2016-04-22T12:11:36Z","pushed_at":"2016-08-04T21:06:38Z","git_url":"git://github.com/opesci/devito.git","ssh_url":"git@github.com:opesci/devito.git","clone_url":"https://github.com/opesci/devito.git","svn_url":"https://github.com/opesci/devito","homepage":null,"size":1593,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"base":{"label":"opesci:master","ref":"master","sha":"22c8557086df0d7d4dbf664d8c0494cd557d1a46","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":54585666,"name":"devito","full_name":"opesci/devito","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/devito","description":"Code generation for the inversion workflow","fork":false,"url":"https://api.github.com/repos/opesci/devito","forks_url":"https://api.github.com/repos/opesci/devito/forks","keys_url":"https://api.github.com/repos/opesci/devito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/devito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/devito/teams","hooks_url":"https://api.github.com/repos/opesci/devito/hooks","issue_events_url":"https://api.github.com/repos/opesci/devito/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/devito/events","assignees_url":"https://api.github.com/repos/opesci/devito/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/devito/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/devito/tags","blobs_url":"https://api.github.com/repos/opesci/devito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/devito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/devito/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/devito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/devito/languages","stargazers_url":"https://api.github.com/repos/opesci/devito/stargazers","contributors_url":"https://api.github.com/repos/opesci/devito/contributors","subscribers_url":"https://api.github.com/repos/opesci/devito/subscribers","subscription_url":"https://api.github.com/repos/opesci/devito/subscription","commits_url":"https://api.github.com/repos/opesci/devito/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/devito/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/devito/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/devito/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/devito/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/devito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/devito/merges","archive_url":"https://api.github.com/repos/opesci/devito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/devito/downloads","issues_url":"https://api.github.com/repos/opesci/devito/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/devito/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/devito/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/devito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/devito/labels{/name}","releases_url":"https://api.github.com/repos/opesci/devito/releases{/id}","deployments_url":"https://api.github.com/repos/opesci/devito/deployments","created_at":"2016-03-23T18:59:49Z","updated_at":"2016-04-22T12:11:36Z","pushed_at":"2016-08-04T21:06:38Z","git_url":"git://github.com/opesci/devito.git","ssh_url":"git@github.com:opesci/devito.git","clone_url":"https://github.com/opesci/devito.git","svn_url":"https://github.com/opesci/devito","homepage":null,"size":1593,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opesci/devito/pulls/60"},"html":{"href":"https://github.com/opesci/devito/pull/60"},"issue":{"href":"https://api.github.com/repos/opesci/devito/issues/60"},"comments":{"href":"https://api.github.com/repos/opesci/devito/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/opesci/devito/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/opesci/devito/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opesci/devito/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/opesci/devito/statuses/196f3a4ee8f911ac80c3f51e2adbc74498937b60"}}}}
{"actor":{"display_login":"navjotk"}}