{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments/73159419","id":73159419,"diff_hunk":"@@ -167,6 +168,7 @@ - (void)createPayloadWithCompletionHandler:(void(^)(ZMEncodedAddressBook *encode\n                     index++;\n                 }\n                 result.otherData = (otherHashesCards.count < 1) ? nil : otherHashesCards;\n+                result.addressBookSize = addressBook.numberOfContacts;","path":"Source/Registration/ZMAddressBookEncoder.m","position":12,"original_position":12,"commit_id":"490263ee88027ceed68b0bfe2694251d321c7ba1","original_commit_id":"490263ee88027ceed68b0bfe2694251d321c7ba1","user":{"login":"marcoconti83","id":620000,"avatar_url":"https://avatars.githubusercontent.com/u/620000?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoconti83","html_url":"https://github.com/marcoconti83","followers_url":"https://api.github.com/users/marcoconti83/followers","following_url":"https://api.github.com/users/marcoconti83/following{/other_user}","gists_url":"https://api.github.com/users/marcoconti83/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoconti83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoconti83/subscriptions","organizations_url":"https://api.github.com/users/marcoconti83/orgs","repos_url":"https://api.github.com/users/marcoconti83/repos","events_url":"https://api.github.com/users/marcoconti83/events{/privacy}","received_events_url":"https://api.github.com/users/marcoconti83/received_events","type":"User","site_admin":false},"body":"We still have that artificial limit of 1000 contacts max, right? In this case, I think `numberOfContacts` will be capped at 1000. What we wanted to know is whether the users has 12.000 contacts, so we can figure out if we are too restrictive with a limit of 1000.","created_at":"2016-08-02T13:58:21Z","updated_at":"2016-08-02T13:58:21Z","html_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/7#discussion_r73159419","pull_request_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments/73159419"},"html":{"href":"https://github.com/wireapp/wire-ios-sync-engine/pull/7#discussion_r73159419"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/7","id":79739436,"html_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/7","diff_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/7.diff","patch_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/7.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/7","number":7,"state":"open","locked":false,"title":"Add address book upload analytics","user":{"login":"daehn","id":4603353,"avatar_url":"https://avatars.githubusercontent.com/u/4603353?v=3","gravatar_id":"","url":"https://api.github.com/users/daehn","html_url":"https://github.com/daehn","followers_url":"https://api.github.com/users/daehn/followers","following_url":"https://api.github.com/users/daehn/following{/other_user}","gists_url":"https://api.github.com/users/daehn/gists{/gist_id}","starred_url":"https://api.github.com/users/daehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daehn/subscriptions","organizations_url":"https://api.github.com/users/daehn/orgs","repos_url":"https://api.github.com/users/daehn/repos","events_url":"https://api.github.com/users/daehn/events{/privacy}","received_events_url":"https://api.github.com/users/daehn/received_events","type":"User","site_admin":false},"body":"**What's in this PR?**\r\n\r\n* Adds address book upload tracking ([6980](https://wearezeta.atlassian.net/browse/ZIOS-6980))","created_at":"2016-08-02T13:55:51Z","updated_at":"2016-08-02T13:58:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40e6ad477bcfc8f2705dee03434766d2dfc03c37","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/7/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/7/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/7/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/490263ee88027ceed68b0bfe2694251d321c7ba1","head":{"label":"wireapp:feature/address-book-analytics","ref":"feature/address-book-analytics","sha":"490263ee88027ceed68b0bfe2694251d321c7ba1","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":53574338,"name":"wire-ios-sync-engine","full_name":"wireapp/wire-ios-sync-engine","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-sync-engine","description":"iOS synchronization library for Wire","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine","forks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/deployments","created_at":"2016-03-10T10:02:14Z","updated_at":"2016-08-01T02:50:11Z","pushed_at":"2016-08-02T13:55:51Z","git_url":"git://github.com/wireapp/wire-ios-sync-engine.git","ssh_url":"git@github.com:wireapp/wire-ios-sync-engine.git","clone_url":"https://github.com/wireapp/wire-ios-sync-engine.git","svn_url":"https://github.com/wireapp/wire-ios-sync-engine","homepage":"https://wire.com","size":4795,"stargazers_count":80,"watchers_count":80,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":80,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"c39fc440e4fdbc04b14c128625615c566acc3479","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":53574338,"name":"wire-ios-sync-engine","full_name":"wireapp/wire-ios-sync-engine","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-sync-engine","description":"iOS synchronization library for Wire","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine","forks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/deployments","created_at":"2016-03-10T10:02:14Z","updated_at":"2016-08-01T02:50:11Z","pushed_at":"2016-08-02T13:55:51Z","git_url":"git://github.com/wireapp/wire-ios-sync-engine.git","ssh_url":"git@github.com:wireapp/wire-ios-sync-engine.git","clone_url":"https://github.com/wireapp/wire-ios-sync-engine.git","svn_url":"https://github.com/wireapp/wire-ios-sync-engine","homepage":"https://wire.com","size":4795,"stargazers_count":80,"watchers_count":80,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":80,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/7"},"html":{"href":"https://github.com/wireapp/wire-ios-sync-engine/pull/7"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/7"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/490263ee88027ceed68b0bfe2694251d321c7ba1"}}}}
{"actor":{"display_login":"marcoconti83"}}