{"push_id":1068643770,"size":92,"distinct_size":37,"ref":"refs/heads/vivek/cput","head":"b9b55403557a05a9281fe0ca67de17ac7e16e855","before":"36a17449decfb9aac8e9b1903af851923827682f","commits":[{"sha":"f51f235b2216065b65cb3daf8bcdfd68c2736d51","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"encoding: Return to base-100 encoding for Decimal\n\nThe previous encoding approach for DECIMAL was broken in two ways:\n- It prefixed the mantissa with the mantissa's length, which meant that\n  decimal values did not always sort correctly. For instance `.01111`\n  would sort before `0.02`.\n- It encoded its exponent in a base that was not a factor of its\n  mantissa's base, which also permitted very subtle ordering errors.\n  Here, the encoding's exponent was base-10 encoded while\n  its mantissa was base-256 encoded. This was not a problem in the\n  current iteration of the previous encoding because the mantissa length\n  varint (discussed above) would prevent any strange ordering. However, if\n  we had moved from the mantissa length prefix approach to the escaped\n  0x00 byte approach for encoding the mantissa, this issue would have\n  come up. In practice, it means that values like `255 = [0xff]` would\n  sort before `256 = [0x01 0x00]`. It is critical that the exponent and\n  the mantissa share the same base (or the exponent is a factor of the\n  mantissa's base) so that the exponent will increment whenever the\n  mantissa's byte size grows.\n\nI spent all day trying to convert the base-10 exponent into a base-256\nexponent so we could avoid marshalling through strings on encoding and\ndecoding, but had little luck. If anyone has ideas, I'd love to hear\nthem.\n\nThe current approach uses a base-100 exponent and a base-100 mantissa.\nIt is similar to the first encoding of decimal, with a few key\ndifferences.\n- The null terminator is searched for AFTER the uvarint has been\n  decoded. This was an issue with both the previous float and decimal\n  encodings, which both assumed that the exponent uvarint would be free\n  of 0x00 bytes. In those instances, there was a risk of searching for\n  the terminator, only to find a 0x00 byte in the uvarint.\n- A few performance tweaks were made to reduce an allocation from\n  encoding and to reduce an allocation from decoding.\n- We're now using the `{Encode/Decode}Uvarint{Ascending/Descending}`\n  functions instead of the old uvarint functions.\n- I've added a random encoding test to make sure this is correct. So far\n  so good.","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/f51f235b2216065b65cb3daf8bcdfd68c2736d51"},{"sha":"ab90a69d394bc6fff42ac0f5680d832d9f30c84a","author":{"email":"ebe33565ff1feb407d76e6fe743a5e72f6c63f84@163.com","name":"es-chow"},"message":"transfer raft leadership to range leadership if these two are not located on the same store","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/ab90a69d394bc6fff42ac0f5680d832d9f30c84a"},{"sha":"d97e240c2dd9cb3cf08207e4a36ba64d793f131d","author":{"email":"9ba101b4ce58adde9ff85c3bc5f9f4dd73a28feb@gmail.com","name":"Kenji Kaneda"},"message":"storage: Move the txn update code in resolveExplicitIntents to a separate function\n\nDefine updateTxnWithExternalIntents, which persists the transaction\nrecord with updated status.","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/d97e240c2dd9cb3cf08207e4a36ba64d793f131d"},{"sha":"e60595711d9a88fc546fa26a3eefec0b3fc7d3af","author":{"email":"9ba101b4ce58adde9ff85c3bc5f9f4dd73a28feb@gmail.com","name":"Kenji Kaneda"},"message":"Merge pull request #5995 from cockroachdb/kaneda/resolve_intents_fix\n\nstorage: Move the txn update code in resolveExplicitIntents to a separate function","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/e60595711d9a88fc546fa26a3eefec0b3fc7d3af"},{"sha":"9319782699e54ec2a0811f0e03f8336912c13d0a","author":{"email":"314fe2776746d1cb8b8611e1e315a38b2017bbff@gmail.com","name":"Matt Jibson"},"message":"sql: support more than 1 result row in pg prepared tests","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/9319782699e54ec2a0811f0e03f8336912c13d0a"},{"sha":"c5fef2e51aa4ae96163731b7071a9114cc810eca","author":{"email":"314fe2776746d1cb8b8611e1e315a38b2017bbff@gmail.com","name":"Matt Jibson"},"message":"Merge pull request #5987 from mjibson/sql-improved-param-tests\n\nsql: support more than 1 result row in pg prepared tests","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/c5fef2e51aa4ae96163731b7071a9114cc810eca"},{"sha":"b6cb613e9bc497286e108fd502131656039b3f21","author":{"email":"73675debcd8a436be48ec22211dcf44fe0df0a64@bendarnell.com","name":"Ben Darnell"},"message":"Merge pull request #5973 from es-chow/transfer-raft-leadership\n\ntransfer raft leadership to range leadership","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/b6cb613e9bc497286e108fd502131656039b3f21"},{"sha":"3d32a23a7a6656e8b97f2c60b32fbad23768c493","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"storage: Fix nil pointer in markDead on log\n\nFixes #6001.\n\nThe descriptor could have never been set on the `storeDetail` if it was\nmarkedAlive and enqueued in getStoreDetailLocked and never markedAlive again.\nI'm not sure if it makes sense to log anything, because chances are the\nstore was never alive to begin with.","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/3d32a23a7a6656e8b97f2c60b32fbad23768c493"},{"sha":"77b6c911f617a7a734475460e44e722be96aeb56","author":{"email":"40acb66e85558f9386bc83d653a8a8231ece881a@users.noreply.github.com","name":"Cuong Do"},"message":"Make terraform+CockroachDB work on GCE\n\nThis updated terraform config allows one to create an insecure\nCockroachDB cluster on GCE.\n\nCaveats:\n- Secure clusters are NOT supported.\n- I didn't investigate the load balancer issues at all, so that's\n  probably still broken.\n- There's no supervisor config for running `cockroach`.","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/77b6c911f617a7a734475460e44e722be96aeb56"},{"sha":"028bf9a2708da3e8f12bd4c8b890d4aec2b35fd3","author":{"email":"b916e94d63c4d551e8d54e7a93ea400ef994acf0@gmail.com","name":"David Taylor"},"message":"acceptance: make c example compile on debian gcc","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/028bf9a2708da3e8f12bd4c8b890d4aec2b35fd3"},{"sha":"d2ce6919c401d14f24f2f6053b367e6a88a5301d","author":{"email":"0706025b2bbcec1ed8d64822f4eccd96314938d0@cockroachlabs.com","name":"Max Lang"},"message":"ui: fix overflow scroll issues\n\nfixes #5937","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/d2ce6919c401d14f24f2f6053b367e6a88a5301d"},{"sha":"34469666544db0645716eda796c34eb6c42b2457","author":{"email":"40acb66e85558f9386bc83d653a8a8231ece881a@users.noreply.github.com","name":"Cuong Do"},"message":"Merge pull request #5890 from cuongdo/terraform_gce\n\nMake terraform+CockroachDB work on GCE","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/34469666544db0645716eda796c34eb6c42b2457"},{"sha":"cad0a4b06f66da319ff7b8d8c49379978d749951","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"Merge pull request #6013 from nvanbenschoten/nvanbenschoten/fixNil\n\nstorage: Fix nil pointer in markDead on log","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/cad0a4b06f66da319ff7b8d8c49379978d749951"},{"sha":"08d664015764b5b04fc09946d0588e16f8651cca","author":{"email":"b916e94d63c4d551e8d54e7a93ea400ef994acf0@gmail.com","name":"David Taylor"},"message":"Merge pull request #6017 from dt/stdc\n\nacceptance: make c example compile on debian gcc","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/08d664015764b5b04fc09946d0588e16f8651cca"},{"sha":"08943439a06057f3f37bf0c200db30518560923a","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"kv: reenable the local call optimization by default\n\nThe local call optimization was accidentally disabled by #5430.","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/08943439a06057f3f37bf0c200db30518560923a"},{"sha":"bf63d20d5e455e8a062e0f8c665a6c2235637795","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"roachpb: make SetInner MustSetInner\n\nThis was always how it was used. Add comments on a particular\nfallacy surrounding the Requests and Responses slices in BatchRequest\nand BatchResponse, respectively.\nAdd a call to Reset in MustSetInner (or multiple values may end up\nbeing set, which causes the first one to be returned from GetInner).","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/bf63d20d5e455e8a062e0f8c665a6c2235637795"},{"sha":"e150bca72a17a9fffba3440cecc2bfbb15aae0d7","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"Merge pull request #5997 from tschottdorf/setinner\n\nroachpb: make SetInner MustSetInner","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/e150bca72a17a9fffba3440cecc2bfbb15aae0d7"},{"sha":"cce1e38bf35d5f8e6dfe4633ee433fe76eb7305f","author":{"email":"4b8373d016f277527198385ba72fda0feb5da015@cockroachlabs.com","name":"Peter Mattis"},"message":"Merge pull request #6021 from petermattis/pmattis/re-enable-local-calls\n\nkv: reenable the local call optimization by default","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/cce1e38bf35d5f8e6dfe4633ee433fe76eb7305f"},{"sha":"3a077de3b6070582bde63433b3dacd0350e09b61","author":{"email":"9ba101b4ce58adde9ff85c3bc5f9f4dd73a28feb@gmail.com","name":"Kenji Kaneda"},"message":"storage: Check the txn deadline for 1PC requests\n\nChange isOnePhaseCommit to check if the transaction exceeded its\ndeadline. If so, return false so that we do not apply the 1PC code path.\n\nWe can also just return a TransactionAbortedError from executeWriteBatch, I think.","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/3a077de3b6070582bde63433b3dacd0350e09b61"},{"sha":"249faab17e4939a0ba64a58cceae57fd29001ab4","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"ci: temporarily skip osx cross-compilation\n\nSee #6030.","distinct":false,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/249faab17e4939a0ba64a58cceae57fd29001ab4"}]}