{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/66443698","id":66443698,"diff_hunk":"@@ -1,41 +1,42 @@\n ---\n-# tasks file for docker\n-\n-- name: Get current installed version if docker_version is specified\n+# Going forward we require Docker 1.10 or greater. If the user has a lesser version installed they must run a separate upgrade process.\n+- name: Get current installed Docker version\n   command: \"{{ repoquery_cmd }} --installed --qf '%{version}' docker\"\n-  when:  not openshift.common.is_atomic | bool and docker_version != ''\n-  register: docker_version_result\n+  when:  not openshift.common.is_atomic | bool\n+  register: curr_docker_version\n   changed_when: false\n \n-- stat: path=/etc/sysconfig/docker-storage\n-  register: docker_storage_check\n+# TODO: The use of upgrading var will be removed in the coming upgrade refactor. This is a temporary\n+# fix to wory around the fact that right now, this role is called during upgrade, before we're\n+# ready to upgrade Docker.\n+- name: Fail if Docker upgrade is required\n+  fail:\n+    msg: \"Docker {{ curr_docker_version.stdout }} must be upgraded to Docker 1.10 or greater\"\n+  when: not upgrading | bool and not curr_docker_version | skipped and curr_docker_version.stdout | default('0.0', True) | version_compare('1.10', '<')\n \n-- name: Remove deferred deletion for downgrades from 1.9\n+- name: Get latest available version of Docker\n   command: >\n-    sed -i 's/--storage-opt dm.use_deferred_deletion=true//' /etc/sysconfig/docker-storage\n-  when: docker_storage_check.stat.exists | bool and not docker_version_result | skipped and docker_version_result.stdout | default('0.0', True) | version_compare('1.9', '>=') and docker_version | version_compare('1.9', '<')\n-\n-- name: Downgrade docker if necessary\n-  command: \"{{ ansible_pkg_mgr }} swap -y docker-* docker-*{{ docker_version }}\"\n-  register: docker_downgrade_result\n-  when: not docker_version_result | skipped and docker_version_result.stdout | default('0.0', True) | version_compare(docker_version, 'gt')\n+    {{ repoquery_cmd }} --qf '%{version}' \"docker\"\n+  register: avail_docker_version\n+  failed_when: false\n+  changed_when: false\n+  when: not curr_docker_version.stdout | default('0.0', True) | version_compare('1.10', '>=') and not openshift.common.is_atomic | bool\n \n-- name: Install docker\n-  action: \"{{ ansible_pkg_mgr }} name=docker{{ '-' + docker_version if docker_version is defined and docker_version != '' else '' }} state=present\"\n-  when: not openshift.common.is_atomic | bool and docker_downgrade_result | skipped\n+- name: Verify Docker >= 1.10 is available\n+  fail:\n+    msg: \"Docker {{ avail_docker_version.stdout }} is available, but 1.10 or greater is required\"\n+  when: not avail_docker_version | skipped and avail_docker_version.stdout | default('0.0', True) | version_compare('1.10', '<')\n \n-# If docker were enabled and started before we downgraded it may have entered a\n-# failed state. Check for that and clear it if necessary.\n-- name: Check that docker hasn't entered failed state\n-  command: systemctl show docker\n-  register: docker_state\n-  changed_when: False\n+- stat: path=/etc/sysconfig/docker-storage\n+  register: docker_storage_check","path":"roles/docker/tasks/main.yml","position":55,"original_position":55,"commit_id":"e272847e1a195d8ca74103fd87c7207b68c0d919","original_commit_id":"4bec37c10f835902a42b62493c5df0de97db73f8","user":{"login":"sdodson","id":48161,"avatar_url":"https://avatars.githubusercontent.com/u/48161?v=3","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"body":"Looks like no.","created_at":"2016-06-09T13:50:44Z","updated_at":"2016-06-09T13:50:44Z","html_url":"https://github.com/openshift/openshift-ansible/pull/2005#discussion_r66443698","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2005","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/66443698"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/2005#discussion_r66443698"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2005"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2005","id":73057144,"html_url":"https://github.com/openshift/openshift-ansible/pull/2005","diff_url":"https://github.com/openshift/openshift-ansible/pull/2005.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/2005.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2005","number":2005,"state":"open","locked":false,"title":"Bug 1338726 - never abort install if the latest version of docker is already installed","user":{"login":"brenton","id":832,"avatar_url":"https://avatars.githubusercontent.com/u/832?v=3","gravatar_id":"","url":"https://api.github.com/users/brenton","html_url":"https://github.com/brenton","followers_url":"https://api.github.com/users/brenton/followers","following_url":"https://api.github.com/users/brenton/following{/other_user}","gists_url":"https://api.github.com/users/brenton/gists{/gist_id}","starred_url":"https://api.github.com/users/brenton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenton/subscriptions","organizations_url":"https://api.github.com/users/brenton/orgs","repos_url":"https://api.github.com/users/brenton/repos","events_url":"https://api.github.com/users/brenton/events{/privacy}","received_events_url":"https://api.github.com/users/brenton/received_events","type":"User","site_admin":false},"body":"This includes https://github.com/openshift/openshift-ansible/pull/1974","created_at":"2016-06-08T14:31:31Z","updated_at":"2016-06-09T13:50:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0e08d3fd0a32fded1feba97b8db9f6058c356f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2005/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2005/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2005/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/e272847e1a195d8ca74103fd87c7207b68c0d919","head":{"label":"brenton:bz1338726","ref":"bz1338726","sha":"e272847e1a195d8ca74103fd87c7207b68c0d919","user":{"login":"brenton","id":832,"avatar_url":"https://avatars.githubusercontent.com/u/832?v=3","gravatar_id":"","url":"https://api.github.com/users/brenton","html_url":"https://github.com/brenton","followers_url":"https://api.github.com/users/brenton/followers","following_url":"https://api.github.com/users/brenton/following{/other_user}","gists_url":"https://api.github.com/users/brenton/gists{/gist_id}","starred_url":"https://api.github.com/users/brenton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenton/subscriptions","organizations_url":"https://api.github.com/users/brenton/orgs","repos_url":"https://api.github.com/users/brenton/repos","events_url":"https://api.github.com/users/brenton/events{/privacy}","received_events_url":"https://api.github.com/users/brenton/received_events","type":"User","site_admin":false},"repo":{"id":37875680,"name":"openshift-ansible","full_name":"brenton/openshift-ansible","owner":{"login":"brenton","id":832,"avatar_url":"https://avatars.githubusercontent.com/u/832?v=3","gravatar_id":"","url":"https://api.github.com/users/brenton","html_url":"https://github.com/brenton","followers_url":"https://api.github.com/users/brenton/followers","following_url":"https://api.github.com/users/brenton/following{/other_user}","gists_url":"https://api.github.com/users/brenton/gists{/gist_id}","starred_url":"https://api.github.com/users/brenton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenton/subscriptions","organizations_url":"https://api.github.com/users/brenton/orgs","repos_url":"https://api.github.com/users/brenton/repos","events_url":"https://api.github.com/users/brenton/events{/privacy}","received_events_url":"https://api.github.com/users/brenton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brenton/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/brenton/openshift-ansible","forks_url":"https://api.github.com/repos/brenton/openshift-ansible/forks","keys_url":"https://api.github.com/repos/brenton/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brenton/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brenton/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/brenton/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/brenton/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/brenton/openshift-ansible/events","assignees_url":"https://api.github.com/repos/brenton/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/brenton/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/brenton/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/brenton/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brenton/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brenton/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/brenton/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brenton/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/brenton/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/brenton/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/brenton/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/brenton/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/brenton/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/brenton/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/brenton/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/brenton/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/brenton/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/brenton/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/brenton/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brenton/openshift-ansible/merges","archive_url":"https://api.github.com/repos/brenton/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brenton/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/brenton/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/brenton/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/brenton/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/brenton/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brenton/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/brenton/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/brenton/openshift-ansible/deployments","created_at":"2015-06-22T19:19:25Z","updated_at":"2016-01-11T14:46:52Z","pushed_at":"2016-06-09T12:25:57Z","git_url":"git://github.com/brenton/openshift-ansible.git","ssh_url":"git@github.com:brenton/openshift-ansible.git","clone_url":"https://github.com/brenton/openshift-ansible.git","svn_url":"https://github.com/brenton/openshift-ansible","homepage":"","size":4916,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"9553b9173d951de39b52a03688ea6f7aff7291d4","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2016-06-06T12:54:48Z","pushed_at":"2016-06-09T12:25:58Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":6598,"stargazers_count":181,"watchers_count":181,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":315,"mirror_url":null,"open_issues_count":305,"forks":315,"open_issues":305,"watchers":181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2005"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/2005"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/2005"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/2005/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2005/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2005/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/e272847e1a195d8ca74103fd87c7207b68c0d919"}}}}
{"actor":{"display_login":"sdodson"}}