{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/9787","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/9787/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/9787/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/9787/events","html_url":"https://github.com/openshift/origin/pull/9787","id":164937531,"number":9787,"title":"Change extended test's DNS port to 8053 intead of 53","user":{"login":"enj","id":7001223,"avatar_url":"https://avatars.githubusercontent.com/u/7001223?v=3","gravatar_id":"","url":"https://api.github.com/users/enj","html_url":"https://github.com/enj","followers_url":"https://api.github.com/users/enj/followers","following_url":"https://api.github.com/users/enj/following{/other_user}","gists_url":"https://api.github.com/users/enj/gists{/gist_id}","starred_url":"https://api.github.com/users/enj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enj/subscriptions","organizations_url":"https://api.github.com/users/enj/orgs","repos_url":"https://api.github.com/users/enj/repos","events_url":"https://api.github.com/users/enj/events{/privacy}","received_events_url":"https://api.github.com/users/enj/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"assignees":[{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-07-11T21:22:24Z","updated_at":"2016-07-11T22:26:47Z","closed_at":"2016-07-11T21:55:32Z","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/9787","html_url":"https://github.com/openshift/origin/pull/9787","diff_url":"https://github.com/openshift/origin/pull/9787.diff","patch_url":"https://github.com/openshift/origin/pull/9787.patch"},"body":"Using a low port for DNS seems to cause issues."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/231884627","html_url":"https://github.com/openshift/origin/pull/9787#issuecomment-231884627","issue_url":"https://api.github.com/repos/openshift/origin/issues/9787","id":231884627,"user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T22:26:47Z","updated_at":"2016-07-11T22:26:47Z","body":"```\r\n\t// For backward compatibility of DNS queries to the master service IP, enabling node DNS\r\n\t// continues to start the master DNS, but the container DNS server will be the node's.\r\n\t// However, if the user has provided an override DNSAddr, we need to honor the value if\r\n\t// the port is not 53 and we do that by disabling node DNS.\r\n\tif !o.IsRunFromConfig() && o.NodeArgs.Components.Enabled(ComponentDNS) {\r\n\t\tdnsAddr := &o.MasterOptions.MasterArgs.DNSBindAddr\r\n\r\n\t\tif dnsAddr.Provided {\r\n\t\t\tif dnsAddr.Port == 53 {\r\n\t\t\t\t// the user has set the DNS port to 53, which is the effective default (node on 53, master on 8053)\r\n\t\t\t\tdnsAddr.Port = 8053\r\n\t\t\t\tdnsAddr.URL.Host = net.JoinHostPort(dnsAddr.Host, strconv.Itoa(dnsAddr.Port))\r\n\t\t\t} else {\r\n\t\t\t\t// if the user set the DNS port to anything but 53, disable node DNS since ClusterDNS (and glibc)\r\n\t\t\t\t// can't look up DNS on anything other than 53, so we'll continue to use the proxy.\r\n\t\t\t\to.NodeArgs.Components.Disable(ComponentDNS)\r\n\t\t\t\tglog.V(2).Infof(\"Node DNS may not be used with a non-standard DNS port %d - disabled node DNS\", dnsAddr.Port)\r\n\t\t\t}\r\n\t\t}\r\n\r\n\t\t// if node DNS is still enabled, then default the node cluster DNS to a reachable master address\r\n\t\tif o.NodeArgs.Components.Enabled(ComponentDNS) && o.NodeArgs.ClusterDNS == nil {\r\n\t\t\tif dnsIP, err := findLocalIPForDNS(o.MasterOptions.MasterArgs); err == nil {\r\n\t\t\t\to.NodeArgs.ClusterDNS = dnsIP\r\n\t\t\t} else {\r\n\t\t\t\tglog.V(2).Infof(\"Unable to find a local address to report as the node DNS - not using node DNS: %v\", err)\r\n\t\t\t}\r\n\t\t}\r\n\t}\r\n```"}}
{"actor":{"display_login":"smarterclayton"}}