{"action":"created","issue":{"url":"https://api.github.com/repos/luvit/luv/issues/224","repository_url":"https://api.github.com/repos/luvit/luv","labels_url":"https://api.github.com/repos/luvit/luv/issues/224/labels{/name}","comments_url":"https://api.github.com/repos/luvit/luv/issues/224/comments","events_url":"https://api.github.com/repos/luvit/luv/issues/224/events","html_url":"https://github.com/luvit/luv/pull/224","id":139315988,"number":224,"title":"Use luarocks native build on rockspec","user":{"login":"tarruda","id":842846,"avatar_url":"https://avatars.githubusercontent.com/u/842846?v=3","gravatar_id":"","url":"https://api.github.com/users/tarruda","html_url":"https://github.com/tarruda","followers_url":"https://api.github.com/users/tarruda/followers","following_url":"https://api.github.com/users/tarruda/following{/other_user}","gists_url":"https://api.github.com/users/tarruda/gists{/gist_id}","starred_url":"https://api.github.com/users/tarruda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarruda/subscriptions","organizations_url":"https://api.github.com/users/tarruda/orgs","repos_url":"https://api.github.com/users/tarruda/repos","events_url":"https://api.github.com/users/tarruda/events{/privacy}","received_events_url":"https://api.github.com/users/tarruda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-03-08T16:02:20Z","updated_at":"2016-03-09T12:59:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/luvit/luv/pulls/224","html_url":"https://github.com/luvit/luv/pull/224","diff_url":"https://github.com/luvit/luv/pull/224.diff","patch_url":"https://github.com/luvit/luv/pull/224.patch"},"body":"This should make luv more compatible with luarocks echosystem:\r\n\r\n- Doesn't depend on cmake(which may not be available). luv is very simple to\r\n  compile, and cmake is used more to setup dependencies, but this is already\r\n  taken care of by luarocks.\r\n- Allows the user to specify custom libuv prefixes with LIBUV_DIR(which is the\r\n  idiomatic way of specifying dependencies location in luarocks)\r\n- Respects CC\r\n\r\nClose #223"},"comment":{"url":"https://api.github.com/repos/luvit/luv/issues/comments/194285571","html_url":"https://github.com/luvit/luv/pull/224#issuecomment-194285571","issue_url":"https://api.github.com/repos/luvit/luv/issues/224","id":194285571,"user":{"login":"tarruda","id":842846,"avatar_url":"https://avatars.githubusercontent.com/u/842846?v=3","gravatar_id":"","url":"https://api.github.com/users/tarruda","html_url":"https://github.com/tarruda","followers_url":"https://api.github.com/users/tarruda/followers","following_url":"https://api.github.com/users/tarruda/following{/other_user}","gists_url":"https://api.github.com/users/tarruda/gists{/gist_id}","starred_url":"https://api.github.com/users/tarruda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarruda/subscriptions","organizations_url":"https://api.github.com/users/tarruda/orgs","repos_url":"https://api.github.com/users/tarruda/repos","events_url":"https://api.github.com/users/tarruda/events{/privacy}","received_events_url":"https://api.github.com/users/tarruda/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T12:59:47Z","updated_at":"2016-03-09T12:59:47Z","body":"> I agree that not providing a way to customize the options passed to CMake is a serious luarocks limitation, but maybe we should fix luarocks instead? This PR's regression would make life harder for applications that use luv and are currently installed automatically using luarocks/cmake (admittedly I'm the author of one such application). On Linux the fix would be an easy apt-get install, but on Windows the amount of extra work to install my application would be immense. Fixing luarocks seems the nobler thing to do here, especially since big projects such as neovim already depend on CMake anyways.\r\n\r\nAgreed, but getting familiar with luarocks internals in order to submit a PR would take considerably longer, and unfortunately I don't have time to spare.\r\n\r\nOTOH I already had a working rockspec from the previous version of neovim lua client, even the windows-specific were already implemented by @equalsraf, so it cost me only a few minutes to adapt the rockspec for luv."}}