{"action":"created","issue":{"url":"https://api.github.com/repos/jgrapht/jgrapht/issues/225","repository_url":"https://api.github.com/repos/jgrapht/jgrapht","labels_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/225/labels{/name}","comments_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/225/comments","events_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/225/events","html_url":"https://github.com/jgrapht/jgrapht/pull/225","id":167050725,"number":225,"title":"Improved GmlExporter","user":{"login":"d-michail","id":15940875,"avatar_url":"https://avatars.githubusercontent.com/u/15940875?v=3","gravatar_id":"","url":"https://api.github.com/users/d-michail","html_url":"https://github.com/d-michail","followers_url":"https://api.github.com/users/d-michail/followers","following_url":"https://api.github.com/users/d-michail/following{/other_user}","gists_url":"https://api.github.com/users/d-michail/gists{/gist_id}","starred_url":"https://api.github.com/users/d-michail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-michail/subscriptions","organizations_url":"https://api.github.com/users/d-michail/orgs","repos_url":"https://api.github.com/users/d-michail/repos","events_url":"https://api.github.com/users/d-michail/events{/privacy}","received_events_url":"https://api.github.com/users/d-michail/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-22T13:56:09Z","updated_at":"2016-07-25T23:51:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jgrapht/jgrapht/pulls/225","html_url":"https://github.com/jgrapht/jgrapht/pull/225","diff_url":"https://github.com/jgrapht/jgrapht/pull/225.diff","patch_url":"https://github.com/jgrapht/jgrapht/pull/225.patch"},"body":"- Improved class public interface\r\n- Deprecated old style options\r\n- Fixed not necessary cast when reading edge weights\r\n"},"comment":{"url":"https://api.github.com/repos/jgrapht/jgrapht/issues/comments/235121488","html_url":"https://github.com/jgrapht/jgrapht/pull/225#issuecomment-235121488","issue_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/225","id":235121488,"user":{"login":"jkinable","id":2742474,"avatar_url":"https://avatars.githubusercontent.com/u/2742474?v=3","gravatar_id":"","url":"https://api.github.com/users/jkinable","html_url":"https://github.com/jkinable","followers_url":"https://api.github.com/users/jkinable/followers","following_url":"https://api.github.com/users/jkinable/following{/other_user}","gists_url":"https://api.github.com/users/jkinable/gists{/gist_id}","starred_url":"https://api.github.com/users/jkinable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkinable/subscriptions","organizations_url":"https://api.github.com/users/jkinable/orgs","repos_url":"https://api.github.com/users/jkinable/repos","events_url":"https://api.github.com/users/jkinable/events{/privacy}","received_events_url":"https://api.github.com/users/jkinable/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T23:51:51Z","updated_at":"2016-07-25T23:51:51Z","body":"I'm not sure whether I'm really convinced that decomposing the setPrintLabels(final Integer i) and getPrintLabels() into separate functions is an improvement.\r\nI do agree however that setPrintLabels(final Integer i) is quite ugly. My main concerns with the decomposition:\r\n-You have a getter/setter function for every parameter. This results in a rather large amount of functions. Adding potential future parameters requires adding even more functions.\r\n-function names like \"isExportVertexLabels()\" are quite cumbersome.\r\n\r\nI would go for either of the following 2 options:\r\n\r\n1. Create an Enum Parameters with all the parameters as originally suggested by @jsichi , and store the values in an EnumMap. Create 2 functions: one setParameter(Parameters param, boolean value) and getParameter(...). So far we have only boolean parameters so that should be nice and concise. If you are concerned with parameters of different types, you can always use something like this: http://stackoverflow.com/questions/24296059/how-do-i-store-enum-types-into-a-map\r\nI wouldn't bother for now.\r\n\r\n2. Use a Property map. This is probably the most generic solution, but quite a bit of overkill.\r\n\r\nI believe that each time a new version of jgrapht is released, the Jeopardy source code beautifier is executed, so I wouldn't bother too much with making the code pretty by adding/removing spaces. That way, the change set remains nice and small, reducing the review overhead :)."}}
{"actor":{"display_login":"jkinable"}}