{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/33940","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/33940/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/33940/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/33940/events","html_url":"https://github.com/rust-lang/rust/pull/33940","id":157370697,"number":33940,"title":"hashmap: use siphash-1-3 as default hasher","user":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?v=3","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rust-lang/rust/labels/needs-crater","name":"needs-crater","color":"207de5"},{"url":"https://api.github.com/repos/rust-lang/rust/labels/relnotes","name":"relnotes","color":"fad8c7"},{"url":"https://api.github.com/repos/rust-lang/rust/labels/T-libs","name":"T-libs","color":"bfd4f2"}],"state":"open","locked":false,"assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"milestone":null,"comments":38,"created_at":"2016-05-29T05:38:24Z","updated_at":"2016-06-29T22:59:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/33940","html_url":"https://github.com/rust-lang/rust/pull/33940","diff_url":"https://github.com/rust-lang/rust/pull/33940.diff","patch_url":"https://github.com/rust-lang/rust/pull/33940.patch"},"body":"Also exposes `SipHash13` and `SipHash24` in `core::hash::sip`, for those that want to differentiate.\r\n\r\nFor motivation, see this quote from the original issue:\r\n\r\n> we proposed SipHash-2-4 as a (strong) PRF/MAC, and so far no attack whatsoever has been found,\r\nalthough many competent people tried to break it. However, fewer rounds may be sufficient and I would \r\nbe very surprised if SipHash-1-3 introduced weaknesses for hash tables.\r\n\r\nThis keeps a type alias of `SipHasher` to `SipHash24`, and since the internal default hasher of HashMap is specified as \"not specified\", changing it should not be a breaking change.\r\n\r\nCloses #29754 "},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/229514689","html_url":"https://github.com/rust-lang/rust/pull/33940#issuecomment-229514689","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/33940","id":229514689,"user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T22:59:40Z","updated_at":"2016-06-29T22:59:40Z","body":"```\r\nsrc/libcoretest/hash/sip.rs:13:29: 13:40 error: use of unstable library feature 'sip_hash_13' (see issue #29754)\r\nsrc/libcoretest/hash/sip.rs:13 use core::hash::{SipHasher, SipHasher13, SipHasher24};\r\n                                                           ^~~~~~~~~~~\r\nsrc/libcoretest/hash/sip.rs:13:29: 13:40 help: add #![feature(sip_hash_13)] to the crate attributes to enable\r\nsrc/libcoretest/hash/sip.rs:13:42: 13:53 error: use of unstable library feature 'sip_hash_13' (see issue #29754)\r\nsrc/libcoretest/hash/sip.rs:13 use core::hash::{SipHasher, SipHasher13, SipHasher24};\r\n                                                                        ^~~~~~~~~~~\r\nsrc/libcoretest/hash/sip.rs:13:42: 13:53 help: add #![feature(sip_hash_13)] to the crate attributes to enable\r\nsrc/libcoretest/hash/sip.rs:136:25: 136:51 error: use of unstable library feature 'sip_hash_13' (see issue #29754)\r\nsrc/libcoretest/hash/sip.rs:136     let mut state_inc = SipHasher13::new_with_keys(k0, k1);\r\n                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~\r\nsrc/libcoretest/hash/sip.rs:136:25: 136:51 help: add #![feature(sip_hash_13)] to the crate attributes to enable\r\nsrc/libcoretest/hash/sip.rs:140:29: 140:55 error: use of unstable library feature 'sip_hash_13' (see issue #29754)\r\nsrc/libcoretest/hash/sip.rs:140         let out = hash_with(SipHasher13::new_with_keys(k0, k1), &Bytes(&buf));\r\n                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~\r\nsrc/libcoretest/hash/sip.rs:140:29: 140:55 help: add #![feature(sip_hash_13)] to the crate attributes to enable\r\nsrc/libcoretest/hash/sip.rs:143:30: 143:56 error: use of unstable library feature 'sip_hash_13' (see issue #29754)\r\nsrc/libcoretest/hash/sip.rs:143         let full = hash_with(SipHasher13::new_with_keys(k0, k1), &Bytes(&buf));\r\n                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~\r\nsrc/libcoretest/hash/sip.rs:143:30: 143:56 help: add #![feature(sip_hash_13)] to the crate attributes to enable\r\nsrc/libcoretest/hash/sip.rs:230:25: 230:51 error: use of unstable library feature 'sip_hash_13' (see issue #29754)\r\nsrc/libcoretest/hash/sip.rs:230     let mut state_inc = SipHasher24::new_with_keys(k0, k1);\r\n                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~\r\nsrc/libcoretest/hash/sip.rs:230:25: 230:51 help: add #![feature(sip_hash_13)] to the crate attributes to enable\r\nsrc/libcoretest/hash/sip.rs:234:29: 234:55 error: use of unstable library feature 'sip_hash_13' (see issue #29754)\r\nsrc/libcoretest/hash/sip.rs:234         let out = hash_with(SipHasher24::new_with_keys(k0, k1), &Bytes(&buf));\r\n                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~\r\nsrc/libcoretest/hash/sip.rs:234:29: 234:55 help: add #![feature(sip_hash_13)] to the crate attributes to enable\r\nsrc/libcoretest/hash/sip.rs:237:30: 237:56 error: use of unstable library feature 'sip_hash_13' (see issue #29754)\r\nsrc/libcoretest/hash/sip.rs:237         let full = hash_with(SipHasher24::new_with_keys(k0, k1), &Bytes(&buf));\r\n```"}}
{"actor":{"display_login":"sfackler"}}