{"action":"created","comment":{"url":"https://api.github.com/repos/davidfowl/Channels/pulls/comments/77046892","id":77046892,"diff_hunk":"@@ -130,16 +139,67 @@ private static void OnThreadStart(object state)\n                     var error = GetLastError();\n                     if (error != 258)\n                     {\n-                        throw new Exception(string.Format(\"ERROR: GetQueuedCompletionStatusEx returned {0}\", error));\n+                        throw new Exception($\"ERROR: GetQueuedCompletionStatusEx returned {error}\");\n                     }\n                 }\n             }\n+\n+#if net451","path":"src/Channels.Networking.Windows.RIO/Internal/RioThread.cs","position":69,"original_position":69,"commit_id":"42301cad25f3f92f80f3edb24f76a4e7462b460c","original_commit_id":"42301cad25f3f92f80f3edb24f76a4e7462b460c","user":{"login":"davidfowl","id":95136,"avatar_url":"https://avatars.githubusercontent.com/u/95136?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"body":"nit: uppercase","created_at":"2016-08-31T18:37:20Z","updated_at":"2016-08-31T18:37:20Z","html_url":"https://github.com/davidfowl/Channels/pull/33#discussion_r77046892","pull_request_url":"https://api.github.com/repos/davidfowl/Channels/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/davidfowl/Channels/pulls/comments/77046892"},"html":{"href":"https://github.com/davidfowl/Channels/pull/33#discussion_r77046892"},"pull_request":{"href":"https://api.github.com/repos/davidfowl/Channels/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/davidfowl/Channels/pulls/33","id":83460281,"html_url":"https://github.com/davidfowl/Channels/pull/33","diff_url":"https://github.com/davidfowl/Channels/pull/33.diff","patch_url":"https://github.com/davidfowl/Channels/pull/33.patch","issue_url":"https://api.github.com/repos/davidfowl/Channels/issues/33","number":33,"state":"open","locked":false,"title":"Rio threadpool","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"body":"* Move request processing off RIO threads\t\r\n* Affinitize RIO threads to physical cores\r\n* Don't count logical cores","created_at":"2016-08-31T14:12:16Z","updated_at":"2016-08-31T18:37:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77311ffdb8ca123d266ccf3c9b30f7659e0d74fa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/davidfowl/Channels/pulls/33/commits","review_comments_url":"https://api.github.com/repos/davidfowl/Channels/pulls/33/comments","review_comment_url":"https://api.github.com/repos/davidfowl/Channels/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davidfowl/Channels/issues/33/comments","statuses_url":"https://api.github.com/repos/davidfowl/Channels/statuses/42301cad25f3f92f80f3edb24f76a4e7462b460c","head":{"label":"benaadams:rio-threadpool","ref":"rio-threadpool","sha":"42301cad25f3f92f80f3edb24f76a4e7462b460c","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"repo":{"id":64987778,"name":"Channels","full_name":"benaadams/Channels","owner":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benaadams/Channels","description":"Replacement for Streams","fork":true,"url":"https://api.github.com/repos/benaadams/Channels","forks_url":"https://api.github.com/repos/benaadams/Channels/forks","keys_url":"https://api.github.com/repos/benaadams/Channels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benaadams/Channels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benaadams/Channels/teams","hooks_url":"https://api.github.com/repos/benaadams/Channels/hooks","issue_events_url":"https://api.github.com/repos/benaadams/Channels/issues/events{/number}","events_url":"https://api.github.com/repos/benaadams/Channels/events","assignees_url":"https://api.github.com/repos/benaadams/Channels/assignees{/user}","branches_url":"https://api.github.com/repos/benaadams/Channels/branches{/branch}","tags_url":"https://api.github.com/repos/benaadams/Channels/tags","blobs_url":"https://api.github.com/repos/benaadams/Channels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benaadams/Channels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benaadams/Channels/git/refs{/sha}","trees_url":"https://api.github.com/repos/benaadams/Channels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benaadams/Channels/statuses/{sha}","languages_url":"https://api.github.com/repos/benaadams/Channels/languages","stargazers_url":"https://api.github.com/repos/benaadams/Channels/stargazers","contributors_url":"https://api.github.com/repos/benaadams/Channels/contributors","subscribers_url":"https://api.github.com/repos/benaadams/Channels/subscribers","subscription_url":"https://api.github.com/repos/benaadams/Channels/subscription","commits_url":"https://api.github.com/repos/benaadams/Channels/commits{/sha}","git_commits_url":"https://api.github.com/repos/benaadams/Channels/git/commits{/sha}","comments_url":"https://api.github.com/repos/benaadams/Channels/comments{/number}","issue_comment_url":"https://api.github.com/repos/benaadams/Channels/issues/comments{/number}","contents_url":"https://api.github.com/repos/benaadams/Channels/contents/{+path}","compare_url":"https://api.github.com/repos/benaadams/Channels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benaadams/Channels/merges","archive_url":"https://api.github.com/repos/benaadams/Channels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benaadams/Channels/downloads","issues_url":"https://api.github.com/repos/benaadams/Channels/issues{/number}","pulls_url":"https://api.github.com/repos/benaadams/Channels/pulls{/number}","milestones_url":"https://api.github.com/repos/benaadams/Channels/milestones{/number}","notifications_url":"https://api.github.com/repos/benaadams/Channels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benaadams/Channels/labels{/name}","releases_url":"https://api.github.com/repos/benaadams/Channels/releases{/id}","deployments_url":"https://api.github.com/repos/benaadams/Channels/deployments","created_at":"2016-08-05T04:08:39Z","updated_at":"2016-08-05T04:08:40Z","pushed_at":"2016-08-31T18:21:11Z","git_url":"git://github.com/benaadams/Channels.git","ssh_url":"git@github.com:benaadams/Channels.git","clone_url":"https://github.com/benaadams/Channels.git","svn_url":"https://github.com/benaadams/Channels","homepage":null,"size":326,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"davidfowl:master","ref":"master","sha":"cdc7ad20bcf34818f5887b29fea5483301f57fe4","user":{"login":"davidfowl","id":95136,"avatar_url":"https://avatars.githubusercontent.com/u/95136?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"repo":{"id":64905710,"name":"Channels","full_name":"davidfowl/Channels","owner":{"login":"davidfowl","id":95136,"avatar_url":"https://avatars.githubusercontent.com/u/95136?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidfowl/Channels","description":"Zero Copy .NET Streams","fork":false,"url":"https://api.github.com/repos/davidfowl/Channels","forks_url":"https://api.github.com/repos/davidfowl/Channels/forks","keys_url":"https://api.github.com/repos/davidfowl/Channels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidfowl/Channels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidfowl/Channels/teams","hooks_url":"https://api.github.com/repos/davidfowl/Channels/hooks","issue_events_url":"https://api.github.com/repos/davidfowl/Channels/issues/events{/number}","events_url":"https://api.github.com/repos/davidfowl/Channels/events","assignees_url":"https://api.github.com/repos/davidfowl/Channels/assignees{/user}","branches_url":"https://api.github.com/repos/davidfowl/Channels/branches{/branch}","tags_url":"https://api.github.com/repos/davidfowl/Channels/tags","blobs_url":"https://api.github.com/repos/davidfowl/Channels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidfowl/Channels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidfowl/Channels/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidfowl/Channels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidfowl/Channels/statuses/{sha}","languages_url":"https://api.github.com/repos/davidfowl/Channels/languages","stargazers_url":"https://api.github.com/repos/davidfowl/Channels/stargazers","contributors_url":"https://api.github.com/repos/davidfowl/Channels/contributors","subscribers_url":"https://api.github.com/repos/davidfowl/Channels/subscribers","subscription_url":"https://api.github.com/repos/davidfowl/Channels/subscription","commits_url":"https://api.github.com/repos/davidfowl/Channels/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidfowl/Channels/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidfowl/Channels/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidfowl/Channels/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidfowl/Channels/contents/{+path}","compare_url":"https://api.github.com/repos/davidfowl/Channels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidfowl/Channels/merges","archive_url":"https://api.github.com/repos/davidfowl/Channels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidfowl/Channels/downloads","issues_url":"https://api.github.com/repos/davidfowl/Channels/issues{/number}","pulls_url":"https://api.github.com/repos/davidfowl/Channels/pulls{/number}","milestones_url":"https://api.github.com/repos/davidfowl/Channels/milestones{/number}","notifications_url":"https://api.github.com/repos/davidfowl/Channels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidfowl/Channels/labels{/name}","releases_url":"https://api.github.com/repos/davidfowl/Channels/releases{/id}","deployments_url":"https://api.github.com/repos/davidfowl/Channels/deployments","created_at":"2016-08-04T05:38:45Z","updated_at":"2016-08-31T17:59:03Z","pushed_at":"2016-08-31T18:21:11Z","git_url":"git://github.com/davidfowl/Channels.git","ssh_url":"git@github.com:davidfowl/Channels.git","clone_url":"https://github.com/davidfowl/Channels.git","svn_url":"https://github.com/davidfowl/Channels","homepage":"","size":335,"stargazers_count":124,"watchers_count":124,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":14,"forks":15,"open_issues":14,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/davidfowl/Channels/pulls/33"},"html":{"href":"https://github.com/davidfowl/Channels/pull/33"},"issue":{"href":"https://api.github.com/repos/davidfowl/Channels/issues/33"},"comments":{"href":"https://api.github.com/repos/davidfowl/Channels/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/davidfowl/Channels/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/davidfowl/Channels/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davidfowl/Channels/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/davidfowl/Channels/statuses/42301cad25f3f92f80f3edb24f76a4e7462b460c"}}}}
{"actor":{"display_login":"davidfowl"}}