{"action":"created","issue":{"url":"https://api.github.com/repos/firehol/netdata/issues/186","repository_url":"https://api.github.com/repos/firehol/netdata","labels_url":"https://api.github.com/repos/firehol/netdata/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/firehol/netdata/issues/186/comments","events_url":"https://api.github.com/repos/firehol/netdata/issues/186/events","html_url":"https://github.com/firehol/netdata/pull/186","id":146066139,"number":186,"title":"cleanup rpm .spec","user":{"login":"glensc","id":199095,"avatar_url":"https://avatars.githubusercontent.com/u/199095?v=3","gravatar_id":"","url":"https://api.github.com/users/glensc","html_url":"https://github.com/glensc","followers_url":"https://api.github.com/users/glensc/followers","following_url":"https://api.github.com/users/glensc/following{/other_user}","gists_url":"https://api.github.com/users/glensc/gists{/gist_id}","starred_url":"https://api.github.com/users/glensc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glensc/subscriptions","organizations_url":"https://api.github.com/users/glensc/orgs","repos_url":"https://api.github.com/users/glensc/repos","events_url":"https://api.github.com/users/glensc/events{/privacy}","received_events_url":"https://api.github.com/users/glensc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":65,"created_at":"2016-04-05T18:12:25Z","updated_at":"2016-04-15T07:28:44Z","closed_at":"2016-04-14T19:54:31Z","pull_request":{"url":"https://api.github.com/repos/firehol/netdata/pulls/186","html_url":"https://github.com/firehol/netdata/pull/186","diff_url":"https://github.com/firehol/netdata/pull/186.diff","patch_url":"https://github.com/firehol/netdata/pull/186.patch"},"body":"i added this package to [PLD Linux](https://github.com/pld-linux/netdata), so i thought to contribute back some fixes:\r\n\r\n- use bconds for conditions, more readable and you can control them via commandline: `rpmbuild -bb --with nfacct` or `--without nfacct`\r\n- add `Group:` tag, `%clean` block needed for older rpm systems and does not hurt others\r\n- add Source0 as URL directly downloading from GitHub, rpmbuild is able to fetch it itself\r\n- add autofoo run and dependencies (github tarball does not contain autogenerated files)\r\n- omit runtime deps. rpm versions old as last decade can generate SONAME dependencies properly\r\n- enchance description from website\r\n- <del>fix path to systemd file to be installed</del>\r\n- drop bogus ovirt_create_user_engine define in the middle of the .spec\r\n- there's no need for -n in %prep as default is %{name}-%{version}\r\n- fix config dir declaration %config applies to files, not directory\r\n- use fixed permission for /var directories, for deterministic results (result could vary on umask during build)\r\n- updated URL to current homepage"},"comment":{"url":"https://api.github.com/repos/firehol/netdata/issues/comments/210328114","html_url":"https://github.com/firehol/netdata/pull/186#issuecomment-210328114","issue_url":"https://api.github.com/repos/firehol/netdata/issues/186","id":210328114,"user":{"login":"glensc","id":199095,"avatar_url":"https://avatars.githubusercontent.com/u/199095?v=3","gravatar_id":"","url":"https://api.github.com/users/glensc","html_url":"https://github.com/glensc","followers_url":"https://api.github.com/users/glensc/followers","following_url":"https://api.github.com/users/glensc/following{/other_user}","gists_url":"https://api.github.com/users/glensc/gists{/gist_id}","starred_url":"https://api.github.com/users/glensc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glensc/subscriptions","organizations_url":"https://api.github.com/users/glensc/orgs","repos_url":"https://api.github.com/users/glensc/repos","events_url":"https://api.github.com/users/glensc/events{/privacy}","received_events_url":"https://api.github.com/users/glensc/received_events","type":"User","site_admin":false},"created_at":"2016-04-15T07:28:44Z","updated_at":"2016-04-15T07:28:44Z","body":"yay. i never expected it to take 10 days and 109 posts!"}}