{"action":"created","comment":{"url":"https://api.github.com/repos/mapleinside/cleave/pulls/comments/90529158","pull_request_review_id":11048729,"id":90529158,"diff_hunk":"@@ -21,13 +20,7 @@ function generic({task}) {\n \n       return cp.exec(`cd ${path.join(process.cwd())}/packages/${item} && npm run ${task}`, (error, stdout) => {\n         if (error) {\n-          log.info(error);\n-          log.info('------------------------------');\n-          log.info(`${item}'s package has failed. It's now unset from Cleave resolution.`);\n-\n-          resolvedPackages.splice(resolvedPackages.indexOf(item), 1);\n-\n-          fs.writeFileSync(path.join(process.cwd(), './packages-manifest.json'), JSON.stringify(resolvedPackages));\n+          throw new Error(`Error '$ packages/${item} npm run ${task}': ${error}`);","path":"src/tasks/generic.js","position":18,"original_position":18,"commit_id":"89f5e17cff725c60af9443127358f92bc77cb964","original_commit_id":"89f5e17cff725c60af9443127358f92bc77cb964","user":{"login":"AzuObs","id":9439499,"avatar_url":"https://avatars.githubusercontent.com/u/9439499?v=3","gravatar_id":"","url":"https://api.github.com/users/AzuObs","html_url":"https://github.com/AzuObs","followers_url":"https://api.github.com/users/AzuObs/followers","following_url":"https://api.github.com/users/AzuObs/following{/other_user}","gists_url":"https://api.github.com/users/AzuObs/gists{/gist_id}","starred_url":"https://api.github.com/users/AzuObs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzuObs/subscriptions","organizations_url":"https://api.github.com/users/AzuObs/orgs","repos_url":"https://api.github.com/users/AzuObs/repos","events_url":"https://api.github.com/users/AzuObs/events{/privacy}","received_events_url":"https://api.github.com/users/AzuObs/received_events","type":"User","site_admin":false},"body":"oui ca suffit, j'avai un bash script en local pour dire si un script fail ou succeed, et si je faisai reject(...) ca `OK` mais avec throw ca `FAILURE` donc c'est good :+1: ","created_at":"2016-12-01T20:20:01Z","updated_at":"2016-12-01T20:20:01Z","html_url":"https://github.com/mapleinside/cleave/pull/1#discussion_r90529158","pull_request_url":"https://api.github.com/repos/mapleinside/cleave/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/mapleinside/cleave/pulls/comments/90529158"},"html":{"href":"https://github.com/mapleinside/cleave/pull/1#discussion_r90529158"},"pull_request":{"href":"https://api.github.com/repos/mapleinside/cleave/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/mapleinside/cleave/pulls/1","id":96148332,"html_url":"https://github.com/mapleinside/cleave/pull/1","diff_url":"https://github.com/mapleinside/cleave/pull/1.diff","patch_url":"https://github.com/mapleinside/cleave/pull/1.patch","issue_url":"https://api.github.com/repos/mapleinside/cleave/issues/1","number":1,"state":"open","locked":false,"title":"throw when cleave task fails","user":{"login":"AzuObs","id":9439499,"avatar_url":"https://avatars.githubusercontent.com/u/9439499?v=3","gravatar_id":"","url":"https://api.github.com/users/AzuObs","html_url":"https://github.com/AzuObs","followers_url":"https://api.github.com/users/AzuObs/followers","following_url":"https://api.github.com/users/AzuObs/following{/other_user}","gists_url":"https://api.github.com/users/AzuObs/gists{/gist_id}","starred_url":"https://api.github.com/users/AzuObs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzuObs/subscriptions","organizations_url":"https://api.github.com/users/AzuObs/orgs","repos_url":"https://api.github.com/users/AzuObs/repos","events_url":"https://api.github.com/users/AzuObs/events{/privacy}","received_events_url":"https://api.github.com/users/AzuObs/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-01T18:56:09Z","updated_at":"2016-12-01T20:20:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd2814c8a084c3e54aa37dc11f7707976509bfc2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapleinside/cleave/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mapleinside/cleave/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mapleinside/cleave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapleinside/cleave/issues/1/comments","statuses_url":"https://api.github.com/repos/mapleinside/cleave/statuses/89f5e17cff725c60af9443127358f92bc77cb964","head":{"label":"mapleinside:UNL-2-deploy-ci","ref":"UNL-2-deploy-ci","sha":"89f5e17cff725c60af9443127358f92bc77cb964","user":{"login":"mapleinside","id":14338492,"avatar_url":"https://avatars.githubusercontent.com/u/14338492?v=3","gravatar_id":"","url":"https://api.github.com/users/mapleinside","html_url":"https://github.com/mapleinside","followers_url":"https://api.github.com/users/mapleinside/followers","following_url":"https://api.github.com/users/mapleinside/following{/other_user}","gists_url":"https://api.github.com/users/mapleinside/gists{/gist_id}","starred_url":"https://api.github.com/users/mapleinside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapleinside/subscriptions","organizations_url":"https://api.github.com/users/mapleinside/orgs","repos_url":"https://api.github.com/users/mapleinside/repos","events_url":"https://api.github.com/users/mapleinside/events{/privacy}","received_events_url":"https://api.github.com/users/mapleinside/received_events","type":"Organization","site_admin":false},"repo":{"id":71665731,"name":"cleave","full_name":"mapleinside/cleave","owner":{"login":"mapleinside","id":14338492,"avatar_url":"https://avatars.githubusercontent.com/u/14338492?v=3","gravatar_id":"","url":"https://api.github.com/users/mapleinside","html_url":"https://github.com/mapleinside","followers_url":"https://api.github.com/users/mapleinside/followers","following_url":"https://api.github.com/users/mapleinside/following{/other_user}","gists_url":"https://api.github.com/users/mapleinside/gists{/gist_id}","starred_url":"https://api.github.com/users/mapleinside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapleinside/subscriptions","organizations_url":"https://api.github.com/users/mapleinside/orgs","repos_url":"https://api.github.com/users/mapleinside/repos","events_url":"https://api.github.com/users/mapleinside/events{/privacy}","received_events_url":"https://api.github.com/users/mapleinside/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapleinside/cleave","description":":dizzy: Strike your multirepo with an only-modified package sweeping build.","fork":false,"url":"https://api.github.com/repos/mapleinside/cleave","forks_url":"https://api.github.com/repos/mapleinside/cleave/forks","keys_url":"https://api.github.com/repos/mapleinside/cleave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapleinside/cleave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapleinside/cleave/teams","hooks_url":"https://api.github.com/repos/mapleinside/cleave/hooks","issue_events_url":"https://api.github.com/repos/mapleinside/cleave/issues/events{/number}","events_url":"https://api.github.com/repos/mapleinside/cleave/events","assignees_url":"https://api.github.com/repos/mapleinside/cleave/assignees{/user}","branches_url":"https://api.github.com/repos/mapleinside/cleave/branches{/branch}","tags_url":"https://api.github.com/repos/mapleinside/cleave/tags","blobs_url":"https://api.github.com/repos/mapleinside/cleave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapleinside/cleave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapleinside/cleave/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapleinside/cleave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapleinside/cleave/statuses/{sha}","languages_url":"https://api.github.com/repos/mapleinside/cleave/languages","stargazers_url":"https://api.github.com/repos/mapleinside/cleave/stargazers","contributors_url":"https://api.github.com/repos/mapleinside/cleave/contributors","subscribers_url":"https://api.github.com/repos/mapleinside/cleave/subscribers","subscription_url":"https://api.github.com/repos/mapleinside/cleave/subscription","commits_url":"https://api.github.com/repos/mapleinside/cleave/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapleinside/cleave/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapleinside/cleave/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapleinside/cleave/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapleinside/cleave/contents/{+path}","compare_url":"https://api.github.com/repos/mapleinside/cleave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapleinside/cleave/merges","archive_url":"https://api.github.com/repos/mapleinside/cleave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapleinside/cleave/downloads","issues_url":"https://api.github.com/repos/mapleinside/cleave/issues{/number}","pulls_url":"https://api.github.com/repos/mapleinside/cleave/pulls{/number}","milestones_url":"https://api.github.com/repos/mapleinside/cleave/milestones{/number}","notifications_url":"https://api.github.com/repos/mapleinside/cleave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapleinside/cleave/labels{/name}","releases_url":"https://api.github.com/repos/mapleinside/cleave/releases{/id}","deployments_url":"https://api.github.com/repos/mapleinside/cleave/deployments","created_at":"2016-10-22T21:08:06Z","updated_at":"2016-11-03T20:42:05Z","pushed_at":"2016-12-01T18:56:09Z","git_url":"git://github.com/mapleinside/cleave.git","ssh_url":"git@github.com:mapleinside/cleave.git","clone_url":"https://github.com/mapleinside/cleave.git","svn_url":"https://github.com/mapleinside/cleave","homepage":"","size":22,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mapleinside:master","ref":"master","sha":"5ba85b5187fc61e026ba5899fe482ce5bebca25e","user":{"login":"mapleinside","id":14338492,"avatar_url":"https://avatars.githubusercontent.com/u/14338492?v=3","gravatar_id":"","url":"https://api.github.com/users/mapleinside","html_url":"https://github.com/mapleinside","followers_url":"https://api.github.com/users/mapleinside/followers","following_url":"https://api.github.com/users/mapleinside/following{/other_user}","gists_url":"https://api.github.com/users/mapleinside/gists{/gist_id}","starred_url":"https://api.github.com/users/mapleinside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapleinside/subscriptions","organizations_url":"https://api.github.com/users/mapleinside/orgs","repos_url":"https://api.github.com/users/mapleinside/repos","events_url":"https://api.github.com/users/mapleinside/events{/privacy}","received_events_url":"https://api.github.com/users/mapleinside/received_events","type":"Organization","site_admin":false},"repo":{"id":71665731,"name":"cleave","full_name":"mapleinside/cleave","owner":{"login":"mapleinside","id":14338492,"avatar_url":"https://avatars.githubusercontent.com/u/14338492?v=3","gravatar_id":"","url":"https://api.github.com/users/mapleinside","html_url":"https://github.com/mapleinside","followers_url":"https://api.github.com/users/mapleinside/followers","following_url":"https://api.github.com/users/mapleinside/following{/other_user}","gists_url":"https://api.github.com/users/mapleinside/gists{/gist_id}","starred_url":"https://api.github.com/users/mapleinside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapleinside/subscriptions","organizations_url":"https://api.github.com/users/mapleinside/orgs","repos_url":"https://api.github.com/users/mapleinside/repos","events_url":"https://api.github.com/users/mapleinside/events{/privacy}","received_events_url":"https://api.github.com/users/mapleinside/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapleinside/cleave","description":":dizzy: Strike your multirepo with an only-modified package sweeping build.","fork":false,"url":"https://api.github.com/repos/mapleinside/cleave","forks_url":"https://api.github.com/repos/mapleinside/cleave/forks","keys_url":"https://api.github.com/repos/mapleinside/cleave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapleinside/cleave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapleinside/cleave/teams","hooks_url":"https://api.github.com/repos/mapleinside/cleave/hooks","issue_events_url":"https://api.github.com/repos/mapleinside/cleave/issues/events{/number}","events_url":"https://api.github.com/repos/mapleinside/cleave/events","assignees_url":"https://api.github.com/repos/mapleinside/cleave/assignees{/user}","branches_url":"https://api.github.com/repos/mapleinside/cleave/branches{/branch}","tags_url":"https://api.github.com/repos/mapleinside/cleave/tags","blobs_url":"https://api.github.com/repos/mapleinside/cleave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapleinside/cleave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapleinside/cleave/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapleinside/cleave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapleinside/cleave/statuses/{sha}","languages_url":"https://api.github.com/repos/mapleinside/cleave/languages","stargazers_url":"https://api.github.com/repos/mapleinside/cleave/stargazers","contributors_url":"https://api.github.com/repos/mapleinside/cleave/contributors","subscribers_url":"https://api.github.com/repos/mapleinside/cleave/subscribers","subscription_url":"https://api.github.com/repos/mapleinside/cleave/subscription","commits_url":"https://api.github.com/repos/mapleinside/cleave/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapleinside/cleave/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapleinside/cleave/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapleinside/cleave/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapleinside/cleave/contents/{+path}","compare_url":"https://api.github.com/repos/mapleinside/cleave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapleinside/cleave/merges","archive_url":"https://api.github.com/repos/mapleinside/cleave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapleinside/cleave/downloads","issues_url":"https://api.github.com/repos/mapleinside/cleave/issues{/number}","pulls_url":"https://api.github.com/repos/mapleinside/cleave/pulls{/number}","milestones_url":"https://api.github.com/repos/mapleinside/cleave/milestones{/number}","notifications_url":"https://api.github.com/repos/mapleinside/cleave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapleinside/cleave/labels{/name}","releases_url":"https://api.github.com/repos/mapleinside/cleave/releases{/id}","deployments_url":"https://api.github.com/repos/mapleinside/cleave/deployments","created_at":"2016-10-22T21:08:06Z","updated_at":"2016-11-03T20:42:05Z","pushed_at":"2016-12-01T18:56:09Z","git_url":"git://github.com/mapleinside/cleave.git","ssh_url":"git@github.com:mapleinside/cleave.git","clone_url":"https://github.com/mapleinside/cleave.git","svn_url":"https://github.com/mapleinside/cleave","homepage":"","size":22,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapleinside/cleave/pulls/1"},"html":{"href":"https://github.com/mapleinside/cleave/pull/1"},"issue":{"href":"https://api.github.com/repos/mapleinside/cleave/issues/1"},"comments":{"href":"https://api.github.com/repos/mapleinside/cleave/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mapleinside/cleave/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mapleinside/cleave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapleinside/cleave/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mapleinside/cleave/statuses/89f5e17cff725c60af9443127358f92bc77cb964"}}}}
{"actor":{"display_login":"AzuObs"}}