{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/phobos/pulls/comments/61334417","id":61334417,"diff_hunk":"@@ -0,0 +1,67 @@\n+; Configurue which static analysis checks are enabled\n+[analysis.config.StaticAnalysisConfig]\n+; Check variable, class, struct, interface, union, and function names against t\n+; he Phobos style guide","path":".dscanner.ini","position":null,"original_position":4,"commit_id":"c06775d0e13ed89b71a0461f43aa2b6a7fa32b89","original_commit_id":"8308cb30acd1fd004ae29ccd0fe4faa940c90a0f","user":{"login":"Hackerpilot","id":1657783,"avatar_url":"https://avatars.githubusercontent.com/u/1657783?v=3","gravatar_id":"","url":"https://api.github.com/users/Hackerpilot","html_url":"https://github.com/Hackerpilot","followers_url":"https://api.github.com/users/Hackerpilot/followers","following_url":"https://api.github.com/users/Hackerpilot/following{/other_user}","gists_url":"https://api.github.com/users/Hackerpilot/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackerpilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackerpilot/subscriptions","organizations_url":"https://api.github.com/users/Hackerpilot/orgs","repos_url":"https://api.github.com/users/Hackerpilot/repos","events_url":"https://api.github.com/users/Hackerpilot/events{/privacy}","received_events_url":"https://api.github.com/users/Hackerpilot/received_events","type":"User","site_admin":false},"body":"I blame @burner for the wrapping.","created_at":"2016-04-27T20:55:52Z","updated_at":"2016-04-27T20:55:53Z","html_url":"https://github.com/dlang/phobos/pull/4243#discussion_r61334417","pull_request_url":"https://api.github.com/repos/dlang/phobos/pulls/4243","_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments/61334417"},"html":{"href":"https://github.com/dlang/phobos/pull/4243#discussion_r61334417"},"pull_request":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4243"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/4243","id":67935504,"html_url":"https://github.com/dlang/phobos/pull/4243","diff_url":"https://github.com/dlang/phobos/pull/4243.diff","patch_url":"https://github.com/dlang/phobos/pull/4243.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/4243","number":4243,"state":"closed","locked":false,"title":"use travis CI to lint Phobos","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"follow-up to #4239. Here's a simple setup with Travis.\r\nObviously a lot of stuff fails (= Phobos doesn't stick to it's own style), but I argue that we should fix this and then enable this bot to help submitters.\r\n\r\nUsing [DScanner](https://github.com/Hackerpilot/Dscanner) allows us to check for a couple of goodies:\r\n\r\n- Check for array literals that cause unnecessary allocation\r\n- Check for poor exception handling practices\r\n- Check for use of the deprecated 'delete' keyword\r\n- Check for use of the deprecated floating point operators\r\n- Check number literals for readability\r\n- Checks that opEquals, opCmp, toHash, and toString are either const, immutable or inout.\r\n- Checks for .. expressions where the left side is larger than the right.\r\n- Checks for if statements whose 'then' block is the same as the 'else' block\r\n- Checks for some problems with constructors\r\n- Checks for unused variables and function parameters\r\n- Checks for unused labels\r\n- Checks for duplicate attributes\r\n- Checks that opEquals and toHash are both defined or neither are defined\r\n- Checks for methods or properties whose names conflict with built-in properties\r\n- Checks for confusing code in inline asm statements\r\n- Checks for undocumented public declarations_\r\n- Checks for poor placement of function attributes\r\n- Checks for use of the comma operator\r\n- Checks for redundant expressions in if statements\r\n- Checks for redundant parenthesis\r\n- Checks for lines longer than 120 characters\r\n- Checks for assignment to auto-ref function parameters\r\n- Checks for incorrect infinite range definitions\r\n- Checks for asserts that are always true\r\n\r\nPing @Hackerpilot.\r\n\r\nFor mir we already had to disable a couple of flags due to bugs or coding practices (thus they are not listed here) and I assume as Phobos is a lot bigger, we might need to flip one or other flag, but hey in the end we will have a bot that does all the nitpicking for us!","created_at":"2016-04-26T18:31:48Z","updated_at":"2016-04-27T20:55:53Z","closed_at":"2016-04-27T18:16:07Z","merged_at":"2016-04-27T18:16:07Z","merge_commit_sha":"86d4576e4141e2f28a94d3ae9a2ea9543c4cf31f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/4243/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/4243/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/4243/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/c06775d0e13ed89b71a0461f43aa2b6a7fa32b89","head":{"label":"wilzbach:travis_linting","ref":"travis_linting","sha":"c06775d0e13ed89b71a0461f43aa2b6a7fa32b89","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"repo":{"id":52009651,"name":"phobos","full_name":"wilzbach/phobos","owner":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wilzbach/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/wilzbach/phobos","forks_url":"https://api.github.com/repos/wilzbach/phobos/forks","keys_url":"https://api.github.com/repos/wilzbach/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wilzbach/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wilzbach/phobos/teams","hooks_url":"https://api.github.com/repos/wilzbach/phobos/hooks","issue_events_url":"https://api.github.com/repos/wilzbach/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/wilzbach/phobos/events","assignees_url":"https://api.github.com/repos/wilzbach/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/wilzbach/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/wilzbach/phobos/tags","blobs_url":"https://api.github.com/repos/wilzbach/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wilzbach/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wilzbach/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/wilzbach/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wilzbach/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/wilzbach/phobos/languages","stargazers_url":"https://api.github.com/repos/wilzbach/phobos/stargazers","contributors_url":"https://api.github.com/repos/wilzbach/phobos/contributors","subscribers_url":"https://api.github.com/repos/wilzbach/phobos/subscribers","subscription_url":"https://api.github.com/repos/wilzbach/phobos/subscription","commits_url":"https://api.github.com/repos/wilzbach/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/wilzbach/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/wilzbach/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/wilzbach/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/wilzbach/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/wilzbach/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wilzbach/phobos/merges","archive_url":"https://api.github.com/repos/wilzbach/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wilzbach/phobos/downloads","issues_url":"https://api.github.com/repos/wilzbach/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/wilzbach/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/wilzbach/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/wilzbach/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wilzbach/phobos/labels{/name}","releases_url":"https://api.github.com/repos/wilzbach/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/wilzbach/phobos/deployments","created_at":"2016-02-18T13:38:55Z","updated_at":"2016-03-08T13:03:37Z","pushed_at":"2016-04-27T13:17:44Z","git_url":"git://github.com/wilzbach/phobos.git","ssh_url":"git@github.com:wilzbach/phobos.git","clone_url":"https://github.com/wilzbach/phobos.git","svn_url":"https://github.com/wilzbach/phobos","homepage":"dlang.org/phobos","size":47727,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"0853d4bc2e05e15576a92894bb64a9cd7ff2e389","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"dlang/phobos","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2016-04-26T22:04:08Z","pushed_at":"2016-04-27T20:14:24Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":75568,"stargazers_count":704,"watchers_count":704,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":476,"mirror_url":null,"open_issues_count":82,"forks":476,"open_issues":82,"watchers":704,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4243"},"html":{"href":"https://github.com/dlang/phobos/pull/4243"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/4243"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/4243/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4243/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4243/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/c06775d0e13ed89b71a0461f43aa2b6a7fa32b89"}}}}