{"action":"created","comment":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments/88838205","pull_request_review_id":9398090,"id":88838205,"diff_hunk":"@@ -4037,6 +4046,26 @@ lacking a \"server_name\" extension by terminating the connection with a\n Security issues are discussed throughout this memo, especially in\n {{implementation-notes}}, {{backward-compatibility}}, and {{security-analysis}}.\n \n+## Re-using Ephemeral shares\n+\n+This document refers to client and server key shares as ephemeral. This literally\n+means that they are used for a short time. Keeping the private key secret forever\n+is necessary for the property of Perfect Forward Secrecy. The simplest and safest \n+way to achieve this is to generate a new Diffie-Hellman share for each TLS \n+handshake. This has some cost in processing power. \n+\n+Alternatively, it is possible to save some CPU cycles by generating a ","path":"draft-ietf-tls-tls13.md","position":28,"original_position":28,"commit_id":"c5ec63e50160ed8e2bdba7b7e1bdcd48baf53cbd","original_commit_id":"c5ec63e50160ed8e2bdba7b7e1bdcd48baf53cbd","user":{"login":"yoavnir","id":3176664,"avatar_url":"https://avatars.githubusercontent.com/u/3176664?v=3","gravatar_id":"","url":"https://api.github.com/users/yoavnir","html_url":"https://github.com/yoavnir","followers_url":"https://api.github.com/users/yoavnir/followers","following_url":"https://api.github.com/users/yoavnir/following{/other_user}","gists_url":"https://api.github.com/users/yoavnir/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavnir/subscriptions","organizations_url":"https://api.github.com/users/yoavnir/orgs","repos_url":"https://api.github.com/users/yoavnir/repos","events_url":"https://api.github.com/users/yoavnir/events{/privacy}","received_events_url":"https://api.github.com/users/yoavnir/received_events","type":"User","site_admin":false},"body":"OK","created_at":"2016-11-21T06:54:50Z","updated_at":"2016-11-21T06:54:50Z","html_url":"https://github.com/tlswg/tls13-spec/pull/768#discussion_r88838205","pull_request_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/768","_links":{"self":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments/88838205"},"html":{"href":"https://github.com/tlswg/tls13-spec/pull/768#discussion_r88838205"},"pull_request":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/768"}}},"pull_request":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/768","id":94513432,"html_url":"https://github.com/tlswg/tls13-spec/pull/768","diff_url":"https://github.com/tlswg/tls13-spec/pull/768.diff","patch_url":"https://github.com/tlswg/tls13-spec/pull/768.patch","issue_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/768","number":768,"state":"open","locked":false,"title":"D-H key re-use considerations","user":{"login":"yoavnir","id":3176664,"avatar_url":"https://avatars.githubusercontent.com/u/3176664?v=3","gravatar_id":"","url":"https://api.github.com/users/yoavnir","html_url":"https://github.com/yoavnir","followers_url":"https://api.github.com/users/yoavnir/followers","following_url":"https://api.github.com/users/yoavnir/following{/other_user}","gists_url":"https://api.github.com/users/yoavnir/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavnir/subscriptions","organizations_url":"https://api.github.com/users/yoavnir/orgs","repos_url":"https://api.github.com/users/yoavnir/repos","events_url":"https://api.github.com/users/yoavnir/events{/privacy}","received_events_url":"https://api.github.com/users/yoavnir/received_events","type":"User","site_admin":false},"body":"Added a subsection to the Security Considerations section. It discusses key reuse (do it carefully or do it not).\r\nIt has the \"don't do this or this grape juice might ferment\" weasel words suggested by someone at the meeting.","created_at":"2016-11-20T10:19:28Z","updated_at":"2016-11-21T06:54:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6c2583ed4ac804e538e52c1314ef7b5adada660","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/768/commits","review_comments_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/768/comments","review_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/768/comments","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/c5ec63e50160ed8e2bdba7b7e1bdcd48baf53cbd","head":{"label":"yoavnir:patch-1","ref":"patch-1","sha":"c5ec63e50160ed8e2bdba7b7e1bdcd48baf53cbd","user":{"login":"yoavnir","id":3176664,"avatar_url":"https://avatars.githubusercontent.com/u/3176664?v=3","gravatar_id":"","url":"https://api.github.com/users/yoavnir","html_url":"https://github.com/yoavnir","followers_url":"https://api.github.com/users/yoavnir/followers","following_url":"https://api.github.com/users/yoavnir/following{/other_user}","gists_url":"https://api.github.com/users/yoavnir/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavnir/subscriptions","organizations_url":"https://api.github.com/users/yoavnir/orgs","repos_url":"https://api.github.com/users/yoavnir/repos","events_url":"https://api.github.com/users/yoavnir/events{/privacy}","received_events_url":"https://api.github.com/users/yoavnir/received_events","type":"User","site_admin":false},"repo":{"id":18902181,"name":"tls13-spec","full_name":"yoavnir/tls13-spec","owner":{"login":"yoavnir","id":3176664,"avatar_url":"https://avatars.githubusercontent.com/u/3176664?v=3","gravatar_id":"","url":"https://api.github.com/users/yoavnir","html_url":"https://github.com/yoavnir","followers_url":"https://api.github.com/users/yoavnir/followers","following_url":"https://api.github.com/users/yoavnir/following{/other_user}","gists_url":"https://api.github.com/users/yoavnir/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavnir/subscriptions","organizations_url":"https://api.github.com/users/yoavnir/orgs","repos_url":"https://api.github.com/users/yoavnir/repos","events_url":"https://api.github.com/users/yoavnir/events{/privacy}","received_events_url":"https://api.github.com/users/yoavnir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yoavnir/tls13-spec","description":"TLS 1.3 Specification","fork":true,"url":"https://api.github.com/repos/yoavnir/tls13-spec","forks_url":"https://api.github.com/repos/yoavnir/tls13-spec/forks","keys_url":"https://api.github.com/repos/yoavnir/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yoavnir/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yoavnir/tls13-spec/teams","hooks_url":"https://api.github.com/repos/yoavnir/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/yoavnir/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/yoavnir/tls13-spec/events","assignees_url":"https://api.github.com/repos/yoavnir/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/yoavnir/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/yoavnir/tls13-spec/tags","blobs_url":"https://api.github.com/repos/yoavnir/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yoavnir/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yoavnir/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/yoavnir/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yoavnir/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/yoavnir/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/yoavnir/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/yoavnir/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/yoavnir/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/yoavnir/tls13-spec/subscription","commits_url":"https://api.github.com/repos/yoavnir/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/yoavnir/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/yoavnir/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/yoavnir/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/yoavnir/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/yoavnir/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yoavnir/tls13-spec/merges","archive_url":"https://api.github.com/repos/yoavnir/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yoavnir/tls13-spec/downloads","issues_url":"https://api.github.com/repos/yoavnir/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/yoavnir/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/yoavnir/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/yoavnir/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yoavnir/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/yoavnir/tls13-spec/releases{/id}","deployments_url":"https://api.github.com/repos/yoavnir/tls13-spec/deployments","created_at":"2014-04-18T04:06:16Z","updated_at":"2014-04-18T04:53:15Z","pushed_at":"2016-11-20T10:18:22Z","git_url":"git://github.com/yoavnir/tls13-spec.git","ssh_url":"git@github.com:yoavnir/tls13-spec.git","clone_url":"https://github.com/yoavnir/tls13-spec.git","svn_url":"https://github.com/yoavnir/tls13-spec","homepage":null,"size":2516,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tlswg:master","ref":"master","sha":"0152fb15d0f68a52fddce33b5e8715ccbaa5f291","user":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"repo":{"id":18887842,"name":"tls13-spec","full_name":"tlswg/tls13-spec","owner":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tlswg/tls13-spec","description":"TLS 1.3 Specification","fork":false,"url":"https://api.github.com/repos/tlswg/tls13-spec","forks_url":"https://api.github.com/repos/tlswg/tls13-spec/forks","keys_url":"https://api.github.com/repos/tlswg/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlswg/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlswg/tls13-spec/teams","hooks_url":"https://api.github.com/repos/tlswg/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/tlswg/tls13-spec/events","assignees_url":"https://api.github.com/repos/tlswg/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/tlswg/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/tlswg/tls13-spec/tags","blobs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlswg/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlswg/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/tlswg/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/tlswg/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/tlswg/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/tlswg/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/tlswg/tls13-spec/subscription","commits_url":"https://api.github.com/repos/tlswg/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlswg/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlswg/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/tlswg/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlswg/tls13-spec/merges","archive_url":"https://api.github.com/repos/tlswg/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlswg/tls13-spec/downloads","issues_url":"https://api.github.com/repos/tlswg/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/tlswg/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/tlswg/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlswg/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/tlswg/tls13-spec/releases{/id}","deployments_url":"https://api.github.com/repos/tlswg/tls13-spec/deployments","created_at":"2014-04-17T17:52:32Z","updated_at":"2016-11-20T15:36:52Z","pushed_at":"2016-11-20T10:19:28Z","git_url":"git://github.com/tlswg/tls13-spec.git","ssh_url":"git@github.com:tlswg/tls13-spec.git","clone_url":"https://github.com/tlswg/tls13-spec.git","svn_url":"https://github.com/tlswg/tls13-spec","homepage":null,"size":6307,"stargazers_count":216,"watchers_count":216,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"open_issues_count":33,"forks":97,"open_issues":33,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/768"},"html":{"href":"https://github.com/tlswg/tls13-spec/pull/768"},"issue":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/768"},"comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/768/comments"},"review_comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/768/comments"},"review_comment":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/768/commits"},"statuses":{"href":"https://api.github.com/repos/tlswg/tls13-spec/statuses/c5ec63e50160ed8e2bdba7b7e1bdcd48baf53cbd"}}}}
{"actor":{"display_login":"yoavnir"}}