{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/94161644","pull_request_review_id":14692703,"id":94161644,"diff_hunk":"@@ -145,6 +145,11 @@ namespace ts {\n             description: Diagnostics.Raise_error_on_expressions_and_declarations_with_an_implied_any_type,\r\n         },\r\n         {\r\n+            name: \"noImplicitOverride\",\r\n+            type: \"boolean\",\r\n+            description: Diagnostics.Member_function_0_was_marked_override_but_no_matching_definition_was_found_in_the_superclass_chain_1,\r","path":"src/compiler/commandLineParser.ts","position":6,"original_position":6,"commit_id":"5650b02cd1c7313e36b30bcb035e10f0ba5e3d21","original_commit_id":"5650b02cd1c7313e36b30bcb035e10f0ba5e3d21","user":{"login":"RyanCavanaugh","id":6685088,"avatar_url":"https://avatars.githubusercontent.com/u/6685088?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanCavanaugh","html_url":"https://github.com/RyanCavanaugh","followers_url":"https://api.github.com/users/RyanCavanaugh/followers","following_url":"https://api.github.com/users/RyanCavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/RyanCavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanCavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanCavanaugh/subscriptions","organizations_url":"https://api.github.com/users/RyanCavanaugh/orgs","repos_url":"https://api.github.com/users/RyanCavanaugh/repos","events_url":"https://api.github.com/users/RyanCavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/RyanCavanaugh/received_events","type":"User","site_admin":false},"body":"Description here is what you would see on the commandline under `-?`, i.e. this should be a string like \"Raise an error when overriding class methods are not marked with 'overide'\"","created_at":"2016-12-29T17:51:38Z","updated_at":"2016-12-29T17:51:38Z","html_url":"https://github.com/Microsoft/TypeScript/pull/13217#discussion_r94161644","pull_request_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/13217","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/94161644"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/13217#discussion_r94161644"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/13217"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/13217","id":99680709,"html_url":"https://github.com/Microsoft/TypeScript/pull/13217","diff_url":"https://github.com/Microsoft/TypeScript/pull/13217.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/13217.patch","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/13217","number":13217,"state":"open","locked":false,"title":"Adds override keyword","user":{"login":"pcj","id":50580,"avatar_url":"https://avatars.githubusercontent.com/u/50580?v=3","gravatar_id":"","url":"https://api.github.com/users/pcj","html_url":"https://github.com/pcj","followers_url":"https://api.github.com/users/pcj/followers","following_url":"https://api.github.com/users/pcj/following{/other_user}","gists_url":"https://api.github.com/users/pcj/gists{/gist_id}","starred_url":"https://api.github.com/users/pcj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcj/subscriptions","organizations_url":"https://api.github.com/users/pcj/orgs","repos_url":"https://api.github.com/users/pcj/repos","events_url":"https://api.github.com/users/pcj/events{/privacy}","received_events_url":"https://api.github.com/users/pcj/received_events","type":"User","site_admin":false},"body":"Fixes #2000 \r\n\r\nThis initial commit simply introduces the keyword and performs some initial modifier flags checks.  The actual checks against the inheritance chain are not implemented yet.\r\n\r\n@RyanCavanaugh or other:  Can you suggest when/where the appropriate time to perform these checks are?    \r\n\r\nNo formal review required at this time (obviously), but would appreciate any strategy recommendations or other suggestions.  \r\n","created_at":"2016-12-29T17:41:05Z","updated_at":"2016-12-29T17:51:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0cd8c5078a863df4c595508ec5dc2d5dc5cdba0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/13217/commits","review_comments_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/13217/comments","review_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/13217/comments","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/5650b02cd1c7313e36b30bcb035e10f0ba5e3d21","head":{"label":"wwrd:override","ref":"override","sha":"5650b02cd1c7313e36b30bcb035e10f0ba5e3d21","user":{"login":"wwrd","id":24814949,"avatar_url":"https://avatars.githubusercontent.com/u/24814949?v=3","gravatar_id":"","url":"https://api.github.com/users/wwrd","html_url":"https://github.com/wwrd","followers_url":"https://api.github.com/users/wwrd/followers","following_url":"https://api.github.com/users/wwrd/following{/other_user}","gists_url":"https://api.github.com/users/wwrd/gists{/gist_id}","starred_url":"https://api.github.com/users/wwrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwrd/subscriptions","organizations_url":"https://api.github.com/users/wwrd/orgs","repos_url":"https://api.github.com/users/wwrd/repos","events_url":"https://api.github.com/users/wwrd/events{/privacy}","received_events_url":"https://api.github.com/users/wwrd/received_events","type":"Organization","site_admin":false},"repo":{"id":77555738,"name":"TypeScript","full_name":"wwrd/TypeScript","owner":{"login":"wwrd","id":24814949,"avatar_url":"https://avatars.githubusercontent.com/u/24814949?v=3","gravatar_id":"","url":"https://api.github.com/users/wwrd","html_url":"https://github.com/wwrd","followers_url":"https://api.github.com/users/wwrd/followers","following_url":"https://api.github.com/users/wwrd/following{/other_user}","gists_url":"https://api.github.com/users/wwrd/gists{/gist_id}","starred_url":"https://api.github.com/users/wwrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwrd/subscriptions","organizations_url":"https://api.github.com/users/wwrd/orgs","repos_url":"https://api.github.com/users/wwrd/repos","events_url":"https://api.github.com/users/wwrd/events{/privacy}","received_events_url":"https://api.github.com/users/wwrd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wwrd/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/wwrd/TypeScript","forks_url":"https://api.github.com/repos/wwrd/TypeScript/forks","keys_url":"https://api.github.com/repos/wwrd/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wwrd/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wwrd/TypeScript/teams","hooks_url":"https://api.github.com/repos/wwrd/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/wwrd/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/wwrd/TypeScript/events","assignees_url":"https://api.github.com/repos/wwrd/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/wwrd/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/wwrd/TypeScript/tags","blobs_url":"https://api.github.com/repos/wwrd/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wwrd/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wwrd/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/wwrd/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wwrd/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/wwrd/TypeScript/languages","stargazers_url":"https://api.github.com/repos/wwrd/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/wwrd/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/wwrd/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/wwrd/TypeScript/subscription","commits_url":"https://api.github.com/repos/wwrd/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/wwrd/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/wwrd/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/wwrd/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/wwrd/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/wwrd/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wwrd/TypeScript/merges","archive_url":"https://api.github.com/repos/wwrd/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wwrd/TypeScript/downloads","issues_url":"https://api.github.com/repos/wwrd/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/wwrd/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/wwrd/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/wwrd/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wwrd/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/wwrd/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/wwrd/TypeScript/deployments","created_at":"2016-12-28T19:19:17Z","updated_at":"2016-12-28T19:20:11Z","pushed_at":"2016-12-29T17:33:23Z","git_url":"git://github.com/wwrd/TypeScript.git","ssh_url":"git@github.com:wwrd/TypeScript.git","clone_url":"https://github.com/wwrd/TypeScript.git","svn_url":"https://github.com/wwrd/TypeScript","homepage":"http://www.typescriptlang.org","size":334137,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"69e0677ea1630daec111b5129aae609809d511e9","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":20929025,"name":"TypeScript","full_name":"Microsoft/TypeScript","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":false,"url":"https://api.github.com/repos/Microsoft/TypeScript","forks_url":"https://api.github.com/repos/Microsoft/TypeScript/forks","keys_url":"https://api.github.com/repos/Microsoft/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/TypeScript/teams","hooks_url":"https://api.github.com/repos/Microsoft/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/TypeScript/events","assignees_url":"https://api.github.com/repos/Microsoft/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/TypeScript/tags","blobs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/TypeScript/languages","stargazers_url":"https://api.github.com/repos/Microsoft/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/TypeScript/subscription","commits_url":"https://api.github.com/repos/Microsoft/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/TypeScript/merges","archive_url":"https://api.github.com/repos/Microsoft/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/TypeScript/downloads","issues_url":"https://api.github.com/repos/Microsoft/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/TypeScript/deployments","created_at":"2014-06-17T15:28:39Z","updated_at":"2016-12-29T17:24:46Z","pushed_at":"2016-12-29T17:43:01Z","git_url":"git://github.com/Microsoft/TypeScript.git","ssh_url":"git@github.com:Microsoft/TypeScript.git","clone_url":"https://github.com/Microsoft/TypeScript.git","svn_url":"https://github.com/Microsoft/TypeScript","homepage":"http://www.typescriptlang.org","size":334497,"stargazers_count":17834,"watchers_count":17834,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2493,"mirror_url":null,"open_issues_count":1766,"forks":2493,"open_issues":1766,"watchers":17834,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/13217"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/13217"},"issue":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/13217"},"comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/13217/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/13217/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/13217/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/TypeScript/statuses/5650b02cd1c7313e36b30bcb035e10f0ba5e3d21"}}}}
{"actor":{"display_login":"RyanCavanaugh"}}