{"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp_rpm/pulls/comments/75449903","id":75449903,"diff_hunk":"@@ -54,25 +54,22 @@ For each Pulp-hosted repository that is protected, a consumer certificate can be\n supplied that will be distributed to consumers when they bind. That certificate\n will allow them to access the protected repository.\n \n-Package signature verification\n-------------------------------\n-\n-RPM repositories can have signature verification policy enabled.\n-With this policy it can be restricted if only RPM/SRPM/DRPM packages, that are\n-signed, will be imported and accepted into the repo. There is also a possibility\n-to specify the list of allowed signature keys. These are the keys that are usually\n-used to sign packages. It is enough to provide in the list short key ID that is\n-8 characters long. So during the import phase, packages will be checked with which\n-key they were signed and if this key is among allowed, the import of the package\n-into the repo will be granted. Requirement of the package signature and list of\n-allowed signature keys can be changed at anytime.\n-\n-This signature validation is granted within the current importer settings and current\n-import of the content, without taking into consideration already present content in\n+Package Signatures and GPG Key ID Filtering\n+-------------------------------------------\n+\n+RPM repositories have limited support for acting on package GPG signatures,\n+including requiring packages to have GPG signatures, and whitelisting signing\n+key IDs to only sync packages with matching signing key IDs. The signing key\n+ID filtering feature uses the 8-character \"short\" key ID, which does not uniquely\n+identify a GPG signing key. This feature does not verify package signatures.","path":"docs/user-guide/features.rst","position":26,"original_position":26,"commit_id":"409687edaa792427c7876c815d517b66f05fe25d","original_commit_id":"409687edaa792427c7876c815d517b66f05fe25d","user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"body":"It might be worth putting \"This feature does not verify package signatures\" in a warning block to be extra clear.","created_at":"2016-08-19T09:10:24Z","updated_at":"2016-08-19T09:10:24Z","html_url":"https://github.com/pulp/pulp_rpm/pull/961#discussion_r75449903","pull_request_url":"https://api.github.com/repos/pulp/pulp_rpm/pulls/961","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/comments/75449903"},"html":{"href":"https://github.com/pulp/pulp_rpm/pull/961#discussion_r75449903"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/961"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp_rpm/pulls/961","id":81909098,"html_url":"https://github.com/pulp/pulp_rpm/pull/961","diff_url":"https://github.com/pulp/pulp_rpm/pull/961.diff","patch_url":"https://github.com/pulp/pulp_rpm/pull/961.patch","issue_url":"https://api.github.com/repos/pulp/pulp_rpm/issues/961","number":961,"state":"open","locked":false,"title":"Reclassify signature verification as signature and key ID filtering","user":{"login":"seandst","id":441252,"avatar_url":"https://avatars.githubusercontent.com/u/441252?v=3","gravatar_id":"","url":"https://api.github.com/users/seandst","html_url":"https://github.com/seandst","followers_url":"https://api.github.com/users/seandst/followers","following_url":"https://api.github.com/users/seandst/following{/other_user}","gists_url":"https://api.github.com/users/seandst/gists{/gist_id}","starred_url":"https://api.github.com/users/seandst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seandst/subscriptions","organizations_url":"https://api.github.com/users/seandst/orgs","repos_url":"https://api.github.com/users/seandst/repos","events_url":"https://api.github.com/users/seandst/events{/privacy}","received_events_url":"https://api.github.com/users/seandst/received_events","type":"User","site_admin":false},"body":"The features introduced in #1991 (https://pulp.plan.io/issues/1991) only act\r\nas filters based on whether or not a package is signed, and the short key ID\r\nof the key used to generate that signature. This changes any reference to\r\n\"verification\" introduced with those changes to \"GPG Key ID filtering\", and\r\nin general attempted to clarify that this is not a security feature, while\r\nstill leaving it possible to (hopefully) do GPG package signature verification\r\nin a future version.\r\n\r\nfixes #2188\r\nhttps://pulp.plan.io/issues/2188","created_at":"2016-08-19T00:15:09Z","updated_at":"2016-08-19T09:10:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"458c20767711361889dd8a01ee1d89c597ca61b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp_rpm/pulls/961/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp_rpm/pulls/961/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp_rpm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulp/pulp_rpm/issues/961/comments","statuses_url":"https://api.github.com/repos/pulp/pulp_rpm/statuses/409687edaa792427c7876c815d517b66f05fe25d","head":{"label":"seandst:gpg-key-id-filter","ref":"gpg-key-id-filter","sha":"409687edaa792427c7876c815d517b66f05fe25d","user":{"login":"seandst","id":441252,"avatar_url":"https://avatars.githubusercontent.com/u/441252?v=3","gravatar_id":"","url":"https://api.github.com/users/seandst","html_url":"https://github.com/seandst","followers_url":"https://api.github.com/users/seandst/followers","following_url":"https://api.github.com/users/seandst/following{/other_user}","gists_url":"https://api.github.com/users/seandst/gists{/gist_id}","starred_url":"https://api.github.com/users/seandst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seandst/subscriptions","organizations_url":"https://api.github.com/users/seandst/orgs","repos_url":"https://api.github.com/users/seandst/repos","events_url":"https://api.github.com/users/seandst/events{/privacy}","received_events_url":"https://api.github.com/users/seandst/received_events","type":"User","site_admin":false},"repo":{"id":45409190,"name":"pulp_rpm","full_name":"seandst/pulp_rpm","owner":{"login":"seandst","id":441252,"avatar_url":"https://avatars.githubusercontent.com/u/441252?v=3","gravatar_id":"","url":"https://api.github.com/users/seandst","html_url":"https://github.com/seandst","followers_url":"https://api.github.com/users/seandst/followers","following_url":"https://api.github.com/users/seandst/following{/other_user}","gists_url":"https://api.github.com/users/seandst/gists{/gist_id}","starred_url":"https://api.github.com/users/seandst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seandst/subscriptions","organizations_url":"https://api.github.com/users/seandst/orgs","repos_url":"https://api.github.com/users/seandst/repos","events_url":"https://api.github.com/users/seandst/events{/privacy}","received_events_url":"https://api.github.com/users/seandst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seandst/pulp_rpm","description":"RPM support for Pulp Platform","fork":true,"url":"https://api.github.com/repos/seandst/pulp_rpm","forks_url":"https://api.github.com/repos/seandst/pulp_rpm/forks","keys_url":"https://api.github.com/repos/seandst/pulp_rpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seandst/pulp_rpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seandst/pulp_rpm/teams","hooks_url":"https://api.github.com/repos/seandst/pulp_rpm/hooks","issue_events_url":"https://api.github.com/repos/seandst/pulp_rpm/issues/events{/number}","events_url":"https://api.github.com/repos/seandst/pulp_rpm/events","assignees_url":"https://api.github.com/repos/seandst/pulp_rpm/assignees{/user}","branches_url":"https://api.github.com/repos/seandst/pulp_rpm/branches{/branch}","tags_url":"https://api.github.com/repos/seandst/pulp_rpm/tags","blobs_url":"https://api.github.com/repos/seandst/pulp_rpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seandst/pulp_rpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seandst/pulp_rpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/seandst/pulp_rpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seandst/pulp_rpm/statuses/{sha}","languages_url":"https://api.github.com/repos/seandst/pulp_rpm/languages","stargazers_url":"https://api.github.com/repos/seandst/pulp_rpm/stargazers","contributors_url":"https://api.github.com/repos/seandst/pulp_rpm/contributors","subscribers_url":"https://api.github.com/repos/seandst/pulp_rpm/subscribers","subscription_url":"https://api.github.com/repos/seandst/pulp_rpm/subscription","commits_url":"https://api.github.com/repos/seandst/pulp_rpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/seandst/pulp_rpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/seandst/pulp_rpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/seandst/pulp_rpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/seandst/pulp_rpm/contents/{+path}","compare_url":"https://api.github.com/repos/seandst/pulp_rpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seandst/pulp_rpm/merges","archive_url":"https://api.github.com/repos/seandst/pulp_rpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seandst/pulp_rpm/downloads","issues_url":"https://api.github.com/repos/seandst/pulp_rpm/issues{/number}","pulls_url":"https://api.github.com/repos/seandst/pulp_rpm/pulls{/number}","milestones_url":"https://api.github.com/repos/seandst/pulp_rpm/milestones{/number}","notifications_url":"https://api.github.com/repos/seandst/pulp_rpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seandst/pulp_rpm/labels{/name}","releases_url":"https://api.github.com/repos/seandst/pulp_rpm/releases{/id}","deployments_url":"https://api.github.com/repos/seandst/pulp_rpm/deployments","created_at":"2015-11-02T17:08:33Z","updated_at":"2016-01-11T13:15:46Z","pushed_at":"2016-08-19T00:24:56Z","git_url":"git://github.com/seandst/pulp_rpm.git","ssh_url":"git@github.com:seandst/pulp_rpm.git","clone_url":"https://github.com/seandst/pulp_rpm.git","svn_url":"https://github.com/seandst/pulp_rpm","homepage":null,"size":42825,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:master","ref":"master","sha":"31e3b6c266d0498b99d3b658d8e6bc927c8bf4c8","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":6106345,"name":"pulp_rpm","full_name":"pulp/pulp_rpm","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp_rpm","description":"RPM support for Pulp Platform","fork":false,"url":"https://api.github.com/repos/pulp/pulp_rpm","forks_url":"https://api.github.com/repos/pulp/pulp_rpm/forks","keys_url":"https://api.github.com/repos/pulp/pulp_rpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp_rpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp_rpm/teams","hooks_url":"https://api.github.com/repos/pulp/pulp_rpm/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp_rpm/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp_rpm/events","assignees_url":"https://api.github.com/repos/pulp/pulp_rpm/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp_rpm/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp_rpm/tags","blobs_url":"https://api.github.com/repos/pulp/pulp_rpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp_rpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp_rpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp_rpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp_rpm/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp_rpm/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp_rpm/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp_rpm/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp_rpm/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp_rpm/subscription","commits_url":"https://api.github.com/repos/pulp/pulp_rpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp_rpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp_rpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp_rpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp/pulp_rpm/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp_rpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp_rpm/merges","archive_url":"https://api.github.com/repos/pulp/pulp_rpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp_rpm/downloads","issues_url":"https://api.github.com/repos/pulp/pulp_rpm/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp_rpm/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp_rpm/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp_rpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp_rpm/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp_rpm/releases{/id}","deployments_url":"https://api.github.com/repos/pulp/pulp_rpm/deployments","created_at":"2012-10-06T20:06:16Z","updated_at":"2016-05-16T08:20:21Z","pushed_at":"2016-08-19T00:29:49Z","git_url":"git://github.com/pulp/pulp_rpm.git","ssh_url":"git@github.com:pulp/pulp_rpm.git","clone_url":"https://github.com/pulp/pulp_rpm.git","svn_url":"https://github.com/pulp/pulp_rpm","homepage":null,"size":43206,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":8,"forks":56,"open_issues":8,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/961"},"html":{"href":"https://github.com/pulp/pulp_rpm/pull/961"},"issue":{"href":"https://api.github.com/repos/pulp/pulp_rpm/issues/961"},"comments":{"href":"https://api.github.com/repos/pulp/pulp_rpm/issues/961/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/961/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/961/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp_rpm/statuses/409687edaa792427c7876c815d517b66f05fe25d"}}}}
{"actor":{"display_login":"jeremycline"}}