{"action":"created","issue":{"url":"https://api.github.com/repos/hlzz/libvot/issues/10","repository_url":"https://api.github.com/repos/hlzz/libvot","labels_url":"https://api.github.com/repos/hlzz/libvot/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/hlzz/libvot/issues/10/comments","events_url":"https://api.github.com/repos/hlzz/libvot/issues/10/events","html_url":"https://github.com/hlzz/libvot/pull/10","id":172450833,"number":10,"title":"Adjacency matrix logging, C++ update","user":{"login":"pmoulon","id":3235050,"avatar_url":"https://avatars.githubusercontent.com/u/3235050?v=3","gravatar_id":"","url":"https://api.github.com/users/pmoulon","html_url":"https://github.com/pmoulon","followers_url":"https://api.github.com/users/pmoulon/followers","following_url":"https://api.github.com/users/pmoulon/following{/other_user}","gists_url":"https://api.github.com/users/pmoulon/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoulon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoulon/subscriptions","organizations_url":"https://api.github.com/users/pmoulon/orgs","repos_url":"https://api.github.com/users/pmoulon/repos","events_url":"https://api.github.com/users/pmoulon/events{/privacy}","received_events_url":"https://api.github.com/users/pmoulon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-22T13:21:47Z","updated_at":"2016-08-22T14:25:04Z","closed_at":"2016-08-22T14:13:11Z","pull_request":{"url":"https://api.github.com/repos/hlzz/libvot/pulls/10","html_url":"https://github.com/hlzz/libvot/pull/10","diff_url":"https://github.com/hlzz/libvot/pull/10.diff","patch_url":"https://github.com/hlzz/libvot/pull/10.patch"},"body":"- Add a LIBVOT_USE_OPENCV option to build libvot with opencv support\r\n- Remove unused dependency about openmvg_descriptor.hpp\r\n- Add some const where data must be const\r\n- Use c++11 nullptr\r\n- replace some new X* by std::vector<X>. Despite there is not memory leak, using pointer array increase the risk to have leak when new contributors comes inside the project.\r\n\r\n- Add an option SVG adjacency matrix log to image_search binary.\r\nHere an example of the generated file by libvot on a tiny dataset\r\n![dataset1_adjacency_matrix](https://cloud.githubusercontent.com/assets/3235050/17855942/7d53cbc4-687b-11e6-9b9a-e29378a6c01c.png)\r\nHere the result of OpenMVG matching (all pair tested, only pair that have geometric correspondences are displayed). We can see that the matrix are very similar ;-)\r\n![dataset1_openmvg_geometric_list](https://cloud.githubusercontent.com/assets/3235050/17855943/7d5852e8-687b-11e6-8d6c-24ca570456f3.png)\r\n\r\nHere the same results on a larger dataset:\r\nvoc 25 libvot results:\r\n![dataset_2-adjacency_matrix-voc25](https://cloud.githubusercontent.com/assets/3235050/17856032/e2f3cc36-687b-11e6-8dc3-69ffc35560bd.png)\r\n\r\nvoc 100 libvot results:\r\n![dataset_2-adjacency_matrix-voc100](https://cloud.githubusercontent.com/assets/3235050/17856045/ef02a79a-687b-11e6-9c89-196494d2a411.png)\r\n\r\nHere the openMVG resulting adjacency matrix (again they are close)\r\n![dataset2-openmvg_geometric_list](https://cloud.githubusercontent.com/assets/3235050/17856060/05d76df2-687c-11e6-8cb0-1b8b0c553167.png)\r\n\r\n\r\n**PS: sorry for the tab alignment issue**\r\n- I think that using spaces based tab would make the edit easier, space have regular size across editor, but it's not the same for tabs (windows VS tab is often 4 spaces)"},"comment":{"url":"https://api.github.com/repos/hlzz/libvot/issues/comments/241429327","html_url":"https://github.com/hlzz/libvot/pull/10#issuecomment-241429327","issue_url":"https://api.github.com/repos/hlzz/libvot/issues/10","id":241429327,"user":{"login":"pmoulon","id":3235050,"avatar_url":"https://avatars.githubusercontent.com/u/3235050?v=3","gravatar_id":"","url":"https://api.github.com/users/pmoulon","html_url":"https://github.com/pmoulon","followers_url":"https://api.github.com/users/pmoulon/followers","following_url":"https://api.github.com/users/pmoulon/following{/other_user}","gists_url":"https://api.github.com/users/pmoulon/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoulon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoulon/subscriptions","organizations_url":"https://api.github.com/users/pmoulon/orgs","repos_url":"https://api.github.com/users/pmoulon/repos","events_url":"https://api.github.com/users/pmoulon/events{/privacy}","received_events_url":"https://api.github.com/users/pmoulon/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T14:25:04Z","updated_at":"2016-08-22T14:25:04Z","body":"BSD3 does not impose you to re-share as public the modification you made to a BSD licensed file.\r\nMPL2 impose you to re-share if you modify the file (so if you find a bug you must share it to the community).\r\nMPL2 is still permissive you can build a project with the licence of your choice and use MPL2 licensed files.\r\n\r\nMore info [there](http://choosealicense.com/licenses/mpl-2.0/)\r\nMPL2 can be seen as a connection between GPL & LGPL & MIT:\r\n- MIT do what you want (but be cereful to cite)\r\n- GPL all connected code must be under the same licence (contaminating)\r\n- LGPL use some third party code but only as shared library (does not apply for header only lib, like the svg header file I wrote)."}}
{"actor":{"display_login":"pmoulon"}}