{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/1106","repository_url":"https://api.github.com/repos/solidusio/solidus","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/1106/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1106/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/1106/events","html_url":"https://github.com/solidusio/solidus/pull/1106","id":151950618,"number":1106,"title":"product_picker.js sku lookup actually works","user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-29T19:28:55Z","updated_at":"2016-05-03T04:56:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1106","html_url":"https://github.com/solidusio/solidus/pull/1106","diff_url":"https://github.com/solidusio/solidus/pull/1106.diff","patch_url":"https://github.com/solidusio/solidus/pull/1106.patch"},"body":"This is used in the backend UI for picking products for\r\nSpree::Promotion::Rules::Product, might be used other places too.\r\n\r\nThere was code in there that looked like someone was trying to\r\nlet the query match a product name or sku. But it totally didn't work,\r\ndidn't do anything, was wrong in like two or three different ways. (useless ransack attribute name for `sku`; `m` has to be inside the `q`; value of `m` has to be lowercased `or` not `OR`). \r\n\r\nTook me a couple hours to figure out what was going on, so I figured\r\nI'd share the fix. Sorry, don't know how to test this, looks like\r\nthere aren't any tests for this kind of JS yet?"},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/216435136","html_url":"https://github.com/solidusio/solidus/pull/1106#issuecomment-216435136","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1106","id":216435136,"user":{"login":"mamhoff","id":703401,"avatar_url":"https://avatars.githubusercontent.com/u/703401?v=3","gravatar_id":"","url":"https://api.github.com/users/mamhoff","html_url":"https://github.com/mamhoff","followers_url":"https://api.github.com/users/mamhoff/followers","following_url":"https://api.github.com/users/mamhoff/following{/other_user}","gists_url":"https://api.github.com/users/mamhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mamhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamhoff/subscriptions","organizations_url":"https://api.github.com/users/mamhoff/orgs","repos_url":"https://api.github.com/users/mamhoff/repos","events_url":"https://api.github.com/users/mamhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mamhoff/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T04:56:10Z","updated_at":"2016-05-03T04:56:10Z","body":"This solution only looks for `master` variant SKUs. 👍 for `sku_start."}}