{"action":"created","comment":{"url":"https://api.github.com/repos/brigade/react-waypoint/pulls/comments/66277375","id":66277375,"diff_hunk":"@@ -32,6 +45,20 @@ function debugLog() {\n   console.log(arguments); // eslint-disable-line no-console\n }\n \n+function parseOffsetAsPixels(str) {","path":"src/waypoint.jsx","position":29,"original_position":29,"commit_id":"26dcfe225c41b6a30bd66ee199afdcd13177dafc","original_commit_id":"26dcfe225c41b6a30bd66ee199afdcd13177dafc","user":{"login":"jmeas","id":2322305,"avatar_url":"https://avatars.githubusercontent.com/u/2322305?v=3","gravatar_id":"","url":"https://api.github.com/users/jmeas","html_url":"https://github.com/jmeas","followers_url":"https://api.github.com/users/jmeas/followers","following_url":"https://api.github.com/users/jmeas/following{/other_user}","gists_url":"https://api.github.com/users/jmeas/gists{/gist_id}","starred_url":"https://api.github.com/users/jmeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmeas/subscriptions","organizations_url":"https://api.github.com/users/jmeas/orgs","repos_url":"https://api.github.com/users/jmeas/repos","events_url":"https://api.github.com/users/jmeas/events{/privacy}","received_events_url":"https://api.github.com/users/jmeas/received_events","type":"User","site_admin":false},"body":"Ah, okay! I misunderstood - sorry 🙂","created_at":"2016-06-08T15:24:29Z","updated_at":"2016-06-08T15:24:29Z","html_url":"https://github.com/brigade/react-waypoint/pull/94#discussion_r66277375","pull_request_url":"https://api.github.com/repos/brigade/react-waypoint/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/brigade/react-waypoint/pulls/comments/66277375"},"html":{"href":"https://github.com/brigade/react-waypoint/pull/94#discussion_r66277375"},"pull_request":{"href":"https://api.github.com/repos/brigade/react-waypoint/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/brigade/react-waypoint/pulls/94","id":72771764,"html_url":"https://github.com/brigade/react-waypoint/pull/94","diff_url":"https://github.com/brigade/react-waypoint/pull/94.diff","patch_url":"https://github.com/brigade/react-waypoint/pull/94.patch","issue_url":"https://api.github.com/repos/brigade/react-waypoint/issues/94","number":94,"state":"open","locked":false,"title":"Replace threshold with topOffset and bottomOffset","user":{"login":"jmeas","id":2322305,"avatar_url":"https://avatars.githubusercontent.com/u/2322305?v=3","gravatar_id":"","url":"https://api.github.com/users/jmeas","html_url":"https://github.com/jmeas","followers_url":"https://api.github.com/users/jmeas/followers","following_url":"https://api.github.com/users/jmeas/following{/other_user}","gists_url":"https://api.github.com/users/jmeas/gists{/gist_id}","starred_url":"https://api.github.com/users/jmeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmeas/subscriptions","organizations_url":"https://api.github.com/users/jmeas/orgs","repos_url":"https://api.github.com/users/jmeas/repos","events_url":"https://api.github.com/users/jmeas/events{/privacy}","received_events_url":"https://api.github.com/users/jmeas/received_events","type":"User","site_admin":false},"body":"This is a WIP to resolve https://github.com/brigade/react-waypoint/issues/77\r\n\r\nIt has two notable changes:\r\n\r\n1. `threshold` has been split into `offsetTop` and `offsetBottom`\r\n2. The new options accept strings and numbers. Strings can be of the form `100px` or `20%`. Numbers are assumed to be pixel values\r\n\r\n---\r\n\r\nI haven't added tests 'cause I figure there might be feedback on the implementation. Once the implementation is :+1:'d I'll update the tests.","created_at":"2016-06-06T20:24:39Z","updated_at":"2016-06-08T15:24:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"878a06bdb18b2e67b30dccac54cde7f080c77778","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brigade/react-waypoint/pulls/94/commits","review_comments_url":"https://api.github.com/repos/brigade/react-waypoint/pulls/94/comments","review_comment_url":"https://api.github.com/repos/brigade/react-waypoint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brigade/react-waypoint/issues/94/comments","statuses_url":"https://api.github.com/repos/brigade/react-waypoint/statuses/26dcfe225c41b6a30bd66ee199afdcd13177dafc","head":{"label":"jmeas:offset","ref":"offset","sha":"26dcfe225c41b6a30bd66ee199afdcd13177dafc","user":{"login":"jmeas","id":2322305,"avatar_url":"https://avatars.githubusercontent.com/u/2322305?v=3","gravatar_id":"","url":"https://api.github.com/users/jmeas","html_url":"https://github.com/jmeas","followers_url":"https://api.github.com/users/jmeas/followers","following_url":"https://api.github.com/users/jmeas/following{/other_user}","gists_url":"https://api.github.com/users/jmeas/gists{/gist_id}","starred_url":"https://api.github.com/users/jmeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmeas/subscriptions","organizations_url":"https://api.github.com/users/jmeas/orgs","repos_url":"https://api.github.com/users/jmeas/repos","events_url":"https://api.github.com/users/jmeas/events{/privacy}","received_events_url":"https://api.github.com/users/jmeas/received_events","type":"User","site_admin":false},"repo":{"id":60376443,"name":"react-waypoint","full_name":"jmeas/react-waypoint","owner":{"login":"jmeas","id":2322305,"avatar_url":"https://avatars.githubusercontent.com/u/2322305?v=3","gravatar_id":"","url":"https://api.github.com/users/jmeas","html_url":"https://github.com/jmeas","followers_url":"https://api.github.com/users/jmeas/followers","following_url":"https://api.github.com/users/jmeas/following{/other_user}","gists_url":"https://api.github.com/users/jmeas/gists{/gist_id}","starred_url":"https://api.github.com/users/jmeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmeas/subscriptions","organizations_url":"https://api.github.com/users/jmeas/orgs","repos_url":"https://api.github.com/users/jmeas/repos","events_url":"https://api.github.com/users/jmeas/events{/privacy}","received_events_url":"https://api.github.com/users/jmeas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmeas/react-waypoint","description":"A React component to execute a function whenever you scroll to an element.","fork":true,"url":"https://api.github.com/repos/jmeas/react-waypoint","forks_url":"https://api.github.com/repos/jmeas/react-waypoint/forks","keys_url":"https://api.github.com/repos/jmeas/react-waypoint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmeas/react-waypoint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmeas/react-waypoint/teams","hooks_url":"https://api.github.com/repos/jmeas/react-waypoint/hooks","issue_events_url":"https://api.github.com/repos/jmeas/react-waypoint/issues/events{/number}","events_url":"https://api.github.com/repos/jmeas/react-waypoint/events","assignees_url":"https://api.github.com/repos/jmeas/react-waypoint/assignees{/user}","branches_url":"https://api.github.com/repos/jmeas/react-waypoint/branches{/branch}","tags_url":"https://api.github.com/repos/jmeas/react-waypoint/tags","blobs_url":"https://api.github.com/repos/jmeas/react-waypoint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmeas/react-waypoint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmeas/react-waypoint/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmeas/react-waypoint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmeas/react-waypoint/statuses/{sha}","languages_url":"https://api.github.com/repos/jmeas/react-waypoint/languages","stargazers_url":"https://api.github.com/repos/jmeas/react-waypoint/stargazers","contributors_url":"https://api.github.com/repos/jmeas/react-waypoint/contributors","subscribers_url":"https://api.github.com/repos/jmeas/react-waypoint/subscribers","subscription_url":"https://api.github.com/repos/jmeas/react-waypoint/subscription","commits_url":"https://api.github.com/repos/jmeas/react-waypoint/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmeas/react-waypoint/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmeas/react-waypoint/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmeas/react-waypoint/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmeas/react-waypoint/contents/{+path}","compare_url":"https://api.github.com/repos/jmeas/react-waypoint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmeas/react-waypoint/merges","archive_url":"https://api.github.com/repos/jmeas/react-waypoint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmeas/react-waypoint/downloads","issues_url":"https://api.github.com/repos/jmeas/react-waypoint/issues{/number}","pulls_url":"https://api.github.com/repos/jmeas/react-waypoint/pulls{/number}","milestones_url":"https://api.github.com/repos/jmeas/react-waypoint/milestones{/number}","notifications_url":"https://api.github.com/repos/jmeas/react-waypoint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmeas/react-waypoint/labels{/name}","releases_url":"https://api.github.com/repos/jmeas/react-waypoint/releases{/id}","deployments_url":"https://api.github.com/repos/jmeas/react-waypoint/deployments","created_at":"2016-06-03T20:41:14Z","updated_at":"2016-06-03T20:41:14Z","pushed_at":"2016-06-06T20:20:26Z","git_url":"git://github.com/jmeas/react-waypoint.git","ssh_url":"git@github.com:jmeas/react-waypoint.git","clone_url":"https://github.com/jmeas/react-waypoint.git","svn_url":"https://github.com/jmeas/react-waypoint","homepage":"http://brigade.github.io/react-waypoint/","size":306,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"brigade:master","ref":"master","sha":"405bf4f95c6a250579549fdc5c22182cd6ae4906","user":{"login":"brigade","id":7872961,"avatar_url":"https://avatars.githubusercontent.com/u/7872961?v=3","gravatar_id":"","url":"https://api.github.com/users/brigade","html_url":"https://github.com/brigade","followers_url":"https://api.github.com/users/brigade/followers","following_url":"https://api.github.com/users/brigade/following{/other_user}","gists_url":"https://api.github.com/users/brigade/gists{/gist_id}","starred_url":"https://api.github.com/users/brigade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brigade/subscriptions","organizations_url":"https://api.github.com/users/brigade/orgs","repos_url":"https://api.github.com/users/brigade/repos","events_url":"https://api.github.com/users/brigade/events{/privacy}","received_events_url":"https://api.github.com/users/brigade/received_events","type":"Organization","site_admin":false},"repo":{"id":29881215,"name":"react-waypoint","full_name":"brigade/react-waypoint","owner":{"login":"brigade","id":7872961,"avatar_url":"https://avatars.githubusercontent.com/u/7872961?v=3","gravatar_id":"","url":"https://api.github.com/users/brigade","html_url":"https://github.com/brigade","followers_url":"https://api.github.com/users/brigade/followers","following_url":"https://api.github.com/users/brigade/following{/other_user}","gists_url":"https://api.github.com/users/brigade/gists{/gist_id}","starred_url":"https://api.github.com/users/brigade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brigade/subscriptions","organizations_url":"https://api.github.com/users/brigade/orgs","repos_url":"https://api.github.com/users/brigade/repos","events_url":"https://api.github.com/users/brigade/events{/privacy}","received_events_url":"https://api.github.com/users/brigade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brigade/react-waypoint","description":"A React component to execute a function whenever you scroll to an element.","fork":false,"url":"https://api.github.com/repos/brigade/react-waypoint","forks_url":"https://api.github.com/repos/brigade/react-waypoint/forks","keys_url":"https://api.github.com/repos/brigade/react-waypoint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brigade/react-waypoint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brigade/react-waypoint/teams","hooks_url":"https://api.github.com/repos/brigade/react-waypoint/hooks","issue_events_url":"https://api.github.com/repos/brigade/react-waypoint/issues/events{/number}","events_url":"https://api.github.com/repos/brigade/react-waypoint/events","assignees_url":"https://api.github.com/repos/brigade/react-waypoint/assignees{/user}","branches_url":"https://api.github.com/repos/brigade/react-waypoint/branches{/branch}","tags_url":"https://api.github.com/repos/brigade/react-waypoint/tags","blobs_url":"https://api.github.com/repos/brigade/react-waypoint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brigade/react-waypoint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brigade/react-waypoint/git/refs{/sha}","trees_url":"https://api.github.com/repos/brigade/react-waypoint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brigade/react-waypoint/statuses/{sha}","languages_url":"https://api.github.com/repos/brigade/react-waypoint/languages","stargazers_url":"https://api.github.com/repos/brigade/react-waypoint/stargazers","contributors_url":"https://api.github.com/repos/brigade/react-waypoint/contributors","subscribers_url":"https://api.github.com/repos/brigade/react-waypoint/subscribers","subscription_url":"https://api.github.com/repos/brigade/react-waypoint/subscription","commits_url":"https://api.github.com/repos/brigade/react-waypoint/commits{/sha}","git_commits_url":"https://api.github.com/repos/brigade/react-waypoint/git/commits{/sha}","comments_url":"https://api.github.com/repos/brigade/react-waypoint/comments{/number}","issue_comment_url":"https://api.github.com/repos/brigade/react-waypoint/issues/comments{/number}","contents_url":"https://api.github.com/repos/brigade/react-waypoint/contents/{+path}","compare_url":"https://api.github.com/repos/brigade/react-waypoint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brigade/react-waypoint/merges","archive_url":"https://api.github.com/repos/brigade/react-waypoint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brigade/react-waypoint/downloads","issues_url":"https://api.github.com/repos/brigade/react-waypoint/issues{/number}","pulls_url":"https://api.github.com/repos/brigade/react-waypoint/pulls{/number}","milestones_url":"https://api.github.com/repos/brigade/react-waypoint/milestones{/number}","notifications_url":"https://api.github.com/repos/brigade/react-waypoint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brigade/react-waypoint/labels{/name}","releases_url":"https://api.github.com/repos/brigade/react-waypoint/releases{/id}","deployments_url":"https://api.github.com/repos/brigade/react-waypoint/deployments","created_at":"2015-01-26T20:56:40Z","updated_at":"2016-06-08T15:01:36Z","pushed_at":"2016-06-08T12:38:23Z","git_url":"git://github.com/brigade/react-waypoint.git","ssh_url":"git@github.com:brigade/react-waypoint.git","clone_url":"https://github.com/brigade/react-waypoint.git","svn_url":"https://github.com/brigade/react-waypoint","homepage":"http://brigade.github.io/react-waypoint/","size":347,"stargazers_count":500,"watchers_count":500,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":61,"mirror_url":null,"open_issues_count":10,"forks":61,"open_issues":10,"watchers":500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brigade/react-waypoint/pulls/94"},"html":{"href":"https://github.com/brigade/react-waypoint/pull/94"},"issue":{"href":"https://api.github.com/repos/brigade/react-waypoint/issues/94"},"comments":{"href":"https://api.github.com/repos/brigade/react-waypoint/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/brigade/react-waypoint/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/brigade/react-waypoint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brigade/react-waypoint/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/brigade/react-waypoint/statuses/26dcfe225c41b6a30bd66ee199afdcd13177dafc"}}}}
{"actor":{"display_login":"jmeas"}}