{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/89545432","pull_request_review_id":10091530,"id":89545432,"diff_hunk":"@@ -27,6 +27,38 @@ template <int DisplacementDim>\n class FractureModelBase\n {\n public:\n+    /// The MaterialStateVariables may store material model specific state\n+    /// (other than sigma and eps), which are usually material history\n+    /// dependent. The objects are stored by the user (usually in assembly per\n+    /// integration point) and are created via \\ref\n+    /// createMaterialStateVariables().\n+    struct MaterialStateVariables\n+    {\n+        virtual ~MaterialStateVariables() = default;\n+        virtual void pushBackState() = 0;\n+\n+        void reset()\n+        {\n+            _is_tensile_stress = false;\n+            _shear_yield_function = 0.0;\n+        }\n+\n+        void setShearYieldFucntion(double Fs) { _shear_yield_function = Fs; }","path":"MaterialLib/FractureModels/FractureModelBase.h","position":20,"original_position":20,"commit_id":"f072cf5570b95af64450cd5c4c206f4028d99a67","original_commit_id":"f072cf5570b95af64450cd5c4c206f4028d99a67","user":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=3","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"body":"i don't see its benefit","created_at":"2016-11-24T20:52:46Z","updated_at":"2016-11-24T20:52:46Z","html_url":"https://github.com/ufz/ogs/pull/1571#discussion_r89545432","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1571","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/89545432"},"html":{"href":"https://github.com/ufz/ogs/pull/1571#discussion_r89545432"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1571"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1571","id":94907704,"html_url":"https://github.com/ufz/ogs/pull/1571","diff_url":"https://github.com/ufz/ogs/pull/1571.diff","patch_url":"https://github.com/ufz/ogs/pull/1571.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1571","number":1571,"state":"open","locked":false,"title":"[LIE/HM] Supporting deactivation by material IDs","user":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=3","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"body":"follow up of #1570 ","created_at":"2016-11-22T22:06:24Z","updated_at":"2016-11-24T20:52:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbf2c4c6d799798505948244a6671e0dfeb1848b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1571/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1571/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1571/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/f072cf5570b95af64450cd5c4c206f4028d99a67","head":{"label":"norihiro-w:lie-hm-deactivation","ref":"lie-hm-deactivation","sha":"f072cf5570b95af64450cd5c4c206f4028d99a67","user":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=3","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"repo":{"id":2612310,"name":"ogs","full_name":"norihiro-w/ogs","owner":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=3","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/norihiro-w/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/norihiro-w/ogs","forks_url":"https://api.github.com/repos/norihiro-w/ogs/forks","keys_url":"https://api.github.com/repos/norihiro-w/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/norihiro-w/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/norihiro-w/ogs/teams","hooks_url":"https://api.github.com/repos/norihiro-w/ogs/hooks","issue_events_url":"https://api.github.com/repos/norihiro-w/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/norihiro-w/ogs/events","assignees_url":"https://api.github.com/repos/norihiro-w/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/norihiro-w/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/norihiro-w/ogs/tags","blobs_url":"https://api.github.com/repos/norihiro-w/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/norihiro-w/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/norihiro-w/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/norihiro-w/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/norihiro-w/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/norihiro-w/ogs/languages","stargazers_url":"https://api.github.com/repos/norihiro-w/ogs/stargazers","contributors_url":"https://api.github.com/repos/norihiro-w/ogs/contributors","subscribers_url":"https://api.github.com/repos/norihiro-w/ogs/subscribers","subscription_url":"https://api.github.com/repos/norihiro-w/ogs/subscription","commits_url":"https://api.github.com/repos/norihiro-w/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/norihiro-w/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/norihiro-w/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/norihiro-w/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/norihiro-w/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/norihiro-w/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/norihiro-w/ogs/merges","archive_url":"https://api.github.com/repos/norihiro-w/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/norihiro-w/ogs/downloads","issues_url":"https://api.github.com/repos/norihiro-w/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/norihiro-w/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/norihiro-w/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/norihiro-w/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/norihiro-w/ogs/labels{/name}","releases_url":"https://api.github.com/repos/norihiro-w/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/norihiro-w/ogs/deployments","created_at":"2011-10-20T10:16:18Z","updated_at":"2015-03-17T09:09:07Z","pushed_at":"2016-11-24T11:28:13Z","git_url":"git://github.com/norihiro-w/ogs.git","ssh_url":"git@github.com:norihiro-w/ogs.git","clone_url":"https://github.com/norihiro-w/ogs.git","svn_url":"https://github.com/norihiro-w/ogs","homepage":"www.opengeosys.org","size":43976,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"0a1d583b4783b86f314386e9e2c0d735e912d557","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2016-10-24T08:18:46Z","pushed_at":"2016-11-24T18:20:44Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":27075,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":93,"forks":56,"open_issues":93,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1571"},"html":{"href":"https://github.com/ufz/ogs/pull/1571"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1571"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1571/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1571/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1571/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/f072cf5570b95af64450cd5c4c206f4028d99a67"}}}}
{"actor":{"display_login":"norihiro-w"}}