{"action":"created","issue":{"url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/674","repository_url":"https://api.github.com/repos/rpherbig/dr-scripts","labels_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/674/labels{/name}","comments_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/674/comments","events_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/674/events","html_url":"https://github.com/rpherbig/dr-scripts/issues/674","id":173561904,"number":674,"title":"Universal Cyclic Release","user":{"login":"drboldwin","id":20247624,"avatar_url":"https://avatars.githubusercontent.com/u/20247624?v=3","gravatar_id":"","url":"https://api.github.com/users/drboldwin","html_url":"https://github.com/drboldwin","followers_url":"https://api.github.com/users/drboldwin/followers","following_url":"https://api.github.com/users/drboldwin/following{/other_user}","gists_url":"https://api.github.com/users/drboldwin/gists{/gist_id}","starred_url":"https://api.github.com/users/drboldwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drboldwin/subscriptions","organizations_url":"https://api.github.com/users/drboldwin/orgs","repos_url":"https://api.github.com/users/drboldwin/repos","events_url":"https://api.github.com/users/drboldwin/events{/privacy}","received_events_url":"https://api.github.com/users/drboldwin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rpherbig/dr-scripts/labels/crossing-training","name":"crossing-training","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/rpherbig/dr-scripts/milestones/6","html_url":"https://github.com/rpherbig/dr-scripts/milestones/v7","labels_url":"https://api.github.com/repos/rpherbig/dr-scripts/milestones/6/labels","id":1794395,"number":6,"title":"v7","description":"","creator":{"login":"rpherbig","id":1181607,"avatar_url":"https://avatars.githubusercontent.com/u/1181607?v=3","gravatar_id":"","url":"https://api.github.com/users/rpherbig","html_url":"https://github.com/rpherbig","followers_url":"https://api.github.com/users/rpherbig/followers","following_url":"https://api.github.com/users/rpherbig/following{/other_user}","gists_url":"https://api.github.com/users/rpherbig/gists{/gist_id}","starred_url":"https://api.github.com/users/rpherbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpherbig/subscriptions","organizations_url":"https://api.github.com/users/rpherbig/orgs","repos_url":"https://api.github.com/users/rpherbig/repos","events_url":"https://api.github.com/users/rpherbig/events{/privacy}","received_events_url":"https://api.github.com/users/rpherbig/received_events","type":"User","site_admin":false},"open_issues":68,"closed_issues":91,"state":"open","created_at":"2016-05-29T11:36:30Z","updated_at":"2016-09-01T03:01:06Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2016-08-26T23:24:38Z","updated_at":"2016-09-01T14:38:37Z","closed_at":null,"body":"So Etreu has been mentioning how he wants to get away from the Hard Coded cyclic release that is used and so I thought I'd propose this idea here.  (I haven't tested this and there's things to work through still but at least we can get a dialogue going).\r\n\r\nI thought that we could handle each cyclic spell with 1 line like:\r\n\r\nfput('release #{data['abbrev']') if data['cyclic'] && DRSpells.active_spells[#{data['name']]\"\r\n\r\nnote this would require people to add the line:\r\nname: <spell name> \r\nto their yaml within the spell - example:\r\n\r\n```\r\n  Warding:\r\n    abbrev: GHS\r\n    name: Ghost Shroud\r\n    cyclic: true\r\n```\r\n\r\nthe issue I find is that this is being called in cast_spell and so the data that it is referring to is from the spell it is currently casting - so although this would resolve single cyclics I would really like this to support multiple cyclics (see my other pull request).\r\n\r\nSo perhaps saving those variables as some sort of last_cast and calling it that way instead?  Thoughts?"},"comment":{"url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/comments/244099627","html_url":"https://github.com/rpherbig/dr-scripts/issues/674#issuecomment-244099627","issue_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/674","id":244099627,"user":{"login":"drboldwin","id":20247624,"avatar_url":"https://avatars.githubusercontent.com/u/20247624?v=3","gravatar_id":"","url":"https://api.github.com/users/drboldwin","html_url":"https://github.com/drboldwin","followers_url":"https://api.github.com/users/drboldwin/followers","following_url":"https://api.github.com/users/drboldwin/following{/other_user}","gists_url":"https://api.github.com/users/drboldwin/gists{/gist_id}","starred_url":"https://api.github.com/users/drboldwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drboldwin/subscriptions","organizations_url":"https://api.github.com/users/drboldwin/orgs","repos_url":"https://api.github.com/users/drboldwin/repos","events_url":"https://api.github.com/users/drboldwin/events{/privacy}","received_events_url":"https://api.github.com/users/drboldwin/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T14:38:37Z","updated_at":"2016-09-01T14:38:37Z","body":"I have a working version of this done - but I am having issue transferring what I have in my test.lic to common-arcana.  Not sure why.  Will continue to play with it. "}}
{"actor":{"display_login":"drboldwin"}}