{"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/comments/57324602","id":57324602,"diff_hunk":"@@ -0,0 +1,35 @@\n+/**\n+ * Copyright 2015-2016 The OpenZipkin Authors\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except\n+ * in compliance with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package zipkin.interop;\n+\n+import java.io.Closeable;\n+import java.io.IOException;\n+import zipkin.async.AsyncSpanStore;\n+\n+final class CloseAdapter {\n+\n+  public static void closeQuietly(AsyncSpanStore spanStore) {\n+    if (spanStore instanceof Closeable) {","path":"interop/src/main/java/zipkin/interop/CloseAdapter.java","position":23,"original_position":23,"commit_id":"f6b1fe96b0a67f09a36784bc83b89cb4da28a024","original_commit_id":"f6b1fe96b0a67f09a36784bc83b89cb4da28a024","user":{"login":"anuraaga","id":198344,"avatar_url":"https://avatars.githubusercontent.com/u/198344?v=3","gravatar_id":"","url":"https://api.github.com/users/anuraaga","html_url":"https://github.com/anuraaga","followers_url":"https://api.github.com/users/anuraaga/followers","following_url":"https://api.github.com/users/anuraaga/following{/other_user}","gists_url":"https://api.github.com/users/anuraaga/gists{/gist_id}","starred_url":"https://api.github.com/users/anuraaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuraaga/subscriptions","organizations_url":"https://api.github.com/users/anuraaga/orgs","repos_url":"https://api.github.com/users/anuraaga/repos","events_url":"https://api.github.com/users/anuraaga/events{/privacy}","received_events_url":"https://api.github.com/users/anuraaga/received_events","type":"User","site_admin":false},"body":"Closeable subclasses AutoCloseable so I think it's fine to leave this if out.","created_at":"2016-03-24T14:30:48Z","updated_at":"2016-03-24T14:30:48Z","html_url":"https://github.com/openzipkin/zipkin-java/pull/124#discussion_r57324602","pull_request_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/124","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/comments/57324602"},"html":{"href":"https://github.com/openzipkin/zipkin-java/pull/124#discussion_r57324602"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/124"}}},"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/124","id":64004637,"html_url":"https://github.com/openzipkin/zipkin-java/pull/124","diff_url":"https://github.com/openzipkin/zipkin-java/pull/124.diff","patch_url":"https://github.com/openzipkin/zipkin-java/pull/124.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/124","number":124,"state":"open","locked":false,"title":"Makes it possible for all span stores to implement AsyncSpanStore","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"In a previous pull request, Elasticsearch implemented AsyncSpanStore.\r\n\r\nThis completes the work, with the following summary:\r\n\r\nChanges to backport async goodness to other span stores:\r\n* `guava.AsyncSpanStoreAdapter` lets Guava implement AsyncSpanStore\r\n* `cassandra.CassandraSpanStore` implements Guava and extends ^^\r\n* `InMemorySpanStore` now directly implements AsyncSpanStore\r\n\r\nChanges relating to interop tests:\r\n* `ScalaSpanStoreAdapter` makes twitter.Futures out of AsyncSpanStore\r\n* `async.AsyncSpanStoreAdapter` lets SpanStore implement AsyncSpanStore\r\n* `jdbc.JDBCSpanStore` wraps with ^^ to run interop tests\r\n\r\nFixes #111","created_at":"2016-03-24T08:50:58Z","updated_at":"2016-03-24T14:30:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9877edee64b076f9eac22b0eba948ee8d19856a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/124/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/124/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/124/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-java/statuses/f6b1fe96b0a67f09a36784bc83b89cb4da28a024","head":{"label":"openzipkin:async-others","ref":"async-others","sha":"f6b1fe96b0a67f09a36784bc83b89cb4da28a024","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":40143886,"name":"zipkin-java","full_name":"openzipkin/zipkin-java","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin-java","description":"Experimental java zipkin backend","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-java","forks_url":"https://api.github.com/repos/openzipkin/zipkin-java/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-java/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-java/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-java/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-java/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-java/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-java/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-java/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-java/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-java/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-java/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-java/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-java/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-java/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-java/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-java/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-java/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-java/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-java/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin-java/deployments","created_at":"2015-08-03T19:28:20Z","updated_at":"2016-03-22T20:20:04Z","pushed_at":"2016-03-24T08:50:59Z","git_url":"git://github.com/openzipkin/zipkin-java.git","ssh_url":"git@github.com:openzipkin/zipkin-java.git","clone_url":"https://github.com/openzipkin/zipkin-java.git","svn_url":"https://github.com/openzipkin/zipkin-java","homepage":null,"size":1013,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":12,"forks":16,"open_issues":12,"watchers":28,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"de359e78101799ef3a0d184ad60400f8d12ad410","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":40143886,"name":"zipkin-java","full_name":"openzipkin/zipkin-java","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin-java","description":"Experimental java zipkin backend","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-java","forks_url":"https://api.github.com/repos/openzipkin/zipkin-java/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-java/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-java/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-java/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-java/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-java/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-java/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-java/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-java/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-java/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-java/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-java/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-java/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-java/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-java/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-java/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-java/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-java/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-java/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin-java/deployments","created_at":"2015-08-03T19:28:20Z","updated_at":"2016-03-22T20:20:04Z","pushed_at":"2016-03-24T08:50:59Z","git_url":"git://github.com/openzipkin/zipkin-java.git","ssh_url":"git@github.com:openzipkin/zipkin-java.git","clone_url":"https://github.com/openzipkin/zipkin-java.git","svn_url":"https://github.com/openzipkin/zipkin-java","homepage":null,"size":1013,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":12,"forks":16,"open_issues":12,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/124"},"html":{"href":"https://github.com/openzipkin/zipkin-java/pull/124"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/issues/124"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/statuses/f6b1fe96b0a67f09a36784bc83b89cb4da28a024"}}}}