{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/73811888","id":73811888,"diff_hunk":"@@ -295,6 +305,8 @@ protected function _base() {\n \n \t\tif (!$baseUrl) {\n \t\t\t$base = dirname(env('PHP_SELF'));\n+\t\t\t// Clean up additional / which cause following code to fail..","path":"lib/Cake/Network/CakeRequest.php","position":67,"original_position":67,"commit_id":"acc32f5c58fc0ad6daa44ad6774e7664a9cc0fd4","original_commit_id":"acc32f5c58fc0ad6daa44ad6774e7664a9cc0fd4","user":{"login":"stickler-ci","id":16011037,"avatar_url":"https://avatars.githubusercontent.com/u/16011037?v=3","gravatar_id":"","url":"https://api.github.com/users/stickler-ci","html_url":"https://github.com/stickler-ci","followers_url":"https://api.github.com/users/stickler-ci/followers","following_url":"https://api.github.com/users/stickler-ci/following{/other_user}","gists_url":"https://api.github.com/users/stickler-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/stickler-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickler-ci/subscriptions","organizations_url":"https://api.github.com/users/stickler-ci/orgs","repos_url":"https://api.github.com/users/stickler-ci/repos","events_url":"https://api.github.com/users/stickler-ci/events{/privacy}","received_events_url":"https://api.github.com/users/stickler-ci/received_events","type":"User","site_admin":false},"body":"Spaces must be used to indent lines; tabs are not allowed","created_at":"2016-08-08T00:05:14Z","updated_at":"2016-08-08T00:05:14Z","html_url":"https://github.com/cakephp/cakephp/pull/9228#discussion_r73811888","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9228","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/73811888"},"html":{"href":"https://github.com/cakephp/cakephp/pull/9228#discussion_r73811888"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9228"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/9228","id":80382139,"html_url":"https://github.com/cakephp/cakephp/pull/9228","diff_url":"https://github.com/cakephp/cakephp/pull/9228.diff","patch_url":"https://github.com/cakephp/cakephp/pull/9228.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/9228","number":9228,"state":"open","locked":false,"title":"Issue with CakeRequest::header() and Authorization: header","user":{"login":"sebastienbarre","id":329967,"avatar_url":"https://avatars.githubusercontent.com/u/329967?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienbarre","html_url":"https://github.com/sebastienbarre","followers_url":"https://api.github.com/users/sebastienbarre/followers","following_url":"https://api.github.com/users/sebastienbarre/following{/other_user}","gists_url":"https://api.github.com/users/sebastienbarre/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienbarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienbarre/subscriptions","organizations_url":"https://api.github.com/users/sebastienbarre/orgs","repos_url":"https://api.github.com/users/sebastienbarre/repos","events_url":"https://api.github.com/users/sebastienbarre/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienbarre/received_events","type":"User","site_admin":false},"body":"As described in #9027, `CakeRequest::header()` can not retrieve the `Authorization` header in some situations, such as passing a JSON Web Token. Using `curl -H \"Authorization: Bearer foobar\"` will have Apache set an `Authorization` variable in `$_SERVER`, *not* the `HTTP_AUTHORIZATION` variable `header()` would normally expect. This seems to be specific to `Authorization` though, since `curl -H \"Authori2zation: Bearer foobar\"` will appropriately set `HTTP_AUTHORI2ZATION` in `$_SERVER`.\r\n\r\nIt is unknown to me if `Authorization` is the only header treated that way. As a workaround, this PR will have `header()` try to find the header directly in `$_SERVER` if the expected uppercased `HTTP_FOOBAR` header is not found beforehand.\r\n \r\nThanks\r\nI'm using CakePHP 2.x here, this PR is against 2.8.6. \r\n\r\nUGH, Github, why can't you let me pick the right branch...","created_at":"2016-08-08T00:02:05Z","updated_at":"2016-08-08T00:05:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9228/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9228/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/9228/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/acc32f5c58fc0ad6daa44ad6774e7664a9cc0fd4","head":{"label":"sebastienbarre:header","ref":"header","sha":"acc32f5c58fc0ad6daa44ad6774e7664a9cc0fd4","user":{"login":"sebastienbarre","id":329967,"avatar_url":"https://avatars.githubusercontent.com/u/329967?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienbarre","html_url":"https://github.com/sebastienbarre","followers_url":"https://api.github.com/users/sebastienbarre/followers","following_url":"https://api.github.com/users/sebastienbarre/following{/other_user}","gists_url":"https://api.github.com/users/sebastienbarre/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienbarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienbarre/subscriptions","organizations_url":"https://api.github.com/users/sebastienbarre/orgs","repos_url":"https://api.github.com/users/sebastienbarre/repos","events_url":"https://api.github.com/users/sebastienbarre/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienbarre/received_events","type":"User","site_admin":false},"repo":{"id":64503845,"name":"cakephp","full_name":"sebastienbarre/cakephp","owner":{"login":"sebastienbarre","id":329967,"avatar_url":"https://avatars.githubusercontent.com/u/329967?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienbarre","html_url":"https://github.com/sebastienbarre","followers_url":"https://api.github.com/users/sebastienbarre/followers","following_url":"https://api.github.com/users/sebastienbarre/following{/other_user}","gists_url":"https://api.github.com/users/sebastienbarre/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienbarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienbarre/subscriptions","organizations_url":"https://api.github.com/users/sebastienbarre/orgs","repos_url":"https://api.github.com/users/sebastienbarre/repos","events_url":"https://api.github.com/users/sebastienbarre/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienbarre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastienbarre/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/sebastienbarre/cakephp","forks_url":"https://api.github.com/repos/sebastienbarre/cakephp/forks","keys_url":"https://api.github.com/repos/sebastienbarre/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastienbarre/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastienbarre/cakephp/teams","hooks_url":"https://api.github.com/repos/sebastienbarre/cakephp/hooks","issue_events_url":"https://api.github.com/repos/sebastienbarre/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/sebastienbarre/cakephp/events","assignees_url":"https://api.github.com/repos/sebastienbarre/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/sebastienbarre/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/sebastienbarre/cakephp/tags","blobs_url":"https://api.github.com/repos/sebastienbarre/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastienbarre/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastienbarre/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastienbarre/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastienbarre/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastienbarre/cakephp/languages","stargazers_url":"https://api.github.com/repos/sebastienbarre/cakephp/stargazers","contributors_url":"https://api.github.com/repos/sebastienbarre/cakephp/contributors","subscribers_url":"https://api.github.com/repos/sebastienbarre/cakephp/subscribers","subscription_url":"https://api.github.com/repos/sebastienbarre/cakephp/subscription","commits_url":"https://api.github.com/repos/sebastienbarre/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastienbarre/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastienbarre/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastienbarre/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastienbarre/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/sebastienbarre/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastienbarre/cakephp/merges","archive_url":"https://api.github.com/repos/sebastienbarre/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastienbarre/cakephp/downloads","issues_url":"https://api.github.com/repos/sebastienbarre/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/sebastienbarre/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastienbarre/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastienbarre/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastienbarre/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/sebastienbarre/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/sebastienbarre/cakephp/deployments","created_at":"2016-07-29T18:57:28Z","updated_at":"2016-07-29T18:57:37Z","pushed_at":"2016-08-07T23:50:29Z","git_url":"git://github.com/sebastienbarre/cakephp.git","ssh_url":"git@github.com:sebastienbarre/cakephp.git","clone_url":"https://github.com/sebastienbarre/cakephp.git","svn_url":"https://github.com/sebastienbarre/cakephp","homepage":"http://cakephp.org","size":128400,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"823d2a4b745317fa565bb9e1199bc3866b53240a","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2016-08-07T06:03:08Z","pushed_at":"2016-08-08T00:02:05Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":128656,"stargazers_count":6642,"watchers_count":6642,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3014,"mirror_url":null,"open_issues_count":199,"forks":3014,"open_issues":199,"watchers":6642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9228"},"html":{"href":"https://github.com/cakephp/cakephp/pull/9228"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9228"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9228/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9228/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9228/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/acc32f5c58fc0ad6daa44ad6774e7664a9cc0fd4"}}}}
{"actor":{"display_login":"stickler-ci"}}