{"action":"created","comment":{"url":"https://api.github.com/repos/crashub/crash/pulls/comments/62425581","id":62425581,"diff_hunk":"@@ -192,7 +192,7 @@ else if (ret instanceof Iterable) {\n         else {\n           boolean use = true;\n           for (Object value : closureOptions.values()) {\n-            if (value == ret) {\n+            if (value.equals(ret)) {","path":"shell/src/main/java/org/crsh/lang/impl/groovy/closure/PipeLineClosure.java","position":5,"original_position":5,"commit_id":"db0532b688760cb52b43795337a07326604facf8","original_commit_id":"db0532b688760cb52b43795337a07326604facf8","user":{"login":"Steve973","id":16421339,"avatar_url":"https://avatars.githubusercontent.com/u/16421339?v=3","gravatar_id":"","url":"https://api.github.com/users/Steve973","html_url":"https://github.com/Steve973","followers_url":"https://api.github.com/users/Steve973/followers","following_url":"https://api.github.com/users/Steve973/following{/other_user}","gists_url":"https://api.github.com/users/Steve973/gists{/gist_id}","starred_url":"https://api.github.com/users/Steve973/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Steve973/subscriptions","organizations_url":"https://api.github.com/users/Steve973/orgs","repos_url":"https://api.github.com/users/Steve973/repos","events_url":"https://api.github.com/users/Steve973/events{/privacy}","received_events_url":"https://api.github.com/users/Steve973/received_events","type":"User","site_admin":false},"body":"This is equivalent to Object.equals().  It still checks for identity, so this buys nothing except for a more cluttered expression.","created_at":"2016-05-08T02:57:06Z","updated_at":"2016-05-08T02:57:06Z","html_url":"https://github.com/crashub/crash/pull/110#discussion_r62425581","pull_request_url":"https://api.github.com/repos/crashub/crash/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/crashub/crash/pulls/comments/62425581"},"html":{"href":"https://github.com/crashub/crash/pull/110#discussion_r62425581"},"pull_request":{"href":"https://api.github.com/repos/crashub/crash/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/crashub/crash/pulls/110","id":55985786,"html_url":"https://github.com/crashub/crash/pull/110","diff_url":"https://github.com/crashub/crash/pull/110.diff","patch_url":"https://github.com/crashub/crash/pull/110.patch","issue_url":"https://api.github.com/repos/crashub/crash/issues/110","number":110,"state":"open","locked":false,"title":"Objects should be compared with \"equals()\"","user":{"login":"zeeshanasghar","id":16441340,"avatar_url":"https://avatars.githubusercontent.com/u/16441340?v=3","gravatar_id":"","url":"https://api.github.com/users/zeeshanasghar","html_url":"https://github.com/zeeshanasghar","followers_url":"https://api.github.com/users/zeeshanasghar/followers","following_url":"https://api.github.com/users/zeeshanasghar/following{/other_user}","gists_url":"https://api.github.com/users/zeeshanasghar/gists{/gist_id}","starred_url":"https://api.github.com/users/zeeshanasghar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeeshanasghar/subscriptions","organizations_url":"https://api.github.com/users/zeeshanasghar/orgs","repos_url":"https://api.github.com/users/zeeshanasghar/repos","events_url":"https://api.github.com/users/zeeshanasghar/events{/privacy}","received_events_url":"https://api.github.com/users/zeeshanasghar/received_events","type":"User","site_admin":false},"body":"This pull request is focused on resolving occurrences of Sonar rule \r\nsquid:S1698 Objects should be compared with \"equals()\"\r\n\r\nYou can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S1698\r\nPlease let me know if you have any questions.\r\n\r\nZeeshan","created_at":"2016-01-14T02:34:51Z","updated_at":"2016-05-08T02:57:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85731eff22f0b2e1e1c5c324aa9adb241c371fc9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crashub/crash/pulls/110/commits","review_comments_url":"https://api.github.com/repos/crashub/crash/pulls/110/comments","review_comment_url":"https://api.github.com/repos/crashub/crash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crashub/crash/issues/110/comments","statuses_url":"https://api.github.com/repos/crashub/crash/statuses/db0532b688760cb52b43795337a07326604facf8","head":{"label":"DevFactory:release/object-should-compare-with-equals-fix-3","ref":"release/object-should-compare-with-equals-fix-3","sha":"db0532b688760cb52b43795337a07326604facf8","user":{"login":"DevFactory","id":1516696,"avatar_url":"https://avatars.githubusercontent.com/u/1516696?v=3","gravatar_id":"","url":"https://api.github.com/users/DevFactory","html_url":"https://github.com/DevFactory","followers_url":"https://api.github.com/users/DevFactory/followers","following_url":"https://api.github.com/users/DevFactory/following{/other_user}","gists_url":"https://api.github.com/users/DevFactory/gists{/gist_id}","starred_url":"https://api.github.com/users/DevFactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevFactory/subscriptions","organizations_url":"https://api.github.com/users/DevFactory/orgs","repos_url":"https://api.github.com/users/DevFactory/repos","events_url":"https://api.github.com/users/DevFactory/events{/privacy}","received_events_url":"https://api.github.com/users/DevFactory/received_events","type":"Organization","site_admin":false},"repo":{"id":49378389,"name":"crash","full_name":"DevFactory/crash","owner":{"login":"DevFactory","id":1516696,"avatar_url":"https://avatars.githubusercontent.com/u/1516696?v=3","gravatar_id":"","url":"https://api.github.com/users/DevFactory","html_url":"https://github.com/DevFactory","followers_url":"https://api.github.com/users/DevFactory/followers","following_url":"https://api.github.com/users/DevFactory/following{/other_user}","gists_url":"https://api.github.com/users/DevFactory/gists{/gist_id}","starred_url":"https://api.github.com/users/DevFactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevFactory/subscriptions","organizations_url":"https://api.github.com/users/DevFactory/orgs","repos_url":"https://api.github.com/users/DevFactory/repos","events_url":"https://api.github.com/users/DevFactory/events{/privacy}","received_events_url":"https://api.github.com/users/DevFactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevFactory/crash","description":"The shell for the Java Platform","fork":true,"url":"https://api.github.com/repos/DevFactory/crash","forks_url":"https://api.github.com/repos/DevFactory/crash/forks","keys_url":"https://api.github.com/repos/DevFactory/crash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevFactory/crash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevFactory/crash/teams","hooks_url":"https://api.github.com/repos/DevFactory/crash/hooks","issue_events_url":"https://api.github.com/repos/DevFactory/crash/issues/events{/number}","events_url":"https://api.github.com/repos/DevFactory/crash/events","assignees_url":"https://api.github.com/repos/DevFactory/crash/assignees{/user}","branches_url":"https://api.github.com/repos/DevFactory/crash/branches{/branch}","tags_url":"https://api.github.com/repos/DevFactory/crash/tags","blobs_url":"https://api.github.com/repos/DevFactory/crash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevFactory/crash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevFactory/crash/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevFactory/crash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevFactory/crash/statuses/{sha}","languages_url":"https://api.github.com/repos/DevFactory/crash/languages","stargazers_url":"https://api.github.com/repos/DevFactory/crash/stargazers","contributors_url":"https://api.github.com/repos/DevFactory/crash/contributors","subscribers_url":"https://api.github.com/repos/DevFactory/crash/subscribers","subscription_url":"https://api.github.com/repos/DevFactory/crash/subscription","commits_url":"https://api.github.com/repos/DevFactory/crash/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevFactory/crash/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevFactory/crash/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevFactory/crash/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevFactory/crash/contents/{+path}","compare_url":"https://api.github.com/repos/DevFactory/crash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevFactory/crash/merges","archive_url":"https://api.github.com/repos/DevFactory/crash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevFactory/crash/downloads","issues_url":"https://api.github.com/repos/DevFactory/crash/issues{/number}","pulls_url":"https://api.github.com/repos/DevFactory/crash/pulls{/number}","milestones_url":"https://api.github.com/repos/DevFactory/crash/milestones{/number}","notifications_url":"https://api.github.com/repos/DevFactory/crash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevFactory/crash/labels{/name}","releases_url":"https://api.github.com/repos/DevFactory/crash/releases{/id}","deployments_url":"https://api.github.com/repos/DevFactory/crash/deployments","created_at":"2016-01-10T17:57:05Z","updated_at":"2016-01-10T17:57:07Z","pushed_at":"2016-01-29T14:00:13Z","git_url":"git://github.com/DevFactory/crash.git","ssh_url":"git@github.com:DevFactory/crash.git","clone_url":"https://github.com/DevFactory/crash.git","svn_url":"https://github.com/DevFactory/crash","homepage":"http://www.crashub.org","size":14034,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crashub:master","ref":"master","sha":"0be41acdebb125e6963d04864cbbfb3a4a6c7707","user":{"login":"crashub","id":2612888,"avatar_url":"https://avatars.githubusercontent.com/u/2612888?v=3","gravatar_id":"","url":"https://api.github.com/users/crashub","html_url":"https://github.com/crashub","followers_url":"https://api.github.com/users/crashub/followers","following_url":"https://api.github.com/users/crashub/following{/other_user}","gists_url":"https://api.github.com/users/crashub/gists{/gist_id}","starred_url":"https://api.github.com/users/crashub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crashub/subscriptions","organizations_url":"https://api.github.com/users/crashub/orgs","repos_url":"https://api.github.com/users/crashub/repos","events_url":"https://api.github.com/users/crashub/events{/privacy}","received_events_url":"https://api.github.com/users/crashub/received_events","type":"Organization","site_admin":false},"repo":{"id":1552601,"name":"crash","full_name":"crashub/crash","owner":{"login":"crashub","id":2612888,"avatar_url":"https://avatars.githubusercontent.com/u/2612888?v=3","gravatar_id":"","url":"https://api.github.com/users/crashub","html_url":"https://github.com/crashub","followers_url":"https://api.github.com/users/crashub/followers","following_url":"https://api.github.com/users/crashub/following{/other_user}","gists_url":"https://api.github.com/users/crashub/gists{/gist_id}","starred_url":"https://api.github.com/users/crashub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crashub/subscriptions","organizations_url":"https://api.github.com/users/crashub/orgs","repos_url":"https://api.github.com/users/crashub/repos","events_url":"https://api.github.com/users/crashub/events{/privacy}","received_events_url":"https://api.github.com/users/crashub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crashub/crash","description":"The shell for the Java Platform","fork":false,"url":"https://api.github.com/repos/crashub/crash","forks_url":"https://api.github.com/repos/crashub/crash/forks","keys_url":"https://api.github.com/repos/crashub/crash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crashub/crash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crashub/crash/teams","hooks_url":"https://api.github.com/repos/crashub/crash/hooks","issue_events_url":"https://api.github.com/repos/crashub/crash/issues/events{/number}","events_url":"https://api.github.com/repos/crashub/crash/events","assignees_url":"https://api.github.com/repos/crashub/crash/assignees{/user}","branches_url":"https://api.github.com/repos/crashub/crash/branches{/branch}","tags_url":"https://api.github.com/repos/crashub/crash/tags","blobs_url":"https://api.github.com/repos/crashub/crash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crashub/crash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crashub/crash/git/refs{/sha}","trees_url":"https://api.github.com/repos/crashub/crash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crashub/crash/statuses/{sha}","languages_url":"https://api.github.com/repos/crashub/crash/languages","stargazers_url":"https://api.github.com/repos/crashub/crash/stargazers","contributors_url":"https://api.github.com/repos/crashub/crash/contributors","subscribers_url":"https://api.github.com/repos/crashub/crash/subscribers","subscription_url":"https://api.github.com/repos/crashub/crash/subscription","commits_url":"https://api.github.com/repos/crashub/crash/commits{/sha}","git_commits_url":"https://api.github.com/repos/crashub/crash/git/commits{/sha}","comments_url":"https://api.github.com/repos/crashub/crash/comments{/number}","issue_comment_url":"https://api.github.com/repos/crashub/crash/issues/comments{/number}","contents_url":"https://api.github.com/repos/crashub/crash/contents/{+path}","compare_url":"https://api.github.com/repos/crashub/crash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crashub/crash/merges","archive_url":"https://api.github.com/repos/crashub/crash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crashub/crash/downloads","issues_url":"https://api.github.com/repos/crashub/crash/issues{/number}","pulls_url":"https://api.github.com/repos/crashub/crash/pulls{/number}","milestones_url":"https://api.github.com/repos/crashub/crash/milestones{/number}","notifications_url":"https://api.github.com/repos/crashub/crash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crashub/crash/labels{/name}","releases_url":"https://api.github.com/repos/crashub/crash/releases{/id}","deployments_url":"https://api.github.com/repos/crashub/crash/deployments","created_at":"2011-03-31T20:26:03Z","updated_at":"2016-05-06T05:48:45Z","pushed_at":"2016-05-07T16:34:16Z","git_url":"git://github.com/crashub/crash.git","ssh_url":"git@github.com:crashub/crash.git","clone_url":"https://github.com/crashub/crash.git","svn_url":"https://github.com/crashub/crash","homepage":"http://www.crashub.org","size":20678,"stargazers_count":525,"watchers_count":525,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":120,"mirror_url":null,"open_issues_count":28,"forks":120,"open_issues":28,"watchers":525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crashub/crash/pulls/110"},"html":{"href":"https://github.com/crashub/crash/pull/110"},"issue":{"href":"https://api.github.com/repos/crashub/crash/issues/110"},"comments":{"href":"https://api.github.com/repos/crashub/crash/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/crashub/crash/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/crashub/crash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crashub/crash/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/crashub/crash/statuses/db0532b688760cb52b43795337a07326604facf8"}}}}