{"action":"created","comment":{"url":"https://api.github.com/repos/rusoto/rusoto/pulls/comments/81882205","pull_request_review_id":2829884,"id":81882205,"diff_hunk":"@@ -0,0 +1,20 @@\n+#![cfg(feature = \"iam\")]","path":"tests/sqs.rs","position":1,"original_position":1,"commit_id":"3bcee06f54a940eb199c1f2d215c713b6f9a646a","original_commit_id":"3bcee06f54a940eb199c1f2d215c713b6f9a646a","user":{"login":"matthewkmayer","id":4998189,"avatar_url":"https://avatars.githubusercontent.com/u/4998189?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewkmayer","html_url":"https://github.com/matthewkmayer","followers_url":"https://api.github.com/users/matthewkmayer/followers","following_url":"https://api.github.com/users/matthewkmayer/following{/other_user}","gists_url":"https://api.github.com/users/matthewkmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewkmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewkmayer/subscriptions","organizations_url":"https://api.github.com/users/matthewkmayer/orgs","repos_url":"https://api.github.com/users/matthewkmayer/repos","events_url":"https://api.github.com/users/matthewkmayer/events{/privacy}","received_events_url":"https://api.github.com/users/matthewkmayer/received_events","type":"User","site_admin":false},"body":"Feature should be `sqs` instead of `iam`.","created_at":"2016-10-05T00:30:49Z","updated_at":"2016-10-05T01:00:42Z","html_url":"https://github.com/rusoto/rusoto/pull/235#discussion_r81882205","pull_request_url":"https://api.github.com/repos/rusoto/rusoto/pulls/235","_links":{"self":{"href":"https://api.github.com/repos/rusoto/rusoto/pulls/comments/81882205"},"html":{"href":"https://github.com/rusoto/rusoto/pull/235#discussion_r81882205"},"pull_request":{"href":"https://api.github.com/repos/rusoto/rusoto/pulls/235"}}},"pull_request":{"url":"https://api.github.com/repos/rusoto/rusoto/pulls/235","id":66734066,"html_url":"https://github.com/rusoto/rusoto/pull/235","diff_url":"https://github.com/rusoto/rusoto/pull/235.diff","patch_url":"https://github.com/rusoto/rusoto/pull/235.patch","issue_url":"https://api.github.com/repos/rusoto/rusoto/issues/235","number":235,"state":"open","locked":false,"title":"Implement IAM support","user":{"login":"indiv0","id":641547,"avatar_url":"https://avatars.githubusercontent.com/u/641547?v=3","gravatar_id":"","url":"https://api.github.com/users/indiv0","html_url":"https://github.com/indiv0","followers_url":"https://api.github.com/users/indiv0/followers","following_url":"https://api.github.com/users/indiv0/following{/other_user}","gists_url":"https://api.github.com/users/indiv0/gists{/gist_id}","starred_url":"https://api.github.com/users/indiv0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiv0/subscriptions","organizations_url":"https://api.github.com/users/indiv0/orgs","repos_url":"https://api.github.com/users/indiv0/repos","events_url":"https://api.github.com/users/indiv0/events{/privacy}","received_events_url":"https://api.github.com/users/indiv0/received_events","type":"User","site_admin":false},"body":"# Status\r\n\r\n* [x] Add `iam` feature\r\n* [x] Add `iam` module\r\n* [x] Enable service generation for `iam` in `build.rs`\r\n* [x] Modify `timestamp` handling to assume it is an `f64`, not a `String`\r\n* [x] Ensure that shapes have the proper case\r\n    * AWS types for `IAM` shapes are `camelCased`, not `CamelCased` like the rest of the AWS services.\r\n* [x] Fix XML deserialization for `IAM` responses\r\n* [x] Verify serialization was not broken for other services (e.g. SQS)\r\n* [x] Fix the way the generator generates function names\r\n    * @cmsd2 has fixed this [upstream](https://github.com/whatisinternet/inflector/commit/6b5614c721ece302f4e98d4f370563f184672bc3).\r\n    * Currently it attempts to naively snake case the type, which doesn't work for types like `ListSAMLProviders`, which becomes `list_s_a_m_l_providers`\r\n* [x] Add tests\r\n    * [x] `list_users`\r\n    * [x] `get_users`\r\n    * [x] protocol tests (implemented outside of this PR)\r\n* [x] Update `README.md`\r\n* [x] Wait for https://github.com/rusoto/rusoto/pull/386 to land, then rebase the code to utilize it's `capitalize_first_letter_of_string` function instead.\r\n* [x] Remove or make [these](https://github.com/rusoto/rusoto/pull/235/files#diff-ff8d2313f22100cddc2afca5c3e20414R358) lines debug-only to reduce codegen memory usage\r\n* [x] Squash commits\r\n* [x] Rebase on master\r\n* [x] Fix the usage of `MockResponseReader` by EC2\r\n* [ ] Await code-review\r\n\r\n# Future Issues\r\n\r\n* Fix `timestamp` deserialization to deserialize to `chrono::DateTime<FixedOffset>` (#388)\r\n* Open upstream botocore issue to fix mismatched expected/received `ListInstanceProfiles, ListSigningCertificates, ListSigningCertificatesResult, ListAccessKeys` responses","created_at":"2016-04-16T10:14:36Z","updated_at":"2016-10-05T01:00:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a720403c88d580ae3d4fc0e504284a157a7d39e6","assignee":{"login":"matthewkmayer","id":4998189,"avatar_url":"https://avatars.githubusercontent.com/u/4998189?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewkmayer","html_url":"https://github.com/matthewkmayer","followers_url":"https://api.github.com/users/matthewkmayer/followers","following_url":"https://api.github.com/users/matthewkmayer/following{/other_user}","gists_url":"https://api.github.com/users/matthewkmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewkmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewkmayer/subscriptions","organizations_url":"https://api.github.com/users/matthewkmayer/orgs","repos_url":"https://api.github.com/users/matthewkmayer/repos","events_url":"https://api.github.com/users/matthewkmayer/events{/privacy}","received_events_url":"https://api.github.com/users/matthewkmayer/received_events","type":"User","site_admin":false},"assignees":[{"login":"matthewkmayer","id":4998189,"avatar_url":"https://avatars.githubusercontent.com/u/4998189?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewkmayer","html_url":"https://github.com/matthewkmayer","followers_url":"https://api.github.com/users/matthewkmayer/followers","following_url":"https://api.github.com/users/matthewkmayer/following{/other_user}","gists_url":"https://api.github.com/users/matthewkmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewkmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewkmayer/subscriptions","organizations_url":"https://api.github.com/users/matthewkmayer/orgs","repos_url":"https://api.github.com/users/matthewkmayer/repos","events_url":"https://api.github.com/users/matthewkmayer/events{/privacy}","received_events_url":"https://api.github.com/users/matthewkmayer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rusoto/rusoto/pulls/235/commits","review_comments_url":"https://api.github.com/repos/rusoto/rusoto/pulls/235/comments","review_comment_url":"https://api.github.com/repos/rusoto/rusoto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rusoto/rusoto/issues/235/comments","statuses_url":"https://api.github.com/repos/rusoto/rusoto/statuses/3bcee06f54a940eb199c1f2d215c713b6f9a646a","head":{"label":"indiv0:feat-implement-iam-support","ref":"feat-implement-iam-support","sha":"3bcee06f54a940eb199c1f2d215c713b6f9a646a","user":{"login":"indiv0","id":641547,"avatar_url":"https://avatars.githubusercontent.com/u/641547?v=3","gravatar_id":"","url":"https://api.github.com/users/indiv0","html_url":"https://github.com/indiv0","followers_url":"https://api.github.com/users/indiv0/followers","following_url":"https://api.github.com/users/indiv0/following{/other_user}","gists_url":"https://api.github.com/users/indiv0/gists{/gist_id}","starred_url":"https://api.github.com/users/indiv0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiv0/subscriptions","organizations_url":"https://api.github.com/users/indiv0/orgs","repos_url":"https://api.github.com/users/indiv0/repos","events_url":"https://api.github.com/users/indiv0/events{/privacy}","received_events_url":"https://api.github.com/users/indiv0/received_events","type":"User","site_admin":false},"repo":{"id":55634268,"name":"rusoto","full_name":"indiv0/rusoto","owner":{"login":"indiv0","id":641547,"avatar_url":"https://avatars.githubusercontent.com/u/641547?v=3","gravatar_id":"","url":"https://api.github.com/users/indiv0","html_url":"https://github.com/indiv0","followers_url":"https://api.github.com/users/indiv0/followers","following_url":"https://api.github.com/users/indiv0/following{/other_user}","gists_url":"https://api.github.com/users/indiv0/gists{/gist_id}","starred_url":"https://api.github.com/users/indiv0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiv0/subscriptions","organizations_url":"https://api.github.com/users/indiv0/orgs","repos_url":"https://api.github.com/users/indiv0/repos","events_url":"https://api.github.com/users/indiv0/events{/privacy}","received_events_url":"https://api.github.com/users/indiv0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indiv0/rusoto","description":"AWS SDK for Rust","fork":true,"url":"https://api.github.com/repos/indiv0/rusoto","forks_url":"https://api.github.com/repos/indiv0/rusoto/forks","keys_url":"https://api.github.com/repos/indiv0/rusoto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indiv0/rusoto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indiv0/rusoto/teams","hooks_url":"https://api.github.com/repos/indiv0/rusoto/hooks","issue_events_url":"https://api.github.com/repos/indiv0/rusoto/issues/events{/number}","events_url":"https://api.github.com/repos/indiv0/rusoto/events","assignees_url":"https://api.github.com/repos/indiv0/rusoto/assignees{/user}","branches_url":"https://api.github.com/repos/indiv0/rusoto/branches{/branch}","tags_url":"https://api.github.com/repos/indiv0/rusoto/tags","blobs_url":"https://api.github.com/repos/indiv0/rusoto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indiv0/rusoto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indiv0/rusoto/git/refs{/sha}","trees_url":"https://api.github.com/repos/indiv0/rusoto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indiv0/rusoto/statuses/{sha}","languages_url":"https://api.github.com/repos/indiv0/rusoto/languages","stargazers_url":"https://api.github.com/repos/indiv0/rusoto/stargazers","contributors_url":"https://api.github.com/repos/indiv0/rusoto/contributors","subscribers_url":"https://api.github.com/repos/indiv0/rusoto/subscribers","subscription_url":"https://api.github.com/repos/indiv0/rusoto/subscription","commits_url":"https://api.github.com/repos/indiv0/rusoto/commits{/sha}","git_commits_url":"https://api.github.com/repos/indiv0/rusoto/git/commits{/sha}","comments_url":"https://api.github.com/repos/indiv0/rusoto/comments{/number}","issue_comment_url":"https://api.github.com/repos/indiv0/rusoto/issues/comments{/number}","contents_url":"https://api.github.com/repos/indiv0/rusoto/contents/{+path}","compare_url":"https://api.github.com/repos/indiv0/rusoto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indiv0/rusoto/merges","archive_url":"https://api.github.com/repos/indiv0/rusoto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indiv0/rusoto/downloads","issues_url":"https://api.github.com/repos/indiv0/rusoto/issues{/number}","pulls_url":"https://api.github.com/repos/indiv0/rusoto/pulls{/number}","milestones_url":"https://api.github.com/repos/indiv0/rusoto/milestones{/number}","notifications_url":"https://api.github.com/repos/indiv0/rusoto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indiv0/rusoto/labels{/name}","releases_url":"https://api.github.com/repos/indiv0/rusoto/releases{/id}","deployments_url":"https://api.github.com/repos/indiv0/rusoto/deployments","created_at":"2016-04-06T19:22:17Z","updated_at":"2016-04-06T19:22:18Z","pushed_at":"2016-10-05T00:56:55Z","git_url":"git://github.com/indiv0/rusoto.git","ssh_url":"git@github.com:indiv0/rusoto.git","clone_url":"https://github.com/indiv0/rusoto.git","svn_url":"https://github.com/indiv0/rusoto","homepage":"","size":10347,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rusoto:master","ref":"master","sha":"0d18596a372de2b463a41a80cbae06663ada1695","user":{"login":"rusoto","id":15861923,"avatar_url":"https://avatars.githubusercontent.com/u/15861923?v=3","gravatar_id":"","url":"https://api.github.com/users/rusoto","html_url":"https://github.com/rusoto","followers_url":"https://api.github.com/users/rusoto/followers","following_url":"https://api.github.com/users/rusoto/following{/other_user}","gists_url":"https://api.github.com/users/rusoto/gists{/gist_id}","starred_url":"https://api.github.com/users/rusoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rusoto/subscriptions","organizations_url":"https://api.github.com/users/rusoto/orgs","repos_url":"https://api.github.com/users/rusoto/repos","events_url":"https://api.github.com/users/rusoto/events{/privacy}","received_events_url":"https://api.github.com/users/rusoto/received_events","type":"Organization","site_admin":false},"repo":{"id":39107211,"name":"rusoto","full_name":"rusoto/rusoto","owner":{"login":"rusoto","id":15861923,"avatar_url":"https://avatars.githubusercontent.com/u/15861923?v=3","gravatar_id":"","url":"https://api.github.com/users/rusoto","html_url":"https://github.com/rusoto","followers_url":"https://api.github.com/users/rusoto/followers","following_url":"https://api.github.com/users/rusoto/following{/other_user}","gists_url":"https://api.github.com/users/rusoto/gists{/gist_id}","starred_url":"https://api.github.com/users/rusoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rusoto/subscriptions","organizations_url":"https://api.github.com/users/rusoto/orgs","repos_url":"https://api.github.com/users/rusoto/repos","events_url":"https://api.github.com/users/rusoto/events{/privacy}","received_events_url":"https://api.github.com/users/rusoto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rusoto/rusoto","description":"AWS SDK for Rust","fork":false,"url":"https://api.github.com/repos/rusoto/rusoto","forks_url":"https://api.github.com/repos/rusoto/rusoto/forks","keys_url":"https://api.github.com/repos/rusoto/rusoto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rusoto/rusoto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rusoto/rusoto/teams","hooks_url":"https://api.github.com/repos/rusoto/rusoto/hooks","issue_events_url":"https://api.github.com/repos/rusoto/rusoto/issues/events{/number}","events_url":"https://api.github.com/repos/rusoto/rusoto/events","assignees_url":"https://api.github.com/repos/rusoto/rusoto/assignees{/user}","branches_url":"https://api.github.com/repos/rusoto/rusoto/branches{/branch}","tags_url":"https://api.github.com/repos/rusoto/rusoto/tags","blobs_url":"https://api.github.com/repos/rusoto/rusoto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rusoto/rusoto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rusoto/rusoto/git/refs{/sha}","trees_url":"https://api.github.com/repos/rusoto/rusoto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rusoto/rusoto/statuses/{sha}","languages_url":"https://api.github.com/repos/rusoto/rusoto/languages","stargazers_url":"https://api.github.com/repos/rusoto/rusoto/stargazers","contributors_url":"https://api.github.com/repos/rusoto/rusoto/contributors","subscribers_url":"https://api.github.com/repos/rusoto/rusoto/subscribers","subscription_url":"https://api.github.com/repos/rusoto/rusoto/subscription","commits_url":"https://api.github.com/repos/rusoto/rusoto/commits{/sha}","git_commits_url":"https://api.github.com/repos/rusoto/rusoto/git/commits{/sha}","comments_url":"https://api.github.com/repos/rusoto/rusoto/comments{/number}","issue_comment_url":"https://api.github.com/repos/rusoto/rusoto/issues/comments{/number}","contents_url":"https://api.github.com/repos/rusoto/rusoto/contents/{+path}","compare_url":"https://api.github.com/repos/rusoto/rusoto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rusoto/rusoto/merges","archive_url":"https://api.github.com/repos/rusoto/rusoto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rusoto/rusoto/downloads","issues_url":"https://api.github.com/repos/rusoto/rusoto/issues{/number}","pulls_url":"https://api.github.com/repos/rusoto/rusoto/pulls{/number}","milestones_url":"https://api.github.com/repos/rusoto/rusoto/milestones{/number}","notifications_url":"https://api.github.com/repos/rusoto/rusoto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rusoto/rusoto/labels{/name}","releases_url":"https://api.github.com/repos/rusoto/rusoto/releases{/id}","deployments_url":"https://api.github.com/repos/rusoto/rusoto/deployments","created_at":"2015-07-15T00:22:17Z","updated_at":"2016-10-04T09:46:17Z","pushed_at":"2016-10-05T00:56:55Z","git_url":"git://github.com/rusoto/rusoto.git","ssh_url":"git@github.com:rusoto/rusoto.git","clone_url":"https://github.com/rusoto/rusoto.git","svn_url":"https://github.com/rusoto/rusoto","homepage":"","size":13380,"stargazers_count":179,"watchers_count":179,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":32,"forks":38,"open_issues":32,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rusoto/rusoto/pulls/235"},"html":{"href":"https://github.com/rusoto/rusoto/pull/235"},"issue":{"href":"https://api.github.com/repos/rusoto/rusoto/issues/235"},"comments":{"href":"https://api.github.com/repos/rusoto/rusoto/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/rusoto/rusoto/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/rusoto/rusoto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rusoto/rusoto/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/rusoto/rusoto/statuses/3bcee06f54a940eb199c1f2d215c713b6f9a646a"}}}}
{"actor":{"display_login":"matthewkmayer"}}