{"action":"created","issue":{"url":"https://api.github.com/repos/caskroom/homebrew-fonts/issues/906","repository_url":"https://api.github.com/repos/caskroom/homebrew-fonts","labels_url":"https://api.github.com/repos/caskroom/homebrew-fonts/issues/906/labels{/name}","comments_url":"https://api.github.com/repos/caskroom/homebrew-fonts/issues/906/comments","events_url":"https://api.github.com/repos/caskroom/homebrew-fonts/issues/906/events","html_url":"https://github.com/caskroom/homebrew-fonts/pull/906","id":186775671,"number":906,"title":"Add missing fonts from Google fonts","user":{"login":"guerrero","id":3751801,"avatar_url":"https://avatars.githubusercontent.com/u/3751801?v=3","gravatar_id":"","url":"https://api.github.com/users/guerrero","html_url":"https://github.com/guerrero","followers_url":"https://api.github.com/users/guerrero/followers","following_url":"https://api.github.com/users/guerrero/following{/other_user}","gists_url":"https://api.github.com/users/guerrero/gists{/gist_id}","starred_url":"https://api.github.com/users/guerrero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guerrero/subscriptions","organizations_url":"https://api.github.com/users/guerrero/orgs","repos_url":"https://api.github.com/users/guerrero/repos","events_url":"https://api.github.com/users/guerrero/events{/privacy}","received_events_url":"https://api.github.com/users/guerrero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-11-02T11:27:35Z","updated_at":"2016-11-02T18:01:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/caskroom/homebrew-fonts/pulls/906","html_url":"https://github.com/caskroom/homebrew-fonts/pull/906","diff_url":"https://github.com/caskroom/homebrew-fonts/pull/906.diff","patch_url":"https://github.com/caskroom/homebrew-fonts/pull/906.patch"},"body":"This PR solves the issue #445. The following steps has been done for each font:\r\n\r\n- [x] `brew cask audit --download {{cask_file}}` is error-free.\r\n- [x] `brew cask style --fix {{cask_file}}` reports no offenses.\r\n- [x] The commit message includes the cask’s name and version.\r\n- [x] Named the cask according to the [token reference].\r\n- [x] `brew cask install {{cask_file}}` worked successfully.\r\n- [x] `brew cask uninstall {{cask_file}}` worked successfully.\r\n- [x] Checked there are no [open pull requests] for the same cask.\r\n- [x] Checked that the cask was not already refused in [closed issues].\r\n\r\nI've created a [fish script] that creates Casks with both automatization and supervision (for font names and URLs). The scripts test that every created cask can be installed and has the correct style.\r\n\r\nSome Casks has been added with changes in their names:\r\n- `font-fjord.rb` has been added as `font-fjord-one.rb`\r\n- `font-supermercado.rb` has been added as `font-supermercado-one.rb`\r\n\r\nSome Casks reflected in the original issue hasn't been added due that they have some problems or some tasks need to be done before upload them. They are the following:\r\n\r\n- `font-bm-hanna.rb` doesn't exists in the `google/fonts` repo. It seems that now it's called [hanna] but I'm not sure\r\n- `font-cantoraone`, `font-hammersmithone` and `font-headlandone` IMHO should be renamed to `font-cantora-one`, `font-hammersmith-one` and `font-headland-one` respectively\r\n- `font-clara.rb`, `font-miama.rb` and  don't have an url in Google Fonts but they appear in the Google fonts repo\r\n- `font-lao-muang-don.rb`, `font-lao-muang-khong.rb`, `font-lao-sans-pro.rb`, `font-tharlon` and `font-nanum-brush-script.rb` are marked as early access and they don't appear in the Google font catalog, you should navigate to early access fonts to find them.\r\n- `font-moul-pali.rb` seems that should be renamed as `font-moulpali.rb` instead\r\n- `font-nanum-pen.rb` seems that should be renamed as `font-nanum-pen-script.rb` instead and it's marked as an Early Access font (it doesn't appear in the Google fonts website)\r\n- `font-odormeanchey.rb` seems that should be renamed as `font-odor-mean-chey.rb`\r\n- `font-preah-vihear.rb` seems that should be renamed as `font-preahviear.rb`\r\n- `font-sirinstencil.rb` seems that should be renamed as `font-sirin-stencil.rb`\r\n- `font-souliyo-unicode.rb` has different name (`font-souliyo.rb`) and is marked as early access and it doesn't appear in the Google font catalog, you should navigate to early access fonts\r\n\r\nAnd that's all. I don't know which is the correct way to address this tasks (open a different issue, update this PR...) so some advice would be really helpful in order to proceed.\r\n\r\nThanks!\r\n\r\n[token reference]: https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/token_reference.md\r\n[open pull requests]: https://github.com/caskroom/homebrew-fonts/pulls\r\n[closed issues]: https://github.com/caskroom/homebrew-fonts/issues?q=is%3Aissue+is%3Aclosed\r\n[fish script]: https://gist.github.com/guerrero/b6c7fa8e92b54cbff34cda645202ade6\r\n[hanna]: https://github.com/google/fonts/tree/49fbebd3dc75d42fe72c4a3eef6524f8fcc335fd/ofl/hanna"},"comment":{"url":"https://api.github.com/repos/caskroom/homebrew-fonts/issues/comments/257948359","html_url":"https://github.com/caskroom/homebrew-fonts/pull/906#issuecomment-257948359","issue_url":"https://api.github.com/repos/caskroom/homebrew-fonts/issues/906","id":257948359,"user":{"login":"vitorgalvao","id":1699443,"avatar_url":"https://avatars.githubusercontent.com/u/1699443?v=3","gravatar_id":"","url":"https://api.github.com/users/vitorgalvao","html_url":"https://github.com/vitorgalvao","followers_url":"https://api.github.com/users/vitorgalvao/followers","following_url":"https://api.github.com/users/vitorgalvao/following{/other_user}","gists_url":"https://api.github.com/users/vitorgalvao/gists{/gist_id}","starred_url":"https://api.github.com/users/vitorgalvao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitorgalvao/subscriptions","organizations_url":"https://api.github.com/users/vitorgalvao/orgs","repos_url":"https://api.github.com/users/vitorgalvao/repos","events_url":"https://api.github.com/users/vitorgalvao/events{/privacy}","received_events_url":"https://api.github.com/users/vitorgalvao/received_events","type":"User","site_admin":false},"created_at":"2016-11-02T18:01:29Z","updated_at":"2016-11-02T18:01:29Z","body":"> Does it look good to you?\r\n\r\nYes. Thank you for all the work."}}
{"actor":{"display_login":"vitorgalvao"}}