{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/24693","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/24693/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/24693/comments","events_url":"https://api.github.com/repos/docker/docker/issues/24693/events","html_url":"https://github.com/docker/docker/issues/24693","id":165842945,"number":24693,"title":"bug: comment on preceding line in Dockerfile causes subsequent run comments to be ignored","user":{"login":"Dieterbe","id":20774,"avatar_url":"https://avatars.githubusercontent.com/u/20774?v=3","gravatar_id":"","url":"https://api.github.com/users/Dieterbe","html_url":"https://github.com/Dieterbe","followers_url":"https://api.github.com/users/Dieterbe/followers","following_url":"https://api.github.com/users/Dieterbe/following{/other_user}","gists_url":"https://api.github.com/users/Dieterbe/gists{/gist_id}","starred_url":"https://api.github.com/users/Dieterbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dieterbe/subscriptions","organizations_url":"https://api.github.com/users/Dieterbe/orgs","repos_url":"https://api.github.com/users/Dieterbe/repos","events_url":"https://api.github.com/users/Dieterbe/events{/privacy}","received_events_url":"https://api.github.com/users/Dieterbe/received_events","type":"User","site_admin":false},"labels":[{"id":73616520,"url":"https://api.github.com/repos/docker/docker/labels/area/builder","name":"area/builder","color":"fbca04","default":false},{"id":375217742,"url":"https://api.github.com/repos/docker/docker/labels/version/1.11","name":"version/1.11","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-15T17:53:03Z","updated_at":"2016-12-03T01:14:31Z","closed_at":null,"body":"maybe a the same as #20273, though the issue there doesn't seem as severe.\n\n**Output of `docker version`:**\n\n```\ndocker version\nClient:\n Version:      1.11.2\n API version:  1.23\n Go version:   go1.6.2\n Git commit:   b9f10c9\n Built:        Tue Jun 21 00:43:14 2016\n OS/Arch:      linux/amd64\n\nServer:\n Version:      1.11.2\n API version:  1.23\n Go version:   go1.6.2\n Git commit:   b9f10c9\n Built:        Tue Jun 21 00:43:14 2016\n OS/Arch:      linux/amd64\n```\n\n**Output of `docker info`:**\n\n```\nContainers: 11\n Running: 0\n Paused: 0\n Stopped: 11\nImages: 254\nServer Version: 1.11.2\nStorage Driver: devicemapper\n Pool Name: docker-254:0-5513598-pool\n Pool Blocksize: 65.54 kB\n Base Device Size: 10.74 GB\n Backing Filesystem: ext4\n Data file: /dev/loop0\n Metadata file: /dev/loop1\n Data Space Used: 17.35 GB\n Data Space Total: 107.4 GB\n Data Space Available: 69.74 GB\n Metadata Space Used: 20.98 MB\n Metadata Space Total: 2.147 GB\n Metadata Space Available: 2.127 GB\n Udev Sync Supported: true\n Deferred Removal Enabled: false\n Deferred Deletion Enabled: false\n Deferred Deleted Device Count: 0\n Data loop file: /var/lib/docker/devicemapper/devicemapper/data\n WARNING: Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.\n Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata\n Library Version: 1.02.127 (2016-06-17)\nLogging Driver: json-file\nCgroup Driver: cgroupfs\nPlugins: \n Volume: local\n Network: null host bridge\nKernel Version: 4.5.4-1-ARCH\nOperating System: Arch Linux\nOSType: linux\nArchitecture: x86_64\nCPUs: 8\nTotal Memory: 31.33 GiB\nName: dieter-m6800\nID: AMPP:4IZ5:BFKQ:LZVT:IAGF:OCS6:4BMI:RI4W:4EZY:6TK3:ZZJV:CBBX\nDocker Root Dir: /var/lib/docker\nDebug mode (client): false\nDebug mode (server): false\nRegistry: https://index.docker.io/v1/\n```\n\nThe problem is, with the below dockerfile - as the run output below that shows - the line with `RUN go get github.com/tsenart/vegeta` gets parsed as if its part of the previous command, and gets prepended with `#`, so the command is not run.\n\nwhat is expected: run `RUN go get github.com/tsenart/vegeta` as its own run command.\n\n```\nFROM raintank/nodejsgo\n\nENV GOPATH /go\nENV PATH $PATH:/usr/local/go/bin:$GOPATH/bin\n\nRUN apt-get -y install wget vim bc supervisor\nRUN mkdir -p /go/src/github.com/grafana\nRUN cd /go/src/github.com/grafana && \\\n    git clone https://github.com/raintank/grafana-api-golang-client.git && \\\n    cd grafana-api-golang-client && \\\n    git checkout raintank #&& \\\n    #go get github.com/raintank/env-load\n\nRUN go get github.com/tsenart/vegeta\nRUN go get github.com/raintank/inspect/inspect-es\n\nCMD [\"/usr/bin/supervisord\"]\n```\n\n```\ndocker build .\nSending build context to Docker daemon 3.072 kB\nStep 1 : FROM raintank/nodejsgo\n ---> b7aacd1c2f48\nStep 2 : ENV GOPATH /go\n ---> Using cache\n ---> 420832244d3e\nStep 3 : ENV PATH $PATH:/usr/local/go/bin:$GOPATH/bin\n ---> Using cache\n ---> 7c875ee90ed4\nStep 4 : RUN apt-get -y install wget vim bc supervisor\n ---> Using cache\n ---> 18e36c697f9a\nStep 5 : RUN mkdir -p /go/src/github.com/grafana\n ---> Using cache\n ---> c339b442715c\nStep 6 : RUN cd /go/src/github.com/grafana &&   git clone https://github.com/raintank/grafana-api-golang-client.git &&      cd grafana-api-golang-client &&     git checkout raintank #&& RUN go get github.com/tsenart/vegeta\n ---> Using cache\n ---> 2ef4a1c65071\nStep 7 : RUN go get github.com/raintank/inspect/inspect-es\n ---> Using cache\n ---> 9d10cd05695c\nStep 8 : CMD /usr/bin/supervisord\n ---> Running in 68942f5f7bb9\n ---> 1a8760d6fae8\nRemoving intermediate container 68942f5f7bb9\nSuccessfully built 1a8760d6fae8\n```\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/264603496","html_url":"https://github.com/docker/docker/issues/24693#issuecomment-264603496","issue_url":"https://api.github.com/repos/docker/docker/issues/24693","id":264603496,"user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"created_at":"2016-12-03T01:14:31Z","updated_at":"2016-12-03T01:14:31Z","body":"Unfortunately, we had to revert the fix for this, because it was too much of a breaking change, see https://github.com/docker/docker/issues/29005. I'll reopen this issue"}}
{"actor":{"display_login":"thaJeztah"}}