{"action":"created","comment":{"url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/comments/50044234","id":50044234,"diff_hunk":"@@ -280,7 +282,54 @@ describe 'Employment Status', ->\n     assert.equal request('employment_status': 'something unexpected'), null\n     assert.equal request('employment_status': ' '), null\n \n-\n+describe 'Response', ->\n+  \n+  it 'should return success', ->\n+    expected = '''\n+               <?xml version=\"1.0\"?>\n+               <LTACK>\n+                 <ERRSTATUS>\n+                   <ERRNUM>0</ERRNUM>\n+                   <ERRDESCRIPTION>Success</ERRDESCRIPTION>\n+                 </ERRSTATUS>\n+               </LTACK>\n+               '''\n+\n+    for form in formsArray()\n+      do (form) ->\n+        res = form.response(req, outcome: 'success')","path":"spec/common_spec.coffee","position":31,"original_position":31,"commit_id":"ef3fc37bd9dbd490678748f3564e18c7c75be95f","original_commit_id":"ef3fc37bd9dbd490678748f3564e18c7c75be95f","user":{"login":"cgrayson","id":5596,"avatar_url":"https://avatars.githubusercontent.com/u/5596?v=3","gravatar_id":"","url":"https://api.github.com/users/cgrayson","html_url":"https://github.com/cgrayson","followers_url":"https://api.github.com/users/cgrayson/followers","following_url":"https://api.github.com/users/cgrayson/following{/other_user}","gists_url":"https://api.github.com/users/cgrayson/gists{/gist_id}","starred_url":"https://api.github.com/users/cgrayson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgrayson/subscriptions","organizations_url":"https://api.github.com/users/cgrayson/orgs","repos_url":"https://api.github.com/users/cgrayson/repos","events_url":"https://api.github.com/users/cgrayson/events{/privacy}","received_events_url":"https://api.github.com/users/cgrayson/received_events","type":"User","site_admin":false},"body":"This is interesting, but not what I had in mind. Since this is common code, it can just be straight tested as such. That is, not keeping and iterating over an index of all the users of this code, but just testing `common.response()`.","created_at":"2016-01-18T21:09:49Z","updated_at":"2016-01-18T21:09:49Z","html_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/33#discussion_r50044234","pull_request_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/comments/50044234"},"html":{"href":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/33#discussion_r50044234"},"pull_request":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/33","id":56372185,"html_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/33","diff_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/33.diff","patch_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/33.patch","issue_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/33","number":33,"state":"open","locked":false,"title":"Refactor lw","user":{"login":"ros3bud","id":3402403,"avatar_url":"https://avatars.githubusercontent.com/u/3402403?v=3","gravatar_id":"","url":"https://api.github.com/users/ros3bud","html_url":"https://github.com/ros3bud","followers_url":"https://api.github.com/users/ros3bud/followers","following_url":"https://api.github.com/users/ros3bud/following{/other_user}","gists_url":"https://api.github.com/users/ros3bud/gists{/gist_id}","starred_url":"https://api.github.com/users/ros3bud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros3bud/subscriptions","organizations_url":"https://api.github.com/users/ros3bud/orgs","repos_url":"https://api.github.com/users/ros3bud/repos","events_url":"https://api.github.com/users/ros3bud/events{/privacy}","received_events_url":"https://api.github.com/users/ros3bud/received_events","type":"User","site_admin":false},"body":"@cgrayson, these changes reflect the changes we discussed when I created the personal loan integration, to dry up the different modules. Specifically, the code in parse.coffee was moved to common.coffee. I also moved the response testing into the common_spec file. LGTY? ","created_at":"2016-01-18T17:40:56Z","updated_at":"2016-01-18T21:09:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18b660cf3adfd4628f60fb5cdc7575ea29ba2ed1","assignee":{"login":"cgrayson","id":5596,"avatar_url":"https://avatars.githubusercontent.com/u/5596?v=3","gravatar_id":"","url":"https://api.github.com/users/cgrayson","html_url":"https://github.com/cgrayson","followers_url":"https://api.github.com/users/cgrayson/followers","following_url":"https://api.github.com/users/cgrayson/following{/other_user}","gists_url":"https://api.github.com/users/cgrayson/gists{/gist_id}","starred_url":"https://api.github.com/users/cgrayson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgrayson/subscriptions","organizations_url":"https://api.github.com/users/cgrayson/orgs","repos_url":"https://api.github.com/users/cgrayson/repos","events_url":"https://api.github.com/users/cgrayson/events{/privacy}","received_events_url":"https://api.github.com/users/cgrayson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/33/commits","review_comments_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/33/comments","review_comment_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/33/comments","statuses_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/statuses/ef3fc37bd9dbd490678748f3564e18c7c75be95f","head":{"label":"activeprospect:refactor-lw","ref":"refactor-lw","sha":"ef3fc37bd9dbd490678748f3564e18c7c75be95f","user":{"login":"activeprospect","id":245554,"avatar_url":"https://avatars.githubusercontent.com/u/245554?v=3","gravatar_id":"","url":"https://api.github.com/users/activeprospect","html_url":"https://github.com/activeprospect","followers_url":"https://api.github.com/users/activeprospect/followers","following_url":"https://api.github.com/users/activeprospect/following{/other_user}","gists_url":"https://api.github.com/users/activeprospect/gists{/gist_id}","starred_url":"https://api.github.com/users/activeprospect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeprospect/subscriptions","organizations_url":"https://api.github.com/users/activeprospect/orgs","repos_url":"https://api.github.com/users/activeprospect/repos","events_url":"https://api.github.com/users/activeprospect/events{/privacy}","received_events_url":"https://api.github.com/users/activeprospect/received_events","type":"Organization","site_admin":false},"repo":{"id":17524991,"name":"leadconduit-integration-lendingtree","full_name":"activeprospect/leadconduit-integration-lendingtree","owner":{"login":"activeprospect","id":245554,"avatar_url":"https://avatars.githubusercontent.com/u/245554?v=3","gravatar_id":"","url":"https://api.github.com/users/activeprospect","html_url":"https://github.com/activeprospect","followers_url":"https://api.github.com/users/activeprospect/followers","following_url":"https://api.github.com/users/activeprospect/following{/other_user}","gists_url":"https://api.github.com/users/activeprospect/gists{/gist_id}","starred_url":"https://api.github.com/users/activeprospect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeprospect/subscriptions","organizations_url":"https://api.github.com/users/activeprospect/orgs","repos_url":"https://api.github.com/users/activeprospect/repos","events_url":"https://api.github.com/users/activeprospect/events{/privacy}","received_events_url":"https://api.github.com/users/activeprospect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree","description":"LeadConduit Integration with LendingTree","fork":false,"url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree","forks_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/forks","keys_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/teams","hooks_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/hooks","issue_events_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/events{/number}","events_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/events","assignees_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/assignees{/user}","branches_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/branches{/branch}","tags_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/tags","blobs_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/statuses/{sha}","languages_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/languages","stargazers_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/stargazers","contributors_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/contributors","subscribers_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/subscribers","subscription_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/subscription","commits_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/contents/{+path}","compare_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/merges","archive_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/downloads","issues_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues{/number}","pulls_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls{/number}","milestones_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/milestones{/number}","notifications_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/labels{/name}","releases_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/releases{/id}","created_at":"2014-03-07T19:35:30Z","updated_at":"2016-01-11T16:59:45Z","pushed_at":"2016-01-18T17:40:58Z","git_url":"git://github.com/activeprospect/leadconduit-integration-lendingtree.git","ssh_url":"git@github.com:activeprospect/leadconduit-integration-lendingtree.git","clone_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree.git","svn_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree","homepage":null,"size":160,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"activeprospect:master","ref":"master","sha":"f18391cdfe1285e576d37b044722083d48da87b4","user":{"login":"activeprospect","id":245554,"avatar_url":"https://avatars.githubusercontent.com/u/245554?v=3","gravatar_id":"","url":"https://api.github.com/users/activeprospect","html_url":"https://github.com/activeprospect","followers_url":"https://api.github.com/users/activeprospect/followers","following_url":"https://api.github.com/users/activeprospect/following{/other_user}","gists_url":"https://api.github.com/users/activeprospect/gists{/gist_id}","starred_url":"https://api.github.com/users/activeprospect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeprospect/subscriptions","organizations_url":"https://api.github.com/users/activeprospect/orgs","repos_url":"https://api.github.com/users/activeprospect/repos","events_url":"https://api.github.com/users/activeprospect/events{/privacy}","received_events_url":"https://api.github.com/users/activeprospect/received_events","type":"Organization","site_admin":false},"repo":{"id":17524991,"name":"leadconduit-integration-lendingtree","full_name":"activeprospect/leadconduit-integration-lendingtree","owner":{"login":"activeprospect","id":245554,"avatar_url":"https://avatars.githubusercontent.com/u/245554?v=3","gravatar_id":"","url":"https://api.github.com/users/activeprospect","html_url":"https://github.com/activeprospect","followers_url":"https://api.github.com/users/activeprospect/followers","following_url":"https://api.github.com/users/activeprospect/following{/other_user}","gists_url":"https://api.github.com/users/activeprospect/gists{/gist_id}","starred_url":"https://api.github.com/users/activeprospect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeprospect/subscriptions","organizations_url":"https://api.github.com/users/activeprospect/orgs","repos_url":"https://api.github.com/users/activeprospect/repos","events_url":"https://api.github.com/users/activeprospect/events{/privacy}","received_events_url":"https://api.github.com/users/activeprospect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree","description":"LeadConduit Integration with LendingTree","fork":false,"url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree","forks_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/forks","keys_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/teams","hooks_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/hooks","issue_events_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/events{/number}","events_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/events","assignees_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/assignees{/user}","branches_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/branches{/branch}","tags_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/tags","blobs_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/statuses/{sha}","languages_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/languages","stargazers_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/stargazers","contributors_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/contributors","subscribers_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/subscribers","subscription_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/subscription","commits_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/contents/{+path}","compare_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/merges","archive_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/downloads","issues_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues{/number}","pulls_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls{/number}","milestones_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/milestones{/number}","notifications_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/labels{/name}","releases_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/releases{/id}","created_at":"2014-03-07T19:35:30Z","updated_at":"2016-01-11T16:59:45Z","pushed_at":"2016-01-18T17:40:58Z","git_url":"git://github.com/activeprospect/leadconduit-integration-lendingtree.git","ssh_url":"git@github.com:activeprospect/leadconduit-integration-lendingtree.git","clone_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree.git","svn_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree","homepage":null,"size":160,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/33"},"html":{"href":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/33"},"issue":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/33"},"comments":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/statuses/ef3fc37bd9dbd490678748f3564e18c7c75be95f"}}}}