{"action":"closed","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/16466","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/16466/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16466/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/16466/events","html_url":"https://github.com/mantidproject/mantid/issues/16466","id":157199506,"number":16466,"title":"Differences in SofQWNormalisedPolygons between v3.6.1 and current","user":{"login":"mducle","id":14106963,"avatar_url":"https://avatars.githubusercontent.com/u/14106963?v=3","gravatar_id":"","url":"https://api.github.com/users/mducle","html_url":"https://github.com/mducle","followers_url":"https://api.github.com/users/mducle/followers","following_url":"https://api.github.com/users/mducle/following{/other_user}","gists_url":"https://api.github.com/users/mducle/gists{/gist_id}","starred_url":"https://api.github.com/users/mducle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mducle/subscriptions","organizations_url":"https://api.github.com/users/mducle/orgs","repos_url":"https://api.github.com/users/mducle/repos","events_url":"https://api.github.com/users/mducle/events{/privacy}","received_events_url":"https://api.github.com/users/mducle/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Bug","name":"Misc: Bug","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/5","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.7","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/5/labels","id":1106939,"number":5,"title":"Release 3.7","description":"Code Freeze:13-May-2016\r\nBeta Testing: 17-May-2016 to 31-May-2016\r\n","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":1002,"state":"open","created_at":"2015-05-12T15:38:13Z","updated_at":"2016-05-27T15:26:03Z","due_on":"2016-06-05T23:00:00Z","closed_at":null},"comments":4,"created_at":"2016-05-27T12:49:21Z","updated_at":"2016-05-27T15:26:03Z","closed_at":"2016-05-27T15:26:03Z","body":"<!-- TEMPLATE FOR BUG REPORTS -->\r\n\r\n### Expected behavior\r\n\r\nOutput of SofQW3 in version 3.6.1 is the same as at present.\r\n\r\n### Actual behavior\r\n\r\nA slight difference in the generated S(q,w) map as shown by the difference map:\r\n![sofqw_difference](https://cloud.githubusercontent.com/assets/14106963/15604667/82b04b68-23f9-11e6-9e63-c96d8d24c6a2.png)\r\n\r\n### Steps to reproduce the behavior\r\n\r\nAttached is a zip of the necessary nxs files:\r\n[sofqw3_differences_nxs.zip](https://github.com/mantidproject/mantid/files/286473/sofqw3_differences_nxs.zip)\r\n\r\nUse this script:\r\n\r\n```\r\nws1 = Load('/babylon5/Public/duc/mt361/mt361/MgAgSb_300K_Al')\r\nws2 = Load('/babylon5/Public/duc/mt362/mt362/MgAgSb_300K_Al')\r\nwsd = ws2 - ws1\r\ny = wsd.extractY()\r\nid = np.logical_not(np.isnan(y))\r\nprint \"Difference in reduced data = \"+str(np.sum(np.sum(y[id])))\r\n\r\nws1s = Load('/babylon5/Public/duc/mt361/mt361/MgAgSb_300K_Al_SQW')\r\nws2s = Load('/babylon5/Public/duc/mt362/mt362/MgAgSb_300K_Al_SQW')\r\nwsd = ws2s - ws1s\r\ny = wsd.extractY()\r\nid = np.logical_not(np.isnan(y))\r\nprint \"Difference in S(q,w) maps = \"+str(np.sum(np.sum(y[id])))\r\n\r\nws_SQW = SofQWNormalisedPolygon(ws1,[0,0.1,9],'Direct',50); \r\nws_SQW = Transpose('ws_SQW')\r\n\r\nwsd = ws_SQW - ws1s\r\ny = wsd.extractY()\r\nid = np.logical_not(np.isnan(y))\r\nprint \"Difference between loaded S(q,w) map constructed by v3.6.1 and that calculated now = \"+str(np.sum(np.sum(y[id])))\r\n\r\nwsd = ws_SQW - ws2s\r\ny = wsd.extractY()\r\nid = np.logical_not(np.isnan(y))\r\nprint \"Difference between loaded S(q,w) map constructed by v3.6.20160510 and that calculated now = \"+str(np.sum(np.sum(y[id])))\r\n```\r\n\r\nResults obtained:\r\n\r\n```\r\nDifference in reduced data = 0.0\r\nDifference in S(q,w) maps = 1260.65851468\r\nDifference between loaded S(q,w) map constructed by v3.6.1 and that calculated now = 1260.2388751\r\nDifference between loaded S(q,w) map constructed by v3.6.20160510 and that calculated now = -0.419639583842\r\n```\r\n\r\nExpect all differences to be zero or small. Last difference is probably due to rounding errors in the nxs file?\r\n\r\n### Platforms affected\r\n\r\nLinux (isiscompute - RHEL7) and Windows 7. Not checked on other platforms."}}
{"actor":{"display_login":"mducle"}}