{"action":"created","issue":{"url":"https://api.github.com/repos/18F/domain-scan/issues/66","repository_url":"https://api.github.com/repos/18F/domain-scan","labels_url":"https://api.github.com/repos/18F/domain-scan/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/18F/domain-scan/issues/66/comments","events_url":"https://api.github.com/repos/18F/domain-scan/issues/66/events","html_url":"https://github.com/18F/domain-scan/issues/66","id":158154271,"number":66,"title":"Suggestion: Split up the Dockerfile","user":{"login":"afeld","id":86842,"avatar_url":"https://avatars.githubusercontent.com/u/86842?v=3","gravatar_id":"","url":"https://api.github.com/users/afeld","html_url":"https://github.com/afeld","followers_url":"https://api.github.com/users/afeld/followers","following_url":"https://api.github.com/users/afeld/following{/other_user}","gists_url":"https://api.github.com/users/afeld/gists{/gist_id}","starred_url":"https://api.github.com/users/afeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afeld/subscriptions","organizations_url":"https://api.github.com/users/afeld/orgs","repos_url":"https://api.github.com/users/afeld/repos","events_url":"https://api.github.com/users/afeld/events{/privacy}","received_events_url":"https://api.github.com/users/afeld/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-06-02T14:25:39Z","updated_at":"2016-06-02T14:30:43Z","closed_at":null,"body":"Just took a look at the Dockerfile for the first time, and was surprised to see how much is in there. I guess it's because the various tools being used all have different dependencies?\r\n\r\nHaving multiple languages in a single Dockerfile is an antipattern (IMHO), and I think the setup for each scanner could be a lot simpler if you isolated each tool to its own Dockerfile. These could then be run independently, or via a `domain-scan` Dockerfile that calls out to `docker run <scanner>` and then stitches the results together.\r\n\r\nI got this idea from the architecture of [the Code Climate CLI](https://github.com/codeclimate/codeclimate), so you could look there for inspiration if you're interested in pursuing this."},"comment":{"url":"https://api.github.com/repos/18F/domain-scan/issues/comments/223309608","html_url":"https://github.com/18F/domain-scan/issues/66#issuecomment-223309608","issue_url":"https://api.github.com/repos/18F/domain-scan/issues/66","id":223309608,"user":{"login":"afeld","id":86842,"avatar_url":"https://avatars.githubusercontent.com/u/86842?v=3","gravatar_id":"","url":"https://api.github.com/users/afeld","html_url":"https://github.com/afeld","followers_url":"https://api.github.com/users/afeld/followers","following_url":"https://api.github.com/users/afeld/following{/other_user}","gists_url":"https://api.github.com/users/afeld/gists{/gist_id}","starred_url":"https://api.github.com/users/afeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afeld/subscriptions","organizations_url":"https://api.github.com/users/afeld/orgs","repos_url":"https://api.github.com/users/afeld/repos","events_url":"https://api.github.com/users/afeld/events{/privacy}","received_events_url":"https://api.github.com/users/afeld/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T14:30:43Z","updated_at":"2016-06-02T14:30:43Z","body":"Also, reached out to see if the architecture motivation/overview/instructions are written down somewhere:\r\n\r\nhttps://twitter.com/aidanfeldman/status/738376676619505664"}}
{"actor":{"display_login":"afeld"}}