{"action":"created","issue":{"url":"https://api.github.com/repos/c2corg/v6_ui/issues/246","repository_url":"https://api.github.com/repos/c2corg/v6_ui","labels_url":"https://api.github.com/repos/c2corg/v6_ui/issues/246/labels{/name}","comments_url":"https://api.github.com/repos/c2corg/v6_ui/issues/246/comments","events_url":"https://api.github.com/repos/c2corg/v6_ui/issues/246/events","html_url":"https://github.com/c2corg/v6_ui/issues/246","id":143015235,"number":246,"title":"Keep the documentediting controller as generic as possible","user":{"login":"asaunier","id":1192331,"avatar_url":"https://avatars.githubusercontent.com/u/1192331?v=3","gravatar_id":"","url":"https://api.github.com/users/asaunier","html_url":"https://github.com/asaunier","followers_url":"https://api.github.com/users/asaunier/followers","following_url":"https://api.github.com/users/asaunier/following{/other_user}","gists_url":"https://api.github.com/users/asaunier/gists{/gist_id}","starred_url":"https://api.github.com/users/asaunier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaunier/subscriptions","organizations_url":"https://api.github.com/users/asaunier/orgs","repos_url":"https://api.github.com/users/asaunier/repos","events_url":"https://api.github.com/users/asaunier/events{/privacy}","received_events_url":"https://api.github.com/users/asaunier/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/c2corg/v6_ui/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-23T16:45:17Z","updated_at":"2016-04-07T14:04:25Z","closed_at":null,"body":"https://github.com/c2corg/v6_ui/blob/master/c2corg_ui/static/js/documentediting.js contains some document_type specific parts (waypoint_type, date, etc.).\r\n\r\nIt would be better that specific data/parts are added for instance in inheriting controllers (possible?)."},"comment":{"url":"https://api.github.com/repos/c2corg/v6_ui/issues/comments/206922291","html_url":"https://github.com/c2corg/v6_ui/issues/246#issuecomment-206922291","issue_url":"https://api.github.com/repos/c2corg/v6_ui/issues/246","id":206922291,"user":{"login":"asaunier","id":1192331,"avatar_url":"https://avatars.githubusercontent.com/u/1192331?v=3","gravatar_id":"","url":"https://api.github.com/users/asaunier","html_url":"https://github.com/asaunier","followers_url":"https://api.github.com/users/asaunier/followers","following_url":"https://api.github.com/users/asaunier/following{/other_user}","gists_url":"https://api.github.com/users/asaunier/gists{/gist_id}","starred_url":"https://api.github.com/users/asaunier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaunier/subscriptions","organizations_url":"https://api.github.com/users/asaunier/orgs","repos_url":"https://api.github.com/users/asaunier/repos","events_url":"https://api.github.com/users/asaunier/events{/privacy}","received_events_url":"https://api.github.com/users/asaunier/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T14:04:25Z","updated_at":"2016-04-07T14:04:25Z","body":"I feel a bit concerned about the ``DocumentEditingController`` because it seems to me it integrates more and more code that is document_type-specific.\r\n\r\nI think we should have a generic ``DocumentEditingController`` that could be extended into ``OutingEditingController``, ``WaypointEditingController`` if needed.\r\n\r\nWe could define dedicated directives as we do now, since it would not duplicate much code.\r\nOr maybe we can change the directive controller according to some directive attribute?\r\n\r\nWhat do you think?\r\n\r\n"}}