{"action":"created","issue":{"url":"https://api.github.com/repos/KnpLabs/php-github-api/issues/422","repository_url":"https://api.github.com/repos/KnpLabs/php-github-api","labels_url":"https://api.github.com/repos/KnpLabs/php-github-api/issues/422/labels{/name}","comments_url":"https://api.github.com/repos/KnpLabs/php-github-api/issues/422/comments","events_url":"https://api.github.com/repos/KnpLabs/php-github-api/issues/422/events","html_url":"https://github.com/KnpLabs/php-github-api/pull/422","id":168597158,"number":422,"title":"Revert \"Fixed the exceptions\"","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-01T08:52:14Z","updated_at":"2016-08-01T09:37:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/KnpLabs/php-github-api/pulls/422","html_url":"https://github.com/KnpLabs/php-github-api/pull/422","diff_url":"https://github.com/KnpLabs/php-github-api/pull/422.diff","patch_url":"https://github.com/KnpLabs/php-github-api/pull/422.patch"},"body":"Reverts KnpLabs/php-github-api#410. // cc @sagikazarmark\r\n\r\nThe other fix in the underlying http library is better. There are still issues here anyway.\r\n\r\nCloses #420."},"comment":{"url":"https://api.github.com/repos/KnpLabs/php-github-api/issues/comments/236534724","html_url":"https://github.com/KnpLabs/php-github-api/pull/422#issuecomment-236534724","issue_url":"https://api.github.com/repos/KnpLabs/php-github-api/issues/422","id":236534724,"user":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"created_at":"2016-08-01T09:37:53Z","updated_at":"2016-08-01T09:37:53Z","body":"> From a public API point of view, you shouldn't even know the HTTP transport layer is under the hood.\r\n\r\nAgreed. \r\n\r\n> If you want to handle it as part of the HTTP flow, implement the Httplug exception on that one, but I think exceptions in general are definitely not HTTP related ones, rather domain specific.\r\n\r\nYes. We want to handle it as part of the HTTPflow to be able to show more detailed message. I've created a custom plugin for that. \r\nhttps://github.com/KnpLabs/php-github-api/blob/master/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php\r\n\r\n@GrahamCampbell: Make sure to update those exception related to this plugin with the HTTPlug exception interface. "}}
{"actor":{"display_login":"Nyholm"}}