{"action":"created","issue":{"url":"https://api.github.com/repos/spinnaker/kork/issues/62","repository_url":"https://api.github.com/repos/spinnaker/kork","labels_url":"https://api.github.com/repos/spinnaker/kork/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/spinnaker/kork/issues/62/comments","events_url":"https://api.github.com/repos/spinnaker/kork/issues/62/events","html_url":"https://github.com/spinnaker/kork/pull/62","id":184562854,"number":62,"title":"Remove Autowiring and Value in Configurations.","user":{"login":"cfieber","id":301292,"avatar_url":"https://avatars.githubusercontent.com/u/301292?v=3","gravatar_id":"","url":"https://api.github.com/users/cfieber","html_url":"https://github.com/cfieber","followers_url":"https://api.github.com/users/cfieber/followers","following_url":"https://api.github.com/users/cfieber/following{/other_user}","gists_url":"https://api.github.com/users/cfieber/gists{/gist_id}","starred_url":"https://api.github.com/users/cfieber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfieber/subscriptions","organizations_url":"https://api.github.com/users/cfieber/orgs","repos_url":"https://api.github.com/users/cfieber/repos","events_url":"https://api.github.com/users/cfieber/events{/privacy}","received_events_url":"https://api.github.com/users/cfieber/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-21T20:33:37Z","updated_at":"2016-10-21T20:55:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spinnaker/kork/pulls/62","html_url":"https://github.com/spinnaker/kork/pull/62","diff_url":"https://github.com/spinnaker/kork/pull/62.diff","patch_url":"https://github.com/spinnaker/kork/pull/62.patch"},"body":"Step towards working with newer Spring versions that have problems working with `@Value` annotated properties, particularly at the `@Configuration` class level.\r\n\r\nThere are some changes in the lifecycle in Spring 4.3 that manifest in `@Value` annotations not reading from configuration if they have defaults set. This moves all the configuration into `@ConfigurationProperties` beans instead. Additionally it is recommended to keep `@Configuration` classes simple - to that end I've removed `@Autowired` fields in those classes and replaced with adding the appropriate parameter to whatever `@Bean` method was using the autowired value.\r\n\r\nOther noise in this PR: removed a `Precondition` class in favor of the same functionality that is native in java 8 (`Objects.requireNonNull`)"},"comment":{"url":"https://api.github.com/repos/spinnaker/kork/issues/comments/255462907","html_url":"https://github.com/spinnaker/kork/pull/62#issuecomment-255462907","issue_url":"https://api.github.com/repos/spinnaker/kork/issues/62","id":255462907,"user":{"login":"cfieber","id":301292,"avatar_url":"https://avatars.githubusercontent.com/u/301292?v=3","gravatar_id":"","url":"https://api.github.com/users/cfieber","html_url":"https://github.com/cfieber","followers_url":"https://api.github.com/users/cfieber/followers","following_url":"https://api.github.com/users/cfieber/following{/other_user}","gists_url":"https://api.github.com/users/cfieber/gists{/gist_id}","starred_url":"https://api.github.com/users/cfieber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfieber/subscriptions","organizations_url":"https://api.github.com/users/cfieber/orgs","repos_url":"https://api.github.com/users/cfieber/repos","events_url":"https://api.github.com/users/cfieber/events{/privacy}","received_events_url":"https://api.github.com/users/cfieber/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T20:55:26Z","updated_at":"2016-10-21T20:55:26Z","body":"Not super interested in adding lombok to the mix, the config classes are simple enough if a bit boilerplatey"}}
{"actor":{"display_login":"cfieber"}}