{"action":"opened","number":46,"pull_request":{"url":"https://api.github.com/repos/PowerShell/xSQLServer/pulls/46","id":64974297,"html_url":"https://github.com/PowerShell/xSQLServer/pull/46","diff_url":"https://github.com/PowerShell/xSQLServer/pull/46.diff","patch_url":"https://github.com/PowerShell/xSQLServer/pull/46.patch","issue_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/46","number":46,"state":"open","locked":false,"title":"Test-TargetResource failing without explanation","user":{"login":"jpmnteiro","id":2106660,"avatar_url":"https://avatars.githubusercontent.com/u/2106660?v=3","gravatar_id":"","url":"https://api.github.com/users/jpmnteiro","html_url":"https://github.com/jpmnteiro","followers_url":"https://api.github.com/users/jpmnteiro/followers","following_url":"https://api.github.com/users/jpmnteiro/following{/other_user}","gists_url":"https://api.github.com/users/jpmnteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/jpmnteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpmnteiro/subscriptions","organizations_url":"https://api.github.com/users/jpmnteiro/orgs","repos_url":"https://api.github.com/users/jpmnteiro/repos","events_url":"https://api.github.com/users/jpmnteiro/events{/privacy}","received_events_url":"https://api.github.com/users/jpmnteiro/received_events","type":"User","site_admin":false},"body":"Had an issue where the module installed SQL correctly, but when testing after the installation (`Test-TargetResource`), an exception would be thrown.\r\n\r\nThe configuration I'm currently using:\r\n\r\n    xSQLServerSetup InstallSqlServer\r\n    {\r\n        InstanceName = \"SQLExpress\"\r\n        SourcePath = $destinationPath\r\n        SourceFolder = \"\"\r\n        Features= \"SQLEngine,LocalDB\"\r\n        UpdateSource = \"MU\" # set this to windows update, otherwise it will use the default and cause the setup to crash\r\n        SetupCredential = $credential\r\n        DependsOn = \"[WindowsFeature]NetFramework35Core\",\"[WindowsFeature]NetFramework45Core\",\"[File]CopySqlServerInstaller\"\r\n    }\r\n\r\nAfter looking into the module's source code, I noticed the features' check was failing because the testing code expects the features to be in upper-case format.\r\n\r\nFurthermore, `Test-TargetResource` failed without providing an explanation to why (and made even more baffling given that SQL was correctly installed).\r\n\r\nSo I added a bit more logging to `Test-TargetResource` and normalised the feature to upper-case.","created_at":"2016-04-01T16:58:28Z","updated_at":"2016-04-01T16:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"735f759ad90b5827e8c517988c84e27dbfd72abc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/xSQLServer/pulls/46/commits","review_comments_url":"https://api.github.com/repos/PowerShell/xSQLServer/pulls/46/comments","review_comment_url":"https://api.github.com/repos/PowerShell/xSQLServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/46/comments","statuses_url":"https://api.github.com/repos/PowerShell/xSQLServer/statuses/c1b8a7c7a393387a030dfa213ae1b8581342cbc1","head":{"label":"jpmnteiro:dev","ref":"dev","sha":"c1b8a7c7a393387a030dfa213ae1b8581342cbc1","user":{"login":"jpmnteiro","id":2106660,"avatar_url":"https://avatars.githubusercontent.com/u/2106660?v=3","gravatar_id":"","url":"https://api.github.com/users/jpmnteiro","html_url":"https://github.com/jpmnteiro","followers_url":"https://api.github.com/users/jpmnteiro/followers","following_url":"https://api.github.com/users/jpmnteiro/following{/other_user}","gists_url":"https://api.github.com/users/jpmnteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/jpmnteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpmnteiro/subscriptions","organizations_url":"https://api.github.com/users/jpmnteiro/orgs","repos_url":"https://api.github.com/users/jpmnteiro/repos","events_url":"https://api.github.com/users/jpmnteiro/events{/privacy}","received_events_url":"https://api.github.com/users/jpmnteiro/received_events","type":"User","site_admin":false},"repo":{"id":55243971,"name":"xSQLServer","full_name":"jpmnteiro/xSQLServer","owner":{"login":"jpmnteiro","id":2106660,"avatar_url":"https://avatars.githubusercontent.com/u/2106660?v=3","gravatar_id":"","url":"https://api.github.com/users/jpmnteiro","html_url":"https://github.com/jpmnteiro","followers_url":"https://api.github.com/users/jpmnteiro/followers","following_url":"https://api.github.com/users/jpmnteiro/following{/other_user}","gists_url":"https://api.github.com/users/jpmnteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/jpmnteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpmnteiro/subscriptions","organizations_url":"https://api.github.com/users/jpmnteiro/orgs","repos_url":"https://api.github.com/users/jpmnteiro/repos","events_url":"https://api.github.com/users/jpmnteiro/events{/privacy}","received_events_url":"https://api.github.com/users/jpmnteiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpmnteiro/xSQLServer","description":null,"fork":true,"url":"https://api.github.com/repos/jpmnteiro/xSQLServer","forks_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/forks","keys_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/teams","hooks_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/hooks","issue_events_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/issues/events{/number}","events_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/events","assignees_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/assignees{/user}","branches_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/branches{/branch}","tags_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/tags","blobs_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/statuses/{sha}","languages_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/languages","stargazers_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/stargazers","contributors_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/contributors","subscribers_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/subscribers","subscription_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/subscription","commits_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/contents/{+path}","compare_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/merges","archive_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/downloads","issues_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/issues{/number}","pulls_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/pulls{/number}","milestones_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/milestones{/number}","notifications_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/labels{/name}","releases_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/releases{/id}","deployments_url":"https://api.github.com/repos/jpmnteiro/xSQLServer/deployments","created_at":"2016-04-01T15:49:41Z","updated_at":"2016-04-01T15:49:42Z","pushed_at":"2016-04-01T16:51:51Z","git_url":"git://github.com/jpmnteiro/xSQLServer.git","ssh_url":"git@github.com:jpmnteiro/xSQLServer.git","clone_url":"https://github.com/jpmnteiro/xSQLServer.git","svn_url":"https://github.com/jpmnteiro/xSQLServer","homepage":null,"size":174,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"PowerShell:dev","ref":"dev","sha":"aadcac5e55e34d531038dd9c991260e433e7141e","user":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":34022262,"name":"xSQLServer","full_name":"PowerShell/xSQLServer","owner":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/xSQLServer","description":null,"fork":false,"url":"https://api.github.com/repos/PowerShell/xSQLServer","forks_url":"https://api.github.com/repos/PowerShell/xSQLServer/forks","keys_url":"https://api.github.com/repos/PowerShell/xSQLServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/xSQLServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/xSQLServer/teams","hooks_url":"https://api.github.com/repos/PowerShell/xSQLServer/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/xSQLServer/events","assignees_url":"https://api.github.com/repos/PowerShell/xSQLServer/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/xSQLServer/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/xSQLServer/tags","blobs_url":"https://api.github.com/repos/PowerShell/xSQLServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/xSQLServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/xSQLServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/xSQLServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/xSQLServer/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/xSQLServer/languages","stargazers_url":"https://api.github.com/repos/PowerShell/xSQLServer/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/xSQLServer/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/xSQLServer/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/xSQLServer/subscription","commits_url":"https://api.github.com/repos/PowerShell/xSQLServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/xSQLServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/xSQLServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/xSQLServer/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/xSQLServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/xSQLServer/merges","archive_url":"https://api.github.com/repos/PowerShell/xSQLServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/xSQLServer/downloads","issues_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/xSQLServer/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/xSQLServer/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/xSQLServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/xSQLServer/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/xSQLServer/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/xSQLServer/deployments","created_at":"2015-04-15T22:43:08Z","updated_at":"2016-04-01T15:49:40Z","pushed_at":"2016-04-01T16:58:28Z","git_url":"git://github.com/PowerShell/xSQLServer.git","ssh_url":"git@github.com:PowerShell/xSQLServer.git","clone_url":"https://github.com/PowerShell/xSQLServer.git","svn_url":"https://github.com/PowerShell/xSQLServer","homepage":null,"size":198,"stargazers_count":20,"watchers_count":20,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":20,"forks":36,"open_issues":20,"watchers":20,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/xSQLServer/pulls/46"},"html":{"href":"https://github.com/PowerShell/xSQLServer/pull/46"},"issue":{"href":"https://api.github.com/repos/PowerShell/xSQLServer/issues/46"},"comments":{"href":"https://api.github.com/repos/PowerShell/xSQLServer/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/xSQLServer/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/xSQLServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/xSQLServer/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/xSQLServer/statuses/c1b8a7c7a393387a030dfa213ae1b8581342cbc1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":0,"changed_files":1}}