{"action":"created","comment":{"url":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/comments/59984051","id":59984051,"diff_hunk":"@@ -68,47 +69,65 @@ TcpStream.prototype.start = function() {\n     this.socket = null;\n   }\n \n-  if(this.reconnect === true && this.socket === null) {\n-    if(this.__timeout !== null) {\n-      clearTimeout(this.__timeout);\n-    }\n+  if (this.socket !== null) {\n+    debug('Fatal: socket cannot be null at this point. Game over.')","path":"providers/tcp.js","position":77,"original_position":77,"commit_id":"f73c3f62cf47c39746ef8abe6bf4f2ea9473eff9","original_commit_id":"f73c3f62cf47c39746ef8abe6bf4f2ea9473eff9","user":{"login":"tkurki","id":1049678,"avatar_url":"https://avatars.githubusercontent.com/u/1049678?v=3","gravatar_id":"","url":"https://api.github.com/users/tkurki","html_url":"https://github.com/tkurki","followers_url":"https://api.github.com/users/tkurki/followers","following_url":"https://api.github.com/users/tkurki/following{/other_user}","gists_url":"https://api.github.com/users/tkurki/gists{/gist_id}","starred_url":"https://api.github.com/users/tkurki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkurki/subscriptions","organizations_url":"https://api.github.com/users/tkurki/orgs","repos_url":"https://api.github.com/users/tkurki/repos","events_url":"https://api.github.com/users/tkurki/events{/privacy}","received_events_url":"https://api.github.com/users/tkurki/received_events","type":"User","site_admin":false},"body":"Must be null?","created_at":"2016-04-17T13:17:48Z","updated_at":"2016-04-17T13:17:48Z","html_url":"https://github.com/SignalK/signalk-server-node/pull/87#discussion_r59984051","pull_request_url":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/comments/59984051"},"html":{"href":"https://github.com/SignalK/signalk-server-node/pull/87#discussion_r59984051"},"pull_request":{"href":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/87","id":66764263,"html_url":"https://github.com/SignalK/signalk-server-node/pull/87","diff_url":"https://github.com/SignalK/signalk-server-node/pull/87.diff","patch_url":"https://github.com/SignalK/signalk-server-node/pull/87.patch","issue_url":"https://api.github.com/repos/SignalK/signalk-server-node/issues/87","number":87,"state":"open","locked":false,"title":"Various changes to the reconnect strategy of TCP provider","user":{"login":"fabdrol","id":123201,"avatar_url":"https://avatars.githubusercontent.com/u/123201?v=3","gravatar_id":"","url":"https://api.github.com/users/fabdrol","html_url":"https://github.com/fabdrol","followers_url":"https://api.github.com/users/fabdrol/followers","following_url":"https://api.github.com/users/fabdrol/following{/other_user}","gists_url":"https://api.github.com/users/fabdrol/gists{/gist_id}","starred_url":"https://api.github.com/users/fabdrol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabdrol/subscriptions","organizations_url":"https://api.github.com/users/fabdrol/orgs","repos_url":"https://api.github.com/users/fabdrol/repos","events_url":"https://api.github.com/users/fabdrol/events{/privacy}","received_events_url":"https://api.github.com/users/fabdrol/received_events","type":"User","site_admin":false},"body":"This PR fixes #86 ","created_at":"2016-04-17T10:26:09Z","updated_at":"2016-04-17T13:17:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cd417969033641e4e65631713d4e905fa52d01c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/87/commits","review_comments_url":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/87/comments","review_comment_url":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SignalK/signalk-server-node/issues/87/comments","statuses_url":"https://api.github.com/repos/SignalK/signalk-server-node/statuses/f73c3f62cf47c39746ef8abe6bf4f2ea9473eff9","head":{"label":"SignalK:tcp-reconnect-fix","ref":"tcp-reconnect-fix","sha":"f73c3f62cf47c39746ef8abe6bf4f2ea9473eff9","user":{"login":"SignalK","id":7126740,"avatar_url":"https://avatars.githubusercontent.com/u/7126740?v=3","gravatar_id":"","url":"https://api.github.com/users/SignalK","html_url":"https://github.com/SignalK","followers_url":"https://api.github.com/users/SignalK/followers","following_url":"https://api.github.com/users/SignalK/following{/other_user}","gists_url":"https://api.github.com/users/SignalK/gists{/gist_id}","starred_url":"https://api.github.com/users/SignalK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SignalK/subscriptions","organizations_url":"https://api.github.com/users/SignalK/orgs","repos_url":"https://api.github.com/users/SignalK/repos","events_url":"https://api.github.com/users/SignalK/events{/privacy}","received_events_url":"https://api.github.com/users/SignalK/received_events","type":"Organization","site_admin":false},"repo":{"id":21731081,"name":"signalk-server-node","full_name":"SignalK/signalk-server-node","owner":{"login":"SignalK","id":7126740,"avatar_url":"https://avatars.githubusercontent.com/u/7126740?v=3","gravatar_id":"","url":"https://api.github.com/users/SignalK","html_url":"https://github.com/SignalK","followers_url":"https://api.github.com/users/SignalK/followers","following_url":"https://api.github.com/users/SignalK/following{/other_user}","gists_url":"https://api.github.com/users/SignalK/gists{/gist_id}","starred_url":"https://api.github.com/users/SignalK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SignalK/subscriptions","organizations_url":"https://api.github.com/users/SignalK/orgs","repos_url":"https://api.github.com/users/SignalK/repos","events_url":"https://api.github.com/users/SignalK/events{/privacy}","received_events_url":"https://api.github.com/users/SignalK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SignalK/signalk-server-node","description":"An implementation of a [Signal K](http://signalk.github.io) central server for boats.","fork":false,"url":"https://api.github.com/repos/SignalK/signalk-server-node","forks_url":"https://api.github.com/repos/SignalK/signalk-server-node/forks","keys_url":"https://api.github.com/repos/SignalK/signalk-server-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SignalK/signalk-server-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SignalK/signalk-server-node/teams","hooks_url":"https://api.github.com/repos/SignalK/signalk-server-node/hooks","issue_events_url":"https://api.github.com/repos/SignalK/signalk-server-node/issues/events{/number}","events_url":"https://api.github.com/repos/SignalK/signalk-server-node/events","assignees_url":"https://api.github.com/repos/SignalK/signalk-server-node/assignees{/user}","branches_url":"https://api.github.com/repos/SignalK/signalk-server-node/branches{/branch}","tags_url":"https://api.github.com/repos/SignalK/signalk-server-node/tags","blobs_url":"https://api.github.com/repos/SignalK/signalk-server-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SignalK/signalk-server-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SignalK/signalk-server-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/SignalK/signalk-server-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SignalK/signalk-server-node/statuses/{sha}","languages_url":"https://api.github.com/repos/SignalK/signalk-server-node/languages","stargazers_url":"https://api.github.com/repos/SignalK/signalk-server-node/stargazers","contributors_url":"https://api.github.com/repos/SignalK/signalk-server-node/contributors","subscribers_url":"https://api.github.com/repos/SignalK/signalk-server-node/subscribers","subscription_url":"https://api.github.com/repos/SignalK/signalk-server-node/subscription","commits_url":"https://api.github.com/repos/SignalK/signalk-server-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/SignalK/signalk-server-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/SignalK/signalk-server-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/SignalK/signalk-server-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/SignalK/signalk-server-node/contents/{+path}","compare_url":"https://api.github.com/repos/SignalK/signalk-server-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SignalK/signalk-server-node/merges","archive_url":"https://api.github.com/repos/SignalK/signalk-server-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SignalK/signalk-server-node/downloads","issues_url":"https://api.github.com/repos/SignalK/signalk-server-node/issues{/number}","pulls_url":"https://api.github.com/repos/SignalK/signalk-server-node/pulls{/number}","milestones_url":"https://api.github.com/repos/SignalK/signalk-server-node/milestones{/number}","notifications_url":"https://api.github.com/repos/SignalK/signalk-server-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SignalK/signalk-server-node/labels{/name}","releases_url":"https://api.github.com/repos/SignalK/signalk-server-node/releases{/id}","deployments_url":"https://api.github.com/repos/SignalK/signalk-server-node/deployments","created_at":"2014-07-11T09:48:59Z","updated_at":"2016-03-01T20:10:19Z","pushed_at":"2016-04-17T10:26:10Z","git_url":"git://github.com/SignalK/signalk-server-node.git","ssh_url":"git@github.com:SignalK/signalk-server-node.git","clone_url":"https://github.com/SignalK/signalk-server-node.git","svn_url":"https://github.com/SignalK/signalk-server-node","homepage":null,"size":1369,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":12,"forks":13,"open_issues":12,"watchers":18,"default_branch":"master"}},"base":{"label":"SignalK:master","ref":"master","sha":"17a7a0c0e8097a6ad885325238eb827d35d3d8f8","user":{"login":"SignalK","id":7126740,"avatar_url":"https://avatars.githubusercontent.com/u/7126740?v=3","gravatar_id":"","url":"https://api.github.com/users/SignalK","html_url":"https://github.com/SignalK","followers_url":"https://api.github.com/users/SignalK/followers","following_url":"https://api.github.com/users/SignalK/following{/other_user}","gists_url":"https://api.github.com/users/SignalK/gists{/gist_id}","starred_url":"https://api.github.com/users/SignalK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SignalK/subscriptions","organizations_url":"https://api.github.com/users/SignalK/orgs","repos_url":"https://api.github.com/users/SignalK/repos","events_url":"https://api.github.com/users/SignalK/events{/privacy}","received_events_url":"https://api.github.com/users/SignalK/received_events","type":"Organization","site_admin":false},"repo":{"id":21731081,"name":"signalk-server-node","full_name":"SignalK/signalk-server-node","owner":{"login":"SignalK","id":7126740,"avatar_url":"https://avatars.githubusercontent.com/u/7126740?v=3","gravatar_id":"","url":"https://api.github.com/users/SignalK","html_url":"https://github.com/SignalK","followers_url":"https://api.github.com/users/SignalK/followers","following_url":"https://api.github.com/users/SignalK/following{/other_user}","gists_url":"https://api.github.com/users/SignalK/gists{/gist_id}","starred_url":"https://api.github.com/users/SignalK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SignalK/subscriptions","organizations_url":"https://api.github.com/users/SignalK/orgs","repos_url":"https://api.github.com/users/SignalK/repos","events_url":"https://api.github.com/users/SignalK/events{/privacy}","received_events_url":"https://api.github.com/users/SignalK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SignalK/signalk-server-node","description":"An implementation of a [Signal K](http://signalk.github.io) central server for boats.","fork":false,"url":"https://api.github.com/repos/SignalK/signalk-server-node","forks_url":"https://api.github.com/repos/SignalK/signalk-server-node/forks","keys_url":"https://api.github.com/repos/SignalK/signalk-server-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SignalK/signalk-server-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SignalK/signalk-server-node/teams","hooks_url":"https://api.github.com/repos/SignalK/signalk-server-node/hooks","issue_events_url":"https://api.github.com/repos/SignalK/signalk-server-node/issues/events{/number}","events_url":"https://api.github.com/repos/SignalK/signalk-server-node/events","assignees_url":"https://api.github.com/repos/SignalK/signalk-server-node/assignees{/user}","branches_url":"https://api.github.com/repos/SignalK/signalk-server-node/branches{/branch}","tags_url":"https://api.github.com/repos/SignalK/signalk-server-node/tags","blobs_url":"https://api.github.com/repos/SignalK/signalk-server-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SignalK/signalk-server-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SignalK/signalk-server-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/SignalK/signalk-server-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SignalK/signalk-server-node/statuses/{sha}","languages_url":"https://api.github.com/repos/SignalK/signalk-server-node/languages","stargazers_url":"https://api.github.com/repos/SignalK/signalk-server-node/stargazers","contributors_url":"https://api.github.com/repos/SignalK/signalk-server-node/contributors","subscribers_url":"https://api.github.com/repos/SignalK/signalk-server-node/subscribers","subscription_url":"https://api.github.com/repos/SignalK/signalk-server-node/subscription","commits_url":"https://api.github.com/repos/SignalK/signalk-server-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/SignalK/signalk-server-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/SignalK/signalk-server-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/SignalK/signalk-server-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/SignalK/signalk-server-node/contents/{+path}","compare_url":"https://api.github.com/repos/SignalK/signalk-server-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SignalK/signalk-server-node/merges","archive_url":"https://api.github.com/repos/SignalK/signalk-server-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SignalK/signalk-server-node/downloads","issues_url":"https://api.github.com/repos/SignalK/signalk-server-node/issues{/number}","pulls_url":"https://api.github.com/repos/SignalK/signalk-server-node/pulls{/number}","milestones_url":"https://api.github.com/repos/SignalK/signalk-server-node/milestones{/number}","notifications_url":"https://api.github.com/repos/SignalK/signalk-server-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SignalK/signalk-server-node/labels{/name}","releases_url":"https://api.github.com/repos/SignalK/signalk-server-node/releases{/id}","deployments_url":"https://api.github.com/repos/SignalK/signalk-server-node/deployments","created_at":"2014-07-11T09:48:59Z","updated_at":"2016-03-01T20:10:19Z","pushed_at":"2016-04-17T10:26:10Z","git_url":"git://github.com/SignalK/signalk-server-node.git","ssh_url":"git@github.com:SignalK/signalk-server-node.git","clone_url":"https://github.com/SignalK/signalk-server-node.git","svn_url":"https://github.com/SignalK/signalk-server-node","homepage":null,"size":1369,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":12,"forks":13,"open_issues":12,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/87"},"html":{"href":"https://github.com/SignalK/signalk-server-node/pull/87"},"issue":{"href":"https://api.github.com/repos/SignalK/signalk-server-node/issues/87"},"comments":{"href":"https://api.github.com/repos/SignalK/signalk-server-node/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SignalK/signalk-server-node/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/SignalK/signalk-server-node/statuses/f73c3f62cf47c39746ef8abe6bf4f2ea9473eff9"}}}}