{"action":"created","comment":{"url":"https://api.github.com/repos/allegro/ralph/pulls/comments/58020493","id":58020493,"diff_hunk":"@@ -48,16 +48,23 @@ def _cache_key_hash(func, *args, **kwargs):\n     return pickle.dumps((func.__module__, func.__name__, args, kwargs))\n \n \n-def cache(seconds=300, cache_name=DEFAULT_CACHE_ALIAS):\n+def cache(seconds=300, cache_name=DEFAULT_CACHE_ALIAS, skip_first=False):\n     \"\"\"\n     Cache the result of a function call with particular parameters for specified\n     number of seconds.\n+\n+    Args:\n+        * skip_first - set to True if first argument should not be considered","path":"src/ralph/helpers.py","position":11,"original_position":11,"commit_id":"1fde30be09a004b31925db419babbc9d4ce6f0b2","original_commit_id":"1fde30be09a004b31925db419babbc9d4ce6f0b2","user":{"login":"xliiv","id":298994,"avatar_url":"https://avatars.githubusercontent.com/u/298994?v=3","gravatar_id":"","url":"https://api.github.com/users/xliiv","html_url":"https://github.com/xliiv","followers_url":"https://api.github.com/users/xliiv/followers","following_url":"https://api.github.com/users/xliiv/following{/other_user}","gists_url":"https://api.github.com/users/xliiv/gists{/gist_id}","starred_url":"https://api.github.com/users/xliiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xliiv/subscriptions","organizations_url":"https://api.github.com/users/xliiv/orgs","repos_url":"https://api.github.com/users/xliiv/repos","events_url":"https://api.github.com/users/xliiv/events{/privacy}","received_events_url":"https://api.github.com/users/xliiv/received_events","type":"User","site_admin":false},"body":"Is this a big change to make seperate fns, one for skipping self (the new one) and old one?","created_at":"2016-03-31T08:59:51Z","updated_at":"2016-03-31T08:59:51Z","html_url":"https://github.com/allegro/ralph/pull/2332#discussion_r58020493","pull_request_url":"https://api.github.com/repos/allegro/ralph/pulls/2332","_links":{"self":{"href":"https://api.github.com/repos/allegro/ralph/pulls/comments/58020493"},"html":{"href":"https://github.com/allegro/ralph/pull/2332#discussion_r58020493"},"pull_request":{"href":"https://api.github.com/repos/allegro/ralph/pulls/2332"}}},"pull_request":{"url":"https://api.github.com/repos/allegro/ralph/pulls/2332","id":64752528,"html_url":"https://github.com/allegro/ralph/pull/2332","diff_url":"https://github.com/allegro/ralph/pull/2332.diff","patch_url":"https://github.com/allegro/ralph/pull/2332.patch","issue_url":"https://api.github.com/repos/allegro/ralph/issues/2332","number":2332,"state":"open","locked":false,"title":"Added `skip_first` to cache and check if dnsaas integration is enabled in view","user":{"login":"mkurek","id":107437,"avatar_url":"https://avatars.githubusercontent.com/u/107437?v=3","gravatar_id":"","url":"https://api.github.com/users/mkurek","html_url":"https://github.com/mkurek","followers_url":"https://api.github.com/users/mkurek/followers","following_url":"https://api.github.com/users/mkurek/following{/other_user}","gists_url":"https://api.github.com/users/mkurek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkurek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkurek/subscriptions","organizations_url":"https://api.github.com/users/mkurek/orgs","repos_url":"https://api.github.com/users/mkurek/repos","events_url":"https://api.github.com/users/mkurek/events{/privacy}","received_events_url":"https://api.github.com/users/mkurek/received_events","type":"User","site_admin":false},"body":"* Now you could use `skip_first` param in cache decorator - when set to True, first param (usually class instance a.k.a self) will not be used to calculate hash of params\r\n* dnsview not checks if dnsaas integration is enabled","created_at":"2016-03-31T08:31:26Z","updated_at":"2016-03-31T08:59:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0e0ad4499a6f0388009b92b5615a58fa65b5da3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/allegro/ralph/pulls/2332/commits","review_comments_url":"https://api.github.com/repos/allegro/ralph/pulls/2332/comments","review_comment_url":"https://api.github.com/repos/allegro/ralph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allegro/ralph/issues/2332/comments","statuses_url":"https://api.github.com/repos/allegro/ralph/statuses/1fde30be09a004b31925db419babbc9d4ce6f0b2","head":{"label":"mkurek:dns-cache-domains","ref":"dns-cache-domains","sha":"1fde30be09a004b31925db419babbc9d4ce6f0b2","user":{"login":"mkurek","id":107437,"avatar_url":"https://avatars.githubusercontent.com/u/107437?v=3","gravatar_id":"","url":"https://api.github.com/users/mkurek","html_url":"https://github.com/mkurek","followers_url":"https://api.github.com/users/mkurek/followers","following_url":"https://api.github.com/users/mkurek/following{/other_user}","gists_url":"https://api.github.com/users/mkurek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkurek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkurek/subscriptions","organizations_url":"https://api.github.com/users/mkurek/orgs","repos_url":"https://api.github.com/users/mkurek/repos","events_url":"https://api.github.com/users/mkurek/events{/privacy}","received_events_url":"https://api.github.com/users/mkurek/received_events","type":"User","site_admin":false},"repo":{"id":14890200,"name":"ralph","full_name":"mkurek/ralph","owner":{"login":"mkurek","id":107437,"avatar_url":"https://avatars.githubusercontent.com/u/107437?v=3","gravatar_id":"","url":"https://api.github.com/users/mkurek","html_url":"https://github.com/mkurek","followers_url":"https://api.github.com/users/mkurek/followers","following_url":"https://api.github.com/users/mkurek/following{/other_user}","gists_url":"https://api.github.com/users/mkurek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkurek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkurek/subscriptions","organizations_url":"https://api.github.com/users/mkurek/orgs","repos_url":"https://api.github.com/users/mkurek/repos","events_url":"https://api.github.com/users/mkurek/events{/privacy}","received_events_url":"https://api.github.com/users/mkurek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkurek/ralph","description":"Ralph is an asset management system for your data center.","fork":true,"url":"https://api.github.com/repos/mkurek/ralph","forks_url":"https://api.github.com/repos/mkurek/ralph/forks","keys_url":"https://api.github.com/repos/mkurek/ralph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkurek/ralph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkurek/ralph/teams","hooks_url":"https://api.github.com/repos/mkurek/ralph/hooks","issue_events_url":"https://api.github.com/repos/mkurek/ralph/issues/events{/number}","events_url":"https://api.github.com/repos/mkurek/ralph/events","assignees_url":"https://api.github.com/repos/mkurek/ralph/assignees{/user}","branches_url":"https://api.github.com/repos/mkurek/ralph/branches{/branch}","tags_url":"https://api.github.com/repos/mkurek/ralph/tags","blobs_url":"https://api.github.com/repos/mkurek/ralph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkurek/ralph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkurek/ralph/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkurek/ralph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkurek/ralph/statuses/{sha}","languages_url":"https://api.github.com/repos/mkurek/ralph/languages","stargazers_url":"https://api.github.com/repos/mkurek/ralph/stargazers","contributors_url":"https://api.github.com/repos/mkurek/ralph/contributors","subscribers_url":"https://api.github.com/repos/mkurek/ralph/subscribers","subscription_url":"https://api.github.com/repos/mkurek/ralph/subscription","commits_url":"https://api.github.com/repos/mkurek/ralph/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkurek/ralph/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkurek/ralph/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkurek/ralph/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkurek/ralph/contents/{+path}","compare_url":"https://api.github.com/repos/mkurek/ralph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkurek/ralph/merges","archive_url":"https://api.github.com/repos/mkurek/ralph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkurek/ralph/downloads","issues_url":"https://api.github.com/repos/mkurek/ralph/issues{/number}","pulls_url":"https://api.github.com/repos/mkurek/ralph/pulls{/number}","milestones_url":"https://api.github.com/repos/mkurek/ralph/milestones{/number}","notifications_url":"https://api.github.com/repos/mkurek/ralph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkurek/ralph/labels{/name}","releases_url":"https://api.github.com/repos/mkurek/ralph/releases{/id}","deployments_url":"https://api.github.com/repos/mkurek/ralph/deployments","created_at":"2013-12-03T10:22:15Z","updated_at":"2015-02-10T13:25:13Z","pushed_at":"2016-03-31T08:53:52Z","git_url":"git://github.com/mkurek/ralph.git","ssh_url":"git@github.com:mkurek/ralph.git","clone_url":"https://github.com/mkurek/ralph.git","svn_url":"https://github.com/mkurek/ralph","homepage":"http://ralph.allegrogroup.com/","size":30551,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ng"}},"base":{"label":"allegro:feature/dns","ref":"feature/dns","sha":"82489fee25fd9837d3dbde3f24c3d46721959583","user":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"repo":{"id":4359038,"name":"ralph","full_name":"allegro/ralph","owner":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allegro/ralph","description":"Ralph is an asset management system for your data center.","fork":false,"url":"https://api.github.com/repos/allegro/ralph","forks_url":"https://api.github.com/repos/allegro/ralph/forks","keys_url":"https://api.github.com/repos/allegro/ralph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allegro/ralph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allegro/ralph/teams","hooks_url":"https://api.github.com/repos/allegro/ralph/hooks","issue_events_url":"https://api.github.com/repos/allegro/ralph/issues/events{/number}","events_url":"https://api.github.com/repos/allegro/ralph/events","assignees_url":"https://api.github.com/repos/allegro/ralph/assignees{/user}","branches_url":"https://api.github.com/repos/allegro/ralph/branches{/branch}","tags_url":"https://api.github.com/repos/allegro/ralph/tags","blobs_url":"https://api.github.com/repos/allegro/ralph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allegro/ralph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allegro/ralph/git/refs{/sha}","trees_url":"https://api.github.com/repos/allegro/ralph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allegro/ralph/statuses/{sha}","languages_url":"https://api.github.com/repos/allegro/ralph/languages","stargazers_url":"https://api.github.com/repos/allegro/ralph/stargazers","contributors_url":"https://api.github.com/repos/allegro/ralph/contributors","subscribers_url":"https://api.github.com/repos/allegro/ralph/subscribers","subscription_url":"https://api.github.com/repos/allegro/ralph/subscription","commits_url":"https://api.github.com/repos/allegro/ralph/commits{/sha}","git_commits_url":"https://api.github.com/repos/allegro/ralph/git/commits{/sha}","comments_url":"https://api.github.com/repos/allegro/ralph/comments{/number}","issue_comment_url":"https://api.github.com/repos/allegro/ralph/issues/comments{/number}","contents_url":"https://api.github.com/repos/allegro/ralph/contents/{+path}","compare_url":"https://api.github.com/repos/allegro/ralph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allegro/ralph/merges","archive_url":"https://api.github.com/repos/allegro/ralph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allegro/ralph/downloads","issues_url":"https://api.github.com/repos/allegro/ralph/issues{/number}","pulls_url":"https://api.github.com/repos/allegro/ralph/pulls{/number}","milestones_url":"https://api.github.com/repos/allegro/ralph/milestones{/number}","notifications_url":"https://api.github.com/repos/allegro/ralph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allegro/ralph/labels{/name}","releases_url":"https://api.github.com/repos/allegro/ralph/releases{/id}","deployments_url":"https://api.github.com/repos/allegro/ralph/deployments","created_at":"2012-05-17T14:04:57Z","updated_at":"2016-03-31T07:54:48Z","pushed_at":"2016-03-31T08:53:52Z","git_url":"git://github.com/allegro/ralph.git","ssh_url":"git@github.com:allegro/ralph.git","clone_url":"https://github.com/allegro/ralph.git","svn_url":"https://github.com/allegro/ralph","homepage":"http://allegro.tech/ralph/","size":33588,"stargazers_count":393,"watchers_count":393,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":85,"forks":99,"open_issues":85,"watchers":393,"default_branch":"ng"}},"_links":{"self":{"href":"https://api.github.com/repos/allegro/ralph/pulls/2332"},"html":{"href":"https://github.com/allegro/ralph/pull/2332"},"issue":{"href":"https://api.github.com/repos/allegro/ralph/issues/2332"},"comments":{"href":"https://api.github.com/repos/allegro/ralph/issues/2332/comments"},"review_comments":{"href":"https://api.github.com/repos/allegro/ralph/pulls/2332/comments"},"review_comment":{"href":"https://api.github.com/repos/allegro/ralph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allegro/ralph/pulls/2332/commits"},"statuses":{"href":"https://api.github.com/repos/allegro/ralph/statuses/1fde30be09a004b31925db419babbc9d4ce6f0b2"}}}}