{"action":"created","comment":{"url":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments/91348042","pull_request_review_id":11857260,"id":91348042,"diff_hunk":"@@ -55,6 +69,17 @@ protected void dispose(ExposedObject<CacheBinding> exposedObject) {\n   }\n \n   @Override\n+  public final Collection<? extends Descriptor> getDescriptors() {\n+    Collection<StatisticDescriptor> capabilities = new HashSet<StatisticDescriptor>();\n+    for (ExposedObject o : getExposedObjects()) {\n+      capabilities.addAll(((StandardEhcacheStatistics) o).getDescriptors());\n+    }\n+    List<StatisticDescriptor> list = new ArrayList<StatisticDescriptor>(capabilities);\n+    Collections.sort(list, STATISTIC_DESCRIPTOR_COMPARATOR);","path":"management/src/main/java/org/ehcache/management/providers/statistics/EhcacheStatisticsProvider.java","position":44,"original_position":44,"commit_id":"bcdde0aeba755cc4056c21fcd736a20d1dd1f2e9","original_commit_id":"bcdde0aeba755cc4056c21fcd736a20d1dd1f2e9","user":{"login":"mathieucarbou","id":61346,"avatar_url":"https://avatars.githubusercontent.com/u/61346?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieucarbou","html_url":"https://github.com/mathieucarbou","followers_url":"https://api.github.com/users/mathieucarbou/followers","following_url":"https://api.github.com/users/mathieucarbou/following{/other_user}","gists_url":"https://api.github.com/users/mathieucarbou/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieucarbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieucarbou/subscriptions","organizations_url":"https://api.github.com/users/mathieucarbou/orgs","repos_url":"https://api.github.com/users/mathieucarbou/repos","events_url":"https://api.github.com/users/mathieucarbou/events{/privacy}","received_events_url":"https://api.github.com/users/mathieucarbou/received_events","type":"User","site_admin":false},"body":"Yes, should have been! Now... Is it worth loosing another  1h for the new build to pass for this small thing and delaying more the PR for M&M ? :-S","created_at":"2016-12-07T17:51:55Z","updated_at":"2016-12-07T17:51:55Z","html_url":"https://github.com/ehcache/ehcache3/pull/1692#discussion_r91348042","pull_request_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/1692","_links":{"self":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments/91348042"},"html":{"href":"https://github.com/ehcache/ehcache3/pull/1692#discussion_r91348042"},"pull_request":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/1692"}}},"pull_request":{"url":"https://api.github.com/repos/ehcache/ehcache3/pulls/1692","id":96963093,"html_url":"https://github.com/ehcache/ehcache3/pull/1692","diff_url":"https://github.com/ehcache/ehcache3/pull/1692.diff","patch_url":"https://github.com/ehcache/ehcache3/pull/1692.patch","issue_url":"https://api.github.com/repos/ehcache/ehcache3/issues/1692","number":1692,"state":"open","locked":false,"title":"#1684: Disabling Latency statistics","user":{"login":"mathieucarbou","id":61346,"avatar_url":"https://avatars.githubusercontent.com/u/61346?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieucarbou","html_url":"https://github.com/mathieucarbou","followers_url":"https://api.github.com/users/mathieucarbou/followers","following_url":"https://api.github.com/users/mathieucarbou/following{/other_user}","gists_url":"https://api.github.com/users/mathieucarbou/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieucarbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieucarbou/subscriptions","organizations_url":"https://api.github.com/users/mathieucarbou/orgs","repos_url":"https://api.github.com/users/mathieucarbou/repos","events_url":"https://api.github.com/users/mathieucarbou/events{/privacy}","received_events_url":"https://api.github.com/users/mathieucarbou/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-07T16:54:04Z","updated_at":"2016-12-07T17:51:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95344bc0b601d15a3bd8f31a1c37c10f8603a32b","assignee":{"login":"anthonydahanne","id":60938,"avatar_url":"https://avatars.githubusercontent.com/u/60938?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonydahanne","html_url":"https://github.com/anthonydahanne","followers_url":"https://api.github.com/users/anthonydahanne/followers","following_url":"https://api.github.com/users/anthonydahanne/following{/other_user}","gists_url":"https://api.github.com/users/anthonydahanne/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydahanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydahanne/subscriptions","organizations_url":"https://api.github.com/users/anthonydahanne/orgs","repos_url":"https://api.github.com/users/anthonydahanne/repos","events_url":"https://api.github.com/users/anthonydahanne/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydahanne/received_events","type":"User","site_admin":false},"assignees":[{"login":"anthonydahanne","id":60938,"avatar_url":"https://avatars.githubusercontent.com/u/60938?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonydahanne","html_url":"https://github.com/anthonydahanne","followers_url":"https://api.github.com/users/anthonydahanne/followers","following_url":"https://api.github.com/users/anthonydahanne/following{/other_user}","gists_url":"https://api.github.com/users/anthonydahanne/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydahanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydahanne/subscriptions","organizations_url":"https://api.github.com/users/anthonydahanne/orgs","repos_url":"https://api.github.com/users/anthonydahanne/repos","events_url":"https://api.github.com/users/anthonydahanne/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydahanne/received_events","type":"User","site_admin":false},{"login":"gibsong","id":6646921,"avatar_url":"https://avatars.githubusercontent.com/u/6646921?v=3","gravatar_id":"","url":"https://api.github.com/users/gibsong","html_url":"https://github.com/gibsong","followers_url":"https://api.github.com/users/gibsong/followers","following_url":"https://api.github.com/users/gibsong/following{/other_user}","gists_url":"https://api.github.com/users/gibsong/gists{/gist_id}","starred_url":"https://api.github.com/users/gibsong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibsong/subscriptions","organizations_url":"https://api.github.com/users/gibsong/orgs","repos_url":"https://api.github.com/users/gibsong/repos","events_url":"https://api.github.com/users/gibsong/events{/privacy}","received_events_url":"https://api.github.com/users/gibsong/received_events","type":"User","site_admin":false},{"login":"GaryWKeim","id":12566053,"avatar_url":"https://avatars.githubusercontent.com/u/12566053?v=3","gravatar_id":"","url":"https://api.github.com/users/GaryWKeim","html_url":"https://github.com/GaryWKeim","followers_url":"https://api.github.com/users/GaryWKeim/followers","following_url":"https://api.github.com/users/GaryWKeim/following{/other_user}","gists_url":"https://api.github.com/users/GaryWKeim/gists{/gist_id}","starred_url":"https://api.github.com/users/GaryWKeim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaryWKeim/subscriptions","organizations_url":"https://api.github.com/users/GaryWKeim/orgs","repos_url":"https://api.github.com/users/GaryWKeim/repos","events_url":"https://api.github.com/users/GaryWKeim/events{/privacy}","received_events_url":"https://api.github.com/users/GaryWKeim/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/1692/commits","review_comments_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/1692/comments","review_comment_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ehcache/ehcache3/issues/1692/comments","statuses_url":"https://api.github.com/repos/ehcache/ehcache3/statuses/bcdde0aeba755cc4056c21fcd736a20d1dd1f2e9","head":{"label":"mathieucarbou:issue-1684","ref":"issue-1684","sha":"bcdde0aeba755cc4056c21fcd736a20d1dd1f2e9","user":{"login":"mathieucarbou","id":61346,"avatar_url":"https://avatars.githubusercontent.com/u/61346?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieucarbou","html_url":"https://github.com/mathieucarbou","followers_url":"https://api.github.com/users/mathieucarbou/followers","following_url":"https://api.github.com/users/mathieucarbou/following{/other_user}","gists_url":"https://api.github.com/users/mathieucarbou/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieucarbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieucarbou/subscriptions","organizations_url":"https://api.github.com/users/mathieucarbou/orgs","repos_url":"https://api.github.com/users/mathieucarbou/repos","events_url":"https://api.github.com/users/mathieucarbou/events{/privacy}","received_events_url":"https://api.github.com/users/mathieucarbou/received_events","type":"User","site_admin":false},"repo":{"id":39974489,"name":"ehcache3","full_name":"mathieucarbou/ehcache3","owner":{"login":"mathieucarbou","id":61346,"avatar_url":"https://avatars.githubusercontent.com/u/61346?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieucarbou","html_url":"https://github.com/mathieucarbou","followers_url":"https://api.github.com/users/mathieucarbou/followers","following_url":"https://api.github.com/users/mathieucarbou/following{/other_user}","gists_url":"https://api.github.com/users/mathieucarbou/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieucarbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieucarbou/subscriptions","organizations_url":"https://api.github.com/users/mathieucarbou/orgs","repos_url":"https://api.github.com/users/mathieucarbou/repos","events_url":"https://api.github.com/users/mathieucarbou/events{/privacy}","received_events_url":"https://api.github.com/users/mathieucarbou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathieucarbou/ehcache3","description":"Ehcache 3.x line ","fork":true,"url":"https://api.github.com/repos/mathieucarbou/ehcache3","forks_url":"https://api.github.com/repos/mathieucarbou/ehcache3/forks","keys_url":"https://api.github.com/repos/mathieucarbou/ehcache3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathieucarbou/ehcache3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathieucarbou/ehcache3/teams","hooks_url":"https://api.github.com/repos/mathieucarbou/ehcache3/hooks","issue_events_url":"https://api.github.com/repos/mathieucarbou/ehcache3/issues/events{/number}","events_url":"https://api.github.com/repos/mathieucarbou/ehcache3/events","assignees_url":"https://api.github.com/repos/mathieucarbou/ehcache3/assignees{/user}","branches_url":"https://api.github.com/repos/mathieucarbou/ehcache3/branches{/branch}","tags_url":"https://api.github.com/repos/mathieucarbou/ehcache3/tags","blobs_url":"https://api.github.com/repos/mathieucarbou/ehcache3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathieucarbou/ehcache3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathieucarbou/ehcache3/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathieucarbou/ehcache3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathieucarbou/ehcache3/statuses/{sha}","languages_url":"https://api.github.com/repos/mathieucarbou/ehcache3/languages","stargazers_url":"https://api.github.com/repos/mathieucarbou/ehcache3/stargazers","contributors_url":"https://api.github.com/repos/mathieucarbou/ehcache3/contributors","subscribers_url":"https://api.github.com/repos/mathieucarbou/ehcache3/subscribers","subscription_url":"https://api.github.com/repos/mathieucarbou/ehcache3/subscription","commits_url":"https://api.github.com/repos/mathieucarbou/ehcache3/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathieucarbou/ehcache3/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathieucarbou/ehcache3/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathieucarbou/ehcache3/issues/comments{/number}","contents_url":"https://api.github.com/repos/mathieucarbou/ehcache3/contents/{+path}","compare_url":"https://api.github.com/repos/mathieucarbou/ehcache3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathieucarbou/ehcache3/merges","archive_url":"https://api.github.com/repos/mathieucarbou/ehcache3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathieucarbou/ehcache3/downloads","issues_url":"https://api.github.com/repos/mathieucarbou/ehcache3/issues{/number}","pulls_url":"https://api.github.com/repos/mathieucarbou/ehcache3/pulls{/number}","milestones_url":"https://api.github.com/repos/mathieucarbou/ehcache3/milestones{/number}","notifications_url":"https://api.github.com/repos/mathieucarbou/ehcache3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathieucarbou/ehcache3/labels{/name}","releases_url":"https://api.github.com/repos/mathieucarbou/ehcache3/releases{/id}","deployments_url":"https://api.github.com/repos/mathieucarbou/ehcache3/deployments","created_at":"2015-07-30T22:05:13Z","updated_at":"2016-01-25T20:46:35Z","pushed_at":"2016-12-07T14:45:02Z","git_url":"git://github.com/mathieucarbou/ehcache3.git","ssh_url":"git@github.com:mathieucarbou/ehcache3.git","clone_url":"https://github.com/mathieucarbou/ehcache3.git","svn_url":"https://github.com/mathieucarbou/ehcache3","homepage":"ehcache.org","size":12820,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ehcache:master","ref":"master","sha":"59605e087c4f038f030b5079dd8e3d3d1adf09b1","user":{"login":"ehcache","id":5504982,"avatar_url":"https://avatars.githubusercontent.com/u/5504982?v=3","gravatar_id":"","url":"https://api.github.com/users/ehcache","html_url":"https://github.com/ehcache","followers_url":"https://api.github.com/users/ehcache/followers","following_url":"https://api.github.com/users/ehcache/following{/other_user}","gists_url":"https://api.github.com/users/ehcache/gists{/gist_id}","starred_url":"https://api.github.com/users/ehcache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehcache/subscriptions","organizations_url":"https://api.github.com/users/ehcache/orgs","repos_url":"https://api.github.com/users/ehcache/repos","events_url":"https://api.github.com/users/ehcache/events{/privacy}","received_events_url":"https://api.github.com/users/ehcache/received_events","type":"Organization","site_admin":false},"repo":{"id":17224514,"name":"ehcache3","full_name":"ehcache/ehcache3","owner":{"login":"ehcache","id":5504982,"avatar_url":"https://avatars.githubusercontent.com/u/5504982?v=3","gravatar_id":"","url":"https://api.github.com/users/ehcache","html_url":"https://github.com/ehcache","followers_url":"https://api.github.com/users/ehcache/followers","following_url":"https://api.github.com/users/ehcache/following{/other_user}","gists_url":"https://api.github.com/users/ehcache/gists{/gist_id}","starred_url":"https://api.github.com/users/ehcache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehcache/subscriptions","organizations_url":"https://api.github.com/users/ehcache/orgs","repos_url":"https://api.github.com/users/ehcache/repos","events_url":"https://api.github.com/users/ehcache/events{/privacy}","received_events_url":"https://api.github.com/users/ehcache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ehcache/ehcache3","description":"Ehcache 3.x line ","fork":false,"url":"https://api.github.com/repos/ehcache/ehcache3","forks_url":"https://api.github.com/repos/ehcache/ehcache3/forks","keys_url":"https://api.github.com/repos/ehcache/ehcache3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehcache/ehcache3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehcache/ehcache3/teams","hooks_url":"https://api.github.com/repos/ehcache/ehcache3/hooks","issue_events_url":"https://api.github.com/repos/ehcache/ehcache3/issues/events{/number}","events_url":"https://api.github.com/repos/ehcache/ehcache3/events","assignees_url":"https://api.github.com/repos/ehcache/ehcache3/assignees{/user}","branches_url":"https://api.github.com/repos/ehcache/ehcache3/branches{/branch}","tags_url":"https://api.github.com/repos/ehcache/ehcache3/tags","blobs_url":"https://api.github.com/repos/ehcache/ehcache3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehcache/ehcache3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehcache/ehcache3/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehcache/ehcache3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehcache/ehcache3/statuses/{sha}","languages_url":"https://api.github.com/repos/ehcache/ehcache3/languages","stargazers_url":"https://api.github.com/repos/ehcache/ehcache3/stargazers","contributors_url":"https://api.github.com/repos/ehcache/ehcache3/contributors","subscribers_url":"https://api.github.com/repos/ehcache/ehcache3/subscribers","subscription_url":"https://api.github.com/repos/ehcache/ehcache3/subscription","commits_url":"https://api.github.com/repos/ehcache/ehcache3/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehcache/ehcache3/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehcache/ehcache3/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehcache/ehcache3/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehcache/ehcache3/contents/{+path}","compare_url":"https://api.github.com/repos/ehcache/ehcache3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehcache/ehcache3/merges","archive_url":"https://api.github.com/repos/ehcache/ehcache3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehcache/ehcache3/downloads","issues_url":"https://api.github.com/repos/ehcache/ehcache3/issues{/number}","pulls_url":"https://api.github.com/repos/ehcache/ehcache3/pulls{/number}","milestones_url":"https://api.github.com/repos/ehcache/ehcache3/milestones{/number}","notifications_url":"https://api.github.com/repos/ehcache/ehcache3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehcache/ehcache3/labels{/name}","releases_url":"https://api.github.com/repos/ehcache/ehcache3/releases{/id}","deployments_url":"https://api.github.com/repos/ehcache/ehcache3/deployments","created_at":"2014-02-26T20:39:16Z","updated_at":"2016-12-07T07:51:24Z","pushed_at":"2016-12-07T16:54:04Z","git_url":"git://github.com/ehcache/ehcache3.git","ssh_url":"git@github.com:ehcache/ehcache3.git","clone_url":"https://github.com/ehcache/ehcache3.git","svn_url":"https://github.com/ehcache/ehcache3","homepage":"http://www.ehcache.org","size":15424,"stargazers_count":566,"watchers_count":566,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":278,"mirror_url":null,"open_issues_count":94,"forks":278,"open_issues":94,"watchers":566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/1692"},"html":{"href":"https://github.com/ehcache/ehcache3/pull/1692"},"issue":{"href":"https://api.github.com/repos/ehcache/ehcache3/issues/1692"},"comments":{"href":"https://api.github.com/repos/ehcache/ehcache3/issues/1692/comments"},"review_comments":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/1692/comments"},"review_comment":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/1692/commits"},"statuses":{"href":"https://api.github.com/repos/ehcache/ehcache3/statuses/bcdde0aeba755cc4056c21fcd736a20d1dd1f2e9"}}}}
{"actor":{"display_login":"mathieucarbou"}}