{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/88723975","pull_request_review_id":9291435,"id":88723975,"diff_hunk":"@@ -4,5 +4,51 @@ class ServiceTemplatesController < BaseController\n     include Subcollections::Tags\n     include Subcollections::ResourceActions\n     include Subcollections::ServiceRequests\n+\n+    def create_resource(_type, _id, data)\n+      # Temporarily only supporting atomic.\n+      raise 'Service Type composite not supported' if data['service_type'] == 'composite'\n+      create_atomic(data).tap(&:save!)\n+    rescue => err\n+      raise BadRequestError, \"Could not create Service Template - #{err}\"\n+    end\n+\n+    private\n+\n+    def create_atomic(data)\n+      service_template = ServiceTemplate.new(data.except('request_info'))\n+      if data.key?('request_info')\n+        service_template.add_resource(create_service_template_request(data['request_info']))","path":"app/controllers/api/service_templates_controller.rb","position":18,"original_position":18,"commit_id":"928ad4d31da7c2d07182ae6b8cea68b7ce94a08b","original_commit_id":"928ad4d31da7c2d07182ae6b8cea68b7ce94a08b","user":{"login":"jntullo","id":2433314,"avatar_url":"https://avatars.githubusercontent.com/u/2433314?v=3","gravatar_id":"","url":"https://api.github.com/users/jntullo","html_url":"https://github.com/jntullo","followers_url":"https://api.github.com/users/jntullo/followers","following_url":"https://api.github.com/users/jntullo/following{/other_user}","gists_url":"https://api.github.com/users/jntullo/gists{/gist_id}","starred_url":"https://api.github.com/users/jntullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jntullo/subscriptions","organizations_url":"https://api.github.com/users/jntullo/orgs","repos_url":"https://api.github.com/users/jntullo/repos","events_url":"https://api.github.com/users/jntullo/events{/privacy}","received_events_url":"https://api.github.com/users/jntullo/received_events","type":"User","site_admin":false},"body":"@bzwei exactly why I wanted this feedback 😃  is there a place in the code already doing this where I can follow along make it work for the REST api? Didn't quite see it in the existing controller...","created_at":"2016-11-18T19:33:51Z","updated_at":"2016-11-18T19:33:52Z","html_url":"https://github.com/ManageIQ/manageiq/pull/12594#discussion_r88723975","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12594","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/88723975"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/12594#discussion_r88723975"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12594"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12594","id":93387463,"html_url":"https://github.com/ManageIQ/manageiq/pull/12594","diff_url":"https://github.com/ManageIQ/manageiq/pull/12594.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/12594.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12594","number":12594,"state":"open","locked":false,"title":"create service template REST api","user":{"login":"jntullo","id":2433314,"avatar_url":"https://avatars.githubusercontent.com/u/2433314?v=3","gravatar_id":"","url":"https://api.github.com/users/jntullo","html_url":"https://github.com/jntullo","followers_url":"https://api.github.com/users/jntullo/followers","following_url":"https://api.github.com/users/jntullo/following{/other_user}","gists_url":"https://api.github.com/users/jntullo/gists{/gist_id}","starred_url":"https://api.github.com/users/jntullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jntullo/subscriptions","organizations_url":"https://api.github.com/users/jntullo/orgs","repos_url":"https://api.github.com/users/jntullo/repos","events_url":"https://api.github.com/users/jntullo/events{/privacy}","received_events_url":"https://api.github.com/users/jntullo/received_events","type":"User","site_admin":false},"body":"create service template REST api for use in the SUI - only doing atomic initially. Will follow up with composite.\r\n\r\n@miq-bot add_label api, enhancement, wip, euwe/no\r\n@miq-bot assign @abellotti ","created_at":"2016-11-11T19:50:31Z","updated_at":"2016-11-18T19:33:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca69eaf8b61928f8b4835b57ff6aad642fdf6df8","assignee":{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false},"assignees":[{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12594/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12594/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12594/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/928ad4d31da7c2d07182ae6b8cea68b7ce94a08b","head":{"label":"jntullo:create_catalog_item","ref":"create_catalog_item","sha":"928ad4d31da7c2d07182ae6b8cea68b7ce94a08b","user":{"login":"jntullo","id":2433314,"avatar_url":"https://avatars.githubusercontent.com/u/2433314?v=3","gravatar_id":"","url":"https://api.github.com/users/jntullo","html_url":"https://github.com/jntullo","followers_url":"https://api.github.com/users/jntullo/followers","following_url":"https://api.github.com/users/jntullo/following{/other_user}","gists_url":"https://api.github.com/users/jntullo/gists{/gist_id}","starred_url":"https://api.github.com/users/jntullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jntullo/subscriptions","organizations_url":"https://api.github.com/users/jntullo/orgs","repos_url":"https://api.github.com/users/jntullo/repos","events_url":"https://api.github.com/users/jntullo/events{/privacy}","received_events_url":"https://api.github.com/users/jntullo/received_events","type":"User","site_admin":false},"repo":{"id":60654025,"name":"manageiq","full_name":"jntullo/manageiq","owner":{"login":"jntullo","id":2433314,"avatar_url":"https://avatars.githubusercontent.com/u/2433314?v=3","gravatar_id":"","url":"https://api.github.com/users/jntullo","html_url":"https://github.com/jntullo","followers_url":"https://api.github.com/users/jntullo/followers","following_url":"https://api.github.com/users/jntullo/following{/other_user}","gists_url":"https://api.github.com/users/jntullo/gists{/gist_id}","starred_url":"https://api.github.com/users/jntullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jntullo/subscriptions","organizations_url":"https://api.github.com/users/jntullo/orgs","repos_url":"https://api.github.com/users/jntullo/repos","events_url":"https://api.github.com/users/jntullo/events{/privacy}","received_events_url":"https://api.github.com/users/jntullo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jntullo/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/jntullo/manageiq","forks_url":"https://api.github.com/repos/jntullo/manageiq/forks","keys_url":"https://api.github.com/repos/jntullo/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jntullo/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jntullo/manageiq/teams","hooks_url":"https://api.github.com/repos/jntullo/manageiq/hooks","issue_events_url":"https://api.github.com/repos/jntullo/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/jntullo/manageiq/events","assignees_url":"https://api.github.com/repos/jntullo/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/jntullo/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/jntullo/manageiq/tags","blobs_url":"https://api.github.com/repos/jntullo/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jntullo/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jntullo/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jntullo/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jntullo/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/jntullo/manageiq/languages","stargazers_url":"https://api.github.com/repos/jntullo/manageiq/stargazers","contributors_url":"https://api.github.com/repos/jntullo/manageiq/contributors","subscribers_url":"https://api.github.com/repos/jntullo/manageiq/subscribers","subscription_url":"https://api.github.com/repos/jntullo/manageiq/subscription","commits_url":"https://api.github.com/repos/jntullo/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jntullo/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jntullo/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jntullo/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/jntullo/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/jntullo/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jntullo/manageiq/merges","archive_url":"https://api.github.com/repos/jntullo/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jntullo/manageiq/downloads","issues_url":"https://api.github.com/repos/jntullo/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/jntullo/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/jntullo/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/jntullo/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jntullo/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/jntullo/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/jntullo/manageiq/deployments","created_at":"2016-06-07T23:41:12Z","updated_at":"2016-06-07T23:41:33Z","pushed_at":"2016-11-18T18:02:13Z","git_url":"git://github.com/jntullo/manageiq.git","ssh_url":"git@github.com:jntullo/manageiq.git","clone_url":"https://github.com/jntullo/manageiq.git","svn_url":"https://github.com/jntullo/manageiq","homepage":"manageiq.org","size":178820,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"d00b5f28e60534b4632db71a82520837490e8f1f","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-11-17T01:31:00Z","pushed_at":"2016-11-18T19:28:02Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":224992,"stargazers_count":352,"watchers_count":352,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":380,"mirror_url":null,"open_issues_count":921,"forks":380,"open_issues":921,"watchers":352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12594"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/12594"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/12594"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/12594/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12594/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12594/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/928ad4d31da7c2d07182ae6b8cea68b7ce94a08b"}}}}
{"actor":{"display_login":"jntullo"}}