{"action":"created","issue":{"url":"https://api.github.com/repos/omkarmoghe/Pokemap/issues/26","repository_url":"https://api.github.com/repos/omkarmoghe/Pokemap","labels_url":"https://api.github.com/repos/omkarmoghe/Pokemap/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/omkarmoghe/Pokemap/issues/26/comments","events_url":"https://api.github.com/repos/omkarmoghe/Pokemap/issues/26/events","html_url":"https://github.com/omkarmoghe/Pokemap/pull/26","id":166785063,"number":26,"title":"Added S2 geometry library and a couple of libs","user":{"login":"fess89","id":659941,"avatar_url":"https://avatars.githubusercontent.com/u/659941?v=3","gravatar_id":"","url":"https://api.github.com/users/fess89","html_url":"https://github.com/fess89","followers_url":"https://api.github.com/users/fess89/followers","following_url":"https://api.github.com/users/fess89/following{/other_user}","gists_url":"https://api.github.com/users/fess89/gists{/gist_id}","starred_url":"https://api.github.com/users/fess89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fess89/subscriptions","organizations_url":"https://api.github.com/users/fess89/orgs","repos_url":"https://api.github.com/users/fess89/repos","events_url":"https://api.github.com/users/fess89/events{/privacy}","received_events_url":"https://api.github.com/users/fess89/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-21T10:16:56Z","updated_at":"2016-07-22T00:56:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/omkarmoghe/Pokemap/pulls/26","html_url":"https://github.com/omkarmoghe/Pokemap/pull/26","diff_url":"https://github.com/omkarmoghe/Pokemap/pull/26.diff","patch_url":"https://github.com/omkarmoghe/Pokemap/pull/26.patch"},"body":"This PR includes a number of things:\r\n- the s2-geometry-java library from Google, which is essential to work with location data when finding the pokemons\r\n- Dagger2 which would be useful in future to inject dependencies when the project grows\r\n- Android Annotations, which are not used now but would also be helpful\r\n- RxJava + Retrolambda + Nucleus. The point of this is that I would like to use RxJava Observables to avoid callback hell (as seen now in NianticManager) and also to implement the MVP pattern, which would make things much easier to maintain later on. It may seem a bit overkill as the project is in its early stage, but I guess it would be really helpful later\r\n- a bunch of gradle options like minifyEnabled and a new Proguard config\r\n\r\nTo compile this, you would need JDK 8 (and I guess Android Studio 2.2 Preview, which I am using).\r\n\r\nThis is my first pull request on Github, so feel free to criticize this and to ask for changes."},"comment":{"url":"https://api.github.com/repos/omkarmoghe/Pokemap/issues/comments/234427070","html_url":"https://github.com/omkarmoghe/Pokemap/pull/26#issuecomment-234427070","issue_url":"https://api.github.com/repos/omkarmoghe/Pokemap/issues/26","id":234427070,"user":{"login":"omkarmoghe","id":4580292,"avatar_url":"https://avatars.githubusercontent.com/u/4580292?v=3","gravatar_id":"","url":"https://api.github.com/users/omkarmoghe","html_url":"https://github.com/omkarmoghe","followers_url":"https://api.github.com/users/omkarmoghe/followers","following_url":"https://api.github.com/users/omkarmoghe/following{/other_user}","gists_url":"https://api.github.com/users/omkarmoghe/gists{/gist_id}","starred_url":"https://api.github.com/users/omkarmoghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkarmoghe/subscriptions","organizations_url":"https://api.github.com/users/omkarmoghe/orgs","repos_url":"https://api.github.com/users/omkarmoghe/repos","events_url":"https://api.github.com/users/omkarmoghe/events{/privacy}","received_events_url":"https://api.github.com/users/omkarmoghe/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T00:56:02Z","updated_at":"2016-07-22T00:56:02Z","body":"@WaylonBrown @s7092910 Yo good feedback, thanks for the thoughts. Ill keep this open so people can discuss this more. I'm leaning towards the YAGNI mindset especially since more dependencies and libraries are going to make this harder to collaborate on.... Idk though, would love to hear both sides of the argument."}}
{"actor":{"display_login":"omkarmoghe"}}