{"action":"closed","number":172,"pull_request":{"url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/172","id":76613727,"html_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/172","diff_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/172.diff","patch_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/172.patch","issue_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/172","number":172,"state":"closed","locked":false,"title":"SimpleHit3D encapsulation and HoughTransform Cleanup","user":{"login":"mccumbermike","id":12105552,"avatar_url":"https://avatars.githubusercontent.com/u/12105552?v=3","gravatar_id":"","url":"https://api.github.com/users/mccumbermike","html_url":"https://github.com/mccumbermike","followers_url":"https://api.github.com/users/mccumbermike/followers","following_url":"https://api.github.com/users/mccumbermike/following{/other_user}","gists_url":"https://api.github.com/users/mccumbermike/gists{/gist_id}","starred_url":"https://api.github.com/users/mccumbermike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccumbermike/subscriptions","organizations_url":"https://api.github.com/users/mccumbermike/orgs","repos_url":"https://api.github.com/users/mccumbermike/repos","events_url":"https://api.github.com/users/mccumbermike/events{/privacy}","received_events_url":"https://api.github.com/users/mccumbermike/received_events","type":"User","site_admin":false},"body":"I'm starting a sequence of revisions on the cluster error handling for the tracking system. This one is a refactor to encapsulate the cluster errors and start introducing the covariance at a deeper level. My goal is to take more control of what errors are reported to the pattern reco and fitter. Here is the MAPS performance check:\r\n![crosscheck_maps](https://cloud.githubusercontent.com/assets/12105552/16658301/1d1b0780-4423-11e6-824f-05e82ec71694.png)\r\nand the MAPS+TPC performance check:\r\n![crosscheck_tpc](https://cloud.githubusercontent.com/assets/12105552/16658309/24de8c94-4423-11e6-95f8-ebe24302d534.png)\r\nboth for embedded pions in central hijing. In order to fully replicate Alan's result I've omitted the thickness entry from my covariance for the time being. But I want to separate structural changing pull requests like this one from performance changing pull requests as much as I can.","created_at":"2016-07-07T15:18:05Z","updated_at":"2016-07-12T17:40:26Z","closed_at":"2016-07-12T17:40:26Z","merged_at":"2016-07-12T17:40:26Z","merge_commit_sha":"bc78b91f1eea7c8e9f3bb4dca40c726135242ad7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/172/commits","review_comments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/172/comments","review_comment_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/172/comments","statuses_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/statuses/e32b626b489579e68740bc628b6f0d3e431bed02","head":{"label":"mccumbermike:cluster_errors","ref":"cluster_errors","sha":"e32b626b489579e68740bc628b6f0d3e431bed02","user":{"login":"mccumbermike","id":12105552,"avatar_url":"https://avatars.githubusercontent.com/u/12105552?v=3","gravatar_id":"","url":"https://api.github.com/users/mccumbermike","html_url":"https://github.com/mccumbermike","followers_url":"https://api.github.com/users/mccumbermike/followers","following_url":"https://api.github.com/users/mccumbermike/following{/other_user}","gists_url":"https://api.github.com/users/mccumbermike/gists{/gist_id}","starred_url":"https://api.github.com/users/mccumbermike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccumbermike/subscriptions","organizations_url":"https://api.github.com/users/mccumbermike/orgs","repos_url":"https://api.github.com/users/mccumbermike/repos","events_url":"https://api.github.com/users/mccumbermike/events{/privacy}","received_events_url":"https://api.github.com/users/mccumbermike/received_events","type":"User","site_admin":false},"repo":{"id":41013413,"name":"coresoftware","full_name":"mccumbermike/coresoftware","owner":{"login":"mccumbermike","id":12105552,"avatar_url":"https://avatars.githubusercontent.com/u/12105552?v=3","gravatar_id":"","url":"https://api.github.com/users/mccumbermike","html_url":"https://github.com/mccumbermike","followers_url":"https://api.github.com/users/mccumbermike/followers","following_url":"https://api.github.com/users/mccumbermike/following{/other_user}","gists_url":"https://api.github.com/users/mccumbermike/gists{/gist_id}","starred_url":"https://api.github.com/users/mccumbermike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccumbermike/subscriptions","organizations_url":"https://api.github.com/users/mccumbermike/orgs","repos_url":"https://api.github.com/users/mccumbermike/repos","events_url":"https://api.github.com/users/mccumbermike/events{/privacy}","received_events_url":"https://api.github.com/users/mccumbermike/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mccumbermike/coresoftware","description":"Our big core software repository","fork":true,"url":"https://api.github.com/repos/mccumbermike/coresoftware","forks_url":"https://api.github.com/repos/mccumbermike/coresoftware/forks","keys_url":"https://api.github.com/repos/mccumbermike/coresoftware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mccumbermike/coresoftware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mccumbermike/coresoftware/teams","hooks_url":"https://api.github.com/repos/mccumbermike/coresoftware/hooks","issue_events_url":"https://api.github.com/repos/mccumbermike/coresoftware/issues/events{/number}","events_url":"https://api.github.com/repos/mccumbermike/coresoftware/events","assignees_url":"https://api.github.com/repos/mccumbermike/coresoftware/assignees{/user}","branches_url":"https://api.github.com/repos/mccumbermike/coresoftware/branches{/branch}","tags_url":"https://api.github.com/repos/mccumbermike/coresoftware/tags","blobs_url":"https://api.github.com/repos/mccumbermike/coresoftware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mccumbermike/coresoftware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mccumbermike/coresoftware/git/refs{/sha}","trees_url":"https://api.github.com/repos/mccumbermike/coresoftware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mccumbermike/coresoftware/statuses/{sha}","languages_url":"https://api.github.com/repos/mccumbermike/coresoftware/languages","stargazers_url":"https://api.github.com/repos/mccumbermike/coresoftware/stargazers","contributors_url":"https://api.github.com/repos/mccumbermike/coresoftware/contributors","subscribers_url":"https://api.github.com/repos/mccumbermike/coresoftware/subscribers","subscription_url":"https://api.github.com/repos/mccumbermike/coresoftware/subscription","commits_url":"https://api.github.com/repos/mccumbermike/coresoftware/commits{/sha}","git_commits_url":"https://api.github.com/repos/mccumbermike/coresoftware/git/commits{/sha}","comments_url":"https://api.github.com/repos/mccumbermike/coresoftware/comments{/number}","issue_comment_url":"https://api.github.com/repos/mccumbermike/coresoftware/issues/comments{/number}","contents_url":"https://api.github.com/repos/mccumbermike/coresoftware/contents/{+path}","compare_url":"https://api.github.com/repos/mccumbermike/coresoftware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mccumbermike/coresoftware/merges","archive_url":"https://api.github.com/repos/mccumbermike/coresoftware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mccumbermike/coresoftware/downloads","issues_url":"https://api.github.com/repos/mccumbermike/coresoftware/issues{/number}","pulls_url":"https://api.github.com/repos/mccumbermike/coresoftware/pulls{/number}","milestones_url":"https://api.github.com/repos/mccumbermike/coresoftware/milestones{/number}","notifications_url":"https://api.github.com/repos/mccumbermike/coresoftware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mccumbermike/coresoftware/labels{/name}","releases_url":"https://api.github.com/repos/mccumbermike/coresoftware/releases{/id}","deployments_url":"https://api.github.com/repos/mccumbermike/coresoftware/deployments","created_at":"2015-08-19T04:33:04Z","updated_at":"2016-01-15T04:21:51Z","pushed_at":"2016-07-12T16:49:06Z","git_url":"git://github.com/mccumbermike/coresoftware.git","ssh_url":"git@github.com:mccumbermike/coresoftware.git","clone_url":"https://github.com/mccumbermike/coresoftware.git","svn_url":"https://github.com/mccumbermike/coresoftware","homepage":null,"size":5210,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sPHENIX-Collaboration:master","ref":"master","sha":"3b8257d698d51dc49e7c295b23e12e93ad775a5c","user":{"login":"sPHENIX-Collaboration","id":12069843,"avatar_url":"https://avatars.githubusercontent.com/u/12069843?v=3","gravatar_id":"","url":"https://api.github.com/users/sPHENIX-Collaboration","html_url":"https://github.com/sPHENIX-Collaboration","followers_url":"https://api.github.com/users/sPHENIX-Collaboration/followers","following_url":"https://api.github.com/users/sPHENIX-Collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sPHENIX-Collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sPHENIX-Collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sPHENIX-Collaboration/subscriptions","organizations_url":"https://api.github.com/users/sPHENIX-Collaboration/orgs","repos_url":"https://api.github.com/users/sPHENIX-Collaboration/repos","events_url":"https://api.github.com/users/sPHENIX-Collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sPHENIX-Collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":34742432,"name":"coresoftware","full_name":"sPHENIX-Collaboration/coresoftware","owner":{"login":"sPHENIX-Collaboration","id":12069843,"avatar_url":"https://avatars.githubusercontent.com/u/12069843?v=3","gravatar_id":"","url":"https://api.github.com/users/sPHENIX-Collaboration","html_url":"https://github.com/sPHENIX-Collaboration","followers_url":"https://api.github.com/users/sPHENIX-Collaboration/followers","following_url":"https://api.github.com/users/sPHENIX-Collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sPHENIX-Collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sPHENIX-Collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sPHENIX-Collaboration/subscriptions","organizations_url":"https://api.github.com/users/sPHENIX-Collaboration/orgs","repos_url":"https://api.github.com/users/sPHENIX-Collaboration/repos","events_url":"https://api.github.com/users/sPHENIX-Collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sPHENIX-Collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sPHENIX-Collaboration/coresoftware","description":"Our big core software repository","fork":false,"url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware","forks_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/forks","keys_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/teams","hooks_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/hooks","issue_events_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/events{/number}","events_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/events","assignees_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/assignees{/user}","branches_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/branches{/branch}","tags_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/tags","blobs_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/refs{/sha}","trees_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/statuses/{sha}","languages_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/languages","stargazers_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/stargazers","contributors_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/contributors","subscribers_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/subscribers","subscription_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/subscription","commits_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/commits{/sha}","git_commits_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/commits{/sha}","comments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/comments{/number}","issue_comment_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/comments{/number}","contents_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/contents/{+path}","compare_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/merges","archive_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/downloads","issues_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues{/number}","pulls_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls{/number}","milestones_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/milestones{/number}","notifications_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/labels{/name}","releases_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/releases{/id}","deployments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/deployments","created_at":"2015-04-28T16:29:55Z","updated_at":"2016-01-12T15:29:14Z","pushed_at":"2016-07-12T17:40:26Z","git_url":"git://github.com/sPHENIX-Collaboration/coresoftware.git","ssh_url":"git@github.com:sPHENIX-Collaboration/coresoftware.git","clone_url":"https://github.com/sPHENIX-Collaboration/coresoftware.git","svn_url":"https://github.com/sPHENIX-Collaboration/coresoftware","homepage":"https://wiki.bnl.gov/sPHENIX/index.php/Main_Page","size":5298,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":0,"forks":26,"open_issues":0,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/172"},"html":{"href":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/172"},"issue":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/172"},"comments":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/statuses/e32b626b489579e68740bc628b6f0d3e431bed02"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mccumbermike","id":12105552,"avatar_url":"https://avatars.githubusercontent.com/u/12105552?v=3","gravatar_id":"","url":"https://api.github.com/users/mccumbermike","html_url":"https://github.com/mccumbermike","followers_url":"https://api.github.com/users/mccumbermike/followers","following_url":"https://api.github.com/users/mccumbermike/following{/other_user}","gists_url":"https://api.github.com/users/mccumbermike/gists{/gist_id}","starred_url":"https://api.github.com/users/mccumbermike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccumbermike/subscriptions","organizations_url":"https://api.github.com/users/mccumbermike/orgs","repos_url":"https://api.github.com/users/mccumbermike/repos","events_url":"https://api.github.com/users/mccumbermike/events{/privacy}","received_events_url":"https://api.github.com/users/mccumbermike/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":41,"additions":8462,"deletions":10511,"changed_files":34}}
{"actor":{"display_login":"mccumbermike"}}