{"action":"created","comment":{"url":"https://api.github.com/repos/rsyslog/rsyslog/pulls/comments/67883172","id":67883172,"diff_hunk":"@@ -1257,11 +1277,22 @@ actionCommit(action_t *__restrict__ const pThis, wti_t *__restrict__ const pWti)\n \tbDone = 0;\n \tdo {\n \t\tiRet = actionTryCommit(pThis, pWti);\n-\t\tDBGPRINTF(\"actionCommit, in retry loop, iRet %d\\n\", iRet);\n+\t\tDBGPRINTF(\"actionCommit, action %d, in retry loop, iRet %d\\n\",\n+\t\t\tpThis->iActionNbr, iRet);\n+\t\tif(iRet == RS_RET_FORCE_TERM) {","path":"action.c","position":98,"original_position":98,"commit_id":"8abfb8117f6fddb784b74cbb8394d2f7cc1915c0","original_commit_id":"8abfb8117f6fddb784b74cbb8394d2f7cc1915c0","user":{"login":"rgerhards","id":1482123,"avatar_url":"https://avatars.githubusercontent.com/u/1482123?v=3","gravatar_id":"","url":"https://api.github.com/users/rgerhards","html_url":"https://github.com/rgerhards","followers_url":"https://api.github.com/users/rgerhards/followers","following_url":"https://api.github.com/users/rgerhards/following{/other_user}","gists_url":"https://api.github.com/users/rgerhards/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerhards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerhards/subscriptions","organizations_url":"https://api.github.com/users/rgerhards/orgs","repos_url":"https://api.github.com/users/rgerhards/repos","events_url":"https://api.github.com/users/rgerhards/events{/privacy}","received_events_url":"https://api.github.com/users/rgerhards/received_events","type":"User","site_admin":false},"body":"no, because RS_RET_FORCE_TERM really tells us to finish as quickly as possible. So it is better to check before each potentially time-consuming task. But I appreciate your note!\r\n\r\nside-note: while this code is better than what was there previously, some more refactoring is strongly desired and on my todo list. I just want to push this here as quickly as possible, as it definitely solves a number of hard-to-track issues (that we have seen on the issue trackers and mailing list).","created_at":"2016-06-21T14:49:35Z","updated_at":"2016-06-21T14:49:35Z","html_url":"https://github.com/rsyslog/rsyslog/pull/1070#discussion_r67883172","pull_request_url":"https://api.github.com/repos/rsyslog/rsyslog/pulls/1070","_links":{"self":{"href":"https://api.github.com/repos/rsyslog/rsyslog/pulls/comments/67883172"},"html":{"href":"https://github.com/rsyslog/rsyslog/pull/1070#discussion_r67883172"},"pull_request":{"href":"https://api.github.com/repos/rsyslog/rsyslog/pulls/1070"}}},"pull_request":{"url":"https://api.github.com/repos/rsyslog/rsyslog/pulls/1070","id":74610010,"html_url":"https://github.com/rsyslog/rsyslog/pull/1070","diff_url":"https://github.com/rsyslog/rsyslog/pull/1070.diff","patch_url":"https://github.com/rsyslog/rsyslog/pull/1070.patch","issue_url":"https://api.github.com/repos/rsyslog/rsyslog/issues/1070","number":1070,"state":"open","locked":false,"title":"fix issues in action commitTransaction processing","user":{"login":"rgerhards","id":1482123,"avatar_url":"https://avatars.githubusercontent.com/u/1482123?v=3","gravatar_id":"","url":"https://api.github.com/users/rgerhards","html_url":"https://github.com/rgerhards","followers_url":"https://api.github.com/users/rgerhards/followers","following_url":"https://api.github.com/users/rgerhards/following{/other_user}","gists_url":"https://api.github.com/users/rgerhards/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerhards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerhards/subscriptions","organizations_url":"https://api.github.com/users/rgerhards/orgs","repos_url":"https://api.github.com/users/rgerhards/repos","events_url":"https://api.github.com/users/rgerhards/events{/privacy}","received_events_url":"https://api.github.com/users/rgerhards/received_events","type":"User","site_admin":false},"body":"This also includes testbench enhancements.\r\n\r\nsee #500, #974 for more details","created_at":"2016-06-21T13:20:07Z","updated_at":"2016-06-21T14:49:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e82a364c3b7d20c8ff31d534c91bf0eab9079878","assignee":{"login":"rgerhards","id":1482123,"avatar_url":"https://avatars.githubusercontent.com/u/1482123?v=3","gravatar_id":"","url":"https://api.github.com/users/rgerhards","html_url":"https://github.com/rgerhards","followers_url":"https://api.github.com/users/rgerhards/followers","following_url":"https://api.github.com/users/rgerhards/following{/other_user}","gists_url":"https://api.github.com/users/rgerhards/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerhards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerhards/subscriptions","organizations_url":"https://api.github.com/users/rgerhards/orgs","repos_url":"https://api.github.com/users/rgerhards/repos","events_url":"https://api.github.com/users/rgerhards/events{/privacy}","received_events_url":"https://api.github.com/users/rgerhards/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/rsyslog/rsyslog/milestones/11","html_url":"https://github.com/rsyslog/rsyslog/milestones/v8.20%20release","labels_url":"https://api.github.com/repos/rsyslog/rsyslog/milestones/11/labels","id":1632494,"number":11,"title":"v8.20 release","description":"","creator":{"login":"rgerhards","id":1482123,"avatar_url":"https://avatars.githubusercontent.com/u/1482123?v=3","gravatar_id":"","url":"https://api.github.com/users/rgerhards","html_url":"https://github.com/rgerhards","followers_url":"https://api.github.com/users/rgerhards/followers","following_url":"https://api.github.com/users/rgerhards/following{/other_user}","gists_url":"https://api.github.com/users/rgerhards/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerhards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerhards/subscriptions","organizations_url":"https://api.github.com/users/rgerhards/orgs","repos_url":"https://api.github.com/users/rgerhards/repos","events_url":"https://api.github.com/users/rgerhards/events{/privacy}","received_events_url":"https://api.github.com/users/rgerhards/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":3,"state":"open","created_at":"2016-03-09T09:27:06Z","updated_at":"2016-06-21T13:20:08Z","due_on":"2016-07-07T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/rsyslog/rsyslog/pulls/1070/commits","review_comments_url":"https://api.github.com/repos/rsyslog/rsyslog/pulls/1070/comments","review_comment_url":"https://api.github.com/repos/rsyslog/rsyslog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rsyslog/rsyslog/issues/1070/comments","statuses_url":"https://api.github.com/repos/rsyslog/rsyslog/statuses/8abfb8117f6fddb784b74cbb8394d2f7cc1915c0","head":{"label":"rgerhards:i-974","ref":"i-974","sha":"8abfb8117f6fddb784b74cbb8394d2f7cc1915c0","user":{"login":"rgerhards","id":1482123,"avatar_url":"https://avatars.githubusercontent.com/u/1482123?v=3","gravatar_id":"","url":"https://api.github.com/users/rgerhards","html_url":"https://github.com/rgerhards","followers_url":"https://api.github.com/users/rgerhards/followers","following_url":"https://api.github.com/users/rgerhards/following{/other_user}","gists_url":"https://api.github.com/users/rgerhards/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerhards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerhards/subscriptions","organizations_url":"https://api.github.com/users/rgerhards/orgs","repos_url":"https://api.github.com/users/rgerhards/repos","events_url":"https://api.github.com/users/rgerhards/events{/privacy}","received_events_url":"https://api.github.com/users/rgerhards/received_events","type":"User","site_admin":false},"repo":{"id":16758618,"name":"rsyslog","full_name":"rgerhards/rsyslog","owner":{"login":"rgerhards","id":1482123,"avatar_url":"https://avatars.githubusercontent.com/u/1482123?v=3","gravatar_id":"","url":"https://api.github.com/users/rgerhards","html_url":"https://github.com/rgerhards","followers_url":"https://api.github.com/users/rgerhards/followers","following_url":"https://api.github.com/users/rgerhards/following{/other_user}","gists_url":"https://api.github.com/users/rgerhards/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerhards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerhards/subscriptions","organizations_url":"https://api.github.com/users/rgerhards/orgs","repos_url":"https://api.github.com/users/rgerhards/repos","events_url":"https://api.github.com/users/rgerhards/events{/privacy}","received_events_url":"https://api.github.com/users/rgerhards/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgerhards/rsyslog","description":"a Rocket-fast SYStem for LOG processing","fork":true,"url":"https://api.github.com/repos/rgerhards/rsyslog","forks_url":"https://api.github.com/repos/rgerhards/rsyslog/forks","keys_url":"https://api.github.com/repos/rgerhards/rsyslog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgerhards/rsyslog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgerhards/rsyslog/teams","hooks_url":"https://api.github.com/repos/rgerhards/rsyslog/hooks","issue_events_url":"https://api.github.com/repos/rgerhards/rsyslog/issues/events{/number}","events_url":"https://api.github.com/repos/rgerhards/rsyslog/events","assignees_url":"https://api.github.com/repos/rgerhards/rsyslog/assignees{/user}","branches_url":"https://api.github.com/repos/rgerhards/rsyslog/branches{/branch}","tags_url":"https://api.github.com/repos/rgerhards/rsyslog/tags","blobs_url":"https://api.github.com/repos/rgerhards/rsyslog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgerhards/rsyslog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgerhards/rsyslog/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgerhards/rsyslog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgerhards/rsyslog/statuses/{sha}","languages_url":"https://api.github.com/repos/rgerhards/rsyslog/languages","stargazers_url":"https://api.github.com/repos/rgerhards/rsyslog/stargazers","contributors_url":"https://api.github.com/repos/rgerhards/rsyslog/contributors","subscribers_url":"https://api.github.com/repos/rgerhards/rsyslog/subscribers","subscription_url":"https://api.github.com/repos/rgerhards/rsyslog/subscription","commits_url":"https://api.github.com/repos/rgerhards/rsyslog/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgerhards/rsyslog/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgerhards/rsyslog/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgerhards/rsyslog/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgerhards/rsyslog/contents/{+path}","compare_url":"https://api.github.com/repos/rgerhards/rsyslog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgerhards/rsyslog/merges","archive_url":"https://api.github.com/repos/rgerhards/rsyslog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgerhards/rsyslog/downloads","issues_url":"https://api.github.com/repos/rgerhards/rsyslog/issues{/number}","pulls_url":"https://api.github.com/repos/rgerhards/rsyslog/pulls{/number}","milestones_url":"https://api.github.com/repos/rgerhards/rsyslog/milestones{/number}","notifications_url":"https://api.github.com/repos/rgerhards/rsyslog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgerhards/rsyslog/labels{/name}","releases_url":"https://api.github.com/repos/rgerhards/rsyslog/releases{/id}","deployments_url":"https://api.github.com/repos/rgerhards/rsyslog/deployments","created_at":"2014-02-12T06:47:58Z","updated_at":"2015-04-30T06:53:09Z","pushed_at":"2016-06-21T12:21:01Z","git_url":"git://github.com/rgerhards/rsyslog.git","ssh_url":"git@github.com:rgerhards/rsyslog.git","clone_url":"https://github.com/rgerhards/rsyslog.git","svn_url":"https://github.com/rgerhards/rsyslog","homepage":"http://www.rsyslog.com","size":41840,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"rsyslog:master","ref":"master","sha":"86e09b162f4bec68011f4be8f555195c1f79e0a8","user":{"login":"rsyslog","id":6178456,"avatar_url":"https://avatars.githubusercontent.com/u/6178456?v=3","gravatar_id":"","url":"https://api.github.com/users/rsyslog","html_url":"https://github.com/rsyslog","followers_url":"https://api.github.com/users/rsyslog/followers","following_url":"https://api.github.com/users/rsyslog/following{/other_user}","gists_url":"https://api.github.com/users/rsyslog/gists{/gist_id}","starred_url":"https://api.github.com/users/rsyslog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsyslog/subscriptions","organizations_url":"https://api.github.com/users/rsyslog/orgs","repos_url":"https://api.github.com/users/rsyslog/repos","events_url":"https://api.github.com/users/rsyslog/events{/privacy}","received_events_url":"https://api.github.com/users/rsyslog/received_events","type":"Organization","site_admin":false},"repo":{"id":10458362,"name":"rsyslog","full_name":"rsyslog/rsyslog","owner":{"login":"rsyslog","id":6178456,"avatar_url":"https://avatars.githubusercontent.com/u/6178456?v=3","gravatar_id":"","url":"https://api.github.com/users/rsyslog","html_url":"https://github.com/rsyslog","followers_url":"https://api.github.com/users/rsyslog/followers","following_url":"https://api.github.com/users/rsyslog/following{/other_user}","gists_url":"https://api.github.com/users/rsyslog/gists{/gist_id}","starred_url":"https://api.github.com/users/rsyslog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsyslog/subscriptions","organizations_url":"https://api.github.com/users/rsyslog/orgs","repos_url":"https://api.github.com/users/rsyslog/repos","events_url":"https://api.github.com/users/rsyslog/events{/privacy}","received_events_url":"https://api.github.com/users/rsyslog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rsyslog/rsyslog","description":"a Rocket-fast SYStem for LOG processing","fork":false,"url":"https://api.github.com/repos/rsyslog/rsyslog","forks_url":"https://api.github.com/repos/rsyslog/rsyslog/forks","keys_url":"https://api.github.com/repos/rsyslog/rsyslog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsyslog/rsyslog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsyslog/rsyslog/teams","hooks_url":"https://api.github.com/repos/rsyslog/rsyslog/hooks","issue_events_url":"https://api.github.com/repos/rsyslog/rsyslog/issues/events{/number}","events_url":"https://api.github.com/repos/rsyslog/rsyslog/events","assignees_url":"https://api.github.com/repos/rsyslog/rsyslog/assignees{/user}","branches_url":"https://api.github.com/repos/rsyslog/rsyslog/branches{/branch}","tags_url":"https://api.github.com/repos/rsyslog/rsyslog/tags","blobs_url":"https://api.github.com/repos/rsyslog/rsyslog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsyslog/rsyslog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsyslog/rsyslog/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsyslog/rsyslog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsyslog/rsyslog/statuses/{sha}","languages_url":"https://api.github.com/repos/rsyslog/rsyslog/languages","stargazers_url":"https://api.github.com/repos/rsyslog/rsyslog/stargazers","contributors_url":"https://api.github.com/repos/rsyslog/rsyslog/contributors","subscribers_url":"https://api.github.com/repos/rsyslog/rsyslog/subscribers","subscription_url":"https://api.github.com/repos/rsyslog/rsyslog/subscription","commits_url":"https://api.github.com/repos/rsyslog/rsyslog/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsyslog/rsyslog/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsyslog/rsyslog/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsyslog/rsyslog/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsyslog/rsyslog/contents/{+path}","compare_url":"https://api.github.com/repos/rsyslog/rsyslog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsyslog/rsyslog/merges","archive_url":"https://api.github.com/repos/rsyslog/rsyslog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsyslog/rsyslog/downloads","issues_url":"https://api.github.com/repos/rsyslog/rsyslog/issues{/number}","pulls_url":"https://api.github.com/repos/rsyslog/rsyslog/pulls{/number}","milestones_url":"https://api.github.com/repos/rsyslog/rsyslog/milestones{/number}","notifications_url":"https://api.github.com/repos/rsyslog/rsyslog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsyslog/rsyslog/labels{/name}","releases_url":"https://api.github.com/repos/rsyslog/rsyslog/releases{/id}","deployments_url":"https://api.github.com/repos/rsyslog/rsyslog/deployments","created_at":"2013-06-03T15:57:55Z","updated_at":"2016-06-20T05:25:26Z","pushed_at":"2016-06-21T13:20:08Z","git_url":"git://github.com/rsyslog/rsyslog.git","ssh_url":"git@github.com:rsyslog/rsyslog.git","clone_url":"https://github.com/rsyslog/rsyslog.git","svn_url":"https://github.com/rsyslog/rsyslog","homepage":"http://www.rsyslog.com","size":48973,"stargazers_count":338,"watchers_count":338,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":179,"forks":194,"open_issues":179,"watchers":338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rsyslog/rsyslog/pulls/1070"},"html":{"href":"https://github.com/rsyslog/rsyslog/pull/1070"},"issue":{"href":"https://api.github.com/repos/rsyslog/rsyslog/issues/1070"},"comments":{"href":"https://api.github.com/repos/rsyslog/rsyslog/issues/1070/comments"},"review_comments":{"href":"https://api.github.com/repos/rsyslog/rsyslog/pulls/1070/comments"},"review_comment":{"href":"https://api.github.com/repos/rsyslog/rsyslog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rsyslog/rsyslog/pulls/1070/commits"},"statuses":{"href":"https://api.github.com/repos/rsyslog/rsyslog/statuses/8abfb8117f6fddb784b74cbb8394d2f7cc1915c0"}}}}
{"actor":{"display_login":"rgerhards"}}