{"action":"created","comment":{"url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments/50030740","id":50030740,"diff_hunk":"@@ -0,0 +1,29 @@\n+// Function for creating URLs of all the places in the application.\n+","path":"client-js/app/scripts/places.ts","position":2,"original_position":2,"commit_id":"ce6376e64af0a7195ea916f531db0ed09a39e0f3","original_commit_id":"ce6376e64af0a7195ea916f531db0ed09a39e0f3","user":{"login":"joshmutus","id":8173925,"avatar_url":"https://avatars.githubusercontent.com/u/8173925?v=3","gravatar_id":"","url":"https://api.github.com/users/joshmutus","html_url":"https://github.com/joshmutus","followers_url":"https://api.github.com/users/joshmutus/followers","following_url":"https://api.github.com/users/joshmutus/following{/other_user}","gists_url":"https://api.github.com/users/joshmutus/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmutus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmutus/subscriptions","organizations_url":"https://api.github.com/users/joshmutus/orgs","repos_url":"https://api.github.com/users/joshmutus/repos","events_url":"https://api.github.com/users/joshmutus/events{/privacy}","received_events_url":"https://api.github.com/users/joshmutus/received_events","type":"User","site_admin":false},"body":"So this just creates URLs, it doesn't handle routing at all?","created_at":"2016-01-18T18:32:01Z","updated_at":"2016-01-18T18:32:01Z","html_url":"https://github.com/labrad/scalabrad-web/pull/129#discussion_r50030740","pull_request_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments/50030740"},"html":{"href":"https://github.com/labrad/scalabrad-web/pull/129#discussion_r50030740"},"pull_request":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/129","id":55046397,"html_url":"https://github.com/labrad/scalabrad-web/pull/129","diff_url":"https://github.com/labrad/scalabrad-web/pull/129.diff","patch_url":"https://github.com/labrad/scalabrad-web/pull/129.patch","issue_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/129","number":129,"state":"open","locked":false,"title":"Move activities and places into their own modules.","user":{"login":"maffoo","id":129268,"avatar_url":"https://avatars.githubusercontent.com/u/129268?v=3","gravatar_id":"","url":"https://api.github.com/users/maffoo","html_url":"https://github.com/maffoo","followers_url":"https://api.github.com/users/maffoo/followers","following_url":"https://api.github.com/users/maffoo/following{/other_user}","gists_url":"https://api.github.com/users/maffoo/gists{/gist_id}","starred_url":"https://api.github.com/users/maffoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maffoo/subscriptions","organizations_url":"https://api.github.com/users/maffoo/orgs","repos_url":"https://api.github.com/users/maffoo/repos","events_url":"https://api.github.com/users/maffoo/events{/privacy}","received_events_url":"https://api.github.com/users/maffoo/received_events","type":"User","site_admin":false},"body":"Pull the Activity classes out into a separate module instead of putting them inside an event callback in the main app module. Among other things, this forces us to declare all the dependencies for each activity in its constructor, rather than close over variables from the outer scope when creating activities. We also put the functions for generating urls into a single location so they can be more self-contained.","created_at":"2016-01-05T01:53:13Z","updated_at":"2016-01-18T18:32:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94f639a2afaf8a3da144b47ba224b37226d09c1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/129/commits","review_comments_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/129/comments","review_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/129/comments","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/ce6376e64af0a7195ea916f531db0ed09a39e0f3","head":{"label":"labrad:u/maffoo/place-refactor","ref":"u/maffoo/place-refactor","sha":"ce6376e64af0a7195ea916f531db0ed09a39e0f3","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":32440005,"name":"scalabrad-web","full_name":"labrad/scalabrad-web","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad-web","description":"A web interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad-web","forks_url":"https://api.github.com/repos/labrad/scalabrad-web/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad-web/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad-web/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad-web/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad-web/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad-web/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad-web/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad-web/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad-web/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad-web/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad-web/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad-web/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad-web/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad-web/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad-web/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad-web/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad-web/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad-web/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad-web/releases{/id}","created_at":"2015-03-18T05:34:53Z","updated_at":"2015-10-26T17:44:45Z","pushed_at":"2016-01-09T02:46:25Z","git_url":"git://github.com/labrad/scalabrad-web.git","ssh_url":"git@github.com:labrad/scalabrad-web.git","clone_url":"https://github.com/labrad/scalabrad-web.git","svn_url":"https://github.com/labrad/scalabrad-web","homepage":"","size":598,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":36,"forks":0,"open_issues":36,"watchers":0,"default_branch":"master"}},"base":{"label":"labrad:master","ref":"master","sha":"78378c553530cec149441b522054782073b7a6f8","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":32440005,"name":"scalabrad-web","full_name":"labrad/scalabrad-web","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad-web","description":"A web interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad-web","forks_url":"https://api.github.com/repos/labrad/scalabrad-web/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad-web/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad-web/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad-web/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad-web/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad-web/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad-web/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad-web/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad-web/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad-web/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad-web/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad-web/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad-web/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad-web/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad-web/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad-web/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad-web/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad-web/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad-web/releases{/id}","created_at":"2015-03-18T05:34:53Z","updated_at":"2015-10-26T17:44:45Z","pushed_at":"2016-01-09T02:46:25Z","git_url":"git://github.com/labrad/scalabrad-web.git","ssh_url":"git@github.com:labrad/scalabrad-web.git","clone_url":"https://github.com/labrad/scalabrad-web.git","svn_url":"https://github.com/labrad/scalabrad-web","homepage":"","size":598,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":36,"forks":0,"open_issues":36,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/129"},"html":{"href":"https://github.com/labrad/scalabrad-web/pull/129"},"issue":{"href":"https://api.github.com/repos/labrad/scalabrad-web/issues/129"},"comments":{"href":"https://api.github.com/repos/labrad/scalabrad-web/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/labrad/scalabrad-web/statuses/ce6376e64af0a7195ea916f531db0ed09a39e0f3"}}}}