{"action":"created","comment":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/71970653","id":71970653,"diff_hunk":"@@ -86,6 +86,17 @@ Feature: quickmarks and bookmarks\n         And I run :bookmark-del http://localhost:(port)/data/numbers/5.txt\n         Then the bookmark file should not contain \"http://localhost:*/data/numbers/5.txt \"\n \n+    Scenario: Deleting the current page's bookmark if it doesn't exist\n+        When I open about:blank\n+        And I run :bookmark-del\n+        Then the error \"Bookmark 'about:blank' not found!\" should be shown\n+\n+    Scenario: Deleting the current page's bookmark\n+        When I open data/numbers/5.txt\n+        And I run :bookmark-add\n+        And I run :bookmark-del\n+        Then the bookmark file should not contain \"http://localhost:*/data/numbers/5.txt \"","path":"tests/end2end/features/urlmarks.feature","position":13,"original_position":13,"commit_id":"e9660ad676c3de3240d4684794c78eb4d607b765","original_commit_id":"e9660ad676c3de3240d4684794c78eb4d607b765","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"body":"I know it's kind of cumbersome, but please use an unused number here, which makes sure tests don't affect each other.","created_at":"2016-07-23T10:22:07Z","updated_at":"2016-07-23T10:22:07Z","html_url":"https://github.com/The-Compiler/qutebrowser/pull/1671#discussion_r71970653","pull_request_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1671","_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/71970653"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/1671#discussion_r71970653"},"pull_request":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1671"}}},"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1671","id":78417839,"html_url":"https://github.com/The-Compiler/qutebrowser/pull/1671","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/1671.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/1671.patch","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1671","number":1671,"state":"open","locked":false,"title":"Make bookmark-del and quickmark-del with no arguments remove the current page's mark","user":{"login":"mlochbaum","id":1320219,"avatar_url":"https://avatars.githubusercontent.com/u/1320219?v=3","gravatar_id":"","url":"https://api.github.com/users/mlochbaum","html_url":"https://github.com/mlochbaum","followers_url":"https://api.github.com/users/mlochbaum/followers","following_url":"https://api.github.com/users/mlochbaum/following{/other_user}","gists_url":"https://api.github.com/users/mlochbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/mlochbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlochbaum/subscriptions","organizations_url":"https://api.github.com/users/mlochbaum/orgs","repos_url":"https://api.github.com/users/mlochbaum/repos","events_url":"https://api.github.com/users/mlochbaum/events{/privacy}","received_events_url":"https://api.github.com/users/mlochbaum/received_events","type":"User","site_admin":false},"body":"Fixes issue #1661 and does the same for bookmarks. The `quickmark-del` implementation is messy since it has to search through the dict values rather than keys, but I assume you knew that the issue required this. If one url has multiple quickmarks (which shouldn't happen often...), I decided to just delete one, chosen arbitrarily, in order to avoid searching all values every time.\r\n\r\nAlso fixes a typo that made the \"deleting a quickmark\" test useless.\r\n\r\nIf I've missed anything, let me know and I will fix it on this end--I want to learn the right process since I plan on making several contributions. And great work on the browser!","created_at":"2016-07-22T02:54:29Z","updated_at":"2016-07-23T10:22:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"666c60378d035d54ca91c3f04c2229215bc616a5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1671/commits","review_comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1671/comments","review_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1671/comments","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/e9660ad676c3de3240d4684794c78eb4d607b765","head":{"label":"mlochbaum:mark-del-no-args","ref":"mark-del-no-args","sha":"e9660ad676c3de3240d4684794c78eb4d607b765","user":{"login":"mlochbaum","id":1320219,"avatar_url":"https://avatars.githubusercontent.com/u/1320219?v=3","gravatar_id":"","url":"https://api.github.com/users/mlochbaum","html_url":"https://github.com/mlochbaum","followers_url":"https://api.github.com/users/mlochbaum/followers","following_url":"https://api.github.com/users/mlochbaum/following{/other_user}","gists_url":"https://api.github.com/users/mlochbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/mlochbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlochbaum/subscriptions","organizations_url":"https://api.github.com/users/mlochbaum/orgs","repos_url":"https://api.github.com/users/mlochbaum/repos","events_url":"https://api.github.com/users/mlochbaum/events{/privacy}","received_events_url":"https://api.github.com/users/mlochbaum/received_events","type":"User","site_admin":false},"repo":{"id":63917546,"name":"qutebrowser","full_name":"mlochbaum/qutebrowser","owner":{"login":"mlochbaum","id":1320219,"avatar_url":"https://avatars.githubusercontent.com/u/1320219?v=3","gravatar_id":"","url":"https://api.github.com/users/mlochbaum","html_url":"https://github.com/mlochbaum","followers_url":"https://api.github.com/users/mlochbaum/followers","following_url":"https://api.github.com/users/mlochbaum/following{/other_user}","gists_url":"https://api.github.com/users/mlochbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/mlochbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlochbaum/subscriptions","organizations_url":"https://api.github.com/users/mlochbaum/orgs","repos_url":"https://api.github.com/users/mlochbaum/repos","events_url":"https://api.github.com/users/mlochbaum/events{/privacy}","received_events_url":"https://api.github.com/users/mlochbaum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlochbaum/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":true,"url":"https://api.github.com/repos/mlochbaum/qutebrowser","forks_url":"https://api.github.com/repos/mlochbaum/qutebrowser/forks","keys_url":"https://api.github.com/repos/mlochbaum/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlochbaum/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlochbaum/qutebrowser/teams","hooks_url":"https://api.github.com/repos/mlochbaum/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/mlochbaum/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/mlochbaum/qutebrowser/events","assignees_url":"https://api.github.com/repos/mlochbaum/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/mlochbaum/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/mlochbaum/qutebrowser/tags","blobs_url":"https://api.github.com/repos/mlochbaum/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlochbaum/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlochbaum/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlochbaum/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlochbaum/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/mlochbaum/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/mlochbaum/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/mlochbaum/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/mlochbaum/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/mlochbaum/qutebrowser/subscription","commits_url":"https://api.github.com/repos/mlochbaum/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlochbaum/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlochbaum/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlochbaum/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlochbaum/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/mlochbaum/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlochbaum/qutebrowser/merges","archive_url":"https://api.github.com/repos/mlochbaum/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlochbaum/qutebrowser/downloads","issues_url":"https://api.github.com/repos/mlochbaum/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/mlochbaum/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/mlochbaum/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/mlochbaum/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlochbaum/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/mlochbaum/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/mlochbaum/qutebrowser/deployments","created_at":"2016-07-22T02:36:22Z","updated_at":"2016-07-22T02:36:24Z","pushed_at":"2016-07-23T03:02:13Z","git_url":"git://github.com/mlochbaum/qutebrowser.git","ssh_url":"git@github.com:mlochbaum/qutebrowser.git","clone_url":"https://github.com/mlochbaum/qutebrowser.git","svn_url":"https://github.com/mlochbaum/qutebrowser","homepage":"https://www.qutebrowser.org/","size":17883,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"The-Compiler:master","ref":"master","sha":"63e466f01985abd7be275855f0af7450eb97d8e1","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"repo":{"id":21244505,"name":"qutebrowser","full_name":"The-Compiler/qutebrowser","owner":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/The-Compiler/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":false,"url":"https://api.github.com/repos/The-Compiler/qutebrowser","forks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/forks","keys_url":"https://api.github.com/repos/The-Compiler/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/The-Compiler/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/The-Compiler/qutebrowser/teams","hooks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/events","assignees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/The-Compiler/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/tags","blobs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/The-Compiler/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscription","commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/The-Compiler/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/The-Compiler/qutebrowser/merges","archive_url":"https://api.github.com/repos/The-Compiler/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/The-Compiler/qutebrowser/downloads","issues_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/The-Compiler/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/The-Compiler/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/The-Compiler/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/deployments","created_at":"2014-06-26T14:59:34Z","updated_at":"2016-07-22T21:45:42Z","pushed_at":"2016-07-23T10:02:10Z","git_url":"git://github.com/The-Compiler/qutebrowser.git","ssh_url":"git@github.com:The-Compiler/qutebrowser.git","clone_url":"https://github.com/The-Compiler/qutebrowser.git","svn_url":"https://github.com/The-Compiler/qutebrowser","homepage":"https://www.qutebrowser.org/","size":21548,"stargazers_count":1277,"watchers_count":1277,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":203,"mirror_url":null,"open_issues_count":406,"forks":203,"open_issues":406,"watchers":1277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1671"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/1671"},"issue":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1671"},"comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1671/comments"},"review_comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1671/comments"},"review_comment":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1671/commits"},"statuses":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/e9660ad676c3de3240d4684794c78eb4d607b765"}}}}
{"actor":{"display_login":"The-Compiler"}}