{"action":"created","issue":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/356","repository_url":"https://api.github.com/repos/SpongePowered/SpongeCommon","labels_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/356/labels{/name}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/356/comments","events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/356/events","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/356","id":123612416,"number":356,"title":"[WIP] MobSpawnerData Processor implementations","user":{"login":"ZephireNZ","id":1644496,"avatar_url":"https://avatars.githubusercontent.com/u/1644496?v=3","gravatar_id":"","url":"https://api.github.com/users/ZephireNZ","html_url":"https://github.com/ZephireNZ","followers_url":"https://api.github.com/users/ZephireNZ/followers","following_url":"https://api.github.com/users/ZephireNZ/following{/other_user}","gists_url":"https://api.github.com/users/ZephireNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ZephireNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZephireNZ/subscriptions","organizations_url":"https://api.github.com/users/ZephireNZ/orgs","repos_url":"https://api.github.com/users/ZephireNZ/repos","events_url":"https://api.github.com/users/ZephireNZ/events{/privacy}","received_events_url":"https://api.github.com/users/ZephireNZ/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/labels/data","name":"data","color":"10E7E8"},{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/labels/needs%20testing","name":"needs testing","color":"73737D"}],"state":"open","locked":false,"assignee":{"login":"gabizou","id":1203877,"avatar_url":"https://avatars.githubusercontent.com/u/1203877?v=3","gravatar_id":"","url":"https://api.github.com/users/gabizou","html_url":"https://github.com/gabizou","followers_url":"https://api.github.com/users/gabizou/followers","following_url":"https://api.github.com/users/gabizou/following{/other_user}","gists_url":"https://api.github.com/users/gabizou/gists{/gist_id}","starred_url":"https://api.github.com/users/gabizou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabizou/subscriptions","organizations_url":"https://api.github.com/users/gabizou/orgs","repos_url":"https://api.github.com/users/gabizou/repos","events_url":"https://api.github.com/users/gabizou/events{/privacy}","received_events_url":"https://api.github.com/users/gabizou/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/milestones/2","html_url":"https://github.com/SpongePowered/SpongeCommon/milestones/4.x","labels_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/milestones/2/labels","id":1598617,"number":2,"title":"4.x","description":"Issues and PR's to be resolved by the end of 4.x's release cycle","creator":{"login":"gabizou","id":1203877,"avatar_url":"https://avatars.githubusercontent.com/u/1203877?v=3","gravatar_id":"","url":"https://api.github.com/users/gabizou","html_url":"https://github.com/gabizou","followers_url":"https://api.github.com/users/gabizou/followers","following_url":"https://api.github.com/users/gabizou/following{/other_user}","gists_url":"https://api.github.com/users/gabizou/gists{/gist_id}","starred_url":"https://api.github.com/users/gabizou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabizou/subscriptions","organizations_url":"https://api.github.com/users/gabizou/orgs","repos_url":"https://api.github.com/users/gabizou/repos","events_url":"https://api.github.com/users/gabizou/events{/privacy}","received_events_url":"https://api.github.com/users/gabizou/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2016-02-23T00:04:37Z","updated_at":"2016-02-23T00:07:35Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2015-12-23T07:13:05Z","updated_at":"2016-02-23T00:08:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/356","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/356","diff_url":"https://github.com/SpongePowered/SpongeCommon/pull/356.diff","patch_url":"https://github.com/SpongePowered/SpongeCommon/pull/356.patch"},"body":"Implementation of `REPLACE_WITH_DATA_MANIPULATOR`.\r\n- [ ] Registration of field getters and setters\r\n- [ ] Accurately used the appropriate `AbstractData` implementation\r\n\r\nImplementation of `REPLACE_WITH_IMMUTABLE_MANIPULATOR`\r\n- [ ] Accurately extended the appropriate `AbstractImmutableData` implementation\r\n- [ ] Accurately instantiating final instance fields with an `ImmutableValue` counter part for any value getters\r\n- [x] If necessary, creating a new `ImmutableValue` for a value that should not be cached, or, using the existing caching utils.\r\n\r\nImplementation of the `VALUE_PROCESSOR`(s):\r\n- [x] Appropriately extended `AbstractSpongeValueProcessor`\r\n- [ ] Individual processors for each source type possible (one for `ItemStack`/`TileEntity`/`Entity` as necessary).\r\n\r\nRegistration:\r\n- [ ] Registered the `Key` correctly by `FIELD_NAME` in the `KeyRegistry`\r\n- [ ] Registered the `DataProcessor`s and `DataManipulatorBuilder` in `SpongeSerializationRegistry`\r\n- [x] Registered the `ValueProcessor`s in the `SpongeSerializationRegistry`\r\n\r\nTest Plugin code:\r\n\r\nThere will be a lot of tests for such a large plugin, will post to a gist:\r\nhttps://gist.github.com/ZephireNZ/187e1b6960feea9a0a80\r\n\r\nNotes:\r\nYour test plugin should test using all possible value related methods with your `DataManipulator`s and also test the serialization and deserialization of your `DataManipulator`s.\r\n"},"comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/comments/187445636","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/356#issuecomment-187445636","issue_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/356","id":187445636,"user":{"login":"gabizou","id":1203877,"avatar_url":"https://avatars.githubusercontent.com/u/1203877?v=3","gravatar_id":"","url":"https://api.github.com/users/gabizou","html_url":"https://github.com/gabizou","followers_url":"https://api.github.com/users/gabizou/followers","following_url":"https://api.github.com/users/gabizou/following{/other_user}","gists_url":"https://api.github.com/users/gabizou/gists{/gist_id}","starred_url":"https://api.github.com/users/gabizou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabizou/subscriptions","organizations_url":"https://api.github.com/users/gabizou/orgs","repos_url":"https://api.github.com/users/gabizou/repos","events_url":"https://api.github.com/users/gabizou/events{/privacy}","received_events_url":"https://api.github.com/users/gabizou/received_events","type":"User","site_admin":false},"created_at":"2016-02-23T00:08:07Z","updated_at":"2016-02-23T00:08:07Z","body":"@ZephireNZ Care to update me on what's holding this up?"}}