{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/78131358","id":78131358,"diff_hunk":"@@ -0,0 +1,123 @@\n+'use strict';\n+const common = require('../common');\n+const assert = require('assert');\n+\n+if (!common.hasCrypto) {\n+  common.skip('missing crypto');\n+  return;\n+}\n+\n+if (!common.enoughTestMem) {\n+  common.skip('skipping memory-intensive test');","path":"test/sequential/test-crypto-timing-safe-equal-benchmarks.js","position":11,"original_position":11,"commit_id":"5abe8b912302c82ef273b2b060bb5dbba73eaaaf","original_commit_id":"5abe8b912302c82ef273b2b060bb5dbba73eaaaf","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"Nit: `common.skip()` prepends text indicating the test has been skipped so the word 'skipping' is redundant. I'm sure this is actually an issue with a bunch of other tests and is fine to leave as-is (hence the 'Nit' prefix) if you wish, as fixing these throughout the tests would probably make a good first contribution for a newcomer anyway.","created_at":"2016-09-09T05:41:32Z","updated_at":"2016-09-09T05:41:32Z","html_url":"https://github.com/nodejs/node/pull/8456#discussion_r78131358","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/8456","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/78131358"},"html":{"href":"https://github.com/nodejs/node/pull/8456#discussion_r78131358"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/8456"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8456","id":84571622,"html_url":"https://github.com/nodejs/node/pull/8456","diff_url":"https://github.com/nodejs/node/pull/8456.diff","patch_url":"https://github.com/nodejs/node/pull/8456.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/8456","number":8456,"state":"open","locked":false,"title":"WIP: test: make crypto.timingSafeEqual test less flaky","user":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars.githubusercontent.com/u/11638619?v=3","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ncrypto\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nWIP; do not merge.\r\n\r\nThe `crypto.timingSafeEqual` test still seems to be a bit flaky. This makes a few changes to the test:\r\n\r\n* Separates the basic usage and the benchmarking into different tests\r\n* Moves the timing-sensitive benchmark function into a separate module, and reparses the module on every iteration of the loop to avoid shared state between tests.\r\n\r\nIf this doesn't work, an alternative would be to start a separate child process for each individual timing measurement, which would completely avoid shared state between measurements (although it would also probably make the test much more CPU-intensive).\r\n\r\n/cc @Trott\r\n\r\nRefs: #8040, #8203, #8304","created_at":"2016-09-08T23:31:27Z","updated_at":"2016-09-09T05:41:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"137305279e796779be20ff006835927075a797eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/8456/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/8456/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8456/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/5abe8b912302c82ef273b2b060bb5dbba73eaaaf","head":{"label":"not-an-aardvark:fix-more-timing-safe-equal-flakes","ref":"fix-more-timing-safe-equal-flakes","sha":"5abe8b912302c82ef273b2b060bb5dbba73eaaaf","user":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars.githubusercontent.com/u/11638619?v=3","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"repo":{"id":65264522,"name":"node","full_name":"not-an-aardvark/node","owner":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars.githubusercontent.com/u/11638619?v=3","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/not-an-aardvark/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/not-an-aardvark/node","forks_url":"https://api.github.com/repos/not-an-aardvark/node/forks","keys_url":"https://api.github.com/repos/not-an-aardvark/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/not-an-aardvark/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/not-an-aardvark/node/teams","hooks_url":"https://api.github.com/repos/not-an-aardvark/node/hooks","issue_events_url":"https://api.github.com/repos/not-an-aardvark/node/issues/events{/number}","events_url":"https://api.github.com/repos/not-an-aardvark/node/events","assignees_url":"https://api.github.com/repos/not-an-aardvark/node/assignees{/user}","branches_url":"https://api.github.com/repos/not-an-aardvark/node/branches{/branch}","tags_url":"https://api.github.com/repos/not-an-aardvark/node/tags","blobs_url":"https://api.github.com/repos/not-an-aardvark/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/not-an-aardvark/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/not-an-aardvark/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/not-an-aardvark/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/not-an-aardvark/node/statuses/{sha}","languages_url":"https://api.github.com/repos/not-an-aardvark/node/languages","stargazers_url":"https://api.github.com/repos/not-an-aardvark/node/stargazers","contributors_url":"https://api.github.com/repos/not-an-aardvark/node/contributors","subscribers_url":"https://api.github.com/repos/not-an-aardvark/node/subscribers","subscription_url":"https://api.github.com/repos/not-an-aardvark/node/subscription","commits_url":"https://api.github.com/repos/not-an-aardvark/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/not-an-aardvark/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/not-an-aardvark/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/not-an-aardvark/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/not-an-aardvark/node/contents/{+path}","compare_url":"https://api.github.com/repos/not-an-aardvark/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/not-an-aardvark/node/merges","archive_url":"https://api.github.com/repos/not-an-aardvark/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/not-an-aardvark/node/downloads","issues_url":"https://api.github.com/repos/not-an-aardvark/node/issues{/number}","pulls_url":"https://api.github.com/repos/not-an-aardvark/node/pulls{/number}","milestones_url":"https://api.github.com/repos/not-an-aardvark/node/milestones{/number}","notifications_url":"https://api.github.com/repos/not-an-aardvark/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/not-an-aardvark/node/labels{/name}","releases_url":"https://api.github.com/repos/not-an-aardvark/node/releases{/id}","deployments_url":"https://api.github.com/repos/not-an-aardvark/node/deployments","created_at":"2016-08-09T05:05:02Z","updated_at":"2016-08-09T05:05:20Z","pushed_at":"2016-09-09T05:31:54Z","git_url":"git://github.com/not-an-aardvark/node.git","ssh_url":"git@github.com:not-an-aardvark/node.git","clone_url":"https://github.com/not-an-aardvark/node.git","svn_url":"https://github.com/not-an-aardvark/node","homepage":"https://nodejs.org","size":226040,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"c21458a15dcbff405b18a680e9ed18863567736b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-09-09T04:55:57Z","pushed_at":"2016-09-09T05:31:55Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":301596,"stargazers_count":26526,"watchers_count":26526,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4168,"mirror_url":null,"open_issues_count":772,"forks":4168,"open_issues":772,"watchers":26526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/8456"},"html":{"href":"https://github.com/nodejs/node/pull/8456"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/8456"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/8456/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/8456/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/8456/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/5abe8b912302c82ef273b2b060bb5dbba73eaaaf"}}}}
{"actor":{"display_login":"Trott"}}