{"push_id":1373389464,"size":352,"distinct_size":0,"ref":"refs/heads/master","head":"e3ded092e21c962093e2e894b04969bf9643e368","before":"c77938efc9f52449c30018bf29422c1d590cdbdc","commits":[{"sha":"d8c09535679ebb60e09bb337c42fd542340a3814","author":{"name":"Giannis Kosmas","email":"8aed0e81db5afa41321bddf4cbfc3288293fdd78@gmail.com"},"message":"Better parsing of query string variables","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/d8c09535679ebb60e09bb337c42fd542340a3814"},{"sha":"dd3a8a1b6dbd519406da2c07ac6c54df3f3f36c4","author":{"name":"Samuel","email":"88234efc198f455848fa728fbde3ce549be1e7b4@cendio.se"},"message":"Merge pull request #363 from kosmasgiannis/query_parse\n\nBetter parsing of query string variables","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/dd3a8a1b6dbd519406da2c07ac6c54df3f3f36c4"},{"sha":"4a4643c05d2412bcb632fde5610f6e0e76d7dea1","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Support automatically opening test HTML in browser\n\nWhen using the '-g' option with run_from_console.js, you can\nnow pass the '-o' option to automatically open the generated\nHTML file in your default browser.  This relies on the 'open'\nNPM module.","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/4a4643c05d2412bcb632fde5610f6e0e76d7dea1"},{"sha":"d906dfc953df38e56756ae4e63f4f017f7aa6921","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Add support for injecting test helper files\n\nNow, the phrase `requires test modules: ` may be place in a comment\nin a file to require modules local to the test directory, similarly\nto the way the `require local modules: ` line may be used to inject\nfiles in the 'include' directory.  This is useful for when common\nfakes need to be injected into a test.","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/d906dfc953df38e56756ae4e63f4f017f7aa6921"},{"sha":"7187bc121fae5a85c04abce315499367b2d7ac67","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Fixed typo in run_from_console.js","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/7187bc121fae5a85c04abce315499367b2d7ac67"},{"sha":"93af721a27419e1e8496c267f96ee1f291717781","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Output error events from provider in test runner\n\nNow, 'error' events from the test runner are output to stderr.\nAdditionally, when debug is enabled, debug output is logged to\nstderr instead of stdout (as was the case previously).","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/93af721a27419e1e8496c267f96ee1f291717781"},{"sha":"9b731d3a5811cce05001e1d8fbb0d53e2859c86b","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Fix race condition in test runner\n\nPreviously, there would be a case where if your tests took\ntoo long to run, the casper test runner would only report\non certain tests.  This has been fixed.","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/9b731d3a5811cce05001e1d8fbb0d53e2859c86b"},{"sha":"960752ea5308ea5aacd5a350b2ad45dcf999a608","author":{"name":"samhed","email":"88234efc198f455848fa728fbde3ce549be1e7b4@cendio.se"},"message":"fixes an error that was made in the merge with the last sync with websockify.","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/960752ea5308ea5aacd5a350b2ad45dcf999a608"},{"sha":"91127741bea2238277a426a382fec3740103d606","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Support running all tests from the root directory\n\nPreviously, if you did not specify a tests file,\nyou had to be in the 'tests' directory for the\n\"run all tests\" functionality to work.  Now it\nwill work in any directory.","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/91127741bea2238277a426a382fec3740103d606"},{"sha":"95eb681bbb609c1fe6a7dace694afa6ed00cf4d3","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Support the \"NOTUNNEL\" tunnel type for TightVNC\n\nPreviously, tight auth was supported without any support for tunnels,\neven the no-op tunnel.  No, the no-op tunnel type is supported.","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/95eb681bbb609c1fe6a7dace694afa6ed00cf4d3"},{"sha":"f8e9b9f1bf45c84deb0d9d939f9a2ac809afa187","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Cleanup and Test: base64.js\n\nThis is the first commit in a series of commits\nwhich improve the readability of some of the code\nand add tests.\n\nFile: base64.js\nTests Added: True\nChanges:\n- Improved indentation\n- Fixed JSHint errors\n- Moved loop variables to be declared in the loop for better readability\n  (N.B. Javascript does not have block scoping, so the variables are\n  still technically available outside the loop -- it just makes the code\n  clearer to place them inside the loop, since they are only used there)","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/f8e9b9f1bf45c84deb0d9d939f9a2ac809afa187"},{"sha":"fb64ed213584423475a262631b6be2e2a157c628","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Cleanup: DES code\n\nFile: des.js\nTests Added: False\nChanges:\n- Fixed JSHint Errors\n- Improved whitespace around operators","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/fb64ed213584423475a262631b6be2e2a157c628"},{"sha":"d21cd6c16453eec8ec4b218dff6dffecf55aa518","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Cleanup: Util code\n\nFile: util.js\nTests Added: True (partial -- for logging and array push methods)\nChanges:\n- Fixed JSHint Errors (indentation, semicolons, global \"use strict\")\n- Made browser detection methods more readable\n- added some newline characters when appropriate for readability\n- throw Errors not strings!\n- Removed conf_defaults, and added make_properties and set_defaults\n  instead (see below)\n\nThe removal of conf_defaults and switch to make_properties and\nset_defaults is to facilitate the switch over to normal Javascript\nconstructors instead of Crockford-style constructors.  Now, methods\nare added to the objects prototype (and thus make properties is called\noutside the constructor).","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/d21cd6c16453eec8ec4b218dff6dffecf55aa518"},{"sha":"d6e281baf66b6aa59e54ea0e1c775b46f9698af2","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Cleanup: Input code\n\nFile: input.js\nTests Added: False (already present partially -- see below)\nChanges:\n- Fixed JSHint Errors\n- Converted to normal non-Crockford constructors\n\nNOTE: while there are tests for the actual key-detecting functionality,\n      the tests do not cover the actual Keyboard and Mouse objects\n      themselves.","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/d6e281baf66b6aa59e54ea0e1c775b46f9698af2"},{"sha":"31f169e86fe7b8065c5e1406ed2885549920e822","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Cleanup: Keyboard code\n\nFile: keyboard.js\nTests Added: False (already present)\nChanges:\n- Fixed JSHint Errors\n- Moved functions outside loops\n- Added proper include directives to tests","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/31f169e86fe7b8065c5e1406ed2885549920e822"},{"sha":"ee7d4c61c6c2b39bc257d9fc1c20d2b2a479d370","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Cleanup: Webutil code\n\nFile: webutil.js\nTests Added: False\nChanges:\n- Fixed JSHint Errors (global \"use strict\", spaces)\n- added some newline characters when appropriate for readability\n- moved variable declarations to the places they were actually used\n  for readability","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/ee7d4c61c6c2b39bc257d9fc1c20d2b2a479d370"},{"sha":"2cccf7530c272de3627fa871da8e6ed44f437edb","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Cleanup: WebSocket Helper\n\nFile: websock.js\nTests Added: True\nChanges:\n- Cleaned up JSHint errors\n- Converted to normal JS constructor pattern with \"private\" fields and\n  methods now simply being prepended by underscores\n- Added a \"bind\" polyfill for use in PhantomJS 1.x in util.js\n- Added FakeWebSocket to fill in for actual WebSocket objects when\n  testing\n- Made exception handler actually log exception name and message,\n  to console, in addition to stack trace","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/2cccf7530c272de3627fa871da8e6ed44f437edb"},{"sha":"1e13775bd5e37173b6c8a814811ea7f16e56f892","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Cleanup: Display Helper\n\nFile: display.js\nTests Added: True (preliminary)\n\nChanges:\n- De-crockford-ified the file\n\nNOTE: the tests included for display.js cover basic functionality, but\nare by no means nearly as comprehensive as the ones presented for\nrfb.js.","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/1e13775bd5e37173b6c8a814811ea7f16e56f892"},{"sha":"b1dee9478815b22bf5fee3ee9e44321d4bb46c91","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Cleanup: RFB Client\n\nFile: rfb.js (also websock.js)\nTests Added: True\n\nChanges:\n- De-Crockford-ified rfb.js\n- Added methods to websock.js to skip bytes in the receive queue","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/b1dee9478815b22bf5fee3ee9e44321d4bb46c91"},{"sha":"bbbf42bb5a70cddd44d5d1f2ec1c6ae9156034bb","author":{"name":"Solly Ross","email":"d3757af8134238877a1f52c1f32f200b7d98e8cb@redhat.com"},"message":"Cleanup: UI code\n\nFile: ui.js\nTests Added: False\n\nChanges:\n- Fix JSHint errors\n- add some curly braces to improve clarity\n- move variable declarations to relevant locations instead of at the top\n  of methods","distinct":false,"url":"https://api.github.com/repos/kosmasgiannis/noVNC/commits/bbbf42bb5a70cddd44d5d1f2ec1c6ae9156034bb"}]}
{"actor":{"display_login":"kosmasgiannis"}}