{"action":"created","comment":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/comments/67623811","id":67623811,"diff_hunk":"@@ -106,8 +106,11 @@ message TaskSpec {\n \t\tContainerSpec container = 1;\n \t}\n \n+\t// ContainerHostConfigSpec specifies hostconfig for container.\n+\tContainerHostConfigSpec hostconfig = 2;","path":"api/specs.proto","position":5,"original_position":5,"commit_id":"64ab4bbdca016211476a5b1330f3ef78cfd995b6","original_commit_id":"64ab4bbdca016211476a5b1330f3ef78cfd995b6","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"This breaks the data model. Container related configuration should be part of `ContainerSpec`.","created_at":"2016-06-19T21:03:22Z","updated_at":"2016-06-19T21:03:22Z","html_url":"https://github.com/docker/swarmkit/pull/1026#discussion_r67623811","pull_request_url":"https://api.github.com/repos/docker/swarmkit/pulls/1026","_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments/67623811"},"html":{"href":"https://github.com/docker/swarmkit/pull/1026#discussion_r67623811"},"pull_request":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1026"}}},"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/1026","id":74360481,"html_url":"https://github.com/docker/swarmkit/pull/1026","diff_url":"https://github.com/docker/swarmkit/pull/1026.diff","patch_url":"https://github.com/docker/swarmkit/pull/1026.patch","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/1026","number":1026,"state":"open","locked":false,"title":"Add support log driver for container","user":{"login":"jimmyxian","id":3146645,"avatar_url":"https://avatars.githubusercontent.com/u/3146645?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmyxian","html_url":"https://github.com/jimmyxian","followers_url":"https://api.github.com/users/jimmyxian/followers","following_url":"https://api.github.com/users/jimmyxian/following{/other_user}","gists_url":"https://api.github.com/users/jimmyxian/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyxian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyxian/subscriptions","organizations_url":"https://api.github.com/users/jimmyxian/orgs","repos_url":"https://api.github.com/users/jimmyxian/repos","events_url":"https://api.github.com/users/jimmyxian/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyxian/received_events","type":"User","site_admin":false},"body":"Implement: https://github.com/docker/swarmkit/issues/964\r\nDo the following thing:\r\n* Add ContainerHostConfigSpec in proto\r\n* Support log-driver for service\r\n\r\n\r\nSigned-off-by: Xian Chaobo <xianchaobo@huawei.com>","created_at":"2016-06-19T10:50:04Z","updated_at":"2016-06-19T21:03:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e1bf1a19fc43310432a8cdc65de81e91c0805ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarmkit/pulls/1026/commits","review_comments_url":"https://api.github.com/repos/docker/swarmkit/pulls/1026/comments","review_comment_url":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/1026/comments","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/64ab4bbdca016211476a5b1330f3ef78cfd995b6","head":{"label":"jimmyxian:add-support-log-driver","ref":"add-support-log-driver","sha":"64ab4bbdca016211476a5b1330f3ef78cfd995b6","user":{"login":"jimmyxian","id":3146645,"avatar_url":"https://avatars.githubusercontent.com/u/3146645?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmyxian","html_url":"https://github.com/jimmyxian","followers_url":"https://api.github.com/users/jimmyxian/followers","following_url":"https://api.github.com/users/jimmyxian/following{/other_user}","gists_url":"https://api.github.com/users/jimmyxian/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyxian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyxian/subscriptions","organizations_url":"https://api.github.com/users/jimmyxian/orgs","repos_url":"https://api.github.com/users/jimmyxian/repos","events_url":"https://api.github.com/users/jimmyxian/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyxian/received_events","type":"User","site_admin":false},"repo":{"id":60820569,"name":"swarmkit","full_name":"jimmyxian/swarmkit","owner":{"login":"jimmyxian","id":3146645,"avatar_url":"https://avatars.githubusercontent.com/u/3146645?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmyxian","html_url":"https://github.com/jimmyxian","followers_url":"https://api.github.com/users/jimmyxian/followers","following_url":"https://api.github.com/users/jimmyxian/following{/other_user}","gists_url":"https://api.github.com/users/jimmyxian/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyxian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyxian/subscriptions","organizations_url":"https://api.github.com/users/jimmyxian/orgs","repos_url":"https://api.github.com/users/jimmyxian/repos","events_url":"https://api.github.com/users/jimmyxian/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyxian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimmyxian/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":true,"url":"https://api.github.com/repos/jimmyxian/swarmkit","forks_url":"https://api.github.com/repos/jimmyxian/swarmkit/forks","keys_url":"https://api.github.com/repos/jimmyxian/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimmyxian/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimmyxian/swarmkit/teams","hooks_url":"https://api.github.com/repos/jimmyxian/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/jimmyxian/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/jimmyxian/swarmkit/events","assignees_url":"https://api.github.com/repos/jimmyxian/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/jimmyxian/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/jimmyxian/swarmkit/tags","blobs_url":"https://api.github.com/repos/jimmyxian/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimmyxian/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimmyxian/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimmyxian/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimmyxian/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/jimmyxian/swarmkit/languages","stargazers_url":"https://api.github.com/repos/jimmyxian/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/jimmyxian/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/jimmyxian/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/jimmyxian/swarmkit/subscription","commits_url":"https://api.github.com/repos/jimmyxian/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimmyxian/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimmyxian/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimmyxian/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimmyxian/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/jimmyxian/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimmyxian/swarmkit/merges","archive_url":"https://api.github.com/repos/jimmyxian/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimmyxian/swarmkit/downloads","issues_url":"https://api.github.com/repos/jimmyxian/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/jimmyxian/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/jimmyxian/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/jimmyxian/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimmyxian/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/jimmyxian/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/jimmyxian/swarmkit/deployments","created_at":"2016-06-10T02:50:24Z","updated_at":"2016-06-10T02:50:25Z","pushed_at":"2016-06-19T11:01:41Z","git_url":"git://github.com/jimmyxian/swarmkit.git","ssh_url":"git@github.com:jimmyxian/swarmkit.git","clone_url":"https://github.com/jimmyxian/swarmkit.git","svn_url":"https://github.com/jimmyxian/swarmkit","homepage":"","size":7823,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"b93f47e10eadc54eae9414712051ed8e24a0f0fc","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":51556828,"name":"swarmkit","full_name":"docker/swarmkit","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":false,"url":"https://api.github.com/repos/docker/swarmkit","forks_url":"https://api.github.com/repos/docker/swarmkit/forks","keys_url":"https://api.github.com/repos/docker/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarmkit/teams","hooks_url":"https://api.github.com/repos/docker/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/docker/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarmkit/events","assignees_url":"https://api.github.com/repos/docker/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarmkit/tags","blobs_url":"https://api.github.com/repos/docker/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarmkit/languages","stargazers_url":"https://api.github.com/repos/docker/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/docker/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/docker/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/docker/swarmkit/subscription","commits_url":"https://api.github.com/repos/docker/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarmkit/merges","archive_url":"https://api.github.com/repos/docker/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarmkit/downloads","issues_url":"https://api.github.com/repos/docker/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/docker/swarmkit/deployments","created_at":"2016-02-12T00:02:15Z","updated_at":"2016-06-19T17:42:25Z","pushed_at":"2016-06-19T11:01:41Z","git_url":"git://github.com/docker/swarmkit.git","ssh_url":"git@github.com:docker/swarmkit.git","clone_url":"https://github.com/docker/swarmkit.git","svn_url":"https://github.com/docker/swarmkit","homepage":"","size":17653,"stargazers_count":656,"watchers_count":656,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":124,"forks":81,"open_issues":124,"watchers":656,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1026"},"html":{"href":"https://github.com/docker/swarmkit/pull/1026"},"issue":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1026"},"comments":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1026/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1026/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1026/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarmkit/statuses/64ab4bbdca016211476a5b1330f3ef78cfd995b6"}}}}
{"actor":{"display_login":"stevvooe"}}