{"action":"created","issue":{"url":"https://api.github.com/repos/potteryhouse/stock_by_attribute_1.5.3/issues/16","repository_url":"https://api.github.com/repos/potteryhouse/stock_by_attribute_1.5.3","labels_url":"https://api.github.com/repos/potteryhouse/stock_by_attribute_1.5.3/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/potteryhouse/stock_by_attribute_1.5.3/issues/16/comments","events_url":"https://api.github.com/repos/potteryhouse/stock_by_attribute_1.5.3/issues/16/events","html_url":"https://github.com/potteryhouse/stock_by_attribute_1.5.3/issues/16","id":49042517,"number":16,"title":"Breadth of application of customID","user":{"login":"mc12345678","id":2072812,"avatar_url":"https://avatars.githubusercontent.com/u/2072812?v=3","gravatar_id":"","url":"https://api.github.com/users/mc12345678","html_url":"https://github.com/mc12345678","followers_url":"https://api.github.com/users/mc12345678/followers","following_url":"https://api.github.com/users/mc12345678/following{/other_user}","gists_url":"https://api.github.com/users/mc12345678/gists{/gist_id}","starred_url":"https://api.github.com/users/mc12345678/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mc12345678/subscriptions","organizations_url":"https://api.github.com/users/mc12345678/orgs","repos_url":"https://api.github.com/users/mc12345678/repos","events_url":"https://api.github.com/users/mc12345678/events{/privacy}","received_events_url":"https://api.github.com/users/mc12345678/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/potteryhouse/stock_by_attribute_1.5.3/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/potteryhouse/stock_by_attribute_1.5.3/labels/question","name":"question","color":"cc317c"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2014-11-17T05:46:10Z","updated_at":"2016-07-12T13:49:11Z","closed_at":"2016-07-12T13:49:11Z","body":"Have found a way to pretty much remove SBA from the includes/classes/order.php file to use the notify system; however, there are two parts remaining to address. The one of \"most\" significance at this point is the customID.  The reason this one is most difficult to address is that in all of the uses of the $this->products[$i]['model'] variable, there is only one location that the variable is substituted for the $customid and that point is products_ordered_html which is used to generate the html email.\r\n\r\nBut it is not used or substituted in low stock emails, product order history, or products_ordered (and therefore not in standard emails, but in html emails because of the inclusion in products_ordered_html.\r\n\r\nSeems appropriate to include/incorporate the information into the regular/non-html emails; however, what about in the low stock emails and the tracked order history?  Currently the method of substitution is if there is a customId then use the customid, otherwise use the model# (whether there or not)... So, the thought is if the customid is to replace all of the above, then it can be done with a relatively simple piece of code, then the last thing to work out in the order.php file above is generating the low-stock e-mail information that is applicable to attributes.\r\n\r\nIn the end if that can happen there are a total of three changes to be made to the includes/classes/order.php file to support SBA via notify/observer action.  Would require adding one more variable declaration to capture the $order_products_attributes_id, a modification in the notifier just below it to pass it to the observer and one other notifier modification to pass the attribute stock to and from unless that variable can remain outside of order.php file and stay only inside the observer (supports the low stock email for a tracked attribute)...  \r\n\r\nSo, question is, what is the objection to logging in the order history to use the customid if assigned or the model# if no customid?"},"comment":{"url":"https://api.github.com/repos/potteryhouse/stock_by_attribute_1.5.3/issues/comments/232052797","html_url":"https://github.com/potteryhouse/stock_by_attribute_1.5.3/issues/16#issuecomment-232052797","issue_url":"https://api.github.com/repos/potteryhouse/stock_by_attribute_1.5.3/issues/16","id":232052797,"user":{"login":"mc12345678","id":2072812,"avatar_url":"https://avatars.githubusercontent.com/u/2072812?v=3","gravatar_id":"","url":"https://api.github.com/users/mc12345678","html_url":"https://github.com/mc12345678","followers_url":"https://api.github.com/users/mc12345678/followers","following_url":"https://api.github.com/users/mc12345678/following{/other_user}","gists_url":"https://api.github.com/users/mc12345678/gists{/gist_id}","starred_url":"https://api.github.com/users/mc12345678/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mc12345678/subscriptions","organizations_url":"https://api.github.com/users/mc12345678/orgs","repos_url":"https://api.github.com/users/mc12345678/repos","events_url":"https://api.github.com/users/mc12345678/events{/privacy}","received_events_url":"https://api.github.com/users/mc12345678/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T13:49:11Z","updated_at":"2016-07-12T13:49:11Z","body":"This issue has effectively been answered through a myriad of other routes and discussions.  In ZC 1.5.5, there are no edits made to the includes/classes/order.php because of modifications that have been made to the core code, so all of the above is sufficiently addressed through that.  Regarding the use of the customID, there remains further work/modification to use it to its full potential, between retrieving the stored version of the customID from the order history instead of the live product to how to apply the customID(s) that could exist for a product based on ones desire of how/what to present.\r\n\r\nThat said, this issue is effectively closed.  Latest code can be found at: https://github.com/mc12345678/Stock_By_Attributes_Combined"}}
{"actor":{"display_login":"mc12345678"}}