{"action":"created","comment":{"url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/comments/88425426","pull_request_review_id":8997682,"id":88425426,"diff_hunk":"@@ -280,7 +280,10 @@ protected function isDynamicallyFiltered() {\n     protected function renderDynamicFilters() {\n         if($this->mode != 'xhtml') return;\n         if(!$this->data['dynfilters']) return;\n-        global $conf;\n+        global $conf, $ACT;\n+        if ($ACT == 'export_pdf') {","path":"meta/AggregationTable.php","position":null,"original_position":6,"commit_id":"1bc467a4cb65e8406384a12611de872a6da0b637","original_commit_id":"e6ae02ec4730e92300c3064ff02fd884c81f4e73","user":{"login":"micgro42","id":7372507,"avatar_url":"https://avatars.githubusercontent.com/u/7372507?v=3","gravatar_id":"","url":"https://api.github.com/users/micgro42","html_url":"https://github.com/micgro42","followers_url":"https://api.github.com/users/micgro42/followers","following_url":"https://api.github.com/users/micgro42/following{/other_user}","gists_url":"https://api.github.com/users/micgro42/gists{/gist_id}","starred_url":"https://api.github.com/users/micgro42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micgro42/subscriptions","organizations_url":"https://api.github.com/users/micgro42/orgs","repos_url":"https://api.github.com/users/micgro42/repos","events_url":"https://api.github.com/users/micgro42/events{/privacy}","received_events_url":"https://api.github.com/users/micgro42/received_events","type":"User","site_admin":false},"body":"And it's a cleaner solution ✔️","created_at":"2016-11-17T10:29:53Z","updated_at":"2016-11-17T10:29:53Z","html_url":"https://github.com/cosmocode/dokuwiki-plugin-struct/pull/213#discussion_r88425426","pull_request_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/comments/88425426"},"html":{"href":"https://github.com/cosmocode/dokuwiki-plugin-struct/pull/213#discussion_r88425426"},"pull_request":{"href":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/213","id":93790674,"html_url":"https://github.com/cosmocode/dokuwiki-plugin-struct/pull/213","diff_url":"https://github.com/cosmocode/dokuwiki-plugin-struct/pull/213.diff","patch_url":"https://github.com/cosmocode/dokuwiki-plugin-struct/pull/213.patch","issue_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/issues/213","number":213,"state":"open","locked":false,"title":"Fix: Do not render dynamic filters on pdf export","user":{"login":"micgro42","id":7372507,"avatar_url":"https://avatars.githubusercontent.com/u/7372507?v=3","gravatar_id":"","url":"https://api.github.com/users/micgro42","html_url":"https://github.com/micgro42","followers_url":"https://api.github.com/users/micgro42/followers","following_url":"https://api.github.com/users/micgro42/following{/other_user}","gists_url":"https://api.github.com/users/micgro42/gists{/gist_id}","starred_url":"https://api.github.com/users/micgro42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micgro42/subscriptions","organizations_url":"https://api.github.com/users/micgro42/orgs","repos_url":"https://api.github.com/users/micgro42/repos","events_url":"https://api.github.com/users/micgro42/events{/privacy}","received_events_url":"https://api.github.com/users/micgro42/received_events","type":"User","site_admin":false},"body":"Do not render the dynamic filters, because mpdf 6, which creates the pdf, is unable to parse `display: none` neither on the `tr` nor on the `th` or `td` tags and hence removing those filters with CSS doesn't work.\r\nThis might improve with mpdf 7.\r\n\r\nThis fixes #169 and fixes SPR-689","created_at":"2016-11-15T15:47:29Z","updated_at":"2016-11-17T10:29:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e46906649ff6ba88385d5ecddfb28fc0b02d2e0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/213/commits","review_comments_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/213/comments","review_comment_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/issues/213/comments","statuses_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/statuses/1bc467a4cb65e8406384a12611de872a6da0b637","head":{"label":"cosmocode:feature/hideDynFiltersExport","ref":"feature/hideDynFiltersExport","sha":"1bc467a4cb65e8406384a12611de872a6da0b637","user":{"login":"cosmocode","id":68587,"avatar_url":"https://avatars.githubusercontent.com/u/68587?v=3","gravatar_id":"","url":"https://api.github.com/users/cosmocode","html_url":"https://github.com/cosmocode","followers_url":"https://api.github.com/users/cosmocode/followers","following_url":"https://api.github.com/users/cosmocode/following{/other_user}","gists_url":"https://api.github.com/users/cosmocode/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmocode/subscriptions","organizations_url":"https://api.github.com/users/cosmocode/orgs","repos_url":"https://api.github.com/users/cosmocode/repos","events_url":"https://api.github.com/users/cosmocode/events{/privacy}","received_events_url":"https://api.github.com/users/cosmocode/received_events","type":"Organization","site_admin":false},"repo":{"id":48178744,"name":"dokuwiki-plugin-struct","full_name":"cosmocode/dokuwiki-plugin-struct","owner":{"login":"cosmocode","id":68587,"avatar_url":"https://avatars.githubusercontent.com/u/68587?v=3","gravatar_id":"","url":"https://api.github.com/users/cosmocode","html_url":"https://github.com/cosmocode","followers_url":"https://api.github.com/users/cosmocode/followers","following_url":"https://api.github.com/users/cosmocode/following{/other_user}","gists_url":"https://api.github.com/users/cosmocode/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmocode/subscriptions","organizations_url":"https://api.github.com/users/cosmocode/orgs","repos_url":"https://api.github.com/users/cosmocode/repos","events_url":"https://api.github.com/users/cosmocode/events{/privacy}","received_events_url":"https://api.github.com/users/cosmocode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cosmocode/dokuwiki-plugin-struct","description":"A new structured data plugin","fork":false,"url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct","forks_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/forks","keys_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/teams","hooks_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/hooks","issue_events_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/issues/events{/number}","events_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/events","assignees_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/assignees{/user}","branches_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/branches{/branch}","tags_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/tags","blobs_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/languages","stargazers_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/stargazers","contributors_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/contributors","subscribers_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/subscribers","subscription_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/subscription","commits_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/contents/{+path}","compare_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/merges","archive_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/downloads","issues_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/issues{/number}","pulls_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/labels{/name}","releases_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/releases{/id}","deployments_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/deployments","created_at":"2015-12-17T14:25:12Z","updated_at":"2016-11-01T09:18:08Z","pushed_at":"2016-11-17T10:29:39Z","git_url":"git://github.com/cosmocode/dokuwiki-plugin-struct.git","ssh_url":"git@github.com:cosmocode/dokuwiki-plugin-struct.git","clone_url":"https://github.com/cosmocode/dokuwiki-plugin-struct.git","svn_url":"https://github.com/cosmocode/dokuwiki-plugin-struct","homepage":"https://www.dokuwiki.org/plugin:struct","size":781,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":19,"forks":4,"open_issues":19,"watchers":8,"default_branch":"master"}},"base":{"label":"cosmocode:master","ref":"master","sha":"a7cffaf2716ff9900177014666b5e4bddc576210","user":{"login":"cosmocode","id":68587,"avatar_url":"https://avatars.githubusercontent.com/u/68587?v=3","gravatar_id":"","url":"https://api.github.com/users/cosmocode","html_url":"https://github.com/cosmocode","followers_url":"https://api.github.com/users/cosmocode/followers","following_url":"https://api.github.com/users/cosmocode/following{/other_user}","gists_url":"https://api.github.com/users/cosmocode/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmocode/subscriptions","organizations_url":"https://api.github.com/users/cosmocode/orgs","repos_url":"https://api.github.com/users/cosmocode/repos","events_url":"https://api.github.com/users/cosmocode/events{/privacy}","received_events_url":"https://api.github.com/users/cosmocode/received_events","type":"Organization","site_admin":false},"repo":{"id":48178744,"name":"dokuwiki-plugin-struct","full_name":"cosmocode/dokuwiki-plugin-struct","owner":{"login":"cosmocode","id":68587,"avatar_url":"https://avatars.githubusercontent.com/u/68587?v=3","gravatar_id":"","url":"https://api.github.com/users/cosmocode","html_url":"https://github.com/cosmocode","followers_url":"https://api.github.com/users/cosmocode/followers","following_url":"https://api.github.com/users/cosmocode/following{/other_user}","gists_url":"https://api.github.com/users/cosmocode/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmocode/subscriptions","organizations_url":"https://api.github.com/users/cosmocode/orgs","repos_url":"https://api.github.com/users/cosmocode/repos","events_url":"https://api.github.com/users/cosmocode/events{/privacy}","received_events_url":"https://api.github.com/users/cosmocode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cosmocode/dokuwiki-plugin-struct","description":"A new structured data plugin","fork":false,"url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct","forks_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/forks","keys_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/teams","hooks_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/hooks","issue_events_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/issues/events{/number}","events_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/events","assignees_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/assignees{/user}","branches_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/branches{/branch}","tags_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/tags","blobs_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/languages","stargazers_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/stargazers","contributors_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/contributors","subscribers_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/subscribers","subscription_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/subscription","commits_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/contents/{+path}","compare_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/merges","archive_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/downloads","issues_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/issues{/number}","pulls_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/labels{/name}","releases_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/releases{/id}","deployments_url":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/deployments","created_at":"2015-12-17T14:25:12Z","updated_at":"2016-11-01T09:18:08Z","pushed_at":"2016-11-17T10:29:39Z","git_url":"git://github.com/cosmocode/dokuwiki-plugin-struct.git","ssh_url":"git@github.com:cosmocode/dokuwiki-plugin-struct.git","clone_url":"https://github.com/cosmocode/dokuwiki-plugin-struct.git","svn_url":"https://github.com/cosmocode/dokuwiki-plugin-struct","homepage":"https://www.dokuwiki.org/plugin:struct","size":781,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":19,"forks":4,"open_issues":19,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/213"},"html":{"href":"https://github.com/cosmocode/dokuwiki-plugin-struct/pull/213"},"issue":{"href":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/issues/213"},"comments":{"href":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/cosmocode/dokuwiki-plugin-struct/statuses/1bc467a4cb65e8406384a12611de872a6da0b637"}}}}
{"actor":{"display_login":"micgro42"}}