{"action":"created","comment":{"url":"https://api.github.com/repos/eedevops/shipyard/pulls/comments/67977901","id":67977901,"diff_hunk":"@@ -97,18 +98,20 @@ func (m DefaultManager) CreateAllBuilds(projectId string, WsEmmitter *emitter.Em\n \tgo func(project *model.Project) {\n \t\tsync := make(chan string)\n \n+\t\tprojectStatus := model.BuildStatusFinishedSuccess\n \t\tfor _, test := range project.Tests {\n \t\t\tm.CreateBuild(projectId, test.ID, model.NewBuildAction(model.BuildStartActionLabel), sync)\n-\t\t\t<-sync\n+\t\t\tif <-sync == model.BuildStatusFinishedFailed {\n+\t\t\t\tprojectStatus = model.BuildStatusFinishedFailed","path":"controller/manager/ilm_builds.go","position":17,"original_position":17,"commit_id":"6f4dd72aa50bdb276acaa0e398fa6a45db65679f","original_commit_id":"6f4dd72aa50bdb276acaa0e398fa6a45db65679f","user":{"login":"rqc","id":89690,"avatar_url":"https://avatars.githubusercontent.com/u/89690?v=3","gravatar_id":"","url":"https://api.github.com/users/rqc","html_url":"https://github.com/rqc","followers_url":"https://api.github.com/users/rqc/followers","following_url":"https://api.github.com/users/rqc/following{/other_user}","gists_url":"https://api.github.com/users/rqc/gists{/gist_id}","starred_url":"https://api.github.com/users/rqc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rqc/subscriptions","organizations_url":"https://api.github.com/users/rqc/orgs","repos_url":"https://api.github.com/users/rqc/repos","events_url":"https://api.github.com/users/rqc/events{/privacy}","received_events_url":"https://api.github.com/users/rqc/received_events","type":"User","site_admin":false},"body":"wouldn't this `projectStatus` be overridden by the last build status incoming from the `sync` channel? I think it should be set the `model.BuildStatusFinishedLabel` when at least one of them has failed. ","created_at":"2016-06-22T00:40:20Z","updated_at":"2016-06-22T00:40:20Z","html_url":"https://github.com/eedevops/shipyard/pull/155#discussion_r67977901","pull_request_url":"https://api.github.com/repos/eedevops/shipyard/pulls/155","_links":{"self":{"href":"https://api.github.com/repos/eedevops/shipyard/pulls/comments/67977901"},"html":{"href":"https://github.com/eedevops/shipyard/pull/155#discussion_r67977901"},"pull_request":{"href":"https://api.github.com/repos/eedevops/shipyard/pulls/155"}}},"pull_request":{"url":"https://api.github.com/repos/eedevops/shipyard/pulls/155","id":74688701,"html_url":"https://github.com/eedevops/shipyard/pull/155","diff_url":"https://github.com/eedevops/shipyard/pull/155.diff","patch_url":"https://github.com/eedevops/shipyard/pull/155.patch","issue_url":"https://api.github.com/repos/eedevops/shipyard/issues/155","number":155,"state":"open","locked":false,"title":"- Added the concept of build statuses to projects","user":{"login":"JonathanRosado","id":12142156,"avatar_url":"https://avatars.githubusercontent.com/u/12142156?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanRosado","html_url":"https://github.com/JonathanRosado","followers_url":"https://api.github.com/users/JonathanRosado/followers","following_url":"https://api.github.com/users/JonathanRosado/following{/other_user}","gists_url":"https://api.github.com/users/JonathanRosado/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanRosado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanRosado/subscriptions","organizations_url":"https://api.github.com/users/JonathanRosado/orgs","repos_url":"https://api.github.com/users/JonathanRosado/repos","events_url":"https://api.github.com/users/JonathanRosado/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanRosado/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-21T21:27:20Z","updated_at":"2016-06-22T00:40:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07011b823c7b4ff2c2eea3ae3e57f073d5ad6399","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eedevops/shipyard/pulls/155/commits","review_comments_url":"https://api.github.com/repos/eedevops/shipyard/pulls/155/comments","review_comment_url":"https://api.github.com/repos/eedevops/shipyard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eedevops/shipyard/issues/155/comments","statuses_url":"https://api.github.com/repos/eedevops/shipyard/statuses/6f4dd72aa50bdb276acaa0e398fa6a45db65679f","head":{"label":"eedevops:fix/project-status-UI","ref":"fix/project-status-UI","sha":"6f4dd72aa50bdb276acaa0e398fa6a45db65679f","user":{"login":"eedevops","id":16719882,"avatar_url":"https://avatars.githubusercontent.com/u/16719882?v=3","gravatar_id":"","url":"https://api.github.com/users/eedevops","html_url":"https://github.com/eedevops","followers_url":"https://api.github.com/users/eedevops/followers","following_url":"https://api.github.com/users/eedevops/following{/other_user}","gists_url":"https://api.github.com/users/eedevops/gists{/gist_id}","starred_url":"https://api.github.com/users/eedevops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eedevops/subscriptions","organizations_url":"https://api.github.com/users/eedevops/orgs","repos_url":"https://api.github.com/users/eedevops/repos","events_url":"https://api.github.com/users/eedevops/events{/privacy}","received_events_url":"https://api.github.com/users/eedevops/received_events","type":"Organization","site_admin":false},"repo":{"id":49720572,"name":"shipyard","full_name":"eedevops/shipyard","owner":{"login":"eedevops","id":16719882,"avatar_url":"https://avatars.githubusercontent.com/u/16719882?v=3","gravatar_id":"","url":"https://api.github.com/users/eedevops","html_url":"https://github.com/eedevops","followers_url":"https://api.github.com/users/eedevops/followers","following_url":"https://api.github.com/users/eedevops/following{/other_user}","gists_url":"https://api.github.com/users/eedevops/gists{/gist_id}","starred_url":"https://api.github.com/users/eedevops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eedevops/subscriptions","organizations_url":"https://api.github.com/users/eedevops/orgs","repos_url":"https://api.github.com/users/eedevops/repos","events_url":"https://api.github.com/users/eedevops/events{/privacy}","received_events_url":"https://api.github.com/users/eedevops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eedevops/shipyard","description":"Composable Docker Management","fork":true,"url":"https://api.github.com/repos/eedevops/shipyard","forks_url":"https://api.github.com/repos/eedevops/shipyard/forks","keys_url":"https://api.github.com/repos/eedevops/shipyard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eedevops/shipyard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eedevops/shipyard/teams","hooks_url":"https://api.github.com/repos/eedevops/shipyard/hooks","issue_events_url":"https://api.github.com/repos/eedevops/shipyard/issues/events{/number}","events_url":"https://api.github.com/repos/eedevops/shipyard/events","assignees_url":"https://api.github.com/repos/eedevops/shipyard/assignees{/user}","branches_url":"https://api.github.com/repos/eedevops/shipyard/branches{/branch}","tags_url":"https://api.github.com/repos/eedevops/shipyard/tags","blobs_url":"https://api.github.com/repos/eedevops/shipyard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eedevops/shipyard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eedevops/shipyard/git/refs{/sha}","trees_url":"https://api.github.com/repos/eedevops/shipyard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eedevops/shipyard/statuses/{sha}","languages_url":"https://api.github.com/repos/eedevops/shipyard/languages","stargazers_url":"https://api.github.com/repos/eedevops/shipyard/stargazers","contributors_url":"https://api.github.com/repos/eedevops/shipyard/contributors","subscribers_url":"https://api.github.com/repos/eedevops/shipyard/subscribers","subscription_url":"https://api.github.com/repos/eedevops/shipyard/subscription","commits_url":"https://api.github.com/repos/eedevops/shipyard/commits{/sha}","git_commits_url":"https://api.github.com/repos/eedevops/shipyard/git/commits{/sha}","comments_url":"https://api.github.com/repos/eedevops/shipyard/comments{/number}","issue_comment_url":"https://api.github.com/repos/eedevops/shipyard/issues/comments{/number}","contents_url":"https://api.github.com/repos/eedevops/shipyard/contents/{+path}","compare_url":"https://api.github.com/repos/eedevops/shipyard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eedevops/shipyard/merges","archive_url":"https://api.github.com/repos/eedevops/shipyard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eedevops/shipyard/downloads","issues_url":"https://api.github.com/repos/eedevops/shipyard/issues{/number}","pulls_url":"https://api.github.com/repos/eedevops/shipyard/pulls{/number}","milestones_url":"https://api.github.com/repos/eedevops/shipyard/milestones{/number}","notifications_url":"https://api.github.com/repos/eedevops/shipyard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eedevops/shipyard/labels{/name}","releases_url":"https://api.github.com/repos/eedevops/shipyard/releases{/id}","deployments_url":"https://api.github.com/repos/eedevops/shipyard/deployments","created_at":"2016-01-15T13:33:34Z","updated_at":"2016-06-21T14:36:12Z","pushed_at":"2016-06-21T21:27:20Z","git_url":"git://github.com/eedevops/shipyard.git","ssh_url":"git@github.com:eedevops/shipyard.git","clone_url":"https://github.com/eedevops/shipyard.git","svn_url":"https://github.com/eedevops/shipyard","homepage":"http://shipyard-project.com","size":27834,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":15,"forks":5,"open_issues":15,"watchers":2,"default_branch":"master"}},"base":{"label":"eedevops:dev","ref":"dev","sha":"2ee928df9063d689fe3bef2e0f577161a8286c41","user":{"login":"eedevops","id":16719882,"avatar_url":"https://avatars.githubusercontent.com/u/16719882?v=3","gravatar_id":"","url":"https://api.github.com/users/eedevops","html_url":"https://github.com/eedevops","followers_url":"https://api.github.com/users/eedevops/followers","following_url":"https://api.github.com/users/eedevops/following{/other_user}","gists_url":"https://api.github.com/users/eedevops/gists{/gist_id}","starred_url":"https://api.github.com/users/eedevops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eedevops/subscriptions","organizations_url":"https://api.github.com/users/eedevops/orgs","repos_url":"https://api.github.com/users/eedevops/repos","events_url":"https://api.github.com/users/eedevops/events{/privacy}","received_events_url":"https://api.github.com/users/eedevops/received_events","type":"Organization","site_admin":false},"repo":{"id":49720572,"name":"shipyard","full_name":"eedevops/shipyard","owner":{"login":"eedevops","id":16719882,"avatar_url":"https://avatars.githubusercontent.com/u/16719882?v=3","gravatar_id":"","url":"https://api.github.com/users/eedevops","html_url":"https://github.com/eedevops","followers_url":"https://api.github.com/users/eedevops/followers","following_url":"https://api.github.com/users/eedevops/following{/other_user}","gists_url":"https://api.github.com/users/eedevops/gists{/gist_id}","starred_url":"https://api.github.com/users/eedevops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eedevops/subscriptions","organizations_url":"https://api.github.com/users/eedevops/orgs","repos_url":"https://api.github.com/users/eedevops/repos","events_url":"https://api.github.com/users/eedevops/events{/privacy}","received_events_url":"https://api.github.com/users/eedevops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eedevops/shipyard","description":"Composable Docker Management","fork":true,"url":"https://api.github.com/repos/eedevops/shipyard","forks_url":"https://api.github.com/repos/eedevops/shipyard/forks","keys_url":"https://api.github.com/repos/eedevops/shipyard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eedevops/shipyard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eedevops/shipyard/teams","hooks_url":"https://api.github.com/repos/eedevops/shipyard/hooks","issue_events_url":"https://api.github.com/repos/eedevops/shipyard/issues/events{/number}","events_url":"https://api.github.com/repos/eedevops/shipyard/events","assignees_url":"https://api.github.com/repos/eedevops/shipyard/assignees{/user}","branches_url":"https://api.github.com/repos/eedevops/shipyard/branches{/branch}","tags_url":"https://api.github.com/repos/eedevops/shipyard/tags","blobs_url":"https://api.github.com/repos/eedevops/shipyard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eedevops/shipyard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eedevops/shipyard/git/refs{/sha}","trees_url":"https://api.github.com/repos/eedevops/shipyard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eedevops/shipyard/statuses/{sha}","languages_url":"https://api.github.com/repos/eedevops/shipyard/languages","stargazers_url":"https://api.github.com/repos/eedevops/shipyard/stargazers","contributors_url":"https://api.github.com/repos/eedevops/shipyard/contributors","subscribers_url":"https://api.github.com/repos/eedevops/shipyard/subscribers","subscription_url":"https://api.github.com/repos/eedevops/shipyard/subscription","commits_url":"https://api.github.com/repos/eedevops/shipyard/commits{/sha}","git_commits_url":"https://api.github.com/repos/eedevops/shipyard/git/commits{/sha}","comments_url":"https://api.github.com/repos/eedevops/shipyard/comments{/number}","issue_comment_url":"https://api.github.com/repos/eedevops/shipyard/issues/comments{/number}","contents_url":"https://api.github.com/repos/eedevops/shipyard/contents/{+path}","compare_url":"https://api.github.com/repos/eedevops/shipyard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eedevops/shipyard/merges","archive_url":"https://api.github.com/repos/eedevops/shipyard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eedevops/shipyard/downloads","issues_url":"https://api.github.com/repos/eedevops/shipyard/issues{/number}","pulls_url":"https://api.github.com/repos/eedevops/shipyard/pulls{/number}","milestones_url":"https://api.github.com/repos/eedevops/shipyard/milestones{/number}","notifications_url":"https://api.github.com/repos/eedevops/shipyard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eedevops/shipyard/labels{/name}","releases_url":"https://api.github.com/repos/eedevops/shipyard/releases{/id}","deployments_url":"https://api.github.com/repos/eedevops/shipyard/deployments","created_at":"2016-01-15T13:33:34Z","updated_at":"2016-06-21T14:36:12Z","pushed_at":"2016-06-21T21:27:20Z","git_url":"git://github.com/eedevops/shipyard.git","ssh_url":"git@github.com:eedevops/shipyard.git","clone_url":"https://github.com/eedevops/shipyard.git","svn_url":"https://github.com/eedevops/shipyard","homepage":"http://shipyard-project.com","size":27834,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":15,"forks":5,"open_issues":15,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eedevops/shipyard/pulls/155"},"html":{"href":"https://github.com/eedevops/shipyard/pull/155"},"issue":{"href":"https://api.github.com/repos/eedevops/shipyard/issues/155"},"comments":{"href":"https://api.github.com/repos/eedevops/shipyard/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/eedevops/shipyard/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/eedevops/shipyard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eedevops/shipyard/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/eedevops/shipyard/statuses/6f4dd72aa50bdb276acaa0e398fa6a45db65679f"}}}}
{"actor":{"display_login":"rqc"}}