{"action":"created","comment":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments/77080872","id":77080872,"diff_hunk":"@@ -27,8 +27,11 @@ trait BaseApi extends Closable {\n     RetryPolicy.backoff(backoffs) {\n       // We will assume 5xx are retryable, everything else is not for now\n       case (_, Return(rep)) => rep.status.code >= 500 && rep.status.code < 600\n+      // Looks like it could be either of 2 depending on where FutureCancelledException occurred\n+      case (_, Throw(e: Failure)) if e.isFlagged(Failure.Interrupted) => false\n+      case (_, Throw(e: FutureCancelledException)) => false","path":"consul/src/main/scala/io/buoyant/consul/v1/BaseApi.scala","position":15,"original_position":15,"commit_id":"68de57a71d254b85ed2b2305576f7c0dd442cc04","original_commit_id":"68de57a71d254b85ed2b2305576f7c0dd442cc04","user":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"body":"Do you want me to update the way we cancel futures within this PR? Or should I just adjust this PR so retry filter will handle Interrupted failures properly and then submit another PR changing the way we canceling futures?","created_at":"2016-08-31T21:53:40Z","updated_at":"2016-08-31T21:53:40Z","html_url":"https://github.com/BuoyantIO/linkerd/pull/615#discussion_r77080872","pull_request_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/615","_links":{"self":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments/77080872"},"html":{"href":"https://github.com/BuoyantIO/linkerd/pull/615#discussion_r77080872"},"pull_request":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/615"}}},"pull_request":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/615","id":83529624,"html_url":"https://github.com/BuoyantIO/linkerd/pull/615","diff_url":"https://github.com/BuoyantIO/linkerd/pull/615.diff","patch_url":"https://github.com/BuoyantIO/linkerd/pull/615.patch","issue_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/615","number":615,"state":"open","locked":false,"title":"Make retry filter do not retry on Future.cancel","user":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"body":"Previously it wasn't possible to cancel request when retry filter is enable as it will consider `FutureCancelledException` as an error that should be re-tried:\r\n```\r\nE 0831 20:24:25.121 THREAD12: retrying consul catalog request on error Failure(The future was cancelled with Future.cancel, flags=0x02)\r\n```","created_at":"2016-08-31T21:06:46Z","updated_at":"2016-08-31T21:53:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c6a354c1de5fc7738f359c791fdf80042f1248f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/615/commits","review_comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/615/comments","review_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/615/comments","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/68de57a71d254b85ed2b2305576f7c0dd442cc04","head":{"label":"Ashald:bugfix/consul-no-retry-on-cancel","ref":"bugfix/consul-no-retry-on-cancel","sha":"68de57a71d254b85ed2b2305576f7c0dd442cc04","user":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"repo":{"id":62817214,"name":"linkerd","full_name":"Ashald/linkerd","owner":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ashald/linkerd","description":"A dynamic linker for microservices.","fork":true,"url":"https://api.github.com/repos/Ashald/linkerd","forks_url":"https://api.github.com/repos/Ashald/linkerd/forks","keys_url":"https://api.github.com/repos/Ashald/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ashald/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ashald/linkerd/teams","hooks_url":"https://api.github.com/repos/Ashald/linkerd/hooks","issue_events_url":"https://api.github.com/repos/Ashald/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/Ashald/linkerd/events","assignees_url":"https://api.github.com/repos/Ashald/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/Ashald/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/Ashald/linkerd/tags","blobs_url":"https://api.github.com/repos/Ashald/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ashald/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ashald/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ashald/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ashald/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/Ashald/linkerd/languages","stargazers_url":"https://api.github.com/repos/Ashald/linkerd/stargazers","contributors_url":"https://api.github.com/repos/Ashald/linkerd/contributors","subscribers_url":"https://api.github.com/repos/Ashald/linkerd/subscribers","subscription_url":"https://api.github.com/repos/Ashald/linkerd/subscription","commits_url":"https://api.github.com/repos/Ashald/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ashald/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ashald/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ashald/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ashald/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/Ashald/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ashald/linkerd/merges","archive_url":"https://api.github.com/repos/Ashald/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ashald/linkerd/downloads","issues_url":"https://api.github.com/repos/Ashald/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/Ashald/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/Ashald/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/Ashald/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ashald/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/Ashald/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/Ashald/linkerd/deployments","created_at":"2016-07-07T15:20:38Z","updated_at":"2016-07-07T15:20:40Z","pushed_at":"2016-08-31T21:04:24Z","git_url":"git://github.com/Ashald/linkerd.git","ssh_url":"git@github.com:Ashald/linkerd.git","clone_url":"https://github.com/Ashald/linkerd.git","svn_url":"https://github.com/Ashald/linkerd","homepage":"https://linkerd.io","size":1815,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BuoyantIO:master","ref":"master","sha":"5f248263684432bb95547f1543f202f0bf2bb595","user":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"name":"linkerd","full_name":"BuoyantIO/linkerd","owner":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BuoyantIO/linkerd","description":"A dynamic linker for microservices.","fork":false,"url":"https://api.github.com/repos/BuoyantIO/linkerd","forks_url":"https://api.github.com/repos/BuoyantIO/linkerd/forks","keys_url":"https://api.github.com/repos/BuoyantIO/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuoyantIO/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuoyantIO/linkerd/teams","hooks_url":"https://api.github.com/repos/BuoyantIO/linkerd/hooks","issue_events_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/BuoyantIO/linkerd/events","assignees_url":"https://api.github.com/repos/BuoyantIO/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/BuoyantIO/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/BuoyantIO/linkerd/tags","blobs_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/BuoyantIO/linkerd/languages","stargazers_url":"https://api.github.com/repos/BuoyantIO/linkerd/stargazers","contributors_url":"https://api.github.com/repos/BuoyantIO/linkerd/contributors","subscribers_url":"https://api.github.com/repos/BuoyantIO/linkerd/subscribers","subscription_url":"https://api.github.com/repos/BuoyantIO/linkerd/subscription","commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuoyantIO/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/BuoyantIO/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuoyantIO/linkerd/merges","archive_url":"https://api.github.com/repos/BuoyantIO/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuoyantIO/linkerd/downloads","issues_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/BuoyantIO/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/BuoyantIO/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuoyantIO/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/BuoyantIO/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/BuoyantIO/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2016-08-30T08:21:44Z","pushed_at":"2016-08-31T21:06:46Z","git_url":"git://github.com/BuoyantIO/linkerd.git","ssh_url":"git@github.com:BuoyantIO/linkerd.git","clone_url":"https://github.com/BuoyantIO/linkerd.git","svn_url":"https://github.com/BuoyantIO/linkerd","homepage":"https://linkerd.io","size":2578,"stargazers_count":903,"watchers_count":903,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":82,"forks":69,"open_issues":82,"watchers":903,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/615"},"html":{"href":"https://github.com/BuoyantIO/linkerd/pull/615"},"issue":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/issues/615"},"comments":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/issues/615/comments"},"review_comments":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/615/comments"},"review_comment":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/615/commits"},"statuses":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/68de57a71d254b85ed2b2305576f7c0dd442cc04"}}}}
{"actor":{"display_login":"Ashald"}}