{"action":"created","comment":{"url":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/comments/62038873","id":62038873,"diff_hunk":"@@ -5,7 +5,11 @@\n     \"build\": \"\"\n   },\n   \"main\": \"uws.js\",\n-  \"description\": \"Highly scalable WebSocket server library\",\n+  \"description\": \"Highly scalable WebSocket server library - binaries for Linux/Darwin\",\n+  \"engines\": {\n+    \"node\": \"4.4.3 5.11.0 6.0.0\"","path":"nodejs/uws-binary/package.json","position":7,"original_position":7,"commit_id":"757435899703ca7cd63c90f83b5a4d3a104a58d6","original_commit_id":"757435899703ca7cd63c90f83b5a4d3a104a58d6","user":{"login":"kapouer","id":131406,"avatar_url":"https://avatars.githubusercontent.com/u/131406?v=3","gravatar_id":"","url":"https://api.github.com/users/kapouer","html_url":"https://github.com/kapouer","followers_url":"https://api.github.com/users/kapouer/followers","following_url":"https://api.github.com/users/kapouer/following{/other_user}","gists_url":"https://api.github.com/users/kapouer/gists{/gist_id}","starred_url":"https://api.github.com/users/kapouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapouer/subscriptions","organizations_url":"https://api.github.com/users/kapouer/orgs","repos_url":"https://api.github.com/users/kapouer/repos","events_url":"https://api.github.com/users/kapouer/events{/privacy}","received_events_url":"https://api.github.com/users/kapouer/received_events","type":"User","site_admin":false},"body":"ok, fixing those","created_at":"2016-05-04T13:34:38Z","updated_at":"2016-05-04T13:34:38Z","html_url":"https://github.com/alexhultman/uWebSockets/pull/88#discussion_r62038873","pull_request_url":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/comments/62038873"},"html":{"href":"https://github.com/alexhultman/uWebSockets/pull/88#discussion_r62038873"},"pull_request":{"href":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/88","id":68855528,"html_url":"https://github.com/alexhultman/uWebSockets/pull/88","diff_url":"https://github.com/alexhultman/uWebSockets/pull/88.diff","patch_url":"https://github.com/alexhultman/uWebSockets/pull/88.patch","issue_url":"https://api.github.com/repos/alexhultman/uWebSockets/issues/88","number":88,"state":"open","locked":false,"title":"Distribute two npm modules: source and binary","user":{"login":"kapouer","id":131406,"avatar_url":"https://avatars.githubusercontent.com/u/131406?v=3","gravatar_id":"","url":"https://api.github.com/users/kapouer","html_url":"https://github.com/kapouer","followers_url":"https://api.github.com/users/kapouer/followers","following_url":"https://api.github.com/users/kapouer/following{/other_user}","gists_url":"https://api.github.com/users/kapouer/gists{/gist_id}","starred_url":"https://api.github.com/users/kapouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapouer/subscriptions","organizations_url":"https://api.github.com/users/kapouer/orgs","repos_url":"https://api.github.com/users/kapouer/repos","events_url":"https://api.github.com/users/kapouer/events{/privacy}","received_events_url":"https://api.github.com/users/kapouer/received_events","type":"User","site_admin":false},"body":"## Makefile changes\r\nTo develop, just `make`.\r\nTo prepare a release, `VERSION=0.3.2 make prepare` and check the content of uws-binary, uws-source folders.\r\nTo publish, `VERSION=0.3.2 make publish` will publish both.\r\nAlso note the stamp on targets/ to avoid redownloading.\r\n\r\n## package.json changes\r\nThe `uws` package tells which nodejs versions and os it exactly supports.\r\nThe `uws-source` package is a little less strict by essence.\r\nI alos finished the work on binding.gyp so flags are set for darwin, and filename is the one expected by uws.js. I think it's a bad idea to load a versioned filename, because the error message will be misleading (missing module). Node already has a module version mismatch check and appropriate warning - but i didn't change that.\r\n","created_at":"2016-05-04T12:44:05Z","updated_at":"2016-05-04T13:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"accb2dacc02d9073896a67897b2e3f06909c67fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/88/commits","review_comments_url":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/88/comments","review_comment_url":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexhultman/uWebSockets/issues/88/comments","statuses_url":"https://api.github.com/repos/alexhultman/uWebSockets/statuses/757435899703ca7cd63c90f83b5a4d3a104a58d6","head":{"label":"kapouer:dist-binary-source","ref":"dist-binary-source","sha":"757435899703ca7cd63c90f83b5a4d3a104a58d6","user":{"login":"kapouer","id":131406,"avatar_url":"https://avatars.githubusercontent.com/u/131406?v=3","gravatar_id":"","url":"https://api.github.com/users/kapouer","html_url":"https://github.com/kapouer","followers_url":"https://api.github.com/users/kapouer/followers","following_url":"https://api.github.com/users/kapouer/following{/other_user}","gists_url":"https://api.github.com/users/kapouer/gists{/gist_id}","starred_url":"https://api.github.com/users/kapouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapouer/subscriptions","organizations_url":"https://api.github.com/users/kapouer/orgs","repos_url":"https://api.github.com/users/kapouer/repos","events_url":"https://api.github.com/users/kapouer/events{/privacy}","received_events_url":"https://api.github.com/users/kapouer/received_events","type":"User","site_admin":false},"repo":{"id":58009151,"name":"uWebSockets","full_name":"kapouer/uWebSockets","owner":{"login":"kapouer","id":131406,"avatar_url":"https://avatars.githubusercontent.com/u/131406?v=3","gravatar_id":"","url":"https://api.github.com/users/kapouer","html_url":"https://github.com/kapouer","followers_url":"https://api.github.com/users/kapouer/followers","following_url":"https://api.github.com/users/kapouer/following{/other_user}","gists_url":"https://api.github.com/users/kapouer/gists{/gist_id}","starred_url":"https://api.github.com/users/kapouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapouer/subscriptions","organizations_url":"https://api.github.com/users/kapouer/orgs","repos_url":"https://api.github.com/users/kapouer/repos","events_url":"https://api.github.com/users/kapouer/events{/privacy}","received_events_url":"https://api.github.com/users/kapouer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kapouer/uWebSockets","description":"Highly scalable WebSocket server library","fork":true,"url":"https://api.github.com/repos/kapouer/uWebSockets","forks_url":"https://api.github.com/repos/kapouer/uWebSockets/forks","keys_url":"https://api.github.com/repos/kapouer/uWebSockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kapouer/uWebSockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kapouer/uWebSockets/teams","hooks_url":"https://api.github.com/repos/kapouer/uWebSockets/hooks","issue_events_url":"https://api.github.com/repos/kapouer/uWebSockets/issues/events{/number}","events_url":"https://api.github.com/repos/kapouer/uWebSockets/events","assignees_url":"https://api.github.com/repos/kapouer/uWebSockets/assignees{/user}","branches_url":"https://api.github.com/repos/kapouer/uWebSockets/branches{/branch}","tags_url":"https://api.github.com/repos/kapouer/uWebSockets/tags","blobs_url":"https://api.github.com/repos/kapouer/uWebSockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kapouer/uWebSockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kapouer/uWebSockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/kapouer/uWebSockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kapouer/uWebSockets/statuses/{sha}","languages_url":"https://api.github.com/repos/kapouer/uWebSockets/languages","stargazers_url":"https://api.github.com/repos/kapouer/uWebSockets/stargazers","contributors_url":"https://api.github.com/repos/kapouer/uWebSockets/contributors","subscribers_url":"https://api.github.com/repos/kapouer/uWebSockets/subscribers","subscription_url":"https://api.github.com/repos/kapouer/uWebSockets/subscription","commits_url":"https://api.github.com/repos/kapouer/uWebSockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/kapouer/uWebSockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/kapouer/uWebSockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/kapouer/uWebSockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/kapouer/uWebSockets/contents/{+path}","compare_url":"https://api.github.com/repos/kapouer/uWebSockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kapouer/uWebSockets/merges","archive_url":"https://api.github.com/repos/kapouer/uWebSockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kapouer/uWebSockets/downloads","issues_url":"https://api.github.com/repos/kapouer/uWebSockets/issues{/number}","pulls_url":"https://api.github.com/repos/kapouer/uWebSockets/pulls{/number}","milestones_url":"https://api.github.com/repos/kapouer/uWebSockets/milestones{/number}","notifications_url":"https://api.github.com/repos/kapouer/uWebSockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kapouer/uWebSockets/labels{/name}","releases_url":"https://api.github.com/repos/kapouer/uWebSockets/releases{/id}","deployments_url":"https://api.github.com/repos/kapouer/uWebSockets/deployments","created_at":"2016-05-03T23:54:21Z","updated_at":"2016-05-03T23:54:22Z","pushed_at":"2016-05-04T12:35:02Z","git_url":"git://github.com/kapouer/uWebSockets.git","ssh_url":"git@github.com:kapouer/uWebSockets.git","clone_url":"https://github.com/kapouer/uWebSockets.git","svn_url":"https://github.com/kapouer/uWebSockets","homepage":"","size":230,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexhultman:master","ref":"master","sha":"9f16011a79155159b59cff8810ec59dc4309850a","user":{"login":"alexhultman","id":3397140,"avatar_url":"https://avatars.githubusercontent.com/u/3397140?v=3","gravatar_id":"","url":"https://api.github.com/users/alexhultman","html_url":"https://github.com/alexhultman","followers_url":"https://api.github.com/users/alexhultman/followers","following_url":"https://api.github.com/users/alexhultman/following{/other_user}","gists_url":"https://api.github.com/users/alexhultman/gists{/gist_id}","starred_url":"https://api.github.com/users/alexhultman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexhultman/subscriptions","organizations_url":"https://api.github.com/users/alexhultman/orgs","repos_url":"https://api.github.com/users/alexhultman/repos","events_url":"https://api.github.com/users/alexhultman/events{/privacy}","received_events_url":"https://api.github.com/users/alexhultman/received_events","type":"User","site_admin":false},"repo":{"id":54360307,"name":"uWebSockets","full_name":"alexhultman/uWebSockets","owner":{"login":"alexhultman","id":3397140,"avatar_url":"https://avatars.githubusercontent.com/u/3397140?v=3","gravatar_id":"","url":"https://api.github.com/users/alexhultman","html_url":"https://github.com/alexhultman","followers_url":"https://api.github.com/users/alexhultman/followers","following_url":"https://api.github.com/users/alexhultman/following{/other_user}","gists_url":"https://api.github.com/users/alexhultman/gists{/gist_id}","starred_url":"https://api.github.com/users/alexhultman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexhultman/subscriptions","organizations_url":"https://api.github.com/users/alexhultman/orgs","repos_url":"https://api.github.com/users/alexhultman/repos","events_url":"https://api.github.com/users/alexhultman/events{/privacy}","received_events_url":"https://api.github.com/users/alexhultman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexhultman/uWebSockets","description":"Highly scalable WebSocket server library","fork":false,"url":"https://api.github.com/repos/alexhultman/uWebSockets","forks_url":"https://api.github.com/repos/alexhultman/uWebSockets/forks","keys_url":"https://api.github.com/repos/alexhultman/uWebSockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexhultman/uWebSockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexhultman/uWebSockets/teams","hooks_url":"https://api.github.com/repos/alexhultman/uWebSockets/hooks","issue_events_url":"https://api.github.com/repos/alexhultman/uWebSockets/issues/events{/number}","events_url":"https://api.github.com/repos/alexhultman/uWebSockets/events","assignees_url":"https://api.github.com/repos/alexhultman/uWebSockets/assignees{/user}","branches_url":"https://api.github.com/repos/alexhultman/uWebSockets/branches{/branch}","tags_url":"https://api.github.com/repos/alexhultman/uWebSockets/tags","blobs_url":"https://api.github.com/repos/alexhultman/uWebSockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexhultman/uWebSockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexhultman/uWebSockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexhultman/uWebSockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexhultman/uWebSockets/statuses/{sha}","languages_url":"https://api.github.com/repos/alexhultman/uWebSockets/languages","stargazers_url":"https://api.github.com/repos/alexhultman/uWebSockets/stargazers","contributors_url":"https://api.github.com/repos/alexhultman/uWebSockets/contributors","subscribers_url":"https://api.github.com/repos/alexhultman/uWebSockets/subscribers","subscription_url":"https://api.github.com/repos/alexhultman/uWebSockets/subscription","commits_url":"https://api.github.com/repos/alexhultman/uWebSockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexhultman/uWebSockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexhultman/uWebSockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexhultman/uWebSockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexhultman/uWebSockets/contents/{+path}","compare_url":"https://api.github.com/repos/alexhultman/uWebSockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexhultman/uWebSockets/merges","archive_url":"https://api.github.com/repos/alexhultman/uWebSockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexhultman/uWebSockets/downloads","issues_url":"https://api.github.com/repos/alexhultman/uWebSockets/issues{/number}","pulls_url":"https://api.github.com/repos/alexhultman/uWebSockets/pulls{/number}","milestones_url":"https://api.github.com/repos/alexhultman/uWebSockets/milestones{/number}","notifications_url":"https://api.github.com/repos/alexhultman/uWebSockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexhultman/uWebSockets/labels{/name}","releases_url":"https://api.github.com/repos/alexhultman/uWebSockets/releases{/id}","deployments_url":"https://api.github.com/repos/alexhultman/uWebSockets/deployments","created_at":"2016-03-21T04:39:40Z","updated_at":"2016-05-04T11:49:07Z","pushed_at":"2016-05-04T12:44:05Z","git_url":"git://github.com/alexhultman/uWebSockets.git","ssh_url":"git@github.com:alexhultman/uWebSockets.git","clone_url":"https://github.com/alexhultman/uWebSockets.git","svn_url":"https://github.com/alexhultman/uWebSockets","homepage":"","size":257,"stargazers_count":822,"watchers_count":822,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":11,"forks":31,"open_issues":11,"watchers":822,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/88"},"html":{"href":"https://github.com/alexhultman/uWebSockets/pull/88"},"issue":{"href":"https://api.github.com/repos/alexhultman/uWebSockets/issues/88"},"comments":{"href":"https://api.github.com/repos/alexhultman/uWebSockets/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexhultman/uWebSockets/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/alexhultman/uWebSockets/statuses/757435899703ca7cd63c90f83b5a4d3a104a58d6"}}}}