{"action":"created","comment":{"url":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/comments/58622698","id":58622698,"diff_hunk":"@@ -80,6 +80,19 @@ class AggregationHandleDistinct : public AggregationConcreteHandle {\n     LOG(FATAL) << \"AggregationHandleDistinct does not support finalize().\";\n   }\n \n+  AggregationState* aggregateOnDistinctifyHashTableForSingle(","path":"expressions/aggregation/AggregationHandleDistinct.hpp","position":4,"original_position":4,"commit_id":"b40484d782890033dac5612e3646912843a34d50","original_commit_id":"b40484d782890033dac5612e3646912843a34d50","user":{"login":"pateljm","id":8864916,"avatar_url":"https://avatars.githubusercontent.com/u/8864916?v=3","gravatar_id":"","url":"https://api.github.com/users/pateljm","html_url":"https://github.com/pateljm","followers_url":"https://api.github.com/users/pateljm/followers","following_url":"https://api.github.com/users/pateljm/following{/other_user}","gists_url":"https://api.github.com/users/pateljm/gists{/gist_id}","starred_url":"https://api.github.com/users/pateljm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pateljm/subscriptions","organizations_url":"https://api.github.com/users/pateljm/orgs","repos_url":"https://api.github.com/users/pateljm/repos","events_url":"https://api.github.com/users/pateljm/events{/privacy}","received_events_url":"https://api.github.com/users/pateljm/received_events","type":"User","site_admin":false},"body":"Doxygen comments? ","created_at":"2016-04-05T22:15:38Z","updated_at":"2016-04-05T22:15:38Z","html_url":"https://github.com/pivotalsoftware/quickstep/pull/128#discussion_r58622698","pull_request_url":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/comments/58622698"},"html":{"href":"https://github.com/pivotalsoftware/quickstep/pull/128#discussion_r58622698"},"pull_request":{"href":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/128","id":65363219,"html_url":"https://github.com/pivotalsoftware/quickstep/pull/128","diff_url":"https://github.com/pivotalsoftware/quickstep/pull/128.diff","patch_url":"https://github.com/pivotalsoftware/quickstep/pull/128.patch","issue_url":"https://api.github.com/repos/pivotalsoftware/quickstep/issues/128","number":128,"state":"open","locked":false,"title":"Extend AggregationHandle and its subclasses to handle DISTINCT aggregation","user":{"login":"jianqiao","id":2695519,"avatar_url":"https://avatars.githubusercontent.com/u/2695519?v=3","gravatar_id":"","url":"https://api.github.com/users/jianqiao","html_url":"https://github.com/jianqiao","followers_url":"https://api.github.com/users/jianqiao/followers","following_url":"https://api.github.com/users/jianqiao/following{/other_user}","gists_url":"https://api.github.com/users/jianqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jianqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianqiao/subscriptions","organizations_url":"https://api.github.com/users/jianqiao/orgs","repos_url":"https://api.github.com/users/jianqiao/repos","events_url":"https://api.github.com/users/jianqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jianqiao/received_events","type":"User","site_admin":false},"body":"This PR adds virtual methods in `AggregationHandle` and corresponding implements in its subclasses to handle DISTINCT aggregations.","created_at":"2016-04-05T19:47:58Z","updated_at":"2016-04-05T22:15:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4578d88858f3f4b6cffc953682a71cd43eea86a2","assignee":{"login":"pateljm","id":8864916,"avatar_url":"https://avatars.githubusercontent.com/u/8864916?v=3","gravatar_id":"","url":"https://api.github.com/users/pateljm","html_url":"https://github.com/pateljm","followers_url":"https://api.github.com/users/pateljm/followers","following_url":"https://api.github.com/users/pateljm/following{/other_user}","gists_url":"https://api.github.com/users/pateljm/gists{/gist_id}","starred_url":"https://api.github.com/users/pateljm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pateljm/subscriptions","organizations_url":"https://api.github.com/users/pateljm/orgs","repos_url":"https://api.github.com/users/pateljm/repos","events_url":"https://api.github.com/users/pateljm/events{/privacy}","received_events_url":"https://api.github.com/users/pateljm/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/pivotalsoftware/quickstep/milestones/2","html_url":"https://github.com/pivotalsoftware/quickstep/milestones/DISTINCT%20aggregation","labels_url":"https://api.github.com/repos/pivotalsoftware/quickstep/milestones/2/labels","id":1685613,"number":2,"title":"DISTINCT aggregation","description":null,"creator":{"login":"jianqiao","id":2695519,"avatar_url":"https://avatars.githubusercontent.com/u/2695519?v=3","gravatar_id":"","url":"https://api.github.com/users/jianqiao","html_url":"https://github.com/jianqiao","followers_url":"https://api.github.com/users/jianqiao/followers","following_url":"https://api.github.com/users/jianqiao/following{/other_user}","gists_url":"https://api.github.com/users/jianqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jianqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianqiao/subscriptions","organizations_url":"https://api.github.com/users/jianqiao/orgs","repos_url":"https://api.github.com/users/jianqiao/repos","events_url":"https://api.github.com/users/jianqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jianqiao/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2016-04-05T20:30:56Z","updated_at":"2016-04-05T22:04:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/128/commits","review_comments_url":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/128/comments","review_comment_url":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pivotalsoftware/quickstep/issues/128/comments","statuses_url":"https://api.github.com/repos/pivotalsoftware/quickstep/statuses/b40484d782890033dac5612e3646912843a34d50","head":{"label":"pivotalsoftware:distinct-aggregation-handle-update","ref":"distinct-aggregation-handle-update","sha":"b40484d782890033dac5612e3646912843a34d50","user":{"login":"pivotalsoftware","id":4247270,"avatar_url":"https://avatars.githubusercontent.com/u/4247270?v=3","gravatar_id":"","url":"https://api.github.com/users/pivotalsoftware","html_url":"https://github.com/pivotalsoftware","followers_url":"https://api.github.com/users/pivotalsoftware/followers","following_url":"https://api.github.com/users/pivotalsoftware/following{/other_user}","gists_url":"https://api.github.com/users/pivotalsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotalsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotalsoftware/subscriptions","organizations_url":"https://api.github.com/users/pivotalsoftware/orgs","repos_url":"https://api.github.com/users/pivotalsoftware/repos","events_url":"https://api.github.com/users/pivotalsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/pivotalsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":45578105,"name":"quickstep","full_name":"pivotalsoftware/quickstep","owner":{"login":"pivotalsoftware","id":4247270,"avatar_url":"https://avatars.githubusercontent.com/u/4247270?v=3","gravatar_id":"","url":"https://api.github.com/users/pivotalsoftware","html_url":"https://github.com/pivotalsoftware","followers_url":"https://api.github.com/users/pivotalsoftware/followers","following_url":"https://api.github.com/users/pivotalsoftware/following{/other_user}","gists_url":"https://api.github.com/users/pivotalsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotalsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotalsoftware/subscriptions","organizations_url":"https://api.github.com/users/pivotalsoftware/orgs","repos_url":"https://api.github.com/users/pivotalsoftware/repos","events_url":"https://api.github.com/users/pivotalsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/pivotalsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pivotalsoftware/quickstep","description":"Quickstep Project","fork":false,"url":"https://api.github.com/repos/pivotalsoftware/quickstep","forks_url":"https://api.github.com/repos/pivotalsoftware/quickstep/forks","keys_url":"https://api.github.com/repos/pivotalsoftware/quickstep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pivotalsoftware/quickstep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pivotalsoftware/quickstep/teams","hooks_url":"https://api.github.com/repos/pivotalsoftware/quickstep/hooks","issue_events_url":"https://api.github.com/repos/pivotalsoftware/quickstep/issues/events{/number}","events_url":"https://api.github.com/repos/pivotalsoftware/quickstep/events","assignees_url":"https://api.github.com/repos/pivotalsoftware/quickstep/assignees{/user}","branches_url":"https://api.github.com/repos/pivotalsoftware/quickstep/branches{/branch}","tags_url":"https://api.github.com/repos/pivotalsoftware/quickstep/tags","blobs_url":"https://api.github.com/repos/pivotalsoftware/quickstep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pivotalsoftware/quickstep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pivotalsoftware/quickstep/git/refs{/sha}","trees_url":"https://api.github.com/repos/pivotalsoftware/quickstep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pivotalsoftware/quickstep/statuses/{sha}","languages_url":"https://api.github.com/repos/pivotalsoftware/quickstep/languages","stargazers_url":"https://api.github.com/repos/pivotalsoftware/quickstep/stargazers","contributors_url":"https://api.github.com/repos/pivotalsoftware/quickstep/contributors","subscribers_url":"https://api.github.com/repos/pivotalsoftware/quickstep/subscribers","subscription_url":"https://api.github.com/repos/pivotalsoftware/quickstep/subscription","commits_url":"https://api.github.com/repos/pivotalsoftware/quickstep/commits{/sha}","git_commits_url":"https://api.github.com/repos/pivotalsoftware/quickstep/git/commits{/sha}","comments_url":"https://api.github.com/repos/pivotalsoftware/quickstep/comments{/number}","issue_comment_url":"https://api.github.com/repos/pivotalsoftware/quickstep/issues/comments{/number}","contents_url":"https://api.github.com/repos/pivotalsoftware/quickstep/contents/{+path}","compare_url":"https://api.github.com/repos/pivotalsoftware/quickstep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pivotalsoftware/quickstep/merges","archive_url":"https://api.github.com/repos/pivotalsoftware/quickstep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pivotalsoftware/quickstep/downloads","issues_url":"https://api.github.com/repos/pivotalsoftware/quickstep/issues{/number}","pulls_url":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls{/number}","milestones_url":"https://api.github.com/repos/pivotalsoftware/quickstep/milestones{/number}","notifications_url":"https://api.github.com/repos/pivotalsoftware/quickstep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pivotalsoftware/quickstep/labels{/name}","releases_url":"https://api.github.com/repos/pivotalsoftware/quickstep/releases{/id}","deployments_url":"https://api.github.com/repos/pivotalsoftware/quickstep/deployments","created_at":"2015-11-05T01:06:50Z","updated_at":"2016-03-30T04:28:05Z","pushed_at":"2016-04-05T22:14:05Z","git_url":"git://github.com/pivotalsoftware/quickstep.git","ssh_url":"git@github.com:pivotalsoftware/quickstep.git","clone_url":"https://github.com/pivotalsoftware/quickstep.git","svn_url":"https://github.com/pivotalsoftware/quickstep","homepage":null,"size":7916,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":17,"forks":9,"open_issues":17,"watchers":14,"default_branch":"master"}},"base":{"label":"pivotalsoftware:master","ref":"master","sha":"95130756c5487e87b8bc43890beeb60c466a0256","user":{"login":"pivotalsoftware","id":4247270,"avatar_url":"https://avatars.githubusercontent.com/u/4247270?v=3","gravatar_id":"","url":"https://api.github.com/users/pivotalsoftware","html_url":"https://github.com/pivotalsoftware","followers_url":"https://api.github.com/users/pivotalsoftware/followers","following_url":"https://api.github.com/users/pivotalsoftware/following{/other_user}","gists_url":"https://api.github.com/users/pivotalsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotalsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotalsoftware/subscriptions","organizations_url":"https://api.github.com/users/pivotalsoftware/orgs","repos_url":"https://api.github.com/users/pivotalsoftware/repos","events_url":"https://api.github.com/users/pivotalsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/pivotalsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":45578105,"name":"quickstep","full_name":"pivotalsoftware/quickstep","owner":{"login":"pivotalsoftware","id":4247270,"avatar_url":"https://avatars.githubusercontent.com/u/4247270?v=3","gravatar_id":"","url":"https://api.github.com/users/pivotalsoftware","html_url":"https://github.com/pivotalsoftware","followers_url":"https://api.github.com/users/pivotalsoftware/followers","following_url":"https://api.github.com/users/pivotalsoftware/following{/other_user}","gists_url":"https://api.github.com/users/pivotalsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotalsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotalsoftware/subscriptions","organizations_url":"https://api.github.com/users/pivotalsoftware/orgs","repos_url":"https://api.github.com/users/pivotalsoftware/repos","events_url":"https://api.github.com/users/pivotalsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/pivotalsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pivotalsoftware/quickstep","description":"Quickstep Project","fork":false,"url":"https://api.github.com/repos/pivotalsoftware/quickstep","forks_url":"https://api.github.com/repos/pivotalsoftware/quickstep/forks","keys_url":"https://api.github.com/repos/pivotalsoftware/quickstep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pivotalsoftware/quickstep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pivotalsoftware/quickstep/teams","hooks_url":"https://api.github.com/repos/pivotalsoftware/quickstep/hooks","issue_events_url":"https://api.github.com/repos/pivotalsoftware/quickstep/issues/events{/number}","events_url":"https://api.github.com/repos/pivotalsoftware/quickstep/events","assignees_url":"https://api.github.com/repos/pivotalsoftware/quickstep/assignees{/user}","branches_url":"https://api.github.com/repos/pivotalsoftware/quickstep/branches{/branch}","tags_url":"https://api.github.com/repos/pivotalsoftware/quickstep/tags","blobs_url":"https://api.github.com/repos/pivotalsoftware/quickstep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pivotalsoftware/quickstep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pivotalsoftware/quickstep/git/refs{/sha}","trees_url":"https://api.github.com/repos/pivotalsoftware/quickstep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pivotalsoftware/quickstep/statuses/{sha}","languages_url":"https://api.github.com/repos/pivotalsoftware/quickstep/languages","stargazers_url":"https://api.github.com/repos/pivotalsoftware/quickstep/stargazers","contributors_url":"https://api.github.com/repos/pivotalsoftware/quickstep/contributors","subscribers_url":"https://api.github.com/repos/pivotalsoftware/quickstep/subscribers","subscription_url":"https://api.github.com/repos/pivotalsoftware/quickstep/subscription","commits_url":"https://api.github.com/repos/pivotalsoftware/quickstep/commits{/sha}","git_commits_url":"https://api.github.com/repos/pivotalsoftware/quickstep/git/commits{/sha}","comments_url":"https://api.github.com/repos/pivotalsoftware/quickstep/comments{/number}","issue_comment_url":"https://api.github.com/repos/pivotalsoftware/quickstep/issues/comments{/number}","contents_url":"https://api.github.com/repos/pivotalsoftware/quickstep/contents/{+path}","compare_url":"https://api.github.com/repos/pivotalsoftware/quickstep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pivotalsoftware/quickstep/merges","archive_url":"https://api.github.com/repos/pivotalsoftware/quickstep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pivotalsoftware/quickstep/downloads","issues_url":"https://api.github.com/repos/pivotalsoftware/quickstep/issues{/number}","pulls_url":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls{/number}","milestones_url":"https://api.github.com/repos/pivotalsoftware/quickstep/milestones{/number}","notifications_url":"https://api.github.com/repos/pivotalsoftware/quickstep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pivotalsoftware/quickstep/labels{/name}","releases_url":"https://api.github.com/repos/pivotalsoftware/quickstep/releases{/id}","deployments_url":"https://api.github.com/repos/pivotalsoftware/quickstep/deployments","created_at":"2015-11-05T01:06:50Z","updated_at":"2016-03-30T04:28:05Z","pushed_at":"2016-04-05T22:14:05Z","git_url":"git://github.com/pivotalsoftware/quickstep.git","ssh_url":"git@github.com:pivotalsoftware/quickstep.git","clone_url":"https://github.com/pivotalsoftware/quickstep.git","svn_url":"https://github.com/pivotalsoftware/quickstep","homepage":null,"size":7916,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":17,"forks":9,"open_issues":17,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/128"},"html":{"href":"https://github.com/pivotalsoftware/quickstep/pull/128"},"issue":{"href":"https://api.github.com/repos/pivotalsoftware/quickstep/issues/128"},"comments":{"href":"https://api.github.com/repos/pivotalsoftware/quickstep/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pivotalsoftware/quickstep/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/pivotalsoftware/quickstep/statuses/b40484d782890033dac5612e3646912843a34d50"}}}}