{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/quark/pulls/comments/50753449","id":50753449,"diff_hunk":"@@ -207,8 +212,12 @@ def _make_port_address_dict(ip, port, fields=None):\n     enabled = ip.enabled_for_port(port)\n     subnet_id = ip.get(\"subnet_id\")\n     net_id = ip.get(\"network_id\")\n-    if STRATEGY.is_provider_network(net_id):\n-        subnet_id = STRATEGY.get_provider_subnet_id(net_id, ip[\"version\"])\n+\n+    subnet_id = ip.get(\"subnet_id\")","path":"quark/plugin_views.py","position":19,"original_position":19,"commit_id":"c73011274a929024855434dc07684f310e386791","original_commit_id":"c73011274a929024855434dc07684f310e386791","user":{"login":"mpath","id":4673268,"avatar_url":"https://avatars.githubusercontent.com/u/4673268?v=3","gravatar_id":"","url":"https://api.github.com/users/mpath","html_url":"https://github.com/mpath","followers_url":"https://api.github.com/users/mpath/followers","following_url":"https://api.github.com/users/mpath/following{/other_user}","gists_url":"https://api.github.com/users/mpath/gists{/gist_id}","starred_url":"https://api.github.com/users/mpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpath/subscriptions","organizations_url":"https://api.github.com/users/mpath/orgs","repos_url":"https://api.github.com/users/mpath/repos","events_url":"https://api.github.com/users/mpath/events{/privacy}","received_events_url":"https://api.github.com/users/mpath/received_events","type":"User","site_admin":false},"body":"Assigning subnet_id twice here (already assigned on line 213).","created_at":"2016-01-25T20:48:34Z","updated_at":"2016-01-25T20:48:34Z","html_url":"https://github.com/rackerlabs/quark/pull/500#discussion_r50753449","pull_request_url":"https://api.github.com/repos/rackerlabs/quark/pulls/500","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/comments/50753449"},"html":{"href":"https://github.com/rackerlabs/quark/pull/500#discussion_r50753449"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/500"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/quark/pulls/500","id":56985969,"html_url":"https://github.com/rackerlabs/quark/pull/500","diff_url":"https://github.com/rackerlabs/quark/pull/500.diff","patch_url":"https://github.com/rackerlabs/quark/pull/500.patch","issue_url":"https://api.github.com/repos/rackerlabs/quark/issues/500","number":500,"state":"open","locked":false,"title":"WIP/RFR: Proxy backend driver","user":{"login":"morgabra","id":325742,"avatar_url":"https://avatars.githubusercontent.com/u/325742?v=3","gravatar_id":"","url":"https://api.github.com/users/morgabra","html_url":"https://github.com/morgabra","followers_url":"https://api.github.com/users/morgabra/followers","following_url":"https://api.github.com/users/morgabra/following{/other_user}","gists_url":"https://api.github.com/users/morgabra/gists{/gist_id}","starred_url":"https://api.github.com/users/morgabra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgabra/subscriptions","organizations_url":"https://api.github.com/users/morgabra/orgs","repos_url":"https://api.github.com/users/morgabra/repos","events_url":"https://api.github.com/users/morgabra/events{/privacy}","received_events_url":"https://api.github.com/users/morgabra/received_events","type":"User","site_admin":false},"body":"This is unfortunately named, because really, it's a pure http proxy backend driver. I'm open to renaming everything to reflect that if you like. \r\n\r\nThe idea here is to let quark be in charge of allocation of macs/ips, validating quotas, access control, lifecycle of the port, etc. Instead of calling to NSX or whatever on port create, it instead hits an arbitrary HTTP endpoint with the collected port data.\r\n\r\nThis supports an agent-like pattern, where the agent is free to manage the actual configuration necessary. This is pretty useful in a bare metal context, given that we have to tightly manage the lifecycle of the actual live configuration on the host, and most of that process is pretty unique to the service and didn't seem like it fit trying to shoehorn the whole thing into quark proper, or at least not at first.\r\n\r\nThis also adds an IPAM that is suitable for allocating single ips from groups of very small subnets, instead of multiple ips out of larger ones. (Think a bunch of /30s or something)\r\n\r\n","created_at":"2016-01-23T20:41:27Z","updated_at":"2016-01-25T20:48:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d31e814c68347bcb9cf7a4c48760612b35cbd83e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/quark/pulls/500/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/quark/pulls/500/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/quark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/quark/issues/500/comments","statuses_url":"https://api.github.com/repos/rackerlabs/quark/statuses/c73011274a929024855434dc07684f310e386791","head":{"label":"morgabra:add_ironic_backend_driver","ref":"add_ironic_backend_driver","sha":"c73011274a929024855434dc07684f310e386791","user":{"login":"morgabra","id":325742,"avatar_url":"https://avatars.githubusercontent.com/u/325742?v=3","gravatar_id":"","url":"https://api.github.com/users/morgabra","html_url":"https://github.com/morgabra","followers_url":"https://api.github.com/users/morgabra/followers","following_url":"https://api.github.com/users/morgabra/following{/other_user}","gists_url":"https://api.github.com/users/morgabra/gists{/gist_id}","starred_url":"https://api.github.com/users/morgabra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgabra/subscriptions","organizations_url":"https://api.github.com/users/morgabra/orgs","repos_url":"https://api.github.com/users/morgabra/repos","events_url":"https://api.github.com/users/morgabra/events{/privacy}","received_events_url":"https://api.github.com/users/morgabra/received_events","type":"User","site_admin":false},"repo":{"id":44582298,"name":"quark","full_name":"morgabra/quark","owner":{"login":"morgabra","id":325742,"avatar_url":"https://avatars.githubusercontent.com/u/325742?v=3","gravatar_id":"","url":"https://api.github.com/users/morgabra","html_url":"https://github.com/morgabra","followers_url":"https://api.github.com/users/morgabra/followers","following_url":"https://api.github.com/users/morgabra/following{/other_user}","gists_url":"https://api.github.com/users/morgabra/gists{/gist_id}","starred_url":"https://api.github.com/users/morgabra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgabra/subscriptions","organizations_url":"https://api.github.com/users/morgabra/orgs","repos_url":"https://api.github.com/users/morgabra/repos","events_url":"https://api.github.com/users/morgabra/events{/privacy}","received_events_url":"https://api.github.com/users/morgabra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/morgabra/quark","description":"","fork":true,"url":"https://api.github.com/repos/morgabra/quark","forks_url":"https://api.github.com/repos/morgabra/quark/forks","keys_url":"https://api.github.com/repos/morgabra/quark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morgabra/quark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morgabra/quark/teams","hooks_url":"https://api.github.com/repos/morgabra/quark/hooks","issue_events_url":"https://api.github.com/repos/morgabra/quark/issues/events{/number}","events_url":"https://api.github.com/repos/morgabra/quark/events","assignees_url":"https://api.github.com/repos/morgabra/quark/assignees{/user}","branches_url":"https://api.github.com/repos/morgabra/quark/branches{/branch}","tags_url":"https://api.github.com/repos/morgabra/quark/tags","blobs_url":"https://api.github.com/repos/morgabra/quark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morgabra/quark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morgabra/quark/git/refs{/sha}","trees_url":"https://api.github.com/repos/morgabra/quark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morgabra/quark/statuses/{sha}","languages_url":"https://api.github.com/repos/morgabra/quark/languages","stargazers_url":"https://api.github.com/repos/morgabra/quark/stargazers","contributors_url":"https://api.github.com/repos/morgabra/quark/contributors","subscribers_url":"https://api.github.com/repos/morgabra/quark/subscribers","subscription_url":"https://api.github.com/repos/morgabra/quark/subscription","commits_url":"https://api.github.com/repos/morgabra/quark/commits{/sha}","git_commits_url":"https://api.github.com/repos/morgabra/quark/git/commits{/sha}","comments_url":"https://api.github.com/repos/morgabra/quark/comments{/number}","issue_comment_url":"https://api.github.com/repos/morgabra/quark/issues/comments{/number}","contents_url":"https://api.github.com/repos/morgabra/quark/contents/{+path}","compare_url":"https://api.github.com/repos/morgabra/quark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morgabra/quark/merges","archive_url":"https://api.github.com/repos/morgabra/quark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morgabra/quark/downloads","issues_url":"https://api.github.com/repos/morgabra/quark/issues{/number}","pulls_url":"https://api.github.com/repos/morgabra/quark/pulls{/number}","milestones_url":"https://api.github.com/repos/morgabra/quark/milestones{/number}","notifications_url":"https://api.github.com/repos/morgabra/quark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morgabra/quark/labels{/name}","releases_url":"https://api.github.com/repos/morgabra/quark/releases{/id}","deployments_url":"https://api.github.com/repos/morgabra/quark/deployments","created_at":"2015-10-20T04:32:54Z","updated_at":"2016-01-23T19:32:16Z","pushed_at":"2016-01-23T20:31:09Z","git_url":"git://github.com/morgabra/quark.git","ssh_url":"git@github.com:morgabra/quark.git","clone_url":"https://github.com/morgabra/quark.git","svn_url":"https://github.com/morgabra/quark","homepage":null,"size":2845,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"de378ce04c095ea16719dedf1d5fe9e750ef6efb","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":13504140,"name":"quark","full_name":"rackerlabs/quark","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/quark","description":"","fork":false,"url":"https://api.github.com/repos/rackerlabs/quark","forks_url":"https://api.github.com/repos/rackerlabs/quark/forks","keys_url":"https://api.github.com/repos/rackerlabs/quark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/quark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/quark/teams","hooks_url":"https://api.github.com/repos/rackerlabs/quark/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/quark/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/quark/events","assignees_url":"https://api.github.com/repos/rackerlabs/quark/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/quark/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/quark/tags","blobs_url":"https://api.github.com/repos/rackerlabs/quark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/quark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/quark/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/quark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/quark/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/quark/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/quark/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/quark/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/quark/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/quark/subscription","commits_url":"https://api.github.com/repos/rackerlabs/quark/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/quark/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/quark/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/quark/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/quark/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/quark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/quark/merges","archive_url":"https://api.github.com/repos/rackerlabs/quark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/quark/downloads","issues_url":"https://api.github.com/repos/rackerlabs/quark/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/quark/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/quark/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/quark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/quark/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/quark/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/quark/deployments","created_at":"2013-10-11T16:45:26Z","updated_at":"2016-01-11T20:15:02Z","pushed_at":"2016-01-25T18:53:06Z","git_url":"git://github.com/rackerlabs/quark.git","ssh_url":"git@github.com:rackerlabs/quark.git","clone_url":"https://github.com/rackerlabs/quark.git","svn_url":"https://github.com/rackerlabs/quark","homepage":null,"size":2920,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":16,"forks":22,"open_issues":16,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/500"},"html":{"href":"https://github.com/rackerlabs/quark/pull/500"},"issue":{"href":"https://api.github.com/repos/rackerlabs/quark/issues/500"},"comments":{"href":"https://api.github.com/repos/rackerlabs/quark/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/quark/statuses/c73011274a929024855434dc07684f310e386791"}}}}