{"action":"created","comment":{"url":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/comments/86425508","pull_request_review_id":7086411,"id":86425508,"diff_hunk":"@@ -26,10 +28,27 @@ trait ConditionalSteps {\n     }\n   }\n \n+  case class ExpectErrorStep(step: Step) extends Step {\n+    override val name = s\"ExpectError-${step.name}\"\n+    override def run: Future[Result] = step.run.recoverWith {\n+      case NonFatal(ex) => Future { EXCEPTION(ex) }","path":"smrt-server-sim/src/main/scala/com/pacbio/simulator/steps/ConditionalSteps.scala","position":23,"original_position":23,"commit_id":"5ed4389de2dc13230a5f32119adbede920b95d0a","original_commit_id":"5ed4389de2dc13230a5f32119adbede920b95d0a","user":{"login":"mpkocher","id":868552,"avatar_url":"https://avatars.githubusercontent.com/u/868552?v=3","gravatar_id":"","url":"https://api.github.com/users/mpkocher","html_url":"https://github.com/mpkocher","followers_url":"https://api.github.com/users/mpkocher/followers","following_url":"https://api.github.com/users/mpkocher/following{/other_user}","gists_url":"https://api.github.com/users/mpkocher/gists{/gist_id}","starred_url":"https://api.github.com/users/mpkocher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpkocher/subscriptions","organizations_url":"https://api.github.com/users/mpkocher/orgs","repos_url":"https://api.github.com/users/mpkocher/repos","events_url":"https://api.github.com/users/mpkocher/events{/privacy}","received_events_url":"https://api.github.com/users/mpkocher/received_events","type":"User","site_admin":false},"body":"Are there any concerns here with false positives? ","created_at":"2016-11-03T19:35:05Z","updated_at":"2016-11-03T19:35:05Z","html_url":"https://github.com/PacificBiosciences/smrtflow/pull/376#discussion_r86425508","pull_request_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/376","_links":{"self":{"href":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/comments/86425508"},"html":{"href":"https://github.com/PacificBiosciences/smrtflow/pull/376#discussion_r86425508"},"pull_request":{"href":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/376"}}},"pull_request":{"url":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/376","id":92219747,"html_url":"https://github.com/PacificBiosciences/smrtflow/pull/376","diff_url":"https://github.com/PacificBiosciences/smrtflow/pull/376.diff","patch_url":"https://github.com/PacificBiosciences/smrtflow/pull/376.patch","issue_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/issues/376","number":376,"state":"open","locked":false,"title":"Create SHOULD_RAISE operator for Sim","user":{"login":"smcclellan7","id":16234182,"avatar_url":"https://avatars.githubusercontent.com/u/16234182?v=3","gravatar_id":"","url":"https://api.github.com/users/smcclellan7","html_url":"https://github.com/smcclellan7","followers_url":"https://api.github.com/users/smcclellan7/followers","following_url":"https://api.github.com/users/smcclellan7/following{/other_user}","gists_url":"https://api.github.com/users/smcclellan7/gists{/gist_id}","starred_url":"https://api.github.com/users/smcclellan7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcclellan7/subscriptions","organizations_url":"https://api.github.com/users/smcclellan7/orgs","repos_url":"https://api.github.com/users/smcclellan7/repos","events_url":"https://api.github.com/users/smcclellan7/events{/privacy}","received_events_url":"https://api.github.com/users/smcclellan7/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-03T19:04:21Z","updated_at":"2016-11-03T19:35:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a06ce0dbb8f4519adfe271c02522fc280d1a9311","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/376/commits","review_comments_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/376/comments","review_comment_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/issues/376/comments","statuses_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/statuses/5ed4389de2dc13230a5f32119adbede920b95d0a","head":{"label":"PacificBiosciences:simulator-expect-fail","ref":"simulator-expect-fail","sha":"5ed4389de2dc13230a5f32119adbede920b95d0a","user":{"login":"PacificBiosciences","id":999745,"avatar_url":"https://avatars.githubusercontent.com/u/999745?v=3","gravatar_id":"","url":"https://api.github.com/users/PacificBiosciences","html_url":"https://github.com/PacificBiosciences","followers_url":"https://api.github.com/users/PacificBiosciences/followers","following_url":"https://api.github.com/users/PacificBiosciences/following{/other_user}","gists_url":"https://api.github.com/users/PacificBiosciences/gists{/gist_id}","starred_url":"https://api.github.com/users/PacificBiosciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PacificBiosciences/subscriptions","organizations_url":"https://api.github.com/users/PacificBiosciences/orgs","repos_url":"https://api.github.com/users/PacificBiosciences/repos","events_url":"https://api.github.com/users/PacificBiosciences/events{/privacy}","received_events_url":"https://api.github.com/users/PacificBiosciences/received_events","type":"Organization","site_admin":false},"repo":{"id":57774224,"name":"smrtflow","full_name":"PacificBiosciences/smrtflow","owner":{"login":"PacificBiosciences","id":999745,"avatar_url":"https://avatars.githubusercontent.com/u/999745?v=3","gravatar_id":"","url":"https://api.github.com/users/PacificBiosciences","html_url":"https://github.com/PacificBiosciences","followers_url":"https://api.github.com/users/PacificBiosciences/followers","following_url":"https://api.github.com/users/PacificBiosciences/following{/other_user}","gists_url":"https://api.github.com/users/PacificBiosciences/gists{/gist_id}","starred_url":"https://api.github.com/users/PacificBiosciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PacificBiosciences/subscriptions","organizations_url":"https://api.github.com/users/PacificBiosciences/orgs","repos_url":"https://api.github.com/users/PacificBiosciences/repos","events_url":"https://api.github.com/users/PacificBiosciences/events{/privacy}","received_events_url":"https://api.github.com/users/PacificBiosciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PacificBiosciences/smrtflow","description":"SMRT Link and Analysis Server, Scala analysis tools and Common models","fork":false,"url":"https://api.github.com/repos/PacificBiosciences/smrtflow","forks_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/forks","keys_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/teams","hooks_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/hooks","issue_events_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/issues/events{/number}","events_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/events","assignees_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/assignees{/user}","branches_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/branches{/branch}","tags_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/tags","blobs_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/statuses/{sha}","languages_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/languages","stargazers_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/stargazers","contributors_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/contributors","subscribers_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/subscribers","subscription_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/subscription","commits_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/contents/{+path}","compare_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/merges","archive_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/downloads","issues_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/issues{/number}","pulls_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls{/number}","milestones_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/milestones{/number}","notifications_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/labels{/name}","releases_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/releases{/id}","deployments_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/deployments","created_at":"2016-05-01T19:41:08Z","updated_at":"2016-10-25T00:22:53Z","pushed_at":"2016-11-03T19:04:24Z","git_url":"git://github.com/PacificBiosciences/smrtflow.git","ssh_url":"git@github.com:PacificBiosciences/smrtflow.git","clone_url":"https://github.com/PacificBiosciences/smrtflow.git","svn_url":"https://github.com/PacificBiosciences/smrtflow","homepage":"","size":3272,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":22,"forks":1,"open_issues":22,"watchers":4,"default_branch":"master"}},"base":{"label":"PacificBiosciences:master","ref":"master","sha":"b41f3d6ea490ad1fe4646d099663963c109cc94c","user":{"login":"PacificBiosciences","id":999745,"avatar_url":"https://avatars.githubusercontent.com/u/999745?v=3","gravatar_id":"","url":"https://api.github.com/users/PacificBiosciences","html_url":"https://github.com/PacificBiosciences","followers_url":"https://api.github.com/users/PacificBiosciences/followers","following_url":"https://api.github.com/users/PacificBiosciences/following{/other_user}","gists_url":"https://api.github.com/users/PacificBiosciences/gists{/gist_id}","starred_url":"https://api.github.com/users/PacificBiosciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PacificBiosciences/subscriptions","organizations_url":"https://api.github.com/users/PacificBiosciences/orgs","repos_url":"https://api.github.com/users/PacificBiosciences/repos","events_url":"https://api.github.com/users/PacificBiosciences/events{/privacy}","received_events_url":"https://api.github.com/users/PacificBiosciences/received_events","type":"Organization","site_admin":false},"repo":{"id":57774224,"name":"smrtflow","full_name":"PacificBiosciences/smrtflow","owner":{"login":"PacificBiosciences","id":999745,"avatar_url":"https://avatars.githubusercontent.com/u/999745?v=3","gravatar_id":"","url":"https://api.github.com/users/PacificBiosciences","html_url":"https://github.com/PacificBiosciences","followers_url":"https://api.github.com/users/PacificBiosciences/followers","following_url":"https://api.github.com/users/PacificBiosciences/following{/other_user}","gists_url":"https://api.github.com/users/PacificBiosciences/gists{/gist_id}","starred_url":"https://api.github.com/users/PacificBiosciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PacificBiosciences/subscriptions","organizations_url":"https://api.github.com/users/PacificBiosciences/orgs","repos_url":"https://api.github.com/users/PacificBiosciences/repos","events_url":"https://api.github.com/users/PacificBiosciences/events{/privacy}","received_events_url":"https://api.github.com/users/PacificBiosciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PacificBiosciences/smrtflow","description":"SMRT Link and Analysis Server, Scala analysis tools and Common models","fork":false,"url":"https://api.github.com/repos/PacificBiosciences/smrtflow","forks_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/forks","keys_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/teams","hooks_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/hooks","issue_events_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/issues/events{/number}","events_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/events","assignees_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/assignees{/user}","branches_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/branches{/branch}","tags_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/tags","blobs_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/statuses/{sha}","languages_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/languages","stargazers_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/stargazers","contributors_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/contributors","subscribers_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/subscribers","subscription_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/subscription","commits_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/contents/{+path}","compare_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/merges","archive_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/downloads","issues_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/issues{/number}","pulls_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls{/number}","milestones_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/milestones{/number}","notifications_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/labels{/name}","releases_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/releases{/id}","deployments_url":"https://api.github.com/repos/PacificBiosciences/smrtflow/deployments","created_at":"2016-05-01T19:41:08Z","updated_at":"2016-10-25T00:22:53Z","pushed_at":"2016-11-03T19:04:24Z","git_url":"git://github.com/PacificBiosciences/smrtflow.git","ssh_url":"git@github.com:PacificBiosciences/smrtflow.git","clone_url":"https://github.com/PacificBiosciences/smrtflow.git","svn_url":"https://github.com/PacificBiosciences/smrtflow","homepage":"","size":3272,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":22,"forks":1,"open_issues":22,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/376"},"html":{"href":"https://github.com/PacificBiosciences/smrtflow/pull/376"},"issue":{"href":"https://api.github.com/repos/PacificBiosciences/smrtflow/issues/376"},"comments":{"href":"https://api.github.com/repos/PacificBiosciences/smrtflow/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PacificBiosciences/smrtflow/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/PacificBiosciences/smrtflow/statuses/5ed4389de2dc13230a5f32119adbede920b95d0a"}}}}
{"actor":{"display_login":"mpkocher"}}