{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37432","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37432/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37432/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37432/events","html_url":"https://github.com/kubernetes/kubernetes/pull/37432","id":191446255,"number":37432,"title":"replace hardcored http header field names and media types with constants","user":{"login":"bruceauyeung","id":1210201,"avatar_url":"https://avatars.githubusercontent.com/u/1210201?v=3","gravatar_id":"","url":"https://api.github.com/users/bruceauyeung","html_url":"https://github.com/bruceauyeung","followers_url":"https://api.github.com/users/bruceauyeung/followers","following_url":"https://api.github.com/users/bruceauyeung/following{/other_user}","gists_url":"https://api.github.com/users/bruceauyeung/gists{/gist_id}","starred_url":"https://api.github.com/users/bruceauyeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruceauyeung/subscriptions","organizations_url":"https://api.github.com/users/bruceauyeung/orgs","repos_url":"https://api.github.com/users/bruceauyeung/repos","events_url":"https://api.github.com/users/bruceauyeung/events{/privacy}","received_events_url":"https://api.github.com/users/bruceauyeung/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":240247879,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":349530192,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2016-11-24T06:58:00Z","updated_at":"2016-12-21T00:54:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37432","html_url":"https://github.com/kubernetes/kubernetes/pull/37432","diff_url":"https://github.com/kubernetes/kubernetes/pull/37432.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37432.patch"},"body":"**What this PR does / why we need it**:\r\n\r\n1. create a new package `k8s.io/kubernetes/pkg/util/net/httpheader`, this package is designed to contain http header related helper functions and field name constants,  and is expected to be used by the whole kubernetes project.basically all http header field name constants are extracted from http://docs.oracle.com/javaee/6/api/javax/ws/rs/core/HttpHeaders.html\r\n2.  create a new package `k8s.io/kubernetes/pkg/util/net/mediatype`, this package is designed to contain media type related helper functions and media type constants,  and is expected to be used by the whole kubernetes project. basically all media type constants are extracted from http://docs.oracle.com/javaee/6/api/javax/ws/rs/core/MediaType.html\r\n3. replace hardcored http header field names and media types in apiserver conponent with corresponding constants\r\n\r\nSigned-off-by: bruceauyeung <ouyang.qinhua@zte.com.cn>\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/37432)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/268403502","html_url":"https://github.com/kubernetes/kubernetes/pull/37432#issuecomment-268403502","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37432","id":268403502,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T00:54:10Z","updated_at":"2016-12-21T00:54:10Z","body":"Jenkins Bazel Build [**failed**](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/37432/pull-kubernetes-bazel/5544878331120056068/) for commit ac333d35c22bdb8b47699e987038082fc6f0daf4. [Full PR test history](http://pr-test.k8s.io/37432).\n\nThe magic incantation to run this job again is `@k8s-bot bazel test this`. Please help us cut down flakes by linking to an [open flake issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open) when you hit one in your PR."}}
{"actor":{"display_login":"k8s-ci-robot"}}