{"action":"created","comment":{"url":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/comments/73118186","id":73118186,"diff_hunk":"@@ -26,8 +26,18 @@ protected TeamServiceImpl(final TeamRepository teamRepository) {\n \n     @Transactional\n     public Team addTeam(final Team team) {\n-        TeamEntity entity = new TeamEntity();\n+        if (team == null) {\n+             throw new IllegalArgumentException(\"Team object is NULL\");\n+        }\n+        if (team.getName() == null || team.getName().isEmpty()) {\n+            throw new TeamNameNullOrEmptyException();\n+        }\n+        // FIXME: need to check whether team already exists or not","path":"service-team/src/main/java/sg/ncl/service/team/logic/TeamServiceImpl.java","position":11,"original_position":11,"commit_id":"2efee8f27895f309ee604fcf44f9619f6ed8cebb","original_commit_id":"2efee8f27895f309ee604fcf44f9619f6ed8cebb","user":{"login":"ChrisZhong","id":1946052,"avatar_url":"https://avatars.githubusercontent.com/u/1946052?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisZhong","html_url":"https://github.com/ChrisZhong","followers_url":"https://api.github.com/users/ChrisZhong/followers","following_url":"https://api.github.com/users/ChrisZhong/following{/other_user}","gists_url":"https://api.github.com/users/ChrisZhong/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisZhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisZhong/subscriptions","organizations_url":"https://api.github.com/users/ChrisZhong/orgs","repos_url":"https://api.github.com/users/ChrisZhong/repos","events_url":"https://api.github.com/users/ChrisZhong/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisZhong/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) Take the required action to fix the issue indicated by this comment. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1134)\n","created_at":"2016-08-02T08:55:54Z","updated_at":"2016-08-02T08:55:54Z","html_url":"https://github.com/nus-ncl/services-in-one/pull/82#discussion_r73118186","pull_request_url":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/comments/73118186"},"html":{"href":"https://github.com/nus-ncl/services-in-one/pull/82#discussion_r73118186"},"pull_request":{"href":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/82","id":79684257,"html_url":"https://github.com/nus-ncl/services-in-one/pull/82","diff_url":"https://github.com/nus-ncl/services-in-one/pull/82.diff","patch_url":"https://github.com/nus-ncl/services-in-one/pull/82.patch","issue_url":"https://api.github.com/repos/nus-ncl/services-in-one/issues/82","number":82,"state":"open","locked":false,"title":"Dev 460","user":{"login":"ZHANGChunwang","id":1309315,"avatar_url":"https://avatars.githubusercontent.com/u/1309315?v=3","gravatar_id":"","url":"https://api.github.com/users/ZHANGChunwang","html_url":"https://github.com/ZHANGChunwang","followers_url":"https://api.github.com/users/ZHANGChunwang/followers","following_url":"https://api.github.com/users/ZHANGChunwang/following{/other_user}","gists_url":"https://api.github.com/users/ZHANGChunwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZHANGChunwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZHANGChunwang/subscriptions","organizations_url":"https://api.github.com/users/ZHANGChunwang/orgs","repos_url":"https://api.github.com/users/ZHANGChunwang/repos","events_url":"https://api.github.com/users/ZHANGChunwang/events{/privacy}","received_events_url":"https://api.github.com/users/ZHANGChunwang/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-02T06:52:00Z","updated_at":"2016-08-02T08:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dadada0c6a75916877832f7ad0983e9e88d02016","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/82/commits","review_comments_url":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/82/comments","review_comment_url":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-ncl/services-in-one/issues/82/comments","statuses_url":"https://api.github.com/repos/nus-ncl/services-in-one/statuses/2efee8f27895f309ee604fcf44f9619f6ed8cebb","head":{"label":"nus-ncl:DEV-460","ref":"DEV-460","sha":"2efee8f27895f309ee604fcf44f9619f6ed8cebb","user":{"login":"nus-ncl","id":15359055,"avatar_url":"https://avatars.githubusercontent.com/u/15359055?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-ncl","html_url":"https://github.com/nus-ncl","followers_url":"https://api.github.com/users/nus-ncl/followers","following_url":"https://api.github.com/users/nus-ncl/following{/other_user}","gists_url":"https://api.github.com/users/nus-ncl/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-ncl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-ncl/subscriptions","organizations_url":"https://api.github.com/users/nus-ncl/orgs","repos_url":"https://api.github.com/users/nus-ncl/repos","events_url":"https://api.github.com/users/nus-ncl/events{/privacy}","received_events_url":"https://api.github.com/users/nus-ncl/received_events","type":"Organization","site_admin":false},"repo":{"id":56112257,"name":"services-in-one","full_name":"nus-ncl/services-in-one","owner":{"login":"nus-ncl","id":15359055,"avatar_url":"https://avatars.githubusercontent.com/u/15359055?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-ncl","html_url":"https://github.com/nus-ncl","followers_url":"https://api.github.com/users/nus-ncl/followers","following_url":"https://api.github.com/users/nus-ncl/following{/other_user}","gists_url":"https://api.github.com/users/nus-ncl/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-ncl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-ncl/subscriptions","organizations_url":"https://api.github.com/users/nus-ncl/orgs","repos_url":"https://api.github.com/users/nus-ncl/repos","events_url":"https://api.github.com/users/nus-ncl/events{/privacy}","received_events_url":"https://api.github.com/users/nus-ncl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-ncl/services-in-one","description":"","fork":false,"url":"https://api.github.com/repos/nus-ncl/services-in-one","forks_url":"https://api.github.com/repos/nus-ncl/services-in-one/forks","keys_url":"https://api.github.com/repos/nus-ncl/services-in-one/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-ncl/services-in-one/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-ncl/services-in-one/teams","hooks_url":"https://api.github.com/repos/nus-ncl/services-in-one/hooks","issue_events_url":"https://api.github.com/repos/nus-ncl/services-in-one/issues/events{/number}","events_url":"https://api.github.com/repos/nus-ncl/services-in-one/events","assignees_url":"https://api.github.com/repos/nus-ncl/services-in-one/assignees{/user}","branches_url":"https://api.github.com/repos/nus-ncl/services-in-one/branches{/branch}","tags_url":"https://api.github.com/repos/nus-ncl/services-in-one/tags","blobs_url":"https://api.github.com/repos/nus-ncl/services-in-one/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-ncl/services-in-one/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-ncl/services-in-one/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-ncl/services-in-one/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-ncl/services-in-one/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-ncl/services-in-one/languages","stargazers_url":"https://api.github.com/repos/nus-ncl/services-in-one/stargazers","contributors_url":"https://api.github.com/repos/nus-ncl/services-in-one/contributors","subscribers_url":"https://api.github.com/repos/nus-ncl/services-in-one/subscribers","subscription_url":"https://api.github.com/repos/nus-ncl/services-in-one/subscription","commits_url":"https://api.github.com/repos/nus-ncl/services-in-one/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-ncl/services-in-one/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-ncl/services-in-one/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-ncl/services-in-one/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-ncl/services-in-one/contents/{+path}","compare_url":"https://api.github.com/repos/nus-ncl/services-in-one/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-ncl/services-in-one/merges","archive_url":"https://api.github.com/repos/nus-ncl/services-in-one/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-ncl/services-in-one/downloads","issues_url":"https://api.github.com/repos/nus-ncl/services-in-one/issues{/number}","pulls_url":"https://api.github.com/repos/nus-ncl/services-in-one/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-ncl/services-in-one/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-ncl/services-in-one/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-ncl/services-in-one/labels{/name}","releases_url":"https://api.github.com/repos/nus-ncl/services-in-one/releases{/id}","deployments_url":"https://api.github.com/repos/nus-ncl/services-in-one/deployments","created_at":"2016-04-13T01:52:23Z","updated_at":"2016-06-23T02:22:35Z","pushed_at":"2016-08-02T08:45:15Z","git_url":"git://github.com/nus-ncl/services-in-one.git","ssh_url":"git@github.com:nus-ncl/services-in-one.git","clone_url":"https://github.com/nus-ncl/services-in-one.git","svn_url":"https://github.com/nus-ncl/services-in-one","homepage":null,"size":1401,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-ncl:master","ref":"master","sha":"c562b7b6fb782de24bce36b0acec6df7667b0be7","user":{"login":"nus-ncl","id":15359055,"avatar_url":"https://avatars.githubusercontent.com/u/15359055?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-ncl","html_url":"https://github.com/nus-ncl","followers_url":"https://api.github.com/users/nus-ncl/followers","following_url":"https://api.github.com/users/nus-ncl/following{/other_user}","gists_url":"https://api.github.com/users/nus-ncl/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-ncl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-ncl/subscriptions","organizations_url":"https://api.github.com/users/nus-ncl/orgs","repos_url":"https://api.github.com/users/nus-ncl/repos","events_url":"https://api.github.com/users/nus-ncl/events{/privacy}","received_events_url":"https://api.github.com/users/nus-ncl/received_events","type":"Organization","site_admin":false},"repo":{"id":56112257,"name":"services-in-one","full_name":"nus-ncl/services-in-one","owner":{"login":"nus-ncl","id":15359055,"avatar_url":"https://avatars.githubusercontent.com/u/15359055?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-ncl","html_url":"https://github.com/nus-ncl","followers_url":"https://api.github.com/users/nus-ncl/followers","following_url":"https://api.github.com/users/nus-ncl/following{/other_user}","gists_url":"https://api.github.com/users/nus-ncl/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-ncl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-ncl/subscriptions","organizations_url":"https://api.github.com/users/nus-ncl/orgs","repos_url":"https://api.github.com/users/nus-ncl/repos","events_url":"https://api.github.com/users/nus-ncl/events{/privacy}","received_events_url":"https://api.github.com/users/nus-ncl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-ncl/services-in-one","description":"","fork":false,"url":"https://api.github.com/repos/nus-ncl/services-in-one","forks_url":"https://api.github.com/repos/nus-ncl/services-in-one/forks","keys_url":"https://api.github.com/repos/nus-ncl/services-in-one/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-ncl/services-in-one/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-ncl/services-in-one/teams","hooks_url":"https://api.github.com/repos/nus-ncl/services-in-one/hooks","issue_events_url":"https://api.github.com/repos/nus-ncl/services-in-one/issues/events{/number}","events_url":"https://api.github.com/repos/nus-ncl/services-in-one/events","assignees_url":"https://api.github.com/repos/nus-ncl/services-in-one/assignees{/user}","branches_url":"https://api.github.com/repos/nus-ncl/services-in-one/branches{/branch}","tags_url":"https://api.github.com/repos/nus-ncl/services-in-one/tags","blobs_url":"https://api.github.com/repos/nus-ncl/services-in-one/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-ncl/services-in-one/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-ncl/services-in-one/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-ncl/services-in-one/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-ncl/services-in-one/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-ncl/services-in-one/languages","stargazers_url":"https://api.github.com/repos/nus-ncl/services-in-one/stargazers","contributors_url":"https://api.github.com/repos/nus-ncl/services-in-one/contributors","subscribers_url":"https://api.github.com/repos/nus-ncl/services-in-one/subscribers","subscription_url":"https://api.github.com/repos/nus-ncl/services-in-one/subscription","commits_url":"https://api.github.com/repos/nus-ncl/services-in-one/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-ncl/services-in-one/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-ncl/services-in-one/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-ncl/services-in-one/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-ncl/services-in-one/contents/{+path}","compare_url":"https://api.github.com/repos/nus-ncl/services-in-one/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-ncl/services-in-one/merges","archive_url":"https://api.github.com/repos/nus-ncl/services-in-one/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-ncl/services-in-one/downloads","issues_url":"https://api.github.com/repos/nus-ncl/services-in-one/issues{/number}","pulls_url":"https://api.github.com/repos/nus-ncl/services-in-one/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-ncl/services-in-one/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-ncl/services-in-one/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-ncl/services-in-one/labels{/name}","releases_url":"https://api.github.com/repos/nus-ncl/services-in-one/releases{/id}","deployments_url":"https://api.github.com/repos/nus-ncl/services-in-one/deployments","created_at":"2016-04-13T01:52:23Z","updated_at":"2016-06-23T02:22:35Z","pushed_at":"2016-08-02T08:45:15Z","git_url":"git://github.com/nus-ncl/services-in-one.git","ssh_url":"git@github.com:nus-ncl/services-in-one.git","clone_url":"https://github.com/nus-ncl/services-in-one.git","svn_url":"https://github.com/nus-ncl/services-in-one","homepage":null,"size":1401,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/82"},"html":{"href":"https://github.com/nus-ncl/services-in-one/pull/82"},"issue":{"href":"https://api.github.com/repos/nus-ncl/services-in-one/issues/82"},"comments":{"href":"https://api.github.com/repos/nus-ncl/services-in-one/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-ncl/services-in-one/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/nus-ncl/services-in-one/statuses/2efee8f27895f309ee604fcf44f9619f6ed8cebb"}}}}
{"actor":{"display_login":"ChrisZhong"}}