{"action":"created","comment":{"url":"https://api.github.com/repos/friendica/friendica/pulls/comments/93170522","pull_request_review_id":13691724,"id":93170522,"diff_hunk":"@@ -337,7 +337,7 @@ function events_content(&$a) {\n \t\t\tforeach($r as $rr) {\n \t\t\t\t$j = (($rr['adjust']) ? datetime_convert('UTC',date_default_timezone_get(),$rr['start'], 'j') : datetime_convert('UTC','UTC',$rr['start'],'j'));\n \t\t\t\tif(! x($links,$j))\n-\t\t\t\t\t$links[$j] = $a->get_baseurl() . '/' . $a->cmd . '#link-' . $j;\n+\t\t\t\t\t$links[$j] = App::get_baseurl() . '/' . $a->cmd . '#link-' . $j;","path":"mod/events.php","position":41,"original_position":41,"commit_id":"884f44ce94de8fdf26a40751dfd4b61b29765d29","original_commit_id":"884f44ce94de8fdf26a40751dfd4b61b29765d29","user":{"login":"Hypolite","id":925415,"avatar_url":"https://avatars.githubusercontent.com/u/925415?v=3","gravatar_id":"","url":"https://api.github.com/users/Hypolite","html_url":"https://github.com/Hypolite","followers_url":"https://api.github.com/users/Hypolite/followers","following_url":"https://api.github.com/users/Hypolite/following{/other_user}","gists_url":"https://api.github.com/users/Hypolite/gists{/gist_id}","starred_url":"https://api.github.com/users/Hypolite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hypolite/subscriptions","organizations_url":"https://api.github.com/users/Hypolite/orgs","repos_url":"https://api.github.com/users/Hypolite/repos","events_url":"https://api.github.com/users/Hypolite/events{/privacy}","received_events_url":"https://api.github.com/users/Hypolite/received_events","type":"User","site_admin":false},"body":"Standards: Can you please add brackets to this conditional statement? 🙂","created_at":"2016-12-20T04:35:57Z","updated_at":"2016-12-20T04:45:23Z","html_url":"https://github.com/friendica/friendica/pull/3027#discussion_r93170522","pull_request_url":"https://api.github.com/repos/friendica/friendica/pulls/3027","_links":{"self":{"href":"https://api.github.com/repos/friendica/friendica/pulls/comments/93170522"},"html":{"href":"https://github.com/friendica/friendica/pull/3027#discussion_r93170522"},"pull_request":{"href":"https://api.github.com/repos/friendica/friendica/pulls/3027"}}},"pull_request":{"url":"https://api.github.com/repos/friendica/friendica/pulls/3027","id":98568474,"html_url":"https://github.com/friendica/friendica/pull/3027","diff_url":"https://github.com/friendica/friendica/pull/3027.diff","patch_url":"https://github.com/friendica/friendica/pull/3027.patch","issue_url":"https://api.github.com/repos/friendica/friendica/issues/3027","number":3027,"state":"open","locked":false,"title":"App::get_baseurl() used more (code convention).","user":{"login":"Quix0r","id":470798,"avatar_url":"https://avatars.githubusercontent.com/u/470798?v=3","gravatar_id":"","url":"https://api.github.com/users/Quix0r","html_url":"https://github.com/Quix0r","followers_url":"https://api.github.com/users/Quix0r/followers","following_url":"https://api.github.com/users/Quix0r/following{/other_user}","gists_url":"https://api.github.com/users/Quix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Quix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quix0r/subscriptions","organizations_url":"https://api.github.com/users/Quix0r/orgs","repos_url":"https://api.github.com/users/Quix0r/repos","events_url":"https://api.github.com/users/Quix0r/events{/privacy}","received_events_url":"https://api.github.com/users/Quix0r/received_events","type":"User","site_admin":false},"body":"I have changed more `$a->get_baseurl()` to `App::get_baseurl()` as in my previous merge request #3010.","created_at":"2016-12-19T13:52:00Z","updated_at":"2016-12-20T04:45:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c3e5d2ef50dc41ed7990a2538710600c8585819","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/friendica/friendica/pulls/3027/commits","review_comments_url":"https://api.github.com/repos/friendica/friendica/pulls/3027/comments","review_comment_url":"https://api.github.com/repos/friendica/friendica/pulls/comments{/number}","comments_url":"https://api.github.com/repos/friendica/friendica/issues/3027/comments","statuses_url":"https://api.github.com/repos/friendica/friendica/statuses/884f44ce94de8fdf26a40751dfd4b61b29765d29","head":{"label":"Quix0r:rewrites/app_get_baseurl_static","ref":"rewrites/app_get_baseurl_static","sha":"884f44ce94de8fdf26a40751dfd4b61b29765d29","user":{"login":"Quix0r","id":470798,"avatar_url":"https://avatars.githubusercontent.com/u/470798?v=3","gravatar_id":"","url":"https://api.github.com/users/Quix0r","html_url":"https://github.com/Quix0r","followers_url":"https://api.github.com/users/Quix0r/followers","following_url":"https://api.github.com/users/Quix0r/following{/other_user}","gists_url":"https://api.github.com/users/Quix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Quix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quix0r/subscriptions","organizations_url":"https://api.github.com/users/Quix0r/orgs","repos_url":"https://api.github.com/users/Quix0r/repos","events_url":"https://api.github.com/users/Quix0r/events{/privacy}","received_events_url":"https://api.github.com/users/Quix0r/received_events","type":"User","site_admin":false},"repo":{"id":52880546,"name":"friendica","full_name":"Quix0r/friendica","owner":{"login":"Quix0r","id":470798,"avatar_url":"https://avatars.githubusercontent.com/u/470798?v=3","gravatar_id":"","url":"https://api.github.com/users/Quix0r","html_url":"https://github.com/Quix0r","followers_url":"https://api.github.com/users/Quix0r/followers","following_url":"https://api.github.com/users/Quix0r/following{/other_user}","gists_url":"https://api.github.com/users/Quix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Quix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quix0r/subscriptions","organizations_url":"https://api.github.com/users/Quix0r/orgs","repos_url":"https://api.github.com/users/Quix0r/repos","events_url":"https://api.github.com/users/Quix0r/events{/privacy}","received_events_url":"https://api.github.com/users/Quix0r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Quix0r/friendica","description":"Friendica Communications Platform","fork":true,"url":"https://api.github.com/repos/Quix0r/friendica","forks_url":"https://api.github.com/repos/Quix0r/friendica/forks","keys_url":"https://api.github.com/repos/Quix0r/friendica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Quix0r/friendica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Quix0r/friendica/teams","hooks_url":"https://api.github.com/repos/Quix0r/friendica/hooks","issue_events_url":"https://api.github.com/repos/Quix0r/friendica/issues/events{/number}","events_url":"https://api.github.com/repos/Quix0r/friendica/events","assignees_url":"https://api.github.com/repos/Quix0r/friendica/assignees{/user}","branches_url":"https://api.github.com/repos/Quix0r/friendica/branches{/branch}","tags_url":"https://api.github.com/repos/Quix0r/friendica/tags","blobs_url":"https://api.github.com/repos/Quix0r/friendica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Quix0r/friendica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Quix0r/friendica/git/refs{/sha}","trees_url":"https://api.github.com/repos/Quix0r/friendica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Quix0r/friendica/statuses/{sha}","languages_url":"https://api.github.com/repos/Quix0r/friendica/languages","stargazers_url":"https://api.github.com/repos/Quix0r/friendica/stargazers","contributors_url":"https://api.github.com/repos/Quix0r/friendica/contributors","subscribers_url":"https://api.github.com/repos/Quix0r/friendica/subscribers","subscription_url":"https://api.github.com/repos/Quix0r/friendica/subscription","commits_url":"https://api.github.com/repos/Quix0r/friendica/commits{/sha}","git_commits_url":"https://api.github.com/repos/Quix0r/friendica/git/commits{/sha}","comments_url":"https://api.github.com/repos/Quix0r/friendica/comments{/number}","issue_comment_url":"https://api.github.com/repos/Quix0r/friendica/issues/comments{/number}","contents_url":"https://api.github.com/repos/Quix0r/friendica/contents/{+path}","compare_url":"https://api.github.com/repos/Quix0r/friendica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Quix0r/friendica/merges","archive_url":"https://api.github.com/repos/Quix0r/friendica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Quix0r/friendica/downloads","issues_url":"https://api.github.com/repos/Quix0r/friendica/issues{/number}","pulls_url":"https://api.github.com/repos/Quix0r/friendica/pulls{/number}","milestones_url":"https://api.github.com/repos/Quix0r/friendica/milestones{/number}","notifications_url":"https://api.github.com/repos/Quix0r/friendica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Quix0r/friendica/labels{/name}","releases_url":"https://api.github.com/repos/Quix0r/friendica/releases{/id}","deployments_url":"https://api.github.com/repos/Quix0r/friendica/deployments","created_at":"2016-03-01T13:56:00Z","updated_at":"2016-03-01T13:56:05Z","pushed_at":"2016-12-19T13:48:54Z","git_url":"git://github.com/Quix0r/friendica.git","ssh_url":"git@github.com:Quix0r/friendica.git","clone_url":"https://github.com/Quix0r/friendica.git","svn_url":"https://github.com/Quix0r/friendica","homepage":"","size":70513,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"friendica:develop","ref":"develop","sha":"52f12ee28db97b29ce0f10c8ecf76144b80d4216","user":{"login":"friendica","id":1176581,"avatar_url":"https://avatars.githubusercontent.com/u/1176581?v=3","gravatar_id":"","url":"https://api.github.com/users/friendica","html_url":"https://github.com/friendica","followers_url":"https://api.github.com/users/friendica/followers","following_url":"https://api.github.com/users/friendica/following{/other_user}","gists_url":"https://api.github.com/users/friendica/gists{/gist_id}","starred_url":"https://api.github.com/users/friendica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendica/subscriptions","organizations_url":"https://api.github.com/users/friendica/orgs","repos_url":"https://api.github.com/users/friendica/repos","events_url":"https://api.github.com/users/friendica/events{/privacy}","received_events_url":"https://api.github.com/users/friendica/received_events","type":"User","site_admin":false},"repo":{"id":2722709,"name":"friendica","full_name":"friendica/friendica","owner":{"login":"friendica","id":1176581,"avatar_url":"https://avatars.githubusercontent.com/u/1176581?v=3","gravatar_id":"","url":"https://api.github.com/users/friendica","html_url":"https://github.com/friendica","followers_url":"https://api.github.com/users/friendica/followers","following_url":"https://api.github.com/users/friendica/following{/other_user}","gists_url":"https://api.github.com/users/friendica/gists{/gist_id}","starred_url":"https://api.github.com/users/friendica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendica/subscriptions","organizations_url":"https://api.github.com/users/friendica/orgs","repos_url":"https://api.github.com/users/friendica/repos","events_url":"https://api.github.com/users/friendica/events{/privacy}","received_events_url":"https://api.github.com/users/friendica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/friendica/friendica","description":"Friendica Communications Platform","fork":true,"url":"https://api.github.com/repos/friendica/friendica","forks_url":"https://api.github.com/repos/friendica/friendica/forks","keys_url":"https://api.github.com/repos/friendica/friendica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/friendica/friendica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/friendica/friendica/teams","hooks_url":"https://api.github.com/repos/friendica/friendica/hooks","issue_events_url":"https://api.github.com/repos/friendica/friendica/issues/events{/number}","events_url":"https://api.github.com/repos/friendica/friendica/events","assignees_url":"https://api.github.com/repos/friendica/friendica/assignees{/user}","branches_url":"https://api.github.com/repos/friendica/friendica/branches{/branch}","tags_url":"https://api.github.com/repos/friendica/friendica/tags","blobs_url":"https://api.github.com/repos/friendica/friendica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/friendica/friendica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/friendica/friendica/git/refs{/sha}","trees_url":"https://api.github.com/repos/friendica/friendica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/friendica/friendica/statuses/{sha}","languages_url":"https://api.github.com/repos/friendica/friendica/languages","stargazers_url":"https://api.github.com/repos/friendica/friendica/stargazers","contributors_url":"https://api.github.com/repos/friendica/friendica/contributors","subscribers_url":"https://api.github.com/repos/friendica/friendica/subscribers","subscription_url":"https://api.github.com/repos/friendica/friendica/subscription","commits_url":"https://api.github.com/repos/friendica/friendica/commits{/sha}","git_commits_url":"https://api.github.com/repos/friendica/friendica/git/commits{/sha}","comments_url":"https://api.github.com/repos/friendica/friendica/comments{/number}","issue_comment_url":"https://api.github.com/repos/friendica/friendica/issues/comments{/number}","contents_url":"https://api.github.com/repos/friendica/friendica/contents/{+path}","compare_url":"https://api.github.com/repos/friendica/friendica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/friendica/friendica/merges","archive_url":"https://api.github.com/repos/friendica/friendica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/friendica/friendica/downloads","issues_url":"https://api.github.com/repos/friendica/friendica/issues{/number}","pulls_url":"https://api.github.com/repos/friendica/friendica/pulls{/number}","milestones_url":"https://api.github.com/repos/friendica/friendica/milestones{/number}","notifications_url":"https://api.github.com/repos/friendica/friendica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/friendica/friendica/labels{/name}","releases_url":"https://api.github.com/repos/friendica/friendica/releases{/id}","deployments_url":"https://api.github.com/repos/friendica/friendica/deployments","created_at":"2011-11-06T22:19:41Z","updated_at":"2016-12-16T16:55:58Z","pushed_at":"2016-12-20T04:31:16Z","git_url":"git://github.com/friendica/friendica.git","ssh_url":"git@github.com:friendica/friendica.git","clone_url":"https://github.com/friendica/friendica.git","svn_url":"https://github.com/friendica/friendica","homepage":"","size":70201,"stargazers_count":434,"watchers_count":434,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":164,"mirror_url":null,"open_issues_count":248,"forks":164,"open_issues":248,"watchers":434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/friendica/friendica/pulls/3027"},"html":{"href":"https://github.com/friendica/friendica/pull/3027"},"issue":{"href":"https://api.github.com/repos/friendica/friendica/issues/3027"},"comments":{"href":"https://api.github.com/repos/friendica/friendica/issues/3027/comments"},"review_comments":{"href":"https://api.github.com/repos/friendica/friendica/pulls/3027/comments"},"review_comment":{"href":"https://api.github.com/repos/friendica/friendica/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/friendica/friendica/pulls/3027/commits"},"statuses":{"href":"https://api.github.com/repos/friendica/friendica/statuses/884f44ce94de8fdf26a40751dfd4b61b29765d29"}}}}
{"actor":{"display_login":"Hypolite"}}