{"comment":{"url":"https://api.github.com/repos/arp7/hadoop/comments/19778095","html_url":"https://github.com/arp7/hadoop/commit/b703b138630a7d8481be7778906a9764d5387172#commitcomment-19778095","id":19778095,"user":{"login":"xiaoyuyao","id":7039184,"avatar_url":"https://avatars.githubusercontent.com/u/7039184?v=3","gravatar_id":"","url":"https://api.github.com/users/xiaoyuyao","html_url":"https://github.com/xiaoyuyao","followers_url":"https://api.github.com/users/xiaoyuyao/followers","following_url":"https://api.github.com/users/xiaoyuyao/following{/other_user}","gists_url":"https://api.github.com/users/xiaoyuyao/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaoyuyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaoyuyao/subscriptions","organizations_url":"https://api.github.com/users/xiaoyuyao/orgs","repos_url":"https://api.github.com/users/xiaoyuyao/repos","events_url":"https://api.github.com/users/xiaoyuyao/events{/privacy}","received_events_url":"https://api.github.com/users/xiaoyuyao/received_events","type":"User","site_admin":false},"position":40,"line":342,"path":"hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java","commit_id":"b703b138630a7d8481be7778906a9764d5387172","created_at":"2016-11-10T22:08:22Z","updated_at":"2016-11-10T22:08:22Z","body":"I did some search of code base and found this is the one usage of FileUtils.moveFile() when making this change. There are other places like BlockPoolSlice#moveLazyPersistReplicasToFinalized() where we use NativeIO.renameTo directly to move meta/block file from lazy persist directory to finalized directory. I think it is good to make it consistent. Let me know your thoughts. "}}
{"actor":{"display_login":"xiaoyuyao"}}