{"action":"closed","number":1240,"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1240","id":96291764,"html_url":"https://github.com/hibernate/hibernate-search/pull/1240","diff_url":"https://github.com/hibernate/hibernate-search/pull/1240.diff","patch_url":"https://github.com/hibernate/hibernate-search/pull/1240.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1240","number":1240,"state":"closed","locked":false,"title":"HSEARCH-2415 Extend indexNullAs type checking to potentially any field bridge","user":{"login":"yrodiere","id":412878,"avatar_url":"https://avatars.githubusercontent.com/u/412878?v=3","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"body":"https://hibernate.atlassian.net/browse/HSEARCH-2415\r\n\r\nThe issue is that, with Elasticsearch, some indexed string values must have a specific format in order to be indexed. For instance, dates must follow the ISO-8601 format.\r\n\r\nWe don't check if that format is followed on `Field.indexNullAs` for string fields, so badly formatted indexNullAs strings are hard to debug. Which is why we added type checking in [HSEARCH-2262](https://hibernate.atlassian.net/browse/HSEARCH-2262).\r\n\r\nBut I missed java 8 time types... And those are not easy to implement, because each one has its own very specific format.\r\n\r\nThis PR fixes the issue by making indexNullAs parsing a bridge responsibility. It makes sense because, currently, it's the field bridge that is responsible for encoding values in the exact format required by the indexing service. This responsibility [might move away from field bridges in the future](https://hibernate.atlassian.net/browse/HSEARCH-2462), but probably not before 6.0.","created_at":"2016-12-02T14:46:26Z","updated_at":"2016-12-05T19:11:31Z","closed_at":"2016-12-05T19:11:31Z","merged_at":null,"merge_commit_sha":"6cddbab42789409d169b55384949f8984187dc36","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1240/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1240/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1240/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/149fa0a9d022f2b19bb6d28924823b168b6e7327","head":{"label":"yrodiere:HSEARCH-2415","ref":"HSEARCH-2415","sha":"149fa0a9d022f2b19bb6d28924823b168b6e7327","user":{"login":"yrodiere","id":412878,"avatar_url":"https://avatars.githubusercontent.com/u/412878?v=3","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"repo":{"id":56803577,"name":"hibernate-search","full_name":"yrodiere/hibernate-search","owner":{"login":"yrodiere","id":412878,"avatar_url":"https://avatars.githubusercontent.com/u/412878?v=3","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yrodiere/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":true,"url":"https://api.github.com/repos/yrodiere/hibernate-search","forks_url":"https://api.github.com/repos/yrodiere/hibernate-search/forks","keys_url":"https://api.github.com/repos/yrodiere/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yrodiere/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yrodiere/hibernate-search/teams","hooks_url":"https://api.github.com/repos/yrodiere/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/yrodiere/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/yrodiere/hibernate-search/events","assignees_url":"https://api.github.com/repos/yrodiere/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/yrodiere/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/yrodiere/hibernate-search/tags","blobs_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yrodiere/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/yrodiere/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/yrodiere/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/yrodiere/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/yrodiere/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/yrodiere/hibernate-search/subscription","commits_url":"https://api.github.com/repos/yrodiere/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/yrodiere/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/yrodiere/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/yrodiere/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/yrodiere/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yrodiere/hibernate-search/merges","archive_url":"https://api.github.com/repos/yrodiere/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yrodiere/hibernate-search/downloads","issues_url":"https://api.github.com/repos/yrodiere/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/yrodiere/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/yrodiere/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/yrodiere/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yrodiere/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/yrodiere/hibernate-search/releases{/id}","deployments_url":"https://api.github.com/repos/yrodiere/hibernate-search/deployments","created_at":"2016-04-21T20:27:30Z","updated_at":"2016-04-21T20:27:35Z","pushed_at":"2016-12-05T17:38:06Z","git_url":"git://github.com/yrodiere/hibernate-search.git","ssh_url":"git@github.com:yrodiere/hibernate-search.git","clone_url":"https://github.com/yrodiere/hibernate-search.git","svn_url":"https://github.com/yrodiere/hibernate-search","homepage":"http://search.hibernate.org","size":46942,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"2a4be0c5e1ae8d43b5af5b77a95872f4f85335ae","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":990281,"name":"hibernate-search","full_name":"hibernate/hibernate-search","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-search","forks_url":"https://api.github.com/repos/hibernate/hibernate-search/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-search/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-search/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-search/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-search/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-search/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-search/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-search/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-search/deployments","created_at":"2010-10-15T15:55:09Z","updated_at":"2016-11-17T14:39:20Z","pushed_at":"2016-12-05T19:10:26Z","git_url":"git://github.com/hibernate/hibernate-search.git","ssh_url":"git@github.com:hibernate/hibernate-search.git","clone_url":"https://github.com/hibernate/hibernate-search.git","svn_url":"https://github.com/hibernate/hibernate-search","homepage":"http://search.hibernate.org","size":56939,"stargazers_count":197,"watchers_count":197,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":14,"forks":145,"open_issues":14,"watchers":197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1240"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/1240"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/1240"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/1240/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1240/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1240/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-search/statuses/149fa0a9d022f2b19bb6d28924823b168b6e7327"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":7,"commits":9,"additions":1807,"deletions":451,"changed_files":58}}
{"actor":{"display_login":"Sanne"}}