{"action":"created","comment":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/81051194","pull_request_review_id":2059938,"id":81051194,"diff_hunk":"@@ -17,10 +17,25 @@ if (NOT D_COMPILER_DMD_COMPAT)\n     message(FATAL_ERROR \"We currently only support building using a D compiler with a DMD-compatible commandline interface. (try 'ldmd2' or 'gdmd')\")\n endif()\n \n+# Helper function\n+function(append value)\n+    foreach(variable ${ARGN})\n+        if(${variable} STREQUAL \"\")\n+            set(${variable} \"${value}\" PARENT_SCOPE)\n+        else()\n+            set(${variable} \"${${variable}} ${value}\" PARENT_SCOPE)\n+        endif()\n+    endforeach(variable)\n+endfunction()\n+\n+option(LDC_WITH_DCOMPUTE_SPIRV \"Enable Dcompute to generate SPIR-V kernels for targetting OpenCL, requires a Khronos llvm\")\n+mark_as_advanced(LDC_WITH_DCOMPUTE_SPIRV)\n+if(LDC_WITH_DCOMPUTE_SPIRV)\n+    append(EXTRA_LLVM_MODULES sprivlib) #The .a is libLLVMSPIRVLib with the extra \"Lib\" on the end so need sprivlib not spirv","path":"CMakeLists.txt","position":18,"original_position":18,"commit_id":"c7bc3f0774c71297aa32a13dbac64212bbc67adc","original_commit_id":"c7bc3f0774c71297aa32a13dbac64212bbc67adc","user":{"login":"thewilsonator","id":6802489,"avatar_url":"https://avatars.githubusercontent.com/u/6802489?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilsonator","html_url":"https://github.com/thewilsonator","followers_url":"https://api.github.com/users/thewilsonator/followers","following_url":"https://api.github.com/users/thewilsonator/following{/other_user}","gists_url":"https://api.github.com/users/thewilsonator/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilsonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilsonator/subscriptions","organizations_url":"https://api.github.com/users/thewilsonator/orgs","repos_url":"https://api.github.com/users/thewilsonator/repos","events_url":"https://api.github.com/users/thewilsonator/events{/privacy}","received_events_url":"https://api.github.com/users/thewilsonator/received_events","type":"User","site_admin":false},"body":"OK, will remove.\r\n","created_at":"2016-09-29T01:33:32Z","updated_at":"2016-09-29T01:33:32Z","html_url":"https://github.com/ldc-developers/ldc/pull/1795#discussion_r81051194","pull_request_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1795","_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/81051194"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1795#discussion_r81051194"},"pull_request":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1795"}}},"pull_request":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1795","id":87124337,"html_url":"https://github.com/ldc-developers/ldc/pull/1795","diff_url":"https://github.com/ldc-developers/ldc/pull/1795.diff","patch_url":"https://github.com/ldc-developers/ldc/pull/1795.patch","issue_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1795","number":1795,"state":"open","locked":false,"title":"dcompute: Enable linking with libLLVMSPRIVlib.a","user":{"login":"thewilsonator","id":6802489,"avatar_url":"https://avatars.githubusercontent.com/u/6802489?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilsonator","html_url":"https://github.com/thewilsonator","followers_url":"https://api.github.com/users/thewilsonator/followers","following_url":"https://api.github.com/users/thewilsonator/following{/other_user}","gists_url":"https://api.github.com/users/thewilsonator/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilsonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilsonator/subscriptions","organizations_url":"https://api.github.com/users/thewilsonator/orgs","repos_url":"https://api.github.com/users/thewilsonator/repos","events_url":"https://api.github.com/users/thewilsonator/events{/privacy}","received_events_url":"https://api.github.com/users/thewilsonator/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-28T13:52:57Z","updated_at":"2016-09-29T01:33:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebf467969e543bfc6c85e2abfc140f0f5df21b49","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1795/commits","review_comments_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1795/comments","review_comment_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1795/comments","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/c7bc3f0774c71297aa32a13dbac64212bbc67adc","head":{"label":"thewilsonator:dcompute-cmake","ref":"dcompute-cmake","sha":"c7bc3f0774c71297aa32a13dbac64212bbc67adc","user":{"login":"thewilsonator","id":6802489,"avatar_url":"https://avatars.githubusercontent.com/u/6802489?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilsonator","html_url":"https://github.com/thewilsonator","followers_url":"https://api.github.com/users/thewilsonator/followers","following_url":"https://api.github.com/users/thewilsonator/following{/other_user}","gists_url":"https://api.github.com/users/thewilsonator/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilsonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilsonator/subscriptions","organizations_url":"https://api.github.com/users/thewilsonator/orgs","repos_url":"https://api.github.com/users/thewilsonator/repos","events_url":"https://api.github.com/users/thewilsonator/events{/privacy}","received_events_url":"https://api.github.com/users/thewilsonator/received_events","type":"User","site_admin":false},"repo":{"id":62774759,"name":"ldc","full_name":"thewilsonator/ldc","owner":{"login":"thewilsonator","id":6802489,"avatar_url":"https://avatars.githubusercontent.com/u/6802489?v=3","gravatar_id":"","url":"https://api.github.com/users/thewilsonator","html_url":"https://github.com/thewilsonator","followers_url":"https://api.github.com/users/thewilsonator/followers","following_url":"https://api.github.com/users/thewilsonator/following{/other_user}","gists_url":"https://api.github.com/users/thewilsonator/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilsonator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilsonator/subscriptions","organizations_url":"https://api.github.com/users/thewilsonator/orgs","repos_url":"https://api.github.com/users/thewilsonator/repos","events_url":"https://api.github.com/users/thewilsonator/events{/privacy}","received_events_url":"https://api.github.com/users/thewilsonator/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thewilsonator/ldc","description":"The LLVM-based D compiler.","fork":true,"url":"https://api.github.com/repos/thewilsonator/ldc","forks_url":"https://api.github.com/repos/thewilsonator/ldc/forks","keys_url":"https://api.github.com/repos/thewilsonator/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thewilsonator/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thewilsonator/ldc/teams","hooks_url":"https://api.github.com/repos/thewilsonator/ldc/hooks","issue_events_url":"https://api.github.com/repos/thewilsonator/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/thewilsonator/ldc/events","assignees_url":"https://api.github.com/repos/thewilsonator/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/thewilsonator/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/thewilsonator/ldc/tags","blobs_url":"https://api.github.com/repos/thewilsonator/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thewilsonator/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thewilsonator/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/thewilsonator/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thewilsonator/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/thewilsonator/ldc/languages","stargazers_url":"https://api.github.com/repos/thewilsonator/ldc/stargazers","contributors_url":"https://api.github.com/repos/thewilsonator/ldc/contributors","subscribers_url":"https://api.github.com/repos/thewilsonator/ldc/subscribers","subscription_url":"https://api.github.com/repos/thewilsonator/ldc/subscription","commits_url":"https://api.github.com/repos/thewilsonator/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/thewilsonator/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/thewilsonator/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/thewilsonator/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/thewilsonator/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/thewilsonator/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thewilsonator/ldc/merges","archive_url":"https://api.github.com/repos/thewilsonator/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thewilsonator/ldc/downloads","issues_url":"https://api.github.com/repos/thewilsonator/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/thewilsonator/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/thewilsonator/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/thewilsonator/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thewilsonator/ldc/labels{/name}","releases_url":"https://api.github.com/repos/thewilsonator/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/thewilsonator/ldc/deployments","created_at":"2016-07-07T04:19:58Z","updated_at":"2016-09-20T05:33:40Z","pushed_at":"2016-09-29T00:51:51Z","git_url":"git://github.com/thewilsonator/ldc.git","ssh_url":"git@github.com:thewilsonator/ldc.git","clone_url":"https://github.com/thewilsonator/ldc.git","svn_url":"https://github.com/thewilsonator/ldc","homepage":"http://wiki.dlang.org/LDC","size":26138,"stargazers_count":3,"watchers_count":3,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ldc-developers:master","ref":"master","sha":"5580d4966f6e4d8f16242aef730bc8351210dd0b","user":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":2174666,"name":"ldc","full_name":"ldc-developers/ldc","owner":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ldc-developers/ldc","description":"The LLVM-based D compiler.","fork":false,"url":"https://api.github.com/repos/ldc-developers/ldc","forks_url":"https://api.github.com/repos/ldc-developers/ldc/forks","keys_url":"https://api.github.com/repos/ldc-developers/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldc-developers/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldc-developers/ldc/teams","hooks_url":"https://api.github.com/repos/ldc-developers/ldc/hooks","issue_events_url":"https://api.github.com/repos/ldc-developers/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/ldc-developers/ldc/events","assignees_url":"https://api.github.com/repos/ldc-developers/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/ldc-developers/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/ldc-developers/ldc/tags","blobs_url":"https://api.github.com/repos/ldc-developers/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldc-developers/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldc-developers/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldc-developers/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/ldc-developers/ldc/languages","stargazers_url":"https://api.github.com/repos/ldc-developers/ldc/stargazers","contributors_url":"https://api.github.com/repos/ldc-developers/ldc/contributors","subscribers_url":"https://api.github.com/repos/ldc-developers/ldc/subscribers","subscription_url":"https://api.github.com/repos/ldc-developers/ldc/subscription","commits_url":"https://api.github.com/repos/ldc-developers/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldc-developers/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldc-developers/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldc-developers/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/ldc-developers/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldc-developers/ldc/merges","archive_url":"https://api.github.com/repos/ldc-developers/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldc-developers/ldc/downloads","issues_url":"https://api.github.com/repos/ldc-developers/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/ldc-developers/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/ldc-developers/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/ldc-developers/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldc-developers/ldc/labels{/name}","releases_url":"https://api.github.com/repos/ldc-developers/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/ldc-developers/ldc/deployments","created_at":"2011-08-08T17:10:27Z","updated_at":"2016-09-26T21:49:25Z","pushed_at":"2016-09-29T00:51:51Z","git_url":"git://github.com/ldc-developers/ldc.git","ssh_url":"git@github.com:ldc-developers/ldc.git","clone_url":"https://github.com/ldc-developers/ldc.git","svn_url":"https://github.com/ldc-developers/ldc","homepage":"http://wiki.dlang.org/LDC","size":30317,"stargazers_count":495,"watchers_count":495,"language":"D","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":104,"mirror_url":null,"open_issues_count":185,"forks":104,"open_issues":185,"watchers":495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1795"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1795"},"issue":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1795"},"comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1795/comments"},"review_comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1795/comments"},"review_comment":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1795/commits"},"statuses":{"href":"https://api.github.com/repos/ldc-developers/ldc/statuses/c7bc3f0774c71297aa32a13dbac64212bbc67adc"}}}}
{"actor":{"display_login":"thewilsonator"}}