{"action":"created","comment":{"url":"https://api.github.com/repos/samtools/htsjdk/pulls/comments/57921551","id":57921551,"diff_hunk":"@@ -73,6 +74,34 @@ private boolean typeSafeEquals(final SAMBinaryTagAndValue that) {\n         }\n     }\n \n+    private boolean valueEquals(SAMBinaryTagAndValue that) {\n+        if (this.value == null) {\n+            return that.value == null;\n+        }\n+        else if (that.value == null) {\n+            return false;\n+        }\n+        else if (this.value instanceof byte[]) {\n+            return that.value instanceof byte[] ?\n+                Arrays.equals((byte[])this.value, (byte[])that.value) : false;\n+        }\n+        else if (this.value instanceof short[]) {\n+            return that.value instanceof short[] ?\n+                    Arrays.equals((short[])this.value, (short[])that.value) : false;\n+        }\n+        else if (this.value instanceof int[]) {\n+            return that.value instanceof int[] ?\n+                    Arrays.equals((int[])this.value, (int[])that.value) : false;\n+        }\n+        else if (this.value instanceof float[]) {\n+            return that.value instanceof float[] ?\n+                    Arrays.equals((float[])this.value, (float[])that.value) : false;\n+        }\n+        else {\n+            return this.value.equals(that.value);","path":"src/java/htsjdk/samtools/SAMBinaryTagAndValue.java","position":45,"original_position":45,"commit_id":"72b333c0a66796fd600a909f707b9678a8396718","original_commit_id":"72b333c0a66796fd600a909f707b9678a8396718","user":{"login":"lbergelson","id":4700332,"avatar_url":"https://avatars.githubusercontent.com/u/4700332?v=3","gravatar_id":"","url":"https://api.github.com/users/lbergelson","html_url":"https://github.com/lbergelson","followers_url":"https://api.github.com/users/lbergelson/followers","following_url":"https://api.github.com/users/lbergelson/following{/other_user}","gists_url":"https://api.github.com/users/lbergelson/gists{/gist_id}","starred_url":"https://api.github.com/users/lbergelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbergelson/subscriptions","organizations_url":"https://api.github.com/users/lbergelson/orgs","repos_url":"https://api.github.com/users/lbergelson/repos","events_url":"https://api.github.com/users/lbergelson/events{/privacy}","received_events_url":"https://api.github.com/users/lbergelson/received_events","type":"User","site_admin":false},"body":"Could you include a note explaining why double, char, and long aren't included?","created_at":"2016-03-30T16:41:22Z","updated_at":"2016-03-30T16:41:22Z","html_url":"https://github.com/samtools/htsjdk/pull/543#discussion_r57921551","pull_request_url":"https://api.github.com/repos/samtools/htsjdk/pulls/543","_links":{"self":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/comments/57921551"},"html":{"href":"https://github.com/samtools/htsjdk/pull/543#discussion_r57921551"},"pull_request":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/543"}}},"pull_request":{"url":"https://api.github.com/repos/samtools/htsjdk/pulls/543","id":64647261,"html_url":"https://github.com/samtools/htsjdk/pull/543","diff_url":"https://github.com/samtools/htsjdk/pull/543.diff","patch_url":"https://github.com/samtools/htsjdk/pull/543.patch","issue_url":"https://api.github.com/repos/samtools/htsjdk/issues/543","number":543,"state":"open","locked":false,"title":"Miscellaneous minor bug fixes for SAMRecord, BAMIndexer.","user":{"login":"cmnbroad","id":10062863,"avatar_url":"https://avatars.githubusercontent.com/u/10062863?v=3","gravatar_id":"","url":"https://api.github.com/users/cmnbroad","html_url":"https://github.com/cmnbroad","followers_url":"https://api.github.com/users/cmnbroad/followers","following_url":"https://api.github.com/users/cmnbroad/following{/other_user}","gists_url":"https://api.github.com/users/cmnbroad/gists{/gist_id}","starred_url":"https://api.github.com/users/cmnbroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmnbroad/subscriptions","organizations_url":"https://api.github.com/users/cmnbroad/orgs","repos_url":"https://api.github.com/users/cmnbroad/repos","events_url":"https://api.github.com/users/cmnbroad/events{/privacy}","received_events_url":"https://api.github.com/users/cmnbroad/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/samtools/htsjdk/issues/512, https://github.com/samtools/htsjdk/issues/402, and a couple of gratuitous javadoc fixes.","created_at":"2016-03-30T15:29:14Z","updated_at":"2016-03-30T16:41:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"911565b85a58f33b97ef5f44764e618a6f4ddff3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/samtools/htsjdk/pulls/543/commits","review_comments_url":"https://api.github.com/repos/samtools/htsjdk/pulls/543/comments","review_comment_url":"https://api.github.com/repos/samtools/htsjdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samtools/htsjdk/issues/543/comments","statuses_url":"https://api.github.com/repos/samtools/htsjdk/statuses/72b333c0a66796fd600a909f707b9678a8396718","head":{"label":"cmnbroad:cn_misc_fixes","ref":"cn_misc_fixes","sha":"72b333c0a66796fd600a909f707b9678a8396718","user":{"login":"cmnbroad","id":10062863,"avatar_url":"https://avatars.githubusercontent.com/u/10062863?v=3","gravatar_id":"","url":"https://api.github.com/users/cmnbroad","html_url":"https://github.com/cmnbroad","followers_url":"https://api.github.com/users/cmnbroad/followers","following_url":"https://api.github.com/users/cmnbroad/following{/other_user}","gists_url":"https://api.github.com/users/cmnbroad/gists{/gist_id}","starred_url":"https://api.github.com/users/cmnbroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmnbroad/subscriptions","organizations_url":"https://api.github.com/users/cmnbroad/orgs","repos_url":"https://api.github.com/users/cmnbroad/repos","events_url":"https://api.github.com/users/cmnbroad/events{/privacy}","received_events_url":"https://api.github.com/users/cmnbroad/received_events","type":"User","site_admin":false},"repo":{"id":41918188,"name":"htsjdk","full_name":"cmnbroad/htsjdk","owner":{"login":"cmnbroad","id":10062863,"avatar_url":"https://avatars.githubusercontent.com/u/10062863?v=3","gravatar_id":"","url":"https://api.github.com/users/cmnbroad","html_url":"https://github.com/cmnbroad","followers_url":"https://api.github.com/users/cmnbroad/followers","following_url":"https://api.github.com/users/cmnbroad/following{/other_user}","gists_url":"https://api.github.com/users/cmnbroad/gists{/gist_id}","starred_url":"https://api.github.com/users/cmnbroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmnbroad/subscriptions","organizations_url":"https://api.github.com/users/cmnbroad/orgs","repos_url":"https://api.github.com/users/cmnbroad/repos","events_url":"https://api.github.com/users/cmnbroad/events{/privacy}","received_events_url":"https://api.github.com/users/cmnbroad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmnbroad/htsjdk","description":"A Java API for high-throughput sequencing data (HTS) formats.","fork":true,"url":"https://api.github.com/repos/cmnbroad/htsjdk","forks_url":"https://api.github.com/repos/cmnbroad/htsjdk/forks","keys_url":"https://api.github.com/repos/cmnbroad/htsjdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmnbroad/htsjdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmnbroad/htsjdk/teams","hooks_url":"https://api.github.com/repos/cmnbroad/htsjdk/hooks","issue_events_url":"https://api.github.com/repos/cmnbroad/htsjdk/issues/events{/number}","events_url":"https://api.github.com/repos/cmnbroad/htsjdk/events","assignees_url":"https://api.github.com/repos/cmnbroad/htsjdk/assignees{/user}","branches_url":"https://api.github.com/repos/cmnbroad/htsjdk/branches{/branch}","tags_url":"https://api.github.com/repos/cmnbroad/htsjdk/tags","blobs_url":"https://api.github.com/repos/cmnbroad/htsjdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmnbroad/htsjdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmnbroad/htsjdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmnbroad/htsjdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmnbroad/htsjdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cmnbroad/htsjdk/languages","stargazers_url":"https://api.github.com/repos/cmnbroad/htsjdk/stargazers","contributors_url":"https://api.github.com/repos/cmnbroad/htsjdk/contributors","subscribers_url":"https://api.github.com/repos/cmnbroad/htsjdk/subscribers","subscription_url":"https://api.github.com/repos/cmnbroad/htsjdk/subscription","commits_url":"https://api.github.com/repos/cmnbroad/htsjdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmnbroad/htsjdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmnbroad/htsjdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmnbroad/htsjdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmnbroad/htsjdk/contents/{+path}","compare_url":"https://api.github.com/repos/cmnbroad/htsjdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmnbroad/htsjdk/merges","archive_url":"https://api.github.com/repos/cmnbroad/htsjdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmnbroad/htsjdk/downloads","issues_url":"https://api.github.com/repos/cmnbroad/htsjdk/issues{/number}","pulls_url":"https://api.github.com/repos/cmnbroad/htsjdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cmnbroad/htsjdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cmnbroad/htsjdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmnbroad/htsjdk/labels{/name}","releases_url":"https://api.github.com/repos/cmnbroad/htsjdk/releases{/id}","deployments_url":"https://api.github.com/repos/cmnbroad/htsjdk/deployments","created_at":"2015-09-04T13:47:19Z","updated_at":"2016-01-20T15:56:14Z","pushed_at":"2016-03-30T15:25:59Z","git_url":"git://github.com/cmnbroad/htsjdk.git","ssh_url":"git@github.com:cmnbroad/htsjdk.git","clone_url":"https://github.com/cmnbroad/htsjdk.git","svn_url":"https://github.com/cmnbroad/htsjdk","homepage":"http://samtools.github.io/htsjdk/","size":57783,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samtools:master","ref":"master","sha":"72a3f6cb9fdcfc03e432274a41e302e0b588311c","user":{"login":"samtools","id":1518450,"avatar_url":"https://avatars.githubusercontent.com/u/1518450?v=3","gravatar_id":"","url":"https://api.github.com/users/samtools","html_url":"https://github.com/samtools","followers_url":"https://api.github.com/users/samtools/followers","following_url":"https://api.github.com/users/samtools/following{/other_user}","gists_url":"https://api.github.com/users/samtools/gists{/gist_id}","starred_url":"https://api.github.com/users/samtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samtools/subscriptions","organizations_url":"https://api.github.com/users/samtools/orgs","repos_url":"https://api.github.com/users/samtools/repos","events_url":"https://api.github.com/users/samtools/events{/privacy}","received_events_url":"https://api.github.com/users/samtools/received_events","type":"Organization","site_admin":false},"repo":{"id":19272315,"name":"htsjdk","full_name":"samtools/htsjdk","owner":{"login":"samtools","id":1518450,"avatar_url":"https://avatars.githubusercontent.com/u/1518450?v=3","gravatar_id":"","url":"https://api.github.com/users/samtools","html_url":"https://github.com/samtools","followers_url":"https://api.github.com/users/samtools/followers","following_url":"https://api.github.com/users/samtools/following{/other_user}","gists_url":"https://api.github.com/users/samtools/gists{/gist_id}","starred_url":"https://api.github.com/users/samtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samtools/subscriptions","organizations_url":"https://api.github.com/users/samtools/orgs","repos_url":"https://api.github.com/users/samtools/repos","events_url":"https://api.github.com/users/samtools/events{/privacy}","received_events_url":"https://api.github.com/users/samtools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samtools/htsjdk","description":"A Java API for high-throughput sequencing data (HTS) formats.","fork":false,"url":"https://api.github.com/repos/samtools/htsjdk","forks_url":"https://api.github.com/repos/samtools/htsjdk/forks","keys_url":"https://api.github.com/repos/samtools/htsjdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samtools/htsjdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samtools/htsjdk/teams","hooks_url":"https://api.github.com/repos/samtools/htsjdk/hooks","issue_events_url":"https://api.github.com/repos/samtools/htsjdk/issues/events{/number}","events_url":"https://api.github.com/repos/samtools/htsjdk/events","assignees_url":"https://api.github.com/repos/samtools/htsjdk/assignees{/user}","branches_url":"https://api.github.com/repos/samtools/htsjdk/branches{/branch}","tags_url":"https://api.github.com/repos/samtools/htsjdk/tags","blobs_url":"https://api.github.com/repos/samtools/htsjdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samtools/htsjdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samtools/htsjdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/samtools/htsjdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samtools/htsjdk/statuses/{sha}","languages_url":"https://api.github.com/repos/samtools/htsjdk/languages","stargazers_url":"https://api.github.com/repos/samtools/htsjdk/stargazers","contributors_url":"https://api.github.com/repos/samtools/htsjdk/contributors","subscribers_url":"https://api.github.com/repos/samtools/htsjdk/subscribers","subscription_url":"https://api.github.com/repos/samtools/htsjdk/subscription","commits_url":"https://api.github.com/repos/samtools/htsjdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/samtools/htsjdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/samtools/htsjdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/samtools/htsjdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/samtools/htsjdk/contents/{+path}","compare_url":"https://api.github.com/repos/samtools/htsjdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samtools/htsjdk/merges","archive_url":"https://api.github.com/repos/samtools/htsjdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samtools/htsjdk/downloads","issues_url":"https://api.github.com/repos/samtools/htsjdk/issues{/number}","pulls_url":"https://api.github.com/repos/samtools/htsjdk/pulls{/number}","milestones_url":"https://api.github.com/repos/samtools/htsjdk/milestones{/number}","notifications_url":"https://api.github.com/repos/samtools/htsjdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samtools/htsjdk/labels{/name}","releases_url":"https://api.github.com/repos/samtools/htsjdk/releases{/id}","deployments_url":"https://api.github.com/repos/samtools/htsjdk/deployments","created_at":"2014-04-29T10:11:28Z","updated_at":"2016-03-28T21:39:56Z","pushed_at":"2016-03-30T15:29:14Z","git_url":"git://github.com/samtools/htsjdk.git","ssh_url":"git@github.com:samtools/htsjdk.git","clone_url":"https://github.com/samtools/htsjdk.git","svn_url":"https://github.com/samtools/htsjdk","homepage":"http://samtools.github.io/htsjdk/","size":68058,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":107,"mirror_url":null,"open_issues_count":124,"forks":107,"open_issues":124,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/543"},"html":{"href":"https://github.com/samtools/htsjdk/pull/543"},"issue":{"href":"https://api.github.com/repos/samtools/htsjdk/issues/543"},"comments":{"href":"https://api.github.com/repos/samtools/htsjdk/issues/543/comments"},"review_comments":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/543/comments"},"review_comment":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/543/commits"},"statuses":{"href":"https://api.github.com/repos/samtools/htsjdk/statuses/72b333c0a66796fd600a909f707b9678a8396718"}}}}