{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments/54266953","id":54266953,"diff_hunk":"@@ -1482,6 +1488,41 @@ Configure this port-channel interface to be a vPC peer-link. A vPC peer-link is\n ###### `vrf`\n VRF member of the interface.  Valid values are a string or the keyword 'default'.\n \n+##### STP config attributes\n+\n+##### `stp_bpdufilter`\n+Enable/Disable BPDU filter for this interface. Valid values are enable, disable or 'default'.\n+\n+##### `stp_bpduguard`\n+Enable/Disable BPDU guard for this interface. Valid values are enable, disable or 'default'.\n+\n+##### `stp_cost`\n+path cost. Valid values are integer, 'auto' or 'default'.","path":"README.md","position":47,"original_position":47,"commit_id":"e010b2eae91db39311eae37af8a0f587992c2536","original_commit_id":"e010b2eae91db39311eae37af8a0f587992c2536","user":{"login":"mikewiebe","id":12445795,"avatar_url":"https://avatars.githubusercontent.com/u/12445795?v=3","gravatar_id":"","url":"https://api.github.com/users/mikewiebe","html_url":"https://github.com/mikewiebe","followers_url":"https://api.github.com/users/mikewiebe/followers","following_url":"https://api.github.com/users/mikewiebe/following{/other_user}","gists_url":"https://api.github.com/users/mikewiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewiebe/subscriptions","organizations_url":"https://api.github.com/users/mikewiebe/orgs","repos_url":"https://api.github.com/users/mikewiebe/repos","events_url":"https://api.github.com/users/mikewiebe/events{/privacy}","received_events_url":"https://api.github.com/users/mikewiebe/received_events","type":"User","site_admin":false},"body":"*nit* Start with upper case: `Path cost.`  Also change properties below.","created_at":"2016-02-26T16:40:03Z","updated_at":"2016-02-26T16:40:03Z","html_url":"https://github.com/cisco/cisco-network-puppet-module/pull/215#discussion_r54266953","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/215","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments/54266953"},"html":{"href":"https://github.com/cisco/cisco-network-puppet-module/pull/215#discussion_r54266953"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/215"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/215","id":60599355,"html_url":"https://github.com/cisco/cisco-network-puppet-module/pull/215","diff_url":"https://github.com/cisco/cisco-network-puppet-module/pull/215.diff","patch_url":"https://github.com/cisco/cisco-network-puppet-module/pull/215.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/215","number":215,"state":"open","locked":false,"title":"Feature/stp global","user":{"login":"saichint","id":15788941,"avatar_url":"https://avatars.githubusercontent.com/u/15788941?v=3","gravatar_id":"","url":"https://api.github.com/users/saichint","html_url":"https://github.com/saichint","followers_url":"https://api.github.com/users/saichint/followers","following_url":"https://api.github.com/users/saichint/following{/other_user}","gists_url":"https://api.github.com/users/saichint/gists{/gist_id}","starred_url":"https://api.github.com/users/saichint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saichint/subscriptions","organizations_url":"https://api.github.com/users/saichint/orgs","repos_url":"https://api.github.com/users/saichint/repos","events_url":"https://api.github.com/users/saichint/events{/privacy}","received_events_url":"https://api.github.com/users/saichint/received_events","type":"User","site_admin":false},"body":"Since stp is has range based attributes, the design was discussed thoroughly with Mike, Chris, Deepak and Sanjay. It would be better if Mike or Chris can do this code review since they have the most background related to this design.\r\n\r\nstp design assumptions:\r\nThere are lot of range based commands in spanning-tree and these ranges dynamically change based on the input. \r\nTo simplify this, we assume:\r\n\r\nAll the multiple ranges given in the manifest will not overlap each other for any given attribute. If they do, it will result in failure.\r\nFor ex:\r\n\r\nvlan_hello_time => [['5,7,13,15-42', '10'], ['83-92,100-230', '5']] -----> correct\r\n\r\nvlan_hello_time => [['5,7,13,15-42', '10'], ['6-100', '5']] -----> not correct\r\n\r\nThe ranges which are not given in the manifest will NOT be set to default. (In future, a new attribute \"purge\" will be added which can be used to alter this behavior)\r\n\r\nFor ex:\r\nvlan_hello_time => [['2,7,13,15-42', '10'], ['3,10-11,100-230', '5']]\r\nIn this case, the vlan_hello_time for [1,4-6,8-9,12,14,43-99,231-3967] will be left as before.\r\nSo if the user needs a particular range to go to default, set that range to 'default' explicitly.\r\n\r\nBridge_domain related attributes are specific to n7k.\r\n\r\nCurrently there is no bridge-domain provider/type. Because of this, the beaker tests are run separately once for vlan and once for bridge-domain (for n7k only). The reason is that some bd related varibales need to be set on the switch before the tests are run and so the tests are run mutually exclusive of each other. So in the beaker test file, bridge domain related tests are commented out. \r\n\r\nHowever, the test results are all attached when they were run separately. Same thing goes for demo manifest as well. There are 2 manifests and once of them is commented out.\r\n\r\nTest results (including demo manifest results). The per interface stp tests are also included in each of the following files:\r\n\r\n[n6k_stp_global.txt](https://github.com/cisco/cisco-network-puppet-module/files/145659/n6k_stp_global.txt)\r\n[n7k_stp_global.txt](https://github.com/cisco/cisco-network-puppet-module/files/145660/n7k_stp_global.txt)\r\n[n9k_stp_global.txt](https://github.com/cisco/cisco-network-puppet-module/files/145661/n9k_stp_global.txt)\r\n","created_at":"2016-02-24T23:39:22Z","updated_at":"2016-02-26T16:40:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f45e0023af888efd342051fcf92a41e64e70924f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/215/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/215/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/215/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/e010b2eae91db39311eae37af8a0f587992c2536","head":{"label":"saichint:feature/stp_global","ref":"feature/stp_global","sha":"e010b2eae91db39311eae37af8a0f587992c2536","user":{"login":"saichint","id":15788941,"avatar_url":"https://avatars.githubusercontent.com/u/15788941?v=3","gravatar_id":"","url":"https://api.github.com/users/saichint","html_url":"https://github.com/saichint","followers_url":"https://api.github.com/users/saichint/followers","following_url":"https://api.github.com/users/saichint/following{/other_user}","gists_url":"https://api.github.com/users/saichint/gists{/gist_id}","starred_url":"https://api.github.com/users/saichint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saichint/subscriptions","organizations_url":"https://api.github.com/users/saichint/orgs","repos_url":"https://api.github.com/users/saichint/repos","events_url":"https://api.github.com/users/saichint/events{/privacy}","received_events_url":"https://api.github.com/users/saichint/received_events","type":"User","site_admin":false},"repo":{"id":45934683,"name":"cisco-network-puppet-module","full_name":"saichint/cisco-network-puppet-module","owner":{"login":"saichint","id":15788941,"avatar_url":"https://avatars.githubusercontent.com/u/15788941?v=3","gravatar_id":"","url":"https://api.github.com/users/saichint","html_url":"https://github.com/saichint","followers_url":"https://api.github.com/users/saichint/followers","following_url":"https://api.github.com/users/saichint/following{/other_user}","gists_url":"https://api.github.com/users/saichint/gists{/gist_id}","starred_url":"https://api.github.com/users/saichint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saichint/subscriptions","organizations_url":"https://api.github.com/users/saichint/orgs","repos_url":"https://api.github.com/users/saichint/repos","events_url":"https://api.github.com/users/saichint/events{/privacy}","received_events_url":"https://api.github.com/users/saichint/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saichint/cisco-network-puppet-module","description":"","fork":true,"url":"https://api.github.com/repos/saichint/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/releases{/id}","deployments_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/deployments","created_at":"2015-11-10T19:20:01Z","updated_at":"2016-02-11T02:10:36Z","pushed_at":"2016-02-25T23:33:18Z","git_url":"git://github.com/saichint/cisco-network-puppet-module.git","ssh_url":"git@github.com:saichint/cisco-network-puppet-module.git","clone_url":"https://github.com/saichint/cisco-network-puppet-module.git","svn_url":"https://github.com/saichint/cisco-network-puppet-module","homepage":null,"size":2416,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"cisco:develop","ref":"develop","sha":"abaf8b400c66deeb1639e8265442fc7ea21d8eef","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565139,"name":"cisco-network-puppet-module","full_name":"cisco/cisco-network-puppet-module","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-puppet-module","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/releases{/id}","deployments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/deployments","created_at":"2015-07-23T12:06:48Z","updated_at":"2016-02-12T17:01:51Z","pushed_at":"2016-02-25T18:19:22Z","git_url":"git://github.com/cisco/cisco-network-puppet-module.git","ssh_url":"git@github.com:cisco/cisco-network-puppet-module.git","clone_url":"https://github.com/cisco/cisco-network-puppet-module.git","svn_url":"https://github.com/cisco/cisco-network-puppet-module","homepage":null,"size":3432,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":4,"forks":31,"open_issues":4,"watchers":11,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/215"},"html":{"href":"https://github.com/cisco/cisco-network-puppet-module/pull/215"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/215"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/e010b2eae91db39311eae37af8a0f587992c2536"}}}}