{"action":"created","comment":{"url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/comments/64698563","id":64698563,"diff_hunk":"@@ -17,7 +17,7 @@ class Monitor {\n     this._resourceInterval = null;\n   }\n \n-  async reportError(err, level='error') {\n+  async reportError(err, level='error', tags={}) {","path":"src/monitor.js","position":5,"original_position":5,"commit_id":"ad7eacd2200ce0b59243b8bccf91595a69ee75b0","original_commit_id":"ad7eacd2200ce0b59243b8bccf91595a69ee75b0","user":{"login":"jonasfj","id":149732,"avatar_url":"https://avatars.githubusercontent.com/u/149732?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasfj","html_url":"https://github.com/jonasfj","followers_url":"https://api.github.com/users/jonasfj/followers","following_url":"https://api.github.com/users/jonasfj/following{/other_user}","gists_url":"https://api.github.com/users/jonasfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasfj/subscriptions","organizations_url":"https://api.github.com/users/jonasfj/orgs","repos_url":"https://api.github.com/users/jonasfj/repos","events_url":"https://api.github.com/users/jonasfj/events{/privacy}","received_events_url":"https://api.github.com/users/jonasfj/received_events","type":"User","site_admin":false},"body":"So let's change the behavior here...\r\n\r\nIMO let's make two methods reportError(errOrText, tags) and reportWarning(errOrText, tags)\r\n\r\nNote, that if tags for reportError is the string 'warning' we can handle that as a special case for backwards compatibility... and eventually remove support for that...\r\n\r\nHow does that sound... I know if error and warning levels, if there are more we want to support... maybe it's better to have only reportError(errOrText, level, tags) but then if level is an object set tags= level and level=error..\r\nSo you don't have to supply a level argument for error which is the common case...","created_at":"2016-05-26T06:50:09Z","updated_at":"2016-05-26T06:50:09Z","html_url":"https://github.com/taskcluster/taskcluster-lib-monitor/pull/19#discussion_r64698563","pull_request_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/comments/64698563"},"html":{"href":"https://github.com/taskcluster/taskcluster-lib-monitor/pull/19#discussion_r64698563"},"pull_request":{"href":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/19","id":71481837,"html_url":"https://github.com/taskcluster/taskcluster-lib-monitor/pull/19","diff_url":"https://github.com/taskcluster/taskcluster-lib-monitor/pull/19.diff","patch_url":"https://github.com/taskcluster/taskcluster-lib-monitor/pull/19.patch","issue_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/issues/19","number":19,"state":"open","locked":false,"title":"Add tags about process and prefix to sentry errors","user":{"login":"imbstack","id":127521,"avatar_url":"https://avatars.githubusercontent.com/u/127521?v=3","gravatar_id":"","url":"https://api.github.com/users/imbstack","html_url":"https://github.com/imbstack","followers_url":"https://api.github.com/users/imbstack/followers","following_url":"https://api.github.com/users/imbstack/following{/other_user}","gists_url":"https://api.github.com/users/imbstack/gists{/gist_id}","starred_url":"https://api.github.com/users/imbstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imbstack/subscriptions","organizations_url":"https://api.github.com/users/imbstack/orgs","repos_url":"https://api.github.com/users/imbstack/repos","events_url":"https://api.github.com/users/imbstack/events{/privacy}","received_events_url":"https://api.github.com/users/imbstack/received_events","type":"User","site_admin":false},"body":"This might help a bit with debugging queue I hope?","created_at":"2016-05-26T00:00:05Z","updated_at":"2016-05-26T06:50:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"692d082b6b0dae615c67880d970c9e43e34a67ab","assignee":{"login":"jonasfj","id":149732,"avatar_url":"https://avatars.githubusercontent.com/u/149732?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasfj","html_url":"https://github.com/jonasfj","followers_url":"https://api.github.com/users/jonasfj/followers","following_url":"https://api.github.com/users/jonasfj/following{/other_user}","gists_url":"https://api.github.com/users/jonasfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasfj/subscriptions","organizations_url":"https://api.github.com/users/jonasfj/orgs","repos_url":"https://api.github.com/users/jonasfj/repos","events_url":"https://api.github.com/users/jonasfj/events{/privacy}","received_events_url":"https://api.github.com/users/jonasfj/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/19/commits","review_comments_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/19/comments","review_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/issues/19/comments","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/statuses/ad7eacd2200ce0b59243b8bccf91595a69ee75b0","head":{"label":"taskcluster:tags","ref":"tags","sha":"ad7eacd2200ce0b59243b8bccf91595a69ee75b0","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":55525788,"name":"taskcluster-lib-monitor","full_name":"taskcluster/taskcluster-lib-monitor","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-lib-monitor","description":"Make it easy to hook up monitoring and metrics for taskcluster services.","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/deployments","created_at":"2016-04-05T16:54:22Z","updated_at":"2016-05-23T21:50:13Z","pushed_at":"2016-05-26T00:42:06Z","git_url":"git://github.com/taskcluster/taskcluster-lib-monitor.git","ssh_url":"git@github.com:taskcluster/taskcluster-lib-monitor.git","clone_url":"https://github.com/taskcluster/taskcluster-lib-monitor.git","svn_url":"https://github.com/taskcluster/taskcluster-lib-monitor","homepage":null,"size":77,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"taskcluster:master","ref":"master","sha":"b5eff144618d8b8e9ef6b50512225eddfbe38b03","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":55525788,"name":"taskcluster-lib-monitor","full_name":"taskcluster/taskcluster-lib-monitor","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-lib-monitor","description":"Make it easy to hook up monitoring and metrics for taskcluster services.","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/deployments","created_at":"2016-04-05T16:54:22Z","updated_at":"2016-05-23T21:50:13Z","pushed_at":"2016-05-26T00:42:06Z","git_url":"git://github.com/taskcluster/taskcluster-lib-monitor.git","ssh_url":"git@github.com:taskcluster/taskcluster-lib-monitor.git","clone_url":"https://github.com/taskcluster/taskcluster-lib-monitor.git","svn_url":"https://github.com/taskcluster/taskcluster-lib-monitor","homepage":null,"size":77,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/19"},"html":{"href":"https://github.com/taskcluster/taskcluster-lib-monitor/pull/19"},"issue":{"href":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/issues/19"},"comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/taskcluster-lib-monitor/statuses/ad7eacd2200ce0b59243b8bccf91595a69ee75b0"}}}}
{"actor":{"display_login":"jonasfj"}}