{"action":"created","comment":{"url":"https://api.github.com/repos/Moya/Moya/pulls/comments/81140165","pull_request_review_id":2141357,"id":81140165,"diff_hunk":"@@ -42,3 +42,24 @@ extension MyService: TargetType {\n //...\n }\n ```\n+\n+\n+Important Note\n+--------------\n+You **have to** add optional parameters like shown above, one per line. Optional parameters won't be removed in case of ```nil``` if you try to initialize them within one line, e.g.:\n+\n+```swift\n+//...\n+\tpublic var parameters: [String: Any]? {\n+\t    switch self {\n+\t    case .users(let limit):\n+\t        let params: [String: Any] = [\"limit\": limit]\n+\t        return params\n+        default:","path":"docs/Examples/OptionalParameters.md","position":17,"original_position":17,"commit_id":"59f00032dd28aae83adbd73c864db403a0f2ba0c","original_commit_id":"59f00032dd28aae83adbd73c864db403a0f2ba0c","user":{"login":"sunshinejr","id":5232779,"avatar_url":"https://avatars.githubusercontent.com/u/5232779?v=3","gravatar_id":"","url":"https://api.github.com/users/sunshinejr","html_url":"https://github.com/sunshinejr","followers_url":"https://api.github.com/users/sunshinejr/followers","following_url":"https://api.github.com/users/sunshinejr/following{/other_user}","gists_url":"https://api.github.com/users/sunshinejr/gists{/gist_id}","starred_url":"https://api.github.com/users/sunshinejr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunshinejr/subscriptions","organizations_url":"https://api.github.com/users/sunshinejr/orgs","repos_url":"https://api.github.com/users/sunshinejr/repos","events_url":"https://api.github.com/users/sunshinejr/events{/privacy}","received_events_url":"https://api.github.com/users/sunshinejr/received_events","type":"User","site_admin":false},"body":"Could you align vertically with `case .users`? ","created_at":"2016-09-29T13:48:27Z","updated_at":"2016-09-29T13:48:27Z","html_url":"https://github.com/Moya/Moya/pull/694#discussion_r81140165","pull_request_url":"https://api.github.com/repos/Moya/Moya/pulls/694","_links":{"self":{"href":"https://api.github.com/repos/Moya/Moya/pulls/comments/81140165"},"html":{"href":"https://github.com/Moya/Moya/pull/694#discussion_r81140165"},"pull_request":{"href":"https://api.github.com/repos/Moya/Moya/pulls/694"}}},"pull_request":{"url":"https://api.github.com/repos/Moya/Moya/pulls/694","id":87259917,"html_url":"https://github.com/Moya/Moya/pull/694","diff_url":"https://github.com/Moya/Moya/pull/694.diff","patch_url":"https://github.com/Moya/Moya/pull/694.patch","issue_url":"https://api.github.com/repos/Moya/Moya/issues/694","number":694,"state":"open","locked":false,"title":"Added Important Note","user":{"login":"fear731","id":3381717,"avatar_url":"https://avatars.githubusercontent.com/u/3381717?v=3","gravatar_id":"","url":"https://api.github.com/users/fear731","html_url":"https://github.com/fear731","followers_url":"https://api.github.com/users/fear731/followers","following_url":"https://api.github.com/users/fear731/following{/other_user}","gists_url":"https://api.github.com/users/fear731/gists{/gist_id}","starred_url":"https://api.github.com/users/fear731/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fear731/subscriptions","organizations_url":"https://api.github.com/users/fear731/orgs","repos_url":"https://api.github.com/users/fear731/repos","events_url":"https://api.github.com/users/fear731/events{/privacy}","received_events_url":"https://api.github.com/users/fear731/received_events","type":"User","site_admin":false},"body":"When I initially tried to initialize all parameters within one line, I found out that the parameters won't be removed from the request if their value is ```nil```, nor unwrapped if they contain a value.\r\nAdded a hint to the example to avoid that wrong implementation for others.","created_at":"2016-09-29T07:32:30Z","updated_at":"2016-09-29T13:48:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d8086e87e9141e098d8870b2c24b38a6caa131a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Moya/Moya/pulls/694/commits","review_comments_url":"https://api.github.com/repos/Moya/Moya/pulls/694/comments","review_comment_url":"https://api.github.com/repos/Moya/Moya/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Moya/Moya/issues/694/comments","statuses_url":"https://api.github.com/repos/Moya/Moya/statuses/59f00032dd28aae83adbd73c864db403a0f2ba0c","head":{"label":"fear731:patch-1","ref":"patch-1","sha":"59f00032dd28aae83adbd73c864db403a0f2ba0c","user":{"login":"fear731","id":3381717,"avatar_url":"https://avatars.githubusercontent.com/u/3381717?v=3","gravatar_id":"","url":"https://api.github.com/users/fear731","html_url":"https://github.com/fear731","followers_url":"https://api.github.com/users/fear731/followers","following_url":"https://api.github.com/users/fear731/following{/other_user}","gists_url":"https://api.github.com/users/fear731/gists{/gist_id}","starred_url":"https://api.github.com/users/fear731/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fear731/subscriptions","organizations_url":"https://api.github.com/users/fear731/orgs","repos_url":"https://api.github.com/users/fear731/repos","events_url":"https://api.github.com/users/fear731/events{/privacy}","received_events_url":"https://api.github.com/users/fear731/received_events","type":"User","site_admin":false},"repo":{"id":69541608,"name":"Moya","full_name":"fear731/Moya","owner":{"login":"fear731","id":3381717,"avatar_url":"https://avatars.githubusercontent.com/u/3381717?v=3","gravatar_id":"","url":"https://api.github.com/users/fear731","html_url":"https://github.com/fear731","followers_url":"https://api.github.com/users/fear731/followers","following_url":"https://api.github.com/users/fear731/following{/other_user}","gists_url":"https://api.github.com/users/fear731/gists{/gist_id}","starred_url":"https://api.github.com/users/fear731/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fear731/subscriptions","organizations_url":"https://api.github.com/users/fear731/orgs","repos_url":"https://api.github.com/users/fear731/repos","events_url":"https://api.github.com/users/fear731/events{/privacy}","received_events_url":"https://api.github.com/users/fear731/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fear731/Moya","description":"Network abstraction layer written in Swift.","fork":true,"url":"https://api.github.com/repos/fear731/Moya","forks_url":"https://api.github.com/repos/fear731/Moya/forks","keys_url":"https://api.github.com/repos/fear731/Moya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fear731/Moya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fear731/Moya/teams","hooks_url":"https://api.github.com/repos/fear731/Moya/hooks","issue_events_url":"https://api.github.com/repos/fear731/Moya/issues/events{/number}","events_url":"https://api.github.com/repos/fear731/Moya/events","assignees_url":"https://api.github.com/repos/fear731/Moya/assignees{/user}","branches_url":"https://api.github.com/repos/fear731/Moya/branches{/branch}","tags_url":"https://api.github.com/repos/fear731/Moya/tags","blobs_url":"https://api.github.com/repos/fear731/Moya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fear731/Moya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fear731/Moya/git/refs{/sha}","trees_url":"https://api.github.com/repos/fear731/Moya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fear731/Moya/statuses/{sha}","languages_url":"https://api.github.com/repos/fear731/Moya/languages","stargazers_url":"https://api.github.com/repos/fear731/Moya/stargazers","contributors_url":"https://api.github.com/repos/fear731/Moya/contributors","subscribers_url":"https://api.github.com/repos/fear731/Moya/subscribers","subscription_url":"https://api.github.com/repos/fear731/Moya/subscription","commits_url":"https://api.github.com/repos/fear731/Moya/commits{/sha}","git_commits_url":"https://api.github.com/repos/fear731/Moya/git/commits{/sha}","comments_url":"https://api.github.com/repos/fear731/Moya/comments{/number}","issue_comment_url":"https://api.github.com/repos/fear731/Moya/issues/comments{/number}","contents_url":"https://api.github.com/repos/fear731/Moya/contents/{+path}","compare_url":"https://api.github.com/repos/fear731/Moya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fear731/Moya/merges","archive_url":"https://api.github.com/repos/fear731/Moya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fear731/Moya/downloads","issues_url":"https://api.github.com/repos/fear731/Moya/issues{/number}","pulls_url":"https://api.github.com/repos/fear731/Moya/pulls{/number}","milestones_url":"https://api.github.com/repos/fear731/Moya/milestones{/number}","notifications_url":"https://api.github.com/repos/fear731/Moya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fear731/Moya/labels{/name}","releases_url":"https://api.github.com/repos/fear731/Moya/releases{/id}","deployments_url":"https://api.github.com/repos/fear731/Moya/deployments","created_at":"2016-09-29T07:20:47Z","updated_at":"2016-09-29T07:20:49Z","pushed_at":"2016-09-29T13:32:41Z","git_url":"git://github.com/fear731/Moya.git","ssh_url":"git@github.com:fear731/Moya.git","clone_url":"https://github.com/fear731/Moya.git","svn_url":"https://github.com/fear731/Moya","homepage":"","size":6376,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Moya:master","ref":"master","sha":"8e3e9a08825a145de44dcb645938ddac4fca67a4","user":{"login":"Moya","id":13662162,"avatar_url":"https://avatars.githubusercontent.com/u/13662162?v=3","gravatar_id":"","url":"https://api.github.com/users/Moya","html_url":"https://github.com/Moya","followers_url":"https://api.github.com/users/Moya/followers","following_url":"https://api.github.com/users/Moya/following{/other_user}","gists_url":"https://api.github.com/users/Moya/gists{/gist_id}","starred_url":"https://api.github.com/users/Moya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moya/subscriptions","organizations_url":"https://api.github.com/users/Moya/orgs","repos_url":"https://api.github.com/users/Moya/repos","events_url":"https://api.github.com/users/Moya/events{/privacy}","received_events_url":"https://api.github.com/users/Moya/received_events","type":"Organization","site_admin":false},"repo":{"id":23013268,"name":"Moya","full_name":"Moya/Moya","owner":{"login":"Moya","id":13662162,"avatar_url":"https://avatars.githubusercontent.com/u/13662162?v=3","gravatar_id":"","url":"https://api.github.com/users/Moya","html_url":"https://github.com/Moya","followers_url":"https://api.github.com/users/Moya/followers","following_url":"https://api.github.com/users/Moya/following{/other_user}","gists_url":"https://api.github.com/users/Moya/gists{/gist_id}","starred_url":"https://api.github.com/users/Moya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moya/subscriptions","organizations_url":"https://api.github.com/users/Moya/orgs","repos_url":"https://api.github.com/users/Moya/repos","events_url":"https://api.github.com/users/Moya/events{/privacy}","received_events_url":"https://api.github.com/users/Moya/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Moya/Moya","description":"Network abstraction layer written in Swift.","fork":false,"url":"https://api.github.com/repos/Moya/Moya","forks_url":"https://api.github.com/repos/Moya/Moya/forks","keys_url":"https://api.github.com/repos/Moya/Moya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Moya/Moya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Moya/Moya/teams","hooks_url":"https://api.github.com/repos/Moya/Moya/hooks","issue_events_url":"https://api.github.com/repos/Moya/Moya/issues/events{/number}","events_url":"https://api.github.com/repos/Moya/Moya/events","assignees_url":"https://api.github.com/repos/Moya/Moya/assignees{/user}","branches_url":"https://api.github.com/repos/Moya/Moya/branches{/branch}","tags_url":"https://api.github.com/repos/Moya/Moya/tags","blobs_url":"https://api.github.com/repos/Moya/Moya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Moya/Moya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Moya/Moya/git/refs{/sha}","trees_url":"https://api.github.com/repos/Moya/Moya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Moya/Moya/statuses/{sha}","languages_url":"https://api.github.com/repos/Moya/Moya/languages","stargazers_url":"https://api.github.com/repos/Moya/Moya/stargazers","contributors_url":"https://api.github.com/repos/Moya/Moya/contributors","subscribers_url":"https://api.github.com/repos/Moya/Moya/subscribers","subscription_url":"https://api.github.com/repos/Moya/Moya/subscription","commits_url":"https://api.github.com/repos/Moya/Moya/commits{/sha}","git_commits_url":"https://api.github.com/repos/Moya/Moya/git/commits{/sha}","comments_url":"https://api.github.com/repos/Moya/Moya/comments{/number}","issue_comment_url":"https://api.github.com/repos/Moya/Moya/issues/comments{/number}","contents_url":"https://api.github.com/repos/Moya/Moya/contents/{+path}","compare_url":"https://api.github.com/repos/Moya/Moya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Moya/Moya/merges","archive_url":"https://api.github.com/repos/Moya/Moya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Moya/Moya/downloads","issues_url":"https://api.github.com/repos/Moya/Moya/issues{/number}","pulls_url":"https://api.github.com/repos/Moya/Moya/pulls{/number}","milestones_url":"https://api.github.com/repos/Moya/Moya/milestones{/number}","notifications_url":"https://api.github.com/repos/Moya/Moya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Moya/Moya/labels{/name}","releases_url":"https://api.github.com/repos/Moya/Moya/releases{/id}","deployments_url":"https://api.github.com/repos/Moya/Moya/deployments","created_at":"2014-08-16T07:41:21Z","updated_at":"2016-09-29T12:42:28Z","pushed_at":"2016-09-29T13:32:42Z","git_url":"git://github.com/Moya/Moya.git","ssh_url":"git@github.com:Moya/Moya.git","clone_url":"https://github.com/Moya/Moya.git","svn_url":"https://github.com/Moya/Moya","homepage":"","size":17193,"stargazers_count":3682,"watchers_count":3682,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":390,"mirror_url":null,"open_issues_count":47,"forks":390,"open_issues":47,"watchers":3682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Moya/Moya/pulls/694"},"html":{"href":"https://github.com/Moya/Moya/pull/694"},"issue":{"href":"https://api.github.com/repos/Moya/Moya/issues/694"},"comments":{"href":"https://api.github.com/repos/Moya/Moya/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/Moya/Moya/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/Moya/Moya/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Moya/Moya/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/Moya/Moya/statuses/59f00032dd28aae83adbd73c864db403a0f2ba0c"}}}}
{"actor":{"display_login":"sunshinejr"}}