{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/82353405","pull_request_review_id":3267269,"id":82353405,"diff_hunk":"@@ -114,11 +115,11 @@ ansible_provision = proc do |ansible|\n     # Use monitor_address_block instead of monitor_interface:\n     ansible.extra_vars.delete(:monitor_interface)\n     ansible.extra_vars = ansible.extra_vars.merge({\n-      cluster_network: \"#{SUBNET}.0/16\",\n+      cluster_network: \"#{CLUSTER_SUBNET}.0/16\",\n       devices: ['/dev/sdc'], # hardcode leftover disk\n       journal_collocation: 'true',\n-      monitor_address_block: \"#{SUBNET}.0/16\",\n-      public_network: \"#{SUBNET}.0/16\",\n+      monitor_address_block: \"#{PUBLIC_SUBNET}.0/16\",\n+      public_network: \"#{PUBLIC_SUBNET}.0/16\",","path":"Vagrantfile","position":42,"original_position":42,"commit_id":"0c8b63bb3f314f9ad039e5dd33fc6b6ec03a9e3b","original_commit_id":"0c8b63bb3f314f9ad039e5dd33fc6b6ec03a9e3b","user":{"login":"leseb","id":912735,"avatar_url":"https://avatars.githubusercontent.com/u/912735?v=3","gravatar_id":"","url":"https://api.github.com/users/leseb","html_url":"https://github.com/leseb","followers_url":"https://api.github.com/users/leseb/followers","following_url":"https://api.github.com/users/leseb/following{/other_user}","gists_url":"https://api.github.com/users/leseb/gists{/gist_id}","starred_url":"https://api.github.com/users/leseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leseb/subscriptions","organizations_url":"https://api.github.com/users/leseb/orgs","repos_url":"https://api.github.com/users/leseb/repos","events_url":"https://api.github.com/users/leseb/events{/privacy}","received_events_url":"https://api.github.com/users/leseb/received_events","type":"User","site_admin":false},"body":"ditto","created_at":"2016-10-07T09:07:43Z","updated_at":"2016-10-07T09:07:47Z","html_url":"https://github.com/ceph/ceph-ansible/pull/1015#discussion_r82353405","pull_request_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1015","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/82353405"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/1015#discussion_r82353405"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1015"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1015","id":88385722,"html_url":"https://github.com/ceph/ceph-ansible/pull/1015","diff_url":"https://github.com/ceph/ceph-ansible/pull/1015.diff","patch_url":"https://github.com/ceph/ceph-ansible/pull/1015.patch","issue_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/1015","number":1015,"state":"open","locked":false,"title":"Create separate subnet for public/cluster networks","user":{"login":"font","id":3596535,"avatar_url":"https://avatars.githubusercontent.com/u/3596535?v=3","gravatar_id":"","url":"https://api.github.com/users/font","html_url":"https://github.com/font","followers_url":"https://api.github.com/users/font/followers","following_url":"https://api.github.com/users/font/following{/other_user}","gists_url":"https://api.github.com/users/font/gists{/gist_id}","starred_url":"https://api.github.com/users/font/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/font/subscriptions","organizations_url":"https://api.github.com/users/font/orgs","repos_url":"https://api.github.com/users/font/repos","events_url":"https://api.github.com/users/font/events{/privacy}","received_events_url":"https://api.github.com/users/font/received_events","type":"User","site_admin":false},"body":"- All Ceph instances now communication using public subnet and\r\n  additionally OSDs communicate with each other using private cluster\r\n  subnet\r\n- Workaround for\r\n  https://github.com/vagrant-libvirt/vagrant-libvirt/issues/645\r\n- Fix for #952 to avoid concatenated MAC addresses caused by\r\n  vagrant-libvirt bug.","created_at":"2016-10-07T06:12:53Z","updated_at":"2016-10-07T09:07:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"353f1315b0b72fb615ad4d458c14450b46a800f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1015/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1015/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/1015/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/0c8b63bb3f314f9ad039e5dd33fc6b6ec03a9e3b","head":{"label":"font:vagrant_net_cfg","ref":"vagrant_net_cfg","sha":"0c8b63bb3f314f9ad039e5dd33fc6b6ec03a9e3b","user":{"login":"font","id":3596535,"avatar_url":"https://avatars.githubusercontent.com/u/3596535?v=3","gravatar_id":"","url":"https://api.github.com/users/font","html_url":"https://github.com/font","followers_url":"https://api.github.com/users/font/followers","following_url":"https://api.github.com/users/font/following{/other_user}","gists_url":"https://api.github.com/users/font/gists{/gist_id}","starred_url":"https://api.github.com/users/font/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/font/subscriptions","organizations_url":"https://api.github.com/users/font/orgs","repos_url":"https://api.github.com/users/font/repos","events_url":"https://api.github.com/users/font/events{/privacy}","received_events_url":"https://api.github.com/users/font/received_events","type":"User","site_admin":false},"repo":{"id":60714762,"name":"ceph-ansible","full_name":"font/ceph-ansible","owner":{"login":"font","id":3596535,"avatar_url":"https://avatars.githubusercontent.com/u/3596535?v=3","gravatar_id":"","url":"https://api.github.com/users/font","html_url":"https://github.com/font","followers_url":"https://api.github.com/users/font/followers","following_url":"https://api.github.com/users/font/following{/other_user}","gists_url":"https://api.github.com/users/font/gists{/gist_id}","starred_url":"https://api.github.com/users/font/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/font/subscriptions","organizations_url":"https://api.github.com/users/font/orgs","repos_url":"https://api.github.com/users/font/repos","events_url":"https://api.github.com/users/font/events{/privacy}","received_events_url":"https://api.github.com/users/font/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/font/ceph-ansible","description":"Ansible playbooks for Ceph","fork":true,"url":"https://api.github.com/repos/font/ceph-ansible","forks_url":"https://api.github.com/repos/font/ceph-ansible/forks","keys_url":"https://api.github.com/repos/font/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/font/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/font/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/font/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/font/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/font/ceph-ansible/events","assignees_url":"https://api.github.com/repos/font/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/font/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/font/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/font/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/font/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/font/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/font/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/font/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/font/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/font/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/font/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/font/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/font/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/font/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/font/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/font/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/font/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/font/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/font/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/font/ceph-ansible/merges","archive_url":"https://api.github.com/repos/font/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/font/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/font/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/font/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/font/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/font/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/font/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/font/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/font/ceph-ansible/deployments","created_at":"2016-06-08T16:58:40Z","updated_at":"2016-06-08T16:58:42Z","pushed_at":"2016-10-07T06:12:17Z","git_url":"git://github.com/font/ceph-ansible.git","ssh_url":"git@github.com:font/ceph-ansible.git","clone_url":"https://github.com/font/ceph-ansible.git","svn_url":"https://github.com/font/ceph-ansible","homepage":null,"size":1795,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"bd50e646655bb432038121b418027a0feaa20022","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":17373313,"name":"ceph-ansible","full_name":"ceph/ceph-ansible","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-ansible","description":"Ansible playbooks for Ceph","fork":false,"url":"https://api.github.com/repos/ceph/ceph-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-ansible/deployments","created_at":"2014-03-03T17:12:09Z","updated_at":"2016-10-05T02:16:52Z","pushed_at":"2016-10-07T09:04:57Z","git_url":"git://github.com/ceph/ceph-ansible.git","ssh_url":"git@github.com:ceph/ceph-ansible.git","clone_url":"https://github.com/ceph/ceph-ansible.git","svn_url":"https://github.com/ceph/ceph-ansible","homepage":null,"size":24364,"stargazers_count":317,"watchers_count":317,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":215,"mirror_url":null,"open_issues_count":43,"forks":215,"open_issues":43,"watchers":317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1015"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/1015"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/1015"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/1015/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1015/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1015/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-ansible/statuses/0c8b63bb3f314f9ad039e5dd33fc6b6ec03a9e3b"}}}}
{"actor":{"display_login":"leseb"}}