{"action":"created","comment":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/53043091","id":53043091,"diff_hunk":"@@ -413,9 +413,15 @@ static struct fi_gni_ops_domain gnix_ops_domain = {\n \t.get_val = __gnix_dom_ops_get_val\n };\n \n+DIRECT_FN int gnix_domain_bind(struct fid_domain *domain, struct fid *fid,","path":"prov/gni/src/gnix_dom.c","position":4,"original_position":4,"commit_id":"3165991041747479961c42b95be18fdb83280cfa","original_commit_id":"3165991041747479961c42b95be18fdb83280cfa","user":{"login":"sungeunchoi","id":4294511,"avatar_url":"https://avatars.githubusercontent.com/u/4294511?v=3","gravatar_id":"","url":"https://api.github.com/users/sungeunchoi","html_url":"https://github.com/sungeunchoi","followers_url":"https://api.github.com/users/sungeunchoi/followers","following_url":"https://api.github.com/users/sungeunchoi/following{/other_user}","gists_url":"https://api.github.com/users/sungeunchoi/gists{/gist_id}","starred_url":"https://api.github.com/users/sungeunchoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sungeunchoi/subscriptions","organizations_url":"https://api.github.com/users/sungeunchoi/orgs","repos_url":"https://api.github.com/users/sungeunchoi/repos","events_url":"https://api.github.com/users/sungeunchoi/events{/privacy}","received_events_url":"https://api.github.com/users/sungeunchoi/received_events","type":"User","site_admin":false},"body":"Might as well have STATIC.","created_at":"2016-02-16T17:12:50Z","updated_at":"2016-02-16T17:12:50Z","html_url":"https://github.com/ofi-cray/libfabric-cray/pull/662#discussion_r53043091","pull_request_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/662","_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/53043091"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/662#discussion_r53043091"},"pull_request":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/662"}}},"pull_request":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/662","id":58557554,"html_url":"https://github.com/ofi-cray/libfabric-cray/pull/662","diff_url":"https://github.com/ofi-cray/libfabric-cray/pull/662.diff","patch_url":"https://github.com/ofi-cray/libfabric-cray/pull/662.patch","issue_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/662","number":662,"state":"open","locked":false,"title":"Implemented fi direct","user":{"login":"e-harvey","id":7410674,"avatar_url":"https://avatars.githubusercontent.com/u/7410674?v=3","gravatar_id":"","url":"https://api.github.com/users/e-harvey","html_url":"https://github.com/e-harvey","followers_url":"https://api.github.com/users/e-harvey/followers","following_url":"https://api.github.com/users/e-harvey/following{/other_user}","gists_url":"https://api.github.com/users/e-harvey/gists{/gist_id}","starred_url":"https://api.github.com/users/e-harvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-harvey/subscriptions","organizations_url":"https://api.github.com/users/e-harvey/orgs","repos_url":"https://api.github.com/users/e-harvey/repos","events_url":"https://api.github.com/users/e-harvey/events{/privacy}","received_events_url":"https://api.github.com/users/e-harvey/received_events","type":"User","site_admin":false},"body":"The following changes bind all the gni API functions globally when compiling with fi direct enabled. This allows applications to see the gni API function references and compile with fabric direct enabled.  The gni API functions that have not been implemented return -FI_ENOSYS and have the appropriate macros before their declarations so that applications can compile with fi direct enabled.  These macros were defined in fi_prov.h in the hope that if other providers support fi direct they will use them as well.\r\n\r\n- Updated fi_provider.m4 to modify CFLAGS in order to change the visibility of the gni API functions.\r\n\r\n- Updated fi_prov.h to change visibility of gni API functions when configuring with --enable-direct=gni.\r\n\r\n- Added gni API function names to the global section of libfabric.map.\r\n\r\n- Implemented direct headers.\r\n\r\n- Updated gnix*.c and gnix*.h to refelect the changes.\r\n\r\nNote:\r\nWhen configuring the GNI provider for fi direct, configure with the following options: `--enable-direct=gni --disable-sockets --disable-udp`.\r\nBefore compiling fabtests for fi direct run: `export CFLAGS=\"-DFABRIC_DIRECT\"`\r\n\r\n@hppritcha @sungeunchoi @jswaro @jshimek @ztiffany @chuckfossen \r\n\r\nFixes #600 ","created_at":"2016-02-07T21:23:31Z","updated_at":"2016-02-16T17:12:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a4b2b74db072a3395750e3ddc08a4a7726a0a9b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/662/commits","review_comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/662/comments","review_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/662/comments","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/3165991041747479961c42b95be18fdb83280cfa","head":{"label":"e-harvey:issue600","ref":"issue600","sha":"3165991041747479961c42b95be18fdb83280cfa","user":{"login":"e-harvey","id":7410674,"avatar_url":"https://avatars.githubusercontent.com/u/7410674?v=3","gravatar_id":"","url":"https://api.github.com/users/e-harvey","html_url":"https://github.com/e-harvey","followers_url":"https://api.github.com/users/e-harvey/followers","following_url":"https://api.github.com/users/e-harvey/following{/other_user}","gists_url":"https://api.github.com/users/e-harvey/gists{/gist_id}","starred_url":"https://api.github.com/users/e-harvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-harvey/subscriptions","organizations_url":"https://api.github.com/users/e-harvey/orgs","repos_url":"https://api.github.com/users/e-harvey/repos","events_url":"https://api.github.com/users/e-harvey/events{/privacy}","received_events_url":"https://api.github.com/users/e-harvey/received_events","type":"User","site_admin":false},"repo":{"id":41583014,"name":"libfabric-cray","full_name":"e-harvey/libfabric-cray","owner":{"login":"e-harvey","id":7410674,"avatar_url":"https://avatars.githubusercontent.com/u/7410674?v=3","gravatar_id":"","url":"https://api.github.com/users/e-harvey","html_url":"https://github.com/e-harvey","followers_url":"https://api.github.com/users/e-harvey/followers","following_url":"https://api.github.com/users/e-harvey/following{/other_user}","gists_url":"https://api.github.com/users/e-harvey/gists{/gist_id}","starred_url":"https://api.github.com/users/e-harvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-harvey/subscriptions","organizations_url":"https://api.github.com/users/e-harvey/orgs","repos_url":"https://api.github.com/users/e-harvey/repos","events_url":"https://api.github.com/users/e-harvey/events{/privacy}","received_events_url":"https://api.github.com/users/e-harvey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/e-harvey/libfabric-cray","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/e-harvey/libfabric-cray","forks_url":"https://api.github.com/repos/e-harvey/libfabric-cray/forks","keys_url":"https://api.github.com/repos/e-harvey/libfabric-cray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/e-harvey/libfabric-cray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/e-harvey/libfabric-cray/teams","hooks_url":"https://api.github.com/repos/e-harvey/libfabric-cray/hooks","issue_events_url":"https://api.github.com/repos/e-harvey/libfabric-cray/issues/events{/number}","events_url":"https://api.github.com/repos/e-harvey/libfabric-cray/events","assignees_url":"https://api.github.com/repos/e-harvey/libfabric-cray/assignees{/user}","branches_url":"https://api.github.com/repos/e-harvey/libfabric-cray/branches{/branch}","tags_url":"https://api.github.com/repos/e-harvey/libfabric-cray/tags","blobs_url":"https://api.github.com/repos/e-harvey/libfabric-cray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/e-harvey/libfabric-cray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/e-harvey/libfabric-cray/git/refs{/sha}","trees_url":"https://api.github.com/repos/e-harvey/libfabric-cray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/e-harvey/libfabric-cray/statuses/{sha}","languages_url":"https://api.github.com/repos/e-harvey/libfabric-cray/languages","stargazers_url":"https://api.github.com/repos/e-harvey/libfabric-cray/stargazers","contributors_url":"https://api.github.com/repos/e-harvey/libfabric-cray/contributors","subscribers_url":"https://api.github.com/repos/e-harvey/libfabric-cray/subscribers","subscription_url":"https://api.github.com/repos/e-harvey/libfabric-cray/subscription","commits_url":"https://api.github.com/repos/e-harvey/libfabric-cray/commits{/sha}","git_commits_url":"https://api.github.com/repos/e-harvey/libfabric-cray/git/commits{/sha}","comments_url":"https://api.github.com/repos/e-harvey/libfabric-cray/comments{/number}","issue_comment_url":"https://api.github.com/repos/e-harvey/libfabric-cray/issues/comments{/number}","contents_url":"https://api.github.com/repos/e-harvey/libfabric-cray/contents/{+path}","compare_url":"https://api.github.com/repos/e-harvey/libfabric-cray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/e-harvey/libfabric-cray/merges","archive_url":"https://api.github.com/repos/e-harvey/libfabric-cray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/e-harvey/libfabric-cray/downloads","issues_url":"https://api.github.com/repos/e-harvey/libfabric-cray/issues{/number}","pulls_url":"https://api.github.com/repos/e-harvey/libfabric-cray/pulls{/number}","milestones_url":"https://api.github.com/repos/e-harvey/libfabric-cray/milestones{/number}","notifications_url":"https://api.github.com/repos/e-harvey/libfabric-cray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/e-harvey/libfabric-cray/labels{/name}","releases_url":"https://api.github.com/repos/e-harvey/libfabric-cray/releases{/id}","deployments_url":"https://api.github.com/repos/e-harvey/libfabric-cray/deployments","created_at":"2015-08-29T06:19:51Z","updated_at":"2016-01-15T22:09:33Z","pushed_at":"2016-02-12T17:08:18Z","git_url":"git://github.com/e-harvey/libfabric-cray.git","ssh_url":"git@github.com:e-harvey/libfabric-cray.git","clone_url":"https://github.com/e-harvey/libfabric-cray.git","svn_url":"https://github.com/e-harvey/libfabric-cray","homepage":"http://ofiwg.github.io/libfabric/","size":11670,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofi-cray:master","ref":"master","sha":"f5bb6854447ed22f5739becc131ebdb6f7cbd00b","user":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"repo":{"id":29607348,"name":"libfabric-cray","full_name":"ofi-cray/libfabric-cray","owner":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofi-cray/libfabric-cray","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/ofi-cray/libfabric-cray","forks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/forks","keys_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/teams","hooks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/hooks","issue_events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/events{/number}","events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/events","assignees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/assignees{/user}","branches_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/branches{/branch}","tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/tags","blobs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/{sha}","languages_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/languages","stargazers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/stargazers","contributors_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contributors","subscribers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscribers","subscription_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscription","commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contents/{+path}","compare_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/merges","archive_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/downloads","issues_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues{/number}","pulls_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls{/number}","milestones_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/milestones{/number}","notifications_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/labels{/name}","releases_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/releases{/id}","deployments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/deployments","created_at":"2015-01-21T19:30:52Z","updated_at":"2016-01-13T18:57:54Z","pushed_at":"2016-02-12T16:47:55Z","git_url":"git://github.com/ofi-cray/libfabric-cray.git","ssh_url":"git@github.com:ofi-cray/libfabric-cray.git","clone_url":"https://github.com/ofi-cray/libfabric-cray.git","svn_url":"https://github.com/ofi-cray/libfabric-cray","homepage":"http://ofiwg.github.io/libfabric/","size":14263,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":50,"forks":7,"open_issues":50,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/662"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/662"},"issue":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/662"},"comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/662/comments"},"review_comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/662/comments"},"review_comment":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/662/commits"},"statuses":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/3165991041747479961c42b95be18fdb83280cfa"}}}}