{"action":"created","issue":{"url":"https://api.github.com/repos/SnabbCo/snabbswitch/issues/708","labels_url":"https://api.github.com/repos/SnabbCo/snabbswitch/issues/708/labels{/name}","comments_url":"https://api.github.com/repos/SnabbCo/snabbswitch/issues/708/comments","events_url":"https://api.github.com/repos/SnabbCo/snabbswitch/issues/708/events","html_url":"https://github.com/SnabbCo/snabbswitch/pull/708","id":126399544,"number":708,"title":"Add a Match app to apps/basic. ","user":{"login":"petebristow","id":16196724,"avatar_url":"https://avatars.githubusercontent.com/u/16196724?v=3","gravatar_id":"","url":"https://api.github.com/users/petebristow","html_url":"https://github.com/petebristow","followers_url":"https://api.github.com/users/petebristow/followers","following_url":"https://api.github.com/users/petebristow/following{/other_user}","gists_url":"https://api.github.com/users/petebristow/gists{/gist_id}","starred_url":"https://api.github.com/users/petebristow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebristow/subscriptions","organizations_url":"https://api.github.com/users/petebristow/orgs","repos_url":"https://api.github.com/users/petebristow/repos","events_url":"https://api.github.com/users/petebristow/events{/privacy}","received_events_url":"https://api.github.com/users/petebristow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-13T11:37:36Z","updated_at":"2016-01-13T11:44:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SnabbCo/snabbswitch/pulls/708","html_url":"https://github.com/SnabbCo/snabbswitch/pull/708","diff_url":"https://github.com/SnabbCo/snabbswitch/pull/708.diff","patch_url":"https://github.com/SnabbCo/snabbswitch/pull/708.patch"},"body":"This PR replaces PR#690. It's been reimplemented, pared down and moved into apps/basic. Match takes 2 inputs and compares them, providing some feedback as to whether they match."},"comment":{"url":"https://api.github.com/repos/SnabbCo/snabbswitch/issues/comments/171263489","html_url":"https://github.com/SnabbCo/snabbswitch/pull/708#issuecomment-171263489","issue_url":"https://api.github.com/repos/SnabbCo/snabbswitch/issues/708","id":171263489,"user":{"login":"andywingo","id":1745903,"avatar_url":"https://avatars.githubusercontent.com/u/1745903?v=3","gravatar_id":"","url":"https://api.github.com/users/andywingo","html_url":"https://github.com/andywingo","followers_url":"https://api.github.com/users/andywingo/followers","following_url":"https://api.github.com/users/andywingo/following{/other_user}","gists_url":"https://api.github.com/users/andywingo/gists{/gist_id}","starred_url":"https://api.github.com/users/andywingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andywingo/subscriptions","organizations_url":"https://api.github.com/users/andywingo/orgs","repos_url":"https://api.github.com/users/andywingo/repos","events_url":"https://api.github.com/users/andywingo/events{/privacy}","received_events_url":"https://api.github.com/users/andywingo/received_events","type":"User","site_admin":false},"created_at":"2016-01-13T11:44:20Z","updated_at":"2016-01-13T11:44:20Z","body":"Neat.  I guess this is for test suites and such.  Initial thought: I'm not sure how useful it is, given that when there's a problem you usually want to be able to see the output of a link as a pcap file, and then compare it to an expected output as a pcap file.  In your patch I don't think you get that kind of context.  For that reason I don't think I'd be tempted to use it.\r\n\r\nCosmetics:\r\nPerhaps it should be named Check or something; \"match\" implies that we match packets and then do something with them.  Keep lines to within the 80-char line limits.  Compare to nil instead of \"nil\", or just test for truthiness."}}