{"action":"created","issue":{"url":"https://api.github.com/repos/alee8888/liferay-portal/issues/306","repository_url":"https://api.github.com/repos/alee8888/liferay-portal","labels_url":"https://api.github.com/repos/alee8888/liferay-portal/issues/306/labels{/name}","comments_url":"https://api.github.com/repos/alee8888/liferay-portal/issues/306/comments","events_url":"https://api.github.com/repos/alee8888/liferay-portal/issues/306/events","html_url":"https://github.com/alee8888/liferay-portal/pull/306","id":172368073,"number":306,"title":"master-bw-10","user":{"login":"brianwulbern","id":2567901,"avatar_url":"https://avatars.githubusercontent.com/u/2567901?v=3","gravatar_id":"","url":"https://api.github.com/users/brianwulbern","html_url":"https://github.com/brianwulbern","followers_url":"https://api.github.com/users/brianwulbern/followers","following_url":"https://api.github.com/users/brianwulbern/following{/other_user}","gists_url":"https://api.github.com/users/brianwulbern/gists{/gist_id}","starred_url":"https://api.github.com/users/brianwulbern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianwulbern/subscriptions","organizations_url":"https://api.github.com/users/brianwulbern/orgs","repos_url":"https://api.github.com/users/brianwulbern/repos","events_url":"https://api.github.com/users/brianwulbern/events{/privacy}","received_events_url":"https://api.github.com/users/brianwulbern/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-22T04:33:59Z","updated_at":"2016-08-26T17:16:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alee8888/liferay-portal/pulls/306","html_url":"https://github.com/alee8888/liferay-portal/pull/306","diff_url":"https://github.com/alee8888/liferay-portal/pull/306.diff","patch_url":"https://github.com/alee8888/liferay-portal/pull/306.patch"},"body":"https://issues.liferay.com/browse/LRQA-27028\r\n\r\n@alee8888 This test fix included some relatively major surgery to `Role#editPermissionCmdCP`\r\n\r\n@Sharryxue noticed that if the desired element is displaying *near* one that was previously used, then this `<if>` block gets skipped when it shouldn't (https://github.com/brianwulbern/liferay-portal/pull/10/commits/715f425720e1e32a33fe6093f423fd2d7cad4db3#diff-83b72a158c0735a0b5477414710abdabL585) - so her solution is to always search, which I thought was OK.\r\n\r\nShe also noticed that 2nd/3rd/4th... Permissions in for-loop succession weren't getting saved, so moved the saving inside the for-loop (https://github.com/brianwulbern/liferay-portal/pull/10/commits/715f425720e1e32a33fe6093f423fd2d7cad4db3#diff-83b72a158c0735a0b5477414710abdabR629).\r\n\r\nI wanted to have you see these changes before sending to BChan.  Can you PR to him if it looks good?  Thanks!\r\n\r\n**Please backport to 7.0.x.  Thanks!**"},"comment":{"url":"https://api.github.com/repos/alee8888/liferay-portal/issues/comments/242795400","html_url":"https://github.com/alee8888/liferay-portal/pull/306#issuecomment-242795400","issue_url":"https://api.github.com/repos/alee8888/liferay-portal/issues/306","id":242795400,"user":{"login":"alee8888","id":871744,"avatar_url":"https://avatars.githubusercontent.com/u/871744?v=3","gravatar_id":"","url":"https://api.github.com/users/alee8888","html_url":"https://github.com/alee8888","followers_url":"https://api.github.com/users/alee8888/followers","following_url":"https://api.github.com/users/alee8888/following{/other_user}","gists_url":"https://api.github.com/users/alee8888/gists{/gist_id}","starred_url":"https://api.github.com/users/alee8888/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alee8888/subscriptions","organizations_url":"https://api.github.com/users/alee8888/orgs","repos_url":"https://api.github.com/users/alee8888/repos","events_url":"https://api.github.com/users/alee8888/events{/privacy}","received_events_url":"https://api.github.com/users/alee8888/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T17:16:17Z","updated_at":"2016-08-26T17:16:17Z","body":"Just started reviewing :) <br><br>:octocat: *Sent from [GH](http://nodegh.io).*"}}
{"actor":{"display_login":"alee8888"}}