{"action":"opened","number":16,"pull_request":{"url":"https://api.github.com/repos/onelogin/python3-saml/pulls/16","id":68231273,"html_url":"https://github.com/onelogin/python3-saml/pull/16","diff_url":"https://github.com/onelogin/python3-saml/pull/16.diff","patch_url":"https://github.com/onelogin/python3-saml/pull/16.patch","issue_url":"https://api.github.com/repos/onelogin/python3-saml/issues/16","number":16,"state":"open","locked":false,"title":"IdP metadata parser: fix singleSignOnService processing","user":{"login":"jgehrcke","id":265630,"avatar_url":"https://avatars.githubusercontent.com/u/265630?v=3","gravatar_id":"","url":"https://api.github.com/users/jgehrcke","html_url":"https://github.com/jgehrcke","followers_url":"https://api.github.com/users/jgehrcke/followers","following_url":"https://api.github.com/users/jgehrcke/following{/other_user}","gists_url":"https://api.github.com/users/jgehrcke/gists{/gist_id}","starred_url":"https://api.github.com/users/jgehrcke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgehrcke/subscriptions","organizations_url":"https://api.github.com/users/jgehrcke/orgs","repos_url":"https://api.github.com/users/jgehrcke/repos","events_url":"https://api.github.com/users/jgehrcke/events{/privacy}","received_events_url":"https://api.github.com/users/jgehrcke/received_events","type":"User","site_admin":false},"body":"There is a typo in the new idp_metadata_parser module: it consumes the `singleLogoutService` XML tag for populating `idp_sso_url`, instead of the `singleSignOnService` tag. This PR fixes the typo and adjusts the tests.\r\n\r\nParser tests pass:\r\n```text\r\n$ python setup.py test --test-suite tests.src.OneLogin.saml2_tests.idp_metadata_parser_test\r\nrunning test\r\nSearching for xmlsec>=0.6.0\r\nBest match: xmlsec 0.6.0\r\nProcessing xmlsec-0.6.0-py3.4-linux-x86_64.egg\r\n\r\nUsing /home/jp/dev/python3-saml/.eggs/xmlsec-0.6.0-py3.4-linux-x86_64.egg\r\nSearching for isodate>=0.5.0\r\nBest match: isodate 0.5.4\r\nProcessing isodate-0.5.4-py3.4.egg\r\n\r\nUsing /home/jp/dev/python3-saml/.eggs/isodate-0.5.4-py3.4.egg\r\nrunning egg_info\r\nwriting dependency_links to src/python3_saml.egg-info/dependency_links.txt\r\nwriting src/python3_saml.egg-info/PKG-INFO\r\nwriting top-level names to src/python3_saml.egg-info/top_level.txt\r\nwriting requirements to src/python3_saml.egg-info/requires.txt\r\nreading manifest file 'src/python3_saml.egg-info/SOURCES.txt'\r\nreading manifest template 'MANIFEST.in'\r\nwarning: no previously-included files matching '__pycache__' found under directory '*'\r\nwarning: no previously-included files matching '*.py[co]' found under directory '*'\r\nwriting manifest file 'src/python3_saml.egg-info/SOURCES.txt'\r\nrunning build_ext\r\ntestGetMetadata (tests.src.OneLogin.saml2_tests.idp_metadata_parser_test.OneLogin_Saml2_IdPMetadataParser_Test) ... ok\r\ntestMergeSettings (tests.src.OneLogin.saml2_tests.idp_metadata_parser_test.OneLogin_Saml2_IdPMetadataParser_Test) ... ok\r\ntestParse (tests.src.OneLogin.saml2_tests.idp_metadata_parser_test.OneLogin_Saml2_IdPMetadataParser_Test) ... ok\r\ntestParseRemote (tests.src.OneLogin.saml2_tests.idp_metadata_parser_test.OneLogin_Saml2_IdPMetadataParser_Test) ... ok\r\n\r\n----------------------------------------------------------------------\r\nRan 4 tests in 2.137s\r\n\r\nOK\r\n```\r\n\r\nNote that the test data also specifies `SingleLogoutService`s:\r\n\r\n\r\n```text\r\n$ curl https://www.testshib.org/metadata/testshib-providers.xml | grep -i singlelogout\r\n  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current\r\n                                 Dload  Upload   Total   Spent    Left  Speed\r\n100 20563  100 20563    0     0  17912      0  0:00:01  0:00:01 --:--:-- 17927\r\n            <SingleLogoutService Location=\"https://sp.testshib.org/Shibboleth.sso/SLO/SOAP\"\r\n            <SingleLogoutService Location=\"https://sp.testshib.org/Shibboleth.sso/SLO/Redirect\"\r\n            <SingleLogoutService Location=\"https://sp.testshib.org/Shibboleth.sso/SLO/POST\"\r\n            <SingleLogoutService Location=\"https://sp.testshib.org/Shibboleth.sso/SLO/Artifact\"\r\n```\r\nThey are part of the `SPSSODescriptor` tag which is not looked into by the IdP parser. So, the `expected_data` in the tests does not contain any SLSs.\r\n\r\nThat's the data the IdP parser currently (with the change from this PR) creates when parsing https://www.testshib.org/metadata/testshib-providers.xml:\r\n\r\n```\r\n{\r\n    \"sp\": {\r\n        \"NameIDFormat\": \"urn:mace:shibboleth:1.0:nameIdentifier\"\r\n    },\r\n    \"idp\": {\r\n        \"singleSignOnService\": {\r\n            \"url\": \"https://idp.testshib.org/idp/profile/SAML2/Redirect/SSO\"\r\n        },\r\n        \"entityId\": \"https://idp.testshib.org/idp/shibboleth\"\r\n    }\r\n}\r\n```\r\n@pitbulk I hope this is now as expected. Please review, thanks!","created_at":"2016-04-28T14:36:08Z","updated_at":"2016-04-28T14:36:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onelogin/python3-saml/pulls/16/commits","review_comments_url":"https://api.github.com/repos/onelogin/python3-saml/pulls/16/comments","review_comment_url":"https://api.github.com/repos/onelogin/python3-saml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onelogin/python3-saml/issues/16/comments","statuses_url":"https://api.github.com/repos/onelogin/python3-saml/statuses/49abfd589d957d591614298d7dd80074a8775029","head":{"label":"jgehrcke:jp/fixparser","ref":"jp/fixparser","sha":"49abfd589d957d591614298d7dd80074a8775029","user":{"login":"jgehrcke","id":265630,"avatar_url":"https://avatars.githubusercontent.com/u/265630?v=3","gravatar_id":"","url":"https://api.github.com/users/jgehrcke","html_url":"https://github.com/jgehrcke","followers_url":"https://api.github.com/users/jgehrcke/followers","following_url":"https://api.github.com/users/jgehrcke/following{/other_user}","gists_url":"https://api.github.com/users/jgehrcke/gists{/gist_id}","starred_url":"https://api.github.com/users/jgehrcke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgehrcke/subscriptions","organizations_url":"https://api.github.com/users/jgehrcke/orgs","repos_url":"https://api.github.com/users/jgehrcke/repos","events_url":"https://api.github.com/users/jgehrcke/events{/privacy}","received_events_url":"https://api.github.com/users/jgehrcke/received_events","type":"User","site_admin":false},"repo":{"id":57305896,"name":"python3-saml","full_name":"jgehrcke/python3-saml","owner":{"login":"jgehrcke","id":265630,"avatar_url":"https://avatars.githubusercontent.com/u/265630?v=3","gravatar_id":"","url":"https://api.github.com/users/jgehrcke","html_url":"https://github.com/jgehrcke","followers_url":"https://api.github.com/users/jgehrcke/followers","following_url":"https://api.github.com/users/jgehrcke/following{/other_user}","gists_url":"https://api.github.com/users/jgehrcke/gists{/gist_id}","starred_url":"https://api.github.com/users/jgehrcke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgehrcke/subscriptions","organizations_url":"https://api.github.com/users/jgehrcke/orgs","repos_url":"https://api.github.com/users/jgehrcke/repos","events_url":"https://api.github.com/users/jgehrcke/events{/privacy}","received_events_url":"https://api.github.com/users/jgehrcke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgehrcke/python3-saml","description":"","fork":true,"url":"https://api.github.com/repos/jgehrcke/python3-saml","forks_url":"https://api.github.com/repos/jgehrcke/python3-saml/forks","keys_url":"https://api.github.com/repos/jgehrcke/python3-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgehrcke/python3-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgehrcke/python3-saml/teams","hooks_url":"https://api.github.com/repos/jgehrcke/python3-saml/hooks","issue_events_url":"https://api.github.com/repos/jgehrcke/python3-saml/issues/events{/number}","events_url":"https://api.github.com/repos/jgehrcke/python3-saml/events","assignees_url":"https://api.github.com/repos/jgehrcke/python3-saml/assignees{/user}","branches_url":"https://api.github.com/repos/jgehrcke/python3-saml/branches{/branch}","tags_url":"https://api.github.com/repos/jgehrcke/python3-saml/tags","blobs_url":"https://api.github.com/repos/jgehrcke/python3-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgehrcke/python3-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgehrcke/python3-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgehrcke/python3-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgehrcke/python3-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/jgehrcke/python3-saml/languages","stargazers_url":"https://api.github.com/repos/jgehrcke/python3-saml/stargazers","contributors_url":"https://api.github.com/repos/jgehrcke/python3-saml/contributors","subscribers_url":"https://api.github.com/repos/jgehrcke/python3-saml/subscribers","subscription_url":"https://api.github.com/repos/jgehrcke/python3-saml/subscription","commits_url":"https://api.github.com/repos/jgehrcke/python3-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgehrcke/python3-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgehrcke/python3-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgehrcke/python3-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgehrcke/python3-saml/contents/{+path}","compare_url":"https://api.github.com/repos/jgehrcke/python3-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgehrcke/python3-saml/merges","archive_url":"https://api.github.com/repos/jgehrcke/python3-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgehrcke/python3-saml/downloads","issues_url":"https://api.github.com/repos/jgehrcke/python3-saml/issues{/number}","pulls_url":"https://api.github.com/repos/jgehrcke/python3-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/jgehrcke/python3-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/jgehrcke/python3-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgehrcke/python3-saml/labels{/name}","releases_url":"https://api.github.com/repos/jgehrcke/python3-saml/releases{/id}","deployments_url":"https://api.github.com/repos/jgehrcke/python3-saml/deployments","created_at":"2016-04-28T13:56:14Z","updated_at":"2016-04-28T13:56:15Z","pushed_at":"2016-04-28T14:26:50Z","git_url":"git://github.com/jgehrcke/python3-saml.git","ssh_url":"git@github.com:jgehrcke/python3-saml.git","clone_url":"https://github.com/jgehrcke/python3-saml.git","svn_url":"https://github.com/jgehrcke/python3-saml","homepage":null,"size":779,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onelogin:master","ref":"master","sha":"92c7ce12975d24caa631c072cc1a5e71d44296c2","user":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?v=3","gravatar_id":"","url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"repo":{"id":40724726,"name":"python3-saml","full_name":"onelogin/python3-saml","owner":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?v=3","gravatar_id":"","url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onelogin/python3-saml","description":"","fork":false,"url":"https://api.github.com/repos/onelogin/python3-saml","forks_url":"https://api.github.com/repos/onelogin/python3-saml/forks","keys_url":"https://api.github.com/repos/onelogin/python3-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onelogin/python3-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onelogin/python3-saml/teams","hooks_url":"https://api.github.com/repos/onelogin/python3-saml/hooks","issue_events_url":"https://api.github.com/repos/onelogin/python3-saml/issues/events{/number}","events_url":"https://api.github.com/repos/onelogin/python3-saml/events","assignees_url":"https://api.github.com/repos/onelogin/python3-saml/assignees{/user}","branches_url":"https://api.github.com/repos/onelogin/python3-saml/branches{/branch}","tags_url":"https://api.github.com/repos/onelogin/python3-saml/tags","blobs_url":"https://api.github.com/repos/onelogin/python3-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onelogin/python3-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onelogin/python3-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/onelogin/python3-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onelogin/python3-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/onelogin/python3-saml/languages","stargazers_url":"https://api.github.com/repos/onelogin/python3-saml/stargazers","contributors_url":"https://api.github.com/repos/onelogin/python3-saml/contributors","subscribers_url":"https://api.github.com/repos/onelogin/python3-saml/subscribers","subscription_url":"https://api.github.com/repos/onelogin/python3-saml/subscription","commits_url":"https://api.github.com/repos/onelogin/python3-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/onelogin/python3-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/onelogin/python3-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/onelogin/python3-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/onelogin/python3-saml/contents/{+path}","compare_url":"https://api.github.com/repos/onelogin/python3-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onelogin/python3-saml/merges","archive_url":"https://api.github.com/repos/onelogin/python3-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onelogin/python3-saml/downloads","issues_url":"https://api.github.com/repos/onelogin/python3-saml/issues{/number}","pulls_url":"https://api.github.com/repos/onelogin/python3-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/onelogin/python3-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/onelogin/python3-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onelogin/python3-saml/labels{/name}","releases_url":"https://api.github.com/repos/onelogin/python3-saml/releases{/id}","deployments_url":"https://api.github.com/repos/onelogin/python3-saml/deployments","created_at":"2015-08-14T16:24:22Z","updated_at":"2016-04-28T09:28:00Z","pushed_at":"2016-04-15T11:45:06Z","git_url":"git://github.com/onelogin/python3-saml.git","ssh_url":"git@github.com:onelogin/python3-saml.git","clone_url":"https://github.com/onelogin/python3-saml.git","svn_url":"https://github.com/onelogin/python3-saml","homepage":null,"size":779,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onelogin/python3-saml/pulls/16"},"html":{"href":"https://github.com/onelogin/python3-saml/pull/16"},"issue":{"href":"https://api.github.com/repos/onelogin/python3-saml/issues/16"},"comments":{"href":"https://api.github.com/repos/onelogin/python3-saml/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/onelogin/python3-saml/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/onelogin/python3-saml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onelogin/python3-saml/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/onelogin/python3-saml/statuses/49abfd589d957d591614298d7dd80074a8775029"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":5,"changed_files":2}}