{"action":"created","comment":{"url":"https://api.github.com/repos/chef/ohai/pulls/comments/58253607","id":58253607,"diff_hunk":"@@ -25,6 +25,6 @@\n \n   collect_data(:aix) do\n     os collect_os\n-    os_version kernel[:version]\n+    os_version shell_out(\"oslevel -s\").stdout.split($/)[0]","path":"lib/ohai/plugins/aix/os.rb","position":5,"original_position":5,"commit_id":"4fca3e98b93bade5507f6ed6d86f6ea6f255912b","original_commit_id":"d726641965b050883767f7e40c673bfc14c9b651","user":{"login":"tas50","id":1015200,"avatar_url":"https://avatars.githubusercontent.com/u/1015200?v=3","gravatar_id":"","url":"https://api.github.com/users/tas50","html_url":"https://github.com/tas50","followers_url":"https://api.github.com/users/tas50/followers","following_url":"https://api.github.com/users/tas50/following{/other_user}","gists_url":"https://api.github.com/users/tas50/gists{/gist_id}","starred_url":"https://api.github.com/users/tas50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tas50/subscriptions","organizations_url":"https://api.github.com/users/tas50/orgs","repos_url":"https://api.github.com/users/tas50/repos","events_url":"https://api.github.com/users/tas50/events{/privacy}","received_events_url":"https://api.github.com/users/tas50/received_events","type":"User","site_admin":false},"body":"So any reason not to just use .strip here?","created_at":"2016-04-01T19:12:26Z","updated_at":"2016-04-01T19:12:26Z","html_url":"https://github.com/chef/ohai/pull/790#discussion_r58253607","pull_request_url":"https://api.github.com/repos/chef/ohai/pulls/790","_links":{"self":{"href":"https://api.github.com/repos/chef/ohai/pulls/comments/58253607"},"html":{"href":"https://github.com/chef/ohai/pull/790#discussion_r58253607"},"pull_request":{"href":"https://api.github.com/repos/chef/ohai/pulls/790"}}},"pull_request":{"url":"https://api.github.com/repos/chef/ohai/pulls/790","id":64975034,"html_url":"https://github.com/chef/ohai/pull/790","diff_url":"https://github.com/chef/ohai/pull/790.diff","patch_url":"https://github.com/chef/ohai/pull/790.patch","issue_url":"https://api.github.com/repos/chef/ohai/issues/790","number":790,"state":"open","locked":false,"title":"Set os_version to match the output of oslevel -s","user":{"login":"juliandunn","id":841412,"avatar_url":"https://avatars.githubusercontent.com/u/841412?v=3","gravatar_id":"","url":"https://api.github.com/users/juliandunn","html_url":"https://github.com/juliandunn","followers_url":"https://api.github.com/users/juliandunn/followers","following_url":"https://api.github.com/users/juliandunn/following{/other_user}","gists_url":"https://api.github.com/users/juliandunn/gists{/gist_id}","starred_url":"https://api.github.com/users/juliandunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliandunn/subscriptions","organizations_url":"https://api.github.com/users/juliandunn/orgs","repos_url":"https://api.github.com/users/juliandunn/repos","events_url":"https://api.github.com/users/juliandunn/events{/privacy}","received_events_url":"https://api.github.com/users/juliandunn/received_events","type":"User","site_admin":false},"body":"Fixes #693.","created_at":"2016-04-01T17:04:19Z","updated_at":"2016-04-01T19:12:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba5ba8e1aeb1c092271ea730d50c2c965b2adeae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/ohai/pulls/790/commits","review_comments_url":"https://api.github.com/repos/chef/ohai/pulls/790/comments","review_comment_url":"https://api.github.com/repos/chef/ohai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/ohai/issues/790/comments","statuses_url":"https://api.github.com/repos/chef/ohai/statuses/4fca3e98b93bade5507f6ed6d86f6ea6f255912b","head":{"label":"juliandunn:aix-os-version","ref":"aix-os-version","sha":"4fca3e98b93bade5507f6ed6d86f6ea6f255912b","user":{"login":"juliandunn","id":841412,"avatar_url":"https://avatars.githubusercontent.com/u/841412?v=3","gravatar_id":"","url":"https://api.github.com/users/juliandunn","html_url":"https://github.com/juliandunn","followers_url":"https://api.github.com/users/juliandunn/followers","following_url":"https://api.github.com/users/juliandunn/following{/other_user}","gists_url":"https://api.github.com/users/juliandunn/gists{/gist_id}","starred_url":"https://api.github.com/users/juliandunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliandunn/subscriptions","organizations_url":"https://api.github.com/users/juliandunn/orgs","repos_url":"https://api.github.com/users/juliandunn/repos","events_url":"https://api.github.com/users/juliandunn/events{/privacy}","received_events_url":"https://api.github.com/users/juliandunn/received_events","type":"User","site_admin":false},"repo":{"id":9757969,"name":"ohai","full_name":"juliandunn/ohai","owner":{"login":"juliandunn","id":841412,"avatar_url":"https://avatars.githubusercontent.com/u/841412?v=3","gravatar_id":"","url":"https://api.github.com/users/juliandunn","html_url":"https://github.com/juliandunn","followers_url":"https://api.github.com/users/juliandunn/followers","following_url":"https://api.github.com/users/juliandunn/following{/other_user}","gists_url":"https://api.github.com/users/juliandunn/gists{/gist_id}","starred_url":"https://api.github.com/users/juliandunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliandunn/subscriptions","organizations_url":"https://api.github.com/users/juliandunn/orgs","repos_url":"https://api.github.com/users/juliandunn/repos","events_url":"https://api.github.com/users/juliandunn/events{/privacy}","received_events_url":"https://api.github.com/users/juliandunn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juliandunn/ohai","description":"Ohai profiles your system and emits JSON","fork":true,"url":"https://api.github.com/repos/juliandunn/ohai","forks_url":"https://api.github.com/repos/juliandunn/ohai/forks","keys_url":"https://api.github.com/repos/juliandunn/ohai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juliandunn/ohai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juliandunn/ohai/teams","hooks_url":"https://api.github.com/repos/juliandunn/ohai/hooks","issue_events_url":"https://api.github.com/repos/juliandunn/ohai/issues/events{/number}","events_url":"https://api.github.com/repos/juliandunn/ohai/events","assignees_url":"https://api.github.com/repos/juliandunn/ohai/assignees{/user}","branches_url":"https://api.github.com/repos/juliandunn/ohai/branches{/branch}","tags_url":"https://api.github.com/repos/juliandunn/ohai/tags","blobs_url":"https://api.github.com/repos/juliandunn/ohai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juliandunn/ohai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juliandunn/ohai/git/refs{/sha}","trees_url":"https://api.github.com/repos/juliandunn/ohai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juliandunn/ohai/statuses/{sha}","languages_url":"https://api.github.com/repos/juliandunn/ohai/languages","stargazers_url":"https://api.github.com/repos/juliandunn/ohai/stargazers","contributors_url":"https://api.github.com/repos/juliandunn/ohai/contributors","subscribers_url":"https://api.github.com/repos/juliandunn/ohai/subscribers","subscription_url":"https://api.github.com/repos/juliandunn/ohai/subscription","commits_url":"https://api.github.com/repos/juliandunn/ohai/commits{/sha}","git_commits_url":"https://api.github.com/repos/juliandunn/ohai/git/commits{/sha}","comments_url":"https://api.github.com/repos/juliandunn/ohai/comments{/number}","issue_comment_url":"https://api.github.com/repos/juliandunn/ohai/issues/comments{/number}","contents_url":"https://api.github.com/repos/juliandunn/ohai/contents/{+path}","compare_url":"https://api.github.com/repos/juliandunn/ohai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juliandunn/ohai/merges","archive_url":"https://api.github.com/repos/juliandunn/ohai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juliandunn/ohai/downloads","issues_url":"https://api.github.com/repos/juliandunn/ohai/issues{/number}","pulls_url":"https://api.github.com/repos/juliandunn/ohai/pulls{/number}","milestones_url":"https://api.github.com/repos/juliandunn/ohai/milestones{/number}","notifications_url":"https://api.github.com/repos/juliandunn/ohai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juliandunn/ohai/labels{/name}","releases_url":"https://api.github.com/repos/juliandunn/ohai/releases{/id}","deployments_url":"https://api.github.com/repos/juliandunn/ohai/deployments","created_at":"2013-04-29T21:03:56Z","updated_at":"2015-05-01T16:16:01Z","pushed_at":"2016-04-01T19:04:11Z","git_url":"git://github.com/juliandunn/ohai.git","ssh_url":"git@github.com:juliandunn/ohai.git","clone_url":"https://github.com/juliandunn/ohai.git","svn_url":"https://github.com/juliandunn/ohai","homepage":"http://wiki.opscode.com/display/ohai","size":4652,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"8f48805e75e5e6be27da414d00fb8c7f8bbc9378","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":108289,"name":"ohai","full_name":"chef/ohai","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/ohai","description":"Ohai profiles your system and emits JSON","fork":false,"url":"https://api.github.com/repos/chef/ohai","forks_url":"https://api.github.com/repos/chef/ohai/forks","keys_url":"https://api.github.com/repos/chef/ohai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/ohai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/ohai/teams","hooks_url":"https://api.github.com/repos/chef/ohai/hooks","issue_events_url":"https://api.github.com/repos/chef/ohai/issues/events{/number}","events_url":"https://api.github.com/repos/chef/ohai/events","assignees_url":"https://api.github.com/repos/chef/ohai/assignees{/user}","branches_url":"https://api.github.com/repos/chef/ohai/branches{/branch}","tags_url":"https://api.github.com/repos/chef/ohai/tags","blobs_url":"https://api.github.com/repos/chef/ohai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/ohai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/ohai/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/ohai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/ohai/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/ohai/languages","stargazers_url":"https://api.github.com/repos/chef/ohai/stargazers","contributors_url":"https://api.github.com/repos/chef/ohai/contributors","subscribers_url":"https://api.github.com/repos/chef/ohai/subscribers","subscription_url":"https://api.github.com/repos/chef/ohai/subscription","commits_url":"https://api.github.com/repos/chef/ohai/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/ohai/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/ohai/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/ohai/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/ohai/contents/{+path}","compare_url":"https://api.github.com/repos/chef/ohai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/ohai/merges","archive_url":"https://api.github.com/repos/chef/ohai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/ohai/downloads","issues_url":"https://api.github.com/repos/chef/ohai/issues{/number}","pulls_url":"https://api.github.com/repos/chef/ohai/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/ohai/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/ohai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/ohai/labels{/name}","releases_url":"https://api.github.com/repos/chef/ohai/releases{/id}","deployments_url":"https://api.github.com/repos/chef/ohai/deployments","created_at":"2009-01-15T20:50:43Z","updated_at":"2016-03-28T19:09:53Z","pushed_at":"2016-04-01T19:04:12Z","git_url":"git://github.com/chef/ohai.git","ssh_url":"git@github.com:chef/ohai.git","clone_url":"https://github.com/chef/ohai.git","svn_url":"https://github.com/chef/ohai","homepage":"https://docs.chef.io/ohai.html","size":5786,"stargazers_count":497,"watchers_count":497,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":364,"mirror_url":null,"open_issues_count":45,"forks":364,"open_issues":45,"watchers":497,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/ohai/pulls/790"},"html":{"href":"https://github.com/chef/ohai/pull/790"},"issue":{"href":"https://api.github.com/repos/chef/ohai/issues/790"},"comments":{"href":"https://api.github.com/repos/chef/ohai/issues/790/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/ohai/pulls/790/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/ohai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/ohai/pulls/790/commits"},"statuses":{"href":"https://api.github.com/repos/chef/ohai/statuses/4fca3e98b93bade5507f6ed6d86f6ea6f255912b"}}}}