{"action":"closed","number":249,"pull_request":{"url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/pulls/249","id":97993951,"html_url":"https://github.com/felixhayashi/TW5-TiddlyMap/pull/249","diff_url":"https://github.com/felixhayashi/TW5-TiddlyMap/pull/249.diff","patch_url":"https://github.com/felixhayashi/TW5-TiddlyMap/pull/249.patch","issue_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/issues/249","number":249,"state":"closed","locked":false,"title":"Handle a status of 0 when using the file protocol","user":{"login":"Kasuko","id":86419,"avatar_url":"https://avatars.githubusercontent.com/u/86419?v=3","gravatar_id":"","url":"https://api.github.com/users/Kasuko","html_url":"https://github.com/Kasuko","followers_url":"https://api.github.com/users/Kasuko/followers","following_url":"https://api.github.com/users/Kasuko/following{/other_user}","gists_url":"https://api.github.com/users/Kasuko/gists{/gist_id}","starred_url":"https://api.github.com/users/Kasuko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kasuko/subscriptions","organizations_url":"https://api.github.com/users/Kasuko/orgs","repos_url":"https://api.github.com/users/Kasuko/repos","events_url":"https://api.github.com/users/Kasuko/events{/privacy}","received_events_url":"https://api.github.com/users/Kasuko/received_events","type":"User","site_admin":false},"body":"When we allow cross-origin requests the XMLHttpRequest's status is 0 when using the file system protocol.\r\n\r\nAllow updating the image if the response has data even if the status is 0.\r\n\r\nThis code isn't the cleanest, but it's the tersest I could come up with. Let me know how your code style dictates this should actually be done?\r\n\r\nNote: This requires explicitly allowing cross-origin requests e.g. launching Google Chrome with the `--allow-file-access-from-files` flag. Testing with TiddlyDesktop, this works without change.\r\n\r\nCloses #248 ","created_at":"2016-12-14T17:04:07Z","updated_at":"2016-12-15T20:40:38Z","closed_at":"2016-12-15T20:40:38Z","merged_at":"2016-12-15T20:40:38Z","merge_commit_sha":"a106689911b4027442cda37e23c757876028989b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/pulls/249/commits","review_comments_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/pulls/249/comments","review_comment_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/issues/249/comments","statuses_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/statuses/d051396d8aed43d9e44c44e4d0fa713e46198f4c","head":{"label":"Kasuko:patch-1","ref":"patch-1","sha":"d051396d8aed43d9e44c44e4d0fa713e46198f4c","user":{"login":"Kasuko","id":86419,"avatar_url":"https://avatars.githubusercontent.com/u/86419?v=3","gravatar_id":"","url":"https://api.github.com/users/Kasuko","html_url":"https://github.com/Kasuko","followers_url":"https://api.github.com/users/Kasuko/followers","following_url":"https://api.github.com/users/Kasuko/following{/other_user}","gists_url":"https://api.github.com/users/Kasuko/gists{/gist_id}","starred_url":"https://api.github.com/users/Kasuko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kasuko/subscriptions","organizations_url":"https://api.github.com/users/Kasuko/orgs","repos_url":"https://api.github.com/users/Kasuko/repos","events_url":"https://api.github.com/users/Kasuko/events{/privacy}","received_events_url":"https://api.github.com/users/Kasuko/received_events","type":"User","site_admin":false},"repo":{"id":76479415,"name":"TW5-TiddlyMap","full_name":"Kasuko/TW5-TiddlyMap","owner":{"login":"Kasuko","id":86419,"avatar_url":"https://avatars.githubusercontent.com/u/86419?v=3","gravatar_id":"","url":"https://api.github.com/users/Kasuko","html_url":"https://github.com/Kasuko","followers_url":"https://api.github.com/users/Kasuko/followers","following_url":"https://api.github.com/users/Kasuko/following{/other_user}","gists_url":"https://api.github.com/users/Kasuko/gists{/gist_id}","starred_url":"https://api.github.com/users/Kasuko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kasuko/subscriptions","organizations_url":"https://api.github.com/users/Kasuko/orgs","repos_url":"https://api.github.com/users/Kasuko/repos","events_url":"https://api.github.com/users/Kasuko/events{/privacy}","received_events_url":"https://api.github.com/users/Kasuko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kasuko/TW5-TiddlyMap","description":"Map drawing and topic visualization for your wiki","fork":true,"url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap","forks_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/forks","keys_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/teams","hooks_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/hooks","issue_events_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/issues/events{/number}","events_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/events","assignees_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/assignees{/user}","branches_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/branches{/branch}","tags_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/tags","blobs_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/statuses/{sha}","languages_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/languages","stargazers_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/stargazers","contributors_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/contributors","subscribers_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/subscribers","subscription_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/subscription","commits_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/contents/{+path}","compare_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/merges","archive_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/downloads","issues_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/issues{/number}","pulls_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/pulls{/number}","milestones_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/milestones{/number}","notifications_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/labels{/name}","releases_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/releases{/id}","deployments_url":"https://api.github.com/repos/Kasuko/TW5-TiddlyMap/deployments","created_at":"2016-12-14T16:57:20Z","updated_at":"2016-12-14T16:57:21Z","pushed_at":"2016-12-14T20:28:10Z","git_url":"git://github.com/Kasuko/TW5-TiddlyMap.git","ssh_url":"git@github.com:Kasuko/TW5-TiddlyMap.git","clone_url":"https://github.com/Kasuko/TW5-TiddlyMap.git","svn_url":"https://github.com/Kasuko/TW5-TiddlyMap","homepage":"http://tiddlymap.org","size":17211,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"felixhayashi:master","ref":"master","sha":"953fa0846c460c734650e58c4ed0a752c7d9649e","user":{"login":"felixhayashi","id":4307137,"avatar_url":"https://avatars.githubusercontent.com/u/4307137?v=3","gravatar_id":"","url":"https://api.github.com/users/felixhayashi","html_url":"https://github.com/felixhayashi","followers_url":"https://api.github.com/users/felixhayashi/followers","following_url":"https://api.github.com/users/felixhayashi/following{/other_user}","gists_url":"https://api.github.com/users/felixhayashi/gists{/gist_id}","starred_url":"https://api.github.com/users/felixhayashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixhayashi/subscriptions","organizations_url":"https://api.github.com/users/felixhayashi/orgs","repos_url":"https://api.github.com/users/felixhayashi/repos","events_url":"https://api.github.com/users/felixhayashi/events{/privacy}","received_events_url":"https://api.github.com/users/felixhayashi/received_events","type":"User","site_admin":false},"repo":{"id":26675859,"name":"TW5-TiddlyMap","full_name":"felixhayashi/TW5-TiddlyMap","owner":{"login":"felixhayashi","id":4307137,"avatar_url":"https://avatars.githubusercontent.com/u/4307137?v=3","gravatar_id":"","url":"https://api.github.com/users/felixhayashi","html_url":"https://github.com/felixhayashi","followers_url":"https://api.github.com/users/felixhayashi/followers","following_url":"https://api.github.com/users/felixhayashi/following{/other_user}","gists_url":"https://api.github.com/users/felixhayashi/gists{/gist_id}","starred_url":"https://api.github.com/users/felixhayashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixhayashi/subscriptions","organizations_url":"https://api.github.com/users/felixhayashi/orgs","repos_url":"https://api.github.com/users/felixhayashi/repos","events_url":"https://api.github.com/users/felixhayashi/events{/privacy}","received_events_url":"https://api.github.com/users/felixhayashi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felixhayashi/TW5-TiddlyMap","description":"Map drawing and topic visualization for your wiki","fork":false,"url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap","forks_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/forks","keys_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/teams","hooks_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/hooks","issue_events_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/issues/events{/number}","events_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/events","assignees_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/assignees{/user}","branches_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/branches{/branch}","tags_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/tags","blobs_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/statuses/{sha}","languages_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/languages","stargazers_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/stargazers","contributors_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/contributors","subscribers_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/subscribers","subscription_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/subscription","commits_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/issues/comments{/number}","contents_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/contents/{+path}","compare_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/merges","archive_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/downloads","issues_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/issues{/number}","pulls_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/pulls{/number}","milestones_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/milestones{/number}","notifications_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/labels{/name}","releases_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/releases{/id}","deployments_url":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/deployments","created_at":"2014-11-15T09:53:38Z","updated_at":"2016-12-14T11:55:51Z","pushed_at":"2016-12-15T20:40:39Z","git_url":"git://github.com/felixhayashi/TW5-TiddlyMap.git","ssh_url":"git@github.com:felixhayashi/TW5-TiddlyMap.git","clone_url":"https://github.com/felixhayashi/TW5-TiddlyMap.git","svn_url":"https://github.com/felixhayashi/TW5-TiddlyMap","homepage":"http://tiddlymap.org","size":17508,"stargazers_count":106,"watchers_count":106,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":41,"forks":23,"open_issues":41,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/pulls/249"},"html":{"href":"https://github.com/felixhayashi/TW5-TiddlyMap/pull/249"},"issue":{"href":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/issues/249"},"comments":{"href":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/felixhayashi/TW5-TiddlyMap/statuses/d051396d8aed43d9e44c44e4d0fa713e46198f4c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"felixhayashi","id":4307137,"avatar_url":"https://avatars.githubusercontent.com/u/4307137?v=3","gravatar_id":"","url":"https://api.github.com/users/felixhayashi","html_url":"https://github.com/felixhayashi","followers_url":"https://api.github.com/users/felixhayashi/followers","following_url":"https://api.github.com/users/felixhayashi/following{/other_user}","gists_url":"https://api.github.com/users/felixhayashi/gists{/gist_id}","starred_url":"https://api.github.com/users/felixhayashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixhayashi/subscriptions","organizations_url":"https://api.github.com/users/felixhayashi/orgs","repos_url":"https://api.github.com/users/felixhayashi/repos","events_url":"https://api.github.com/users/felixhayashi/events{/privacy}","received_events_url":"https://api.github.com/users/felixhayashi/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":3,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"felixhayashi"}}