{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/buck/pulls/comments/61112412","id":61112412,"diff_hunk":"@@ -180,6 +180,21 @@ An <code>android_binary()</code> rule is used to generate an Android APK.\n {call android_common.deps_apk_arg /}\n \n {call buck.arg}\n+  {param name : 'cpu_filters' /}\n+  {param default : '[]' /}\n+  {param desc}\n+  The CPU architecture filter applied to the final apk. Could be a subset of <code>ARM</code>,\n+  <code> ARMV7</code>, <code>X86</code>, <code>X86_64</code>, <code>MIPS</code>.\n+\n+  <p>\n+  <strong>Note</strong>: If you set this parameter, you must setup your NDK, otherwise BUCK\n+  build will fail. You can follow the Android SDK and NDK part of the\n+  <a href=\"{ROOT}setup/install.html\"> install guide</a> to set it up.","path":"docs/rule/android_binary.soy","position":13,"original_position":13,"commit_id":"91d82fdd51063200946b07b962d274c6c5e3c92a","original_commit_id":"91d82fdd51063200946b07b962d274c6c5e3c92a","user":{"login":"sdwilsh","id":656602,"avatar_url":"https://avatars.githubusercontent.com/u/656602?v=3","gravatar_id":"","url":"https://api.github.com/users/sdwilsh","html_url":"https://github.com/sdwilsh","followers_url":"https://api.github.com/users/sdwilsh/followers","following_url":"https://api.github.com/users/sdwilsh/following{/other_user}","gists_url":"https://api.github.com/users/sdwilsh/gists{/gist_id}","starred_url":"https://api.github.com/users/sdwilsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdwilsh/subscriptions","organizations_url":"https://api.github.com/users/sdwilsh/orgs","repos_url":"https://api.github.com/users/sdwilsh/repos","events_url":"https://api.github.com/users/sdwilsh/events{/privacy}","received_events_url":"https://api.github.com/users/sdwilsh/received_events","type":"User","site_admin":false},"body":"likewise here.  Use `{sp}` instead of artificially padding what text the link has.","created_at":"2016-04-26T15:55:44Z","updated_at":"2016-04-26T15:55:44Z","html_url":"https://github.com/facebook/buck/pull/725#discussion_r61112412","pull_request_url":"https://api.github.com/repos/facebook/buck/pulls/725","_links":{"self":{"href":"https://api.github.com/repos/facebook/buck/pulls/comments/61112412"},"html":{"href":"https://github.com/facebook/buck/pull/725#discussion_r61112412"},"pull_request":{"href":"https://api.github.com/repos/facebook/buck/pulls/725"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/buck/pulls/725","id":67879975,"html_url":"https://github.com/facebook/buck/pull/725","diff_url":"https://github.com/facebook/buck/pull/725.diff","patch_url":"https://github.com/facebook/buck/pull/725.patch","issue_url":"https://api.github.com/repos/facebook/buck/issues/725","number":725,"state":"open","locked":false,"title":"add `cpu_filters` parameter doc","user":{"login":"Piasy","id":3098704,"avatar_url":"https://avatars.githubusercontent.com/u/3098704?v=3","gravatar_id":"","url":"https://api.github.com/users/Piasy","html_url":"https://github.com/Piasy","followers_url":"https://api.github.com/users/Piasy/followers","following_url":"https://api.github.com/users/Piasy/following{/other_user}","gists_url":"https://api.github.com/users/Piasy/gists{/gist_id}","starred_url":"https://api.github.com/users/Piasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piasy/subscriptions","organizations_url":"https://api.github.com/users/Piasy/orgs","repos_url":"https://api.github.com/users/Piasy/repos","events_url":"https://api.github.com/users/Piasy/events{/privacy}","received_events_url":"https://api.github.com/users/Piasy/received_events","type":"User","site_admin":false},"body":"Summary:\r\nThe document for `cpu_filters` parameter of `android_binary` rule is missing, and more importantly, the `ANDROID_NDK` environment variable must be set, otherwise BUCK build will fail. Our team is stuck by this problem for weeks.\r\n\r\nTest Plan:\r\nRan `./docs/soyweb-local.sh` and viewed:\r\n\r\n```\r\nhttp://localhost:9811/rule/android_binary.html\r\n```","created_at":"2016-04-26T12:53:23Z","updated_at":"2016-04-26T15:55:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4554be6c232562bcdf851748ef42dca38a8661af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/buck/pulls/725/commits","review_comments_url":"https://api.github.com/repos/facebook/buck/pulls/725/comments","review_comment_url":"https://api.github.com/repos/facebook/buck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/buck/issues/725/comments","statuses_url":"https://api.github.com/repos/facebook/buck/statuses/91d82fdd51063200946b07b962d274c6c5e3c92a","head":{"label":"Piasy:master","ref":"master","sha":"91d82fdd51063200946b07b962d274c6c5e3c92a","user":{"login":"Piasy","id":3098704,"avatar_url":"https://avatars.githubusercontent.com/u/3098704?v=3","gravatar_id":"","url":"https://api.github.com/users/Piasy","html_url":"https://github.com/Piasy","followers_url":"https://api.github.com/users/Piasy/followers","following_url":"https://api.github.com/users/Piasy/following{/other_user}","gists_url":"https://api.github.com/users/Piasy/gists{/gist_id}","starred_url":"https://api.github.com/users/Piasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piasy/subscriptions","organizations_url":"https://api.github.com/users/Piasy/orgs","repos_url":"https://api.github.com/users/Piasy/repos","events_url":"https://api.github.com/users/Piasy/events{/privacy}","received_events_url":"https://api.github.com/users/Piasy/received_events","type":"User","site_admin":false},"repo":{"id":52073291,"name":"buck","full_name":"Piasy/buck","owner":{"login":"Piasy","id":3098704,"avatar_url":"https://avatars.githubusercontent.com/u/3098704?v=3","gravatar_id":"","url":"https://api.github.com/users/Piasy","html_url":"https://github.com/Piasy","followers_url":"https://api.github.com/users/Piasy/followers","following_url":"https://api.github.com/users/Piasy/following{/other_user}","gists_url":"https://api.github.com/users/Piasy/gists{/gist_id}","starred_url":"https://api.github.com/users/Piasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piasy/subscriptions","organizations_url":"https://api.github.com/users/Piasy/orgs","repos_url":"https://api.github.com/users/Piasy/repos","events_url":"https://api.github.com/users/Piasy/events{/privacy}","received_events_url":"https://api.github.com/users/Piasy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Piasy/buck","description":"A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.","fork":true,"url":"https://api.github.com/repos/Piasy/buck","forks_url":"https://api.github.com/repos/Piasy/buck/forks","keys_url":"https://api.github.com/repos/Piasy/buck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Piasy/buck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Piasy/buck/teams","hooks_url":"https://api.github.com/repos/Piasy/buck/hooks","issue_events_url":"https://api.github.com/repos/Piasy/buck/issues/events{/number}","events_url":"https://api.github.com/repos/Piasy/buck/events","assignees_url":"https://api.github.com/repos/Piasy/buck/assignees{/user}","branches_url":"https://api.github.com/repos/Piasy/buck/branches{/branch}","tags_url":"https://api.github.com/repos/Piasy/buck/tags","blobs_url":"https://api.github.com/repos/Piasy/buck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Piasy/buck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Piasy/buck/git/refs{/sha}","trees_url":"https://api.github.com/repos/Piasy/buck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Piasy/buck/statuses/{sha}","languages_url":"https://api.github.com/repos/Piasy/buck/languages","stargazers_url":"https://api.github.com/repos/Piasy/buck/stargazers","contributors_url":"https://api.github.com/repos/Piasy/buck/contributors","subscribers_url":"https://api.github.com/repos/Piasy/buck/subscribers","subscription_url":"https://api.github.com/repos/Piasy/buck/subscription","commits_url":"https://api.github.com/repos/Piasy/buck/commits{/sha}","git_commits_url":"https://api.github.com/repos/Piasy/buck/git/commits{/sha}","comments_url":"https://api.github.com/repos/Piasy/buck/comments{/number}","issue_comment_url":"https://api.github.com/repos/Piasy/buck/issues/comments{/number}","contents_url":"https://api.github.com/repos/Piasy/buck/contents/{+path}","compare_url":"https://api.github.com/repos/Piasy/buck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Piasy/buck/merges","archive_url":"https://api.github.com/repos/Piasy/buck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Piasy/buck/downloads","issues_url":"https://api.github.com/repos/Piasy/buck/issues{/number}","pulls_url":"https://api.github.com/repos/Piasy/buck/pulls{/number}","milestones_url":"https://api.github.com/repos/Piasy/buck/milestones{/number}","notifications_url":"https://api.github.com/repos/Piasy/buck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Piasy/buck/labels{/name}","releases_url":"https://api.github.com/repos/Piasy/buck/releases{/id}","deployments_url":"https://api.github.com/repos/Piasy/buck/deployments","created_at":"2016-02-19T08:32:12Z","updated_at":"2016-02-19T08:32:22Z","pushed_at":"2016-04-26T15:50:30Z","git_url":"git://github.com/Piasy/buck.git","ssh_url":"git@github.com:Piasy/buck.git","clone_url":"https://github.com/Piasy/buck.git","svn_url":"https://github.com/Piasy/buck","homepage":"https://buckbuild.com","size":371486,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"036995ab475f5d5c4a26c50a10babcfea84f0bb3","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":9504214,"name":"buck","full_name":"facebook/buck","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/buck","description":"A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.","fork":false,"url":"https://api.github.com/repos/facebook/buck","forks_url":"https://api.github.com/repos/facebook/buck/forks","keys_url":"https://api.github.com/repos/facebook/buck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/buck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/buck/teams","hooks_url":"https://api.github.com/repos/facebook/buck/hooks","issue_events_url":"https://api.github.com/repos/facebook/buck/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/buck/events","assignees_url":"https://api.github.com/repos/facebook/buck/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/buck/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/buck/tags","blobs_url":"https://api.github.com/repos/facebook/buck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/buck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/buck/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/buck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/buck/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/buck/languages","stargazers_url":"https://api.github.com/repos/facebook/buck/stargazers","contributors_url":"https://api.github.com/repos/facebook/buck/contributors","subscribers_url":"https://api.github.com/repos/facebook/buck/subscribers","subscription_url":"https://api.github.com/repos/facebook/buck/subscription","commits_url":"https://api.github.com/repos/facebook/buck/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/buck/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/buck/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/buck/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/buck/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/buck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/buck/merges","archive_url":"https://api.github.com/repos/facebook/buck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/buck/downloads","issues_url":"https://api.github.com/repos/facebook/buck/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/buck/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/buck/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/buck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/buck/labels{/name}","releases_url":"https://api.github.com/repos/facebook/buck/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/buck/deployments","created_at":"2013-04-17T18:12:18Z","updated_at":"2016-04-26T12:45:43Z","pushed_at":"2016-04-26T15:51:42Z","git_url":"git://github.com/facebook/buck.git","ssh_url":"git@github.com:facebook/buck.git","clone_url":"https://github.com/facebook/buck.git","svn_url":"https://github.com/facebook/buck","homepage":"https://buckbuild.com","size":417338,"stargazers_count":2573,"watchers_count":2573,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":436,"mirror_url":null,"open_issues_count":126,"forks":436,"open_issues":126,"watchers":2573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/buck/pulls/725"},"html":{"href":"https://github.com/facebook/buck/pull/725"},"issue":{"href":"https://api.github.com/repos/facebook/buck/issues/725"},"comments":{"href":"https://api.github.com/repos/facebook/buck/issues/725/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/buck/pulls/725/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/buck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/buck/pulls/725/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/buck/statuses/91d82fdd51063200946b07b962d274c6c5e3c92a"}}}}