{"action":"created","comment":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments/72648495","id":72648495,"diff_hunk":"@@ -1272,6 +1265,53 @@ The key exchange messages are used to exchange security capabilities\n between the client and server and to establish the traffic keys used to protect\n the handshake and data.\n \n+\n+### Cryptographic Negotiation\n+\n+TLS cryptographic negotiation proceeds by the client offering the\n+following four sets of options in its ClientHello.\n+\n+- A list of cipher suites which indicates the AEAD cipher/HKDF hash\n+  pairs which the client supports\n+- A \"supported_group\" ({{negotiated-groups}}) extension which indicates the (EC)DHE groups\n+  which the client supports and a \"key_share\" ({{key-share}}) extension which contains\n+  (EC)DHE shares for some or all of these groups\n+- A \"signature_algorithms\" ({{signature-algorithms}}) extension which indicates the signature\n+  algorithms which the client can accept.\n+- A \"pre_shared_key\" ({{pre-shared-key-extension}}) extension which contains the identities\n+  of symmetric keys known to the client and the key exchange\n+  modes which each PSK supports.\n+\n+If the server does not select a PSK, then the first three of these\n+options are entirely orthogonal: the server independently selects a\n+cipher suite, an (EC)DHE group and key share for key establishment,\n+and a signature algorithm/certificate pair to authenticate itself.","path":"draft-ietf-tls-tls13.md","position":134,"original_position":134,"commit_id":"4cc784a3a7cdb3628daada411860c4a9c7a6d046","original_commit_id":"4cc784a3a7cdb3628daada411860c4a9c7a6d046","user":{"login":"kaduk","id":1894506,"avatar_url":"https://avatars.githubusercontent.com/u/1894506?v=3","gravatar_id":"","url":"https://api.github.com/users/kaduk","html_url":"https://github.com/kaduk","followers_url":"https://api.github.com/users/kaduk/followers","following_url":"https://api.github.com/users/kaduk/following{/other_user}","gists_url":"https://api.github.com/users/kaduk/gists{/gist_id}","starred_url":"https://api.github.com/users/kaduk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaduk/subscriptions","organizations_url":"https://api.github.com/users/kaduk/orgs","repos_url":"https://api.github.com/users/kaduk/repos","events_url":"https://api.github.com/users/kaduk/events{/privacy}","received_events_url":"https://api.github.com/users/kaduk/received_events","type":"User","site_admin":false},"body":"\"to use to authenticate itself to the client\"?","created_at":"2016-07-28T15:48:55Z","updated_at":"2016-07-28T15:48:55Z","html_url":"https://github.com/tlswg/tls13-spec/pull/559#discussion_r72648495","pull_request_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/559","_links":{"self":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments/72648495"},"html":{"href":"https://github.com/tlswg/tls13-spec/pull/559#discussion_r72648495"},"pull_request":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/559"}}},"pull_request":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/559","id":78672474,"html_url":"https://github.com/tlswg/tls13-spec/pull/559","diff_url":"https://github.com/tlswg/tls13-spec/pull/559.diff","patch_url":"https://github.com/tlswg/tls13-spec/pull/559.patch","issue_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/559","number":559,"state":"open","locked":false,"title":"WIP: Refactor negotiation as discussed in Berlin","user":{"login":"ekr","id":1111457,"avatar_url":"https://avatars.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"body":"This is just a WIP and needs review.\r\n\r\n@martinthomson @grittygrease @davidben PTAL.\r\n\r\n@davidben: I know you don't like the indication from the server but would like your opinion on other aspects.","created_at":"2016-07-25T12:27:07Z","updated_at":"2016-07-28T15:48:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8405603cedfafb2eccfbce725c91ea42152aa124","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/559/commits","review_comments_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/559/comments","review_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/559/comments","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/4cc784a3a7cdb3628daada411860c4a9c7a6d046","head":{"label":"ekr:WIP_refactor_negotiation","ref":"WIP_refactor_negotiation","sha":"4cc784a3a7cdb3628daada411860c4a9c7a6d046","user":{"login":"ekr","id":1111457,"avatar_url":"https://avatars.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"repo":{"id":19185500,"name":"tls13-spec","full_name":"ekr/tls13-spec","owner":{"login":"ekr","id":1111457,"avatar_url":"https://avatars.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekr/tls13-spec","description":"TLS 1.3 Specification","fork":true,"url":"https://api.github.com/repos/ekr/tls13-spec","forks_url":"https://api.github.com/repos/ekr/tls13-spec/forks","keys_url":"https://api.github.com/repos/ekr/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekr/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekr/tls13-spec/teams","hooks_url":"https://api.github.com/repos/ekr/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/ekr/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/ekr/tls13-spec/events","assignees_url":"https://api.github.com/repos/ekr/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/ekr/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/ekr/tls13-spec/tags","blobs_url":"https://api.github.com/repos/ekr/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekr/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekr/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekr/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekr/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/ekr/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/ekr/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/ekr/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/ekr/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/ekr/tls13-spec/subscription","commits_url":"https://api.github.com/repos/ekr/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekr/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekr/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekr/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekr/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/ekr/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekr/tls13-spec/merges","archive_url":"https://api.github.com/repos/ekr/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekr/tls13-spec/downloads","issues_url":"https://api.github.com/repos/ekr/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/ekr/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/ekr/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/ekr/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekr/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/ekr/tls13-spec/releases{/id}","deployments_url":"https://api.github.com/repos/ekr/tls13-spec/deployments","created_at":"2014-04-26T18:47:51Z","updated_at":"2016-07-20T08:41:28Z","pushed_at":"2016-07-26T12:59:45Z","git_url":"git://github.com/ekr/tls13-spec.git","ssh_url":"git@github.com:ekr/tls13-spec.git","clone_url":"https://github.com/ekr/tls13-spec.git","svn_url":"https://github.com/ekr/tls13-spec","homepage":null,"size":2578,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"tlswg:master","ref":"master","sha":"31fa4aaa7bafe449949c1a5ceb5da38a1117354c","user":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"repo":{"id":18887842,"name":"tls13-spec","full_name":"tlswg/tls13-spec","owner":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tlswg/tls13-spec","description":"TLS 1.3 Specification","fork":false,"url":"https://api.github.com/repos/tlswg/tls13-spec","forks_url":"https://api.github.com/repos/tlswg/tls13-spec/forks","keys_url":"https://api.github.com/repos/tlswg/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlswg/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlswg/tls13-spec/teams","hooks_url":"https://api.github.com/repos/tlswg/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/tlswg/tls13-spec/events","assignees_url":"https://api.github.com/repos/tlswg/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/tlswg/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/tlswg/tls13-spec/tags","blobs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlswg/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlswg/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/tlswg/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/tlswg/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/tlswg/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/tlswg/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/tlswg/tls13-spec/subscription","commits_url":"https://api.github.com/repos/tlswg/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlswg/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlswg/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/tlswg/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlswg/tls13-spec/merges","archive_url":"https://api.github.com/repos/tlswg/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlswg/tls13-spec/downloads","issues_url":"https://api.github.com/repos/tlswg/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/tlswg/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/tlswg/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlswg/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/tlswg/tls13-spec/releases{/id}","deployments_url":"https://api.github.com/repos/tlswg/tls13-spec/deployments","created_at":"2014-04-17T17:52:32Z","updated_at":"2016-07-24T15:37:57Z","pushed_at":"2016-07-28T15:03:52Z","git_url":"git://github.com/tlswg/tls13-spec.git","ssh_url":"git@github.com:tlswg/tls13-spec.git","clone_url":"https://github.com/tlswg/tls13-spec.git","svn_url":"https://github.com/tlswg/tls13-spec","homepage":null,"size":3549,"stargazers_count":162,"watchers_count":162,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"open_issues_count":42,"forks":77,"open_issues":42,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/559"},"html":{"href":"https://github.com/tlswg/tls13-spec/pull/559"},"issue":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/559"},"comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/559/comments"},"review_comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/559/comments"},"review_comment":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/559/commits"},"statuses":{"href":"https://api.github.com/repos/tlswg/tls13-spec/statuses/4cc784a3a7cdb3628daada411860c4a9c7a6d046"}}}}
{"actor":{"display_login":"kaduk"}}