{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/30353","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/30353/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/30353/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/30353/events","html_url":"https://github.com/rust-lang/rust/pull/30353","id":121866446,"number":30353,"title":"configure: Enable -C rpath by default","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rust-lang/rust/labels/relnotes","name":"relnotes","color":"fad8c7"}],"state":"closed","locked":false,"assignee":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"milestone":null,"comments":21,"created_at":"2015-12-12T17:05:15Z","updated_at":"2016-01-06T14:35:44Z","closed_at":"2015-12-23T06:20:07Z","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/30353","html_url":"https://github.com/rust-lang/rust/pull/30353","diff_url":"https://github.com/rust-lang/rust/pull/30353.diff","patch_url":"https://github.com/rust-lang/rust/pull/30353.patch"},"body":"This commit changes our distribution and in-tree sources to pass the `-C rpath`\r\nflag by default during compiles. This means that from-source builds, including\r\nour release channels, will have this option enabled as well. Motivated\r\nby #29941, this change means that the compiler should be usable as-is on all\r\nplatforms just after extraction or installation. This experience is already true\r\non Windows but on Unixes you still need to set up LD_LIBRARY_PATH or the\r\nequivalent, which can often be unfortunate.\r\n\r\nThis option was originally turned off by default for Linux distributions who\r\ntend to take care of these sorts of details themselves, so it is expected that\r\nall those builds of Rust will want to pass `--disable-rpath` to the configure\r\nscript to preserve that behavior.\r\n\r\nCloses #29941"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/169338551","html_url":"https://github.com/rust-lang/rust/pull/30353#issuecomment-169338551","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/30353","id":169338551,"user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars.githubusercontent.com/u/173127?v=3","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"created_at":"2016-01-06T14:35:44Z","updated_at":"2016-01-06T14:35:44Z","body":"(in fact, the awesome thing is that it looks like this PR on its own *breaks* `--enable-rpath`, since it causes the `CFG_ENABLE_RPATH=1` to no longer be emitted into the `config.mk`.)\r\n\r\nMaybe we should change the generation of `config.mk` to include *all* opt's, with their default values if not overriden, rather than just the options supplied by the user."}}